- Devel - libvirt List Archives

[libvirt] [PATCH] conf: Fix typo enconding -> encoding
by Andrea Bolognani 12 Apr '19

12 Apr '19

Introduced-by: e0fae78ad550 Spotted-by: Lintian Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed-as: trivial src/conf/domain_audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index ce176f7940..de7386d4c6 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -420,7 +420,7 @@ virDomainAuditHostdev(virDomainObjPtr vm, virDomainHostdevDefPtr hostdev, break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: if (VIR_STRDUP_QUIET(address, mdevsrc->uuidstr) < 0) { - VIR_WARN("OOM while enconding audit message"); + VIR_WARN("OOM while encoding audit message"); goto cleanup; } break; -- 2.20.1

1 0

[libvirt] [PATCH 0/7] vbox: drop support for many old versions
by Daniel P. Berrangé 12 Apr '19

12 Apr '19

Per this link: https://www.virtualbox.org/wiki/Download_Old_Builds VirtualBox 6.0 (active maintenance) VirtualBox 5.2 (active maintenance) VirtualBox 5.1 (no longer supported, support ended 2018/04) VirtualBox 5.0 (no longer supported, support ended 2017/05) VirtualBox 4.3 (no longer supported, support ended 2015/12) VirtualBox 4.2 (no longer supported, support ended 2015/12) VirtualBox 4.1 (no longer supported, support ended 2015/12) VirtualBox 4.0 (no longer supported, support ended 2015/12) We can certainly drop all the 4.x versions. The host OS those are officially supported on are very outdated: eg https://www.virtualbox.org/wiki/Download_Old_Builds_4_3 Linux Hosts: Ubuntu 13.04 ("Raring") / 13.10 ("Saucy") / 14.04 ("Trusty") / 14.10 ("Utopic") i386 | AMD64 Ubuntu 12.10 ("Quantal") i386 | AMD64 Ubuntu 12.04 ("Precise") i386 | AMD64 Ubuntu 10.04 LTS ("Lucid") i386 | AMD64 Debian 7 ("Wheezy") i386 | AMD64 Debian 6 ("Squeeze") i386 | AMD64 openSUSE 12.3 / 13.1 i386 | AMD64 openSUSE 11.4 / 12.1 / 12.2 i386 | AMD64 SUSE Linux Enterprise Server 11 (SLES11) i386 | AMD64 SUSE Linux Enterprise Server 10 (SLES10) i386 | AMD64 Fedora 18 ("Spherical Cow") / Fedora 19 ("Schrödingers Cat") i386 | AMD64 Fedora 17 ("Beefy Miracle") i386 | AMD64 Mandriva 2011.0 i386 | AMD64 Oracle Linux 6 ("OL6") / Red Hat Enterprise Linux 6 ("RHEL6") / CentOS 6 i386 | AMD64 Oracle Linux 5 ("OL5") / Red Hat Enterprise Linux 5 ("RHEL5") / CentOS 5 i386 | AMD64 All distributions i386 | AMD64 Although the catch all "All distributions" suggest it might work with newer distros, they are clearly a second tier from a support POV. All these explicitly targetted distros are outside libvirt's support policy. There is a question as to whether to delete 5.0 and 5.1 support from libvirt. There are no remainining #ifdef VBOX_API_VERSION conditionals in the vbox_tmpl.h file related to code differences between 5.0, 5.1 and 5.2, so keeping them is not a maint burden in code. The main burden is distributing the large vbox_CAPI_v5_0.h and vbox_CAPI_v5_1.h files which are ~1 MB in size (uncompressed) or ~85 kb (xz compressed). IOW versions 5.0 and 5.1 increase the release tarballs by a small amount, but nothing that is too unreasonable vs the overall size of 14 MB for libvirt source. Thus I have kept 5.0 and 5.1 support. VirtualBox 6.0 came out in Dec 2018 and given past practice it would not suprise me if that has API changes impacting libvirt. So some interested party might want to look at supporting that in libvirt. Daniel P. Berrangé (7): vbox: drop support for VirtualBox 4.x releases vbox: drop C API definition for release 4.0 vbox: drop C API definition for release 4.1 vbox: drop C API definition for release 4.2 vbox: drop C API definition for release 4.2.20 vbox: drop C API definition for release 4.3 vbox: drop C API definition for release 4.3.4 src/vbox/Makefile.inc.am | 6 - src/vbox/vbox_CAPI_v4_0.h | 7451 ----------------------- src/vbox/vbox_CAPI_v4_1.h | 7882 ------------------------ src/vbox/vbox_CAPI_v4_2.h | 8855 --------------------------- src/vbox/vbox_CAPI_v4_2_20.h | 9001 ---------------------------- src/vbox/vbox_CAPI_v4_3.h | 10210 ------------------------------- src/vbox/vbox_CAPI_v4_3_4.h | 10321 -------------------------------- src/vbox/vbox_V4_0.c | 37 - src/vbox/vbox_V4_1.c | 37 - src/vbox/vbox_V4_2.c | 13 - src/vbox/vbox_V4_2_20.c | 13 - src/vbox/vbox_V4_3.c | 13 - src/vbox/vbox_V4_3_4.c | 13 - src/vbox/vbox_common.h | 14 +- src/vbox/vbox_storage.c | 14 +- src/vbox/vbox_tmpl.c | 218 +- src/vbox/vbox_uniformed_api.h | 10 +- 17 files changed, 7 insertions(+), 54101 deletions(-) delete mode 100644 src/vbox/vbox_CAPI_v4_0.h delete mode 100644 src/vbox/vbox_CAPI_v4_1.h delete mode 100644 src/vbox/vbox_CAPI_v4_2.h delete mode 100644 src/vbox/vbox_CAPI_v4_2_20.h delete mode 100644 src/vbox/vbox_CAPI_v4_3.h delete mode 100644 src/vbox/vbox_CAPI_v4_3_4.h delete mode 100644 src/vbox/vbox_V4_0.c delete mode 100644 src/vbox/vbox_V4_1.c delete mode 100644 src/vbox/vbox_V4_2.c delete mode 100644 src/vbox/vbox_V4_2_20.c delete mode 100644 src/vbox/vbox_V4_3.c delete mode 100644 src/vbox/vbox_V4_3_4.c -- 2.20.1

1 8

[libvirt] [PATCH 0/2] Add capability-based mlock tests
by Ján Tomko 12 Apr '19

12 Apr '19

Ján Tomko (2): qemuxml2argvtest: add mlock tests for QEMU 3.0.0 qemuxml2argvtest: add mlock tests for latest QEMU .../mlock-off.x86_64-3.0.0.args | 32 +++++++++++++++++++ .../mlock-off.x86_64-latest.args | 32 +++++++++++++++++++ .../mlock-on.x86_64-3.0.0.args | 32 +++++++++++++++++++ .../mlock-on.x86_64-latest.args | 32 +++++++++++++++++++ tests/qemuxml2argvtest.c | 5 +++ 5 files changed, 133 insertions(+) create mode 100644 tests/qemuxml2argvdata/mlock-off.x86_64-3.0.0.args create mode 100644 tests/qemuxml2argvdata/mlock-off.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/mlock-on.x86_64-3.0.0.args create mode 100644 tests/qemuxml2argvdata/mlock-on.x86_64-latest.args -- 2.19.2

2 5

[libvirt] [PATCH 0/3] qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'
by Michal Privoznik 12 Apr '19

12 Apr '19

Patches available also at: https://github.com/zippy2/libvirt/tree/qemu_mlock Inspired by the following QEMU patch: http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg01980.html Michal Prívozník (3): qemu: Always assume QEMU_CAPS_REALTIME_MLOCK qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock' src/qemu/qemu_capabilities.c | 3 ++- src/qemu/qemu_capabilities.h | 3 ++- src/qemu/qemu_command.c | 10 ++++------ tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 +- tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 2 +- tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.args | 1 + tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 1 + tests/qemuxml2argvdata/aarch64-cpu-passthrough.args | 1 + tests/qemuxml2argvdata/aarch64-gic-host.args | 1 + tests/qemuxml2argvdata/aarch64-gic-none-tcg.args | 1 + tests/qemuxml2argvdata/aarch64-gic-v2.args | 1 + tests/qemuxml2argvdata/aarch64-gic-v3.args | 1 + tests/qemuxml2argvdata/aarch64-kvm-32-on-64.args | 1 + tests/qemuxml2argvdata/aarch64-noacpi-nouefi.args | 1 + tests/qemuxml2argvdata/aarch64-noacpi-uefi.args | 1 + tests/qemuxml2argvdata/aarch64-pci-serial.args | 1 + tests/qemuxml2argvdata/aarch64-traditional-pci.args | 1 + .../aarch64-usb-controller-nec-xhci.args | 1 + .../aarch64-usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/aarch64-video-default.args | 1 + .../qemuxml2argvdata/aarch64-video-virtio-gpu-pci.args | 1 + .../aarch64-virt-2.6-virtio-pci-default.args | 1 + tests/qemuxml2argvdata/aarch64-virt-default-nic.args | 1 + tests/qemuxml2argvdata/aarch64-virt-virtio.args | 1 + tests/qemuxml2argvdata/aarch64-virtio-pci-default.args | 1 + .../aarch64-virtio-pci-manual-addresses.args | 1 + tests/qemuxml2argvdata/acpi-table.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-basic.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-nodevs.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-virtio.args | 1 + tests/qemuxml2argvdata/arm-virt-virtio.args | 1 + tests/qemuxml2argvdata/autoindex.args | 1 + tests/qemuxml2argvdata/balloon-ccw-deflate.args | 1 + tests/qemuxml2argvdata/balloon-device-auto.args | 1 + tests/qemuxml2argvdata/balloon-device-deflate-off.args | 1 + tests/qemuxml2argvdata/balloon-device-deflate.args | 1 + tests/qemuxml2argvdata/balloon-device-period.args | 1 + tests/qemuxml2argvdata/balloon-device.args | 1 + tests/qemuxml2argvdata/balloon-mmio-deflate.args | 1 + tests/qemuxml2argvdata/bios-nvram-secure.args | 1 + tests/qemuxml2argvdata/bios-nvram.args | 1 + tests/qemuxml2argvdata/bios.args | 1 + tests/qemuxml2argvdata/blkdeviotune-group-num.args | 1 + tests/qemuxml2argvdata/blkdeviotune-max-length.args | 1 + tests/qemuxml2argvdata/blkdeviotune-max.args | 1 + tests/qemuxml2argvdata/blkiotune-device.args | 1 + tests/qemuxml2argvdata/blkiotune.args | 1 + tests/qemuxml2argvdata/boot-cdrom.args | 1 + tests/qemuxml2argvdata/boot-complex.args | 1 + tests/qemuxml2argvdata/boot-floppy-q35.args | 1 + tests/qemuxml2argvdata/boot-floppy.args | 1 + tests/qemuxml2argvdata/boot-menu-disable-drive.args | 1 + tests/qemuxml2argvdata/boot-menu-disable.args | 1 + .../boot-menu-enable-with-timeout.args | 1 + tests/qemuxml2argvdata/boot-menu-enable.args | 1 + tests/qemuxml2argvdata/boot-multi.args | 1 + tests/qemuxml2argvdata/boot-network.args | 1 + tests/qemuxml2argvdata/boot-order.args | 1 + tests/qemuxml2argvdata/boot-strict.args | 1 + tests/qemuxml2argvdata/channel-guestfwd.args | 1 + tests/qemuxml2argvdata/channel-spicevmc.args | 1 + .../channel-unix-guestfwd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/channel-virtio-auto.args | 1 + tests/qemuxml2argvdata/channel-virtio-autoadd.args | 1 + tests/qemuxml2argvdata/channel-virtio-autoassign.args | 1 + tests/qemuxml2argvdata/channel-virtio-default.args | 1 + tests/qemuxml2argvdata/channel-virtio-state.args | 1 + tests/qemuxml2argvdata/channel-virtio-unix.args | 1 + tests/qemuxml2argvdata/channel-virtio.args | 1 + tests/qemuxml2argvdata/chardev-reconnect.args | 1 + tests/qemuxml2argvdata/clock-catchup.args | 1 + tests/qemuxml2argvdata/clock-france.args | 1 + tests/qemuxml2argvdata/clock-hpet-off.args | 1 + .../clock-localtime-basis-localtime.args | 1 + tests/qemuxml2argvdata/clock-localtime.args | 1 + tests/qemuxml2argvdata/clock-timer-hyperv-rtc.args | 1 + tests/qemuxml2argvdata/clock-utc.args | 1 + tests/qemuxml2argvdata/clock-variable.args | 1 + tests/qemuxml2argvdata/console-compat-auto.args | 1 + tests/qemuxml2argvdata/console-compat-chardev.args | 1 + tests/qemuxml2argvdata/console-compat.args | 1 + tests/qemuxml2argvdata/console-sclp.args | 1 + tests/qemuxml2argvdata/console-virtio-ccw.args | 1 + tests/qemuxml2argvdata/console-virtio-many.args | 1 + tests/qemuxml2argvdata/console-virtio-s390.args | 1 + .../console-virtio-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/console-virtio.args | 1 + tests/qemuxml2argvdata/controller-order.args | 1 + .../controller-virtio-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 1 + tests/qemuxml2argvdata/cpu-Haswell.args | 1 + tests/qemuxml2argvdata/cpu-Haswell2.args | 1 + tests/qemuxml2argvdata/cpu-Haswell3.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable2.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable3.args | 1 + tests/qemuxml2argvdata/cpu-cache-emulate-l3.args | 1 + tests/qemuxml2argvdata/cpu-cache-passthrough.args | 1 + tests/qemuxml2argvdata/cpu-cache-passthrough2.args | 1 + tests/qemuxml2argvdata/cpu-check-default-none.args | 1 + tests/qemuxml2argvdata/cpu-check-default-none2.args | 1 + tests/qemuxml2argvdata/cpu-check-default-partial.args | 1 + tests/qemuxml2argvdata/cpu-check-default-partial2.args | 1 + tests/qemuxml2argvdata/cpu-check-none.args | 1 + tests/qemuxml2argvdata/cpu-eoi-disabled.args | 1 + tests/qemuxml2argvdata/cpu-eoi-enabled.args | 1 + tests/qemuxml2argvdata/cpu-exact1.args | 1 + tests/qemuxml2argvdata/cpu-exact2-nofallback.args | 1 + tests/qemuxml2argvdata/cpu-exact2.args | 1 + tests/qemuxml2argvdata/cpu-fallback.args | 1 + tests/qemuxml2argvdata/cpu-host-kvmclock.args | 1 + tests/qemuxml2argvdata/cpu-host-model-cmt.args | 1 + tests/qemuxml2argvdata/cpu-host-model-fallback.args | 1 + tests/qemuxml2argvdata/cpu-host-model-vendor.args | 1 + tests/qemuxml2argvdata/cpu-host-model.args | 1 + .../cpu-host-passthrough-features.args | 1 + tests/qemuxml2argvdata/cpu-host-passthrough.args | 1 + tests/qemuxml2argvdata/cpu-hotplug-startup.args | 1 + tests/qemuxml2argvdata/cpu-kvmclock.args | 1 + tests/qemuxml2argvdata/cpu-minimum1.args | 1 + tests/qemuxml2argvdata/cpu-minimum2.args | 1 + tests/qemuxml2argvdata/cpu-numa-disjoint.args | 1 + tests/qemuxml2argvdata/cpu-numa-memshared.args | 1 + tests/qemuxml2argvdata/cpu-numa-no-memory-element.args | 1 + tests/qemuxml2argvdata/cpu-numa1.args | 1 + tests/qemuxml2argvdata/cpu-numa2.args | 1 + tests/qemuxml2argvdata/cpu-s390-features.args | 1 + tests/qemuxml2argvdata/cpu-s390-zEC12.args | 1 + tests/qemuxml2argvdata/cpu-strict1.args | 1 + tests/qemuxml2argvdata/cpu-topology1.args | 1 + tests/qemuxml2argvdata/cpu-topology2.args | 1 + tests/qemuxml2argvdata/cpu-topology3.args | 1 + tests/qemuxml2argvdata/cpu-tsc-frequency.args | 1 + tests/qemuxml2argvdata/cputune-numatune.args | 1 + tests/qemuxml2argvdata/cputune-zero-shares.args | 1 + tests/qemuxml2argvdata/cputune.args | 1 + tests/qemuxml2argvdata/debug-threads.args | 1 + tests/qemuxml2argvdata/default-kvm-host-arch.args | 1 + tests/qemuxml2argvdata/default-qemu-host-arch.args | 1 + tests/qemuxml2argvdata/disk-aio.args | 1 + tests/qemuxml2argvdata/disk-aio.x86_64-latest.args | 2 +- .../disk-backing-chains-noindex.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-blockio.args | 1 + tests/qemuxml2argvdata/disk-boot-cdrom.args | 1 + tests/qemuxml2argvdata/disk-boot-disk.args | 1 + tests/qemuxml2argvdata/disk-cache.x86_64-latest.args | 2 +- .../disk-cdrom-bus-other.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom-network.args | 1 + .../disk-cdrom-network.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom-tray.args | 1 + .../disk-cdrom-tray.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom.args | 1 + tests/qemuxml2argvdata/disk-cdrom.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-copy_on_read.args | 1 + .../disk-copy_on_read.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-detect-zeroes.args | 1 + .../disk-detect-zeroes.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-discard.args | 1 + tests/qemuxml2argvdata/disk-error-policy.args | 1 + .../disk-error-policy.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-floppy-tray.args | 1 + tests/qemuxml2argvdata/disk-floppy.args | 1 + tests/qemuxml2argvdata/disk-floppy.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-fmt-qcow.args | 1 + tests/qemuxml2argvdata/disk-geometry.args | 1 + .../disk-hostdev-scsi-virtio-iscsi-auth-AES.args | 1 + tests/qemuxml2argvdata/disk-ide-split.args | 1 + tests/qemuxml2argvdata/disk-ide-wwn.args | 1 + tests/qemuxml2argvdata/disk-ioeventfd.args | 1 + tests/qemuxml2argvdata/disk-iscsi.args | 1 + tests/qemuxml2argvdata/disk-network-gluster.args | 1 + .../disk-network-gluster.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-iscsi-modern.args | 1 + tests/qemuxml2argvdata/disk-network-iscsi.args | 1 + .../disk-network-iscsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-nbd.args | 1 + .../disk-network-nbd.x86_64-latest.args | 2 +- .../disk-network-rbd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-sheepdog.args | 1 + .../disk-network-sheepdog.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-source-auth.args | 1 + .../disk-network-source-auth.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-tlsx509.args | 1 + .../disk-network-tlsx509.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-vxhs.args | 1 + tests/qemuxml2argvdata/disk-no-boot.args | 1 + tests/qemuxml2argvdata/disk-order.args | 1 + tests/qemuxml2argvdata/disk-readonly-disk.args | 1 + .../disk-readonly-disk.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-sata-device.args | 1 + .../disk-scsi-device-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-scsi-disk-split.args | 1 + tests/qemuxml2argvdata/disk-scsi-disk-vpd.args | 1 + tests/qemuxml2argvdata/disk-scsi-disk-wwn.args | 1 + tests/qemuxml2argvdata/disk-scsi-lun-passthrough.args | 1 + tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-serial.args | 1 + tests/qemuxml2argvdata/disk-shared.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-snapshot.args | 1 + tests/qemuxml2argvdata/disk-source-pool-mode.args | 1 + tests/qemuxml2argvdata/disk-source-pool.args | 1 + tests/qemuxml2argvdata/disk-usb-device-removable.args | 1 + tests/qemuxml2argvdata/disk-usb-device.args | 1 + tests/qemuxml2argvdata/disk-virtio-ccw-many.args | 1 + tests/qemuxml2argvdata/disk-virtio-ccw.args | 1 + tests/qemuxml2argvdata/disk-virtio-queues.args | 1 + tests/qemuxml2argvdata/disk-virtio-s390-zpci.args | 1 + tests/qemuxml2argvdata/disk-virtio-s390.args | 1 + .../disk-virtio-scsi-reservations.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-virtio.args | 1 + tests/qemuxml2argvdata/encrypted-disk-usage.args | 1 + tests/qemuxml2argvdata/encrypted-disk.args | 1 + tests/qemuxml2argvdata/eoi-disabled.args | 1 + tests/qemuxml2argvdata/eoi-enabled.args | 1 + tests/qemuxml2argvdata/event_idx.args | 1 + tests/qemuxml2argvdata/fd-memory-no-numa-topology.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology2.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology3.args | 1 + tests/qemuxml2argvdata/fips-enabled.args | 1 + tests/qemuxml2argvdata/floppy-drive-fat.args | 1 + .../floppy-drive-fat.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/fs9p-ccw.args | 1 + tests/qemuxml2argvdata/fs9p.args | 1 + tests/qemuxml2argvdata/genid-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/genid.x86_64-latest.args | 2 +- ...graphics-egl-headless-rendernode.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-egl-headless.args | 1 + .../graphics-egl-headless.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-sdl-fullscreen.args | 1 + tests/qemuxml2argvdata/graphics-sdl.args | 1 + .../graphics-spice-agent-file-xfer.args | 1 + tests/qemuxml2argvdata/graphics-spice-agentmouse.args | 1 + .../graphics-spice-auto-socket-cfg.args | 1 + tests/qemuxml2argvdata/graphics-spice-auto-socket.args | 1 + tests/qemuxml2argvdata/graphics-spice-compression.args | 1 + .../qemuxml2argvdata/graphics-spice-egl-headless.args | 1 + ...raphics-spice-gl-auto-rendernode.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-spice-no-args.args | 1 + tests/qemuxml2argvdata/graphics-spice-qxl-vga.args | 1 + tests/qemuxml2argvdata/graphics-spice-sasl.args | 1 + tests/qemuxml2argvdata/graphics-spice-socket.args | 1 + tests/qemuxml2argvdata/graphics-spice-timeout.args | 1 + tests/qemuxml2argvdata/graphics-spice-usb-redir.args | 1 + tests/qemuxml2argvdata/graphics-spice.args | 1 + .../qemuxml2argvdata/graphics-vnc-auto-socket-cfg.args | 1 + tests/qemuxml2argvdata/graphics-vnc-auto-socket.args | 1 + tests/qemuxml2argvdata/graphics-vnc-egl-headless.args | 1 + .../qemuxml2argvdata/graphics-vnc-no-listen-attr.args | 1 + tests/qemuxml2argvdata/graphics-vnc-none.args | 1 + tests/qemuxml2argvdata/graphics-vnc-policy.args | 1 + .../graphics-vnc-remove-generated-socket.args | 1 + tests/qemuxml2argvdata/graphics-vnc-sasl.args | 1 + .../graphics-vnc-socket-new-cmdline.args | 1 + tests/qemuxml2argvdata/graphics-vnc-socket.args | 1 + .../graphics-vnc-tls-secret.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-tls.args | 1 + .../graphics-vnc-tls.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-websocket.args | 1 + tests/qemuxml2argvdata/graphics-vnc.args | 1 + ...-mdev-display-spice-egl-headless.x86_64-latest.args | 2 +- ...ostdev-mdev-display-spice-opengl.x86_64-latest.args | 2 +- ...ev-mdev-display-vnc-egl-headless.x86_64-latest.args | 2 +- .../hostdev-mdev-display-vnc.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hostdev-mdev-precreated.args | 1 + tests/qemuxml2argvdata/hostdev-pci-address-device.args | 1 + tests/qemuxml2argvdata/hostdev-pci-address.args | 1 + .../qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-lsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-readonly.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-ccw.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-pci.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-pcie.args | 1 + .../hostdev-scsi-virtio-iscsi-auth.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.args | 1 + .../qemuxml2argvdata/hostdev-subsys-mdev-vfio-ccw.args | 1 + .../hostdev-usb-address-device-boot.args | 1 + tests/qemuxml2argvdata/hostdev-usb-address-device.args | 1 + tests/qemuxml2argvdata/hostdev-usb-address.args | 1 + tests/qemuxml2argvdata/hostdev-vfio-multidomain.args | 1 + .../hostdev-vfio-zpci-autogenerate.args | 1 + .../qemuxml2argvdata/hostdev-vfio-zpci-boundaries.args | 1 + .../hostdev-vfio-zpci-multidomain-many.args | 1 + tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 1 + tests/qemuxml2argvdata/hostdev-vfio.args | 1 + tests/qemuxml2argvdata/hotplug-base.args | 1 + tests/qemuxml2argvdata/hugepages-default-2M.args | 1 + .../hugepages-default-system-size.args | 1 + tests/qemuxml2argvdata/hugepages-default.args | 1 + tests/qemuxml2argvdata/hugepages-memaccess.args | 1 + tests/qemuxml2argvdata/hugepages-memaccess2.args | 1 + tests/qemuxml2argvdata/hugepages-nodeset.args | 1 + tests/qemuxml2argvdata/hugepages-numa-default-2M.args | 1 + .../qemuxml2argvdata/hugepages-numa-default-dimm.args | 1 + tests/qemuxml2argvdata/hugepages-numa-default.args | 1 + .../qemuxml2argvdata/hugepages-numa-nodeset-part.args | 1 + tests/qemuxml2argvdata/hugepages-numa-nodeset.args | 1 + .../hugepages-nvdimm.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hugepages-shared.args | 1 + tests/qemuxml2argvdata/hyperv-off.args | 1 + tests/qemuxml2argvdata/hyperv-panic.args | 1 + tests/qemuxml2argvdata/hyperv.args | 1 + tests/qemuxml2argvdata/input-usbmouse-addr.args | 1 + tests/qemuxml2argvdata/input-usbmouse.args | 1 + tests/qemuxml2argvdata/input-usbtablet.args | 1 + tests/qemuxml2argvdata/input-virtio-ccw.args | 1 + tests/qemuxml2argvdata/intel-iommu-caching-mode.args | 1 + tests/qemuxml2argvdata/intel-iommu-device-iotlb.args | 1 + tests/qemuxml2argvdata/intel-iommu-eim.args | 1 + tests/qemuxml2argvdata/intel-iommu-machine.args | 1 + tests/qemuxml2argvdata/intel-iommu.args | 1 + tests/qemuxml2argvdata/iothreads-disk-virtio-ccw.args | 1 + tests/qemuxml2argvdata/iothreads-disk.args | 1 + tests/qemuxml2argvdata/iothreads-ids-partial.args | 1 + tests/qemuxml2argvdata/iothreads-ids.args | 1 + .../iothreads-virtio-scsi-pci.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/iothreads.args | 1 + tests/qemuxml2argvdata/kvm-features-off.args | 1 + tests/qemuxml2argvdata/kvm-features.args | 1 + tests/qemuxml2argvdata/kvm-pit-delay.args | 1 + tests/qemuxml2argvdata/kvm-pit-discard.args | 1 + tests/qemuxml2argvdata/kvmclock+eoi-disabled.args | 1 + tests/qemuxml2argvdata/kvmclock.args | 1 + tests/qemuxml2argvdata/luks-disks-source-qcow2.args | 1 + tests/qemuxml2argvdata/luks-disks-source.args | 1 + tests/qemuxml2argvdata/luks-disks.args | 1 + tests/qemuxml2argvdata/mach-virt-console-virtio.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-native.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-pci.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-usb.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-off-cap.args | 1 + .../qemuxml2argvdata/machine-aeskeywrap-off-caps.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-on-cap.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-on-caps.args | 1 + tests/qemuxml2argvdata/machine-aliases1.args | 1 + tests/qemuxml2argvdata/machine-aliases2.args | 1 + tests/qemuxml2argvdata/machine-core-off.args | 1 + tests/qemuxml2argvdata/machine-core-on.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-off-cap.args | 1 + .../qemuxml2argvdata/machine-deakeywrap-off-caps.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-on-cap.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-on-caps.args | 1 + tests/qemuxml2argvdata/machine-keywrap-none-caps.args | 1 + tests/qemuxml2argvdata/machine-keywrap-none.args | 1 + .../machine-loadparm-multiple-disks-nets-s390.args | 1 + tests/qemuxml2argvdata/machine-loadparm-net-s390.args | 1 + tests/qemuxml2argvdata/machine-loadparm-s390.args | 1 + tests/qemuxml2argvdata/machine-smm-opt.args | 1 + tests/qemuxml2argvdata/machine-vmport-opt.args | 1 + tests/qemuxml2argvdata/master-key.args | 1 + .../memfd-memory-default-hugepage.x86_64-latest.args | 2 +- .../memfd-memory-numa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/memory-hotplug-dimm-addr.args | 1 + tests/qemuxml2argvdata/memory-hotplug-dimm.args | 1 + .../memory-hotplug-nvdimm-access.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-align.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-label.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-readonly.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 2 +- .../qemuxml2argvdata/memory-hotplug-ppc64-nonuma.args | 1 + tests/qemuxml2argvdata/memory-hotplug.args | 1 + tests/qemuxml2argvdata/memtune-unlimited.args | 1 + tests/qemuxml2argvdata/memtune.args | 1 + tests/qemuxml2argvdata/migrate-numa-unaligned.args | 1 + tests/qemuxml2argvdata/migrate.args | 1 + tests/qemuxml2argvdata/minimal-msg-timestamp.args | 1 + tests/qemuxml2argvdata/minimal-sandbox.args | 1 + tests/qemuxml2argvdata/minimal.args | 1 + tests/qemuxml2argvdata/misc-acpi.args | 1 + tests/qemuxml2argvdata/misc-disable-s3.args | 1 + tests/qemuxml2argvdata/misc-disable-suspends.args | 1 + tests/qemuxml2argvdata/misc-enable-s4.args | 1 + tests/qemuxml2argvdata/misc-no-reboot.args | 1 + tests/qemuxml2argvdata/misc-uuid.args | 1 + tests/qemuxml2argvdata/mlock-off.args | 2 +- tests/qemuxml2argvdata/mlock-on.args | 2 +- tests/qemuxml2argvdata/mlock-unsupported.args | 1 + tests/qemuxml2argvdata/monitor-json.args | 1 + tests/qemuxml2argvdata/multifunction-pci-device.args | 1 + tests/qemuxml2argvdata/name-escape.args | 1 + tests/qemuxml2argvdata/net-client.args | 1 + tests/qemuxml2argvdata/net-eth-hostip.args | 1 + tests/qemuxml2argvdata/net-eth-ifname.args | 1 + tests/qemuxml2argvdata/net-eth-names.args | 1 + tests/qemuxml2argvdata/net-eth.args | 1 + tests/qemuxml2argvdata/net-hostdev-bootorder.args | 1 + tests/qemuxml2argvdata/net-hostdev-multidomain.args | 1 + .../qemuxml2argvdata/net-hostdev-vfio-multidomain.args | 1 + tests/qemuxml2argvdata/net-hostdev-vfio.args | 1 + tests/qemuxml2argvdata/net-hostdev.args | 1 + tests/qemuxml2argvdata/net-mcast.args | 1 + tests/qemuxml2argvdata/net-server.args | 1 + tests/qemuxml2argvdata/net-udp.args | 1 + tests/qemuxml2argvdata/net-user-addr.args | 1 + tests/qemuxml2argvdata/net-user.args | 1 + tests/qemuxml2argvdata/net-vhostuser-multiq.args | 1 + tests/qemuxml2argvdata/net-vhostuser.args | 1 + .../qemuxml2argvdata/net-vhostuser.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/net-virtio-ccw.args | 1 + tests/qemuxml2argvdata/net-virtio-device.args | 1 + .../qemuxml2argvdata/net-virtio-disable-offloads.args | 1 + tests/qemuxml2argvdata/net-virtio-netdev.args | 1 + tests/qemuxml2argvdata/net-virtio-rxtxqueuesize.args | 1 + tests/qemuxml2argvdata/net-virtio-s390.args | 1 + tests/qemuxml2argvdata/net-virtio.args | 1 + tests/qemuxml2argvdata/nosharepages.args | 1 + .../numad-auto-memory-vcpu-cpuset.args | 1 + ...numad-auto-memory-vcpu-no-cpuset-and-placement.args | 1 + .../numad-auto-vcpu-static-numatune.args | 1 + .../numad-static-memory-auto-vcpu.args | 1 + tests/qemuxml2argvdata/numad.args | 1 + .../numatune-auto-nodeset-invalid.args | 1 + tests/qemuxml2argvdata/numatune-auto-prefer.args | 1 + tests/qemuxml2argvdata/numatune-distances.args | 1 + tests/qemuxml2argvdata/numatune-memnode-no-memory.args | 1 + tests/qemuxml2argvdata/numatune-memnode.args | 1 + tests/qemuxml2argvdata/numatune-memory.args | 1 + .../os-firmware-bios.x86_64-latest.args | 2 +- .../os-firmware-efi-secboot.x86_64-latest.args | 2 +- .../os-firmware-efi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pages-dimm-discard.args | 1 + tests/qemuxml2argvdata/pages-discard-hugepages.args | 1 + tests/qemuxml2argvdata/pages-discard.args | 1 + tests/qemuxml2argvdata/panic-double.args | 1 + tests/qemuxml2argvdata/panic-no-address.args | 1 + tests/qemuxml2argvdata/panic.args | 1 + tests/qemuxml2argvdata/parallel-parport-chardev.args | 1 + tests/qemuxml2argvdata/parallel-tcp-chardev.args | 1 + .../parallel-unix-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 1 + tests/qemuxml2argvdata/pci-autoadd-idx.args | 1 + tests/qemuxml2argvdata/pci-autofill-addr.args | 1 + tests/qemuxml2argvdata/pci-bridge-many-disks.args | 1 + tests/qemuxml2argvdata/pci-bridge.args | 1 + tests/qemuxml2argvdata/pci-expander-bus.args | 1 + tests/qemuxml2argvdata/pci-many.args | 1 + tests/qemuxml2argvdata/pci-rom-disabled.args | 1 + tests/qemuxml2argvdata/pci-rom.args | 1 + tests/qemuxml2argvdata/pci-serial-dev-chardev.args | 1 + tests/qemuxml2argvdata/pcie-expander-bus.args | 1 + .../qemuxml2argvdata/pcie-root-port-model-generic.args | 1 + .../qemuxml2argvdata/pcie-root-port-model-ioh3420.args | 1 + tests/qemuxml2argvdata/pcie-root-port.args | 1 + tests/qemuxml2argvdata/pcie-root.args | 1 + .../qemuxml2argvdata/pcie-switch-downstream-port.args | 1 + tests/qemuxml2argvdata/pcie-switch-upstream-port.args | 1 + tests/qemuxml2argvdata/pcihole64-q35.args | 1 + tests/qemuxml2argvdata/pcihole64.args | 1 + tests/qemuxml2argvdata/pmu-feature-off.args | 1 + tests/qemuxml2argvdata/pmu-feature.args | 1 + tests/qemuxml2argvdata/ppc-dtb.args | 1 + .../ppc64-pseries-graphics.ppc64-latest.args | 2 +- .../ppc64-pseries-headless.ppc64-latest.args | 2 +- .../qemuxml2argvdata/ppc64-usb-controller-legacy.args | 1 + .../ppc64-usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/ppc64-usb-controller.args | 1 + tests/qemuxml2argvdata/ppce500-serial.args | 1 + tests/qemuxml2argvdata/pseries-basic.args | 1 + tests/qemuxml2argvdata/pseries-console-virtio.args | 1 + tests/qemuxml2argvdata/pseries-cpu-compat-power9.args | 1 + tests/qemuxml2argvdata/pseries-cpu-compat.args | 1 + tests/qemuxml2argvdata/pseries-cpu-exact.args | 1 + tests/qemuxml2argvdata/pseries-cpu-le.args | 1 + tests/qemuxml2argvdata/pseries-features.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-1.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-2.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-3.args | 1 + .../pseries-machine-max-cpu-compat.args | 1 + tests/qemuxml2argvdata/pseries-many-buses-1.args | 1 + tests/qemuxml2argvdata/pseries-many-buses-2.args | 1 + tests/qemuxml2argvdata/pseries-many-devices.args | 1 + tests/qemuxml2argvdata/pseries-nvram.args | 1 + tests/qemuxml2argvdata/pseries-panic-missing.args | 1 + tests/qemuxml2argvdata/pseries-panic-no-address.args | 1 + .../qemuxml2argvdata/pseries-phb-default-missing.args | 1 + tests/qemuxml2argvdata/pseries-phb-numa-node.args | 1 + tests/qemuxml2argvdata/pseries-phb-simple.args | 1 + tests/qemuxml2argvdata/pseries-serial-native.args | 1 + tests/qemuxml2argvdata/pseries-serial-pci.args | 1 + tests/qemuxml2argvdata/pseries-serial-usb.args | 1 + tests/qemuxml2argvdata/pseries-usb-default.args | 1 + tests/qemuxml2argvdata/pseries-usb-kbd.args | 1 + tests/qemuxml2argvdata/pseries-usb-multi.args | 1 + tests/qemuxml2argvdata/pseries-vio-user-assigned.args | 1 + tests/qemuxml2argvdata/pseries-vio.args | 1 + tests/qemuxml2argvdata/pv-spinlock-disabled.args | 1 + tests/qemuxml2argvdata/pv-spinlock-enabled.args | 1 + tests/qemuxml2argvdata/q35-acpi-nouefi.args | 1 + tests/qemuxml2argvdata/q35-acpi-uefi.args | 1 + tests/qemuxml2argvdata/q35-default-devices-only.args | 1 + tests/qemuxml2argvdata/q35-multifunction.args | 1 + tests/qemuxml2argvdata/q35-noacpi-nouefi.args | 1 + tests/qemuxml2argvdata/q35-pci-force-address.args | 1 + tests/qemuxml2argvdata/q35-pcie-autoadd.args | 1 + tests/qemuxml2argvdata/q35-pcie.args | 1 + tests/qemuxml2argvdata/q35-pm-disable-fallback.args | 1 + tests/qemuxml2argvdata/q35-pm-disable.args | 1 + tests/qemuxml2argvdata/q35-usb2-multi.args | 1 + tests/qemuxml2argvdata/q35-usb2-reorder.args | 1 + tests/qemuxml2argvdata/q35-usb2.args | 1 + tests/qemuxml2argvdata/q35-virt-manager-basic.args | 1 + tests/qemuxml2argvdata/q35-virtio-pci.args | 1 + tests/qemuxml2argvdata/q35.args | 1 + tests/qemuxml2argvdata/qemu-ns-alt.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline-ns1.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline.args | 1 + .../qemu-ns-domain-commandline-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-domain-commandline.args | 1 + tests/qemuxml2argvdata/qemu-ns-domain-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-no-env.args | 1 + tests/qemuxml2argvdata/qemu-ns.args | 1 + tests/qemuxml2argvdata/reboot-timeout-disabled.args | 1 + tests/qemuxml2argvdata/reboot-timeout-enabled.args | 1 + tests/qemuxml2argvdata/restore-v2-fd.args | 1 + tests/qemuxml2argvdata/restore-v2.args | 1 + .../riscv64-virt-headless.riscv64-latest.args | 2 +- tests/qemuxml2argvdata/riscv64-virt-pci.args | 1 + tests/qemuxml2argvdata/riscv64-virt.args | 1 + .../s390-allow-bogus-usb-controller.args | 1 + tests/qemuxml2argvdata/s390-allow-bogus-usb-none.args | 1 + tests/qemuxml2argvdata/s390-panic-missing.args | 1 + tests/qemuxml2argvdata/s390-panic-no-address.args | 1 + tests/qemuxml2argvdata/s390-serial-2.args | 1 + tests/qemuxml2argvdata/s390-serial-console.args | 1 + tests/qemuxml2argvdata/s390-serial.args | 1 + tests/qemuxml2argvdata/seclabel-dac-none.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-baselabel.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-labelskip.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-override.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-relabel.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic.args | 1 + tests/qemuxml2argvdata/seclabel-none.args | 1 + tests/qemuxml2argvdata/seclabel-static-labelskip.args | 1 + tests/qemuxml2argvdata/seclabel-static-relabel.args | 1 + tests/qemuxml2argvdata/seclabel-static.args | 1 + tests/qemuxml2argvdata/serial-dev-chardev-iobase.args | 1 + tests/qemuxml2argvdata/serial-dev-chardev.args | 1 + tests/qemuxml2argvdata/serial-file-chardev.args | 1 + tests/qemuxml2argvdata/serial-file-log.args | 1 + tests/qemuxml2argvdata/serial-many-chardev.args | 1 + tests/qemuxml2argvdata/serial-pty-chardev.args | 1 + tests/qemuxml2argvdata/serial-spiceport-nospice.args | 1 + tests/qemuxml2argvdata/serial-spiceport.args | 1 + tests/qemuxml2argvdata/serial-tcp-chardev.args | 1 + tests/qemuxml2argvdata/serial-tcp-telnet-chardev.args | 1 + .../serial-tcp-tlsx509-chardev-notls.args | 1 + .../serial-tcp-tlsx509-chardev-verify.args | 1 + tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.args | 1 + .../serial-tcp-tlsx509-secret-chardev.args | 1 + tests/qemuxml2argvdata/serial-udp-chardev.args | 1 + tests/qemuxml2argvdata/serial-unix-chardev.args | 1 + .../serial-unix-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 1 + tests/qemuxml2argvdata/shmem-plain-doorbell.args | 1 + tests/qemuxml2argvdata/shmem.args | 1 + tests/qemuxml2argvdata/smartcard-controller.args | 1 + .../smartcard-host-certificates-database.args | 1 + .../qemuxml2argvdata/smartcard-host-certificates.args | 1 + tests/qemuxml2argvdata/smartcard-host.args | 1 + .../smartcard-passthrough-spicevmc.args | 1 + tests/qemuxml2argvdata/smartcard-passthrough-tcp.args | 1 + .../smartcard-passthrough-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/smbios.args | 1 + tests/qemuxml2argvdata/smp.args | 1 + tests/qemuxml2argvdata/sound-device.args | 1 + tests/qemuxml2argvdata/sound.args | 1 + .../tpm-emulator-tpm2.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/tpm-emulator.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/tpm-passthrough-crb.args | 1 + tests/qemuxml2argvdata/tpm-passthrough.args | 1 + .../tseg-explicit-size.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/usb-controller-default-q35.args | 1 + .../qemuxml2argvdata/usb-controller-explicit-q35.args | 1 + tests/qemuxml2argvdata/usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/usb-controller-xhci.args | 1 + tests/qemuxml2argvdata/usb-controller.args | 1 + tests/qemuxml2argvdata/usb-hub-autoadd-deluxe.args | 1 + tests/qemuxml2argvdata/usb-hub-autoadd.args | 1 + tests/qemuxml2argvdata/usb-hub.args | 1 + tests/qemuxml2argvdata/usb-ich9-autoassign.args | 1 + tests/qemuxml2argvdata/usb-ich9-companion.args | 1 + tests/qemuxml2argvdata/usb-ich9-ehci-addr.args | 1 + tests/qemuxml2argvdata/usb-long-port-path.args | 1 + tests/qemuxml2argvdata/usb-none.args | 1 + tests/qemuxml2argvdata/usb-piix3-controller.args | 1 + tests/qemuxml2argvdata/usb-port-autoassign.args | 1 + tests/qemuxml2argvdata/usb-port-missing.args | 1 + tests/qemuxml2argvdata/usb-ports.args | 1 + tests/qemuxml2argvdata/usb-redir-boot.args | 1 + tests/qemuxml2argvdata/usb-redir-filter-version.args | 1 + tests/qemuxml2argvdata/usb-redir-filter.args | 1 + .../qemuxml2argvdata/usb-redir-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/usb-redir.args | 1 + tests/qemuxml2argvdata/usb-xhci-autoassign.args | 1 + tests/qemuxml2argvdata/usb1-usb2.args | 1 + tests/qemuxml2argvdata/user-aliases-usb.args | 1 + tests/qemuxml2argvdata/user-aliases.args | 1 + tests/qemuxml2argvdata/vcpu-placement-static.args | 1 + .../vhost-vsock-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vhost-vsock.x86_64-latest.args | 2 +- .../qemuxml2argvdata/video-device-pciaddr-default.args | 1 + tests/qemuxml2argvdata/video-none-device.args | 1 + tests/qemuxml2argvdata/video-qxl-device-vgamem.args | 1 + .../video-qxl-device-vram64.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/video-qxl-device.args | 1 + tests/qemuxml2argvdata/video-qxl-heads.args | 1 + tests/qemuxml2argvdata/video-qxl-nodevice.args | 1 + tests/qemuxml2argvdata/video-qxl-noheads.args | 1 + .../qemuxml2argvdata/video-qxl-sec-device-vgamem.args | 1 + .../video-qxl-sec-device-vram64.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/video-qxl-sec-device.args | 1 + tests/qemuxml2argvdata/video-vga-device-vgamem.args | 1 + tests/qemuxml2argvdata/video-vga-device.args | 1 + tests/qemuxml2argvdata/video-vga-nodevice.args | 1 + tests/qemuxml2argvdata/video-vga-qxl-heads.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-ccw.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-device.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-sdl-gl.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-secondary.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-spice-gl.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-virgl.args | 1 + tests/qemuxml2argvdata/video-virtio-vga.args | 1 + tests/qemuxml2argvdata/virtio-input-passthrough.args | 1 + tests/qemuxml2argvdata/virtio-input.args | 1 + tests/qemuxml2argvdata/virtio-lun.args | 1 + .../virtio-non-transitional.x86_64-3.1.0.args | 2 +- .../virtio-non-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-options.args | 1 + tests/qemuxml2argvdata/virtio-rng-ccw.args | 1 + tests/qemuxml2argvdata/virtio-rng-default.args | 1 + .../virtio-rng-egd-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-rng-egd.args | 1 + tests/qemuxml2argvdata/virtio-rng-multiple.args | 1 + tests/qemuxml2argvdata/virtio-rng-random.args | 1 + .../virtio-transitional.x86_64-3.1.0.args | 2 +- .../virtio-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vmcoreinfo.args | 1 + tests/qemuxml2argvdata/watchdog-device.args | 1 + tests/qemuxml2argvdata/watchdog-diag288.args | 1 + tests/qemuxml2argvdata/watchdog-dump.args | 1 + tests/qemuxml2argvdata/watchdog-injectnmi.args | 1 + tests/qemuxml2argvdata/watchdog.args | 1 + tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 1 + .../x86_64-pc-graphics.x86_64-latest.args | 2 +- .../x86_64-pc-headless.x86_64-latest.args | 2 +- .../x86_64-q35-graphics.x86_64-latest.args | 2 +- .../x86_64-q35-headless.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 5 ++--- 688 files changed, 663 insertions(+), 126 deletions(-) -- 2.21.0

2 7

[libvirt] [jenkins-ci PATCH] guests: Remove SASL symlink kludge
by Andrea Bolognani 12 Apr '19

12 Apr '19

It's no longer needed as of libvirt commit ab6f29c6da12. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/playbooks/update/tasks/kludges.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/update/tasks/kludges.yml index 9d4f232..708e7a4 100644 --- a/guests/playbooks/update/tasks/kludges.yml +++ b/guests/playbooks/update/tasks/kludges.yml @@ -9,9 +9,7 @@ force: yes with_items: - include/readline - - include/sasl - lib/libreadline.so - - lib/libsasl2.so when: - os_name == 'FreeBSD' -- 2.20.1

2 1

[libvirt] [PATCH] virresctrl: fix MBA memory leak
by Pavel Hrdina 12 Apr '19

12 Apr '19

The 'bandwidths' variable is allocated using VIR_RESIZE_N so it has to be freed as well. ==118315== 8 bytes in 1 blocks are definitely lost in loss record 299 of 2,401 ==118315== at 0x4C29DAD: malloc (vg_replace_malloc.c:308) ==118315== by 0x4C2C100: realloc (vg_replace_malloc.c:836) ==118315== by 0x52C3FAF: virReallocN (viralloc.c:245) ==118315== by 0x52C4079: virExpandN (viralloc.c:294) ==118315== by 0x532BBA8: virResctrlAllocParseProcessMemoryBandwidth (virresctrl.c:1156) ==118315== by 0x532BBA8: virResctrlAllocParseMemoryBandwidthLine (virresctrl.c:1211) ==118315== by 0x532BBA8: virResctrlAllocParse (virresctrl.c:1414) ==118315== by 0x532BBA8: virResctrlAllocGetGroup (virresctrl.c:1446) ==118315== by 0x532C11D: virResctrlAllocGetDefault (virresctrl.c:1464) ==118315== by 0x532D15E: virResctrlAllocAssign (virresctrl.c:1923) ==118315== by 0x532D15E: virResctrlAllocCreate (virresctrl.c:2042) ==118315== by 0x31E1ABEE: qemuProcessResctrlCreate (qemu_process.c:2596) ==118315== by 0x31E1ABEE: qemuProcessLaunch (qemu_process.c:6444) ==118315== by 0x31E1E341: qemuProcessStart (qemu_process.c:6721) ==118315== by 0x31E81315: qemuDomainObjStart.constprop.50 (qemu_driver.c:7288) ==118315== by 0x31E81A65: qemuDomainCreateWithFlags (qemu_driver.c:7341) ==118315== by 0x54DDB4B: virDomainCreate (libvirt-domain.c:6534) Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virresctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 9e477fc064..87feb4bdcf 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -407,6 +407,7 @@ virResctrlAllocDispose(void *obj) virResctrlAllocMemBWPtr mem_bw = alloc->mem_bw; for (i = 0; i < mem_bw->nbandwidths; i++) VIR_FREE(mem_bw->bandwidths[i]); + VIR_FREE(alloc->mem_bw->bandwidths); VIR_FREE(alloc->mem_bw); } -- 2.20.1

2 1

[libvirt] [PATCH v3 0/7] extend virsh domstate to show additional information
by Bjoern Walk 12 Apr '19

12 Apr '19

This patch series introduces the ability to save additional information for the domain state and exposes this information in virsh domstate. For example in the case of QEMU guest panic events, we can provide additional information like the crash reason or register state of the domain. This information usually gets logged in the domain log but for debugging it is useful to have it accessible from the client. Therefore, let's introduce a new public API function, virDomainGetStateParams, an extensible version of virDomainGetState, which returns the complete state of the domain, including newly introduced additional information. Let's also extend virsh domstate and introduce a new parameter --info to show the domain state, reason and additional information when available. virsh # domstate --info guest-1 crashed (panicked) s390.core = 0 s390.psw-mask = 0x0002000180000000 s390.psw-addr = 0x000000000010f146 s390.reason = disabled-wait v2 -> v3: * try to find a reasonable naming-scheme for parameters * make state/reason in virDomainGetStateParams optional * use new API only when requested * print additional information per line for easier consumption v1 -> v2: * refactored the public API according to discussions to provide a more machine-parsable interface Bjoern Walk (7): qemu: monitor: move event data structure to domain qemu: domain: store and update panic info lib: introduce virDomainGetStateParams function remote: implement remoteDomainGetStateParams qemu: implement qemuDomainGetStateParams virsh: domstate: report detailed state if available news: add entry for virDomainGetStateParams docs/news.xml | 11 +++ include/libvirt/libvirt-domain.h | 76 +++++++++++++++++ src/driver-hypervisor.h | 9 ++ src/libvirt-domain.c | 62 ++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_domain.c | 80 +++++++++++++++++- src/qemu/qemu_domain.h | 47 +++++++++++ src/qemu/qemu_driver.c | 126 +++++++++++++++++++++++++++- src/qemu/qemu_monitor.c | 53 +----------- src/qemu/qemu_monitor.h | 48 ++--------- src/qemu/qemu_monitor_json.c | 20 ++--- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 50 +++++++++++ src/remote/remote_driver.c | 48 +++++++++++ src/remote/remote_protocol.x | 22 ++++- src/remote_protocol-structs | 13 +++ tools/virsh-domain-monitor.c | 94 +++++++++++++++++++-- tools/virsh.pod | 5 +- 18 files changed, 651 insertions(+), 120 deletions(-) -- 2.19.1

3 17

[libvirt] [PATCH v5] tests: perform cross compiler builds on GitLab CI
by Daniel P. Berrangé 12 Apr '19

12 Apr '19

GitLab CI provides some shared build runners that use Docker containers. This resource can usefully run cross-compiled builds since all other CI build testing is currently x86 only, and Travis CI is already very busy testing native builds. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Changed in v4: - Fix env name - Rename jobs to match image name .gitlab-ci.yml | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 .gitlab-ci.yml diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index 0000000000..f576757c88 --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,74 @@ +.job_template: &job_definition + script: + - mkdir vpath + - cd vpath + - ../autogen.sh $CONFIGURE_OPTS + - make -j $(getconf _NPROCESSORS_ONLN) + +debian-9-cross-aarch64: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-aarch64:master + +debian-9-cross-armv6l: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-armv6l:master + +debian-9-cross-armv7l: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-armv7l:master + +debian-9-cross-mips64el: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-mips64el:master + +debian-9-cross-mips: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-mips:master + +debian-9-cross-mipsel: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-mipsel:master + +debian-9-cross-ppc64le: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-ppc64le:master + +debian-9-cross-s390x: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-s390x:master + +debian-sid-cross-aarch64: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-aarch64:master + +debian-sid-cross-armv6l: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-armv6l:master + +debian-sid-cross-armv7l: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-armv7l:master + +debian-sid-cross-i686: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-i686:master + +debian-sid-cross-mips64el: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-mips64el:master + +debian-sid-cross-mips: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-mips:master + +debian-sid-cross-mipsel: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-mipsel:master + +debian-sid-cross-ppc64le: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-ppc64le:master + +debian-sid-cross-s390x: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-s390x:master -- 2.20.1

2 2

[libvirt] [PATCH 0/4] Add 'label' arg to VIR_ENUM_IMPL
by Cole Robinson 11 Apr '19

11 Apr '19

This is a different take on an RFE I posted in July: https://www.redhat.com/archives/libvir-list/2018-July/msg01815.html The goal of this series is to get us close to being able to raise errors from ToString and FromString functions directly. This will allow us to drop many hundreds of lines of error reporting and accompanying translator load. The first attempt above added a new macro, VIR_ENUM_IMPL_LABEL, which would take a string label, like 'domain type' for virDomainType enum. The generated ToString and FromString functions for that enum would now raise errors containing the label. Redundant error reporting could now be stripped out piece by piece as individual enums are converted. Thinking some more though I don't really like this strategy. Calling code won't have an easy way to know whether ToString/FromString functions are the type that raise errors or not, which could lead to new code accidentally omitting them and failing to raise an error. It could also stretch out the time that the code base is in a half transitioned state. This series is a slightly different direction. VIR_ENUM_IMPL now always takes a label, but for now we don't actually raise any errors. Later at a chosen time we can enable error reporting in the code and begin removing duplicate error reporting. The only downside is that until the transition is complete, there may be cases of double error reporting, but that's the lesser of two evils compared to the previous approach IMO. So the feedback I'm looking for: - Is this worth doing? (danpb+mprivozn said as much for first posting) - Is this approach acceptable? - Review of the strings added in the last patch Notes: - This is on top of pkrempa's virenum.c patches on list - The last two patches are separated to make review easier, but they will be committed together - When enabled, one notable case this will make error reporting worse is virTristate usage. But I think if we manually implement *TOString/FromString wrappers in that case we can require callers to pass in an identifying string. Something to think about for later Cole Robinson (4): Always put _LAST enums on second line of VIR_ENUM_IMPL cfg.mk: Only force _LAST enum on VIR_ENUM_IMPL second line util: Add 'label' field to VIR_ENUM_IMPL Add string labels to all VIR_ENUM_IMPL calls cfg.mk | 6 +- docs/apibuild.py | 12 ++ src/access/viraccessperm.c | 20 +- src/conf/capabilities.c | 3 +- src/conf/cpu_conf.c | 21 +- src/conf/device_conf.c | 3 +- src/conf/domain_capabilities.c | 3 +- src/conf/domain_conf.c | 333 +++++++++++++++++++----------- src/conf/interface_conf.c | 2 +- src/conf/netdev_vlan_conf.c | 3 +- src/conf/network_conf.c | 11 +- src/conf/node_device_conf.c | 12 +- src/conf/numa_conf.c | 7 +- src/conf/nwfilter_conf.c | 21 +- src/conf/snapshot_conf.c | 6 +- src/conf/storage_adapter_conf.c | 2 +- src/conf/storage_conf.c | 18 +- src/libxl/libxl_domain.c | 3 +- src/locking/lock_daemon.c | 3 +- src/logging/log_daemon.c | 3 +- src/lxc/lxc_domain.c | 7 +- src/lxc/lxc_native.c | 3 +- src/network/leaseshelper.c | 3 +- src/qemu/qemu_agent.c | 4 +- src/qemu/qemu_capabilities.c | 3 +- src/qemu/qemu_command.c | 27 ++- src/qemu/qemu_domain.c | 12 +- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_firmware.c | 6 +- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_migration_cookie.c | 2 +- src/qemu/qemu_migration_params.c | 9 +- src/qemu/qemu_monitor.c | 8 +- src/qemu/qemu_monitor_json.c | 10 +- src/remote/remote_daemon.c | 3 +- src/util/vircgroup.c | 3 +- src/util/vircgroupbackend.c | 3 +- src/util/vircgroupv1.c | 3 +- src/util/vircgroupv2.c | 3 +- src/util/virconf.c | 3 +- src/util/virenum.c | 28 ++- src/util/virenum.h | 15 +- src/util/virerror.c | 3 +- src/util/virfirewall.c | 3 +- src/util/virfirewalld.c | 6 +- src/util/virgic.c | 3 +- src/util/virhook.c | 20 +- src/util/virkeycode.c | 3 +- src/util/virlog.c | 3 +- src/util/virmdev.c | 3 +- src/util/virnetdev.c | 6 +- src/util/virnetdevmacvlan.c | 3 +- src/util/virnetdevvportprofile.c | 6 +- src/util/virpci.c | 9 +- src/util/virperf.c | 3 +- src/util/virprocess.c | 3 +- src/util/virresctrl.c | 12 +- src/util/virsecret.c | 3 +- src/util/virstorageencryption.c | 4 +- src/util/virstoragefile.c | 17 +- src/util/virsysinfo.c | 3 +- src/util/virtypedparam.c | 3 +- src/util/virutil.c | 1 - src/vmware/vmware_conf.c | 3 +- src/vmx/vmx.c | 3 +- tests/group-qemu-caps.pl | 2 +- tests/virkeycodetest.c | 3 +- tools/virsh-domain-monitor.c | 24 +-- tools/virsh-domain.c | 56 ++--- tools/virsh-host.c | 3 +- tools/virsh-network.c | 10 +- tools/virsh-nodedev.c | 2 +- tools/virsh-pool.c | 4 +- tools/virsh-secret.c | 2 +- tools/virsh-volume.c | 5 +- tools/virt-admin.c | 2 +- tools/virt-host-validate-common.c | 3 +- 77 files changed, 561 insertions(+), 334 deletions(-) -- 2.21.0

2 12

[libvirt] [PATCH 0/3] vz: fixes after commits refactoring common snapshot code
by Nikolay Shirokovskiy 11 Apr '19

11 Apr '19

Nikolay Shirokovskiy (3): vz: fix for tracking current snapshot vz: fixes: snapshot: Switch type of virDomainSnapshotObj.def vz: fixes: snapshot: Factor out virDomainMomentDef class src/vz/vz_driver.c | 36 +++++++----------------------------- src/vz/vz_sdk.c | 24 +++++++++++------------- 2 files changed, 18 insertions(+), 42 deletions(-) -- 1.8.3.1

3 5