- Devel - libvirt List Archives

[libvirt] [PATCH for-QEMU-4.1] Declare -realtime as deprecated
by Thomas Huth 15 Apr '19

15 Apr '19

The old -realtime mlock=on|off parameter does exactly the same as the new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so let's deprecate the old -realtime option. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- Deprecation has already been suggested last year: https://patchwork.kernel.org/patch/10480963/#22026215 ... but apparently we forgot to really do it. qemu-deprecated.texi | 5 +++++ vl.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2219386769..2c45204f3f 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -72,6 +72,11 @@ backend settings instead of environment variables. To ease migration to the new format, the ``-audiodev-help'' option can be used to convert the current values of the environment variables to ``-audiodev'' options. +@subsection -realtime (since 4.1) + +The @code{-realtime mlock=on|off} argument has been replaced by the +@code{-overcommit mem-lock=on|off} argument. + @section QEMU Machine Protocol (QMP) commands @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) diff --git a/vl.c b/vl.c index c696ad2a13..d6a2779b70 100644 --- a/vl.c +++ b/vl.c @@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp) } break; case QEMU_OPTION_realtime: + warn_report("'-realtime mlock=...' is deprecated, please use " + "'-overcommit mem-lock=...' instead"); opts = qemu_opts_parse_noisily(qemu_find_opts("realtime"), optarg, false); if (!opts) { -- 2.21.0

5 4

[libvirt] [PATCH] examples: domtop: fix build error
by Bjoern Walk 15 Apr '19

15 Apr '19

GCC version 8.2.1 has problems seeing the the correct flow of control, so manually initialize the temporary variable. ../../examples/domtop/domtop.c: In function 'print_cpu_usage': ../../examples/domtop/domtop.c:242:28: error: 'pos' may be used uninitialized in this function [-Werror=maybe-uninitialized] usage = (now_params[pos].value.ul - then_params[pos].value.ul) / cc1: all warnings being treated as errors Signed-off-by: Bjoern Walk <bwalk(a)linux.ibm.com> --- examples/domtop/domtop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/domtop/domtop.c b/examples/domtop/domtop.c index c9b51aed..e463e287 100644 --- a/examples/domtop/domtop.c +++ b/examples/domtop/domtop.c @@ -206,7 +206,7 @@ print_cpu_usage(size_t cpu, } for (i = 0; i < ncpus; i++) { - size_t pos; + size_t pos = 0; double usage; /* check if the vCPU is in the maps */ -- 2.19.1

1 1

[libvirt] [PATCH] examples: Initialize @pos in domtop.c
by Martin Kletzander 15 Apr '19

15 Apr '19

This is a zero-cost workaround for a bug in GCC 8.3.0 which causes the compilation to fail, because the compiler thinks that the value might be used uninitialized even though it clearly cannot be. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- This is technically a fix for a build-breaker, but I'm sending it for review as it is not that big of a deal it being in examples/ examples/domtop/domtop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/domtop/domtop.c b/examples/domtop/domtop.c index c9b51aed510d..e463e2873f42 100644 --- a/examples/domtop/domtop.c +++ b/examples/domtop/domtop.c @@ -206,7 +206,7 @@ print_cpu_usage(size_t cpu, } for (i = 0; i < ncpus; i++) { - size_t pos; + size_t pos = 0; double usage; /* check if the vCPU is in the maps */ -- 2.21.0

2 2

[libvirt] [PATCH v2 0/2] network: only reload firewall after firewalld is finished restarting
by Laine Stump 15 Apr '19

15 Apr '19

Explanation in Patch 2/2 Changes in v2: * don't (erroneously) check the fields of the message if it's a "Reload" message; only do that if it's a NameOwnerChanged Message. * merge virDBusMessageRead() and virDBusMessageDecode(), since they are now identical (new Patch 1/2) Laine Stump (2): util: eliminate duplicate function virDBusMessageRead network: only reload firewall after firewalld is finished restarting src/libvirt_private.syms | 1 - src/network/bridge_driver.c | 30 +++++++++++++++++---- src/util/virdbus.c | 53 ++++++++++++------------------------- src/util/virdbus.h | 4 +-- src/util/virdbuspriv.h | 4 --- src/util/virfirewalld.c | 8 +++--- src/util/virpolkit.c | 12 ++++----- src/util/virsystemd.c | 6 ++--- tests/virpolkittest.c | 24 ++++++++--------- 9 files changed, 69 insertions(+), 73 deletions(-) -- 2.20.1

2 4

[libvirt] [PATCH] news: Drop empty sections
by Andrea Bolognani 15 Apr '19

15 Apr '19

We have occasionally failed to document certain categories of changes in the release notes, yet still left the corresponding sections in the file even though they were completely empty. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/news.xml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index fcf8520132..c4d61007b9 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -681,8 +681,6 @@ </description> </change> </section> - <section title="Improvements"> - </section> <section title="Bug fixes"> <change> <summary> @@ -990,8 +988,6 @@ </description> </change> </section> - <section title="Bug fixes"> - </section> </release> <release version="v4.5.0" date="2018-07-02"> <section title="New features"> @@ -1305,8 +1301,6 @@ </description> </change> </section> - <section title="Bug fixes"> - </section> </release> <release version="v4.3.0" date="2018-05-02"> <section title="New features"> -- 2.20.1

1 1

[libvirt] [PATCH] Fix spelling for macOS
by Andrea Bolognani 15 Apr '19

15 Apr '19

Though it used to be called "Mac OS X" and "OS X" in the past, it was never "MacOS X" nor "OS-X", and it's just "macOS" now. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. configure.ac | 10 +++++----- m4/virt-driver-network.m4 | 4 ++-- m4/virt-driver-qemu.m4 | 2 +- tools/virsh.pod | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index 4afa4d4b78..dcd78f64bf 100644 --- a/configure.ac +++ b/configure.ac @@ -180,13 +180,13 @@ want_ifconfig=no dnl Make some notes about which OS we're compiling for, as the lxc and qemu dnl drivers require linux headers, and storage_mpath, dtrace, and nwfilter dnl are also linux specific. The "network" and storage_fs drivers are known -dnl to not work on MacOS X presently, so we also make a note if compiling +dnl to not work on macOS presently, so we also make a note if compiling dnl for that -with_linux=no with_osx=no with_freebsd=no with_win=no with_cygwin=no +with_linux=no with_macos=no with_freebsd=no with_win=no with_cygwin=no case $host in *-*-linux*) with_linux=yes ;; - *-*-darwin*) with_osx=yes ;; + *-*-darwin*) with_macos=yes ;; *-*-freebsd*) with_freebsd=yes ;; *-*-mingw* | *-*-msvc* ) with_win=yes ;; *-*-cygwin*) with_cygwin=yes ;; @@ -627,9 +627,9 @@ if test "$with_libvirtd" = "no"; then with_storage_vstorage=no fi -dnl storage-fs does not work on MacOS X +dnl storage-fs does not work on macOS -if test "$with_osx" = "yes"; then +if test "$with_macos" = "yes"; then with_storage_fs=no fi diff --git a/m4/virt-driver-network.m4 b/m4/virt-driver-network.m4 index 1fc9b204c6..b98ce07c9c 100644 --- a/m4/virt-driver-network.m4 +++ b/m4/virt-driver-network.m4 @@ -27,9 +27,9 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_NETWORK], [ AC_REQUIRE([LIBVIRT_DRIVER_CHECK_LXC]) dnl there's no use compiling the network driver without the libvirt - dnl daemon, nor compiling it for MacOS X, where it breaks the compile + dnl daemon, nor compiling it for macOS, where it breaks the compile - if test "$with_libvirtd" = "no" || test "$with_osx" = "yes"; then + if test "$with_libvirtd" = "no" || test "$with_macos" = "yes"; then with_network=no fi diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4 index 556599f1f3..a1d05bbd7f 100644 --- a/m4/virt-driver-qemu.m4 +++ b/m4/virt-driver-qemu.m4 @@ -40,7 +40,7 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_QEMU], [ fi AM_CONDITIONAL([WITH_QEMU], [test "$with_qemu" = "yes"]) - if test $with_freebsd = yes || test $with_osx = yes; then + if test $with_freebsd = yes || test $with_macos = yes; then default_qemu_user=root default_qemu_group=wheel else diff --git a/tools/virsh.pod b/tools/virsh.pod index b7ceba8d03..bb52de3eed 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2389,8 +2389,8 @@ See L<virkeycode-atset3(7)> =item B<os_x> -The numeric values are those defined by the OS-X keyboard input -subsystem. The symbolic names match the corresponding OS-X key +The numeric values are those defined by the macOS keyboard input +subsystem. The symbolic names match the corresponding macOS key constant macro names See L<virkeycode-osx(7)> and L<virkeyname-osx(7)> -- 2.20.1

1 0

[libvirt] [PATCH 0/3] Couple of build fixes after latest cpu changes
by Michal Privoznik 14 Apr '19

14 Apr '19

I've successfully tested these on mingw, arm and x86_64. Almost trivial, but not pushed yet. I'll wait for review. Michal Prívozník (3): virhostcpu.c: Fix misalignment in virHostCPUGetMSRFromKVM comment virhostcpu: Make virHostCPUGetMSR() work only on x86 cpu_x86: Fix placement of *CheckFeature functions src/cpu/cpu_x86.c | 68 ++++++++++++++++++++++--------------------- src/util/virhostcpu.c | 34 ++++++++++++---------- 2 files changed, 54 insertions(+), 48 deletions(-) -- 2.21.0

3 6

[libvirt] [PATCH 00/36] CPU driver enhancements and MSR features
by Jiri Denemark 14 Apr '19

14 Apr '19

In addition to usual CPUID bits, some CPU features started to be reported in IA32_ARCH_CAPABILITIES MSR. This series adds support for such CPU features. However, the last patch which actually adds definitions for some MSR features to the cpu_map should not be pushed yet as the QEMU interface for MSR features is not complete yet. If a domain with some MSR features enabled would be started, all of them would be marked as disabled in the live domain configuration (even though they were actually enabled by QEMU) and they would disappear during migration. Jiri Denemark (36): domaincapstest: Test QEMU 3.1.0 cputest: Add data for Intel(R) Xeon(R) Platinum 8268 CPU cpu_map: Add Cascadelake-Server CPU model cpu_x86: Do not cache microcode version cpu_x86: Require <cpuid> within <feature> in CPU map cpu_x86: Introduce virCPUx86DataItem container struct cpu_x86: Rename virCPUx86Vendor.cpuid cpu_x86: Rename virCPUx86DataItem variables cpu_x86: Rename x86DataCpuidNext function cpu_x86: Rename x86DataCpuid cpu_x86: Rename virCPUx86CPUIDSorter cpu_x86: Rename virCPUx86DataAddCPUIDInt cpu_x86: Rename virCPUx86DataAddCPUID cpu_x86: Rename virCPUx86VendorToCPUID cpu_x86: Simplify x86DataAdd cpu_x86: Introduce virCPUx86DataCmp cpu_x86: Make x86cpuidSetBits more general cpu_x86: Make x86cpuidClearBits more general cpu_x86: Make x86cpuidAndBits more general cpu_x86: Make x86cpuidMatchMasked more general cpu_x86: Make x86cpuidMatch more general cpu_x86: Store virCPUx86DataItem content in union cpu_x86: Add support for storing MSR features in CPU map cpu_x86: Move *CheckFeature functions cputest: Drop support for old QEMU from cpu-parse.sh cputest: Generalize function names in cpu-cpuid.py cputest: Fix comparison in checkCPUIDFeature in cpu-cpuid.py cputest: Rename in_e[ac]x as e[ac]x_in in cpu-cpuid.py cputest: Prepare cpu-cpuid.py for MSR features cputest: Generalize feature parsing in cpu-cpuid.py cputest: Add support for MSR features to cpu-gather.sh cputest: Add support for MSR features to cpu-parse.sh cputest: Add support for MSR features to cpu-cpuid.py vircpuhost: Add support for reading MSRs cpu_x86: Read CPU features from IA32_ARCH_CAPABILITIES MSR cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR features src/cpu/cpu_x86.c | 807 ++++++++++++------ src/cpu/cpu_x86.h | 4 +- src/cpu/cpu_x86_data.h | 27 +- src/cpu_map/index.xml | 1 + src/cpu_map/x86_Cascadelake-Server.xml | 82 ++ src/cpu_map/x86_features.xml | 17 + src/libvirt_private.syms | 3 +- src/libxl/libxl_capabilities.c | 9 +- src/qemu/qemu_monitor_json.c | 7 +- src/util/virhostcpu.c | 80 ++ src/util/virhostcpu.h | 3 + tests/cputest.c | 1 + tests/cputestdata/cpu-cpuid.py | 414 +++------ tests/cputestdata/cpu-gather.sh | 49 +- tests/cputestdata/cpu-parse.sh | 12 +- .../x86_64-cpuid-Core-i7-7600U-enabled.xml | 1 + .../x86_64-cpuid-Core-i7-7600U-json.xml | 1 + ...6_64-cpuid-Xeon-Platinum-8268-disabled.xml | 7 + ...86_64-cpuid-Xeon-Platinum-8268-enabled.xml | 9 + .../x86_64-cpuid-Xeon-Platinum-8268-guest.xml | 35 + .../x86_64-cpuid-Xeon-Platinum-8268-host.xml | 36 + .../x86_64-cpuid-Xeon-Platinum-8268-json.xml | 13 + .../x86_64-cpuid-Xeon-Platinum-8268.json | 702 +++++++++++++++ .../x86_64-cpuid-Xeon-Platinum-8268.sig | 4 + .../x86_64-cpuid-Xeon-Platinum-8268.xml | 55 ++ .../qemu_3.1.0.x86_64.xml | 155 ++++ .../qemu_4.0.0.x86_64.xml | 2 + tests/domaincapstest.c | 4 + 28 files changed, 1954 insertions(+), 586 deletions(-) create mode 100644 src/cpu_map/x86_Cascadelake-Server.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Platinum-8268-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Platinum-8268-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Platinum-8268-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Platinum-8268-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Platinum-8268-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Platinum-8268.json create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Platinum-8268.sig create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-Platinum-8268.xml create mode 100644 tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml -- 2.21.0

6 79

[libvirt] [PATCH v5 0/2] PPC64 support for NVIDIA V100 GPU with NVLink2 passthrough
by Daniel Henrique Barboza 14 Apr '19

14 Apr '19

This series adds support for a new QEMU feature for the spapr (PPC64) machine, NVIDIA V100 + P9 passthrough. Refer to [1] for the version 7 of this feature (version accepted upstream). changes in v5: - patch1: * use ARRAY_CARDINALITY instead of hard coding the array size * fixed leak of 'file' string inside loop * added ATTRIBUTE_UNUSED in the static function to allow build to succeed without applying the second patch - patch 2: * added QEMU reference of the memory layout of NVLink2 support * fixed leak of 'pciAddrStr' string inside loop * added curly braces in multi-line statements Previous version can be found at [2]. [1] https://patchwork.kernel.org/patch/10848727/ [2] https://www.redhat.com/archives/libvir-list/2019-March/msg00801.html Daniel Henrique Barboza (2): qemu_domain: NVLink2 bridge detection function for PPC64 PPC64 support for NVIDIA V100 GPU with NVLink2 passthrough src/qemu/qemu_domain.c | 108 ++++++++++++++++++++++++++++++++++------- 1 file changed, 90 insertions(+), 18 deletions(-) -- 2.20.1

2 6

[libvirt] [PATCH] cpu_map: Distribute x86_Cascadelake-Server.xml
by Michal Privoznik 13 Apr '19

13 Apr '19

In 2878278c74cc4 we've added new cpu model but we've forgot to distribute the XML file it comes in. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under build breaker and trivial rules. src/cpu_map/Makefile.inc.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 5634dd9348..ce8a311e22 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -18,6 +18,7 @@ cpumap_DATA = \ cpu_map/x86_Broadwell-IBRS.xml \ cpu_map/x86_Broadwell-noTSX.xml \ cpu_map/x86_Broadwell-noTSX-IBRS.xml \ + cpu_map/x86_Cascadelake-Server.xml \ cpu_map/x86_Conroe.xml \ cpu_map/x86_core2duo.xml \ cpu_map/x86_coreduo.xml \ -- 2.21.0

1 0