- Devel - libvirt List Archives

[libvirt] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines
by Thomas Huth 12 Apr '19

12 Apr '19

These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- hw/arm/nseries.c | 3 +++ qemu-deprecated.texi | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index 906b7ca22d..66e50b850c 100644 --- a/hw/arm/nseries.c +++ b/hw/arm/nseries.c @@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine, struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s)); int sdram_size = binfo->ram_size; + warn_report("The n800 and n810 machines are deprecated. Please use a " + "different Arm machine instead."); + s->mpu = omap2420_mpu_init(sysmem, sdram_size, machine->cpu_type); /* Setup peripherals diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2219386769..4de7452fac 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -145,6 +145,12 @@ This machine type uses an unmaintained firmware, broken in lots of ways, and unable to start post-2004 operating systems. 40p machine type should be used instead. +@subsection n800 and n810 (Arm) (since 4.1) + +These machines depend on the deprecated bluetooth subsystem. When the +bluetooth subsystem will be removed, the n800 and n810 machines will be +deleted, too. If possible, use a different Arm board instead. + @section Device options @subsection Block device options -- 2.21.0

3 3

[libvirt] [PATCH] network: only reload firewall after firewalld is finished restarting
by Laine Stump 12 Apr '19

12 Apr '19

The network driver used to reload the firewall rules whenever a dbus NameOwnerChanged message for org.fedoraproject.FirewallD1 was received. Presumably at some point in the past this was successful at reloading our rules after a firewalld restart. Recently though I noticed that once firewalld was restarted, libvirt's logs would get this message: The name org.fedoraproject.FirewallD1 was not provided by any .service files After this point, no networks could be started until libvirtd itself was restarted. The problem is that the NameOwnerChanged message is sent twice during a firewalld restart - once when the old firewalld is stopped, and again when the new firewalld is started. If we try to reload at the point the old firewalld is stopped, none of the firewalld dbus calls will succeed. The solution is to check the new_owner field of the message - we should reload our firewall rules only if new_owner is non-empty (it is set to "" when firewalld is stopped, and some sort of epoch number when it is again started). Signed-off-by: Laine Stump <laine(a)laine.org> --- src/network/bridge_driver.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 4d4ab0f375..167c142ae2 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -549,8 +549,23 @@ firewalld_dbus_filter_bridge(DBusConnection *connection ATTRIBUTE_UNUSED, dbus_message_is_signal(message, "org.fedoraproject.FirewallD1", "Reloaded")) { - VIR_DEBUG("Reload in bridge_driver because of firewalld."); - networkReloadFirewallRules(driver, false); + VIR_AUTOFREE(char *) name = NULL; + VIR_AUTOFREE(char *) old_owner = NULL; + VIR_AUTOFREE(char *) new_owner = NULL; + + if (virDBusMessageDecode(message, "sss", &name, &old_owner, &new_owner) < 0) { + VIR_WARN("Failed to decode DBus NameOwnerChanged message"); + return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; + } + + /* + * if new_owner is empty, firewalld is shutting down. If it is + * non-empty, then it is starting + */ + if (new_owner && *new_owner) { + VIR_DEBUG("Reload in bridge_driver because of firewalld."); + networkReloadFirewallRules(driver, false); + } } return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; -- 2.20.1

2 2

[libvirt] [PATCH] network: clear cached error if we successfully create firewall chains
by Daniel P. Berrangé 12 Apr '19

12 Apr '19

Since: commit 9f4e35dc73ec9e940aa61bc7c140c2b800218ef3 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Mon Mar 18 17:31:21 2019 +0000 network: improve error report when firewall chain creation fails We cache an error when failing to create the top level firewall chains. This commit failed to account for fact that we may invoke networkPreReloadFirewallRules() many times while libvirtd is running. For example when firewalld is restarted. When this happens the original failure may no longer occurr and we'll successfully create our top level chains. We failed to clear the cached error resulting in us failing to start virtual networks. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/network/bridge_driver_linux.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 50fc197134..f2827543ca 100644 --- a/src/network/bridge_driver_linux.c +++ b/src/network/bridge_driver_linux.c @@ -55,6 +55,9 @@ void networkPreReloadFirewallRules(bool startup) if (rc < 0) { errInitV4 = virSaveLastError(); virResetLastError(); + } else { + virFreeError(errInitV4); + errInitV4 = NULL; } if (rc) created = true; @@ -63,6 +66,9 @@ void networkPreReloadFirewallRules(bool startup) if (rc < 0) { errInitV6 = virSaveLastError(); virResetLastError(); + } else { + virFreeError(errInitV6); + errInitV6 = NULL; } if (rc) created = true; -- 2.20.1

2 1

[libvirt] [PATCH] qemu: Label uniqDir when probing capabilities
by Martin Kletzander 12 Apr '19

12 Apr '19

This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue because the directory is created with mkdtemp(3) which explicitly creates that with 0700 permissions and qemu running as non-root cannot access that. The scenarios include: - Builds without CAPNG - Running libvirtd in a container [1] - and possibly others. [1] https://github.com/kubevirt/kubevirt/pull/2181#issuecomment-481840304 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_process.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 47d8ca2ff163..2e2c4812fef7 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8447,6 +8447,19 @@ qemuProcessQMPNew(const char *binary, } +static int +qemuProcessQEMULabelUniqPath(qemuProcessQMPPtr proc) { + /* We cannot use the security driver here, but we should not need to. */ + if (chown(proc->uniqDir, proc->runUid, -1) < 0) { + virReportSystemError(errno, + "Cannot chown uniq path: %s", proc->uniqDir); + return -1; + } + + return 0; +} + + static int qemuProcessQMPInit(qemuProcessQMPPtr proc) { @@ -8466,6 +8479,9 @@ qemuProcessQMPInit(qemuProcessQMPPtr proc) goto cleanup; } + if (qemuProcessQEMULabelUniqPath(proc) < 0) + goto cleanup; + if (virAsprintf(&proc->monpath, "%s/%s", proc->uniqDir, "qmp.monitor") < 0) goto cleanup; -- 2.21.0

2 5

[libvirt] [jenkins-ci PATCH 0/2] guests: Remove readline symlink kludge
by Andrea Bolognani 12 Apr '19

12 Apr '19

The last remaining one! \o/ Andrea Bolognani (2): guests: Install ncurses for libvirt guests: Remove readline symlink kludge guests/playbooks/update/tasks/kludges.yml | 14 -------------- guests/vars/mappings.yml | 8 ++++++++ guests/vars/projects/libvirt.yml | 1 + 3 files changed, 9 insertions(+), 14 deletions(-) -- 2.20.1

2 5

[libvirt] [PATCH v2] maint: Add filetype annotations to Makefile.inc.am
by Andrea Bolognani 12 Apr '19

12 Apr '19

Vim has trouble figuring out the filetype automatically because the name doesn't follow existing conventions; annotations like the ones we already have in Makefile.ci help it out. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Changes from [v1]: * drop emacs annotation; * switch from filetype=make to filetype=automake. [v1] https://www.redhat.com/archives/libvir-list/2019-April/msg00867.html src/access/Makefile.inc.am | 2 ++ src/admin/Makefile.inc.am | 2 ++ src/bhyve/Makefile.inc.am | 2 ++ src/conf/Makefile.inc.am | 2 ++ src/cpu/Makefile.inc.am | 2 ++ src/cpu_map/Makefile.inc.am | 2 ++ src/esx/Makefile.inc.am | 2 ++ src/hyperv/Makefile.inc.am | 2 ++ src/interface/Makefile.inc.am | 2 ++ src/libxl/Makefile.inc.am | 2 ++ src/locking/Makefile.inc.am | 2 ++ src/logging/Makefile.inc.am | 2 ++ src/lxc/Makefile.inc.am | 2 ++ src/network/Makefile.inc.am | 2 ++ src/node_device/Makefile.inc.am | 2 ++ src/nwfilter/Makefile.inc.am | 2 ++ src/openvz/Makefile.inc.am | 2 ++ src/phyp/Makefile.inc.am | 2 ++ src/qemu/Makefile.inc.am | 2 ++ src/remote/Makefile.inc.am | 2 ++ src/rpc/Makefile.inc.am | 2 ++ src/secret/Makefile.inc.am | 2 ++ src/security/Makefile.inc.am | 2 ++ src/storage/Makefile.inc.am | 2 ++ src/test/Makefile.inc.am | 2 ++ src/util/Makefile.inc.am | 2 ++ src/vbox/Makefile.inc.am | 2 ++ src/vmware/Makefile.inc.am | 2 ++ src/vmx/Makefile.inc.am | 2 ++ src/vz/Makefile.inc.am | 2 ++ src/xenapi/Makefile.inc.am | 2 ++ src/xenconfig/Makefile.inc.am | 2 ++ 32 files changed, 64 insertions(+) diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am index 6d57ca1a1b..4dc742f4e5 100644 --- a/src/access/Makefile.inc.am +++ b/src/access/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ACCESS_DRIVER_GENERATED = \ access/viraccessapicheck.h \ access/viraccessapicheck.c \ diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am index 19afb0e179..4cc588a47c 100644 --- a/src/admin/Makefile.inc.am +++ b/src/admin/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ADMIN_PROTOCOL = $(srcdir)/admin/admin_protocol.x ADMIN_PROTOCOL_GENERATED = \ diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am index fba1b9ef30..36af5d7504 100644 --- a/src/bhyve/Makefile.inc.am +++ b/src/bhyve/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + BHYVE_DRIVER_SOURCES = \ bhyve/bhyve_capabilities.c \ bhyve/bhyve_capabilities.h \ diff --git a/src/conf/Makefile.inc.am b/src/conf/Makefile.inc.am index 6eb64db9de..3e9fdd1aea 100644 --- a/src/conf/Makefile.inc.am +++ b/src/conf/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NETDEV_CONF_SOURCES = \ conf/netdev_bandwidth_conf.h \ conf/netdev_bandwidth_conf.c \ diff --git a/src/cpu/Makefile.inc.am b/src/cpu/Makefile.inc.am index 5020d40583..0abeee87b6 100644 --- a/src/cpu/Makefile.inc.am +++ b/src/cpu/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + CPU_SOURCES = \ cpu/cpu.h \ cpu/cpu.c \ diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 9d7cef15c5..5634dd9348 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + cpumapdir = $(pkgdatadir)/cpu_map cpumap_DATA = \ cpu_map/index.xml \ diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am index 152dd7b979..2d55c6573c 100644 --- a/src/esx/Makefile.inc.am +++ b/src/esx/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ESX_DRIVER_SOURCES = \ esx/esx_private.h \ esx/esx_driver.c \ diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am index a768272b72..51be8bcacc 100644 --- a/src/hyperv/Makefile.inc.am +++ b/src/hyperv/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + HYPERV_DRIVER_SOURCES = \ hyperv/hyperv_private.h \ hyperv/hyperv_driver.c \ diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am index 08b35d040d..339a92786b 100644 --- a/src/interface/Makefile.inc.am +++ b/src/interface/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + INTERFACE_DRIVER_SOURCES = \ interface/interface_driver.h \ interface/interface_driver.c \ diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am index 59c136bf4e..7f60b449d8 100644 --- a/src/libxl/Makefile.inc.am +++ b/src/libxl/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LIBXL_DRIVER_SOURCES = \ libxl/libxl_conf.c \ libxl/libxl_conf.h \ diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index 5d5e923769..da26fab91f 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + DRIVER_SOURCES += \ locking/lock_manager.c \ locking/lock_manager.h \ diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index 3f4a87d91a..f5eba2a4f7 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LOG_PROTOCOL_GENERATED = \ logging/log_protocol.h \ logging/log_protocol.c \ diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index 8dd2e9ea9e..f27827c1e9 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LXC_MONITOR_PROTOCOL_GENERATED = \ lxc/lxc_monitor_protocol.h \ lxc/lxc_monitor_protocol.c \ diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index cbaaa7ea68..3fed59c13b 100644 --- a/src/network/Makefile.inc.am +++ b/src/network/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NETWORK_DRIVER_SOURCES = \ network/bridge_driver.h \ network/bridge_driver.c \ diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am index 0c3ad51273..3e04651e8c 100644 --- a/src/node_device/Makefile.inc.am +++ b/src/node_device/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NODE_DEVICE_DRIVER_SOURCES = \ node_device/node_device_driver.c \ node_device/node_device_driver.h \ diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am index 27aa801095..810ca54bcc 100644 --- a/src/nwfilter/Makefile.inc.am +++ b/src/nwfilter/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NWFILTER_DRIVER_SOURCES = \ nwfilter/nwfilter_driver.h \ nwfilter/nwfilter_driver.c \ diff --git a/src/openvz/Makefile.inc.am b/src/openvz/Makefile.inc.am index baad737362..93bf3b9c96 100644 --- a/src/openvz/Makefile.inc.am +++ b/src/openvz/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + OPENVZ_DRIVER_SOURCES = \ openvz/openvz_conf.c \ openvz/openvz_conf.h \ diff --git a/src/phyp/Makefile.inc.am b/src/phyp/Makefile.inc.am index 496ff25266..315f1c36ee 100644 --- a/src/phyp/Makefile.inc.am +++ b/src/phyp/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + PHYP_DRIVER_SOURCES = \ phyp/phyp_driver.c \ phyp/phyp_driver.h \ diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 8d10e1085a..fd32a90d56 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + QEMU_DRIVER_SOURCES = \ qemu/qemu_agent.c \ qemu/qemu_agent.h \ diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 13a1f9f8f2..06714249b4 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + REMOTE_DRIVER_GENERATED = \ remote/remote_protocol.c \ remote/remote_protocol.h \ diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am index 722ef64db1..68a4945198 100644 --- a/src/rpc/Makefile.inc.am +++ b/src/rpc/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + EXTRA_DIST += \ rpc/gendispatch.pl \ rpc/genprotocol.pl \ diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am index 79c2b2d74a..7a1c8f8e1a 100644 --- a/src/secret/Makefile.inc.am +++ b/src/secret/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + SECRET_DRIVER_SOURCES = \ secret/secret_driver.h \ secret/secret_driver.c \ diff --git a/src/security/Makefile.inc.am b/src/security/Makefile.inc.am index b24cdfd083..7fb6d8cc4f 100644 --- a/src/security/Makefile.inc.am +++ b/src/security/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + SECURITY_DRIVER_APPARMOR_HELPER_SOURCES = \ $(DATATYPES_SOURCES) \ security/virt-aa-helper.c \ diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index b4400b556f..ea4681f70e 100644 --- a/src/storage/Makefile.inc.am +++ b/src/storage/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + STORAGE_DRIVER_BACKEND_SOURCES = \ storage/storage_backend.h \ storage/storage_backend.c \ diff --git a/src/test/Makefile.inc.am b/src/test/Makefile.inc.am index d52c281545..c20541a368 100644 --- a/src/test/Makefile.inc.am +++ b/src/test/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + TEST_DRIVER_SOURCES = \ test/test_driver.c \ test/test_driver.h \ diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index 58874cca3c..f44d3b3b2a 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + # These files are not related to driver APIs. Simply generic # helper APIs for various purposes UTIL_SOURCES = \ diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am index 8c76f84e82..15f7b78416 100644 --- a/src/vbox/Makefile.inc.am +++ b/src/vbox/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VBOX_DRIVER_SOURCES = \ vbox/vbox_glue.c \ vbox/vbox_glue.h \ diff --git a/src/vmware/Makefile.inc.am b/src/vmware/Makefile.inc.am index 0fbf866030..2c8c2d9884 100644 --- a/src/vmware/Makefile.inc.am +++ b/src/vmware/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VMWARE_DRIVER_SOURCES = \ vmware/vmware_driver.c \ vmware/vmware_driver.h \ diff --git a/src/vmx/Makefile.inc.am b/src/vmx/Makefile.inc.am index b9bf6ef690..429bdfe51e 100644 --- a/src/vmx/Makefile.inc.am +++ b/src/vmx/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VMX_SOURCES = \ vmx/vmx.c \ vmx/vmx.h \ diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am index cacdb38795..a3a146c627 100644 --- a/src/vz/Makefile.inc.am +++ b/src/vz/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VZ_DRIVER_SOURCES = \ vz/vz_driver.h \ vz/vz_driver.c \ diff --git a/src/xenapi/Makefile.inc.am b/src/xenapi/Makefile.inc.am index 4640e9943f..b6e4ed0bdb 100644 --- a/src/xenapi/Makefile.inc.am +++ b/src/xenapi/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + XENAPI_DRIVER_SOURCES = \ xenapi/xenapi_driver.c \ xenapi/xenapi_driver.h \ diff --git a/src/xenconfig/Makefile.inc.am b/src/xenconfig/Makefile.inc.am index a87d69990f..cd751029d2 100644 --- a/src/xenconfig/Makefile.inc.am +++ b/src/xenconfig/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + XENCONFIG_SOURCES = \ xenconfig/xenxs_private.h \ xenconfig/xen_common.c \ -- 2.20.1

2 1

[libvirt] RFC: remove qemu commandline parsing?
by Cole Robinson 12 Apr '19

12 Apr '19

qemu/qemu_parse_command.c powers 'sudo virsh domxml-from-native qemu-argv', parsing a qemu command line and attempting to turn it into libvirt domain XML. Some history: RFE: https://www.redhat.com/archives/libvir-list/2009-April/msg00266.html Patches: https://www.redhat.com/archives/libvir-list/2009-May/msg00321.html danpb blog post about related qemu-attach: https://www.berrange.com/posts/2011/07/13/attaching-libvirt-to-an-externall… At the time it was added, the parser was pretty comprehensive WRT to what libvirt XML features were available at the time. However it's quite hopelessly out of date these days and has been for a long time. As an example, the only -device it knows to parse is virtio-balloon, and it doesn't know anything about -netdev. So the parser can really only handle typical old style qemu options. AFAICT The original motivation for adding this and qemu-attach was providing a more straightforward path for direct qemu users to switch to libvirt. Googling does provide some cases of users successfully converting very simple qemu invocations to libvirt XML. But at least from my experience I don't think these features every really moved the needle in this respect. If anything, it's been that managing qemu has only grown more complex over time, which has made libvirt and tools that use it all the more compelling over launching your own qemu command line (for end users, think manually setting up usb2 with qemu directly). But IMO all that is kind of beside the point. I don't think it's debatable that the code is largely unused, and it hasn't seen many material improvements in the last 5 years, with zero plans to improve it on the horizon. It's 2000+ lines of text processing code living in every libvirtd instance. Deleting it all and making the qemu_driver.c APIs just return errors seems like an easy win considering we are trying to make libvirtd more modular and have a smaller footprint to facilitate usecases like kubevirt Thoughts? - Cole

4 3

[libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am
by Andrea Bolognani 12 Apr '19

12 Apr '19

Both vim and emacs have trouble figuring out the filetype automatically because the name doesn't follow existing conventions; annotations like the ones we already have in Makefile.ci help them out. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/access/Makefile.inc.am | 3 +++ src/admin/Makefile.inc.am | 3 +++ src/bhyve/Makefile.inc.am | 3 +++ src/conf/Makefile.inc.am | 3 +++ src/cpu/Makefile.inc.am | 3 +++ src/cpu_map/Makefile.inc.am | 3 +++ src/esx/Makefile.inc.am | 3 +++ src/hyperv/Makefile.inc.am | 3 +++ src/interface/Makefile.inc.am | 3 +++ src/libxl/Makefile.inc.am | 3 +++ src/locking/Makefile.inc.am | 3 +++ src/logging/Makefile.inc.am | 3 +++ src/lxc/Makefile.inc.am | 3 +++ src/network/Makefile.inc.am | 3 +++ src/node_device/Makefile.inc.am | 3 +++ src/nwfilter/Makefile.inc.am | 3 +++ src/openvz/Makefile.inc.am | 3 +++ src/phyp/Makefile.inc.am | 3 +++ src/qemu/Makefile.inc.am | 3 +++ src/remote/Makefile.inc.am | 3 +++ src/rpc/Makefile.inc.am | 3 +++ src/secret/Makefile.inc.am | 3 +++ src/security/Makefile.inc.am | 3 +++ src/storage/Makefile.inc.am | 3 +++ src/test/Makefile.inc.am | 3 +++ src/util/Makefile.inc.am | 3 +++ src/vbox/Makefile.inc.am | 3 +++ src/vmware/Makefile.inc.am | 3 +++ src/vmx/Makefile.inc.am | 3 +++ src/vz/Makefile.inc.am | 3 +++ src/xenapi/Makefile.inc.am | 3 +++ src/xenconfig/Makefile.inc.am | 3 +++ 32 files changed, 96 insertions(+) diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am index 6d57ca1a1b..5233a6fc08 100644 --- a/src/access/Makefile.inc.am +++ b/src/access/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ACCESS_DRIVER_GENERATED = \ access/viraccessapicheck.h \ access/viraccessapicheck.c \ diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am index 19afb0e179..d3300d57ff 100644 --- a/src/admin/Makefile.inc.am +++ b/src/admin/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ADMIN_PROTOCOL = $(srcdir)/admin/admin_protocol.x ADMIN_PROTOCOL_GENERATED = \ diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am index fba1b9ef30..ebd576f334 100644 --- a/src/bhyve/Makefile.inc.am +++ b/src/bhyve/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + BHYVE_DRIVER_SOURCES = \ bhyve/bhyve_capabilities.c \ bhyve/bhyve_capabilities.h \ diff --git a/src/conf/Makefile.inc.am b/src/conf/Makefile.inc.am index 6eb64db9de..2040220378 100644 --- a/src/conf/Makefile.inc.am +++ b/src/conf/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NETDEV_CONF_SOURCES = \ conf/netdev_bandwidth_conf.h \ conf/netdev_bandwidth_conf.c \ diff --git a/src/cpu/Makefile.inc.am b/src/cpu/Makefile.inc.am index 5020d40583..3508158fab 100644 --- a/src/cpu/Makefile.inc.am +++ b/src/cpu/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + CPU_SOURCES = \ cpu/cpu.h \ cpu/cpu.c \ diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 9d7cef15c5..39d98f8ce7 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + cpumapdir = $(pkgdatadir)/cpu_map cpumap_DATA = \ cpu_map/index.xml \ diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am index 152dd7b979..95846baea5 100644 --- a/src/esx/Makefile.inc.am +++ b/src/esx/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ESX_DRIVER_SOURCES = \ esx/esx_private.h \ esx/esx_driver.c \ diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am index a768272b72..e5cc06bab7 100644 --- a/src/hyperv/Makefile.inc.am +++ b/src/hyperv/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + HYPERV_DRIVER_SOURCES = \ hyperv/hyperv_private.h \ hyperv/hyperv_driver.c \ diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am index 08b35d040d..d1c59fa75b 100644 --- a/src/interface/Makefile.inc.am +++ b/src/interface/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + INTERFACE_DRIVER_SOURCES = \ interface/interface_driver.h \ interface/interface_driver.c \ diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am index 59c136bf4e..86dfb176ca 100644 --- a/src/libxl/Makefile.inc.am +++ b/src/libxl/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LIBXL_DRIVER_SOURCES = \ libxl/libxl_conf.c \ libxl/libxl_conf.h \ diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index 5d5e923769..1d75223106 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + DRIVER_SOURCES += \ locking/lock_manager.c \ locking/lock_manager.h \ diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index 3f4a87d91a..05ec5aa197 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LOG_PROTOCOL_GENERATED = \ logging/log_protocol.h \ logging/log_protocol.c \ diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index 8dd2e9ea9e..a5b00a830d 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LXC_MONITOR_PROTOCOL_GENERATED = \ lxc/lxc_monitor_protocol.h \ lxc/lxc_monitor_protocol.c \ diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index cbaaa7ea68..ae546be0c2 100644 --- a/src/network/Makefile.inc.am +++ b/src/network/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NETWORK_DRIVER_SOURCES = \ network/bridge_driver.h \ network/bridge_driver.c \ diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am index 0c3ad51273..c2255bd845 100644 --- a/src/node_device/Makefile.inc.am +++ b/src/node_device/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NODE_DEVICE_DRIVER_SOURCES = \ node_device/node_device_driver.c \ node_device/node_device_driver.h \ diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am index 27aa801095..aabfccd654 100644 --- a/src/nwfilter/Makefile.inc.am +++ b/src/nwfilter/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NWFILTER_DRIVER_SOURCES = \ nwfilter/nwfilter_driver.h \ nwfilter/nwfilter_driver.c \ diff --git a/src/openvz/Makefile.inc.am b/src/openvz/Makefile.inc.am index baad737362..f88660ee7b 100644 --- a/src/openvz/Makefile.inc.am +++ b/src/openvz/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + OPENVZ_DRIVER_SOURCES = \ openvz/openvz_conf.c \ openvz/openvz_conf.h \ diff --git a/src/phyp/Makefile.inc.am b/src/phyp/Makefile.inc.am index 496ff25266..2e213413a3 100644 --- a/src/phyp/Makefile.inc.am +++ b/src/phyp/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + PHYP_DRIVER_SOURCES = \ phyp/phyp_driver.c \ phyp/phyp_driver.h \ diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 8d10e1085a..59b970c077 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + QEMU_DRIVER_SOURCES = \ qemu/qemu_agent.c \ qemu/qemu_agent.h \ diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 13a1f9f8f2..26e2091434 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + REMOTE_DRIVER_GENERATED = \ remote/remote_protocol.c \ remote/remote_protocol.h \ diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am index 722ef64db1..50bdde5d9f 100644 --- a/src/rpc/Makefile.inc.am +++ b/src/rpc/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + EXTRA_DIST += \ rpc/gendispatch.pl \ rpc/genprotocol.pl \ diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am index 79c2b2d74a..fa377578ea 100644 --- a/src/secret/Makefile.inc.am +++ b/src/secret/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + SECRET_DRIVER_SOURCES = \ secret/secret_driver.h \ secret/secret_driver.c \ diff --git a/src/security/Makefile.inc.am b/src/security/Makefile.inc.am index b24cdfd083..6d1f749b49 100644 --- a/src/security/Makefile.inc.am +++ b/src/security/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + SECURITY_DRIVER_APPARMOR_HELPER_SOURCES = \ $(DATATYPES_SOURCES) \ security/virt-aa-helper.c \ diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index b4400b556f..a68e58f065 100644 --- a/src/storage/Makefile.inc.am +++ b/src/storage/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + STORAGE_DRIVER_BACKEND_SOURCES = \ storage/storage_backend.h \ storage/storage_backend.c \ diff --git a/src/test/Makefile.inc.am b/src/test/Makefile.inc.am index d52c281545..8d2201f352 100644 --- a/src/test/Makefile.inc.am +++ b/src/test/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + TEST_DRIVER_SOURCES = \ test/test_driver.c \ test/test_driver.h \ diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index 58874cca3c..ccdca2263f 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + # These files are not related to driver APIs. Simply generic # helper APIs for various purposes UTIL_SOURCES = \ diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am index 8c76f84e82..2cabe96c1c 100644 --- a/src/vbox/Makefile.inc.am +++ b/src/vbox/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VBOX_DRIVER_SOURCES = \ vbox/vbox_glue.c \ vbox/vbox_glue.h \ diff --git a/src/vmware/Makefile.inc.am b/src/vmware/Makefile.inc.am index 0fbf866030..6a1b565070 100644 --- a/src/vmware/Makefile.inc.am +++ b/src/vmware/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VMWARE_DRIVER_SOURCES = \ vmware/vmware_driver.c \ vmware/vmware_driver.h \ diff --git a/src/vmx/Makefile.inc.am b/src/vmx/Makefile.inc.am index b9bf6ef690..b15fe37e62 100644 --- a/src/vmx/Makefile.inc.am +++ b/src/vmx/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VMX_SOURCES = \ vmx/vmx.c \ vmx/vmx.h \ diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am index cacdb38795..8e53906cae 100644 --- a/src/vz/Makefile.inc.am +++ b/src/vz/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VZ_DRIVER_SOURCES = \ vz/vz_driver.h \ vz/vz_driver.c \ diff --git a/src/xenapi/Makefile.inc.am b/src/xenapi/Makefile.inc.am index 4640e9943f..2eee125ae2 100644 --- a/src/xenapi/Makefile.inc.am +++ b/src/xenapi/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + XENAPI_DRIVER_SOURCES = \ xenapi/xenapi_driver.c \ xenapi/xenapi_driver.h \ diff --git a/src/xenconfig/Makefile.inc.am b/src/xenconfig/Makefile.inc.am index a87d69990f..861e1c69ce 100644 --- a/src/xenconfig/Makefile.inc.am +++ b/src/xenconfig/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + XENCONFIG_SOURCES = \ xenconfig/xenxs_private.h \ xenconfig/xen_common.c \ -- 2.20.1

2 3

[libvirt] [PATCH v2 0/7] readline: Drop obsolete code, add pkg-config support
by Andrea Bolognani 12 Apr '19

12 Apr '19

Changes from [v1]: * ensure macOS builds don't break by picking up libedit instead of readline. [v1] https://www.redhat.com/archives/libvir-list/2019-April/msg00632.html Andrea Bolognani (7): tools: vsh: Drop obsolete readline compatibility code m4: readline: Fix indentation m4: readline: Comment rl_completion_quote_character() check m4: readline: Extract code setting -D_FUNCTION_DEF m4: readline: Drop extra_LIBS machinery m4: readline: Use pkg-config where possible m4: readline: Add gross kludge for include path m4/virt-readline.m4 | 85 +++++++++++++++++++++++++++------------------ tools/vsh.c | 17 --------- 2 files changed, 51 insertions(+), 51 deletions(-) -- 2.20.1

2 14

[libvirt] [PATCH] lib: Don't use virReportSystemError() if virCommandRun() fails
by Michal Privoznik 12 Apr '19

12 Apr '19

Firstly, virCommandRun() does report an error on failure (which in most cases is more accurate than what we overwrite it with). Secondly, usually errno is not set (or gets overwritten in the cleanup code) which makes virReportSystemError() report useless error messages. Drop all virReportSystemError() calls in cases like this (I've found three occurrences). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I was under impression that I've sent this one earlier. Well, maybe I did not. src/storage/storage_backend_fs.c | 7 +------ src/util/virdnsmasq.c | 10 ++-------- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 97148acebe..ae4e9a03a3 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -425,13 +425,8 @@ virStorageBackendExecuteMKFS(const char *device, virCommandAddArg(cmd, device); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, - _("Failed to make filesystem of " - "type '%s' on device '%s'"), - format, device); + if (virCommandRun(cmd, NULL) < 0) return -1; - } return 0; } diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index 550f3179ae..42f62682c4 100644 --- a/src/util/virdnsmasq.c +++ b/src/util/virdnsmasq.c @@ -751,22 +751,16 @@ dnsmasqCapsRefreshInternal(dnsmasqCapsPtr caps, bool force) virCommandSetOutputBuffer(cmd, &version); virCommandAddEnvPassCommon(cmd); virCommandClearCaps(cmd); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, _("failed to run '%s --version': %s"), - caps->binaryPath, version); + if (virCommandRun(cmd, NULL) < 0) goto cleanup; - } virCommandFree(cmd); cmd = virCommandNewArgList(caps->binaryPath, "--help", NULL); virCommandSetOutputBuffer(cmd, &help); virCommandAddEnvPassCommon(cmd); virCommandClearCaps(cmd); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, _("failed to run '%s --help': %s"), - caps->binaryPath, help); + if (virCommandRun(cmd, NULL) < 0) goto cleanup; - } if (virAsprintf(&complete, "%s\n%s", version, help) < 0) goto cleanup; -- 2.21.0

2 1