- Devel - libvirt List Archives

[libvirt] [PATCH] virsh: Add virshDomainShutdownModeCompleter
by Michal Privoznik 10 Apr '19

10 Apr '19

This completer is used to offer shutdown/reboot modes. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-completer.c | 56 +++++++++++++++++++++++++++++++++++++++++ tools/virsh-completer.h | 4 +++ tools/virsh-domain.c | 2 ++ 3 files changed, 62 insertions(+) diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c index aac4579d1f..918e409890 100644 --- a/tools/virsh-completer.c +++ b/tools/virsh-completer.c @@ -936,3 +936,59 @@ virshDomainDeviceAliasCompleter(vshControl *ctl, VIR_STEAL_PTR(ret, tmp); return ret; } + + +char ** +virshDomainShutdownModeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags) +{ + const char *modes[] = {"acpi", "agent", "initctl", "signal", "paravirt"}; + size_t i; + char **ret = NULL; + size_t ntmp = 0; + VIR_AUTOSTRINGLIST tmp = NULL; + const char *modeConst = NULL; + VIR_AUTOFREE(char *) mode = NULL; + VIR_AUTOSTRINGLIST modesSpecified = NULL; + + virCheckFlags(0, NULL); + + if (vshCommandOptStringQuiet(ctl, cmd, "mode", &modeConst) < 0) + return NULL; + + if (STREQ_NULLABLE(modeConst, " ")) + modeConst = NULL; + + if (modeConst) { + char *modeTmp = NULL; + + if (VIR_STRDUP(mode, modeConst) < 0) + return NULL; + + if ((modeTmp = strrchr(mode, ','))) + *modeTmp = '\0'; + else + VIR_FREE(mode); + } + + if (mode && !(modesSpecified = virStringSplit(mode, ",", 0))) + return NULL; + + if (VIR_ALLOC_N(tmp, ARRAY_CARDINALITY(modes) + 1) < 0) + return NULL; + + for (i = 0; i < ARRAY_CARDINALITY(modes); i++) { + if (virStringListHasString((const char **)modesSpecified, modes[i])) + continue; + + if ((mode && virAsprintf(&tmp[ntmp], "%s,%s", mode, modes[i]) < 0) || + (!mode && VIR_STRDUP(tmp[ntmp], modes[i]) < 0)) + return NULL; + + ntmp++; + } + + VIR_STEAL_PTR(ret, tmp); + return ret; +} diff --git a/tools/virsh-completer.h b/tools/virsh-completer.h index 2e2e1edafb..ed37a26cc9 100644 --- a/tools/virsh-completer.h +++ b/tools/virsh-completer.h @@ -110,4 +110,8 @@ char ** virshDomainDeviceAliasCompleter(vshControl *ctl, char ** virshCellnoCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** virshDomainShutdownModeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); #endif /* LIBVIRT_VIRSH_COMPLETER_H */ diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index e8d5404acf..a8a0b2f20d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5829,6 +5829,7 @@ static const vshCmdOptDef opts_shutdown[] = { VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name = "mode", .type = VSH_OT_STRING, + .completer = virshDomainShutdownModeCompleter, .help = N_("shutdown mode: acpi|agent|initctl|signal|paravirt") }, {.name = NULL} @@ -5913,6 +5914,7 @@ static const vshCmdOptDef opts_reboot[] = { VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name = "mode", .type = VSH_OT_STRING, + .completer = virshDomainShutdownModeCompleter, .help = N_("shutdown mode: acpi|agent|initctl|signal|paravirt") }, {.name = NULL} -- 2.21.0

2 1

[libvirt] [PATCH] security: apparmor: make vhost-net access a static rule
by Christian Ehrhardt 10 Apr '19

10 Apr '19

So far we were detecting at guest start if any devices needed vhost net and only if that was true added a rule for /dev/vhost-net. It turns out that it is an absolutely valid case to start a guest without any vhost-net networking but later on wanting to hotplug such a device which then would be denied by apparmor. Unfortunately there also is no security labeling callback involved other than the one to /dev/net/tun. But on the other hand vhost-net is no more new and considered rather safe. Therefore drop the old detection and just add it as a static rule. Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1815910 Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- src/security/apparmor/libvirt-qemu | 1 + src/security/virt-aa-helper.c | 17 +---------------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index eaa5167525..a71f34c175 100644 --- a/src/security/apparmor/libvirt-qemu +++ b/src/security/apparmor/libvirt-qemu @@ -21,6 +21,7 @@ signal (receive) peer=/usr/sbin/libvirtd, /dev/net/tun rw, + /dev/vhost-net rw, /dev/kvm rw, /dev/ptmx rw, /dev/kqemu rw, diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 8e22e9978a..ebc4feac77 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -937,7 +937,7 @@ get_files(vahControl * ctl) size_t i; char *uuid; char uuidstr[VIR_UUID_STRING_BUFLEN]; - bool needsVfio = false, needsvhost = false; + bool needsVfio = false; /* verify uuid is same as what we were given on the command line */ virUUIDFormat(ctl->def->uuid, uuidstr); @@ -1248,21 +1248,6 @@ get_files(vahControl * ctl) } } - if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) { - for (i = 0; i < ctl->def->nnets; i++) { - virDomainNetDefPtr net = ctl->def->nets[i]; - if (net && net->model) { - if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU) - continue; - if (!virDomainNetIsVirtioModel(net)) - continue; - } - needsvhost = true; - } - } - if (needsvhost) - virBufferAddLit(&buf, " \"/dev/vhost-net\" rw,\n"); - if (needsVfio) { virBufferAddLit(&buf, " \"/dev/vfio/vfio\" rw,\n"); virBufferAddLit(&buf, " \"/dev/vfio/[0-9]*\" rw,\n"); -- 2.17.1

2 5

[libvirt] [PATCH] qemuHotplugDiskSourceDataFree: also free backends
by Ján Tomko 10 Apr '19

10 Apr '19

Also free the backends array, not just its members. Fixes: d3f9dda2c9fd9fa7d2f7f1f1dd70ed7d83938101 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_hotplug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 34249bd030..540befba68 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -512,6 +512,7 @@ qemuHotplugDiskSourceDataFree(qemuHotplugDiskSourceDataPtr data) for (i = 0; i < data->nbackends; i++) qemuBlockStorageSourceAttachDataFree(data->backends[i]); + VIR_FREE(data->backends); VIR_FREE(data); } -- 2.19.2

2 1

[libvirt] [PATCH 00/11] A selection of refactors and improvements from the blockdev-add saga
by Peter Krempa 10 Apr '19

10 Apr '19

Few patches require https://www.redhat.com/archives/libvir-list/2019-April/msg00324.html to be applied. This is a collection of cleanups and improvements from my blockdev branch which make sense even without the rest of the blockdev patches. Peter Krempa (11): qemu: block: Introduce and use AUTOPTR func for qemuBlockStorageSourceAttachDataPtr qemu: block: Use VIR_AUTOPTR for virJSONValue util: uri: Introduce VIR_AUTOPTR freeing function qemu: block: Use VIR_AUTOPTR for virURIPtr qemu: block: Use VIR_AUTOPTR for virHashTablePtr qemu: block: Use VIR_AUTOFREE for char * qemu: block: Add and use AUTOPTR func for qemuBlockNodeNameBackingChainData qemu: block: Remove unneeded cleanup jumps internal: Introduce VIR_RETURN_PTR qemu: block: Use VIR_RETURN_PTR util: json: Use VIR_APPEND_ELEMENT in virJSONValueObjectAppend src/internal.h | 15 ++ src/qemu/qemu_block.c | 388 +++++++++++++------------------------- src/qemu/qemu_block.h | 3 + src/qemu/qemu_command.c | 14 +- src/qemu/qemu_hotplug.c | 9 +- src/qemu/qemu_migration.c | 3 +- src/util/virjson.c | 19 +- src/util/viruri.h | 2 + 8 files changed, 172 insertions(+), 281 deletions(-) -- 2.20.1

2 22

[libvirt] [PATCH] tests: Fix MinGW build for domaincapstest
by Andrea Bolognani 10 Apr '19

10 Apr '19

Commit 5b9819eedc71 started using the virFileWrapper APIs in the test program, and correctly called them only in the section of code guarded by WITH_QEMU; however, a single call to the virFileWrapperClearPrefixes() function ended up in the hypervisor-agnostic section, causing a build failure on MinGW. Move the call to the QEMU-only section; while at it, also drop the virFileWrapperRemovePrefix() calls, which are entirely redundant since we'd drop all prefixes immediately afterwards anyway. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Another approach would be to simply drop the call to virFileWrapperClearPrefixes(), but there really is no point in removing prefixes one by one when we can just clear all of them in one fell swoop. tests/domaincapstest.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index 3ee95a4b58..a9922e1edb 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -451,9 +451,7 @@ mymain(void) "x86_64", VIR_DOMAIN_VIRT_KVM); virObjectUnref(cfg); - virFileWrapperRemovePrefix(SYSCONFDIR "/qemu/firmware"); - virFileWrapperRemovePrefix(PREFIX "/share/qemu/firmware"); - virFileWrapperRemovePrefix("/home/user/.config/qemu/firmware"); + virFileWrapperClearPrefixes(); #endif /* WITH_QEMU */ @@ -476,8 +474,6 @@ mymain(void) DO_TEST_BHYVE("fbuf", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); #endif /* WITH_BHYVE */ - virFileWrapperClearPrefixes(); - return ret; } -- 2.20.1

2 1

[libvirt] [PATCH 0/4] qemu: Honor memory mode='strict'
by Michal Privoznik 10 Apr '19

10 Apr '19

If there's a domain configured as: <currentMemory unit='MiB'>4096</currentMemory> <numatune> <memory mode='strict' nodeset='1'/> </numatune> but there is not enough memory on NUMA node 1 the domain will start successfully because we allow it to allocate memory from other nodes. This is a result of some previous fix (v1.2.7-rc1~91). However, I've tested my fix successfully on a NUMA machine with F29 and recent kernel. So the kernel bug I'm mentioning in 4/4 is probably fixed then and we can drop the workaround. Michal Prívozník (4): qemuSetupCpusetMems: Use VIR_AUTOFREE() qemuSetupCpusetMems: Create EMULATOR thread upfront qemu_cgroup: Make qemuSetupCpusetMems static qemuSetupCpusetCgroup: Set up cpuset.mems before execing qemu src/qemu/qemu_cgroup.c | 12 +++++++----- src/qemu/qemu_cgroup.h | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) -- 2.21.0

2 6

[libvirt] [PATCH v2 0/4] domain capabilities: Expose firmware auto selection feature
by Michal Privoznik 10 Apr '19

10 Apr '19

v2 of: https://www.redhat.com/archives/libvir-list/2019-April/msg00460.html diff to v1: - Expose 'secure' too - Switch to uint64_t for qemuFirmwareGetSupported() Michal Prívozník (4): qemu_firmware: Separate firmware loading into a function qemu_firmware: Separate machine and arch matching into a function qemu_firmware: Introduce qemuFirmwareGetSupported domain capabilities: Expose firmware auto selection feature docs/formatdomaincaps.html.in | 23 +++ docs/schemas/domaincaps.rng | 1 + src/conf/domain_capabilities.c | 3 + src/conf/domain_capabilities.h | 2 + src/qemu/qemu_capabilities.c | 35 +++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_firmware.c | 169 ++++++++++++++---- src/qemu/qemu_firmware.h | 10 ++ tests/Makefile.am | 4 +- .../qemu_1.7.0.x86_64.xml | 7 + .../qemu_2.12.0-virt.aarch64.xml | 6 + .../qemu_2.12.0.ppc64.xml | 4 + .../qemu_2.12.0.s390x.xml | 4 + .../qemu_2.12.0.x86_64.xml | 7 + .../qemu_2.6.0-virt.aarch64.xml | 6 + .../qemu_2.6.0.aarch64.xml | 4 + .../domaincapsschemadata/qemu_2.6.0.ppc64.xml | 4 + .../qemu_2.6.0.x86_64.xml | 7 + .../domaincapsschemadata/qemu_2.7.0.s390x.xml | 4 + .../qemu_2.8.0-tcg.x86_64.xml | 7 + .../domaincapsschemadata/qemu_2.8.0.s390x.xml | 4 + .../qemu_2.8.0.x86_64.xml | 7 + .../qemu_2.9.0-q35.x86_64.xml | 8 + .../qemu_2.9.0-tcg.x86_64.xml | 7 + .../qemu_2.9.0.x86_64.xml | 7 + .../domaincapsschemadata/qemu_3.0.0.s390x.xml | 4 + .../qemu_3.1.0.x86_64.xml | 7 + .../qemu_4.0.0.x86_64.xml | 7 + tests/domaincapstest.c | 16 ++ tests/qemufirmwaretest.c | 72 ++++++++ 31 files changed, 412 insertions(+), 36 deletions(-) -- 2.21.0

3 7

[libvirt] [PATCH] Revert "Include unistd.h directly by files using it"
by Peter Krempa 10 Apr '19

10 Apr '19

This reverts commit a5e16020907e91bca1b0ab6c4ee5dbbdcccf6a54. Getting rid of unistd.h from our headers will require more work than just fixing the broken mingw build. Revert it until I have a more complete proposal. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed under the build-breaker rule. src/conf/virnwfilterbindingobj.c | 2 -- src/libxl/libxl_domain.c | 1 - src/locking/lock_daemon_config.c | 2 -- src/locking/lock_driver_lockd.c | 2 -- src/logging/log_daemon_config.c | 2 -- src/lxc/lxc_conf.c | 2 -- src/lxc/lxc_fuse.c | 1 - src/network/leaseshelper.c | 1 - src/nwfilter/nwfilter_ebiptables_driver.c | 1 - src/qemu/qemu_domain.c | 1 - src/remote/remote_daemon_config.c | 2 -- src/security/security_dac.c | 1 - src/security/security_manager.c | 1 - src/storage/storage_file_fs.c | 1 - src/util/vircgroupv1.c | 1 - src/util/vircgroupv2.c | 1 - src/util/virnetdev.c | 1 - src/util/virnetdevip.c | 1 - src/util/virnetdevmacvlan.c | 2 -- src/util/virnetdevvportprofile.c | 2 -- src/util/virperf.c | 1 - src/util/virpidfile.c | 1 - src/util/virpolkit.c | 1 - src/util/virresctrl.c | 1 - src/util/virutil.h | 1 + tests/eventtest.c | 1 - tests/objecteventtest.c | 2 -- tests/scsihosttest.c | 1 - tests/vboxsnapshotxmltest.c | 1 - tests/virfiletest.c | 1 - tests/virfilewrapper.c | 1 - tests/virlockspacetest.c | 1 - tests/virnetdaemontest.c | 2 -- tests/virnetsockettest.c | 1 - tests/virnettlscontexttest.c | 1 - tests/virnettlshelpers.c | 1 - tests/virnettlssessiontest.c | 1 - tests/virscsitest.c | 1 - tests/virstoragetest.c | 1 - 39 files changed, 1 insertion(+), 48 deletions(-) diff --git a/src/conf/virnwfilterbindingobj.c b/src/conf/virnwfilterbindingobj.c index 56a9022fc5..68afb9c434 100644 --- a/src/conf/virnwfilterbindingobj.c +++ b/src/conf/virnwfilterbindingobj.c @@ -20,8 +20,6 @@ #include <config.h> -#include <unistd.h> - #include "viralloc.h" #include "virerror.h" #include "virstring.h" diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 935d3d86b9..287406d323 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -21,7 +21,6 @@ #include <config.h> #include <fcntl.h> -#include <unistd.h> #include "libxl_domain.h" #include "libxl_capabilities.h" diff --git a/src/locking/lock_daemon_config.c b/src/locking/lock_daemon_config.c index 9dc3d6e409..03feeb02a5 100644 --- a/src/locking/lock_daemon_config.c +++ b/src/locking/lock_daemon_config.c @@ -21,8 +21,6 @@ #include <config.h> -#include <unistd.h> - #include "lock_daemon_config.h" #include "virconf.h" #include "viralloc.h" diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c index 335180dafa..f6371f3050 100644 --- a/src/locking/lock_driver_lockd.c +++ b/src/locking/lock_driver_lockd.c @@ -21,8 +21,6 @@ #include <config.h> -#include <unistd.h> - #include "lock_driver.h" #include "virconf.h" #include "viralloc.h" diff --git a/src/logging/log_daemon_config.c b/src/logging/log_daemon_config.c index 626ef15403..ec6d0686f4 100644 --- a/src/logging/log_daemon_config.c +++ b/src/logging/log_daemon_config.c @@ -21,8 +21,6 @@ #include <config.h> -#include <unistd.h> - #include "log_daemon_config.h" #include "virconf.h" #include "viralloc.h" diff --git a/src/lxc/lxc_conf.c b/src/lxc/lxc_conf.c index a6be352b22..2e4cc4f51a 100644 --- a/src/lxc/lxc_conf.c +++ b/src/lxc/lxc_conf.c @@ -23,8 +23,6 @@ /* includes */ #include <config.h> -#include "unistd.h" - #include "lxc_conf.h" #include "lxc_domain.h" #include "virerror.h" diff --git a/src/lxc/lxc_fuse.c b/src/lxc/lxc_fuse.c index b647743206..4137d1b04f 100644 --- a/src/lxc/lxc_fuse.c +++ b/src/lxc/lxc_fuse.c @@ -23,7 +23,6 @@ #include <fcntl.h> #include <sys/mount.h> #include <mntent.h> -#include <unistd.h> #include "lxc_fuse.h" #include "lxc_cgroup.h" diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index af71e32499..4c23a55326 100644 --- a/src/network/leaseshelper.c +++ b/src/network/leaseshelper.c @@ -23,7 +23,6 @@ #include <config.h> -#include <unistd.h> #include "virthread.h" #include "virfile.h" diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 424daeb3c7..32bbf6d05c 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -25,7 +25,6 @@ #include <sys/stat.h> #include <fcntl.h> #include <sys/utsname.h> -#include <unistd.h> #include "internal.h" diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 58029ab20c..f0bf1aa4fe 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -64,7 +64,6 @@ #endif #include <sys/time.h> #include <fcntl.h> -#include <unistd.h> #if defined(HAVE_SYS_MOUNT_H) # include <sys/mount.h> #endif diff --git a/src/remote/remote_daemon_config.c b/src/remote/remote_daemon_config.c index 59f14bdbdc..a56aa9065a 100644 --- a/src/remote/remote_daemon_config.c +++ b/src/remote/remote_daemon_config.c @@ -21,8 +21,6 @@ #include <config.h> -#include <unistd.h> - #include "remote_daemon_config.h" #include "virconf.h" #include "viralloc.h" diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 5718557411..6f8ca8cd54 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -22,7 +22,6 @@ #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> -#include <unistd.h> #ifdef __FreeBSD__ # include <sys/sysctl.h> diff --git a/src/security/security_manager.c b/src/security/security_manager.c index 9bcd8f85ab..74ab0d0dd3 100644 --- a/src/security/security_manager.c +++ b/src/security/security_manager.c @@ -22,7 +22,6 @@ #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> -#include <unistd.h> #include "security_driver.h" #include "security_stack.h" diff --git a/src/storage/storage_file_fs.c b/src/storage/storage_file_fs.c index 1570170d0e..8817970f44 100644 --- a/src/storage/storage_file_fs.c +++ b/src/storage/storage_file_fs.c @@ -23,7 +23,6 @@ #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> -#include <unistd.h> #include "virerror.h" #include "storage_file_fs.h" diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c index 7482b96a27..6224072db0 100644 --- a/src/util/vircgroupv1.c +++ b/src/util/vircgroupv1.c @@ -21,7 +21,6 @@ #include <config.h> #ifdef __linux__ -# include <unistd.h> # include <mntent.h> # include <sys/stat.h> # include <sys/mount.h> diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c index 3264bff014..940ee58528 100644 --- a/src/util/vircgroupv2.c +++ b/src/util/vircgroupv2.c @@ -20,7 +20,6 @@ #include <config.h> #ifdef __linux__ -# include <unistd.h> # include <mntent.h> # include <sys/mount.h> #endif /* __linux__ */ diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 8e098b3634..5c0e9723b9 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -35,7 +35,6 @@ #include <sys/ioctl.h> #include <net/if.h> #include <fcntl.h> -#include <unistd.h> #ifdef __linux__ # include <linux/sockios.h> diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 7fc500007f..e2009fd829 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -36,7 +36,6 @@ #include <sys/ioctl.h> #include <net/if.h> #include <fcntl.h> -#include <unistd.h> #ifdef __linux__ # include <linux/sockios.h> diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index e916ba0a0a..c80a3a381f 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -24,8 +24,6 @@ #include <config.h> -#include <unistd.h> - #include "virnetdevmacvlan.h" #include "virmacaddr.h" #include "virerror.h" diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c index b30204fe7f..fb05190c02 100644 --- a/src/util/virnetdevvportprofile.c +++ b/src/util/virnetdevvportprofile.c @@ -18,8 +18,6 @@ #include <config.h> -#include <unistd.h> - #include "virnetdevvportprofile.h" #include "virerror.h" #include "viralloc.h" diff --git a/src/util/virperf.c b/src/util/virperf.c index 9bde5c1246..6ecfc29cb2 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -17,7 +17,6 @@ */ #include <config.h> -#include <unistd.h> #include <sys/ioctl.h> #if defined HAVE_SYS_SYSCALL_H # include <sys/syscall.h> diff --git a/src/util/virpidfile.c b/src/util/virpidfile.c index a6ee6e1f4b..999bccbee4 100644 --- a/src/util/virpidfile.c +++ b/src/util/virpidfile.c @@ -26,7 +26,6 @@ #include <fcntl.h> #include <signal.h> #include <sys/stat.h> -#include <unistd.h> #include "virpidfile.h" #include "virfile.h" diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 5c94ae346b..198439cea2 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -21,7 +21,6 @@ #include <config.h> #include <poll.h> -#include <unistd.h> #include "virpolkit.h" #include "virerror.h" diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index e495233110..9e477fc064 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -22,7 +22,6 @@ #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> -#include <unistd.h> #define LIBVIRT_VIRRESCTRLPRIV_H_ALLOW #include "virresctrlpriv.h" diff --git a/src/util/virutil.h b/src/util/virutil.h index 477d70554b..ded9b039e5 100644 --- a/src/util/virutil.h +++ b/src/util/virutil.h @@ -24,6 +24,7 @@ # define LIBVIRT_VIRUTIL_H # include "internal.h" +# include <unistd.h> # include <sys/types.h> # ifndef MIN diff --git a/tests/eventtest.c b/tests/eventtest.c index 37166253cc..df7570bac6 100644 --- a/tests/eventtest.c +++ b/tests/eventtest.c @@ -22,7 +22,6 @@ #include <signal.h> #include <time.h> -#include <unistd.h> #if HAVE_MACH_CLOCK_ROUTINES # include <mach/clock.h> diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c index b53763bc1d..9ba082d353 100644 --- a/tests/objecteventtest.c +++ b/tests/objecteventtest.c @@ -19,8 +19,6 @@ #include <config.h> -#include <unistd.h> - #include "testutils.h" #include "virerror.h" diff --git a/tests/scsihosttest.c b/tests/scsihosttest.c index 01cd77462b..6989e4fc4a 100644 --- a/tests/scsihosttest.c +++ b/tests/scsihosttest.c @@ -25,7 +25,6 @@ # include <fcntl.h> # include <sys/stat.h> -# include <unistd.h> # include "virstring.h" # include "virerror.h" # include "virlog.h" diff --git a/tests/vboxsnapshotxmltest.c b/tests/vboxsnapshotxmltest.c index 2f815a2bca..c70d7ab100 100644 --- a/tests/vboxsnapshotxmltest.c +++ b/tests/vboxsnapshotxmltest.c @@ -5,7 +5,6 @@ #ifdef WITH_VBOX # include <regex.h> -# include <unistd.h> # include "vbox/vbox_snapshot_conf.h" # define VIR_FROM_THIS VIR_FROM_NONE diff --git a/tests/virfiletest.c b/tests/virfiletest.c index 6e4805b42d..e2bd4953ed 100644 --- a/tests/virfiletest.c +++ b/tests/virfiletest.c @@ -19,7 +19,6 @@ #include <config.h> #include <fcntl.h> -#include <unistd.h> #include "testutils.h" #include "virfile.h" diff --git a/tests/virfilewrapper.c b/tests/virfilewrapper.c index f4d077d608..067cb30657 100644 --- a/tests/virfilewrapper.c +++ b/tests/virfilewrapper.c @@ -21,7 +21,6 @@ #ifndef WIN32 # include <fcntl.h> -# include <unistd.h> # include "viralloc.h" # include "virfile.h" diff --git a/tests/virlockspacetest.c b/tests/virlockspacetest.c index 4dd485bc0e..991e587db6 100644 --- a/tests/virlockspacetest.c +++ b/tests/virlockspacetest.c @@ -20,7 +20,6 @@ #include <signal.h> #include <sys/stat.h> -#include <unistd.h> #include "testutils.h" #include "virutil.h" diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c index d7b9db6641..3e9b007d9b 100644 --- a/tests/virnetdaemontest.c +++ b/tests/virnetdaemontest.c @@ -18,8 +18,6 @@ #include <config.h> -#include <unistd.h> - #include "testutils.h" #include "virerror.h" #include "rpc/virnetdaemon.h" diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index a7990ee5f3..9c14989287 100644 --- a/tests/virnetsockettest.c +++ b/tests/virnetsockettest.c @@ -23,7 +23,6 @@ # include <ifaddrs.h> #endif #include <netdb.h> -#include <unistd.h> #include "testutils.h" #include "virutil.h" diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index b94275b943..07910c2749 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -20,7 +20,6 @@ #include <fcntl.h> #include <sys/socket.h> -#include <unistd.h> #include "testutils.h" #include "virnettlshelpers.h" diff --git a/tests/virnettlshelpers.c b/tests/virnettlshelpers.c index dfb747b45d..a6aacf4cc3 100644 --- a/tests/virnettlshelpers.c +++ b/tests/virnettlshelpers.c @@ -20,7 +20,6 @@ #include <fcntl.h> #include <sys/socket.h> -#include <unistd.h> #include "virnettlshelpers.h" #include "viralloc.h" diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c index 153c8929ed..41abbe7eaf 100644 --- a/tests/virnettlssessiontest.c +++ b/tests/virnettlssessiontest.c @@ -20,7 +20,6 @@ #include <fcntl.h> #include <sys/socket.h> -#include <unistd.h> #include "testutils.h" #include "virnettlshelpers.h" diff --git a/tests/virscsitest.c b/tests/virscsitest.c index 75c7be5822..be3ef6234e 100644 --- a/tests/virscsitest.c +++ b/tests/virscsitest.c @@ -19,7 +19,6 @@ #include <config.h> -#include <unistd.h> #include "virscsi.h" #include "testutils.h" diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index d20559a636..4f23511240 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -18,7 +18,6 @@ #include <config.h> -#include <unistd.h> #include "testutils.h" #include "vircommand.h" -- 2.20.1

1 0

[libvirt] [jenkins-ci PATCH] Fix host list for osinfo-db-tools-check
by Andrea Bolognani 10 Apr '19

10 Apr '19

Commit e423182b4528 updated the host list for the job, but got things slightly wrong in that it included libvirt-debian-sid, libvirt-freebsd-current and libvirt-ubuntu-18 in the Jenkins configuration rather than the Ansible one. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as a trivial fix. guests/playbooks/build/projects/osinfo-db-tools.yml | 3 +++ jenkins/projects/osinfo-db-tools.yaml | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/guests/playbooks/build/projects/osinfo-db-tools.yml b/guests/playbooks/build/projects/osinfo-db-tools.yml index e33ea7a..27f6cc4 100644 --- a/guests/playbooks/build/projects/osinfo-db-tools.yml +++ b/guests/playbooks/build/projects/osinfo-db-tools.yml @@ -14,11 +14,14 @@ # CentOS 7; machines: - libvirt-debian-9 + - libvirt-debian-sid - libvirt-fedora-28 - libvirt-fedora-29 - libvirt-fedora-rawhide - libvirt-freebsd-11 - libvirt-freebsd-12 + - libvirt-freebsd-current + - libvirt-ubuntu-18 - include: '{{ playbook_base }}/jobs/autotools-rpm-job.yml' vars: machines: '{{ rpm_machines }}' diff --git a/jenkins/projects/osinfo-db-tools.yaml b/jenkins/projects/osinfo-db-tools.yaml index 9f738b6..de96bb5 100644 --- a/jenkins/projects/osinfo-db-tools.yaml +++ b/jenkins/projects/osinfo-db-tools.yaml @@ -16,14 +16,11 @@ # CentOS 7; machines: - libvirt-debian-9 - - libvirt-debian-sid - libvirt-fedora-28 - libvirt-fedora-29 - libvirt-fedora-rawhide - libvirt-freebsd-11 - libvirt-freebsd-12 - - libvirt-freebsd-current - - libvirt-ubuntu-18 - autotools-rpm-job: parent_jobs: 'osinfo-db-tools-check' machines: '{rpm_machines}' -- 2.20.1

1 0

[libvirt] [PATCH 0/2] drop QEMU_CAPS*KQEMU
by Ján Tomko 10 Apr '19

10 Apr '19

Ján Tomko (2): Delete QEMU_CAPS_KQEMU and QEMU_CAPS_ENABLE_KQEMU fixup: regroup QEMU capabilities src/qemu/qemu_capabilities.c | 248 +++++++++++++++++------------------ src/qemu/qemu_capabilities.h | 248 +++++++++++++++++------------------ 2 files changed, 246 insertions(+), 250 deletions(-) -- 2.19.2

2 3