- Users - libvirt List Archives

Re: [libvirt-users] access VMX config on esxi with virsh
by frank dirks 21 Sep '10

21 Sep '10

Hi, ... > > However, it sounds like that's not working for you. > > That could be a bug. Would you be ok with trying it again, then pasting > the error message here for us to see? > - virsh -c esx://esx1.local/?no_verify=1 dominfo vmtest.local --> works OK - virsh -c esx://esx1.local/?no_verify=1 dumpxml vmtest.local gives the error message: error memory conf:90: expecting an assignment (+ debug logs attached to this mail) regards, frank -- GMX DSL SOMMER-SPECIAL: Surf & Phone Flat 16.000 für nur 19,99 Euro/mtl.!* http://portal.gmx.net/de/go/dsl

2 1

[libvirt-users] libvirt with multiple users
by Zach Tibbitts 21 Sep '10

21 Sep '10

Hi, I'm trying to set up a virtual machine server for our newly re-founded LUG at my school. The idea is for members to have their own virtual machine that they can learn their way around a Linux system without worry of them hosing the host system or their own computers. At home I use libvirt with my server to manage multiple virtual machines, but the issue I'm running into for this use case is user permissions. As far as I've seen, anyone who has access to the server over ssh and has access to the libvirt server via virt-manager has access to all of the virtual machines. I'd like to find some way for each user to only see their own virtual machine. Is this possible? I've considered setting up VMs myself, and giving them direct access via ssh or VNC, but I'd like them to have access to the console so that they can attach things like CD images to their VMs for reinstalling or changing distros. Is there a way to get libvirt to do what I need here? Thanks much, Zach Tibbitts

2 1

[libvirt-users] access VMX config on esxi with virsh
by frank dirks 21 Sep '10

21 Sep '10

Hi, Is virsh able to access the VMX config of a virtual machine running on a esxi host? I would like to take backups of my virtual machine configs and the doku section "Converting from VMware VMX config to domain XML config" (http://libvirt.org/drvesx.html) comes close to this - but does not tell how to get access to the vmx file. I would prefer a solution where ssh access to the esxi host can stay disabled. best regards, frank -- Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail

3 3

[libvirt-users] virConnectOpen question.
by Sharad Mishra 17 Sep '10

17 Sep '10

Hi, I am using virConnectOpen(const char *uri) to connect to the local hypervisor. When uri is set to "lxc:///", an error gets logged in /var/log/messages about failed connection. But I do not see any error for "xen:///". The machine does not have these drivers installed, and I am using libvirt 0.6.3. My questions are - 1. Why I see error in /var/log/messages for container and not for xen? 2. Is there a way to avoid this error? Can I check for installed drivers before trying to connect? Thanks Sharad Mishra

2 1

[libvirt-users] sco 5.0.5 not booting on hard disk
by Jean Michault 17 Sep '10

17 Sep '10

Hello, I am trying to run SCO unix 5.0.5 with KVM. I have created the Virtual Machine with virt-manager. The installation runs correctly, but when the virtual machine reboots from hard disk, i obtain this message : "FATAL: No bootable device." If i run manually the virtual machine without the suboption "boot=on" in the "-drive" option, the virtual machine boots correctly. Why is "boot=on" preventing my VM to boot ? Is there a way to modify the .xml file for this VM to inform libvirt to not add "boot=on" ? Thanks Jean Michault.

3 2

[libvirt-users] qemu driver boot up
by ccmail111 16 Sep '10

16 Sep '10

Hi, Looking to libvirt source code questions: a) I see virt-mgr or such client invokes libvirt API which inturn connects to libvirtd on host. Is this right ? Further libvirtd invokes qemu driver callbacks which were registered when it comes up using: qemuRegister() API. Is this right ? b) If (a) is true then does is mandate that (i) libvirtd daemon need to be running on host only ? (ii) also libvirtd daemon need to be running before qemu (to register) ? c) what is the call sequence and boot up flow between libvirtd daemon and qemu ? d) can libvirtd process run in a guest ? Thanks ! CM.

1 0

[libvirt-users] qemu and libvirtd question.
by ccmail111 16 Sep '10

16 Sep '10

Hi, I looked to developer guide and have couple of novice questions. I hope this is the right forum and some can shed some light and pointers. 1) does virtd need to running on host ? can it run in a guest (privileged guest) ? 2) how does virtd (backend) interact with qemu drivers ? Thanks, CM

1 0

[libvirt-users] Can I set up VMs in a "Flat" network?
by sean darcy 16 Sep '10

16 Sep '10

Our small network is 10.10.11.0/24, gateway 10.10.11.252. dhcp is set up. I'm using virt-manager to install VM's with kvm-qemu on an F14 host - 10.10.11.100. qemu-kvm-0.13.0-0.6.rc1.fc14.x86_64 libvirt-0.8.3-2.fc14.x86_64 I'd like all the VM's to be on the same network as the physical machines with an address range of 10.10.11.110-10.10.11.130. I have virt-net set up. ifconfig on the host: br0 Link encap:Ethernet HWaddr 00:30:67:6A:2C:5E inet addr:10.10.11.100 Bcast:10.10.11.255 Mask:255.255.255.0 inet6 addr: fe80::230:67ff:fe6a:2c5e/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:2792310 errors:0 dropped:0 overruns:0 frame:0 TX packets:4310569 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:571898900 (545.4 MiB) TX bytes:5394989297 (5.0 GiB) eth0 Link encap:Ethernet HWaddr 00:30:67:6A:2C:5E inet6 addr: fe80::230:67ff:fe6a:2c5e/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:2908711 errors:0 dropped:0 overruns:0 frame:0 TX packets:4462246 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:629708224 (600.5 MiB) TX bytes:5402914301 (5.0 GiB) Interrupt:44 Base address:0xe000 lo ......................... virbr0 Link encap:Ethernet HWaddr 00:00:00:00:00:00 inet addr:192.168.122.1 Bcast:192.168.122.255 Mask:255.255.255.0 UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:219830 errors:0 dropped:0 overruns:0 frame:0 TX packets:640662 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:0 RX bytes:142081963 (135.4 MiB) TX bytes:777889995 (741.8 MiB) On virt-manager I've tried a "Routed" network, but that doesn't work: libvirtError: internal error Network 10.10.11.1/255.255.255.0 is already in use by interface br0 Can this be done? How? sean

1 0

[libvirt-users] KVM guest creation - no manual interference
by Lucas Arbiza 11 Sep '10

11 Sep '10

Hi I've looking for a way to create KVM virtual machines completely automated without the need to interact with guest operating system during installation. With ubuntu-vm-builder is possible create the guest, list packages to be installed and scripts to be run. Is there a way to do something like it with libvirt? Thanks! __ Lucas Arbiza email: lucas.arbiza(a)gmail.com celular: +55 (55) 9152 7561 <http://br.linkedin.com/in/lucasarbiza> <http://www.google.com/profiles/lucas.arbiza>

4 4

[libvirt-users] Disabling iptables on bridge breaks port forwarding for NAT
by Brian Pitts 10 Sep '10

10 Sep '10

Hi, Following the directions for setting up bridged networking in the red hat virtualization guide and libvirt wiki, I set the following kernel parameters to 0 on a RHEL 5.5 server. net.bridge.bridge-nf-call-ip6tables net.bridge.bridge-nf-call-iptables net.bridge.bridge-nf-call-arptables Unfortunately, doing this broke the port forwarding I'd set up for VMs on my NAT networks, e.g. iptables -I FORWARD -d 192.168.122.2 -i eth0 -p tcp -m tcp --dport 80 -m state --state NEW -j ACCEPT iptables -t nat -I PREROUTING -i eth0 -p tcp -m tcp --dport 8080 -j DNAT --to-destination 192.168.122.2:80 Before I run sysctl to change those values, nmap shows port 8080 as open. Afterwards, nmap shows it as filtered. Using sysctl to set those values to 1 did not undo the change, the port still showed as filtered. I had to reboot to open the port again. Creating an iptables rule to accept traffic on bridged devices, i.e. iptables -I FORWARD -m physdev --physdev-is-bridged -j ACCEPT did not not cause this problem. I am wondering if breaking the FORWARD and PREROUTING rules I set up to do port forwarding is to be expected when those net.bridge parameters are set to 1. If so, I think this should be mentioned in the libvirt wiki and red hat documentation. It can't be that uncommon for a single server to host guests with a mix of with bridged and NAT networking. -- Brian Pitts Systems Administrator | EuPathDB Bioinformatics Resource Center 706-542-1447 | bdp(a)uga.edu | http://eupathdb.org

1 0

[libvirt-users] Restarting iptables and libvirtd
by Brian Pitts 10 Sep '10

10 Sep '10

Hi, If I issue the commands # service libvirtd stop # service iptables stop # service iptables start # service libvirtd start the iptables rules that enable NAT on my virtual networks are not created when libvirtd is started, even though the networks are set to autostart and 'virsh net-list' shows them as active. The rules are only created if I run net-destroy and net-start. Is this the expected behavior? I would have thought that restarting libvirtd would ensure the necessary iptables rules are in place for networks marked as autostart. I would also have though that net-list would not show networks as active if the iptables rules needed for them to work were not in place. -- Brian Pitts Systems Administrator | EuPathDB Bioinformatics Resource Center 706-542-1447 | bdp(a)uga.edu | http://eupathdb.org

1 0

[libvirt-users] Status of libvirtd on BSD/OSX?
by Mitchell Hashimoto 09 Sep '10

09 Sep '10

Hello, I've done some research prior to this and the answer is clear that libvirtd doesn't compile on BSD or OSX, but I'd like to know more details about this, if I can have a bit of your time: * Are there any current efforts to get libvirtd running on BSD? * What are the blockers to getting it running? * My main goal is really to, at first only control VirtualBox, so KVM/Xen/etc is not an issue. I realize that KVM and some other hypervisors obviously can't be supported on BSD, but if I could just start by compiling libvirtd for VirtualBox on BSD that would be a big win in and of itself. Thanks, Mitchell

3 4

[libvirt-users] kqemu
by Zvi Dubitzky 08 Sep '10

08 Sep '10

Hi we have a Debian 64 bit system with qemu 0.9.1-10 ( uname -a = 2.6.26-2-amd64) installed . kvm is included and loaded to memory . Still when we create a VM we sometimes get the following error message: libvir: QEMU error : internal error unable to start guest: You do not have enough space in '/dev/shm' for the 499 MB of QEMU virtual RAM. To have more space available provided you have enough RAM and swap, do as root: mount -o remount,size=515m /dev/shm Or disable the accelerator module with -no-kqemu after we do the mount we can create the VM . Does that mean that kvm is not active because it seems that kqemu is an old way to do the duties of kvm e.g supply memory to VMs via /dev/shm thanks Zvi Dubitzky Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

1 0

[libvirt-users] override DNS server address?
by steven765＠yahoo.com 07 Sep '10

07 Sep '10

Is there a spot in the xml i'm not seeing to identify the network DNS server. Currently it's defaulting to a.b.c.1 I'm running my own though on a different address and can't find where to configure it in the xml schema or could I override it in DNSMASQ? Thanks Steve

1 0

[libvirt-users] libvirt 0.8.3 rpm package for RHEL
by Joel Miller 06 Sep '10

06 Sep '10

Hi List, I've checked RHEL6 beta2, it's libvirt 0.8.1, but I need 0.8.3 to support vSphere 4.1, I know I can compile it by myself, but our Red Hat's customer wanna have "half official" rpm package for their test, anyone would help me to make rpm for RHEL5.5? And, do we have any roadmap about libvirt 0.8.3 to be official rpm package in RHEL6? Regards, Joel -- 周维伟 Joel Graber Miller Solution Architect Greater China Mobile: +86 134 0808 8141 E-mail: wzhou(a)redhat.com

1 0

[libvirt-users] Couple of libvirtd warnings
by jeremy avnet 04 Sep '10

04 Sep '10

Hello, I recently upgraded to libvirt 0.8.3 and qemu 0.12.5 and I'm seeing these messages in syslog: libvirtd: 09:52:34.591: warning : virStorageBackendQEMUImgBackingFormat:623 : Unexpected exit status '1', qemu probably failed libvirtd: 09:52:34.746: warning : qemudParsePCIDeviceStrs:1422 : Unexpected exit status '1', qemu probably failed I'm not having any problems, but I'd like to know what these mean. Thanks! .:. jeremy

1 0

[libvirt-users] is libvirt java binding thread safe?
by Ravi Pawar 03 Sep '10

03 Sep '10

please check the java file attached they throws the exception in case of passing. please let me know if i am missing something. -- Thanks & Regards Ravi Pawar

3 10

[libvirt-users] C, C++ or Python programming tutorial/manual/guide for libvirt
by Lucas Arbiza 01 Sep '10

01 Sep '10

Hi, I want to develop an application to manage KVM virtual machines. I've been looking for something that helps me to start programming using libvirt in C/C++. The only one documentation I found is in this link: http://libvirt.org/html/libvirt-libvirt.html. Neither Google has helped me! That does not look like a good way to start. So, do you know some useful C, C++ or Python tutorial for libvirt? I prefer C or C++. Thanks in advance. __ Lucas Arbiza email: lucas.arbiza(a)gmail.com celular: +55 (55) 9152 7561 skype: lucas.arbiza <http://br.linkedin.com/in/lucasarbiza> <http://www.google.com/profiles/lucas.arbiza>

2 2

[libvirt-users] Decent How-To now on the wiki for setting up Transport Layer Security
by Justin Clift 30 Aug '10

30 Aug '10

Hi all, For anyone that's interested in setting up TLS with libvirt, but hasn't gotten around to it yet, there's a decent guide on the wiki now: http://wiki.libvirt.org/page/TLSSetup It's user focused (ie SysAdmin's), and has lots of pics explaining concepts, plus shows what needs to be done, and shows how to do it. Please note, it doesn't cover SASL, it's just plain host based TLS. Very much open to feedback on it, if people have suggestions for improvement. Hope that helps. :) Regards and best wishes, Justin Clift

3 3

[libvirt-users] Unable to autostart storage pool.
by Sharad Mishra 28 Aug '10

28 Aug '10

Following xml file was used to create storage pool using 'virsh pool-create <xml>' <pool type='dir'> <name>my-diskpool</name> <uuid>2fbc894e-7619-6cda-a33c-b27fae5fbe8b</uuid> <capacity>136024670208</capacity> <allocation>11416657920</allocation> <available>124608012288</available> <source> <host name='localhost'/> </source> <target> <path>/var/lib/libvirt/images</path> <permissions> <mode>0700</mode> <owner>0</owner> <group>0</group> </permissions> </target> </pool> The command succeeds and a pool is created - # virsh pool-list --all Name State Autostart ----------------------------------------- my-diskpool active no When I try to set it up for autostart, I get - # virsh pool-autostart my-diskpool error: failed to mark pool my-diskpool as autostarted error: invalid argument in pool has no config file Why is it failing to autostart? /etc/libvirt/storage has no xml file. Thanks Sharad Mishra IBM

2 1

[libvirt-users] Installing a VM to a virtio disk
by Brian Roberg 27 Aug '10

27 Aug '10

When provisioning new VMs, is it possible to enable virtio for the guest's storage at the time of the installation? When I try to do so, the Ubuntu installer says, "No root file system is defined" when it gets to the partitioning step. Here's the disk option I'm giving to virt-install: --disk pool=libvirt-pool,size=4,bus=virtio (I'm also using "--os-variant=ubuntulucid".) I've been able to install a new VM using the IDE storage driver first and then switch to virtio after the installation is complete, but it would simplify the process if it could start with virtio right off the bat. I'm using Ubuntu 10.04 LTS ("Lucid") host and guest, which provides libvirt 0.7.5 and kernel 2.6.32. I'm about ready to concede defeat and set up a way to automate making the change after the installation, but I thought I'd ask here first. Thanks! -- Brian

1 1

Re: [libvirt-users] [virt-tools-list] Client certificate paths?
by Cole Robinson 22 Aug '10

22 Aug '10

On 08/12/2010 10:29 AM, Lars Kellogg-Stedman wrote: > Hello all, > > I'm trying to get virsh (and virt-manager) to talk to a remote libvirt > instance. I cannot for the life of me figure out how to tell either > tool where to find client or CA certificates. Do they *really* need > to access the ones in /etc/pki? In particular, the client seems to > want to read the *server's* private key, which for obvious reasons is > only readable by root. > > I feel like I must be missing something obvious...if someone can point > me towards a solution I would really appreciate it. Thanks! > > If it's relevant, I'm running everything under Fedora 13 right now, so > that means libvirt-0.8.2-1.fc13.x86_64 and > qemu-kvm-0.12.3-8.fc13.x86_64. > This is more a libvirt question, so CC-ing libvirt-users. - Cole

3 2

[libvirt-users] Libvirt and iptables rule order
by Brian Pitts 21 Aug '10

21 Aug '10

Hi, On RHEL 5.5, I set up iptables rules for forwarding ports to some of my virtual machines. For example. iptables -t nat -A PREROUTING -i eth0 -p tcp -m tcp --dport 3380 -j DNAT --to-destination 192.168.123.2:3389 iptables -I FORWARD -d 192.168.123.2 -i eth0 -p tcp -m tcp --dport 3389 -m state --state NEW -j ACCEPT These worked fine, and I saved them with 'service iptables save'. However, upon rebooting the server the forwarding no longer works. When I inspect the configuration with 'iptables -L', I see that the rules libvirt creates were inserted before the rules from /etc/sysconfig/iptables. Since the rules from libvirt include one that rejects any new connections, the data I want forwarded is dropped. For example, target prot opt in out source destination ACCEPT all -- any virbr1 anywhere 192.168.123.0/24 state RELATED,ESTABLISHED ACCEPT all -- virbr1 any 192.168.123.0/24 anywhere ACCEPT all -- virbr1 virbr1 anywhere anywhere REJECT all -- any virbr1 anywhere anywhere reject-with icmp-port-unreachable REJECT all -- virbr1 any anywhere anywhere reject-with icmp-port-unreachable ACCEPT tcp -- eth0 any anywhere 192.168.123.2 tcp dpt:ms-wbt-server state NEW How should I configure iptables so that my rules and libvirt's play nicely? Basically I need my ACCEPTs to end up before libvirt's REJECTs. I looked through the list archives and libvirt documentation but did not see an answer to this question. -- Brian Pitts Systems Administrator | EuPathDB Bioinformatics Resource Center 706-542-1447 | bdp(a)uga.edu | http://eupathdb.org

1 0

[libvirt-users] how to Create virtual machine
by Saravanan S 20 Aug '10

20 Aug '10

Hi, I am working on a virtualization project that involves setting up virtual appliances to implement the same, which tool is required to 1) create virtual appliances 2) deploy virtual appliances 3) manage virtual appliances/virtual machines Could you please guide me with some pointers or resources to get started with the creation of virtual machines? I am little confused with libvirt with Xen and qemu. how does xen or qemu related with libvirt ? Thank you. Saravanan Sundaramoorthy Red Hat Certified Engineer http://www.google.com/profiles/dearsaravanan#about +91 99404 32545

3 2

[libvirt-users] libvirt support spice protocol
by Songwen Liao 20 Aug '10

20 Aug '10

Hi,everyone, there is a problem with libvirt support spice protocol. i use the following patch file,but it seems not success.anyone have an idea about that? thanks. patch file: This adds an element <graphics type='spice' port='5903' tlsPort='5904' listen='127.0.0.1'/> This is the bare minimum that should be exposed in the guest config for SPICE. Other parameters are better handled as per host level configuration tunables * docs/schemas/domain.rng: Define the SPICE <graphics> schema * src/domain_conf.h, src/domain_conf.c: Add parsing and formatting for SPICE graphics config * src/qemu_conf.c: Complain about unsupported graphics types --- docs/schemas/domain.rng | 30 +++++++++++++++++++++ src/conf/domain_conf.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++- src/conf/domain_conf.h | 8 ++++++ src/qemu/qemu_conf.c | 9 ++++++ 4 files changed, 111 insertions(+), 1 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index f9d6d7e..8aa2079 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -746,6 +746,36 @@ </group> <group> <attribute name="type"> + <value>spice</value> + </attribute> + <optional> + <attribute name="port"> + <ref name="PortNumber"/> + </attribute> + </optional> + <optional> + <attribute name="tlsPort"> + <ref name="PortNumber"/> + </attribute> + </optional> + <optional> + <attribute name="listen"> + <ref name="addrIP"/> + </attribute> + </optional> + <optional> + <attribute name="passwd"> + <text/> + </attribute> + </optional> + <optional> + <attribute name="keymap"> + <text/> + </attribute> + </optional> + </group> + <group> + <attribute name="type"> <value>rdp</value> </attribute> <optional> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4930c38..ca5dfc3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -165,7 +165,8 @@ VIR_ENUM_IMPL(virDomainGraphics, VIR_DOMAIN_GRAPHICS_TYPE_LAST, "sdl", "vnc", "rdp", - "desktop") + "desktop", + "spice") VIR_ENUM_IMPL(virDomainHostdevMode, VIR_DOMAIN_HOSTDEV_MODE_LAST, "subsystem", @@ -267,6 +268,12 @@ void virDomainGraphicsDefFree(virDomainGraphicsDefPtr def) case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP: VIR_FREE(def->data.desktop.display); break; + + case VIR_DOMAIN_GRAPHICS_TYPE_SPICE: + VIR_FREE(def->data.spice.listenAddr); + VIR_FREE(def->data.spice.keymap); + VIR_FREE(def->data.spice.passwd); + break; } VIR_FREE(def); @@ -1692,6 +1699,38 @@ virDomainGraphicsDefParseXML(virConnectPtr conn, def->data.desktop.fullscreen = 0; def->data.desktop.display = virXMLPropString(node, "display"); + } else if (def->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) { + char *port = virXMLPropString(node, "port"); + char *tlsPort; + + if (port) { + if (virStrToLong_i(port, NULL, 10, &def->data.spice.port) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("cannot parse spice port %s"), port); + VIR_FREE(port); + goto error; + } + VIR_FREE(port); + } else { + def->data.spice.port = 5900; + } + + tlsPort = virXMLPropString(node, "tlsPort"); + if (tlsPort) { + if (virStrToLong_i(tlsPort, NULL, 10, &def->data.spice.tlsPort) < 0) { + virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("cannot parse spice tlsPort %s"), tlsPort); + VIR_FREE(tlsPort); + goto error; + } + VIR_FREE(tlsPort); + } else { + def->data.spice.tlsPort = 0; + } + + def->data.spice.listenAddr = virXMLPropString(node, "listen"); + def->data.spice.passwd = virXMLPropString(node, "passwd"); + def->data.spice.keymap = virXMLPropString(node, "keymap"); } cleanup: @@ -4100,6 +4139,30 @@ virDomainGraphicsDefFormat(virConnectPtr conn, break; + case VIR_DOMAIN_GRAPHICS_TYPE_SPICE: + if (def->data.spice.port) + virBufferVSprintf(buf, " port='%d'", + def->data.spice.port); + + if (def->data.spice.tlsPort) + virBufferVSprintf(buf, " tlsPort='%d'", + def->data.spice.tlsPort); + + if (def->data.spice.listenAddr) + virBufferVSprintf(buf, " listen='%s'", + def->data.spice.listenAddr); + + if (def->data.spice.keymap) + virBufferEscapeString(buf, " keymap='%s'", + def->data.spice.keymap); + + if (def->data.spice.passwd && + (flags & VIR_DOMAIN_XML_SECURE)) + virBufferEscapeString(buf, " passwd='%s'", + def->data.spice.passwd); + + break; + } virBufferAddLit(buf, "/>\n"); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 7ea1152..4cb10d3 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -334,6 +334,7 @@ enum virDomainGraphicsType { VIR_DOMAIN_GRAPHICS_TYPE_VNC, VIR_DOMAIN_GRAPHICS_TYPE_RDP, VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP, + VIR_DOMAIN_GRAPHICS_TYPE_SPICE, VIR_DOMAIN_GRAPHICS_TYPE_LAST, }; @@ -366,6 +367,13 @@ struct _virDomainGraphicsDef { char *display; int fullscreen : 1; } desktop; + struct { + int port; + int tlsPort; + char *listenAddr; + char *keymap; + char *passwd; + } spice; } data; }; diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 7ba0ac2..ae171bc 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -2067,6 +2067,12 @@ int qemudBuildCommandLine(virConnectPtr conn, } } + if (def->ngraphics > 1) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + "%s", _("only one graphics output is currently supported")); + goto error; + } + if ((def->ngraphics == 1) && def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) { virBuffer opt = VIR_BUFFER_INITIALIZER; @@ -2155,6 +2161,9 @@ int qemudBuildCommandLine(virConnectPtr conn, */ ADD_ENV_COPY("QEMU_AUDIO_DRV"); ADD_ENV_COPY("SDL_AUDIODRIVER"); + } else if (def->ngraphics) { + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + "%s", _("unsupported graphics output requested")); } if (def->nvideos) { -- -- Name: Ben ------------------------------------------ Msn: liaosongwen(a)live.cn

1 0