- Devel - libvirt List Archives

[libvirt] [PATCH] libvirt_private.syms: Properly expose virPCI* function from virpci.h
by Michal Privoznik 18 Jul '19

18 Jul '19

There are couple of functions that are meant to be exposed but are missing syms file adjustment. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/libvirt_private.syms | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 9640e91eaa..1d9eb17a86 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2614,6 +2614,7 @@ virObjectUnref; # util/virpci.h virPCIDeviceAddressAsString; virPCIDeviceAddressEqual; +virPCIDeviceAddressFree; virPCIDeviceAddressGetIOMMUGroupAddresses; virPCIDeviceAddressGetIOMMUGroupNum; virPCIDeviceAddressGetSysfsFile; @@ -2625,6 +2626,7 @@ virPCIDeviceCopy; virPCIDeviceDetach; virPCIDeviceFileIterate; virPCIDeviceFree; +virPCIDeviceGetAddress; virPCIDeviceGetConfigPath; virPCIDeviceGetDriverPathAndName; virPCIDeviceGetIOMMUGroupDev; @@ -2664,11 +2666,14 @@ virPCIDeviceSetUsedBy; virPCIDeviceUnbind; virPCIDeviceWaitForCleanup; virPCIEDeviceInfoFree; +virPCIELinkSpeedTypeFromString; +virPCIELinkSpeedTypeToString; virPCIGetDeviceAddressFromSysfsLink; virPCIGetHeaderType; virPCIGetMdevTypes; virPCIGetNetName; virPCIGetPhysicalFunction; +virPCIGetSysfsFile; virPCIGetVirtualFunctionIndex; virPCIGetVirtualFunctionInfo; virPCIGetVirtualFunctions; -- 2.21.0

1 0

[libvirt] [dockerfiles PATCH 0/3] Add libosinfo-related projects
by Andrea Bolognani 18 Jul '19

18 Jul '19

See patch 2/3 for more information. Andrea Bolognani (3): refresh: Store projects in a more convenient format refresh: Add libosinfo-related projects Refresh after adding libosinfo-related projects buildenv-centos-7.Dockerfile | 11 +++++++++ buildenv-debian-10-cross-aarch64.Dockerfile | 15 ++++++++++++ buildenv-debian-10-cross-armv6l.Dockerfile | 15 ++++++++++++ buildenv-debian-10-cross-armv7l.Dockerfile | 15 ++++++++++++ buildenv-debian-10-cross-i686.Dockerfile | 15 ++++++++++++ buildenv-debian-10-cross-mips.Dockerfile | 15 ++++++++++++ buildenv-debian-10-cross-mips64el.Dockerfile | 15 ++++++++++++ buildenv-debian-10-cross-mipsel.Dockerfile | 15 ++++++++++++ buildenv-debian-10-cross-ppc64le.Dockerfile | 15 ++++++++++++ buildenv-debian-10-cross-s390x.Dockerfile | 15 ++++++++++++ buildenv-debian-10.Dockerfile | 15 ++++++++++++ buildenv-debian-9-cross-aarch64.Dockerfile | 15 ++++++++++++ buildenv-debian-9-cross-armv6l.Dockerfile | 15 ++++++++++++ buildenv-debian-9-cross-armv7l.Dockerfile | 15 ++++++++++++ buildenv-debian-9-cross-mips.Dockerfile | 15 ++++++++++++ buildenv-debian-9-cross-mips64el.Dockerfile | 15 ++++++++++++ buildenv-debian-9-cross-mipsel.Dockerfile | 15 ++++++++++++ buildenv-debian-9-cross-ppc64le.Dockerfile | 15 ++++++++++++ buildenv-debian-9-cross-s390x.Dockerfile | 15 ++++++++++++ buildenv-debian-9.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-aarch64.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-armv6l.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-armv7l.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-i686.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-mips.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-mips64el.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-mipsel.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-ppc64le.Dockerfile | 15 ++++++++++++ buildenv-debian-sid-cross-s390x.Dockerfile | 15 ++++++++++++ buildenv-debian-sid.Dockerfile | 15 ++++++++++++ buildenv-fedora-29.Dockerfile | 15 ++++++++++++ buildenv-fedora-30.Dockerfile | 15 ++++++++++++ buildenv-fedora-rawhide.Dockerfile | 24 +++++++++++++++++++ buildenv-ubuntu-16.Dockerfile | 15 ++++++++++++ buildenv-ubuntu-18.Dockerfile | 15 ++++++++++++ refresh | 17 +++++++++---- 36 files changed, 543 insertions(+), 4 deletions(-) -- 2.21.0

3 8

[libvirt] [PATCH 0/2] virSecurityManagerMetadataLock: Skip over duplicate paths
by Michal Privoznik 18 Jul '19

18 Jul '19

See 2/2 for explanation. Michal Prívozník (2): virSecurityManagerMetadataLock: Expand the comment on deadlocks virSecurityManagerMetadataLock: Skip over duplicate paths src/security/security_manager.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) -- 2.21.0

3 7

[libvirt] [dockerfiles PATCH] Add git-publish configuration file
by Andrea Bolognani 18 Jul '19

18 Jul '19

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitpublish | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish new file mode 100644 index 0000000..a56a6d0 --- /dev/null +++ b/.gitpublish @@ -0,0 +1,4 @@ +[gitpublishprofile "default"] +base = master +to = libvir-list(a)redhat.com +prefix = dockerfiles PATCH -- 2.20.1

1 1

[libvirt] [PATCH 1/1] Revert "Revert "qemu: Temporary disable owner remembering""
by Daniel Henrique Barboza 18 Jul '19

18 Jul '19

After this commit, QEMU domains with PCI hostdevs running with managed=true started to fail to launch with the following error: error : virProcessRunInFork:1170 : internal error: child reported (status=125): unable to open /dev/vfio/1: Device or resource busy One way to avoid this issue is to disable this new feature in qemu.conf, setting remember_owner=0. However, given that this feature is enabled by default and it is breaking domains that were running before it, it is best to revert the change until it is fixed for this scenario as well. This reverts commit 8695793d726e37e31498f9fcbf0bce0adc56dc91. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- docs/news.xml | 13 ------------- src/qemu/libvirtd_qemu.aug | 1 - src/qemu/qemu.conf | 5 ----- src/qemu/qemu_conf.c | 4 ---- src/qemu/test_libvirtd_qemu.aug.in | 1 - 5 files changed, 24 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 07d4575a65..8931f74bb9 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -25,19 +25,6 @@ <section title="New features"> </section> <section title="Improvements"> - <change> - <summary> - Remember original owners and SELinux labels of files - </summary> - <description> - When a domain is starting up libvirt changes DAC and - SELinux labels so that domain can access it. However, - it never remembered the original labels and therefore - the file was returned back to <code>root:root</code>. - With this release, the original labels are remembered - and restored properly. - </description> - </change> </section> <section title="Bug fixes"> </section> diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index eea9094d39..6821cc4a29 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -72,7 +72,6 @@ module Libvirtd_qemu = | str_entry "user" | str_entry "group" | bool_entry "dynamic_ownership" - | bool_entry "remember_owner" | str_array_entry "cgroup_controllers" | str_array_entry "cgroup_device_acl" | int_entry "seccomp_sandbox" diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index fd2ed9dc21..1969b3f0a1 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -456,11 +456,6 @@ # Set to 0 to disable file ownership changes. #dynamic_ownership = 1 -# Whether libvirt should remember and restore the original -# ownership over files it is relabeling. Defaults to 1, set -# to 0 to disable the feature. -#remember_owner = 1 - # What cgroup controllers to make use of with QEMU guests # # - 'cpu' - use for scheduler tunables diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index e0195dac29..8312f99f80 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -125,7 +125,6 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged) cfg->group = (gid_t)-1; } cfg->dynamicOwnership = privileged; - cfg->rememberOwner = privileged; cfg->cgroupControllers = -1; /* -1 == auto-detect */ @@ -891,9 +890,6 @@ virQEMUDriverConfigLoadSecurityEntry(virQEMUDriverConfigPtr cfg, if (virConfGetValueBool(conf, "dynamic_ownership", &cfg->dynamicOwnership) < 0) return -1; - if (virConfGetValueBool(conf, "remember_owner", &cfg->rememberOwner) < 0) - return -1; - if (virConfGetValueStringList(conf, "cgroup_controllers", false, &controllers) < 0) return -1; diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in index 388ba24b8b..50b728ad22 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -44,7 +44,6 @@ module Test_libvirtd_qemu = { "user" = "root" } { "group" = "root" } { "dynamic_ownership" = "1" } -{ "remember_owner" = "1" } { "cgroup_controllers" { "1" = "cpu" } { "2" = "devices" } -- 2.21.0

2 3

[libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.
by Julio Faracco 18 Jul '19

18 Jul '19

This commit is similar with 596aa144. It fixes an uninitialized variable to avoid garbage value. This case, it uses time 't' 0 if an error occurs with virTimeMillisNowRaw. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/util/virtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virtime.c b/src/util/virtime.c index d1187726ee..86993e4e8d 100644 --- a/src/util/virtime.c +++ b/src/util/virtime.c @@ -422,7 +422,7 @@ virTimeBackOffStart(virTimeBackOffVar *var, bool virTimeBackOffWait(virTimeBackOffVar *var) { - unsigned long long t, next; + unsigned long long next, t = 0; ignore_value(virTimeMillisNowRaw(&t)); -- 2.20.1

2 1

[libvirt] [jenkins-ci PATCH v2 00/20] quayadmin: Introduce Quay API client
by Andrea Bolognani 18 Jul '19

18 Jul '19

Changes from [v1]: * add Dan's R-b to the patch importing the initial implementation; * don't break quiet mode for show-repo, and make sure it works for all other show-* commands as well; * fix typos. [v1] https://www.redhat.com/archives/libvir-list/2019-July/msg01018.html Andrea Bolognani (20): quayadmin: Import initial implementation quayadmin: Fix argument parsing for delete-repo quayadmin: Tweak quiet logic quayadmin: Tweak show-repo output format quayadmin: Tweak list-repos output format quayadmin: Build endpoint, params and payload separately quayadmin: Implement debug mode quayadmin: Remove clientid and clientsecret quayadmin: Introduce configuration object quayadmin: Read configuration from file quayadmin: Add support for the PUT method quayadmin: Add list-triggers command quayadmin: Add show-trigger command quayadmin: Add activate-trigger command quayadmin: Add list-builds command quayadmin: Add show-build command quayadmin: Add list-tags command quayadmin: Add show-tag command quayadmin: Add create-tag command quayadmin: Add delete-tag command guests/quayadmin | 585 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 585 insertions(+) create mode 100755 guests/quayadmin -- 2.21.0

2 40

[libvirt] [PATCH 0/2] docs: news: add per-release links
by Ján Tomko 17 Jul '19

17 Jul '19

Ján Tomko (2): docs: news: remove sed sorcery docs: news: add per-release links docs/Makefile.am | 8 +------- docs/news-html.xsl | 21 ++++++++++++++------- 2 files changed, 15 insertions(+), 14 deletions(-) -- 2.20.1

4 8

[libvirt] [PATCH 0/7] docs: assorted cleanups (virtio-fs epopee)
by Ján Tomko 17 Jul '19

17 Jul '19

Got a bit lost while navigating around the <filesystem> element documentation. Ján Tomko (7): docs: link to networkportformat.html in format.html docs: drvqemu: fix a typo docs: drvqemu: remove relative time reference docs: formatdomain: remove stray nbsp docs: formatdomain: tsc is supported by QEMU docs: formatdomain: remove "Since" references older than 1.1.1 docs: remove "Since" references older than 1.1.1 docs/drvnodedev.html.in | 8 +- docs/drvqemu.html.in | 15 +- docs/format.html.in | 1 + docs/formatcaps.html.in | 22 ++- docs/formatdomain.html.in | 340 +++++++++++++------------------------- docs/storage.html.in | 5 - 6 files changed, 138 insertions(+), 253 deletions(-) -- 2.20.1

2 10

[libvirt] [PATCH 0/2] qemu: blockjob: Tweak config saving in legacy block job handling (blockdev-add saga)
by Peter Krempa 17 Jul '19

17 Jul '19

This is based on quite a lot of patches that were ACK'd but I didn't push them yet, so feel free to fetch this at: git fetch https://gitlab.com/pipo.sk/libvirt.git legacy-job-refactor Peter Krempa (2): qemu: blockjob: Save config only in qemuBlockJobEventProcessLegacyCompleted qemu: blockjob: Update new job state earlier in qemuBlockJobEventProcessLegacy src/qemu/qemu_blockjob.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) -- 2.21.0

2 4