- Devel - libvirt List Archives

[libvirt] [PATCH] maint: Post-release version bump to 5.5.0
by Andrea Bolognani 03 Jun '19

03 Jun '19

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. configure.ac | 2 +- docs/news.xml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7e01b77fc0..1f05055d6f 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [5.4.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] +AC_INIT([libvirt], [5.5.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/docs/news.xml b/docs/news.xml index 5d5dfb93aa..699fde7b52 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -39,6 +39,14 @@ --> <libvirt> + <release version="v5.5.0" date="unreleased"> + <section title="New features"> + </section> + <section title="Improvements"> + </section> + <section title="Bug fixes"> + </section> + </release> <release version="v5.4.0" date="2019-06-03"> <section title="New features"> </section> -- 2.21.0

1 0

[libvirt] [PATCH 0/5] Check TSC frequency before starting QEMU
by Jiri Denemark 03 Jun '19

03 Jun '19

When migrating a domain with invtsc CPU feature enabled, the TSC frequency of the destination host must match the frequency used when the domain was started on the source host or the destination host has to support TSC scaling. If the frequencies do not match and the destination host does not support TSC scaling, QEMU will fail to set the right TSC frequency when starting vCPUs on the destination and thus migration will fail. However, this is quite late since both host might have spent significant time transferring memory and perhaps even storage data. By adding the check to libvirt we can let migration fail before any data starts to be sent over. If for some reason libvirt is unable to detect the host's TSC frequency or scaling support, we'll just let QEMU try and the migration will either succeed or fail later. Luckily, we mandate TSC frequency to be explicitly set in the domain XML to even allow migration of domains with invtsc. We can just check whether the requested frequency is compatible with the current host before starting QEMU. And to let libvirt client decide whether it should even start the migration to a specific host, this series adds host's TSC frequency and scaling support to the host CPU capabilities XML. https://bugzilla.redhat.com/show_bug.cgi?id=1641702 Jiri Denemark (5): util: Add virHostCPUGetTscInfo conf: Report TSC frequency in host CPU capabilities cpu_x86: Fix placement of *CheckFeature functions cpu_x86: Probe TSC frequency and scaling support qemu: Check TSC frequency before starting QEMU src/conf/cpu_conf.c | 48 ++++++++++++++++++++++++ src/conf/cpu_conf.h | 2 + src/cpu/cpu_x86.c | 81 ++++++++++++++++++++++------------------- src/qemu/qemu_process.c | 53 +++++++++++++++++++++++++++ src/util/virhostcpu.c | 71 ++++++++++++++++++++++++++++++++++++ src/util/virhostcpu.h | 11 ++++++ 6 files changed, 229 insertions(+), 37 deletions(-) -- 2.21.0

2 7

[libvirt] [PATCH] test_driver: implement virDomainGetHostname
by Ilias Stamatis 02 Jun '19

02 Jun '19

Always return "domain_name" + "host". Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f58a1da95..aad7bb6036 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1910,6 +1910,27 @@ static int testDomainReboot(virDomainPtr domain, return ret; } +static char * +testDomainGetHostname(virDomainPtr domain, + unsigned int flags) +{ + char *ret = NULL; + virDomainObjPtr vm = NULL; + + virCheckFlags(0, NULL); + + if (!(vm = testDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + ignore_value(virAsprintf(&ret, "%shost", domain->name)); + + cleanup: + return ret; +} + static int testDomainGetInfo(virDomainPtr domain, virDomainInfoPtr info) { @@ -6950,6 +6971,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainGetMaxMemory = testDomainGetMaxMemory, /* 0.1.4 */ .domainSetMaxMemory = testDomainSetMaxMemory, /* 0.1.1 */ .domainSetMemory = testDomainSetMemory, /* 0.1.4 */ + .domainGetHostname = testDomainGetHostname, /* 5.5.0 */ .domainGetInfo = testDomainGetInfo, /* 0.1.1 */ .domainGetState = testDomainGetState, /* 0.9.2 */ .domainGetTime = testDomainGetTime, /* 5.4.0 */ -- 2.21.0

2 2

[libvirt] [PATCH] virDomainSendKey: validate codeset argument
by Ilias Stamatis 02 Jun '19

02 Jun '19

This argument wasn't validated anywhere, neither in the generic implementation nor in the individual drivers. As a result a call to this function with a large enough codeset value prior to this change causes libvirtd to crash. This happens because all drivers call virKeycodeValueTranslate which uses codeset as an index to the virKeymapValues array, causing an out-of-bounds error. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/libvirt-domain.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index df7e405b3e..c09448927b 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6837,6 +6837,13 @@ virDomainSendKey(virDomainPtr domain, virCheckNonNullArgGoto(keycodes, error); virCheckPositiveArgGoto(nkeycodes, error); + if (codeset >= VIR_KEYCODE_SET_LAST) { + virReportInvalidArg(codeset, + _("codeset must be less than %d"), + VIR_KEYCODE_SET_LAST); + goto error; + } + if (nkeycodes > VIR_DOMAIN_SEND_KEY_MAX_KEYS) { virReportInvalidArg(nkeycodes, _("nkeycodes must be <= %d"), -- 2.21.0

2 1

[libvirt] [PATCH] qemu: fix pr-helper0 remain
by Jie Wang 31 May '19

31 May '19

if libvirt receive DISCONNECTED event and set prDaemonRunning to false, and qemuDomainRemoveDiskDevice is performing in the meantime. qemuDomainRemoveDiskDevice will return directly by prDaemonRunning check, so the pr-helper0 object will remain. I think it is no need to check prDaemonRunning in qemuHotplugRemoveManagedPR. Signed-off-by: Jie Wang <wangjie88(a)huawei.com> --- src/qemu/qemu_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 34249bd030..5e4a929738 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -465,8 +465,7 @@ qemuHotplugRemoveManagedPR(virQEMUDriverPtr driver, virErrorPtr orig_err; int ret = -1; - if (!priv->prDaemonRunning || - virDomainDefHasManagedPR(vm->def)) + if (virDomainDefHasManagedPR(vm->def)) return 0; virErrorPreserveLast(&orig_err); -- 2.16.2.windows.1

3 6

[libvirt] [PATCH v2] docs: Drop the external AMD SEV links
by Erik Skultety 31 May '19

31 May '19

One of the current SEV document links went dead as AMD moved the resource to another place (document store), so there's probably very little point in maintaining 3rd party links if the resources are being moved. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- docs/formatdomaincaps.html.in | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index 432d7aed5e..bcd2b3354b 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -514,19 +514,9 @@ encrypted with a key unique to that VM.</p> <p> - For more details on the SEV feature and how to use it with libvirt have - a look at the following resources: - <dl> - <dd> - <a href="https://support.amd.com/TechDocs/55766_SEV-KM_API_Specification.pdf">SEV API spec</a> - </dd> - <dd> - <a href="http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_E…">SEV White Paper</a> - </dd> - <dd> - <a href="formatdomain.html#launchSecurity">SEV in domain XML</a> - </dd> - </dl> + For more details on the SEV feature, please follow resources in the + AMD developer's document store. In order to use SEV with libvirt have + a look at <a href="formatdomain.html#launchSecurity">SEV in domain XML</a> </p> <dl> -- 2.20.1

2 1

[libvirt] [PATCH] maint: Add support for .ctags.d
by Jiri Denemark 31 May '19

31 May '19

Depending on the way ctags was compiled, it may look for .ctags.d/*.ctags files rather than .ctags for reading configuration. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- .ctags.d/libvirt.ctags | 1 + 1 file changed, 1 insertion(+) create mode 120000 .ctags.d/libvirt.ctags diff --git a/.ctags.d/libvirt.ctags b/.ctags.d/libvirt.ctags new file mode 120000 index 0000000000..eefd37f401 --- /dev/null +++ b/.ctags.d/libvirt.ctags @@ -0,0 +1 @@ +../.ctags \ No newline at end of file -- 2.21.0

2 1

[libvirt] [PATCH 0/2] news: Update for 5.4.0 release
by Andrea Bolognani 31 May '19

31 May '19

Hopefully I've done a decent enough job at summarizing, especially with the security stuff: if not, please let me know! Andrea Bolognani (2): news: Reformat overgrown line news: Update for 5.4.0 release docs/news.xml | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 60 insertions(+), 1 deletion(-) -- 2.21.0

2 3

[libvirt] Entering freeze for libvirt 5.4.0
by Daniel Veillard 31 May '19

31 May '19

This is tagged in git, I have put the signed tarball and source RPM at the usual place: https://libvirt.org/sources/ I did not build the binaries rpms, first it broke because I was still on F28 c.f. Jan's patch, and second it's true to provides little value, it's doubtful people would just install my binaries as is. Will likely stick to sources as part of releases in the future. Release looks fine in my limited testing, https://ci.centos.org/view/libvirt/ is of a rare uniform green color, which is promising too ! Please give it a try, I will likely cut RC2 on Thrusday, and then if everything goes fine push the GA over the w.e. or Monday, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] Question about save and restore OVS per-port data in live migration
by wangxin (U) 30 May '19

30 May '19

Hi When we try to migrate a guest with 12 NICs, we find libvirt will try to get per-port data in finish phase, it makes the guest paused for several hundred milliseconds. qemuMigrationCookieAddNetwork -> virNetDevOpenvswitchGetMigrateData for per-nic -> run 'ovs-vsctl --if-exists get Interface vnetx external_ids:Port' (about 25ms) In our case, there's no portData available and it seems there is no need to run the cmd. Questions: 1. Is it necessary to get/set per-port data in migration finish phase? It will increase the downtime. 2. Is there any way (i.e. a switch) to not run the OVS cmd if there's no portData available?

2 4