- Devel - libvirt List Archives

[libvirt] [PATCH] virpcitest: Separate two functions properly
by Michal Privoznik 17 Jun '19

17 Jun '19

There is a missing empty line between two functions since its introduction in v1.2.0-rc1~150. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. tests/virpcimock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 7f9cdaa9b8..beb5e1490d 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -696,6 +696,7 @@ pci_driver_handle_unbind(const char *path) cleanup: return ret; } + static int pci_driver_handle_new_id(const char *path) { -- 2.21.0

1 0

[libvirt] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution
by Igor Mammedov 17 Jun '19

17 Jun '19

Changes since v3: - simplify series by dropping idea of showing property values in "qom-list-properties" and use MachineInfo in QAPI schema instead Changes since v2: - taking in account previous review, implement a way for mgmt to intospect if '-numa node,mem' is supported by machine type as suggested by Daniel at https://www.mail-archive.com/qemu-devel@nongnu.org/msg601220.html * ammend "qom-list-properties" to show property values * add "numa-mem-supported" machine property to reflect if '-numa node,mem=SZ' is supported. It culd be used with '-machine none' or at runtime with --preconfig before numa memory mapping are configured * minor fixes to deprecation documentation mentioning "numa-mem-supported" property 1) "I'm considering to deprecating -mem-path/prealloc CLI options and replacing them with a single memdev Machine property to allow interested users to pick used backend for initial RAM (fixes mixed -mem-path+hostmem backends issues) and as a transition step to modeling initial RAM as a Device instead of (ab)using MemoryRegion APIs." (for more details see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg596314.html) However there is a couple of roadblocks on the way (s390x and numa memory handling). I think I finally thought out a way to hack s390x in migration compatible manner, but I don't see any way to do it for -numa node,mem and default RAM assignement to nodes. Considering both numa usecases aren't meaningfully using NUMA (aside guest side testing) and could be replaced with explicitly used memdev parameter, I'd like to propose removing these fake NUMA friends on new machine types, hence this deprecation. And once the last machie type that supported the option is removed we would be able to remove option altogether. As result of removing deprecated options and replacing initial RAM allocation with 'memdev's (1), QEMU will allocate guest RAM in consistent way, fixing mixed use-case and allowing boards to move towards modelling initial RAM as Device(s). Which in its own turn should allow to cleanup NUMA/HMP/memory accounting code more by dropping ad-hoc node_mem tracking and reusing memory device enumeration instead. Reference to previous versions: * https://www.mail-archive.com/qemu-devel@nongnu.org/msg617694.html CC: libvir-list(a)redhat.com CC: ehabkost(a)redhat.com CC: pbonzini(a)redhat.com CC: berrange(a)redhat.com CC: armbru(a)redhat.com Igor Mammedov (3): machine: show if CLI option '-numa node,mem' is supported in QAPI schema numa: deprecate 'mem' parameter of '-numa node' option numa: deprecate implict memory distribution between nodes include/hw/boards.h | 3 +++ hw/arm/virt.c | 1 + hw/i386/pc.c | 1 + hw/ppc/spapr.c | 1 + numa.c | 5 +++++ qapi/misc.json | 5 ++++- qemu-deprecated.texi | 24 ++++++++++++++++++++++++ vl.c | 1 + 8 files changed, 40 insertions(+), 1 deletion(-) -- 2.7.4

4 15

[libvirt] [PATCH] build: Require cppi for syntax-check
by Michal Privoznik 17 Jun '19

17 Jun '19

Since its introduction in v0.8.0~314 we allowed for cppi to be not present for 'syntax-check' because the package did exist in Fedora Core 12. Well, we don't care anymore ¯\_(ツ)_/¯ All recent distros have it. Moreover, it's fairly easy to miss 'cppi not installed' message in sea of syntax-check output (esp. for newbies who probably benefit from it the most). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- cfg.mk | 32 ++++++++++++-------------------- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/cfg.mk b/cfg.mk index 5074ef611a..dd0a177fb3 100644 --- a/cfg.mk +++ b/cfg.mk @@ -697,30 +697,22 @@ sc_require_whitespace_in_translation: # Enforce recommended preprocessor indentation style. sc_preprocessor_indentation: - @if cppi --version >/dev/null 2>&1; then \ - $(VC_LIST_EXCEPT) | $(GREP) -E '\.[ch](\.in)?$$' | xargs cppi -a -c \ - || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \ - exit 1; }; \ - else \ - echo '$(ME): skipping test $@: cppi not installed' 1>&2; \ - fi + @$(VC_LIST_EXCEPT) | $(GREP) -E '\.[ch](\.in)?$$' | xargs cppi -a -c \ + || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \ + exit 1; }; # Enforce similar spec file indentation style, by running cppi on a # (comment-only) C file that mirrors the same layout as the spec file. sc_spec_indentation: - @if cppi --version >/dev/null 2>&1; then \ - for f in $$($(VC_LIST_EXCEPT) | $(GREP) '\.spec\.in$$'); do \ - $(SED) -e 's|#|// #|; s|%ifn*$arch$* |#if a // |' \ - -e 's/%$else\|endif\|define$/#\1/' \ - -e 's/^$ *$\1\1\1#/#\1/' \ - -e 's|^$ *[^#/ ]$|// \1|; s|^$ */[^/]$|// \1|' $$f \ - | cppi -a -c 2>&1 | $(SED) "s|standard input|$$f|"; \ - done | { if $(GREP) . >&2; then false; else :; fi; } \ - || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \ - exit 1; }; \ - else \ - echo '$(ME): skipping test $@: cppi not installed' 1>&2; \ - fi + @for f in $$($(VC_LIST_EXCEPT) | $(GREP) '\.spec\.in$$'); do \ + $(SED) -e 's|#|// #|; s|%ifn*$arch$* |#if a // |' \ + -e 's/%$else\|endif\|define$/#\1/' \ + -e 's/^$ *$\1\1\1#/#\1/' \ + -e 's|^$ *[^#/ ]$|// \1|; s|^$ */[^/]$|// \1|' $$f \ + | cppi -a -c 2>&1 | $(SED) "s|standard input|$$f|"; \ + done | { if $(GREP) . >&2; then false; else :; fi; } \ + || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \ + exit 1; }; # Nested conditionals are easier to understand if we enforce that endifs # can be paired back to the if -- 2.21.0

6 7

[libvirt] [PATCH 0/7] Validate spapr-vio addresses as 32-bit
by Andrea Bolognani 17 Jun '19

17 Jun '19

An alternative take on David Gibson's patch https://www.redhat.com/archives/libvir-list/2019-June/msg00061.html from earlier this month. Andrea Bolognani (7): docs: Fix validation of spapr-vio addresses qemu: Rework qemuDomainDeviceDefValidateAddress() qemu: Validate spapr-vio addresses tests: Add pseries-spaprvio-invalid conf: Format spapr-vio addresses as 32-bit qemu: Format spapr-vio addresses as 32-bit docs: Update documentation for spapr-vio addresses docs/formatdomain.html.in | 6 +-- docs/schemas/domaincommon.rng | 2 +- src/conf/domain_conf.c | 2 +- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_domain.c | 41 ++++++++++++++++++- tests/qemuargv2xmldata/nomachine-ppc64.xml | 2 +- tests/qemuargv2xmldata/pseries-disk.xml | 2 +- tests/qemuargv2xmldata/pseries-nvram.xml | 2 +- .../disk-scsi.x86_64-latest.args | 2 +- .../pseries-spaprvio-invalid.xml | 17 ++++++++ .../pseries-vio-user-assigned.args | 2 +- tests/qemuxml2argvdata/pseries-vio.args | 4 +- tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/disk-scsi.xml | 2 +- tests/qemuxml2xmloutdata/pseries-nvram.xml | 2 +- 15 files changed, 73 insertions(+), 16 deletions(-) create mode 100644 tests/qemuxml2argvdata/pseries-spaprvio-invalid.xml -- 2.21.0

2 8

[libvirt] [PATCH 0/3] docs: storage: document 'lvm2' disk fun
by Ján Tomko 17 Jun '19

17 Jun '19

Ján Tomko (3): docs: storage: fix spacing when enumerating volume formats docs: storage: type out two docs: storage: document the 'lvm2' disk format oddness docs/storage.html.in | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) -- 2.20.1

2 4

[libvirt] [RFC PATCH 0/5] qemu: drop command line parsing
by Peter Krempa 16 Jun '19

16 Jun '19

All the code is mostly outdated and does not really help in most cases. Since this was already proposed and I did not see anything against here are the patches. As a follow up I'll refactor and move the rest of qemu_parse_command.c once this is out of the way. you can fetch this by git fetch https://github.com/pipo/libvirt.git parse-command-delete Peter Krempa (5): qemu: driver: Drop support for qemu-attach qemu: parse: Drop qemuParseCommandLinePid and friends qemu: driver: Remove support for native->XML conversion tests: Drop qemuargv2xmltest qemu: parse: Drop unused qemu command line parsing infrastructure src/check-aclrules.pl | 1 + src/qemu/qemu_domain.c | 2 + src/qemu/qemu_driver.c | 125 +- src/qemu/qemu_parse_command.c | 2714 +---------------- src/qemu/qemu_parse_command.h | 23 - tests/Makefile.am | 11 +- tests/qemuargv2xmldata/boot-cdrom.args | 22 - tests/qemuargv2xmldata/boot-cdrom.xml | 35 - tests/qemuargv2xmldata/boot-floppy.args | 23 - tests/qemuargv2xmldata/boot-floppy.xml | 41 - tests/qemuargv2xmldata/boot-network.args | 22 - tests/qemuargv2xmldata/boot-network.xml | 34 - tests/qemuargv2xmldata/clock-localtime.args | 23 - tests/qemuargv2xmldata/clock-localtime.xml | 34 - tests/qemuargv2xmldata/clock-utc.args | 22 - tests/qemuargv2xmldata/clock-utc.xml | 34 - tests/qemuargv2xmldata/console-compat.args | 22 - tests/qemuargv2xmldata/console-compat.xml | 42 - tests/qemuargv2xmldata/disk-cdrom-empty.args | 23 - tests/qemuargv2xmldata/disk-cdrom-empty.xml | 40 - tests/qemuargv2xmldata/disk-cdrom.args | 23 - tests/qemuargv2xmldata/disk-cdrom.xml | 41 - .../disk-drive-boot-cdrom.args | 23 - .../disk-drive-boot-cdrom.xml | 41 - .../disk-drive-boot-disk.args | 23 - .../qemuargv2xmldata/disk-drive-boot-disk.xml | 41 - .../disk-drive-cache-directsync.args | 24 - .../disk-drive-cache-directsync.xml | 41 - .../disk-drive-cache-unsafe.args | 24 - .../disk-drive-cache-unsafe.xml | 41 - .../disk-drive-cache-v2-none.args | 23 - .../disk-drive-cache-v2-none.xml | 41 - .../disk-drive-cache-v2-wb.args | 24 - .../disk-drive-cache-v2-wb.xml | 41 - .../disk-drive-cache-v2-wt.args | 24 - .../disk-drive-cache-v2-wt.xml | 41 - .../disk-drive-error-policy-enospace.args | 24 - .../disk-drive-error-policy-enospace.xml | 41 - .../disk-drive-error-policy-stop.args | 24 - .../disk-drive-error-policy-stop.xml | 41 - ...sk-drive-error-policy-wreport-rignore.args | 24 - ...isk-drive-error-policy-wreport-rignore.xml | 41 - .../qemuargv2xmldata/disk-drive-fmt-qcow.args | 23 - .../qemuargv2xmldata/disk-drive-fmt-qcow.xml | 41 - .../disk-drive-network-gluster.args | 25 - .../disk-drive-network-gluster.xml | 41 - .../disk-drive-network-iscsi-auth.args | 25 - .../disk-drive-network-iscsi-auth.xml | 44 - .../disk-drive-network-iscsi.args | 25 - .../disk-drive-network-iscsi.xml | 41 - .../disk-drive-network-nbd-export.args | 23 - .../disk-drive-network-nbd-export.xml | 42 - .../disk-drive-network-nbd-ipv6-export.args | 23 - .../disk-drive-network-nbd-ipv6-export.xml | 42 - .../disk-drive-network-nbd-ipv6.args | 23 - .../disk-drive-network-nbd-ipv6.xml | 42 - .../disk-drive-network-nbd-unix.args | 23 - .../disk-drive-network-nbd-unix.xml | 42 - .../disk-drive-network-nbd.args | 23 - .../disk-drive-network-nbd.xml | 42 - .../disk-drive-network-rbd-auth.args | 26 - .../disk-drive-network-rbd-auth.xml | 47 - .../disk-drive-network-rbd-ceph-env.args | 25 - .../disk-drive-network-rbd-ceph-env.xml | 44 - .../disk-drive-network-rbd-ipv6.args | 25 - .../disk-drive-network-rbd-ipv6.xml | 45 - .../disk-drive-network-rbd.args | 29 - .../disk-drive-network-rbd.xml | 72 - .../disk-drive-network-sheepdog.args | 23 - .../disk-drive-network-sheepdog.xml | 42 - tests/qemuargv2xmldata/disk-floppy.args | 24 - tests/qemuargv2xmldata/disk-floppy.xml | 47 - tests/qemuargv2xmldata/disk-many.args | 25 - tests/qemuargv2xmldata/disk-many.xml | 52 - tests/qemuargv2xmldata/disk-usb.args | 23 - tests/qemuargv2xmldata/disk-usb.xml | 39 - tests/qemuargv2xmldata/disk-virtio.args | 25 - tests/qemuargv2xmldata/disk-virtio.xml | 53 - .../graphics-sdl-fullscreen.args | 25 - .../graphics-sdl-fullscreen.xml | 39 - tests/qemuargv2xmldata/graphics-sdl.args | 24 - tests/qemuargv2xmldata/graphics-sdl.xml | 39 - .../qemuargv2xmldata/graphics-vnc-policy.args | 23 - .../qemuargv2xmldata/graphics-vnc-policy.xml | 41 - tests/qemuargv2xmldata/graphics-vnc-sasl.args | 24 - tests/qemuargv2xmldata/graphics-vnc-sasl.xml | 41 - .../qemuargv2xmldata/graphics-vnc-socket.args | 23 - .../qemuargv2xmldata/graphics-vnc-socket.xml | 41 - tests/qemuargv2xmldata/graphics-vnc-tls.args | 24 - tests/qemuargv2xmldata/graphics-vnc-tls.xml | 41 - .../graphics-vnc-websocket.args | 22 - .../graphics-vnc-websocket.xml | 32 - tests/qemuargv2xmldata/graphics-vnc.args | 23 - tests/qemuargv2xmldata/graphics-vnc.xml | 41 - .../qemuargv2xmldata/hostdev-pci-address.args | 23 - .../qemuargv2xmldata/hostdev-pci-address.xml | 40 - .../qemuargv2xmldata/hostdev-usb-address.args | 23 - .../qemuargv2xmldata/hostdev-usb-address.xml | 39 - tests/qemuargv2xmldata/hyperv-panic.args | 21 - tests/qemuargv2xmldata/hyperv-panic.xml | 29 - tests/qemuargv2xmldata/hyperv.args | 21 - tests/qemuargv2xmldata/hyperv.xml | 33 - tests/qemuargv2xmldata/input-usbmouse.args | 23 - tests/qemuargv2xmldata/input-usbmouse.xml | 35 - tests/qemuargv2xmldata/input-usbtablet.args | 23 - tests/qemuargv2xmldata/input-usbtablet.xml | 35 - tests/qemuargv2xmldata/kvm-features.args | 21 - tests/qemuargv2xmldata/kvm-features.xml | 31 - tests/qemuargv2xmldata/kvmclock.args | 22 - tests/qemuargv2xmldata/kvmclock.xml | 30 - .../machine-aeskeywrap-off-argv.args | 18 - .../machine-aeskeywrap-off-argv.xml | 23 - .../machine-aeskeywrap-on-argv.args | 18 - .../machine-aeskeywrap-on-argv.xml | 23 - tests/qemuargv2xmldata/machine-core-off.args | 22 - tests/qemuargv2xmldata/machine-core-off.xml | 34 - tests/qemuargv2xmldata/machine-core-on.args | 22 - tests/qemuargv2xmldata/machine-core-on.xml | 34 - .../machine-deakeywrap-off-argv.args | 18 - .../machine-deakeywrap-off-argv.xml | 23 - .../machine-deakeywrap-on-argv.args | 18 - .../machine-deakeywrap-on-argv.xml | 23 - .../machine-keywrap-none-argv.args | 18 - .../machine-keywrap-none-argv.xml | 20 - .../qemuargv2xmldata/mem-scale-maxmemory.args | 22 - .../qemuargv2xmldata/mem-scale-maxmemory.xml | 38 - tests/qemuargv2xmldata/mem-scale.args | 22 - tests/qemuargv2xmldata/mem-scale.xml | 37 - tests/qemuargv2xmldata/migrate.args | 23 - tests/qemuargv2xmldata/migrate.xml | 34 - tests/qemuargv2xmldata/misc-acpi.args | 21 - tests/qemuargv2xmldata/misc-acpi.xml | 37 - tests/qemuargv2xmldata/misc-disable-s3.args | 23 - tests/qemuargv2xmldata/misc-disable-s3.xml | 37 - .../misc-disable-suspends.args | 24 - .../misc-disable-suspends.xml | 38 - tests/qemuargv2xmldata/misc-enable-s4.args | 23 - tests/qemuargv2xmldata/misc-enable-s4.xml | 37 - tests/qemuargv2xmldata/misc-no-reboot.args | 23 - tests/qemuargv2xmldata/misc-no-reboot.xml | 34 - tests/qemuargv2xmldata/misc-uuid.args | 21 - tests/qemuargv2xmldata/misc-uuid.xml | 37 - tests/qemuargv2xmldata/net-eth-ifname.args | 23 - tests/qemuargv2xmldata/net-eth-ifname.xml | 41 - tests/qemuargv2xmldata/net-eth.args | 23 - tests/qemuargv2xmldata/net-eth.xml | 40 - tests/qemuargv2xmldata/net-user.args | 23 - tests/qemuargv2xmldata/net-user.xml | 39 - tests/qemuargv2xmldata/net-virtio.args | 23 - tests/qemuargv2xmldata/net-virtio.xml | 39 - .../nographics-vga-display.args | 23 - .../nographics-vga-display.xml | 34 - tests/qemuargv2xmldata/nographics-vga.args | 23 - tests/qemuargv2xmldata/nographics-vga.xml | 34 - tests/qemuargv2xmldata/nomachine-ppc64.args | 11 - tests/qemuargv2xmldata/nomachine-ppc64.xml | 50 - tests/qemuargv2xmldata/nomachine-x86_64.args | 11 - tests/qemuargv2xmldata/nomachine-x86_64.xml | 49 - tests/qemuargv2xmldata/nosharepages.args | 22 - tests/qemuargv2xmldata/nosharepages.xml | 37 - tests/qemuargv2xmldata/parallel-tcp.args | 22 - tests/qemuargv2xmldata/parallel-tcp.xml | 39 - tests/qemuargv2xmldata/pseries-disk.args | 18 - tests/qemuargv2xmldata/pseries-disk.xml | 50 - tests/qemuargv2xmldata/pseries-nvram.args | 22 - tests/qemuargv2xmldata/pseries-nvram.xml | 30 - tests/qemuargv2xmldata/qemu-ns-no-env.args | 23 - tests/qemuargv2xmldata/qemu-ns-no-env.xml | 38 - .../reboot-timeout-disabled.args | 21 - .../reboot-timeout-disabled.xml | 26 - .../reboot-timeout-enabled.args | 21 - .../reboot-timeout-enabled.xml | 26 - tests/qemuargv2xmldata/restore-v2.args | 23 - tests/qemuargv2xmldata/restore-v2.xml | 34 - tests/qemuargv2xmldata/serial-dev.args | 22 - tests/qemuargv2xmldata/serial-dev.xml | 44 - tests/qemuargv2xmldata/serial-file.args | 22 - tests/qemuargv2xmldata/serial-file.xml | 44 - tests/qemuargv2xmldata/serial-many.args | 23 - tests/qemuargv2xmldata/serial-many.xml | 48 - tests/qemuargv2xmldata/serial-pty.args | 22 - tests/qemuargv2xmldata/serial-pty.xml | 42 - tests/qemuargv2xmldata/serial-tcp-telnet.args | 22 - tests/qemuargv2xmldata/serial-tcp-telnet.xml | 46 - tests/qemuargv2xmldata/serial-tcp.args | 22 - tests/qemuargv2xmldata/serial-tcp.xml | 46 - tests/qemuargv2xmldata/serial-udp.args | 23 - tests/qemuargv2xmldata/serial-udp.xml | 52 - tests/qemuargv2xmldata/serial-unix.args | 22 - tests/qemuargv2xmldata/serial-unix.xml | 44 - tests/qemuargv2xmldata/serial-vc.args | 22 - tests/qemuargv2xmldata/serial-vc.xml | 42 - tests/qemuargv2xmldata/smp.args | 22 - tests/qemuargv2xmldata/smp.xml | 37 - tests/qemuargv2xmldata/sound.args | 23 - tests/qemuargv2xmldata/sound.xml | 42 - tests/qemuargv2xmldata/watchdog.args | 24 - tests/qemuargv2xmldata/watchdog.xml | 35 - tests/qemuargv2xmltest.c | 323 -- tests/virschematest.c | 2 +- 200 files changed, 18 insertions(+), 9093 deletions(-) delete mode 100644 tests/qemuargv2xmldata/boot-cdrom.args delete mode 100644 tests/qemuargv2xmldata/boot-cdrom.xml delete mode 100644 tests/qemuargv2xmldata/boot-floppy.args delete mode 100644 tests/qemuargv2xmldata/boot-floppy.xml delete mode 100644 tests/qemuargv2xmldata/boot-network.args delete mode 100644 tests/qemuargv2xmldata/boot-network.xml delete mode 100644 tests/qemuargv2xmldata/clock-localtime.args delete mode 100644 tests/qemuargv2xmldata/clock-localtime.xml delete mode 100644 tests/qemuargv2xmldata/clock-utc.args delete mode 100644 tests/qemuargv2xmldata/clock-utc.xml delete mode 100644 tests/qemuargv2xmldata/console-compat.args delete mode 100644 tests/qemuargv2xmldata/console-compat.xml delete mode 100644 tests/qemuargv2xmldata/disk-cdrom-empty.args delete mode 100644 tests/qemuargv2xmldata/disk-cdrom-empty.xml delete mode 100644 tests/qemuargv2xmldata/disk-cdrom.args delete mode 100644 tests/qemuargv2xmldata/disk-cdrom.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-boot-cdrom.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-boot-cdrom.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-boot-disk.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-boot-disk.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-directsync.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-directsync.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-unsafe.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-unsafe.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-none.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-none.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-wb.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-wb.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-wt.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-cache-v2-wt.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-enospace.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-enospace.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-stop.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-stop.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-wreport-rignore.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-error-policy-wreport-rignore.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-fmt-qcow.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-fmt-qcow.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-gluster.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-gluster.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-iscsi-auth.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-iscsi-auth.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-iscsi.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-iscsi.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-export.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-export.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-ipv6-export.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-ipv6-export.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-ipv6.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-ipv6.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-unix.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd-unix.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-nbd.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-auth.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-auth.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-ceph-env.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-ceph-env.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-ipv6.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd-ipv6.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-rbd.xml delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-sheepdog.args delete mode 100644 tests/qemuargv2xmldata/disk-drive-network-sheepdog.xml delete mode 100644 tests/qemuargv2xmldata/disk-floppy.args delete mode 100644 tests/qemuargv2xmldata/disk-floppy.xml delete mode 100644 tests/qemuargv2xmldata/disk-many.args delete mode 100644 tests/qemuargv2xmldata/disk-many.xml delete mode 100644 tests/qemuargv2xmldata/disk-usb.args delete mode 100644 tests/qemuargv2xmldata/disk-usb.xml delete mode 100644 tests/qemuargv2xmldata/disk-virtio.args delete mode 100644 tests/qemuargv2xmldata/disk-virtio.xml delete mode 100644 tests/qemuargv2xmldata/graphics-sdl-fullscreen.args delete mode 100644 tests/qemuargv2xmldata/graphics-sdl-fullscreen.xml delete mode 100644 tests/qemuargv2xmldata/graphics-sdl.args delete mode 100644 tests/qemuargv2xmldata/graphics-sdl.xml delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-policy.args delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-policy.xml delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-sasl.args delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-sasl.xml delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-socket.args delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-socket.xml delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-tls.args delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-tls.xml delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-websocket.args delete mode 100644 tests/qemuargv2xmldata/graphics-vnc-websocket.xml delete mode 100644 tests/qemuargv2xmldata/graphics-vnc.args delete mode 100644 tests/qemuargv2xmldata/graphics-vnc.xml delete mode 100644 tests/qemuargv2xmldata/hostdev-pci-address.args delete mode 100644 tests/qemuargv2xmldata/hostdev-pci-address.xml delete mode 100644 tests/qemuargv2xmldata/hostdev-usb-address.args delete mode 100644 tests/qemuargv2xmldata/hostdev-usb-address.xml delete mode 100644 tests/qemuargv2xmldata/hyperv-panic.args delete mode 100644 tests/qemuargv2xmldata/hyperv-panic.xml delete mode 100644 tests/qemuargv2xmldata/hyperv.args delete mode 100644 tests/qemuargv2xmldata/hyperv.xml delete mode 100644 tests/qemuargv2xmldata/input-usbmouse.args delete mode 100644 tests/qemuargv2xmldata/input-usbmouse.xml delete mode 100644 tests/qemuargv2xmldata/input-usbtablet.args delete mode 100644 tests/qemuargv2xmldata/input-usbtablet.xml delete mode 100644 tests/qemuargv2xmldata/kvm-features.args delete mode 100644 tests/qemuargv2xmldata/kvm-features.xml delete mode 100644 tests/qemuargv2xmldata/kvmclock.args delete mode 100644 tests/qemuargv2xmldata/kvmclock.xml delete mode 100644 tests/qemuargv2xmldata/machine-aeskeywrap-off-argv.args delete mode 100644 tests/qemuargv2xmldata/machine-aeskeywrap-off-argv.xml delete mode 100644 tests/qemuargv2xmldata/machine-aeskeywrap-on-argv.args delete mode 100644 tests/qemuargv2xmldata/machine-aeskeywrap-on-argv.xml delete mode 100644 tests/qemuargv2xmldata/machine-core-off.args delete mode 100644 tests/qemuargv2xmldata/machine-core-off.xml delete mode 100644 tests/qemuargv2xmldata/machine-core-on.args delete mode 100644 tests/qemuargv2xmldata/machine-core-on.xml delete mode 100644 tests/qemuargv2xmldata/machine-deakeywrap-off-argv.args delete mode 100644 tests/qemuargv2xmldata/machine-deakeywrap-off-argv.xml delete mode 100644 tests/qemuargv2xmldata/machine-deakeywrap-on-argv.args delete mode 100644 tests/qemuargv2xmldata/machine-deakeywrap-on-argv.xml delete mode 100644 tests/qemuargv2xmldata/machine-keywrap-none-argv.args delete mode 100644 tests/qemuargv2xmldata/machine-keywrap-none-argv.xml delete mode 100644 tests/qemuargv2xmldata/mem-scale-maxmemory.args delete mode 100644 tests/qemuargv2xmldata/mem-scale-maxmemory.xml delete mode 100644 tests/qemuargv2xmldata/mem-scale.args delete mode 100644 tests/qemuargv2xmldata/mem-scale.xml delete mode 100644 tests/qemuargv2xmldata/migrate.args delete mode 100644 tests/qemuargv2xmldata/migrate.xml delete mode 100644 tests/qemuargv2xmldata/misc-acpi.args delete mode 100644 tests/qemuargv2xmldata/misc-acpi.xml delete mode 100644 tests/qemuargv2xmldata/misc-disable-s3.args delete mode 100644 tests/qemuargv2xmldata/misc-disable-s3.xml delete mode 100644 tests/qemuargv2xmldata/misc-disable-suspends.args delete mode 100644 tests/qemuargv2xmldata/misc-disable-suspends.xml delete mode 100644 tests/qemuargv2xmldata/misc-enable-s4.args delete mode 100644 tests/qemuargv2xmldata/misc-enable-s4.xml delete mode 100644 tests/qemuargv2xmldata/misc-no-reboot.args delete mode 100644 tests/qemuargv2xmldata/misc-no-reboot.xml delete mode 100644 tests/qemuargv2xmldata/misc-uuid.args delete mode 100644 tests/qemuargv2xmldata/misc-uuid.xml delete mode 100644 tests/qemuargv2xmldata/net-eth-ifname.args delete mode 100644 tests/qemuargv2xmldata/net-eth-ifname.xml delete mode 100644 tests/qemuargv2xmldata/net-eth.args delete mode 100644 tests/qemuargv2xmldata/net-eth.xml delete mode 100644 tests/qemuargv2xmldata/net-user.args delete mode 100644 tests/qemuargv2xmldata/net-user.xml delete mode 100644 tests/qemuargv2xmldata/net-virtio.args delete mode 100644 tests/qemuargv2xmldata/net-virtio.xml delete mode 100644 tests/qemuargv2xmldata/nographics-vga-display.args delete mode 100644 tests/qemuargv2xmldata/nographics-vga-display.xml delete mode 100644 tests/qemuargv2xmldata/nographics-vga.args delete mode 100644 tests/qemuargv2xmldata/nographics-vga.xml delete mode 100644 tests/qemuargv2xmldata/nomachine-ppc64.args delete mode 100644 tests/qemuargv2xmldata/nomachine-ppc64.xml delete mode 100644 tests/qemuargv2xmldata/nomachine-x86_64.args delete mode 100644 tests/qemuargv2xmldata/nomachine-x86_64.xml delete mode 100644 tests/qemuargv2xmldata/nosharepages.args delete mode 100644 tests/qemuargv2xmldata/nosharepages.xml delete mode 100644 tests/qemuargv2xmldata/parallel-tcp.args delete mode 100644 tests/qemuargv2xmldata/parallel-tcp.xml delete mode 100644 tests/qemuargv2xmldata/pseries-disk.args delete mode 100644 tests/qemuargv2xmldata/pseries-disk.xml delete mode 100644 tests/qemuargv2xmldata/pseries-nvram.args delete mode 100644 tests/qemuargv2xmldata/pseries-nvram.xml delete mode 100644 tests/qemuargv2xmldata/qemu-ns-no-env.args delete mode 100644 tests/qemuargv2xmldata/qemu-ns-no-env.xml delete mode 100644 tests/qemuargv2xmldata/reboot-timeout-disabled.args delete mode 100644 tests/qemuargv2xmldata/reboot-timeout-disabled.xml delete mode 100644 tests/qemuargv2xmldata/reboot-timeout-enabled.args delete mode 100644 tests/qemuargv2xmldata/reboot-timeout-enabled.xml delete mode 100644 tests/qemuargv2xmldata/restore-v2.args delete mode 100644 tests/qemuargv2xmldata/restore-v2.xml delete mode 100644 tests/qemuargv2xmldata/serial-dev.args delete mode 100644 tests/qemuargv2xmldata/serial-dev.xml delete mode 100644 tests/qemuargv2xmldata/serial-file.args delete mode 100644 tests/qemuargv2xmldata/serial-file.xml delete mode 100644 tests/qemuargv2xmldata/serial-many.args delete mode 100644 tests/qemuargv2xmldata/serial-many.xml delete mode 100644 tests/qemuargv2xmldata/serial-pty.args delete mode 100644 tests/qemuargv2xmldata/serial-pty.xml delete mode 100644 tests/qemuargv2xmldata/serial-tcp-telnet.args delete mode 100644 tests/qemuargv2xmldata/serial-tcp-telnet.xml delete mode 100644 tests/qemuargv2xmldata/serial-tcp.args delete mode 100644 tests/qemuargv2xmldata/serial-tcp.xml delete mode 100644 tests/qemuargv2xmldata/serial-udp.args delete mode 100644 tests/qemuargv2xmldata/serial-udp.xml delete mode 100644 tests/qemuargv2xmldata/serial-unix.args delete mode 100644 tests/qemuargv2xmldata/serial-unix.xml delete mode 100644 tests/qemuargv2xmldata/serial-vc.args delete mode 100644 tests/qemuargv2xmldata/serial-vc.xml delete mode 100644 tests/qemuargv2xmldata/smp.args delete mode 100644 tests/qemuargv2xmldata/smp.xml delete mode 100644 tests/qemuargv2xmldata/sound.args delete mode 100644 tests/qemuargv2xmldata/sound.xml delete mode 100644 tests/qemuargv2xmldata/watchdog.args delete mode 100644 tests/qemuargv2xmldata/watchdog.xml delete mode 100644 tests/qemuargv2xmltest.c -- 2.21.0

3 12

[libvirt] [PATCH 00/12] tests: remove text monitor testing infrastructure
by Ján Tomko 16 Jun '19

16 Jun '19

Ján Tomko (12): tests: assume JSON monitor in qemuMonitorTestNewSimple tests: always assume JSON in qemuMonitorTestNew tests: qemuMonitorTestAddErrorResponse: use VIR_AUTOFREE tests: qemuMonitorTestProcessCommandDefaultValidate: simplify condition tests: assume JSON in qemuMonitorTestIO tests: qemuMonitorReportError: use tmp variable properly tests: remove text monitor testing infrastructure tests: qemuMonitorReportError: use VIR_AUTOFREE tests: refactor qemuMonitorTestProcessCommandDefault tests: refactor qemuMonitorTestProcessCommandDefaultValidate tests: qemuMonitorTestAddUnexpectedErrorResponse: VIR_AUTOFREE tests: qemuMonitorTestAddInvalidCommandResponse: VIR_AUTOFREE tests/qemuhotplugtest.c | 2 +- tests/qemumonitortestutils.c | 235 ++++++++++++----------------------- tests/qemumonitortestutils.h | 9 +- 3 files changed, 84 insertions(+), 162 deletions(-) -- 2.20.1

2 16

[libvirt] [PATCH 00/19] Use '#pragma once' in headers
by Jonathon Jongsma 14 Jun '19

14 Jun '19

Hi all, I'm trying to get up to speed with libvirt code, so I decided to start out with a slightly "mindless" task. I grabbed the '#pragma once' task from https://wiki.libvirt.org/page/BiteSizedTasks. This series covers the first part of the conversion. I chatted with Daniel Berrange briefly on IRC before starting, and he suggested that I should try to keep patches under 100k, and maybe each driver's source files as a single patch. I had a bit of difficulty deciding where to split the src/conf/ and src/util/ directories. So some of the files with more changes ended up being single-file patches. I tried to combine some related source files into patches, but at a certain point I ran out of obvious files to combine, so I combined a bunch of smaller miscellaneous files into one larger patch. It may not be ideal, but it's the best I could come up with. Alternative suggestions welcome. I'll follow up with the remaining changes if this division looks acceptable. Jonathon Jongsma (19): Use #pragma once in driver headers src/access: use #pragma once in headers src/admin: use #pragma once in headers src/bhyve: use #pragma once in headers conf: domain: use #pragma once in headers conf: network: use #pragma once in headers conf: nwfilter: use #pragma once in headers conf: node device: use #pragma once in headers conf: storage: use #pragma once in headers conf: misc: use #pragma once in headers src/cpu: use #pragma once in headers src/datatypes.h: use #pragma once src/esx: use #pragma once in headers src/hyperv: use #pragma once in headers src/interface: use #pragma once in headers src/internal.h: use #pragma once src/libvirt_internal.h: use #pragma once src/libxl: use #pragma once in headers src/logging: use #pragma once in headers src/access/viraccessdriver.h | 10 +- src/access/viraccessdrivernop.h | 7 +- src/access/viraccessdriverpolkit.h | 7 +- src/access/viraccessdriverstack.h | 7 +- src/access/viraccessmanager.h | 26 +-- src/access/viraccessperm.h | 11 +- src/admin/admin_server.h | 9 +- src/admin/admin_server_dispatch.h | 11 +- src/bhyve/bhyve_capabilities.h | 11 +- src/bhyve/bhyve_command.h | 15 +- src/bhyve/bhyve_conf.h | 7 +- src/bhyve/bhyve_device.h | 11 +- src/bhyve/bhyve_domain.h | 11 +- src/bhyve/bhyve_driver.h | 9 +- src/bhyve/bhyve_monitor.h | 11 +- src/bhyve/bhyve_parse_command.h | 5 +- src/bhyve/bhyve_process.h | 7 +- src/bhyve/bhyve_utils.h | 31 ++- src/conf/capabilities.h | 23 +-- src/conf/cpu_conf.h | 23 +-- src/conf/device_conf.h | 33 ++- src/conf/domain_addr.h | 16 +- src/conf/domain_audit.h | 10 +- src/conf/domain_capabilities.h | 15 +- src/conf/domain_conf.h | 91 ++++----- src/conf/domain_event.h | 11 +- src/conf/domain_nwfilter.h | 5 +- src/conf/interface_conf.h | 23 +-- src/conf/moment_conf.h | 11 +- src/conf/netdev_bandwidth_conf.h | 15 +- src/conf/netdev_vlan_conf.h | 13 +- src/conf/netdev_vport_profile_conf.h | 14 +- src/conf/network_conf.h | 52 +++-- src/conf/network_event.h | 11 +- src/conf/networkcommon_conf.h | 17 +- src/conf/node_device_conf.h | 31 ++- src/conf/node_device_event.h | 11 +- src/conf/node_device_util.h | 7 +- src/conf/numa_conf.h | 18 +- src/conf/nwfilter_conf.h | 93 ++++----- src/conf/nwfilter_ipaddrmap.h | 5 +- src/conf/nwfilter_params.h | 28 ++- src/conf/object_event.h | 11 +- src/conf/object_event_private.h | 7 +- src/conf/secret_conf.h | 15 +- src/conf/secret_event.h | 11 +- src/conf/snapshot_conf.h | 13 +- src/conf/storage_adapter_conf.h | 11 +- src/conf/storage_capabilities.h | 8 +- src/conf/storage_conf.h | 41 ++-- src/conf/storage_event.h | 11 +- src/conf/virchrdev.h | 9 +- src/conf/virconftypes.h | 5 +- src/conf/virdomainmomentobjlist.h | 17 +- src/conf/virdomainobjlist.h | 21 +- src/conf/virdomainsnapshotobjlist.h | 21 +- src/conf/virinterfaceobj.h | 7 +- src/conf/virnetworkobj.h | 9 +- src/conf/virnodedeviceobj.h | 13 +- src/conf/virnwfilterbindingdef.h | 13 +- src/conf/virnwfilterbindingobj.h | 11 +- src/conf/virnwfilterbindingobjlist.h | 8 +- src/conf/virnwfilterobj.h | 11 +- src/conf/virsavecookie.h | 13 +- src/conf/virsecretobj.h | 11 +- src/conf/virstorageobj.h | 11 +- src/cpu/cpu.h | 19 +- src/cpu/cpu_arm.h | 7 +- src/cpu/cpu_map.h | 7 +- src/cpu/cpu_ppc64.h | 7 +- src/cpu/cpu_ppc64_data.h | 8 +- src/cpu/cpu_s390.h | 7 +- src/cpu/cpu_x86.h | 9 +- src/cpu/cpu_x86_data.h | 58 +++--- src/datatypes.h | 89 ++++---- src/driver-hypervisor.h | 12 +- src/driver-interface.h | 12 +- src/driver-network.h | 12 +- src/driver-nodedev.h | 12 +- src/driver-nwfilter.h | 12 +- src/driver-secret.h | 12 +- src/driver-state.h | 12 +- src/driver-storage.h | 12 +- src/driver-stream.h | 12 +- src/driver.h | 37 ++-- src/esx/esx_driver.h | 5 +- src/esx/esx_interface_driver.h | 7 +- src/esx/esx_network_driver.h | 7 +- src/esx/esx_private.h | 15 +- src/esx/esx_storage_backend_iscsi.h | 7 +- src/esx/esx_storage_backend_vmfs.h | 7 +- src/esx/esx_storage_driver.h | 7 +- src/esx/esx_stream.h | 9 +- src/esx/esx_util.h | 13 +- src/esx/esx_vi.h | 37 ++-- src/esx/esx_vi_methods.h | 11 +- src/esx/esx_vi_types.h | 13 +- src/hyperv/hyperv_driver.h | 5 +- src/hyperv/hyperv_private.h | 13 +- src/hyperv/hyperv_util.h | 9 +- src/hyperv/hyperv_wmi.h | 21 +- src/hyperv/hyperv_wmi_classes.h | 27 ++- src/hyperv/openwsman.h | 35 ++-- src/interface/interface_driver.h | 5 +- src/internal.h | 295 +++++++++++++-------------- src/libvirt_internal.h | 7 +- src/libxl/libxl_capabilities.h | 29 ++- src/libxl/libxl_conf.h | 101 +++++---- src/libxl/libxl_domain.h | 29 ++- src/libxl/libxl_driver.h | 5 +- src/libxl/libxl_logger.h | 7 +- src/libxl/libxl_migration.h | 11 +- src/logging/log_daemon.h | 9 +- src/logging/log_daemon_config.h | 7 +- src/logging/log_daemon_dispatch.h | 7 +- src/logging/log_handler.h | 9 +- src/logging/log_manager.h | 9 +- 117 files changed, 928 insertions(+), 1296 deletions(-) -- 2.20.1

3 26

[libvirt] [PATCH] virNodeDeviceCapPCIDefFormat: Drop useless space before end of tags
by Michal Privoznik 13 Jun '19

13 Jun '19

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/conf/node_device_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 1db045d9ac..4ef92d5129 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -227,14 +227,14 @@ virNodeDeviceCapPCIDefFormat(virBufferPtr buf, virBufferEscapeString(buf, ">%s</product>\n", data->pci_dev.product_name); else - virBufferAddLit(buf, " />\n"); + virBufferAddLit(buf, "/>\n"); virBufferAsprintf(buf, "<vendor id='0x%04x'", data->pci_dev.vendor); if (data->pci_dev.vendor_name) virBufferEscapeString(buf, ">%s</vendor>\n", data->pci_dev.vendor_name); else - virBufferAddLit(buf, " />\n"); + virBufferAddLit(buf, "/>\n"); if (data->pci_dev.flags & VIR_NODE_DEV_CAP_FLAG_PCI_PHYSICAL_FUNCTION) { virBufferAddLit(buf, "<capability type='phys_function'>\n"); virBufferAdjustIndent(buf, 2); -- 2.21.0

1 0

[libvirt] [PATCH v2] qemu: fix pr-helper0 remain
by Jie Wang 13 Jun '19

13 Jun '19

If libvirt receive DISCONNECTED event and set prDaemonRunning to false, and qemuDomainRemoveDiskDevice is performing in the meantime. qemuDomainRemoveDiskDevice will return directly by prDaemonRunning check, so the pr-helper0 object will remain. In that case we should try harder and also kill the pr-helper process, so qemuProcessKillManagedPRDaemon could use the same treatment. Signed-off-by: Jie Wang <wangjie88(a)huawei.com> --- src/qemu/qemu_hotplug.c | 3 +-- src/qemu/qemu_process.c | 3 --- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 34249bd..5e4a929 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -465,8 +465,7 @@ qemuHotplugRemoveManagedPR(virQEMUDriverPtr driver, virErrorPtr orig_err; int ret = -1; - if (!priv->prDaemonRunning || - virDomainDefHasManagedPR(vm->def)) + if (virDomainDefHasManagedPR(vm->def)) return 0; virErrorPreserveLast(&orig_err); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 47d8ca2..8070a09 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2746,9 +2746,6 @@ qemuProcessKillManagedPRDaemon(virDomainObjPtr vm) virErrorPtr orig_err; char *pidfile; - if (!priv->prDaemonRunning) - return; - if (!(pidfile = qemuProcessBuildPRHelperPidfilePath(vm))) { VIR_WARN("Unable to construct pr-helper pidfile path"); return; -- 2.8.3.windows.1

2 1