- Devel - libvirt List Archives

[libvirt] [PATCH] parallels: don't forget to unlock domain after successful virDomainObjListFindByUUID call
by Maxim Nestratov 22 Apr '15

22 Apr '15

Also a typo is fixed (s/detached/attached/) Signed-off-by: Maxim Nestratov mnestratov(a)parallels.com --- src/parallels/parallels_driver.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 46e6c3e..41908a5 100644 --- a/src/parallels/parallels_driver.c +++ b/src/parallels/parallels_driver.c @@ -1081,7 +1081,7 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, privdom = virDomainObjListFindByUUID(privconn->domains, dom->uuid); if (privdom == NULL) { parallelsDomNotFoundError(dom); - goto cleanup; + return -1; } if (!(flags & VIR_DOMAIN_AFFECT_CONFIG)) { @@ -1120,13 +1120,14 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml, break; default: virReportError(VIR_ERR_OPERATION_UNSUPPORTED, - _("device type '%s' cannot be detached"), + _("device type '%s' cannot be attached"), virDomainDeviceTypeToString(dev->type)); break; } ret = 0; cleanup: + virObjectUnlock(privdom); return ret; } -- 1.7.1

2 2

[libvirt] [PATCH 0/3] Support libvirt's lock manager in the libxl driver
by Jim Fehlig 22 Apr '15

22 Apr '15

Patch 1 relaxes the requirement of PID != 0 in the locking code. danpb and I discussed this on IRC: danpb: jimfehlig: it wouldn't be the end of the world if you leave pid as 0 danpb: jimfehlig: it'd just loose some safety sanity check in that scenario Patch 2 introduces a config file for the libxl driver, with the lone config entry 'autoballoon'. I thought this would make review easier, vs adding all the config file support in patch 3, which is fairly large as is. Jim Fehlig (3): locking: relax PID requirement libxl: Introduce configuration file for libxl driver libxl: provide integration with lock manager libvirt.spec.in | 8 ++++ src/Makefile.am | 36 ++++++++++++++++- src/libxl/libvirtd_libxl.aug | 44 +++++++++++++++++++++ src/libxl/libxl.conf | 22 +++++++++++ src/libxl/libxl_conf.c | 75 +++++++++++++++++++++++++++++++++--- src/libxl/libxl_conf.h | 11 ++++++ src/libxl/libxl_domain.c | 47 +++++++++++++++++++++- src/libxl/libxl_domain.h | 1 + src/libxl/libxl_driver.c | 34 ++++++++++++++++ src/libxl/libxl_migration.c | 6 +++ src/libxl/test_libvirtd_libxl.aug.in | 6 +++ src/locking/lock_daemon.c | 2 +- src/locking/lock_daemon_dispatch.c | 49 +++++++---------------- src/locking/lock_driver_lockd.c | 7 +--- 14 files changed, 298 insertions(+), 50 deletions(-) create mode 100644 src/libxl/libvirtd_libxl.aug create mode 100644 src/libxl/libxl.conf create mode 100644 src/libxl/test_libvirtd_libxl.aug.in -- 1.8.4.5

2 10

[libvirt] [PATCH 0/2] Add tox.ini to run tests with tox
by Victor Stinner 22 Apr '15

22 Apr '15

Tox is a convinient tool creating virtual environment to install dependencies and run tests. To run all tests, just type "tox". To only test a specific Python version, use "tox -e py34" (Python 3.4). Victor Stinner (2): sanitytest.py parameters are now optional Add tox.ini to run tests on Python 2.6, 2.7 & 3.4 .gitignore | 1 + sanitytest.py | 23 ++++++++++++++++++----- tox.ini | 10 ++++++++++ 3 files changed, 29 insertions(+), 5 deletions(-) create mode 100644 tox.ini -- 2.1.0

4 8

[libvirt] [PATCH v2] libvirt-python: add classifiers to setup.py
by Victor Stinner 22 Apr '15

22 Apr '15

Add the Python 3 classifier, needed by the caniusepython3 tool to check if dependencies of a projects are Python 3 compatible: https://caniusepython3.com/ --- setup.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 79b048f..a8e9e86 100755 --- a/setup.py +++ b/setup.py @@ -325,4 +325,13 @@ setup(name = 'libvirt-python', 'sdist': my_sdist, 'rpm': my_rpm, 'test': my_test - }) + }, + classifiers = [ + "Development Status :: 5 - Production/Stable", + "Intended Audience :: Developers", + "License :: OSI Approved :: GNU Lesser General Public License v2 or later (LGPLv2+)", + "Programming Language :: Python", + "Programming Language :: Python :: 2", + "Programming Language :: Python :: 3", + ] +) -- 2.1.0

2 1

[libvirt] [PATCH] vircommand: fix polling in virCommandProcessIO
by Roman Bogorodskiy 22 Apr '15

22 Apr '15

When running on FreeBSD, there's a bug in virCommandProcessIO polling that is triggered by the commandtest. A test that triggers EPIPE in commandtest (named "test20") hungs forever on FreeBSD. Apparently, this happens because FreeBSD sets POLLHUP flag on revents when stdin in closed. And as the current implementation only checks for POLLOUT and POLLERR, it ends up looping forever inside virCommandProcessIO and not trying to do one more write() that would trigger EPIPE. To fix that check for the POLLHUP flag along with POLLOUT and POLLERR. --- src/util/vircommand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 648f5ed..f9b3c3f 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -2097,7 +2097,7 @@ virCommandProcessIO(virCommandPtr cmd) } } - if (fds[i].revents & (POLLOUT | POLLERR) && + if (fds[i].revents & (POLLOUT | POLLHUP | POLLERR) && fds[i].fd == cmd->inpipe) { int done; -- 2.3.5

2 2

[libvirt] [PATCH] schemas: capability: Add ostype 'aix'
by Cole Robinson 22 Apr '15

22 Apr '15

--- docs/schemas/capability.rng | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index 5f3ec70..3868ee2 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -266,6 +266,7 @@ <value>hvm</value>  <value>exe</value>  <value>uml</value>  + <value>aix</value>  </choice> </element> </define> -- 2.3.5

3 3

[libvirt] [PATCH] libvirt-python: add classifiers to setup.py
by Victor Stinner 22 Apr '15

22 Apr '15

Add the Python 3 classifier, needed by the caniusepython3 tool to check if dependencies of a projects are Python 3 compatible: https://caniusepython3.com/ --- setup.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 79b048f..116b3c0 100755 --- a/setup.py +++ b/setup.py @@ -325,4 +325,12 @@ setup(name = 'libvirt-python', 'sdist': my_sdist, 'rpm': my_rpm, 'test': my_test - }) + }, + classifiers = [ + "Development Status :: 5 - Production/Stable", + "Intended Audience :: Developers", + "License :: OSI Approved :: GNU Lesser General Public License v2 or later (LGPLv2+)", + "Programming Language :: Python", + "Programming Language :: Python :: 3", + ] +) -- 2.1.0

2 1

[libvirt] [PATCHv2]rework the check for the numa cpus
by Luyao Huang 22 Apr '15

22 Apr '15

V1 discussion: https://www.redhat.com/archives/libvir-list/2015-April/msg00919.html new for v2: remove 1/2 because no need introduce a new flag to avoid the broken introduced by the new check. We introduce a check for numa cpu total count in 5f7b71, But seems this check cannot work well. There are some scenarioes: 1. one of cpu id is out of maxvcpus, can set success(cpu count = 5 < 10): <vcpu placement='static'>10</vcpu> <cell id='0' cpus='0-3,100' memory='512000' unit='KiB'/> the cpus '100' exceed maxvcpus, this setting is not valid (although qemu do not output error). 2. use the same cpu in 2 cell, can set success(cpu count = 8 < 10): <vcpu placement='static'>10</vcpu> <cell id='0' cpus='0-3' memory='512000' unit='KiB'/> <cell id='1' cpus='0-3' memory='512000' unit='KiB'/> I guess nobody will use this setting if he really want use numa in his vm. (qemu not output error, but we can find some interesting things in vm, all cpus have bind in one numa node) 3. use the same cpu in 2 cell, cannot set success(cpu count = 11 > 10): <vcpu placement='static'>10</vcpu> <cell id='0' cpus='0-6' memory='512000' unit='KiB'/> <cell id='1' cpus='0-3' memory='512000' unit='KiB'/> No need forbid this scenario if scenario 2 is a 'valid' setting. However add new check during parse xml will make vm has broken settings disappear after update libvirtd, so possible solutions: 1. add new check when parse xml, i chose this way in this version. 2. add new check when start vm. I think this is a configuration issue, so no need report it so late. 3. just remove this check and do not add new check... :) Luyao Huang (1): conf: rework the cpu check for vm numa settings src/conf/domain_conf.c | 6 +----- src/conf/numa_conf.c | 37 ++++++++++++++++++++++++++++++------- src/conf/numa_conf.h | 2 +- 3 files changed, 32 insertions(+), 13 deletions(-) -- 1.8.3.1

2 3

[libvirt] [PATCH 0/3] util: storage: fix indexed access to backing store
by Peter Krempa 22 Apr '15

22 Apr '15

Improve error reporting when an index can't be found in the backing chain. Peter Krempa (3): util: storage: Fix possible crash when source path is NULL util: storage: Add hint to error message that indexed access was used util: storage: Improve error message when requesting image above 'start' src/util/virstoragefile.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) -- 2.3.5

2 7

[libvirt] [PATCH 0/2] misc cleanups
by Peter Krempa 22 Apr '15

22 Apr '15

Peter Krempa (2): qemu: migration: Refactor hostdev validation in migration check util: command: Deduplicate code in virCommandNewArgList src/qemu/qemu_migration.c | 15 ++++----------- src/util/vircommand.c | 10 +++------- 2 files changed, 7 insertions(+), 18 deletions(-) -- 2.3.5

2 4