- Devel - libvirt List Archives

[libvirt] [PATCH 1/1] nodeinfo: Increase the num of CPU thread siblings to a larger value
by Wei Huang 27 Mar '15

27 Mar '15

Current libvirt can only handle up to 1024 thread siblings when it reads Linux sysfs topology/thread_siblings. This isn't enough for Linux distributions that support a large value. This patch fixes the problem by using VIR_ALLOC()/VIR_FREE(), instead of using a fixed-size (1024) local char array. In the meanwhile SYSFS_THREAD_SIBLINGS_LIST_LENGTH_MAX is increased to 8192 which should be large enough for a foreseeable future. Signed-off-by: Wei Huang <wei(a)redhat.com> --- src/nodeinfo.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 34d27a6..66dc7ef 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -287,7 +287,7 @@ freebsdNodeGetMemoryStats(virNodeMemoryStatsPtr params, # define PROCSTAT_PATH "/proc/stat" # define MEMINFO_PATH "/proc/meminfo" # define SYSFS_MEMORY_SHARED_PATH "/sys/kernel/mm/ksm" -# define SYSFS_THREAD_SIBLINGS_LIST_LENGTH_MAX 1024 +# define SYSFS_THREAD_SIBLINGS_LIST_LENGTH_MAX 8192 # define LINUX_NB_CPU_STATS 4 # define LINUX_NB_MEMORY_STATS_ALL 4 @@ -345,7 +345,7 @@ virNodeCountThreadSiblings(const char *dir, unsigned int cpu) unsigned long ret = 0; char *path; FILE *pathfp; - char str[1024]; + char *str = NULL; size_t i; if (virAsprintf(&path, "%s/cpu%u/topology/thread_siblings", @@ -365,7 +365,10 @@ virNodeCountThreadSiblings(const char *dir, unsigned int cpu) return 0; } - if (fgets(str, sizeof(str), pathfp) == NULL) { + if (VIR_ALLOC_N(str, SYSFS_THREAD_SIBLINGS_LIST_LENGTH_MAX) < 0) + goto cleanup; + + if (fgets(str, SYSFS_THREAD_SIBLINGS_LIST_LENGTH_MAX, pathfp) == NULL) { virReportSystemError(errno, _("cannot read from %s"), path); goto cleanup; } @@ -382,6 +385,7 @@ virNodeCountThreadSiblings(const char *dir, unsigned int cpu) } cleanup: + VIR_FREE(str); VIR_FORCE_FCLOSE(pathfp); VIR_FREE(path); -- 1.8.3.1

3 5

[libvirt] qemu_migration: Precreate missing storage breaks with network drives
by Noel Burton-Krahn 27 Mar '15

27 Mar '15

Hi Michal, We're testing libvirt-1.2.13 and found it failed to live migrate domains with attached network drives. The change to libvirt was made in commit cf54c606, announced here: https://www.redhat.com/archives/libvir-list/2014-November/msg01053.html It's not necessary to precreate network drives. They're created during nova live migration in openstack. How about this patch? diff -U3 -r libvirt-1.2.13.orig/src/qemu/qemu_migration.c libvirt-1.2.13/src/qemu/qemu_migration.c --- libvirt-1.2.13.orig/src/qemu/qemu_migration.c 2015-02-23 22:04:12.000000000 -0800 +++ libvirt-1.2.13/src/qemu/qemu_migration.c 2015-03-18 12:18:14.137990147 -0700 @@ -1510,6 +1510,9 @@ case VIR_STORAGE_TYPE_BLOCK: case VIR_STORAGE_TYPE_DIR: case VIR_STORAGE_TYPE_NETWORK: + ret = 0; + goto cleanup; + break; case VIR_STORAGE_TYPE_NONE: case VIR_STORAGE_TYPE_LAST: virReportError(VIR_ERR_INTERNAL_ERROR, Cheers, -- Noel Burton-Krahn Sr, Distributed Systems Engineer Piston Cloud Computing

4 11

[libvirt] [libvirt-test-API][PATCH] Add connection_getDomainCapabilities test case
by jiahu 27 Mar '15

27 Mar '15

In the case, we will validate getDomainCapabilities API for libvirt. jiahu (1): Add connection_getDomainCapabilities test case cases/test_connection.conf | 10 + repos/virconn/connection_getDomainCapabilities.py | 438 ++++++++++++++++++++++ 2 files changed, 448 insertions(+) create mode 100644 repos/virconn/connection_getDomainCapabilities.py -- 1.8.1.4

2 2

[libvirt] [PATCH] relaxng: allow : in /dev/disk/by-path names
by Eric Blake 27 Mar '15

27 Mar '15

On IRC, Hydrar pointed a problem where 'virsh edit' failed on his domain created through an ISCSI pool managed by virt-manager, all because the XML included a block device with colons in the name. * docs/schemas/basictypes.rng (absFilePath): Add colon as safe. * tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml: New file. * tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.args: Likewise. * tests/qemuxml2argvtest.c (mymain): Test it. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- docs/schemas/basictypes.rng | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-iscsi.args | 7 ++++++ tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml | 28 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 4 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index 0cd1c4e..f086ad2 100644 --- a/docs/schemas/basictypes.rng +++ b/docs/schemas/basictypes.rng @@ -242,7 +242,7 @@ <define name="absFilePath"> <data type="string"> - <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%,]+</param> + <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%,:]+</param> </data> </define> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.args new file mode 100644 index 0000000..b987a38 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.args @@ -0,0 +1,7 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \ +/usr/bin/qemu -S -M \ +pc -m 214 -smp 1 -nographic -monitor unix:/tmp/test-monitor,server,nowait \ +-no-acpi -boot c -usb \ +-hda /dev/disk/by-path/ip-192.168.44.1:3260-iscsi-iqn.2011-02.lan.hdserver\ +:hydrar-desktop.win7vm-lun-0 -net none \ +-serial none -parallel none diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml new file mode 100644 index 0000000..e4d9c97 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-iscsi.xml @@ -0,0 +1,28 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219100</memory> + <currentMemory unit='KiB'>219100</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu</emulator> + <disk type='block' device='disk'> + <driver name='qemu' type='raw'/> + <source dev='/dev/disk/by-path/ip-192.168.44.1:3260-iscsi-iqn.2011-02.lan.hdserver:hydrar-desktop.win7vm-lun-0'/> + <target dev='hda' bus='ide'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <controller type='usb' index='0'/> + <controller type='ide' index='0'/> + <controller type='pci' index='0' model='pci-root'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 3c2fbf1..57ef053 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -708,6 +708,7 @@ mymain(void) DO_TEST("hugepages-pages6", NONE); DO_TEST("nosharepages", QEMU_CAPS_MACHINE_OPT, QEMU_CAPS_MEM_MERGE); DO_TEST("disk-cdrom", NONE); + DO_TEST("disk-iscsi", NONE); DO_TEST("disk-cdrom-network-http", QEMU_CAPS_KVM, QEMU_CAPS_DEVICE, QEMU_CAPS_DRIVE); DO_TEST("disk-cdrom-network-https", QEMU_CAPS_KVM, QEMU_CAPS_DEVICE, -- 2.1.0

2 2

[libvirt] [PATCH] libxl: Fix memory leak if pthread_create fails.
by Konrad Rzeszutek Wilk 26 Mar '15

26 Mar '15

If we fail to create the thread we leak the shutdown_info structure. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com> --- src/libxl/libxl_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 774b070..0ac5c62 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -482,7 +482,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event) libxlDriverPrivatePtr driver = data; virDomainObjPtr vm = NULL; libxl_shutdown_reason xl_reason = event->u.domain_shutdown.shutdown_reason; - struct libxlShutdownThreadInfo *shutdown_info; + struct libxlShutdownThreadInfo *shutdown_info = NULL; virThread thread; libxlDriverConfigPtr cfg; @@ -535,6 +535,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event) virObjectUnref(cfg); if (vm) virObjectUnlock(vm); + VIR_FREE(shutdown_info); } void -- 1.8.4.2

2 1

[libvirt] [PATCH 0/3] Parallels disk device attach
by Alexander Burluka 26 Mar '15

26 Mar '15

This patchset implements disk device attachment and allows OpenStack to attach volumes to Parallels-driven instances. Parallels Cloud Server SDK supports live attachment of disk devices and virtual interfaces cards. Alexander Burluka (3): Parallels: remove disk serial number check Parallels: implement domainAttachDeviceFlags Parallels: implemented domainAttachDevice

2 6

[libvirt] [PATCH 0/4] util: use netlink to create bridge devices
by Laine Stump 26 Mar '15

26 Mar '15

This patch series comes out of a comment in: https://bugzilla.redhat.com/show_bug.cgi?id=1125755 that pointed out that sioctl(SIOCBRDELBR) won't delete a bridge interface if it is IFF_UP, but the netlink RTM_DELLINK message doesn't care - it will delete it anyway. In these patches we switch to using RTM_DELLINK to avoid failures caused by a bridge interface that is IFF_UP. Laine Stump (4): util: netlink function to delete any network device util: replace body of virNetDevMacVLanDelete() with virNetlinkDelLink() util: use netlink to delete bridge devices util: use netlink to create bridge devices src/libvirt_private.syms | 1 + src/util/virnetdevbridge.c | 90 +++++++++++++++++++++++++++++++++++++++++++-- src/util/virnetdevmacvlan.c | 67 +-------------------------------- src/util/virnetlink.c | 89 ++++++++++++++++++++++++++++++++++++++++++++ src/util/virnetlink.h | 3 +- 5 files changed, 181 insertions(+), 69 deletions(-) -- 2.1.0

2 11

[libvirt] [PATCH] maint: update to latest gnulib
by Eric Blake 26 Mar '15

26 Mar '15

Needed to silence a valgrind detection of uninitialized memory: https://bugzilla.redhat.com/show_bug.cgi?id=1174147 * .gnulib: Update to latest. * bootstrap: Resync to gnulib. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- I've missed RC1, so I'll wait for a review on this one (are we sure that RC2 will be enough time to ensure the gnulib update doesn't cause regressions, basically). .gnulib | 2 +- bootstrap | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gnulib b/.gnulib index c27f1a3..8be5f2c 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit c27f1a356f2f321daa7f971ef276a1dbfa873bf8 +Subproject commit 8be5f2c10eeb05e52cc4a33cdcd37078742ff5db diff --git a/bootstrap b/bootstrap index 2fdf267..e72894c 100755 --- a/bootstrap +++ b/bootstrap @@ -915,7 +915,8 @@ if test $use_libtool = 1; then esac fi echo "$0: $gnulib_tool $gnulib_tool_options --import ..." -$gnulib_tool $gnulib_tool_options --import $gnulib_modules && +$gnulib_tool $gnulib_tool_options --import $gnulib_modules \ + || die "gnulib-tool failed" for file in $gnulib_files; do symlink_to_dir "$GNULIB_SRCDIR" $file \ -- 2.1.0

4 6

[libvirt] [PATCH] Fix common misspellings
by Martin Kletzander 26 Mar '15

26 Mar '15

Wikipedia's list of common misspellings [1] has a machine-readable version. This patch fixes those misspellings mentioned in the list which don't have multiple right variants (as e.g. "accension", which can be both "accession" and "ascension"), such misspellings are left untouched. The list of changes was manually re-checked for false positives. [1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_ma… Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- This is in no way automated, it's merely a check on whether this makes sense. Also I left out three words and two files which I thought might not be what we want. docs/bugs.html.in | 2 +- docs/contact.html.in | 2 +- docs/schemas/basictypes.rng | 2 +- docs/schemas/interface.rng | 2 +- docs/securityprocess.html.in | 6 +++--- examples/systemtap/lock-debug.stp | 2 +- include/libvirt/libvirt-host.h | 2 +- include/libvirt/virterror.h | 2 +- src/bhyve/bhyve_driver.c | 6 +++--- src/cpu/cpu_powerpc.c | 2 +- src/datatypes.c | 4 ++-- src/network/bridge_driver_linux.c | 2 +- src/qemu/THREADS.txt | 2 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 2 +- src/util/virfirewall.c | 2 +- src/util/virprocess.c | 2 +- src/vbox/vbox_common.c | 2 +- src/vbox/vbox_common.h | 2 +- src/xen/xend_internal.c | 2 +- src/xenconfig/xen_xm.c | 2 +- tools/wireshark/samples/libvirt-sample.pdml | 2 +- 22 files changed, 27 insertions(+), 27 deletions(-) diff --git a/docs/bugs.html.in b/docs/bugs.html.in index 140d1b4..55ceb60 100644 --- a/docs/bugs.html.in +++ b/docs/bugs.html.in @@ -11,7 +11,7 @@ If you think that an issue with libvirt may have security - implications, please do not publically + implications, please do not publicly report it in the bug tracker, mailing lists, or irc. Libvirt has <a href="securityprocess.html">a dedicated process for handling (potential) security issues</a> that should be used instead. So if your issue has security diff --git a/docs/contact.html.in b/docs/contact.html.in index 51cc775..9ab0ab9 100644 --- a/docs/contact.html.in +++ b/docs/contact.html.in @@ -10,7 +10,7 @@ If you think that an issue with libvirt may have security - implications, please do not publically + implications, please do not publicly report it in the bug tracker, mailing lists, or irc. Libvirt has <a href="securityprocess.html">a dedicated process for handling (potential) security issues</a> that should be used instead. So if your issue has security diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index 3e1841c..8b49a27 100644 --- a/docs/schemas/basictypes.rng +++ b/docs/schemas/basictypes.rng @@ -115,7 +115,7 @@    -  +     diff --git a/docs/schemas/interface.rng b/docs/schemas/interface.rng index d78f877..bf0346c 100644 --- a/docs/schemas/interface.rng +++ b/docs/schemas/interface.rng @@ -4,7 +4,7 @@ xmlns:v="http://netcf.org/xml/version/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes">  diff --git a/docs/securityprocess.html.in b/docs/securityprocess.html.in index 3efd687..bdef1e9 100644 --- a/docs/securityprocess.html.in +++ b/docs/securityprocess.html.in @@ -66,9 +66,9 @@ The libvirt security team operates a policy of <a href="http://en.wikipedia.org/wiki/Responsible_disclosure">responsible disclosure</a>. - As such any security issue reported, that is not already publically disclosed + As such any security issue reported, that is not already publicly disclosed elsewhere, will have an embargo date assigned. Members of the security team agree - not to publically disclose any details of the security issue until the embargo + not to publicly disclose any details of the security issue until the embargo date expires. @@ -77,7 +77,7 @@ are two weeks or less in duration. If a problem is identified with a proposed patch for a security issue, requiring further investigation and bug fixing, the embargo clock may be restarted. - In exceptional circumstances longer initial embargos may be + In exceptional circumstances longer initial embargoes may be negotiated by mutual agreement between members of the security team and other relevant parties to the problem. Any such extended embargoes will aim to be at most one month in duration. diff --git a/examples/systemtap/lock-debug.stp b/examples/systemtap/lock-debug.stp index 8f06340..78e94ba 100644 --- a/examples/systemtap/lock-debug.stp +++ b/examples/systemtap/lock-debug.stp @@ -49,7 +49,7 @@ probe unlock = library.function("virMutexUnlock") probe begin { %( $# > 1 %? println("error: Too many parameters"); exit(); - %: print("Started, press ^C when the proccess hangs\n"); %) + %: print("Started, press ^C when the process hangs\n"); %) } probe lock.call diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index 77058af..953366b 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -218,7 +218,7 @@ typedef enum { * * The types virSchedParameter, virBlkioParameter, and * virMemoryParameter are aliases of this type, for use when - * targetting libvirt earlier than 0.9.2. + * targeting libvirt earlier than 0.9.2. */ typedef struct _virTypedParameter virTypedParameter; diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 3d3d80a..5dc99dc 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt/virterror.h @@ -304,7 +304,7 @@ typedef enum { VIR_ERR_STORAGE_VOL_EXIST = 90, /* the storage vol already exists */ VIR_ERR_CPU_INCOMPATIBLE = 91, /* given CPU is incompatible with host CPU*/ - VIR_ERR_XML_INVALID_SCHEMA = 92, /* XML document doens't validate against schema */ + VIR_ERR_XML_INVALID_SCHEMA = 92, /* XML document doesn't validate against schema */ } virErrorNumber; /** diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 33a12be..21db277 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1160,14 +1160,14 @@ bhyveStateCleanup(void) } static int -bhyveStateInitialize(bool priveleged, +bhyveStateInitialize(bool privileged, virStateInhibitCallback callback ATTRIBUTE_UNUSED, void *opaque ATTRIBUTE_UNUSED) { virConnectPtr conn = NULL; - if (!priveleged) { - VIR_INFO("Not running priveleged, disabling driver"); + if (!privileged) { + VIR_INFO("Not running privileged, disabling driver"); return 0; } diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powerpc.c index c77374c..733a0cd 100644 --- a/src/cpu/cpu_powerpc.c +++ b/src/cpu/cpu_powerpc.c @@ -102,7 +102,7 @@ ppcModelFindPVR(const struct ppc_map *map, /* PowerPC Processor Version Register is interpreted as follows : * Higher order 16 bits : Power ISA generation. * Lower order 16 bits : CPU chip version number. - * If the exact CPU isnt found, return the nearest matching CPU generation + * If the exact CPU isn't found, return the nearest matching CPU generation */ if (pvr & 0x0000FFFFul) return ppcModelFindPVR(map, (pvr & 0xFFFF0000ul)); diff --git a/src/datatypes.c b/src/datatypes.c index 1afaf00..0f535b4 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -377,7 +377,7 @@ virInterfaceDispose(void *obj) * @name: pointer to the storage pool name * @uuid: pointer to the uuid * @privateData: pointer to driver specific private data - * @freeFunc: private data cleanup function pointer specfic to driver + * @freeFunc: private data cleanup function pointer specific to driver * * Allocates a new storage pool object. When the object is no longer needed, * virObjectUnref() must be called in order to not leak data. @@ -453,7 +453,7 @@ virStoragePoolDispose(void *obj) * @name: pointer to the storage vol name * @key: pointer to unique key of the volume * @privateData: pointer to driver specific private data - * @freeFunc: private data cleanup function pointer specfic to driver + * @freeFunc: private data cleanup function pointer specific to driver * * Allocates a new storage volume object. When the object is no longer needed, * virObjectUnref() must be called in order to not leak data. diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index aa2ad10..e394daf 100644 --- a/src/network/bridge_driver_linux.c +++ b/src/network/bridge_driver_linux.c @@ -450,7 +450,7 @@ networkRemoveGeneralIPv4FirewallRules(virFirewallPtr fw, /* Add all once/network rules required for IPv6. * If no IPv6 addresses are defined and <network ipv6='yes'> is - * specified, then allow IPv6 commuinications between virtual systems. + * specified, then allow IPv6 communications between virtual systems. * If any IPv6 addresses are defined, then add the rules for regular operation. */ static void diff --git a/src/qemu/THREADS.txt b/src/qemu/THREADS.txt index dfa372b..1ad63cc 100644 --- a/src/qemu/THREADS.txt +++ b/src/qemu/THREADS.txt @@ -29,7 +29,7 @@ There are a number of locks on various objects methods. However, preferred method is qemuDomObjFromDomain() that uses virDomainFindByUUIDRef() which also increases the reference counter and finds the domain in the domain list without blocking all other lookups. - When the domain is locked and the reference increased, the prefered way of + When the domain is locked and the reference increased, the preferred way of decrementing the reference counter and unlocking the domain is using the qemuDomObjEndAPI() function. diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index ccf22f0..ce6767c 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1266,7 +1266,7 @@ virQEMUCapsComputeCmdFlags(const char *help, * promises to keep the human interface stable, but requests that * we use QMP (the JSON interface) for everything. If the user * forgot to include YAJL libraries when building their own - * libvirt but is targetting a newer qemu, we are better off + * libvirt but is targeting a newer qemu, we are better off * telling them to recompile (the spec file includes the * dependency, so distros won't hit this). This check is * also in m4/virt-yajl.m4 (see $with_yajl). */ diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6d9217b..3cd5f8b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6357,7 +6357,7 @@ qemuDomainSaveImageUpdateDef(virQEMUDriverPtr driver, * @open_write: open the file for writing (for updates) * @unlink_corrupt: remove the image file if it is corrupted * - * Returns the opened fd of the save image file and fills the apropriate fields + * Returns the opened fd of the save image file and fills the appropriate fields * on success. On error returns -1 on most failures, -3 if corrupt image was * unlinked (no error raised). */ diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index cd7afa5..2251f97 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -945,7 +945,7 @@ virFirewallApply(virFirewallPtr firewall) VIR_DEBUG("Applying groups for %p", firewall); for (i = 0; i < firewall->ngroups; i++) { if (virFirewallApplyGroup(firewall, i) < 0) { - VIR_DEBUG("Rolling back groups upto %zu for %p", i, firewall); + VIR_DEBUG("Rolling back groups up to %zu for %p", i, firewall); size_t first = i; virErrorPtr saved_error = virSaveLastError(); diff --git a/src/util/virprocess.c b/src/util/virprocess.c index aa00a99..ab1e039 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -354,7 +354,7 @@ virProcessKillPainfully(pid_t pid, bool force) /* This loop sends SIGTERM, then waits a few iterations (10 seconds) * to see if it dies. If the process still hasn't exited, and * @force is requested, a SIGKILL will be sent, and this will - * wait upto 5 seconds more for the process to exit before + * wait up to 5 seconds more for the process to exit before * returning. * * Note that setting @force could result in dataloss for the process. diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 0fb53aa..20211b2 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -7413,7 +7413,7 @@ vboxConnectListAllDomains(virConnectPtr conn, /* filter out flag options that will produce 0 results in vbox driver: * - managed save: vbox guests don't have managed save images * - autostart: vbox doesn't support autostarting guests - * - persistance: vbox doesn't support transient guests + * - persistence: vbox doesn't support transient guests */ if ((MATCH(VIR_CONNECT_LIST_DOMAINS_TRANSIENT) && !MATCH(VIR_CONNECT_LIST_DOMAINS_PERSISTENT)) || diff --git a/src/vbox/vbox_common.h b/src/vbox/vbox_common.h index d318921..f9ce612 100644 --- a/src/vbox/vbox_common.h +++ b/src/vbox/vbox_common.h @@ -32,7 +32,7 @@ * vbox_CAPI_v*.h. It tells the vbox_common.c * how to treat with this symbols. This file * can't be included with files such as - * vbox_CAPI_v*.h, or it would casue multiple + * vbox_CAPI_v*.h, or it would cause multiple * definitions. * * You can see the more informations in vbox_api.h diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 6c8ec7c..3813900 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -523,7 +523,7 @@ xend_op_ext(virConnectPtr xend, const char *path, const char *key, va_list ap) * @ap: input values to pass to the operation * @...: input values to pass to the operation * - * internal routine to run a POST RPC operation to the Xen Daemon targetting + * internal routine to run a POST RPC operation to the Xen Daemon targeting * a given domain. * * Returns 0 in case of success, -1 in case of failure. diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index 5d70af6..c6bdbd3 100644 --- a/src/xenconfig/xen_xm.c +++ b/src/xenconfig/xen_xm.c @@ -469,7 +469,7 @@ xenFormatXMInputDevs(virConfPtr conf, virDomainDefPtr def) verify(MAX_VIRT_CPUS <= sizeof(1UL) * CHAR_BIT); /* - * Convert a virDomainDef object inot an XM config record. + * Convert a virDomainDef object into an XM config record. */ virConfPtr xenFormatXM(virConnectPtr conn, diff --git a/tools/wireshark/samples/libvirt-sample.pdml b/tools/wireshark/samples/libvirt-sample.pdml index f6a4c28..abe7fbb 100644 --- a/tools/wireshark/samples/libvirt-sample.pdml +++ b/tools/wireshark/samples/libvirt-sample.pdml @@ -3,7 +3,7 @@   <pdml version="0" creator="wireshark/1.10.2" time="Thu Sep 19 18:09:24 2013" capture_file=""> -- 2.3.3

4 10

[libvirt] [PATCH 0/7] iothread api followups
by Ján Tomko 26 Mar '15

26 Mar '15

Looking at the proposed SetIOThread API, I noticed that the virsh command for printing the info is named 'iothreadsinfo'. This seemed counter-intuitive for me. Since the API has not been released yet, I propose a rename of the command to: iothreadinfo (patch 5) and the API for freeing one struct to: virDomainIOThreadInfoFree (patch 1) I don't feel as strongly about renaming the virDomainGetIOThreadsInfo API (patches 3, 4) or the internal APIs (patch 2). Looking at virVcpuInfoPtr (which might not be the best inspiration), I realized including the cpu time might be a good idea. Ján Tomko (7): Rename virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree Rename qemuMonitorIOThreadsInfo* to qemuMonitorIOThreadInfo* Rename DomainGetIOThreadsInfo to DomainGetIOThreadInfo gendispatch: remove IOThreads from name fixups virsh: rename iothreadsinfo to iothreadinfo Do not use vshPrintPinInfo in iothreadinfo add cpu time to iothreadinfo daemon/remote.c | 15 +++++++------ include/libvirt/libvirt-domain.h | 5 +++-- src/driver-hypervisor.h | 4 ++-- src/libvirt-domain.c | 20 ++++++++--------- src/libvirt_public.syms | 4 ++-- src/qemu/qemu_driver.c | 24 ++++++++++++++------ src/qemu/qemu_monitor.c | 4 ++-- src/qemu/qemu_monitor.h | 10 ++++----- src/qemu/qemu_monitor_json.c | 8 +++---- src/qemu/qemu_monitor_json.h | 2 +- src/qemu/qemu_process.c | 4 ++-- src/remote/remote_driver.c | 23 ++++++++++---------- src/remote/remote_protocol.x | 11 +++++----- src/remote_protocol-structs | 7 +++--- src/rpc/gendispatch.pl | 1 - tests/qemumonitorjsontest.c | 4 ++-- tools/virsh-domain.c | 47 ++++++++++++++++++++++++++++------------ 17 files changed, 113 insertions(+), 80 deletions(-) -- 2.0.5

3 24