- Devel - libvirt List Archives

[libvirt] [PATCH] virsh: remove stale comment
by Ján Tomko 02 Apr '15

02 Apr '15

Copied from the vcpupin command, which has two modes of operation. --- Pushed as trivial. tools/virsh-domain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index eee441f..e7b5eeb 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6961,7 +6961,6 @@ cmdIOThreadPin(vshControl *ctl, const vshCmd *cmd) goto cleanup; cpumaplen = VIR_CPU_MAPLEN(maxcpu); - /* Pin mode: pinning specified vcpu to specified physical cpus*/ if (!(cpumap = vshParseCPUList(ctl, cpulist, maxcpu, cpumaplen))) goto cleanup; -- 2.0.5

1 0

[libvirt] [python PATCH] Post-release version bump to 1.2.15
by Jiri Denemark 02 Apr '15

02 Apr '15

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as trivial. setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 00e6d75..79b048f 100755 --- a/setup.py +++ b/setup.py @@ -309,7 +309,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '1.2.14', + version = '1.2.15', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.3.5

1 0

[libvirt] [PATCH 0/2] qemu: Finish fixing of interlocking domain ops with blockjobs
by Peter Krempa 02 Apr '15

02 Apr '15

Peter Krempa (1): qemu: snapshot: Check for block jobs individually Shanzhi Yu (1): conf: Rename virDomainHasDiskMirror and detect block jobs properly src/conf/domain_conf.c | 25 ++++++++++++++++++++----- src/conf/domain_conf.h | 3 ++- src/libvirt_private.syms | 2 +- src/qemu/qemu_driver.c | 19 +++++++++++-------- src/qemu/qemu_migration.c | 2 +- 5 files changed, 35 insertions(+), 16 deletions(-) -- 2.2.2

2 5

[libvirt] [PATCH 0/6] Cleanups
by Ján Tomko 02 Apr '15

02 Apr '15

First two patches are a result of compiling with -Wunused-macros. They reduce the number of infractions from 111 to 82. The remaining cases are: * unused VIR_FROM_THIS * copies of other headers * in drivers I'm not familiar with enough The next two were found randomly, which lead me to look into virutil.h as well, because just like virsh.c, the util files were split as well. Ján Tomko (6): Remove unused macros Use the DEFAULT_DRIVER_DIR macro Do not include cpu_map.h in libvirtd.c Clean up headers in src/util/virutil.h Remove unused includes from virsh Remove unnecessary includes from virsh.h daemon/libvirtd.c | 2 -- src/conf/network_conf.c | 1 - src/driver.c | 4 ++-- src/locking/lock_daemon.c | 1 - src/locking/lock_driver_lockd.c | 4 ---- src/openvz/openvz_driver.c | 4 ---- src/qemu/qemu_driver.c | 2 -- src/qemu/qemu_monitor_text.c | 3 --- src/test/test_driver.c | 1 - src/uml/uml_driver.c | 3 --- src/util/virutil.c | 4 ---- src/util/virutil.h | 2 -- tests/sockettest.c | 10 ---------- tests/testutils.c | 5 ----- tools/virsh-domain.c | 1 + tools/virsh-network.c | 7 +------ tools/virsh-nodedev.c | 7 +------ tools/virsh-nwfilter.c | 6 ------ tools/virsh-pool.c | 6 ------ tools/virsh-secret.c | 6 ------ tools/virsh-snapshot.c | 1 + tools/virsh.c | 10 ---------- tools/virsh.h | 3 --- 23 files changed, 6 insertions(+), 87 deletions(-) -- 2.0.5

2 13

[libvirt] [PATCH 0/8] Fix cgroups regresion when default cpuset is specified
by Peter Krempa 02 Apr '15

02 Apr '15

Since commit a39f69d2b libvirt would fail to start a VM if the default cpu set was specified and individual vcpus were pinned to cpus outside of that cpuset. Peter Krempa (8): qemu: cgroup: Store auto cpuset instead of re-creating it on demand qemu: cgroup: Refactor setup for IOThread cgroups qemu: cgroup: Properly set up vcpu pinning qemu: cgroup: Use priv->autoCpuset instead of using qemuPrepareCpumap() qemu: cgroup: Rename qemuSetupCgroupEmulatorPin to qemuSetupCgroupCpusetCpus qemu: cgroup: Kill qemuSetupCgroupIOThreadsPin() qemu: cgroup: Kill qemuSetupCgroupVcpuPin() qemu: Copy bitmap in a sane way src/qemu/qemu_cgroup.c | 150 +++++++++++++++--------------------------------- src/qemu/qemu_cgroup.h | 13 +---- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 21 +++---- src/qemu/qemu_process.c | 93 +++++++++--------------------- src/qemu/qemu_process.h | 2 - 7 files changed, 85 insertions(+), 198 deletions(-) -- 2.2.2

4 12

[libvirt] [PATCH] Bump version to 1.2.15 for new dev cycle
by Peter Krempa 02 Apr '15

02 Apr '15

--- Pushed as trivial. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index b1193a6..38fbbad 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [1.2.14], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [1.2.15], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) -- 2.2.2

1 0

[libvirt] Release of libvirt-1.2.14
by Daniel Veillard 02 Apr '15

02 Apr '15

It's out ! The release is tagged in git, signed tarballs and packages are available from the usual place: ftp://libvirt.org/libvirt/ I also tagged and pushed a libvirt-python-1.2.14 release at: ftp://libvirt.org/libvirt/python/ This is a rather large release, around 350 commits, in a balanced set: a few new features, a reasonable set of fixes and a bunch of improvements :-) Features: - qemu: Implement memory device hotplug (Peter Krempa) - Implement public API for virDomainPinIOThread (John Ferlan) - Implement public API for virDomainGetIOThreadsInfo (John Ferlan) - SRIOV NIC offload feature discovery (James Chapman) Documentation: - virCgroupNewPartition: Fix comment (Michal Privoznik) - route element must specify network address (Chen Fan) - no 'via' attribute in route element (Chen Fan) - Document that USB hostdevs do not need nodeDettach (Ján Tomko) - Document behavior of compat when creating qcow2 volumes (Ján Tomko) - Fix typo in error message (Ján Tomko) - Fix common misspellings (Martin Kletzander) - Fix doc for backingStore (Deepak Shetty) - schema and docs for the midonet virtualport type (Antoni Segura Puimedon) - add a note that spice channel is usable only with spice graphics (Pavel Hrdina) - net-define: update or unify documentation (Pavel Hrdina) - pool-define: update and unify documentation (Pavel Hrdina) - iface-define: update and unify documentation (Pavel Hrdina) - Fix syntax for vcpupin description (John Ferlan) - virsh.pod: Add information regarding LXC for setmem, memtune, and dominfo (John Ferlan) - add a note that attr 'managed' is only used by PCI devices (Erik Skultety) Portability: - build: avoid variable named 'interface', for mingw (Eric Blake) - vircgroup: Fix build issue mingw cross compile (John Ferlan) - vircgroup: Fix build issue on mingw cross compile (John Ferlan) - virnetdev: fix build with old kernel (Pavel Hrdina) - Fix build on mingw (Ján Tomko) Bug fixes: - qemu: blockjob: Synchronously update backing chain in XML on ABORT/PIVOT (Peter Krempa) - qemu: processBlockJob: Don't unlock @vm twice (Peter Krempa) - qemu: blockCopy: Pass adjusted bandwidth when called via blockRebase (Peter Krempa) - virsh: blockCopy: Add missing jump on error path (Luyao Huang) - qemuDomainGetNumaParameters: Check for the correct CGroup controller (Michal Privoznik) - virCgroupController: Check the enum fits into 'int' (Michal Privoznik) - virnetlink: fix build error (Pavel Hrdina) - qemu: end the job when try to blockcopy to non-file destination (Shanzhi Yu) - relaxng: allow : in /dev/disk/by-path names (Eric Blake) - libxl: Fix memory leak if pthread_create fails. (Konrad Rzeszutek Wilk) - util: use netlink to delete bridge devices (Laine Stump) - qemu: command: Fix property name for start address of a pc-dimm module (Luyao Huang) - qemu: command: Check for empty network source when formatting drive cmd (Peter Krempa) - qemu: command: Report error when formatting network source with protocol _NONE (Peter Krempa) - build: fix race when creating the cpu_map.xml symlink (Amy Fong) - Don't validata filesystem target type (Guido Günther) - rpc: Don't unref identity object while callbacks still can be executed (Peter Krempa) - util: identity: Harden virIdentitySetCurrent() (Peter Krempa) - qemu: domain: Don't leak device alias list (Peter Krempa) - rpc: serverclient: Clear pointer with NULL instead of 0 (Peter Krempa) - qemu: fix set vcpus on host without NUMA (Pavel Hrdina) - qemu: monitor: Don't leak @props with non-JSON in qemuMonitorAddObject (Peter Krempa) - qemu: Don't return memory device config on error in qemuBuildMemoryBackendStr (Peter Krempa) - Fix underlinking of libvirt_driver_interface.so (Natanael Copa) - networkStateInitialize: Don't lock network driver (Michal Privoznik) - qemu: Migrate memory on numatune change (Martin Kletzander) - parallels: fix libvirt crash if parallelsNetworkOpen fails (Maxim Nestratov) - qemu: do not overwrite the error in qemuDomainObjExitMonitor (Luyao Huang) - libxl: Don't overwrite errors from xenconfig (Jim Fehlig) - qemu: Fix two issues in qemuDomainSetVcpus error handling (John Ferlan) - qemu: track 'cancelling' migration state (Eric Blake) - parallels: don't prevent domain define if VIR_DOMAIN_NET_TYPE_BRIDGE (Maxim Nestratov) - parallels: switch off offline management feature (Maxim Nestratov) - parallels: set correct network adapter link state (Maxim Nestratov) - parallels: fix parallelsLoadNetworks (Maxim Nestratov) - network: Resolve Coverity FORWARD_NULL (John Ferlan) - qemuGetDHCPInterfaces: Don't leak @network (Michal Privoznik) - cmdDomIfAddr: Free @ip_addr_str (Michal Privoznik) - qemu: read backing chain names from qemu (Eric Blake) - qemu: driver: Fix cold-update of removable storage devices (Peter Krempa) - parallels: fix home directory for VMs (Maxim Nestratov) - parallels: don't forget to unlock domain if unregister fails (Maxim Nestratov) - parallels: set cpu mode when applying xml configuration (Mikhail Feoktistov) - conf: Use correct type for balloon stats period (Martin Kletzander) - qemu: Don't duplicate errors when settings stats period (Martin Kletzander) - libxl: fix regression introduced by commit 4ab8cd77 (Jim Fehlig) - qemu: block-commit: Mark disk in block jobs only on successful command (Peter Krempa) - daemon: avoid memleak when ListAll returns nothing (Eric Blake) - qemu: Fix possible memory leak in qemuDomainPinVcpuFlags (John Ferlan) - qemu: Disallow concurrent block jobs on a single disk (Peter Krempa) - qemu: event: Don't fiddle with disk backing trees without a job (Peter Krempa) - qemu: Check for negative port values in network drive configuration (Erik Skultety) - network: avoid memory leak of dnsmasq capabilities (Eric Blake) - virsh: fix report of non-active commit completion (Eric Blake) - util: don't fail if no PortData is found while getting migrateData (zhang bo) - libxl: prevent attaching multiple netdevs with the same MAC (Marek Marczykowski-Górecki) - parallels: fix prlsdkCheckUnsupportedParams checks (Maxim Nestratov) - Error out on an address for isa-serial in QEMU driver. (Ján Tomko) - xenapi: Resolve Coverity REVERSE_INULL (John Ferlan) - xenapi: Resolve Coverity REVERSE_INULL (John Ferlan) - xenapi: Resolve Coverity NULL_RETURNS (John Ferlan) - xenapi: Resolve Coverity NO_EFFECT (John Ferlan) - xenapi: Resolve Coverity FORWARD_NULL (John Ferlan) - conf: Resolve Coverity RESOURCE_LEAK (John Ferlan) - parallels: prevent domain define only if vcpupin is specified (Maxim Nestratov) - parallels: prevent domain define only if NUMA is really specified (Maxim Nestratov) - parallels: don't forget to unlock domain in parallelsDomainHasManagedSaveImage (Maxim Nestratov) - domain_conf: fix crash in virDomainObjListFindByUUIDInternal (Michael Chapman) - {domain, network}_conf: disable autostart when deleting config (Michael Chapman) - virQEMUCapsInitQMP: Don't dispose locked @vm (Michal Privoznik) - qemu: fix memory leak in qemuAgentGetFSInfo (Chen Fan) - qemu: don't fill in nicindexes for session mode libvirtd (Laine Stump) - virnet*: Don't unlock object in dispose (Michal Privoznik) - sanlock: Don't spam logs with "target pid not found" (Jiri Denemark) - qemu: Resolve Coverity CHECKED_RETURN issue (John Ferlan) - conf: Remove duplicate entries in <metadata> by namespace (Peter Krempa) - qemu: Allow spaces in disk serial (Michal Privoznik) - parallels: Cleanup partly opened drivers on connect open failure (Michal Privoznik) - qemu: snapshot: Don't skip check for qcow2 format with network disks (Shanzhi Yu) - testNetworkUpdate: Unlock network at the end (Michal Privoznik) - qemuProcessReconnect: Fill in pid file path (Michal Privoznik) - qemu: check defaultMode for spice graphics independently (Pavel Hrdina) - schema: Fix interface link state schema (Peter Krempa) - qemu: Don't crash in qemuDomainOpenChannel() (Martin Kletzander) - disk: Provide a default storage source format type. (John Ferlan) - disk: Disallow duplicated target 'dev' values (John Ferlan) - phyp: Fix error messages mentioning memory (Peter Krempa) - storage: sheepdog: Avoid skipping variable initialization (Peter Krempa) - Check if domain is running in qemuDomainAgentIsAvailable (Ján Tomko) - Revert "Restore skipping of setting capacity" (Ján Tomko) Improvements: - tests: nodeinfo: Add test for RHELSA on APM mustang (Cole Robinson) - tests: nodeinfo: Test F21 aarch64 on APM mustang (Cole Robinson) - qemu: Extract internals of processBlockJobEvent into a helper (Peter Krempa) - virCgroupNew: Enhance debug message (Michal Privoznik) - tests: introduce qemucaps2xmlmock (Pavel Hrdina) - nodeinfo: Increase the num of CPU thread siblings to a larger value (Wei Huang) - util: use netlink to create bridge devices (Laine Stump) - util: replace body of virNetDevMacVLanDelete() with virNetlinkDelLink() (Laine Stump) - util: netlink function to delete any network device (Laine Stump) - maint: update to latest gnulib (Eric Blake) - Rename DomainGetIOThreadsInfo to DomainGetIOThreadInfo (Ján Tomko) - Rename qemuMonitorIOThreadsInfo* to qemuMonitorIOThreadInfo* (Ján Tomko) - Rename virDomainIOThreadsInfoFree to virDomainIOThreadInfoFree (Ján Tomko) - virsh: rename iothreadsinfo to iothreadinfo (Ján Tomko) - qemu: Give hint about -noTSX CPU model (Jiri Denemark) - cpu: Add {Haswell,Broadwell}-noTSX CPU models (Jiri Denemark) - tests: qemuxml2xml: Test status XML formatting and parsing (Peter Krempa) - util: buffer: Add support for adding text blocks with indentation (Peter Krempa) - daemon: Clear fake domain def object that is used to check ACL prior to use (Peter Krempa) - tests: qemuxml2xml: Refactor the qemuxml2xml test (Peter Krempa) - qemu: Report better error when memory device source has wrong NUMA node (Luyao Huang) - util: NUMA: Change error code in virNumaNodesetIsAvailable() (Peter Krempa) - conf: Add missing apostrophe to error message (Luyao Huang) - Makefile: fix typo (Pavel Hrdina) - qemu: Add timing to domain jobs (Jiri Denemark) - qemu: Track the API which started the current job (Jiri Denemark) - Set thread job for every RPC call (Jiri Denemark) - virThreadPool: Set thread worker name (Jiri Denemark) - virThread: Set thread job (Jiri Denemark) - Force usage of virThreadCreate (Jiri Denemark) - Add support for tracking thread jobs (Jiri Denemark) - POTFILES.in: Sort (Jiri Denemark) - libxl: remove per-domain libxl_ctx (Jim Fehlig) - libxl: make libxlDomainFreeMem static (Jim Fehlig) - libxl: remove unnecessary libxlDomainEventsRegister (Jim Fehlig) - libxl: use global libxl_ctx in event handler (Jim Fehlig) - libxl: move event registration to driver initialization (Jim Fehlig) - libxl: Move setup of child processing code to driver initialization (Jim Fehlig) - libxl: use driver-wide ctx in fd and timer event handling (Jim Fehlig) - qemu: cleanup setvcpus (Pavel Hrdina) - qemu: move virDomainLiveConfigHelperMethod right after BeginJob (Pavel Hrdina) - qemu: change accidental VIR_WARNING back to VIR_DEBUG (Laine Stump) - qemucaps2xmltest: fix the test to correspond to new domain formatting (Pavel Hrdina) - conf: fix parsing of NUMA settings in VM status XML (Luyao Huang) - qemu: Implement memory device hotunplug (Peter Krempa) - qemu: conf: Add support for memory device cold(un)plug (Peter Krempa) - qemu: add support for memory devices (Peter Krempa) - qemu: migration: Forbid migration with memory modules lacking info (Peter Krempa) - qemu: memdev: Add infrastructure to load memory device information (Peter Krempa) - conf: Add interface to parse and format memory device information (Peter Krempa) - conf: Add device address type for dimm devices (Peter Krempa) - qemu: Implement setup of memory hotplug parameters (Peter Krempa) - conf: Add support for parsing and formatting max memory and slot count (Peter Krempa) - libxl: Refactor logic in domain post parse callback (Peter Krempa) - qemu: Set default SCSI controller model for S390 arch (Boris Fiuczynski) - qemu: skip precreation of network disks (Michael Chapman) - network_conf: Drop virNetworkObjIsDuplicate (Michal Privoznik) - objecteventtest: Check for virNetwork* return values (Michal Privoznik) - cgroup: Add accessors for cpuset.memory_migrate (Martin Kletzander) - maint: update .mailmap for recent contributions (Eric Blake) - libxl: use xenlight pkgconfig file if present (Jim Fehlig) - util: more verbose error when failing to create macvtap device (Laine Stump) - util: clean up #includes of virnetdevopenvswitch.h (Laine Stump) - util: vhost user: support for bootindex (zhang bo) - parallels: make E1000 network adapter model default (Maxim Nestratov) - parallels: better bridge network interface support (Maxim Nestratov) - parallels: introduce and use string constants for network types and names (Maxim Nestratov) - maint: Distribute tests/vircgroupdata (Jiri Denemark) - Use PAUSED state for domains that are starting up (Jiri Denemark) - tests: Add tests for virCgroupDetectMounts (Jiri Denemark) - qemuAgentGetInterfaces: Don't error out on missing HW address (Michal Privoznik) - virsh: Adapt to new HW address scenario (Michal Privoznik) - RPC: Allow HW address in remote_domain_interface struct to be NULL (Michal Privoznik) - network: Add midonet virtual port type support to qemu (Antoni Segura Puimedon) - util: functions to support binding/unbinding midonet virtualports (Antoni Segura Puimedon) - conf: disk: Simplify checking if source definition was parsed (Peter Krempa) - util: storage: Fix check for empty storage device (Peter Krempa) - qemu: hotplug: Use checker function to check if disk is empty (Peter Krempa) - virsh: domain: Fix the change-media command (Peter Krempa) - virsh: domain: Add --print-xml flag for command change-media (Peter Krempa) - virsh: domain: Don't use vshPrepareDiskXML for creating XML to detach disk (Peter Krempa) - parallels_sdk.c: minor cleanup (Maxim Nestratov) - domifaddr: Add virsh support (Nehal J Wani) - domifaddr: Implement the API for qemu (Nehal J Wani) - domifaddr: Implement the remote protocol (Nehal J Wani) - domifaddr: Implement the public APIs (Nehal J Wani) - conf: Reorder elements inside memballoon (Martin Kletzander) - util: Make sure the comment about virBufferAddBuffer is true (Martin Kletzander) - wireshark: fix VPATH build (Pavel Hrdina) - qemu_command: Fix some indentation and a typo (Luyao Huang) - rpm-build: use pkg-config to detect wireshark presence (Pavel Hrdina) - Remove virDomainIOThreadsPinDel (John Ferlan) - Replace virDomainVcpuPinDel with virDomainPinDel (John Ferlan) - Replace virDomainIOThreadsPinAdd with virDomainPinAdd (John Ferlan) - Replace virDomainVcpuPinAdd with virDomainPinAdd (John Ferlan) - Convert virDomainVcpuPinFindByVcpu into virDomainPinFindByVcpu (John Ferlan) - Convert virDomainVcpuPinIsDuplicate into virDomainPinIsDuplicate (John Ferlan) - Convert virDomainVcpuPinDefCopy into virDomainPinDefCopy (John Ferlan) - Convert virDomainVcpuPinDefArrayFree to virDomainPinDefArrayFree (John Ferlan) - Convert virDomainVcpuPinDefFree to virDomainPinDefFree (John Ferlan) - Convert virDomainPinDefPtr->vcpuid to virDomainPinDefPtr->id (John Ferlan) - Convert virDomainVcpuPinDefPtr to virDomainPinDefPtr (John Ferlan) - conf: Make specifying <memory> optional (Peter Krempa) - conf: Automatically use NUMA memory size in case NUMA is enabled (Peter Krempa) - qemu: command: Add helper to align memory sizes (Peter Krempa) - conf: Replace access to def->mem.max_balloon with accessor functions (Peter Krempa) - qemu: process: Export qemuProcessFindDomainDiskByAlias (Peter Krempa) - AUTHORS: add myself to commiters list (Erik Skultety) - netdev: silence valgrind warning about ioctl use (Eric Blake) - conf: add virDomainHasNet (Marek Marczykowski-Górecki) - tests: xenconfig: test for multiple USB devices and other HVM options (Marek Marczykowski-Górecki) - xenconfig: add support for multiple USB devices syntax (Marek Marczykowski-Górecki) - libxl: add tablet/mouse input device support (Marek Marczykowski) - bridge_driver: Use more of networkObjFromNetwork (Michal Privoznik) - parallels_network: Drop parallelsDriverLock() from everywhere. (Michal Privoznik) - test_driver: Drop testDriverLock() from almost everywhere (Michal Privoznik) - bridge_driver: Drop networkDriverLock() from almost everywhere (Michal Privoznik) - struct _virNetworkDriverState: Annotate items (Michal Privoznik) - network_driver: Use accessor for dnsmasqCaps (Michal Privoznik) - bridge_driver: Don't access global driver randomly (Michal Privoznik) - Introduce virBitmapIsBitSet (Ján Tomko) - Clarify the meaning of version in redirdev filters (Ján Tomko) - vmx: add e1000e to supported NIC models. (Dawid Zamirski) - vbox: use user cache dir when screenshotting. (Dawid Zamirski) - parallels: add VIR_ARCH_I686 capability to parallels driver (Maxim Nestratov) - virsh: Add iothreadpin command (John Ferlan) - qemu: Add support to pin IOThreads to specific CPU (John Ferlan) - domain: Introduce virDomainIOThreadsPin{Add|Del} (John Ferlan) - remote: Implement the plumbing for virDomainPinIOThread (John Ferlan) - virNetworkObjFindBy*: Return an reference to found object (Michal Privoznik) - virNetworkObjListPtr: Make APIs self-locking (Michal Privoznik) - network_conf: Introduce locked versions of lookup functions (Michal Privoznik) - virNetworkObjList: Derive from virObjectLockableClass (Michal Privoznik) - parallels_network: Use virNetworkObjEndAPI (Michal Privoznik) - test_driver: Use virNetworkObjEndAPI (Michal Privoznik) - bridge_driver: Use virNetworkObjEndAPI (Michal Privoznik) - network_conf: Introduce virNetworkObjEndAPI (Michal Privoznik) - network_conf: Make virNetworkObj actually virObject (Michal Privoznik) - virNetworkObjListPtr: Turn list into a hash table (Michal Privoznik) - qemu: monitor: Kill qemuMonitorGetBlockStats(Info,ParamsNumber) (Peter Krempa) - test: qemu: json: Avoid using the now obsolete functions (Peter Krempa) - qemu: blockstats: Refactor qemuDomainBlockStatsFlags (Peter Krempa) - qemu: blockstats: Add support for totalled block statistics (Peter Krempa) - qemu: Split out working code qemuDomainBlockStats (Peter Krempa) - qemu: monitor: Count block stats fields in qemuMonitorGetAllBlockStatsInfo (Peter Krempa) - qemu: monitor: Convert common code to a macro (Peter Krempa) - qemu: monitor: Implement HMP version for listing all block device stats (Peter Krempa) - test: qemu: Fix qemu monitor test utils to allow testing HMP (Peter Krempa) - qemu: blockstats: Switch to caller allocated hash table (Peter Krempa) - qemu: monitor: Drop parsing of 'errs' from block info (Peter Krempa) - qemu: Use macro to set block stats typed parameters (Peter Krempa) - RNG: Allow multiple parameters to be passed to an interface filter (Michal Privoznik) - parallels: cpumask support (Maxim Nestratov) - qemu: Remove unnecessary virReportError on networkGetNetworkAddress return (Luyao Huang) - Reverse the logic in virbitmaptest (Ján Tomko) - Use virBitmapNextClearBit in networkNextClassID (Ján Tomko) - network_conf: Turn struct _virNetworkObjList private (Michal Privoznik) - network_conf: Turn virNetworkObjList into virObject (Michal Privoznik) - parallels_network: Adapt to new virNetworkObjList accessors (Michal Privoznik) - test_driver: Adapt to new virNetworkObjList accessors (Michal Privoznik) - bridge_driver: Adapt to new virNetworkObjList accessors (Michal Privoznik) - network_conf: Introduce virNetworkObjListPrune (Michal Privoznik) - network_conf: Introduce virNetworkObjListNumOfNetworks (Michal Privoznik) - network_conf: Introduce virNetworkObjListGetNames (Michal Privoznik) - network_conf: Introduce virNetworkObjListForEach (Michal Privoznik) - locking: Fix flags in virLockManagerLockDaemonNew (Jiri Denemark) - tests: fix qemuxml2argvtest to be arch independent (Pavel Hrdina) - qemu: Change qemuDomainGetEmulatorPinInfo bitmap manipulation (John Ferlan) - qemu: Change qemuDomainGetVcpuPinInfo bitmap manipulation (John Ferlan) - qemu: Change/Fix IOThread CPU affinity bitmap manipulation (John Ferlan) - Remove ReadOnly check for GetIOThreadsInfo (John Ferlan) - tests: Add test for os interleaving (Martin Kletzander) - tests: Add test for virtio-mmio address type (Martin Kletzander) - domain_conf: Format <pvpanic/> without address correctly (Michal Privoznik) - Refresh translations from Zanata (Daniel P. Berrange) - virsh: Add 'iothreadsinfo' command (John Ferlan) - qemu: Implement the qemu driver fetch for IOThreads (John Ferlan) - remote: Implement the remote plumbing for virDomainGetIOThreadsInfo (John Ferlan) - memtune: change the way how we store unlimited value (Pavel Hrdina) - virutil: introduce helper functions for memory limits (Pavel Hrdina) - virsh: fix memtune to also accept 0 as valid value (Pavel Hrdina) - qemu: Pass file descriptor when using TPM passthrough (Stefan Berger) - qemu: Move TPM command line build code into own function (Stefan Berger) - utils: Implement virCommandPassFDGetFDIndex (Stefan Berger) - libxl: remove unneeded cleanup_unlock label (Jim Fehlig) - libxl: use libxl_ctx passed to libxlConsoleCallback (Jim Fehlig) - libxl: remove redundant calls to libxl_evdisable_domain_death (Jim Fehlig) - spec: Enable RBD storage driver in RHEL-7 (Peter Krempa) - storage: tweak condition to properly test lseek (Erik Skultety) - virsh: tweak domif-getlink link state reporting message (Erik Skultety) - qemu: Allow inactive domains in qemuDomainGetControlInfo() (Peter Krempa) - qemu: Properly report error state in qemuDomainGetControlInfo() (Peter Krempa) - conf: s/virNetworkFindByName/virNetworkObjFindByName/ (Michal Privoznik) - conf: s/virNetworkFindByUUID/virNetworkObjFindByUUID/ (Michal Privoznik) - bridge_driver: s/virNetworkObjList/virNetworkObjListPtr/ (Michal Privoznik) - parallels: s/virNetworkObjList/virNetworkObjListPtr/ (Michal Privoznik) - test_driver: s/virNetworkObjList/virNetworkObjListPtr/ (Michal Privoznik) - virNetworkObjListExport: Pass virNetworkObjListPtr (Michal Privoznik) - virNetworkObjListFree: Accept NULL (Michal Privoznik) - virNetworkObjIsDuplicate: s/@doms/@nets/ (Michal Privoznik) - networkGetNetworkAddress: Drop empty 'error' label (Michal Privoznik) - bridge_driver: Don't check network active unlocked (Michal Privoznik) - networkLookupByUUID: Improve error message (Michal Privoznik) - qemu: remove duplicated code for allocating spice ports (Pavel Hrdina) - tests : Add test for 'ppc64le' architecture. (Prerna Saxena) - RNG: Add 'ppc64le' arch and newer pseries-2.* machine types (Prerna Saxena) - conf: De-duplicate scheduling policy enums (Martin Kletzander) - virsh.pod: Update find-storage-pool-sources[-as] man page (John Ferlan) - iscsi: Adjust error message for findStorageSources backend (John Ferlan) - virsh: Adjust domblklist to understand disk volume syntax (John Ferlan) - conf: numa: Add helper to count total memory size configured in NUMA (Peter Krempa) - qemu: Forbid setting maximum memory size with the API with NUMA enabled (Peter Krempa) - Pass virDomainObjPtr to qemuDomainAgentAvailable (Ján Tomko) - Check for qemu guest agent availability after getting the job (Ján Tomko) - Allow creating volumes with a backing store but no capacity (Ján Tomko) - Allow omitting volume capacity when backing store is specified (Ján Tomko) - Probe for capacity in virStorageBackendUpdateVolTargetInfo (Ján Tomko) - Allow cloning volumes with no capacity specified (Ján Tomko) - Allow parsing volumes without specifying the capacity (Ján Tomko) - Parse backingStore before capacity in volume XML (Ján Tomko) - Add flags argument to virStorageVolDefParse* (Ján Tomko) - Add --migratable support to virsh cpu-baseline (Ján Tomko) - Trivially implement VIR_CONNECT_BASELINE_CPU_MIGRATABLE for non-x86 cpus (Ján Tomko) - Implement VIR_CONNECT_BASELINE_CPU_MIGRATABLE in the x86 cpu driver (Ján Tomko) - Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag (Ján Tomko) - Use virBufferTrim when generating boot options (Ján Tomko) - Make -boot arg generation more readable (Ján Tomko) - Remove code handling the QEMU_CAPS_DOMID capability (Ján Tomko) - Remove bootloader option from QEMU (Ján Tomko) Thanks everybody who contributed to this release, with code, ideas bug reports, docs, localizations, or patch reviews. Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] error: negative width in bit-field '_gl_verify_error_if_negative' ?
by Zhi Yong Wu 02 Apr '15

02 Apr '15

HI, Does anyone hit this issue when compiling libvirt? CCLD libvirt.la CC libvirt_qemu_la-libvirt-qemu.lo CCLD libvirt-qemu.la CC libvirt_lxc_la-libvirt-lxc.lo CCLD libvirt-lxc.la CC lockd_la-lock_driver_lockd.lo CC lockd_la-lock_protocol.lo CCLD lockd.la CC libvirt_driver_qemu_impl_la-qemu_agent.lo CC libvirt_driver_qemu_impl_la-qemu_capabilities.lo qemu/qemu_capabilities.c:55: error: negative width in bit-field '_gl_verify_error_if_negative' make[3]: *** [libvirt_driver_qemu_impl_la-qemu_capabilities.lo] Error 1 make[3]: Leaving directory `/home/zhiyong.wzy/libvirt-source/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/zhiyong.wzy/libvirt-source/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/zhiyong.wzy/libvirt-source' make: *** [all] Error 2 -- Regards, Zhi Yong Wu

2 2

[libvirt] [PATCH 0/3] libxl: domain destroy fixes
by Jim Fehlig 01 Apr '15

01 Apr '15

This small series of patches fixes some issues wrt domain destroy in the libxl driver. The primary motivation for this work is to prevent locking the virDomainObj during long running destroy operations on large memory domains. Patch 1 moves job acquisition from libxlDomainStart to it's callers so they have more control over when the job is acquired. Patch 2 fixes a few spots where we never acquired a job during domain destroy. Patch 3 contains the interesting change, where the virDomainObj is unlocked during the long-running destroy operation. This series wraps up my work to improve parallel OpenStack Tempest runs against the libxl driver. With libvirt.git master + this series + a patched libxl [1], I've successfully run a reproducer that was hitting the same issues encountered by Tempest. [1] libxl commits from xen.git: 93699882d, f1335f0d, 4783c99a, 1c91d6fba, and 188e9c54. I'll contact the stable branch maintainers and ask them to include these commits in the next Xen 4.4.x and 4.5.x releases. Jim Fehlig (3): libxl: Move job acquisition in libxlDomainStart to callers libxl: acquire a job when destroying a domain libxl: drop virDomainObj lock when destroying a domain src/libxl/libxl_domain.c | 77 +++++++++++++++++++---------------------------- src/libxl/libxl_domain.h | 4 --- src/libxl/libxl_driver.c | 78 ++++++++++++++++++++++++++++++++++++------------ 3 files changed, 89 insertions(+), 70 deletions(-) -- 1.8.4.5

5 15

[libvirt] [PATCH] qemu: lifecycle: make agent-mode shutdown and reboot timeout
by zhang bo 01 Apr '15

01 Apr '15

When we shutdown/reboot a guest using agent-mode, if the guest itself blocks infinitely, libvirt would block in qemuAgentShutdown() forever. Thus, we set a timeout for shutdown/reboot, from our experience, 60 seconds would be fine. Signed-off-by: Zhang Bo <oscar.zhangbo(a)huawei.com> Signed-off-by: Wang Yufei <james.wangyufei(a)huawei.com> --- include/libvirt/libvirt-qemu.h | 1 + src/qemu/qemu_agent.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index 0c5d650..2bb8ee8 100644 --- a/include/libvirt/libvirt-qemu.h +++ b/include/libvirt/libvirt-qemu.h @@ -49,6 +49,7 @@ typedef enum { VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK = -2, VIR_DOMAIN_QEMU_AGENT_COMMAND_DEFAULT = -1, VIR_DOMAIN_QEMU_AGENT_COMMAND_NOWAIT = 0, + VIR_DOMAIN_QEMU_AGENT_COMMAND_SHUTDOWN = 60, } virDomainQemuAgentCommandTimeoutValues; char *virDomainQemuAgentCommand(virDomainPtr domain, const char *cmd, diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index a7b3279..548d580 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1300,7 +1300,7 @@ int qemuAgentShutdown(qemuAgentPtr mon, else mon->await_event = QEMU_AGENT_EVENT_SHUTDOWN; ret = qemuAgentCommand(mon, cmd, &reply, false, - VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK); + VIR_DOMAIN_QEMU_AGENT_COMMAND_SHUTDOWN); virJSONValueFree(cmd); virJSONValueFree(reply); -- 1.7.12.4

2 1