- Devel - libvirt List Archives

[libvirt] [PATCH] Fix unbalanced quotation marks in messages
by Yuri Chornoivan 02 Aug '16

02 Aug '16

Hi, Thanks for reviewing this minor patch that fixes some glitches found while translating libvirt. Best regards, Yuri

2 1

[libvirt] [PATCH] device_conf: Let compiler decide on inlining functions
by Michal Privoznik 02 Aug '16

02 Aug '16

There's no point in forcing some functions to be both 'static' and 'inline' at the same time at the header file level. This leads to a situation where just linking the file defines those function (potentially needlessly). Instead, we should let the compiler (linker) decide whether the function are small enough to be inlined or not. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/device_conf.c | 24 ++++++++++++++++++++++++ src/conf/device_conf.h | 21 +++------------------ src/libvirt_private.syms | 3 +++ 3 files changed, 30 insertions(+), 18 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index f58b9d0..f34b6c6 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -78,6 +78,30 @@ int virPCIDeviceAddressIsValid(virPCIDeviceAddressPtr addr, } +bool +virPCIDeviceAddressIsEmpty(const virPCIDeviceAddress *addr) +{ + return !(addr->domain || addr->bus || addr->slot); +} + + +bool +virDeviceInfoPCIAddressWanted(const virDomainDeviceInfo *info) +{ + return info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE || + (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && + virPCIDeviceAddressIsEmpty(&info->addr.pci)); +} + + +bool +virDeviceInfoPCIAddressPresent(const virDomainDeviceInfo *info) +{ + return info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && + !virPCIDeviceAddressIsEmpty(&info->addr.pci); +} + + int virPCIDeviceAddressParseXML(xmlNodePtr node, virPCIDeviceAddressPtr addr) diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h index 8443de6..98eaf3f 100644 --- a/src/conf/device_conf.h +++ b/src/conf/device_conf.h @@ -148,26 +148,11 @@ typedef struct _virDomainDeviceInfo { int virPCIDeviceAddressIsValid(virPCIDeviceAddressPtr addr, bool report); -static inline bool -virPCIDeviceAddressIsEmpty(const virPCIDeviceAddress *addr) -{ - return !(addr->domain || addr->bus || addr->slot); -} +bool virPCIDeviceAddressIsEmpty(const virPCIDeviceAddress *addr); -static inline bool -virDeviceInfoPCIAddressWanted(const virDomainDeviceInfo *info) -{ - return info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE || - (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && - virPCIDeviceAddressIsEmpty(&info->addr.pci)); -} +bool virDeviceInfoPCIAddressWanted(const virDomainDeviceInfo *info); -static inline bool -virDeviceInfoPCIAddressPresent(const virDomainDeviceInfo *info) -{ - return info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && - !virPCIDeviceAddressIsEmpty(&info->addr.pci); -} +bool virDeviceInfoPCIAddressPresent(const virDomainDeviceInfo *info); int virPCIDeviceAddressParseXML(xmlNodePtr node, virPCIDeviceAddressPtr addr); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 89c4511..8c7aef0 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -76,10 +76,13 @@ virCPUModeTypeToString; # conf/device_conf.h +virDeviceInfoPCIAddressPresent; +virDeviceInfoPCIAddressWanted; virInterfaceLinkFormat; virInterfaceLinkParseXML; virPCIDeviceAddressEqual; virPCIDeviceAddressFormat; +virPCIDeviceAddressIsEmpty; virPCIDeviceAddressIsValid; virPCIDeviceAddressParseXML; -- 2.8.4

2 1

[libvirt] [PATCH 0/2] virpci: support driver_override sysfs interface
by Jim Fehlig 02 Aug '16

02 Aug '16

This series fixes a regression using Xen's pciback with kernels >= 3.16 containing https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/driv… It makes use of the driver_override sysfs interface introduced in kernel 3.12 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/driv… This approach was suggested by Laine, falling back to using the new_id interface in the absence of driver_override https://www.redhat.com/archives/libvir-list/2016-June/msg02129.html The first patch simplifies the existing logic in virPCIDeviceBindToStub, making the second patch (which actually fixes the bug) a bit easier to code (and hopefully review). Jim Fehlig (2): virpci: simplify virPCIDeviceBindToStub virpci: support driver_override sysfs interface src/util/virpci.c | 253 +++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 173 insertions(+), 80 deletions(-) -- 2.1.4

2 7

[libvirt] [PATCH 0/3] qemu: Don't error out on missing optional disk
by Martin Kletzander 01 Aug '16

01 Aug '16

More info in PATCH 3/3. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1168453 Martin Kletzander (3): qemu: Make qemuDomainCheckDiskStartupPolicy self-contained qemu: Remove unnecessary label and its only reference qemu: Fix support for startupPolicy with volume/pool disks src/qemu/qemu_domain.c | 36 +++++++++++++++++++++--------------- src/qemu/qemu_domain.h | 5 +++-- src/qemu/qemu_process.c | 20 +++++--------------- 3 files changed, 29 insertions(+), 32 deletions(-) -- 2.9.2

2 4

[libvirt] [PATCH v2] storage: Document wiping formatted volume types
by Martin Kletzander 01 Aug '16

01 Aug '16

When wiping a volume we just rewrite all the data of the volume, not only the content. Since format gets overridden, we need to recreate the volume. However we can't do that for every possible format out there. Since it was only coded for the ploop volume type, let's document what might be the consequences instead of forbidding it for every other format out there. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=868771 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- v2: - Reworded according to John v1: - https://www.redhat.com/archives/libvir-list/2016-August/msg00050.html src/libvirt-storage.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index cebe02fdda66..48996ba4c9c8 100644 --- a/src/libvirt-storage.c +++ b/src/libvirt-storage.c @@ -1725,11 +1725,16 @@ virStorageVolDelete(virStorageVolPtr vol, * @vol: pointer to storage volume * @flags: extra flags; not used yet, so callers should always pass 0 * - * Ensure data previously on a volume is not accessible to future - * reads. Also note, that depending on the actual volume - * representation, this call may not really overwrite the - * physical location of the volume. For instance, files stored - * journaled, log structured, copy-on-write, versioned, and + * Ensure data previously on a volume is not accessible to future reads. + * + * The data to be wiped may include the format and possibly size information, + * so non-raw images might become raw with a different size. It is storage + * backend dependent whether the format and size information is regenerated + * once the initial volume wipe is completed. + * + * Depending on the actual volume representation, this call may not + * overwrite the physical location of the volume. For instance, files + * stored journaled, log structured, copy-on-write, versioned, and * network file systems are known to be problematic. * * Returns 0 on success, or -1 on error -- 2.9.2

2 1

[libvirt] Question about LSN-2016-0001
by Jim Fehlig 01 Aug '16

01 Aug '16

I've noticed the behavior described by this LSN with libvirt+Xen. Config containing <graphics type='vnc' passwd=''/> allows any client to connect with no authentication check. I asked about this on the Xen security list and was told that "libxl interprets an empty password in the caller's configuration to mean that passwordless access should be permitted". The libvirt domXML docs are not clear on semantics of empty vnc password, only stating "The passwd attribute provides a VNC password in clear text". Should the libvirt domXML vnc passwd documentation be amended to define the semantics of an empty string in the passwd attribute? Is the behavior hypervisor-dependent as the documentation in qemu.conf suggests? Regards, Jim

2 4

[libvirt] [PATCH] storage: Document wiping formatted volume types
by Martin Kletzander 01 Aug '16

01 Aug '16

When wiping a volume we just rewrite all the data of the volume, not only the content. Since format gets overriden, we need to recreate the volume. However we can't do that for every possible format there. And since it was only coded for the ploop volume type, let's document what might be the consequences instead of forbidding it for every other format out there. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=868771 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/libvirt-storage.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index cebe02fdda66..2be95a5adcaf 100644 --- a/src/libvirt-storage.c +++ b/src/libvirt-storage.c @@ -1732,6 +1732,12 @@ virStorageVolDelete(virStorageVolPtr vol, * journaled, log structured, copy-on-write, versioned, and * network file systems are known to be problematic. * + * NB the data includes the format (and possibly size information), so + * non-raw images might become raw with different size from libvirt's + * POV. Due to the fact that not all information for re-creating the + * volume can be kept for every volume type, the volume might be kept + * in that state and not re-created. + * * Returns 0 on success, or -1 on error */ int -- 2.9.2

2 2

[libvirt] [PATCH 0/3] storage: Clean up some volume wiping code
by Martin Kletzander 01 Aug '16

01 Aug '16

Just a cleanup so that some functionality is more readable (about what's being done for ploop volumes when wiping them) and extensible in the future. Feel free to NACK if I'm the only one that finds this more readable. Martin Kletzander (3): storage: Move functions around storage: Use path instead of volume as an argument storage: Clean up volume wiping src/storage/storage_backend.c | 193 +++++++++++++++++++++++------------------- 1 file changed, 104 insertions(+), 89 deletions(-) -- 2.9.2

2 6

[libvirt] [PATCH 0/2] admin: sasl: Save the SASL username to client's identity
by Erik Skultety 01 Aug '16

01 Aug '16

Erik Skultety (2): admin: Retrieve the SASL context for both local and remote connection daemon: sasl: Don't forget to save SASL username to client's identity daemon/admin_server.c | 14 +++++++------- daemon/remote.c | 6 ++++++ 2 files changed, 13 insertions(+), 7 deletions(-) -- 2.5.5

2 3

[libvirt] [PATCH] wireshark dissector compile fix
by Benedikt Spranger 01 Aug '16

01 Aug '16

Compiling libvirt wireshark dissector on a debian based system failed: CC wireshark/src/wireshark_src_libvirt_la-packet-libvirt.lo In file included from ../../libvirt/tools/wireshark/src/packet-libvirt.c:27:0: /usr/include/wireshark/epan/proto.h:40:18: fatal error: glib.h: No such file or directory compilation terminated. Makefile:2595: recipe for target 'wireshark/src/wireshark_src_libvirt_la-packet-libvirt.lo' failed Add an explicit dependency to glib. Benedikt Spranger (1): wireshark: glib compile fix m4/virt-wireshark.m4 | 2 ++ tools/Makefile.am | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.8.1

3 5