- Devel - libvirt List Archives

[libvirt] [PATCH glib] Avoid unused variable in DHCP lease finalize method
by Daniel P. Berrange 28 Jul '16

28 Jul '16

If the network DHCP lease support is not detected, the build will generate a warning / error: libvirt-gobject-network-dhcp-lease.c: In function 'gvir_network_dhcp_lease_finalize': libvirt-gobject-network-dhcp-lease.c:99:27: error: unused variable 'lease' [-Werror=unused-variable] GVirNetworkDHCPLease *lease = GVIR_NETWORK_DHCP_LEASE(object); ^~~~~ cc1: all warnings being treated as errors Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a broken build fix libvirt-gobject/libvirt-gobject-network-dhcp-lease.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c index 7d1c979..200778d 100644 --- a/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c +++ b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c @@ -96,12 +96,10 @@ static void gvir_network_dhcp_lease_set_property(GObject *object, static void gvir_network_dhcp_lease_finalize(GObject *object) { - GVirNetworkDHCPLease *lease = GVIR_NETWORK_DHCP_LEASE(object); #ifdef HAVE_VIR_NETWORK_GET_DHCP_LEASES + GVirNetworkDHCPLease *lease = GVIR_NETWORK_DHCP_LEASE(object); GVirNetworkDHCPLeasePrivate *priv = lease->priv; -#endif /* HAVE_VIR_NETWORK_GET_DHCP_LEASES */ -#ifdef HAVE_VIR_NETWORK_GET_DHCP_LEASES virNetworkDHCPLeaseFree(priv->handle); #endif /* HAVE_VIR_NETWORK_GET_DHCP_LEASES */ -- 2.7.4

1 0

[libvirt] [PATCH] wireshark: Adapt to dissector function header change
by Michal Privoznik 28 Jul '16

28 Jul '16

In wireshark commit bbdd89b9 (contained in 2.1.0 release) they have changed prototype of dissector function. Now it returns number of bytes consumed by the dissector, and can get a pointer to user specified data (which we don't use). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/wireshark/src/packet-libvirt.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c index aa1c323..569a0a1 100644 --- a/tools/wireshark/src/packet-libvirt.c +++ b/tools/wireshark/src/packet-libvirt.c @@ -442,8 +442,14 @@ get_message_len(packet_info *pinfo ATTRIBUTE_UNUSED, tvbuff_t *tvb, int offset) return tvb_get_ntohl(tvb, offset); } +#if WIRESHARK_VERSION >= 2000001 +static int +dissect_libvirt(tvbuff_t *tvb, packet_info *pinfo, + proto_tree *tree, void *data ATTRIBUTE_UNUSED) +#else static void dissect_libvirt(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) +#endif { /* Another magic const - 4; simply, how much bytes * is needed to tell the length of libvirt packet. */ @@ -454,6 +460,10 @@ dissect_libvirt(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) tcp_dissect_pdus(tvb, pinfo, tree, TRUE, 4, get_message_len, dissect_libvirt_message, NULL); #endif + +#if WIRESHARK_VERSION >= 2000001 + return tvb_captured_length(tvb); +#endif } void -- 2.8.4

2 1

[libvirt] [PATCH 0/2] tools: Fix usage of incorrect environment variables
by Erik Skultety 28 Jul '16

28 Jul '16

According to https://bugzilla.redhat.com/show_bug.cgi?id=1357363, most of virt-admin's environment variables are not taken into effect when set. As it turned out, virsh suffers from the very same problem which resides in the generic vsh.c module. Erik Skultety (2): vsh: Make vshInitDebug return int instead of void tools: Make use of the correct environment variables tools/virsh.c | 1 + tools/virt-admin.c | 1 + tools/vsh.c | 34 +++++++++++++++++++--------------- tools/vsh.h | 1 + 4 files changed, 22 insertions(+), 15 deletions(-) -- 2.5.5

2 4

[libvirt] logging: Libvirtd could not create its own logfile, when the path /var/log/libvirt is not exist.
by weifuqiang 28 Jul '16

28 Jul '16

Hi all: Libvirtd could not create its own logfile, such as /var/log/libvirt/libvirtd.log, when the path /var/log/libvirt is not exist. It may be a problem,I think,so try to make patch when open file failed in virLogAddOutputToFile. or any better idea? ------------ Libvirtd just creates its logfile, such as /var/log/libvirt/libvirtd.log, DURING INSTALLATION. If the logfile(we mean its path here,that's /var/log/libvirt/) is deleted during its runtime, even if we restart libvirtd, such file would not be generated automatically, thus, the logs are all missing after then, it becomes impossible to debug problems after then as well. So, we try to mkdir the deleted path after restarting libvirtd. Or, any better idea? Thanks in advance. Wei Fuqiang

2 1

[libvirt] [PATCH 0/2] Couple of build fixes
by Michal Privoznik 28 Jul '16

28 Jul '16

Contradictory to my previous patch set [1], these are not pushed yet and thus require proper review. 1: https://www.redhat.com/archives/libvir-list/2016-July/msg01147.html Michal Privoznik (2): vshCmddefGetOption: Change type of opt_index vshReadlineParse: Drop some unused variables tools/vsh.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.8.4

2 3

[libvirt] [PATCH] Fix RPM spec for wireshark on Fedora < 24
by Daniel P. Berrange 28 Jul '16

28 Jul '16

This previous commit commit cd9fcc8be7dcb9126d70f744ce54b0b742eeefb8 Author: Michal Privoznik <mprivozn(a)redhat.com> Date: Wed Jul 27 16:58:32 2016 +0200 libvirt.spec.in: Adapt to newest wireshark plugindir Adapted the libvirt spec for wireshark >= 2.1.0 but this ignored the fact that we enable wireshark from Fedora 21 and 2.1.0 was only added in Fedora 24 Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt.spec.in | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 35c7449..5841f45 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -406,7 +406,11 @@ BuildRequires: numad %endif %if %{with_wireshark} +%if 0%{fedora} >= 24 BuildRequires: wireshark-devel >= 2.1.0 +%else +BuildRequires: wireshark-devel >= 1.12.1 +%endif %endif Provides: bundled(gnulib) @@ -1212,7 +1216,13 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/libvirt/lock-driver/*.a rm -f $RPM_BUILD_ROOT%{_libdir}/libvirt/connection-driver/*.la rm -f $RPM_BUILD_ROOT%{_libdir}/libvirt/connection-driver/*.a %if %{with_wireshark} +%if 0%{fedora} >= 24 rm -f $RPM_BUILD_ROOT%{_libdir}/wireshark/plugins/libvirt.la +%else +rm -f $RPM_BUILD_ROOT%{_libdir}/wireshark/plugins/*/libvirt.la +mv $RPM_BUILD_ROOT%{_libdir}/wireshark/plugins/*/libvirt.so \ + $RPM_BUILD_ROOT%{_libdir}/wireshark/plugins/libvirt.so +%endif %endif install -d -m 0755 $RPM_BUILD_ROOT%{_datadir}/lib/libvirt/dnsmasq/ -- 2.5.5

1 0

[libvirt] [PATCH 0/3] libxl hooks
by Cédric Bosdonnat 28 Jul '16

28 Jul '16

Hi there! Here is small patchset adding hooks support to the libxl driver. Cédric Bosdonnat (3): libxl: add a flag to mark guests as tainted by a hook libxl: fix segfault in libxlReconnectDomain libxl: add hooks support docs/hooks.html.in | 53 ++++++++++++++++++++++++++-- src/libxl/libxl_domain.c | 85 +++++++++++++++++++++++++++++++++++++++++++++ src/libxl/libxl_domain.h | 2 ++ src/libxl/libxl_driver.c | 52 ++++++++++++++++++++------- src/libxl/libxl_migration.c | 58 +++++++++++++++++++++++++++++++ src/util/virhook.c | 16 ++++++++- src/util/virhook.h | 13 +++++++ 7 files changed, 264 insertions(+), 15 deletions(-) -- 2.6.6

3 7

[libvirt] [PATCH] qemu: remove panic device with model s390 when migrating
by Boris Fiuczynski 28 Jul '16

28 Jul '16

The panic device with model s390 is autogenerated on domains with S390 architecture since libvirt version 1.3.5. For backwards compatibility reasons the device is to be removed when migrating. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- src/qemu/qemu_domain.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ceac22f..0d97ea6 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3310,6 +3310,28 @@ qemuDomainDefFormatBuf(virQEMUDriverPtr driver, virDomainControllerDefFree(usb); } + /* Remove the panic device with model s390 if present */ + for (i = 0; i < def->npanics; i++) { + if (def->panics[i]->model == VIR_DOMAIN_PANIC_MODEL_S390) { + virDomainPanicDefPtr *panics = def->panics; + int npanics = def->npanics; + size_t j; + + if (VIR_ALLOC_N(def->panics, npanics - 1) < 0) { + def->panics = panics; + goto cleanup; + } + + def->npanics = 0; + for (j = 0; j < npanics; j++) { + if (j != i) + def->panics[def->npanics++] = panics[j]; + } + VIR_FREE(panics); + break; /* only one panic dev with model s390 can exist */ + } + } + for (i = 0; i < def->nchannels; i++) qemuDomainChrDefDropDefaultPath(def->channels[i], driver); } -- 2.9.0

3 3

[libvirt] [libvirt RFC PATCH 00/10] Add support for qemu's JSON pseudo'protocol for backing store
by Peter Krempa 28 Jul '16

28 Jul '16

Libvirt didn't handle this for a long time and VMs with such config would not start we should implement it. Using JSON is basically the only option to specify advanced configuration for a backing file. Field names were taken from qemu's source since there isn't really documentation for this. CCing qemu-block for possible comments on patches 2-8,10. Peter Krempa (10): tests: Add testing of backing store string parser util: storage: Add parser for qemu's "json" backing pseudo-protocol util: storage: Add support for host device backing specified via JSON util: storage: Add support for URI based backing volumes in qemu's JSON pseudo-protocol util: storage: Add json pseudo protocol support for gluster volumes util: storage: Add json pseudo protocol support for iSCSI volumes Add JSON backing volume parser for 'nbd' protocol util: storage: Add JSON backing store parser for 'sheepdog' protocol util: storage: Add 'ssh' network storage protocol util: storage: Add JSON backing volume parser for 'ssh' protocol src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 1 + src/qemu/qemu_command.c | 7 + src/qemu/qemu_driver.c | 3 + src/qemu/qemu_parse_command.c | 1 + src/util/virstoragefile.c | 288 ++++++++++++++++++++++++++++++++++++++++-- src/util/virstoragefile.h | 4 + src/xenconfig/xen_xl.c | 1 + tests/virstoragetest.c | 128 +++++++++++++++++++ 9 files changed, 425 insertions(+), 9 deletions(-) -- 2.8.2

3 18

[libvirt] [PATCH 0/2] Two wireshark fixes
by Michal Privoznik 27 Jul '16

27 Jul '16

While trying to do an RPM, I've ran into two problems. I've already pushed the fixes under 'build breaker rule'. I'm sending them for completeness. Michal Privoznik (2): virt-wireshark: Properly substract wireshark prefix libvirt.spec.in: Adapt to newest wireshark plugindir libvirt.spec.in | 6 ++---- m4/virt-wireshark.m4 | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) -- 2.8.4

2 3