- Devel - libvirt List Archives

[libvirt] [PATCH] docs: remove outdated suggestion to make patches with "diff -urp" or "git diff"
by Laine Stump 01 Jul '16

01 Jul '16

I can't think of any good reason to do either of those, and having the examples there will just lead to unusable patch emails from people who can't be bothered to read the entire page. --- I'm sure there are other problems with this file, but this one really jupmed out at me when I was suggesting to someone that they look to this page for proper procedures. docs/hacking.html.in | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index a471d88..5f19143 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -23,21 +23,11 @@ automatically pulls the latest version of each translation file from zanata.</li> - <li>Post patches in unified diff format, with git rename + <li>Post patches using "git send-email", with git rename detection enabled. You need a one-time setup of: <pre> git config diff.renames true </pre> - After that, a command similar to this should work: -<pre> - diff -urp libvirt.orig/ libvirt.modified/ > libvirt-myfeature.patch -</pre> - - or: - -<pre> - git diff > libvirt-myfeature.patch -</pre> Also, for code motion patches, you may find that <code>git diff --patience</code> provides an easier-to-read patch. However, the usual workflow of libvirt developer is: -- 2.5.5

3 2

[libvirt] [PATCH] qemu: Let empty default VNC password work as documented
by Jiri Denemark 01 Jul '16

01 Jul '16

CVE-2016-5008 Setting an empty graphics password is documented as a way to disable VNC/SPICE access, but QEMU does not always behaves like that. VNC would happily accept the empty password. Let's enforce the behavior by setting password expiration to "now". https://bugzilla.redhat.com/show_bug.cgi?id=1180092 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_hotplug.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index e0b8230..bf6430d 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3933,6 +3933,7 @@ qemuDomainChangeGraphicsPasswords(virQEMUDriverPtr driver, time_t now = time(NULL); char expire_time [64]; const char *connected = NULL; + const char *password; int ret = -1; virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); @@ -3940,16 +3941,14 @@ qemuDomainChangeGraphicsPasswords(virQEMUDriverPtr driver, ret = 0; goto cleanup; } + password = auth->passwd ? auth->passwd : defaultPasswd; if (auth->connected) connected = virDomainGraphicsAuthConnectedTypeToString(auth->connected); if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0) goto cleanup; - ret = qemuMonitorSetPassword(priv->mon, - type, - auth->passwd ? auth->passwd : defaultPasswd, - connected); + ret = qemuMonitorSetPassword(priv->mon, type, password, connected); if (ret == -2) { if (type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) { @@ -3957,14 +3956,15 @@ qemuDomainChangeGraphicsPasswords(virQEMUDriverPtr driver, _("Graphics password only supported for VNC")); ret = -1; } else { - ret = qemuMonitorSetVNCPassword(priv->mon, - auth->passwd ? auth->passwd : defaultPasswd); + ret = qemuMonitorSetVNCPassword(priv->mon, password); } } if (ret != 0) goto end_job; - if (auth->expires) { + if (password[0] == '\0') { + snprintf(expire_time, sizeof(expire_time), "now"); + } else if (auth->expires) { time_t lifetime = auth->validTo - now; if (lifetime <= 0) snprintf(expire_time, sizeof(expire_time), "now"); -- 2.9.0

2 3

[libvirt] Release of libvirt-2.0.0
by Daniel Veillard 01 Jul '16

01 Jul '16

It's out ! As planned I tagged it in git and made available signed tarball and rpms at the usual place: ftp://libvirt.org/libvirt/ I also pushed a libvirt-python-2.0.0 release that can be found at: ftp://libvirt.org/libvirt/python/ Independantly of the major bump in numbering scheme (see the document at http://libvirt.org/downloads.html#numbering for new mechanism) this is a major release in terms of the number of commits included, more than 500. This includes user visible changes and APIs, a very large amount of bug fixes and massive set of improvements: Features: - Many improvements in Xen support (Jim Fehlig, Philipp Hahn, Chunyan Liu) - Many improvements in OpenVZ support (Nikolay Shirokovskiy, mfeoktistov(a)virtuozzo.com) - Guest agent vCPU APIs (Peter Krempa) - storage lifecycle event APIs (Jovanka Gulicoska) - CPU type detection (Jiri Denemark) Documentation: - Document to not rely on virConnectGetMaxVcpus API (Shivaprasad G Bhat) - add help document relevant to default mapping of credentials to machines (yuelongguang) - docs: Fix whitespace in output (John Ferlan) - util: fix a typo (Chen Hanxiao) - docs: virsh: Added note for the dump command (Jaroslav Suchanek) - docs: Add at least some docs and fix schema entry for perf events (Peter Krempa) - virsh: Fix help string for net-dumpxml (sannyshao) - doc: Fix explanation of S3 and S4 states (Jingjing Shao) - docs: Clarify chardev protocol (John Ferlan) - docs: Document our event loop (Michal Privoznik) Portability: - libvirt.spec.in: Use libnl-devel for RHEL-6 (Jean-Marc Liger) - qemuDomainDeviceDefValidate: Drop unused qemuCaps (Jiri Denemark) - vz: Fix indentation in prlsdkGetNetAddresses() (Andrea Bolognani) - Revert "util: new function virNetDevIPInfoAddToDev" (Ján Tomko) - Revert "conf: allow setting peer address in <ip> element of <interface>" (Ján Tomko) - Revert "conf: support host-side IP/route information in <interface>" (Ján Tomko) - Revert "util: support setting peer for virNetDevIPInfo addresses" (Ján Tomko) - Revert "lxc: support setting host-side IP addresses/routes" (Ján Tomko) - Revert "qemu: support setting host-side IP addresses/routes" (Ján Tomko) - Clean up after virNetDevIP creation (Andrea Bolognani) - util: netdevip: Include vircommand.h (Andrea Bolognani) - qemu: support setting host-side IP addresses/routes (Laine Stump) - lxc: support setting host-side IP addresses/routes (Laine Stump) - util: support setting peer for virNetDevIPInfo addresses (Laine Stump) - conf: support host-side IP/route information in <interface> (Laine Stump) - conf: allow setting peer address in <ip> element of <interface> (Vasiliy Tolstov) - util: new function virNetDevIPInfoAddToDev (Laine Stump) - lxc: move debug/error log when adding IP addresses to virNetDevIPAddrAdd (Laine Stump) - conf: clean up after adding calls to virNetDevIPInfo helpers (Laine Stump) - qemu: forbid setting guest-side IP address/route info of <interface> (Laine Stump) - conf: use virNetDevIPInfo for guest-side <interface> config (Laine Stump) - conf: use virNetDevIPInfo in virDomainHostdevCaps (Laine Stump) - conf: single object containing list of IP addresses, list of routes (Laine Stump) - util: move IP route & address object-related functions to virnetdevip.c (Laine Stump) - util: new files virnetdevip.[ch] for IP-related netdev functions (Laine Stump) - conf/openvz: eliminate incorrect/undocumented use of <source dev='blah'/> (Laine Stump) - qemu: eliminate memory leaks when converting NetDefs to type='ethernet' (Laine Stump) - qemu: don't set/clear NetDef IP addresses in qemuConnectDomainXMLToNative() (Laine Stump) - conf: new function virDomainNetDefClear (Laine Stump) - virHostCPUGetInfo: Fix build on non-Unix like systems (Michal Privoznik) - Fix build without xen (Martin Kletzander) - bhyve: add missing virhost(cpu|mem).h headers (Roman Bogorodskiy) - hostcpu: fix build on FreeBSD (Roman Bogorodskiy) - nodeinfo: fix build on non-Linux (Roman Bogorodskiy) - domain_conf: silence gcc warnings (Pavel Hrdina) - vz: fixed build by including necessary headers (Maxim Nestratov) - nodeinfo: remove FreeBSD specific code for getting memory (Daniel P. Berrange) - util: Alter virCryptoEncryptData for non GNUTLS builds (John Ferlan) Bug Fixes: - conf: Don't free the constructed string in virDomainGetBlkioParametersAssignFromDef (Peter Krempa) - conf: def: Avoid unnecessary allocation of 'perf' events definition (Peter Krempa) - docs: Warn against locked memory limit too high (Jiri Denemark) - qemu: SCSI hostdev hot-plug: Fix automatic creation of SCSI controllers (Marc Hartmayer) - qemu: hot-plug: Fix broken SCSI disk hot-plug (Marc Hartmayer) - qemu: Let empty default VNC password work as documented (Jiri Denemark) - admin: fix virt-admin startup crash by calling virAdmInitialize (Erik Skultety) - Fix possible invalid read in adminClientGetInfo (Ján Tomko) - virStorageTranslateDiskSourcePool: Avoid double free (Michal Privoznik) - logging: fixing log level initialization from cmdline (Jaroslav Suchanek) - vz: fix build for virNetDev* changes (Olga Krishtal) - libvirtd.conf: Fix invalid default of max_anonymous_clients (Michal Privoznik) - lxc: eliminate extraneous free of netDef->ifname_guest (Laine Stump) - vz: fix memory leaks in attach/detach functions (Nikolay Shirokovskiy) - Fix error detection in virStorageBackendISCSIGetHostNumber (Ján Tomko) - virStorageBackendISCSIGetHostNumber: correctly use virDirOpen (Ján Tomko) - storage: Fix coverity warning (Cole Robinson) - Don't allow raneming domains to empty strings (Martin Kletzander) - Revert "virnetsocket: Provide socket address format in a more standard form" (Ján Tomko) - Allow configs to start with a dot (Ján Tomko) - Do not skip hidden entries when looking for a stable path (Ján Tomko) - Do not ignore hidden files in /sys and /proc (Ján Tomko) - tests: genericxml2xml: Fix test file name (Peter Krempa) - qemu: command: Error on accel2d (Cole Robinson) - qemu: command: Error on accel3d with non-virtio (Cole Robinson) - Allow virDomain(SG)etGuestVcpus on read-write connection only (Peter Krempa) - libxl: use serial device for console when targetType is serial (Jim Fehlig) - conf: Remove redundant free in virCPUDefFree (Jiri Denemark) - qemu: Fix reference leak in qemuDomainDefPostParse (Jiri Denemark) - tests: Adjust tests for encrypted storage (John Ferlan) - conf: limit chassisNr, and busNr to a minimum value of 1, not 0 (Laine Stump) - virsh migrate: Fix positional parameters (Jiri Denemark) - util: Make failure to get supplementary group list for a uid non-fatal (Peter Krempa) - tools: virt-login-shell: Fix group list bounds checking (Peter Krempa) - conf: Fix memory leak in graphics XML parser (Peter Krempa) - qemu: restore non-pci hostdev labels after detach (Ján Tomko) - configure: define preprocessor macros for SCSI and MPATH (Ján Tomko) - spec: Make driver-qemu require driver-storage (Martin Kletzander) - conf: Remove pre-calculation of initial memory size (Peter Krempa) - conf: Fix perf event parser (Peter Krempa) - qemu: perf: Don't set state of first event for every other event (Peter Krempa) - xenconfig: fix conversion of <driver> to backendtype (Jim Fehlig) - util: fix missing broadcast address in bridge and tap device IP addresses (Laine Stump) - qemu: Shorten domain name for watchdog coredump (Martin Kletzander) - util: Fix broken syntax-check (John Ferlan) - docs: document rng backend path restrictions of older libvirt (Ján Tomko) - docs: Fix syntax-check (John Ferlan) - Fix renumbering once again (Martin Kletzander) - qemu: Allow ACPI shutdown only for running domains (Martin Kletzander) - virt-host-validate: fix build with clang (Roman Bogorodskiy) - tests: fix CPUID detection tests compilation failure (Wei Liu) - apparmor: Don't scrub environment of virtlogd process (Guido Günther) - bhyve: fix bhyvexml2arg test (Roman Bogorodskiy) - vz: fix crash when parsing unexpected disk configuration (Maxim Nestratov) - vz: return correct result for unimplemented ChangeState actions (Maxim Nestratov) - qemuMonitorJSONAttachCharDev: Teach spicevmc (Michal Privoznik) - qemu: Yet another check for blkdeviotune values (Martin Kletzander) - qemu: Generate channel target paths on hotplug as well (Martin Kletzander) - virsh-domain: fix memory leak in cmdDomDisplay (Pavel Hrdina) - virsh-network: Avoid possible NULL deref in cmdNetworkDHCPLeases (Michal Privoznik) - virsh: domdisplay: if listen is 0.0.0.0 or [::] print address from URI (Pavel Hrdina) - qemu_process: don't print empty line if qemu exits without any error (Pavel Hrdina) - virschematest: Link with libxml2 (Michal Privoznik) - virschematest: Access the right directory containing XMLs (Michal Privoznik) - qemu: process: Call disk startup policy check after cloning domain def (Peter Krempa) - qemu: driver: Unset log file watcher after restoring a VM save file (Peter Krempa) - test: Remove executable permission from Xen xm files (Philipp Hahn) - qemu: process: Append the "shutting down" message using the new APIs (Peter Krempa) - Do not VIR_STRDUP the string in udevGetDeviceProperty (Ján Tomko) - systemd: directly notify systemd instead of using sd_notify (Daniel P. Berrange) Improvements: - dist: Speed up distribution compression (Martin Kletzander) - tests: Add test cases for SCSI disk hot-plug with QEMU (Marc Hartmayer) - qemu: Use proper async job to refresh virtio channels (Jiri Denemark) - lxc: use correct prefix when setting veth IP address (Laine Stump) - util: allow calling virSocketAddrGetIPPrefix with NULL netmask or address (Laine Stump) - tests: mock virNetDevSetIPAddress (Laine Stump) - conf: clean up virDomainNetIPParseXML() (Laine Stump) - global: consistently use IP rather than Ip in identifiers (Laine Stump) - util: move virInterface(State|Link)/virNetDevFeature from conf to util (Laine Stump) - util: move virNetDevLinkDump to virnetlink.c (Laine Stump) - spec: distribute admin API within libvirt-client package (Erik Skultety) - examples: admin: Add some examples for the new admin APIs (Erik Skultety) - admin: enable both admin API functionality and tarball distribution (Erik Skultety) - vz: always pass graphics address to sdk (Nikolay Shirokovskiy) - vz: support vnc password (Nikolay Shirokovskiy) - vz: remove exlicitly setting zeros in dumping graphics (Nikolay Shirokovskiy) - vz: support attach/detach/update/ of graphics device (Nikolay Shirokovskiy) - vz: move getting container video devices out from vnc code (Nikolay Shirokovskiy) - vz: trustGuestRxFilters fixes (Nikolay Shirokovskiy) - vz: fix minor type safey issues with net union usage (Nikolay Shirokovskiy) - vz: fix updating to no gateways (Nikolay Shirokovskiy) - vz: dump route info in domain xml (Nikolay Shirokovskiy) - vz: dump ip addresses to domain xml (Nikolay Shirokovskiy) - vz: give nice report if network device not found (Nikolay Shirokovskiy) - vz: move disks checks to device post parse (Nikolay Shirokovskiy) - vz: leverage disks parameters check on disks updates too (Nikolay Shirokovskiy) - vz: add device updates (Nikolay Shirokovskiy) - vz: reuse edit config frame in for attach/detach functions (Nikolay Shirokovskiy) - vz: make prlsdkGetDisk more generic (Nikolay Shirokovskiy) - vz: remove disk cache mode hunk (Nikolay Shirokovskiy) - cpu_map.xml: add cmt/mbm feature to x86 (Qiaowei Ren) - cpu: Consolidate ARM drivers (Jiri Denemark) - util: fix build in virNetDevTapGetRealDeviceName (Roman Bogorodskiy) - storage: Introduce virStoragePoolObjBuildTempFilePath (John Ferlan) - Promote storage pool refresh lifecycle event to top level event (Daniel P. Berrange) - util: Add 'luks' to the FileTypeInfo (John Ferlan) - util: Modify the FileTypeInfo to add a version size (John Ferlan) - util: Introduce virReadBufInt16LE and virReadBufInt16BE (John Ferlan) - qemu: Remove authdef from secret setup (John Ferlan) - qemu: Change protocol parameter for secret setup (John Ferlan) - qemu: check the kvm host cpu max limits in virConnectGetDomainCapabilities (Shivaprasad G Bhat) - qemu: Make qemuBuildSecretInfoProps global (John Ferlan) - qemu: Remove type from qemuBuildSecretInfoProps (John Ferlan) - Rename kvmGetMaxVCPUs() to virHostCPUGetKVMMaxVCPUs() (Shivaprasad G Bhat) - conf: Allow disks with identical WWN or serial (Peter Krempa) - build: increase xz compression level (Ján Tomko) - openvz: do not open-code STRSKIP (Ján Tomko) - Replace some uses STREQLEN with STRPREFIX (Ján Tomko) - qemu: Check for VFIO too where legacy passthrough is checked (Shivaprasad G Bhat) - Prohibit opendir in syntax-check (Ján Tomko) - Use virDirOpenQuiet (Ján Tomko) - Introduce virDirOpenQuiet (Ján Tomko) - Use virDirOpenIfExists (Ján Tomko) - Add virDirOpenIfExists (Ján Tomko) - Use virDirOpen (Ján Tomko) - Introduce virDirOpen (Ján Tomko) - openvz: split single-line if (Ján Tomko) - qemu: Use stricter checks in virQEMUCapsFillDomainDeviceDiskCaps() (Andrea Bolognani) - qemu: Introduce qemuDomainMachineIsPSeries() (Andrea Bolognani) - qemu: Add architecture checks to qemuDomainMachineIsVirt() (Andrea Bolognani) - qemu: Remove redundant arguments to qemuBuildSerialChrDeviceStr() (Andrea Bolognani) - Add support for VirtualBox 5 (Martin Pietsch) - Rename virNetClient*AddrString (Ján Tomko) - Rename virNetServerClient*AddrString (Ján Tomko) - Add SASL to virNetSocket{Local,Remote}AddrString (Ján Tomko) - virNetSocket: rename AddrStr to AddrStrSASL (Ján Tomko) - virnetsockettest: fix error messages (Ján Tomko) - Introduce virNetServerClientRemoteAddrStringURI (Ján Tomko) - Introduce virNetSocketRemoteAddrStringURI (Ján Tomko) - Do not skip files starting with a dot in leases directory (Ján Tomko) - Fix comment in virStorageBackendFileSystemRefresh (Ján Tomko) - Do not check for '.' and '..' after virDirRead (Ján Tomko) - Skip '.' and '..' in virDirRead (Ján Tomko) - Introduce VIR_DIR_CLOSE (Ján Tomko) - Do not check the return value of closedir (Ján Tomko) - Do not save errno in virUSBDeviceSearch (Ján Tomko) - tests: utils: Fail XML file comparison if input file doesn't exist (Peter Krempa) - qemu: Add new secret info type (John Ferlan) - util: Introduce virSecretLookupFormatSecret (John Ferlan) - util: Move and rename virStorageAuthDefParseSecret (John Ferlan) - secret: Move virStorageSecretType and rename (John Ferlan) - storage: Remove redundant refreshPool check (Cole Robinson) - qemu: make monitor command API available during async jobs (Nikolay Shirokovskiy) - prohibit-duplicate-header: print file name and line (Ján Tomko) - syntax-check: rewrite prohibit-duplicate-header in perl (Ján Tomko) - Do not ignore perl scripts in build-aux (Ján Tomko) - Add newDomain parameter to qemuDomainAssignAddresses (Ján Tomko) - Add a USB hub to controller order test (Ján Tomko) - conf: Remove dead console compat formatting (Cole Robinson) - Use for instead of code duplication when parsing USB port (Ján Tomko) - Split out USB port parsing (Ján Tomko) - Add a test for long USB port paths (Ján Tomko) - Report auto convergence throttle rate in migration stats (Jiri Denemark) - qemu: Implement auto convergence migration parameters (Jiri Denemark) - qemu: Add support for cpu throttling parameters (Jiri Denemark) - qemu: Introduce qemuMigrationSetParams (Jiri Denemark) - Add auto convergence migration parameters (Jiri Denemark) - test: Rework qemuMonitorJSONGetMigrationParams test (Jiri Denemark) - qemu: Rework qemuMonitorJSONSetMigrationParams (Jiri Denemark) - qemu: Rework qemuMonitorJSONGetMigrationParams (Jiri Denemark) - qemu: Rename qemuMonitorMigrationCompression (Jiri Denemark) - qemu: Decouple migration parameters from compression settings (Jiri Denemark) - qemu: Make qemuMonitorSetMigrationCompression saner (Jiri Denemark) - conf: Simplify conditions in CPU parser/formatter (Jiri Denemark) - qemucapsprobe: Don't put empty line at EOF (Jiri Denemark) - qemu: Hide virQEMUCapsNewForBinary (Jiri Denemark) - qemu: Implement virDomainSetGuestVcpus (Peter Krempa) - qemu: Implement virDomainGetGuestVcpus (Peter Krempa) - qemu: agent: Make setting of vcpus more robust (Peter Krempa) - virsh: Add command 'guestvcpus' implementing virDomain(GS)etGuestVcpus (Peter Krempa) - lib: Add API to set individual vcpu usage in the guest via guest agent (Peter Krempa) - lib: Add API to query guest vcpu info using guest agent (Peter Krempa) - rpcgen: Add support for generating funcs returning alloc'd typed params (Peter Krempa) - storage: Use virSecretGetSecretString (John Ferlan) - storage: Create helper to set options for CreateQemuImg code (John Ferlan) - storage: Create helper to set backing for CreateQemuImg code (John Ferlan) - storage: Adjust qemu-img switches check (John Ferlan) - Do not call postParse with ABI_UPDATE when parsing cmdline (Ján Tomko) - Fix USB port in input-usbmouse test (Ján Tomko) - test-wrap-argv: add --check parameter (Ján Tomko) - test-wrap-argv: add --in-place parameter (Ján Tomko) - test-wrap-argv: hold a copy of the original file in an array (Ján Tomko) - test-wrap-argv: return a string in rewrap_line (Ján Tomko) - test-wrap-argv: use map and join instead of a for cycle (Ján Tomko) - test-wrap-argv: return a string in rewrap_arg (Ján Tomko) - test-wrap-argv: split out rewrap_arg (Ján Tomko) - test-wrap-argv: split out rewrap_line (Ján Tomko) - vsh: remove namespace poisoning (Ján Tomko) - vbox: remove duplicate macros (Ján Tomko) - Remove unused SOL_NETLINK macro (Ján Tomko) - qemu: Fix typo pci-extender-bus -> pci-expander-bus (Andrea Bolognani) - Mark virsh-optparse as expensive (Ján Tomko) - Drop virrandomtest (Ján Tomko) - Remove virsh-synopsis (Ján Tomko) - Introduce virsh self-test (Ján Tomko) - tests: mock gnutls_dh_params_generate2 (Ján Tomko) - Remove virsh-all (Ján Tomko) - util: Add option not to report errors in virGetUserEnt (Peter Krempa) - tools: virt-login-shell: Fix cut'n'paste mistake in error message (Peter Krempa) - conf: Fix label name in virDomainGraphicsListensParseXML (Peter Krempa) - Allow disjunct ranges in VIR_TEST_RANGE (Ján Tomko) - Introduce virBitmapParseUnlimited (Ján Tomko) - Remove separator argument from virBitmapParse (Ján Tomko) - Introduce virBitmapParseSeparator (Ján Tomko) - Do not return number of set bits in virBitmapParse (Ján Tomko) - qemu: Don't use legacy USB for aarch64 mach-virt guests (Andrea Bolognani) - qemu_hotplug: Use a helper variable consistently (Tomasz Flendrich) - virsh: Introduce pool-event command (Jovanka Gulicoska) - libxl: add USB to hostdev domcapabilities (Jim Fehlig) - Remove stray space in cmdHelp (Ján Tomko) - qemu: Permit PCI-free aarch64 mach-virt guests (Andrea Bolognani) - qemuDomainDetachDeviceConfig: Allow cold unplug of redirdevs (Michal Privoznik) - qemuDomainAttachDeviceConfig: Allow redirdev coldplug (Michal Privoznik) - virDomainDeviceInfoIterateInternal: Iterate through redirdevs too (Michal Privoznik) - virDomainRedirdevDef: Introduce find & remove routines (Michal Privoznik) - domain_conf: Validate redirdev after parsing (Michal Privoznik) - configure: remove definition of HAVE_GLIBC_RPCGEN (Ján Tomko) - configure: error out when asked for mpath on non-Linux (Ján Tomko) - qemu: Fix alignment in virDomainDefAddController() call (Andrea Bolognani) - tests: schema: Remove useless perf schema data (Peter Krempa) - docs: virsh: Add minimal documentation for 'mbmt' and 'mbml' perf events (Peter Krempa) - cpu_x86: Use signature in CPU detection code (Jiri Denemark) - cpu: Add Skylake-Client x86 CPU model (Jiri Denemark) - conf: Rename virDomainDefGetMemoryActual to virDomainDefGetMemoryTotal (Peter Krempa) - qemu: don't add pci-bridge to Q35/arm domains unless it's needed (Laine Stump) - qemu: don't be as insistent about adding dmi-to-pci-bridge or pci-bridge (Laine Stump) - util: remove redundant comments (Chen Hanxiao) - event-test: support storage lifecycle event APIs (Jovanka Gulicoska) - storage: implement storage lifecycle event APIs (Jovanka Gulicoska) - remote: implement storage lifecycle event APIs (Jovanka Gulicoska) - test: implement storage lifecycle event APIs (Jovanka Gulicoska) - conf: add storage_event handling (Jovanka Gulicoska) - Introduce storage lifecycle event APIs (Jovanka Gulicoska) - qemu: Remove useless block in processWatchdogEvent (Martin Kletzander) - qemu: Follow coding style convention (Martin Kletzander) - qemu: Unify automatic coredump filenames (Martin Kletzander) - qemu: Add cfg pointer to various command line helpers (John Ferlan) - qemu: Make qemuBuildShmemBackendStr private (John Ferlan) - qemu: migration: use consistent error message (Cole Robinson) - qemu: More usage of qemuDomainDiskBlockJobIsActive (Cole Robinson) - add default mapping of credentials to machine (yuelongguang) - syntax-check: drop prohibit_undesirable_word_seq (Ján Tomko) - maint: Switch to xz compressed PAX release archives (Andrea Bolognani) - vz: get rid of unused home state variable in private domain obj (Nikolay Shirokovskiy) - check-spacing: fix error message (Ján Tomko) - check-spacing: use non-capturing groups (Ján Tomko) - check-spacing: remove virAssertCmpInt exception (Ján Tomko) - check-spacing: simplify keyword spacing check (Ján Tomko) - check-spacing: rewrite regex for checking the closing parenthesis (Ján Tomko) - check-spacing: rewrite whitespace check before (semi)colon (Ján Tomko) - Rename bracket-spacing.pl to check-spacing.pl (Ján Tomko) - Rename virAssertCmpInt to testAssertEq (Ján Tomko) - maint: remove whitespace from closing parentheses (Ján Tomko) - vbox: reformat multi-line error reports (Ján Tomko) - cfg.mk: use a single regex for all non-reentrant functions (Ján Tomko) - xlconfigtest: add test for USB config conversion (Chunyan Liu) - Add conversion of domxml USB config to/from xl.cfg (Chunyan Liu) - libxl: support hotplug USB host device (Chunyan Liu) - libxl: support creating guest with USB hostdev (Chunyan Liu) - qemu: Refactor qemuDomainAttachChrDevice error paths (John Ferlan) - caps: Add capability for tls-x509-creds (John Ferlan) - Change 1.3.6 occurrences to 2.0.0 to follow version bump (Martin Kletzander) - qemu: Obtain job before checking if domain is live (Martin Kletzander) - Bump release to 2.0.0 and document release schedule & versioning (Daniel P. Berrange) - cputest: Get rid of the array of test functions (Jiri Denemark) - qemu: Add support for zero-detection writes (Martin Kletzander) - conf: Add support of zero-detection for disks (Martin Kletzander) - libxl: Add support for ovmf firmware (Jim Fehlig) - xenconfig: support bios=ovmf xl.cfg (Jim Fehlig) - libxl: implement connectGetDomainCapabilities (Jim Fehlig) - libxl: introduce libxl_capabilities.{ch} (Jim Fehlig) - libxl: add default firmwares to driver config object (Jim Fehlig) - driver config: Introduce virFirmware object (Jim Fehlig) - libxl: fix vm lock overwritten bug (Wang Yufei) - virt-host-validate: improve tests for arm/aarch64 (Riku Voipio) - virt-login-shell: mark as Linux only (Roman Bogorodskiy) - vz: implementation of domainSetUserPassword callback (Mikhail Feoktistov) - vz: remove unused macro logPrlEventError (Maxim Nestratov) - vz: keep subscription to performance events thru domain lifetime (Nikolay Shirokovskiy) - vz: use consistent naming for different domain object in vz_driver.c (Nikolay Shirokovskiy) - Export virDomainRedirdevDefFree (Michal Privoznik) - virt-login-shell: add ability to join the container cgroups (Daniel P. Berrange) - virt-login-shell: add ability to auto-detect shell from container (Daniel P. Berrange) - virt-login-shell: fully reset container environment (Daniel P. Berrange) - virt-login-shell: avoid loosing error during cleanup (Daniel P. Berrange) - virt-login-shell: allow shell to be a simple string argument (Daniel P. Berrange) - virt-login-shell: change way we request a login shell (Daniel P. Berrange) - virt-login-shell: honour the -c option to launch commands (Daniel P. Berrange) - virsh: make lxc-enter-namespace also join the cgroups (Daniel P. Berrange) - libvirt-lxc: add virDomainLxcEnterCGroup API (Daniel P. Berrange) - util: add function for looking up the user shell (Daniel P. Berrange) - nodeinfo: move host memory APIs out into virhostmem file (Daniel P. Berrange) - nodeinfo: move host CPU APIs out into virhostcpu.c file (Daniel P. Berrange) - nodeinfo: rename all CPU APIs to have a virHostCPU prefix (Daniel P. Berrange) - nodeinfo: rename all memory APIs to have a virHostMem prefix (Daniel P. Berrange) - nodeinfo: split CPU info retrieval out of nodeGetInfo (Daniel P. Berrange) - nodeinfo: make nodeGetInfo() call nodeGetMemory for memory size (Daniel P. Berrange) - nodeinfo: remove sysfs_prefix from all methods (Daniel P. Berrange) - vnc: add support for listen type none (Pavel Hrdina) - spice: introduce listen type none (Pavel Hrdina) - spice: introduce spice_auto_unix_socket config option (Pavel Hrdina) - spice: add support for listen type socket (Pavel Hrdina) - qemu_capabilites: add QEMU_CAPS_SPICE_UNIX (Pavel Hrdina) - vnc: add support for listen type 'socket' (Pavel Hrdina) - graphics: introduce new listen type 'socket' (Pavel Hrdina) - vnc: move generation of socket path to qemuProcessGraphicsSetupListen (Pavel Hrdina) - vnc: rename socketAutogenerated to socketFromConfig (Pavel Hrdina) - qemu_command: move websocket code into else part for address listen (Pavel Hrdina) - qemuhotplugtest: Test live data (Martin Kletzander) - qemu: Move channel path generation out of command creation (Martin Kletzander) - cputest: Rename nehalem-force to penryn-force (Jiri Denemark) - cpu: Add ARAT x86 CPU feature (Jiri Denemark) - cpu: Add x86 feature flags for CPUID leaf 0xd, sub leaf 1 (Jiri Denemark) - cpu: Sort CPU map features on eax_in (Jiri Denemark) - cpu: Shorten eax_in values in CPU map (Jiri Denemark) - cpu_x86: Add full support for ecx_in CPUID parameter (Jiri Denemark) - cpu_x86: Prepare for ecx_in CPUID parameter (Jiri Denemark) - qemumonitorjsontest: Add getcpu test data (Jiri Denemark) - tests: Add CPU detection test for Intel Xeon X5460 (Jiri Denemark) - tests: Add CPU detection test for Intel Xeon W3520 (Jiri Denemark) - tests: Add CPU detection test for Intel Xeon E7-4820 (Jiri Denemark) - tests: Add CPU detection test for Intel Xeon E5-2650 (Jiri Denemark) - tests: Add CPU detection test for Intel Xeon E5-2630 (Jiri Denemark) - tests: Add CPU detection test for Intel Xeon E3-1245 (Jiri Denemark) - tests: Add CPU detection test for Intel Xeon 5110 (Jiri Denemark) - tests: Add CPU detection test for AMD Phenom II X4 B95 (Jiri Denemark) - tests: Add CPU detection test for Intel Pentium P6100 (Jiri Denemark) - tests: Add CPU detection test for AMD Opteron 6282 SE (Jiri Denemark) - tests: Add CPU detection test for AMD Opteron 6234 (Jiri Denemark) - tests: Add CPU detection test for AMD Opteron 2350 (Jiri Denemark) - tests: Add CPU detection test for AMD Opteron 1352 (Jiri Denemark) - tests: Add CPU detection test for AMD FX 8150 (Jiri Denemark) - tests: Add CPU detection test for Intel Core2 Quad Q9500 (Jiri Denemark) - tests: Add CPU detection test for Intel Core2 Duo E6850 (Jiri Denemark) - tests: Add CPU detection test for Intel Core i7-5600U (Jiri Denemark) - tests: Add CPU detection test for Intel Core i7-4600U (Jiri Denemark) - tests: Add CPU detection test for Intel Core i7-3770 (Jiri Denemark) - tests: Add CPU detection test for Intel Core i7-3740QM (Jiri Denemark) - tests: Add CPU detection test for Intel Core i7-3520M (Jiri Denemark) - tests: Add CPU detection test for Intel Core i7-2600 (Jiri Denemark) - tests: Add CPU detection test for Intel Core i5-6600 (Jiri Denemark) - tests: Add CPU detection test for Intel Core i5-4670T (Jiri Denemark) - tests: Add CPU detection test for Intel Core i5-2540M (Jiri Denemark) - tests: Add CPU detection test for Intel Core i5-2500 (Jiri Denemark) - tests: Add CPU detection test for Intel Atom N450 (Jiri Denemark) - tests: Add CPU detection test for Intel Atom D510 (Jiri Denemark) - tests: Add CPU detection test for AMD A10-5800K (Jiri Denemark) - tests: Add CPU detection tests (Jiri Denemark) - cpu_x86: Refactor internal KVM features (Jiri Denemark) - cpu_ppc64: Avoid unnecessary pointer to virCPUppc64Data (Jiri Denemark) - cpu_x86: Avoid unnecessary pointers to virCPUx86Data (Jiri Denemark) - tests: Create simple monitor in qemuMonitorTestNewFromFile (Jiri Denemark) - tests: Fix "Reponse" typo (Jiri Denemark) - tests: Introduce qemuMonitorTestNewFromFile (Jiri Denemark) - qemu: Refactor qemuMonitorJSONGetCPUx86Data (Jiri Denemark) - cpu_x86: Rename CPUID function to eax_in (Jiri Denemark) - cpu: Detect arch when parsing CPU data (Jiri Denemark) - cpu_x86: Fix CPU data parser (Jiri Denemark) - cpu_x86: Propagate vendor to guest's virCPUData (Jiri Denemark) - Fix typo in virNetDevGetEthtoolGFeatures stub (Ján Tomko) - tests: Rename virtTestMain to virTestMain. (Tomáš Ryšavý) - tests: Rename virtTestErrorFuncQuiet to virTestErrorFuncQuiet. (Tomáš Ryšavý) - tests: Rename virtTestCounterNext to virTestCounterNext. (Tomáš Ryšavý) - tests: Rename virtTestCaptureProgramOutput to virTestCaptureProgramOutput. (Tomáš Ryšavý) - tests: Rename virtTestDifferenceBin to virTestDifferenceBin. (Tomáš Ryšavý) - tests: Rename virtTestCaptureProgramExecChild to virTestCaptureProgramExecChild. (Tomáš Ryšavý) - tests: Rename virtTestDifferenceFullInternal to virTestDifferenceFullInternal. (Tomáš Ryšavý) - tests: Rename virtTestDifferenceFullNoRegenerate. (Tomáš Ryšavý) - tests: Rename virtTestQuiesceLibvirtErrors to virTestQuiesceLibvirtErrors. (Tomáš Ryšavý) - tests: Rename virtTestUseTerminalColors to virTestUseTerminalColors. (Tomáš Ryšavý) - tests: Rename virtTestLogContentAndReset to virTestLogContentAndReset. (Tomáš Ryšavý) - tests: Rename virtTestCounterReset to virTestCounterReset. (Tomáš Ryšavý) - tests: Rename virtTest00MActive to virTest00MActive. (Tomáš Ryšavý) - tests: Rename virtTestClearCommandPath to virTestClearCommandPath. (Tomáš Ryšavý) - Rename virtTestDifferenceFull to virTestDifferenceFull. (Tomáš Ryšavý) - tests: Rename virtTestCompareToFile to virTestCompareToFile. (Tomáš Ryšavý) - Rename virtTestLoadFile to virTestLoadFile. (Tomáš Ryšavý) - Rename virtTestDifference to virTestDifference. (Tomáš Ryšavý) - tests: Rename virtTestRun to virTestRun. (Tomáš Ryšavý) - virschematest: call va_end even on OOM (Ján Tomko) - node_device: Replace VIR_ERROR with standard vir*Error in state driver init (Jovanka Gulicoska) - lxc: simplify lxcDomainGetBlkioParameters (Ján Tomko) - Export virDomainGetBlkioParametersAssignFromDef (Ján Tomko) - Use virDomainObjGetDefs in lxcDomainGetBlkioParameters (Ján Tomko) - Use virDomainObjGetDefs in lxcDomainSetBlkioParameters (Ján Tomko) - Use virDomainObjGetDefs in lxcDomainGetMemoryParameters (Ján Tomko) - Use virDomainObjGetDefs in lxcDomainGetSchedulerParametersFlags (Ján Tomko) - Use virDomainObjGetDefs in lxcDomainSetSchedulerParametersFlags (Ján Tomko) - Use virDomainObjGetDefs in lxcDomainSetMemoryFlags (Ján Tomko) - lxc: rename vmdef to persistentDef (Ján Tomko) - Use @SYSTEM priority for TLS on Fedora >= 21 (Daniel P. Berrange) - remote: allow TLS priority to be customized (Daniel P. Berrange) - Pass config file object through to driver open methods (Daniel P. Berrange) - remote: allow TLS protocol/cipher priority override in URI (Daniel P. Berrange) - libvirtd: add config option for TLS priority (Daniel P. Berrange) - rpc: allow priority string to be passed to TLS context (Daniel P. Berrange) - configure: allow setting default TLS priority string (Daniel P. Berrange) - rpc: set gnutls log function at global init time (Daniel P. Berrange) - tls: remove support for gnutls 1.x.x, require 2.2.0 (Daniel P. Berrange) - qemu_monitor: rephrase error message if qemu closes monitor (Pavel Hrdina) - Introduce virschematest (Ján Tomko) - Introduce virXMLValidatorValidate (Ján Tomko) - Introduce virXMLValidatorInit (Ján Tomko) - Introduce virXMLValidatorFree (Ján Tomko) - Introduce virXMLValidator structure (Ján Tomko) - qemu: domain: Sanitize return value handling in disk presence checker (Peter Krempa) - xen: test for driver=tap2 sub-type in xen-xm (Philipp Hahn) - xen: Also add sub-type for driver=tap2 in xen-xm (Philipp Hahn) - qemu: Replace VIR_ERROR with standard vir*Error in state driver init (Jovanka Gulicoska) - xen: Replace VIR_ERROR with standard vir*Error in state driver init (Jovanka Gulicoska) - uml: Replace VIR_ERROR with standard vir*Error in state driver init (Jovanka Gulicoska) - qemu: migration: Add VM log entry on start of migration (Peter Krempa) - qemu: domain: Implement helper for one-shot log entries to the VM log file (Peter Krempa) - log: daemon: Add remote protocol handling for the log appending API (Peter Krempa) - log: handler: Add new API to append to logging files (Peter Krempa) - util: Perform proper virRandomBytes return value checking (John Ferlan) - Reindent virNetDevSendEthtoolIoctl (Ján Tomko) - Reuse the socket in virNetDevGetFeatures (Ján Tomko) - Return bool in virNetDevFeatureAvailable (Ján Tomko) - Split out virNetDevGetEthtoolGFeatures (Ján Tomko) - Split out virNetDevGetEthtoolFeatures (Ján Tomko) - Move struct elem out of virNetDevGetFeatures (Ján Tomko) - Reindent comment of virNetDevFeatureAvailable (Ján Tomko) - qemu: process: Allow VIR_QEMU_PROCESS_START_NEW in qemuProcessLaunch (Peter Krempa) - Add nomatch filters when enumerating udev devices (Ján Tomko) - node_device_udev: rename labels to cleanup (Ján Tomko) - node_device_udev: remove unnecessary ret variables (Ján Tomko) - qemu: Move check that validates 'min_guarantee' to qemuDomainDefValidate (Peter Krempa) - conf: Move validation of disk LUN device to the appropriate place (Peter Krempa) - conf: Move disk info validator to the domain conf validator (Peter Krempa) - qemu: process: Call the domain config validator when starting a new VM (Peter Krempa) - qemu: process: Convert multiple boolean args to a single flag (Peter Krempa) - qemu: process: Unexport qemuProcessStartValidate (Peter Krempa) - conf: Add device def validation callback (Peter Krempa) - conf: drop 'def' from struct virDomainDefPostParseDeviceIteratorData (Peter Krempa) - conf: Add infrastructure for adding configuration validation (Peter Krempa) - conf: Rename VIR_DOMAIN_DEF_PARSE_VALIDATE to VIR_DOMAIN_DEF_PARSE_VALIDATE_SCHEMA (Peter Krempa) - node_device_udev: remove yoda condition (Ján Tomko) - udevSetupSystemDev: return if allocation fails (Ján Tomko) - Reformat udevProcessRemoveableMedia (Ján Tomko) - udevProcessStorage: trim all whitespace from model and vendor (Ján Tomko) - node_device_udev: switch to using virReportError (Ján Tomko) - Remove PROPERTY_* constants (Ján Tomko) - Only return two values in udevGetUintSysfsAttr (Ján Tomko) - Only return two values in udevGetIntSysfsAttr (Ján Tomko) - Only return two values in udevGetStringSysfsAttr (Ján Tomko) - Remove extra allocation in udevGetDeviceSysfsAttr (Ján Tomko) - Only return two values in udevGetUintProperty (Ján Tomko) - Only return two values in udevGetStringProperty (Ján Tomko) - qemu: Add support to QXL's max_outputs parameter (Martin Kletzander) - qemu: Check for qxl's max_outputs parameter (Martin Kletzander) - Rewrite disk type checking in udevProcessStorage (Ján Tomko) - Fix the return value in udevKludgeStorageType (Ján Tomko) - udevProcessFloppy; remove unnecessary allocation (Ján Tomko) - Move udevHasDeviceProperty earlier (Ján Tomko) - Remove udevStrToLong_i (Ján Tomko) - Remove udevStrToLong_ui (Ján Tomko) - Remove udevStrToLong_ull (Ján Tomko) - Rewrite usage of StrToLong_ui in udevProcess{PCI,SCSI} (Ján Tomko) - udevProcessSCSIHost: use STRSKIP (Ján Tomko) - udevGetDMIData: remove unused variable (Ján Tomko) - Assign node device driver private data earlier (Ján Tomko) - Do not call nodeStateCleanup on early initialization error (Ján Tomko) - Reformat nodeStateCleanup (Ján Tomko) - node_device_udev: initialize libpciaccess after the driver lock (Ján Tomko) - Split out pciaccess (de)initialization (Ján Tomko) - Initialize ret to -1 in nodeStateInitialize (Ján Tomko) - qemu: Move and rename qemuBuildObjectCommandlineFromJSON (John Ferlan) - storage: Create helper to set input for CreateQemuImg code (John Ferlan) - storage: Split out a helper for encryption checks (John Ferlan) - storage: Split out setting default secret for encryption (John Ferlan) - util: Clean up code formatting in virstorageencryption (John Ferlan) - Do not check for domain liveness in virDomainObjSetDefTransient (Ján Tomko) - Check if the domain is active in virDomainObjGetPersistentDef (Ján Tomko) - Clean up redundant usage of virDomainObjSetDefTransient (Ján Tomko) - Post-release version bump to 1.3.6 (Ján Tomko) Thanks everyone for contributing to this release, with bug reports, patches, reviews, documentation etc ... Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] Entering freeze for libvirt-2.0.0
by Daniel Veillard 01 Jul '16

01 Jul '16

As planned the Release candidate 1 of libvirt 2.0.0 is tagged in git, I have made signed tarball and rpms available at the usual place: ftp://libvirt.org/libvirt/ Seems to work just fine in my limited testing, but there is a number of packaging changes and we need to look for issues that could come from bumping the major release version. If things go as planned an RC2 on Tuesday or Wednesday and final release on Friday is the schedule, but please give it some testing it would be a shame to have 2.0.0 be a brown paper bag release ! :-) Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

6 7

[libvirt] [PATCH] dist: Speed up distribution compression
by Martin Kletzander 01 Jul '16

01 Jul '16

This almost reverts b7200d723648. The size is increased from 11M to 13M and the compression is sped up from 2 minutes to 17 seconds. The compression level is removed because -9 doesn't allow multiple threads to be spawned. Effectively speeds up distcheck as well. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 99ee4763c5cd..50c358c30d2c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,7 +22,7 @@ GENHTML = genhtml SUBDIRS = . gnulib/lib include/libvirt src daemon tools docs gnulib/tests \ tests po examples -XZ_OPT ?= -9ev +XZ_OPT ?= -v -T0 export XZ_OPT ACLOCAL_AMFLAGS = -I m4 -- 2.9.0

3 3

[libvirt] [PATCH 0/2] option to disable default gateway in IPv6 RA
by Maxim Perevedentsev 01 Jul '16

01 Jul '16

In case of DHCPv6 in isolated network, we start dnsmasq which sends Router Advertisements (RA). If RA containts no gateway then the link-local address of the source of RA is considered a gateway (and guest installs a corresponding default route). If a guest has two network interfaces (public and isolated network) and the user installs a default route through "public" interface, the guest will have something like default via fe80::ffff:1:1 dev eth2 metric 1024 default via fe80::5054:ff:fe0a:d808 dev eth3 proto ra metric 1024 expires 1789sec RA route metric may vary, and it is preferred. The validity of default route is controlled by "default [route] lifetime" field in RA. If it is 0, then the default gateway announced is considered invalid, and no default route is installed into guest. dnsmasq 2.67+ supports "ra-param=<interface>,<RA interval>,<default lifetime>" option. We can pass "ra-param=*,0,0" (here, RA_interval=0 means default) to disable default gateway in RA. This patchset adds <network ipv6noDefRoute="yes|no"> option to network xml and sets the above option to dnsmasq config if it is set to yes (default: no). Maxim Perevedentsev (2): dnsmasq: add option to disable IPv6 default gateway in RA docs: add ipv6noDefRoute to schema and html. docs/formatnetwork.html.in | 15 ++++++++++++++- docs/schemas/network.rng | 5 +++++ src/conf/network_conf.c | 17 +++++++++++++++++ src/conf/network_conf.h | 3 +++ src/network/bridge_driver.c | 22 ++++++++++++++++++++++ src/util/virdnsmasq.h | 6 ++++++ 6 files changed, 67 insertions(+), 1 deletion(-) -- 1.8.3.1

2 5

[libvirt] [PATCH 0/2] Add support for preallocated memory
by Jaroslav Safka 01 Jul '16

01 Jul '16

This change introduces support for preallocated shared file descriptor based memory backing. It allows vhost-user to be used without hugepages. This is achieved by introducing 3 new sub elements to the memoryBacking element: source, access & allocation which will configure qemu commandline during VM startup accordingly Jaroslav Safka (2): Add new elements source,access and allocation Add xml to argv for memorybacking access,source,.. docs/schemas/domaincommon.rng | 45 +++++++++++++++++ src/conf/domain_conf.c | 59 +++++++++++++++++++++- src/conf/domain_conf.h | 31 ++++++++++++ src/qemu/qemu_command.c | 56 ++++++++++++++++++++ src/qemu/qemu_command.h | 4 ++ .../qemuxml2argv-memorybacking-set.args | 26 ++++++++++ .../qemuxml2argv-memorybacking-set.xml | 32 ++++++++++++ .../qemuxml2argv-memorybacking-unset.args | 22 ++++++++ .../qemuxml2argv-memorybacking-unset.xml | 32 ++++++++++++ tests/qemuxml2argvtest.c | 3 ++ .../qemuxml2xmlout-memorybacking-set.xml | 40 +++++++++++++++ .../qemuxml2xmlout-memorybacking-unset.xml | 40 +++++++++++++++ tests/qemuxml2xmltest.c | 3 ++ 13 files changed, 392 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-set.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-set.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-unset.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-unset.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memorybacking-set.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memorybacking-unset.xml -- 2.1.0 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

5 7

[libvirt] [PATCH] A description error about libvirtd manpage
by Jingjing Shao 30 Jun '16

30 Jun '16

To fix the bug The description of --timeout should be updated in libvirtd manpage https://bugzilla.redhat.com/show_bug.cgi?id=1325066 According to the description, delete the part: "Be aware that resources such as autostart networks will result in never reaching the timeout, even when there are no client connections." --- daemon/libvirtd.pod | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/daemon/libvirtd.pod b/daemon/libvirtd.pod index 3b819a2..5adf8a2 100644 --- a/daemon/libvirtd.pod +++ b/daemon/libvirtd.pod @@ -57,9 +57,7 @@ Use this name for the PID file, overriding the default value. =item B<-t, --timeout> I<SECONDS> Exit after timeout period (in seconds) elapse with no client connections -or registered resources. Be aware that resources such as autostart -networks will result in never reaching the timeout, even when there are -no client connections. +or registered resources. =item B<-v, --verbose> -- 1.8.3.1

2 1

[libvirt] [PATCH] conf: Don't free the constructed string in virDomainGetBlkioParametersAssignFromDef
by Peter Krempa 30 Jun '16

30 Jun '16

virTypedParameterAssign steals the string rather than copying it into the typed parameter and thus freeing it leads to a crash when attempting to serialize the results. This was introduced in commit 9f50f6e2 and later made an universal helper in 32e6339c. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1351473 --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ef266af..5e2a467 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -24944,7 +24944,7 @@ virDomainGetBlkioParametersAssignFromDef(virDomainDefPtr def, if (virTypedParameterAssign(&(params[(*nparams)++]), name, \ VIR_TYPED_PARAM_STRING, data) < 0) \ goto error; \ - VIR_FREE(data); \ + data = NULL; \ } /* blkiotune.device_weight */ -- 2.9.0

2 1

[libvirt] [PATCH v2] conf: def: Avoid unnecessary allocation of 'perf' events definition
by Peter Krempa 30 Jun '16

30 Jun '16

Some code paths already assume that it is allocated since it was always allocated by virDomainPerfDefParseXML. Make it member of virDomainDef directly so that we don't have to allocate it all the time. This fixes crash when attempting to connect to an existing process via virDomainQemuAttach since we would not allocate it in that code path. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1350688 --- src/conf/domain_conf.c | 12 ++---------- src/conf/domain_conf.h | 2 +- src/qemu/qemu_driver.c | 6 +++--- src/qemu/qemu_process.c | 8 ++++---- 4 files changed, 10 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ef266af..7d40f26 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2671,8 +2671,6 @@ void virDomainDefFree(virDomainDefPtr def) VIR_FREE(def->keywrap); - VIR_FREE(def->perf); - if (def->namespaceData && def->ns.free) (def->ns.free)(def->namespaceData); @@ -13136,19 +13134,14 @@ virDomainPerfDefParseXML(virDomainDefPtr def, if ((n = virXPathNodeSet("./perf/event", ctxt, &nodes)) < 0) return n; - if (VIR_ALLOC(def->perf) < 0) - goto cleanup; - for (i = 0; i < n; i++) { - if (virDomainPerfEventDefParseXML(def->perf, nodes[i]) < 0) + if (virDomainPerfEventDefParseXML(&def->perf, nodes[i]) < 0) goto cleanup; } ret = 0; cleanup: - if (ret < 0) - VIR_FREE(def->perf); VIR_FREE(nodes); return ret; } @@ -23388,8 +23381,7 @@ virDomainDefFormatInternal(virDomainDefPtr def, virBufferAddLit(buf, "</pm>\n"); } - if (def->perf) - virDomainPerfDefFormat(buf, def->perf); + virDomainPerfDefFormat(buf, &def->perf); virBufferAddLit(buf, "<devices>\n"); virBufferAdjustIndent(buf, 2); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 7c5cbd9..e1990dc 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2140,7 +2140,7 @@ struct _virDomainDef { virDomainPowerManagement pm; - virDomainPerfDefPtr perf; + virDomainPerfDef perf; virDomainOSDef os; char *emulator; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 61d184b..0507be8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9642,7 +9642,7 @@ qemuDomainSetPerfEvents(virDomainPtr dom, if (enabled && virPerfEventEnable(priv->perf, type, vm->pid) < 0) goto endjob; - def->perf->events[type] = enabled ? + def->perf.events[type] = enabled ? VIR_TRISTATE_BOOL_YES : VIR_TRISTATE_BOOL_NO; } @@ -9656,7 +9656,7 @@ qemuDomainSetPerfEvents(virDomainPtr dom, enabled = param->value.b; type = virPerfEventTypeFromString(param->field); - persistentDef->perf->events[type] = enabled ? + persistentDef->perf.events[type] = enabled ? VIR_TRISTATE_BOOL_YES : VIR_TRISTATE_BOOL_NO; } @@ -9716,7 +9716,7 @@ qemuDomainGetPerfEvents(virDomainPtr dom, bool perf_enabled; if (flags & VIR_DOMAIN_AFFECT_CONFIG) - perf_enabled = def->perf->events[i] == VIR_TRISTATE_BOOL_YES; + perf_enabled = def->perf.events[i] == VIR_TRISTATE_BOOL_YES; else perf_enabled = virPerfEventIsEnabled(priv->perf, i); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 63da600..a175a4d 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -3139,12 +3139,12 @@ qemuDomainPerfRestart(virDomainObjPtr vm) return -1; for (i = 0; i < VIR_PERF_EVENT_LAST; i++) { - if (def->perf->events[i] && - def->perf->events[i] == VIR_TRISTATE_BOOL_YES) { + if (def->perf.events[i] && + def->perf.events[i] == VIR_TRISTATE_BOOL_YES) { /* Failure to re-enable the perf event should not be fatal */ if (virPerfEventEnable(priv->perf, i, vm->pid) < 0) - def->perf->events[i] = VIR_TRISTATE_BOOL_NO; + def->perf.events[i] = VIR_TRISTATE_BOOL_NO; } } @@ -5217,7 +5217,7 @@ qemuProcessLaunch(virConnectPtr conn, goto cleanup; for (i = 0; i < VIR_PERF_EVENT_LAST; i++) { - if (vm->def->perf->events[i] == VIR_TRISTATE_BOOL_YES && + if (vm->def->perf.events[i] == VIR_TRISTATE_BOOL_YES && virPerfEventEnable(priv->perf, i, vm->pid) < 0) goto cleanup; } -- 2.9.0

2 1