- Devel - libvirt List Archives

[libvirt] [PATCH] libxl: allow libxl to calculate shadow mem requirements
by Jim Fehlig 04 Aug '16

04 Aug '16

Long, long ago before libxl_get_required_shadow_memory() was made publicly available, its code was copied to the libxl driver for calculating shadow memory requirements of HVM domains. Long ago, libxl_get_required_shadow_memory() was exported in libxl_utils.h and included in xen-devel packages everywhere. Remove the copied code, which has become stale, and let libxl provode a proper shadow memory value. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- I ensured libxl_get_required_shadow_memory() was available as far back as Xen 4.4, which is the minimum version supported by the libxl driver. src/libxl/libxl_conf.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 1344604..5202ca1 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -493,15 +493,10 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, } } - /* - * The following comment and calculation were taken directly from - * libxenlight's internal function libxl_get_required_shadow_memory(): - * - * 256 pages (1MB) per vcpu, plus 1 page per MiB of RAM for the P2M map, - * plus 1 page per MiB of RAM to shadow the resident processes. - */ - b_info->shadow_memkb = 4 * (256 * libxl_bitmap_count_set(&b_info->avail_vcpus) + - 2 * (b_info->max_memkb / 1024)); + /* Allow libxl to calculate shadow memory requirements */ + b_info->shadow_memkb = + libxl_get_required_shadow_memory(b_info->max_memkb, + b_info->max_vcpus); } else { /* * For compatibility with the legacy xen toolstack, default to pygrub -- 2.1.4

2 2

[libvirt] [gconfig v2 0/4] Add support for changing listen address
by Visarion Alexandru 04 Aug '16

04 Aug '16

From: Visarion Alexandru <viorel.visarion(a)gmail.com> libvirt-domain-graphics-listen defines an abstract class used to represent one listen node. libvirt-domain-graphics-liste-address defines a class that represents a listen node of type 'address', for the graphics device. We have to first remove the 'listen' attribute of the graphics device before adding child 'listen' nodes, to avoid inconsistencies check. Visarion Alexandru (4): Introduce libvirt-domain-graphics-listen Introduce libvirt-gconfig-domain-graphics-listen-address config: Add vnc host setter config: Add spice host setter libvirt-gconfig/Makefile.am | 4 ++ ...ibvirt-gconfig-domain-graphics-listen-address.c | 79 ++++++++++++++++++++++ ...ibvirt-gconfig-domain-graphics-listen-address.h | 67 ++++++++++++++++++ .../libvirt-gconfig-domain-graphics-listen.c | 48 +++++++++++++ .../libvirt-gconfig-domain-graphics-listen.h | 64 ++++++++++++++++++ .../libvirt-gconfig-domain-graphics-spice.c | 28 ++++++++ .../libvirt-gconfig-domain-graphics-spice.h | 3 + .../libvirt-gconfig-domain-graphics-vnc.c | 28 ++++++++ .../libvirt-gconfig-domain-graphics-vnc.h | 3 + libvirt-gconfig/libvirt-gconfig.h | 2 + libvirt-gconfig/libvirt-gconfig.sym | 6 ++ 11 files changed, 332 insertions(+) create mode 100644 libvirt-gconfig/libvirt-gconfig-domain-graphics-listen-address.c create mode 100644 libvirt-gconfig/libvirt-gconfig-domain-graphics-listen-address.h create mode 100644 libvirt-gconfig/libvirt-gconfig-domain-graphics-listen.c create mode 100644 libvirt-gconfig/libvirt-gconfig-domain-graphics-listen.h -- 2.7.4

2 8

[libvirt] [PATCH] libxl: add serial list support
by Bob Liu 03 Aug '16

03 Aug '16

Add support for multi serial devices, after this patch virsh can be used to connect different serial devices of running domains. E.g. vish # console <xxx> --devname serial<xxx> Signed-off-by: Bob Liu <bob.liu(a)oracle.com> --- src/libxl/libxl_conf.c | 25 ++++++++++++++++++------- src/libxl/libxl_domain.c | 23 +++++++++++++++++++++++ src/libxl/libxl_driver.c | 17 +++++++++-------- 3 files changed, 50 insertions(+), 15 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 146e08a..685a5ad 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -431,14 +431,25 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, } if (def->nserials) { - if (def->nserials > 1) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - "%s", - _("Only one serial device is supported by libxl")); - return -1; + if (def->nserials == 1) { + if (libxlMakeChrdevStr(def->serials[0], &b_info->u.hvm.serial) < + 0) + return -1; + } else { + if (VIR_ALLOC_N(b_info->u.hvm.serial_list, def->nserials + 1) < + 0) + return -1; + + for (i = 0; i < def->nserials; i++) { + if (libxlMakeChrdevStr(def->serials[i], + &b_info->u.hvm.serial_list[i]) < 0) + { + libxl_string_list_dispose(&b_info->u.hvm.serial_list); + return -1; + } + } + b_info->u.hvm.serial_list[i] = NULL; } - if (libxlMakeChrdevStr(def->serials[0], &b_info->u.hvm.serial) < 0) - return -1; } if (def->nparallels) { diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 0e26b91..82fe9e8 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -989,6 +989,29 @@ libxlConsoleCallback(libxl_ctx *ctx, libxl_event *ev, void *for_callback) VIR_FREE(console); } } + for (i = 0; i < vm->def->nserials; i++) { + virDomainChrDefPtr chr = vm->def->serials[i]; + char *console = NULL; + int ret; + + if (chr->source.type == VIR_DOMAIN_CHR_TYPE_PTY) { + ignore_value(virAsprintf(&chr->info.alias, "serial%zd", i)); + if (chr->source.data.file.path) + continue; + ret = libxl_console_get_tty(ctx, ev->domid, + chr->target.port, + LIBXL_CONSOLE_TYPE_SERIAL, + &console); + if (!ret) { + VIR_FREE(chr->source.data.file.path); + if (console && console[0] != '\0') { + ignore_value(VIR_STRDUP(chr->source.data.file.path, + console)); + } + } + VIR_FREE(console); + } + } virObjectUnlock(vm); libxl_event_free(ctx, ev); } diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index f153f69..a34eb02 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -4450,13 +4450,6 @@ libxlDomainOpenConsole(virDomainPtr dom, virCheckFlags(VIR_DOMAIN_CONSOLE_FORCE, -1); - if (dev_name) { - /* XXX support device aliases in future */ - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Named device aliases are not supported")); - goto cleanup; - } - if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; @@ -4472,8 +4465,16 @@ libxlDomainOpenConsole(virDomainPtr dom, } priv = vm->privateData; + if (dev_name) { + size_t i; - if (vm->def->nconsoles) { + for (i = 0; !chr && i < vm->def->nserials; i++) { + if (STREQ(dev_name, vm->def->serials[i]->info.alias)) { + chr = vm->def->serials[i]; + break; + } + } + } else if (vm->def->nconsoles) { chr = vm->def->consoles[0]; if (chr->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL) chr = vm->def->serials[0]; -- 2.6.5

2 1

[libvirt] [PATCH 0/2] Add ability to set specific IOThread scheduler quota/period
by John Ferlan 03 Aug '16

03 Aug '16

https://bugzilla.redhat.com/show_bug.cgi?id=1356937 John Ferlan (2): conf: Add IOThread quota and period scheduler/cputune defs qemu: Add support to get/set IOThread period and quota cgroup values docs/formatdomain.html.in | 25 ++++ docs/schemas/domaincommon.rng | 10 ++ include/libvirt/libvirt-domain.h | 32 ++++++ src/conf/domain_conf.c | 42 +++++++ src/conf/domain_conf.h | 2 + src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 127 ++++++++++++++++++++- src/qemu/qemu_process.c | 4 +- tests/qemuxml2argvdata/qemuxml2argv-cputune.xml | 2 + .../qemuxml2xmloutdata/qemuxml2xmlout-cputune.xml | 2 + tools/virsh.pod | 9 +- 11 files changed, 249 insertions(+), 9 deletions(-) -- 2.5.5

2 4

[libvirt] [PATCH python 0/2] Bindings for node device lifecycle events
by Jovanka Gulicoska 03 Aug '16

03 Aug '16

Python buindings and tests for node device lifecycle events API. Jovanka Gulicoska (2): Python binding for node poll lifecycle events API event-test: Add node device lifecycle event tests examples/event-test.py | 16 +++++ generator.py | 2 + libvirt-override-virConnect.py | 45 ++++++++++++ libvirt-override.c | 153 +++++++++++++++++++++++++++++++++++++++++ sanitytest.py | 3 + 5 files changed, 219 insertions(+) -- 2.7.4

3 5

[libvirt] [PATCH python] Post-release version bump to 2.2.0
by Cole Robinson 03 Aug '16

03 Aug '16

--- Pushed as trivial setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 647529b..240e796 100755 --- a/setup.py +++ b/setup.py @@ -307,7 +307,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '2.1.0', + version = '2.2.0', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.7.4

1 0

[libvirt] [PATCH] remote: Fix indentation of the remote protocol structs check file
by Peter Krempa 02 Aug '16

02 Aug '16

--- Pushed under the build-breaker rule. src/remote_protocol-structs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 0e66fc5..24401d1 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -2572,20 +2572,20 @@ struct remote_storage_pool_event_refresh_msg { remote_nonnull_storage_pool pool; }; struct remote_connect_node_device_event_register_any_args { - int eventID; - remote_node_device dev; + int eventID; + remote_node_device dev; }; struct remote_connect_node_device_event_register_any_ret { - int callbackID; + int callbackID; }; struct remote_connect_node_device_event_deregister_any_args { - int callbackID; + int callbackID; }; struct remote_node_device_event_lifecycle_msg { - int callbackID; - remote_nonnull_node_device dev; - int event; - int detail; + int callbackID; + remote_nonnull_node_device dev; + int event; + int detail; }; struct remote_domain_fsfreeze_args { remote_nonnull_domain dom; -- 2.9.2

1 0

[libvirt] [PATCH] tests: Make schema test fail on XML schema errors
by Peter Krempa 02 Aug '16

02 Aug '16

Failure to parse the schema file would not trigger a test suite failure. In addition to making the test fail it's necessary to split up the parsing of the schema file into a separate test. This is necessary as the XML validator uses libvirt errors to report problems parsing of the actual schema RNG needs to be split out into a separate function and called via virTestRun which has the infrastructure to report them. --- tests/virschematest.c | 64 ++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 46 insertions(+), 18 deletions(-) diff --git a/tests/virschematest.c b/tests/virschematest.c index a1901e7..dbd9f3b 100644 --- a/tests/virschematest.c +++ b/tests/virschematest.c @@ -114,24 +114,17 @@ testSchemaDir(const char *schema, static int -testSchemaDirs(const char *schema, ...) +testSchemaDirs(const char *schema, virXMLValidatorPtr validator, ...) { - virXMLValidatorPtr validator = NULL; va_list args; int ret = 0; - char *schema_path = NULL; char *dir_path = NULL; const char *dir; - va_start(args, schema); - - if (virAsprintf(&schema_path, "%s/docs/schemas/%s", abs_topsrcdir, schema) < 0) - goto cleanup; - - if (!(validator = virXMLValidatorInit(schema_path))) - goto cleanup; + va_start(args, validator); while ((dir = va_arg(args, char *))) { + printf("\nDERP: %s\n", dir); if (virAsprintf(&dir_path, "%s/%s", abs_srcdir, dir) < 0) { ret = -1; goto cleanup; @@ -142,24 +135,59 @@ testSchemaDirs(const char *schema, ...) } cleanup: - virXMLValidatorFree(validator); - VIR_FREE(schema_path); VIR_FREE(dir_path); va_end(args); return ret; } +struct testSchemaFileData { + virXMLValidatorPtr validator; + const char *schema; +}; + +static int +testSchemaGrammar(const void *opaque) +{ + struct testSchemaFileData *data = (struct testSchemaFileData *) opaque; + char *schema_path; + int ret = -1; + + if (virAsprintf(&schema_path, "%s/docs/schemas/%s", + abs_topsrcdir, data->schema) < 0) + return -1; + + if (!(data->validator = virXMLValidatorInit(schema_path))) + goto cleanup; + + ret = 0; + + cleanup: + VIR_FREE(schema_path); + return ret; +} + + static int mymain(void) { int ret = 0; - -#define DO_TEST(schema, ...) \ - do { \ - if (testSchemaDirs(schema, __VA_ARGS__, NULL) < 0) \ - ret = -1; \ - } while (0) \ + struct testSchemaFileData data; + +#define DO_TEST(sch, ...) \ + do { \ + data.schema = sch; \ + if (virTestRun("test schema grammar file: " sch, \ + testSchemaGrammar, &data) == 0) { \ + if (testSchemaDirs(sch, data.validator, __VA_ARGS__, NULL) < 0) \ + ret = -1; \ + \ + virXMLValidatorFree(data.validator); \ + data.validator = NULL; \ + } else { \ + ret = -1; \ + } \ + } while (0) DO_TEST("capability.rng", "capabilityschemadata", "xencapsdata"); DO_TEST("domain.rng", "domainschemadata", "qemuargv2xmldata", -- 2.9.2

2 1

[libvirt] [PATCH 0/3] virsh: Clean up and fix qemu-monitor-command
by Peter Krempa 02 Aug '16

02 Aug '16

Mostly to allow piping of the prettified output into a file without having to fix it up later to stop syntax-check whining. Peter Krempa (3): virsh: qemu-monitor-command: Use macro for exclusive options virsh: qemu-monitor-command: Don't print extra newline with --pretty virsh: qemu-monitor-command: Simplify control flow tools/virsh-domain.c | 48 ++++++++++++++++++++---------------------------- 1 file changed, 20 insertions(+), 28 deletions(-) -- 2.9.2

2 10

[libvirt] [PATCH v2 0/9] Various hotplug cleanups
by John Ferlan 02 Aug '16

02 Aug '16

v1: http://www.redhat.com/archives/libvir-list/2016-June/msg02207.html Changes since v1... - Use the bz noted by Cole from the v1 series - Merged in recent hotplug cleanup changes - Patches 6 - 9 are new Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1336225 and probably: https://bugzilla.redhat.com/show_bug.cgi?id=1289391 Patches 1-5 address the USB hotplug cleanup Patch 6 addresses the SCSI hotplug cleanup Patch 7-9 address some SCSI host device cleanups found while looking at the other cleanups... John Ferlan (9): qemu: Reorder qemuDomainAttachUSBMassStorageDevice failure path qemu: Move drive alias processing to qemu_alias qemu: Use qemuAssignDeviceDiskDriveAlias qemu: Make QEMU_DRIVE_HOST_PREFIX more private qemu: Add attempt to call qemuMonitorDriveDel for USB failure path qemu: Add attempt to call qemuMonitorDriveDel for AttachSCSI failure path qemu: Introduce qemuAssignSCSIHostDeviceDriveAlias qemu: Use qemuAssignSCSIHostDeviceDriveAlias qemu: Use the hostdev alias in qemuDomainAttachHostSCSIDevice error path src/qemu/qemu_alias.c | 52 +++++++++++++++++++++++++ src/qemu/qemu_alias.h | 6 +++ src/qemu/qemu_command.c | 35 ++++++++--------- src/qemu/qemu_command.h | 1 - src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_hotplug.c | 92 +++++++++++++++++++++++++++++--------------- src/qemu/qemu_migration.c | 11 ++---- src/qemu/qemu_monitor_json.c | 10 ++--- src/qemu/qemu_monitor_text.c | 18 +++++---- src/qemu/qemu_process.c | 3 +- 11 files changed, 156 insertions(+), 78 deletions(-) -- 2.5.5

2 24