- Devel - libvirt List Archives

[libvirt] [PATCH RFC 0/8] qemu: allow disabling certain virtio revisions
by Ján Tomko 05 Aug '16

05 Aug '16

For https://bugzilla.redhat.com/show_bug.cgi?id=1227354 some users might want to adjust the QEMU defaults and disable either virtio 0.9 or virtio 1.0 (spelled out as disable-legacy and disable-modern on qemu command line). This series uses a separate <virtio revision="x"> element right under the relevant device element for consistency, even though it might fit better in different subelemets for some of them. Ján Tomko (8): Fix indentation Add virtio revision attribute to memballoon Add virtio revision attribute to disks Add virtio revision attribute to controllers Add virtio revision attribute to filesystems Add virtio revision attribute to intefaces Add virtio revision to rng devices qemu: format options for enforcing virtio revisions docs/formatdomain.html.in | 51 ++++++++++ docs/schemas/domaincommon.rng | 29 ++++++ src/conf/domain_conf.c | 72 +++++++++++++- src/conf/domain_conf.h | 14 +++ src/qemu/qemu_command.c | 31 ++++++ .../qemuxml2argv-virtio-revision.args | 58 +++++++++++ .../qemuxml2argv-virtio-revision.xml | 107 +++++++++++++++++++++ tests/qemuxml2argvtest.c | 10 ++ .../qemuxml2xmlout-virtio-revision.xml | 107 +++++++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 10 files changed, 480 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-revision.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-revision.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-virtio-revision.xml -- 2.7.3

4 14

[libvirt] [PATCH] rpm: set TLS priority to @LIBVIRT, SYSTEM on Fedora >= 25
by Daniel P. Berrange 05 Aug '16

05 Aug '16

With newest gnutls available in Fedora 25/rawhide, it is possible to have TLS priority fallbacks, so we can finally use --tls-priority=@LIBVIRT,SYSTEM Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- libvirt.spec.in | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index d3986bb..a389e88 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -206,10 +206,14 @@ %define enable_werror --disable-werror %endif -%if 0%{?fedora} >= 21 - %define tls_priority "@SYSTEM" +%if 0%{?fedora} >= 25 + %define tls_priority "@LIBVIRT,SYSTEM" %else - %define tls_priority "NORMAL" + %if 0%{?fedora} >= 21 + %define tls_priority "@SYSTEM" + %else + %define tls_priority "NORMAL" + %endif %endif -- 2.7.4

2 1

[libvirt] [PATCH v2 0/3] New vCPU hotplug prequel
by Peter Krempa 04 Aug '16

04 Aug '16

Few of the patches needed more significant changes. Peter Krempa (3): internal: Introduce macro for stealing pointers qemu: monitor: Return structures from qemuMonitorGetCPUInfo qemu: monitor: Return struct from qemuMonitor(Text|Json)QueryCPUs src/internal.h | 12 +++++++ src/qemu/qemu_domain.c | 25 ++++++-------- src/qemu/qemu_monitor.c | 70 ++++++++++++++++++++++++++++++++++++---- src/qemu/qemu_monitor.h | 19 ++++++++++- src/qemu/qemu_monitor_json.c | 77 +++++++++++++++++++++++--------------------- src/qemu/qemu_monitor_json.h | 3 +- src/qemu/qemu_monitor_text.c | 39 +++++++++++----------- src/qemu/qemu_monitor_text.h | 3 +- tests/qemumonitorjsontest.c | 39 +++++++++++++++------- 9 files changed, 194 insertions(+), 93 deletions(-) -- 2.9.2

2 4

[libvirt] [PATCH 0/6] Couple of small fixes
by Michal Privoznik 04 Aug '16

04 Aug '16

Some of these were found by coverity, some by me going through code. Michal Privoznik (6): virqemu: Reflect return type of virJSONValueArraySize() qemuMigrationCookieStatisticsXMLParse: Check for retvals of virXPath*() securityselinuxlabeltest: Prefer virGetLastErrorMessage() over virGetLastError virshConnect: Don't leak polkit agent libxlDoMigrateReceive: Drop useless check for !vm virObjectEventNew: Use virObjectUnref() to free virObjectEvent src/conf/object_event.c | 10 ++--- src/libxl/libxl_migration.c | 2 +- src/qemu/qemu_migration.c | 80 +++++++++++++++++++--------------------- src/util/virqemu.c | 2 +- tests/securityselinuxlabeltest.c | 3 +- tools/virsh.c | 2 +- 6 files changed, 45 insertions(+), 54 deletions(-) -- 2.8.4

2 13

[libvirt] [PATCH libvirt-sanbox] image: ignore OSError on listdir()
by marcandre.lureau＠redhat.com 04 Aug '16

04 Aug '16

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> If the directory to list is missing, don't raise an exception but return empty list instead. This fixes for example running "virt-sandbox-image list" without a ~/.local/share/libvirt/templates/virt-builder. Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- libvirt-sandbox/image/sources/docker.py | 18 +++++++++++++++--- libvirt-sandbox/image/sources/virtbuilder.py | 6 +++++- 2 files changed, 20 insertions(+), 4 deletions(-) mode change 100644 => 100755 libvirt-sandbox/image/sources/docker.py mode change 100644 => 100755 libvirt-sandbox/image/sources/virtbuilder.py diff --git a/libvirt-sandbox/image/sources/docker.py b/libvirt-sandbox/image/sources/docker.py old mode 100644 new mode 100755 index f6724af..43e9c32 --- a/libvirt-sandbox/image/sources/docker.py +++ b/libvirt-sandbox/image/sources/docker.py @@ -358,7 +358,11 @@ class DockerSource(base.Source): def list_templates(self, templatedir): indexes = [] - imagedirs = os.listdir(templatedir) + try: + imagedirs = os.listdir(templatedir) + except OSError: + return [] + for imagetagid in imagedirs: indexfile = templatedir + "/" + imagetagid + "/index.json" if os.path.exists(indexfile): @@ -552,7 +556,11 @@ class DockerSource(base.Source): def _get_image_list(self, image, templatedir): imageparent = {} imagenames = {} - imagedirs = os.listdir(templatedir) + imagedirs = [] + try: + imagedirs = os.listdir(templatedir) + except OSError: + pass for imagetagid in imagedirs: indexfile = templatedir + "/" + imagetagid + "/index.json" if os.path.exists(indexfile): @@ -585,7 +593,11 @@ class DockerSource(base.Source): imageusage = {} imageparent = {} imagenames = {} - imagedirs = os.listdir(templatedir) + imagedirs = [] + try: + imagedirs = os.listdir(templatedir) + except OSError: + pass for imagetagid in imagedirs: indexfile = templatedir + "/" + imagetagid + "/index.json" if os.path.exists(indexfile): diff --git a/libvirt-sandbox/image/sources/virtbuilder.py b/libvirt-sandbox/image/sources/virtbuilder.py old mode 100644 new mode 100755 index fefe0dd..6bd9695 --- a/libvirt-sandbox/image/sources/virtbuilder.py +++ b/libvirt-sandbox/image/sources/virtbuilder.py @@ -68,7 +68,11 @@ class VirtBuilderSource(base.Source): def list_templates(self, templatedir): files = [] - imagefiles = os.listdir(templatedir) + try: + imagefiles = os.listdir(templatedir) + except OSError: + return [] + for filename in imagefiles: if not filename.endswith(".qcow2"): continue -- 2.9.0

2 1

[libvirt] [PATCH] storage: Fix a NULL ptr dereference in virStorageBackendCreateQemuImg
by Erik Skultety 04 Aug '16

04 Aug '16

There was a missing check for vol->target.encryption being NULL at one particular place (modified by commit a48c71411) which caused a crash when user attempted to create a raw volume using a non-raw file volume as source. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1363636 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/storage/storage_backend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index 1f33181..d4334dc 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -1459,6 +1459,7 @@ virStorageBackendCreateQemuImg(virConnectPtr conn, goto cleanup; if (vol->target.format == VIR_STORAGE_FILE_RAW && + vol->target.encryption && vol->target.encryption->format == VIR_STORAGE_ENCRYPTION_FORMAT_LUKS) { if (!(secretPath = virStorageBackendCreateQemuImgSecretPath(conn, pool, vol))) -- 2.5.5

3 3

[libvirt] [PATCH 00/10] New vCPU hotplug prequel
by Peter Krempa 04 Aug '16

04 Aug '16

A few patches that are standalone enough which originated from my work in progress on new way to do vcpu hotplug. Peter Krempa (10): qemu: monitor: Add monitor API for device_add supporting JSON objects internal: Introduce macro for stealing pointers qemu: monitor: Add do-while block to QEMU_CHECK_MONITOR_FULL qemu: Improve error message in virDomainGetVcpus qemu: domain: Rename qemuDomainDetectVcpuPids to qemuDomainRefreshVcpuInfo qemu: monitor: Rename qemuMonitor(JSON|Text)GetCPUInfo qemu: domain: Improve vCPU data checking in qemuDomainDetectVcpuPids qemu: domain: Simplify return values of qemuDomainRefreshVcpuInfo qemu: monitor: Return structures from qemuMonitorGetCPUInfo qemu: monitor: Return struct from qemuMonitor(Text|Json)QueryCPUs src/internal.h | 12 +++++ src/qemu/qemu_domain.c | 95 ++++++++++++++++++++++++------------- src/qemu/qemu_domain.h | 6 ++- src/qemu/qemu_driver.c | 25 +++++----- src/qemu/qemu_monitor.c | 110 ++++++++++++++++++++++++++++++++++++------- src/qemu/qemu_monitor.h | 21 ++++++++- src/qemu/qemu_monitor_json.c | 103 ++++++++++++++++++++++------------------ src/qemu/qemu_monitor_json.h | 6 ++- src/qemu/qemu_monitor_text.c | 40 ++++++++-------- src/qemu/qemu_monitor_text.h | 4 +- src/qemu/qemu_process.c | 12 +++-- tests/qemumonitorjsontest.c | 35 ++++++++++---- 12 files changed, 316 insertions(+), 153 deletions(-) -- 2.9.2

5 29

[libvirt] [PATCH v2 0/8] Introducing node device lifecycle event APIs
by Jovanka Gulicoska 04 Aug '16

04 Aug '16

Introducing implementation of node device event APIs. Code changes follow network/storage pool event APIs. Implemented functions: virNodeDeviceEventRegisterAny(), virNodeDeviceEventDeregisterAny(), virNodeDeviceLifeCycleEventNew(), introduced CREATED and DELETED. There are also test as well as unittests for the new functions and signals. This is part of a GSOC project: Asynchronous lifecycle events for storage objects Jovanka Gulicoska (8): Introduce node device lifecycle event APIs conf: add node_device_event handling test: implement node device lifecycle event APIs remote: implement node device lifecycle event APIs node_device: implement node device lifecycle event APIs node_device: Implement event queue in udev event-test: support node device lifecycle event APIs virsh: Introduce nodedev-event command daemon/libvirtd.h | 2 + daemon/remote.c | 206 ++++++++++++++++++++++++++++++ examples/object-events/event-test.c | 68 ++++++++++ include/libvirt/libvirt-nodedev.h | 90 ++++++++++++++ po/POTFILES.in | 1 + src/Makefile.am | 5 + src/conf/node_device_conf.h | 4 + src/conf/node_device_event.c | 234 +++++++++++++++++++++++++++++++++++ src/conf/node_device_event.h | 59 +++++++++ src/datatypes.h | 13 ++ src/driver-nodedev.h | 14 +++ src/libvirt-nodedev.c | 127 +++++++++++++++++++ src/libvirt_private.syms | 5 + src/libvirt_public.syms | 6 + src/node_device/node_device_driver.c | 42 +++++++ src/node_device/node_device_driver.h | 10 ++ src/node_device/node_device_udev.c | 46 +++++-- src/remote/remote_driver.c | 139 +++++++++++++++++++++ src/remote/remote_protocol.x | 43 ++++++- src/remote_protocol-structs | 19 +++ src/test/test_driver.c | 48 +++++++ tests/objecteventtest.c | 72 +++++++++++ tools/virsh-nodedev.c | 182 +++++++++++++++++++++++++++ tools/virsh.pod | 18 +++ 24 files changed, 1443 insertions(+), 10 deletions(-) create mode 100644 src/conf/node_device_event.c create mode 100644 src/conf/node_device_event.h -- 2.7.4

3 16

[libvirt] [PATCH v4 0/4] perf: add more perf events support
by Qiaowei Ren 04 Aug '16

04 Aug '16

With current perf framework, this patchset refactor virPerfEventEnable() for general purpose and add more perf events support based on this change, including cache misses, cache references, cpu cycles, instrctions, etc.. Changes since v3: * separate the patch into 4 patches. * update virsh.pod for new perf events. * introduce a static attr table that would be able to convert the VIR_PERF_EVENT_* into their respective "attr.type" and "attr.config". Qiaowei Ren (4): perf: rename qemuDomainGetStatsPerfRdt() perf: introduce a static attr table and refactor virPerfEventEnable() for general purpose perf: add more perf events support perf: add description for new events in virsh.pod docs/formatdomain.html.in | 24 ++++ docs/schemas/domaincommon.rng | 4 + include/libvirt/libvirt-domain.h | 39 ++++++ src/libvirt-domain.c | 8 ++ src/qemu/qemu_driver.c | 23 ++-- src/util/virperf.c | 176 +++++++++++++++++----------- src/util/virperf.h | 11 ++ tests/genericxml2xmlindata/generic-perf.xml | 4 + tools/virsh.pod | 4 + 9 files changed, 211 insertions(+), 82 deletions(-) -- 1.9.1

3 9

[libvirt] Examples of QEMU machine-type-specific code in libvirt?
by Eduardo Habkost 04 Aug '16

04 Aug '16

Hi, I am collecting some material for my KVM Forum talk, and I am interested in hearing from libvirt developers about instances where machine-type-specific information is needed by libvirt, and the info is not provided by QEMU. I found some instances where machine-type capabilities are hardcoded in libvirt itself (see below[1]), but I would like to know if you have other examples. They may be about things that are already done by libvirt today, or about things that you would like to do in the future. [1] Examples where machine-type names are hardcoded in libvirt: src/qemu/qemu_capabilities.c: STREQ(def->os.machine, "ppce500")) src/qemu/qemu_capabilities.c: STREQ(def->os.machine, "prep")) src/qemu/qemu_capabilities.c: STREQ(def->os.machine, "bamboo")) src/qemu/qemu_capabilities.c: if (STREQ(def->os.machine, "mpc8544ds")) src/qemu/qemu_capabilities.c: if (STREQ(machines[i]->name, "none")) src/qemu/qemu_capabilities.c: STREQ(def->os.machine, "isapc"); src/qemu/qemu_capabilities.c: (STRNEQ(machine, "pseries") && !STRPREFIX(machine, "pseries-"))) src/qemu/qemu_capabilities.c: (STRNEQ(machine, "pseries") && !STRPREFIX(machine, "pseries-"))) src/qemu/qemu_capabilities.c: if (STRNEQ(domCaps->machine, "virt") && src/qemu/qemu_capabilities.c: !STRPREFIX(domCaps->machine, "virt-")) src/qemu/qemu_command.c: if (STRPREFIX(def->os.machine, "s390-virtio") && src/qemu/qemu_domain.c: if (STREQ(def->os.machine, "isapc")) { src/qemu/qemu_domain.c: if (STREQ(def->os.machine, "versatilepb")) src/qemu/qemu_domain.c: return (STRPREFIX(def->os.machine, "pc-q35") || src/qemu/qemu_domain.c: STREQ(def->os.machine, "q35")); src/qemu/qemu_domain.c: return (STREQ(def->os.machine, "pc") || src/qemu/qemu_domain.c: STRPREFIX(def->os.machine, "pc-0.") || src/qemu/qemu_domain.c: STRPREFIX(def->os.machine, "pc-1.") || src/qemu/qemu_domain.c: STRPREFIX(def->os.machine, "pc-i440") || src/qemu/qemu_domain.c: STRPREFIX(def->os.machine, "rhel")); src/qemu/qemu_domain.c: char *p = STRSKIP(def->os.machine, "pc-q35-"); src/qemu/qemu_domain.c: return STRPREFIX(def->os.machine, "s390-ccw"); src/qemu/qemu_domain.c: if (STRNEQ(def->os.machine, "virt") && src/qemu/qemu_domain.c: !STRPREFIX(def->os.machine, "virt-")) src/qemu/qemu_domain.c: if (STRNEQ(def->os.machine, "pseries") && src/qemu/qemu_domain.c: !STRPREFIX(def->os.machine, "pseries-")) src/qemu/qemu_domain.c: STREQ(def->os.machine, "malta") || src/qemu/qemu_domain.c: STREQ(def->os.machine, "sun4u") || src/qemu/qemu_domain.c: STREQ(def->os.machine, "g3beige"); src/qemu/qemu_domain_address.c: if (!(STRPREFIX(def->os.machine, "vexpress-") || src/qemu/qemu_domain_address.c: if (STREQ(def->os.machine, "versatilepb")) -- Eduardo

2 1