- Devel - libvirt List Archives

[libvirt] [libvirt-glib][PATCH 0/2] Support python3
by Michal Privoznik 01 Aug '16

01 Aug '16

/usr/bin/python defaults to python3 on my system. While trying to build libvirt-glib I've noticed some errors in configure (first patch), and some missing implementation (second patch). Michal Privoznik (2): configure: Detect python in compatible fashion python: Introduce support for python3 configure.ac | 6 +++--- python/libvirt-glib.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 3 deletions(-) -- 2.8.4

3 4

[libvirt] [PATCH 0/2] a couple of schema fixes
by Nikolay Shirokovskiy 01 Aug '16

01 Aug '16

Nikolay Shirokovskiy (2): schema: add missed alias element to memory device schema: fix resolved interfaces of network type docs/schemas/domaincommon.rng | 43 +++++++++++++++++++++++++++++++++--------- docs/schemas/network.rng | 5 +---- docs/schemas/networkcommon.rng | 6 ++++++ 3 files changed, 41 insertions(+), 13 deletions(-) -- 1.8.3.1

3 5

[libvirt] [PATCH v2] qemu: fix domain id after domainCreateWithFlags()
by Sascha Silbe 01 Aug '16

01 Aug '16

Ever since virDomainCreateWithFlags() was introduced by de3aadaa [drivers: add virDomainCreateWithFlags if virDomainCreate exists], the domain ID retrieved with virDomainGetID() was incorrect for several drivers after virDomainCreateWithFlags() was called. The API consumer had to look up the domain anew to retrieve the correct ID. For the ESX driver, this was fixed in 6139b274 [esx: Update ID after starting a domain]. For the openvz driver, it was fixed in fd81a097 [openvzDomainCreateWithFlags: set domain id to the correct value]. The test driver, the OpenNebula driver (removed in the meantime) and the vbox driver were already updating the domain ID correctly in domainCreate(). Copy over the ID in qemuDomainCreateWithFlags() to fix this for the qemu driver, too. Fixes: de3aadaa ("drivers: add virDomainCreateWithFlags if virDomainCreate exists") Reported-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> Signed-off-by: Sascha Silbe <silbe(a)linux.vnet.ibm.com> Tested-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> Reviewed-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> --- v1→v2: - Adjusted commit message. remoteDomainCreate() is actually fine since it explicitly queries the ID in a second RPC, only remoteDomainCreateWithFlags() is broken. Found and mentioned several other commits that fixed this for several of the other hypervisor drivers. src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1820f85..43242e0 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7100,6 +7100,7 @@ qemuDomainCreateWithFlags(virDomainPtr dom, unsigned int flags) QEMU_ASYNC_JOB_START) < 0) goto endjob; + dom->id = vm->def->id; ret = 0; endjob: -- 1.9.1

2 1

[libvirt] [PATCH] wireshark: Drop glib dependency
by Michal Privoznik 01 Aug '16

01 Aug '16

The only function that we currently use from glib is g_sprintf(). That's a very big gun for such small target. Not only that, but we've silently relied on wireshark dragging in the glib. Replace the g_sprintf() with plain sprinf() so that we can drop the glib dependency. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/wireshark/src/packet-libvirt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c index 569a0a1..9eadf4f 100644 --- a/tools/wireshark/src/packet-libvirt.c +++ b/tools/wireshark/src/packet-libvirt.c @@ -27,8 +27,6 @@ #include <wireshark/epan/proto.h> #include <wireshark/epan/packet.h> #include <wireshark/epan/dissectors/packet-tcp.h> -#include <glib.h> -#include <glib/gprintf.h> #ifdef HAVE_RPC_TYPES_H # include <rpc/types.h> #endif @@ -113,7 +111,7 @@ format_xdr_bytes(guint8 *bytes, guint32 length) for (i = 0; i < length; i++) { /* We know that buf has enough size to contain 2 * length + '\0' characters. */ - g_sprintf(buf, "%02x", bytes[i]); + sprintf(buf, "%02x", bytes[i]); buf += 2; } return buf - length*2; -- 2.8.4

2 1

[libvirt] [PATCH] tests: qemu: Don't leak security manager object
by Peter Krempa 01 Aug '16

01 Aug '16

==2064442== 200 (88 direct, 112 indirect) bytes in 1 blocks are definitely lost in loss record 54 of 73 ==2064442== at 0x4C2E0F0: calloc (vg_replace_malloc.c:711) ==2064442== by 0x18E75B80: virAllocVar (viralloc.c:560) ==2064442== by 0x18EC43B0: virObjectNew (virobject.c:193) ==2064442== by 0x18EC476E: virObjectLockableNew (virobject.c:219) ==2064442== by 0x1906BC73: virSecurityManagerNewDriver (security_manager.c:93) ==2064442== by 0x1906C076: virSecurityManagerNewStack (security_manager.c:115) ==2064442== by 0x43CC39: qemuTestDriverInit (testutilsqemu.c:548) ==2064442== by 0x4337ED: mymain (qemumonitorjsontest.c:2440) ==2064442== by 0x43BABE: virTestMain (testutils.c:982) ==2064442== by 0x43A490: main (qemumonitorjsontest.c:2558) --- tests/testutilsqemu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 1cf72a9..133de29 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -475,6 +475,7 @@ void qemuTestDriverFree(virQEMUDriver *driver) virObjectUnref(driver->xmlopt); virObjectUnref(driver->caps); virObjectUnref(driver->config); + virObjectUnref(driver->securityManager); } int qemuTestCapsCacheInsert(virQEMUCapsCachePtr cache, const char *binary, -- 2.9.2

2 1

[libvirt] [PATCH] spec: Require perl-XML-XPath during build
by Martin Kletzander 01 Aug '16

01 Aug '16

Some time ago I went through the trouble to make support for perl module requirements in our bootstrap. Even though we require it in the bootstrap, it was not listed as a build requirement in the specfile. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- libvirt.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index cc5d72209873..b182f4521453 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -269,6 +269,7 @@ BuildRequires: /usr/bin/pod2man %endif BuildRequires: git BuildRequires: perl +BuildRequires: perl-XML-XPath BuildRequires: python %if %{with_systemd} BuildRequires: systemd-units -- 2.9.2

3 4

[libvirt] [PATCH 0/2] qemu: caps: Sanitize storage of machine type related data
by Peter Krempa 01 Aug '16

01 Aug '16

Peter Krempa (2): qemu: capabilities: Drop unused function virQEMUCapsGetMachineTypes qemu: caps: Sanitize storage of machine type related data src/qemu/qemu_capabilities.c | 125 ++++++++++++++++--------------------------- src/qemu/qemu_capabilities.h | 2 - 2 files changed, 46 insertions(+), 81 deletions(-) -- 2.9.2

2 5

[libvirt] [PATCH] virsh: Report error when explicit connection fails
by Martin Kletzander 01 Aug '16

01 Aug '16

Commit 0c56d9431839 forgot to return false in the cmdConnect command after the clean up made there. Before (assuming you don't have uri alias for 'asdf'): $ virsh connect asdf error: failed to connect to the hypervisor $ echo $? 0 After (with the same assumption): $ virsh connect asdf error: failed to connect to the hypervisor error: no connection driver available for asdf $ echo $? 1 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1356461 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tools/virsh.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index f74698fa5f9a..d3fe06f19032 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -210,7 +210,7 @@ virshConnect(vshControl *ctl, const char *uri, bool readonly) * Reconnect after a disconnect from libvirtd * */ -static void +static int virshReconnect(vshControl *ctl, const char *name, bool readonly, bool force) { bool connected = false; @@ -237,6 +237,7 @@ virshReconnect(vshControl *ctl, const char *name, bool readonly, bool force) vshError(ctl, "%s", _("Failed to reconnect to the hypervisor")); else vshError(ctl, "%s", _("failed to connect to the hypervisor")); + return -1; } else { if (name) { VIR_FREE(ctl->connname); @@ -253,6 +254,7 @@ virshReconnect(vshControl *ctl, const char *name, bool readonly, bool force) priv->useGetInfo = false; priv->useSnapshotOld = false; priv->blockJobNoBytes = false; + return 0; } int virshStreamSink(virStreamPtr st ATTRIBUTE_UNUSED, @@ -301,7 +303,8 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptStringReq(ctl, cmd, "name", &name) < 0) return false; - virshReconnect(ctl, name, ro, true); + if (virshReconnect(ctl, name, ro, true) < 0) + return false; return true; } @@ -333,11 +336,13 @@ virshConnectionHandler(vshControl *ctl) { virshControlPtr priv = ctl->privData; - if (!priv->conn || disconnected) - virshReconnect(ctl, NULL, false, false); + if ((!priv->conn || disconnected) && + virshReconnect(ctl, NULL, false, false) < 0) + return NULL; if (virshConnectionUsability(ctl, priv->conn)) return priv->conn; + return NULL; } @@ -444,14 +449,13 @@ virshInit(vshControl *ctl) return false; if (ctl->connname) { - virshReconnect(ctl, NULL, false, false); /* Connecting to a named connection must succeed, but we delay * connecting to the default connection until we need it * (since the first command might be 'connect' which allows a * non-default connection, or might be 'help' which needs no * connection). */ - if (!priv->conn) { + if (virshReconnect(ctl, NULL, false, false) < 0) { vshReportError(ctl); return false; } -- 2.9.2

2 1

[libvirt] [PATCH] qemuDomainDetermineDiskChain: initialize ret as -1
by Chen Hanxiao 31 Jul '16

31 Jul '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/qemu/qemu_domain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 9b439df..35d4365 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4394,7 +4394,7 @@ qemuDomainDetermineDiskChain(virQEMUDriverPtr driver, bool report_broken) { virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); - int ret = 0; + int ret = -1; uid_t uid; gid_t gid; @@ -4416,6 +4416,8 @@ qemuDomainDetermineDiskChain(virQEMUDriverPtr driver, report_broken) < 0) ret = -1; + ret = 0; + cleanup: virObjectUnref(cfg); return ret; -- 1.8.3.1

2 1

[libvirt] [PATCH] qemu: Fix domain state after reset
by Martin Kletzander 30 Jul '16

30 Jul '16

When reset was called from a domain that crashed we didn't change the crashed state into a paused one which could confuse users. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1269575 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_driver.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index cda85f65fc98..866580705493 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2139,6 +2139,7 @@ qemuDomainReset(virDomainPtr dom, unsigned int flags) virDomainObjPtr vm; int ret = -1; qemuDomainObjPrivatePtr priv; + virDomainState state; virCheckFlags(0, -1); @@ -2165,6 +2166,10 @@ qemuDomainReset(virDomainPtr dom, unsigned int flags) priv->fakeReboot = false; + state = virDomainObjGetState(vm, NULL); + if (state == VIR_DOMAIN_CRASHED) + virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, VIR_DOMAIN_PAUSED_CRASHED); + endjob: qemuDomainObjEndJob(driver, vm); -- 2.9.0

2 1