- Devel - libvirt List Archives

[libvirt] [PATCH v2 0/5] Fix gluster pool lookup issues
by Peter Krempa 04 Apr '17

04 Apr '17

Peter Krempa (5): storage: util: Add boolean differentiating between gluster lookup type storage: util: Split out the gluster volume extraction code into new function test: Introduce testing of virStorageUtilGlusterExtractPoolSources storage: Fix XPath for looking up gluster volume name storage: gluster: Use volume name as "<name>" field in the XML src/storage/storage_backend_fs.c | 5 +- src/storage/storage_backend_gluster.c | 3 +- src/storage/storage_util.c | 110 ++++++++++++-------- src/storage/storage_util.h | 6 +- tests/Makefile.am | 15 ++- .../gluster-parse-basic-native.xml | 7 ++ .../gluster-parse-basic-netfs.xml | 7 ++ .../virstorageutildata/gluster-parse-basic-src.xml | 47 +++++++++ .../gluster-parse-multivol-native.xml | 17 +++ .../gluster-parse-multivol-netfs.xml | 17 +++ .../gluster-parse-multivol-src.xml | 32 ++++++ tests/virstorageutiltest.c | 114 +++++++++++++++++++++ 12 files changed, 330 insertions(+), 50 deletions(-) create mode 100644 tests/virstorageutildata/gluster-parse-basic-native.xml create mode 100644 tests/virstorageutildata/gluster-parse-basic-netfs.xml create mode 100644 tests/virstorageutildata/gluster-parse-basic-src.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-native.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-netfs.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-src.xml create mode 100644 tests/virstorageutiltest.c -- 2.12.1

2 14

[libvirt] [PATCH] news.rng: work around a bug in old libxml2
by Ján Tomko 04 Apr '17

04 Apr '17

Similar to commit c3c2cc6, use a literal newsline instead of \n inside the brackets. --- Pushed as a build fix. docs/schemas/news.rng | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/schemas/news.rng b/docs/schemas/news.rng index ec4313f..a633e22 100644 --- a/docs/schemas/news.rng +++ b/docs/schemas/news.rng @@ -45,7 +45,9 @@ <element name="change"> <element name="summary"> <data type="string"> - <param name="pattern">\n[^\n]+\n +</param> +  + <param name="pattern">\n[^ +]+\n +</param> </data> </element> <optional> -- 2.10.2

3 3

[libvirt] [PATCH 0/2] news: Further improvements
by Andrea Bolognani 04 Apr '17

04 Apr '17

This applies on top of Peter's series[1], which has already been ACKed. [1] https://www.redhat.com/archives/libvir-list/2017-March/msg01478.html Andrea Bolognani (2): news: Remove handling of random HTML tags news: Allow empty <section> elements docs/news-html.xsl | 20 +++++++++----------- docs/news.xml | 9 --------- docs/schemas/news.rng | 17 ++++++++--------- 3 files changed, 17 insertions(+), 29 deletions(-) -- 2.7.4

3 5

[libvirt] [PATCH 0/3] A couple of Coverity found issues
by John Ferlan 04 Apr '17

04 Apr '17

There's more, but many are false positives and there's also a couple more that I have to think more deeply about... John Ferlan (3): tests: Pass BlockIOThrottle arguments by reference not value qemu: Initialize 'data' argument qemu: Fix resource leak in qemuDomainAddChardevTLSObjects error path src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_migration.c | 11 ++++++++--- tests/qemumonitorjsontest.c | 38 +++++++++++++++++++------------------- 3 files changed, 28 insertions(+), 23 deletions(-) -- 2.9.3

2 4

[libvirt] [PATCH 0/5] qemu: fix individual vcpu hotplug code
by Peter Krempa 04 Apr '17

04 Apr '17

Resolve a few corner cases which would create invalid configurations or produce bad error messages. Peter Krempa (5): qemu: hotplug: Iterate over vcpu 0 in individual vcpu hotplug code qemu: hotplug: Fix formatting strings in qemuDomainFilterHotplugVcpuEntities qemu: hotplug: Clear vcpu ordering for coldplug of vcpus qemu: hotplug: Add validation for coldplug of individual vcpus qemu: hotplug: Validate that vcpu-hotplug does not break config src/qemu/qemu_hotplug.c | 73 +++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 65 insertions(+), 8 deletions(-) -- 2.12.2

2 8

[libvirt] [PATCH v2 00/10] hyperv: add support for Hyper-V 2012 and newer.
by Dawid Zamirski 04 Apr '17

04 Apr '17

Hello, This is v2 with all the code review feedback addressed. Please see the cover letter in v1 here: https://www.redhat.com/archives/libvir-list/2017-March/msg01624.html Changes in v2: * checked each patch with make syntax-check individually * fixed missing notices in hyperv_wmi_generator.py * addressed an issue where a case of "v2-only" WMI classes was not handled properly. Patches 5-10 should be squashed onto 4 - those won't compile individually as the code is too inter-dependent and are kept separately just for review puroposes. Regards, Dawid Zamirski (10): hyperv: store WMI version in hypervPrivate. hyperv: introduce hypervWmiClassInfo struct. hyperv: update hypervObject struct. hyperv: add hypervWqlQuery struct. hyperv: make hypervEnumAndPull use hypervWqlQuery hyperv: update generator input file. hyperv: update wmi code generator. hyperv: add helper for getting WMI class lists. hyperv: port rest of the driver to new stucts. hyperv: add hypervInitConnection. src/Makefile.am | 2 - src/hyperv/hyperv_driver.c | 168 ++++++++------- src/hyperv/hyperv_private.h | 8 +- src/hyperv/hyperv_wmi.c | 173 +++++++++++---- src/hyperv/hyperv_wmi.h | 56 ++++- src/hyperv/hyperv_wmi_classes.h | 30 +++ src/hyperv/hyperv_wmi_generator.input | 239 ++++++++++++++++++--- src/hyperv/hyperv_wmi_generator.py | 385 +++++++++++++++++++++++++--------- 8 files changed, 810 insertions(+), 251 deletions(-) -- 2.9.3

2 14

[libvirt] [PATCH v2] virNetDevIPCheckIPv6ForwardingCallback fixes
by Cédric Bosdonnat 03 Apr '17

03 Apr '17

Add check for more than one RTA_OIF, even though this is rather unlikely. Get rid of the buggy switch / break as this code won't need to handle more attributes. Use VIR_WARNINGS_NO_CAST_ALIGN to fix impossible to fix util/virnetdevip.c:560:17: error: cast increases required alignment of target type [-Werror=cast-align] --- Diff to v1: * Add error message * Use VIR_WARNINGS_NO_CAST_ALIGN src/util/virnetdevip.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index c9ac6baf7..726fa6c3e 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -556,15 +556,24 @@ virNetDevIPCheckIPv6ForwardingCallback(const struct nlmsghdr *resp, if (resp->nlmsg_type != RTM_NEWROUTE) return ret; - /* Extract a few attributes */ + /* Extract a device ID attribute */ + VIR_WARNINGS_NO_CAST_ALIGN for (rta = RTM_RTA(rtmsg); RTA_OK(rta, len); rta = RTA_NEXT(rta, len)) { - switch (rta->rta_type) { - case RTA_OIF: + VIR_WARNINGS_RESET + if (rta->rta_type == RTA_OIF) { oif = *(int *)RTA_DATA(rta); + /* Should never happen: netlink message would be broken */ + if (ifname) { + char *ifname2 = virNetDevGetName(oif); + VIR_WARN("Single route has unexpected 2nd interface " + "- '%s' and '%s'", ifname, ifname2); + VIR_FREE(ifname2); + break; + } + if (!(ifname = virNetDevGetName(oif))) goto error; - break; } } -- 2.12.0

3 2

[libvirt] [PATCH] qemu: Add device id for mediated devices on qemu command line
by Erik Skultety 03 Apr '17

03 Apr '17

Like all devices, add the 'id' option for mdevs as well. Patch also adjusts the test accordingly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1438431 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/qemu/qemu_command.c | 3 ++- tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-precreated.args | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 5cf383aaea..445c696d6e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5231,7 +5231,8 @@ qemuBuildHostdevMediatedDevStr(const virDomainDef *def, char *ret = NULL; virBufferAddLit(&buf, "vfio-pci"); - virBufferAsprintf(&buf, ",sysfsdev=%s", + virBufferAsprintf(&buf, ",id=%s,sysfsdev=%s", + dev->info->alias, virMediatedDeviceGetSysfsPath(mdevsrc->uuidstr)); if (qemuBuildDeviceAddressStr(&buf, def, dev->info, qemuCaps) < 0) diff --git a/tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-precreated.args b/tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-precreated.args index fdefeb6104..76e77707bf 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-precreated.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-precreated.args @@ -20,6 +20,6 @@ QEMU_AUDIO_DRV=none \ -usb \ -drive file=/dev/HostVG/QEMUGuest2,format=raw,if=none,id=drive-ide0-0-0 \ -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ --device vfio-pci,\ +-device vfio-pci,id=hostdev0,\ sysfsdev=/sys/bus/mdev/devices/53764d0e-85a0-42b4-af5c-2046b460b1dc,bus=pci.0,\ addr=0x3 -- 2.12.2

2 1

[libvirt] [PATCH 0/5] Split out network object into its own module
by John Ferlan 03 Apr '17

03 Apr '17

Reached the last of the code from my RFC for making a common pool object - networkobj... For reference see patch 3 of: http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html This series works through the network conf adjustments. This pile is fairly straightforward, like other series we split out anything referencing virNetworkPoolObj and go from there. There was one small detour to avoid a potentially conflict in names. John Ferlan (5): conf: Introduce virnetworkobj conf: Adjust coding style for network conf sources conf: Alter coding style of network conf function prototypes conf: Rename virNetworkObjAssignDef to virNetworkObjUpdateAssignDef conf: Use consistent function name prefixes for virnetworkobj po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/conf/network_conf.c | 1387 ++-------------------------------- src/conf/network_conf.h | 204 ++--- src/conf/virnetworkobj.c | 1371 +++++++++++++++++++++++++++++++++ src/conf/virnetworkobj.h | 185 +++++ src/libvirt_private.syms | 57 +- src/network/bridge_driver.c | 62 +- src/network/bridge_driver.h | 2 +- src/network/bridge_driver_platform.h | 2 +- src/test/test_driver.c | 16 +- 11 files changed, 1762 insertions(+), 1528 deletions(-) create mode 100644 src/conf/virnetworkobj.c create mode 100644 src/conf/virnetworkobj.h -- 2.9.3

2 8

[libvirt] [libvirt-perl][PATCH 0/3] Reflect upstream changes
by Michal Privoznik 03 Apr '17

03 Apr '17

Couple of new APIs and constants were added to libvirt. Reflect them in the perl bindings. Michal Privoznik (3): Add block threshold event Add virDomainSetBlockThreshold API Add VIR_MIGRATE_TLS constant Changes | 3 +++ Virt.xs | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++ lib/Sys/Virt/Domain.pm | 22 ++++++++++++++++++ t/030-api-coverage.t | 1 + 4 files changed, 87 insertions(+) -- 2.10.2

2 7