- Devel - libvirt List Archives

[libvirt] [PATCH] storage: gluster: Implement 'checkPool' method so that state is restored
by Peter Krempa 05 Apr '17

05 Apr '17

After restart of libvirtd the 'checkPool' method is supposed to validate that the pool is online. Since libvirt then refreshes the pool contents anyways just return whether the pool was supposed to be online so that the code can be reached. This is necessary since if a pool does not implement the method it's automatically considered as inactive. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1436065 --- src/storage/storage_backend_gluster.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c index 52c9ee372..83da47347 100644 --- a/src/storage/storage_backend_gluster.c +++ b/src/storage/storage_backend_gluster.c @@ -537,9 +537,22 @@ virStorageBackendGlusterFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSED, } +static int +virStorageBackendGlusterCheckPool(virStoragePoolObjPtr pool, + bool *active) +{ + /* Return previous state remembered by the status XML. If the pool is not + * available we will fail to refresh it and end up in the same situation. + * This will save one attempt to open the connection to the remote server */ + *active = pool->active; + return 0; +} + + virStorageBackend virStorageBackendGluster = { .type = VIR_STORAGE_POOL_GLUSTER, + .checkPool = virStorageBackendGlusterCheckPool, .refreshPool = virStorageBackendGlusterRefreshPool, .findPoolSources = virStorageBackendGlusterFindPoolSources, -- 2.12.1

2 1

[libvirt] [PATCH] docs: don't install news.rng file
by Daniel P. Berrange 05 Apr '17

05 Apr '17

The news.rng file gets picked up by the wildcard match on docs/schemas, and so gets installed into /usr/share/libvirt, along with the schemas for our API objects. This then generated an RPM build failure, since we don't have news.rng in the RPM file list The news.rng schema is not something that users of libvirt ever care about, since it is purely an internal thing to validate our website content. So rather than add news.rng to the RPM file list, this changes the make rules so that we don't install news.rng at all. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Technically a built-break fix, but I'm not pushing it, in case people have any alternative suggestions. eg we could just put news.rng in the tests/ subdirectory instead, letting us keep the wildcard in the docs/Makefile.am docs/Makefile.am | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 62e069e..2251848 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -153,7 +153,30 @@ fig = \ migration-unmanaged-direct.fig schemadir = $(pkgdatadir)/schemas -schema_DATA = $(wildcard $(srcdir)/schemas/*.rng) +schema_DATA = \ + schemas/basictypes.rng \ + schemas/capability.rng \ + schemas/cputypes.rng \ + schemas/domaincaps.rng \ + schemas/domaincommon.rng \ + schemas/domain.rng \ + schemas/domainsnapshot.rng \ + schemas/domain.xml \ + schemas/interface.rng \ + schemas/networkcommon.rng \ + schemas/network.rng \ + schemas/nodedev.rng \ + schemas/nwfilter.rng \ + schemas/secret.rng \ + schemas/storagecommon.rng \ + schemas/storagepool.rng \ + schemas/storagevol.rng \ + $(NULL) + +noinst_DATA = \ + schemas/news.rng \ + $(NULL) + EXTRA_DIST= \ apibuild.py genaclperms.pl \ @@ -166,7 +189,7 @@ EXTRA_DIST= \ $(internals_html_in) $(internals_html) \ aclperms.htmlinc \ hvsupport.pl \ - $(schema_DATA) + $(schema_DATA) $(noinst_DATA) acl_generated = aclperms.htmlinc -- 2.9.3

3 7

[libvirt] [PATCH] docs: Document limitation of maximum vcpu count used with <topology>
by Peter Krempa 05 Apr '17

05 Apr '17

qemu requires that the topology equals to the maximum vcpu count. Document this along with the API to set maximum vcpu count and the XML element. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1426220 --- docs/formatdomain.html.in | 5 ++++- src/libvirt-domain.c | 3 ++- tools/virsh.pod | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index aae5e9c07..b1e38f00e 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1401,7 +1401,10 @@ virtual CPU provided to the guest. Three non-zero values have to be given for <code>sockets</code>, <code>cores</code>, and <code>threads</code>: total number of CPU sockets, number of cores per - socket, and number of threads per core, respectively.</dd> + socket, and number of threads per core, respectively. Hypervisors may + require that the maximum number of vCPUs specified by the + <code>cpus</code> element equals to the number of vcpus resulting + from the topology.</dd> <dt><code>feature</code></dt> <dd>The <code>cpu</code> element can contain zero or more diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4670c54e5..310b91b37 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -7010,7 +7010,8 @@ virDomainSetVcpus(virDomainPtr domain, unsigned int nvcpus) * CPU limit is altered; generally, this value must be less than or * equal to virConnectGetMaxVcpus(). Otherwise, this call affects the * current virtual CPU limit, which must be less than or equal to the - * maximum limit. + * maximum limit. Note that hypervisors may not allow changing the maximum + * vcpu count if processor topology is specified. * * If @flags includes VIR_DOMAIN_VCPU_GUEST, then the state of processors is * modified inside the guest instead of the hypervisor. This flag can only diff --git a/tools/virsh.pod b/tools/virsh.pod index 9a52d6716..d1030808a 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2477,7 +2477,8 @@ marked as hotpluggable. The I<--maximum> flag controls the maximum number of virtual cpus that can be hot-plugged the next time the domain is booted. As such, it must only be used with the I<--config> flag, and not with the I<--live> or the I<--current> -flag. +flag. Note that it may not be possible to change the maximum vcpu count if +the processor topology is specified for the guest. =item B<setvcpu> I<domain> I<vcpulist> [I<--enable>] | [I<--disable>] [[I<--live>] [I<--config>] | [I<--current>]] -- 2.12.2

2 1

[libvirt] [PATCH v3 00/12] hyperv: add support for Hyper-V 2012 and newer.
by Dawid Zamirski 05 Apr '17

05 Apr '17

Changes since v2[1]: * address the issue with incorrect request URI used in invoke * update driver doc * add news entry [1] https://www.redhat.com/archives/libvir-list/2017-April/msg00018.html Dawid Zamirski (12): hyperv: store WMI version in hypervPrivate. hyperv: introduce hypervWmiClassInfo struct. hyperv: update hypervObject struct. hyperv: add hypervWqlQuery struct. hyperv: make hypervEnumAndPull use hypervWqlQuery hyperv: update generator input file. hyperv: update wmi code generator. hyperv: add helper for getting WMI class lists. hyperv: port rest of the driver to new stucts. hyperv: add hypervInitConnection. hyperv: update driver documentation. news: update for Hyper-V 2012+ support. docs/drvhyperv.html.in | 2 +- docs/news.xml | 11 + src/Makefile.am | 2 - src/hyperv/hyperv_driver.c | 168 ++++++++------- src/hyperv/hyperv_private.h | 8 +- src/hyperv/hyperv_wmi.c | 173 +++++++++++---- src/hyperv/hyperv_wmi.h | 56 ++++- src/hyperv/hyperv_wmi_classes.h | 30 +++ src/hyperv/hyperv_wmi_generator.input | 239 ++++++++++++++++++--- src/hyperv/hyperv_wmi_generator.py | 385 +++++++++++++++++++++++++--------- 10 files changed, 822 insertions(+), 252 deletions(-) -- 2.9.3

2 17

[libvirt] [PATCH v2 0/2] libvirt-python: libvirtaio
by Wojtek Porczyk 04 Apr '17

04 Apr '17

Hello, libvirt-list, This is second attempt at merging libvirtaio, an event loop implementation which dispatches the callbacks via asyncio's event loop. The first patch fixes the bug around freeing opaque objects [1][2], and the second one is the actual implementation. Since v1 series, as per Daniel Berrange's notes, the second patch has licence comment changed to LGPL-2.1+ and there is no import into main libvirt module. The first patch is unchanged. [1] https://www.redhat.com/archives/libvir-list/2017-January/msg00863.html [2] https://bugzilla.redhat.com/show_bug.cgi?id=1433028 Wojtek Porczyk (2): Allow for ff callbacks to be called by custom event implementations Add asyncio event loop implementation libvirt-override.c | 36 ++--- libvirt-override.py | 39 +++++ libvirt-python.spec.in | 1 + libvirtaio.py | 401 +++++++++++++++++++++++++++++++++++++++++++++++++ sanitytest.py | 5 +- setup.py | 12 ++ 6 files changed, 468 insertions(+), 26 deletions(-) create mode 100644 libvirtaio.py -- pozdrawiam / best regards _.-._ Wojtek Porczyk .-^' '^-. Invisible Things Lab |'-.-^-.-'| | | | | I do not fear computers, | '-.-' | I fear lack of them. '-._ : ,-' -- Isaac Asimov `^-^-_>

2 7

[libvirt] [PATCH v3.2-maint 0/2] Maintenance branch details
by Martin Kletzander 04 Apr '17

04 Apr '17

So I just created v3.2-maint with one rather important back-port. This is what I would've pushed with it, but I'd rather know the opinions on whether one or both ideas are stupid. Thanks. Martin Kletzander (2): Maintenance branch version bump docs: Add vz driver typo fix to news.xml configure.ac | 2 +- docs/news.xml | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) -- 2.12.2

2 4

[libvirt] [PATCH] libvirt_public.syms: Fix virDomainSetBlockThreshold placement
by Michal Privoznik 04 Apr '17

04 Apr '17

The symbol was introduced in the 3.2.0 release (bb09798fbeb5f) and not 3.1.0 release as its current placement in the file suggests. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt_public.syms | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index 428cf2e..37a8a18 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -755,8 +755,12 @@ LIBVIRT_3.0.0 { LIBVIRT_3.1.0 { global: - virDomainSetBlockThreshold; virDomainSetVcpu; } LIBVIRT_3.0.0; +LIBVIRT_3.2.0 { + global: + virDomainSetBlockThreshold; +} LIBVIRT_3.1.0; + # .... define new API here using predicted next version number .... -- 2.10.2

3 6

[libvirt] [PATCH] vz: fix typo that breaks build
by Nikolay Shirokovskiy 04 Apr '17

04 Apr '17

--- I guess it should be back ported to 3.2.0 release too. Sorry that we missed this during freeze period. src/vz/vz_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index bb1afd0..da83a8f 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -121,7 +121,7 @@ vzBuildCapabilities(void) verify(ARRAY_CARDINALITY(archs) == ARRAY_CARDINALITY(emulators)); - for (i = 0; i < ARRAY_CARDINALITY(os_types); i++) + for (i = 0; i < ARRAY_CARDINALITY(ostypes); i++) for (j = 0; j < ARRAY_CARDINALITY(archs); j++) for (k = 0; k < ARRAY_CARDINALITY(emulators); k++) if (vzCapsAddGuestDomain(caps, ostypes[i], archs[j], -- 1.8.3.1

2 2

[libvirt] [PATCH] qemu: Break endless loop if qemuMigrationResetTLS fails
by Jiri Denemark 04 Apr '17

04 Apr '17

Jumping to "endjob" label from a code after this label is not a very good idea. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 87d7dcd0c..7f00a3d93 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5351,9 +5351,7 @@ qemuMigrationFinish(virQEMUDriverPtr driver, QEMU_ASYNC_JOB_MIGRATION_IN); } - if (qemuMigrationResetTLS(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN, - NULL, NULL) < 0) - goto endjob; + qemuMigrationResetTLS(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN, NULL, NULL); qemuMigrationJobFinish(driver, vm); if (!virDomainObjIsActive(vm)) -- 2.12.2

3 4

[libvirt] [PATCH 0/2] More clang-inspired fixes
by Ján Tomko 04 Apr '17

04 Apr '17

Hopefully, the split of library/non-library code will let us tighten the frame limit in the future. Ján Tomko (2): util: ignore -Wcast-align in virNetlinkDumpCommand Split out -Wframe-larger-than warning from WARN_CLFAGS daemon/Makefile.am | 3 +++ m4/virt-compile-warnings.m4 | 4 ++-- src/Makefile.am | 1 + src/util/virnetlink.c | 3 ++- tests/Makefile.am | 2 ++ tools/Makefile.am | 6 ++++++ 6 files changed, 16 insertions(+), 3 deletions(-) -- 2.10.2

3 5