- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Move some functions to qemu_capspriv.h
by Andrea Bolognani 06 Apr '17

06 Apr '17

This header file has been created so that we can expose internal functions to the test suite without making them public: those in qemu_capabilities.h bearing the comment /* Only for use by test suite */ are obvious candidates for being moved over. --- src/qemu/qemu_capabilities.h | 19 ------------------- src/qemu/qemu_capspriv.h | 22 ++++++++++++++++++++++ tests/qemuhelptest.c | 4 ++++ 3 files changed, 26 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 24e2f38..cca9a12 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -473,11 +473,6 @@ bool virQEMUCapsIsValid(virQEMUCapsPtr qemuCaps, void virQEMUCapsFilterByMachineType(virQEMUCapsPtr qemuCaps, const char *machineType); -/* Only for use by test suite */ -void virQEMUCapsSetGICCapabilities(virQEMUCapsPtr qemuCaps, - virGICCapability *capabilities, - size_t ncapabilities); - virQEMUCapsCachePtr virQEMUCapsCacheNew(const char *libDir, const char *cacheDir, uid_t uid, gid_t gid); @@ -499,20 +494,6 @@ int virQEMUCapsGetDefaultVersion(virCapsPtr caps, virQEMUCapsCachePtr capsCache, unsigned int *version); -/* Only for use by test suite */ -int virQEMUCapsParseHelpStr(const char *qemu, - const char *str, - virQEMUCapsPtr qemuCaps, - unsigned int *version, - bool *is_kvm, - unsigned int *kvm_version, - bool check_yajl, - const char *qmperr); -/* Only for use by test suite */ -int virQEMUCapsParseDeviceStr(virQEMUCapsPtr qemuCaps, const char *str); -/* Only for use by test suite */ -void virQEMUCapsInitQMPBasicArch(virQEMUCapsPtr qemuCaps); - VIR_ENUM_DECL(virQEMUCaps); bool virQEMUCapsSupportsChardev(const virDomainDef *def, diff --git a/src/qemu/qemu_capspriv.h b/src/qemu/qemu_capspriv.h index 61ccd45..9818859 100644 --- a/src/qemu/qemu_capspriv.h +++ b/src/qemu/qemu_capspriv.h @@ -84,6 +84,9 @@ virQEMUCapsInitCPUModel(virQEMUCapsPtr qemuCaps, virCPUDefPtr cpu); void +virQEMUCapsInitQMPBasicArch(virQEMUCapsPtr qemuCaps); + +void virQEMUCapsSetCPUModelInfo(virQEMUCapsPtr qemuCaps, virDomainVirtType type, qemuMonitorCPUModelInfoPtr modelInfo); @@ -92,4 +95,23 @@ virCPUDefPtr virQEMUCapsProbeHostCPUForEmulator(virCapsPtr caps, virQEMUCapsPtr qemuCaps, virDomainVirtType type); + +void +virQEMUCapsSetGICCapabilities(virQEMUCapsPtr qemuCaps, + virGICCapability *capabilities, + size_t ncapabilities); + +int +virQEMUCapsParseHelpStr(const char *qemu, + const char *str, + virQEMUCapsPtr qemuCaps, + unsigned int *version, + bool *is_kvm, + unsigned int *kvm_version, + bool check_yajl, + const char *qmperr); + +int +virQEMUCapsParseDeviceStr(virQEMUCapsPtr qemuCaps, + const char *str); #endif diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index e3751b2..d80225c 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -8,6 +8,10 @@ # include <stdlib.h> # include "qemu/qemu_capabilities.h" +# define __QEMU_CAPSPRIV_H_ALLOW__ +# include "qemu/qemu_capspriv.h" +# undef __QEMU_CAPSPRIV_H_ALLOW__ + # include "viralloc.h" # include "virstring.h" -- 2.7.4

3 4

[libvirt] [PATCH v2] storage: Avoid leak in virStorageUtilGlusterExtractPoolSources()
by Andrea Bolognani 06 Apr '17

06 Apr '17

The contents of volname would be leaked if the function were to be passed an invalid pooltype by the caller. Make sure the memory is released instead. --- Changes from v1: * use VIR_STEAL_PTR() instead of open-coding it. src/storage/storage_util.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 7cc125a..8e25984 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -2846,7 +2846,7 @@ virStorageUtilGlusterExtractPoolSources(const char *host, xmlXPathContextPtr ctxt = NULL; xmlNodePtr *nodes = NULL; virStoragePoolSource *src = NULL; - char *volname; + char *volname = NULL; size_t i; int nnodes; int ret = -1; @@ -2871,12 +2871,11 @@ virStorageUtilGlusterExtractPoolSources(const char *host, if (pooltype == VIR_STORAGE_POOL_NETFS) { src->format = VIR_STORAGE_POOL_NETFS_GLUSTERFS; - src->dir = volname; + VIR_STEAL_PTR(src->dir, volname); } else if (pooltype == VIR_STORAGE_POOL_GLUSTER) { - src->name = volname; - if (VIR_STRDUP(src->dir, "/") < 0) goto cleanup; + VIR_STEAL_PTR(src->name, volname); } else { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unsupported gluster lookup")); @@ -2894,6 +2893,7 @@ virStorageUtilGlusterExtractPoolSources(const char *host, ret = nnodes; cleanup: + VIR_FREE(volname); VIR_FREE(nodes); xmlXPathFreeContext(ctxt); xmlFreeDoc(doc); -- 2.7.4

2 1

[libvirt] [PATCH] storage: Avoid leak in virStorageUtilGlusterExtractPoolSources()
by Andrea Bolognani 06 Apr '17

06 Apr '17

The contents of volname would be leaked if the function were to be passed an invalid pooltype by the caller. Make sure the memory is released instead. --- Initializing volname to NULL is strictly speaking not necessary, but I like it better that way :) src/storage/storage_util.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 7cc125a..e0f948b 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -2846,7 +2846,7 @@ virStorageUtilGlusterExtractPoolSources(const char *host, xmlXPathContextPtr ctxt = NULL; xmlNodePtr *nodes = NULL; virStoragePoolSource *src = NULL; - char *volname; + char *volname = NULL; size_t i; int nnodes; int ret = -1; @@ -2871,12 +2871,17 @@ virStorageUtilGlusterExtractPoolSources(const char *host, if (pooltype == VIR_STORAGE_POOL_NETFS) { src->format = VIR_STORAGE_POOL_NETFS_GLUSTERFS; + + /* Ownership of volname is passed to src */ src->dir = volname; + volname = NULL; } else if (pooltype == VIR_STORAGE_POOL_GLUSTER) { - src->name = volname; - if (VIR_STRDUP(src->dir, "/") < 0) goto cleanup; + + /* Ownership of volname is passed to src */ + src->name = volname; + volname = NULL; } else { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unsupported gluster lookup")); @@ -2894,6 +2899,7 @@ virStorageUtilGlusterExtractPoolSources(const char *host, ret = nnodes; cleanup: + VIR_FREE(volname); VIR_FREE(nodes); xmlXPathFreeContext(ctxt); xmlFreeDoc(doc); -- 2.7.4

3 3

[libvirt] [PATCH] qemu: Fix VPATH syntax-check for qemuSecurity wrappers enforcment
by Boris Fiuczynski 05 Apr '17

05 Apr '17

Fixing make syntax-check broken by commit 4da534c0b9. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> Reviewed-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com> --- cfg.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index 89e03ca..cc174a3 100644 --- a/cfg.mk +++ b/cfg.mk @@ -984,8 +984,8 @@ sc_prohibit_sysconf_pagesize: $(_sc_search_regexp) sc_prohibit_virSecurity: - @grep -Pn 'virSecurityManager(?!Ptr)' $$($(VC_LIST_EXCEPT) | grep '^src/qemu/' | \ - grep -v '^src/qemu/qemu_security') && \ + @grep -Pn 'virSecurityManager(?!Ptr)' $$($(VC_LIST_EXCEPT) | grep 'src/qemu/' | \ + grep -v 'src/qemu/qemu_security') && \ { echo '$(ME): prefer qemuSecurity wrappers' 1>&2; exit 1; } || : sc_prohibit_pthread_create: -- 2.7.4

2 1

[libvirt] [PATCH] qemu: Properly reset TLS in qemuProcessRecoverMigrationIn
by Jiri Denemark 05 Apr '17

05 Apr '17

There is no async job running when a freshly started libvirtd is trying to recover from an interrupted incoming migration. While at it, let's call qemuMigrationResetTLS every time we don't kill the domain. This is not strictly necessary since TLS is not supported when v2 migration protocol is used, but doing so makes more sense. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_process.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e450d0647..a37496107 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2973,9 +2973,6 @@ qemuProcessRecoverMigrationIn(virQEMUDriverPtr driver, /* migration finished, we started resuming the domain but didn't * confirm success or failure yet; killing it seems safest unless * we already started guest CPUs or we were in post-copy mode */ - ignore_value(qemuMigrationResetTLS(driver, vm, - QEMU_ASYNC_JOB_MIGRATION_IN, - NULL, NULL)); if (postcopy) { qemuMigrationPostcopyFailed(driver, vm); } else if (state != VIR_DOMAIN_RUNNING) { @@ -2985,6 +2982,7 @@ qemuProcessRecoverMigrationIn(virQEMUDriverPtr driver, break; } + qemuMigrationResetTLS(driver, vm, QEMU_ASYNC_JOB_NONE, NULL, NULL); return 0; } -- 2.12.2

1 1

[libvirt] [PATCH v2 0/5] qemu: ACPI and UEFI fixes
by Andrea Bolognani 05 Apr '17

05 Apr '17

Changes from [v1]: * use a dedicated function for setting basic arch-dependent capabilities instead of having two copies of the same code that will have to be kept in sync; * enforce requirements at guest validation time rather than at command line creation time; * shuffle patches around so that the order has more sense; * make test files slightly smaller and nicer. [v1] https://www.redhat.com/archives/libvir-list/2017-March/msg00429.html Andrea Bolognani (5): qemu: Split virQEMUCapsInitArchQMPBasic() tests: Initialize basic capabilities properly qemu: Advertise ACPI support for aarch64 guests qemu: Enforce ACPI, UEFI requirements tests: Test ACPI, UEFI requirements src/qemu/qemu_capabilities.c | 68 ++++++++++++++++------ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 20 ++----- src/qemu/qemu_domain.c | 20 +++++++ .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + .../qemuxml2argv-aarch64-aavmf-virtio-mmio.args | 1 + .../qemuxml2argv-aarch64-aavmf-virtio-mmio.xml | 1 - ....args => qemuxml2argv-aarch64-acpi-nouefi.args} | 9 +-- .../qemuxml2argv-aarch64-acpi-nouefi.xml | 22 +++++++ .../qemuxml2argv-aarch64-acpi-uefi.args | 22 +++++++ .../qemuxml2argv-aarch64-acpi-uefi.xml | 21 +++++++ .../qemuxml2argv-aarch64-cpu-passthrough.args | 1 + .../qemuxml2argv-aarch64-cpu-passthrough.xml | 1 - ...rgs => qemuxml2argv-aarch64-noacpi-nouefi.args} | 13 +++-- .../qemuxml2argv-aarch64-noacpi-nouefi.xml | 19 ++++++ .../qemuxml2argv-aarch64-noacpi-uefi.args | 23 ++++++++ .../qemuxml2argv-aarch64-noacpi-uefi.xml | 18 ++++++ .../qemuxml2argv-aarch64-video-virtio-gpu-pci.args | 1 + .../qemuxml2argv-aarch64-video-virtio-gpu-pci.xml | 3 - ...l2argv-aarch64-virt-2.6-virtio-pci-default.args | 1 + ...ml2argv-aarch64-virt-2.6-virtio-pci-default.xml | 1 - .../qemuxml2argv-aarch64-virt-default-nic.args | 1 + .../qemuxml2argv-aarch64-virt-default-nic.xml | 3 - .../qemuxml2argv-aarch64-virt-virtio.args | 1 + .../qemuxml2argv-aarch64-virt-virtio.xml | 1 - .../qemuxml2argv-aarch64-virtio-pci-default.args | 1 + .../qemuxml2argv-aarch64-virtio-pci-default.xml | 1 - ...l2argv-aarch64-virtio-pci-manual-addresses.args | 1 + ...ml2argv-aarch64-virtio-pci-manual-addresses.xml | 1 - .../qemuxml2argv-balloon-ccw-deflate.args | 1 - .../qemuxml2argv-balloon-mmio-deflate.args | 1 + .../qemuxml2argv-balloon-mmio-deflate.xml | 1 - .../qemuxml2argv-console-sclp.args | 1 - .../qemuxml2argv-console-virtio-ccw.args | 1 - .../qemuxml2argv-console-virtio-s390.args | 1 - .../qemuxml2argv-cpu-s390-features.args | 1 - .../qemuxml2argv-cpu-s390-zEC12.args | 1 - .../qemuxml2argv-disk-virtio-ccw-many.args | 1 - .../qemuxml2argv-disk-virtio-ccw.args | 1 - .../qemuxml2argv-disk-virtio-s390.args | 1 - .../qemuxml2argv-disk-virtio-scsi-ccw.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-fs9p-ccw.args | 1 - .../qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.args | 1 - .../qemuxml2argv-hugepages-numa.args | 1 + .../qemuxml2argv-iothreads-disk-virtio-ccw.args | 1 - .../qemuxml2argv-iothreads-virtio-scsi-ccw.args | 1 - .../qemuxml2argv-machine-aeskeywrap-off-cap.args | 1 - .../qemuxml2argv-machine-aeskeywrap-off-caps.args | 1 - .../qemuxml2argv-machine-aeskeywrap-on-cap.args | 1 - .../qemuxml2argv-machine-aeskeywrap-on-caps.args | 1 - .../qemuxml2argv-machine-deakeywrap-off-cap.args | 1 - .../qemuxml2argv-machine-deakeywrap-off-caps.args | 1 - .../qemuxml2argv-machine-deakeywrap-on-cap.args | 1 - .../qemuxml2argv-machine-deakeywrap-on-caps.args | 1 - .../qemuxml2argv-machine-keywrap-none-caps.args | 1 - .../qemuxml2argv-machine-keywrap-none.args | 1 - .../qemuxml2argv-memory-hotplug-ppc64-nonuma.args | 1 - .../qemuxml2argv-net-virtio-ccw.args | 1 - .../qemuxml2argv-net-virtio-s390.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.args | 1 - .../qemuxml2argv-ppce500-serial.args | 1 - .../qemuxml2argv-pseries-basic.args | 1 - .../qemuxml2argv-pseries-cpu-compat.args | 1 - .../qemuxml2argv-pseries-cpu-exact.args | 1 - .../qemuxml2argv-pseries-cpu-le.args | 1 - .../qemuxml2argv-pseries-nvram.args | 1 - .../qemuxml2argv-pseries-panic-missing.args | 1 - .../qemuxml2argv-pseries-panic-no-address.args | 1 - .../qemuxml2argv-pseries-usb-default.args | 1 - .../qemuxml2argv-pseries-usb-kbd.args | 1 - .../qemuxml2argv-pseries-usb-multi.args | 1 - .../qemuxml2argv-pseries-vio-user-assigned.args | 1 - .../qemuxml2argvdata/qemuxml2argv-pseries-vio.args | 1 - .../qemuxml2argv-q35-acpi-nouefi.args | 21 +++++++ .../qemuxml2argv-q35-acpi-nouefi.xml | 22 +++++++ .../qemuxml2argv-q35-acpi-uefi.args | 22 +++++++ .../qemuxml2argv-q35-acpi-uefi.xml | 21 +++++++ .../qemuxml2argv-q35-noacpi-nouefi.args | 22 +++++++ .../qemuxml2argv-q35-noacpi-nouefi.xml | 19 ++++++ .../qemuxml2argv-q35-noacpi-uefi.xml | 18 ++++++ .../qemuxml2argv-q35-virt-manager-basic.args | 1 + ...muxml2argv-s390-allow-bogus-usb-controller.args | 1 - .../qemuxml2argv-s390-allow-bogus-usb-none.args | 1 - .../qemuxml2argv-s390-panic-missing.args | 1 - .../qemuxml2argv-s390-panic-no-address.args | 1 - .../qemuxml2argv-virtio-rng-ccw.args | 1 - .../qemuxml2argv-watchdog-diag288.args | 1 - tests/qemuxml2argvtest.c | 18 +++++- .../qemuxml2xmlout-aarch64-aavmf-virtio-mmio.xml | 1 - ...qemuxml2xmlout-aarch64-video-virtio-gpu-pci.xml | 1 - .../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 1 - ...2xmlout-aarch64-virtio-pci-manual-addresses.xml | 1 - 93 files changed, 388 insertions(+), 109 deletions(-) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-cpu-passthrough.args => qemuxml2argv-aarch64-acpi-nouefi.args} (55%) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-acpi-nouefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-acpi-uefi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-acpi-uefi.xml copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-cpu-passthrough.args => qemuxml2argv-aarch64-noacpi-nouefi.args} (50%) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-noacpi-nouefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-noacpi-uefi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-noacpi-uefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-acpi-nouefi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-acpi-nouefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-acpi-uefi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-acpi-uefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-noacpi-nouefi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-noacpi-nouefi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-noacpi-uefi.xml -- 2.7.4

3 19

[libvirt] [PATCH] qemu: monitor: No need to debug-log the 'mon' pointer
by Peter Krempa 05 Apr '17

05 Apr '17

QEMU_CHECK_MONITOR_* already logs the object and vm name --- src/qemu/qemu_monitor.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index a4fa6eca6..2fc6192dc 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4194,8 +4194,6 @@ qemuMonitorMigrateIncoming(qemuMonitorPtr mon, int qemuMonitorMigrateStartPostCopy(qemuMonitorPtr mon) { - VIR_DEBUG("mon=%p", mon); - QEMU_CHECK_MONITOR_JSON(mon); return qemuMonitorJSONMigrateStartPostCopy(mon); @@ -4205,8 +4203,6 @@ int qemuMonitorGetRTCTime(qemuMonitorPtr mon, struct tm *tm) { - VIR_DEBUG("mon=%p", mon); - QEMU_CHECK_MONITOR_JSON(mon); return qemuMonitorJSONGetRTCTime(mon, tm); @@ -4216,8 +4212,6 @@ qemuMonitorGetRTCTime(qemuMonitorPtr mon, virHashTablePtr qemuMonitorQueryQMPSchema(qemuMonitorPtr mon) { - VIR_DEBUG("mon=%p", mon); - QEMU_CHECK_MONITOR_JSON_NULL(mon); return qemuMonitorJSONQueryQMPSchema(mon); @@ -4229,7 +4223,7 @@ qemuMonitorSetBlockThreshold(qemuMonitorPtr mon, const char *nodename, unsigned long long threshold) { - VIR_DEBUG("mon=%p, node='%s', threshold=%llu", mon, nodename, threshold); + VIR_DEBUG("node='%s', threshold=%llu", nodename, threshold); QEMU_CHECK_MONITOR_JSON(mon); @@ -4240,8 +4234,6 @@ qemuMonitorSetBlockThreshold(qemuMonitorPtr mon, virJSONValuePtr qemuMonitorQueryNamedBlockNodes(qemuMonitorPtr mon) { - VIR_DEBUG("mon=%p", mon); - QEMU_CHECK_MONITOR_JSON_NULL(mon); return qemuMonitorJSONQueryNamedBlockNodes(mon); -- 2.12.2

2 1

[libvirt] [PATCH 00/14] Add tests for virCPUUpdateLive API
by Jiri Denemark 05 Apr '17

05 Apr '17

Jiri Denemark (14): cpu_conf: Introduce virCPUDefFreeFeatures cpu: Introduce virCPUExpandFeatures cpu: Drop unused flags from cpuArchDecode cpu: Move feature expansion out of cpuBaseline cpu: Do not pass virConnectBaselineCPUFlags to cpuBaseline cputest: Move instantiation of JSONDecoder in cpu-convert.py cputest: Rename cpu-convert.py script as cpu-cpuid.py cputest: Add cpuidIsSet helper to cpu-cpuid.py cputest: Add cpuidLeaf helper to cpu-cpuid.py cputest: Add "diff" command to cpu-cpuid.py cputest: Generate data for virCPUUpdateLive cputest: Disable TSX on broken models cputest: Disable "cmt" feature unknown to QEMU cputest: Add tests for virCPUUpdateLive API src/conf/cpu_conf.c | 21 ++- src/conf/cpu_conf.h | 3 + src/cpu/cpu.c | 74 +++++++-- src/cpu/cpu.h | 15 +- src/cpu/cpu_arm.c | 5 +- src/cpu/cpu_ppc64.c | 12 +- src/cpu/cpu_x86.c | 109 ++++++++------ src/libvirt_private.syms | 2 + tests/cputest.c | 160 +++++++++++++++++++- tests/cputestdata/{cpu-convert.py => cpu-cpuid.py} | 165 +++++++++++++++++---- tests/cputestdata/cpu-parse.sh | 3 +- tests/cputestdata/x86_64-baseline-3-expanded.xml | 48 +++--- tests/cputestdata/x86_64-baseline-4-expanded.xml | 68 ++++----- tests/cputestdata/x86_64-baseline-5-expanded.xml | 70 ++++----- .../x86_64-cpuid-A10-5800K-disabled.xml | 7 + .../cputestdata/x86_64-cpuid-A10-5800K-enabled.xml | 8 + .../x86_64-cpuid-Core-i5-2500-disabled.xml | 5 + .../x86_64-cpuid-Core-i5-2500-enabled.xml | 9 ++ .../x86_64-cpuid-Core-i5-2540M-disabled.xml | 5 + .../x86_64-cpuid-Core-i5-2540M-enabled.xml | 9 ++ .../x86_64-cpuid-Core-i5-4670T-disabled.xml | 7 + .../x86_64-cpuid-Core-i5-4670T-enabled.xml | 8 + tests/cputestdata/x86_64-cpuid-Core-i5-4670T.json | 4 +- .../x86_64-cpuid-Core-i5-6600-disabled.xml | 5 + .../x86_64-cpuid-Core-i5-6600-enabled.xml | 9 ++ .../x86_64-cpuid-Core-i7-2600-disabled.xml | 6 + .../x86_64-cpuid-Core-i7-2600-enabled.xml | 8 + .../x86_64-cpuid-Core-i7-3740QM-disabled.xml | 6 + .../x86_64-cpuid-Core-i7-3740QM-enabled.xml | 8 + .../x86_64-cpuid-Core-i7-3770-disabled.xml | 6 + .../x86_64-cpuid-Core-i7-3770-enabled.xml | 8 + .../x86_64-cpuid-Core-i7-4510U-disabled.xml | 5 + .../x86_64-cpuid-Core-i7-4510U-enabled.xml | 9 ++ .../x86_64-cpuid-Core-i7-4600U-disabled.xml | 5 + .../x86_64-cpuid-Core-i7-4600U-enabled.xml | 9 ++ .../x86_64-cpuid-Core-i7-5600U-disabled.xml | 5 + .../x86_64-cpuid-Core-i7-5600U-enabled.xml | 9 ++ .../x86_64-cpuid-Core2-E6850-disabled.xml | 4 + .../x86_64-cpuid-Core2-E6850-enabled.xml | 7 + .../x86_64-cpuid-Opteron-2350-disabled.xml | 7 + .../x86_64-cpuid-Opteron-2350-enabled.xml | 7 + .../x86_64-cpuid-Opteron-6234-disabled.xml | 7 + .../x86_64-cpuid-Opteron-6234-enabled.xml | 9 ++ .../x86_64-cpuid-Phenom-B95-disabled.xml | 7 + .../x86_64-cpuid-Phenom-B95-enabled.xml | 7 + .../x86_64-cpuid-Xeon-E3-1245-disabled.xml | 6 + .../x86_64-cpuid-Xeon-E3-1245-enabled.xml | 9 ++ .../x86_64-cpuid-Xeon-E5-2630-disabled.xml | 7 + .../x86_64-cpuid-Xeon-E5-2630-enabled.xml | 8 + .../x86_64-cpuid-Xeon-E5-2650-disabled.xml | 8 + .../x86_64-cpuid-Xeon-E5-2650-enabled.xml | 7 + .../x86_64-cpuid-Xeon-E7-4820-disabled.xml | 6 + .../x86_64-cpuid-Xeon-E7-4820-enabled.xml | 7 + .../x86_64-cpuid-Xeon-W3520-disabled.xml | 5 + .../x86_64-cpuid-Xeon-W3520-enabled.xml | 7 + 55 files changed, 834 insertions(+), 206 deletions(-) rename tests/cputestdata/{cpu-convert.py => cpu-cpuid.py} (83%) create mode 100644 tests/cputestdata/x86_64-cpuid-A10-5800K-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-A10-5800K-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-2500-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-2500-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-2540M-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-2540M-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-4670T-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-4670T-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-6600-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i5-6600-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-2600-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-2600-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-3740QM-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-3740QM-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-3770-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-3770-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4510U-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4600U-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-4600U-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core-i7-5600U-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core2-E6850-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Core2-E6850-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Opteron-2350-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Opteron-2350-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Opteron-6234-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Opteron-6234-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Phenom-B95-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Phenom-B95-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E3-1245-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E3-1245-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2630-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E5-2650-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E7-4820-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-E7-4820-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-W3520-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Xeon-W3520-enabled.xml -- 2.12.0

4 21

[libvirt] [PATCH] docs: Add news.rng to EXTRA_DIST
by Peter Krempa 05 Apr '17

05 Apr '17

--- Pushed under the build-breaker rule. docs/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/Makefile.am b/docs/Makefile.am index 62e069e15..105fe6894 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -220,6 +220,7 @@ news.html.in: \ fi EXTRA_DIST += \ $(srcdir)/news.xml \ + $(srcdir)/news.rng \ $(srcdir)/news-html.xsl MAINTAINERCLEANFILES += \ $(srcdir)/news.html.in -- 2.12.2

1 0

[libvirt] [PATCH v3 0/5] Fix gluster pool lookup issues
by Peter Krempa 05 Apr '17

05 Apr '17

Naming, style and other fixes suggested by Andrea in his review. The changes were too invasive so I'll rather repost it. Peter Krempa (5): storage: util: Pass pool type to virStorageBackendFindGlusterPoolSources storage: util: Split out the gluster volume extraction code into new function test: Introduce testing of virStorageUtilGlusterExtractPoolSources storage: Fix XPath for looking up gluster volume name storage: gluster: Use volume name as "<name>" field in the XML src/storage/storage_backend_fs.c | 2 +- src/storage/storage_backend_gluster.c | 2 +- src/storage/storage_util.c | 114 +++++++++++++-------- src/storage/storage_util.h | 6 +- tests/Makefile.am | 16 ++- .../gluster-parse-basic-native.xml | 7 ++ .../gluster-parse-basic-netfs.xml | 7 ++ .../virstorageutildata/gluster-parse-basic-src.xml | 47 +++++++++ .../gluster-parse-multivol-native.xml | 17 +++ .../gluster-parse-multivol-netfs.xml | 17 +++ .../gluster-parse-multivol-src.xml | 32 ++++++ tests/virstorageutiltest.c | 114 +++++++++++++++++++++ 12 files changed, 336 insertions(+), 45 deletions(-) create mode 100644 tests/virstorageutildata/gluster-parse-basic-native.xml create mode 100644 tests/virstorageutildata/gluster-parse-basic-netfs.xml create mode 100644 tests/virstorageutildata/gluster-parse-basic-src.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-native.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-netfs.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-src.xml create mode 100644 tests/virstorageutiltest.c -- 2.12.2

3 10