- Devel - libvirt List Archives

[libvirt] [PATCH 00/23] Pre-CAT preparation patches (mostly trivial, I promise)
by Martin Kletzander 27 Mar '17

27 Mar '17

Don't get pushed away just because it is 23 patches. They are almost one-liners. Just a lot of stuff I got dragged into, lot of rabbit holes where I reached the end, basically lot of side fixes. That's mostly due to one of the bigger changes being removed from the series completely about two days ago when I realized I'm not spending week of fixing terribly tricky stuff just so we can test one more teeny tiny thing that's not even needed (which I realized way too late). The patches are available on github: https://github.com/nertpinx/libvirt -- branch pre-cat The patches should be *really* nice to review, and there's lot of cleanups. The only reason for this patch-series to add more lines than remove them, is because it adds tests. And tests are good and yummy. Me like tests... Yeah, I guess it's Friday, 8PM. I should go home... Bye. Martin Kletzander (23): Add virNumaGetNodeCPUs to private syms Introduce virCPUProbeHost Expose virCapabilitiesFreeGuest vmware: Fix some initialization problems cpu: Don't use prefixes for no reason syms: Add one newline to make things consistent tests: Fix indentation in virhostcputest vz: Do not use magic constants when building capabilities Separate syms based on files they are defined in openvz: Ditch openvzGetNodeCPUs tests: Remove some unneeded files virfile: Add helpers for reading simple values tests: Add cpu/{online,present} files for old tests util: Add virsysfs for handling sysfs files util: Adapt virhostcpu to the new virsysfs Move src/fdstream to src/util/virfdstream Remove src/nodeinfo util: Fix naming in util/virnodesuspend Change virQEMUCapsInitPages to virCapabilitiesInitPages tests: Add sysfs node/cpu topology for the only vircaps2xml testcase tests: Add linux-caches sysfs entries for vircaps2xmltest tests: Add virnumamock tests: Enhance vircaps2xml test cfg.mk | 2 +- po/POTFILES.in | 3 +- src/Makefile.am | 7 +- src/bhyve/bhyve_capabilities.c | 20 +- src/bhyve/bhyve_driver.c | 7 +- src/conf/capabilities.c | 317 +++++++++++++++- src/conf/capabilities.h | 9 + src/conf/virchrdev.c | 2 +- src/cpu/cpu.c | 15 +- src/cpu/cpu.h | 5 +- src/libvirt_linux.syms | 1 - src/libvirt_private.syms | 93 +++-- src/libxl/libxl_migration.c | 2 +- src/lxc/lxc_conf.c | 3 +- src/lxc/lxc_driver.c | 7 +- src/nodeinfo.c | 418 --------------------- src/openvz/openvz_conf.c | 17 +- src/openvz/openvz_conf.h | 1 - src/openvz/openvz_driver.c | 5 +- src/phyp/phyp_driver.c | 3 +- src/qemu/qemu_capabilities.c | 43 +-- src/qemu/qemu_conf.c | 1 - src/qemu/qemu_driver.c | 7 +- src/qemu/qemu_migration.c | 2 +- src/storage/storage_driver.c | 2 +- src/storage/storage_util.c | 2 +- src/test/test_driver.c | 2 +- src/uml/uml_conf.c | 3 +- src/uml/uml_driver.c | 7 +- src/{fdstream.c => util/virfdstream.c} | 4 +- src/{fdstream.h => util/virfdstream.h} | 2 +- src/util/virfile.c | 83 ++++ src/util/virfile.h | 6 + src/util/virhostcpu.c | 345 +++++------------ src/util/virhostcpu.h | 7 +- src/util/virhostcpupriv.h | 2 - src/util/virnodesuspend.c | 20 +- src/util/virnodesuspend.h | 6 +- src/util/virsysfs.c | 229 +++++++++++ src/util/virsysfs.h | 70 ++++ src/{nodeinfo.h => util/virsysfspriv.h} | 18 +- src/vbox/vbox_common.c | 7 +- src/vmware/vmware_conf.c | 20 +- src/vz/vz_driver.c | 16 +- src/vz/vz_sdk.c | 1 - src/xen/xen_driver.c | 5 +- tests/Makefile.am | 7 + tests/commandtest.c | 1 - tests/fdstreamtest.c | 2 +- .../linux-basic/cpu/cpu0/topology/core_id} | 0 .../linux-basic/cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list} | 0 .../linux-basic/cpu/cpu1/topology/core_id | 1 + .../linux-basic/cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list | 1 + .../cpu/cpu1/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu10/topology/core_id | 1 + .../linux-basic/cpu/cpu10/topology/core_siblings | 1 + .../cpu/cpu10/topology/core_siblings_list | 1 + .../cpu/cpu10/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu10/topology/thread_siblings | 1 + .../cpu/cpu10/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu11/topology/core_id | 1 + .../linux-basic/cpu/cpu11/topology/core_siblings | 1 + .../cpu/cpu11/topology/core_siblings_list | 1 + .../cpu/cpu11/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu11/topology/thread_siblings | 1 + .../cpu/cpu11/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu12/topology/core_id | 1 + .../linux-basic/cpu/cpu12/topology/core_siblings | 1 + .../cpu/cpu12/topology/core_siblings_list | 1 + .../cpu/cpu12/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu12/topology/thread_siblings | 1 + .../cpu/cpu12/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu13/topology/core_id | 1 + .../linux-basic/cpu/cpu13/topology/core_siblings | 1 + .../cpu/cpu13/topology/core_siblings_list | 1 + .../cpu/cpu13/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu13/topology/thread_siblings | 1 + .../cpu/cpu13/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu14/topology/core_id | 1 + .../linux-basic/cpu/cpu14/topology/core_siblings | 1 + .../cpu/cpu14/topology/core_siblings_list | 1 + .../cpu/cpu14/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu14/topology/thread_siblings | 1 + .../cpu/cpu14/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu15/topology/core_id | 1 + .../linux-basic/cpu/cpu15/topology/core_siblings | 1 + .../cpu/cpu15/topology/core_siblings_list | 1 + .../cpu/cpu15/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu15/topology/thread_siblings | 1 + .../cpu/cpu15/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu2/topology/core_id | 1 + .../linux-basic/cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list | 1 + .../cpu/cpu2/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu3/topology/core_id | 1 + .../linux-basic/cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list | 1 + .../cpu/cpu3/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu4/topology/core_id | 1 + .../linux-basic/cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu5/topology/core_id | 1 + .../linux-basic/cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu6/topology/core_id | 1 + .../linux-basic/cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu7/topology/core_id | 1 + .../linux-basic/cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu8/topology/core_id | 1 + .../linux-basic/cpu/cpu8/topology/core_siblings | 1 + .../cpu/cpu8/topology/core_siblings_list | 1 + .../cpu/cpu8/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu8/topology/thread_siblings | 1 + .../cpu/cpu8/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu9/topology/core_id | 1 + .../linux-basic/cpu/cpu9/topology/core_siblings | 1 + .../cpu/cpu9/topology/core_siblings_list | 1 + .../cpu/cpu9/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu9/topology/thread_siblings | 1 + .../cpu/cpu9/topology/thread_siblings_list | 1 + tests/vircaps2xmldata/linux-basic/cpu/online | 1 + tests/vircaps2xmldata/linux-basic/cpu/present | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu0 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu1 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu2 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu3 | 1 + .../vircaps2xmldata/linux-basic/node/node0/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu4 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu5 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu6 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu7 | 1 + .../vircaps2xmldata/linux-basic/node/node1/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu10 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu11 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu8 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu9 | 1 + .../vircaps2xmldata/linux-basic/node/node2/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu12 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu13 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu14 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu15 | 1 + .../vircaps2xmldata/linux-basic/node/node3/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/online | 1 + tests/vircaps2xmldata/linux-basic/node/possible | 1 + .../linux-caches/cpu/cpu0/cache/index0/level | 1 + .../cpu/cpu0/cache/index0/shared_cpu_list | 1 + .../cpu/cpu0/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index0/size | 1 + .../linux-caches/cpu/cpu0/cache/index0/type | 1 + .../linux-caches/cpu/cpu0/cache/index1/level | 1 + .../cpu/cpu0/cache/index1/shared_cpu_list | 1 + .../cpu/cpu0/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index1/size | 1 + .../linux-caches/cpu/cpu0/cache/index1/type | 1 + .../linux-caches/cpu/cpu0/cache/index2/level | 1 + .../cpu/cpu0/cache/index2/shared_cpu_list | 1 + .../cpu/cpu0/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index2/size | 1 + .../linux-caches/cpu/cpu0/cache/index2/type | 1 + .../linux-caches/cpu/cpu0/cache/index3/level | 1 + .../cpu/cpu0/cache/index3/shared_cpu_list} | 0 .../cpu/cpu0/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index3/size | 1 + .../linux-caches/cpu/cpu0/cache/index3/type | 1 + .../linux-caches/cpu/cpu0/topology/core_id} | 0 .../linux-caches/cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list} | 0 .../cpu/cpu0/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu1/cache/index0/level | 1 + .../cpu/cpu1/cache/index0/shared_cpu_list | 1 + .../cpu/cpu1/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index0/size | 1 + .../linux-caches/cpu/cpu1/cache/index0/type | 1 + .../linux-caches/cpu/cpu1/cache/index1/level | 1 + .../cpu/cpu1/cache/index1/shared_cpu_list | 1 + .../cpu/cpu1/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index1/size | 1 + .../linux-caches/cpu/cpu1/cache/index1/type | 1 + .../linux-caches/cpu/cpu1/cache/index2/level | 1 + .../cpu/cpu1/cache/index2/shared_cpu_list | 1 + .../cpu/cpu1/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index2/size | 1 + .../linux-caches/cpu/cpu1/cache/index2/type | 1 + .../linux-caches/cpu/cpu1/cache/index3/level | 1 + .../cpu/cpu1/cache/index3/shared_cpu_list} | 0 .../cpu/cpu1/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index3/size | 1 + .../linux-caches/cpu/cpu1/cache/index3/type | 1 + .../linux-caches/cpu/cpu1/topology/core_id | 1 + .../linux-caches/cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list} | 0 .../cpu/cpu1/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu2/cache/index0/level | 1 + .../cpu/cpu2/cache/index0/shared_cpu_list | 1 + .../cpu/cpu2/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index0/size | 1 + .../linux-caches/cpu/cpu2/cache/index0/type | 1 + .../linux-caches/cpu/cpu2/cache/index1/level | 1 + .../cpu/cpu2/cache/index1/shared_cpu_list | 1 + .../cpu/cpu2/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index1/size | 1 + .../linux-caches/cpu/cpu2/cache/index1/type | 1 + .../linux-caches/cpu/cpu2/cache/index2/level | 1 + .../cpu/cpu2/cache/index2/shared_cpu_list | 1 + .../cpu/cpu2/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index2/size | 1 + .../linux-caches/cpu/cpu2/cache/index2/type | 1 + .../linux-caches/cpu/cpu2/cache/index3/level | 1 + .../cpu/cpu2/cache/index3/shared_cpu_list} | 0 .../cpu/cpu2/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index3/size | 1 + .../linux-caches/cpu/cpu2/cache/index3/type | 1 + .../linux-caches/cpu/cpu2/topology/core_id | 1 + .../linux-caches/cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list} | 0 .../cpu/cpu2/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu3/cache/index0/level | 1 + .../cpu/cpu3/cache/index0/shared_cpu_list | 1 + .../cpu/cpu3/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index0/size | 1 + .../linux-caches/cpu/cpu3/cache/index0/type | 1 + .../linux-caches/cpu/cpu3/cache/index1/level | 1 + .../cpu/cpu3/cache/index1/shared_cpu_list | 1 + .../cpu/cpu3/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index1/size | 1 + .../linux-caches/cpu/cpu3/cache/index1/type | 1 + .../linux-caches/cpu/cpu3/cache/index2/level | 1 + .../cpu/cpu3/cache/index2/shared_cpu_list | 1 + .../cpu/cpu3/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index2/size | 1 + .../linux-caches/cpu/cpu3/cache/index2/type | 1 + .../linux-caches/cpu/cpu3/cache/index3/level | 1 + .../cpu/cpu3/cache/index3/shared_cpu_list} | 0 .../cpu/cpu3/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index3/size | 1 + .../linux-caches/cpu/cpu3/cache/index3/type | 1 + .../linux-caches/cpu/cpu3/topology/core_id | 1 + .../linux-caches/cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list} | 0 .../cpu/cpu3/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu4/cache/index0/level | 1 + .../cpu/cpu4/cache/index0/shared_cpu_list | 1 + .../cpu/cpu4/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index0/size | 1 + .../linux-caches/cpu/cpu4/cache/index0/type | 1 + .../linux-caches/cpu/cpu4/cache/index1/level | 1 + .../cpu/cpu4/cache/index1/shared_cpu_list | 1 + .../cpu/cpu4/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index1/size | 1 + .../linux-caches/cpu/cpu4/cache/index1/type | 1 + .../linux-caches/cpu/cpu4/cache/index2/level | 1 + .../cpu/cpu4/cache/index2/shared_cpu_list | 1 + .../cpu/cpu4/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index2/size | 1 + .../linux-caches/cpu/cpu4/cache/index2/type | 1 + .../linux-caches/cpu/cpu4/cache/index3/level | 1 + .../cpu/cpu4/cache/index3/shared_cpu_list} | 0 .../cpu/cpu4/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index3/size | 1 + .../linux-caches/cpu/cpu4/cache/index3/type | 1 + .../linux-caches/cpu/cpu4/topology/core_id} | 0 .../linux-caches/cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list} | 0 .../cpu/cpu4/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu5/cache/index0/level | 1 + .../cpu/cpu5/cache/index0/shared_cpu_list | 1 + .../cpu/cpu5/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index0/size | 1 + .../linux-caches/cpu/cpu5/cache/index0/type | 1 + .../linux-caches/cpu/cpu5/cache/index1/level | 1 + .../cpu/cpu5/cache/index1/shared_cpu_list | 1 + .../cpu/cpu5/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index1/size | 1 + .../linux-caches/cpu/cpu5/cache/index1/type | 1 + .../linux-caches/cpu/cpu5/cache/index2/level | 1 + .../cpu/cpu5/cache/index2/shared_cpu_list | 1 + .../cpu/cpu5/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index2/size | 1 + .../linux-caches/cpu/cpu5/cache/index2/type | 1 + .../linux-caches/cpu/cpu5/cache/index3/level | 1 + .../cpu/cpu5/cache/index3/shared_cpu_list} | 0 .../cpu/cpu5/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index3/size | 1 + .../linux-caches/cpu/cpu5/cache/index3/type | 1 + .../linux-caches/cpu/cpu5/topology/core_id | 1 + .../linux-caches/cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list} | 0 .../cpu/cpu5/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu6/cache/index0/level | 1 + .../cpu/cpu6/cache/index0/shared_cpu_list | 1 + .../cpu/cpu6/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index0/size | 1 + .../linux-caches/cpu/cpu6/cache/index0/type | 1 + .../linux-caches/cpu/cpu6/cache/index1/level | 1 + .../cpu/cpu6/cache/index1/shared_cpu_list | 1 + .../cpu/cpu6/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index1/size | 1 + .../linux-caches/cpu/cpu6/cache/index1/type | 1 + .../linux-caches/cpu/cpu6/cache/index2/level | 1 + .../cpu/cpu6/cache/index2/shared_cpu_list | 1 + .../cpu/cpu6/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index2/size | 1 + .../linux-caches/cpu/cpu6/cache/index2/type | 1 + .../linux-caches/cpu/cpu6/cache/index3/level | 1 + .../cpu/cpu6/cache/index3/shared_cpu_list} | 0 .../cpu/cpu6/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index3/size | 1 + .../linux-caches/cpu/cpu6/cache/index3/type | 1 + .../linux-caches/cpu/cpu6/topology/core_id | 1 + .../linux-caches/cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list} | 0 .../cpu/cpu6/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu7/cache/index0/level | 1 + .../cpu/cpu7/cache/index0/shared_cpu_list | 1 + .../cpu/cpu7/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index0/size | 1 + .../linux-caches/cpu/cpu7/cache/index0/type | 1 + .../linux-caches/cpu/cpu7/cache/index1/level | 1 + .../cpu/cpu7/cache/index1/shared_cpu_list | 1 + .../cpu/cpu7/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index1/size | 1 + .../linux-caches/cpu/cpu7/cache/index1/type | 1 + .../linux-caches/cpu/cpu7/cache/index2/level | 1 + .../cpu/cpu7/cache/index2/shared_cpu_list | 1 + .../cpu/cpu7/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index2/size | 1 + .../linux-caches/cpu/cpu7/cache/index2/type | 1 + .../linux-caches/cpu/cpu7/cache/index3/level | 1 + .../cpu/cpu7/cache/index3/shared_cpu_list} | 0 .../cpu/cpu7/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index3/size | 1 + .../linux-caches/cpu/cpu7/cache/index3/type | 1 + .../linux-caches/cpu/cpu7/topology/core_id | 1 + .../linux-caches/cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list} | 0 .../cpu/cpu7/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + tests/vircaps2xmldata/linux-caches/cpu/kernel_max | 1 + .../linux-caches/cpu/online} | 0 .../linux-caches/cpu/present} | 0 tests/vircaps2xmldata/linux-caches/node/node0/cpu0 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu1 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu2 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu3 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu4 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu5 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu6 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu7 | 1 + .../linux-caches/node/node0/cpulist} | 0 .../linux-caches/node/node0/meminfo | 31 ++ .../linux-caches/node/online} | 0 .../linux-caches/node}/possible | 0 tests/vircaps2xmldata/vircaps-aarch64-basic.xml | 64 ++++ tests/vircaps2xmldata/vircaps-basic-4-4-2G.xml | 74 ---- tests/vircaps2xmldata/vircaps-x86_64-basic.xml | 62 +++ tests/vircaps2xmldata/vircaps-x86_64-caches.xml | 33 ++ tests/vircaps2xmltest.c | 133 +++---- .../cpu/offline | 0 .../cpu/possible | 0 tests/virhostcpudata/linux-deconf-cpus/cpu/offline | 1 - .../virhostcpudata/linux-deconf-cpus/cpu/possible | 1 - tests/virhostcpudata/linux-raspberrypi/cpu/offline | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/offline | 1 - tests/virhostcpudata/linux-subcores1/cpu/offline | 1 - tests/virhostcpudata/linux-subcores1/cpu/possible | 1 - tests/virhostcpudata/linux-subcores2/cpu/offline | 1 - tests/virhostcpudata/linux-subcores2/cpu/possible | 1 - tests/virhostcpudata/linux-subcores3/cpu/offline | 1 - tests/virhostcpudata/linux-subcores3/cpu/possible | 1 - tests/virhostcpudata/linux-test1/cpu/online | 1 + tests/virhostcpudata/linux-test1/cpu/present | 1 + tests/virhostcpudata/linux-test2/cpu/online | 1 + tests/virhostcpudata/linux-test2/cpu/present | 1 + tests/virhostcpudata/linux-test3/cpu/online | 1 + tests/virhostcpudata/linux-test3/cpu/present | 1 + tests/virhostcpudata/linux-test4/cpu/online | 1 + tests/virhostcpudata/linux-test4/cpu/present | 1 + tests/virhostcpudata/linux-test5/cpu/online | 1 + tests/virhostcpudata/linux-test5/cpu/present | 1 + tests/virhostcpudata/linux-test6/cpu/online | 1 + .../cpu/possible => linux-test6/cpu/present} | 0 tests/virhostcpudata/linux-test7/cpu/online | 1 + tests/virhostcpudata/linux-test7/cpu/present | 1 + tests/virhostcpudata/linux-test8/cpu/offline | 0 tests/virhostcpudata/linux-test8/cpu/possible | 1 - tests/virhostcputest.c | 9 +- tests/virnumamock.c | 191 ++++++++++ 427 files changed, 1736 insertions(+), 1047 deletions(-) delete mode 100644 src/nodeinfo.c rename src/{fdstream.c => util/virfdstream.c} (99%) rename src/{fdstream.h => util/virfdstream.h} (97%) create mode 100644 src/util/virsysfs.c create mode 100644 src/util/virsysfs.h rename src/{nodeinfo.h => util/virsysfspriv.h} (62%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/thread_siblings copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/thread_siblings_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu1/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu2/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu3/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/online create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/present create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu0 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu1 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu2 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu3 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node0/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu4 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu5 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu6 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu7 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node1/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu10 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu11 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu8 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu9 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node2/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu12 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu13 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu14 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu15 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node3/cpulist create mode 100644 tests/vircaps2xmldata/linux-basic/node/online create mode 100644 tests/vircaps2xmldata/linux-basic/node/possible create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/type copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_siblings rename tests/{virhostcpudata/linux-rhelsa-3.19.0-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/type copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/kernel_max copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/online} (100%) copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/present} (100%) create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu0 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu1 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu2 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu3 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu4 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu5 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu6 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu7 copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/node/node0/cpulist} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/node/node0/meminfo copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/node/online} (100%) rename tests/{virhostcpudata/linux-raspberrypi/cpu => vircaps2xmldata/linux-caches/node}/possible (100%) create mode 100644 tests/vircaps2xmldata/vircaps-aarch64-basic.xml delete mode 100644 tests/vircaps2xmldata/vircaps-basic-4-4-2G.xml create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-basic.xml create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-caches.xml rename tests/virhostcpudata/{linux-f21-mustang => linux-caches1}/cpu/offline (100%) copy tests/virhostcpudata/{linux-f21-mustang => linux-caches1}/cpu/possible (100%) delete mode 100644 tests/virhostcpudata/linux-deconf-cpus/cpu/offline delete mode 100644 tests/virhostcpudata/linux-deconf-cpus/cpu/possible delete mode 100644 tests/virhostcpudata/linux-raspberrypi/cpu/offline delete mode 100644 tests/virhostcpudata/linux-rhelsa-3.19.0-mustang/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores1/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores1/cpu/possible delete mode 100644 tests/virhostcpudata/linux-subcores2/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores2/cpu/possible delete mode 100644 tests/virhostcpudata/linux-subcores3/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores3/cpu/possible create mode 100644 tests/virhostcpudata/linux-test1/cpu/online create mode 100644 tests/virhostcpudata/linux-test1/cpu/present create mode 100644 tests/virhostcpudata/linux-test2/cpu/online create mode 100644 tests/virhostcpudata/linux-test2/cpu/present create mode 100644 tests/virhostcpudata/linux-test3/cpu/online create mode 100644 tests/virhostcpudata/linux-test3/cpu/present create mode 100644 tests/virhostcpudata/linux-test4/cpu/online create mode 100644 tests/virhostcpudata/linux-test4/cpu/present create mode 100644 tests/virhostcpudata/linux-test5/cpu/online create mode 100644 tests/virhostcpudata/linux-test5/cpu/present create mode 100644 tests/virhostcpudata/linux-test6/cpu/online rename tests/virhostcpudata/{linux-f21-mustang/cpu/possible => linux-test6/cpu/present} (100%) create mode 100644 tests/virhostcpudata/linux-test7/cpu/online create mode 100644 tests/virhostcpudata/linux-test7/cpu/present delete mode 100644 tests/virhostcpudata/linux-test8/cpu/offline delete mode 100644 tests/virhostcpudata/linux-test8/cpu/possible create mode 100644 tests/virnumamock.c -- 2.12.0

3 29

[libvirt] Plan for next release
by Daniel Veillard 27 Mar '17

27 Mar '17

Hi all, if we want to release around the end of the month, I think we need to enter freeze on Monday end of day (for me europe) to try to get the release around the next week-end. I assume that work for everyone, if not please tell :-) Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 2

[libvirt] [PATCH] Fix build with GCC's static analysis
by Martin Kletzander 27 Mar '17

27 Mar '17

STREQ_NULLABLE returns true if both parameters are NULL. And that's not what we want here. We just want to skop comparing source nodes that don't have that info set. The function wouldn't make much sense with nodeName == NULL, so we don't need to check that. Moreover, the function's declaration uses ATTRIBUDE_NONNULL for nodeName, which not only means that function expects the parameter not to be NULL, but actually tells the compiler that it can optimize out the NULL checks. That way it could end up calling strcmp on NULL (either nodeformat or nodebacking). GCC figures this out if libvirt is compiled with lv_cv_static_analysis=yes, unfortunately not everyone uses that. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/util/virstoragefile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 3bcb69bf6206..0ac707962102 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -3809,8 +3809,8 @@ virStorageSourceFindByNodeName(virStorageSourcePtr top, *index = 0; for (tmp = top; tmp; tmp = tmp->backingStore) { - if (STREQ_NULLABLE(tmp->nodeformat, nodeName) || - STREQ_NULLABLE(tmp->nodebacking, nodeName)) + if ((tmp->nodeformat && STREQ(tmp->nodeformat, nodeName)) || + (tmp->nodebacking && STREQ(tmp->nodebacking, nodeName))) return tmp; if (index) -- 2.12.1

3 4

[libvirt] [PATCH v2 00/11] Fix saving/setting/restoring SR-IOV VF MAC address
by Laine Stump 27 Mar '17

27 Mar '17

I pushed the 1st 10 patches of this series. The rest of the series was ACKed as well, except patch 11, which is patch 01/11 in this repost. Michal had asked that the rewrite of the saving/restoring of MAC and vlan tag data use a more sane format for the data file (it has been just an unformatted plaintext file since the beginning, which has always bothered me, but not enough to change it.) The resulting JSON format file is *much* nicer, and will be easier to expand if we ever need to. Patches 2 - 11 were already ACKed and haven't been modified, but feel free to go over them again if you want :-) Laine Stump (11): util: new functions virNetDev(Save|Read|Set)NetConfig() util: use new virNetDev*NetConfig() functions for macvtap setup/teardown util: use new virNetDev*NetConfig() functions for hostdev setup/teardown util: replace virHostdevNetConfigReplace with ...(Save|Set)NetConfig() util: save hostdev network device config before unbinding from host driver util: after hostdev assignment, restore VF MAC address via setting admin MAC util: remove unused functions from virnetdev.c util: if setting admin MAC to 00:00:00:00:00:00 fails, try 02:00:00:00:00:00 util: try *really* hard to set the MAC address of an SRIOV VF util: log all setting of MAC addresses and vlan tags util: rename virHostdevNetConfigRestore() to virHostdevRestoreNetConfig() src/libvirt_private.syms | 7 +- src/util/virhostdev.c | 147 ++++++-- src/util/virnetdev.c | 855 +++++++++++++++++++++++++++++++------------- src/util/virnetdev.h | 29 +- src/util/virnetdevmacvlan.c | 40 ++- 5 files changed, 778 insertions(+), 300 deletions(-) -- 2.9.3

2 12

[libvirt] [PATCH 00/23] Add block write threshold event
by Peter Krempa 27 Mar '17

27 Mar '17

This is another version of the stuff that I've posted here: https://www.redhat.com/archives/libvir-list/2017-February/msg01391.html which was partially based on the very old discussion at https://www.redhat.com/archives/libvir-list/2015-May/msg00580.html This version fixes some of the review feedback that I've got and also fixes all the issues pointed out in the original cover letter since I managed to implement the node name detection in a way suitable for this. The event is useful for mgmt apps using thin-provisioned storage so that they don't have to poll for the disk filling all the time. Peter Krempa (23): qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs util: buffer: Add API to set indentation level to a given value util: storage: Split out useful bits of virStorageFileParseChainIndex util: storage: Add variables for node names into virStorageSource lib: Introduce event for tracking disk backing file write threshold qemu: monitor: Add support for BLOCK_WRITE_THRESHOLD event qemu: domain: Add helper to lookup disk by node name qemu: domain: Add helper to generate indexed backing store names qemu: process: Wire up firing of the VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD event lib: Add API for setting the threshold size for VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD virsh: Implement 'domblkthreshold' command to call virDomainSetBlockThreshold qemu: domain: Add helper to look up disk soruce by the backing store string qemu: implement qemuDomainSetBlockThreshold qemu: capabilities: add capability for query-named-block-nodes qmp cmd qemu: monitor: Add monitor infrastructure for query-named-block-nodes qemu: block: Add code to allow detection of auto-allocated node names tests: qemumonitorjson: Add test case for node name detection code tests: qemumonitorjson: Add long backing chain test case for node name detection tests: qemumonitorjson: Add case for two disks sharing a backing image tests: qemumonitorjson: Add relative image names for node name detection tests: qemumonitorjson: Test node name detection on networked storage qemu: monitor: Extract the top level format node when querying disks qemu: block: Add code to detect node names when necessary daemon/remote.c | 45 + examples/object-events/event-test.c | 19 + include/libvirt/libvirt-domain.h | 36 + src/Makefile.am | 1 + src/conf/domain_event.c | 97 + src/conf/domain_event.h | 15 + src/driver-hypervisor.h | 8 + src/libvirt-domain.c | 51 + src/libvirt_private.syms | 5 + src/libvirt_public.syms | 1 + src/qemu/qemu_block.c | 378 ++++ src/qemu/qemu_block.h | 51 + src/qemu/qemu_blockjob.c | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_domain.c | 102 + src/qemu/qemu_domain.h | 14 + src/qemu/qemu_driver.c | 80 +- src/qemu/qemu_monitor.c | 54 +- src/qemu/qemu_monitor.h | 20 + src/qemu/qemu_monitor_json.c | 91 +- src/qemu/qemu_monitor_json.h | 9 + src/qemu/qemu_process.c | 44 + src/remote/remote_driver.c | 34 + src/remote/remote_protocol.x | 33 +- src/remote_protocol-structs | 16 + src/util/virbuffer.c | 19 + src/util/virbuffer.h | 2 + src/util/virstoragefile.c | 108 +- src/util/virstoragefile.h | 15 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 2 + .../caps_2.6.0-gicv2.aarch64.xml | 2 + .../caps_2.6.0-gicv3.aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 2 + .../qemumonitorjson-nodename-1.json | 268 +++ .../qemumonitorjson-nodename-1.result | 15 + .../qemumonitorjson-nodename-2.json | 2270 ++++++++++++++++++++ .../qemumonitorjson-nodename-2.result | 60 + .../qemumonitorjson-nodename-gluster.json | 135 ++ .../qemumonitorjson-nodename-gluster.result | 10 + .../qemumonitorjson-nodename-relative.json | 554 +++++ .../qemumonitorjson-nodename-relative.result | 31 + .../qemumonitorjson-nodename-same-backing.json | 316 +++ .../qemumonitorjson-nodename-same-backing.result | 11 + tests/qemumonitorjsontest.c | 120 ++ tools/virsh-domain.c | 85 + tools/virsh.pod | 8 + 55 files changed, 5243 insertions(+), 19 deletions(-) create mode 100644 src/qemu/qemu_block.c create mode 100644 src/qemu/qemu_block.h create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-1.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-1.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-2.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-2.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing.result -- 2.12.0

2 64

[libvirt] [PATCH] docs: make interface start mode element optional
by Laine Stump 27 Mar '17

27 Mar '17

This brings the libvirt version of this RNG file in line with the same file in netcf (as soon as the corresponding patch there is ACKed and pushed). There's no reason to require it when defining an interface (the config option it corresponds to is optional), and it isn't even output in the status of an interface. Resolves: https://bugzilla.redhat.com/1414404 --- docs/schemas/interface.rng | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/docs/schemas/interface.rng b/docs/schemas/interface.rng index 052703c..4bb08e9 100644 --- a/docs/schemas/interface.rng +++ b/docs/schemas/interface.rng @@ -279,17 +279,19 @@ </define> <define name="startmode"> - <element name="start"> - <attribute name="mode"> - <choice> - <value>onboot</value> - <value>none</value> - <value>hotplug</value> -  - </choice> - </attribute> - </element> + <optional> + <element name="start"> + <attribute name="mode"> + <choice> + <value>onboot</value> + <value>none</value> + <value>hotplug</value> +  + </choice> + </attribute> + </element> + </optional> </define> <!-- -- 2.9.3

2 1

[libvirt] Question about qemuDomainLogContextNew
by Liu Feng 27 Mar '17

27 Mar '17

Hi, Dear all I have a question, and need your help. I want to output some log message to "/var/log/libvirt/qemu/instance-xxxxxx" when guest kernel crashed, so I add following the code: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> static int qemuProcessHandleGuestPanic(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, void *opaque) { ...... + qemuDomainLogContextPtr logCtxt = NULL; + if (!(logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START))){ + VIR_WARN("Unable to open domainlog"); + goto cleanup; + } ...... } <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< But this code cannot get the logCtxt, logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START) always return NULL, so I CANNOT write message to log file. Really Need your help, Thanks! Thanks Feng

3 2

[libvirt] [PATCH] conf: don't ignore <target dev='blah'/> for macvtap interfaces
by Laine Stump 27 Mar '17

27 Mar '17

The parser had been clearing out *all* suggested device names for type='direct' (aka macvtap) interfaces. All of the code implementing macvtap allows for a user-specified device name, so we should allow it. In the case that an interface name starts with "macvtap" or "macvlan" though, we do still clear it out, just as we do with "vnet" (which is the prefix used for automatically generated tap device names), since those are the prefixes for the names we autogenerate for macvtap and macvlan devices. Resolves: https://bugzilla.redhat.com/1335798 --- docs/formatdomain.html.in | 6 +++--- src/conf/domain_conf.c | 6 +++++- src/conf/domain_conf.h | 4 ++++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 4a3123e..8a2294f 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5125,9 +5125,9 @@ qemu-kvm -net nic,model=? /dev/null If no target is specified, certain hypervisors will automatically generate a name for the created tun device. This name can be manually specified, however the name should not - start with either 'vnet' or 'vif', which are prefixes - reserved by libvirt and certain hypervisors. Manually specified - targets using these prefixes may be ignored. + start with either 'vnet', 'vif', 'macvtap', or 'macvlan', + which are prefixes reserved by libvirt and certain hypervisors. + Manually specified targets using these prefixes may be ignored. diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2139ab0..4b80018 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9826,8 +9826,12 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, def->data.direct.linkdev = dev; dev = NULL; - if (flags & VIR_DOMAIN_DEF_PARSE_INACTIVE) + if (ifname && + flags & VIR_DOMAIN_DEF_PARSE_INACTIVE && + (STRPREFIX(ifname, VIR_NET_GENERATED_MACVTAP_PREFIX) || + STRPREFIX(ifname, VIR_NET_GENERATED_MACVTAP_PREFIX))) { VIR_FREE(ifname); + } break; diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8e6d874..38a15f1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1033,6 +1033,10 @@ struct _virDomainNetDef { * by libvirt, and cannot be used for a persistent network name. */ # define VIR_NET_GENERATED_PREFIX "vnet" +/* except to macvtap/macvlan interfaces, which start with "macv(tap|lan) */ +# define VIR_NET_GENERATED_MACVTAP_PREFIX "macvtap" +# define VIR_NET_GENERATED_MACVLAN_PREFIX "macvlan" + typedef enum { VIR_DOMAIN_CHR_DEVICE_STATE_DEFAULT = 0, VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED, -- 2.9.3

2 1

[libvirt] Question about qemuDomainLogContextNew()
by Feng Feng24 Liu 27 Mar '17

27 Mar '17

Hi, Dear all I have a question, and need your help. 　　I want to output some log message to "/var/log/libvirt/qemu/instance-xxxxxx" when guest kernel crashed, so I add following the code: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> static int qemuProcessHandleGuestPanic(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, void *opaque) { ...... + qemuDomainLogContextPtr logCtxt = NULL; + if (!(logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START))){ + VIR_WARN("Unable to open domainlog"); + goto cleanup; + } ...... } <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< But this code cannot get the logCtxt, logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START) always return NULL, so I CANNOT write message to log file. Really Need your help, Thanks! Thanks Feng

1 0

[libvirt] [PATCH 0/2] Fix possible use-after-free when sending event message
by John Ferlan 27 Mar '17

27 Mar '17

Rework patches/logic most recently posted here: https://www.redhat.com/archives/libvir-list/2017-March/msg00072.html John Ferlan (2): daemon: Rework remoteClientFreeFunc cleanup loops into C macro remote: Fix possible use-after-free when sending event message daemon/remote.c | 158 +++++++++++++++++++------------------------------------- 1 file changed, 52 insertions(+), 106 deletions(-) -- 2.9.3

2 3