- Devel - libvirt List Archives

[libvirt] [PATCH 0/4] news: Add schema validation and tweak few details
by Peter Krempa 29 Mar '17

29 Mar '17

The file caused quite some trouble. Add schema validation so that breakage is kept to a minimum. Peter Krempa (4): tests: schema: Add possibility to validate individual files news: Introduce rules for the schema file and fix offending lines schema: Introduce schema for the news.xml file news: Add template for a <release> section docs/news.xml | 64 +++++++++++++++++++++++++++++++++++--------- docs/schemas/news.rng | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/virschematest.c | 36 ++++++++++++++++++++----- 3 files changed, 153 insertions(+), 20 deletions(-) create mode 100644 docs/schemas/news.rng -- 2.12.1

3 9

[libvirt] [PATCH 0/2] conf: do not steal pointers from the pool source
by Ján Tomko 29 Mar '17

29 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1436400 Ján Tomko (2): schema: do not require name for certain pool types conf: do not steal pointers from the pool source docs/schemas/storagepool.rng | 27 +++++++++++++++++----- src/conf/storage_conf.c | 5 ++-- tests/storagepoolxml2xmlin/pool-logical-noname.xml | 18 +++++++++++++++ .../storagepoolxml2xmlout/pool-logical-noname.xml | 19 +++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + 5 files changed, 62 insertions(+), 8 deletions(-) create mode 100644 tests/storagepoolxml2xmlin/pool-logical-noname.xml create mode 100644 tests/storagepoolxml2xmlout/pool-logical-noname.xml -- 2.10.2

2 4

[libvirt] [PATCH] storage: Fix build on i686
by Jiri Denemark 28 Mar '17

28 Mar '17

off_t is signed and it's size is the same as long only on 64b archs. Thus it cannot be formatted as %lu. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/storage/storage_backend_logical.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 9ca6fd43b..d87aaf0b6 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -116,9 +116,9 @@ virStorageBackendLogicalInitializeDevice(const char *path) if (size < 4 * PV_BLANK_SECTOR_SIZE) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, - _("cannot initialize '%s' detected size='%lu' less " + _("cannot initialize '%s' detected size='%zd' less " "than minimum required='%d"), - path, size, 4 * PV_BLANK_SECTOR_SIZE); + path, (ssize_t) size, 4 * PV_BLANK_SECTOR_SIZE); goto cleanup; } if ((size = lseek(fd, 0, SEEK_SET)) == (off_t)-1) { -- 2.12.2

2 1

[libvirt] [PATCHv2 0/2] Restore logical pool functionality
by Ján Tomko 28 Mar '17

28 Mar '17

John Ferlan (1): storage: Better describe logical pool creation/definition parameters Ján Tomko (1): Revert "storage: Better describe logical pool creation/definition parameters" src/conf/storage_conf.c | 8 -------- tools/virsh.pod | 7 +++---- 2 files changed, 3 insertions(+), 12 deletions(-) -- 2.10.2

2 3

[libvirt] [PATCH] news: Fix typo in element name
by Jiri Denemark 28 Mar '17

28 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Oops, pushed as trivial. We really need a schema for news.xml... docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 85a1d4d97..17186b954 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -72,7 +72,7 @@ introducing a new host device type in the XML. </description> </change> - <changes> + <change> <summary> qemu: Add support for setting TSC frequency </summary> @@ -80,7 +80,7 @@ Setting TSC frequency is required to enable migration for domains with 'invtsc' CPU feature turned on. </description> - </changes> + </change> </section> <section title="Improvements"> <change> -- 2.12.2

2 1

[libvirt] [PATCH v2 0/7] Memory locking fixes
by Andrea Bolognani 28 Mar '17

28 Mar '17

Changes from [v1]: * exit early from the loop in patch 2; * dropped patch 5/8, as it's no longer needed; * rewrote tests not to generate QEMU command line; * changed documentation slightly. [v1] https://www.redhat.com/archives/libvir-list/2017-March/msg01089.html Andrea Bolognani (7): Revert "qemu: Forbid <memoryBacking><locked> without <memtune><hard_limit>" qemu: Remove qemuDomainRequiresMemLock() qemu: Fix memory locking limit calculation process: Translate "unlimited" correctly tests: Introduce virTestCompareToULL() tests: Introduce QEMU memory locking limit tests docs: Improve documentation related to memory locking docs/formatdomain.html.in | 39 ++++-- src/qemu/qemu_command.c | 4 +- src/qemu/qemu_domain.c | 76 ++++------ src/qemu/qemu_domain.h | 1 - src/util/virprocess.c | 20 ++- tests/Makefile.am | 9 ++ .../qemumemlock-pc-hardlimit+hostdev.xml | 20 +++ .../qemumemlock-pc-hardlimit+locked+hostdev.xml | 23 ++++ .../qemumemlock-pc-hardlimit+locked.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pc-hostdev.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pc-kvm.xml | 11 ++ .../qemumemlock-pc-locked+hostdev.xml | 20 +++ tests/qemumemlockdata/qemumemlock-pc-locked.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pc-tcg.xml | 11 ++ .../qemumemlock-pseries-hardlimit+hostdev.xml | 20 +++ ...emumemlock-pseries-hardlimit+locked+hostdev.xml | 23 ++++ .../qemumemlock-pseries-hardlimit+locked.xml | 17 +++ .../qemumemlock-pseries-hardlimit.xml | 14 ++ .../qemumemlock-pseries-hostdev.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pseries-kvm.xml | 11 ++ .../qemumemlock-pseries-locked+hostdev.xml | 20 +++ .../qemumemlockdata/qemumemlock-pseries-locked.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pseries-tcg.xml | 11 ++ tests/qemumemlocktest.c | 153 +++++++++++++++++++++ tests/qemuxml2argvdata/qemuxml2argv-mlock-on.xml | 3 - tests/testutils.c | 27 ++++ tests/testutils.h | 2 + 28 files changed, 556 insertions(+), 72 deletions(-) create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-kvm.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-tcg.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-kvm.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-tcg.xml create mode 100644 tests/qemumemlocktest.c -- 2.7.4

2 11

[libvirt] [PATCH] Revert "storage: Better describe logical pool creation/definition parameters"
by Ján Tomko 28 Mar '17

28 Mar '17

This reverts commit ca4515d2639057020c749470f390fe1f5981e91e which broke the functionality of logical storage pools not named after their volume groups. --- src/conf/storage_conf.c | 8 -------- tools/virsh.pod | 7 ------- 2 files changed, 15 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 5213503..585ca71 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -760,14 +760,6 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (VIR_STRDUP(ret->source.name, ret->name) < 0) goto error; } - if (ret->type == VIR_STORAGE_POOL_LOGICAL && - STRNEQ(ret->name, ret->source.name)) { - virReportError(VIR_ERR_XML_ERROR, - _("for a logical pool, the pool name='%s' " - "must match the pool source name='%s'"), - ret->name, ret->source.name); - goto error; - } } if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) && diff --git a/tools/virsh.pod b/tools/virsh.pod index 55b71a9..43124ba 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3639,13 +3639,6 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. -For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>] -must match the Volume Group name for which the pool is being defined or -created. The [I<--source-name>] if provided must match the Volume Group -name. If not provided, one will be generated using the [I<--name>]. If -provided the [I<--target>] is ignored and a target source is generated -using the [I<--source-name>] (or as generated from the [I<--name>]). - =item B<pool-define> I<file> Define an inactive persistent storage pool or modify an existing persistent one -- 2.10.2

3 2

[libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev
by Martin Kletzander 28 Mar '17

28 Mar '17

Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with lv_cv_static_analysis=yes. Caused by a4a39d90ab4930750bcbcfccffdf6bb6d310b5d5 --- src/util/virhostdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 2c557f5bbc6b..998df5871539 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -2060,8 +2060,8 @@ virHostdevReAttachMediatedDevices(virHostdevManagerPtr mgr, continue; virMediatedDeviceGetUsedBy(tmp, &used_by_drvname, &used_by_domname); - if (STREQ_NULLABLE(drv_name, used_by_drvname) && - STREQ_NULLABLE(dom_name, used_by_domname)) { + if (used_by_drvname && STREQ(drv_name, used_by_drvname) && + used_by_domname && STREQ(dom_name, used_by_domname)) { VIR_DEBUG("Removing %s dom=%s from activeMediatedHostdevs", mdevsrc->uuidstr, dom_name); virMediatedDeviceListDel(mgr->activeMediatedHostdevs, tmp); -- 2.12.1

3 4

[libvirt] [PATCH v2 0/4] storage: Better describe logical pool creation/definition parameters
by John Ferlan 28 Mar '17

28 Mar '17

v1: https://www.redhat.com/archives/libvir-list/2017-March/msg01227.html changes since v1: Split things part - added news article John Ferlan (4): conf: Set defaultFormat if no storage source XML present virsh.pod: Move the positional --print-xml for pool-{define|create}-as storage: Better describe logical pool creation/definition parameters docs: Add news article for logical pool-create-as docs/news.xml | 5 +++++ src/conf/storage_conf.c | 11 +++++++++++ tools/virsh.pod | 15 +++++++++++---- 3 files changed, 27 insertions(+), 4 deletions(-) -- 2.9.3

4 10

[libvirt] [PATCH] storage: Better describe logical pool creation/definition parameters
by John Ferlan 28 Mar '17

28 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1398087 Clean up the virsh man page description for --pool-create-as in order to better describe how the various arguments are used when creating (or defining) a logical pool. Also move the --print-xml to the end of the qualifiers since it's not properly positionally situated for both --pool-create-as and --pool-define-as. Finally modify the storage pool XML parsing algorithm to check for the mismatched "name" and "source-name" as well as a more general if not provided, then set the default source format. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/conf/storage_conf.c | 11 +++++++++++ tools/virsh.pod | 15 +++++++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 6b34cea..6ca4949 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -703,6 +703,9 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (virStoragePoolDefParseSource(ctxt, &ret->source, ret->type, source_node) < 0) goto error; + } else { + if (options->formatFromString) + ret->source.format = options->defaultFormat; } ret->name = virXPathString("string(./name)", ctxt); @@ -757,6 +760,14 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (VIR_STRDUP(ret->source.name, ret->name) < 0) goto error; } + if (ret->type == VIR_STORAGE_POOL_LOGICAL && + STRNEQ(ret->name, ret->source.name)) { + virReportError(VIR_ERR_XML_ERROR, + _("for a logical pool, the pool name='%s' " + "must match the pool source name='%s'"), + ret->name, ret->source.name); + goto error; + } } if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) && diff --git a/tools/virsh.pod b/tools/virsh.pod index ee79046..a1b4086 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3572,13 +3572,13 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. -=item B<pool-create-as> I<name> I<type> [I<--print-xml>] +=item B<pool-create-as> I<name> I<type> [I<--source-host hostname>] [I<--source-path path>] [I<--source-dev path>] [I<--source-name name>] [I<--target path>] [I<--source-format format>] [I<--auth-type authtype> I<--auth-username username> I<--secret-usage usage>] [[I<--adapter-name name>] | [I<--adapter-wwnn> I<--adapter-wwpn>] [I<--adapter-parent parent>]] -[I<--build>] [[I<--overwrite>] | [I<--no-overwrite>]] +[I<--build>] [[I<--overwrite>] | [I<--no-overwrite>]] [I<--print-xml>] Create and start a pool object I<name> from the raw parameters. If @@ -3628,17 +3628,24 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. +For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>] +must match the Volume Group name for which the pool is being defined or +created. The [I<--source-name>] if provided must match the Volume Group +name. If not provided, one will be generated using the [I<--name>]. If +provided the [I<--target>] is ignored and a target source is generated +using the [I<--source-name>] (or as generated from the [I<--name>]). + =item B<pool-define> I<file> Define an inactive persistent storage pool or modify an existing persistent one from the XML I<file>. -=item B<pool-define-as> I<name> I<type> [I<--print-xml>] +=item B<pool-define-as> I<name> I<type> [I<--source-host hostname>] [I<--source-path path>] [I<--source-dev path>] [I<--source-name name>] [I<--target path>] [I<--source-format format>] [I<--auth-type authtype> I<--auth-username username> I<--secret-usage usage>] [[I<--adapter-name name>] | [I<--adapter-wwnn> I<--adapter-wwpn>] -[I<--adapter-parent parent>]] +[I<--adapter-parent parent>]] [I<--print-xml>] Create, but do not start, a pool object I<name> from the raw parameters. If I<--print-xml> is specified, then print the XML of the pool object -- 2.9.3

3 4