- Devel - libvirt List Archives

[libvirt] [PATCH] news: Move recent bug fixes into 3.2.0 release
by Jiri Denemark 28 Mar '17

28 Mar '17

Commits 29f7b5ea6a and 5edf9aaf54 pushed them incorrectly at the end of the file in the bug fixes section for libvirt 2.5.0. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as trivial. docs/news.xml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 494c6489b..85a1d4d97 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -120,7 +120,17 @@ zero out pages for qemu. The timeout is now flexible and computed by libvirt at domain startup. </description> - </change> + </change> + <change> + <summary> + Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device + </summary> + </change> + <change> + <summary> + Describe the logical backend requirements better for pool-create-as + </summary> + </change> </section> </release> <release version="v3.1.0" date="2017-03-03"> @@ -704,16 +714,6 @@ Fix compilation on macOS </summary> </change> - <change> - <summary> - Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device - </summary> - </change> - <change> - <summary> - Describe the logical backend requirements better for pool-create-as - </summary> - </change> </section> </release> </libvirt> -- 2.12.0

1 0

[libvirt] [PATCH 0/2] build: Fix build on mingw
by Martin Kletzander 28 Mar '17

28 Mar '17

Fixes pushed under build-breaker rule. Martin Kletzander (2): Use stub for virNetDevGetName on mingw Build vircaps2xmltest and requirements only on Linux configure.ac | 7 ++++--- src/util/virnetdev.c | 10 ++++++++++ tests/Makefile.am | 17 ++++++++++------- tests/vircaps2xmltest.c | 16 ++-------------- 4 files changed, 26 insertions(+), 24 deletions(-) -- 2.12.2

1 2

[libvirt] [PATCH 0/4] Start refactoring migration cookies
by Jiri Denemark 28 Mar '17

28 Mar '17

This series is a first step in refactoring migration cookies. The rest will take some time until it's done, but I figured the part which moves the code is very fragile and I don't really want to keep rebasing it until the refactoring is finished. Jiri Denemark (4): qemu: Move migration cookies to a separate file qemu: Fix formatting in qemu_migration_cookie.c qemu: Typedef migration cookie enums qemu: Free persistent def inside qemuMigrationCookieFree po/POTFILES.in | 1 + src/Makefile.am | 1 + src/qemu/qemu_migration.c | 1425 +------------------------------------- src/qemu/qemu_migration_cookie.c | 1348 ++++++++++++++++++++++++++++++++++++ src/qemu/qemu_migration_cookie.h | 153 ++++ 5 files changed, 1512 insertions(+), 1416 deletions(-) create mode 100644 src/qemu/qemu_migration_cookie.c create mode 100644 src/qemu/qemu_migration_cookie.h -- 2.12.1

2 6

[libvirt] [PATCH] news: Add support for setting TSC frequency
by Jiri Denemark 28 Mar '17

28 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/news.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index a77279948..3f3821a16 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -72,6 +72,15 @@ introducing a new host device type in the XML. </description> </change> + <changes> + <summary> + qemu: Add support for setting TSC frequency + </summary> + <description> + Setting TSC frequency is required to enable migration for domains + with 'invtsc' CPU feature turned on. + </description> + </changes> </section> <section title="Improvements"> <change> -- 2.12.0

2 1

[libvirt] [PATCH 0/4] qemu: Add support for setting TSC frequency to enable migration with invtsc
by Jiri Denemark 28 Mar '17

28 Mar '17

QEMU allows for TSC frequency to be explicitly set to enable migration with invtsc (migration fails if the destination QEMU cannot set the exact same frequency used when starting the domain on the source host). Jiri Denemark (4): conf: Fix XML parser for timer frequency qemu: Add support for setting TSC frequency qemu: Use virCPUCheckFeature in qemuMigrationIsAllowed qemu: Allow migration with invtsc if tsc frequency is set src/conf/domain_conf.c | 2 +- src/qemu/qemu_command.c | 16 ++++++---- src/qemu/qemu_migration.c | 28 +++++++++++------ .../qemuxml2argv-cpu-tsc-frequency.args | 23 ++++++++++++++ .../qemuxml2argv-cpu-tsc-frequency.xml | 35 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 6 files changed, 89 insertions(+), 16 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-tsc-frequency.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-tsc-frequency.xml -- 2.12.1

2 6

[libvirt] [PATCH v2] virmdev: fix build on non-Linux
by Roman Bogorodskiy 28 Mar '17

28 Mar '17

- Make virMediatedDeviceNew() stub args match its prototype - Fix typo: virRerportError -> virReportError - Move MDEV_SYSFS_DEVICES definition out of the #ifdef __linux__ block so we don't have to stub virMediatedDeviceGetSysfsPath() --- Changes from v1: instead of adding a stub for virMediatedDeviceGetSysfsPath(), just unconditionally define MDEV_SYSFS_DEVICES as it makes things easier for the tests. src/util/virmdev.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index e924af3c1..2a1ade739 100644 --- a/src/util/virmdev.c +++ b/src/util/virmdev.c @@ -28,6 +28,8 @@ #define VIR_FROM_THIS VIR_FROM_NONE +#define MDEV_SYSFS_DEVICES "/sys/bus/mdev/devices/" + VIR_LOG_INIT("util.mdev"); struct _virMediatedDevice { @@ -68,7 +70,6 @@ virMediatedOnceInit(void) VIR_ONCE_GLOBAL_INIT(virMediated) #ifdef __linux__ -# define MDEV_SYSFS_DEVICES "/sys/bus/mdev/devices/" static int virMediatedDeviceGetSysfsDeviceAPI(virMediatedDevicePtr dev, @@ -173,12 +174,12 @@ virMediatedDeviceNew(const char *uuidstr, virMediatedDeviceModelType model) #else virMediatedDevicePtr -virMediatedDeviceNew(virPCIDeviceAddressPtr pciaddr ATTRIBUTE_UNUSED, - const char *uuidstr ATTRIBUTE_UNUSED) +virMediatedDeviceNew(const char *uuidstr ATTRIBUTE_UNUSED, + virMediatedDeviceModelType model ATTRIBUTE_UNUSED) { - virRerportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("mediated devices are not supported on non-linux " - "platforms")); + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("mediated devices are not supported on non-linux " + "platforms")); return NULL; } -- 2.11.0

1 1

[libvirt] [PATCH] util: Fix build on FreeBSD
by Jiri Denemark 28 Mar '17

28 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as a trivial build-braker. src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 598d1c61a..486fe4cd1 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, ret = 0; cleanup: - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, ret < 0 ? "Fail" : "Success"); VIR_FORCE_CLOSE(s); -- 2.12.0

2 3

[libvirt] [PATCH] netdev: fix build on non-Linux
by Roman Bogorodskiy 28 Mar '17

28 Mar '17

Fix some typos in the source code: - Missplaced ")", - virNetDevVLanPtr -> virNetDevVlanPtr --- I'm NOT pushing that under the build breaker rule right now because I also have some other build failures and syntax-checking failing, so I cannot do a complete test build. src/util/virnetdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 598d1c61a..47e2b20d5 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, ret = 0; cleanup: - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, ret < 0 ? "Fail" : "Success"); VIR_FORCE_CLOSE(s); @@ -2336,7 +2336,7 @@ virNetDevReadNetConfig(const char *linkdev ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, const char *stateDir ATTRIBUTE_UNUSED, virMacAddrPtr *adminMAC ATTRIBUTE_UNUSED, - virNetDevVLanPtr *vlan ATTRIBUTE_UNUSED, + virNetDevVlanPtr *vlan ATTRIBUTE_UNUSED, virMacAddrPtr *MAC ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", -- 2.11.0

3 3

[libvirt] [PATCH] news: Update after recent commits
by Peter Krempa 28 Mar '17

28 Mar '17

Mention the hyperv notifier and the new API to set block thresholds. --- docs/news.xml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 814bd93fd..2dbd2335d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -70,6 +70,20 @@ introducing a new host device type in the XML. </description> </change> + <change> + <summary> + Add support for block device threshold event + </summary> + <description> + When using thin provisioning, management tools need to resize the + disk in certain cases. To avoid having them to poll disk usage + this version introduces an event which will be fired when a given + offset of the storage is written by the hypervisor. Together with the + API it allows registering thresholds for given storage backing + volumes and this event will then notify management if the threshold + is exceeded. Currently only the qemu driver supports this. + </description> + </change> </section> <section title="Improvements"> <change> @@ -94,6 +108,17 @@ applications running on the platform. </description> </change> + <change> + <summary> + Write hyperv crash information into vm log + </summary> + <description> + qemu's implementation of the hyperv panic notifier now reports + information about the crash from the guest os. Libvirt starting from + this version logs the information to the vm log file for possible + debugging. + </description> + </change> </section> <section title="Bug fixes"> <change> -- 2.12.1

2 1

[libvirt] [PATCH 0/2] More simple fixes.
by John Ferlan 28 Mar '17

28 Mar '17

One noted after push w/r/t change in news.xml and the other found after I rebased to current head from recent commit. John Ferlan (2): news: Add <change> lost in merge util: Remove NONNUL from virHostdevReAttachMediatedDevices docs/news.xml | 2 ++ src/util/virhostdev.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.9.3

2 4