- Devel - libvirt List Archives

[libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash
by Luyao Huang 05 Jul '18

05 Jul '18

If the code jump to the cleanup before assagin value to xml pointer, libvirtd may get crashed when try to free an uninitialized pointer. backtrace: 0 0x00007ffff428d59c in free () from /lib64/libc.so.6 1 0x00007ffff721314a in virFree (ptrptr=ptrptr@entry=0x7fffc67f1b00) at util/viralloc.c:582 2 0x00007ffff7345ac4 in virDomainConfNWFilterInstantiate (vmname=<optimized out>, vmuuid=vmuuid@entry=0x7fffc0181ca8 "߉\237\\۔H\262\206z\340\302f\265\233z", net=<optimized out>, ignoreExists=ignoreExists@entry=true) at conf/domain_nwfilter.c:122 3 0x00007fffca5a77f6 in qemuProcessFiltersInstantiate (ignoreExists=true, def=0x7fffc0181ca0) at qemu/qemu_process.c:3028 4 qemuProcessReconnect (opaque=<optimized out>) at qemu/qemu_process.c:7653 5 0x00007ffff72c4895 in virThreadHelper (data=<optimized out>) at util/virthread.c:206 6 0x00007ffff45dcdd5 in start_thread () from /lib64/libpthread.so.0 7 0x00007ffff4305ead in clone () from /lib64/libc.so.6 Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/conf/domain_nwfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_nwfilter.c b/src/conf/domain_nwfilter.c index 948b324..24b5f42 100644 --- a/src/conf/domain_nwfilter.c +++ b/src/conf/domain_nwfilter.c @@ -90,7 +90,7 @@ virDomainConfNWFilterInstantiate(const char *vmname, virConnectPtr conn = virGetConnectNWFilter(); virNWFilterBindingDefPtr def = NULL; virNWFilterBindingPtr binding = NULL; - char *xml; + char *xml = NULL; int ret = -1; VIR_DEBUG("vmname=%s portdev=%s filter=%s ignoreExists=%d", -- 1.8.3.1

2 2

[libvirt] [PATCH] virsh.pod: Drop --persistent for detach-device-alias
by Michal Privoznik 05 Jul '18

05 Jul '18

https://bugzilla.redhat.com/show_bug.cgi?id=1598087 The detach-device-alias never supported --persistent argument. Drop it from the man page. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index dc100db9f3..003becb7c3 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3197,7 +3197,7 @@ Note that older versions of virsh used I<--config> as an alias for I<--persistent>. =item B<detach-device-alias> I<domain> I<alias> -[[[I<--live>] [I<--config>] | [I<--current>]] | [I<--persistent>]] +[[[I<--live>] [I<--config>] | [I<--current>]]]] Detach a device with given I<alias> from the I<domain>. -- 2.16.4

1 0

Re: [libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash
by Luyao Huang 05 Jul '18

05 Jul '18

What !! This can not be true :D Okay, looks like that github offline in a short time. BTW, CC libvirt-ci@ maybe better than libvirt-list@ (does this mail-list ever exist ?) BR, Luyao ----- Original Message ----- From: no-reply(a)patchew.org To: famz(a)redhat.com, lhuang(a)redhat.com Cc: libvir-list(a)redhat.com, lhuang(a)redhat.com Sent: Thursday, July 5, 2018 12:43:16 PM Subject: Re: [libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 1530765251-5291-1-git-send-email-lhuang(a)redhat.com Subject: [libvirt] [PATCH] conf: initialize character pointer xml value to avoid random crash === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch time bash -c './autogen.sh && make syntax-check' === TEST SCRIPT END === Updating bcb55ab053bc79561b55d0394490f4b64e0f2d01 fatal: unable to access 'https://github.com/patchew-project/libvirt/': Failed to connect to github.com port 443: Connection timed out error: Could not fetch bcb55ab053bc79561b55d0394490f4b64e0f2d01 Traceback (most recent call last): File "./patchew-cli", line 514, in test_one git_clone_repo(clone, r["repo"], r["head"], logf) File "./patchew-cli", line 48, in git_clone_repo stdout=logf, stderr=logf) File "/usr/lib64/python3.6/subprocess.py", line 291, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['git', 'remote', 'add', '-f', '--mirror=fetch', 'bcb55ab053bc79561b55d0394490f4b64e0f2d01', 'https://github.com/patchew-project/libvirt']' returned non-zero exit status 1. --- Email generated automatically by Patchew [http://patchew.org/] Please send your feedback to patchew-devel(a)redhat.com

1 0

[libvirt] [PATCH] util:Fix with process number and pid file do not match
by Bobo Du 04 Jul '18

04 Jul '18

Bobo Du (1): util:Fix with process number and pid file do not match src/util/virpidfile.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 1.8.3.1

3 3

[libvirt] [PATCH] util:Fix with process number and pid file do not match
by dubo163 04 Jul '18

04 Jul '18

From: dubobo <dubobo(a)didichuxing.com> the libvirtd pid file is not match the os process pid number which is smaller than before. this would be exist if the libvirtd process coredump or the os process was killed which the next pid number is smaller. you can be also edit the pid file to write the longer number than before,then restart the libvirtd service. Signed-off-by: dubobo <dubobo(a)didichuxing.com> --- src/util/virpidfile.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/util/virpidfile.c b/src/util/virpidfile.c index 58ab29f..8b0ff99 100644 --- a/src/util/virpidfile.c +++ b/src/util/virpidfile.c @@ -445,6 +445,12 @@ int virPidFileAcquirePath(const char *path, } snprintf(pidstr, sizeof(pidstr), "%lld", (long long) pid); + if (ftruncate(fd, 0) < 0) { + VIR_FORCE_CLOSE(fd); + return -1; + } + + lseek(fd, 0, SEEK_SET); if (safewrite(fd, pidstr, strlen(pidstr)) < 0) { virReportSystemError(errno, -- 1.8.3.1

4 5

[libvirt] ANNOUNCE: libvirt-dbus 1.2.0 released
by Pavel Hrdina 04 Jul '18

04 Jul '18

I'm happy to announce the release of libvirt-dbus 1.2.0. libvirt-dbus wraps libvirt API to provide high-level object-oriented API better suited for dbus-based applications. You can download it here: https://libvirt.org/sources/dbus/libvirt-dbus-1.2.0.tar.xz * Bug fixes - Properly deregister NodeDevice event callback * Improvements - Allow system access to users in the libvirt group - Switch to xz compression for release archives * Build-system fixes - Fix default polkit rule directory and make it configurable - Fix typo to properly build binaries with PIE Thanks everybody who contributed! Pavel

1 0

[libvirt] [PATCH 0/2] Two almost trivial fixes
by Michal Privoznik 04 Jul '18

04 Jul '18

that I haven't pushed. Michal Privoznik (2): src: Mention DEVICE_REMOVAL_FAILED event in virDomainDetachDeviceAlias docs qemu: Check for guest NUMA nodes properly when validating hugepages src/libvirt-domain.c | 4 +++- src/qemu/qemu_command.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) -- 2.16.4

4 7

[libvirt] [PATCH 0/7] Couple of PR fixes and improvements
by Michal Privoznik 04 Jul '18

04 Jul '18

QEMU implemented event when pr-manager connects to/disconnects from pr-helper process. Also, it implemented query command to learn the pr-manager state on libvirtd restart. Whilst working on patches for this, I've noticed couple of other bugs too. Michal Privoznik (7): qemuProcessStartPRDaemonHook: Try to set NS iff domain was started with one qemuDomainValidateStorageSource: Relax PR validation virStoragePRDefFormat: Suppress path formatting for migratable XML virstoragefile: Introduce virStorageSourceChainGetManagedPRAlias qemu: Wire up PR_MANAGER_STATUS_CHANGED event qemu_monitor: Introduce qemuMonitorJSONGetPRManagerInfo qemu: Fetch pr-helper process info on reconnect src/conf/domain_conf.c | 3 +- src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c | 21 +++---- src/qemu/qemu_monitor.c | 40 ++++++++++++ src/qemu/qemu_monitor.h | 20 ++++++ src/qemu/qemu_monitor_json.c | 113 ++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 4 ++ src/qemu/qemu_process.c | 143 +++++++++++++++++++++++++++++++++++++++++-- src/util/virstoragefile.c | 20 +++++- src/util/virstoragefile.h | 6 +- 10 files changed, 349 insertions(+), 22 deletions(-) -- 2.16.4

3 16

[libvirt] [PATCH] qemuDomainNestedJobAllowed: Allow QEMU_JOB_NONE
by Michal Privoznik 04 Jul '18

04 Jul '18

https://bugzilla.redhat.com/show_bug.cgi?id=1598084 When creating a snapshot with --quiesce an async job is grabbed and just before executing guest fs-freeze command an agent job is grabbed. This is achieved by calling qemuDomainObjBeginJobInternal(job = QEMU_JOB_NONE, agentJob = QEMU_AGENT_JOB_MODIFY); Since there already is an async job set on the domain (by the same thread) qemuDomainNestedJobAllowed(priv, job) is consulted if @job is allowed by job mask. But this function returns false (meaning sync @job is not allowed) which leads to a deadlock. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index a60bca29ca..1b8fb71ba8 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6414,7 +6414,9 @@ qemuDomainObjReleaseAsyncJob(virDomainObjPtr obj) static bool qemuDomainNestedJobAllowed(qemuDomainObjPrivatePtr priv, qemuDomainJob job) { - return !priv->job.asyncJob || (priv->job.mask & JOB_MASK(job)) != 0; + return !priv->job.asyncJob || + job == QEMU_JOB_NONE || + (priv->job.mask & JOB_MASK(job)) != 0; } bool -- 2.16.4

2 1

[libvirt] perl-Sys-Virt docs and linker options
by Olaf Hering 04 Jul '18

04 Jul '18

The docs in libvirt-perl.git refer still to Makefile.PL. In the buildlog I noticed that somehow /usr/local is used, nothing uses the relevant flags from libvirt.pc: cc -shared -L/usr/local/lib64 -fstack-protector -o blib/arch/auto/Sys/Virt/Virt.so lib/Sys/Virt.o -lvirt But even the patch below just appends -L %{_libdir} to that command. Any idea how to suppress -L/usr/local/lib64? It happens to work for me, likely because the toolchain has /usr/lib64 in a default path. Olaf --- Sys-Virt-20180703T160550.57299b4.orig/Build.PL +++ Sys-Virt-20180703T160550.57299b4/Build.PL @@ -24,6 +24,7 @@ die "libvirt >= $libvirtver is required\ my $LIBVIRT_LIBS = `pkg-config --libs libvirt`; my $LIBVIRT_CFLAGS = `pkg-config --cflags libvirt`; +my $LIBVIRT_LIBDIR = `pkg-config --variable=libdir libvirt`; my $GCC_CFLAGS = ""; if ($ENV{TEST_MAINTAINER}) { @@ -76,7 +77,7 @@ my $b = Module::Build->new( 'perl' => '5.8.0', }, extra_compiler_flags => $GCC_CFLAGS . $LIBVIRT_CFLAGS, - extra_linker_flags => $LIBVIRT_LIBS, + extra_linker_flags => "-L" . $LIBVIRT_LIBDIR . $LIBVIRT_LIBS , build_requires => { 'ExtUtils::CBuilder' => 0, 'Sys::Hostname' => 0,

2 1