- Devel - libvirt List Archives

Re: [libvirt] [dbus PATCH] gitignore: add tests/.pytest_cache
by Andrea Bolognani 09 Jul '18

09 Jul '18

[re-adding libvirt-list] On Mon, 2018-07-09 at 09:23 -0400, Anya Harter wrote: > On 07/09/2018 04:34 AM, Andrea Bolognani wrote: > > On Thu, 2018-07-05 at 13:48 -0400, Anya Harter wrote: > > > +/tests/.pytest_cache > > > > When does the directory (or file?) get created? I just ran 'make > > test' but it's not there for me. > > The tests/.pytest_cache/ directory is created when make check is run and > the test suite fails. > > Additionally, a .pytest_cache/ directory is created in the home > directory if ./run tests/<testfile> fails. s/home directory/top-level directory of the project/ ;) > If you want I can give you a patch that breaks the test suite and > creates the directories in the two ways above. No need: I verified the above on my own, and in that light... > > Either way, this looks like it should be a more generic exclude > > pattern like the one we already have for __pycache__ directories > > instead of being limited to tests/. ... this suggestion was spot-on, as adding the pattern you suggested would take care of the failed 'make check' case but not of the failed './run tests/...' case. Looking forward to v2 :) -- Andrea Bolognani / Red Hat / Virtualization

1 0

[libvirt] [PATCH] domain_nwfilter: Return early if net has no name in virDomainConfNWFilterTeardownImpl
by Michal Privoznik 09 Jul '18

09 Jul '18

This function is called from various clean up paths (e.g. from qemuBuildInterfaceCommandLine). However, depending on the stage the interface creation process failed at, net->ifname might still be not filled in when control jumps to cleanup label. If that is the case return early (avoiding useless error message produced in virNWFilterBindingLookupByPortDev) as there is no NWFilter to tear down anyway. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_nwfilter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/domain_nwfilter.c b/src/conf/domain_nwfilter.c index 24b5f42ddd..f39c8a1f9b 100644 --- a/src/conf/domain_nwfilter.c +++ b/src/conf/domain_nwfilter.c @@ -133,6 +133,9 @@ virDomainConfNWFilterTeardownImpl(virConnectPtr conn, { virNWFilterBindingPtr binding; + if (!net->ifname) + return; + binding = virNWFilterBindingLookupByPortDev(conn, net->ifname); if (!binding) return; -- 2.16.4

2 1

[libvirt] [PATCH v2 0/2] qemu: monitor: Use 'target' instead of 'arch' in reply of 'query-cpus-fast'
by Peter Krempa 09 Jul '18

09 Jul '18

Peter Krempa (2): qemu: monitor: Remove qemuMonitorJSONExtractCPUArchInfo wrapper qemu: monitor: Use 'target' instead of 'arch' in reply of 'query-cpus-fast' src/qemu/qemu_monitor_json.c | 31 +++++++++---------------------- 1 file changed, 9 insertions(+), 22 deletions(-) -- 2.16.2

2 4

[libvirt] [PATCH 0/6] Couple of important fixes
by Michal Privoznik 09 Jul '18

09 Jul '18

I think the most important fix is 2/6 as it might touch live user data. Also, I haven't run 'make check-access' in a while. If I did I would have noticed new paths being accessed. I'll try to update white list (in a separate patch set) and hopefully we can then enable by default and threat its errors as fatal. Michal Prívozník (6): qemuBuildSCSIiSCSIHostdevDrvStr: Don't leak @netsource and @srcprops qemuxml2argvtest: Don't spawn session daemon Forget last daemon/ dir artefacts virtestmock: Track connect() too check-file-access: Allow specifying action virtestmock: Track action Makefile.am | 2 +- run.in | 2 +- src/driver.h | 2 +- src/qemu/qemu_command.c | 6 ++--- tests/check-file-access.pl | 32 ++++++++++++++++++---- tests/file_access_whitelist.txt | 15 +++++++---- tests/libvirtd-fail | 4 +-- tests/qemuxml2argvmock.c | 7 +++++ tests/virtestmock.c | 59 ++++++++++++++++++++++++++++++----------- 9 files changed, 95 insertions(+), 34 deletions(-) -- 2.16.4

3 12

[libvirt] [PATCH] qemu: monitor: Note change in output of query-cpus-fast
by Peter Krempa 09 Jul '18

09 Jul '18

We did not use the field that has changed but note it in the code which extracts the data for future reference. Especially since there is an example of the output. https://bugzilla.redhat.com/show_bug.cgi?id=1598829 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_monitor_json.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3e90279b71..41abb920ab 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1645,6 +1645,9 @@ qemuMonitorJSONExtractCPUArchInfo(virJSONValuePtr jsoncpu, * ...}, * {...} * ] + * + * Note that since QEMU 2.13.0 the "arch" output member of the + * "query-cpus-fast" command is replaced by "target". */ static int qemuMonitorJSONExtractCPUInfo(virJSONValuePtr data, -- 2.16.2

2 2

[libvirt] [PATCH 0/2] Adding reflink support for XFS and others.
by Julio Faracco 09 Jul '18

09 Jul '18

This serie add XFS library to use the macro for reflink (clone). This is the case where BTRFS is not available but XFS is. In case of both is unavailable, the code will use FICLONE from filesystem library if it is defined. This implementation is similar to copy command. If you run a copy and trace the syscalls, you will see that ioctl uses BTRFS_IOC_CLONE or FICLONE to create a reflink. Julio Faracco (2): configure: Adding XFS library/headers check. storage: Rename btrfsCloneFile to support other filesystems. configure.ac | 7 +++++++ src/storage/storage_util.c | 20 ++++++++++++++------ 2 files changed, 21 insertions(+), 6 deletions(-) -- 2.17.1

4 6

[libvirt] [dbus PATCH] gitignore: Add trailing slashes to directory patterns
by Andrea Bolognani 09 Jul '18

09 Jul '18

This makes it explicit that they're meant to ignore entire directories rather than single files. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitignore | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index ca9e4e1..45a1eb4 100644 --- a/.gitignore +++ b/.gitignore @@ -7,9 +7,9 @@ *Makefile *Makefile.in *~ -.deps -.libs -__pycache__ +.deps/ +.libs/ +__pycache__/ vgcore.* /AUTHORS -- 2.17.1

1 0

[libvirt] [dbus PATCH] gitignore: add tests/.pytest_cache
by Anya Harter 09 Jul '18

09 Jul '18

Signed-off-by: Anya Harter <aharter(a)redhat.com> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index ca9e4e1..c41c82c 100644 --- a/.gitignore +++ b/.gitignore @@ -44,3 +44,4 @@ vgcore.* /src/org.libvirt.service /tests/test_util +/tests/.pytest_cache -- 2.17.1

2 1

[libvirt] [PATCH python] fix build with older libvirt missing virNWFilterBindingPtr
by Daniel P. Berrangé 09 Jul '18

09 Jul '18

While we correctly disable all public API bindings that rely on virNWFilterBindingPtr, the generator is still creating a helper function that needs it - libvirt_virNWFilterBinding_pointer. Making this helper conditional is a little hairy, so just provide a trivial typedef to keep it happy. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- typewrappers.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/typewrappers.h b/typewrappers.h index 1570c6a..4423774 100644 --- a/typewrappers.h +++ b/typewrappers.h @@ -27,6 +27,10 @@ typedef ssize_t Py_ssize_t; #endif +#if !LIBVIR_CHECK_VERSION(4, 5, 0) +typedef struct _virNWFilterBinding *virNWFilterBindingPtr; +#endif + #define PyvirConnect_Get(v) (((v) == Py_None) ? NULL : \ (((PyvirConnect_Object *)(v))->obj)) -- 2.17.1

1 0

[libvirt] [PATCH] examples: Remove config.h from hellolibvirt and openauth
by Marcos Paulo de Souza 09 Jul '18

09 Jul '18

These two examples do not use any definition from config.h, and by removing it these examples can be compiled standalone. Signed-off-by: Marcos Paulo de Souza <marcos.souza.org(a)gmail.com> --- When trying to remove config.h from domtop and domsuspend, a later inclusion of unistd.h complains about the missing config.h. This unistd.h come from gnulib, so I need more time to check why this header would complain, so for now just these examples are a good start ... examples/hellolibvirt/hellolibvirt.c | 2 -- examples/openauth/openauth.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/examples/hellolibvirt/hellolibvirt.c b/examples/hellolibvirt/hellolibvirt.c index 02c4401987..bfb12846e6 100644 --- a/examples/hellolibvirt/hellolibvirt.c +++ b/examples/hellolibvirt/hellolibvirt.c @@ -2,8 +2,6 @@ * hypervisor and gather a few bits of information about domains. * Similar API's exist for storage pools, networks, and interfaces. */ -#include <config.h> - #include <stdio.h> #include <stdlib.h> #include <libvirt/libvirt.h> diff --git a/examples/openauth/openauth.c b/examples/openauth/openauth.c index eef46d5f52..efd21c374f 100644 --- a/examples/openauth/openauth.c +++ b/examples/openauth/openauth.c @@ -1,8 +1,6 @@ /* This is a copy of the hellolibvirt example demonstaring how to use * virConnectOpenAuth with a custom auth callback */ -#include <config.h> - #include <stdio.h> #include <stdlib.h> #include <string.h> -- 2.17.1

2 1