- Devel - libvirt List Archives

[libvirt] ANNOUNCE: Libvirt TCK release v1.0.0
by Daniel P. Berrangé 11 Jun '18

11 Jun '18

It has been 9 years since the first release of Libvirt TCK, so I'm happy to annonunce a second ever release, with countless accumulated bug fixes and features, is now available from https://libvirt.org/sources/tck/Sys-Virt-TCK-v1.0.0.tar.gz The GPG signature: https://libvirt.org/sources/tck/Sys-Virt-TCK-v1.0.0.tar.gz.asc Is created with my key with a fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) All historical releases are available from: https://libvirt.org/sources/tck/ Changes in this release are: - So many that it is not useful to list them all, please see the GIT history. It is expected to have a 100% pass rate when used with the QEMU driver from current libvirt GIT master, and with 4.4.0 release it should pass everything except some nwfilter tests. The state of the tests wrt other hypervisor drivers is currently an unknown. The intention is that it would work with other drivers, but it has not been tested anytime in recent history. Thanks to everyone who contributed to this new release. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0

[libvirt] [PATCH 0/3] conf: Refactor formatting of <disk>
by Peter Krempa 11 Jun '18

11 Jun '18

Split out various bits from the overly-long functions. Peter Krempa (3): conf: Use virXMLFormatElement to format disk IO tuning conf: Use virXMLFormatElement to format disk 'driver' element conf: Extract formatting of 'mirror' disk sub-element src/conf/domain_conf.c | 321 ++++++++++++++++++++++++++----------------------- 1 file changed, 169 insertions(+), 152 deletions(-) -- 2.16.2

2 6

[libvirt] [PATCH 0/2] Fix a couple of virtio-scsi iothread issues
by John Ferlan 11 Jun '18

11 Jun '18

See the patches for details John Ferlan (2): qemu: Fix error for attach controller config for live guest qemu: Allow no address to be defined for virtio-scsi iothrad attach src/qemu/qemu_domain.c | 7 ++++--- src/qemu/qemu_driver.c | 5 +++-- 2 files changed, 7 insertions(+), 5 deletions(-) -- 2.14.4

3 5

[libvirt] [PATCH 0/2] Share cgroup code that is duplicated between QEMU and LXC
by Fabiano Fidêncio 11 Jun '18

11 Jun '18

virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup() and virLXCCgroupSetupCpuTune() and qemuSetupCpuCgroup() are the most similar functions between QEMU and LXC code. Let's move their common code to virCgroup. Fabiano Fidêncio (2): vircgroup: Add virCgroupSetupBlkiotune() vircgroup: Add virCgroupSetupMemtune() src/libvirt_private.syms | 2 ++ src/lxc/lxc_cgroup.c | 69 ++------------------------------------------ src/qemu/qemu_cgroup.c | 61 ++------------------------------------- src/util/vircgroup.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++ src/util/vircgroup.h | 4 +++ 5 files changed, 85 insertions(+), 125 deletions(-) -- 2.14.3

3 5

[libvirt] [PATCH] virstring: fix a typo
by Chen Hanxiao 11 Jun '18

11 Jun '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> s/glibc's_asprintf/glibc's asprintf Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/util/virstring.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virstring.h b/src/util/virstring.h index fa2ec1df4d..607ae66e99 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -248,7 +248,7 @@ size_t virStringListLength(const char * const *strings); * @strp: variable to hold result (char **) * @fmt: printf format * - * Like glibc's_asprintf but makes sure *strp == NULL on failure, in which case + * Like glibc's asprintf but makes sure *strp == NULL on failure, in which case * the OOM error is reported too. * * Returns -1 on failure (with OOM error reported), number of bytes printed @@ -264,7 +264,7 @@ size_t virStringListLength(const char * const *strings); * @strp: variable to hold result (char **) * @fmt: printf format * - * Like glibc's_asprintf but makes sure *strp == NULL on failure. + * Like glibc's asprintf but makes sure *strp == NULL on failure. * * Returns -1 on failure, number of bytes printed on success. */ -- 2.17.1

2 1

[libvirt] [jenkins-ci PATCH] guests: Install ip and tc for libvirt
by Andrea Bolognani 11 Jun '18

11 Jun '18

They're both pretty much guaranteed to be dragged in by other packages already, but since we're being explicit in the spec file might as well be explicit here too. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 10 ++++++++++ guests/vars/projects/libvirt.yml | 2 ++ 2 files changed, 12 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index af026e1..570e8fb 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -186,6 +186,10 @@ mappings: intltool: default: intltool + ip: + deb: iproute2 + rpm: iproute + iscsiadm: deb: open-iscsi rpm: iscsi-initiator-utils @@ -761,6 +765,12 @@ mappings: sudo: default: sudo + tc: + deb: iproute2 + rpm: iproute-tc + CentOS6: iproute + CentOS7: iproute + unzip: default: unzip FreeBSD: diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index ad42fd5..248a64e 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -13,6 +13,7 @@ packages: - glusterfs - gnutls - hal + - ip - iscsiadm - libacl - libattr @@ -49,6 +50,7 @@ packages: - scrub - sheepdog - showmount + - tc - wireshark - xen - xmllint -- 2.17.1

2 1

[libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions
by Fabiano Fidêncio 11 Jun '18

11 Jun '18

This patchset finishes the conversion to virConfGetValue* functions, started by Daniel Berrange a few months ago. Please, mind that although we could make virConfGetValue* functions more generic in order to support numbers and booleans as strings, that doesn't seem the safest path to take. The side-effect of this is that we will have to live with some specific code doing that as part of vmx and xen_common. Once this patchset gets merged, https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGe… can be removed. - Changes since v1: All the "values" from virConfGetValueString() are freed - Changes since v2: All comments from Ján Tomko have been addressed; A few leaks were (possibly) found and they're addressed in the last patch of the series; Fabiano Fidêncio (7): xen_xm: Split the per-disk logic from xenParseXMDisk() xen_vm: convert to typesafe virConf accessors vmx: convert to typesafe virConf accessors xen_common: Split per-PCI logic from xenParsePCI() xen_common: Split per-Vfi logic from xenParseVif() xen_common: convert to typesafe virConf acessors xen_common: Fix a few memory leaks src/vmx/vmx.c | 194 +++++-------- src/xenconfig/xen_common.c | 701 +++++++++++++++++++++++---------------------- src/xenconfig/xen_xm.c | 306 ++++++++++---------- 3 files changed, 595 insertions(+), 606 deletions(-) -- 2.14.3

2 15

[libvirt] [dbus PATCH] Implement Undefine method for NWFilter Interface
by Katerina Koukiou 11 Jun '18

11 Jun '18

Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com> --- All other NWFilter APIs are merged but I forgot this one as Jano noticed. data/org.libvirt.NWFilter.xml | 4 ++++ src/nwfilter.c | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/data/org.libvirt.NWFilter.xml b/data/org.libvirt.NWFilter.xml index 69e3357..b8aae02 100644 --- a/data/org.libvirt.NWFilter.xml +++ b/data/org.libvirt.NWFilter.xml @@ -19,5 +19,9 @@ <arg name="flags" type="u" direction="in"/> <arg name="xml" type="s" direction="out"/> </method> + <method name="Undefine"> + <annotation name="org.gtk.GDBus.DocString" + value="See https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterUndefine"/> + </method> </interface> </node> diff --git a/src/nwfilter.c b/src/nwfilter.c index acfbdd5..3fc6e12 100644 --- a/src/nwfilter.c +++ b/src/nwfilter.c @@ -92,6 +92,26 @@ virtDBusNWFilterGetXMLDesc(GVariant *inArgs, *outArgs = g_variant_new("(s)", xml); } +static void +virtDBusNWFilterUndefine(GVariant *inArgs G_GNUC_UNUSED, + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath, + gpointer userData, + GVariant **outArgs G_GNUC_UNUSED, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) +{ + virtDBusConnect *connect = userData; + g_autoptr(virNWFilter) nwfilter = NULL; + + nwfilter = virtDBusNWFilterGetVirNWFilter(connect, objectPath, error); + if (!nwfilter) + return; + + if (virNWFilterUndefine(nwfilter) < 0) + virtDBusUtilSetLastVirtError(error); +} + static virtDBusGDBusPropertyTable virtDBusNWFilterPropertyTable[] = { { "Name", virtDBusNWFilterGetName, NULL }, { "UUID", virtDBusNWFilterGetUUID, NULL }, @@ -100,6 +120,7 @@ static virtDBusGDBusPropertyTable virtDBusNWFilterPropertyTable[] = { static virtDBusGDBusMethodTable virtDBusNWFilterMethodTable[] = { { "GetXMLDesc", virtDBusNWFilterGetXMLDesc }, + { "Undefine", virtDBusNWFilterUndefine}, { 0 } }; -- 2.15.0

2 1

[libvirt] [PATCH 00/12] Various apparmor related changes (part )
by Christian Ehrhardt 11 Jun '18

11 Jun '18

Hi, this is a continuation of the ongoing effort to feed back Ubuntu apparmor Delta on libvirt to the community (or to sort out remaining todos or to keep them distro specific). In that it is a follow on to: - https://www.redhat.com/archives/libvir-list/2017-May/msg00630.html - https://www.redhat.com/archives/libvir-list/2017-May/msg00887.html I punted those we had discussions on and decided to rework in the last rounds out of the submission. But in exchange pulled in some more changes we had that are now ready for discussion. That way I prepared the next set of 12 changes which I hereby submit for your consideration into 3.11. Christian Ehrhardt (3): apparmor, libvirt-qemu: add default pki path of lbvirt-spice apparmor, libvirt-qemu: add generic base vfio device apparmor, libvirt-qemu: qemu won't call qemu-nbd Jamie Strandboge (5): apparmor, libvirt-qemu: Allow read access to sysfs system info apparmor, libvirt-qemu: Allow qemu-block-extra libraries apparmor, libvirtd: Allow ixr to /var/lib/libvirt/virtd* apparmor, virt-aa-helper: Allow access to ecryptfs files apparmor, virt-aa-helper: Allow access to /sys/bus/usb/devices Serge Hallyn (3): apparmor, libvirt-qemu: Allow use of sgabios apparmor, libvirt-qemu: Allow read access to max_mem_regions apparmor, libvirt-qemu: Allow access to hugepage mounts Stefan Bader (1): apparmor, libvirt-qemu: Silence lttng related deny messages examples/apparmor/libvirt-qemu | 26 +++++++++++++++++++++++- examples/apparmor/usr.lib.libvirt.virt-aa-helper | 6 ++++++ examples/apparmor/usr.sbin.libvirtd | 4 ++++ 3 files changed, 35 insertions(+), 1 deletion(-) -- 2.7.4

5 56

[libvirt] [PATCH 0/6] Some Coverity patches
by John Ferlan 11 Jun '18

11 Jun '18

Resolve a few things that have built up previous and a couple that are more recent. John Ferlan (6): vbox: Fix resource leak vbox: Fix resource leak qemu: Fix Coverity build for qemu_monitor test: Fix resource leak in qemumonitorjsontest test: Check return status for libxlxml2domconfigtest conf: Check error from virXMLFormatElement call src/conf/domain_conf.c | 3 ++- src/qemu/qemu_monitor.h | 2 +- src/vbox/vbox_common.c | 28 +++++++++++++++------------- tests/libxlxml2domconfigtest.c | 4 +++- tests/qemumonitorjsontest.c | 2 +- 5 files changed, 22 insertions(+), 17 deletions(-) -- 2.14.4

2 7