- Devel - libvirt List Archives

[libvirt] [tck PATCH 0/2] Enable the storage encryption test
by Erik Skultety 02 Jan '20

02 Jan '20

The test was present, but at the time the test was added libvirt (apparently) didn't fully support LUKS encryption with disks. Erik Skultety (2): scripts: qemu: Fix the disk encryption test description scripts: qemu: Enable disk encryption test scripts/qemu/100-disk-encryption.t | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) -- 2.23.0

2 5

[libvirt] [PATCH] maint: update to latest gnulib
by Ján Tomko 02 Jan '20

02 Jan '20

Update to: commit 7d069378921bfa0d7c7198ea177aac0a2440016f Author: Pádraig Brady <P(a)draigBrady.com> CommitDate: 2020-01-01 22:00:28 +0000 md5, sha1, sha256, sha512: support --with-openssl=auto-gpl-compat Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- .gnulib | 2 +- bootstrap | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) Pushed. diff --git a/.gnulib b/.gnulib index 1f6fb368c0..7d06937892 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 1f6fb368c04919243e2c70f2aa514a5f88e95309 +Subproject commit 7d069378921bfa0d7c7198ea177aac0a2440016f diff --git a/bootstrap b/bootstrap index 5b08e7e2d4..70fd73cc74 100755 --- a/bootstrap +++ b/bootstrap @@ -4,7 +4,7 @@ scriptversion=2019-01-04.17; # UTC # Bootstrap this package from checked-out sources. -# Copyright (C) 2003-2019 Free Software Foundation, Inc. +# Copyright (C) 2003-2020 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -166,7 +166,7 @@ bootstrap_epilogue() { :; } # specified directory. Fill in the first %s with the destination # directory and the second with the domain name. po_download_command_format=\ -"wget --mirror --level=1 -nd -q -A.po -P '%s' \ +"wget --mirror --level=1 -nd -nv -A.po -P '%s' \ https://translationproject.org/latest/%s/" # Prefer a non-empty tarname (4th argument of AC_INIT if given), else -- 2.19.2

1 0

[libvirt] [PATCH] storage: Fix volStorageBackendRBDRefreshVolInfo
by Yi Li 24 Dec '19

24 Dec '19

Fix the return value status comparison checking for call to volStorageBackendRBDRefreshVolInfo introduced by commit id f46d137e. we only should fail when the return is < 0. -ENOENT, -ETIMEDOUT will ignore according commit id f46d137e. Signed-off-by: Yi Li <yili(a)winhong.com> --- src/storage/storage_backend_rbd.c | 40 ++++++++++++++++++++++++--------------- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index 7ce26ed..1551cf4 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -411,6 +411,7 @@ volStorageBackendRBDGetFeatures(rbd_image_t image, int r, ret = -1; if ((r = rbd_get_features(image, features)) < 0) { + ret = r; virReportSystemError(-r, _("failed to get the features of RBD image " "%s"), volname); goto cleanup; @@ -427,16 +428,19 @@ volStorageBackendRBDGetFlags(rbd_image_t image, const char *volname, uint64_t *flags) { - int rc; + int r, ret = -1; - if ((rc = rbd_get_flags(image, flags)) < 0) { - virReportSystemError(-rc, + if ((r = rbd_get_flags(image, flags)) < 0) { + ret = r; + virReportSystemError(-r, _("failed to get the flags of RBD image %s"), volname); - return -1; + goto cleanup; } + ret = 0; - return 0; + cleanup: + return ret; } static bool @@ -470,6 +474,7 @@ virStorageBackendRBDSetAllocation(virStorageVolDefPtr vol, if ((r = rbd_diff_iterate2(image, NULL, 0, info->size, 0, 1, &virStorageBackendRBDRefreshVolInfoCb, &allocation)) < 0) { + ret = r; virReportSystemError(-r, _("failed to iterate RBD image '%s'"), vol->name); goto cleanup; @@ -525,24 +530,28 @@ volStorageBackendRBDRefreshVolInfo(virStorageVolDefPtr vol, uint64_t flags; if ((r = rbd_open_read_only(ptr->ioctx, vol->name, &image, NULL)) < 0) { - ret = -r; + ret = r; virReportSystemError(-r, _("failed to open the RBD image '%s'"), vol->name); goto cleanup; } if ((r = rbd_stat(image, &info, sizeof(info))) < 0) { - ret = -r; + ret = r; virReportSystemError(-r, _("failed to stat the RBD image '%s'"), vol->name); goto cleanup; } - if (volStorageBackendRBDGetFeatures(image, vol->name, &features) < 0) + if ((r = volStorageBackendRBDGetFeatures(image, vol->name, &features)) < 0) { + ret = r; goto cleanup; + } - if (volStorageBackendRBDGetFlags(image, vol->name, &flags) < 0) + if ((r = volStorageBackendRBDGetFlags(image, vol->name, &flags)) < 0) { + ret = r; goto cleanup; + } vol->target.capacity = info.size; vol->type = VIR_STORAGE_VOL_NETWORK; @@ -555,8 +564,11 @@ volStorageBackendRBDRefreshVolInfo(virStorageVolDefPtr vol, "Querying for actual allocation", def->source.name, vol->name); - if (virStorageBackendRBDSetAllocation(vol, image, &info) < 0) + if ((r = virStorageBackendRBDSetAllocation(vol, image, &info) < 0)) { + ret = r; goto cleanup; + } + } else { vol->target.allocation = info.obj_size * info.num_objs; } @@ -734,12 +746,10 @@ virStorageBackendRBDRefreshPool(virStoragePoolObjPtr pool) * * Do not error out and simply ignore the volume */ - if (r < 0) { - if (r == -ENOENT || r == -ETIMEDOUT) - continue; - + if (r == -ENOENT || r == -ETIMEDOUT) + continue; + else if (r < 0) goto cleanup; - } if (virStoragePoolObjAddVol(pool, vol) < 0) goto cleanup; -- 2.7.5

3 7

[libvirt] [go-xml PATCH 0/2] Fix libvirt-go-xml test CI
by Cole Robinson 23 Dec '19

23 Dec '19

Patch 1 is a nearby 'fix' Patch 2 fixes the CI for the new address type='unassigned' Cole Robinson (2): Fix virtio-s390 address lookup Support domain address type='unassigned' domain.go | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) -- 2.23.0

2 5

[libvirt] [jenkins-ci PATCH] guests: update FreeBSD to use py37 packages
by Daniel P. Berrangé 23 Dec '19

23 Dec '19

The base python3 package was updated to python 3.7.5, so we must update all the modules to match this version. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index ef4e17a..7b97546 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -160,7 +160,7 @@ mappings: flake8: deb: flake8 - pkg: py36-flake8 + pkg: py37-flake8 rpm: python3-flake8 CentOS7: @@ -824,14 +824,14 @@ mappings: python3-docutils: default: python3-docutils CentOS7: python36-docutils - FreeBSD: py36-docutils + FreeBSD: py37-docutils python3: default: python3 python3-dbus: default: python3-dbus - FreeBSD: py36-dbus + FreeBSD: py37-dbus CentOS7: python36-dbus python3-devel: @@ -843,24 +843,24 @@ mappings: python3-gi: deb: python3-gi - pkg: py36-gobject3 + pkg: py37-gobject3 rpm: python3-gobject CentOS7: python36-gobject python3-libxml2: default: python3-libxml2 - FreeBSD: py36-libxml2 + FreeBSD: py37-libxml2 CentOS7: Ubuntu1604: python3-lxml: default: python3-lxml - FreeBSD: py36-lxml + FreeBSD: py37-lxml CentOS7: python36-lxml python3-nose: default: python3-nose - FreeBSD: py36-nose + FreeBSD: py37-nose CentOS7: python36-nose python3-pip: @@ -871,17 +871,17 @@ mappings: python3-pytest: default: python3-pytest - FreeBSD: py36-pytest + FreeBSD: py37-pytest CentOS7: python36-pytest python3-requests: default: python3-requests - FreeBSD: py36-requests + FreeBSD: py37-requests CentOS7: python36-requests python3-setuptools: default: python3-setuptools - FreeBSD: py36-setuptools + FreeBSD: py37-setuptools qemu-img: default: qemu-utils -- 2.23.0

1 1

[libvirt] [PATCH] docs/auth.html.in: fixed typos
by Andrew Miloradovsky 23 Dec '19

23 Dec '19

Signed-off-by: Andrew Miloradovsky <andrew(a)interpretmath.pw> --- docs/auth.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/auth.html.in b/docs/auth.html.in index 62af43a915..c81c1e58ad 100644 --- a/docs/auth.html.in +++ b/docs/auth.html.in @@ -274,7 +274,7 @@ to turn on SASL auth in these listeners. </p> <p> Since the libvirt SASL config file defaults to using GSSAPI (Kerberos), a -config change is rquired to enable plain password auth. This is done by +config change is required to enable plain password auth. This is done by editting <code>/etc/sasl2/libvirt.conf</code> to set the <code>mech_list</code> parameter to <code>scram-sha-1</code>. </p> @@ -317,7 +317,7 @@ in these scenarios - only the plain TCP listener needs encryption Some operating systems do not install the SASL kerberos plugin by default. It may be necessary to install a sub-package such as <code>cyrus-sasl-gssapi</code>. To check whether the Kerberos plugin is installed run the <code>pluginviewer</code> -program and verify that <code>gssapi</code> is listed,eg: +program and verify that <code>gssapi</code> is listed, e.g.: </p> <pre> # pluginviewer @@ -359,7 +359,7 @@ kadmin.local: quit <p> Any client application wishing to connect to a Kerberos enabled libvirt server merely needs to run <code>kinit</code> to gain a user principal. This may well -be done automatically when a user logs into a desktop session, if PAM is setup +be done automatically when a user logs into a desktop session, if PAM is set up to authenticate against Kerberos. </p> </body> -- 2.24.0

2 1

[libvirt] [PATCH] gconfig: Add GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_QEMU_XHCI
by Felipe Borges 23 Dec '19

23 Dec '19

Modern operating systems support qemu-xhci and that's available since libvirt 3.3.x and qemu 2.9.x Signed-off-by: Felipe Borges <feborges(a)redhat.com> --- libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h b/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h index d593764..3f93d7c 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h @@ -65,7 +65,8 @@ typedef enum { GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_ICH9_UHCI2, GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_ICH9_UHCI3, GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_VT82C686B_UHCI, - GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_PCI_OHCI + GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_PCI_OHCI, + GVIR_CONFIG_DOMAIN_CONTROLLER_USB_MODEL_QEMU_XHCI } GVirConfigDomainControllerUsbModel; GType gvir_config_domain_controller_usb_get_type(void); -- 2.24.1

2 1

[libvirt] [PATCH 0/5] Get rid of "no_memory" labels
by Fabiano Fidêncio 23 Dec '19

23 Dec '19

As pointed out by Ján Tomko, "no_memory seems suspicious in the times of abort()". As libvirt decided to take the path to not report OOM and simply abort when it happens, let's get rid of the no_memory labels and simplify the code around them. The two exceptions are: - phyp code, as libvirt may end up dropping this code entirely; - virfirewall.c code, as it seems we heavily really on firewall->err being set to ENOMEM; If one thinks that virfirewall.c should also be converted, please, shout out and I'll work on that. Fabiano Fidêncio (5): conf: Get rid of "no_memory" labels openvz: Get rid of "no_memory" labels rpc: Get rid of "no_memory" labels util: Get rid of "no_memory" labels vbox: Get rid of "no_memory" labels src/conf/capabilities.c | 16 ++-------- src/conf/domain_audit.c | 40 +++++++------------------ src/openvz/openvz_conf.c | 18 +++++------ src/rpc/virnetclient.c | 42 ++++++++------------------ src/util/virsysinfo.c | 64 +++++++++++++++------------------------- src/util/virsysinfo.h | 2 ++ src/util/viruri.c | 28 +++++++----------- src/vbox/vbox_common.c | 20 +++++-------- 8 files changed, 75 insertions(+), 155 deletions(-) -- 2.24.1

3 7

[libvirt] [PATCH] storage: Fix daemon crash on lookup storagepool by targetpath
by Yi Li 22 Dec '19

22 Dec '19

Causing a crash when storagePoolLookupByTargetPath because of Some types of storage pool have no target elements. Core was generated by `/usr/sbin/libvirtd'. Program terminated with signal 11, Segmentation fault. (gdb) bt 0 0x0000ffff9e951388 in strcmp () from /lib64/libc.so.6 1 0x0000ffff92103e9c in storagePoolLookupByTargetPathCallback ( obj=0xffff7009aab0, opaque=0xffff801058b0) at storage/storage_driver.c:1649 2 0x0000ffff9f2c52a4 in virStoragePoolObjListSearchCb ( payload=0xffff801058b0, name=<optimized out>, opaque=<optimized out>) at conf/virstorageobj.c:476 3 0x0000ffff9f1f2f7c in virHashSearch (ctable=0xffff800f4f60, iter=iter@entry=0xffff9f2c5278 <virStoragePoolObjListSearchCb>, data=data@entry=0xffff95af7488, name=name@entry=0x0) at util/virhash.c:696 4 0x0000ffff9f2c64f0 in virStoragePoolObjListSearch (pools=0xffff800f2ce0, searcher=searcher@entry=0xffff92103e68 <storagePoolLookupByTargetPathCallback>, opaque=<optimized out>) at conf/virstorageobj.c:505 5 0x0000ffff92101f54 in storagePoolLookupByTargetPath (conn=0xffff5c0009f0, path=0xffff7009a850 "/vms/images") at storage/storage_driver.c:1672 Signed-off-by: Yi Li <yili(a)winhong.com> --- src/storage/storage_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index a33328d..5863e1f 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1713,6 +1713,12 @@ storagePoolLookupByTargetPathCallback(virStoragePoolObjPtr obj, return false; def = virStoragePoolObjGetDef(obj); + + /* Some Storage pool types have no Target elements, + * so we should check it. */ + if (def->target.path == NULL) + return false; + return STREQ(path, def->target.path); } -- 2.7.5

2 3

Re: [libvirt] Add support for vhost-user-scsi-pci/vhost-user-blk-pci
by Cole Robinson 22 Dec '19

22 Dec '19

FYI there's some more recent discussion over here: https://www.redhat.com/archives/libvir-list/2019-December/msg00817.html There isn't any objections to using <disk type='vhostuser'/> for vhost-user-blk, so maybe that's a good place to start. Thanks, Cole On 10/15/19 7:34 AM, Li Feng wrote: > Cole Robinson <crobinso(a)redhat.com> 于2019年10月15日周二上午1:48写道： >> >> On 10/14/19 3:12 AM, Li Feng wrote: >>> Hi Cole & Michal, >>> >>> I'm sorry for my late response, I just end my journey today. >>> Thank your response, your suggestion is very helpful to me. >>> >>> I have added Michal in this mail, Michal helps me review my initial patchset. >>> (https://www.spinics.net/linux/fedora/libvir/msg191339.html) >>> >> >> Whoops I missed that posting, I didn't realize you had sent patches! >> >>> All concern about this feature is the XML design. >>> My original XML design exposes more details of Qemu. >>> >>> <vhost-user-blk-pci type='unix'> >>> <source type='bind' path='/tmp/vhost-blk.sock'> >>> <reconnect enabled='yes' timeout='5' /> >>> </source> >>> <queue num='4'/> >>> </vhost-user-blk-pci> >>> >>> As Cole's suggestion, the better design with all vhost-user-scsi/blk >>> features would like this: >>> >>> vhost-user-blk: >>> >>> <disk type='vhostuser' device='disk'> >>> <source type='unix' path='/path/to/vhost-user-blk.sock' mode='client'> >>> <reconnect enabled='yes' timeout='5' /> >>> </source> >>> <target dev='vda' bus='virtio'/> >>> <queue num='4'/> >>> <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> >>> </disk> >>> >>> vhost-user-scsi: >>> >>> <disk type='vhostuser' device='disk'> >>> <source type='unix' path='/path/to/vhost-user-scsi.sock' mode='client'> >>> <reconnect enabled='yes' timeout='5' /> >>> </source> >>> <target dev='sda' bus='scsi'/> >>> <queue num='4'/> >>> </disk> >>> >> >> I think my SCSI idea is wrong, sorry. vhost-user-scsi is for passing a >> scsi host adapter to the VM, correct? If so, then it's not really a >> <disk>, and so using the existing vhost-scsi support in <hostdev> is >> probably better. <hostdev> could possible be used for vhost-user-blk as well >> >> Can you provide some examples of full qemu command lines using >> vhost-user-blk and vhost-user-scsi? Just linking to examples else where >> is fine, but I'm wondering if there's more context > > You could check the vhost-user-scsi/blk examples from SPDK pages: > https://spdk.io/doc/vhost.html > >> >> Internally we already have an abstraction for vhost-scsi: >> >> <hostdev mode='subsystem' type='scsi_host'> >> <source protocol='vhost' wwpn='XXX'/> >> </hostdev> >> >> >> The obvious extension would be >> >> <hostdev mode='subsystem' type='scsi_host'> >> <source protocol='vhostuser' type='unix' >> path='/path/to/vhost-user-scsi.sock' mode='client'/> >> </hostdev> >> >> Internally implementing this will be weird. The <source> parameters are >> only dictated by the hostdev type= field, but in this case they would be >> dictated by the <source protocol=> field, and we would want to reuse the >> internal chardev abstraction. >> >> vhost-user-blk could be implemented similarly, but with type='storage' >> which is the way we pass through block devices to LXC guests, but it >> isn't currently supported in the qemu driver. >> >> I dunno. Maybe Michal or danpb can provide guidance >> > @Michal, @danpb, could you give some guidance? >> >>> Conclusion: >>> 1. Add new type(vhostuser) for disk label; >>> 2. Add queue sub-label for disk to support multiqueue(<queue >>> num='4'/>) or reusing the driver label >>> (<driver name='vhostuser' queues='4'), which one is better? >>> Qemu support multiqueue like this: >>> -device vhost-user-scsi-pci,id=scsi0,chardev=spdk_vhost_scsi0,num_queues=4 >>> -device vhost-user-blk-pci,chardev=spdk_vhost_blk0,num-queues=4 >>> >> >> num-queues is already supported by libvirt for both <disk> and <hostdev> >> with <driver queues=X/>, so whether we use <disk> or <hostdev> you won't >> need to add any new XML here. > Got it. > >> >>> Another question: >>> When qemu is connecting to a vhost-user-scsi controller[1], there may >>> exist multiple LUNs under one target, >>> then one disklabel(<disk/>) will represent multiple SCSI LUNs, >>> the 'dev' property(<target dev='sda' bus='scsi'/>) will be ignored, right? >>> In other words, for vhost-user-scsi disk, it more likes a controller, >>> maybe the controller label is suitable. >>> >> >> Yes you are right, and this was my understanding. But then its not >> really a <controller> in libvirt's sense because we can't attach >> emulated devices to it, so it's more a fit for the existing <hostdev> >> vhost-user support. Unfortunately it's not really a clean fit anywhere, >> there will have to be some kind of compromise. And I'm not sure if >> <disk> or <hostdev> is right for vhost-user-blk, but hopefully others >> have more clear opinions. > > I'm also confused about it. > Thanks for your reply. > > Thanks, > Feng Li > >> >> Thanks, >> Cole >> >>> I look forward to hearing from you as soon as possible. >>> >>> [1]: https://spdk.io/doc/vhost.html >>> >>> Feng Li >>> >>> Cole Robinson <crobinso(a)redhat.com> 于2019年10月10日周四上午6:48写道： >>>> >>>> Sorry for the late reply, and thanks Jano for pointing out elsewhere >>>> that this didn't receive a response. >>>> >>>> On 8/12/19 5:56 AM, Li Feng wrote: >>>>> Hi Guys, >>>>> >>>>> And I want to add the vhost-user-scsi-pci/vhost-user-blk-pci support >>>>> for libvirt. >>>>> >>>>> The usage in qemu like this: >>>>> >>>>> Vhost-SCSI >>>>> -chardev socket,id=char0,path=/var/tmp/vhost.0 >>>>> -device vhost-user-scsi-pci,id=scsi0,chardev=char0 >>>>> Vhost-BLK >>>>> -chardev socket,id=char1,path=/var/tmp/vhost.1 >>>>> -device vhost-user-blk-pci,id=blk0,chardev=char1 >>>>> >>>> >>>> Indeed that matches what I see for the qemu commits too: >>>> >>>> https://git.qemu.org/?p=qemu.git;a=commit;h=00343e4b54b >>>> https://git.qemu.org/?p=qemu.git;a=commit;h=f12c1ebddf7 >>>> >>>>> What type should I add for libvirt. >>>>> Type1: >>>>> <hostdev mode='subsystem' type='vhost-user'> >>>>> <source protocol='vhost-user-scsi' path='/tmp/vhost-scsi.sock'></source> >>>>> <alias name="vhost-user-scsi-disk1"/> >>>>> </hostdev> >>>>> >>>>> >>>>> Type2: >>>>> >>>>> <disk type='network' device='disk'> >>>>> <driver name='qemu' type='raw' cache='none' io='native'/> >>>>> <source protocol='vhost-user' path='/tmp/vhost-scsi.sock'> >>>>> </source> >>>>> <target dev='sdb' bus='vhost-user-scsi'/> >>>>> <boot order='3'/> >>>>> <alias name='scsi0-0-0-1'/> >>>>> <address type='drive' controller='0' bus='0' target='0' unit='1'/> >>>>> </disk> >>>>> >>>>> >>>>> <disk type='network' device='disk'> >>>>> <driver name='qemu' type='raw' cache='none' io='native'/> >>>>> <source protocol='vhost-user' path='/tmp/vhost-blk.sock'> >>>>> </source> >>>>> <target dev='vda' bus='vhost-user-blk'/> >>>>> <boot order='1'/> >>>>> <alias name='virtio-disk0'/> >>>>> <address type='pci' domain='0x0000' bus='0x00' slot='0x07' >>>>> function='0x0'/> >>>>> </disk> >>>>> >>>> >>>> I think wiring this into <disk> makes more sense. <hostdev> is really an >>>> abstraction for assigning a (typically) physical host device to the VM, >>>> so it handles things like hiding a PCI device from the host, and passing >>>> that exact device to the VM. >>>> >>>> In the vhost-user-scsi/blk case, the host device is just a special >>>> process running on the other side of a socket, and the device >>>> represented to the guest is a typical virtio device. So to me it makes >>>> more sense as a <disk> with a <source> that points at that socket. >>>> >>>> target bus=virtio vs bus=scsi is already used to distinguish between >>>> virtio-blk and virtio-scsi, so I think we can keep that bit as is, with >>>> the <address type=drive|pci> to match. We just need to differentiate >>>> between plain virtio and vhost-user >>>> >>>> network devices already have vhostuser support: >>>> >>>> <interface type='vhostuser'> >>>> <source type='unix' path='/tmp/vhost1.sock' mode='server|client'/> >>>> <model type='virtio'/> >>>> </interface> >>>> >>>> Internally that <source> is a virDomainChrSourceDefPtr which is our >>>> internal representation of a chardev. So I think something akin to this >>>> is the way to go. It will likely require updating a LOT of places in the >>>> code that check disk type= field, probably most places that care about >>>> whether type=NETWORK or type=!NETWORK will need to be mirrored for the >>>> new type. >>>> >>>> <disk type='vhostuser' device='disk'> >>>> <source type='unix' path='/path/to/vhost-user-blk.sock' mode='client'/> >>>> <target dev='vda' bus='virtio'/> >>>> </disk> >>>> >>>> <disk type='vhostuser' device='disk'> >>>> <source type='unix' path='/path/to/vhost-user-scsi.sock' mode='client'/> >>>> <target dev='sda' bus='scsi'/> >>>> </disk> >>>> >>>> - Cole >>> >> >> >> - Cole > - Cole

1 0

[libvirt] libvirt API/design questions
by Cole Robinson 22 Dec '19

22 Dec '19

There's some pre-existing libvirt design questions I would like some feedback on, and one new one * `virsh blockresize` doesn't prevent shrink by default, couple users have blown their foot off and there's attempts at patches. https://www.redhat.com/archives/libvir-list/2019-October/msg00258.html https://www.redhat.com/archives/libvir-list/2019-November/msg00843.html Do we implement this as a protection in virsh, or change the API behavior and require a new API flag to allow shrinking? Or some other idea? * vhost-user-scsi and vhost-user-blk XML schema https://www.redhat.com/archives/libvirt-users/2019-October/msg00018.html Last proposal was using <hostdev> for this, which revisiting it now makes more sense than <disk>, because it vhost-user-X doesn't seem to use qemu's block layer at all. So vhost-user-scsi would be: <hostdev mode='subsystem' type='scsi_host'> <source protocol='vhostuser' type='unix' path='/path/to/vhost-user-scsi.sock' mode='client'/> </hostdev> vhost-user-blk maybe requires a new type='block' ? Otherwise it's unclear how to differentiate between the two. Regardless it would be nice to give the original patch author guidance here, they seemed motivated to get this working * Splitting domain_conf up. There's 30k lines in domain_conf.c and 3500 in domain_conf.h, it would be nice to unwind it a bit. Getting some sign off on this ahead of time is critical IMO so pieces can be posted and committed quickly because they will obviously go out of date fast. My thoughts: - domain_def.[ch]: DomainDefXXX and enum definitions. - probably New and Free functions too - domain_parse.[ch]: XML parsing - domain_format.[ch]: XML formatting - domain_validate.[ch]: validate and postparse handling - domain_util.[ch]: everything else, or keep it in domain_conf? domain_def should be easy but no idea how intertwined the rest are. If the domain_validate naming is acceptable for both validate and postparse functions, we could use that naming for qemu_domain.c split too. Also maybe it's worth considering if there's some way to sensibly split the conf/ directory. We could add a top level domain/ directory, but that's kinda ambiguously named as we already have network/ + storage/ + secret/ etc that have different meanings. Maybe sub dirs like conf/domain/ ? I'm curious if anyone has strong feelings either way. There's not really a clear place to dump shared DomainDef code at the moment, like possible domain_cgroup for sharing cgroup handling across lxc + qemu Thanks, Cole

4 5

[libvirt] virsh blockresize syntax is inconsistent with vol-resize and somewhat dangerous
by Tim Small 22 Dec '19

22 Dec '19

Hello, virsh has two commands which can be used to resize block devices - "blockresize" for volumes in use by and active guest, and "vol-resize" for volumes which are not in use. The vol-resize syntax allows to specify the size as a delta (increase or decrease vs. the current size), and also refuses to shrink a volume unless the "--shrink" argument is also passed. Most other tools which can be used for block device resizing (outside of libvirt) also have similar "--shrink" argument requirements when reducing the size of an existing block device. e.g. ceph requires "--allow-shrink" when using the "rbd resize" command. The lack of such a safety device makes "blockresize" a foot-gun (which I recently found to great effect when I typoed the domain name to another valid domain). It seems I am not alone in making this error e.g. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902171 One possible solution would be to make a new command e.g. "domblkresize" or perhaps "live-resize", which implement the "--shrink" and "--delta" behaviour to make it consistent with "vol-resize" syntax, and mark the "blockresize" command as deprecated in the documentation and help (so that existing automation which depends on the current behaviour doesn't break). Any thoughts? Should I open this as an RFE? Thanks, Tim. -- South East Open Source Solutions Limited Registered in England and Wales with company number 06134732. Registered Office: 2 Powell Gardens, Redhill, Surrey, RH1 1TQ VAT number: 900 6633 53 http://seoss.co.uk/ +44-(0)1273-808309

3 3

[libvirt] [PATCH v5 0/5] qemu_process: Glib sponsored cleanup
by Daniel Henrique Barboza 20 Dec '19

20 Dec '19

changes from previous version 4 [1]: - patch 1: * moved 'dev' inside the for loop in qemuProcessHandleBlockThreshold() * moved 'id' inside the 'for' loop in qemuProcessLookupPTYs() * moved 'path' inside both conditionals in qemuProcessBuildDestroyMemoryPaths() * set 'template=NULL' in case g_mkdtemp() succeeds in qemuProcessQMPInit() - patch 2: new patch. add g_autoptr() support for qemuDomainLogContextPtr - patch 3: * using g_autoptr() on feasible virCommandPtr and * qemuDomainLogContextPtr [1] https://www.redhat.com/archives/libvir-list/2019-December/msg01311.html Daniel Henrique Barboza (5): qemu_process.c: use g_autofree qemu_domain.h: add G_DEFINE_AUTOPTR_CLEANUP_FUNC for qemuDomainLogContext qemu_process.c: use g_autoptr() qemu_process.c: remove cleanup labels after g_auto*() changes qemu_process.c: remove 'cleanup' label from qemuProcessCreatePretendCmd() src/qemu/qemu_domain.h | 1 + src/qemu/qemu_process.c | 445 +++++++++++++++------------------------- 2 files changed, 166 insertions(+), 280 deletions(-) -- 2.24.1

2 6

[libvirt] [PATCH v4 0/4] qemu_process: Glib sponsored cleanup
by Daniel Henrique Barboza 20 Dec '19

20 Dec '19

This series got buried a few months ago. Let's go onward unto the 20s with no one left behind. changes from version 3 [1]: - rebased to master at commit 330b556829 - removed former patch 4. The 'g_strdup_printf' change was made along the road - new patch 4: I am sending this one in separate to patch 3 because this unneeded label was already in the code, being unrelated to the changes of this series. The maintainer is welcome to squash it into patch 3. [1] https://www.redhat.com/archives/libvir-list/2019-October/msg01080.html Daniel Henrique Barboza (4): qemu_process.c: use g_autofree qemu_process.c: use g_autoptr() qemu_process.c: remove cleanup labels after g_auto*() changes qemu_process.c: remove 'cleanup' label from qemuProcessCreatePretendCmd() src/qemu/qemu_process.c | 429 +++++++++++++++------------------------- 1 file changed, 157 insertions(+), 272 deletions(-) -- 2.23.0

3 12

[libvirt] [PATCH] schemas: Allow additional qemu cmd line arguments/env variables and qemuCaps to be interleaved
by Michal Privoznik 20 Dec '19

20 Dec '19

While command line arguments are sort of positional (becasue you have to have two entries, one for "-arg" the other for "value"), it doesn't really matter whether env variables come before or after command line arguments. And it matter even less when playing with qemu capabilities. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/schemas/domaincommon.rng | 54 +++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 5f1d4a34a4..b87457382a 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -6295,37 +6295,41 @@ --> <define name="qemucmdline"> <element name="commandline" ns="http://libvirt.org/schemas/domain/qemu/1.0"> - <zeroOrMore> - <element name="arg"> - <attribute name='value'/> - </element> - </zeroOrMore> - <zeroOrMore> - <element name="env"> - <attribute name='name'> - <ref name="filter-param-name"/> - </attribute> - <optional> + <interleave> + <zeroOrMore> + <element name="arg"> <attribute name='value'/> - </optional> - <empty/> - </element> - </zeroOrMore> + </element> + </zeroOrMore> + <zeroOrMore> + <element name="env"> + <attribute name='name'> + <ref name="filter-param-name"/> + </attribute> + <optional> + <attribute name='value'/> + </optional> + <empty/> + </element> + </zeroOrMore> + </interleave> </element> </define> <define name="qemucapabilities"> <element name="capabilities" ns="http://libvirt.org/schemas/domain/qemu/1.0"> - <zeroOrMore> - <element name="add"> - <attribute name="capability"/> - </element> - </zeroOrMore> - <zeroOrMore> - <element name="del"> - <attribute name="capability"/> - </element> - </zeroOrMore> + <interleave> + <zeroOrMore> + <element name="add"> + <attribute name="capability"/> + </element> + </zeroOrMore> + <zeroOrMore> + <element name="del"> + <attribute name="capability"/> + </element> + </zeroOrMore> + </interleave> </element> </define> -- 2.24.1

3 2

[libvirt] [PATCH] util: add note about event file descriptors on Windows
by Daniel P. Berrangé 20 Dec '19

20 Dec '19

When using GNULIB with Winsock, libvirt will never see the normal HANDLE objects, instead GNULIB guarantees that libvirt gets a C runtime file descriptor. The GNULIB poll impl also expects to get C runtime file descriptors rather than HANDLE objects. Document this behaviour so that it is clear to applications providing event loop implementations if they need Windows portability. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- include/libvirt/libvirt-event.h | 4 ++++ src/util/virevent.c | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/include/libvirt/libvirt-event.h b/include/libvirt/libvirt-event.h index 734dbdcbc1..facdc3a3ec 100644 --- a/include/libvirt/libvirt-event.h +++ b/include/libvirt/libvirt-event.h @@ -67,6 +67,10 @@ typedef void (*virEventHandleCallback)(int watch, int fd, int events, void *opaq * listen for specific events. The same file handle can be registered * multiple times provided the requested event sets are non-overlapping * + * @fd will always be a C runtime file descriptor. On Windows + * the _get_osfhandle() method can be used if a HANDLE is required + * instead. + * * If the opaque user data requires free'ing when the handle * is unregistered, then a 2nd callback can be supplied for * this purpose. This callback needs to be invoked from a clean stack. diff --git a/src/util/virevent.c b/src/util/virevent.c index f6c797724e..fd5d8f5bf1 100644 --- a/src/util/virevent.c +++ b/src/util/virevent.c @@ -60,6 +60,13 @@ static virEventRemoveTimeoutFunc removeTimeoutImpl; * requires that an event loop has previously been registered with * virEventRegisterImpl() or virEventRegisterDefaultImpl(). * + * @fd must always always be a C runtime file descriptor. On Windows + * if the caller only has a HANDLE, the _open_osfhandle() method can + * be used to open an associated C runtime file descriptor for use + * with this API. After opening a runtime file descriptor, CloseHandle() + * must not be used, instead close() will close the runtime file + * descriptor and its original associated HANDLE. + * * Returns -1 if the file handle cannot be registered, otherwise a handle * watch number to be used for updating and unregistering for events. */ -- 2.21.0

2 1

[libvirt] [PATCH v2 0/2] Initialize host boot time global var upfront
by Michal Privoznik 20 Dec '19

20 Dec '19

This is a v2 for: https://www.redhat.com/archives/libvir-list/2019-December/msg01045.html While technically v1 was fixed I agree with Cole's suggestion, so I'm discarding v1 and sending another version which implements his suggestion. Michal Prívozník (2): virhostuptime: Introduce virHostBootTimeInit() remote_daemon: Initialize host boot time global variable src/libvirt_private.syms | 1 + src/remote/remote_daemon.c | 9 +++++++++ src/util/virhostuptime.c | 13 ++++++++++++- src/util/virhostuptime.h | 3 +++ 4 files changed, 25 insertions(+), 1 deletion(-) -- 2.24.1

3 4

[libvirt] [PATCH v2 0/3] store binary name in capabilities
by Daniel P. Berrangé 20 Dec '19

20 Dec '19

2 5

[libvirt] [PATCH] news: document phyp removal
by Cole Robinson 20 Dec '19

20 Dec '19

Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/news.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 055353b9a5..1af57f8af0 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -99,6 +99,16 @@ Python 2 binary. Python 3 must be used instead. </description> </change> + <change> + <summary> + 'phyp' Power Hypervisor driver removed + </summary> + <description> + The 'phyp' Power Hypervisor driver has not seen active development + since 2011 and does not seem to have any real world usage. It + has now been removed. + </description> + </change> </section> </release> <release version="v5.10.0" date="2019-12-02"> -- 2.23.0

2 1

[libvirt] i want to update the disk driver from ide to virtio, but fail , why ?
by thomas 20 Dec '19

20 Dec '19

hi, ALL: my question description as follow: virsh dumpxml root-vsys_v2 > v2.xml , in the v2.xml has the following information: <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/home/root-vsys_v2.qcow2'/> <backingStore/> <target dev='hda' bus='ide'/> // i want change the 'ide' to 'virtio', but fail <alias name='ide0-0-0'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> so i create a new xml name v2-new.xml ,it content is: <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/home/root-vsys_v2.qcow2'/> <target dev='vda' bus='virtio'/> </disk> then run: virsh update-device root-vsys_v2 /root/v2-new.xml --live the result is: [root@NSG ~]# virsh update-device root-vsys_v2 /root/v2-new.xml --live error: Failed to update device from /root/v2-new.xml error: internal error: No device with bus 'virtio' and target 'vda' i read the source code for libvirt ,the log outprint at funcion: static int qemuDomainChangeDiskLive(virDomainObjPtr vm, virDomainDeviceDefPtr dev, virQEMUDriverPtr driver, bool force) { virDomainDiskDefPtr disk = dev->data.disk; virDomainDiskDefPtr orig_disk = NULL; virDomainDeviceDef oldDev = { .type = dev->type }; int ret = -1; if (!(orig_disk = virDomainDiskFindByBusAndDst(vm->def, disk->bus, disk->dst))) { virReportError(VIR_ERR_INTERNAL_ERROR, _("No device with bus '%s' and target '%s'"), virDomainDiskBusTypeToString(disk->bus), disk->dst); //the failure log is here, the vm->def has disk item :dev = hda, bus=ide ,and disk->bus = virtio disk->dst=vda, goto cleanup; } //the disk->bus and disk->dst can't in the vm->def ,so the api virDomainDiskFindByBusAndDst failed oldDev.data.disk = orig_disk; if (virDomainDefCompatibleDevice(vm->def, dev, &oldDev, VIR_DOMAIN_DEVICE_ACTION_UPDATE, true) < 0) goto cleanup; if (!qemuDomainDiskChangeSupported(disk, orig_disk)) goto cleanup; if (!virStorageSourceIsSameLocation(disk->src, orig_disk->src)) { /* Disk source can be changed only for removable devices */ if (disk->device != VIR_DOMAIN_DISK_DEVICE_CDROM && disk->device != VIR_DOMAIN_DISK_DEVICE_FLOPPY) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("disk source can be changed only in removable " "drives")); goto cleanup; } if (qemuDomainAttachDeviceDiskLive(driver, vm, dev, force) < 0) goto cleanup; } orig_disk->startupPolicy = dev->data.disk->startupPolicy; orig_disk->snapshot = dev->data.disk->snapshot; ret = 0; cleanup: return ret; } what reason lead the faiure ? is my v2-new.xml write error ? how to write the xml for virsh update-device ? i refer the link https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/ht… -------------------------- thanks ! thosmas.kuang

2 2

[libvirt] [PATCH 0/7] introduce support for an embedded driver mode
by Daniel P. Berrangé 20 Dec '19

20 Dec '19

This is a followup to: https://www.redhat.com/archives/libvir-list/2019-May/msg00467.html This series implements support for an embedded driver mode for libvirt, with initial support in the QEMU and secrets drivers. In this mode of operation, the driver stores all its config and state under a private directory tree. See the individual patches for the illustrated directory hierarchy used. The intent of this embedded mode is to suit cases where the application is using virtualization as a building block for some functionality, as opposed to running traditional "full OS" builds. The long time posterchild example would be libguestfs, while a more recent example could be Kata containers. The general principal in enabling this embedded mode is that the functionality available should be identical to that seen when the driver is running inside libvirtd. This is achieved by loading the exact same driver .so module as libvirtd would load, and simply configuring it with a different directory layout. The result of this is that when running in embedded mode, the driver can still talk to other secondary drivers running inside libvirtd if desired. This is useful, for example, to connect a VM to the default virtual network. The secondary drivers can be made to operate in embedded mode as well, however, this will require some careful consideration for each driver to ensure they don't clash with each other. Thus in this series only the secret driver is enabled for embedded mode. This is required to enable use of VMs with encrypted disks, or authenticated network block storage. In this series we introduce a new command line tool 'virt-qemu-run' which is a really simple tool for launching a VM in embedded mode. I'm not entirely sure whether we should provide this as an official supported tool in this way, or merely put it into the 'examples' directory as demo-ware. With testing of the virt-qemu-run tool we can immediately see what the next important thing to tackle is: performance. We have not really cared too much about the startup performance of libvirtd as this is a one time cost when the mgmt application connects. We did none the less cache capabilities because probing caps for 30 QEMU binaries takes a long time. Even with this caching it takes an unacceptably long time to start a VM in embedded mode. About 100 ms to open the embedded QEMU driver, assuming pre-cached capabilies - ~2 seconds if not cached and all 30 QEMU targets are present. Then about 300 ms to actually start the QEMU guest. IOW, about 400 ms to get QEMU running. NB this is measuring time from launching the virt-run-qemu program, to the point at which the API call 'virDomainCreate' returns control. This has both libvirt & QEMU overhead in & I don't have clear figures to distinguish, but I can see a 40 ms delay between issuing the 'qmp_capabilities' call and getting a reply, which is QEMU startup overead. This is a i440fx based QEMU with a general purpose virtio-pci config (disk, net, etc) tyupical for running a full OS. I've not tried any kind of optimized QEMU config with microvm. I've already started on measuring & optimizing & identified several key areas that can be addressed, but it is all ultimately about not doing work before we need the answers from that work (which often means we will never do the work at all). For example, we shouldn't probe all 30 QEMU's upfront. If the app is only going to create an x86_64 KVM guest we should only care about that 1 QEMU. This is painful because parsing any guest XML requires a virCapsPtr which in turn causes probing of every QEMU binary. I've got in progress patches to eliminate virCapsPtr almost entirely and work directly with the virQEMUCapsPtr instead. It is possible we'll want to use a different file format for storing the cached QEMU capabilities, and the CPU feature/model info. Parsing this XML is a non-negligible time sink. A binary format is likely way quicker, especially if its designed to be just mmap'able for direct read. To be investigated... We shouldn't probe for whether host PM suspend is possible unless someone wants that info, or tries to issue that API call. After starting QEMU we spend 150-200 ms issuing a massive number of qom-get calls to check whether QEMU enabled each individual CPU feature flag. We only need this info if someone asks for the live XML or we intend to live migrate etc. So we shouldn't issue these qom-get calls in the "hot path" of QEMU startup. It can be done later in a non-time critical point. Also the QEMU API for this is horribly inefficient to require so many qom-get calls. There's more but I won't talk about it now. Suffice to say that I think we can get libvirt overhead down to less than 100 ms fairly easily and probably even down to less than 50 ms without much effort. The exact figure will depend on what libvirt features you want enabled, and how much work we want/need to put into optimization. We'll want to fix the really gross mistakes & slow downs, but we'll want guidance from likely users as to their VM startup targets to decide how much work needs investing. This optimization will ultimately help non-embedded QEMU mode too, making it faster to respond & start. Changed in v2: - Use a simplified directory layout for embedded mode. Previously we just put a dir prefix onto the normal paths. This has the downside that the embedded drivers paths are needlessly different for privileged vs unprivileged user. It also results in very long paths which can be a problem for the UNIX socket name length limits. - Also ported the secret driver to support embedded mode - Check to validate that the event loop is registered. - Add virt-qemu-run tool for embedded usage. - Added docs for the qemu & secret driver explaining embedded mode Daniel P. Berrangé (7): access: report an error if no access manager is present libvirt: pass a directory path into drivers for embedded usage event: add API for requiring an event loop impl to be registered libvirt: support an "embed" URI path selector for opening drivers qemu: add support for running QEMU driver in embedded mode secrets: add support for running secret driver in embedded mode qemu: introduce a new "virt-qemu-run" program build-aux/syntax-check.mk | 2 +- docs/drivers.html.in | 1 + docs/drvqemu.html.in | 84 +++++++ docs/drvsecret.html.in | 82 +++++++ libvirt.spec.in | 2 + po/POTFILES.in | 1 + src/Makefile.am | 9 + src/access/viraccessmanager.c | 5 + src/driver-state.h | 2 + src/driver.h | 2 + src/interface/interface_backend_netcf.c | 7 + src/interface/interface_backend_udev.c | 7 + src/libvirt.c | 93 ++++++- src/libvirt_internal.h | 4 +- src/libxl/libxl_driver.c | 7 + src/lxc/lxc_driver.c | 8 + src/network/bridge_driver.c | 7 + src/node_device/node_device_hal.c | 7 + src/node_device/node_device_udev.c | 7 + src/nwfilter/nwfilter_driver.c | 7 + src/qemu/Makefile.inc.am | 26 ++ src/qemu/qemu_conf.c | 38 ++- src/qemu/qemu_conf.h | 6 +- src/qemu/qemu_driver.c | 21 +- src/qemu/qemu_process.c | 15 +- src/qemu/qemu_shim.c | 313 ++++++++++++++++++++++++ src/qemu/qemu_shim.pod | 94 +++++++ src/remote/remote_daemon.c | 1 + src/remote/remote_driver.c | 1 + src/secret/secret_driver.c | 41 +++- src/storage/storage_driver.c | 7 + src/util/virevent.c | 25 ++ src/util/virevent.h | 2 + src/vz/vz_driver.c | 7 + tests/domaincapstest.c | 2 +- tests/testutilsqemu.c | 2 +- 36 files changed, 920 insertions(+), 25 deletions(-) create mode 100644 docs/drvsecret.html.in create mode 100644 src/qemu/qemu_shim.c create mode 100644 src/qemu/qemu_shim.pod -- 2.23.0

3 16

[libvirt] [PATCH 00/42] Cleanups after adopting g_get_*_dir()
by Fabiano Fidêncio 20 Dec '19

20 Dec '19

After adopting g_get_*_dir(), internally, when implementing virGetUser*Dir(), the libvirt functions changed their behaviour as NULL is never ever returned by the GLib functions. Knowing that, let's cleanup the callers' code of those functions, removing the unnecessary checks. While doing the cleanup mentioned above, I've noticed that some other cleanups could be done, when touching the very same function, as using g_autofree. It's done as part of this series as well. phyp driver was not touched as there's some plan to just drop its code entirely: https://www.redhat.com/archives/libvir-list/2019-December/msg01162.html Fabiano Fidêncio (42): tools: Use g_autofree on cmdCd() vbox: Don't leak virGetUserDirectory()'s output rpc: Use g_autofree on virNetClientNewLibSSH2() rpc: Use g_autofree on virNetClientNewLibssh() rpc: Don't check the output of virGetUserDirectory() qemu: Don't check the output of virGetUserDirectory() util: Don't check the output of virGetUserConfigDirectory() storage: Don't check the output of virGetUserConfigDirectory() secret: Don't check the output of virGetUserConfigDirectory() tools: Don't check the output of virGetUserCacheDirectory() vbox: Use g_autofree on vboxDomainScreenshot() vbox: Don't check the output of virGetUserCacheDirectory() util: Use g_autofree on virLogSetDefaultOutputToFile() util: Don't check the output of virGetUserCacheDirectory() qemu: Don't check the output of virGetUserCacheDirectory() rpc: Don't check the output of virGetUserConfigDirectory() remote: Don't check the output of virGetUserConfigDirectory() qemu: Don't check the output of virGetUserConfigDirectory() network: Don't check the output of virGetUserConfigDirectory() logging: Use g_autofree on virLogDaemonConfigFilePath() logging: Don't check the output of virGetUserConfigDirectory() locking: Use g_autofree on virLockDaemonConfigFilePath() locking: Don't check the output of virGetUserConfigDirectory() util: Don't check the output of virGetUserRuntimeDirectory() storage: Don't check the output of virGetUserRuntimeDirectory() secret: Don't check the output of virGetUserRuntimeDirectory() rpc: Don't check the output of virGetUserRuntimeDirectory() remote: Don't check the output of virGetUserRuntimeDirectory() qemu: Don't check the output of virGetUserRuntimeDirectory() node_device: Don't check the output of virGetUserRuntimeDirectory() network: Don't check the output of virGetUserRuntimeDirectory() logging: Use g_autofree on virLogManagerDaemonPath() logging: Use g_autofree on virLogDaemonUnixSocketPaths() logging: Use g_autofree on virLogDaemonExecRestartStatePath() logging: Don't check the output of virGetUserRuntimeDirectory() locking: Use g_autofree on virLockManagerLockDaemonPath() locking: Use g_autofree on virLockDaemonUnixSocketPaths() locking: Use g_autofree on virLockDaemonExecRestartStatePath() locking: Don't check the output of virGetUserRuntimeDirectory() interface: Don't check the output of virGetUserRuntimeDirectory() admin: Use g_autofree on getSocketPath() admin: Don't check the output of virGetUserRuntimeDirectory() src/admin/libvirt-admin.c | 6 +-- src/interface/interface_backend_netcf.c | 3 +- src/interface/interface_backend_udev.c | 3 +- src/locking/lock_daemon.c | 31 +++---------- src/locking/lock_daemon_config.c | 9 +--- src/locking/lock_driver_lockd.c | 7 +-- src/logging/log_daemon.c | 31 +++---------- src/logging/log_daemon_config.c | 9 +--- src/logging/log_manager.c | 7 +-- src/network/bridge_driver.c | 2 - src/node_device/node_device_hal.c | 3 +- src/node_device/node_device_udev.c | 3 +- src/qemu/qemu_conf.c | 7 +-- src/qemu/qemu_interop_config.c | 3 -- src/remote/remote_daemon.c | 8 +--- src/remote/remote_daemon_config.c | 6 +-- src/remote/remote_driver.c | 3 +- src/rpc/virnetclient.c | 59 +++++++++---------------- src/rpc/virnetsocket.c | 3 +- src/rpc/virnettlscontext.c | 12 ----- src/secret/secret_driver.c | 6 +-- src/storage/storage_driver.c | 2 - src/util/virauth.c | 3 +- src/util/virconf.c | 2 - src/util/virhostdev.c | 3 +- src/util/virlog.c | 13 ++---- src/util/virpidfile.c | 3 +- src/vbox/vbox_common.c | 12 ++--- src/vbox/vbox_storage.c | 7 ++- tools/vsh.c | 13 ++---- 30 files changed, 73 insertions(+), 206 deletions(-) -- 2.24.1

5 100

[libvirt] [PATCH] cpu: add CLZERO CPUID support for AMD platforms
by Ani Sinha 20 Dec '19

20 Dec '19

Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR") adds support for CLZERO CPUID bit. This commit extends support for this CPUID bit into libvirt. Signed-off-by: Ani Sinha <ani.sinha(a)nutanix.com> --- src/cpu_map/x86_EPYC-IBPB.xml | 1 + src/cpu_map/x86_EPYC.xml | 1 + src/cpu_map/x86_features.xml | 3 +++ 3 files changed, 5 insertions(+) diff --git a/src/cpu_map/x86_EPYC-IBPB.xml b/src/cpu_map/x86_EPYC-IBPB.xml index 283697e..a70fbd8 100644 --- a/src/cpu_map/x86_EPYC-IBPB.xml +++ b/src/cpu_map/x86_EPYC-IBPB.xml @@ -14,6 +14,7 @@ <feature name='bmi2'/> <feature name='clflush'/> <feature name='clflushopt'/> + <feature name='clzero'/> <feature name='cmov'/> <feature name='cr8legacy'/> <feature name='cx16'/> diff --git a/src/cpu_map/x86_EPYC.xml b/src/cpu_map/x86_EPYC.xml index f060139..6c11d82 100644 --- a/src/cpu_map/x86_EPYC.xml +++ b/src/cpu_map/x86_EPYC.xml @@ -14,6 +14,7 @@ <feature name='bmi2'/> <feature name='clflush'/> <feature name='clflushopt'/> + <feature name='clzero'/> <feature name='cmov'/> <feature name='cr8legacy'/> <feature name='cx16'/> diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 2bed1e0..dd62755 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -473,6 +473,9 @@ <feature name='ibpb'> <cpuid eax_in='0x80000008' ebx='0x00001000'/> </feature> + <feature name='clzero'> + <cpuid eax_in='0x80000008' ebx='0x00000001'/> + </feature> <feature name='amd-ssbd'> <cpuid eax_in='0x80000008' ebx='0x01000000'/> </feature> -- 1.9.4

2 2

[libvirt] [PATCH] AUTHORS: Add Fabiano Fidêncio
by Ján Tomko 19 Dec '19

19 Dec '19

$ git log --committer=fidencio --pretty=oneline | wc -l 12 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Déjà vu from c379576dbc80a66820e256f9ce27595270d95ac2 except the mailmap entry is already set up. AUTHORS.in | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.in b/AUTHORS.in index fbac54c48d..4ed8ceb858 100644 --- a/AUTHORS.in +++ b/AUTHORS.in @@ -19,6 +19,7 @@ Daniel Veillard <veillard(a)redhat.com> Doug Goldstein <cardoe(a)gentoo.org> Eric Blake <eblake(a)redhat.com> Erik Skultety <eskultet(a)redhat.com> +Fabiano Fidêncio <fidencio(a)redhat.com> Gao Feng <gaofeng(a)cn.fujitsu.com> Guido Günther <agx(a)sigxcpu.org> Ján Tomko <jtomko(a)redhat.com> -- 2.21.0

3 2

[libvirt] CfP VHPC20: HPC Containers-Kubernetes
by VHPC 20 19 Dec '19

19 Dec '19

==================================================================== CALL FOR PAPERSa 15th Workshop on Virtualization in High-Performance Cloud Computing (VHPC 20) held in conjunction with the International Supercomputing Conference - High Performance, June 21-25, 2020, Frankfurt, Germany. (Springer LNCS Proceedings) ==================================================================== Date: June 25, 2020 Workshop URL: vhpc[dot]org Abstract registration Deadline: Jan 31st, 2020 Paper Submission Deadline: Apr 05th, 2020 Springer LNCS Call for Papers Containers and virtualization technologies constitute key enabling factors for flexible resource management in modern data centers, and particularly in cloud environments. Cloud providers need to manage complex infrastructures in a seamless fashion to support the highly dynamic and heterogeneous workloads and hosted applications customers deploy. Similarly, HPC environments have been increasingly adopting techniques that enable flexible management of vast computing and networking resources, close to marginal provisioning cost, which is unprecedented in the history of scientific and commercial computing. Most recently, Function as a Service (Faas) and Serverless computing, utilizing lightweight VMs-containers widens the spectrum of applications that can be deployed in a cloud environment, especially in an HPC context. Here, HPC-provided services can be become accessible to distributed workloads outside of large cluster environments. Various virtualization-containerization technologies contribute to the overall picture in different ways: machine virtualization, with its capability to enable consolidation of multiple underutilized servers with heterogeneous software and operating systems (OSes), and its capability to live-migrate a fully operating virtual machine (VM) with a very short downtime, enables novel and dynamic ways to manage physical servers; OS-level virtualization (i.e., containerization), with its capability to isolate multiple user-space environments and to allow for their coexistence within the same OS kernel, promises to provide many of the advantages of machine virtualization with high levels of responsiveness and performance; lastly, unikernels provide for many virtualization benefits with a minimized OS/library surface. I/O Virtualization in turn allows physical network interfaces to take traffic from multiple VMs or containers; network virtualization, with its capability to create logical network overlays that are independent of the underlying physical topology is furthermore enabling virtualization of HPC infrastructures. Publication Accepted papers will be published in a Springer LNCS proceedings volume. Topics of Interest The VHPC program committee solicits original, high-quality submissions related to virtualization across the entire software stack with a special focus on the intersection of HPC, containers-virtualization and the cloud. Major Topics: - HPC workload orchestration (Kubernetes) - Kubernetes HPC batch - HPC Container Environments Landscape - HW Heterogeneity - Container ecosystem (Docker alternatives) - Networking - Lightweight Virtualization - Unikernels / LibOS - State-of-the-art processor virtualization (RISC-V, EPI) - Containerizing HPC Stacks/Apps/Codes: Climate model containers each major topic encompassing design/architecture, management, performance management, modeling and configuration/tooling. Specifically, we invite papers that deal with the following topics: - HPC orchestration (Kubernetes) - Virtualizing Kubernetes for HPC - Deployment paradigms - Multitenancy - Serverless - Declerative data center integration - Network provisioning - Storage - OCI i.a. images - Isolation/security - HW Accelerators, including GPUs, FPGAs, AI, and others - State-of-practice/art, including transition to cloud - Frameworks, system software - Programming models, runtime systems, and APIs to facilitate cloud adoption - Edge use-cases - Application adaptation, success stories - Kubernetes Batch - Scheduling, job management - Execution paradigm - workflow - Data management - Deployment paradigm - Multi-cluster/scalability - Performance improvement - Workflow / execution paradigm - Podman: end-to-end Docker alternative container environment & use-cases - Creating, Running containers as non-root (rootless) - Running rootless containers with MPI - Container live migration - Running containers in restricted environments without setuid - Networking - Software defined networks and network virtualization - New virtualization NICs/Nitro alike ASICs for the data center? - Kubernetes SDN policy (Calico i.a.) - Kubernetes network provisioning (Flannel i.a.) - Lightweight Virtualization - Micro VMMs (Rust-VMM, Firecracker, solo5) - Xen - Nitro hypervisor (KVM) - RVirt - Cloud Hypervisor - Unikernels / LibOS - HPC Storage in Virtualization - HPC container storage - Cloud-native storage - Hypervisors in storage virtualization - Processor Virtualization - RISC-V hypervisor extensions - RISC-V Hypervisor ports - EPI - Composable HPC microservices - Containerizing Scientific Codes - Building - Deploying - Securing - Storage - Monitoring - Use case for containerizing HPC codes: Climate model containers for portability, reproducibility, traceability, immutability, provenance, data & software preservation The Workshop on Virtualization in High-Performance Cloud Computing (VHPC) aims to bring together researchers and industrial practitioners facing the challenges posed by virtualization in order to foster discussion, collaboration, mutual exchange of knowledge and experience, enabling research to ultimately provide novel solutions for virtualized computing systems of tomorrow. The workshop will be one day in length, composed of 20 min paper presentations, each followed by 10 min discussion sections, plus lightning talks that are limited to 5 minutes. Presentations may be accompanied by interactive demonstrations. Important Dates Jan 31st, 2020 - Abstract Apr 5th, 2020 - Paper submission deadline (Springer LNCS) Apr 26th, 2020 - Acceptance notification June 25th, 2020 - Workshop Day July 10th, 2020 - Camera-ready version due Chair Michael Alexander (chair), BOKU, Vienna, Austria Anastassios Nanos (co-chair), Sunlight.io, UK Program committee Stergios Anastasiadis, University of Ioannina, Greece Paolo Bonzini, Redhat, Italy Jakob Blomer, CERN, Europe Eduardo César, Universidad Autonoma de Barcelona, Spain Taylor Childers, Argonne National Laboratory, USA Stephen Crago, USC ISI, USA Tommaso Cucinotta, St. Anna School of Advanced Studies, Italy François Diakhaté CEA DAM Ile de France, France Kyle Hale, Northwestern University, USA Brian Kocoloski, Washington University, USA John Lange, University of Pittsburgh, USA Giuseppe Lettieri, University of Pisa, Italy Klaus Ma, Huawei, China Alberto Madonna, Swiss National Supercomputing Center, Switzerland Nikos Parlavantzas, IRISA, France Anup Patel, Western Digital, USA Kevin Pedretti, Sandia National Laboratories, USA Amer Qouneh, Western New England University, USA Carlos Reaño, Queen’s University Belfast, UK Adrian Reber, Redhat, Germany Riccardo Rocha, CERN, Europe Borja Sotomayor, University of Chicago, USA Jonathan Sparks, Cray, USA Kurt Tutschku, Blekinge Institute of Technology, Sweden John Walters, USC ISI, USA Yasuhiro Watashiba, Osaka University, Japan Chao-Tung Yang, Tunghai University, Taiwan Paper Submission-Publication Papers submitted to the workshop will be reviewed by at least two members of the program committee and external reviewers. Submissions should include abstract, keywords, the e-mail address of the corresponding author, and must not exceed 10 pages, including tables and figures at a main font size no smaller than 11 point. Submission of a paper should be regarded as a commitment that, should the paper be accepted, at least one of the authors will register and attend the conference to present the work. Accepted papers will be published in a Springer LNCS volume. The format must be according to the Springer LNCS Style. Initial submissions are in PDF; authors of accepted papers will be requested to provide source files. Abstract, Paper Submission Link: edas[dot]info/newPaper.php?c=26973 Lightning Talks Lightning Talks are non-paper track, synoptical in nature and are strictly limited to 5 minutes. They can be used to gain early feedback on ongoing research, for demonstrations, to present research results, early research ideas, perspectives and positions of interest to the community. Submit abstract via the main submission link. General Information The workshop is one day in length and will be held in conjunction with the International Supercomputing Conference - High Performance (ISC) 2019, June 21-25, Frankfurt, Germany.

1 0

[libvirt] [libvirt-tck PATCH v2] Add cases for nvram
by dzheng＠redhat.com 19 Dec '19

19 Dec '19

From: Dan Zheng <dzheng(a)redhat.com> This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM v1: https://www.redhat.com/archives/libvir-list/2019-December/msg00932.html Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- scripts/domain/401-ovmf-nvram.t | 144 ++++++++++++++++++++++++++++++++ 1 file changed, 144 insertions(+) create mode 100644 scripts/domain/401-ovmf-nvram.t diff --git a/scripts/domain/401-ovmf-nvram.t b/scripts/domain/401-ovmf-nvram.t new file mode 100644 index 0000000..4af2117 --- /dev/null +++ b/scripts/domain/401-ovmf-nvram.t @@ -0,0 +1,144 @@ +# -*- perl -*- +# +# Copyright (C) 2009 Red Hat, Inc. +# Copyright (C) 2018 Dan Zheng (dzheng(a)redhat.com) +# +# This program is free software; You can redistribute it and/or modify +# it under the GNU General Public License as published by the Free +# Software Foundation; either version 2, or (at your option) any +# later version +# +# The file "LICENSE" distributed along with this file provides full +# details of the terms and conditions +# + +=pod + +=head1 NAME + +domain/401-ovmf-nvram.t - Test OVMF related functions and flags + +=head1 DESCRIPTION + +The test cases validates OVMF related APIs and flags + +Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM +Sys::Virt::Domain::UNDEFINE_NVRAM + +=cut + +use strict; +use warnings; + +use Test::More tests => 6; + +use Sys::Virt::TCK; +use File::stat; +use File::Copy; + + +my $tck = Sys::Virt::TCK->new(); +my $conn = eval { $tck->setup(); }; +BAIL_OUT "failed to setup test harness: $@" if $@; +END { $tck->cleanup if $tck; } + + +sub setup_nvram { + + my $loader_path = shift; + my $nvram_template = shift; + my $nvram_path = shift; + + # Check below two files should exist + # - /usr/share/OVMF/OVMF_CODE.secboot.fd + # - /usr/share/OVMF/OVMF_VARS.fd + if (!stat($loader_path) or !stat($nvram_template)) { + return undef; + } + + # Ensure the sample nvram file exists + copy($nvram_template, $nvram_path) or die "Copy failed: $!"; + + # Use 'q35' as machine type and add below lines to guest xml + # <loader readonly='yes' secure='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.secboot.fd</loader> + # <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/test_VARS.fd</nvram> + + my $xml = $tck->generic_domain(name => "tck")->as_xml; + my $xp = XML::XPath->new($xml); + + if ($xp->getNodeText("/domain/os/type/\@machine") ne 'q35') { + diag "Changing guest machine type to q35"; + $xp->setNodeText("/domain/os/type/\@machine", "q35"); + } + + my $loader_node = XML::XPath::Node::Element->new('loader'); + my $loader_text = XML::XPath::Node::Text->new($loader_path); + my $attr_ro = XML::XPath::Node::Attribute->new('readonly'); + my $attr_secure = XML::XPath::Node::Attribute->new('secure'); + my $attr_type = XML::XPath::Node::Attribute->new('type'); + + $attr_ro -> setNodeValue('yes'); + $attr_secure -> setNodeValue('yes'); + $attr_type -> setNodeValue('pflash'); + + $loader_node->appendChild($loader_text); + $loader_node->appendAttribute($attr_ro); + $loader_node->appendAttribute($attr_secure); + $loader_node->appendAttribute($attr_type); + + my $nvram_node = XML::XPath::Node::Element->new('nvram'); + my $nvram_text = XML::XPath::Node::Text->new($nvram_path); + my $attr_template = XML::XPath::Node::Attribute->new('template'); + + $attr_template -> setNodeValue($nvram_template); + + $nvram_node->appendChild($nvram_text); + $nvram_node->appendAttribute($attr_template); + + my $smm_node = XML::XPath::Node::Element->new('smm'); + my $attr_state = XML::XPath::Node::Attribute->new('state'); + $attr_state -> setNodeValue("on"); + $smm_node -> appendAttribute($attr_state); + + my ($root) = $xp->findnodes('/domain/os'); + $root->appendChild($loader_node); + $root->appendChild($nvram_node); + ($root) = $xp->findnodes('/domain/features'); + $root->appendChild($smm_node); + + $xml = $xp->findnodes_as_string('/'); + diag $xml; + return $xml; +} + +diag "Defining an inactive domain config with nvram"; +my $loader_file_path = '/usr/share/OVMF/OVMF_CODE.secboot.fd'; +my $nvram_file_template = '/usr/share/OVMF/OVMF_VARS.fd'; +my $nvram_file_path = '/var/lib/libvirt/qemu/nvram/test_VARS.fd'; + +my $xml = setup_nvram($loader_file_path, $nvram_file_template, $nvram_file_path); + +SKIP: { + diag "Require files ($loader_file_path, $nvram_file_template) for testing"; + skip "Please install OVMF and ensure necessary files exist", 5 if !defined($xml); + my $dom; + + diag "Test Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM"; + ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); + diag "Checking nvram file already exists"; + my $st = stat($nvram_file_path); + ok($st, "File '$nvram_file_path' exists as expected"); + $dom->undefine(Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM); + diag "Checking nvram file still exists"; + $st = stat($nvram_file_path); + ok($st, "File '$nvram_file_path' still exists as expected"); + + diag "Test Sys::Virt::Domain::UNDEFINE_NVRAM"; + ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); + $dom->undefine(Sys::Virt::Domain::UNDEFINE_NVRAM); + diag "Checking nvram file removed"; + $st = stat($nvram_file_path); + ok(!$st, "File '$nvram_file_path' is removed"); +} +ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised from missing domain", + Sys::Virt::Error::ERR_NO_DOMAIN); -- 2.18.1

2 1

[libvirt] [PATCH] remote_daemon: Log host boot time
by Michal Privoznik 19 Dec '19

19 Dec '19

This is not strictly needed, but it makes sure we initialize the @bootTime global variable. Thing is, in order to validate XATTRs and prune those set in some previous runs of the host, a timestamp is recorded in XATTRs. The host boot time was unique enough so it was chosen as the timestamp value. And to avoid querying and parsing /proc/uptime every time, the query function does that only once and stores the boot time in a global variable. However, the only time the query function is called is in a child process that does lock files and changes seclabels. So effectively, we are doing exactly what we wanted to prevent from happening. The fix is simple, call the query function whilst the daemon is initializing. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Since this will be used by security driver only, I was tempted to put this somewhere under src/security/, but especially because of split daemon I didn't. Placing this into remote_daemon.c makes sure all sub-daemons will have the variable initialized and won't suffer the problem. src/remote/remote_daemon.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c index b400b1dd10..5debb6ce97 100644 --- a/src/remote/remote_daemon.c +++ b/src/remote/remote_daemon.c @@ -57,6 +57,7 @@ #include "virgettext.h" #include "util/virnetdevopenvswitch.h" #include "virsystemd.h" +#include "virhostuptime.h" #include "driver.h" @@ -1020,6 +1021,7 @@ int main(int argc, char **argv) { bool implicit_conf = false; char *run_dir = NULL; mode_t old_umask; + unsigned long long bootTime; struct option opts[] = { { "verbose", no_argument, &verbose, 'v'}, @@ -1151,6 +1153,12 @@ int main(int argc, char **argv) { exit(EXIT_FAILURE); } + if (virHostGetBootTime(&bootTime) < 0) { + VIR_DEBUG("Unable to get host boot time"); + } else { + VIR_DEBUG("host boot time: %lld", bootTime); + } + daemonSetupNetDevOpenvswitch(config); if (daemonSetupAccessManager(config) < 0) { -- 2.24.1

3 2

[libvirt] [PATCH] cpu: add CLZERO CPUID support for AMD platforms (libvirt 4.5)
by Ani Sinha 19 Dec '19

19 Dec '19

Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR") adds support for CLZERO CPUID bit. This commit extends support for this bit in libvirt. This patch is based off of libvirt-4.5 tree. Signed-off-by: Ani Sinha <ani.sinha(a)nutanix.com> --- src/cpu/cpu_map.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 088c820..c251cb7 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -431,6 +431,9 @@ <feature name='virt-ssbd'> <cpuid eax_in='0x80000008' ebx='0x02000000'/> </feature> + <feature name='clzero'> + <cpuid eax_in='0x80000008' ebx='0x00000001'/> + </feature>  <model name='486'> @@ -1685,6 +1688,7 @@ <feature name='bmi2'/> <feature name='clflush'/> <feature name='clflushopt'/> + <feature name='clzero'/> <feature name='cmov'/> <feature name='cr8legacy'/> <feature name='cx16'/> @@ -1756,6 +1760,7 @@ <feature name='bmi2'/> <feature name='clflush'/> <feature name='clflushopt'/> + <feature name='clzero'/> <feature name='cmov'/> <feature name='cr8legacy'/> <feature name='cx16'/> -- 1.9.4

2 3

[libvirt] [PATCH 1/1] qemu: hide details of fake reboot
by Nikolay Shirokovskiy 19 Dec '19

19 Dec '19

If we use fake reboot then domain goes thru running->shutdown->running state changes with shutdown state only for short period of time. At least this is implementation details leaking into API. And also there is one real case when this is not convinient. I'm doing a backup with the help of temporary block snapshot (with the help of qemu's API which is used in the newly created libvirt's backup API). If guest is shutdowned I want to continue to backup so I don't kill the process and domain is in shutdown state. Later when backup is finished I want to destroy qemu process. So I check if it is in shutdowned state and destroy it if it is. Now if instead of shutdown domain got fake reboot then I can destroy process in the middle of fake reboot process. After shutdown event we also get stop event and now as domain state is running it will be transitioned to paused state and back to running later. Though this is not critical for the described case I guess it is better not to leak these details to user too. So let's leave domain in running state on stop event if fake reboot is in process. As we don't know when stop event really arrive let's move resetting flag after starting CPUs - at this point stop event should be handled. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/qemu/qemu_process.c | 57 ++++++++++++++++++++++------------------- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ed8666e9d1..2d37f92724 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -500,6 +500,8 @@ qemuProcessFakeReboot(void *opaque) goto endjob; } + qemuDomainSetFakeReboot(driver, vm, false); + if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) { VIR_WARN("Unable to save status on vm %s after state change", vm->def->name); @@ -525,7 +527,6 @@ qemuProcessShutdownOrReboot(virQEMUDriverPtr driver, qemuDomainObjPrivatePtr priv = vm->privateData; if (priv->fakeReboot) { - qemuDomainSetFakeReboot(driver, vm, false); virObjectRef(vm); virThread th; if (virThreadCreate(&th, @@ -534,6 +535,7 @@ qemuProcessShutdownOrReboot(virQEMUDriverPtr driver, vm) < 0) { VIR_ERROR(_("Failed to create reboot thread, killing domain")); ignore_value(qemuProcessKill(vm, VIR_QEMU_PROCESS_KILL_NOWAIT)); + qemuDomainSetFakeReboot(driver, vm, false); virObjectUnref(vm); } } else { @@ -595,35 +597,37 @@ qemuProcessHandleShutdown(qemuMonitorPtr mon G_GNUC_UNUSED, goto unlock; } - VIR_DEBUG("Transitioned guest %s to shutdown state", - vm->def->name); - virDomainObjSetState(vm, - VIR_DOMAIN_SHUTDOWN, - VIR_DOMAIN_SHUTDOWN_UNKNOWN); + if (!priv->fakeReboot) { + VIR_DEBUG("Transitioned guest %s to shutdown state", + vm->def->name); + virDomainObjSetState(vm, + VIR_DOMAIN_SHUTDOWN, + VIR_DOMAIN_SHUTDOWN_UNKNOWN); - switch (guest_initiated) { - case VIR_TRISTATE_BOOL_YES: - detail = VIR_DOMAIN_EVENT_SHUTDOWN_GUEST; - break; + switch (guest_initiated) { + case VIR_TRISTATE_BOOL_YES: + detail = VIR_DOMAIN_EVENT_SHUTDOWN_GUEST; + break; - case VIR_TRISTATE_BOOL_NO: - detail = VIR_DOMAIN_EVENT_SHUTDOWN_HOST; - break; + case VIR_TRISTATE_BOOL_NO: + detail = VIR_DOMAIN_EVENT_SHUTDOWN_HOST; + break; - case VIR_TRISTATE_BOOL_ABSENT: - case VIR_TRISTATE_BOOL_LAST: - default: - detail = VIR_DOMAIN_EVENT_SHUTDOWN_FINISHED; - break; - } + case VIR_TRISTATE_BOOL_ABSENT: + case VIR_TRISTATE_BOOL_LAST: + default: + detail = VIR_DOMAIN_EVENT_SHUTDOWN_FINISHED; + break; + } - event = virDomainEventLifecycleNewFromObj(vm, - VIR_DOMAIN_EVENT_SHUTDOWN, - detail); + event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_SHUTDOWN, + detail); - if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) { - VIR_WARN("Unable to save status on vm %s after state change", - vm->def->name); + if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) { + VIR_WARN("Unable to save status on vm %s after state change", + vm->def->name); + } } if (priv->agent) @@ -657,7 +661,8 @@ qemuProcessHandleStop(qemuMonitorPtr mon G_GNUC_UNUSED, reason = priv->pausedReason; priv->pausedReason = VIR_DOMAIN_PAUSED_UNKNOWN; - if (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_RUNNING) { + if (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_RUNNING && + !priv->fakeReboot) { if (priv->job.asyncJob == QEMU_ASYNC_JOB_MIGRATION_OUT) { if (priv->job.current->status == QEMU_DOMAIN_JOB_STATUS_POSTCOPY) reason = VIR_DOMAIN_PAUSED_POSTCOPY; -- 2.23.0

2 2

[libvirt] [PATCH 0/2] Remove VIR_FILE_*_SEPARATOR_*
by Fabiano Fidêncio 18 Dec '19

18 Dec '19

Let's use the defines provided by GLib, instead of keeping our own. Fabiano Fidêncio (2): util: Use G_DIR_SEPARATOR instead of VIR_FILE_DIR_SEPARATOR util: Remove VIR_FILE_*_SEPARATOR* src/util/virfile.c | 2 +- src/util/virfile.h | 19 ------------------- 2 files changed, 1 insertion(+), 20 deletions(-) -- 2.23.0

2 3

[libvirt] [PATCH 0/3] Remove unused virFile*() functions
by Fabiano Fidêncio 18 Dec '19

18 Dec '19

- virFileSkipRoot() is no longer used since faf2d811f3e9a4; - virFileIsAbsPath() is no longer used since faf2d811f3e9a4; - VIR_FILE_IS_DIR_SEPARATOR is no longer used since virFileIsAbsPath has been dropped; Fabiano Fidêncio (3): util: Remove virFileSkipRoot() util: Remove virFileIsAbsPath() util: Remove VIR_FILE_IS_DIR_SEPARATOR src/libvirt_private.syms | 2 -- src/util/virfile.c | 73 ---------------------------------------- src/util/virfile.h | 4 --- 3 files changed, 79 deletions(-) -- 2.23.0

3 5

[libvirt] [PATCH] docs: Only distribute sanlock manpage if WITH_SANLOCK
by Cole Robinson 18 Dec '19

18 Dec '19

This fixes mingw-libvirt RPM build Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/Makefile.am | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index eb8de80b9c..66f164a1ac 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -214,9 +214,7 @@ manpages7_rst = \ $(KEYCODES:%=manpages/virkeycode-%.rst) \ $(KEYNAMES:%=manpages/virkeyname-%.rst) \ $(NULL) -manpages8_rst = \ - manpages/virt-sanlock-cleanup.rst \ - $(NULL) +manpages8_rst = $(NULL) manpages_rst += \ $(manpages1_rst) \ $(manpages7_rst) \ @@ -245,6 +243,11 @@ if WITH_LOGIN_SHELL else ! WITH_LOGIN_SHELL manpages_rst += manpages/virt-login-shell.rst endif ! WITH_LOGIN_SHELL +if WITH_SANLOCK + manpages8_rst += manpages/virt-sanlock-cleanup.rst +else ! WITH_SANLOCK + manpages_rst += manpages/virt-sanlock-cleanup.rst +endif ! WITH_SANLOCK manpages_rst_html_in = \ $(manpages_rst:%.rst=%.html.in) manpages_html = \ -- 2.23.0

2 1

[libvirt] [PATCH] util: Simplify Windows version of virGetUserDirectoryByUID()
by Fabiano Fidêncio 18 Dec '19

18 Dec '19

Let's just use the plain g_get_home_dir(), from GLib, instead of maintaining a code adapted from the GLib's one. Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- src/util/virutil.c | 92 +--------------------------------------------- 1 file changed, 1 insertion(+), 91 deletions(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index a28feb3daa..4075047cf9 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -1070,100 +1070,10 @@ virDoesGroupExist(const char *name G_GNUC_UNUSED) } # ifdef WIN32 -/* These methods are adapted from GLib2 under terms of LGPLv2+ */ -static int -virGetWin32SpecialFolder(int csidl, char **path) -{ - char buf[MAX_PATH+1]; - LPITEMIDLIST pidl = NULL; - int ret = 0; - - *path = NULL; - - if (SHGetSpecialFolderLocation(NULL, csidl, &pidl) == S_OK) { - if (SHGetPathFromIDList(pidl, buf)) - *path = g_strdup(buf); - CoTaskMemFree(pidl); - } - return ret; -} - -static int -virGetWin32DirectoryRoot(char **path) -{ - char windowsdir[MAX_PATH]; - - *path = NULL; - - if (GetWindowsDirectory(windowsdir, G_N_ELEMENTS(windowsdir))) { - const char *tmp; - /* Usually X:\Windows, but in terminal server environments - * might be an UNC path, AFAIK. - */ - tmp = virFileSkipRoot(windowsdir); - if (VIR_FILE_IS_DIR_SEPARATOR(tmp[-1]) && - tmp[-2] != ':') - tmp--; - - windowsdir[tmp - windowsdir] = '\0'; - } else { - strcpy(windowsdir, "C:\\"); - } - - *path = g_strdup(windowsdir); - return 0; -} - - - char * virGetUserDirectoryByUID(uid_t uid G_GNUC_UNUSED) { - /* Since Windows lacks setuid binaries, and since we already fake - * geteuid(), we can safely assume that this is only called when - * querying about the current user */ - const char *dir; - char *ret; - - dir = getenv("HOME"); - - /* Only believe HOME if it is an absolute path and exists */ - if (dir) { - if (!virFileIsAbsPath(dir) || - !virFileExists(dir)) - dir = NULL; - } - - /* In case HOME is Unix-style (it happens), convert it to - * Windows style. - */ - if (dir) { - char *p; - while ((p = strchr(dir, '/')) != NULL) - *p = '\\'; - } - - if (!dir) - /* USERPROFILE is probably the closest equivalent to $HOME? */ - dir = getenv("USERPROFILE"); - - ret = g_strdup(dir); - - if (!ret && - virGetWin32SpecialFolder(CSIDL_PROFILE, &ret) < 0) - return NULL; - - if (!ret && - virGetWin32DirectoryRoot(&ret) < 0) - return NULL; - - if (!ret) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to determine home directory")); - return NULL; - } - - return ret; + return g_strdup(g_get_home_dir()); } char * -- 2.23.0

2 1

[libvirt] [PATCH v6 0/4] PCI hostdev partial assignment support
by Daniel Henrique Barboza 18 Dec '19

18 Dec '19

changes from previous version 5 [1]: - changes in the commit message of patch 1 and the documentation included in patches 3 and 4, all of them suggested/hinted by Alex Williamson. Daniel Henrique Barboza (4): Introducing new address type='unassigned' for PCI hostdevs qemu: handle unassigned PCI hostdevs in command line formatdomain.html.in: document <address type='unassigned'/> news.xml: add address type='unassigned' entry [1] https://www.redhat.com/archives/libvir-list/2019-December/msg01097.html docs/formatdomain.html.in | 10 ++++ docs/news.xml | 14 +++++ docs/schemas/domaincommon.rng | 5 ++ src/conf/device_conf.c | 2 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 7 ++- src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 5 ++ .../hostdev-pci-address-unassigned.args | 31 ++++++++++ .../hostdev-pci-address-unassigned.xml | 42 ++++++++++++++ tests/qemuxml2argvtest.c | 4 ++ .../hostdev-pci-address-unassigned.xml | 58 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 14 files changed, 185 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-unassigned.xml -- 2.23.0

3 6

[libvirt] [PATCH v2 0/4] move qemucaps validations from qemu_command to qemu_domain
by Daniel Henrique Barboza 18 Dec '19

18 Dec '19

Most of the patches were pushed in the first version. These are the patches that didn't make the cut and needed new versions. After these patches I'll refrain from doing more validation moves to qemu_domain.c. I'll send a RFC discussing how we can move all the validations to a new file first, then we can resume this work in the definitive location instead. Changes from previous version 1 [1]: - patch 1 (former patch 04): moved the validation to a new qemuDomainDeviceDefValidateMemory() function which is called by qemuDomainDeviceDefValidate(). - patch 2 (former patch 23): added the missing "if (graphics->data.egl_headless.rendernode)" check. - patch 3 (former patch 24): virReportEnumRangeError is now being used in the "default" label error case. - patch 4 (new): added the VMCOREINFO validation case that I mentioned about in the cover letter of [1] as a difficult case, but Cole mentioned that it was simpler than that and that I was probably missing something. Cole was right. [1] https://www.redhat.com/archives/libvir-list/2019-December/msg00570.html Daniel Henrique Barboza (4): qemu: command: move NVDIMM validation to qemu_domain.c qemu: command: move qemuBuildGraphicsEGLHeadlessCommandLine validation to qemu_domain.c qemu: move qemuBuildSmartcardCommandLine validation to qemu_domain.c qemu: command: move validation of vmcoreinfo to qemu_domain.c src/qemu/qemu_command.c | 51 ++---------------------------- src/qemu/qemu_domain.c | 70 +++++++++++++++++++++++++++++++++++++++-- tests/qemuxml2xmltest.c | 30 +++++++++--------- 3 files changed, 87 insertions(+), 64 deletions(-) -- 2.23.0

2 5

[libvirt] [PATCH v4 0/4] Rewrite virGetUser*Directory() functions using g_get_*_dir()
by Fabiano Fidêncio 18 Dec '19

18 Dec '19

By rewriting virGetUser*Directory() functions using g_get_*_dir() functions allows us to drop all the different implementations we keep, as GLib already takes care of those for us. Changes since v3: https://www.redhat.com/archives/libvir-list/2019-December/msg01123.html - Used g_build_filename() instead of g_strdup_printf(); Changes since v2: https://www.redhat.com/archives/libvir-list/2019-December/msg01064.html - Addressed comments made by Cole about: - virGetUserDirectory() should return $HOME; - virGetUser*Directory() don't append "libvirt" to the returned path on Windows; Changes since v1: https://www.redhat.com/archives/libvir-list/2019-December/msg01055.html - Don't check for the return of g_get_*_dir(), as it cannot be NULL; Fabiano Fidêncio (4): util: Rewrite virGetUserDirectory() using g_get_home_dir() util: Rewrite virGetUserConfigDirectory() using g_get_user_config_dir() util: Rewrite virGetUserCacheDirectory() using g_get_user_cache_dir() util: Rewrite virGetUserRuntimeDirectory() using g_get_user_runtime_dir() src/util/virutil.c | 137 ++++++++++----------------------------------- 1 file changed, 31 insertions(+), 106 deletions(-) -- 2.23.0

2 5

[libvirt] [PATCH v2 0/4] Rewrite virGetUser*Directory() functions using g_get_*_dir()
by Fabiano Fidêncio 18 Dec '19

18 Dec '19

By rewriting virGetUser*Directory() functions using g_get_*_dir() functions allows us to drop all the different implementations we keep, as GLib already takes care of those for us. Changes since v1: https://www.redhat.com/archives/libvir-list/2019-December/msg01055.html - Don't check for the return of g_get_*_dir(), as it cannot be NULL; Fabiano Fidêncio (4): util: Rewrite virGetUserDirectory() using g_get_home_dir() util: Rewrite virGetUserConfigDirectory() using g_get_user_config_dir() util: Rewrite virGetUserCacheDirectory() using g_get_user_cache_dir() util: Rewrite virGetUserRuntimeDirectory() using g_get_user_runtime_dir() src/util/virutil.c | 125 +++++++-------------------------------------- 1 file changed, 19 insertions(+), 106 deletions(-) -- 2.23.0

4 12

[libvirt] [PATCH v3 0/1] qemu_command: tidy up qemuBuildHostdevCommandLine loop
by Daniel Henrique Barboza 18 Dec '19

18 Dec '19

This fella got buried a few months ago. Re-sending as a v3 due to rebase changes. changes from previous version [1]: - rebased to master at 6c17606b7c [1] https://www.redhat.com/archives/libvir-list/2019-October/msg00457.html Daniel Henrique Barboza (1): qemu_command: tidy up qemuBuildHostdevCommandLine loop src/qemu/qemu_command.c | 52 +++++++++++++++++++++++++---------------- 1 file changed, 32 insertions(+), 20 deletions(-) -- 2.23.0

2 2

[libvirt] [PATCH] qemu: store the emulator name in the capabilities XML
by Daniel P. Berrangé 18 Dec '19

18 Dec '19

We don't need this for any functional purpose, but when debugging hosts it is useful to know what binary a given capabilities XML document is associated with. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_capabilities.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 2223589058..7d47fa4d02 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3852,6 +3852,7 @@ virQEMUCapsParseSEVInfo(virQEMUCapsPtr qemuCaps, xmlXPathContextPtr ctxt) * Parsing a doc that looks like * * <qemuCaps> + * <emulator>/some/path</emulator> * <qemuctime>234235253</qemuctime> * <selfctime>234235253</selfctime> * <selfvers>1002016</selfvers> @@ -3895,6 +3896,18 @@ virQEMUCapsLoadCache(virArch hostArch, goto cleanup; } + if (!(str = virXPathString("string(./emulator)", ctxt))) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("missing emulator in QEMU capabilities cache")); + goto cleanup; + } + if (!STREQ(str, qemuCaps->binary)) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Expected caps for '%s' but saw '%s'"), + qemuCaps->binary, str); + goto cleanup; + } + VIR_FREE(str); if (virXPathLongLong("string(./qemuctime)", ctxt, &l) < 0) { virReportError(VIR_ERR_XML_ERROR, "%s", _("missing qemuctime in QEMU capabilities XML")); @@ -4232,6 +4245,8 @@ virQEMUCapsFormatCache(virQEMUCapsPtr qemuCaps) virBufferAddLit(&buf, "<qemuCaps>\n"); virBufferAdjustIndent(&buf, 2); + virBufferEscapeString(&buf, "<emulator>%s</emulator>\n", + qemuCaps->binary); virBufferAsprintf(&buf, "<qemuctime>%llu</qemuctime>\n", (long long)qemuCaps->ctime); virBufferAsprintf(&buf, "<selfctime>%llu</selfctime>\n", -- 2.23.0

3 3

[libvirt] [PATCH] conf: fix populating of fake NUMA in multi-node hosts
by Daniel P. Berrangé 18 Dec '19

18 Dec '19

If the host OS doesn't have NUMA present, we fallback to populating fake NUMA info and the code thus assumes only a single NUMA node. Unfortunately we also fallback to fake NUMA if numactl-devel was not present, and in this case we can still have multiple NUMA nodes. In this case we create all CPUs, but only the CPUs in the first node have any data filled in, resulting in capabilities like: <topology> <cells num='1'> <cell id='0'> <memory unit='KiB'>15977572</memory> <cpus num='48'> <cpu id='0' socket_id='0' core_id='0' siblings='0'/> <cpu id='1' socket_id='0' core_id='0' siblings='1'/> <cpu id='2' socket_id='0' core_id='1' siblings='2'/> <cpu id='3' socket_id='0' core_id='1' siblings='3'/> <cpu id='4' socket_id='0' core_id='2' siblings='4'/> <cpu id='5' socket_id='0' core_id='2' siblings='5'/> <cpu id='6' socket_id='0' core_id='3' siblings='6'/> <cpu id='7' socket_id='0' core_id='3' siblings='7'/> <cpu id='8' socket_id='0' core_id='4' siblings='8'/> <cpu id='9' socket_id='0' core_id='4' siblings='9'/> <cpu id='10' socket_id='0' core_id='5' siblings='10'/> <cpu id='11' socket_id='0' core_id='5' siblings='11'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> <cpu id='0'/> </cpus> </cell> </cells> </topology> With this new code we get something slightly less broken <topology> <cells num='4'> <cell id='0'> <memory unit='KiB'>15977572</memory> <cpus num='12'> <cpu id='0' socket_id='0' core_id='0' siblings='0-1'/> <cpu id='1' socket_id='0' core_id='0' siblings='0-1'/> <cpu id='2' socket_id='0' core_id='1' siblings='2-3'/> <cpu id='3' socket_id='0' core_id='1' siblings='2-3'/> <cpu id='4' socket_id='0' core_id='2' siblings='4-5'/> <cpu id='5' socket_id='0' core_id='2' siblings='4-5'/> <cpu id='6' socket_id='0' core_id='3' siblings='6-7'/> <cpu id='7' socket_id='0' core_id='3' siblings='6-7'/> <cpu id='8' socket_id='0' core_id='4' siblings='8-9'/> <cpu id='9' socket_id='0' core_id='4' siblings='8-9'/> <cpu id='10' socket_id='0' core_id='5' siblings='10-11'/> <cpu id='11' socket_id='0' core_id='5' siblings='10-11'/> </cpus> </cell> <cell id='0'> <memory unit='KiB'>15977572</memory> <cpus num='12'> <cpu id='12' socket_id='0' core_id='0' siblings='12-13'/> <cpu id='13' socket_id='0' core_id='0' siblings='12-13'/> <cpu id='14' socket_id='0' core_id='1' siblings='14-15'/> <cpu id='15' socket_id='0' core_id='1' siblings='14-15'/> <cpu id='16' socket_id='0' core_id='2' siblings='16-17'/> <cpu id='17' socket_id='0' core_id='2' siblings='16-17'/> <cpu id='18' socket_id='0' core_id='3' siblings='18-19'/> <cpu id='19' socket_id='0' core_id='3' siblings='18-19'/> <cpu id='20' socket_id='0' core_id='4' siblings='20-21'/> <cpu id='21' socket_id='0' core_id='4' siblings='20-21'/> <cpu id='22' socket_id='0' core_id='5' siblings='22-23'/> <cpu id='23' socket_id='0' core_id='5' siblings='22-23'/> </cpus> </cell> </cells> </topology> The topology at least now reflects what 'virsh nodeinfo' reports. The main bug is that the CPU "id" values won't match what the Linux host actually uses. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/conf/capabilities.c | 67 ++++++++++++++++++++++------------------- 1 file changed, 36 insertions(+), 31 deletions(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 81a2004dba..2a183d7070 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -1593,7 +1593,7 @@ virCapabilitiesHostNUMAInitFake(virCapsHostNUMAPtr caps) virNodeInfo nodeinfo; virCapsHostNUMACellCPUPtr cpus; int ncpus; - int s, c, t; + int n, s, c, t; int id, cid; int onlinecpus G_GNUC_UNUSED; bool tmp; @@ -1602,47 +1602,52 @@ virCapabilitiesHostNUMAInitFake(virCapsHostNUMAPtr caps) return -1; ncpus = VIR_NODEINFO_MAXCPUS(nodeinfo); - onlinecpus = nodeinfo.cpus; - if (VIR_ALLOC_N(cpus, ncpus) < 0) - return -1; - id = cid = 0; - for (s = 0; s < nodeinfo.sockets; s++) { - for (c = 0; c < nodeinfo.cores; c++) { - for (t = 0; t < nodeinfo.threads; t++) { - if (virHostCPUGetOnline(id, &tmp) < 0) - goto error; - if (tmp) { - cpus[cid].id = id; - cpus[cid].socket_id = s; - cpus[cid].core_id = c; - if (!(cpus[cid].siblings = virBitmapNew(ncpus))) + id = 0; + for (n = 0; n < nodeinfo.nodes; n++) { + int nodecpus = nodeinfo.sockets * nodeinfo.cores * nodeinfo.threads; + cid = 0; + + if (VIR_ALLOC_N(cpus, nodecpus) < 0) + return -1; + + for (s = 0; s < nodeinfo.sockets; s++) { + for (c = 0; c < nodeinfo.cores; c++) { + g_autoptr(virBitmap) siblings = virBitmapNew(ncpus); + for (t = 0; t < nodeinfo.threads; t++) + ignore_value(virBitmapSetBit(siblings, id + t)); + + for (t = 0; t < nodeinfo.threads; t++) { + if (virHostCPUGetOnline(id, &tmp) < 0) goto error; - ignore_value(virBitmapSetBit(cpus[cid].siblings, id)); - cid++; + if (tmp) { + cpus[cid].id = id; + cpus[cid].socket_id = s; + cpus[cid].core_id = c; + if (!(cpus[cid].siblings = virBitmapNew(ncpus))) + goto error; + virBitmapCopy(cpus[cid].siblings, siblings); + cid++; + } + + id++; } - - id++; } } - } - virCapabilitiesHostNUMAAddCell(caps, 0, - nodeinfo.memory, -#ifdef __linux__ - onlinecpus, cpus, -#else - ncpus, cpus, -#endif - 0, NULL, - 0, NULL); + virCapabilitiesHostNUMAAddCell(caps, 0, + nodeinfo.memory, + cid, cpus, + 0, NULL, + 0, NULL); + } return 0; error: - for (; id >= 0; id--) - virBitmapFree(cpus[id].siblings); + for (; cid >= 0; cid--) + virBitmapFree(cpus[cid].siblings); VIR_FREE(cpus); return -1; } -- 2.23.0

2 1

[libvirt] [PATCH 0/5] Various memleak fixes
by Michal Privoznik 18 Dec '19

18 Dec '19

*** BLURB HERE *** Michal Prívozník (5): domaincapstest: Don't leak cpu definitions testutilsxen: Avoid double free of driver caps virCapabilitiesHostNUMAUnref: Accept NULL qemu: Reoder cleanup in qemuStateCleanup() qemu: Don't leak hostcpu or hostnuma on driver cleanup src/conf/capabilities.c | 3 +++ src/qemu/qemu_driver.c | 45 +++++++++++++++++------------------------ tests/domaincapstest.c | 2 +- tests/testutilsxen.c | 1 - 4 files changed, 23 insertions(+), 28 deletions(-) -- 2.24.1

2 8

[libvirt] [PATCH] conf: avoid mem leak re-allocating fake NUMA capabilities
by Daniel P. Berrangé 18 Dec '19

18 Dec '19

The 'caps' object is already allocated when the fake NUMA initialization takes place. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/conf/capabilities.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 4fac59e6f7..81a2004dba 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -1628,9 +1628,6 @@ virCapabilitiesHostNUMAInitFake(virCapsHostNUMAPtr caps) } } - caps = g_new0(virCapsHostNUMA, 1); - caps->cells = g_ptr_array_new_with_free_func( - (GDestroyNotify)virCapabilitiesFreeHostNUMACell); virCapabilitiesHostNUMAAddCell(caps, 0, nodeinfo.memory, #ifdef __linux__ -- 2.23.0

2 1

[libvirt] [PATCH 0/3] qemu: fix crash bugs in snapshot revert
by Pavel Mores 18 Dec '19

18 Dec '19

The aim of this series is to fix https://bugzilla.redhat.com/show_bug.cgi?id=1610207 however before getting to that we first need to fix an unrelated (and much more recent) bug in patch 1. We clean up the fix in patch 2 by converting the whole function to the new allocation idioms. The actual reported bug is then fixed in patch 3. Pavel Mores (3): qemu: fix crash due to freeing an uninitialised pointer qemu: use g_autofree instead of VIR_FREE in qemuMonitorTextCreateSnapshot() qemu: fix concurrency crash bug in snapshot revert src/qemu/qemu_driver.c | 17 ++++++++++++++--- src/qemu/qemu_monitor_text.c | 20 ++++++-------------- 2 files changed, 20 insertions(+), 17 deletions(-) -- 2.21.0

3 7

[libvirt] [PATCH 0/3] Some coverity adjustments
by John Ferlan 18 Dec '19

18 Dec '19

I upgraded to f31 and it resulted in an essentially hosed Coverity build/analysis environment with the following message during cov-emit processing (a preprocessing of sorts): "/usr/include/glib-2.0/glib/gspawn.h", line 76: error #67: expected a "}" G_SPAWN_ERROR_2BIG GLIB_DEPRECATED_ENUMERATOR_IN_2_32_FOR(G_SPAWN_ERROR_TOO_BIG) = G_SPAWN_ERROR_TOO_BIG, ^ So instead, I'm using a guest to run Coverity "when I remember/can". I also found that my f31 environment doesn't like building w/ docs as I get the following messages while running the convert command: ... usr/bin/mv: cannot stat '/tmp/magick-1191987h12h27ex0lZD.svg': No such file or directory GEN kbase.html.tmp convert: delegate failed `'uniconvertor' '%i' '%o.svg'; /usr/bin/mv '%o.svg' '%o'' @ error/delegate.c/InvokeDelegate/1958. convert: unable to open file `/tmp/magick-1191987OqYJwrq8isaG': No such file or directory @ error/constitute.c/ReadImage/605. convert: no images defined `migration-managed-p2p.png' @ error/convert.c/ConvertImageCommand/3235. .... I haven't followed along as closely as I used to, but my vpath env uses obj as a subdirectory of my main git tree/target. Whether the new build env has anything to do with it or it's just f31, I haven't been able to determine. Beyond these 3 patches here - there is one other adjustment that is necessary to build libvirt under Coverity and that's removing the ATTRIBUTE_NONNULL(2) from the virDomainDefFormat definition in src/conf/domain_conf.h. This was added in commit 92d412149 which also included two calls to virDomainDefFormat with NULL as the 2nd argument (hyperv_driver.c and security_apparmor.c); however, the commit message notes preparation for future work, so I'll keep a hack for that local for now at least. The virsh change below is innocuous yes, but it showed up in a coverity analysis because it wasn't sure if the resulting variables could point to the same address and if they did, then there was a possible use after free because the @source is free'd even though the @target_node is later referenced. The patch here avoids that and provides a slight adjustment to not search for either node by name if it was already found. Whether there's a weird latent issue because <source> can be repeated while <target> cannot be is something I suppose a reviewer can warn me about ;-). John Ferlan (3): conf: Fix ATTRIBUTE_NONNULL usages vbox: Reset @ret after xmlFreeNode virsh: Adjust logic checks in virshUpdateDiskXML src/conf/domain_conf.h | 15 ++++++--------- src/vbox/vbox_snapshot_conf.c | 1 + tools/virsh-domain.c | 5 ++--- 3 files changed, 9 insertions(+), 12 deletions(-) -- 2.23.0

2 4

[libvirt] [PATCH] test: qemucaps: Refresh x86_64 caps probe data for the qemu-4.2 release
by Peter Krempa 18 Dec '19

18 Dec '19

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed as trivial. tests/qemucapabilitiesdata/caps_4.2.0.x86_64.replies | 10 +++++----- tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.replies index ae07ffdb49..b9481b6f85 100644 --- a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 92, - "minor": 1, + "micro": 0, + "minor": 2, "major": 4 }, - "package": "v4.2.0-rc2-19-g2061735ff0" + "package": "v4.2.0" }, "id": "libvirt-2" } @@ -23614,7 +23614,7 @@ "kvm-steal-time": true, "kvmclock": true, "vmx-zero-len-inject": false, - "pschange-mc-no": false, + "pschange-mc-no": true, "vmx-rdrand-exit": true, "lwp": false, "amd-ssbd": false, @@ -23930,7 +23930,7 @@ "kvm-steal-time": true, "kvmclock": true, "vmx-zero-len-inject": false, - "pschange-mc-no": false, + "pschange-mc-no": true, "vmx-rdrand-exit": true, "lwp": false, "amd-ssbd": false, diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml index 31302c9a7b..7d886d9a87 100644 --- a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml @@ -217,10 +217,10 @@ <flag name='blockdev-file-dynamic-auto-read-only'/> <flag name='savevm-monitor-nodes'/> <flag name='drive-nvme'/> - <version>4001092</version> + <version>4002000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100242</microcodeVersion> - <package>v4.2.0-rc2-19-g2061735ff0</package> + <package>v4.2.0</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> @@ -416,7 +416,7 @@ <property name='kvm-steal-time' type='boolean' value='true' migratable='yes'/> <property name='kvmclock' type='boolean' value='true' migratable='yes'/> <property name='vmx-zero-len-inject' type='boolean' value='false'/> - <property name='pschange-mc-no' type='boolean' value='false'/> + <property name='pschange-mc-no' type='boolean' value='true' migratable='yes'/> <property name='vmx-rdrand-exit' type='boolean' value='true' migratable='yes'/> <property name='lwp' type='boolean' value='false'/> <property name='amd-ssbd' type='boolean' value='false'/> -- 2.23.0

1 0

[libvirt] [RFC PATCH 0/9] Introduce mediate ops in vfio-pci
by Yan Zhao 18 Dec '19

18 Dec '19

For SRIOV devices, VFs are passthroughed into guest directly without host driver mediation. However, when VMs migrating with passthroughed VFs, dynamic host mediation is required to (1) get device states, (2) get dirty pages. Since device states as well as other critical information required for dirty page tracking for VFs are usually retrieved from PFs, it is handy to provide an extension in PF driver to centralizingly control VFs' migration. Therefore, in order to realize (1) passthrough VFs at normal time, (2) dynamically trap VFs' bars for dirty page tracking and (3) centralizing VF critical states retrieving and VF controls into one driver, we propose to introduce mediate ops on top of current vfio-pci device driver. _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ __________ register mediate ops| ___________ ___________ | | |<-----------------------| VF | | | | vfio-pci | | | mediate | | PF driver | | |__________|----------------------->| driver | |___________| | open(pdev) | ----------- | | | | | |_ _ _ _ _ _ _ _ _ _ _ _|_ _ _ _ _| \|/ \|/ ----------- ------------ | VF | | PF | ----------- ------------ VF mediate driver could be a standalone driver that does not bind to any devices (as in demo code in patches 5-6) or it could be a built-in extension of PF driver (as in patches 7-9) . Rather than directly bind to VF, VF mediate driver register a mediate ops into vfio-pci in driver init. vfio-pci maintains a list of such mediate ops. (Note that: VF mediate driver can register mediate ops into vfio-pci before vfio-pci binding to any devices. And VF mediate driver can support mediating multiple devices.) When opening a device (e.g. a VF), vfio-pci goes through the mediate ops list and calls each vfio_pci_mediate_ops->open() with pdev of the opening device as a parameter. VF mediate driver should return success or failure depending on it supports the pdev or not. E.g. VF mediate driver would compare its supported VF devfn with the devfn of the passed-in pdev. Once vfio-pci finds a successful vfio_pci_mediate_ops->open(), it will stop querying other mediate ops and bind the opening device with this mediate ops using the returned mediate handle. Further vfio-pci ops (VFIO_DEVICE_GET_REGION_INFO ioctl, rw, mmap) on the VF will be intercepted into VF mediate driver as vfio_pci_mediate_ops->get_region_info(), vfio_pci_mediate_ops->rw, vfio_pci_mediate_ops->mmap, and get customized. For vfio_pci_mediate_ops->rw and vfio_pci_mediate_ops->mmap, they will further return 'pt' to indicate whether vfio-pci should further passthrough data to hw. when vfio-pci closes the VF, it calls its vfio_pci_mediate_ops->release() with a mediate handle as parameter. The mediate handle returned from vfio_pci_mediate_ops->open() lets VF mediate driver be able to differentiate two opening VFs of the same device id and vendor id. When VF mediate driver exits, it unregisters its mediate ops from vfio-pci. In this patchset, we enable vfio-pci to provide 3 things: (1) calling mediate ops to allow vendor driver customizing default region info/rw/mmap of a region. (2) provide a migration region to support migration (3) provide a dynamic trap bar info region to allow vendor driver control trap/untrap of device pci bars This vfio-pci + mediate ops way differs from mdev way in that (1) medv way needs to create a 1:1 mdev device on top of one VF, device specific mdev parent driver is bound to VF directly. (2) vfio-pci + mediate ops way does not create mdev devices and VF mediate driver does not bind to VFs. Instead, vfio-pci binds to VFs. The reason why we don't choose the way of writing mdev parent driver is that (1) VFs are almost all the time directly passthroughed. Directly binding to vfio-pci can make most of the code shared/reused. If we write a vendor specific mdev parent driver, most of the code (like passthrough style of rw/mmap) still needs to be copied from vfio-pci driver, which is actually a duplicated and tedious work. (2) For features like dynamically trap/untrap pci bars, if they are in vfio-pci, they can be available to most people without repeated code copying and re-testing. (3) with a 1:1 mdev driver which passthrough VFs most of the time, people have to decide whether to bind VFs to vfio-pci or mdev parent driver before it runs into a real migration need. However, if vfio-pci is bound initially, they have no chance to do live migration when there's a need later. In this patchset, - patches 1-4 enable vfio-pci to call mediate ops registered by vendor driver to mediate/customize region info/rw/mmap. - patches 5-6 provide a standalone sample driver to register a mediate ops for Intel Graphics Devices. It does not bind to IGDs directly but decides what devices it supports via its pciidlist. It also demonstrates how to dynamic trap a device's PCI bars. (by adding more pciids in its pciidlist, this sample driver actually is not necessarily limited to support IGDs) - patch 7-9 provide a sample on i40e driver that supports Intel(R) Ethernet Controller XL710 Family of devices. It supports VF precopy live migration on Intel's 710 SRIOV. (but we commented out the real implementation of dirty page tracking and device state retrieving part to focus on demonstrating framework part. Will send out them in future versions) patch 7 registers/unregisters VF mediate ops when PF driver probes/removes. It specifies its supporting VFs via vfio_pci_mediate_ops->open(pdev) patch 8 reports device cap of VFIO_PCI_DEVICE_CAP_MIGRATION and provides a sample implementation of migration region. The QEMU part of vfio migration is based on v8 https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg05542.html. We do not based on recent v9 because we think there are still opens in dirty page track part in that series. patch 9 reports device cap of VFIO_PCI_DEVICE_CAP_DYNAMIC_TRAP_BAR and provides an example on how to trap part of bar0 when migration starts and passthrough this part of bar0 again when migration fails. Yan Zhao (9): vfio/pci: introduce mediate ops to intercept vfio-pci ops vfio/pci: test existence before calling region->ops vfio/pci: register a default migration region vfio-pci: register default dynamic-trap-bar-info region samples/vfio-pci/igd_dt: sample driver to mediate a passthrough IGD sample/vfio-pci/igd_dt: dynamically trap/untrap subregion of IGD bar0 i40e/vf_migration: register mediate_ops to vfio-pci i40e/vf_migration: mediate migration region i40e/vf_migration: support dynamic trap of bar0 drivers/net/ethernet/intel/Kconfig | 2 +- drivers/net/ethernet/intel/i40e/Makefile | 3 +- drivers/net/ethernet/intel/i40e/i40e.h | 2 + drivers/net/ethernet/intel/i40e/i40e_main.c | 3 + .../ethernet/intel/i40e/i40e_vf_migration.c | 626 ++++++++++++++++++ .../ethernet/intel/i40e/i40e_vf_migration.h | 78 +++ drivers/vfio/pci/vfio_pci.c | 189 +++++- drivers/vfio/pci/vfio_pci_private.h | 2 + include/linux/vfio.h | 18 + include/uapi/linux/vfio.h | 160 +++++ samples/Kconfig | 6 + samples/Makefile | 1 + samples/vfio-pci/Makefile | 2 + samples/vfio-pci/igd_dt.c | 367 ++++++++++ 14 files changed, 1455 insertions(+), 4 deletions(-) create mode 100644 drivers/net/ethernet/intel/i40e/i40e_vf_migration.c create mode 100644 drivers/net/ethernet/intel/i40e/i40e_vf_migration.h create mode 100644 samples/vfio-pci/Makefile create mode 100644 samples/vfio-pci/igd_dt.c -- 2.17.1

4 45

[libvirt] [PATCH v3 0/4] Rewrite virGetUser*Directory() functions using g_get_*_dir()
by Fabiano Fidêncio 17 Dec '19

17 Dec '19

By rewriting virGetUser*Directory() functions using g_get_*_dir() functions allows us to drop all the different implementations we keep, as GLib already takes care of those for us. Changes since v2: https://www.redhat.com/archives/libvir-list/2019-December/msg01064.html - Addressed comments made by Cole about: - virGetUserDirectory() should return $HOME; - virGetUser*Directory() don't append "libvirt" to the returned path on Windows; Changes since v1: https://www.redhat.com/archives/libvir-list/2019-December/msg01055.html - Don't check for the return of g_get_*_dir(), as it cannot be NULL; Fabiano Fidêncio (4): util: Rewrite virGetUserDirectory() using g_get_home_dir() util: Rewrite virGetUserConfigDirectory() using g_get_user_config_dir() util: Rewrite virGetUserCacheDirectory() using g_get_user_cache_dir() util: Rewrite virGetUserRuntimeDirectory() using g_get_user_runtime_dir() src/util/virutil.c | 137 ++++++++++----------------------------------- 1 file changed, 31 insertions(+), 106 deletions(-) -- 2.23.0

1 4

[libvirt] [PATCH v5 0/4] PCI hostdev partial assignment support
by Daniel Henrique Barboza 17 Dec '19

17 Dec '19

changes from v4 [1]: - previous patch 3 was removed. The validation it was implementating proved to be too restrict, while providing no tangible benefits for the trouble of having existing domains failing to launch. This makes this series all about the new address type implementation and its benefits. More info about the rationale can be found at [1]. - documentation was changed to reflect this new tone [1] https://www.redhat.com/archives/libvir-list/2019-December/msg01016.html Daniel Henrique Barboza (4): Introducing new address type='unassigned' for PCI hostdevs qemu: handle unassigned PCI hostdevs in command line formatdomain.html.in: document <address type='unassigned'/> news.xml: add address type='unassigned' entry docs/formatdomain.html.in | 13 +++++ docs/news.xml | 14 +++++ docs/schemas/domaincommon.rng | 5 ++ src/conf/device_conf.c | 2 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 7 ++- src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 5 ++ .../hostdev-pci-address-unassigned.args | 31 ++++++++++ .../hostdev-pci-address-unassigned.xml | 42 ++++++++++++++ tests/qemuxml2argvtest.c | 4 ++ .../hostdev-pci-address-unassigned.xml | 58 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 14 files changed, 188 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-unassigned.xml -- 2.23.0

2 8

[libvirt] [PATCH] qemu: homogenize MAC address in live & config when hotplugging a netdev
by Laine Stump 17 Dec '19

17 Dec '19

Prior to commit 55ce6564634 (first in libvirt 4.6.0), the XML sent to virDomainAttachDeviceFlags() was parsed only once, and the results of that parse were inserted into both the live object of the running domain and into the persistent config. Thus, if MAC address was omitted from in XML for a network device (<interface>), both the live and config object would have the same MAC address. Commit 55ce6564634 changed the code to parse the incoming XML twice - once for live and once for config. This does eliminate the problem of PCI (/scsi/sata) address conflicts caused by allocating an address based on existing devices in live object, but then inserting the result into the config (which may already have a device using that address), BUT it also means that when the MAC address of a network device hasn't been specified in the XML, each copy will get a different auto-generated MAC address. This results in the MAC address of the device changing the next time the domain is shutdown and restarted, which creates havoc with the guest OS's network config. There have been several discussions about this in the last > 1 year, attempting to find the ideal solution to this problem that makes MAC addresses consistent and accounts for all sorts of corner cases with PCI/scsi/sata addresses. All of these discussions fizzled out because every proposal was either too difficult to implement or failed to fix some esoteric case someone thought up. So, in the interest of solving the MAC address problem while not making the "other address" situation any worse than before, this patch simply adds a qemuDomainAttachDeviceLiveAndConfigHomogenize() function that (for now) copies the MAC address from the config object to the live object (if the original xml had <mac address='blah'/> then this will be an effective NOP (as the macs already match)). Any downstream libvirt containing upstream commit 55ce6564634 should have this patch as well. https://bugzilla.redhat.com/1783411 Signed-off-by: Laine Stump <laine(a)redhat.com> --- src/qemu/qemu_driver.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 924f01d3eb..19ddff80b5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8623,6 +8623,30 @@ qemuDomainUpdateDeviceConfig(virDomainDefPtr vmdef, return 0; } + +static void +qemuDomainAttachDeviceLiveAndConfigHomogenize(const virDomainDeviceDef *devConf, + virDomainDeviceDefPtr devLive) +{ + /* + * fixup anything that needs to be identical in the live and + * config versions of DeviceDef, but might not be. Do this by + * changing the contents of devLive. + */ + + /* MAC address should be identical in both DeviceDefs, but if it + * wasn't specified in the XML, and was instead autogenerated, it + * will be different for the two since they are each the result of + * a separate parser call. If it *was* specified, it will already + * be the same, so copying does no harm. + */ + + if (devConf->type == VIR_DOMAIN_DEVICE_NET) + virMacAddrSet(&devLive->data.net->mac, &devConf->data.net->mac); + +} + + static int qemuDomainAttachDeviceLiveAndConfig(virDomainObjPtr vm, virQEMUDriverPtr driver, @@ -8633,6 +8657,7 @@ qemuDomainAttachDeviceLiveAndConfig(virDomainObjPtr vm, virDomainDefPtr vmdef = NULL; g_autoptr(virQEMUDriverConfig) cfg = NULL; virDomainDeviceDefPtr devConf = NULL; + virDomainDeviceDef devConfSave = { 0 }; virDomainDeviceDefPtr devLive = NULL; int ret = -1; unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | @@ -8657,6 +8682,13 @@ qemuDomainAttachDeviceLiveAndConfig(virDomainObjPtr vm, parse_flags))) goto cleanup; + /* + * devConf will be NULLed out by + * qemuDomainAttachDeviceConfig(), so save it for later use by + * qemuDomainDeviceLiveAndConfigHomogenize() + */ + devConfSave = *devConf; + if (virDomainDeviceValidateAliasForHotplug(vm, devConf, VIR_DOMAIN_AFFECT_CONFIG) < 0) goto cleanup; @@ -8678,6 +8710,9 @@ qemuDomainAttachDeviceLiveAndConfig(virDomainObjPtr vm, parse_flags))) goto cleanup; + if (flags & VIR_DOMAIN_AFFECT_CONFIG) + qemuDomainAttachDeviceLiveAndConfigHomogenize(&devConfSave, devLive); + if (virDomainDeviceValidateAliasForHotplug(vm, devLive, VIR_DOMAIN_AFFECT_LIVE) < 0) goto cleanup; -- 2.23.0

2 2

[libvirt] [PATCH 0/4] qemu: Error out if backing image format is not recorded in image metadata
by Peter Krempa 17 Dec '19

17 Dec '19

See patch 3/4 for explanation. Peter Krempa (4): tests: storage: Use strict version of virStorageFileGetMetadata tests: storage: Remove unused test modes util: storage: Don't treat files with missing backing store format as 'raw' kbase: Add document outlining backing chain XML config and troubleshooting docs/kbase.html.in | 4 + docs/kbase/backing_chains.rst | 185 ++++++++++++++++++++++++++++++++++ src/util/virstoragefile.c | 21 +++- tests/virstoragetest.c | 42 +++----- 4 files changed, 221 insertions(+), 31 deletions(-) create mode 100644 docs/kbase/backing_chains.rst -- 2.23.0

3 7

[libvirt] [PATCH v2 00/12] esx: various improvements
by Pino Toscano 17 Dec '19

17 Dec '19

- implement connectListAllStoragePools, so virConnectListAllStoragePools() works - implement connectListAllNetworks, so virConnectListAllNetworks() works - implement storagePoolListAllVolumes, so virStoragePoolListAllVolumes() works - set the proper filesystem type for vmfs-based datastores Pino Toscano (12): esx: split datastoreToStoragePoolPtr helper esx: split datastorePoolType helper esx: split targetToStoragePool helper esx: implement connectListAllStoragePools esx: split virtualswitchToNetwork helper esx: implement connectListAllNetworks storage: add vmfs filesystem type esx: set vmfs fs type for vmfs-based datastores esx: split datastorePathToStorageVol helper esx: split scsilunToStorageVol helper esx: implement storagePoolListAllVolumes docs: document implemented APIs in esx docs/news.xml | 11 + docs/schemas/storagepool.rng | 1 + docs/schemas/storagevol.rng | 1 + docs/storage.html.in | 3 + src/conf/storage_conf.c | 1 + src/conf/storage_conf.h | 1 + src/esx/esx_network_driver.c | 100 +++++- src/esx/esx_storage_backend_iscsi.c | 234 +++++++++++--- src/esx/esx_storage_backend_vmfs.c | 306 +++++++++++++++--- src/esx/esx_storage_driver.c | 87 +++++ .../storagepoolcapsschemadata/poolcaps-fs.xml | 1 + .../poolcaps-full.xml | 1 + 12 files changed, 655 insertions(+), 92 deletions(-) -- 2.21.0

3 23

[libvirt] [PATCH v4 0/5] PCI hostdev partial assignment support
by Daniel Henrique Barboza 17 Dec '19

17 Dec '19

changes from version 3 [1]: - removed last 2 patches that made function 0 of PCI multifunction devices mandatory - new patch: news.xml update - changed 'since' version to 6.0.0 in patch 4 - unassigned hostdevs are now getting qemu aliases [1] https://www.redhat.com/archives/libvir-list/2019-November/msg01263.html Daniel Henrique Barboza (5): Introducing new address type='unassigned' for PCI hostdevs qemu: handle unassigned PCI hostdevs in command line virhostdev.c: check all IOMMU devs in virHostdevPreparePCIDevices formatdomain.html.in: document <address type='unassigned'/> news.xml: add address type='unassigned' entry docs/formatdomain.html.in | 14 ++++ docs/news.xml | 19 ++++++ docs/schemas/domaincommon.rng | 5 ++ src/conf/device_conf.c | 2 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 7 +- src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 5 ++ src/util/virhostdev.c | 64 +++++++++++++++++-- .../hostdev-pci-address-unassigned.args | 31 +++++++++ .../hostdev-pci-address-unassigned.xml | 42 ++++++++++++ tests/qemuxml2argvtest.c | 4 ++ .../hostdev-pci-address-unassigned.xml | 58 +++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 15 files changed, 251 insertions(+), 8 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-unassigned.xml -- 2.23.0

4 19

[libvirt] [PATCH 0/4] Rewrite virGetUser*Directory() functions using g_get_*_dir()
by Fabiano Fidêncio 17 Dec '19

17 Dec '19

By rewriting virGetUser*Directory() functions using g_get_*_dir() functions allows us to drop all the different implementations we keep, as GLib already takes care of those for us. Fabiano Fidêncio (4): util: Rewrite virGetUserDirectory() using g_get_home_dir() util: Rewrite virGetUserConfigDirectory() using g_get_user_config_dir() util: Rewrite virGetUserCacheDirectory() using g_get_user_cache_dir() util: Rewrite virGetUserRuntimeDirectory() using g_get_user_runtime_dir() src/util/virutil.c | 146 +++++++++++++-------------------------------- 1 file changed, 40 insertions(+), 106 deletions(-) -- 2.23.0

1 4

[libvirt] [PATCH] tests: securityselinuxlabel: Add QEMU_CAPS_VNC to fake qemuCaps
by Peter Krempa 17 Dec '19

17 Dec '19

In commit 45270337f057f26ce484f6e forgot to make sure that tests pass. Add the missing capability to fix the test. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed. tests/securityselinuxlabeltest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/securityselinuxlabeltest.c b/tests/securityselinuxlabeltest.c index 192f2dc84f..3040a36693 100644 --- a/tests/securityselinuxlabeltest.c +++ b/tests/securityselinuxlabeltest.c @@ -351,6 +351,7 @@ mymain(void) return EXIT_FAILURE; virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_CIRRUS_VGA); + virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC); if (qemuTestCapsCacheInsert(driver.qemuCapsCache, qemuCaps) < 0) return EXIT_FAILURE; -- 2.23.0

2 1

[libvirt] [PATCH 0/9] Cleanup virConnectPtr usage
by Michal Privoznik 17 Dec '19

17 Dec '19

I've noticed this problem when reviewing a patch on the list [1]. Long story short, dom->conn is not guaranteed to have all driver pointers set (consider split daemons). I haven't identified any other violation than what I'm fixing here. But something might have slipped through my git grep. 1: https://www.redhat.com/archives/libvir-list/2019-December/msg00120.html Michal Prívozník (9): qemu_driver: Push qemuDomainInterfaceAddresses() a few lines down qemu: Don't use dom->conn to lookup virNetwork qemuGetDHCPInterfaces: Move some variables inside the loop qemuGetDHCPInterfaces: Switch to GLib libxl: Don't use dom->conn to lookup virNetwork libxlGetDHCPInterfaces: Move some variables inside the loop libxlGetDHCPInterfaces: Switch to GLib lxc: Cleanup virConnectPtr usage get_nonnull_domain: Drop useless comment src/libxl/libxl_driver.c | 71 ++++------ src/lxc/lxc_driver.c | 12 +- src/lxc/lxc_process.c | 40 +++--- src/lxc/lxc_process.h | 2 +- src/qemu/qemu_driver.c | 193 ++++++++++++---------------- src/remote/remote_daemon_dispatch.c | 3 - 6 files changed, 139 insertions(+), 182 deletions(-) -- 2.23.0

2 10

[libvirt] [PATCH] cpu_map/x86: Add support for BFLOAT16 data type
by Jiri Denemark 17 Dec '19

17 Dec '19

Introduced in QEMU by commit v4.1.0-266-g80db491da4. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu_map/x86_features.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b42b490160..eefb55067e 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -339,6 +339,10 @@ <cpuid eax_in='0x07' ecx_in='0x00' edx='0x80000000'/> </feature> + <feature name='avx512-bf16'> + <cpuid eax_in='0x07' ecx_in='0x01' eax='0x00000020'/> + </feature> +  <feature name='xsaveopt'> <cpuid eax_in='0x0d' ecx_in='0x01' eax='0x00000001'/> -- 2.24.1

2 1

[libvirt] [PATCH] virsh migrate: Require --tls for --tls-destination
by Jiri Denemark 17 Dec '19

17 Dec '19

--tls-destination would be just ignored unless --tls is not specified, which is correct, but let's provide a bit of a guidance is a user forgets to add --tls. https://bugzilla.redhat.com/show_bug.cgi?id=1784345 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 56137bdd74..e7e92ee60d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10966,6 +10966,7 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) VSH_REQUIRE_OPTION("postcopy-after-precopy", "postcopy"); VSH_REQUIRE_OPTION("timeout-postcopy", "postcopy"); VSH_REQUIRE_OPTION("persistent-xml", "persistent"); + VSH_REQUIRE_OPTION("tls-destination", "tls"); if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return false; -- 2.24.1

2 3

[libvirt] [glib PATCH 0/2] po: change over to use Weblate instead of Zanata
by Daniel P. Berrangé 17 Dec '19

17 Dec '19

Zanata is dead upstream, and Fedora is replacing it with Weblate https://fedoraproject.org/wiki/L10N_Move_to_Weblate Libvirt has outsourced its translations to the Fedora translation team, so we must follow this move. Daniel P. Berrangé (2): po: delete empty translation files po: change update rules to use weblate instead of zanata po/Makefile.am | 32 +++++++++++++++++++------------- po/af.mini.po | 20 -------------------- po/am.mini.po | 20 -------------------- po/anp.mini.po | 19 ------------------- po/ar.mini.po | 21 --------------------- po/as.mini.po | 20 -------------------- po/ast.mini.po | 20 -------------------- po/bal.mini.po | 20 -------------------- po/be.mini.po | 21 --------------------- po/bg.mini.po | 20 -------------------- po/bn.mini.po | 20 -------------------- po/bn_IN.mini.po | 20 -------------------- po/bo.mini.po | 20 -------------------- po/br.mini.po | 20 -------------------- po/brx.mini.po | 20 -------------------- po/bs.mini.po | 21 --------------------- po/cy.mini.po | 21 --------------------- po/da.mini.po | 20 -------------------- po/de.mini.po | 20 -------------------- po/de_CH.mini.po | 20 -------------------- po/el.mini.po | 20 -------------------- po/eo.mini.po | 20 -------------------- po/et.mini.po | 20 -------------------- po/eu.mini.po | 20 -------------------- po/fa.mini.po | 20 -------------------- po/gl.mini.po | 20 -------------------- po/gu.mini.po | 20 -------------------- po/he.mini.po | 20 -------------------- po/hr.mini.po | 21 --------------------- po/hu.mini.po | 20 -------------------- po/ia.mini.po | 20 -------------------- po/id.mini.po | 20 -------------------- po/ilo.mini.po | 20 -------------------- po/is.mini.po | 20 -------------------- po/it.mini.po | 20 -------------------- po/ka.mini.po | 20 -------------------- po/kk.mini.po | 20 -------------------- po/km.mini.po | 20 -------------------- po/kn.mini.po | 20 -------------------- po/ko.mini.po | 20 -------------------- po/kw.mini.po | 20 -------------------- po/kw(a)kkcor.mini.po | 20 -------------------- po/kw(a)uccor.mini.po | 20 -------------------- po/kw_GB.mini.po | 20 -------------------- po/ky.mini.po | 20 -------------------- po/lt.mini.po | 21 --------------------- po/lv.mini.po | 21 --------------------- po/mai.mini.po | 20 -------------------- po/mk.mini.po | 20 -------------------- po/ml.mini.po | 20 -------------------- po/mn.mini.po | 20 -------------------- po/mr.mini.po | 20 -------------------- po/ms.mini.po | 20 -------------------- po/nb.mini.po | 20 -------------------- po/nds.mini.po | 20 -------------------- po/ne.mini.po | 20 -------------------- po/nl.mini.po | 20 -------------------- po/nn.mini.po | 20 -------------------- po/nso.mini.po | 20 -------------------- po/or.mini.po | 20 -------------------- po/pa.mini.po | 20 -------------------- po/pt.mini.po | 20 -------------------- po/ro.mini.po | 21 --------------------- po/si.mini.po | 20 -------------------- po/sk.mini.po | 20 -------------------- po/sl.mini.po | 21 --------------------- po/sq.mini.po | 20 -------------------- po/sr.mini.po | 21 --------------------- po/sr(a)latin.mini.po | 21 --------------------- po/sv.mini.po | 20 -------------------- po/ta.mini.po | 20 -------------------- po/te.mini.po | 20 -------------------- po/tg.mini.po | 20 -------------------- po/th.mini.po | 20 -------------------- po/tr.mini.po | 20 -------------------- po/tw.mini.po | 19 ------------------- po/ur.mini.po | 20 -------------------- po/vi.mini.po | 20 -------------------- po/wba.mini.po | 19 ------------------- po/yo.mini.po | 19 ------------------- po/zanata.xml | 7 ------- po/zh_CN.mini.po | 20 -------------------- po/zh_HK.mini.po | 20 -------------------- po/zh_TW.mini.po | 20 -------------------- po/zu.mini.po | 20 -------------------- 85 files changed, 19 insertions(+), 1687 deletions(-) delete mode 100644 po/af.mini.po delete mode 100644 po/am.mini.po delete mode 100644 po/anp.mini.po delete mode 100644 po/ar.mini.po delete mode 100644 po/as.mini.po delete mode 100644 po/ast.mini.po delete mode 100644 po/bal.mini.po delete mode 100644 po/be.mini.po delete mode 100644 po/bg.mini.po delete mode 100644 po/bn.mini.po delete mode 100644 po/bn_IN.mini.po delete mode 100644 po/bo.mini.po delete mode 100644 po/br.mini.po delete mode 100644 po/brx.mini.po delete mode 100644 po/bs.mini.po delete mode 100644 po/cy.mini.po delete mode 100644 po/da.mini.po delete mode 100644 po/de.mini.po delete mode 100644 po/de_CH.mini.po delete mode 100644 po/el.mini.po delete mode 100644 po/eo.mini.po delete mode 100644 po/et.mini.po delete mode 100644 po/eu.mini.po delete mode 100644 po/fa.mini.po delete mode 100644 po/gl.mini.po delete mode 100644 po/gu.mini.po delete mode 100644 po/he.mini.po delete mode 100644 po/hr.mini.po delete mode 100644 po/hu.mini.po delete mode 100644 po/ia.mini.po delete mode 100644 po/id.mini.po delete mode 100644 po/ilo.mini.po delete mode 100644 po/is.mini.po delete mode 100644 po/it.mini.po delete mode 100644 po/ka.mini.po delete mode 100644 po/kk.mini.po delete mode 100644 po/km.mini.po delete mode 100644 po/kn.mini.po delete mode 100644 po/ko.mini.po delete mode 100644 po/kw.mini.po delete mode 100644 po/kw(a)kkcor.mini.po delete mode 100644 po/kw(a)uccor.mini.po delete mode 100644 po/kw_GB.mini.po delete mode 100644 po/ky.mini.po delete mode 100644 po/lt.mini.po delete mode 100644 po/lv.mini.po delete mode 100644 po/mai.mini.po delete mode 100644 po/mk.mini.po delete mode 100644 po/ml.mini.po delete mode 100644 po/mn.mini.po delete mode 100644 po/mr.mini.po delete mode 100644 po/ms.mini.po delete mode 100644 po/nb.mini.po delete mode 100644 po/nds.mini.po delete mode 100644 po/ne.mini.po delete mode 100644 po/nl.mini.po delete mode 100644 po/nn.mini.po delete mode 100644 po/nso.mini.po delete mode 100644 po/or.mini.po delete mode 100644 po/pa.mini.po delete mode 100644 po/pt.mini.po delete mode 100644 po/ro.mini.po delete mode 100644 po/si.mini.po delete mode 100644 po/sk.mini.po delete mode 100644 po/sl.mini.po delete mode 100644 po/sq.mini.po delete mode 100644 po/sr.mini.po delete mode 100644 po/sr(a)latin.mini.po delete mode 100644 po/sv.mini.po delete mode 100644 po/ta.mini.po delete mode 100644 po/te.mini.po delete mode 100644 po/tg.mini.po delete mode 100644 po/th.mini.po delete mode 100644 po/tr.mini.po delete mode 100644 po/tw.mini.po delete mode 100644 po/ur.mini.po delete mode 100644 po/vi.mini.po delete mode 100644 po/wba.mini.po delete mode 100644 po/yo.mini.po delete mode 100644 po/zanata.xml delete mode 100644 po/zh_CN.mini.po delete mode 100644 po/zh_HK.mini.po delete mode 100644 po/zh_TW.mini.po delete mode 100644 po/zu.mini.po -- 2.23.0

2 4

[libvirt] [PATCH v3 00/30] Introduce NVMe support
by Michal Privoznik 17 Dec '19

17 Dec '19

v3 of: https://www.redhat.com/archives/libvir-list/2019-September/msg01209.html Builds just fine ;-) https://travis-ci.org/zippy2/libvirt/builds/619622349 diff to v2: - Fixed bug reported by Cole - unability to plug regular <hostdev/>-s caused by v2. Michal Prívozník (30): qemu: Explicitly add/remove /dev/vfio/vfio to/from NS/CGroups qemuDomainGetHostdevPath: Use more g_autoptr()/g_autofree qemuDomainGetHostdevPath: Don't include /dev/vfio/vfio in returned paths qemu: Drop some 'cleanup' labels virpci: Introduce and use virPCIDeviceAddressGetIOMMUGroupDev virHostdevPreparePCIDevices: Separate out function body virHostdevReAttachPCIDevices: Separate out function body virpci: Introduce virPCIDeviceAddressCopy qemuMigrationSrcIsSafe: Rework slightly schemas: Introduce disk type NVMe conf: Format and parse NVMe type disk virstoragefile: Introduce virStorageSourceChainHasNVMe domain_conf: Introduce virDomainDefHasNVMeDisk util: Introduce virNVMeDevice module virhostdev: Include virNVMeDevice module virpcimock: Introduce NVMe driver and devices virhostdevtest: Test virNVMeDevice assignment qemu: prepare NVMe devices too qemu: Take NVMe disks into account when calculating memlock limit qemu: Create NVMe disk in domain namespace qemu: Mark NVMe disks as 'need VFIO' qemu: Allow NVMe disk in CGroups virSecuritySELinuxRestoreImageLabelInt: Don't skip non-local storage qemu_capabilities: Introduce QEMU_CAPS_DRIVE_NVME qemu: Generate command line of NVMe disks qemu_monitor_text: Catch IOMMU/VFIO related errors in qemuMonitorTextAddDrive qemu: Don't leak storage perms on failure in qemuDomainAttachDiskGeneric qemu: Allow forcing VFIO when computing memlock limit qemu_hotplug: Prepare NVMe disks on hotplug virsh: Introduce nvme disk to domblklist docs/formatdomain.html.in | 57 ++- docs/schemas/domaincommon.rng | 32 ++ po/POTFILES.in | 1 + src/conf/domain_conf.c | 109 +++++ src/conf/domain_conf.h | 3 + src/libvirt_private.syms | 28 ++ src/libxl/xen_xl.c | 1 + src/qemu/qemu_block.c | 25 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 203 +++++--- src/qemu/qemu_command.c | 6 +- src/qemu/qemu_domain.c | 375 +++++++++------ src/qemu/qemu_domain.h | 15 +- src/qemu/qemu_driver.c | 4 + src/qemu/qemu_hostdev.c | 71 ++- src/qemu/qemu_hostdev.h | 16 + src/qemu/qemu_hotplug.c | 31 +- src/qemu/qemu_migration.c | 30 +- src/qemu/qemu_monitor_text.c | 7 + src/qemu/qemu_process.c | 7 + src/security/security_apparmor.c | 25 +- src/security/security_dac.c | 30 ++ src/security/security_selinux.c | 51 +- src/util/Makefile.inc.am | 2 + src/util/virhostdev.c | 431 +++++++++++++++-- src/util/virhostdev.h | 37 ++ src/util/virnvme.c | 447 ++++++++++++++++++ src/util/virnvme.h | 97 ++++ src/util/virpci.c | 29 ++ src/util/virpci.h | 5 + src/util/virstoragefile.c | 71 +++ src/util/virstoragefile.h | 19 + .../caps_2.12.0.aarch64.xml | 1 + .../caps_2.12.0.ppc64.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../caps_2.12.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + .../caps_3.0.0.riscv32.xml | 1 + .../caps_3.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + .../caps_3.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + .../caps_3.1.0.x86_64.xml | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + tests/qemumemlocktest.c | 2 +- .../disk-nvme.x86_64-latest.args | 63 +++ tests/qemuxml2argvdata/disk-nvme.xml | 63 +++ tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/disk-nvme.xml | 1 + tests/qemuxml2xmltest.c | 1 + tests/virhostdevtest.c | 97 ++++ tests/virpcimock.c | 3 + tests/virpcitestdata/0000-01-00.0.config | Bin 0 -> 4096 bytes tests/virpcitestdata/0000-02-00.0.config | Bin 0 -> 4096 bytes tools/virsh-domain-monitor.c | 31 +- 66 files changed, 2240 insertions(+), 312 deletions(-) create mode 100644 src/util/virnvme.c create mode 100644 src/util/virnvme.h create mode 100644 tests/qemuxml2argvdata/disk-nvme.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-nvme.xml create mode 120000 tests/qemuxml2xmloutdata/disk-nvme.xml create mode 100644 tests/virpcitestdata/0000-01-00.0.config create mode 100644 tests/virpcitestdata/0000-02-00.0.config -- 2.23.0

3 67

[libvirt] [PATCH 0/2] build: -Wframe-larger-than shenanigans
by Ján Tomko 17 Dec '19

17 Dec '19

The recent cputest addition broke the build with clang for me, since clang calculates the stack size differently than gcc. Put the strict limit into all warning by default (this starts enforcing it for examples, for example) and raise the limit by a few orders, which might appear Sisyphean but I believe it's needed for putting two conflicting limits on the compiler command line. Ján Tomko (2): build: warn on a large frame by default build: relax the relaxed stack frame limit further m4/virt-compile-warnings.m4 | 4 ++-- src/Makefile.am | 2 -- tools/Makefile.am | 2 -- 3 files changed, 2 insertions(+), 6 deletions(-) -- 2.19.2

2 4

[libvirt] [PATCH] virtio-blk: deprecate SCSI passthrough
by Stefan Hajnoczi 17 Dec '19

17 Dec '19

The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough support. Deprecate this feature in QEMU too. Signed-off-by: Stefan Hajnoczi <stefanha(a)redhat.com> --- qemu-deprecated.texi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 4b4b7425ac..ef94d497da 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -285,6 +285,17 @@ spec you can use the ``-cpu rv64gcsu,priv_spec=v1.9.1`` command line argument. @section Device options +@subsection Emulated device options + +@subsubsection -device virtio-blk,scsi=on|off (since 5.0.0) + +The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature. VIRTIO 1.0 +and later do not support it because the virtio-scsi device was introduced for +full SCSI support. Use virtio-scsi instead when SCSI passthrough is required. + +Note this also applies to ``-device virtio-blk-pci,scsi=on|off'', which is an +alias. + @subsection Block device options @subsubsection "backing": "" (since 2.12.0) -- 2.23.0

6 7

[libvirt] [PATCH 0/5] Introduce the support of Intel RDT-MBM
by Wang Huaqiang 17 Dec '19

17 Dec '19

RDT is the short for Intel Resource Director Technology, consists of four sub-technologies until now: -. CAT for cache allocation -. CMT for cache usage monitoring -. MBA for memory bandwidth allocation -. MBM for memory bandwidth usage monitoring The Linux kernel interface is 'resctrl' file system, and we have already implemented the support of CAT, CMT and MBA, to accomplish the tasks such as allocating a part of shared CPU last level cache to particular domain vcpu or a list of vcpus and monitoring the usage of cache, or the task of allocating a mount of memory bandwidth to specify domain vcpu(s). This series is to introduce the support of MBM. Basically the interfaces are: ** Identify host capability ** Similar to identify the host capability of CMT, it could be gotten through the result of 'virsh capabilities', if following elements are found, then MBM is supported: <memory_bandwidth> <monitor maxMonitors='176'> <feature name='mbm_total_bytes'/> <feature name='mbm_local_bytes'/> </monitor> </memory_bandwidth> 'mbm_total_bytes' means supporting to report the memory bandwidth used by the vcpu(s) of specific monitor on all CPU sockets. 'mbm_local_bytes' means supporting to report the memory bandwidth used by vcpu(s) that is passing through local CPU socket. ** Create monitor group** The monitor group for specific domain vcpus, for example vcpu 0-4, is defined in domain configuration file, in such kind of way: <cputune> <memorytune vcpus='0-4'> <monitor vcpus='0-4'/> </memorytune> </cputune> ** Report memory usage ** Introduced an option '--memory' against 'virsh domstats' command to show the memory bandwidth usage in such way: (also very similar to the format of CMT result.) # virsh domstats --memory Domain: 'libvirt-vm' memory.bandwidth.monitor.count=4 memory.bandwidth.monitor.0.name=vcpus_0-4 memory.bandwidth.monitor.0.vcpus=0-4 memory.bandwidth.monitor.0.node.count=2 memory.bandwidth.monitor.0.node.0.id=0 memory.bandwidth.monitor.0.node.0.bytes.total=14201651200 memory.bandwidth.monitor.0.node.0.bytes.local=7369809920 memory.bandwidth.monitor.0.node.1.id=1 memory.bandwidth.monitor.0.node.1.bytes.total=188897640448 memory.bandwidth.monitor.0.node.1.bytes.local=170044047360 Huaqiang (5): util, resctrl: using 64bit interface instead of 32bit for counters conf: showing cache/memoryBW monitor features in capabilities cachetune schema: a looser check for the order of <cache> and <monitor> element conf: Parse dommon configure file for memorytune monitors virsh: show memoryBW info in 'virsh domstats' command docs/schemas/domaincommon.rng | 91 +++++++++--------- include/libvirt/libvirt-domain.h | 1 + src/conf/capabilities.c | 4 +- src/conf/domain_conf.c | 44 +++++++-- src/libvirt-domain.c | 21 +++++ src/qemu/qemu_driver.c | 103 ++++++++++++++++++++- src/util/virfile.c | 40 ++++++++ src/util/virfile.h | 2 + src/util/virresctrl.c | 6 +- src/util/virresctrl.h | 2 +- tests/genericxml2xmlindata/cachetune.xml | 1 + tests/genericxml2xmlindata/memorytune.xml | 5 + tests/genericxml2xmloutdata/cachetune.xml | 34 +++++++ tests/genericxml2xmloutdata/memorytune.xml | 42 +++++++++ tests/genericxml2xmltest.c | 4 +- tools/virsh-domain-monitor.c | 7 ++ tools/virsh.pod | 23 ++++- 17 files changed, 367 insertions(+), 63 deletions(-) create mode 100644 tests/genericxml2xmloutdata/cachetune.xml create mode 100644 tests/genericxml2xmloutdata/memorytune.xml -- 2.23.0

4 17

[libvirt] [PATCH v1 00/26] move qemucaps validations from qemu_command to qemu_domain
by Daniel Henrique Barboza 16 Dec '19

16 Dec '19

(series based on master commit 97cafa610ecf5) This work was proposed by Cole in [1]. This is Cole's reasoning for it, copy/pasted from [1]: ------- The benefits of moving to validate time is that XML is rejected by 'virsh define' rather than at 'virsh start' time. It also makes it easier to follow the cli building code, and makes it easier to verify qemu_command.c test suite code coverage for the important stuff like covering every CLI option. It's also a good intermediate step for sharing validation with domain capabilities building, like is done presently for rng models. ------- Cole also mentioned that the machine features validation was a good place to start. I took it a step further and did it across the board on all qemu_command.c. This series didn't create any new validation, just moved them to domain define time. Any other outcome is unintended. Not all cases where covered in this work. For a first version I decided to do only the most trivial cases. These are the other cases I left out for another day: - all verifications contained in functions that are also called by qemu_hotplug.c. This means that the hotplug process will also use the validation code, and we can't just move it to qemu_domain.c. Besides, not all validation done in domain define time applies to hotplug, so it's not simply a matter of calling the same function from qemu_domain in qemu_hotplug. I have patches that moved the verification of all virtio options to qemu_domain.c, while also considering qemu_hotplug validation. In the end I decided to leave it away from this work for now because (1) it took 8 patches just for virtio case alone and (2) there are a lot of these cases in qemu_command.c and it would be too much to do it all at in this same series. - moving CPU Model validation is trickier than the rest because there are code in DefPostParse() that makes CPU Model changes that are then validated in qemu_command.c. Moving the validation to define time doesn't cut in this case - the validation is considering PostParse changes in the CPU Model and some of the will fail if done by qemuDomainDefValidate time. I didn't think too much about how to handle this case, but given that the approach would be different from the other cases handled here, I left it out too. - SHMem: part of SHMem validation is being used by hotplug code. I could've moved the non-hotplug validation to define time, instead I decided it's better to to leave it to do it all at once in the future. - DBus-VMState: validation of this fella must be done by first querying if the hash vm->priv->dbusVMState has elements. qemuDomainDefValidate does not have 'vm->priv' in it's API, meaning that I would need to either change the API to include it (which means changing domainValidateCallback), or do the validation by another branch where I can get access to vm->priv. - vmcoreinfo: there are no challenges in moving vmcoreinfo validation to qemuDomainDefValidate. The problem were the unit tests. Moving this validation to domain define time breaks 925 tests on qemuxml2xmltest.c, including tests labelled as 'minimal' which should pass under any circurstances, as far as I understand. It is possible to just shoehorn QEMU_CAPS_DEVICE_VMCOREINFO in the qemuCaps of all tests, but this would tamper the idea of having to deal with NONE or LATEST or a specific set of capabilities for certain tests. Another case I would rather discuss separately. [1] https://www.redhat.com/archives/libvir-list/2019-October/msg00568.html Daniel Henrique Barboza (26): qemu_command.c: move PSeries features validation to qemu_domain.c qemu_command.c: move mem.nosharepages validation to qemu_domain.c qemu_command.c: move validation of vmport to qemu_domain.c qemu_command.c: move nvdimm validation to qemu_domain.c qemu_command.c: move I/O APIC validation to qemu_domain.c numa_conf: add virDomainNumaNodesDistancesAreBeingSet() helper qemu_command.c move NUMA validation to qemu_domain.c qemu_command.c: move NVRAM validation to qemu_domain.c qemu_command: move qemuBuildSoundDevStr caps validation to qemu_domain qemu_command.c: move sound codec validation to qemu_domain.c qemu_command: move qemuBuildHubDevStr caps validation to qemu_domain qemu_command: move qemuBuildChrChardevStr caps validation to qemu_domain qemu: move qemuBuildHostdevCommandLine caps validation to qemu_domain qemu_command.c: move vmGenID validation to qemu_domain.c qemu: move qemuBuildSgaCommandLine validation to qemu_domain.c qemu: move virDomainClockDef validation to qemu_domain.c qemu: move qemuBuildPMCommandLine validation to qemu_domain.c qemu: move qemuBuildBootCommandLine validation to qemu_domain.c qemu_command.c: move pcihole64 validation to qemu_domain.c qemu: move qemuBuildGraphicsSDLCommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsVNCCommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsSPICECommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsEGLHeadlessCommandLine validation to qemu_domain.c qemu: move qemuBuildSmartcardCommandLine validation to qemu_domain.c qemu: move qemuBuildConsoleCommandLine validation to qemu_domain.c qemu: move qemuBuildTPMDevStr TPM validation to qemu_domain.c src/conf/numa_conf.c | 19 + src/conf/numa_conf.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 575 +--------- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 983 ++++++++++++++++-- tests/qemuhotplugtest.c | 10 + tests/qemumemlocktest.c | 16 +- .../default-video-type-aarch64.xml | 2 +- .../default-video-type-ppc64.xml | 2 +- .../default-video-type-s390x.xml | 2 +- .../graphics-egl-headless.args | 2 +- .../graphics-spice-egl-headless.args | 2 +- .../graphics-vnc-egl-headless.args | 2 +- tests/qemuxml2argvtest.c | 80 +- ...ault-video-type-aarch64.aarch64-latest.xml | 4 +- .../default-video-type-ppc64.ppc64-latest.xml | 4 +- .../default-video-type-s390x.s390x-latest.xml | 4 +- tests/qemuxml2xmltest.c | 244 +++-- 19 files changed, 1246 insertions(+), 709 deletions(-) -- 2.23.0

4 42

[libvirt] [PATCH v6 0/4] scripts: convert most perl scripts to python
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

This series is an effort to reduce the number of different languages we use by eliminating most use of perl in favour of python. This aligns with fact that the likely future build system we'll use (meson) is written in python, and that python is much more commonly used/understood by developers these days than perl. With this applied we use perl in a handful of places only: - src/rpc/gendispatch.pl - this is a horrendously large script and very hard to understand/follow. A straight syntax conversion to Python would still leave a hgue and hard to understand/follow script. It really needs a clean room rewrite from scratch, with better structure. - src/rpc/genprotocol.pl - fairly easy to convert, but might be obsolete depending on approach for rewriting gendispatch.pl, so ignored for now - tests/oomtrace.pl - will be purge by the patches that drop OOM handling anyway - tools/wireshark/util/genxdrstub.pl - a very large script, which I haven't got the courage to tackle yet. - cfg.mk/maint.mk - many syntax rules involve regexes which are fed to perl. Decision on what to do with syntax-check rules punted to another time. - build-aux/gitlog-to-changelog - build-aux/useless-if-before-free - Both pulled in from gnulib. Could be rewritten quite easily if desired, but given that we aren't maintainers of them right now, they're ignored as they don't really impact our developers. Note that the check-spacing.py script is significantly slower in Python than in Perl. After researching this it appears there is nothing that can be done. The Perl regex engine is simply much better optimized than the Python one. As previously discussed we need to loook at uncrustify or clang-format or some other tool to validate whitespace formatting. This is ongoing. We can either accept the slow down in the short term or keep the Perl version in the short term. In v6: - Fix various bugs in check-file-access.py so it now reports same output as original perl script. - Merged the already-ACKd scripts In v5: - Rebased to cope with changes to require VPATH build - Merged the already-ACKd scripts In v4: - Moved all scripts into the scripts/ directory instead of having them scattered around source tree - Use re.search instead of re.match - Don't bother re-compiling regexes In v3: - All scripts comply with all flake8 style rules with exception of E129 visually indented line with same indent as next logical line In v2: - Pulled in patch to hacking file - Converted many more scripts - Forced UTF-8 character set to avoid ascii codec on py3 < 3.7 Daniel P. Berrangé (4): tests: rewrite qemu capability grouper in Python tests: rewrite file access checker in Python docs: rewrite hvsupport.html page generator in python docs: rewrite polkit docs generator in Python Makefile.am | 4 + build-aux/syntax-check.mk | 3 +- docs/Makefile.am | 12 +- docs/genaclperms.pl | 125 -------- docs/hvsupport.pl | 459 ----------------------------- scripts/check-file-access.py | 125 ++++++++ scripts/genaclperms.py | 121 ++++++++ scripts/group-qemu-caps.py | 121 ++++++++ scripts/hvsupport.py | 502 ++++++++++++++++++++++++++++++++ tests/Makefile.am | 3 +- tests/check-file-access.pl | 130 --------- tests/file_access_whitelist.txt | 2 +- tests/group-qemu-caps.pl | 124 -------- 13 files changed, 882 insertions(+), 849 deletions(-) delete mode 100755 docs/genaclperms.pl delete mode 100755 docs/hvsupport.pl create mode 100755 scripts/check-file-access.py create mode 100755 scripts/genaclperms.py create mode 100755 scripts/group-qemu-caps.py create mode 100755 scripts/hvsupport.py delete mode 100755 tests/check-file-access.pl delete mode 100755 tests/group-qemu-caps.pl -- 2.21.0

2 5

[libvirt] [tck PATCH] Update x86_64 image & virt-builder image to F31
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

i386 was dropped even as a secondary arch in F31 so must remain on F30 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- conf/default.cfg | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index 39d9b04..3493ad7 100644 --- a/conf/default.cfg +++ b/conf/default.cfg @@ -49,7 +49,7 @@ images = ( hvm xen ) - osname = fedora-30 + osname = fedora-31 } ) @@ -76,6 +76,7 @@ images = ( # kernels = ( # Fedora 30 i686 PAE has pv_ops, so one kernel can do both Xen and KVM guests here + # No i386 releases since F30 { arch = i686 ostype = ( @@ -85,15 +86,15 @@ kernels = ( kernel = http://dl.fedoraproject.org/pub/fedora-secondary/releases/30/Everything/i38… initrd = http://dl.fedoraproject.org/pub/fedora-secondary/releases/30/Everything/i38… } - # Fedora 30 x86_64 has pv_ops, so one kernel can do both Xen and KVM guests here + # Fedora 31 x86_64 has pv_ops, so one kernel can do both Xen and KVM guests here { arch = x86_64 ostype = ( hvm xen ) - kernel = http://dl.fedoraproject.org/pub/fedora/linux/releases/30/Everything/x86_64/… - initrd = http://dl.fedoraproject.org/pub/fedora/linux/releases/30/Everything/x86_64/… + kernel = http://dl.fedoraproject.org/pub/fedora/linux/releases/31/Everything/x86_64/… + initrd = http://dl.fedoraproject.org/pub/fedora/linux/releases/31/Everything/x86_64/… } # LXC containers need a virtual container filesystem somewhere # { -- 2.23.0

2 1

[libvirt] ongoing code transitions section on the wiki
by Cole Robinson 16 Dec '19

16 Dec '19

Hi all, I added a 'Ongoing code transitions' section to the BiteSizedTasks page on the wiki: https://wiki.libvirt.org/page/BiteSizedTasks#Ongoing_code_transitions BiteSizedTasks might not be the best location for it, but I wanted to start a list and that page already exists. I added 3 sections: * g_autofree/g_autoptr, with some example conversion commits * GLib in general, listing APIs that can replace custom libvirt code. Currently the list is only g_key_file for virkeyfile, g_user_*_dir for virGetUser*Dir, some virFile APIs for g_path_* APIs. * gnulib removal. I filled in a few examples of possible gnulib module replacements, and listed all the others as 'Unsorted/replacments unclear'. If you know any GLib replacements for existing code or gnulib modules, please fill them in there. Or any other incomplete code conversions internally Thanks, Cole

1 0

[libvirt] [rust PATCH] Domain: Implement scheduler information related APIs
by Vineeth Remanan Pillai 16 Dec '19

16 Dec '19

Implement the following: - virDomainGetSchedulerType - virDomainSetSchedulerParameters - virDomainSetSchedulerParametersFlags - virDomainGetSchedulerParameters - virDomainGetSchedulerParametersFlags Signed-off-by: Vineeth Remanan Pillai <vpilllai(a)digitalocean.com> --- examples/hello.rs | 38 +++++++ src/domain.rs | 260 +++++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 283 insertions(+), 15 deletions(-) diff --git a/examples/hello.rs b/examples/hello.rs index e5ec6e4..1f336a9 100644 --- a/examples/hello.rs +++ b/examples/hello.rs @@ -89,6 +89,44 @@ fn show_domains(conn: &Connect) -> Result<(), Error> { numa.node_set.unwrap_or(String::from(""))); println!(" Mode: {}", numa.mode.unwrap_or(0)); } + + if let Ok((sched_type, nparams)) = dom.get_scheduler_type() { + println!("SchedType: {}, nparams: {}", + sched_type, nparams); + } + + if let Ok(sched_info) = dom.get_scheduler_parameters() { + println!("Schedule Information:"); + println!("\tScheduler\t: {}", sched_info.scheduler_type); + if let Some(shares) = sched_info.cpu_shares { + println!("\tcpu_shares\t: {}", shares); + } + if let Some(period) = sched_info.vcpu_bw.period { + println!("\tvcpu_period\t: {}", period); + } + if let Some(quota) = sched_info.vcpu_bw.quota { + println!("\tvcpu_quota\t: {}", quota); + } + if let Some(period) = sched_info.emulator_bw.period { + println!("\temulator_period\t: {}", period); + } + if let Some(quota) = sched_info.emulator_bw.quota { + println!("\temulator_quota\t: {}", quota); + } + if let Some(period) = sched_info.global_bw.period { + println!("\tglobal_period\t: {}", period); + } + if let Some(quota) = sched_info.global_bw.quota { + println!("\tglobal_quota\t: {}", quota); + } + if let Some(period) = sched_info.global_bw.period { + println!("\tiothread_period\t: {}", period); + } + if let Some(quota) = sched_info.global_bw.quota { + println!("\tiothread_quota\t: {}", quota); + } + } + } } return Ok(()); diff --git a/src/domain.rs b/src/domain.rs index acb9e6e..40a18d8 100644 --- a/src/domain.rs +++ b/src/domain.rs @@ -363,6 +363,29 @@ extern "C" { snaps: *mut *mut virDomainSnapshotPtr, flags: libc::c_uint) -> libc::c_int; + + fn virDomainGetSchedulerType(ptr: sys::virDomainPtr, + nparams: *mut libc::c_int) + -> *mut libc::c_char; + fn virDomainGetSchedulerParameters(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: *mut libc::c_int) + -> libc::c_int; + fn virDomainSetSchedulerParameters(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: libc::c_int) + -> libc::c_int; + fn virDomainGetSchedulerParametersFlags(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: *mut libc::c_int, + flags: libc::c_uint) + -> libc::c_int; + fn virDomainSetSchedulerParametersFlags(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: libc::c_int, + flags: libc::c_uint) + -> libc::c_int; + } pub type DomainXMLFlags = self::libc::c_uint; @@ -607,6 +630,124 @@ impl MemoryStats { } } +/// Structure representing the CFS scheduler cpu bandwidth parameters +/// see https://www.kernel.org/doc/html/latest/scheduler/sched-bwc.html +#[derive(Clone, Debug, Default)] +pub struct SchedBandwidth { + pub period: Option<u64>, + pub quota: Option<i64>, +} + +#[derive(Clone, Debug, Default)] +pub struct SchedulerInfo { + pub scheduler_type: String, + // cpu shares for the domain. + pub cpu_shares: Option<u64>, + // Bandwidth allocated for the vcpu threads. + pub vcpu_bw: SchedBandwidth, + // Bandwidth allocated for the emulator threads. + pub emulator_bw: SchedBandwidth, + // Bandwidth allocated for the Domain. + pub global_bw: SchedBandwidth, + // Bandwidth allocated for the io threads.. + pub iothread_bw: SchedBandwidth, +} + +impl SchedulerInfo { + pub fn from_vec(vec: Vec<virTypedParameter>, scheduler_type: String) -> SchedulerInfo { + unsafe { + let mut ret = SchedulerInfo::default(); + ret.scheduler_type = scheduler_type; + for param in vec { + match str::from_utf8(CStr::from_ptr(param.field.as_ptr()).to_bytes()).unwrap() { + "cpu_shares" => ret.cpu_shares = Some(param.value as u64), + "vcpu_period" => ret.vcpu_bw.period = Some(param.value as u64), + "vcpu_quota" => ret.vcpu_bw.quota = Some(param.value as i64), + "emulator_period" => ret.emulator_bw.period = Some(param.value as u64), + "emulator_quota" => ret.emulator_bw.quota = Some(param.value as i64), + "global_period" => ret.global_bw.period = Some(param.value as u64), + "global_quota" => ret.global_bw.quota = Some(param.value as i64), + "iothread_period" => ret.iothread_bw.period = Some(param.value as u64), + "iothread_quota" => ret.iothread_bw.quota = Some(param.value as i64), + unknow => panic!("Field not implemented for SchedulerInfo, {:?}", unknow), + } + } + ret + } + } + + pub fn to_vec(&self) -> Vec<virTypedParameter> { + let mut cparams: Vec<virTypedParameter> = Vec::new(); + + if let Some(shares) = self.cpu_shares { + cparams.push(virTypedParameter { + field: to_arr("cpu_shares\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: shares + }); + } + + if let Some(period) = self.vcpu_bw.period { + cparams.push(virTypedParameter { + field: to_arr("vcpu_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.vcpu_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("vcpu_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.emulator_bw.period { + cparams.push(virTypedParameter { + field: to_arr("emulator_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.emulator_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("emulator_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.global_bw.period { + cparams.push(virTypedParameter { + field: to_arr("global_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.global_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("global_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.iothread_bw.period { + cparams.push(virTypedParameter { + field: to_arr("iothread_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.iothread_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("iothread_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + + cparams + } +} + /// Provides APIs for the management of domains. /// /// See http://libvirt.org/html/libvirt-libvirt-domain.html @@ -627,6 +768,14 @@ impl Drop for Domain { } } +fn to_arr(name: &str) -> [libc::c_char; 80] { + let mut field: [libc::c_char; 80] = [0; 80]; + for (a, c) in field.iter_mut().zip(name.as_bytes()) { + *a = *c as i8 + } + field +} + impl Domain { pub fn new(ptr: sys::virDomainPtr) -> Domain { return Domain { ptr: Some(ptr) }; @@ -1656,14 +1805,6 @@ impl Domain { flags: u32) -> Result<u32, Error> { unsafe { - fn to_arr(name: &str) -> [libc::c_char; 80] { - let mut field: [libc::c_char; 80] = [0; 80]; - for (a, c) in field.iter_mut().zip(name.as_bytes()) { - *a = *c as i8 - } - field - } - let mut cparams: Vec<virTypedParameter> = Vec::new(); if params.hard_limit.is_some() { cparams.push(virTypedParameter { @@ -1809,13 +1950,6 @@ impl Domain { pub fn set_numa_parameters(&self, params: NUMAParameters, flags: u32) -> Result<u32, Error> { unsafe { - fn to_arr(name: &str) -> [libc::c_char; 80] { - let mut field: [libc::c_char; 80] = [0; 80]; - for (a, c) in field.iter_mut().zip(name.as_bytes()) { - *a = *c as i8 - } - field - } let mut cparams: Vec<virTypedParameter> = Vec::new(); if params.node_set.is_some() { @@ -1863,4 +1997,100 @@ impl Domain { return Ok(array); } } + + /// Get the cpu scheduler type for the domain + pub fn get_scheduler_type(&self) -> Result<(String, i32), Error> + { + unsafe { + let mut nparams: libc::c_int = -1; + let sched_type = virDomainGetSchedulerType(self.as_ptr(), + &mut nparams); + if sched_type.is_null() { + return Err(Error::new()); + } + + return Ok((c_chars_to_string!(sched_type), nparams)); + } + } + + /// Get the scheduler parameters for the domain. + pub fn get_scheduler_parameters(&self) -> Result<SchedulerInfo, Error> { + + let (sched_type, mut nparams) = self.get_scheduler_type()?; + unsafe { + let mut params: Vec<virTypedParameter> = vec![ + virTypedParameter::default(); 9]; + let ret = virDomainGetSchedulerParameters(self.as_ptr(), + &mut params[0], + &mut nparams); + if ret == -1 { + return Err(Error::new()); + } + Ok(SchedulerInfo::from_vec(params, sched_type)) + } + + } + + /// Get the scheduler parameters for the domain for the configuration + /// as specified by the flags. + /// # Arguments + /// + /// * `flags` - Specifies the Domain Impact: CONFIG, LIVE or CURRENT. + pub fn get_scheduler_parameters_flags(&self, + flags: DomainModImpactFlags) + -> Result<SchedulerInfo, Error> { + + let (sched_type, mut nparams) = self.get_scheduler_type()?; + unsafe { + let mut params: Vec<virTypedParameter> = vec![ + virTypedParameter::default(); 9]; + let ret = virDomainGetSchedulerParametersFlags(self.as_ptr(), + &mut params[0], + &mut nparams, + flags as libc::c_uint); + if ret == -1 { + return Err(Error::new()); + } + Ok(SchedulerInfo::from_vec(params, sched_type)) + } + + } + + /// Set the scheduler parameters for the domain. + pub fn set_scheduler_parameters(&self, + sched_info: &SchedulerInfo) + -> Result<i32, Error> { + unsafe { + let mut params = sched_info.to_vec(); + let ret = virDomainSetSchedulerParameters(self.as_ptr(), + &mut params[0], + params.len() as libc::c_int); + if ret == -1 { + return Err(Error::new()); + } + Ok(ret) + } + } + + /// Set the scheduler parameters for the domain for the configuration + /// as specified by the flags. + /// # Arguments + /// + /// * `flags` - Specifies the Domain Impact: CONFIG, LIVE or CURRENT. + pub fn set_scheduler_parameters_flags(&self, + sched_info: &SchedulerInfo, + flags: DomainModImpactFlags) + -> Result<i32, Error> { + unsafe { + let mut params = sched_info.to_vec(); + let ret = virDomainSetSchedulerParametersFlags(self.as_ptr(), + &mut params[0], + params.len() as libc::c_int, + flags as libc::c_uint); + if ret == -1 { + return Err(Error::new()); + } + Ok(ret) + } + } } -- 2.17.1

2 2

[libvirt] [PATCH] src: warn against virNodeGetInfo() API call due to inaccurate info
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- include/libvirt/libvirt-host.h | 4 ++++ src/libvirt-host.c | 16 ++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index be65b4686b..b87d634813 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -147,6 +147,10 @@ typedef virSecurityModel *virSecurityModelPtr; * * a virNodeInfo is a structure filled by virNodeGetInfo() and providing * the information for the Node. + * + * Note that the information in this struct is not guaranteed to be an + * accurate relection of the system hardware. See the virNodeGetInfo() + * API documentation for further guidance. */ typedef struct _virNodeInfo virNodeInfo; diff --git a/src/libvirt-host.c b/src/libvirt-host.c index 94ba5a8e80..bc3d1d2803 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -399,6 +399,22 @@ virConnectGetMaxVcpus(virConnectPtr conn, * * Extract hardware information about the node. * + * Use of this API is strongly discouraged as the information provided + * is not guaranteed to be accurate on all hardware platforms. + * + * The mHZ value merely reflects the speed that the first CPU in the + * machine is currently running at. This speed may vary across CPUs + * and changes continually as the host OS throttles. + * + * The nodes/sockets/cores/threads data is potentially inaccurate as + * it assumes a symmetric installation. If one NUMA node has more + * sockets populated that another NUMA node this information will be + * wrong. It is also not able to report about CPU dies. + * + * Applications are recommended to use the virConnectGetCapabilities() + * call instead, which provides all the information except CPU mHZ, + * in a more accurate representation. + * * Returns 0 in case of success and -1 in case of failure. */ int -- 2.23.0

2 1

[libvirt] [PATCH] tools: skip libvirt-guests fast if libvirtd is not active
by Christian Ehrhardt 16 Dec '19

16 Dec '19

The most common operation of libvirt-guests is to manage the local libvirtd. But users might have disabled that and while we are After=libvirtd for ordering we are not Requiring it.. OTOH adding that or any harder dependency might affect our ordering. But if people have disabled libvirt they will do a full retry loop until timeout. Lets check if the local service is active at all and skip fast if it is not. Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1854653 Reported-by: Doug Smythies <dsmythies(a)telus.net> Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- tools/libvirt-guests.sh.in | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 4bc6e866f0..5a9930ee2f 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -90,6 +90,14 @@ test_connect() { uri=$1 + if [ "x$uri" = xdefault ]; then + # Default config is most common and for the local libvirtd + # Check if it is active before wasting time in connect loop + if ! systemctl -q is-active libvirtd; then + return 1 + fi + fi + i=${CONNECT_RETRIES} while [ $i -gt 0 ]; do run_virsh "$uri" connect 2>/dev/null -- 2.24.0

4 8

[libvirt] [PATCH] virsh.pod: Mention iscsi-direct is supported in find-storage-pool-sources
by Han Han 13 Dec '19

13 Dec '19

Signed-off-by: Han Han <hhan(a)redhat.com> --- tools/virsh.pod | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index a8331154e1..14f4121787 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3994,7 +3994,8 @@ any other provided XML elements in I<srcSpec>. For a "logical" pool, the contents of the I<srcSpec> file are ignored, although if provided the file must at least exist. -For an "iscsi" pool, the minimal expect XML required is the <host> element +For an "iscsi" or "iscsi-direct" pool, +the minimal expect XML required is the <host> element with a "name" attribute describing the IP address or hostname to be used to find the pool (the iSCSI server address). Optionally, the "port" attribute may be provided, although it will default to 3260. Optionally, an <initiator> -- 2.24.0.rc1

2 1

[libvirt] [PATCH v3 0/6] PCI hostdev partial assignment support
by Daniel Henrique Barboza 13 Dec '19

13 Dec '19

changes from previous version [1]: - do not overload address type='none'. A new address type called 'unassigned' is introduced; - there is no unassigned' flag being created in virDomainHostdevDef. The logic added by new address type is enough; - do not allow function zero of multifunction devices to be unassigned. Nothing too special to discuss in this cover letter. More details can be found at the discussions of the previous version [1]. Commit messages of the patches have more background info as well. [1] https://www.redhat.com/archives/libvir-list/2019-November/msg01099.html Daniel Henrique Barboza (6): Introducing new address type='unassigned' for PCI hostdevs qemu: handle unassigned PCI hostdevs in command line and alias virhostdev.c: check all IOMMU devs in virHostdevPreparePCIDevices formatdomain.html.in: document <address type='unassigned'/> utils: PCI multifunction detection helpers domain_conf.c: don't allow function zero to be unassigned docs/formatdomain.html.in | 14 +++ docs/schemas/domaincommon.rng | 5 ++ src/conf/device_conf.c | 2 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 20 ++++- src/libvirt_private.syms | 2 + src/qemu/qemu_alias.c | 6 ++ src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 5 ++ src/util/virhostdev.c | 88 +++++++++++++++++-- src/util/virhostdev.h | 3 + src/util/virpci.c | 17 ++++ src/util/virpci.h | 2 + .../hostdev-pci-address-unassigned.args | 31 +++++++ .../hostdev-pci-address-unassigned.xml | 42 +++++++++ ...pci-multifunction-zero-unassigned-fail.xml | 42 +++++++++ tests/qemuxml2argvtest.c | 8 ++ .../hostdev-pci-address-unassigned.xml | 58 ++++++++++++ tests/qemuxml2xmltest.c | 1 + tests/virpcimock.c | 9 +- 21 files changed, 351 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction-zero-unassigned-fail.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-unassigned.xml -- 2.23.0

2 9

[libvirt] [libvirt-tck PATCH] Add cases for nvram
by Dan Zheng 13 Dec '19

13 Dec '19

This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- scripts/domain/401-ovmf-nvram.t | 143 ++++++++++++++++++++++++++++++++ 1 file changed, 143 insertions(+) create mode 100644 scripts/domain/401-ovmf-nvram.t diff --git a/scripts/domain/401-ovmf-nvram.t b/scripts/domain/401-ovmf-nvram.t new file mode 100644 index 0000000..5310dd0 --- /dev/null +++ b/scripts/domain/401-ovmf-nvram.t @@ -0,0 +1,143 @@ +# -*- perl -*- +# +# Copyright (C) 2009 Red Hat, Inc. +# Copyright (C) 2018 Dan Zheng (dzheng(a)redhat.com) +# +# This program is free software; You can redistribute it and/or modify +# it under the GNU General Public License as published by the Free +# Software Foundation; either version 2, or (at your option) any +# later version +# +# The file "LICENSE" distributed along with this file provides full +# details of the terms and conditions +# + +=pod + +=head1 NAME + +domain/401-ovmf-nvram.t - Test OVMF related functions and flags + +=head1 DESCRIPTION + +The test cases validates OVMF related APIs and flags + +Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM +Sys::Virt::Domain::UNDEFINE_NVRAM + +=cut + +use strict; +use warnings; + +use Test::More tests => 8; + +use Sys::Virt::TCK; +use File::stat; +use File::Copy; + + +my $tck = Sys::Virt::TCK->new(); +my $conn = eval { $tck->setup(); }; +BAIL_OUT "failed to setup test harness: $@" if $@; +END { $tck->cleanup if $tck; } + + +sub setup_nvram { + +my $loader_path = shift; +my $nvram_template = shift; +my $nvram_path = shift; + +# Install OVMF and check the two files should exist +# - /usr/share/OVMF/OVMF_CODE.secboot.fd +# - /usr/share/OVMF/OVMF_VARS.fd + +my $ret = `yum install -y OVMF`; +diag "yum install OVMF: $ret"; +my $st = stat($loader_path); +ok($st, "path $loader_path exists after OVMF is installed"); +$st = stat($nvram_template); +ok($st, "path $nvram_template exists after OVMF is installed"); + +# Ensure the sample nvram file exists +copy($nvram_template, $nvram_path) or die "Copy failed: $!"; + +# Use 'q35' as machine type and add below lines to guest xml +# <loader readonly='yes' secure='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.secboot.fd</loader> +# <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/test_VARS.fd</nvram> + +my $xml = $tck->generic_domain(name => "tck")->as_xml; +my $xp = XML::XPath->new($xml); +diag $xp->getNodeText("/domain/os/type/\@machine"); + +diag "Changing guest machine type to q35"; +$xp->setNodeText("/domain/os/type/\@machine", "q35"); + +my $loader_node = XML::XPath::Node::Element->new('loader'); +my $loader_text = XML::XPath::Node::Text->new($loader_path); +my $attr_ro = XML::XPath::Node::Attribute->new('readonly'); +my $attr_secure = XML::XPath::Node::Attribute->new('secure'); +my $attr_type = XML::XPath::Node::Attribute->new('type'); + +$attr_ro -> setNodeValue('yes'); +$attr_secure -> setNodeValue('yes'); +$attr_type -> setNodeValue('pflash'); + +$loader_node->appendChild($loader_text); +$loader_node->appendAttribute($attr_ro); +$loader_node->appendAttribute($attr_secure); +$loader_node->appendAttribute($attr_type); + +my $nvram_node = XML::XPath::Node::Element->new('nvram'); +my $nvram_text = XML::XPath::Node::Text->new($nvram_path); +my $attr_template = XML::XPath::Node::Attribute->new('template'); + +$attr_template -> setNodeValue($nvram_template); + +$nvram_node->appendChild($nvram_text); +$nvram_node->appendAttribute($attr_template); + +my $smm_node = XML::XPath::Node::Element->new('smm'); +my $attr_state = XML::XPath::Node::Attribute->new('state'); +$attr_state -> setNodeValue("on"); +$smm_node -> appendAttribute($attr_state); + +my ($root) = $xp->findnodes('/domain/os'); +$root->appendChild($loader_node); +$root->appendChild($nvram_node); +($root) = $xp->findnodes('/domain/features'); +$root->appendChild($smm_node); + +$xml = $xp->findnodes_as_string('/'); +diag $xml; +return $xml; +} + +diag "Defining an inactive domain config with nvram"; +my $loader_file_path = '/usr/share/OVMF/OVMF_CODE.secboot.fd'; +my $nvram_file_template = '/usr/share/OVMF/OVMF_VARS.fd'; +my $nvram_file_path = '/var/lib/libvirt/qemu/nvram/test_VARS.fd'; + +my $xml = setup_nvram($loader_file_path, $nvram_file_template, $nvram_file_path); +my $dom; + +diag "Test Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +diag "Checking nvram file already exists"; +my $st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' exists as expected"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM); +diag "Checking nvram file still exists"; +$st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' still exists as expected"); + +diag "Test Sys::Virt::Domain::UNDEFINE_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_NVRAM); +diag "Checking nvram file removed"; +$st = stat($nvram_file_path); +ok(!$st, "File '$nvram_file_path' is removed"); + +ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised from missing domain", + Sys::Virt::Error::ERR_NO_DOMAIN); -- 2.18.1

2 1

[libvirt] [PATCH 0/2] configure: Provide OpenRC scripts for sub-daemons
by Michal Privoznik 13 Dec '19

13 Dec '19

Tested on my Gentoo and it works (TM). I've copied dependencies from systemd unit files. I was also thinking about providing a dummy init script that would do nothing but depend on the rest of sub-daemon init files for convenience: /etc/init.d/libvirt-dummy start (the name is still WIP) But I'm not sure if we want that - after we drop libvirtd we can use libvirtd script just for that. But if somebody wants it, I can write and post it as a follow up patch. Michal Prívozník (2): configure: Provide OpenRC scripts for sub-daemons news: Document init scripts docs/news.xml | 11 ++++++ m4/virt-init-script.m4 | 8 +++- src/Makefile.am | 56 +++++++++++++++++++++++++++- src/interface/Makefile.inc.am | 11 ++++++ src/interface/virtinterfaced.init.in | 26 +++++++++++++ src/libxl/Makefile.inc.am | 10 +++++ src/libxl/virtxend.init.in | 26 +++++++++++++ src/lxc/Makefile.inc.am | 10 +++++ src/lxc/virtlxcd.init.in | 26 +++++++++++++ src/network/Makefile.inc.am | 10 +++++ src/network/virtnetworkd.init.in | 26 +++++++++++++ src/node_device/Makefile.inc.am | 11 ++++++ src/node_device/virtnodedevd.init.in | 26 +++++++++++++ src/nwfilter/Makefile.inc.am | 11 ++++++ src/nwfilter/virtnwfilterd.init.in | 26 +++++++++++++ src/qemu/Makefile.inc.am | 10 +++++ src/qemu/virtqemud.init.in | 26 +++++++++++++ src/remote/Makefile.inc.am | 30 +++++++++++++++ src/remote/libvirtd.confd | 18 +++++++++ src/remote/libvirtd.init.in | 29 ++++++++++++++ src/remote/virtproxyd.confd | 10 +++++ src/remote/virtproxyd.init.in | 28 ++++++++++++++ src/secret/Makefile.inc.am | 10 +++++ src/secret/virtsecretd.init.in | 26 +++++++++++++ src/storage/Makefile.inc.am | 10 +++++ src/storage/virtstoraged.init.in | 26 +++++++++++++ src/vbox/Makefile.inc.am | 10 +++++ src/vbox/virtvboxd.init.in | 26 +++++++++++++ src/vz/Makefile.inc.am | 10 +++++ src/vz/virtvzd.init.in | 26 +++++++++++++ 30 files changed, 587 insertions(+), 2 deletions(-) create mode 100644 src/interface/virtinterfaced.init.in create mode 100644 src/libxl/virtxend.init.in create mode 100644 src/lxc/virtlxcd.init.in create mode 100644 src/network/virtnetworkd.init.in create mode 100644 src/node_device/virtnodedevd.init.in create mode 100644 src/nwfilter/virtnwfilterd.init.in create mode 100644 src/qemu/virtqemud.init.in create mode 100644 src/remote/libvirtd.confd create mode 100644 src/remote/libvirtd.init.in create mode 100644 src/remote/virtproxyd.confd create mode 100644 src/remote/virtproxyd.init.in create mode 100644 src/secret/virtsecretd.init.in create mode 100644 src/storage/virtstoraged.init.in create mode 100644 src/vbox/virtvboxd.init.in create mode 100644 src/vz/virtvzd.init.in -- 2.23.0

2 4

[libvirt] [PATCH RESEND 0/4] Add support for Hygon Dhyana CPU
by Yingle Hou 13 Dec '19

13 Dec '19

As a Joint Venture between AMD and Haiguang Information Technology Co., Ltd., Hygon aims to provide x86 server processor in China market. The first generation processor Dhyana (family 18h) shares similar architecture with AMD family 17h. As Dhyana support in QEMU already have been merged in qemu-4.1.0 [1], to add Dhyana support in libvirt, we have added a new Dhyana CPU model file x86_Dhyana.xml in cpu_map directory, and also we have added a series of Dhyana test files. We have tested the patches on Hygon Dhyana machine with the result that it has successfully worked as expected. Reference: [1] https://patchwork.kernel.org/patch/10902889/ Yingle Hou (4): cpu: Remove the verification conditions of the model in the x86 signatures cpu: Add new Dhyana CPU model cputest: Add CPUID data for Hygon Dhyana 7185 32-core Processor domaincapstest: Add CPU model Dhyana to QEMU src/cpu/cpu_x86.c | 2 +- src/cpu_map/Makefile.inc.am | 1 + src/cpu_map/index.xml | 3 + src/cpu_map/x86_Dhyana.xml | 70 + src/cpu_map/x86_vendors.xml | 1 + tests/cputest.c | 1 + ...86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml | 7 + ...x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml | 9 + .../x86_64-cpuid-Hygon-C86-7185-32-core-guest.xml | 16 + .../x86_64-cpuid-Hygon-C86-7185-32-core-host.xml | 17 + .../x86_64-cpuid-Hygon-C86-7185-32-core-json.xml | 12 + .../x86_64-cpuid-Hygon-C86-7185-32-core.json | 1631 ++++++++++++++++++++ .../x86_64-cpuid-Hygon-C86-7185-32-core.sig | 4 + .../x86_64-cpuid-Hygon-C86-7185-32-core.xml | 54 + tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + 20 files changed, 1833 insertions(+), 1 deletion(-) create mode 100644 src/cpu_map/x86_Dhyana.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.json create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.sig create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.xml -- 1.8.3.1

2 9

[libvirt] [PATCH] docs: remove link to virsh cmd ref & app dev guide
by Daniel P. Berrangé 13 Dec '19

13 Dec '19

Both the application developer guide and virsh command reference are unmaintained for best part of 8 years, and so horrifically out of date. This does not give a good impression to people reading the docs. Now that we are publishing the man pages online, those are a better doc to read for virsh. We can also highlight the API reference instead of the app dev guide. The virsh command reference & app dev guide will still exist on the web root, but will not be linked to. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/docs.html.in | 48 +++++++++++++++++++++-------------------------- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/docs/docs.html.in b/docs/docs.html.in index b592f7d51f..004f099a9f 100644 --- a/docs/docs.html.in +++ b/docs/docs.html.in @@ -54,11 +54,27 @@ <div class="panel"> <h2>Application development</h2> <dl> - <dt><a href="devguide.html">Development Guide</a></dt> - <dd>A guide and reference for developing with libvirt</dd> - - <dt><a href="virshcmdref.html">Virsh Commands</a></dt> - <dd>Command reference for virsh</dd> + <dt><a href="html/index.html">API reference</a></dt> + <dd>Reference manual for the C public API, split in + <a href="html/libvirt-libvirt-common.html">common</a>, + <a href="html/libvirt-libvirt-domain.html">domain</a>, + <a href="html/libvirt-libvirt-domain-checkpoint.html">domain checkpoint</a>, + <a href="html/libvirt-libvirt-domain-snapshot.html">domain snapshot</a>, + <a href="html/libvirt-virterror.html">error</a>, + <a href="html/libvirt-libvirt-event.html">event</a>, + <a href="html/libvirt-libvirt-host.html">host</a>, + <a href="html/libvirt-libvirt-interface.html">interface</a>, + <a href="html/libvirt-libvirt-network.html">network</a>, + <a href="html/libvirt-libvirt-nodedev.html">node device</a>, + <a href="html/libvirt-libvirt-nwfilter.html">network filter</a>, + <a href="html/libvirt-libvirt-secret.html">secret</a>, + <a href="html/libvirt-libvirt-storage.html">storage</a>, + <a href="html/libvirt-libvirt-stream.html">stream</a> + and + <a href="html/index-admin.html">admin</a>, + <a href="html/index-qemu.html">QEMU</a>, + <a href="html/index-lxc.html">LXC</a> libs + </dd> <dt><a href="bindings.html">Language bindings and API modules</a></dt> <dd>Bindings of the libvirt API for @@ -97,28 +113,6 @@ <dt><a href="cgroups.html">CGroups</a></dt> <dd>Control groups integration</dd> - <dt><a href="html/index.html">API reference</a></dt> - <dd>Reference manual for the C public API, split in - <a href="html/libvirt-libvirt-common.html">common</a>, - <a href="html/libvirt-libvirt-domain.html">domain</a>, - <a href="html/libvirt-libvirt-domain-checkpoint.html">domain checkpoint</a>, - <a href="html/libvirt-libvirt-domain-snapshot.html">domain snapshot</a>, - <a href="html/libvirt-virterror.html">error</a>, - <a href="html/libvirt-libvirt-event.html">event</a>, - <a href="html/libvirt-libvirt-host.html">host</a>, - <a href="html/libvirt-libvirt-interface.html">interface</a>, - <a href="html/libvirt-libvirt-network.html">network</a>, - <a href="html/libvirt-libvirt-nodedev.html">node device</a>, - <a href="html/libvirt-libvirt-nwfilter.html">network filter</a>, - <a href="html/libvirt-libvirt-secret.html">secret</a>, - <a href="html/libvirt-libvirt-storage.html">storage</a>, - <a href="html/libvirt-libvirt-stream.html">stream</a> - and - <a href="html/index-admin.html">admin</a>, - <a href="html/index-qemu.html">QEMU</a>, - <a href="html/index-lxc.html">LXC</a> libs - </dd> - <dt><a href="drivers.html">Drivers</a></dt> <dd>Hypervisor specific driver information</dd> -- 2.21.0

2 1

[libvirt] [dockerfiles PATCH] Drop Dockerfile for mips cross-builds on Debian sid
by Andrea Bolognani 13 Dec '19

13 Dec '19

The Debian project has dropped support for the architecture. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfiles maintainance rule. Text diff below. buildenv-libvirt-debian-sid-cross-mips.zip | Bin 1010 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 buildenv-libvirt-debian-sid-cross-mips.zip diff --git a/buildenv-libvirt-debian-sid-cross-mips.zip b/buildenv-libvirt-debian-sid-cross-mips.zip deleted file mode 100644 index 287fa12..0000000 --- a/buildenv-libvirt-debian-sid-cross-mips.zip +++ /dev/null @@ -1,112 +0,0 @@ -FROM debian:sid - -RUN export DEBIAN_FRONTEND=noninteractive && \ - apt-get update && \ - apt-get dist-upgrade -y && \ - apt-get install --no-install-recommends -y \ - augeas-lenses \ - augeas-tools \ - autoconf \ - automake \ - autopoint \ - bash \ - bash-completion \ - ca-certificates \ - ccache \ - chrony \ - dnsmasq-base \ - dwarves \ - ebtables \ - flake8 \ - gcc \ - gdb \ - gettext \ - git \ - iproute2 \ - kmod \ - libc-dev-bin \ - libtool \ - libtool-bin \ - libxml2-utils \ - locales \ - lsof \ - lvm2 \ - make \ - meson \ - net-tools \ - nfs-common \ - ninja-build \ - numad \ - open-iscsi \ - parted \ - patch \ - perl \ - pkgconf \ - policykit-1 \ - python3 \ - python3-docutils \ - python3-setuptools \ - qemu-utils \ - radvd \ - screen \ - scrub \ - strace \ - sudo \ - vim \ - xsltproc \ - zfs-fuse && \ - apt-get autoremove -y && \ - apt-get autoclean -y && \ - sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ - dpkg-reconfigure locales - -RUN export DEBIAN_FRONTEND=noninteractive && \ - dpkg --add-architecture mips && \ - apt-get update && \ - apt-get dist-upgrade -y && \ - apt-get install --no-install-recommends -y \ - gcc-mips-linux-gnu \ - libacl1-dev:mips \ - libapparmor-dev:mips \ - libattr1-dev:mips \ - libaudit-dev:mips \ - libavahi-client-dev:mips \ - libblkid-dev:mips \ - libc6-dev:mips \ - libcap-ng-dev:mips \ - libcurl4-gnutls-dev:mips \ - libdbus-1-dev:mips \ - libdevmapper-dev:mips \ - libfuse-dev:mips \ - libglib2.0-dev:mips \ - libglusterfs-dev:mips \ - libgnutls28-dev:mips \ - libiscsi-dev:mips \ - libncurses-dev:mips \ - libnl-3-dev:mips \ - libnl-route-3-dev:mips \ - libnuma-dev:mips \ - libparted-dev:mips \ - libpcap0.8-dev:mips \ - libpciaccess-dev:mips \ - librbd-dev:mips \ - libreadline-dev:mips \ - libsanlock-dev:mips \ - libsasl2-dev:mips \ - libselinux1-dev:mips \ - libssh-gcrypt-dev:mips \ - libssh2-1-dev:mips \ - libtirpc-dev:mips \ - libudev-dev:mips \ - libxml2-dev:mips \ - libyajl-dev:mips \ - xfslibs-dev:mips && \ - apt-get autoremove -y && \ - apt-get autoclean -y - -ENV LANG "en_US.UTF-8" - -ENV ABI "mips-linux-gnu" -ENV CONFIGURE_OPTS "--host=mips-linux-gnu \ - --target=mips-linux-gnu" -ENV PKG_CONFIG_LIBDIR "/usr/lib/mips-linux-gnu/pkgconfig" -- 2.23.0

1 0

[libvirt] [PATCH] gitlab: Move mips job to Debian 9
by Andrea Bolognani 13 Dec '19

13 Dec '19

Support for the mips architecture has been dropped from Debian sid. Move the mipsel job from Debian 9 to Debian sid at the same time to keep things balanced. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitlab-ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3915a37a90..ea49c6178b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -17,9 +17,9 @@ debian-9-cross-mips64el: <<: *job_definition image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mips64el:latest -debian-9-cross-mipsel: +debian-9-cross-mips: <<: *job_definition - image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mipsel:latest + image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mips:latest debian-10-cross-aarch64: <<: *job_definition @@ -41,6 +41,6 @@ debian-sid-cross-i686: <<: *job_definition image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-i686:latest -debian-sid-cross-mips: +debian-sid-cross-mipsel: <<: *job_definition - image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-mips:latest + image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-mipsel:latest -- 2.23.0

2 1

[libvirt] [PATCH 0/2] cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR bits for TAA
by Jiri Denemark 13 Dec '19

13 Dec '19

CVE-2019-11135 TAA_NO and TSX_CTRL are new IA32_ARCH_CAPABILITIES MSR bits related to the TSX Asynchronous Abort (TAA) vulnerability. See [1] and [2] for details about the issue and mitigations. [1] https://software.intel.com/security-software-guidance/insights/deep-dive-in… [2] https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/tsx_async_abort.… Jiri Denemark (2): cpu_map: Add TAA_NO bit for IA32_ARCH_CAPABILITIES MSR cpu_map: Add TSX_CTRL bit for IA32_ARCH_CAPABILITIES MSR src/cpu_map/x86_features.xml | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.24.1

2 3

[libvirt] [PATCH] qemu: snapshot: Fix libvirtd crash in snapshot-revert
by Lin Ma 13 Dec '19

13 Dec '19

When reverting a running domain to a snapshot(active state), We need to use the FORCE flag for snapshot-revert if current domain configuration is different from the target domain configuration, and this will start a new qemu instance for the target domain. In this situation, if there is existing connection to the domain, say Spice or VNC through virt-manager, Then the libvirtd would crash during snapshot revert because: Both of snapshot revert worker and new worker job 'remoteDispatchDomainOpenGraphicsFd' are waiting for mon->msg->finished in qemuMonitorSend(), We know if IO process resulted in an error with a message, Libvirtd main thread calls qemuMonitorIO() to wakeup the waiter. Then mon->msg will be set to NULL in qemuMonitorSend() once the worker GraphicsFD is woken up, which causes snapshot revert worker dereferences this null pointer. Not sure whether this scenario makes sense, But at least the libvirtd should not crash, So fix it. Thread 6 "libvirtd" hit Breakpoint 1, qemuMonitorSend 987 if (mon->lastError.code != VIR_ERR_OK) { (gdb) bt #0 in qemuMonitorSend #1 in qemuMonitorJSONCommandWithFd #2 in qemuMonitorJSONSendFileHandle #3 in qemuMonitorSendFileHandle #4 in qemuMonitorOpenGraphics #5 in qemuDomainOpenGraphicsFD #6 in virDomainOpenGraphicsFD #7 in remoteDispatchDomainOpenGraphicsFd #8 in remoteDispatchDomainOpenGraphicsFdHelper #9 in virNetServerProgramDispatchCall #10 in virNetServerProgramDispatch #11 in virNetServerProcessMsg #12 in virNetServerHandleJob #13 in virThreadPoolWorker #14 in virThreadHelper #15 in start_thread #16 in clone (gdb) c Continuing. Thread 2 "libvirtd" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fbd20fe2700 (LWP 19014)] 0x00007fbd1c3be838 in qemuMonitorSend (mon=mon@entry=0x7fbd1804a940, msg=msg@entry=0x7fbd20fe15b0) at ../../src/qemu/qemu_monitor.c:1001 1001 while (!mon->msg->finished) { (gdb) bt #0 in qemuMonitorSend #1 in qemuMonitorJSONCommandWithFd #2 in qemuMonitorJSONCommand #3 in qemuMonitorJSONGetChardevInfo #4 in qemuMonitorGetChardevInfo #5 in qemuProcessWaitForMonitor #6 in qemuProcessLaunch #7 in qemuProcessStart #8 in qemuDomainRevertToSnapshot #9 in virDomainRevertToSnapshot #10 in remoteDispatchDomainRevertToSnapshot #11 in remoteDispatchDomainRevertToSnapshotHelper #12 in virNetServerProgramDispatchCall #13 in virNetServerProgramDispatch #14 in virNetServerProcessMsg #15 in virNetServerHandleJob #16 in virThreadPoolWorker #17 in virThreadHelper #18 in start_thread #19 in clone Signed-off-by: Lin Ma <lma(a)suse.com> --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index ea3e62dc8e..a8344e698b 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -994,7 +994,7 @@ qemuMonitorSend(qemuMonitorPtr mon, "mon=%p msg=%s fd=%d", mon, mon->msg->txBuffer, mon->msg->txFD); - while (!mon->msg->finished) { + while (mon->msg && !mon->msg->finished) { if (virCondWait(&mon->notify, &mon->parent.lock) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Unable to wait on monitor condition")); -- 2.23.0

4 4

[libvirt] [dockerfiles PATCH 0/2] Refresh and add openSUSE Leap 15.1
by Andrea Bolognani 13 Dec '19

13 Dec '19

Pushed under the Dockerfile refresh rule. Text diffs are provided. Andrea Bolognani (2): Refresh Dockerfiles after recent changes Add openSUSE Leap 15.1 Dockerfile for libvirt buildenv-libosinfo-centos-7.zip | Bin 570 -> 1659 bytes buildenv-libosinfo-centos-8.zip | Bin 586 -> 589 bytes buildenv-libvirt-centos-7.zip | Bin 758 -> 1878 bytes buildenv-libvirt-centos-8.zip | Bin 791 -> 793 bytes buildenv-libvirt-debian-10-cross-aarch64.zip | Bin 1016 -> 1021 bytes buildenv-libvirt-debian-10-cross-armv6l.zip | Bin 1009 -> 1014 bytes buildenv-libvirt-debian-10-cross-armv7l.zip | Bin 1013 -> 1019 bytes buildenv-libvirt-debian-10-cross-i686.zip | Bin 1008 -> 1016 bytes buildenv-libvirt-debian-10-cross-mips.zip | Bin 1003 -> 1011 bytes buildenv-libvirt-debian-10-cross-mips64el.zip | Bin 1017 -> 1022 bytes buildenv-libvirt-debian-10-cross-mipsel.zip | Bin 1007 -> 1016 bytes buildenv-libvirt-debian-10-cross-ppc64le.zip | Bin 1019 -> 1024 bytes buildenv-libvirt-debian-10-cross-s390x.zip | Bin 1006 -> 1011 bytes buildenv-libvirt-debian-10.zip | Bin 904 -> 908 bytes buildenv-libvirt-debian-9-cross-aarch64.zip | Bin 1048 -> 1053 bytes buildenv-libvirt-debian-9-cross-armv6l.zip | Bin 1039 -> 1045 bytes buildenv-libvirt-debian-9-cross-armv7l.zip | Bin 1045 -> 1050 bytes buildenv-libvirt-debian-9-cross-mips.zip | Bin 1039 -> 1044 bytes buildenv-libvirt-debian-9-cross-mips64el.zip | Bin 1051 -> 1056 bytes buildenv-libvirt-debian-9-cross-mipsel.zip | Bin 1043 -> 1048 bytes buildenv-libvirt-debian-9-cross-ppc64le.zip | Bin 1053 -> 1057 bytes buildenv-libvirt-debian-9-cross-s390x.zip | Bin 1040 -> 1045 bytes buildenv-libvirt-debian-9.zip | Bin 934 -> 938 bytes buildenv-libvirt-debian-sid-cross-aarch64.zip | Bin 1015 -> 1020 bytes buildenv-libvirt-debian-sid-cross-armv6l.zip | Bin 1009 -> 1013 bytes buildenv-libvirt-debian-sid-cross-armv7l.zip | Bin 1013 -> 1019 bytes buildenv-libvirt-debian-sid-cross-i686.zip | Bin 1008 -> 1016 bytes buildenv-libvirt-debian-sid-cross-mips.zip | Bin 1006 -> 1010 bytes ...denv-libvirt-debian-sid-cross-mips64el.zip | Bin 1017 -> 1022 bytes buildenv-libvirt-debian-sid-cross-mipsel.zip | Bin 1011 -> 1016 bytes buildenv-libvirt-debian-sid-cross-ppc64le.zip | Bin 1018 -> 1023 bytes buildenv-libvirt-debian-sid-cross-s390x.zip | Bin 1006 -> 1011 bytes buildenv-libvirt-debian-sid.zip | Bin 904 -> 908 bytes buildenv-libvirt-opensuse-151.zip | Bin 0 -> 761 bytes buildenv-libvirt-ubuntu-1604.zip | Bin 939 -> 942 bytes buildenv-libvirt-ubuntu-1804.zip | Bin 941 -> 943 bytes 36 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 buildenv-libvirt-opensuse-151.zip -- 2.23.0

1 2

[libvirt] [jenkins-ci PATCH] lcitool: Don't install yast2_base group on openSUSE
by Andrea Bolognani 12 Dec '19

12 Dec '19

We're handling all configuration using lcitool, and we have to be able to cope with minimal openSUSE environments anyway because of containers. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- I've tested this by creating a fresh openSUSE Leap 15.1 VM and verifying that I could successfully 'lcitool build' libvirt inside it. guests/configs/autoinst.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/configs/autoinst.xml b/guests/configs/autoinst.xml index f8ec3df..ceb702d 100644 --- a/guests/configs/autoinst.xml +++ b/guests/configs/autoinst.xml @@ -44,7 +44,6 @@ <patterns config:type="list"> <pattern>base</pattern> <pattern>minimal_base</pattern> - <pattern>yast2_basis</pattern> </patterns> <packages config:type="list"> <package>openssh</package> -- 2.23.0

2 1

[libvirt] [PATCH] Remove redundant usage of WITH_YAJL
by Ján Tomko 12 Dec '19

12 Dec '19

As of commit 2a00ef6e71f30241f9ca6288da984d75f3cef957 which was released in v5.2.0, we require YAJL to build the QEMU driver. Remove the checks from code that requires the QEMU driver or checks that also check for WITH_QEMU. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_driver.c | 5 ----- tests/cputest.c | 16 +++++++------- tests/qemuagenttest.c | 5 ----- tests/qemublocktest.c | 42 ++++++++++++++----------------------- tests/qemumigparamstest.c | 5 ----- tests/qemumonitorjsontest.c | 5 ----- 6 files changed, 24 insertions(+), 54 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e65150f42b..66c58d190f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2104,11 +2104,6 @@ qemuDomainRebootMonitor(virQEMUDriverPtr driver, if (virDomainObjCheckActive(vm) < 0) goto endjob; -#if !WITH_YAJL - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("ACPI reboot is not supported without the JSON monitor")); - goto endjob; -#endif qemuDomainSetFakeReboot(driver, vm, isReboot); qemuDomainObjEnterMonitor(driver, vm); ret = qemuMonitorSystemPowerdown(priv->mon); diff --git a/tests/cputest.c b/tests/cputest.c index fd86344ea4..f57516838b 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -36,7 +36,7 @@ #include "cpu/cpu_map.h" #include "virstring.h" -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU # include "testutilsqemu.h" # include "qemumonitortestutils.h" # define LIBVIRT_QEMU_CAPSPRIV_H_ALLOW @@ -62,7 +62,7 @@ struct data { int result; }; -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU static virQEMUDriver driver; #endif @@ -465,7 +465,7 @@ typedef enum { JSON_MODELS_REQUIRED, } cpuTestCPUIDJson; -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU static virQEMUCapsPtr cpuTestMakeQEMUCaps(const struct data *data) { @@ -547,7 +547,7 @@ cpuTestGetCPUModels(const struct data *data, return 0; } -#else /* if WITH_QEMU && WITH_YAJL */ +#else /* if WITH_QEMU */ static int cpuTestGetCPUModels(const struct data *data, @@ -871,7 +871,7 @@ cpuTestUpdateLive(const void *arg) } -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU static int cpuTestJSONCPUID(const void *arg) { @@ -970,7 +970,7 @@ mymain(void) virDomainCapsCPUModelsPtr ppc_models = NULL; int ret = 0; -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU if (qemuTestDriverInit(&driver) < 0) return EXIT_FAILURE; @@ -1057,7 +1057,7 @@ mymain(void) host "/" cpu " (" #models ")", \ host, cpu, models, 0, result) -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU # define DO_TEST_JSON(arch, host, json) \ do { \ if (json == JSON_MODELS) { \ @@ -1270,7 +1270,7 @@ mymain(void) DO_TEST_CPUID(VIR_ARCH_X86_64, "Ice-Lake-Server", JSON_MODELS); cleanup: -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU qemuTestDriverFree(&driver); #endif diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c index d8824b8f09..644dc9d08b 100644 --- a/tests/qemuagenttest.c +++ b/tests/qemuagenttest.c @@ -1426,11 +1426,6 @@ mymain(void) { int ret = 0; -#if !WITH_YAJL - fputs("libvirt not compiled with JSON support, skipping this test\n", stderr); - return EXIT_AM_SKIP; -#endif - if (qemuTestDriverInit(&driver) < 0) return EXIT_FAILURE; diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c index 2c170548ec..c9335774b9 100644 --- a/tests/qemublocktest.c +++ b/tests/qemublocktest.c @@ -18,22 +18,20 @@ #include "testutils.h" +#include "testutilsqemu.h" +#include "testutilsqemuschema.h" +#include "virstoragefile.h" +#include "virstring.h" +#include "virlog.h" +#include "qemu/qemu_block.h" +#include "qemu/qemu_qapi.h" -#if WITH_YAJL -# include "testutilsqemu.h" -# include "testutilsqemuschema.h" -# include "virstoragefile.h" -# include "virstring.h" -# include "virlog.h" -# include "qemu/qemu_block.h" -# include "qemu/qemu_qapi.h" +#include "qemu/qemu_command.h" -# include "qemu/qemu_command.h" +#define LIBVIRT_SNAPSHOT_CONF_PRIV_H_ALLOW +#include "conf/snapshot_conf_priv.h" -# define LIBVIRT_SNAPSHOT_CONF_PRIV_H_ALLOW -# include "conf/snapshot_conf_priv.h" - -# define VIR_FROM_THIS VIR_FROM_NONE +#define VIR_FROM_THIS VIR_FROM_NONE VIR_LOG_INIT("tests.storagetest"); @@ -523,7 +521,7 @@ mymain(void) virTestCounterReset("qemu storage source xml->json->xml "); -# define TEST_JSON_FORMAT(tpe, xmlstr) \ +#define TEST_JSON_FORMAT(tpe, xmlstr) \ do { \ xmljsonxmldata.type = tpe; \ xmljsonxmldata.xml = xmlstr; \ @@ -532,7 +530,7 @@ mymain(void) ret = -1; \ } while (0) -# define TEST_JSON_FORMAT_NET(xmlstr) \ +#define TEST_JSON_FORMAT_NET(xmlstr) \ TEST_JSON_FORMAT(VIR_STORAGE_TYPE_NETWORK, xmlstr) TEST_JSON_FORMAT(VIR_STORAGE_TYPE_FILE, "<source file='/path/to/file'/>\n"); @@ -588,7 +586,7 @@ mymain(void) " <host name='example.com' port='9999'/>\n" "</source>\n"); -# define TEST_DISK_TO_JSON_FULL(nme, fl) \ +#define TEST_DISK_TO_JSON_FULL(nme, fl) \ do { \ diskxmljsondata.name = nme; \ diskxmljsondata.props = NULL; \ @@ -611,7 +609,7 @@ mymain(void) testQemuDiskXMLToPropsClear(&diskxmljsondata); \ } while (0) -# define TEST_DISK_TO_JSON(nme) TEST_DISK_TO_JSON_FULL(nme, false) +#define TEST_DISK_TO_JSON(nme) TEST_DISK_TO_JSON_FULL(nme, false) if (!(diskxmljsondata.schema = testQEMUSchemaLoad())) { ret = -1; @@ -667,7 +665,7 @@ mymain(void) TEST_DISK_TO_JSON("block-raw-noopts"); TEST_DISK_TO_JSON("block-raw-reservations"); -# define TEST_IMAGE_CREATE(testname, testbacking) \ +#define TEST_IMAGE_CREATE(testname, testbacking) \ do { \ imagecreatedata.name = testname; \ imagecreatedata.backingname = testbacking; \ @@ -711,12 +709,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -#else -static int -mymain(void) -{ - return EXIT_AM_SKIP; -} -#endif - VIR_TEST_MAIN(mymain) diff --git a/tests/qemumigparamstest.c b/tests/qemumigparamstest.c index b36aa60302..954cd1c578 100644 --- a/tests/qemumigparamstest.c +++ b/tests/qemumigparamstest.c @@ -201,11 +201,6 @@ mymain(void) virQEMUDriver driver; int ret = 0; -#if !WITH_YAJL - fputs("libvirt not compiled with JSON support, skipping this test\n", stderr); - return EXIT_AM_SKIP; -#endif - if (qemuTestDriverInit(&driver) < 0) return EXIT_FAILURE; diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 4f3bfad1d7..21b029390c 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2991,11 +2991,6 @@ mymain(void) virJSONValuePtr metaschema = NULL; char *metaschemastr = NULL; -#if !WITH_YAJL - fputs("libvirt not compiled with JSON support, skipping this test\n", stderr); - return EXIT_AM_SKIP; -#endif - if (qemuTestDriverInit(&driver) < 0) return EXIT_FAILURE; -- 2.19.2

2 1

[libvirt] [jenkins-ci PATCH 0/5] lcitool: Make Dockerfile generation work on openSUSE
by Andrea Bolognani 12 Dec '19

12 Dec '19

With this series applied, running ./lcitool dockerfile libvirt-opensuse-151 libvirt results in a Dockerfile that can be successfully used to build a container image, and that image in turn can be successfully used to build libvirt in. Andrea Bolognani (5): guests: Add mapping for augeas-lenses guests: Install augeas-lenses for libvirt lcitool: Remove redundant update step for openSUSE guests: Add base container image for openSUSE Leap 15.1 lcitool: Make Dockerfile generation work on openSUSE guests/host_vars/libvirt-opensuse-151/docker.yml | 2 ++ guests/lcitool | 14 ++++++++++++-- guests/playbooks/update/tasks/base.yml | 7 ------- guests/vars/mappings.yml | 5 +++++ guests/vars/projects/libvirt.yml | 1 + 5 files changed, 20 insertions(+), 9 deletions(-) create mode 100644 guests/host_vars/libvirt-opensuse-151/docker.yml -- 2.23.0

4 20

[libvirt] [jenkins-ci PATCH v2 0/6] Add support for gtk-vnc builds
by Daniel P. Berrangé 12 Dec '19

12 Dec '19

Support gtk-vnc and make virt-viewer depend on it I sent this months ago & forgot to push it. Re-sending just in case something has invalidated any patches. I've at least added the newer distros Daniel P. Berrangé (6): mappings: add libgcrypt mappings: add PulseAudio projects: add gtk-vnc project guests: pull in deps for gtk-vnc project projects: make virt-viewer depend on gtk-vnc jobs mappings: remove gtk-vnc2 guests/host_vars/libvirt-centos-7/main.yml | 1 + guests/host_vars/libvirt-centos-8/main.yml | 1 + guests/host_vars/libvirt-debian-10/main.yml | 1 + guests/host_vars/libvirt-debian-9/main.yml | 1 + guests/host_vars/libvirt-debian-sid/main.yml | 1 + guests/host_vars/libvirt-fedora-30/main.yml | 1 + guests/host_vars/libvirt-fedora-31/main.yml | 1 + .../host_vars/libvirt-fedora-rawhide/main.yml | 3 ++ guests/host_vars/libvirt-freebsd-11/main.yml | 1 + guests/host_vars/libvirt-freebsd-12/main.yml | 1 + .../libvirt-freebsd-current/main.yml | 1 + guests/host_vars/libvirt-ubuntu-1604/main.yml | 1 + guests/host_vars/libvirt-ubuntu-1804/main.yml | 1 + guests/playbooks/build/jobs/defaults.yml | 3 ++ .../build/projects/gtk-vnc+mingw32.yml | 12 ++++++++ .../build/projects/gtk-vnc+mingw64.yml | 12 ++++++++ guests/playbooks/build/projects/gtk-vnc.yml | 14 +++++++++ guests/vars/mappings.yml | 30 +++++++++++-------- guests/vars/projects/gtk-vnc+mingw32.yml | 6 ++++ guests/vars/projects/gtk-vnc+mingw64.yml | 6 ++++ guests/vars/projects/gtk-vnc.yml | 11 +++++++ guests/vars/projects/virt-viewer+mingw32.yml | 1 - guests/vars/projects/virt-viewer+mingw64.yml | 1 - guests/vars/projects/virt-viewer.yml | 1 - jenkins/jobs/defaults.yaml | 3 ++ jenkins/projects/gtk-vnc+mingw32.yaml | 12 ++++++++ jenkins/projects/gtk-vnc+mingw64.yaml | 12 ++++++++ jenkins/projects/gtk-vnc.yaml | 17 +++++++++++ jenkins/projects/virt-viewer+mingw32.yaml | 4 ++- jenkins/projects/virt-viewer+mingw64.yaml | 4 ++- jenkins/projects/virt-viewer.yaml | 4 ++- 31 files changed, 149 insertions(+), 19 deletions(-) create mode 100644 guests/playbooks/build/projects/gtk-vnc+mingw32.yml create mode 100644 guests/playbooks/build/projects/gtk-vnc+mingw64.yml create mode 100644 guests/playbooks/build/projects/gtk-vnc.yml create mode 100644 guests/vars/projects/gtk-vnc+mingw32.yml create mode 100644 guests/vars/projects/gtk-vnc+mingw64.yml create mode 100644 guests/vars/projects/gtk-vnc.yml create mode 100644 jenkins/projects/gtk-vnc+mingw32.yaml create mode 100644 jenkins/projects/gtk-vnc+mingw64.yaml create mode 100644 jenkins/projects/gtk-vnc.yaml -- 2.23.0

2 9

[libvirt] [jenkins-ci PATCH] lcitool: Only install EPEL on CentOS
by Andrea Bolognani 12 Dec '19

12 Dec '19

This fixes a bug introduced by commit 0a7993d3ed30 which caused our machinery to try to install the epel-release on all targets, including the likes of Debian and even FreeBSD. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the build breaker rule. guests/playbooks/update/tasks/base.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/update/tasks/base.yml index 8128975..f721e39 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -21,6 +21,8 @@ package: name: epel-release state: latest + when: + - os_name == 'CentOS' - name: Create OpenVZ key template: -- 2.23.0

1 0

[libvirt] [PATCH 0/8] Don't hold both monitor and agent jobs at the same time
by Jonathon Jongsma 12 Dec '19

12 Dec '19

We have to assume that the guest agent may be malicious, so we don't want to allow any agent queries to block any other libvirt API. By holding a monitor job and an agent job while we're querying the agent, any other threads will be blocked from using the monitor while the agent is unresponsive. Because libvirt waits forever for an agent response, this makes us vulnerable to a denial of service from a malicious (or simply buggy) guest agent. This series of patches attempts to remove any cases where we were holding both jobs at the same time, removes a convenience function which allows us to grab both jobs at once, and updates documentation regarding this issue. Jonathon Jongsma (8): qemu: don't take agent and monitor job for shutdown qemu: don't hold a monitor and agent job for reboot qemu: don't hold both jobs for suspend qemu: don't hold monitor and agent job when setting time qemu: don't hold monitor job for fsinfo qemu: don't hold monitor job for GetGuestInfo() qemu: remove use of qemuDomainObjBeginJobWithAgent() qemu: remove qemuDomainObjBegin/EndJobWithAgent() src/qemu/THREADS.txt | 58 +----- src/qemu/qemu_domain.c | 56 +----- src/qemu/qemu_domain.h | 7 - src/qemu/qemu_driver.c | 405 +++++++++++++++++++++++++---------------- 4 files changed, 258 insertions(+), 268 deletions(-) -- 2.21.0

3 15

[libvirt] [RFC PATCH 0/9] add virtiofs support (virtio-fs epopee)
by Ján Tomko 12 Dec '19

12 Dec '19

https://bugzilla.redhat.com/show_bug.cgi?id=1694166 A work in progress, but I'm sending it now to get the XML bikesh^Wdiscussion out of the way. TODO: * documentation (due to the requirement of shared memory and therefore a <numa> topology specification, this probably deserves a separate article on https://libvirt.org/kbase.html ) * validation - refuse unsupported combinations and block migration * remove a few hardcoded values * figure out the binary path from qemu interop config * leave queue-size and cache-size on their default values or expose them in XML * use FD passing for vhost-user-fs device as well * clean up the code Tested with: commit 320000e72ec0613e164ce9608d865396fb2da278 Author: Linus Torvalds <torvalds(a)linux-foundation.org> Date: Wed Oct 30 14:17:18 2019 +0100 Merge tag 'iommu-fixes-v5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu and commit d3d2efbb0e37494708dde359a9d0f492f84833e8 Author: Dr. David Alan Gilbert <dgilbert(a)redhat.com> CommitDate: 2019-10-24 11:50:55 +0100 virtio-fs: Allow mapping of meta data version table from https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev git fetch https://gitlab.com/virtio-fs/qemu.git virtio-fs-dev (not yet merged upstream) Ján Tomko (9): qemu: address: take fsdriver type into account qemu: cmdline: take fsdriver into account qemu: add QEMU_CAPS_VHOST_USER_FS wip: tests: add xml2xml tests for virtio-fs wip: add XML -> ARGV tests for virtio-fs conf: qemu: add virtio-fs fsdriver type qemu: pass private data to qemuBuildFilesystemCommandLine wip: start virtiofsd wip: build vhost-user-fs device command line docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 67 +++++- src/qemu/qemu_domain.c | 4 + src/qemu/qemu_domain_address.c | 35 +++- src/qemu/qemu_extdevice.c | 191 ++++++++++++++++++ ...vhost-user-fs-fd-memory.x86_64-latest.args | 38 ++++ .../vhost-user-fs-fd-memory.xml | 38 ++++ ...vhost-user-fs-hugepages.x86_64-latest.args | 42 ++++ .../vhost-user-fs-hugepages.xml | 67 ++++++ tests/qemuxml2argvtest.c | 9 + .../vhost-user-fs-fd-memory.x86_64-latest.xml | 1 + .../vhost-user-fs-hugepages.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 3 + 17 files changed, 493 insertions(+), 14 deletions(-) create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-fd-memory.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-hugepages.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-hugepages.xml create mode 120000 tests/qemuxml2xmloutdata/vhost-user-fs-fd-memory.x86_64-latest.xml create mode 120000 tests/qemuxml2xmloutdata/vhost-user-fs-hugepages.x86_64-latest.xml -- 2.21.0

5 19

[libvirt] [jenkins-ci PATCH 0/2] lcitool: Refactor Dockerfile generation
by Andrea Bolognani 12 Dec '19

12 Dec '19

Andrea Bolognani (2): lcitool: Perform system update after enabling repos lcitool: Refactor Dockerfile generation guests/lcitool | 66 +++++++++++++++++++++++++------------------------- 1 file changed, 33 insertions(+), 33 deletions(-) -- 2.23.0

2 6

[libvirt] [PATCH v2 0/3] misc fixes for qemu domain validation/post-parse
by Daniel P. Berrangé 12 Dec '19

12 Dec '19

Daniel P. Berrangé (3): tests: add a domain ID to live status XML doc qemu: check os type / virt type / arch in validate callback qemu: honour parseOpaque instead of refetching caps src/qemu/qemu_domain.c | 54 ++++++++++--------- .../qemustatusxml2xmldata/vcpus-multi-in.xml | 2 +- tests/qemuxml2argvtest.c | 9 ++-- 3 files changed, 35 insertions(+), 30 deletions(-) -- 2.23.0

2 5

[libvirt] [PATCHv2 0/8] Remove VIR_STRNDUP
by Ján Tomko 12 Dec '19

12 Dec '19

Ján Tomko (8): Remove VIR_STRDUP usage that sneaked in in the meantime vsh: remove vshErrorOOM Remove VIR_STRNDUP usage with checked pointers Remove all the uses that use subtraction in their length argument Remove the rest of VIR_STRNDUP tests: delete tests for VIR_STR(N)DUP util: remove VIR_STRDUP and VIR_STRNDUP docs: hacking: document removal of VIR_STR(N)DUP docs/hacking.html.in | 10 +- src/bhyve/bhyve_parse_command.c | 6 +- src/conf/backup_conf.c | 4 +- src/conf/nwfilter_conf.c | 4 +- src/conf/nwfilter_params.c | 6 +- src/interface/interface_backend_udev.c | 8 +- src/libvirt_private.syms | 2 - src/libxl/xen_common.c | 29 +++--- src/libxl/xen_xl.c | 6 +- src/libxl/xen_xm.c | 9 +- src/lxc/lxc_driver.c | 3 +- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_monitor_json.c | 14 +-- src/rpc/virnetlibsshsession.c | 7 +- src/util/vircgroupv1.c | 5 +- src/util/vircommand.c | 1 - src/util/virconf.c | 24 ++--- src/util/viriscsi.c | 3 +- src/util/virjson.c | 11 +- src/util/virkeyfile.c | 9 +- src/util/virsocketaddr.c | 5 +- src/util/virstoragefile.c | 6 +- src/util/virstring.c | 52 +--------- src/util/virstring.h | 69 ------------- src/util/virsysinfo.c | 3 +- src/vmware/vmware_conf.c | 6 +- tests/virstringtest.c | 136 ------------------------- tools/vsh.c | 16 +-- 28 files changed, 63 insertions(+), 394 deletions(-) -- 2.21.0

2 9

[libvirt] [jenkins-ci PATCH] lcitool: Fix invalid escape sequence
by Andrea Bolognani 12 Dec '19

12 Dec '19

Spotted by flake8. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. guests/lcitool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index e87a805..d4dc1c8 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -723,7 +723,7 @@ class Application: {package_manager} install --no-install-recommends -y {pkgs} && \\ {package_manager} autoremove -y && \\ {package_manager} autoclean -y && \\ - sed -Ei 's,^# (en_US\.UTF-8 .*)$,\\1,' /etc/locale.gen && \\ + sed -Ei 's,^# (en_US\\.UTF-8 .*)$,\\1,' /etc/locale.gen && \\ dpkg-reconfigure locales """).format(**varmap)) if args.cross_arch: -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH] guests: Fix locale handling
by Andrea Bolognani 12 Dec '19

12 Dec '19

Commit 3ce973f2fb38 introduced a new glibc-langpack-en mapping in order to make en_US.UTF-8 available on CentOS 8, but as it turns out we already had a mapping for that and we just needed to tweak it a bit. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 9 ++------- guests/vars/projects/base.yml | 1 - 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 68664a0..d32ecf3 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -189,11 +189,6 @@ mappings: rpm: glibc-devel cross-policy-deb: foreign - glibc-langpack-en: - rpm: glibc-langpack-en - CentOS7: - OpenSUSE: - glibc-static: deb: libc6-dev rpm: glibc-static @@ -451,9 +446,9 @@ mappings: cross-policy-deb: foreign locales: - CentOS7: glibc-common deb: locales - Fedora: glibc-langpack-en + rpm: glibc-langpack-en + CentOS7: glibc-common FreeBSD: OpenSUSE: glibc-locale diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index 9ebf249..29c10b4 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -14,7 +14,6 @@ packages: - gettext - git - glibc - - glibc-langpack-en - libtool - libtoolize - locales -- 2.23.0

2 2

[libvirt] [dockerfiles PATCH] Refresh after recent changes
by Andrea Bolognani 12 Dec '19

12 Dec '19

This makes the en_US.UTF-8 locale available on CentOS 8 and uses better named tags for CentOS images. The corresponding libvirt-jenkins-ci commit is 2c996a745a68. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. Text diff below. buildenv-libosinfo-centos-7.zip | Bin 572 -> 570 bytes buildenv-libosinfo-centos-8.zip | Bin 578 -> 586 bytes buildenv-libvirt-centos-7.zip | Bin 761 -> 758 bytes buildenv-libvirt-centos-8.zip | Bin 781 -> 791 bytes 4 files changed, 0 insertions(+), 0 deletions(-) diff --git a/buildenv-libosinfo-centos-7.zip b/buildenv-libosinfo-centos-7.zip index b91f3aa..ac09cf5 100644 --- a/buildenv-libosinfo-centos-7.zip +++ b/buildenv-libosinfo-centos-7.zip @@ -1,4 +1,4 @@ -FROM centos:centos7 +FROM centos:7 RUN yum update -y && \ yum install -y epel-release && \ diff --git a/buildenv-libosinfo-centos-8.zip b/buildenv-libosinfo-centos-8.zip index e739059..6ac848e 100644 --- a/buildenv-libosinfo-centos-8.zip +++ b/buildenv-libosinfo-centos-8.zip @@ -1,4 +1,4 @@ -FROM centos:centos8 +FROM centos:8 RUN dnf update -y && \ dnf install 'dnf-command(config-manager)' -y && \ @@ -19,6 +19,7 @@ RUN dnf update -y && \ git \ glib2-devel \ glibc-devel \ + glibc-langpack-en \ gobject-introspection-devel \ gtk-doc \ hwdata \ diff --git a/buildenv-libvirt-centos-7.zip b/buildenv-libvirt-centos-7.zip index 4e9c3db..bc3041f 100644 --- a/buildenv-libvirt-centos-7.zip +++ b/buildenv-libvirt-centos-7.zip @@ -1,4 +1,4 @@ -FROM centos:centos7 +FROM centos:7 RUN yum update -y && \ yum install -y epel-release && \ diff --git a/buildenv-libvirt-centos-8.zip b/buildenv-libvirt-centos-8.zip index 5410201..bb014ea 100644 --- a/buildenv-libvirt-centos-8.zip +++ b/buildenv-libvirt-centos-8.zip @@ -1,4 +1,4 @@ -FROM centos:centos8 +FROM centos:8 RUN dnf update -y && \ dnf install 'dnf-command(config-manager)' -y && \ @@ -27,6 +27,7 @@ RUN dnf update -y && \ git \ glib2-devel \ glibc-devel \ + glibc-langpack-en \ glusterfs-api-devel \ gnutls-devel \ iproute \ -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH] guests: Use more natural tags for CentOS base images
by Andrea Bolognani 12 Dec '19

12 Dec '19

Both the 'X' and 'centosX' tags are available on the registry, and they point to the same image; the former looks more natural though, so let's use that one. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/host_vars/libvirt-centos-7/docker.yml | 2 +- guests/host_vars/libvirt-centos-8/docker.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/docker.yml b/guests/host_vars/libvirt-centos-7/docker.yml index 59f7f12..5c2e299 100644 --- a/guests/host_vars/libvirt-centos-7/docker.yml +++ b/guests/host_vars/libvirt-centos-7/docker.yml @@ -1,2 +1,2 @@ --- -docker_base: centos:centos7 +docker_base: centos:7 diff --git a/guests/host_vars/libvirt-centos-8/docker.yml b/guests/host_vars/libvirt-centos-8/docker.yml index 10c2a50..aae78a2 100644 --- a/guests/host_vars/libvirt-centos-8/docker.yml +++ b/guests/host_vars/libvirt-centos-8/docker.yml @@ -1,2 +1,2 @@ --- -docker_base: centos:centos8 +docker_base: centos:8 -- 2.23.0

2 1

[libvirt] [PATCH] docs: stop using syntax highlighting for man page code blocks
by Daniel P. Berrangé 12 Dec '19

12 Dec '19

Some versions of the rst2man convertor are buggy failing to cope with syntax highlighting in code blocks. This isn't something we really need for the man page code blocks, so we can just delete the highlighting directive. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/manpages/libvirtd.rst | 4 +- docs/manpages/virsh.rst | 576 ++++++++++++++--------------- docs/manpages/virt-admin.rst | 50 +-- docs/manpages/virt-login-shell.rst | 2 +- docs/manpages/virtlockd.rst | 4 +- docs/manpages/virtlogd.rst | 4 +- 6 files changed, 320 insertions(+), 320 deletions(-) diff --git a/docs/manpages/libvirtd.rst b/docs/manpages/libvirtd.rst index b7489a57fc..4125604f9a 100644 --- a/docs/manpages/libvirtd.rst +++ b/docs/manpages/libvirtd.rst @@ -199,7 +199,7 @@ EXAMPLES To retrieve the version of libvirtd: -.. code-block:: shell +.. code-block:: # libvirtd --version libvirtd (libvirt) 0.8.2 @@ -207,7 +207,7 @@ To retrieve the version of libvirtd: To start libvirtd, instructing it to daemonize and create a PID file: -.. code-block:: shell +.. code-block:: # libvirtd -d # ls -la RUNSTATEDIR/libvirtd.pid diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index e9d6deaee1..e063b76641 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -38,7 +38,7 @@ KVM, LXC, OpenVZ, VirtualBox and VMware ESX. The basic structure of most virsh usage is: -.. code-block:: shell +.. code-block:: virsh [OPTION]... <command> <domain> [ARG]... @@ -214,7 +214,7 @@ help **Syntax:** -.. code-block:: shell +.. code-block:: help [command-or-group] @@ -228,7 +228,7 @@ group as an option. For example: **Example 1:** -.. code-block:: shell +.. code-block:: virsh # help host @@ -250,7 +250,7 @@ option instead. For example: **Example 2:** -.. code-block:: shell +.. code-block:: virsh # help list NAME @@ -272,7 +272,7 @@ quit, exit **Syntax:** -.. code-block:: shell +.. code-block:: quit exit @@ -286,7 +286,7 @@ version **Syntax:** -.. code-block:: shell +.. code-block:: version [--daemon] @@ -296,7 +296,7 @@ is included in the output. **Example:** -.. code-block:: shell +.. code-block:: $ virsh version Compiled against library: libvirt 1.2.3 @@ -317,7 +317,7 @@ cd **Syntax:** -.. code-block:: shell +.. code-block:: cd [directory] @@ -334,7 +334,7 @@ pwd **Syntax:** -.. code-block:: shell +.. code-block:: pwd @@ -347,7 +347,7 @@ connect **Syntax:** -.. code-block:: shell +.. code-block:: connect [URI] [--readonly] @@ -388,7 +388,7 @@ uri **Syntax:** -.. code-block:: shell +.. code-block:: uri @@ -400,7 +400,7 @@ hostname **Syntax:** -.. code-block:: shell +.. code-block:: hostname @@ -412,7 +412,7 @@ sysinfo **Syntax:** -.. code-block:: shell +.. code-block:: sysinfo @@ -424,7 +424,7 @@ nodeinfo **Syntax:** -.. code-block:: shell +.. code-block:: nodeinfo @@ -440,7 +440,7 @@ nodecpumap **Syntax:** -.. code-block:: shell +.. code-block:: nodecpumap [--pretty] @@ -456,7 +456,7 @@ nodecpustats **Syntax:** -.. code-block:: shell +.. code-block:: nodecpustats [cpu] [--percent] @@ -471,7 +471,7 @@ nodememstats **Syntax:** -.. code-block:: shell +.. code-block:: nodememstats [cell] @@ -484,7 +484,7 @@ nodesuspend **Syntax:** -.. code-block:: shell +.. code-block:: nodesuspend [target] [duration] @@ -503,7 +503,7 @@ node **Syntax:** -.. code-block:: shell +.. code-block:: node-memory-tune [shm-pages-to-scan] [shm-sleep-millisecs] [shm-merge-across-nodes] @@ -525,7 +525,7 @@ capabilities **Syntax:** -.. code-block:: shell +.. code-block:: capabilities @@ -545,7 +545,7 @@ domcapabilities **Syntax:** -.. code-block:: shell +.. code-block:: domcapabilities [virttype] [emulatorbin] [arch] [machine] @@ -588,7 +588,7 @@ pool-capabilities **Syntax:** -.. code-block:: shell +.. code-block:: pool-capabilities @@ -605,7 +605,7 @@ inject **Syntax:** -.. code-block:: shell +.. code-block:: inject-nmi domain @@ -617,7 +617,7 @@ list **Syntax:** -.. code-block:: shell +.. code-block:: list [--inactive | --all] [--managed-save] [--title] @@ -637,7 +637,7 @@ specified it prints out information about running domains. An example format for the list is as follows: -.. code-block:: shell +.. code-block:: ``virsh`` list Id Name State @@ -775,7 +775,7 @@ printed in an extra column. This flag is usable only with the default **Example 2:** -.. code-block:: shell +.. code-block:: $ virsh list --title Id Name State Title @@ -790,7 +790,7 @@ freecell **Syntax:** -.. code-block:: shell +.. code-block:: freecell [{ [--cellno] cellno | --all }] @@ -809,7 +809,7 @@ freepages **Syntax:** -.. code-block:: shell +.. code-block:: freepages [{ [--cellno] cellno [--pagesize] pagesize | --all }] @@ -824,7 +824,7 @@ allocpages **Syntax:** -.. code-block:: shell +.. code-block:: allocpages [--pagesize] pagesize [--pagecount] pagecount [[--cellno] cellno] [--add] [--all] @@ -843,7 +843,7 @@ cpu-baseline **Syntax:** -.. code-block:: shell +.. code-block:: cpu-baseline FILE [--features] [--migratable] @@ -864,7 +864,7 @@ cpu-compare **Syntax:** -.. code-block:: shell +.. code-block:: cpu-compare FILE [--error] @@ -890,7 +890,7 @@ cpu-models **Syntax:** -.. code-block:: shell +.. code-block:: cpu-models arch @@ -909,7 +909,7 @@ echo **Syntax:** -.. code-block:: shell +.. code-block:: echo [--shell] [--xml] [err...] [arg...] @@ -926,7 +926,7 @@ hypervisor-cpu-compare **Syntax:** -.. code-block:: shell +.. code-block:: hypervisor-cpu-compare FILE [virttype] [emulator] [arch] [machine] [--error] @@ -958,7 +958,7 @@ hypervisor-cpu-baseline **Syntax:** -.. code-block:: shell +.. code-block:: hypervisor-cpu-baseline FILE [virttype] [emulator] [arch] [machine] [--features] [--migratable] @@ -1005,7 +1005,7 @@ autostart **Syntax:** -.. code-block:: shell +.. code-block:: autostart [--disable] domain @@ -1020,7 +1020,7 @@ blkdeviotune **Syntax:** -.. code-block:: shell +.. code-block:: blkdeviotune domain device [[--config] [--live] | [--current]] [[total-bytes-sec] | [read-bytes-sec] [write-bytes-sec]] @@ -1102,7 +1102,7 @@ blkiotune **Syntax:** -.. code-block:: shell +.. code-block:: blkiotune domain [--weight weight] [--device-weights device-weights] [--device-read-iops-sec device-read-iops-sec] @@ -1163,7 +1163,7 @@ blockcommit **Syntax:** -.. code-block:: shell +.. code-block:: blockcommit domain path [bandwidth] [--bytes] [base] [--shallow] [top] [--delete] [--keep-relative] @@ -1221,7 +1221,7 @@ blockcopy **Syntax:** -.. code-block:: shell +.. code-block:: blockcopy domain path { dest [format] [--blockdev] | --xml file } [--shallow] [--reuse-external] [bandwidth] @@ -1293,7 +1293,7 @@ blockjob **Syntax:** -.. code-block:: shell +.. code-block:: blockjob domain path { [--abort] [--async] [--pivot] | [--info] [--raw] [--bytes] | [bandwidth] } @@ -1343,7 +1343,7 @@ blockpull **Syntax:** -.. code-block:: shell +.. code-block:: blockpull domain path [bandwidth] [--bytes] [base] [--wait [--verbose] [--timeout seconds] [--async]] @@ -1384,7 +1384,7 @@ blockresize **Syntax:** -.. code-block:: shell +.. code-block:: blockresize domain path size @@ -1405,7 +1405,7 @@ console **Syntax:** -.. code-block:: shell +.. code-block:: console domain [devname] [--safe] [--force] @@ -1426,7 +1426,7 @@ cpu-stats **Syntax:** -.. code-block:: shell +.. code-block:: cpu-stats domain [--total] [start] [count] @@ -1442,7 +1442,7 @@ create **Syntax:** -.. code-block:: shell +.. code-block:: create FILE [--console] [--paused] [--autodestroy] [--pass-fds N,M,...] [--validate] @@ -1473,7 +1473,7 @@ is only supported with container based virtualization. #. prepare a template from an existing domain (skip directly to 3a if writing one from scratch) - .. code-block:: shell + .. code-block:: # virsh dumpxml <domain> > domain.xml @@ -1482,7 +1482,7 @@ is only supported with container based virtualization. a. DO CHANGE! <name> and <uuid> (<uuid> can also be removed), or b. DON'T CHANGE! either <name> or <uuid> - .. code-block:: shell + .. code-block:: # $EDITOR domain.xml @@ -1493,7 +1493,7 @@ is only supported with container based virtualization. b. an existing persistent domain will run with a modified one-time configuration - .. code-block:: shell + .. code-block:: # virsh create domain.xml @@ -1503,7 +1503,7 @@ define **Syntax:** -.. code-block:: shell +.. code-block:: define FILE [--validate] @@ -1519,7 +1519,7 @@ desc **Syntax:** -.. code-block:: shell +.. code-block:: desc domain [[--live] [--config] | [--current]] [--title] [--edit] [--new-desc @@ -1551,7 +1551,7 @@ destroy **Syntax:** -.. code-block:: shell +.. code-block:: destroy domain [--graceful] @@ -1579,7 +1579,7 @@ domblkerror **Syntax:** -.. code-block:: shell +.. code-block:: domblkerror domain @@ -1595,7 +1595,7 @@ domblkinfo **Syntax:** -.. code-block:: shell +.. code-block:: domblkinfo domain [block-device --all] [--human] @@ -1615,7 +1615,7 @@ domblklist **Syntax:** -.. code-block:: shell +.. code-block:: domblklist domain [--inactive] [--details] @@ -1635,7 +1635,7 @@ domblkstat **Syntax:** -.. code-block:: shell +.. code-block:: domblkstat domain [block-device] [--human] @@ -1672,7 +1672,7 @@ domblkthreshold **Syntax:** -.. code-block:: shell +.. code-block:: domblkthreshold domain dev threshold @@ -1687,7 +1687,7 @@ domcontrol **Syntax:** -.. code-block:: shell +.. code-block:: domcontrol domain @@ -1701,7 +1701,7 @@ domdisplay **Syntax:** -.. code-block:: shell +.. code-block:: domdisplay domain [--include-password] [[--type] type] [--all] @@ -1718,7 +1718,7 @@ domfsfreeze **Syntax:** -.. code-block:: shell +.. code-block:: domfsfreeze domain [[--mountpoint] mountpoint...] @@ -1740,7 +1740,7 @@ domfsinfo **Syntax:** -.. code-block:: shell +.. code-block:: domfsinfo domain @@ -1757,7 +1757,7 @@ domfsthaw **Syntax:** -.. code-block:: shell +.. code-block:: domfsthaw domain [[--mountpoint] mountpoint...] @@ -1774,7 +1774,7 @@ domfstrim **Syntax:** -.. code-block:: shell +.. code-block:: domfstrim domain [--minimum bytes] [--mountpoint mountPoint] @@ -1795,7 +1795,7 @@ domhostname **Syntax:** -.. code-block:: shell +.. code-block:: domhostname domain @@ -1807,7 +1807,7 @@ domid **Syntax:** -.. code-block:: shell +.. code-block:: domid domain-name-or-uuid @@ -1819,7 +1819,7 @@ domif **Syntax:** -.. code-block:: shell +.. code-block:: domif-getlink domain interface-device [--config] @@ -1835,7 +1835,7 @@ domif **Syntax:** -.. code-block:: shell +.. code-block:: domif-setlink domain interface-device state [--config] @@ -1851,7 +1851,7 @@ domifaddr **Syntax:** -.. code-block:: shell +.. code-block:: domifaddr domain [interface] [--full] [--source lease|agent|arp] @@ -1878,7 +1878,7 @@ backup-begin **Syntax:** -.. code-block:: shell +.. code-block:: backup-begin domain [backupxml] [checkpointxml] [--reuse-external] @@ -1912,7 +1912,7 @@ backup-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: backup-dumpxml domain @@ -1924,7 +1924,7 @@ domiflist **Syntax:** -.. code-block:: shell +.. code-block:: domiflist domain [--inactive] @@ -1941,7 +1941,7 @@ domifstat **Syntax:** -.. code-block:: shell +.. code-block:: domifstat domain interface-device @@ -1958,7 +1958,7 @@ domiftune **Syntax:** -.. code-block:: shell +.. code-block:: domiftune domain interface-device [[--config] [--live] | [--current]] [*--inbound average,peak,burst,floor*] @@ -1992,7 +1992,7 @@ dominfo **Syntax:** -.. code-block:: shell +.. code-block:: dominfo domain @@ -2004,7 +2004,7 @@ domjobabort **Syntax:** -.. code-block:: shell +.. code-block:: domjobabort domain @@ -2016,7 +2016,7 @@ domjobinfo **Syntax:** -.. code-block:: shell +.. code-block:: domjobinfo domain [--completed [--keep-completed]] [--anystats] [--rawstats] @@ -2043,7 +2043,7 @@ dommemstat **Syntax:** -.. code-block:: shell +.. code-block:: dommemstat domain [--period seconds] [[--config] [--live] | [--current]] @@ -2096,7 +2096,7 @@ domname **Syntax:** -.. code-block:: shell +.. code-block:: domname domain-id-or-uuid @@ -2108,7 +2108,7 @@ dompmsuspend **Syntax:** -.. code-block:: shell +.. code-block:: dompmsuspend domain target [--duration] @@ -2139,7 +2139,7 @@ dompmwakeup **Syntax:** -.. code-block:: shell +.. code-block:: dompmwakeup domain @@ -2154,7 +2154,7 @@ domrename **Syntax:** -.. code-block:: shell +.. code-block:: domrename domain new-name @@ -2169,7 +2169,7 @@ domstate **Syntax:** -.. code-block:: shell +.. code-block:: domstate domain [--reason] @@ -2182,7 +2182,7 @@ domstats **Syntax:** -.. code-block:: shell +.. code-block:: domstats [--raw] [--enforce] [--backing] [--nowait] [--state] [--cpu-total] [--balloon] [--vcpu] [--interface] @@ -2389,7 +2389,7 @@ domtime **Syntax:** -.. code-block:: shell +.. code-block:: domtime domain { [--now] [--pretty] [--sync] [--time time] } @@ -2414,7 +2414,7 @@ domuuid **Syntax:** -.. code-block:: shell +.. code-block:: domuuid domain-name-or-id @@ -2426,7 +2426,7 @@ domxml **Syntax:** -.. code-block:: shell +.. code-block:: domxml-from-native format config @@ -2444,7 +2444,7 @@ domxml **Syntax:** -.. code-block:: shell +.. code-block:: domxml-to-native format { [--xml] xml | --domain domain-name-or-id-or-uuid } @@ -2459,7 +2459,7 @@ dump **Syntax:** -.. code-block:: shell +.. code-block:: dump domain corefilepath [--bypass-cache] { [--live] | [--crash] | [--reset] } @@ -2501,7 +2501,7 @@ dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: dumpxml domain [--inactive] [--security-info] [--update-cpu] [--migratable] @@ -2522,7 +2522,7 @@ edit **Syntax:** -.. code-block:: shell +.. code-block:: edit domain @@ -2531,7 +2531,7 @@ next boot of the guest. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh dumpxml --inactive --security-info domain > domain.xml vi domain.xml (or make changes with your other text editor) @@ -2548,7 +2548,7 @@ emulatorpin **Syntax:** -.. code-block:: shell +.. code-block:: emulatorpin domain [cpulist] [[--live] [--config] | [--current]] @@ -2570,7 +2570,7 @@ event **Syntax:** -.. code-block:: shell +.. code-block:: event {[domain] { event | --all } [--loop] [--timeout seconds] [--timestamp] | --list} @@ -2597,7 +2597,7 @@ guest **Syntax:** -.. code-block:: shell +.. code-block:: guest-agent-timeout domain --timeout value @@ -2616,7 +2616,7 @@ guestinfo **Syntax:** -.. code-block:: shell +.. code-block:: guestinfo domain [--user] [--os] [--timezone] [--hostname] [--filesystem] @@ -2692,7 +2692,7 @@ guestvcpus **Syntax:** -.. code-block:: shell +.. code-block:: guestvcpus domain [[--enable] | [--disable]] [cpulist] @@ -2711,7 +2711,7 @@ iothreadadd **Syntax:** -.. code-block:: shell +.. code-block:: iothreadadd domain iothread_id [[--config] [--live] | [--current]] @@ -2731,7 +2731,7 @@ iothreaddel **Syntax:** -.. code-block:: shell +.. code-block:: iothreaddel domain iothread_id [[--config] [--live] | [--current]] @@ -2752,7 +2752,7 @@ iothreadinfo **Syntax:** -.. code-block:: shell +.. code-block:: iothreadinfo domain [[--live] [--config] | [--current]] @@ -2772,7 +2772,7 @@ iothreadpin **Syntax:** -.. code-block:: shell +.. code-block:: iothreadpin domain iothread cpulist [[--live] [--config] | [--current]] @@ -2805,7 +2805,7 @@ iothreadset **Syntax:** -.. code-block:: shell +.. code-block:: iothreadset domain iothread_id [[--poll-max-ns ns] [--poll-grow factor] [--poll-shrink divisor]] @@ -2836,7 +2836,7 @@ managedsave **Syntax:** -.. code-block:: shell +.. code-block:: managedsave domain [--bypass-cache] [{--running | --paused}] [--verbose] @@ -2865,7 +2865,7 @@ managedsave-define **Syntax:** -.. code-block:: shell +.. code-block:: managedsave-define domain xml [{--running | --paused}] @@ -2885,7 +2885,7 @@ managedsave-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: managedsave-dumpxml domain [--security-info] @@ -2899,7 +2899,7 @@ managedsave-edit **Syntax:** -.. code-block:: shell +.. code-block:: managedsave-edit domain [{--running | --paused}] @@ -2913,7 +2913,7 @@ will allow overriding which state the ``restore`` should use. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh managedsave-dumpxml domain-name > state-file.xml vi state-file.xml (or make changes with your other text editor) @@ -2930,7 +2930,7 @@ managedsave-remove **Syntax:** -.. code-block:: shell +.. code-block:: managedsave-remove domain @@ -2943,7 +2943,7 @@ maxvcpus **Syntax:** -.. code-block:: shell +.. code-block:: maxvcpus [type] @@ -2957,7 +2957,7 @@ memtune **Syntax:** -.. code-block:: shell +.. code-block:: memtune domain [--hard-limit size] [--soft-limit size] [--swap-hard-limit size] [--min-guarantee size] [[--config] [--live] | [--current]] @@ -3015,7 +3015,7 @@ metadata **Syntax:** -.. code-block:: shell +.. code-block:: metadata domain [[--live] [--config] | [--current]] [--edit] [uri] [key] [set] [--remove] @@ -3054,7 +3054,7 @@ migrate **Syntax:** -.. code-block:: shell +.. code-block:: migrate [--live] [--offline] [--direct] [--p2p [--tunnelled]] [--persistent] [--undefinesource] [--suspend] [--copy-storage-all] @@ -3228,7 +3228,7 @@ connected to and needs to connect through a proxy, *graphicsuri* may be used to specify the address the client should connect to. The URI is formed as follows: -.. code-block:: shell +.. code-block:: protocol://hostname[:port]/[?parameters] @@ -3236,7 +3236,7 @@ where protocol is either "spice" or "vnc" and parameters is a list of protocol specific parameters separated by '&'. Currently recognized parameters are "tlsPort" and "tlsSubject". For example, -.. code-block:: shell +.. code-block:: spice://target.host.com:1234/?tlsPort=4567 @@ -3255,7 +3255,7 @@ migrate-compcache **Syntax:** -.. code-block:: shell +.. code-block:: migrate-compcache domain [--size bytes] @@ -3275,7 +3275,7 @@ migrate-getmaxdowntime **Syntax:** -.. code-block:: shell +.. code-block:: migrate-getmaxdowntime domain @@ -3290,7 +3290,7 @@ migrate-getspeed **Syntax:** -.. code-block:: shell +.. code-block:: migrate-getspeed domain [--postcopy] @@ -3304,7 +3304,7 @@ migrate-postcopy **Syntax:** -.. code-block:: shell +.. code-block:: migrate-postcopy domain @@ -3317,7 +3317,7 @@ migrate-setmaxdowntime **Syntax:** -.. code-block:: shell +.. code-block:: migrate-setmaxdowntime domain downtime @@ -3331,7 +3331,7 @@ migrate-setspeed **Syntax:** -.. code-block:: shell +.. code-block:: migrate-setspeed domain bandwidth [--postcopy] @@ -3349,7 +3349,7 @@ numatune **Syntax:** -.. code-block:: shell +.. code-block:: numatune domain [--mode mode] [--nodeset nodeset] [[--config] [--live] | [--current]] @@ -3378,7 +3378,7 @@ perf **Syntax:** -.. code-block:: shell +.. code-block:: perf domain [--enable eventSpec] [--disable eventSpec] [[--config] [--live] | [--current]] @@ -3466,7 +3466,7 @@ reboot **Syntax:** -.. code-block:: shell +.. code-block:: reboot domain [--mode MODE-LIST] @@ -3492,7 +3492,7 @@ reset **Syntax:** -.. code-block:: shell +.. code-block:: reset domain @@ -3508,7 +3508,7 @@ restore **Syntax:** -.. code-block:: shell +.. code-block:: restore state-file [--bypass-cache] [--xml file] [{--running | --paused}] @@ -3540,7 +3540,7 @@ resume **Syntax:** -.. code-block:: shell +.. code-block:: resume domain @@ -3554,7 +3554,7 @@ save **Syntax:** -.. code-block:: shell +.. code-block:: save domain state-file [--bypass-cache] [--xml file] [{--running | --paused}] [--verbose] @@ -3598,7 +3598,7 @@ save-image-define **Syntax:** -.. code-block:: shell +.. code-block:: save-image-define file xml [{--running | --paused}] @@ -3620,7 +3620,7 @@ save-image-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: save-image-dumpxml file [--security-info] @@ -3634,7 +3634,7 @@ save-image-edit **Syntax:** -.. code-block:: shell +.. code-block:: save-image-edit file [{--running | --paused}] @@ -3648,7 +3648,7 @@ will allow overriding which state the ``restore`` should use. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh save-image-dumpxml state-file > state-file.xml vi state-file.xml (or make changes with your other text editor) @@ -3665,7 +3665,7 @@ schedinfo **Syntax:** -.. code-block:: shell +.. code-block:: schedinfo domain [[--config] [--live] | [--current]] [[--set] parameter=value]... schedinfo [--weight number] [--cap number] domain @@ -3706,7 +3706,7 @@ screenshot **Syntax:** -.. code-block:: shell +.. code-block:: screenshot domain [imagefilepath] [--screen screenID] @@ -3723,7 +3723,7 @@ send-key **Syntax:** -.. code-block:: shell +.. code-block:: send-key domain [--codeset codeset] [--holdtime holdtime] keycode... @@ -3820,7 +3820,7 @@ distinct keypresses, you must use multiple send-key invocations. **Examples:** -.. code-block:: shell +.. code-block:: # send three strokes 'k', 'e', 'y', using xt codeset. these # are all pressed simultaneously and may be received by the guest @@ -3840,7 +3840,7 @@ send-process-signal **Syntax:** -.. code-block:: shell +.. code-block:: send-process-signal domain-id pid signame @@ -3851,7 +3851,7 @@ domain namespace. The *signame* argument may be either an integer signal constant number, or one of the symbolic names: -.. code-block:: shell +.. code-block:: "nop", "hup", "int", "quit", "ill", "trap", "abrt", "bus", "fpe", "kill", @@ -3871,7 +3871,7 @@ may be in uppercase or lowercase. **Examples:** -.. code-block:: shell +.. code-block:: virsh send-process-signal myguest 1 15 virsh send-process-signal myguest 1 term @@ -3884,7 +3884,7 @@ set-lifecycle-action **Syntax:** -.. code-block:: shell +.. code-block:: set-lifecycle-action domain type action [[--config] [--live] | [--current]] @@ -3901,7 +3901,7 @@ set-user-password **Syntax:** -.. code-block:: shell +.. code-block:: set-user-password domain user password [--encrypted] @@ -3919,7 +3919,7 @@ setmaxmem **Syntax:** -.. code-block:: shell +.. code-block:: setmaxmem domain size [[--config] [--live] | [--current]] @@ -3950,7 +3950,7 @@ setmem **Syntax:** -.. code-block:: shell +.. code-block:: setmem domain size [[--config] [--live] | [--current]] @@ -3985,7 +3985,7 @@ setvcpus **Syntax:** -.. code-block:: shell +.. code-block:: setvcpus domain count [--maximum] [[--config] [--live] | [--current]] [--guest] [--hotpluggable] @@ -4036,7 +4036,7 @@ setvcpu **Syntax:** -.. code-block:: shell +.. code-block:: setvcpu domain vcpulist [--enable] | [--disable] [[--live] [--config] | [--current]] @@ -4063,7 +4063,7 @@ shutdown **Syntax:** -.. code-block:: shell +.. code-block:: shutdown domain [--mode MODE-LIST] @@ -4095,7 +4095,7 @@ start **Syntax:** -.. code-block:: shell +.. code-block:: start domain-name-or-uuid [--console] [--paused] [--autodestroy] [--bypass-cache] [--force-boot] @@ -4124,7 +4124,7 @@ suspend **Syntax:** -.. code-block:: shell +.. code-block:: suspend domain @@ -4137,7 +4137,7 @@ ttyconsole **Syntax:** -.. code-block:: shell +.. code-block:: ttyconsole domain @@ -4150,7 +4150,7 @@ undefine **Syntax:** -.. code-block:: shell +.. code-block:: undefine domain [--managed-save] [--snapshots-metadata] [--checkpoints-metadata] [--nvram] [--keep-nvram] @@ -4216,7 +4216,7 @@ vcpucount **Syntax:** -.. code-block:: shell +.. code-block:: vcpucount domain [{--maximum | --active} {--config | --live | --current}] [--guest] @@ -4247,7 +4247,7 @@ vcpuinfo **Syntax:** -.. code-block:: shell +.. code-block:: vcpuinfo domain [--pretty] @@ -4258,7 +4258,7 @@ With *--pretty*, cpu affinities are shown as ranges. **Example:** -.. code-block:: shell +.. code-block:: $ virsh vcpuinfo fedora VCPU: 0 @@ -4311,7 +4311,7 @@ vcpupin **Syntax:** -.. code-block:: shell +.. code-block:: vcpupin domain [vcpu] [cpulist] [[--live] [--config] | [--current]] @@ -4339,7 +4339,7 @@ vncdisplay **Syntax:** -.. code-block:: shell +.. code-block:: vncdisplay domain @@ -4362,7 +4362,7 @@ attach-device **Syntax:** -.. code-block:: shell +.. code-block:: attach-device domain FILE [[[--live] [--config] | [--current]] | [--persistent]] @@ -4398,7 +4398,7 @@ attach-disk **Syntax:** -.. code-block:: shell +.. code-block:: attach-disk domain source target [[[--live] [--config] | [--current]] | [--persistent]] [--targetbus bus] @@ -4464,7 +4464,7 @@ attach-interface **Syntax:** -.. code-block:: shell +.. code-block:: attach-interface domain type source [[[--live] [--config] | [--current]] | [--persistent]] @@ -4555,7 +4555,7 @@ detach-device **Syntax:** -.. code-block:: shell +.. code-block:: detach-device domain FILE [[[--live] [--config] | [--current]] | [--persistent]] @@ -4601,7 +4601,7 @@ detach-device-alias **Syntax:** -.. code-block:: shell +.. code-block:: detach-device-alias domain alias [[[--live] [--config] | [--current]]]] @@ -4622,7 +4622,7 @@ detach-disk **Syntax:** -.. code-block:: shell +.. code-block:: detach-disk domain target [[[--live] [--config] | [--current]] | [--persistent]] [--print-xml] @@ -4655,7 +4655,7 @@ detach-interface **Syntax:** -.. code-block:: shell +.. code-block:: detach-interface domain type [--mac mac] [[[--live] [--config] | [--current]] | [--persistent]] @@ -4687,7 +4687,7 @@ update-device **Syntax:** -.. code-block:: shell +.. code-block:: update-device domain file [--force] [[[--live] [--config] | [--current]] | [--persistent]] @@ -4721,7 +4721,7 @@ change-media **Syntax:** -.. code-block:: shell +.. code-block:: change-media domain path [--eject] [--insert] [--update] [source] [--force] [[--live] [--config] | @@ -4791,7 +4791,7 @@ nodedev-create **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-create FILE @@ -4807,7 +4807,7 @@ nodedev-destroy **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-destroy device @@ -4822,7 +4822,7 @@ nodedev-detach **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-detach nodedev [--driver backend_driver] @@ -4842,7 +4842,7 @@ nodedev-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-dumpxml device @@ -4859,7 +4859,7 @@ nodedev-list **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-list cap --tree @@ -4878,7 +4878,7 @@ nodedev-reattach **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-reattach nodedev @@ -4893,7 +4893,7 @@ nodedev-reset **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-reset nodedev @@ -4908,7 +4908,7 @@ nodedev-event **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-event {[nodedev] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -4944,7 +4944,7 @@ net-autostart **Syntax:** -.. code-block:: shell +.. code-block:: net-autostart network [--disable] @@ -4957,7 +4957,7 @@ net-create **Syntax:** -.. code-block:: shell +.. code-block:: net-create file @@ -4972,7 +4972,7 @@ net-define **Syntax:** -.. code-block:: shell +.. code-block:: net-define file @@ -4985,7 +4985,7 @@ net-destroy **Syntax:** -.. code-block:: shell +.. code-block:: net-destroy network @@ -4998,7 +4998,7 @@ net-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: net-dumpxml network [--inactive] @@ -5013,7 +5013,7 @@ net-edit **Syntax:** -.. code-block:: shell +.. code-block:: net-edit network @@ -5021,7 +5021,7 @@ Edit the XML configuration file for a network. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh net-dumpxml --inactive network > network.xml vi network.xml (or make changes with your other text editor) @@ -5038,7 +5038,7 @@ net-event **Syntax:** -.. code-block:: shell +.. code-block:: net-event {[network] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -5063,7 +5063,7 @@ net-info **Syntax:** -.. code-block:: shell +.. code-block:: net-info network @@ -5075,7 +5075,7 @@ net-list **Syntax:** -.. code-block:: shell +.. code-block:: net-list [--inactive | --all] { [--table] | --name | --uuid } @@ -5106,7 +5106,7 @@ net-name **Syntax:** -.. code-block:: shell +.. code-block:: net-name network-UUID @@ -5118,7 +5118,7 @@ net-start **Syntax:** -.. code-block:: shell +.. code-block:: net-start network @@ -5130,7 +5130,7 @@ net-undefine **Syntax:** -.. code-block:: shell +.. code-block:: net-undefine network @@ -5143,7 +5143,7 @@ net-uuid **Syntax:** -.. code-block:: shell +.. code-block:: net-uuid network-name @@ -5155,7 +5155,7 @@ net-update **Syntax:** -.. code-block:: shell +.. code-block:: net-update network command section xml [--parent-index index] [[--live] [--config] | [--current]] @@ -5202,7 +5202,7 @@ net-dhcp-leases **Syntax:** -.. code-block:: shell +.. code-block:: net-dhcp-leases network [mac] @@ -5227,7 +5227,7 @@ net-port-list **Syntax:** -.. code-block:: shell +.. code-block:: net-port-list { [--table] | --uuid } network @@ -5244,7 +5244,7 @@ net-port-create **Syntax:** -.. code-block:: shell +.. code-block:: net-port-create network file @@ -5257,7 +5257,7 @@ net-port-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: net-port-dumpxml network port @@ -5269,7 +5269,7 @@ net-port-delete **Syntax:** -.. code-block:: shell +.. code-block:: net-port-delete network port @@ -5298,7 +5298,7 @@ iface-bridge **Syntax:** -.. code-block:: shell +.. code-block:: iface-bridge interface bridge [--no-stp] [delay] [--no-start] @@ -5317,7 +5317,7 @@ iface-define **Syntax:** -.. code-block:: shell +.. code-block:: iface-define file @@ -5330,7 +5330,7 @@ iface-destroy **Syntax:** -.. code-block:: shell +.. code-block:: iface-destroy interface @@ -5343,7 +5343,7 @@ iface-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: iface-dumpxml interface [--inactive] @@ -5357,7 +5357,7 @@ iface-edit **Syntax:** -.. code-block:: shell +.. code-block:: iface-edit interface @@ -5365,7 +5365,7 @@ Edit the XML configuration file for a host interface. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh iface-dumpxml iface > iface.xml vi iface.xml (or make changes with your other text editor) @@ -5382,7 +5382,7 @@ iface-list **Syntax:** -.. code-block:: shell +.. code-block:: iface-list [--inactive | --all] @@ -5396,7 +5396,7 @@ iface-name **Syntax:** -.. code-block:: shell +.. code-block:: iface-name interface @@ -5411,7 +5411,7 @@ iface-mac **Syntax:** -.. code-block:: shell +.. code-block:: iface-mac interface @@ -5425,7 +5425,7 @@ iface-start **Syntax:** -.. code-block:: shell +.. code-block:: iface-start interface @@ -5437,7 +5437,7 @@ iface-unbridge **Syntax:** -.. code-block:: shell +.. code-block:: iface-unbridge bridge [--no-start] @@ -5455,7 +5455,7 @@ iface-undefine **Syntax:** -.. code-block:: shell +.. code-block:: iface-undefine interface @@ -5467,7 +5467,7 @@ iface-begin **Syntax:** -.. code-block:: shell +.. code-block:: iface-begin @@ -5485,7 +5485,7 @@ iface-commit **Syntax:** -.. code-block:: shell +.. code-block:: iface-commit @@ -5499,7 +5499,7 @@ iface-rollback **Syntax:** -.. code-block:: shell +.. code-block:: iface-rollback @@ -5525,7 +5525,7 @@ find-storage-pool-sources **Syntax:** -.. code-block:: shell +.. code-block:: find-storage-pool-sources type [srcSpec] @@ -5562,7 +5562,7 @@ find-pool-sources-as **Syntax:** -.. code-block:: shell +.. code-block:: find-storage-pool-sources-as type [host] [port] [initiator] @@ -5586,7 +5586,7 @@ pool-autostart **Syntax:** -.. code-block:: shell +.. code-block:: pool-autostart pool-or-uuid [--disable] @@ -5598,7 +5598,7 @@ pool-build **Syntax:** -.. code-block:: shell +.. code-block:: pool-build pool-or-uuid [--overwrite] [--no-overwrite] @@ -5640,7 +5640,7 @@ pool-create **Syntax:** -.. code-block:: shell +.. code-block:: pool-create file [--build] [[--overwrite] | [--no-overwrite]] @@ -5658,7 +5658,7 @@ pool-create-as **Syntax:** -.. code-block:: shell +.. code-block:: pool-create-as name type [--source-host hostname] [--source-path path] [--source-dev path] @@ -5744,7 +5744,7 @@ pool-define **Syntax:** -.. code-block:: shell +.. code-block:: pool-define file @@ -5757,7 +5757,7 @@ pool-define-as **Syntax:** -.. code-block:: shell +.. code-block:: pool-define-as name type [--source-host hostname] [--source-path path] [--source-dev path] @@ -5782,7 +5782,7 @@ pool-destroy **Syntax:** -.. code-block:: shell +.. code-block:: pool-destroy pool-or-uuid @@ -5797,7 +5797,7 @@ pool-delete **Syntax:** -.. code-block:: shell +.. code-block:: pool-delete pool-or-uuid @@ -5811,7 +5811,7 @@ pool-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: pool-dumpxml [--inactive] pool-or-uuid @@ -5825,7 +5825,7 @@ pool-edit **Syntax:** -.. code-block:: shell +.. code-block:: pool-edit pool-or-uuid @@ -5833,7 +5833,7 @@ Edit the XML configuration file for a storage pool. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh pool-dumpxml pool > pool.xml vi pool.xml (or make changes with your other text editor) @@ -5850,7 +5850,7 @@ pool-info **Syntax:** -.. code-block:: shell +.. code-block:: pool-info [--bytes] pool-or-uuid @@ -5863,7 +5863,7 @@ pool-list **Syntax:** -.. code-block:: shell +.. code-block:: pool-list [--inactive] [--all] [--persistent] [--transient] @@ -5903,7 +5903,7 @@ pool-name **Syntax:** -.. code-block:: shell +.. code-block:: pool-name uuid @@ -5915,7 +5915,7 @@ pool-refresh **Syntax:** -.. code-block:: shell +.. code-block:: pool-refresh pool-or-uuid @@ -5927,7 +5927,7 @@ pool-start **Syntax:** -.. code-block:: shell +.. code-block:: pool-start pool-or-uuid [--build] [[--overwrite] | [--no-overwrite]] @@ -5955,7 +5955,7 @@ pool-undefine **Syntax:** -.. code-block:: shell +.. code-block:: pool-undefine pool-or-uuid @@ -5967,7 +5967,7 @@ pool-uuid **Syntax:** -.. code-block:: shell +.. code-block:: pool-uuid pool @@ -5979,7 +5979,7 @@ pool-event **Syntax:** -.. code-block:: shell +.. code-block:: pool-event {[pool] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -6007,7 +6007,7 @@ vol-create **Syntax:** -.. code-block:: shell +.. code-block:: vol-create pool-or-uuid FILE [--prealloc-metadata] @@ -6026,7 +6026,7 @@ only slightly higher initial disk space usage. **Example:** -.. code-block:: shell +.. code-block:: virsh vol-dumpxml --pool storagepool1 appvolume1 > newvolume.xml vi newvolume.xml (or make changes with your other text editor) @@ -6038,7 +6038,7 @@ vol-create-from **Syntax:** -.. code-block:: shell +.. code-block:: vol-create-from pool-or-uuid FILE vol-name-or-key-or-path [--inputpool pool-or-uuid] [--prealloc-metadata] [--reflink] @@ -6069,7 +6069,7 @@ vol-create-as **Syntax:** -.. code-block:: shell +.. code-block:: vol-create-as pool-or-uuid name capacity [--allocation size] [--format string] [--backing-vol vol-name-or-key-or-path] @@ -6118,7 +6118,7 @@ vol-clone **Syntax:** -.. code-block:: shell +.. code-block:: vol-clone vol-name-or-key-or-path name [--pool pool-or-uuid] [--prealloc-metadata] [--reflink] @@ -6151,7 +6151,7 @@ vol-delete **Syntax:** -.. code-block:: shell +.. code-block:: vol-delete vol-name-or-key-or-path [--pool pool-or-uuid] [--delete-snapshots] @@ -6175,7 +6175,7 @@ vol-upload **Syntax:** -.. code-block:: shell +.. code-block:: vol-upload vol-name-or-key-or-path local-file [--pool pool-or-uuid] [--offset bytes] @@ -6213,7 +6213,7 @@ vol-download **Syntax:** -.. code-block:: shell +.. code-block:: vol-download vol-name-or-key-or-path local-file [--pool pool-or-uuid] [--offset bytes] [--length bytes] @@ -6244,7 +6244,7 @@ vol-wipe **Syntax:** -.. code-block:: shell +.. code-block:: vol-wipe vol-name-or-key-or-path [--pool pool-or-uuid] [--algorithm algorithm] @@ -6303,7 +6303,7 @@ vol-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: vol-dumpxml vol-name-or-key-or-path [--pool pool-or-uuid] @@ -6323,7 +6323,7 @@ vol-info **Syntax:** -.. code-block:: shell +.. code-block:: vol-info vol-name-or-key-or-path [--pool pool-or-uuid] [--bytes] [--physical] @@ -6352,7 +6352,7 @@ vol-list **Syntax:** -.. code-block:: shell +.. code-block:: vol-list [--pool pool-or-uuid] [--details] @@ -6369,7 +6369,7 @@ vol-pool **Syntax:** -.. code-block:: shell +.. code-block:: vol-pool vol-key-or-path [--uuid] @@ -6387,7 +6387,7 @@ vol-path **Syntax:** -.. code-block:: shell +.. code-block:: vol-path vol-name-or-key [--pool pool-or-uuid] @@ -6406,7 +6406,7 @@ vol-name **Syntax:** -.. code-block:: shell +.. code-block:: vol-name vol-key-or-path @@ -6420,7 +6420,7 @@ vol-key **Syntax:** -.. code-block:: shell +.. code-block:: vol-key vol-name-or-path [--pool pool-or-uuid] @@ -6440,7 +6440,7 @@ vol-resize **Syntax:** -.. code-block:: shell +.. code-block:: vol-resize vol-name-or-path capacity [--pool pool-or-uuid] [--allocate] [--delta] [--shrink] @@ -6485,7 +6485,7 @@ secret-define **Syntax:** -.. code-block:: shell +.. code-block:: secret-define file @@ -6500,7 +6500,7 @@ secret-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: secret-dumpxml secret @@ -6512,7 +6512,7 @@ secret-event **Syntax:** -.. code-block:: shell +.. code-block:: secret-event {[secret] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -6537,7 +6537,7 @@ secret-set-value **Syntax:** -.. code-block:: shell +.. code-block:: secret-set-value secret base64 @@ -6550,7 +6550,7 @@ secret-get-value **Syntax:** -.. code-block:: shell +.. code-block:: secret-get-value secret @@ -6563,7 +6563,7 @@ secret-undefine **Syntax:** -.. code-block:: shell +.. code-block:: secret-undefine secret @@ -6577,7 +6577,7 @@ secret-list **Syntax:** -.. code-block:: shell +.. code-block:: secret-list [--ephemeral] [--no-ephemeral] [--private] [--no-private] @@ -6604,7 +6604,7 @@ snapshot-create **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-create domain [xmlfile] {[--redefine [--current]] | [--no-metadata] [--halt] [--disk-only] [--reuse-external] @@ -6685,7 +6685,7 @@ snapshot-create-as **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-create-as domain {[--print-xml] [--no-metadata] [--halt] [--reuse-external]} [name] @@ -6723,7 +6723,7 @@ all three of *domain*, *name*, and *description* are also present. For example, a diskspec of "vda,snapshot=external,file=/path/to,,new" results in the following XML: -.. code-block:: xml +.. code-block:: <disk name='vda' snapshot='external'> <source file='/path/to,new'/> @@ -6766,7 +6766,7 @@ snapshot-current **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-current domain {[--name] | [--security-info] | [snapshotname]} @@ -6785,7 +6785,7 @@ snapshot-edit **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-edit domain [snapshotname] [--current] {[--rename] | [--clone]} @@ -6797,7 +6797,7 @@ snapshot. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh snapshot-dumpxml dom name > snapshot.xml vi snapshot.xml (or make changes with your other text editor) @@ -6822,7 +6822,7 @@ snapshot-info **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-info domain {snapshot | --current} @@ -6835,7 +6835,7 @@ snapshot-list **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-list domain [--metadata] [--no-metadata] [{--parent | --roots | [{--tree | --name}]}] [--topological] @@ -6904,7 +6904,7 @@ snapshot-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-dumpxml domain snapshot [--security-info] @@ -6918,7 +6918,7 @@ snapshot-parent **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-parent domain {snapshot | --current} @@ -6931,7 +6931,7 @@ snapshot-revert **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-revert domain {snapshot | --current} [{--running | --paused}] [--force] @@ -6972,7 +6972,7 @@ snapshot-delete **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-delete domain {snapshot | --current} [--metadata] [{--children | --children-only}] @@ -7006,7 +7006,7 @@ checkpoint-create **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-create domain [xmlfile] { --redefine | [--quiesce]} @@ -7045,7 +7045,7 @@ checkpoint-create-as **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-create-as domain [--print-xml] [name] [description] [--quiesce] [--diskspec] diskspec]... @@ -7065,7 +7065,7 @@ all three of *domain*, *name*, and *description* are also present. For example, a diskspec of "vda,checkpoint=bitmap,bitmap=map1" results in the following XML: -.. code-block:: xml +.. code-block:: <disk name='vda' checkpoint='bitmap' bitmap='map1'/> @@ -7083,7 +7083,7 @@ checkpoint-edit **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-edit domain checkpointname @@ -7091,7 +7091,7 @@ Edit the XML configuration file for *checkpointname* of a domain. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh checkpoint-dumpxml dom name > checkpoint.xml vi checkpoint.xml (or make changes with your other text editor) @@ -7109,7 +7109,7 @@ checkpoint-info **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-info domain checkpoint @@ -7121,7 +7121,7 @@ checkpoint-list **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-list domain [{--parent | --roots | [{--tree | --name}]}] [--topological] @@ -7167,7 +7167,7 @@ checkpoint-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-dumpxml domain checkpoint [--security-info] [--no-domain] [--size] @@ -7187,7 +7187,7 @@ checkpoint-parent **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-parent domain checkpoint @@ -7199,7 +7199,7 @@ checkpoint **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-delete domain checkpoint [--metadata] [{--children | --children-only}] @@ -7236,7 +7236,7 @@ nwfilter-define **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-define xmlfile @@ -7253,7 +7253,7 @@ nwfilter-undefine **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-undefine nwfilter-name @@ -7266,7 +7266,7 @@ nwfilter-list **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-list @@ -7278,7 +7278,7 @@ nwfilter-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-dumpxml nwfilter-name @@ -7290,7 +7290,7 @@ nwfilter-edit **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-edit nwfilter-name @@ -7298,7 +7298,7 @@ Edit the XML of a network filter. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh nwfilter-dumpxml myfilter > myfilter.xml vi myfilter.xml (or make changes with your other text editor) @@ -7329,7 +7329,7 @@ nwfilter-binding-create **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-binding-create xmlfile @@ -7348,7 +7348,7 @@ nwfilter-binding-delete **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-binding-delete port-name @@ -7366,7 +7366,7 @@ nwfilter-binding-list **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-binding-list @@ -7378,7 +7378,7 @@ nwfilter-binding-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-binding-dumpxml port-name @@ -7402,7 +7402,7 @@ qemu-attach **Syntax:** -.. code-block:: shell +.. code-block:: qemu-attach pid @@ -7411,7 +7411,7 @@ The QEMU process must have been created with a monitor connection using the UNIX driver. Ideally the process will also have had the '-name' argument specified. -.. code-block:: shell +.. code-block:: $ qemu-kvm -cdrom ~/demo.iso \ -monitor unix:/tmp/demo,server,nowait \ @@ -7432,7 +7432,7 @@ qemu-monitor-command **Syntax:** -.. code-block:: shell +.. code-block:: qemu-monitor-command domain { [--hmp] | [--pretty] } command... @@ -7451,7 +7451,7 @@ qemu-agent-command **Syntax:** -.. code-block:: shell +.. code-block:: qemu-agent-command domain [--timeout seconds | --async | --block] command... @@ -7469,7 +7469,7 @@ qemu-monitor-event **Syntax:** -.. code-block:: shell +.. code-block:: qemu-monitor-event [domain] [--event event-name] [--loop] [--timeout seconds] [--pretty] [--regex] [--no-case] @@ -7500,7 +7500,7 @@ lxc-enter-namespace **Syntax:** -.. code-block:: shell +.. code-block:: lxc-enter-namespace domain [--noseclabel] -- /path/to/binary [arg1, [arg2, ...]] diff --git a/docs/manpages/virt-admin.rst b/docs/manpages/virt-admin.rst index bf42139f30..51c3d3917e 100644 --- a/docs/manpages/virt-admin.rst +++ b/docs/manpages/virt-admin.rst @@ -28,7 +28,7 @@ as for monitoring and managing all clients connected to the daemon. The basic structure of most virt-admin usage is: -.. code-block:: shell +.. code-block:: virt-admin [OPTION]... <command> [ARG]... @@ -107,7 +107,7 @@ help **Syntax:** -.. code-block:: shell +.. code-block:: help [command-or-group] @@ -124,7 +124,7 @@ quit, exit **Syntax:** -.. code-block:: shell +.. code-block:: quit exit @@ -136,7 +136,7 @@ version **Syntax:** -.. code-block:: shell +.. code-block:: version @@ -146,7 +146,7 @@ the version of the daemon. **Example:** -.. code-block:: shell +.. code-block:: $ virt-admin version Compiled against library: libvirt 1.2.21 @@ -160,7 +160,7 @@ cd **Syntax:** -.. code-block:: shell +.. code-block:: cd [directory] @@ -175,7 +175,7 @@ pwd **Syntax:** -.. code-block:: shell +.. code-block:: pwd @@ -187,7 +187,7 @@ connect **Syntax:** -.. code-block:: shell +.. code-block:: connect [URI] @@ -206,7 +206,7 @@ uri **Syntax:** -.. code-block:: shell +.. code-block:: uri @@ -230,7 +230,7 @@ server-list **Syntax:** -.. code-block:: shell +.. code-block:: server-list @@ -243,7 +243,7 @@ daemon-log-filters **Syntax:** -.. code-block:: shell +.. code-block:: daemon-log-filters [--filters string] @@ -264,7 +264,7 @@ space. Each filter must conform to the form described in detail by To define a filter which suppresses all e.g. 'virObjectUnref' DEBUG messages, use the following: -.. code-block:: shell +.. code-block:: $ virt-admin daemon-log-filters "4:util.object" @@ -277,7 +277,7 @@ daemon-log-outouts **Syntax:** -.. code-block:: shell +.. code-block:: daemon-log-outputs [--outputs string] @@ -298,13 +298,13 @@ space. Each output must conform to the form described in detail by To replace the current setting for logging outputs with one that writes to a file while logging errors only, the following could be used: -.. code-block:: shell +.. code-block:: $ virt-admin daemon-log-outputs "4:file:<absolute_path_to_the_file>" To define multiple outputs at once they need to be delimited by spaces: -.. code-block:: shell +.. code-block:: $ virt-admin daemon-log-outputs "4:stderr 2:syslog:<msg_ident>" @@ -320,7 +320,7 @@ server-threadpool-info **Syntax:** -.. code-block:: shell +.. code-block:: server-threadpool-info server @@ -355,7 +355,7 @@ that, unlike tasks carried out by normal workers, are within libvirt's full control and libvirt guarantees that such a task cannot hang, thus will always finish. An example of such a task this would be destroying a domain: -.. code-block:: shell +.. code-block:: $ virsh destroy <domain>. @@ -365,7 +365,7 @@ server-threadpool-set **Syntax:** -.. code-block:: shell +.. code-block:: server-threadpool-set server [--min-workers count] [--max-workers count] [--priority-workers count] @@ -394,7 +394,7 @@ server-clients-info **Syntax:** -.. code-block:: shell +.. code-block:: server-clients-info server @@ -407,7 +407,7 @@ runtime values, more specifically, the current number of clients connected to **Example:** -.. code-block:: shell +.. code-block:: # virt-admin server-clients-info libvirtd nclients_max : 120 @@ -421,7 +421,7 @@ server-clients-set **Syntax:** -.. code-block:: shell +.. code-block:: server-clients-set server [--max-clients count] [--max-unauth-clients count] @@ -457,7 +457,7 @@ client-list **Syntax:** -.. code-block:: shell +.. code-block:: client-list server @@ -471,7 +471,7 @@ client-info **Syntax:** -.. code-block:: shell +.. code-block:: client-info server client @@ -487,7 +487,7 @@ enabled within daemon). **Examples:** -.. code-block:: shell +.. code-block:: # virt-admin client-info libvirtd 1 id : 1 @@ -513,7 +513,7 @@ client-disconnect **Syntax:** -.. code-block:: shell +.. code-block:: client-disconnect server client diff --git a/docs/manpages/virt-login-shell.rst b/docs/manpages/virt-login-shell.rst index 4716493f87..3833a3e912 100644 --- a/docs/manpages/virt-login-shell.rst +++ b/docs/manpages/virt-login-shell.rst @@ -29,7 +29,7 @@ configured in ``/etc/libvirt/virt-login-shell.conf``. The basic structure of most ``virt-login-shell`` usage is: -.. code-block:: shell +.. code-block:: virt-login-shell diff --git a/docs/manpages/virtlockd.rst b/docs/manpages/virtlockd.rst index 4066934e42..1dc106d6fc 100644 --- a/docs/manpages/virtlockd.rst +++ b/docs/manpages/virtlockd.rst @@ -120,14 +120,14 @@ EXAMPLES To retrieve the version of ``virtlockd``: -.. code-block:: shell +.. code-block:: # virtlockd --version virtlockd (libvirt) 1.1.1 To start ``virtlockd``, instructing it to daemonize and create a PID file: -.. code-block:: shell +.. code-block:: # virtlockd -d # ls -la RUNSTATEDIR/virtlockd.pid diff --git a/docs/manpages/virtlogd.rst b/docs/manpages/virtlogd.rst index 7f4c5d7e7f..c84ab2e621 100644 --- a/docs/manpages/virtlogd.rst +++ b/docs/manpages/virtlogd.rst @@ -121,14 +121,14 @@ EXAMPLES To retrieve the version of ``virtlogd``: -.. code-block:: shell +.. code-block:: # virtlogd --version virtlogd (libvirt) 1.1.1 To start ``virtlogd``, instructing it to daemonize and create a PID file: -.. code-block:: shell +.. code-block:: # virtlogd -d # ls -la RUNSTATEDIR/virtlogd.pid -- 2.23.0

1 1

[libvirt] [jenkins-ci PATCH 0/2] Add glibc-langpack-en to the mappings & to the base project
by Fabiano Fidêncio 12 Dec '19

12 Dec '19

As done for locales, lets also add glibc-langpack-en to the mappings and to the base project. The reasoning for that is that (at least) osinfo-db tests set the locale to en_US causing errors like: 1215 INTERNALERROR> Traceback (most recent call last): 1216 INTERNALERROR> File "/usr/lib/python3.6/site-packages/_pytest/main.py", line 96, in wrap_session 1217 INTERNALERROR> config._do_configure() 1218 INTERNALERROR> File "/usr/lib/python3.6/site-packages/_pytest/config.py", line 922, in _do_configure 1219 INTERNALERROR> self.hook.pytest_configure.call_historic(kwargs=dict(config=self)) 1220 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 628, in call_historic 1221 INTERNALERROR> res = self._hookexec(self, self._nonwrappers + self._wrappers, kwargs) 1222 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 222, in _hookexec 1223 INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs) 1224 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 216, in <lambda> 1225 INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'), 1226 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall 1227 INTERNALERROR> return outcome.get_result() 1228 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result 1229 INTERNALERROR> raise ex[1].with_traceback(ex[2]) 1230 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall 1231 INTERNALERROR> res = hook_impl.function(*args) 1232 INTERNALERROR> File "/builds/fidencio/osinfo-db/tests/conftest.py", line 27, in pytest_configure 1233 INTERNALERROR> locale.setlocale(locale.LC_CTYPE, 'en_US.UTF-8') 1234 INTERNALERROR> File "/usr/lib64/python3.6/locale.py", line 598, in setlocale 1235 INTERNALERROR> return _setlocale(category, locale) 1236 INTERNALERROR> locale.Error: unsupported locale setting 1237 make: *** [../Makefile:124: check] Error 3 Fabiano Fidêncio (2): mappings: Add glibc-langpack-en guests: Add glibc-langpack-en to the base project guests/vars/mappings.yml | 5 +++++ guests/vars/projects/base.yml | 1 + 2 files changed, 6 insertions(+) -- 2.23.0

2 4

[libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet
by Andrea Bolognani 12 Dec '19

12 Dec '19

We're currently waiting to see whether we can get more capacity for our CI environment, and in the meantime we've decided not do create additional builders on the existing machine. In order to be able to deploy other configuration changes without enabling CentOS 8 jobs at the same time, we need to temporarily drop all mentions of the target from the Jenkins configuration: once we've figured out where to create the CentOS 8 builder, we can simply revert this patch. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- jenkins/jobs/defaults.yaml | 2 -- jenkins/projects/libosinfo.yaml | 1 - jenkins/projects/libvirt-dbus.yaml | 2 -- jenkins/projects/libvirt.yaml | 1 - jenkins/projects/osinfo-db-tools.yaml | 1 - jenkins/projects/virt-manager.yaml | 3 --- 6 files changed, 10 deletions(-) diff --git a/jenkins/jobs/defaults.yaml b/jenkins/jobs/defaults.yaml index 9232d42..676ecbf 100644 --- a/jenkins/jobs/defaults.yaml +++ b/jenkins/jobs/defaults.yaml @@ -4,7 +4,6 @@ node: libvirt all_machines: - libvirt-centos-7 - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 @@ -14,7 +13,6 @@ - libvirt-freebsd-12 rpm_machines: - libvirt-centos-7 - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide diff --git a/jenkins/projects/libosinfo.yaml b/jenkins/projects/libosinfo.yaml index cc7e024..819c5ac 100644 --- a/jenkins/projects/libosinfo.yaml +++ b/jenkins/projects/libosinfo.yaml @@ -15,7 +15,6 @@ # RPM build is still not possible on CentOS7 as it does not # have the needed RPM macros for meson. machines: - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide diff --git a/jenkins/projects/libvirt-dbus.yaml b/jenkins/projects/libvirt-dbus.yaml index e71e2f9..dfc159c 100644 --- a/jenkins/projects/libvirt-dbus.yaml +++ b/jenkins/projects/libvirt-dbus.yaml @@ -15,7 +15,6 @@ # Python3 version in Ubuntu 16.04 and python3-pytest version # in CentOS 7 are too old. machines: - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 @@ -26,7 +25,6 @@ # RPM build is still not possible on CentOS7 as it does not # have the needed RPM macros for meson. machines: - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide diff --git a/jenkins/projects/libvirt.yaml b/jenkins/projects/libvirt.yaml index fa8fb89..fdc24bc 100644 --- a/jenkins/projects/libvirt.yaml +++ b/jenkins/projects/libvirt.yaml @@ -14,7 +14,6 @@ # commands with more arguments than FreeBSD supports machines: - libvirt-centos-7 - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 diff --git a/jenkins/projects/osinfo-db-tools.yaml b/jenkins/projects/osinfo-db-tools.yaml index 7831df4..f28e72f 100644 --- a/jenkins/projects/osinfo-db-tools.yaml +++ b/jenkins/projects/osinfo-db-tools.yaml @@ -15,7 +15,6 @@ # RPM build is still not possible on CentOS7 as it does not # have the needed RPM macros for meson. machines: - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide diff --git a/jenkins/projects/virt-manager.yaml b/jenkins/projects/virt-manager.yaml index 9c4c3bf..4524831 100644 --- a/jenkins/projects/virt-manager.yaml +++ b/jenkins/projects/virt-manager.yaml @@ -3,7 +3,6 @@ name: virt-manager # CentOS 7 and Ubuntu 16.04 have Python 3 but not the libxml2 bindings machines: - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 @@ -27,7 +26,6 @@ # so skip the test suite there for the time being. See # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224902 machines: - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 @@ -36,7 +34,6 @@ - python-distutils-rpm-job: parent_jobs: 'virt-manager-check' machines: - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide -- 2.23.0

3 5

[libvirt] [PATCH v2 0/1] qemu: fix crash bug in snapshot revert
by Pavel Mores 12 Dec '19

12 Dec '19

This is a significant rework of v1 as - patch 1 was dropped because an equivalent change was accidentally committed in the meantime in 4c53267b70fc5c548b6530113c3f96870d8d7fc1 - patch 2 was dropped as it was just a mostly formal clean-up of patch 1 - patch 3 was redone using a different approach. Patch 3 now takes the approach that was hinted at in the last paragraph of v1's cover letter, more specifically it now fixes qemuProcessStop() rather than its caller. Digging into git history I located the commit that introduced qemuProcessStop()'s problematic behaviour and after consulting with Michal, we agreed that fixing qemuProcessStop() seems safe enough, and definitely a better solution conceptually. Pavel Mores (1): qemu: fix concurrency crash bug in snapshot revert src/qemu/qemu_domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.21.0

3 3

[libvirt] [libvirt-tck PATCH] Add cases for nvram
by Dan Zheng 12 Dec '19

12 Dec '19

This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- scripts/domain/401-ovmf-nvram.t | 143 ++++++++++++++++++++++++++++++++ 1 file changed, 143 insertions(+) create mode 100644 scripts/domain/401-ovmf-nvram.t diff --git a/scripts/domain/401-ovmf-nvram.t b/scripts/domain/401-ovmf-nvram.t new file mode 100644 index 0000000..5310dd0 --- /dev/null +++ b/scripts/domain/401-ovmf-nvram.t @@ -0,0 +1,143 @@ +# -*- perl -*- +# +# Copyright (C) 2009 Red Hat, Inc. +# Copyright (C) 2018 Dan Zheng (dzheng(a)redhat.com) +# +# This program is free software; You can redistribute it and/or modify +# it under the GNU General Public License as published by the Free +# Software Foundation; either version 2, or (at your option) any +# later version +# +# The file "LICENSE" distributed along with this file provides full +# details of the terms and conditions +# + +=pod + +=head1 NAME + +domain/401-ovmf-nvram.t - Test OVMF related functions and flags + +=head1 DESCRIPTION + +The test cases validates OVMF related APIs and flags + +Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM +Sys::Virt::Domain::UNDEFINE_NVRAM + +=cut + +use strict; +use warnings; + +use Test::More tests => 8; + +use Sys::Virt::TCK; +use File::stat; +use File::Copy; + + +my $tck = Sys::Virt::TCK->new(); +my $conn = eval { $tck->setup(); }; +BAIL_OUT "failed to setup test harness: $@" if $@; +END { $tck->cleanup if $tck; } + + +sub setup_nvram { + +my $loader_path = shift; +my $nvram_template = shift; +my $nvram_path = shift; + +# Install OVMF and check the two files should exist +# - /usr/share/OVMF/OVMF_CODE.secboot.fd +# - /usr/share/OVMF/OVMF_VARS.fd + +my $ret = `yum install -y OVMF`; +diag "yum install OVMF: $ret"; +my $st = stat($loader_path); +ok($st, "path $loader_path exists after OVMF is installed"); +$st = stat($nvram_template); +ok($st, "path $nvram_template exists after OVMF is installed"); + +# Ensure the sample nvram file exists +copy($nvram_template, $nvram_path) or die "Copy failed: $!"; + +# Use 'q35' as machine type and add below lines to guest xml +# <loader readonly='yes' secure='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.secboot.fd</loader> +# <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/test_VARS.fd</nvram> + +my $xml = $tck->generic_domain(name => "tck")->as_xml; +my $xp = XML::XPath->new($xml); +diag $xp->getNodeText("/domain/os/type/\@machine"); + +diag "Changing guest machine type to q35"; +$xp->setNodeText("/domain/os/type/\@machine", "q35"); + +my $loader_node = XML::XPath::Node::Element->new('loader'); +my $loader_text = XML::XPath::Node::Text->new($loader_path); +my $attr_ro = XML::XPath::Node::Attribute->new('readonly'); +my $attr_secure = XML::XPath::Node::Attribute->new('secure'); +my $attr_type = XML::XPath::Node::Attribute->new('type'); + +$attr_ro -> setNodeValue('yes'); +$attr_secure -> setNodeValue('yes'); +$attr_type -> setNodeValue('pflash'); + +$loader_node->appendChild($loader_text); +$loader_node->appendAttribute($attr_ro); +$loader_node->appendAttribute($attr_secure); +$loader_node->appendAttribute($attr_type); + +my $nvram_node = XML::XPath::Node::Element->new('nvram'); +my $nvram_text = XML::XPath::Node::Text->new($nvram_path); +my $attr_template = XML::XPath::Node::Attribute->new('template'); + +$attr_template -> setNodeValue($nvram_template); + +$nvram_node->appendChild($nvram_text); +$nvram_node->appendAttribute($attr_template); + +my $smm_node = XML::XPath::Node::Element->new('smm'); +my $attr_state = XML::XPath::Node::Attribute->new('state'); +$attr_state -> setNodeValue("on"); +$smm_node -> appendAttribute($attr_state); + +my ($root) = $xp->findnodes('/domain/os'); +$root->appendChild($loader_node); +$root->appendChild($nvram_node); +($root) = $xp->findnodes('/domain/features'); +$root->appendChild($smm_node); + +$xml = $xp->findnodes_as_string('/'); +diag $xml; +return $xml; +} + +diag "Defining an inactive domain config with nvram"; +my $loader_file_path = '/usr/share/OVMF/OVMF_CODE.secboot.fd'; +my $nvram_file_template = '/usr/share/OVMF/OVMF_VARS.fd'; +my $nvram_file_path = '/var/lib/libvirt/qemu/nvram/test_VARS.fd'; + +my $xml = setup_nvram($loader_file_path, $nvram_file_template, $nvram_file_path); +my $dom; + +diag "Test Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +diag "Checking nvram file already exists"; +my $st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' exists as expected"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM); +diag "Checking nvram file still exists"; +$st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' still exists as expected"); + +diag "Test Sys::Virt::Domain::UNDEFINE_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_NVRAM); +diag "Checking nvram file removed"; +$st = stat($nvram_file_path); +ok(!$st, "File '$nvram_file_path' is removed"); + +ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised from missing domain", + Sys::Virt::Error::ERR_NO_DOMAIN); -- 2.18.1

1 0

[libvirt] [PATCH] ci: Fix VPATH builds
by Andrea Bolognani 12 Dec '19

12 Dec '19

The CI build machinery is intentionally not handled by autotools, so for VPATH builds - which are mandatory now - we need to make sure we're looking into $(srcdir). Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 15df6ed68e..4edb3fdd43 100644 --- a/Makefile.am +++ b/Makefile.am @@ -148,4 +148,4 @@ gen-AUTHORS: fi ci-%: - $(MAKE) -C ci/ $@ + $(MAKE) -C $(srcdir)/ci/ $@ -- 2.23.0

2 1