- Devel - libvirt List Archives

[PATCH] NEWS: Fix vertical spacing
by Andrea Bolognani 01 Dec '23

01 Dec '23

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. NEWS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 29b977565b..c0a6d180a2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -89,6 +89,7 @@ v9.9.0 (2023-11-01) The ``virsh create --console`` now tries to connect to the guest console before starting the vCPUs. + v9.8.0 (2023-10-02) =================== @@ -131,6 +132,7 @@ v9.8.0 (2023-10-02) Now libvirt validates more values of virtio-mem and virtio-pmem devices, e.g. overlapping memory addresses or alignment. + v9.7.0 (2023-09-01) =================== @@ -2549,7 +2551,6 @@ v6.6.0 (2020-08-02) management applications may wish to override this behaviour. This is now possible via new ``cow`` element. - * **Improvements** * esx: Change the NIC limit for recent virtualHW versions @@ -2574,7 +2575,6 @@ v6.6.0 (2020-08-02) instead of all possible CPUs are returned making these APIs consistent with the behavior of ``vcpuinfo``. - * **Bug fixes** * virdevmapper: Don't use libdevmapper to obtain dependencies -- 2.43.0

1 0

Release of libvirt-9.10.0
by Jiri Denemark 01 Dec '23

01 Dec '23

The 9.10.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * Introduce pipewire audio backend The QEMU hypervisor driver now allows setting ``pipewire`` backend for ``<audio/>`` device. * Improvements * Adapt to qemu's use of protocol drivers in QCOW2 'backing file format' field QEMU allows creating images where the 'backing file format' is actually a protocol name such as 'file'/'host_device'/'nbd'/etc.. Adapt libvirt to properly handle such images and don't assume automatic format probing is necessary, which is in many cases forbidden due to security implications. * Bug fixes * qemu: Fix setup of images on hotplug of disk Internal image metadata was not setup correctly which could cause some disk hotplug configurations (namely those including backing images) to fail. * qemu: Fix qemu crash when reverting an internal snapshot Libvirt attempted to start qemu with wrong arguments when attempting to revert to an internal snapshot causing qemu to crash. * qemu: Fix hotplug of empty cdrom Empty cdrom drive couldn't be hotplugged as libvirt wanted to setup the storage backing it unconditionally. Enjoy. Jirka

1 0

[libvirt PATCH 0/1] rpcgen: Skip generator tests on macOS
by Andrea Bolognani 01 Dec '23

01 Dec '23

Based on: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/GLJL… Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1091405064 Since we're supposed to tag 9.10.0 tomorrow, go for the quick and dirty workaround. Andrea Bolognani (1): rpcgen: Skip generator tests on macOS scripts/rpcgen/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.43.0

2 3

[PATCH 0/2] Report better error message with no socket to connect to
by Martin Kletzander 01 Dec '23

01 Dec '23

When opening a libvirt connection with no URI set and no daemon running the error message might be confusing at times, so these patches are trying to mitigate such confusion. Martin Kletzander (2): Report first tried socket from remoteProbeSystemDriverFromSocket Report better error message in remoteGetUNIXSocket src/remote/remote_daemon_dispatch.c | 2 +- src/remote/remote_sockets.c | 22 ++++++++++++++++++---- src/remote/remote_sockets.h | 2 +- 3 files changed, 20 insertions(+), 6 deletions(-) -- 2.43.0

5 25

[PATCH] NEWS: Mention image probing, snaphsot and hotplug fixes
by Peter Krempa 01 Dec '23

01 Dec '23

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index f12734c2a1..9739bcdc36 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -24,8 +24,30 @@ v9.10.0 (unreleased) * **Improvements** + * Adapt to qemu's use of protocol drivers in QCOW2 'backing file format' field + + QEMU allows creating images where the 'backing file format' is actually a + protocol name such as 'file'/'host_device'/'nbd'/etc.. Adapt libvirt to + properly handle such images and don't assume automatic format probing is + necessary, which is in many cases forbidden due to security implications. + * **Bug fixes** + * qemu: Fix setup of images on hotplug of disk + + Internal image metadata was not setup correctly which could cause some disk + hotplug configurations (namely those including backing images) to fail. + + * qemu: Fix qemu crash when reverting an internal snapshot + + Libvirt attempted to start qemu with wrong arguments when attempting to + revert to an internal snapshot causing qemu to crash. + + * qemu: Fix hotplug of empty cdrom + + Empty cdrom drive couldn't be hotplugged as libvirt wanted to setup the + storage backing it unconditionally. + v9.9.0 (2023-11-01) =================== -- 2.43.0

2 1

[PATCH for 9.9.0] qemuProcessStartWithMemoryState: Don't start qemu with '-loadvm SNAP' and '-incoming defer' together
by Peter Krempa 01 Dec '23

01 Dec '23

A bug in qemuProcessStartWithMemoryState caused that we would start qemu with '-loadvm SNAP' and '-incoming defer' together. qemu doesn't expect that and crashes on an assertion failure [1]. [1]: https://issues.redhat.com/browse/RHEL-16782 Fixes: 8a88d3e5860881f430e528d3e5e8d6455ded4d1d Resolves: https://issues.redhat.com/browse/RHEL-17841 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_process.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f32e82bbd1..fc05b4b24f 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8196,6 +8196,7 @@ qemuProcessStartWithMemoryState(virConnectPtr conn, VIR_AUTOCLOSE intermediatefd = -1; g_autoptr(virCommand) cmd = NULL; g_autofree char *errbuf = NULL; + const char *migrateFrom = NULL; int rc = 0; if (data) { @@ -8207,6 +8208,8 @@ qemuProcessStartWithMemoryState(virConnectPtr conn, &errbuf, &cmd) < 0) { return -1; } + + migrateFrom = "stdio"; } /* No cookie means libvirt which saved the domain was too old to mess up @@ -8220,7 +8223,7 @@ qemuProcessStartWithMemoryState(virConnectPtr conn, priv->disableSlirp = true; if (qemuProcessStart(conn, driver, vm, cookie ? cookie->cpu : NULL, - asyncJob, "stdio", *fd, path, snapshot, + asyncJob, migrateFrom, *fd, path, snapshot, VIR_NETDEV_VPORT_PROFILE_OP_RESTORE, start_flags) == 0) *started = true; -- 2.43.0

2 1

[libvirt PATCH v2] scripts/rpcgen: fix 64 unsigned int test on macOS
by Daniel P. Berrangé 30 Nov '23

30 Nov '23

macOS XDR library is an oddball using xdr_u_int64_t instead of xdr_uint64_t which everyone else has. The code generator already does the right thing, but the test program previously generated with the Linux rpcgen program does not compile on macOS due to this. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Changed in v2: - Put compat logic in test_demo.c instead of demo.c, since the latter is liable to be re-generated scripts/rpcgen/tests/test_demo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/rpcgen/tests/test_demo.c b/scripts/rpcgen/tests/test_demo.c index d6be9e236d..94f1002ac8 100644 --- a/scripts/rpcgen/tests/test_demo.c +++ b/scripts/rpcgen/tests/test_demo.c @@ -3,6 +3,10 @@ #include <rpc/xdr.h> #include <stdbool.h> +#ifdef __APPLE__ +# define xdr_uint64_t xdr_u_int64_t +#endif + #include "demo.h" #include "demo.c" -- 2.41.0

3 9

[libvirt PATCH] scripts/rpcgen: fix 64 unsigned int test on macOS
by Daniel P. Berrangé 30 Nov '23

30 Nov '23

macOS XDR library is an oddball using xdr_u_int64_t instead of xdr_uint64_t which everyone else has. The code generator already does the right thing, but the test program previously generated with the Linux rpcgen program does not compile on macOS due to this. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- scripts/rpcgen/tests/demo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/rpcgen/tests/demo.c b/scripts/rpcgen/tests/demo.c index 182ed448f0..56a50239dc 100644 --- a/scripts/rpcgen/tests/demo.c +++ b/scripts/rpcgen/tests/demo.c @@ -1,4 +1,8 @@ +#ifdef __APPLE__ +# define xdr_uint64_t xdr_u_int64_t +#endif + void xdr_TestStruct_clear(TestStruct *objp) { xdr_free((xdrproc_t)xdr_TestStruct, (char *)objp); -- 2.41.0

2 4

[libvirt PATCH] rpcgen: Pass 3 arguments to xdrproc_t calls
by Andrea Bolognani 30 Nov '23

30 Nov '23

The test_demo program currently fails to compile on macOS with too few arguments to function call, expected 3, have 2 ret = !!proc(&xdr, vorig); ~~~~ ^ Way back in 2013, commit 9fa3a8ab6fd8 handled this situation for the main library code. Apply the same fix here. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- scripts/rpcgen/tests/test_demo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/rpcgen/tests/test_demo.c b/scripts/rpcgen/tests/test_demo.c index a48ceccd58..931f25f982 100644 --- a/scripts/rpcgen/tests/test_demo.c +++ b/scripts/rpcgen/tests/test_demo.c @@ -22,7 +22,7 @@ static void test_xdr(xdrproc_t proc, void *vorig, void *vnew, const char *testna /* Step 1: serialize the vorig and compare to the data in test .bin files */ xdrmem_create(&xdr, buf, buflen, XDR_ENCODE); - ret = !!proc(&xdr, vorig); + ret = !!proc(&xdr, vorig, 0); g_assert_cmpint(ret, ==, !fail); if (fail) @@ -49,7 +49,7 @@ static void test_xdr(xdrproc_t proc, void *vorig, void *vnew, const char *testna /* Step 2: de-serialize the state to create a new object */ xdrmem_create(&xdr, buf, buflen, XDR_DECODE); - ret = !!proc(&xdr, vnew); + ret = !!proc(&xdr, vnew, 0); g_assert_cmpint(ret, ==, true); actlen = xdr_getpos(&xdr); @@ -63,7 +63,7 @@ static void test_xdr(xdrproc_t proc, void *vorig, void *vnew, const char *testna xdrmem_create(&xdr, buf, buflen, XDR_ENCODE); - ret = !!proc(&xdr, vnew); + ret = !!proc(&xdr, vnew, 0); g_assert_cmpint(ret, ==, true); actlen = xdr_getpos(&xdr); -- 2.43.0

2 1

[libvirt PATCH 0/5] rpcgen: Fix test coverage
by Andrea Bolognani 30 Nov '23

30 Nov '23

Right now we don't have pytest installed in any of the CI build environments, and tests are only executed when pytest is present, so the test coverage is exactly zero. This series changes things so that we actually run the test suite as part of the CI pipeline, which immediately triggers a build failure on macOS: In file included from ../scripts/rpcgen/tests/test_demo.c:7: ../scripts/rpcgen/tests/demo.c:402:10: error: call to undeclared function 'xdr_uint64_t'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] if (!xdr_uint64_t(xdrs, &objp->suh)) ^ ../scripts/rpcgen/tests/test_demo.c:25:29: error: too few arguments to function call, expected 3, have 2 ret = !!proc(&xdr, vorig); ~~~~ ^ ../scripts/rpcgen/tests/test_demo.c:52:28: error: too few arguments to function call, expected 3, have 2 ret = !!proc(&xdr, vnew); ~~~~ ^ ../scripts/rpcgen/tests/test_demo.c:66:28: error: too few arguments to function call, expected 3, have 2 ret = !!proc(&xdr, vnew); ~~~~ ^ 4 errors generated. I haven't looked into that failure at all, but it looks like something that we might want to fix before 9.10.0 is released? libvirt itself seems to build fine, so perhaps it's just the test suite that needs fixing. I leave the call to people who are more familiar with the rpcgen situation. Andrea Bolognani (5): rpcgen: Don't skip all tests when pytest is missing rpcgen: Organize meson tests into suites rpcgen: Skip tests if tests are disabled rpcgen: Reformat meson files ci: Refresh generated files ci/buildenv/almalinux-8.sh | 1 + ci/buildenv/alpine-317.sh | 1 + ci/buildenv/alpine-edge.sh | 1 + ci/buildenv/centos-stream-8.sh | 1 + ci/buildenv/centos-stream-9.sh | 1 + ci/buildenv/debian-11-cross-aarch64.sh | 1 + ci/buildenv/debian-11-cross-armv6l.sh | 1 + ci/buildenv/debian-11-cross-armv7l.sh | 1 + ci/buildenv/debian-11-cross-i686.sh | 1 + ci/buildenv/debian-11-cross-mips64el.sh | 1 + ci/buildenv/debian-11-cross-mipsel.sh | 1 + ci/buildenv/debian-11-cross-ppc64le.sh | 1 + ci/buildenv/debian-11-cross-s390x.sh | 1 + ci/buildenv/debian-11.sh | 1 + ci/buildenv/debian-12-cross-aarch64.sh | 1 + ci/buildenv/debian-12-cross-armv6l.sh | 1 + ci/buildenv/debian-12-cross-armv7l.sh | 1 + ci/buildenv/debian-12-cross-i686.sh | 1 + ci/buildenv/debian-12-cross-mips64el.sh | 1 + ci/buildenv/debian-12-cross-mipsel.sh | 1 + ci/buildenv/debian-12-cross-ppc64le.sh | 1 + ci/buildenv/debian-12-cross-s390x.sh | 1 + ci/buildenv/debian-12.sh | 1 + ci/buildenv/debian-sid-cross-aarch64.sh | 1 + ci/buildenv/debian-sid-cross-armv6l.sh | 1 + ci/buildenv/debian-sid-cross-armv7l.sh | 1 + ci/buildenv/debian-sid-cross-i686.sh | 1 + ci/buildenv/debian-sid-cross-mips64el.sh | 1 + ci/buildenv/debian-sid-cross-ppc64le.sh | 1 + ci/buildenv/debian-sid-cross-s390x.sh | 1 + ci/buildenv/debian-sid.sh | 1 + ci/buildenv/fedora-37.sh | 1 + ci/buildenv/fedora-38-cross-mingw32.sh | 1 + ci/buildenv/fedora-38-cross-mingw64.sh | 1 + ci/buildenv/fedora-38.sh | 1 + ci/buildenv/fedora-rawhide-cross-mingw32.sh | 1 + ci/buildenv/fedora-rawhide-cross-mingw64.sh | 1 + ci/buildenv/fedora-rawhide.sh | 1 + ci/buildenv/opensuse-leap-15.sh | 1 + ci/buildenv/opensuse-tumbleweed.sh | 1 + ci/buildenv/ubuntu-2004.sh | 1 + ci/buildenv/ubuntu-2204.sh | 1 + ci/cirrus/freebsd-12.vars | 2 +- ci/cirrus/freebsd-13.vars | 2 +- ci/cirrus/macos-13.vars | 2 +- ci/cirrus/macos-14.vars | 2 +- ci/containers/almalinux-8.Dockerfile | 1 + ci/containers/alpine-317.Dockerfile | 1 + ci/containers/alpine-edge.Dockerfile | 1 + ci/containers/centos-stream-8.Dockerfile | 1 + ci/containers/centos-stream-9.Dockerfile | 1 + .../debian-11-cross-aarch64.Dockerfile | 1 + .../debian-11-cross-armv6l.Dockerfile | 1 + .../debian-11-cross-armv7l.Dockerfile | 1 + ci/containers/debian-11-cross-i686.Dockerfile | 1 + .../debian-11-cross-mips64el.Dockerfile | 1 + .../debian-11-cross-mipsel.Dockerfile | 1 + .../debian-11-cross-ppc64le.Dockerfile | 1 + .../debian-11-cross-s390x.Dockerfile | 1 + ci/containers/debian-11.Dockerfile | 1 + .../debian-12-cross-aarch64.Dockerfile | 1 + .../debian-12-cross-armv6l.Dockerfile | 1 + .../debian-12-cross-armv7l.Dockerfile | 1 + ci/containers/debian-12-cross-i686.Dockerfile | 1 + .../debian-12-cross-mips64el.Dockerfile | 1 + .../debian-12-cross-mipsel.Dockerfile | 1 + .../debian-12-cross-ppc64le.Dockerfile | 1 + .../debian-12-cross-s390x.Dockerfile | 1 + ci/containers/debian-12.Dockerfile | 1 + .../debian-sid-cross-aarch64.Dockerfile | 1 + .../debian-sid-cross-armv6l.Dockerfile | 1 + .../debian-sid-cross-armv7l.Dockerfile | 1 + .../debian-sid-cross-i686.Dockerfile | 1 + .../debian-sid-cross-mips64el.Dockerfile | 1 + .../debian-sid-cross-ppc64le.Dockerfile | 1 + .../debian-sid-cross-s390x.Dockerfile | 1 + ci/containers/debian-sid.Dockerfile | 1 + ci/containers/fedora-37.Dockerfile | 1 + .../fedora-38-cross-mingw32.Dockerfile | 1 + .../fedora-38-cross-mingw64.Dockerfile | 1 + ci/containers/fedora-38.Dockerfile | 1 + .../fedora-rawhide-cross-mingw32.Dockerfile | 1 + .../fedora-rawhide-cross-mingw64.Dockerfile | 1 + ci/containers/fedora-rawhide.Dockerfile | 1 + ci/containers/opensuse-leap-15.Dockerfile | 1 + ci/containers/opensuse-tumbleweed.Dockerfile | 1 + ci/containers/ubuntu-2004.Dockerfile | 1 + ci/containers/ubuntu-2204.Dockerfile | 1 + scripts/rpcgen/meson.build | 17 ++++++----- scripts/rpcgen/rpcgen/meson.build | 10 +++---- scripts/rpcgen/tests/meson.build | 29 ++++++++++--------- 91 files changed, 118 insertions(+), 30 deletions(-) -- 2.43.0

3 9

[RFC v2: vf-token 0/7] Introduce vf-token when using userspace PF
by Vivek Kashyap 30 Nov '23

30 Nov '23

vf token is set by a vfio-pci based PF driver and it must be known to the vfio-pci based VF driver. This vf-token is set by the PF driver before VF drivers can access the device. vfio-pci driver and qemu support vf-token. This RFC patch series adds support to provide the vf-token (uuid format) in the domain XML and to generate the qemu commandline including the vf-token. To support vf-token the new element will be used as follows: <hostdev mode='subsystem' type='pci' managed='yes'> <driver name='vfio'/> <source> <address domain='0x0000' bus='0x0' slot='0x00' function='0x1'> <vf-token uuid='00112233-4455-6677-8899-aabbccddeeff'/> </address> </source> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> </hostdev> The generated commandline will include the following: -device {"driver":"vfio-pci","host":"0000:00:0.1", "vf-token":"00112233-4455-6677-8899-aabbccddeeff", "id":"hostdev0","bus":"pci.0","addr":"0x1"} Changes since initial RFC: 1. Added documentation 2. Added test cases and ran test suite - virtsocketest fails when run with 'ninja test' 3. fixed spaces and uuid string format 4. Used S:vftoken in virJSONValueObjectAdd instead of introducing a conditional Vivek Kashyap (7): virpci: Define vf-token qemu: vf-token capability conf: vf-token flag conf: vf-token parsing and formatting conf: test cases qemu: validate & generate command line doc: doc and news NEWS.rst | 8 +++++ docs/formatdomain.rst | 4 +++ src/conf/device_conf.c | 32 +++++++++++++++-- src/conf/device_conf.h | 3 ++ src/conf/domain_addr.h | 1 + src/conf/domain_conf.c | 8 +++++ src/conf/schemas/basictypes.rng | 7 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 3 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 +++++++ src/qemu/qemu_domain_address.c | 3 ++ src/qemu/qemu_validate.c | 20 +++++++++++ src/util/virpci.c | 7 ++++ src/util/virpci.h | 12 +++++++ .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + .../caps_8.2.0_x86_64.xml | 1 + .../hostdev-vfio-vf-token.x86_64-latest.args | 34 +++++++++++++++++++ .../hostdev-vfio-vf-token.xml | 22 ++++++++++++ tests/qemuxml2argvtest.c | 1 + 21 files changed, 181 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-vf-token.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/hostdev-vfio-vf-token.xml -- 2.25.1

2 14

[PATCH 0/4] Support for dirty-limit live migration
by Hyman Huang 30 Nov '23

30 Nov '23

The dirty-limit functionality for live migration was introduced since qemu>=8.1. In the live migration scenario, it implements the force convergence using the dirty-limit approach, which results in better reliable read performance. A straightforward dirty-limit capability for live migration is added by this patchset. Users might not care about other dirty-limit arguments like "x-vcpu-dirty-limit-period" or "vcpu-dirty-limit," thus do not expose them to Libvirt and Keep the default configurations and values in place. For more details about dirty-limit, please see the following reference: https://lore.kernel.org/qemu- devel/169024923116.19090.10825599068950039132-0(a)git.sr.ht/ Hyman Huang (4): Add VIR_MIGRATE_DIRTY_LIMIT flag qemu_migration: Implement VIR_MIGRATE_DIRTY_LIMIT flag virsh: Add support for VIR_MIGRATE_DIRTY_LIMIT flag NEWS: document support for dirty-limit live migration NEWS.rst | 8 ++++++++ docs/manpages/virsh.rst | 10 +++++++++- include/libvirt/libvirt-domain.h | 5 +++++ src/libvirt-domain.c | 8 ++++++++ src/qemu/qemu_migration.c | 8 ++++++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 6 ++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 10 ++++++++++ 9 files changed, 56 insertions(+), 1 deletion(-) -- 2.39.1

1 4

Entering freeze for libvirt-9.10.0
by Jiri Denemark 29 Nov '23

29 Nov '23

I have just tagged v9.10.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH 0/2] rpcgen: tests: Improve on funky platforms
by Michal Privoznik 29 Nov '23

29 Nov '23

At least the second patch should be merged before the release so that Jirka can do the release cleanly. Michal Prívozník (2): rpcgen: tests: Allow running test_demo from anywhere rpcgen: tests: Run cleanly on platforms where char is unsigned scripts/rpcgen/tests/meson.build | 4 +++- scripts/rpcgen/tests/test_demo.c | 4 ++-- .../tests/test_demo_struct_fixed_array.bin | Bin 136 -> 136 bytes .../tests/test_demo_struct_pointer_set.bin | Bin 12 -> 12 bytes .../rpcgen/tests/test_demo_struct_scalar.bin | Bin 8 -> 8 bytes .../test_demo_struct_variable_array_set.bin | Bin 28 -> 28 bytes .../tests/test_demo_test_struct_all_types.bin | Bin 1752 -> 1752 bytes 7 files changed, 5 insertions(+), 3 deletions(-) -- 2.41.0

3 5

[PATCH V5] support for hotplug/hotunplug in test hypervisor
by Thanos Makatos 29 Nov '23

29 Nov '23

Signed-off-by: Thanos Makatos <thanos.makatos(a)nutanix.com> --- Changed since v4: * removed inadvertent calls to functions virNWFilterReadLockFilterUpdates/virNWFilterUnlockFilterUpdates (original patch was based on v8.0.0) --- src/test/test_driver.c | 382 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 380 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e87d7cfd44..effb7f9880 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -26,8 +26,6 @@ #include <unistd.h> #include <sys/stat.h> #include <libxml/xmlsave.h> - - #include "virerror.h" #include "datatypes.h" #include "test_driver.h" @@ -38,9 +36,12 @@ #include "virnetworkobj.h" #include "interface_conf.h" #include "checkpoint_conf.h" +#include "domain_addr.h" +#include "domain_audit.h" #include "domain_conf.h" #include "domain_driver.h" #include "domain_event.h" +#include "domain_validate.h" #include "network_event.h" #include "snapshot_conf.h" #include "virfdstream.h" @@ -50,6 +51,7 @@ #include "node_device_conf.h" #include "virnodedeviceobj.h" #include "node_device_event.h" +#include "vircgroup.h" #include "virxml.h" #include "virthread.h" #include "virlog.h" @@ -10035,6 +10037,379 @@ testConnectGetDomainCapabilities(virConnectPtr conn G_GNUC_UNUSED, return virDomainCapsFormat(domCaps); } +static int +testDomainAttachHostPCIDevice(testDriver *driver G_GNUC_UNUSED, + virDomainObj *vm, + virDomainHostdevDef *hostdev) +{ + int backend = hostdev->source.subsys.u.pci.backend; + + switch ((virDomainHostdevSubsysPCIBackendType)backend) { + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM: + break; + + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_TYPE_LAST: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("test hypervisor does not support device assignment mode '%s'"), + virDomainHostdevSubsysPCIBackendTypeToString(backend)); + return -1; + } + + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("guest unexpectedly quit during hotplug")); + return -1; + } + + VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs + 1); + + virDomainAuditHostdev(vm, hostdev, "attach", true); + + vm->def->hostdevs[vm->def->nhostdevs++] = hostdev; + + return 0; +} + +static int +testDomainAttachHostDevice(testDriver *driver, + virDomainObj *vm, + virDomainHostdevDef *hostdev) +{ + if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("hotplug is not supported for hostdev mode '%s'"), + virDomainHostdevModeTypeToString(hostdev->mode)); + return -1; + } + + if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("hotplug is not supported for hostdev subsys type '%s'"), + virDomainHostdevSubsysTypeToString(hostdev->source.subsys.type)); + return -1; + } + + return testDomainAttachHostPCIDevice(driver, vm, hostdev); +} + +static int +testDomainAttachDeviceLive(virDomainObj *vm, + virDomainDeviceDef *dev, + testDriver *driver) +{ + int ret = -1; + const char *alias = NULL; + + if ((virDomainDeviceType)dev->type != VIR_DOMAIN_DEVICE_HOSTDEV) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("live attach of device '%s' is not supported"), + virDomainDeviceTypeToString(dev->type)); + return -1; + } + + testDomainObjCheckHostdevTaint(vm, dev->data.hostdev); + if ((ret = testDomainAttachHostDevice(driver, vm, dev->data.hostdev)) != 0) + return ret; + + alias = dev->data.hostdev->info->alias; + dev->data.hostdev = NULL; + + if (alias) { + virObjectEvent *event; + event = virDomainEventDeviceAddedNewFromObj(vm, alias); + virObjectEventStateQueue(driver->eventState, event); + } + + return 0; +} + +static int +testDomainAttachDeviceLiveAndConfig(virDomainObj *vm, + testDriver *driver, + const char *xml, + unsigned int flags) +{ + g_autoptr(virDomainDeviceDef) devConf = NULL; + g_autoptr(virDomainDeviceDef) devLive = NULL; + unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | + VIR_DOMAIN_DEF_PARSE_ABI_UPDATE; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE, -1); + + if (flags & VIR_DOMAIN_AFFECT_LIVE) { + if (!(devLive = virDomainDeviceDefParse(xml, vm->def, + driver->xmlopt, NULL, + parse_flags))) + return -1; + + if (virDomainDeviceValidateAliasForHotplug(vm, devLive, + VIR_DOMAIN_AFFECT_LIVE) < 0) + return -1; + + if (virDomainDefCompatibleDevice(vm->def, devLive, NULL, + VIR_DOMAIN_DEVICE_ACTION_ATTACH, + true) < 0) + return -1; + + if (testDomainAttachDeviceLive(vm, devLive, driver) < 0) + return -1; + } + + return 0; +} + +static int +testDomainAttachDeviceFlags(virDomainPtr domain, + const char *xml, + unsigned int flags) { + + testDriver *driver = domain->conn->privateData; + virDomainObj *vm = NULL; + int ret = -1; + + if (!(vm = testDomObjFromDomain(domain))) + return -1; + + if (virDomainObjUpdateModificationImpact(vm, &flags) < 0) + goto cleanup; + + if (testDomainAttachDeviceLiveAndConfig(vm, driver, xml, flags) < 0) + goto cleanup; + + ret = 0; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + +static int +testDomainAttachDevice(virDomainPtr domain, const char *xml) +{ + return testDomainAttachDeviceFlags(domain, xml, 0); +} + +/* search for a hostdev matching dev and detach it */ +static int +testDomainDetachPrepHostdev(virDomainObj *vm, + virDomainHostdevDef *match, + virDomainHostdevDef **detach) +{ + virDomainHostdevSubsys *subsys = &match->source.subsys; + virDomainHostdevSubsysPCI *pcisrc = &subsys->u.pci; + virDomainHostdevDef *hostdev = NULL; + + if (match->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("hot unplug is not supported for hostdev mode '%s'"), + virDomainHostdevModeTypeToString(match->mode)); + return -1; + } + + if (virDomainHostdevFind(vm->def, match, &hostdev) < 0) { + if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { + virReportError(VIR_ERR_DEVICE_MISSING, + _("host pci device " VIR_PCI_DEVICE_ADDRESS_FMT + " not found"), + pcisrc->addr.domain, pcisrc->addr.bus, + pcisrc->addr.slot, pcisrc->addr.function); + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("unexpected hostdev type %d"), subsys->type); + } + return -1; + } + + *detach = hostdev; + + return 0; +} + +static int +testDomainRemoveHostDevice(testDriver *driver G_GNUC_UNUSED, + virDomainObj *vm, + virDomainHostdevDef *hostdev) +{ + virDomainNetDef *net = NULL; + size_t i; + + VIR_DEBUG("Removing host device %s from domain %p %s", + hostdev->info->alias, vm, vm->def->name); + + if (hostdev->parentnet) { + net = hostdev->parentnet; + for (i = 0; i < vm->def->nnets; i++) { + if (vm->def->nets[i] == hostdev->parentnet) { + virDomainNetRemove(vm->def, i); + break; + } + } + } + + for (i = 0; i < vm->def->nhostdevs; i++) { + if (vm->def->hostdevs[i] == hostdev) { + virDomainHostdevRemove(vm->def, i); + break; + } + } + + virDomainAuditHostdev(vm, hostdev, "detach", true); + + virDomainHostdevDefFree(hostdev); + + if (net) { + if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) { + g_autoptr(virConnect) conn = virGetConnectNetwork(); + if (conn) + virDomainNetReleaseActualDevice(conn, vm->def, net); + else + VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); + } + virDomainNetDefFree(net); + } + + return 0; +} + +static int +testDomainRemoveDevice(testDriver *driver, + virDomainObj *vm, + virDomainDeviceDef *dev) +{ + virDomainDeviceInfo *info; + virObjectEvent *event; + g_autofree char *alias = NULL; + + /* + * save the alias to use when sending a DEVICE_REMOVED event after + * all other teardown is complete + */ + if ((info = virDomainDeviceGetInfo(dev))) + alias = g_strdup(info->alias); + info = NULL; + + if ((virDomainDeviceType)dev->type != VIR_DOMAIN_DEVICE_HOSTDEV) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("don't know how to remove a %s device"), + virDomainDeviceTypeToString(dev->type)); + goto out; + } + + if (testDomainRemoveHostDevice(driver, vm, dev->data.hostdev) < 0) + return -1; + +out: + event = virDomainEventDeviceRemovedNewFromObj(vm, alias); + virObjectEventStateQueue(driver->eventState, event); + + return 0; +} + +static int +testDomainDetachDeviceLive(virDomainObj *vm, + virDomainDeviceDef *match, + testDriver *driver) +{ + virDomainDeviceDef detach = { .type = match->type }; + virDomainDeviceInfo *info = NULL; + + if ((virDomainDeviceType)match->type != VIR_DOMAIN_DEVICE_HOSTDEV) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("live detach of device '%s' is not supported"), + virDomainDeviceTypeToString(match->type)); + return -1; + } + + if (testDomainDetachPrepHostdev(vm, match->data.hostdev, + &detach.data.hostdev) < 0) + return -1; + + /* "detach" now points to the actual device we want to detach */ + + if (!(info = virDomainDeviceGetInfo(&detach))) { + /* + * This should never happen, since all of the device types in + * the switch cases that end with a "break" instead of a + * return have a virDeviceInfo in them. + */ + virReportError(VIR_ERR_INTERNAL_ERROR, + _("device of type '%s' has no device info"), + virDomainDeviceTypeToString(detach.type)); + return -1; + } + + /* Make generic validation checks common to all device types */ + + if (!info->alias) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Cannot detach %s device with no alias"), + virDomainDeviceTypeToString(detach.type)); + return -1; + } + + return testDomainRemoveDevice(driver, vm, &detach); +} + +static int +testDomainDetachDeviceAliasLiveAndConfig(testDriver *driver, + virDomainObj *vm, + const char *alias, + unsigned int flags) +{ + virDomainDef *def = NULL; + g_autoptr(virDomainDef) vmdef = NULL; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE, -1); + + if (virDomainObjGetDefs(vm, flags, &def, NULL) < 0) + return -1; + + if (def) { + virDomainDeviceDef dev; + + if (virDomainDefFindDevice(def, alias, &dev, true) < 0) + return -1; + + if (testDomainDetachDeviceLive(vm, &dev, driver) < 0) + return -1; + } + + if (vmdef) { + if (virDomainDefSave(vmdef, driver->xmlopt, NULL) < 0) + return -1; + virDomainObjAssignDef(vm, &vmdef, false, NULL); + } + + return 0; +} + +static int +testDomainDetachDeviceAlias(virDomainPtr dom, + const char *alias, + unsigned int flags) +{ + testDriver *driver = dom->conn->privateData; + virDomainObj *vm = NULL; + int ret = -1; + + if (!(vm = testDomObjFromDomain(dom))) + return -1; + + if (virDomainObjUpdateModificationImpact(vm, &flags) < 0) + goto cleanup; + + if (testDomainDetachDeviceAliasLiveAndConfig(driver, vm, alias, flags) < 0) + goto cleanup; + + ret = 0; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} /* * Test driver @@ -10058,6 +10433,9 @@ static virHypervisorDriver testHypervisorDriver = { .connectListDomains = testConnectListDomains, /* 0.1.1 */ .connectNumOfDomains = testConnectNumOfDomains, /* 0.1.1 */ .connectListAllDomains = testConnectListAllDomains, /* 0.9.13 */ + .domainAttachDevice = testDomainAttachDevice, /* 9.10.0 */ + .domainAttachDeviceFlags = testDomainAttachDeviceFlags, /* 9.10.0 */ + .domainDetachDeviceAlias = testDomainDetachDeviceAlias, /* 9.10.0 */ .domainCreateXML = testDomainCreateXML, /* 0.1.4 */ .domainCreateXMLWithFiles = testDomainCreateXMLWithFiles, /* 5.7.0 */ .domainLookupByID = testDomainLookupByID, /* 0.1.1 */ -- 2.27.0

2 3

[PATCH] qemu_driver: Don't handle the EOF event if monitor changed
by Guoyi Tu 29 Nov '23

29 Nov '23

Currently, libvirt creates a thread pool with only on thread to handle all qemu monitor events for virtual machines, In the cases that if the thread gets stuck while handling a monitor EOF event, such as unable to kill the virtual machine process or release resources, the events of other virtual machine will be also blocked, which will lead to the abnormal behavior of other virtual machines. For instance, when another virtual machine completes a shutdown operation and the monitor EOF event has been queued but remains unprocessed, we immediately destroy and start the virtual machine again, at a later time when EOF event get processed, the processMonitorEOFEvent() will kill the virtual machine that just started. To address this issue, in the processMonitorEOFEvent(), we check whether the current virtual machine's monitor object matches the one at the time the event was generated. If they do not match, we immediately return. Signed-off-by: Guoyi Tu <tugy(a)chinatelecom.cn> Signed-off-by: dengpengcheng <dengpc12(a)chinatelecom.cn> --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_driver.c | 11 +++++++++-- src/qemu/qemu_process.c | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ae19ce884b..bc80afdfac 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11500,7 +11500,6 @@ qemuProcessEventFree(struct qemuProcessEvent *event) case QEMU_PROCESS_EVENT_NETDEV_STREAM_DISCONNECTED: case QEMU_PROCESS_EVENT_NIC_RX_FILTER_CHANGED: case QEMU_PROCESS_EVENT_SERIAL_CHANGED: - case QEMU_PROCESS_EVENT_MONITOR_EOF: case QEMU_PROCESS_EVENT_GUEST_CRASHLOADED: g_free(event->data); break; @@ -11514,6 +11513,7 @@ qemuProcessEventFree(struct qemuProcessEvent *event) case QEMU_PROCESS_EVENT_UNATTENDED_MIGRATION: case QEMU_PROCESS_EVENT_RESET: case QEMU_PROCESS_EVENT_NBDKIT_EXITED: + case QEMU_PROCESS_EVENT_MONITOR_EOF: case QEMU_PROCESS_EVENT_LAST: break; } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d00d2a27c6..57acafb48b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3854,7 +3854,8 @@ processJobStatusChangeEvent(virDomainObj *vm, static void processMonitorEOFEvent(virQEMUDriver *driver, - virDomainObj *vm) + virDomainObj *vm, + qemuMonitor *mon) { qemuDomainObjPrivate *priv = vm->privateData; int eventReason = VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN; @@ -3863,6 +3864,12 @@ processMonitorEOFEvent(virQEMUDriver *driver, unsigned int stopFlags = 0; virObjectEvent *event = NULL; + if (priv->mon != mon) { + VIR_DEBUG("Domain %p '%s' has been shutdown, ignoring EOF", + vm, vm->def->name); + return; + } + if (qemuProcessBeginStopJob(vm, VIR_JOB_DESTROY, true) < 0) return; @@ -4082,7 +4089,7 @@ static void qemuProcessEventHandler(void *data, void *opaque) processJobStatusChangeEvent(vm, processEvent->data); break; case QEMU_PROCESS_EVENT_MONITOR_EOF: - processMonitorEOFEvent(driver, vm); + processMonitorEOFEvent(driver, vm, processEvent->data); break; case QEMU_PROCESS_EVENT_PR_DISCONNECT: processPRDisconnectEvent(vm); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index b9267d8699..4de6e5c234 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -316,7 +316,7 @@ qemuProcessHandleMonitorEOF(qemuMonitor *mon, } qemuProcessEventSubmit(vm, QEMU_PROCESS_EVENT_MONITOR_EOF, - 0, 0, NULL); + 0, 0, priv->mon); /* We don't want this EOF handler to be called over and over while the * thread is waiting for a job. -- 2.17.1

2 2

[libvirt PATCH] rpm: Drop rpcgen Build-Requires once again
by Andrea Bolognani 28 Nov '23

28 Nov '23

We no longer use it, so commit a62486b95fee correctly dropped the Build-Requires; shortly afterwards, however, I accidentally re-introduced it by mistake. Fixes: 3df8cc658ed0ac2f84089ad0db61ba20eb8b8aa7 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 361a34675b..f3fdedfde4 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -313,7 +313,6 @@ BuildRequires: libxml2 BuildRequires: libxslt BuildRequires: gettext BuildRequires: systemd-rpm-macros -BuildRequires: rpcgen # Fedora build root suckage BuildRequires: gawk %if %{with_native} -- 2.43.0

2 1

[PATCH 0/4] A bunch of trivial fixes
by Michal Privoznik 28 Nov '23

28 Nov '23

*** BLURB HERE *** Michal Prívozník (4): virpci: Decrease scope of VIR_PF_PHYS_PORT_NAME_REGEX macro qemu_command: Don't open code virPCIDeviceAddressAsString() vircpi: Decrease scope of VIR_PCI_DEVICE_ADDRESS_FMT macro ch: Don't leak ch_driver->chCaps src/ch/ch_driver.c | 5 +++-- src/qemu/qemu_command.c | 6 +----- src/util/virpci.c | 9 +++++++++ src/util/virpci.h | 7 ------- 4 files changed, 13 insertions(+), 14 deletions(-) -- 2.41.0

5 10

[Call for Presentations] FOSDEM 2024: Virt & IaaS Devroom
by Kashyap Chamarthy 28 Nov '23

28 Nov '23

[Cross-posted to KVM, Rust-VMM, QEMU, and libvirt lists) Hi, the CFP for the "Virt & IaaS" DevRoom is out[+]. Something new this year is a new talk-submission system: so you need to create a new account, even if you've had an account with the older talk-submission system. Details in the "Submit Your Proposal" section below. ======================================================================== We are excited to announce that the call for proposals is now open for the Virtualization and Cloud infrastructure devroom at the upcoming FOSDEM 2024, to be hosted on February 3rd 2024. This devroom is a collaborative effort, and is organized by dedicated folks from projects such as OpenStack, Xen Project, KubeVirt, QEMU, KVM, and Foreman. We would like to invite all those who are involved in these fields to submit your proposals by December 8th, 2023. Important Dates --------------- Submission deadline: 8th December 2023 Acceptance notifications: 10th December 2023 Final schedule announcement: 15th December 2023 Devroom: 3rd February 2024 About the Devroom ----------------- The Virtualization & IaaS devroom will feature session topics such as open source hypervisors or virtual machine managers such as Xen Project, KVM, bhyve and VirtualBox as well as Infrastructure-as-a-Service projects such as KubeVirt, Apache CloudStack, OpenStack, QEMU and OpenNebula. This devroom will host presentations that focus on topics of shared interest, such as KVM; libvirt; shared storage; virtualized networking; cloud security; clustering and high availability; interfacing with multiple hypervisors; hyperconverged deployments; and scaling across hundreds or thousands of servers. Presentations in this devroom will be aimed at developers working on these platforms who are looking to collaborate and improve shared infrastructure or solve common problems. We seek topics that encourage dialog between projects and continued work post-FOSDEM. Submit Your Proposal -------------------- All submissions must be made via the Pretalx event planning site[1]. It is a new submission system so you will need to create an account. If you submitted proposals for FOSDEM in previous years, you won’t be able to use your existing account. During submission please make sure to select Virtualization and Cloud infrastructure from the Track list. Please fill out all the required fields, and provide a meaningful abstract and description of your proposed session. Submission Guidelines --------------------- We expect more proposals than we can possibly accept, so it is vitally important that you submit your proposal on or before the deadline. Late submissions are unlikely to be considered. All presentation slots are 30 minutes, with 20 minutes planned for presentations, and 10 minutes for Q&A. All presentations will be recorded and made available under Creative Commons licenses. In the Submission notes field, please indicate that you agree that your presentation will be licensed under the CC-By-SA-4.0 or CC-By-4.0 license and that you agree to have your presentation recorded. For example: "If my presentation is accepted for FOSDEM, I hereby agree to license all recordings, slides, and other associated materials under the Creative Commons Attribution Share-Alike 4.0 International License. Sincerely, <NAME>." In the Submission notes field, please also confirm that if your talk is accepted, you will be able to attend FOSDEM and deliver your presentation. We will not consider proposals from prospective speakers who are unsure whether they will be able to secure funds for travel and lodging to attend FOSDEM. (Sadly, we are not able to offer travel funding for prospective speakers.) Code of Conduct --------------- Following the release of the updated code of conduct for FOSDEM, we'd like to remind all speakers and attendees that all of the presentations and discussions in our devroom are held under the guidelines set in the CoC and we expect attendees, speakers, and volunteers to follow the CoC at all times. If you submit a proposal and it is accepted, you will be required to confirm that you accept the FOSDEM CoC. If you have any questions about the CoC or wish to have one of the devroom organizers review your presentation slides or any other content for CoC compliance, please email us and we will do our best to assist you. Questions? ---------- If you have any questions about this devroom, please send your questions to our devroom mailing list[2]. You can also subscribe to the list to receive updates about important dates, session announcements, and to connect with other attendees. See you all at FOSDEM! [1] https://pretalx.fosdem.org/fosdem-2024/cfp [2] virtualization-devroom-manager at fosdem.org ======================================================================= [+] This email is a slightly formatted version of the official announce: https://lists.fosdem.org/pipermail/fosdem/2023q4/003481.html -- /kashyap

1 0

Re: [libvirt RFCv11 00/33] multifd save restore prototype
by Claudio Fontana 27 Nov '23

27 Nov '23

On 11/27/23 11:18, Daniel P. Berrangé wrote: > On Mon, Nov 27, 2023 at 10:43:58AM +0100, Claudio Fontana wrote: >> Hi all, >> >> I understand there has been some movement in this topic as the fixed-offset ram and multifd code evolves. >> >> I think I understood that now the idea is to pass from libvirt to QEMU two file descriptors, >> one for writing metadata, >> and a separate one for the actual memory pages, which is the one that can potentially be O_DIRECT. > > We determined that O_DIRECT changes propagate across dup'd file > descriptors, so we have only two choices > > * 1 FD, and QEMU has to take care to toggle O_DIRECT on/off > repeatedly depending on what phase it is in > * 2 FDs, one with and one without O_DIRECT > > Either is viable for libvirt. I have a mild preference for having > 1 FD, but not enough to call it a design blocker. So at the > discretion of whomever implements the QEMU part. > >> 1) I would assume that libvirt would then need to check if the user requested --parallel / --parallel-connections to enable QEMU multifd. > > Yes > >> 2) I would also assume that libvirt would check the presence of --bypass-cache as the condition to set O_DIRECT on the second (memory pages fd), and to enable QEMU "io-direct" feature. > > Yes > >> 3) I would tentatively suggest that when it comes to fixed-ram-offset, the condition to enable that one is a check like the one currently in libvirt: >> >> src/util/virfile.c::virFileDiskCopy() >> >> ie checking that we are writing to a seekable file that is not S_ISBLK . >> >> Does this match your understanding/reasoning? > > Both the io-direct and fixed-ram-offset features are dependent on > new QEMU impls, so there is a mild backwards compatibility concern. > > ie, lets say if we are running QEMU 9.0.0, but with old machine > type pc-i440fx-8.0.0, and we save the state, but want to then > restore with QEMU 8.2.0. > > Essentially we must NOT use io-direct/fixed-ram-offset if we > want the ability to migrate to older QEMU. At the same time I > would like us to be able to take advantage of this new QEMU > support to the greatest extent possible, even if not doing the > --parallel stuff which was the original motivator. > > Thus, we need some way to decide whether to use the new or the > old on disk format. > > I wonder if having a setting in '/etc/libvirt/qemu.conf' is > sufficient, or whether we must expose a flag via the API. > > With regards, > Daniel Thanks Daniel, that's an interesting point. The new fixed-ram-offset format is a QEMU format, and as such I presume that in theory there is a qemu_saveimage.h:#define QEMU_SAVE_VERSION 2 that could be bumped to 3 if this new format is used? But then again, libvirt would need to decide whether to save in "old QEMU compatibility mode" or in the new QEMU_SAVE_VERSION 3 mode that allows for fixed-ram-offset. Maybe a new libvirt option for controlling which QEMU_SAVE_VERSION format to use for the save, with the default being v2 for backward compatibility reasons? Thanks, Claudio

2 2

Re: [kubevirt-dev] ANNOUNCE: Virtualization linting library
by Michal Prívozník 27 Nov '23

27 Nov '23

[Following move of libvir-list to new location] On 11/15/23 09:26, Dan Kenigsberg wrote: > Thanks, Michal, for this overture. I think libvirt and its people have a > lot of knowledge about working-yet-not-recommended configurations that > can be beneficial to higher-level management systems such as KubeVirt. Indeed. But writing checks for such configurations should be trivial enough, now that they can be written in Lua. But individual checks are technicality, those can and will be extended once we know current (API) design works for KubeVirt. > > How do you envisage it to be used by KubeVirt? > > Do you think virt-launcher can call it before it is calling > virCreateXML()? If so, would it make sense to bubble up its warnings as > VM.status conditions? Yes, that's my idea. Once KubeVirt constructed domain XML, it can feed it to virt-lint tool. From that it'll receive bunch of warnings (or none if domain XML is okay) which could be then forwarded to the UI for users to resolve. Or ignore and continue starting up the guest (for instance, one of currently implemented checks is for enough of free PCIe root ports for future hotplug - it's up to user to tell if they will ever want hotplug). > > BTW, I think it may be valuable to add a machine-accessible code for > each warning, on top of the English language text. Good point. That way we can save user's preference on ignoring some warnings. Or have KubeVirt fix some of the warnings automagically. Anyway, my knowledge of KubeVirt internals is not intimate enough to even attempt to integrate this. If anybody from KubeVirt developers is willing to offer a helping hand, I'd appreciate it. Michal

1 0

[PATCH v2 0/3] Introduce pipewire audio backend
by Michal Privoznik 24 Nov '23

24 Nov '23

v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/4M7O… diff to v1: - Introduced 'runtimeDir' attribute to <audio/> so that users do not have use <qemu:env/> hack to set PIPEWIRE_RUNTIME_DIR. - Worked in the rest of Peter's review suggestions. Michal Prívozník (3): conf: Introduce pipewire audio backend qemu: Generate cmd line for pipewire audio backend NEWS: Document pipewire audio backend NEWS.rst | 5 ++ docs/formatdomain.rst | 46 +++++++++++- src/conf/domain_conf.c | 73 +++++++++++++++++++ src/conf/domain_conf.h | 13 ++++ src/conf/schemas/domaincommon.rng | 42 +++++++++++ src/qemu/qemu_command.c | 71 ++++++++++++++++++ src/qemu/qemu_validate.c | 1 + .../audio-many-backends.x86_64-latest.args | 2 + .../qemuxml2argvdata/audio-many-backends.xml | 1 + .../audio-pipewire-best.x86_64-latest.args | 36 +++++++++ .../qemuxml2argvdata/audio-pipewire-best.xml | 43 +++++++++++ .../audio-pipewire-full.x86_64-latest.args | 36 +++++++++ .../qemuxml2argvdata/audio-pipewire-full.xml | 43 +++++++++++ .../audio-pipewire-minimal.x86_64-latest.args | 36 +++++++++ .../audio-pipewire-minimal.xml | 36 +++++++++ tests/qemuxml2argvtest.c | 10 +++ .../audio-many-backends.x86_64-latest.xml | 1 + .../audio-pipewire-best.x86_64-latest.xml | 46 ++++++++++++ .../audio-pipewire-full.x86_64-latest.xml | 46 ++++++++++++ .../audio-pipewire-minimal.x86_64-latest.xml | 39 ++++++++++ tests/qemuxml2xmltest.c | 3 + 21 files changed, 627 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/audio-pipewire-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-best.xml create mode 100644 tests/qemuxml2argvdata/audio-pipewire-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-full.xml create mode 100644 tests/qemuxml2argvdata/audio-pipewire-minimal.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-best.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-full.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-minimal.x86_64-latest.xml -- 2.41.0

2 5

[PATCH 00/17] qemu: Prepare block device setup for removing the 'raw' driver ('raw' driver removal part 3)
by Peter Krempa 24 Nov '23

24 Nov '23

This series prepares the setup of the block device backend for removal of the raw driver from the block graph, and actually removes it from the migration NBD connection. Unfortunately for normal usage it's not yet possible as qemu then records the protocol driver name in the backing file format field which would break with older versions of libvirt (see my other series). Peter Krempa (17): qemu: block: Introduce qemuBlockStorageSourceGetSliceNodename qemu: block: Use qemuBlockStorageSourceNeedsStorageSliceLayer only for setup qemu: block: Introduce helper for deciding when a 'format' layer is needed qemuBlockStorageSourceGetBlockdevStorageSliceProps: Allow turning the slice layer into effective blockdev layer qemuBlockStorageSourceAttachPrepareBlockdev: Prepare for optionally missing format layer qemuBlockStorageSourceDetachPrepare: Prepare for possibly missing 'format' layer qemuDomainPrepareStorageSourceBlockdevNodename: Restructure code to allow missing 'format' layer qemuBlockStorageSourceGetEffectiveNodename: Prepare for missing 'format' driver qemu: block: Extract logic from qemuBlockReopenReadWrite/ReadOnly qemu: block: Absorb logic from qemuBlockReopenFormat to qemuBlockReopenAccess qemu: monitor: Sanitize arguments of qemuMonitorBlockdevReopen testQemuMonitorJSONBlockdevReopen: Don't use qemuBlockReopenFormatMon qemu: block: Absorb qemuBlockReopenFormatMon into qemuBlockReopenAccess qemuBlockReopenAccess: prepare for removal of 'raw' format layer qemuMigrationSrcNBDCopyCancel: Use qemuBlockStorageSourceAttachRollback to detach migration NBD blockdevs qemu: block: Remove unused qemuBlockStorageSourceDetachOneBlockdev qemuMigrationSrcNBDStorageCopyBlockdevPrepareSource: Don't setup 'raw' layer for migration NBD connection src/qemu/qemu_block.c | 257 ++++++++++++++++++----------------- src/qemu/qemu_block.h | 16 +-- src/qemu/qemu_domain.c | 17 ++- src/qemu/qemu_migration.c | 19 ++- src/qemu/qemu_monitor.c | 7 +- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 6 +- src/qemu/qemu_monitor_json.h | 2 +- tests/qemumonitorjsontest.c | 10 +- 9 files changed, 185 insertions(+), 151 deletions(-) -- 2.42.0

2 21

[PATCH 0/7] storage_file_probe: Handle qcow2 images with 'protocol' driver name in 'backing file format' field (part 1 - the fix)
by Peter Krempa 24 Nov '23

24 Nov '23

See 6/7 and 7/7 for the rationale. Further patches will be posted to refactor the rest of the parsers which are bitrotten. Peter Krempa (7): storage_file_probe: Remove unused state 'BACKING_STORE_ERROR' virStorageFileProbeGetMetadata: Do not partially skip probing of the image storage_file_probe: Remove BACKING_STORE_OK,BACKING_STORE_INVALID states virstoragetest: Use strings for storage type and format in output data virstoragetest: Format detected/unprocessed backing store format into output files virstoragetest: Add test cases for QCOW2 files with a protocol name as backing file format storage_file_probe: Treat qcow2 images with protocol drivers in backing store field as raw src/storage_file/storage_file_probe.c | 71 ++++++++---------- tests/virstoragetest.c | 19 ++++- .../images/qcow2-protocol-backing-file.qcow2 | Bin 0 -> 196616 bytes .../images/qcow2-protocol-backing-nbd.qcow2 | Bin 0 -> 196616 bytes tests/virstoragetestdata/out/directory-dir | 5 +- tests/virstoragetestdata/out/directory-none | 5 +- tests/virstoragetestdata/out/directory-raw | 5 +- .../out/qcow2-auto_qcow2-qcow2_raw-raw | 5 +- .../out/qcow2-auto_raw-raw-relative | 5 +- .../out/qcow2-protocol-backing-file | 21 ++++++ .../out/qcow2-protocol-backing-nbd | 21 ++++++ .../out/qcow2-qcow2_nbd-raw | 10 ++- .../out/qcow2-qcow2_qcow2-auto | 10 ++- .../out/qcow2-qcow2_qcow2-qcow2_qcow2-auto | 15 ++-- .../out/qcow2-qcow2_qcow2-qcow2_raw-auto | 15 ++-- .../out/qcow2-qcow2_qcow2-qcow2_raw-raw | 15 ++-- .../out/qcow2-qcow2_raw-raw-relative | 10 ++- tests/virstoragetestdata/out/qcow2-symlinks | 15 ++-- tests/virstoragetestdata/out/qed-auto_raw | 5 +- tests/virstoragetestdata/out/qed-qed_raw | 10 ++- tests/virstoragetestdata/out/raw-auto | 5 +- tests/virstoragetestdata/out/raw-raw | 5 +- 22 files changed, 173 insertions(+), 99 deletions(-) create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-file.qcow2 create mode 100644 tests/virstoragetestdata/images/qcow2-protocol-backing-nbd.qcow2 create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-file create mode 100644 tests/virstoragetestdata/out/qcow2-protocol-backing-nbd -- 2.42.0

2 9

[PATCH 0/2] qemu: block fixes
by Peter Krempa 24 Nov '23

24 Nov '23

Few issues I've found while testing the block layer for an upcoming patchset. Peter Krempa (2): qemu: hotplug: Detect disk backing images before setting up security access qemu: block: Don't try to merge bitmaps into 'raw' images src/qemu/qemu_block.c | 10 ++++++++++ src/qemu/qemu_hotplug.c | 10 +++++----- 2 files changed, 15 insertions(+), 5 deletions(-) -- 2.42.0

2 4

[PATCH] virnuma: Avoid integer overflow in virNumaGetPages()
by Michal Privoznik 24 Nov '23

24 Nov '23

On systems with humongous pages (16GiB) and 32bit int it's easy to hit integer overflow in virNumaGetPages(). What happens is, inside of virNumaGetPages() as we process hugepages for given NUMA node (e.g. in order to produce capabilities XML), we keep a sum of sizes of pools in an ULL variable (huge_page_sum). In each iteration, the variable is incremented by 1024 * page_size * page_avail. Now, page_size is just an uint, so we have: ULL += U * U * ULL; and because of associativity, U * U is computed first and since we have two operands of the same type, no type expansion happens. But this means, for humongous pages (like 16GiB) the multiplication overflows. Therefore, move the multiplication out of the loop. This helps in two ways: 1) now we have ULL += U * ULL; which expands the uint in multiplication, 2) it saves couple of CPU cycles. Resolves: https://issues.redhat.com/browse/RHEL-16749 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virnuma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/util/virnuma.c b/src/util/virnuma.c index 5053a70c61..9393c20875 100644 --- a/src/util/virnuma.c +++ b/src/util/virnuma.c @@ -787,9 +787,7 @@ virNumaGetPages(int node, tmp_free[ntmp] = page_free; ntmp++; - /* page_size is in kibibytes while we want huge_page_sum - * in just bytes. */ - huge_page_sum += 1024 * page_size * page_avail; + huge_page_sum += page_size * page_avail; } if (direrr < 0) @@ -800,6 +798,9 @@ virNumaGetPages(int node, VIR_REALLOC_N(tmp_avail, ntmp + 1); VIR_REALLOC_N(tmp_free, ntmp + 1); + /* page_size is in kibibytes while we want huge_page_sum in just bytes. */ + huge_page_sum *= 1024; + if (virNumaGetPageInfo(node, system_page_size, huge_page_sum, &tmp_avail[ntmp], &tmp_free[ntmp]) < 0) return -1; -- 2.41.0

2 1

[pushed][libvirt PATCH] Fix cpu-host-model test data
by Tim Wiederhake 24 Nov '23

24 Nov '23

This was broken by the recent addition of vmx-* features. Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- .../cpu-host-model-fallback-kvm.x86_64-4.2.0.args | 2 +- .../cpu-host-model-fallback-kvm.x86_64-5.0.0.args | 2 +- .../cpu-host-model-fallback-kvm.x86_64-latest.args | 2 +- .../cpu-host-model-nofallback-kvm.x86_64-4.2.0.args | 2 +- .../cpu-host-model-nofallback-kvm.x86_64-5.0.0.args | 2 +- .../cpu-host-model-nofallback-kvm.x86_64-latest.args | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-4.2.0.args b/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-4.2.0.args index 1111e388d9..f5f0e818af 100644 --- a/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-4.2.0.args +++ b/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-4.2.0.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes \ -machine pc-i440fx-4.2,usb=off,dump-guest-core=off \ -accel kvm \ --cpu Skylake-Client-IBRS,ss=on,vmx=on,hypervisor=on,tsc-adjust=on,clflushopt=on,umip=on,md-clear=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,pdpe1gb=on,skip-l1dfl-vmentry=on,pschange-mc-no=on \ +-cpu Skylake-Client-IBRS,ss=on,vmx=on,hypervisor=on,tsc-adjust=on,clflushopt=on,umip=on,md-clear=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,pdpe1gb=on,skip-l1dfl-vmentry=on,pschange-mc-no=on,vmx-ins-outs=on,vmx-true-ctls=on,vmx-store-lma=on,vmx-activity-hlt=on,vmx-vmwrite-vmexit-fields=on,vmx-apicv-xapic=on,vmx-ept=on,vmx-desc-exit=on,vmx-rdtscp-exit=on,vmx-apicv-x2apic=on,vmx-vpid=on,vmx-wbinvd-exit=on,vmx-unrestricted-guest=on,vmx-rdrand-exit=on,vmx-invpcid-exit=on,vmx-vmfunc=on,vmx-shadow-vmcs=on,vmx-rdseed-exit=on,vmx-pml=on,vmx-xsaves=on,vmx-invvpid=on,vmx-invvpid-single-addr=on,vmx-invvpid-all-context=on,vmx-ept-execonly=on,vmx-page-walk-4=on,vmx-ept-2mb=on,vmx-ept-1gb=on,vmx-invept=on,vmx-eptad=on,vmx-invept-single-context=on,vmx-invept-all-context=on,vmx-intr-exit=on,vmx-nmi-exit=on,vmx-vnmi=on,vmx-preemption-timer=on,vmx-vintr-pending=on,vmx-tsc-offset=on,vmx-hlt-exit=on,vmx-invlpg-exit=on,vmx-mwait-exit=on,vmx-rdpmc-exit=on,vmx-rdtsc-exit=on,vmx-cr3-load-noexit=on,vmx-cr3-store-noexit=on,vmx-cr8-load-exit=on,vmx-cr8-store-exit=on,vmx-flexpriority=on,vmx-vnmi-pending=on,vmx-movdr-exit=on,vmx-io-exit=on,vmx-io-bitmap=on,vmx-mtf=on,vmx-msr-bitmap=on,vmx-monitor-exit=on,vmx-pause-exit=on,vmx-secondary-ctls=on,vmx-exit-nosave-debugctl=on,vmx-exit-ack-intr=on,vmx-exit-save-pat=on,vmx-exit-load-pat=on,vmx-exit-save-efer=on,vmx-exit-load-efer=on,vmx-exit-save-preemption-timer=on,vmx-entry-noload-debugctl=on,vmx-entry-ia32e-mode=on,vmx-entry-load-pat=on,vmx-entry-load-efer=on,vmx-eptp-switching=on \ -m size=219136k \ -overcommit mem-lock=off \ -smp 6,sockets=6,cores=1,threads=1 \ diff --git a/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-5.0.0.args b/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-5.0.0.args index f51c51bcb3..699f48fbaa 100644 --- a/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-5.0.0.args +++ b/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-5.0.0.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes \ -machine pc-i440fx-5.0,usb=off,dump-guest-core=off \ -accel kvm \ --cpu Skylake-Client-IBRS,ss=on,vmx=on,hypervisor=on,tsc-adjust=on,clflushopt=on,umip=on,md-clear=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,pdpe1gb=on,skip-l1dfl-vmentry=on,pschange-mc-no=on \ +-cpu Skylake-Client-IBRS,ss=on,vmx=on,hypervisor=on,tsc-adjust=on,clflushopt=on,umip=on,md-clear=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,pdpe1gb=on,skip-l1dfl-vmentry=on,pschange-mc-no=on,vmx-ins-outs=on,vmx-true-ctls=on,vmx-store-lma=on,vmx-activity-hlt=on,vmx-vmwrite-vmexit-fields=on,vmx-apicv-xapic=on,vmx-ept=on,vmx-desc-exit=on,vmx-rdtscp-exit=on,vmx-apicv-x2apic=on,vmx-vpid=on,vmx-wbinvd-exit=on,vmx-unrestricted-guest=on,vmx-rdrand-exit=on,vmx-invpcid-exit=on,vmx-vmfunc=on,vmx-shadow-vmcs=on,vmx-rdseed-exit=on,vmx-pml=on,vmx-xsaves=on,vmx-invvpid=on,vmx-invvpid-single-addr=on,vmx-invvpid-all-context=on,vmx-ept-execonly=on,vmx-page-walk-4=on,vmx-ept-2mb=on,vmx-ept-1gb=on,vmx-invept=on,vmx-eptad=on,vmx-invept-single-context=on,vmx-invept-all-context=on,vmx-intr-exit=on,vmx-nmi-exit=on,vmx-vnmi=on,vmx-preemption-timer=on,vmx-vintr-pending=on,vmx-tsc-offset=on,vmx-hlt-exit=on,vmx-invlpg-exit=on,vmx-mwait-exit=on,vmx-rdpmc-exit=on,vmx-rdtsc-exit=on,vmx-cr3-load-noexit=on,vmx-cr3-store-noexit=on,vmx-cr8-load-exit=on,vmx-cr8-store-exit=on,vmx-flexpriority=on,vmx-vnmi-pending=on,vmx-movdr-exit=on,vmx-io-exit=on,vmx-io-bitmap=on,vmx-mtf=on,vmx-msr-bitmap=on,vmx-monitor-exit=on,vmx-pause-exit=on,vmx-secondary-ctls=on,vmx-exit-nosave-debugctl=on,vmx-exit-ack-intr=on,vmx-exit-save-pat=on,vmx-exit-load-pat=on,vmx-exit-save-efer=on,vmx-exit-load-efer=on,vmx-exit-save-preemption-timer=on,vmx-entry-noload-debugctl=on,vmx-entry-ia32e-mode=on,vmx-entry-load-pat=on,vmx-entry-load-efer=on,vmx-eptp-switching=on \ -m size=219136k \ -overcommit mem-lock=off \ -smp 6,sockets=6,cores=1,threads=1 \ diff --git a/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-latest.args b/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-latest.args index 21b8184e55..c11c2118bf 100644 --- a/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-latest.args +++ b/tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \ -accel kvm \ --cpu EPYC-Rome,x2apic=on,tsc-deadline=on,hypervisor=on,tsc-adjust=on,stibp=on,arch-capabilities=on,ssbd=on,cmp-legacy=on,amd-ssbd=on,virt-ssbd=on,lbrv=on,tsc-scale=on,vmcb-clean=on,pause-filter=on,pfthreshold=on,v-vmsave-vmload=on,vgif=on,svme-addr-chk=on,lfence-always-serializing=on,null-sel-clr-base=on,rdctl-no=on,skip-l1dfl-vmentry=on,mds-no=on,pschange-mc-no=on,xsaves=off \ +-cpu EPYC-Rome,x2apic=on,tsc-deadline=on,hypervisor=on,tsc-adjust=on,stibp=on,arch-capabilities=on,ssbd=on,cmp-legacy=on,amd-ssbd=on,virt-ssbd=on,lbrv=on,tsc-scale=on,vmcb-clean=on,pause-filter=on,pfthreshold=on,v-vmsave-vmload=on,vgif=on,svme-addr-chk=on,lfence-always-serializing=on,null-sel-clr-base=on,rdctl-no=on,skip-l1dfl-vmentry=on,mds-no=on,pschange-mc-no=on,gds-no=on,xsaves=off \ -m size=219136k \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}' \ -overcommit mem-lock=off \ diff --git a/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-4.2.0.args b/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-4.2.0.args index 1111e388d9..f5f0e818af 100644 --- a/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-4.2.0.args +++ b/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-4.2.0.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes \ -machine pc-i440fx-4.2,usb=off,dump-guest-core=off \ -accel kvm \ --cpu Skylake-Client-IBRS,ss=on,vmx=on,hypervisor=on,tsc-adjust=on,clflushopt=on,umip=on,md-clear=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,pdpe1gb=on,skip-l1dfl-vmentry=on,pschange-mc-no=on \ +-cpu Skylake-Client-IBRS,ss=on,vmx=on,hypervisor=on,tsc-adjust=on,clflushopt=on,umip=on,md-clear=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,pdpe1gb=on,skip-l1dfl-vmentry=on,pschange-mc-no=on,vmx-ins-outs=on,vmx-true-ctls=on,vmx-store-lma=on,vmx-activity-hlt=on,vmx-vmwrite-vmexit-fields=on,vmx-apicv-xapic=on,vmx-ept=on,vmx-desc-exit=on,vmx-rdtscp-exit=on,vmx-apicv-x2apic=on,vmx-vpid=on,vmx-wbinvd-exit=on,vmx-unrestricted-guest=on,vmx-rdrand-exit=on,vmx-invpcid-exit=on,vmx-vmfunc=on,vmx-shadow-vmcs=on,vmx-rdseed-exit=on,vmx-pml=on,vmx-xsaves=on,vmx-invvpid=on,vmx-invvpid-single-addr=on,vmx-invvpid-all-context=on,vmx-ept-execonly=on,vmx-page-walk-4=on,vmx-ept-2mb=on,vmx-ept-1gb=on,vmx-invept=on,vmx-eptad=on,vmx-invept-single-context=on,vmx-invept-all-context=on,vmx-intr-exit=on,vmx-nmi-exit=on,vmx-vnmi=on,vmx-preemption-timer=on,vmx-vintr-pending=on,vmx-tsc-offset=on,vmx-hlt-exit=on,vmx-invlpg-exit=on,vmx-mwait-exit=on,vmx-rdpmc-exit=on,vmx-rdtsc-exit=on,vmx-cr3-load-noexit=on,vmx-cr3-store-noexit=on,vmx-cr8-load-exit=on,vmx-cr8-store-exit=on,vmx-flexpriority=on,vmx-vnmi-pending=on,vmx-movdr-exit=on,vmx-io-exit=on,vmx-io-bitmap=on,vmx-mtf=on,vmx-msr-bitmap=on,vmx-monitor-exit=on,vmx-pause-exit=on,vmx-secondary-ctls=on,vmx-exit-nosave-debugctl=on,vmx-exit-ack-intr=on,vmx-exit-save-pat=on,vmx-exit-load-pat=on,vmx-exit-save-efer=on,vmx-exit-load-efer=on,vmx-exit-save-preemption-timer=on,vmx-entry-noload-debugctl=on,vmx-entry-ia32e-mode=on,vmx-entry-load-pat=on,vmx-entry-load-efer=on,vmx-eptp-switching=on \ -m size=219136k \ -overcommit mem-lock=off \ -smp 6,sockets=6,cores=1,threads=1 \ diff --git a/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-5.0.0.args b/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-5.0.0.args index f51c51bcb3..699f48fbaa 100644 --- a/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-5.0.0.args +++ b/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-5.0.0.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -object secret,id=masterKey0,format=raw,file=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes \ -machine pc-i440fx-5.0,usb=off,dump-guest-core=off \ -accel kvm \ --cpu Skylake-Client-IBRS,ss=on,vmx=on,hypervisor=on,tsc-adjust=on,clflushopt=on,umip=on,md-clear=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,pdpe1gb=on,skip-l1dfl-vmentry=on,pschange-mc-no=on \ +-cpu Skylake-Client-IBRS,ss=on,vmx=on,hypervisor=on,tsc-adjust=on,clflushopt=on,umip=on,md-clear=on,stibp=on,arch-capabilities=on,ssbd=on,xsaves=on,pdpe1gb=on,skip-l1dfl-vmentry=on,pschange-mc-no=on,vmx-ins-outs=on,vmx-true-ctls=on,vmx-store-lma=on,vmx-activity-hlt=on,vmx-vmwrite-vmexit-fields=on,vmx-apicv-xapic=on,vmx-ept=on,vmx-desc-exit=on,vmx-rdtscp-exit=on,vmx-apicv-x2apic=on,vmx-vpid=on,vmx-wbinvd-exit=on,vmx-unrestricted-guest=on,vmx-rdrand-exit=on,vmx-invpcid-exit=on,vmx-vmfunc=on,vmx-shadow-vmcs=on,vmx-rdseed-exit=on,vmx-pml=on,vmx-xsaves=on,vmx-invvpid=on,vmx-invvpid-single-addr=on,vmx-invvpid-all-context=on,vmx-ept-execonly=on,vmx-page-walk-4=on,vmx-ept-2mb=on,vmx-ept-1gb=on,vmx-invept=on,vmx-eptad=on,vmx-invept-single-context=on,vmx-invept-all-context=on,vmx-intr-exit=on,vmx-nmi-exit=on,vmx-vnmi=on,vmx-preemption-timer=on,vmx-vintr-pending=on,vmx-tsc-offset=on,vmx-hlt-exit=on,vmx-invlpg-exit=on,vmx-mwait-exit=on,vmx-rdpmc-exit=on,vmx-rdtsc-exit=on,vmx-cr3-load-noexit=on,vmx-cr3-store-noexit=on,vmx-cr8-load-exit=on,vmx-cr8-store-exit=on,vmx-flexpriority=on,vmx-vnmi-pending=on,vmx-movdr-exit=on,vmx-io-exit=on,vmx-io-bitmap=on,vmx-mtf=on,vmx-msr-bitmap=on,vmx-monitor-exit=on,vmx-pause-exit=on,vmx-secondary-ctls=on,vmx-exit-nosave-debugctl=on,vmx-exit-ack-intr=on,vmx-exit-save-pat=on,vmx-exit-load-pat=on,vmx-exit-save-efer=on,vmx-exit-load-efer=on,vmx-exit-save-preemption-timer=on,vmx-entry-noload-debugctl=on,vmx-entry-ia32e-mode=on,vmx-entry-load-pat=on,vmx-entry-load-efer=on,vmx-eptp-switching=on \ -m size=219136k \ -overcommit mem-lock=off \ -smp 6,sockets=6,cores=1,threads=1 \ diff --git a/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-latest.args b/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-latest.args index 21b8184e55..c11c2118bf 100644 --- a/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-latest.args +++ b/tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \ -accel kvm \ --cpu EPYC-Rome,x2apic=on,tsc-deadline=on,hypervisor=on,tsc-adjust=on,stibp=on,arch-capabilities=on,ssbd=on,cmp-legacy=on,amd-ssbd=on,virt-ssbd=on,lbrv=on,tsc-scale=on,vmcb-clean=on,pause-filter=on,pfthreshold=on,v-vmsave-vmload=on,vgif=on,svme-addr-chk=on,lfence-always-serializing=on,null-sel-clr-base=on,rdctl-no=on,skip-l1dfl-vmentry=on,mds-no=on,pschange-mc-no=on,xsaves=off \ +-cpu EPYC-Rome,x2apic=on,tsc-deadline=on,hypervisor=on,tsc-adjust=on,stibp=on,arch-capabilities=on,ssbd=on,cmp-legacy=on,amd-ssbd=on,virt-ssbd=on,lbrv=on,tsc-scale=on,vmcb-clean=on,pause-filter=on,pfthreshold=on,v-vmsave-vmload=on,vgif=on,svme-addr-chk=on,lfence-always-serializing=on,null-sel-clr-base=on,rdctl-no=on,skip-l1dfl-vmentry=on,mds-no=on,pschange-mc-no=on,gds-no=on,xsaves=off \ -m size=219136k \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}' \ -overcommit mem-lock=off \ -- 2.39.2

1 0

[PATCH 0/3] lib: Replace qsort() with g_qsort_with_data()
by Michal Privoznik 23 Nov '23

23 Nov '23

Technically, this is a v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/GBTH… but it implements a different approach, so I'm sending it anew. Michal Prívozník (3): build-aux: Refresh list of nonreentrant functions lib: Replace qsort() with g_qsort_with_data() syntax-check: Forbid use of qsort() build-aux/Makefile.nonreentrant | 18 +++++++------- build-aux/syntax-check.mk | 9 ++++++- src/conf/capabilities.c | 8 ++++--- src/conf/domain_conf.c | 6 +++-- src/cpu/cpu.c | 7 +++--- src/cpu/cpu_x86.c | 15 +++++++----- src/lxc/lxc_container.c | 3 ++- src/nwfilter/nwfilter_ebiptables_driver.c | 29 +++++++++++++++-------- src/qemu/qemu_monitor_json.c | 6 +++-- src/qemu/qemu_process.c | 7 +++--- src/security/security_manager.c | 9 ++++--- src/util/virfile.c | 8 ++++--- src/util/virhash.c | 9 ++++--- src/util/virresctrl.c | 9 ++++--- src/util/virstring.c | 12 ++++++---- src/util/virstring.h | 8 +++++-- src/util/virtypedparam.c | 9 ++++--- tests/commandhelper.c | 6 +++-- tests/virstringtest.c | 8 +++---- tools/nss/libvirt_nss.c | 3 ++- tools/virsh-checkpoint.c | 10 ++++---- tools/virsh-domain-monitor.c | 11 +++++---- tools/virsh-host.c | 7 ++++-- tools/virsh-interface.c | 11 +++++---- tools/virsh-network.c | 29 +++++++++++++++-------- tools/virsh-nodedev.c | 11 +++++---- tools/virsh-nwfilter.c | 22 ++++++++++------- tools/virsh-pool.c | 11 +++++---- tools/virsh-secret.c | 11 +++++---- tools/virsh-snapshot.c | 10 ++++---- tools/virsh-volume.c | 10 +++++--- 31 files changed, 213 insertions(+), 119 deletions(-) -- 2.41.0

3 5

[PATCH 0/5] conf: Check for dimm/nvimm address conflicts too
by Michal Privoznik 23 Nov '23

23 Nov '23

*** BLURB HERE *** Michal Prívozník (5): domain_validate: Move memdevice address conflict check into a separate function qemuxml2argvdata: Extend memory-hotplug-virtio-mem-overlap-address.xml virDomainMemoryDefCheckConflict: Check dimm & nvdimm models too virDomainMemoryDefCheckConflict: Validate dimm slot too qemu_domain: Drop qemuCheckMemoryDimmConflict() src/conf/domain_validate.c | 165 +++++++++++------- src/qemu/qemu_domain.c | 37 ---- ...rtio-mem-overlap-address.x86_64-latest.err | 2 +- ...ory-hotplug-virtio-mem-overlap-address.xml | 19 +- 4 files changed, 123 insertions(+), 100 deletions(-) -- 2.41.0

3 13

[PULL 05/14] target/nios2: Deprecate the Nios II architecture
by Alex Bennée 23 Nov '23

23 Nov '23

From: Philippe Mathieu-Daudé <philmd(a)linaro.org> See commit 9ba1caf510 ("MAINTAINERS: Mark the Nios II CPU as orphan"), last contribution from Chris was in 2012 [1] and Marek in 2018 [2]. [1] https://lore.kernel.org/qemu-devel/1352607539-10455-2-git-send-email-crwulf… [2] https://lore.kernel.org/qemu-devel/805fc7b5-03f0-56d4-abfd-ed010d4fa769@den… Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> Reviewed-by: Richard Henderson <richard.henderson(a)linaro.org> Acked-by: Marek Vasut <marex(a)denx.de> Reviewed-by: Thomas Huth <thuth(a)redhat.com> Message-Id: <20231117070250.32932-1-philmd(a)linaro.org> Signed-off-by: Alex Bennée <alex.bennee(a)linaro.org> Message-Id: <20231120150833.2552739-6-alex.bennee(a)linaro.org> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 6c84db90b5..2e15040246 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -236,6 +236,16 @@ it. Since all recent x86 hardware from the past >10 years is capable of the 64-bit x86 extensions, a corresponding 64-bit OS should be used instead. +System emulator CPUs +-------------------- + +Nios II CPU (since 8.2) +''''''''''''''''''''''' + +The Nios II architecture is orphan. The ``nios2`` guest CPU support is +deprecated and will be removed in a future version of QEMU. + + System emulator machines ------------------------ @@ -254,6 +264,11 @@ These old machine types are quite neglected nowadays and thus might have various pitfalls with regards to live migration. Use a newer machine type instead. +Nios II ``10m50-ghrd`` and ``nios2-generic-nommu`` machines (since 8.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +The Nios II architecture is orphan. + Backend options --------------- diff --git a/hw/nios2/10m50_devboard.c b/hw/nios2/10m50_devboard.c index 952a0dc33e..6cb32f777b 100644 --- a/hw/nios2/10m50_devboard.c +++ b/hw/nios2/10m50_devboard.c @@ -160,6 +160,7 @@ static void nios2_10m50_ghrd_class_init(ObjectClass *oc, void *data) mc->desc = "Altera 10M50 GHRD Nios II design"; mc->init = nios2_10m50_ghrd_init; mc->is_default = true; + mc->deprecation_reason = "Nios II architecture is deprecated"; object_class_property_add_bool(oc, "vic", get_vic, set_vic); object_class_property_set_description(oc, "vic", diff --git a/hw/nios2/generic_nommu.c b/hw/nios2/generic_nommu.c index 48edb3ae37..defa16953f 100644 --- a/hw/nios2/generic_nommu.c +++ b/hw/nios2/generic_nommu.c @@ -95,6 +95,7 @@ static void nios2_generic_nommu_machine_init(struct MachineClass *mc) { mc->desc = "Generic NOMMU Nios II design"; mc->init = nios2_generic_nommu_init; + mc->deprecation_reason = "Nios II architecture is deprecated"; } DEFINE_MACHINE("nios2-generic-nommu", nios2_generic_nommu_machine_init); -- 2.39.2

1 0

[libvirt PATCH v2 0/5] ci: Build RPMs on MinGW
by Andrea Bolognani 23 Nov '23

23 Nov '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1075354744 Ignore the macOS 14 failure, it's caused by a temporary issue on the Cirrus CI side. Changes since [v1]: * a few patches have either been pushed (1-4) or are no longer needed (10), so they have been dropped; * the last patch has been tweaked a bit and the changes contained in it are now documented with a code comment. [v1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/Y2W2… Andrea Bolognani (5): rpm: Shuffle BuildRequires around rpm: Split call to mingw_debug_package rpm: Introduce with_mingw32/with_mingw64 rpm: Introduce with_native ci: Build RPMs on MinGW .gitlab-ci.yml | 11 +- ci/jobs.sh | 23 ++- libvirt.spec.in | 460 +++++++++++++++++++++++++++--------------------- 3 files changed, 285 insertions(+), 209 deletions(-) -- 2.41.0

2 6

[PATCH 0/3] qemuDomainAttachDeviceDiskLiveInternal: Fix error handling and properly hotplug empty cdroms
by Peter Krempa 23 Nov '23

23 Nov '23

Patch 3 is best viewed with '-w' Peter Krempa (3): qemuDomainAttachDeviceDiskLiveInternal: Fix jumps on error qemuDomainAttachDeviceDiskLiveInternal: Add missing jump to 'cleanup' on error qemu: hotplug: Don't try to setup disk image when hotplugging empty cdrom drive src/qemu/qemu_hotplug.c | 100 +++++++++++++++++++++------------------- 1 file changed, 53 insertions(+), 47 deletions(-) -- 2.42.0

2 4

Kernel issue or libvirt issue? Where to report?
by Koos Pol 22 Nov '23

22 Nov '23

Hi, After upgrading the VM host (os + kernel) a VM client can no longer use a pass-through USB device. The syslog of the VM host is flooded with: nov 08 19:59:46 vmhost kernel: usb 1-3: usbfs: process 1729 (qemu-system-x86) did not claim interface 1 before use Because of the upgrade the vm host has gotten both a new kernel version and a new libvirt verion. The vm client has not been touched. Before I waste everyone's time on an incorrect bug report, would you say I file this with libvirt or with the openSUSE kernel (the o.s. of the vmhost)? Thanks! Koos

2 2

[PATCH] qemu: validate: Reword error message when CCW addresses are not supported for a machine
by Peter Krempa 22 Nov '23

22 Nov '23

Reword the error message to clearly state that the machine type doesn't support the address type. It doesn't matter which device it's for. Additionally the alias may be still NULL at the point when the error is being reported misleading users that they have something wrong with a specific device. Resolves:https://issues.redhat.com/browse/RHEL-16878 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_validate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 93df9e4c8e..2afd7e128a 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1512,8 +1512,8 @@ qemuValidateDomainDeviceDefAddress(const virDomainDeviceDef *dev, case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: if (!qemuDomainIsS390CCW(def)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("cannot use CCW address type for device '%1$s' using machine type '%2$s'"), - NULLSTR(info->alias), def->os.machine); + _("CCW addresses are not supported by machine type '%1$s'"), + def->os.machine); return -1; } -- 2.41.0

3 2

[PATCH 0/2] Adapt to glibc qsort() turned unstable
by Michal Privoznik 22 Nov '23

22 Nov '23

glibc reworked qsort() which now uses an unstable sorting algorithm. This is causing issues to our tests (see broken pipeline for rawhide). Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1081297468 Michal Prívozník (2): tests: Introduce virqsortmock nwfilterxml2firewalltest: Use virqsortmock for stable sorting tests/meson.build | 1 + tests/nwfilterxml2firewalltest.c | 4 ++- tests/virqsortmock.c | 58 ++++++++++++++++++++++++++++++++ 3 files changed, 62 insertions(+), 1 deletion(-) create mode 100644 tests/virqsortmock.c -- 2.41.0

3 4

[PATCH 0/3] Introduce pipewire audio backend
by Michal Privoznik 22 Nov '23

22 Nov '23

This is a resend of patches from earlier: https://listman.redhat.com/archives/libvir-list/2023-May/239860.html Apparently, users want this now. Michal Prívozník (3): conf: Introduce pipewire audio backend qemu: Generate cmd line for pipewire audio backend NEWS: Document pipewire audio backend NEWS.rst | 10 +++ docs/formatdomain.rst | 35 +++++++++- src/conf/domain_conf.c | 70 +++++++++++++++++++ src/conf/domain_conf.h | 12 ++++ src/conf/schemas/domaincommon.rng | 37 ++++++++++ src/qemu/qemu_command.c | 63 +++++++++++++++++ src/qemu/qemu_validate.c | 1 + .../audio-many-backends.x86_64-latest.args | 2 + .../qemuxml2argvdata/audio-many-backends.xml | 1 + .../audio-pipewire-best.x86_64-latest.args | 36 ++++++++++ .../qemuxml2argvdata/audio-pipewire-best.xml | 43 ++++++++++++ .../audio-pipewire-full.x86_64-latest.args | 36 ++++++++++ .../qemuxml2argvdata/audio-pipewire-full.xml | 43 ++++++++++++ .../audio-pipewire-minimal.x86_64-latest.args | 36 ++++++++++ .../audio-pipewire-minimal.xml | 36 ++++++++++ tests/qemuxml2argvtest.c | 14 ++++ .../audio-many-backends.x86_64-latest.xml | 1 + .../audio-pipewire-best.x86_64-latest.xml | 46 ++++++++++++ .../audio-pipewire-full.x86_64-latest.xml | 46 ++++++++++++ .../audio-pipewire-minimal.x86_64-latest.xml | 39 +++++++++++ tests/qemuxml2xmltest.c | 3 + 21 files changed, 608 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/audio-pipewire-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-best.xml create mode 100644 tests/qemuxml2argvdata/audio-pipewire-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-full.xml create mode 100644 tests/qemuxml2argvdata/audio-pipewire-minimal.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-best.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-full.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-minimal.x86_64-latest.xml -- 2.41.0

3 8

Plans for 9.10.0 release (freeze on Monday 27 Nov)
by Jiri Denemark 21 Nov '23

21 Nov '23

We are getting close to 9.10.0 release of libvirt. To aim for the release on Friday 01 Dec I suggest entering the freeze on Monday 27 Nov and tagging RC2 on Wednesday 29 Nov. I hope this works for everyone. Jirka

1 0

[libvirt PATCH] gitlab: adjust url to Coverity tools
by Daniel P. Berrangé 21 Nov '23

21 Nov '23

The URL to the Coverity tools download has changed; the old one points to an obsolete version that is not supported anymore. Adjust to point to the correct and supported tools. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 1cdabed941..7dcd07a5c9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -179,7 +179,7 @@ coverity: before_script: - cat /packages.txt script: - - curl https://scan.coverity.com/download/linux64 --form project=$COVERITY_SCAN_PROJECT_NAME --form token=$COVERITY_SCAN_TOKEN -o /tmp/cov-analysis-linux64.tgz + - curl https://scan.coverity.com/download/cxx/linux64 --form project=$COVERITY_SCAN_PROJECT_NAME --form token=$COVERITY_SCAN_TOKEN -o /tmp/cov-analysis-linux64.tgz - tar xfz /tmp/cov-analysis-linux64.tgz - meson setup build --werror || (cat build/meson-logs/meson-log.txt && exit 1) - cov-analysis-linux64-*/bin/cov-build --dir cov-int meson compile -C build -- 2.41.0

2 1

[libvirt PATCH] security: drop virSecurityDACRestoreImageLabelSingle()
by Andrea Bolognani 21 Nov '23

21 Nov '23

It only has a single, trivial caller. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/security/security_dac.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index c07e488db7..35b9b56c66 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -972,10 +972,10 @@ virSecurityDACSetImageLabel(virSecurityManager *mgr, } static int -virSecurityDACRestoreImageLabelSingle(virSecurityManager *mgr, - virDomainDef *def, - virStorageSource *src, - bool migrated) +virSecurityDACRestoreImageLabelInt(virSecurityManager *mgr, + virDomainDef *def, + virStorageSource *src, + bool migrated) { virSecurityDACData *priv = virSecurityManagerGetPrivateData(mgr); virSecurityLabelDef *secdef; @@ -1047,19 +1047,6 @@ virSecurityDACRestoreImageLabelSingle(virSecurityManager *mgr, } -static int -virSecurityDACRestoreImageLabelInt(virSecurityManager *mgr, - virDomainDef *def, - virStorageSource *src, - bool migrated) -{ - if (virSecurityDACRestoreImageLabelSingle(mgr, def, src, migrated) < 0) - return -1; - - return 0; -} - - static int virSecurityDACRestoreImageLabel(virSecurityManager *mgr, virDomainDef *def, -- 2.42.0

2 1

[libvirt PATCH v2] qemu: add runtime config option for nbdkit
by Jonathon Jongsma 21 Nov '23

21 Nov '23

Currently when we build with nbdkit support, libvirt will always try to use nbdkit to access remote disk sources when it is available. But without an up-to-date selinux policy allowing this, it will fail. Because the required selinux policies are not yet widely available, we have disabled nbdkit support on rpm builds for all distributions before Fedora 40. Unfortunately, this makes it more difficult to test nbdkit support. After someone updates to the necessary selinux policies, they would also need to rebuild libvirt to enable nbdkit support. By introducing a configure option (storage_use_nbdkit), we can build packages with nbdkit support but have it disabled by default. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> Suggested-by: Andrea Bolognani <abologna(a)redhat.com> --- Responding to one part of Andrea's review on v1: > The main concern I have is how this will be handled for upgrades. At > some point we want to make nbdkit the default, right? But that would > mean changing how existing installations behave. I guess that is fine > in this case? Performing the switch transparently was always the plan > after all... I still feel a tiny bit uneasy about that though. Yes, I feel the same tiny bit of unease. I think it will be OK though. For upgrades, we have to consider three basic cases: 1. user doesn't make any configuration changes - by default nbdkit will not be used. When the default changes in the future, nbdkit will start being used after upgrade. 2. user explicitly enables nbdkit - if the user decides to enable nbdkit explicitly via config file, libvirt will start using nbdkit to serve remote disks. In order for this to work, the user would have had to install a custom selinux policy. When the default changes in the future (because the selinux policy is included downstream) libvirt will continue using nbdkit for remote disks after upgrade 3. user explicitly disables nbdkit - there is very little reason for the user to explicitly disable this configure option until there is a widely-available selinux policy that makes it possible to *enable* the option. I can think of two potential reaons it might be done: A) the user wanted to test the nbdkit feature so they explicitly enabled it in the config file. After finding out that it failed due to missing selinux policies, the user explicitly disabled it in the config file rather than just deleting the configuration option. B) the user doesn't want nbdkit to be used even if the default changes in the future. The only slightly problematic option for upgrades is 3A. If a user disabled the option and then upgraded to a libvirt version that defaulted to enabling nbdkit, that new default would not be used. If the downstream distribution then removed the qemu block drivers for curl and ssh, remote disks may no longer work. But since there's very little reason for a user to explicitly disable this configure option while it is disabled by default, I don't see this as a scenario that is likely to happen to anybody aside from a developer or two. libvirt.spec.in | 18 ++++++++++++++---- meson.build | 4 ++++ meson_options.txt | 3 ++- src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/meson.build | 2 ++ src/qemu/qemu.conf.in | 10 ++++++++++ src/qemu/qemu_conf.c | 15 +++++++++++++++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_domain.c | 3 +++ tests/qemuxml2argvtest.c | 15 +++++++++------ 10 files changed, 64 insertions(+), 11 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f50c451e73..5107b06677 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -96,6 +96,7 @@ %define with_sanlock 0 %define with_numad 0 %define with_nbdkit 0 +%define with_nbdkit_config_default 0 %define with_firewalld_zone 0 %define with_netcf 0 %define with_libssh2 0 @@ -174,15 +175,17 @@ %endif %endif -# We should only enable nbdkit support if the OS ships a SELinux policy that -# allows libvirt to launch it. Right now that's not the case anywhere, but -# things should be fine by the time Fedora 40 is released. +# We want to build with nbdkit support, but should only enable nbdkit by +# default if the OS ships a SELinux policy that allows libvirt to launch it. +# Right now that's not the case anywhere, but things should be fine by the time +# Fedora 40 is released. # # TODO: add RHEL 9 once a minor release that contains the necessary SELinux # bits exists (we only support the most recent minor release) %if %{with_qemu} + %define with_nbdkit 0%{!?_without_nbdkit:1} %if 0%{?fedora} >= 40 - %define with_nbdkit 0%{!?_without_nbdkit:1} + %define with_nbdkit_config_default 0%{!?_without_nbdkit_config_default:1} %endif %endif @@ -1184,6 +1187,12 @@ exit 1 %define arg_nbdkit -Dnbdkit=disabled %endif +%if %{with_nbdkit_config_default} + %define arg_nbdkit_config_default -Dnbdkit_config_default=true +%else + %define arg_nbdkit_config_default -Dnbdkit_config_default=false +%endif + %if %{with_fuse} %define arg_fuse -Dfuse=enabled %else @@ -1298,6 +1307,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec) %{?arg_sanlock} \ -Dlibpcap=enabled \ %{?arg_nbdkit} \ + %{?arg_nbdkit_config_default} \ -Dlibnl=enabled \ -Daudit=enabled \ -Ddtrace=enabled \ diff --git a/meson.build b/meson.build index 62481a008d..ce8ea1300f 100644 --- a/meson.build +++ b/meson.build @@ -1012,6 +1012,10 @@ if not conf.has('WITH_NBDKIT') libnbd_dep = dependency('', required: false) endif +# default value for storage_use_nbdkit config option +use_nbdkit_default = get_option('nbdkit_config_default') +conf.set10('USE_NBDKIT_DEFAULT', use_nbdkit_default) + libnl_version = '3.0' if not get_option('libnl').disabled() and host_machine.system() == 'linux' libnl_dep = dependency('libnl-3.0', version: '>=' + libnl_version, required: get_option('libnl')) diff --git a/meson_options.txt b/meson_options.txt index a0928102bf..af76cc967e 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -104,7 +104,8 @@ option('loader_nvram', type: 'string', value: '', description: 'Pass list of pai option('login_shell', type: 'feature', value: 'auto', description: 'build virt-login-shell') option('nss', type: 'feature', value: 'auto', description: 'enable Name Service Switch plugin for resolving guest IP addresses') option('numad', type: 'feature', value: 'auto', description: 'use numad to manage CPU placement dynamically') -option('nbdkit', type: 'feature', value: 'auto', description: 'use nbdkit to access network disks') +option('nbdkit', type: 'feature', value: 'auto', description: 'Build nbdkit storage backend') +option('nbdkit_config_default', type: 'boolean', value: 'false', description: 'Whether to use nbdkit storage backend for network disks by default (configurable)') option('pm_utils', type: 'feature', value: 'auto', description: 'use pm-utils for power management') option('sysctl_config', type: 'feature', value: 'auto', description: 'Whether to install sysctl configs') option('tls_priority', type: 'string', value: 'NORMAL', description: 'set the default TLS session priority string') diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index ed097ea3d9..43485b43fb 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -147,6 +147,8 @@ module Libvirtd_qemu = let capability_filters_entry = str_array_entry "capability_filters" + let storage_entry = bool_entry "storage_use_nbdkit" + (* Each entry in the config is one of the following ... *) let entry = default_tls_entry | vnc_entry @@ -170,6 +172,7 @@ module Libvirtd_qemu = | nbd_entry | swtpm_entry | capability_filters_entry + | storage_entry | obsolete_entry let comment = [ label "#comment" . del /#[ \t]*/ "# " . store /([^ \t\n][^\n]*)?/ . del /\n/ "\n" ] diff --git a/src/qemu/meson.build b/src/qemu/meson.build index 2279fef2ca..4c3e1dee78 100644 --- a/src/qemu/meson.build +++ b/src/qemu/meson.build @@ -137,6 +137,7 @@ if conf.has('WITH_QEMU') qemu_user_group_conf = configuration_data({ 'QEMU_USER': qemu_user, 'QEMU_GROUP': qemu_group, + 'USE_NBDKIT_DEFAULT': use_nbdkit_default.to_int(), }) qemu_conf = configure_file( input: 'qemu.conf.in', @@ -147,6 +148,7 @@ if conf.has('WITH_QEMU') qemu_user_group_hack_conf = configuration_data({ 'QEMU_USER': qemu_user, 'QEMU_GROUP': qemu_group, + 'USE_NBDKIT_DEFAULT': use_nbdkit_default.to_int(), # This hack is necessary because the output file is going to be # used as input for another configure_file() call later, which # will take care of substituting @CONFIG@ with useful data diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 6897e0f760..d12ff9f641 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -974,3 +974,13 @@ # "full" - both QEMU and its helper processes are placed into separate # scheduling group #sched_core = "none" + +# Using nbdkit to access remote disk sources +# +# If this is set then libvirt will use nbdkit to access remote disk sources +# when available. nbdkit will export an NBD share to QEMU rather than having +# QEMU attempt to access the remote server directly. +# +# Possible values are 0 or 1. Default value is @USE_NBDKIT_DEFAULT@. +# +# storage_use_nbdkit = @USE_NBDKIT_DEFAULT@ diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 513b5ebb1e..fbc32822ec 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -285,6 +285,7 @@ virQEMUDriverConfig *virQEMUDriverConfigNew(bool privileged, return NULL; cfg->deprecationBehavior = g_strdup("none"); + cfg->storageUseNbdkit = USE_NBDKIT_DEFAULT; return g_steal_pointer(&cfg); } @@ -1065,6 +1066,17 @@ virQEMUDriverConfigLoadCapsFiltersEntry(virQEMUDriverConfig *cfg, } +static int +virQEMUDriverConfigLoadStorageEntry(virQEMUDriverConfig *cfg, + virConf *conf) +{ + if (virConfGetValueBool(conf, "storage_use_nbdkit", &cfg->storageUseNbdkit) < 0) + return -1; + + return 0; +} + + int virQEMUDriverConfigLoadFile(virQEMUDriverConfig *cfg, const char *filename, bool privileged) @@ -1136,6 +1148,9 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfig *cfg, if (virQEMUDriverConfigLoadCapsFiltersEntry(cfg, conf) < 0) return -1; + if (virQEMUDriverConfigLoadStorageEntry(cfg, conf) < 0) + return -1; + return 0; } diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 1a3ba3a0fb..36049b4bfa 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -230,6 +230,8 @@ struct _virQEMUDriverConfig { char *deprecationBehavior; + bool storageUseNbdkit; + virQEMUSchedCore schedCore; }; diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ae19ce884b..f8dda6c898 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10333,6 +10333,9 @@ qemuDomainPrepareStorageSourceNbdkit(virStorageSource *src, { g_autoptr(qemuNbdkitCaps) nbdkit = NULL; + if (!cfg->storageUseNbdkit) + return false; + if (virStorageSourceGetActualType(src) != VIR_STORAGE_TYPE_NETWORK) return false; diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 24997c0aaa..e7a364f897 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1115,7 +1115,6 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-cdrom-empty-network-invalid"); DO_TEST_CAPS_LATEST("disk-cdrom-bus-other"); DO_TEST_CAPS_LATEST("disk-cdrom-network"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); DO_TEST_CAPS_LATEST("disk-cdrom-tray"); DO_TEST_CAPS_LATEST("disk-floppy"); DO_TEST_CAPS_LATEST("disk-floppy-q35"); @@ -1161,8 +1160,6 @@ mymain(void) DO_TEST_CAPS_VER("disk-network-sheepdog", "6.0.0"); DO_TEST_CAPS_LATEST("disk-network-source-auth"); DO_TEST_CAPS_LATEST("disk-network-source-curl"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit-backing", QEMU_NBDKIT_CAPS_PLUGIN_CURL); DO_TEST_CAPS_LATEST("disk-network-nfs"); driver.config->vxhsTLS = 1; driver.config->nbdTLSx509secretUUID = g_strdup("6fd3f62d-9fe7-4a4e-a869-7acd6376d8ea"); @@ -1173,13 +1170,10 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-network-tlsx509-nbd-hostname"); DO_TEST_CAPS_VER("disk-network-tlsx509-vxhs", "5.0.0"); DO_TEST_CAPS_LATEST("disk-network-http"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-http-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); VIR_FREE(driver.config->nbdTLSx509secretUUID); VIR_FREE(driver.config->vxhsTLSx509secretUUID); driver.config->vxhsTLS = 0; DO_TEST_CAPS_LATEST("disk-network-ssh"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_SSH); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-password", QEMU_NBDKIT_CAPS_PLUGIN_SSH); DO_TEST_CAPS_LATEST("disk-no-boot"); DO_TEST_CAPS_LATEST("disk-nvme"); DO_TEST_CAPS_VER("disk-vhostuser-numa", "4.2.0"); @@ -1249,6 +1243,15 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-geometry"); DO_TEST_CAPS_LATEST("disk-blockio"); + driver.config->storageUseNbdkit = 1; + DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit-backing", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-http-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_SSH); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-password", QEMU_NBDKIT_CAPS_PLUGIN_SSH); + driver.config->storageUseNbdkit = 0; + DO_TEST_CAPS_VER("disk-virtio-scsi-reservations", "5.2.0"); DO_TEST_CAPS_LATEST("disk-virtio-scsi-reservations"); -- 2.41.0

2 1

[PATCH 0/6] Adapt to libxml2-2.12.0
by Michal Privoznik 21 Nov '23

21 Nov '23

There is a new release of libxml2 and we have a technical debt we need to address before we can compile with it cleanly. Michal Prívozník (6): vbox_snapshot_conf: Parse XMLs without net access vbox_snapshot_conf: Keep indent in snapshot XML virxml: include <libxml/xmlsave.h> for xmlIndentTreeOutput declaration virXMLParseHelper: Store XML parsing flags in a variable virxml: Introduce parsing APIs that keep indentation lib: Replace xmlKeepBlanksDefault() with virXMLParseWithIndent() src/conf/backup_conf.c | 8 +++----- src/conf/checkpoint_conf.c | 8 +++----- src/conf/domain_conf.c | 11 +++-------- src/conf/network_conf.c | 6 ++---- src/conf/snapshot_conf.c | 8 +++----- src/util/virxml.c | 24 +++++++++++++++++------- src/util/virxml.h | 29 +++++++++++++++++++++++++---- src/vbox/vbox_snapshot_conf.c | 27 +++++++++++++++++++-------- tools/virsh-util.c | 5 +---- 9 files changed, 76 insertions(+), 50 deletions(-) -- 2.41.0

2 12

[PATCH v2 00/14] random fixes for 8.2 pre-PR (tests, plugins, docs, semihosting)
by Alex Bennée 20 Nov '23

20 Nov '23

I've just been trying to clear some of the bugs against various subsystems. These are mostly testing changes and a minor tweak I found while checking up on semihosting behaviour. Enabling arm-softmmu check-tcg tests expands our testing abilities slightly for the 32 bit side of the family. For v2 ------ - fixed up register test for ppc64/s390x - added gdbstub doc patch - review comments for arm-softmmu testing - changed handling of "native" cross for linux-user I intend to roll the PR on Wednesday. The following need still review: tests/tcg: finesse the registers check for "hidden" regs configure: don't try a "native" cross for linux-user tests/tcg: enable semiconsole test for Arm tests/tcg: enable arm softmmu tests docs/system: clarify limits of using gdbstub in system emulation docs/emulation: expand warning about semihosting tests/tcg: fixup Aarch64 semiconsole test Alex Bennée (10): tests/docker: merge debian-native with debian-amd64 tests/tcg: fixup Aarch64 semiconsole test docs/emulation: expand warning about semihosting docs/system: clarify limits of using gdbstub in system emulation hw/core: skip loading debug on all failures testing: move arm system tests into their own folder tests/tcg: enable arm softmmu tests tests/tcg: enable semiconsole test for Arm configure: don't try a "native" cross for linux-user tests/tcg: finesse the registers check for "hidden" regs Daniel P. Berrangé (1): tests/docker: replace fedora-i386 with debian-i686 Greg Manning (1): plugins: fix win plugin tests on cross compile Philippe Mathieu-Daudé (2): .gitlab-ci.d/cirrus: Upgrade macOS to 13 (Ventura) target/nios2: Deprecate the Nios II architecture docs/about/deprecated.rst | 15 + docs/about/emulation.rst | 5 +- docs/system/gdb.rst | 13 +- configure | 27 +- hw/core/loader.c | 2 +- hw/nios2/10m50_devboard.c | 1 + hw/nios2/generic_nommu.c | 1 + tests/tcg/arm/system/semiconsole.c | 42 +++ .gitlab-ci.d/buildtest.yml | 12 +- .gitlab-ci.d/cirrus.yml | 6 +- .../cirrus/{macos-12.vars => macos-13.vars} | 2 +- .gitlab-ci.d/container-cross.yml | 11 +- .gitlab-ci.d/containers.yml | 2 +- .gitlab-ci.d/crossbuilds.yml | 14 +- contrib/plugins/Makefile | 2 +- plugins/meson.build | 2 +- tests/docker/Makefile.include | 3 - .../dockerfiles/debian-i686-cross.docker | 182 +++++++++++ tests/docker/dockerfiles/debian-native.docker | 54 ---- .../{debian-amd64.docker => debian.docker} | 7 +- .../dockerfiles/fedora-i386-cross.docker | 40 --- tests/lcitool/refresh | 18 +- tests/plugin/meson.build | 3 +- tests/tcg/aarch64/Makefile.softmmu-target | 5 +- tests/tcg/arm/Makefile.softmmu-target | 76 ++++- tests/tcg/arm/system/boot.S | 301 ++++++++++++++++++ tests/tcg/arm/system/kernel.ld | 24 ++ .../tcg/arm/{ => system}/test-armv6m-undef.S | 0 .../tcg/arm/{ => system}/test-armv6m-undef.ld | 0 tests/tcg/multiarch/gdbstub/registers.py | 87 +++-- tests/tcg/ppc64/Makefile.target | 7 - tests/tcg/s390x/Makefile.target | 4 - 32 files changed, 775 insertions(+), 193 deletions(-) create mode 100644 tests/tcg/arm/system/semiconsole.c rename .gitlab-ci.d/cirrus/{macos-12.vars => macos-13.vars} (95%) create mode 100644 tests/docker/dockerfiles/debian-i686-cross.docker delete mode 100644 tests/docker/dockerfiles/debian-native.docker rename tests/docker/dockerfiles/{debian-amd64.docker => debian.docker} (96%) delete mode 100644 tests/docker/dockerfiles/fedora-i386-cross.docker create mode 100644 tests/tcg/arm/system/boot.S create mode 100644 tests/tcg/arm/system/kernel.ld rename tests/tcg/arm/{ => system}/test-armv6m-undef.S (100%) rename tests/tcg/arm/{ => system}/test-armv6m-undef.ld (100%) -- 2.39.2

3 17

[libvirt PATCH 0/6] polkit: Make it possible to write safer rules
by Andrea Bolognani 20 Nov '23

20 Nov '23

See patch 5/6 for details. Andrea Bolognani (6): docs: The Polkit access driver is disabled by default docs: Document org.libvirt.unix.* actions rpc: Introduce virNetServerHasGranularPolkit() remote: Set granularPolkit if applicable remote: Expose granularPolkit attribute to rules docs: Document granularPolkit attribute docs/aclpolkit.rst | 33 +++++++++++++++++++++++++++++ src/libvirt_remote.syms | 1 + src/locking/lock_daemon.c | 6 ++++-- src/logging/log_daemon.c | 6 ++++-- src/lxc/lxc_controller.c | 3 ++- src/remote/remote_daemon.c | 24 +++++++++++++++++---- src/remote/remote_daemon_dispatch.c | 6 +++++- src/rpc/virnetserver.c | 16 ++++++++++++-- src/rpc/virnetserver.h | 4 +++- tests/virnetdaemontest.c | 3 ++- 10 files changed, 88 insertions(+), 14 deletions(-) -- 2.42.0

2 7

[libvirt PATCH] kbase: More info on firmware change for existing VMs
by Andrea Bolognani 20 Nov '23

20 Nov '23

The need to remove the <loader> and <nvram> elements in order to make the firmware autoselection process kick in again is not exactly intuitive, so document it explicitly. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/kbase/secureboot.rst | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/docs/kbase/secureboot.rst b/docs/kbase/secureboot.rst index 4340454a7b..6c22b08d22 100644 --- a/docs/kbase/secureboot.rst +++ b/docs/kbase/secureboot.rst @@ -72,16 +72,36 @@ relevant documentation Changing an existing VM ======================= -Once the VM has been created, updating the XML configuration as -described above is **not** enough to change the Secure Boot status: -the NVRAM file associated with the VM has to be regenerated from its -template as well. +When a VM is defined, libvirt will pick the firmware that best +satisfies the provided criteria and record this information for use +on subsequent boots. The resulting XML configuration will look like +this: + +:: + + <os firmware='efi'> + <firmware> + <feature enabled='yes' name='enrolled-keys'/> + <feature enabled='yes' name='secure-boot'/> + </firmware> + <loader readonly='yes' secure='yes' type='pflash'>/usr/share/edk2/ovmf/OVMF_CODE.secboot.fd</loader> + <nvram template='/usr/share/edk2/ovmf/OVMF_VARS.secboot.fd'>/var/lib/libvirt/qemu/nvram/vm_VARS.fd</nvram> + </os> + +In order to force libvirt to repeat the firmware autoselection +process, it's necessary to remove the ``<loader>`` and ``<nvram>`` +elements. Failure to do so will likely result in an error. + +Note that updating the XML configuration as described above is +**not** enough to change the Secure Boot status: the NVRAM file +associated with the VM has to be regenerated from its template as +well. In order to do that, update the XML and then start the VM with :: - $ virsh start $vm --reset-nvram + $ virsh start vm --reset-nvram This option is only available starting with libvirt 8.1.0, so if your version of libvirt is older than that you will have to delete the -- 2.41.0

2 1

[PATCH-for-8.2] target/nios2: Deprecate the Nios II architecture
by Philippe Mathieu-Daudé 17 Nov '23

17 Nov '23

See commit 9ba1caf510 ("MAINTAINERS: Mark the Nios II CPU as orphan"), last contribution from Chris was in 2012 [1] and Marek in 2018 [2]. [1] https://lore.kernel.org/qemu-devel/1352607539-10455-2-git-send-email-crwulf… [2] https://lore.kernel.org/qemu-devel/805fc7b5-03f0-56d4-abfd-ed010d4fa769@den… Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> --- docs/about/deprecated.rst | 15 +++++++++++++++ hw/nios2/10m50_devboard.c | 1 + hw/nios2/generic_nommu.c | 1 + 3 files changed, 17 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 78550c07bf..f7aa556294 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -236,6 +236,16 @@ it. Since all recent x86 hardware from the past >10 years is capable of the 64-bit x86 extensions, a corresponding 64-bit OS should be used instead. +System emulator CPUs +-------------------- + +Nios II CPU (since 8.2) +''''''''''''''''''''''' + +The Nios II architecture is orphan. The ``nios2`` guest CPU support is +deprecated and will be removed in a future version of QEMU. + + System emulator machines ------------------------ @@ -254,6 +264,11 @@ These old machine types are quite neglected nowadays and thus might have various pitfalls with regards to live migration. Use a newer machine type instead. +Nios II ``10m50-ghrd`` and ``nios2-generic-nommu`` machines (since 8.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +The Nios II architecture is orphan. + Backend options --------------- diff --git a/hw/nios2/10m50_devboard.c b/hw/nios2/10m50_devboard.c index 952a0dc33e..6cb32f777b 100644 --- a/hw/nios2/10m50_devboard.c +++ b/hw/nios2/10m50_devboard.c @@ -160,6 +160,7 @@ static void nios2_10m50_ghrd_class_init(ObjectClass *oc, void *data) mc->desc = "Altera 10M50 GHRD Nios II design"; mc->init = nios2_10m50_ghrd_init; mc->is_default = true; + mc->deprecation_reason = "Nios II architecture is deprecated"; object_class_property_add_bool(oc, "vic", get_vic, set_vic); object_class_property_set_description(oc, "vic", diff --git a/hw/nios2/generic_nommu.c b/hw/nios2/generic_nommu.c index 48edb3ae37..defa16953f 100644 --- a/hw/nios2/generic_nommu.c +++ b/hw/nios2/generic_nommu.c @@ -95,6 +95,7 @@ static void nios2_generic_nommu_machine_init(struct MachineClass *mc) { mc->desc = "Generic NOMMU Nios II design"; mc->init = nios2_generic_nommu_init; + mc->deprecation_reason = "Nios II architecture is deprecated"; } DEFINE_MACHINE("nios2-generic-nommu", nios2_generic_nommu_machine_init); -- 2.41.0

6 5

[libvirt PATCH] rpc: Pass GPG_TTY and TERM environment variables
by Andrea Bolognani 17 Nov '23

17 Nov '23

gpg-agent can be used instead of ssh-agent to authenticate against an SSH server, but in order to do so the GPG_TTY and TERM environment variables need to be passed through. For obvious reasons, we avoid doing that when no_tty=1 is found in the connection URI. https://bugs.debian.org/843863 https://gitlab.com/libvirt/libvirt/-/merge_requests/290 Thanks: Guilhem Moulin <guilhem(a)guilhem.org> Thanks: Kunwu Chan <chentao(a)kylinos.cn> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/rpc/virnetsocket.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index b58f7a6b8f..151077c2dd 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -843,6 +843,11 @@ int virNetSocketNewConnectSSH(const char *nodename, virCommandAddEnvPass(cmd, "OPENSSL_CONF"); virCommandAddEnvPass(cmd, "DISPLAY"); virCommandAddEnvPass(cmd, "XAUTHORITY"); + if (!noTTY) { + /* Needed for gpg-agent's curses-based authentication prompt */ + virCommandAddEnvPass(cmd, "GPG_TTY"); + virCommandAddEnvPass(cmd, "TERM"); + } virCommandClearCaps(cmd); if (service) -- 2.41.0

2 1

[libvirt PATCH] qemu_snapshot: fix reverting to inactive snapshot
by Pavel Hrdina 16 Nov '23

16 Nov '23

When reverting to inactive snapshot updating the domain definition needs to happen after the new overlays are created otherwise qemu-img will correctly fail with error: Trying to create an image with the same filename as the backing file Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_snapshot.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 1962ba4027..5fc0b82e79 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -2157,13 +2157,20 @@ qemuSnapshotRevertExternalInactive(virDomainObj *vm, { virQEMUDriver *driver = QEMU_DOMAIN_PRIVATE(vm)->driver; g_autoptr(virBitmap) created = NULL; + int ret = -1; created = virBitmapNew(tmpsnapdef->ndisks); + if (qemuSnapshotCreateQcow2Files(driver, domdef, tmpsnapdef, created) < 0) + goto cleanup; + if (qemuSnapshotDomainDefUpdateDisk(domdef, tmpsnapdef, false) < 0) - return -1; + goto cleanup; - if (qemuSnapshotCreateQcow2Files(driver, domdef, tmpsnapdef, created) < 0) { + ret = 0; + + cleanup: + if (ret < 0 && created) { ssize_t bit = -1; virErrorPtr err = NULL; @@ -2180,11 +2187,9 @@ qemuSnapshotRevertExternalInactive(virDomainObj *vm, } virErrorRestore(&err); - - return -1; } - return 0; + return ret; } -- 2.41.0

2 1

[libvirt PATCH] qemu_snapshot: fix snapshot deletion that had multiple children
by Pavel Hrdina 16 Nov '23

16 Nov '23

When we revert to non-leaf snapshot and create new branch or branches the overlay in snapshot metadata is no longer usable as a disk source for deletion of that snapshot. We need to use other places to figure out the correct storage source. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/534 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_snapshot.c | 46 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 1962ba4027..ee06e72b11 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -2748,6 +2748,44 @@ qemuSnapshotGetDisksWithBackingStore(virDomainObj *vm, } +/** + * qemuSnapshotExternalGetSnapDiskSrc: + * @vm: domain object + * @snap: snapshot object + * @snapDisk: disk definition from snapshost + * + * Try to get actual disk source for @snapDisk as the source stored in + * snapshot metadata is not always the correct source we need to work with. + * This happens mainly after reverting to non-leaf snapshot and creating + * new branch with new snapshot. + * + * Returns disk source on success, NULL on error. + */ +static virStorageSource * +qemuSnapshotExternalGetSnapDiskSrc(virDomainObj *vm, + virDomainMomentObj *snap, + virDomainSnapshotDiskDef *snapDisk) +{ + virDomainDiskDef *disk = NULL; + + /* Should never happen when deleting external snapshot as for now we do + * not support this specific case for now. */ + if (snap->nchildren > 1) + return snapDisk->src; + + if (snap->first_child) { + disk = qemuDomainDiskByName(snap->first_child->def->dom, snapDisk->name); + } else if (virDomainSnapshotGetCurrent(vm->snapshots) == snap) { + disk = qemuDomainDiskByName(vm->def, snapDisk->name); + } + + if (disk) + return disk->src; + + return snapDisk->src; +} + + /** * qemuSnapshotDeleteExternalPrepareData: * @vm: domain object @@ -2802,18 +2840,22 @@ qemuSnapshotDeleteExternalPrepareData(virDomainObj *vm, } if (data->merge) { + virStorageSource *snapDiskSrc = NULL; + data->domDisk = qemuDomainDiskByName(vm->def, snapDisk->name); if (!data->domDisk) return -1; + snapDiskSrc = qemuSnapshotExternalGetSnapDiskSrc(vm, snap, data->snapDisk); + if (virDomainObjIsActive(vm)) { data->diskSrc = virStorageSourceChainLookupBySource(data->domDisk->src, - data->snapDisk->src, + snapDiskSrc, &data->prevDiskSrc); if (!data->diskSrc) return -1; - if (!virStorageSourceIsSameLocation(data->diskSrc, data->snapDisk->src)) { + if (!virStorageSourceIsSameLocation(data->diskSrc, snapDiskSrc)) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("VM disk source and snapshot disk source are not the same")); return -1; -- 2.41.0

2 1

[libvirt PATCH 0/3] Introduce VIR_MIGRATE_ASSUME_SHARED_STORAGE
by Andrea Bolognani 13 Nov '23

13 Nov '23

This was initially motivated by a KubeVirt issue[1] concerning integration with the Portworx storage provide, but it turns out to be more generally applicable: since mounting an NFS share on the same host that is exporting it is known to cause issues and is therefore not recommended, we need a way to allow migration in such a configuration while still not going quite as far as VIR_MIGRATE_UNSAFE does and losing all handrails. [1] https://issues.redhat.com/browse/CNV-34322 Andrea Bolognani (3): include: Introduce VIR_MIGRATE_ASSUME_SHARED_STORAGE qemu: Implement VIR_MIGRATE_ASSUME_SHARED_STORAGE support virsh: Wire up VIR_MIGRATE_ASSUME_SHARED_STORAGE support docs/manpages/virsh.rst | 5 ++++- include/libvirt/libvirt-domain.h | 14 ++++++++++++++ src/qemu/qemu_migration.c | 5 +++++ src/qemu/qemu_migration.h | 1 + tools/virsh-domain.c | 5 +++++ 5 files changed, 29 insertions(+), 1 deletion(-) -- 2.41.0

3 11

[v2 0/4] Support for dirty-limit live migration
by Hyman Huang 12 Nov '23

12 Nov '23

Hello, this is series version 2. Just certain that it won't be overlooked. Please review, thanks, Yong v2: - rebase on master v1: In qemu>=8.1, the dirty-limit functionality for live migration was included. In the live migration scenario, it implements the force convergence using the dirty-limit approach, which results in better reliable read performance. A straightforward dirty-limit capability for live migration is added by this patchset. Users might not care about other dirty-limit arguments like "x-vcpu-dirty-limit-period" or "vcpu-dirty-limit," thus do not expose them to Libvirt and leave the default settings in place. values as default. For more details about dirty-limit. please see the following reference: https://lore.kernel.org/qemu- devel/169024923116.19090.10825599068950039132-0(a)git.sr.ht/ Hyman Huang (4): Add VIR_MIGRATE_DIRTY_LIMIT flag qemu_migration: Implement VIR_MIGRATE_DIRTY_LIMIT flag virsh: Add support for VIR_MIGRATE_DIRTY_LIMIT flag NEWS: document support for dirty-limit live migration NEWS.rst | 8 ++++++++ docs/manpages/virsh.rst | 10 +++++++++- include/libvirt/libvirt-domain.h | 5 +++++ src/libvirt-domain.c | 8 ++++++++ src/qemu/qemu_migration.c | 8 ++++++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 6 ++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 10 ++++++++++ 9 files changed, 56 insertions(+), 1 deletion(-) -- 2.39.1

1 4

[libvirt PATCH 00/19] RFC: Add versioned CPUs to libvirt
by Jonathon Jongsma 10 Nov '23

10 Nov '23

This is not necessarily intended as a finished proposal, but as a discussion starter. I mentioned in an email last week that for SEV-SNP support we will need to be able to specify versioned CPU models that are not yet supported by libvirt. Rather than just adding a versioned CPU or two that would satisfy my immediate need, I decided to try to add versioned CPUs in a standard way. This involves adding the concept of an 'alias' for a CPU model in libvirt. Qemu already has the concept of a CPU alias for a versioned CPU. In fact, libvirt already provides a select subset of these as configurable CPU models (e.g. 'EPYC-IBPB'). After this patchset, these aliased CPU versions would be configurable by either their versioned name ('EPYC-v2') or their alias ('EPYC-IBPB'). And it would also provide non-aliased CPU versions as options within libvirt ('EPYC-v4'). Assuming that we want to offer all versioned CPUs like this, there are two approaches to naming. I chose to maintain the existing names (e.g. EPYC-IBPB) as the primary name where available, and use the versioned name (EPYC-v2) as the alias. However, some CPU models don't have an alias, so their versioned name would be their primary name. So we have the following set of 'EPYC' CPU models: - EPYC (alias = EPYC-v1) - EPYC-IBPB (alias = EPYC-v2) - EPYC-v3 (no alias) - EPYC-v4 (no alias) An alternative approach is something more like: - EPYC-v1 (alias = EPYC) - EPYC-v2 (alias = EPYC-IBPB) - EPYC-v3 (no alias) - EPYC-v4 (no alias) The naming of the second set is more consistent, but it could result in slight changes to behavior. For example, any call to cpuDecode() that returned EPYC-IBPB in the past might now return EPYC-v2. These two CPUs are just two different names for the same model, so I'm not sure it would result in any issues. But in this patch series I went with the first approach since it maintained stability and resulted in less churn in the test output. Note also that there are a couple of patches that update existing CPU models by re-running this script against the current qemu source code. For example, the patch "cpu_map: Update EPYC cpu definitions from qemu" results in some minor changes to the existing EPYC CPUs by adding a couple of feature flags. In theory, it seems like a good idea for our libvirt models to match how the model is defined in qemu, but I admit that I don't have a great understanding of whether this will result in undesirable side-effects. I'm hoping those of you with deeper knowledge will tell me why this is or is not a good idea. In the same vein, I've included the last patch of the series showing what it would look like if we regenerated all of the other CPU definitions from the qemu source code. Jonathon Jongsma (19): cpu_map: update script to generate versioned CPUs cpu: handle aliases in CPU definitions cpu_map: Update EPYC cpu definitions from qemu cpu_map: Add versioned EPYC CPUs cpu_map: Add versioned Intel Nehalem CPUs cpu_map: Add versioned Intel Westmere CPUs cpu_map: Add versioned Intel SandyBridge CPUs cpu_map: Add versioned Intel IvyBridge CPUs cpu_map: Add versioned Intel Haswell CPUs cpu_map: Add versioned Intel Broadwell CPUs cpu_map: Add versioned Intel Skylake CPUs cpu_map: Add versioned Intel Cascadelake CPUs cpu_map: Add versioned Intel Icelake CPUs cpu_map: Add versioned Intel Cooperlake CPUs cpu_map: Add versioned Intel Snowridge CPUs cpu_map: Add versioned Intel SapphireRapids CPUs cpu_map: Add versioned Dhyana CPUs cpu: advertise CPU aliases NOMERGE: RFC: regenerate all cpu definitions src/cpu/cpu_x86.c | 88 ++++++++---- src/cpu_map/index.xml | 22 +++ src/cpu_map/meson.build | 22 +++ src/cpu_map/sync_qemu_models_i386.py | 44 ++++-- src/cpu_map/x86_Broadwell-IBRS.xml | 19 ++- src/cpu_map/x86_Broadwell-noTSX-IBRS.xml | 19 ++- src/cpu_map/x86_Broadwell-noTSX.xml | 19 ++- src/cpu_map/x86_Broadwell.xml | 18 ++- src/cpu_map/x86_Cascadelake-Server-noTSX.xml | 19 ++- src/cpu_map/x86_Cascadelake-Server-v2.xml | 93 +++++++++++++ src/cpu_map/x86_Cascadelake-Server-v4.xml | 91 +++++++++++++ src/cpu_map/x86_Cascadelake-Server-v5.xml | 92 +++++++++++++ src/cpu_map/x86_Cascadelake-Server.xml | 11 +- src/cpu_map/x86_Cooperlake-v2.xml | 98 ++++++++++++++ src/cpu_map/x86_Cooperlake.xml | 9 +- src/cpu_map/x86_Dhyana-v2.xml | 81 ++++++++++++ src/cpu_map/x86_Dhyana.xml | 13 +- src/cpu_map/x86_EPYC-Genoa.xml | 7 + src/cpu_map/x86_EPYC-IBPB.xml | 14 +- src/cpu_map/x86_EPYC-Milan-v2.xml | 108 +++++++++++++++ src/cpu_map/x86_EPYC-Milan.xml | 8 ++ src/cpu_map/x86_EPYC-Rome-v2.xml | 93 +++++++++++++ src/cpu_map/x86_EPYC-Rome-v3.xml | 95 +++++++++++++ src/cpu_map/x86_EPYC-Rome-v4.xml | 94 +++++++++++++ src/cpu_map/x86_EPYC-Rome.xml | 9 ++ src/cpu_map/x86_EPYC-v3.xml | 87 ++++++++++++ src/cpu_map/x86_EPYC-v4.xml | 88 ++++++++++++ src/cpu_map/x86_EPYC.xml | 13 +- src/cpu_map/x86_Haswell-IBRS.xml | 20 ++- src/cpu_map/x86_Haswell-noTSX-IBRS.xml | 20 ++- src/cpu_map/x86_Haswell-noTSX.xml | 20 ++- src/cpu_map/x86_Haswell.xml | 18 ++- src/cpu_map/x86_Icelake-Server-noTSX.xml | 14 +- src/cpu_map/x86_Icelake-Server-v3.xml | 103 +++++++++++++++ src/cpu_map/x86_Icelake-Server-v4.xml | 108 +++++++++++++++ src/cpu_map/x86_Icelake-Server-v5.xml | 109 +++++++++++++++ src/cpu_map/x86_Icelake-Server-v6.xml | 109 +++++++++++++++ src/cpu_map/x86_Icelake-Server.xml | 11 +- src/cpu_map/x86_IvyBridge-IBRS.xml | 13 +- src/cpu_map/x86_IvyBridge.xml | 12 +- src/cpu_map/x86_Nehalem-IBRS.xml | 14 +- src/cpu_map/x86_Nehalem.xml | 13 +- src/cpu_map/x86_SandyBridge-IBRS.xml | 14 +- src/cpu_map/x86_SandyBridge.xml | 13 +- src/cpu_map/x86_SapphireRapids-v2.xml | 125 ++++++++++++++++++ src/cpu_map/x86_SapphireRapids.xml | 7 + src/cpu_map/x86_Skylake-Client-IBRS.xml | 16 ++- src/cpu_map/x86_Skylake-Client-noTSX-IBRS.xml | 18 +-- src/cpu_map/x86_Skylake-Client-v4.xml | 77 +++++++++++ src/cpu_map/x86_Skylake-Client.xml | 15 ++- src/cpu_map/x86_Skylake-Server-IBRS.xml | 12 +- src/cpu_map/x86_Skylake-Server-noTSX-IBRS.xml | 14 +- src/cpu_map/x86_Skylake-Server-v4.xml | 83 ++++++++++++ src/cpu_map/x86_Skylake-Server-v5.xml | 85 ++++++++++++ src/cpu_map/x86_Skylake-Server.xml | 12 +- src/cpu_map/x86_Snowridge-v2.xml | 78 +++++++++++ src/cpu_map/x86_Snowridge-v3.xml | 80 +++++++++++ src/cpu_map/x86_Snowridge-v4.xml | 78 +++++++++++ src/cpu_map/x86_Snowridge.xml | 10 +- src/cpu_map/x86_Westmere-IBRS.xml | 13 +- src/cpu_map/x86_Westmere.xml | 14 +- ...4-baseline-Westmere+Nehalem-migratable.xml | 4 +- ...86_64-baseline-Westmere+Nehalem-result.xml | 4 +- .../x86_64-baseline-features-expanded.xml | 1 + .../x86_64-baseline-features-result.xml | 2 - .../x86_64-baseline-simple-expanded.xml | 3 + .../x86_64-cpuid-Atom-P5362-guest.xml | 3 +- .../x86_64-cpuid-Atom-P5362-host.xml | 3 - .../x86_64-cpuid-Atom-P5362-json.xml | 3 +- .../x86_64-cpuid-Cooperlake-host.xml | 3 +- .../x86_64-cpuid-Core-i5-2500-guest.xml | 3 - .../x86_64-cpuid-Core-i5-2500-host.xml | 3 - .../x86_64-cpuid-Core-i5-2500-json.xml | 3 - .../x86_64-cpuid-Core-i5-2540M-guest.xml | 3 - .../x86_64-cpuid-Core-i5-2540M-host.xml | 3 - .../x86_64-cpuid-Core-i5-2540M-json.xml | 3 - .../x86_64-cpuid-Core-i5-4670T-guest.xml | 6 +- .../x86_64-cpuid-Core-i5-4670T-host.xml | 19 ++- .../x86_64-cpuid-Core-i5-4670T-json.xml | 6 +- .../x86_64-cpuid-Core-i5-650-guest.xml | 3 - .../x86_64-cpuid-Core-i5-650-host.xml | 3 - .../x86_64-cpuid-Core-i5-650-json.xml | 3 - .../x86_64-cpuid-Core-i5-6600-guest.xml | 1 + .../x86_64-cpuid-Core-i5-6600-host.xml | 1 + .../x86_64-cpuid-Core-i5-6600-json.xml | 1 + .../x86_64-cpuid-Core-i7-2600-guest.xml | 3 - .../x86_64-cpuid-Core-i7-2600-host.xml | 3 - .../x86_64-cpuid-Core-i7-2600-json.xml | 3 - ...6_64-cpuid-Core-i7-2600-xsaveopt-guest.xml | 2 - ...86_64-cpuid-Core-i7-2600-xsaveopt-host.xml | 9 +- ...86_64-cpuid-Core-i7-2600-xsaveopt-json.xml | 2 - .../x86_64-cpuid-Core-i7-3520M-guest.xml | 2 - .../x86_64-cpuid-Core-i7-3520M-host.xml | 2 - .../x86_64-cpuid-Core-i7-3740QM-guest.xml | 2 +- .../x86_64-cpuid-Core-i7-3740QM-host.xml | 13 +- .../x86_64-cpuid-Core-i7-3740QM-json.xml | 2 +- .../x86_64-cpuid-Core-i7-3770-guest.xml | 2 - .../x86_64-cpuid-Core-i7-3770-host.xml | 2 - .../x86_64-cpuid-Core-i7-3770-json.xml | 2 +- .../x86_64-cpuid-Core-i7-4510U-guest.xml | 6 - .../x86_64-cpuid-Core-i7-4510U-host.xml | 3 - .../x86_64-cpuid-Core-i7-4510U-json.xml | 6 - .../x86_64-cpuid-Core-i7-4600U-guest.xml | 6 - .../x86_64-cpuid-Core-i7-4600U-host.xml | 6 - .../x86_64-cpuid-Core-i7-4600U-json.xml | 6 - .../x86_64-cpuid-Core-i7-5600U-arat-guest.xml | 6 - .../x86_64-cpuid-Core-i7-5600U-arat-host.xml | 6 - .../x86_64-cpuid-Core-i7-5600U-arat-json.xml | 6 +- .../x86_64-cpuid-Core-i7-5600U-guest.xml | 6 - .../x86_64-cpuid-Core-i7-5600U-host.xml | 6 - .../x86_64-cpuid-Core-i7-5600U-ibrs-guest.xml | 6 - .../x86_64-cpuid-Core-i7-5600U-ibrs-host.xml | 6 - .../x86_64-cpuid-Core-i7-5600U-ibrs-json.xml | 6 - .../x86_64-cpuid-Core-i7-5600U-json.xml | 6 - .../x86_64-cpuid-Core-i7-7600U-guest.xml | 1 + .../x86_64-cpuid-Core-i7-7600U-host.xml | 1 + .../x86_64-cpuid-Core-i7-7600U-json.xml | 1 + .../x86_64-cpuid-Core-i7-7700-guest.xml | 1 + .../x86_64-cpuid-Core-i7-7700-host.xml | 1 + .../x86_64-cpuid-Core-i7-7700-json.xml | 1 + .../x86_64-cpuid-Core-i7-8550U-guest.xml | 5 +- .../x86_64-cpuid-Core-i7-8550U-host.xml | 4 +- .../x86_64-cpuid-Core-i7-8550U-json.xml | 5 +- .../x86_64-cpuid-Core-i7-8700-guest.xml | 1 + .../x86_64-cpuid-Core-i7-8700-host.xml | 1 + .../x86_64-cpuid-Core-i7-8700-json.xml | 1 + .../x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 - .../x86_64-cpuid-EPYC-7502-32-Core-host.xml | 5 +- .../x86_64-cpuid-EPYC-7502-32-Core-json.xml | 1 - .../x86_64-cpuid-EPYC-7601-32-Core-guest.xml | 9 +- .../x86_64-cpuid-EPYC-7601-32-Core-host.xml | 2 - ..._64-cpuid-EPYC-7601-32-Core-ibpb-guest.xml | 2 - ...6_64-cpuid-EPYC-7601-32-Core-ibpb-host.xml | 8 +- ...6_64-cpuid-EPYC-7601-32-Core-ibpb-json.xml | 3 - .../x86_64-cpuid-EPYC-7601-32-Core-json.xml | 3 - ..._64-cpuid-Hygon-C86-7185-32-core-guest.xml | 5 +- ...6_64-cpuid-Hygon-C86-7185-32-core-host.xml | 5 +- ...6_64-cpuid-Hygon-C86-7185-32-core-json.xml | 3 - .../x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 + .../x86_64-cpuid-Ice-Lake-Server-host.xml | 1 + .../x86_64-cpuid-Ice-Lake-Server-json.xml | 2 +- .../x86_64-cpuid-Pentium-P6100-guest.xml | 10 +- ...4-cpuid-Ryzen-7-1800X-Eight-Core-guest.xml | 9 +- ...64-cpuid-Ryzen-7-1800X-Eight-Core-host.xml | 2 - ...64-cpuid-Ryzen-7-1800X-Eight-Core-json.xml | 3 - ...6_64-cpuid-Ryzen-9-3900X-12-Core-guest.xml | 1 - ...86_64-cpuid-Ryzen-9-3900X-12-Core-host.xml | 1 - ...86_64-cpuid-Ryzen-9-3900X-12-Core-json.xml | 1 - .../x86_64-cpuid-Xeon-E3-1225-v5-guest.xml | 1 + .../x86_64-cpuid-Xeon-E3-1225-v5-host.xml | 1 + .../x86_64-cpuid-Xeon-E3-1225-v5-json.xml | 1 + .../x86_64-cpuid-Xeon-E3-1245-v5-guest.xml | 1 + .../x86_64-cpuid-Xeon-E3-1245-v5-host.xml | 1 + .../x86_64-cpuid-Xeon-E3-1245-v5-json.xml | 1 + .../x86_64-cpuid-Xeon-E5-2609-v3-guest.xml | 6 - .../x86_64-cpuid-Xeon-E5-2609-v3-host.xml | 6 - .../x86_64-cpuid-Xeon-E5-2609-v3-json.xml | 6 - .../x86_64-cpuid-Xeon-E5-2623-v4-guest.xml | 6 - .../x86_64-cpuid-Xeon-E5-2623-v4-host.xml | 6 - .../x86_64-cpuid-Xeon-E5-2623-v4-json.xml | 6 - .../x86_64-cpuid-Xeon-E5-2630-v3-guest.xml | 6 - .../x86_64-cpuid-Xeon-E5-2630-v3-host.xml | 6 - .../x86_64-cpuid-Xeon-E5-2630-v3-json.xml | 6 +- .../x86_64-cpuid-Xeon-E5-2630-v4-guest.xml | 6 - .../x86_64-cpuid-Xeon-E5-2630-v4-host.xml | 6 - .../x86_64-cpuid-Xeon-E5-2630-v4-json.xml | 6 - .../x86_64-cpuid-Xeon-E5-2650-guest.xml | 3 - .../x86_64-cpuid-Xeon-E5-2650-host.xml | 3 - .../x86_64-cpuid-Xeon-E5-2650-json.xml | 3 - .../x86_64-cpuid-Xeon-E5-2650-v3-guest.xml | 6 - .../x86_64-cpuid-Xeon-E5-2650-v3-host.xml | 6 - .../x86_64-cpuid-Xeon-E5-2650-v3-json.xml | 6 +- .../x86_64-cpuid-Xeon-E5-2650-v4-guest.xml | 6 - .../x86_64-cpuid-Xeon-E5-2650-v4-host.xml | 6 - .../x86_64-cpuid-Xeon-E5-2650-v4-json.xml | 6 - .../x86_64-cpuid-Xeon-E7-4820-guest.xml | 3 - .../x86_64-cpuid-Xeon-E7-4820-host.xml | 3 - .../x86_64-cpuid-Xeon-E7-4820-json.xml | 4 +- .../x86_64-cpuid-Xeon-E7-4830-guest.xml | 3 - .../x86_64-cpuid-Xeon-E7-4830-host.xml | 3 - .../x86_64-cpuid-Xeon-E7-4830-json.xml | 3 - .../x86_64-cpuid-Xeon-E7-8890-v3-guest.xml | 6 - .../x86_64-cpuid-Xeon-E7-8890-v3-host.xml | 6 - .../x86_64-cpuid-Xeon-E7-8890-v3-json.xml | 6 - .../x86_64-cpuid-Xeon-E7540-guest.xml | 1 - .../x86_64-cpuid-Xeon-E7540-host.xml | 1 - .../x86_64-cpuid-Xeon-E7540-json.xml | 1 - .../x86_64-cpuid-Xeon-Gold-5115-guest.xml | 2 +- .../x86_64-cpuid-Xeon-Gold-5115-host.xml | 2 +- .../x86_64-cpuid-Xeon-Gold-5115-json.xml | 2 + .../x86_64-cpuid-Xeon-Gold-6130-guest.xml | 2 +- .../x86_64-cpuid-Xeon-Gold-6130-host.xml | 2 +- .../x86_64-cpuid-Xeon-Gold-6130-json.xml | 2 +- .../x86_64-cpuid-Xeon-Gold-6148-guest.xml | 3 +- .../x86_64-cpuid-Xeon-Gold-6148-host.xml | 3 +- .../x86_64-cpuid-Xeon-Gold-6148-json.xml | 3 +- .../x86_64-cpuid-Xeon-Platinum-8268-guest.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-8268-host.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-8268-json.xml | 2 +- .../x86_64-cpuid-Xeon-Platinum-9242-guest.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-9242-host.xml | 9 +- .../x86_64-cpuid-Xeon-Platinum-9242-json.xml | 9 +- .../x86_64-cpuid-Xeon-W3520-guest.xml | 1 - .../x86_64-cpuid-Xeon-W3520-host.xml | 1 - .../x86_64-cpuid-Xeon-W3520-json.xml | 1 - ...id-baseline-Broadwell-IBRS+Cascadelake.xml | 6 - ..._64-cpuid-baseline-Cascadelake+Icelake.xml | 9 +- ...puid-baseline-Cascadelake+Skylake-IBRS.xml | 2 +- ..._64-cpuid-baseline-Cascadelake+Skylake.xml | 3 +- ...-cpuid-baseline-Cooperlake+Cascadelake.xml | 9 +- ...6_64-cpuid-baseline-Cooperlake+Icelake.xml | 9 +- .../x86_64-cpuid-baseline-EPYC+Rome.xml | 3 - .../x86_64-cpuid-baseline-Haswell+Skylake.xml | 6 - ...-baseline-Haswell-noTSX-IBRS+Broadwell.xml | 6 - ...seline-Haswell-noTSX-IBRS+Skylake-IBRS.xml | 6 - ...id-baseline-Haswell-noTSX-IBRS+Skylake.xml | 6 - .../x86_64-cpuid-baseline-Ryzen+Rome.xml | 3 - ...4-cpuid-baseline-Skylake-Client+Server.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 33 +++++ .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 32 +++++ tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 33 +++++ .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 37 ++++++ .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 36 +++++ tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 37 ++++++ .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 40 +++++- .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 39 ++++++ tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 40 +++++- .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 40 +++++- .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 39 ++++++ tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 40 +++++- .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 42 +++++- .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 41 ++++++ tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 42 +++++- .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 49 ++++++- .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 48 +++++++ tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 49 ++++++- .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 50 ++++++- .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 49 +++++++ tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 50 ++++++- .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 51 ++++++- .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 50 +++++++ tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 51 ++++++- .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 51 ++++++- .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 50 +++++++ tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 51 ++++++- .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 51 ++++++- .../qemu_7.2.0-tcg.x86_64+hvf.xml | 51 ++++++- .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 51 ++++++- tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 51 ++++++- .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 52 +++++++- .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 52 +++++++- tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 52 +++++++- .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 61 ++++++++- .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 57 +++++++- tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 61 ++++++++- .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 61 ++++++++- .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 57 +++++++- tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 61 ++++++++- ...-Icelake-Server-pconfig.x86_64-latest.args | 2 +- .../cpu-fallback.x86_64-5.2.0.args | 2 +- .../cpu-fallback.x86_64-8.0.0.args | 2 +- tests/qemuxml2argvdata/cpu-fallback.xml | 1 - .../cpu-host-model-fallback.x86_64-7.2.0.args | 2 +- .../cpu-host-model-fallback.x86_64-8.0.0.args | 2 +- ...cpu-host-model-fallback.x86_64-latest.args | 2 +- ...pu-host-model-nofallback.x86_64-7.2.0.args | 2 +- ...pu-host-model-nofallback.x86_64-8.0.0.args | 2 +- ...u-host-model-nofallback.x86_64-latest.args | 2 +- .../cpu-host-model.x86_64-4.2.0.args | 2 +- .../cpu-host-model.x86_64-5.0.0.args | 2 +- .../cpu-host-model.x86_64-5.1.0.args | 2 +- .../cpu-host-model.x86_64-5.2.0.args | 2 +- .../cpu-host-model.x86_64-6.0.0.args | 2 +- .../cpu-host-model.x86_64-6.1.0.args | 2 +- .../cpu-host-model.x86_64-6.2.0.args | 2 +- .../cpu-host-model.x86_64-7.0.0.args | 2 +- .../cpu-host-model.x86_64-7.1.0.args | 2 +- .../cpu-host-model.x86_64-7.2.0.args | 2 +- .../cpu-host-model.x86_64-8.0.0.args | 2 +- .../cpu-host-model.x86_64-latest.args | 2 +- .../cpu-nofallback.x86_64-8.0.0.args | 2 +- tests/qemuxml2argvdata/cpu-nofallback.xml | 1 - 282 files changed, 4591 insertions(+), 692 deletions(-) create mode 100644 src/cpu_map/x86_Cascadelake-Server-v2.xml create mode 100644 src/cpu_map/x86_Cascadelake-Server-v4.xml create mode 100644 src/cpu_map/x86_Cascadelake-Server-v5.xml create mode 100644 src/cpu_map/x86_Cooperlake-v2.xml create mode 100644 src/cpu_map/x86_Dhyana-v2.xml create mode 100644 src/cpu_map/x86_EPYC-Milan-v2.xml create mode 100644 src/cpu_map/x86_EPYC-Rome-v2.xml create mode 100644 src/cpu_map/x86_EPYC-Rome-v3.xml create mode 100644 src/cpu_map/x86_EPYC-Rome-v4.xml create mode 100644 src/cpu_map/x86_EPYC-v3.xml create mode 100644 src/cpu_map/x86_EPYC-v4.xml create mode 100644 src/cpu_map/x86_Icelake-Server-v3.xml create mode 100644 src/cpu_map/x86_Icelake-Server-v4.xml create mode 100644 src/cpu_map/x86_Icelake-Server-v5.xml create mode 100644 src/cpu_map/x86_Icelake-Server-v6.xml create mode 100644 src/cpu_map/x86_SapphireRapids-v2.xml create mode 100644 src/cpu_map/x86_Skylake-Client-v4.xml create mode 100644 src/cpu_map/x86_Skylake-Server-v4.xml create mode 100644 src/cpu_map/x86_Skylake-Server-v5.xml create mode 100644 src/cpu_map/x86_Snowridge-v2.xml create mode 100644 src/cpu_map/x86_Snowridge-v3.xml create mode 100644 src/cpu_map/x86_Snowridge-v4.xml -- 2.41.0

2 21

Versioned CPU types in libvirt
by Jonathon Jongsma 10 Nov '23

10 Nov '23

I'm currently looking at getting libvirt working with AMD's SEV-SNP encrypted virtualization technology. I have access to a test machine with an AMD EPYC 7713 processor which I can use to launch SNP guests with qemu, but only when I specify one of the following versioned -cpu values: - EPYC-v4 - EPYC-Milan-v2 - EPYC-Rome-v3 From what I understand, the unversioned CPU models in qemu are supposed to resolve to a specific versioned CPU model depending on the machine type. But I'm not exactly sure how machine type influences it. I've got some libvirt patches to launch an SEV-SNP guest working now except for the CPU model specification. As far as I can tell, I can currently only specify the un-versioned model in libvirt. Is there any way to request a particular versioned CPU from qemu? I feel like I'm missing something here. I should perhaps also mention that I'm running a development version of qemu from Cole's copr repo[1], which could still have some related bugs [1] https://copr.fedorainfracloud.org/coprs/g/virtmaint-sig/sev-snp-coconut/ Thanks, Jonathon

5 7

[libvirt PATCH] src: reject empty string for 'dname' in migrate APIs
by Daniel P. Berrangé 10 Nov '23

10 Nov '23

A domain name is expected to be non-empty, and we validate this when parsing XML, or accepting a new name during renames. We fail to enforce this property, however, when performing a migration. This was discovered when a user complained about inaccessible VMs after migrating with the Rust APIs which mistakenly hardcoded 'dname' to the empty string. Fixes: https://gitlab.com/libvirt/libvirt-rust/-/issues/11 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/internal.h | 14 +++++++ src/libvirt-domain.c | 97 +++++++++++++++++++++++++++++++++++++++----- 2 files changed, 100 insertions(+), 11 deletions(-) diff --git a/src/internal.h b/src/internal.h index 5a9e1c7cd0..01860efad9 100644 --- a/src/internal.h +++ b/src/internal.h @@ -441,6 +441,20 @@ goto label; \ } \ } while (0) +#define virCheckNonEmptyOptStringArgGoto(argname, label) \ + do { \ + if (argname && *argname == '\0') { \ + virReportInvalidEmptyStringArg(argname); \ + goto label; \ + } \ + } while (0) +#define virCheckNonEmptyOptStringArgReturn(argname, retval) \ + do { \ + if (argname && *argname == '\0') { \ + virReportInvalidEmptyStringArg(argname); \ + return retval; \ + } \ + } while (0) #define virCheckPositiveArgGoto(argname, label) \ do { \ if (argname <= 0) { \ diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 58e1e5ea8d..77a9682ecb 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -2991,6 +2991,8 @@ virDomainMigrateVersion1(virDomainPtr domain, "dconn=%p, flags=0x%lx, dname=%s, uri=%s, bandwidth=%lu", dconn, flags, NULLSTR(dname), NULLSTR(uri), bandwidth); + virCheckNonEmptyOptStringArgReturn(dname, NULL); + ret = virDomainGetInfo(domain, &info); if (ret == 0 && info.state == VIR_DOMAIN_PAUSED) flags |= VIR_MIGRATE_PAUSED; @@ -3085,6 +3087,8 @@ virDomainMigrateVersion2(virDomainPtr domain, "dconn=%p, flags=0x%lx, dname=%s, uri=%s, bandwidth=%lu", dconn, flags, NULLSTR(dname), NULLSTR(uri), bandwidth); + virCheckNonEmptyOptStringArgReturn(dname, NULL); + /* Prepare the migration. * * The destination host may return a cookie, or leave cookie as @@ -3242,6 +3246,8 @@ virDomainMigrateVersion3Full(virDomainPtr domain, bandwidth, params, nparams, useParams, flags); VIR_TYPED_PARAMS_DEBUG(params, nparams); + virCheckNonEmptyOptStringArgReturn(dname, NULL); + if ((!useParams && (!domain->conn->driver->domainMigrateBegin3 || !domain->conn->driver->domainMigratePerform3 || @@ -3582,6 +3588,8 @@ virDomainMigrateUnmanagedProto2(virDomainPtr domain, return -1; } + virCheckNonEmptyOptStringArgReturn(dname, -1); + if (flags & VIR_MIGRATE_PEER2PEER) { if (miguri) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -3632,6 +3640,8 @@ virDomainMigrateUnmanagedProto3(virDomainPtr domain, return -1; } + virCheckNonEmptyOptStringArgReturn(dname, -1); + return domain->conn->driver->domainMigratePerform3 (domain, xmlin, NULL, 0, NULL, NULL, dconnuri, miguri, flags, dname, bandwidth); @@ -3802,6 +3812,8 @@ virDomainMigrate(virDomainPtr domain, virCheckConnectGoto(dconn, error); virCheckReadOnlyGoto(dconn->flags, error); + virCheckNonEmptyOptStringArgReturn(dname, NULL); + VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_NON_SHARED_DISK, VIR_MIGRATE_NON_SHARED_INC, error); @@ -3999,6 +4011,8 @@ virDomainMigrate2(virDomainPtr domain, virCheckConnectGoto(dconn, error); virCheckReadOnlyGoto(dconn->flags, error); + virCheckNonEmptyOptStringArgReturn(dname, NULL); + VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_NON_SHARED_DISK, VIR_MIGRATE_NON_SHARED_INC, error); @@ -4232,6 +4246,19 @@ virDomainMigrate3(virDomainPtr domain, goto error; } + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_URI, &uri) < 0 || + virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, &dname) < 0 || + virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_XML, &dxml) < 0 || + virTypedParamsGetULLong(params, nparams, + VIR_MIGRATE_PARAM_BANDWIDTH, &bandwidth) < 0) { + goto error; + } + + virCheckNonEmptyOptStringArgReturn(dname, NULL); + if (flags & VIR_MIGRATE_OFFLINE) { rc = VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE); @@ -4293,17 +4320,6 @@ virDomainMigrate3(virDomainPtr domain, goto error; } - if (virTypedParamsGetString(params, nparams, - VIR_MIGRATE_PARAM_URI, &uri) < 0 || - virTypedParamsGetString(params, nparams, - VIR_MIGRATE_PARAM_DEST_NAME, &dname) < 0 || - virTypedParamsGetString(params, nparams, - VIR_MIGRATE_PARAM_DEST_XML, &dxml) < 0 || - virTypedParamsGetULLong(params, nparams, - VIR_MIGRATE_PARAM_BANDWIDTH, &bandwidth) < 0) { - goto error; - } - rc_src = VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_V3); if (rc_src < 0) @@ -4475,6 +4491,7 @@ virDomainMigrateToURI(virDomainPtr domain, virCheckDomainReturn(domain, -1); virCheckReadOnlyGoto(domain->conn->flags, error); virCheckNonNullArgGoto(duri, error); + virCheckNonEmptyOptStringArgGoto(dname, error); VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_TUNNELLED, VIR_MIGRATE_PARALLEL, @@ -4554,6 +4571,8 @@ virDomainMigrateToURI2(virDomainPtr domain, virCheckDomainReturn(domain, -1); virCheckReadOnlyGoto(domain->conn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); + VIR_EXCLUSIVE_FLAGS_GOTO(VIR_MIGRATE_TUNNELLED, VIR_MIGRATE_PARALLEL, error); @@ -4679,6 +4698,7 @@ virDomainMigratePrepare(virConnectPtr dconn, virCheckConnectReturn(dconn, -1); virCheckReadOnlyGoto(dconn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (dconn->driver->domainMigratePrepare) { int ret; @@ -4723,6 +4743,7 @@ virDomainMigratePerform(virDomainPtr domain, conn = domain->conn; virCheckReadOnlyGoto(conn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (conn->driver->domainMigratePerform) { int ret; @@ -4762,6 +4783,7 @@ virDomainMigrateFinish(virConnectPtr dconn, virCheckConnectReturn(dconn, NULL); virCheckReadOnlyGoto(dconn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (dconn->driver->domainMigrateFinish) { virDomainPtr ret; @@ -4805,6 +4827,7 @@ virDomainMigratePrepare2(virConnectPtr dconn, virCheckConnectReturn(dconn, -1); virCheckReadOnlyGoto(dconn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (dconn->driver->domainMigratePrepare2) { int ret; @@ -4846,6 +4869,7 @@ virDomainMigrateFinish2(virConnectPtr dconn, virCheckConnectReturn(dconn, NULL); virCheckReadOnlyGoto(dconn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (dconn->driver->domainMigrateFinish2) { virDomainPtr ret; @@ -4886,6 +4910,7 @@ virDomainMigratePrepareTunnel(virConnectPtr conn, virCheckConnectReturn(conn, -1); virCheckReadOnlyGoto(conn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (conn != st->conn) { virReportInvalidArg(conn, "%s", @@ -4936,6 +4961,7 @@ virDomainMigrateBegin3(virDomainPtr domain, conn = domain->conn; virCheckReadOnlyGoto(conn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (conn->driver->domainMigrateBegin3) { char *xml; @@ -4983,6 +5009,7 @@ virDomainMigratePrepare3(virConnectPtr dconn, virCheckConnectReturn(dconn, -1); virCheckReadOnlyGoto(dconn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (dconn->driver->domainMigratePrepare3) { int ret; @@ -5031,6 +5058,7 @@ virDomainMigratePrepareTunnel3(virConnectPtr conn, virCheckConnectReturn(conn, -1); virCheckReadOnlyGoto(conn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (conn != st->conn) { virReportInvalidArg(conn, "%s", @@ -5089,6 +5117,7 @@ virDomainMigratePerform3(virDomainPtr domain, conn = domain->conn; virCheckReadOnlyGoto(conn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (conn->driver->domainMigratePerform3) { int ret; @@ -5135,6 +5164,7 @@ virDomainMigrateFinish3(virConnectPtr dconn, virCheckConnectReturn(dconn, NULL); virCheckReadOnlyGoto(dconn->flags, error); + virCheckNonEmptyOptStringArgGoto(dname, error); if (dconn->driver->domainMigrateFinish3) { virDomainPtr ret; @@ -5211,6 +5241,7 @@ virDomainMigrateBegin3Params(virDomainPtr domain, unsigned int flags) { virConnectPtr conn; + const char *dname = NULL; VIR_DOMAIN_DEBUG(domain, "params=%p, nparams=%d, " "cookieout=%p, cookieoutlen=%p, flags=0x%x", @@ -5224,6 +5255,12 @@ virDomainMigrateBegin3Params(virDomainPtr domain, virCheckReadOnlyGoto(conn->flags, error); + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, &dname) < 0) + goto error; + + virCheckNonEmptyOptStringArgGoto(dname, error); + if (conn->driver->domainMigrateBegin3Params) { char *xml; xml = conn->driver->domainMigrateBegin3Params(domain, params, nparams, @@ -5258,6 +5295,8 @@ virDomainMigratePrepare3Params(virConnectPtr dconn, char **uri_out, unsigned int flags) { + const char *dname = NULL; + VIR_DEBUG("dconn=%p, params=%p, nparams=%d, cookiein=%p, cookieinlen=%d, " "cookieout=%p, cookieoutlen=%p, uri_out=%p, flags=0x%x", dconn, params, nparams, cookiein, cookieinlen, @@ -5269,6 +5308,12 @@ virDomainMigratePrepare3Params(virConnectPtr dconn, virCheckConnectReturn(dconn, -1); virCheckReadOnlyGoto(dconn->flags, error); + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, &dname) < 0) + goto error; + + virCheckNonEmptyOptStringArgGoto(dname, error); + if (dconn->driver->domainMigratePrepare3Params) { int ret; ret = dconn->driver->domainMigratePrepare3Params(dconn, params, nparams, @@ -5303,6 +5348,8 @@ virDomainMigratePrepareTunnel3Params(virConnectPtr conn, int *cookieoutlen, unsigned int flags) { + const char *dname = NULL; + VIR_DEBUG("conn=%p, stream=%p, params=%p, nparams=%d, cookiein=%p, " "cookieinlen=%d, cookieout=%p, cookieoutlen=%p, flags=0x%x", conn, st, params, nparams, cookiein, cookieinlen, @@ -5320,6 +5367,12 @@ virDomainMigratePrepareTunnel3Params(virConnectPtr conn, goto error; } + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, &dname) < 0) + goto error; + + virCheckNonEmptyOptStringArgGoto(dname, error); + if (conn->driver->domainMigratePrepareTunnel3Params) { int rv; rv = conn->driver->domainMigratePrepareTunnel3Params( @@ -5354,6 +5407,7 @@ virDomainMigratePerform3Params(virDomainPtr domain, unsigned int flags) { virConnectPtr conn; + const char *dname = NULL; VIR_DOMAIN_DEBUG(domain, "dconnuri=%s, params=%p, nparams=%d, cookiein=%p, " "cookieinlen=%d, cookieout=%p, cookieoutlen=%p, flags=0x%x", @@ -5368,6 +5422,12 @@ virDomainMigratePerform3Params(virDomainPtr domain, virCheckReadOnlyGoto(conn->flags, error); + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, &dname) < 0) + goto error; + + virCheckNonEmptyOptStringArgGoto(dname, error); + if (conn->driver->domainMigratePerform3Params) { int ret; ret = conn->driver->domainMigratePerform3Params( @@ -5401,6 +5461,8 @@ virDomainMigrateFinish3Params(virConnectPtr dconn, unsigned int flags, int cancelled) { + const char *dname = NULL; + VIR_DEBUG("dconn=%p, params=%p, nparams=%d, cookiein=%p, cookieinlen=%d, " "cookieout=%p, cookieoutlen=%p, flags=0x%x, cancelled=%d", dconn, params, nparams, cookiein, cookieinlen, cookieout, @@ -5412,6 +5474,12 @@ virDomainMigrateFinish3Params(virConnectPtr dconn, virCheckConnectReturn(dconn, NULL); virCheckReadOnlyGoto(dconn->flags, error); + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, &dname) < 0) + goto error; + + virCheckNonEmptyOptStringArgGoto(dname, error); + if (dconn->driver->domainMigrateFinish3Params) { virDomainPtr ret; ret = dconn->driver->domainMigrateFinish3Params( @@ -5444,6 +5512,7 @@ virDomainMigrateConfirm3Params(virDomainPtr domain, int cancelled) { virConnectPtr conn; + const char *dname = NULL; VIR_DOMAIN_DEBUG(domain, "params=%p, nparams=%d, cookiein=%p, " "cookieinlen=%d, flags=0x%x, cancelled=%d", @@ -5457,6 +5526,12 @@ virDomainMigrateConfirm3Params(virDomainPtr domain, virCheckReadOnlyGoto(conn->flags, error); + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, &dname) < 0) + goto error; + + virCheckNonEmptyOptStringArgGoto(dname, error); + if (conn->driver->domainMigrateConfirm3Params) { int ret; ret = conn->driver->domainMigrateConfirm3Params( -- 2.41.0

2 1

[PATCH 0/6] qemucapabilitiestest: Bump 8.2 dev cycle data
by Peter Krempa 10 Nov '23

10 Nov '23

Peter Krempa (6): qemumigrationcookiexmltest: Don't crash when parsing of status XML fails tests: qemumigparamsdata: Drop deprecated fields qemuxml2argvtest: Rename 'cpu-host-model' tests according to emulation type qemuxml2argvtest: Add complementary 'kvm/tcg' test cases for cpu-host-model* qemuxml2argvtest: Add '8.1.0' variants of 'cpu-host-model*' tests qemucapabilitiestest: Update capabilities data for 8.2 dev cycle on x86_64 .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 1 - .../caps_8.2.0_x86_64.replies | 4365 +++++++++-------- .../caps_8.2.0_x86_64.xml | 53 +- tests/qemumigparamsdata/basic.json | 3 - tests/qemumigparamsdata/basic.reply | 3 - tests/qemumigparamsdata/basic.xml | 3 - tests/qemumigparamsdata/tls-enabled.json | 3 - tests/qemumigparamsdata/tls-enabled.reply | 3 - tests/qemumigparamsdata/tls-enabled.xml | 3 - tests/qemumigparamsdata/tls-hostname.json | 3 - tests/qemumigparamsdata/tls-hostname.reply | 3 - tests/qemumigparamsdata/tls-hostname.xml | 3 - tests/qemumigparamsdata/tls.json | 3 - tests/qemumigparamsdata/tls.reply | 3 - tests/qemumigparamsdata/tls.xml | 3 - tests/qemumigrationcookiexmltest.c | 16 +- ...-host-model-fallback-kvm.x86_64-4.2.0.args | 33 + ...-host-model-fallback-kvm.x86_64-5.0.0.args | 33 + ...-host-model-fallback-kvm.x86_64-5.1.0.args | 33 + ...-host-model-fallback-kvm.x86_64-5.2.0.args | 34 + ...-host-model-fallback-kvm.x86_64-6.0.0.args | 34 + ...-host-model-fallback-kvm.x86_64-6.1.0.args | 34 + ...-host-model-fallback-kvm.x86_64-6.2.0.args | 34 + ...-host-model-fallback-kvm.x86_64-7.0.0.args | 34 + ...-host-model-fallback-kvm.x86_64-7.1.0.args | 34 + ...-host-model-fallback-kvm.x86_64-7.2.0.args | 34 + ...-host-model-fallback-kvm.x86_64-8.0.0.args | 33 + ...-host-model-fallback-kvm.x86_64-8.1.0.args | 33 + ...host-model-fallback-kvm.x86_64-latest.args | 33 + .../cpu-host-model-fallback-kvm.xml | 19 + ...host-model-fallback-tcg.x86_64-4.2.0.args} | 0 ...host-model-fallback-tcg.x86_64-5.0.0.args} | 0 ...host-model-fallback-tcg.x86_64-5.1.0.args} | 0 ...host-model-fallback-tcg.x86_64-5.2.0.args} | 0 ...host-model-fallback-tcg.x86_64-6.0.0.args} | 0 ...host-model-fallback-tcg.x86_64-6.1.0.args} | 0 ...host-model-fallback-tcg.x86_64-6.2.0.args} | 0 ...host-model-fallback-tcg.x86_64-7.0.0.args} | 0 ...host-model-fallback-tcg.x86_64-7.1.0.args} | 0 ...host-model-fallback-tcg.x86_64-7.2.0.args} | 0 ...host-model-fallback-tcg.x86_64-8.0.0.args} | 0 ...host-model-fallback-tcg.x86_64-8.1.0.args} | 2 +- ...host-model-fallback-tcg.x86_64-latest.args | 33 + ...ck.xml => cpu-host-model-fallback-tcg.xml} | 0 ...s => cpu-host-model-kvm.x86_64-4.2.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-5.0.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-5.1.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-5.2.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-6.0.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-6.1.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-6.2.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-7.0.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-7.1.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-7.2.0.args} | 0 ...s => cpu-host-model-kvm.x86_64-8.0.0.args} | 0 .../cpu-host-model-kvm.x86_64-8.1.0.args | 38 + ... => cpu-host-model-kvm.x86_64-latest.args} | 0 ...-host-model.xml => cpu-host-model-kvm.xml} | 0 ...ost-model-nofallback-kvm.x86_64-4.2.0.args | 33 + ...ost-model-nofallback-kvm.x86_64-5.0.0.args | 33 + ...ost-model-nofallback-kvm.x86_64-5.1.0.args | 33 + ...ost-model-nofallback-kvm.x86_64-5.2.0.args | 34 + ...ost-model-nofallback-kvm.x86_64-6.0.0.args | 34 + ...ost-model-nofallback-kvm.x86_64-6.1.0.args | 34 + ...ost-model-nofallback-kvm.x86_64-6.2.0.args | 34 + ...ost-model-nofallback-kvm.x86_64-7.0.0.args | 34 + ...ost-model-nofallback-kvm.x86_64-7.1.0.args | 34 + ...ost-model-nofallback-kvm.x86_64-7.2.0.args | 34 + ...ost-model-nofallback-kvm.x86_64-8.0.0.args | 33 + ...ost-model-nofallback-kvm.x86_64-8.1.0.args | 33 + ...st-model-nofallback-kvm.x86_64-latest.args | 33 + .../cpu-host-model-nofallback-kvm.xml | 21 + ...st-model-nofallback-tcg.x86_64-4.2.0.args} | 0 ...st-model-nofallback-tcg.x86_64-5.0.0.args} | 0 ...st-model-nofallback-tcg.x86_64-5.1.0.args} | 0 ...st-model-nofallback-tcg.x86_64-5.2.0.args} | 0 ...st-model-nofallback-tcg.x86_64-6.0.0.args} | 0 ...st-model-nofallback-tcg.x86_64-6.1.0.args} | 0 ...st-model-nofallback-tcg.x86_64-6.2.0.args} | 0 ...st-model-nofallback-tcg.x86_64-7.0.0.args} | 0 ...st-model-nofallback-tcg.x86_64-7.1.0.args} | 0 ...st-model-nofallback-tcg.x86_64-7.2.0.args} | 0 ...st-model-nofallback-tcg.x86_64-8.0.0.args} | 0 ...st-model-nofallback-tcg.x86_64-8.1.0.args} | 2 +- ...st-model-nofallback-tcg.x86_64-latest.args | 33 + ....xml => cpu-host-model-nofallback-tcg.xml} | 0 .../cpu-host-model-tcg.x86_64-4.2.0.args | 38 + .../cpu-host-model-tcg.x86_64-5.0.0.args | 38 + .../cpu-host-model-tcg.x86_64-5.1.0.args | 38 + .../cpu-host-model-tcg.x86_64-5.2.0.args | 39 + .../cpu-host-model-tcg.x86_64-6.0.0.args | 39 + .../cpu-host-model-tcg.x86_64-6.1.0.args | 39 + .../cpu-host-model-tcg.x86_64-6.2.0.args | 39 + .../cpu-host-model-tcg.x86_64-7.0.0.args | 39 + .../cpu-host-model-tcg.x86_64-7.1.0.args | 39 + .../cpu-host-model-tcg.x86_64-7.2.0.args | 39 + .../cpu-host-model-tcg.x86_64-8.0.0.args | 38 + .../cpu-host-model-tcg.x86_64-8.1.0.args | 38 + .../cpu-host-model-tcg.x86_64-latest.args | 38 + tests/qemuxml2argvdata/cpu-host-model-tcg.xml | 21 + tests/qemuxml2argvtest.c | 122 +- 101 files changed, 4025 insertions(+), 2110 deletions(-) create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-4.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-5.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-6.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-8.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-8.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-kvm.xml rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-4.2.0.args => cpu-host-model-fallback-tcg.x86_64-4.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-5.0.0.args => cpu-host-model-fallback-tcg.x86_64-5.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-5.1.0.args => cpu-host-model-fallback-tcg.x86_64-5.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-5.2.0.args => cpu-host-model-fallback-tcg.x86_64-5.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-6.0.0.args => cpu-host-model-fallback-tcg.x86_64-6.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-6.1.0.args => cpu-host-model-fallback-tcg.x86_64-6.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-6.2.0.args => cpu-host-model-fallback-tcg.x86_64-6.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-7.0.0.args => cpu-host-model-fallback-tcg.x86_64-7.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-7.1.0.args => cpu-host-model-fallback-tcg.x86_64-7.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-7.2.0.args => cpu-host-model-fallback-tcg.x86_64-7.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-8.0.0.args => cpu-host-model-fallback-tcg.x86_64-8.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.x86_64-latest.args => cpu-host-model-fallback-tcg.x86_64-8.1.0.args} (95%) create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback-tcg.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-host-model-fallback.xml => cpu-host-model-fallback-tcg.xml} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-4.2.0.args => cpu-host-model-kvm.x86_64-4.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-5.0.0.args => cpu-host-model-kvm.x86_64-5.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-5.1.0.args => cpu-host-model-kvm.x86_64-5.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-5.2.0.args => cpu-host-model-kvm.x86_64-5.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-6.0.0.args => cpu-host-model-kvm.x86_64-6.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-6.1.0.args => cpu-host-model-kvm.x86_64-6.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-6.2.0.args => cpu-host-model-kvm.x86_64-6.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-7.0.0.args => cpu-host-model-kvm.x86_64-7.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-7.1.0.args => cpu-host-model-kvm.x86_64-7.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-7.2.0.args => cpu-host-model-kvm.x86_64-7.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-8.0.0.args => cpu-host-model-kvm.x86_64-8.0.0.args} (100%) create mode 100644 tests/qemuxml2argvdata/cpu-host-model-kvm.x86_64-8.1.0.args rename tests/qemuxml2argvdata/{cpu-host-model.x86_64-latest.args => cpu-host-model-kvm.x86_64-latest.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model.xml => cpu-host-model-kvm.xml} (100%) create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-4.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-5.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-6.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-8.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-8.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-kvm.xml rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-4.2.0.args => cpu-host-model-nofallback-tcg.x86_64-4.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-5.0.0.args => cpu-host-model-nofallback-tcg.x86_64-5.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-5.1.0.args => cpu-host-model-nofallback-tcg.x86_64-5.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-5.2.0.args => cpu-host-model-nofallback-tcg.x86_64-5.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-6.0.0.args => cpu-host-model-nofallback-tcg.x86_64-6.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-6.1.0.args => cpu-host-model-nofallback-tcg.x86_64-6.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-6.2.0.args => cpu-host-model-nofallback-tcg.x86_64-6.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-7.0.0.args => cpu-host-model-nofallback-tcg.x86_64-7.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-7.1.0.args => cpu-host-model-nofallback-tcg.x86_64-7.1.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-7.2.0.args => cpu-host-model-nofallback-tcg.x86_64-7.2.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-8.0.0.args => cpu-host-model-nofallback-tcg.x86_64-8.0.0.args} (100%) rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.x86_64-latest.args => cpu-host-model-nofallback-tcg.x86_64-8.1.0.args} (95%) create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback-tcg.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-host-model-nofallback.xml => cpu-host-model-nofallback-tcg.xml} (100%) create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-4.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-5.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-6.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-8.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-8.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-tcg.xml -- 2.41.0

2 7

[libvirt PATCH] qemu: add runtime config option for nbdkit
by Jonathon Jongsma 09 Nov '23

09 Nov '23

Currently when we build with nbdkit support, libvirt will always try to use nbdkit to access remote disk sources when it is available. But without an up-to-date selinux policy allowing this, it will fail. Because the required selinux policies are not yet widely available, we have disabled nbdkit support on rpm builds for all distributions before Fedora 40. Unfortunately, this makes it more difficult to test nbdkit support. After someone updates to the necessary selinux policies, they would also need to rebuild libvirt to enable nbdkit support. By introducing a configure option (storage_use_nbdkit), we can build packages with nbdkit support but have it disabled by default. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- Suggested as an option for making testing easier by Andrea Bolognani libvirt.spec.in | 10 +--------- src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/qemu.conf.in | 10 ++++++++++ src/qemu/qemu_conf.c | 14 ++++++++++++++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_domain.c | 3 +++ tests/qemuxml2argvtest.c | 15 +++++++++------ 7 files changed, 42 insertions(+), 15 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index f50c451e73..e2ba245ade 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -174,16 +174,8 @@ %endif %endif -# We should only enable nbdkit support if the OS ships a SELinux policy that -# allows libvirt to launch it. Right now that's not the case anywhere, but -# things should be fine by the time Fedora 40 is released. -# -# TODO: add RHEL 9 once a minor release that contains the necessary SELinux -# bits exists (we only support the most recent minor release) %if %{with_qemu} - %if 0%{?fedora} >= 40 - %define with_nbdkit 0%{!?_without_nbdkit:1} - %endif + %define with_nbdkit 0%{!?_without_nbdkit:1} %endif %ifarch %{arches_dmidecode} diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index ed097ea3d9..43485b43fb 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -147,6 +147,8 @@ module Libvirtd_qemu = let capability_filters_entry = str_array_entry "capability_filters" + let storage_entry = bool_entry "storage_use_nbdkit" + (* Each entry in the config is one of the following ... *) let entry = default_tls_entry | vnc_entry @@ -170,6 +172,7 @@ module Libvirtd_qemu = | nbd_entry | swtpm_entry | capability_filters_entry + | storage_entry | obsolete_entry let comment = [ label "#comment" . del /#[ \t]*/ "# " . store /([^ \t\n][^\n]*)?/ . del /\n/ "\n" ] diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 6897e0f760..1017edefa5 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -974,3 +974,13 @@ # "full" - both QEMU and its helper processes are placed into separate # scheduling group #sched_core = "none" + +# Using nbdkit to access remote disk sources +# +# If this is set then libvirt will use nbdkit to access remote disk sources +# when available. nbdkit will export an NBD share to qemu rather than having +# qemu attempt access the remote server directly. +# +# Possible values are 0 or 1. Disabled by default. +# +# storage_use_nbdkit = 1 diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 513b5ebb1e..b5c0ca10b4 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1065,6 +1065,17 @@ virQEMUDriverConfigLoadCapsFiltersEntry(virQEMUDriverConfig *cfg, } +static int +virQEMUDriverConfigLoadStorageEntry(virQEMUDriverConfig *cfg, + virConf *conf) +{ + if (virConfGetValueBool(conf, "storage_use_nbdkit", &cfg->storageUseNbdkit) < 0) + return -1; + + return 0; +} + + int virQEMUDriverConfigLoadFile(virQEMUDriverConfig *cfg, const char *filename, bool privileged) @@ -1136,6 +1147,9 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfig *cfg, if (virQEMUDriverConfigLoadCapsFiltersEntry(cfg, conf) < 0) return -1; + if (virQEMUDriverConfigLoadStorageEntry(cfg, conf) < 0) + return -1; + return 0; } diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 1a3ba3a0fb..36049b4bfa 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -230,6 +230,8 @@ struct _virQEMUDriverConfig { char *deprecationBehavior; + bool storageUseNbdkit; + virQEMUSchedCore schedCore; }; diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ae19ce884b..f8dda6c898 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -10333,6 +10333,9 @@ qemuDomainPrepareStorageSourceNbdkit(virStorageSource *src, { g_autoptr(qemuNbdkitCaps) nbdkit = NULL; + if (!cfg->storageUseNbdkit) + return false; + if (virStorageSourceGetActualType(src) != VIR_STORAGE_TYPE_NETWORK) return false; diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 4fda68a4ce..3c64fcc7eb 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1115,7 +1115,6 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-cdrom-empty-network-invalid"); DO_TEST_CAPS_LATEST("disk-cdrom-bus-other"); DO_TEST_CAPS_LATEST("disk-cdrom-network"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); DO_TEST_CAPS_LATEST("disk-cdrom-tray"); DO_TEST_CAPS_LATEST("disk-floppy"); DO_TEST_CAPS_LATEST("disk-floppy-q35"); @@ -1161,8 +1160,6 @@ mymain(void) DO_TEST_CAPS_VER("disk-network-sheepdog", "6.0.0"); DO_TEST_CAPS_LATEST("disk-network-source-auth"); DO_TEST_CAPS_LATEST("disk-network-source-curl"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit-backing", QEMU_NBDKIT_CAPS_PLUGIN_CURL); DO_TEST_CAPS_LATEST("disk-network-nfs"); driver.config->vxhsTLS = 1; driver.config->nbdTLSx509secretUUID = g_strdup("6fd3f62d-9fe7-4a4e-a869-7acd6376d8ea"); @@ -1173,13 +1170,10 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-network-tlsx509-nbd-hostname"); DO_TEST_CAPS_VER("disk-network-tlsx509-vxhs", "5.0.0"); DO_TEST_CAPS_LATEST("disk-network-http"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-http-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); VIR_FREE(driver.config->nbdTLSx509secretUUID); VIR_FREE(driver.config->vxhsTLSx509secretUUID); driver.config->vxhsTLS = 0; DO_TEST_CAPS_LATEST("disk-network-ssh"); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_SSH); - DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-password", QEMU_NBDKIT_CAPS_PLUGIN_SSH); DO_TEST_CAPS_LATEST("disk-no-boot"); DO_TEST_CAPS_LATEST("disk-nvme"); DO_TEST_CAPS_VER("disk-vhostuser-numa", "4.2.0"); @@ -1249,6 +1243,15 @@ mymain(void) DO_TEST_CAPS_LATEST("disk-geometry"); DO_TEST_CAPS_LATEST("disk-blockio"); + driver.config->storageUseNbdkit = 1; + DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-source-curl-nbdkit-backing", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-http-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_SSH); + DO_TEST_CAPS_LATEST_NBDKIT("disk-network-ssh-password", QEMU_NBDKIT_CAPS_PLUGIN_SSH); + driver.config->storageUseNbdkit = 0; + DO_TEST_CAPS_VER("disk-virtio-scsi-reservations", "5.2.0"); DO_TEST_CAPS_LATEST("disk-virtio-scsi-reservations"); -- 2.41.0

2 1

[PATCH V4] support for hotplug/hotunplug in test hypervisor
by Thanos Makatos 09 Nov '23

09 Nov '23

Signed-off-by: Thanos Makatos <thanos.makatos(a)nutanix.com> --- src/test/test_driver.c | 387 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 385 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e87d7cfd44..a3b4799a0f 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -26,8 +26,6 @@ #include <unistd.h> #include <sys/stat.h> #include <libxml/xmlsave.h> - - #include "virerror.h" #include "datatypes.h" #include "test_driver.h" @@ -38,10 +36,14 @@ #include "virnetworkobj.h" #include "interface_conf.h" #include "checkpoint_conf.h" +#include "domain_addr.h" +#include "domain_audit.h" #include "domain_conf.h" #include "domain_driver.h" #include "domain_event.h" +#include "domain_validate.h" #include "network_event.h" +#include "nwfilter_conf.h" #include "snapshot_conf.h" #include "virfdstream.h" #include "storage_conf.h" @@ -50,6 +52,7 @@ #include "node_device_conf.h" #include "virnodedeviceobj.h" #include "node_device_event.h" +#include "vircgroup.h" #include "virxml.h" #include "virthread.h" #include "virlog.h" @@ -10035,6 +10038,383 @@ testConnectGetDomainCapabilities(virConnectPtr conn G_GNUC_UNUSED, return virDomainCapsFormat(domCaps); } +static int +testDomainAttachHostPCIDevice(testDriver *driver G_GNUC_UNUSED, + virDomainObj *vm, + virDomainHostdevDef *hostdev) +{ + int backend = hostdev->source.subsys.u.pci.backend; + + switch ((virDomainHostdevSubsysPCIBackendType)backend) { + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM: + break; + + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN: + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_TYPE_LAST: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("test hypervisor does not support device assignment mode '%s'"), + virDomainHostdevSubsysPCIBackendTypeToString(backend)); + return -1; + } + + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("guest unexpectedly quit during hotplug")); + return -1; + } + + VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs + 1); + + virDomainAuditHostdev(vm, hostdev, "attach", true); + + vm->def->hostdevs[vm->def->nhostdevs++] = hostdev; + + return 0; +} + +static int +testDomainAttachHostDevice(testDriver *driver, + virDomainObj *vm, + virDomainHostdevDef *hostdev) +{ + if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("hotplug is not supported for hostdev mode '%s'"), + virDomainHostdevModeTypeToString(hostdev->mode)); + return -1; + } + + if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("hotplug is not supported for hostdev subsys type '%s'"), + virDomainHostdevSubsysTypeToString(hostdev->source.subsys.type)); + return -1; + } + + return testDomainAttachHostPCIDevice(driver, vm, hostdev); +} + +static int +testDomainAttachDeviceLive(virDomainObj *vm, + virDomainDeviceDef *dev, + testDriver *driver) +{ + int ret = -1; + const char *alias = NULL; + + if ((virDomainDeviceType)dev->type != VIR_DOMAIN_DEVICE_HOSTDEV) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("live attach of device '%s' is not supported"), + virDomainDeviceTypeToString(dev->type)); + return -1; + } + + testDomainObjCheckHostdevTaint(vm, dev->data.hostdev); + if ((ret = testDomainAttachHostDevice(driver, vm, dev->data.hostdev)) != 0) + return ret; + + alias = dev->data.hostdev->info->alias; + dev->data.hostdev = NULL; + + if (alias) { + virObjectEvent *event; + event = virDomainEventDeviceAddedNewFromObj(vm, alias); + virObjectEventStateQueue(driver->eventState, event); + } + + return 0; +} + +static int +testDomainAttachDeviceLiveAndConfig(virDomainObj *vm, + testDriver *driver, + const char *xml, + unsigned int flags) +{ + g_autoptr(virDomainDeviceDef) devConf = NULL; + g_autoptr(virDomainDeviceDef) devLive = NULL; + unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | + VIR_DOMAIN_DEF_PARSE_ABI_UPDATE; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE, -1); + + if (flags & VIR_DOMAIN_AFFECT_LIVE) { + if (!(devLive = virDomainDeviceDefParse(xml, vm->def, + driver->xmlopt, NULL, + parse_flags))) + return -1; + + if (virDomainDeviceValidateAliasForHotplug(vm, devLive, + VIR_DOMAIN_AFFECT_LIVE) < 0) + return -1; + + if (virDomainDefCompatibleDevice(vm->def, devLive, NULL, + VIR_DOMAIN_DEVICE_ACTION_ATTACH, + true) < 0) + return -1; + + if (testDomainAttachDeviceLive(vm, devLive, driver) < 0) + return -1; + } + + return 0; +} + +static int +testDomainAttachDeviceFlags(virDomainPtr domain, + const char *xml, + unsigned int flags) { + + testDriver *driver = domain->conn->privateData; + virDomainObj *vm = NULL; + int ret = -1; + + virNWFilterReadLockFilterUpdates(); + + if (!(vm = testDomObjFromDomain(domain))) + return -1; + + if (virDomainObjUpdateModificationImpact(vm, &flags) < 0) + goto cleanup; + + if (testDomainAttachDeviceLiveAndConfig(vm, driver, xml, flags) < 0) + goto cleanup; + + ret = 0; + + cleanup: + virDomainObjEndAPI(&vm); + virNWFilterUnlockFilterUpdates(); + return ret; + +} + +static int +testDomainAttachDevice(virDomainPtr domain, const char *xml) +{ + return testDomainAttachDeviceFlags(domain, xml, 0); +} + +/* search for a hostdev matching dev and detach it */ +static int +testDomainDetachPrepHostdev(virDomainObj *vm, + virDomainHostdevDef *match, + virDomainHostdevDef **detach) +{ + virDomainHostdevSubsys *subsys = &match->source.subsys; + virDomainHostdevSubsysPCI *pcisrc = &subsys->u.pci; + virDomainHostdevDef *hostdev = NULL; + + if (match->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("hot unplug is not supported for hostdev mode '%s'"), + virDomainHostdevModeTypeToString(match->mode)); + return -1; + } + + if (virDomainHostdevFind(vm->def, match, &hostdev) < 0) { + if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { + virReportError(VIR_ERR_DEVICE_MISSING, + _("host pci device " VIR_PCI_DEVICE_ADDRESS_FMT + " not found"), + pcisrc->addr.domain, pcisrc->addr.bus, + pcisrc->addr.slot, pcisrc->addr.function); + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("unexpected hostdev type %d"), subsys->type); + } + return -1; + } + + *detach = hostdev; + + return 0; +} + +static int +testDomainRemoveHostDevice(testDriver *driver G_GNUC_UNUSED, + virDomainObj *vm, + virDomainHostdevDef *hostdev) +{ + virDomainNetDef *net = NULL; + size_t i; + + VIR_DEBUG("Removing host device %s from domain %p %s", + hostdev->info->alias, vm, vm->def->name); + + if (hostdev->parentnet) { + net = hostdev->parentnet; + for (i = 0; i < vm->def->nnets; i++) { + if (vm->def->nets[i] == hostdev->parentnet) { + virDomainNetRemove(vm->def, i); + break; + } + } + } + + for (i = 0; i < vm->def->nhostdevs; i++) { + if (vm->def->hostdevs[i] == hostdev) { + virDomainHostdevRemove(vm->def, i); + break; + } + } + + virDomainAuditHostdev(vm, hostdev, "detach", true); + + virDomainHostdevDefFree(hostdev); + + if (net) { + if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) { + g_autoptr(virConnect) conn = virGetConnectNetwork(); + if (conn) + virDomainNetReleaseActualDevice(conn, vm->def, net); + else + VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); + } + virDomainNetDefFree(net); + } + + return 0; +} + +static int +testDomainRemoveDevice(testDriver *driver, + virDomainObj *vm, + virDomainDeviceDef *dev) +{ + virDomainDeviceInfo *info; + virObjectEvent *event; + g_autofree char *alias = NULL; + + /* + * save the alias to use when sending a DEVICE_REMOVED event after + * all other teardown is complete + */ + if ((info = virDomainDeviceGetInfo(dev))) + alias = g_strdup(info->alias); + info = NULL; + + if ((virDomainDeviceType)dev->type != VIR_DOMAIN_DEVICE_HOSTDEV) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("don't know how to remove a %s device"), + virDomainDeviceTypeToString(dev->type)); + goto out; + } + + if (testDomainRemoveHostDevice(driver, vm, dev->data.hostdev) < 0) + return -1; + +out: + event = virDomainEventDeviceRemovedNewFromObj(vm, alias); + virObjectEventStateQueue(driver->eventState, event); + + return 0; +} + +static int +testDomainDetachDeviceLive(virDomainObj *vm, + virDomainDeviceDef *match, + testDriver *driver) +{ + virDomainDeviceDef detach = { .type = match->type }; + virDomainDeviceInfo *info = NULL; + + if ((virDomainDeviceType)match->type != VIR_DOMAIN_DEVICE_HOSTDEV) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("live detach of device '%s' is not supported"), + virDomainDeviceTypeToString(match->type)); + return -1; + } + + if (testDomainDetachPrepHostdev(vm, match->data.hostdev, + &detach.data.hostdev) < 0) + return -1; + + /* "detach" now points to the actual device we want to detach */ + + if (!(info = virDomainDeviceGetInfo(&detach))) { + /* + * This should never happen, since all of the device types in + * the switch cases that end with a "break" instead of a + * return have a virDeviceInfo in them. + */ + virReportError(VIR_ERR_INTERNAL_ERROR, + _("device of type '%s' has no device info"), + virDomainDeviceTypeToString(detach.type)); + return -1; + } + + /* Make generic validation checks common to all device types */ + + if (!info->alias) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Cannot detach %s device with no alias"), + virDomainDeviceTypeToString(detach.type)); + return -1; + } + + return testDomainRemoveDevice(driver, vm, &detach); +} + +static int +testDomainDetachDeviceAliasLiveAndConfig(testDriver *driver, + virDomainObj *vm, + const char *alias, + unsigned int flags) +{ + virDomainDef *def = NULL; + g_autoptr(virDomainDef) vmdef = NULL; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE, -1); + + if (virDomainObjGetDefs(vm, flags, &def, NULL) < 0) + return -1; + + if (def) { + virDomainDeviceDef dev; + + if (virDomainDefFindDevice(def, alias, &dev, true) < 0) + return -1; + + if (testDomainDetachDeviceLive(vm, &dev, driver) < 0) + return -1; + } + + if (vmdef) { + if (virDomainDefSave(vmdef, driver->xmlopt, NULL) < 0) + return -1; + virDomainObjAssignDef(vm, &vmdef, false, NULL); + } + + return 0; +} + +static int +testDomainDetachDeviceAlias(virDomainPtr dom, + const char *alias, + unsigned int flags) +{ + testDriver *driver = dom->conn->privateData; + virDomainObj *vm = NULL; + int ret = -1; + + if (!(vm = testDomObjFromDomain(dom))) + return -1; + + if (virDomainObjUpdateModificationImpact(vm, &flags) < 0) + goto cleanup; + + if (testDomainDetachDeviceAliasLiveAndConfig(driver, vm, alias, flags) < 0) + goto cleanup; + + ret = 0; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} /* * Test driver @@ -10058,6 +10438,9 @@ static virHypervisorDriver testHypervisorDriver = { .connectListDomains = testConnectListDomains, /* 0.1.1 */ .connectNumOfDomains = testConnectNumOfDomains, /* 0.1.1 */ .connectListAllDomains = testConnectListAllDomains, /* 0.9.13 */ + .domainAttachDevice = testDomainAttachDevice, /* 9.10.0 */ + .domainAttachDeviceFlags = testDomainAttachDeviceFlags, /* 9.10.0 */ + .domainDetachDeviceAlias = testDomainDetachDeviceAlias, /* 9.10.0 */ .domainCreateXML = testDomainCreateXML, /* 0.1.4 */ .domainCreateXMLWithFiles = testDomainCreateXMLWithFiles, /* 5.7.0 */ .domainLookupByID = testDomainLookupByID, /* 0.1.1 */ -- 2.27.0

1 0

[PATCH V3] support for hotplug/hotunplug in test hypervisor
by Thanos Makatos 07 Nov '23

07 Nov '23

Signed-off-by: Thanos Makatos <thanos.makatos(a)nutanix.com> --- src/test/test_driver.c | 59 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e87d7cfd44..d605649262 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -10035,6 +10035,62 @@ testConnectGetDomainCapabilities(virConnectPtr conn G_GNUC_UNUSED, return virDomainCapsFormat(domCaps); } +static int +testVirDomainAttachDeviceFlags(virDomainPtr domain, + const char *xml, + unsigned int flags G_GNUC_UNUSED) { + + int ret = -1; + virDomainObj *vm; + testDriver *driver; + virDomainDeviceDef *devConf; + + if (!(vm = testDomObjFromDomain(domain))) + return -1; + + driver = domain->conn->privateData; + + if (!(devConf = virDomainDeviceDefParse(xml, vm->def, driver->xmlopt, + NULL, 0))) + goto out; + + VIR_APPEND_ELEMENT(vm->def->hostdevs, vm->def->nhostdevs, + devConf->data.hostdev); + virDomainDeviceDefFree(devConf); + ret = 0; +out: + virDomainObjEndAPI(&vm); + return ret; +} + +static int +testVirDomainAttachDevice(virDomainPtr domain, const char *xml) +{ + return testVirDomainAttachDeviceFlags(domain, xml, 0); +} + +static int +testVirDomainDetachDeviceAlias(virDomainPtr domain, + const char *alias, + unsigned int flags G_GNUC_UNUSED) +{ + virDomainObj *vm; + size_t i; + bool found = false; + + if (!(vm = testDomObjFromDomain(domain))) + return -1; + + for (i = 0; i < vm->def->nhostdevs && !found; i++) { + if (!strcmp(vm->def->hostdevs[i]->info->alias, alias)) { + virDomainHostdevDefFree(vm->def->hostdevs[i]); + VIR_DELETE_ELEMENT(vm->def->hostdevs, i, vm->def->nhostdevs); + found = true; + } + } + virDomainObjEndAPI(&vm); + return found ? 0 : -1; +} /* * Test driver @@ -10058,6 +10114,9 @@ static virHypervisorDriver testHypervisorDriver = { .connectListDomains = testConnectListDomains, /* 0.1.1 */ .connectNumOfDomains = testConnectNumOfDomains, /* 0.1.1 */ .connectListAllDomains = testConnectListAllDomains, /* 0.9.13 */ + .domainAttachDevice = testVirDomainAttachDevice, /* 9.9.0 */ + .domainAttachDeviceFlags = testVirDomainAttachDeviceFlags, /* 9.9.0 */ + .domainDetachDeviceAlias = testVirDomainDetachDeviceAlias, /* 9.9.0 */ .domainCreateXML = testDomainCreateXML, /* 0.1.4 */ .domainCreateXMLWithFiles = testDomainCreateXMLWithFiles, /* 5.7.0 */ .domainLookupByID = testDomainLookupByID, /* 0.1.1 */ -- 2.27.0

4 5

[libvirt PATCH] systemd: More tweaks to Description and Documentation lines
by Andrea Bolognani 06 Nov '23

06 Nov '23

We recently unified all services and sockets, except a couple were missed. Finish the job. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/remote/virt-guest-shutdown.target | 4 ++-- tools/libvirt-guests.service.in | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/remote/virt-guest-shutdown.target b/src/remote/virt-guest-shutdown.target index 25d4aaa267..34219d00b0 100644 --- a/src/remote/virt-guest-shutdown.target +++ b/src/remote/virt-guest-shutdown.target @@ -1,3 +1,3 @@ [Unit] -Description=Libvirt guests shutdown -Documentation=https://libvirt.org +Description=libvirt guests shutdown target +Documentation=https://libvirt.org/ diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index c547218f2a..b044444298 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,5 +1,7 @@ [Unit] -Description=Suspend/Resume Running libvirt Guests +Description=libvirt guests suspend/resume service +Documentation=man:libvirt-guests(8) +Documentation=https://libvirt.org/ Requires=virt-guest-shutdown.target After=network.target After=time-sync.target @@ -10,8 +12,6 @@ After=virtvboxd.socket After=virtvzd.socket After=virtxend.socket After=virt-guest-shutdown.target -Documentation=man:libvirt-guests(8) -Documentation=https://libvirt.org [Service] EnvironmentFile=-@initconfdir@/libvirt-guests -- 2.41.0

2 1

[libvirt PATCH] conf: virDomainDiskSourceFormat: check for srcpool presence correctly
by Ján Tomko 06 Nov '23

06 Nov '23

As a guard against programming errors, one part of the condition only dereferences srcpool if it exists, other one does not. Move the check up one level so that it actually has a chance to do something useful. Fixes: 19b1c0d31988a3a10c4694c10c27eb15c018f450 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/conf/domain_conf.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 80f467ae7a..99f9d56f07 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -22357,14 +22357,12 @@ virDomainDiskSourceFormat(virBuffer *buf, g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER; g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf); - if (src->type == VIR_STORAGE_TYPE_VOLUME) { - if (src->srcpool) { - virBufferEscapeString(&attrBuf, " pool='%s'", src->srcpool->pool); - virBufferEscapeString(&attrBuf, " volume='%s'", src->srcpool->volume); - if (src->srcpool->mode) - virBufferAsprintf(&attrBuf, " mode='%s'", - virStorageSourcePoolModeTypeToString(src->srcpool->mode)); - } + if (src->type == VIR_STORAGE_TYPE_VOLUME && src->srcpool) { + virBufferEscapeString(&attrBuf, " pool='%s'", src->srcpool->pool); + virBufferEscapeString(&attrBuf, " volume='%s'", src->srcpool->volume); + if (src->srcpool->mode) + virBufferAsprintf(&attrBuf, " mode='%s'", + virStorageSourcePoolModeTypeToString(src->srcpool->mode)); if (flags & VIR_DOMAIN_DEF_FORMAT_VOLUME_TRANSLATED && src->srcpool->actualtype != VIR_STORAGE_TYPE_NONE) { -- 2.41.0

2 1

[PATCH] ci: workaround broken opensuse leap 15.5 tirpc
by Daniel P. Berrangé 06 Nov '23

06 Nov '23

Temporarily disable '-Wmissing-include-dirs' becuase the libtirpc pkg-confog file has a bogus include dir. The headers can fortunately still be found since they are in the system include dir. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- ci/gitlab/builds.yml | 2 ++ ci/manifest.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index 9ae2225e35..e1ea87db1b 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -332,6 +332,7 @@ x86_64-opensuse-leap-15-prebuilt-env: optional: true allow_failure: false variables: + CFLAGS: -Wno-missing-include-dirs NAME: opensuse-leap-15 RPM: skip @@ -340,6 +341,7 @@ x86_64-opensuse-leap-15-local-env: needs: [] allow_failure: false variables: + CFLAGS: -Wno-missing-include-dirs IMAGE: registry.opensuse.org/opensuse/leap:15.5 NAME: opensuse-leap-15 RPM: skip diff --git a/ci/manifest.yml b/ci/manifest.yml index 0e5a17a2bd..2af8e62f28 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -205,6 +205,8 @@ targets: - arch: x86_64 variables: RPM: skip + # Keep until fix for: https://bugzilla.opensuse.org/show_bug.cgi?id=1216862 + CFLAGS: -Wno-missing-include-dirs opensuse-tumbleweed: jobs: -- 2.41.0

5 12

[libvirt PATCH 0/5] ci: Add macOS 13 & 14, drop macOS 12
by Andrea Bolognani 06 Nov '23

06 Nov '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1062214982 Assumes that https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/444 has been merged, which it hasn't yet, but I don't expect it to be controversial. I've added both macOS 13 and 14, doubling the amount of coverage. I'm not aware of us being particularly tight on Cirrus CI credits, but if that's the case we can just skip the macOS 13 patch. The job environment is supposed to make the build system pick up dependencies that are installed via Homebrew but can't be exposed by default because they conflict with OS-supplied packages. Right now it doesn't really do anything, because it hasn't been updated with the switch to aarch64. I'm going to look into it later, but for now I've left it as-is as reminder/documentation. Andrea Bolognani (5): ci: Update generated files ci: Drop rpcgen override from macOS $PATH ci: Add macOS 13 ci: Add macOS 14 ci: Drop macOS 12 ci/buildenv/almalinux-8.sh | 1 - ci/buildenv/alpine-317.sh | 1 - ci/buildenv/alpine-edge.sh | 1 - ci/buildenv/centos-stream-8.sh | 1 - ci/buildenv/centos-stream-9.sh | 1 - ci/buildenv/debian-11-cross-aarch64.sh | 1 - ci/buildenv/debian-11-cross-armv6l.sh | 1 - ci/buildenv/debian-11-cross-armv7l.sh | 1 - ci/buildenv/debian-11-cross-i686.sh | 1 - ci/buildenv/debian-11-cross-mips64el.sh | 1 - ci/buildenv/debian-11-cross-mipsel.sh | 1 - ci/buildenv/debian-11-cross-ppc64le.sh | 1 - ci/buildenv/debian-11-cross-s390x.sh | 1 - ci/buildenv/debian-11.sh | 1 - ci/buildenv/debian-12-cross-aarch64.sh | 1 - ci/buildenv/debian-12-cross-armv6l.sh | 1 - ci/buildenv/debian-12-cross-armv7l.sh | 1 - ci/buildenv/debian-12-cross-i686.sh | 1 - ci/buildenv/debian-12-cross-mips64el.sh | 1 - ci/buildenv/debian-12-cross-mipsel.sh | 1 - ci/buildenv/debian-12-cross-ppc64le.sh | 1 - ci/buildenv/debian-12-cross-s390x.sh | 1 - ci/buildenv/debian-12.sh | 1 - ci/buildenv/debian-sid-cross-aarch64.sh | 1 - ci/buildenv/debian-sid-cross-armv6l.sh | 1 - ci/buildenv/debian-sid-cross-armv7l.sh | 1 - ci/buildenv/debian-sid-cross-i686.sh | 1 - ci/buildenv/debian-sid-cross-mips64el.sh | 1 - ci/buildenv/debian-sid-cross-ppc64le.sh | 1 - ci/buildenv/debian-sid-cross-s390x.sh | 1 - ci/buildenv/debian-sid.sh | 1 - ci/buildenv/fedora-37.sh | 1 - ci/buildenv/fedora-38-cross-mingw32.sh | 2 +- ci/buildenv/fedora-38-cross-mingw64.sh | 2 +- ci/buildenv/fedora-38.sh | 1 - ci/buildenv/fedora-rawhide-cross-mingw32.sh | 2 +- ci/buildenv/fedora-rawhide-cross-mingw64.sh | 2 +- ci/buildenv/fedora-rawhide.sh | 1 - ci/buildenv/opensuse-leap-15.sh | 1 - ci/buildenv/opensuse-tumbleweed.sh | 1 - ci/buildenv/ubuntu-2004.sh | 1 - ci/buildenv/ubuntu-2204.sh | 1 - ci/cirrus/{macos-12.vars => macos-13.vars} | 2 +- ci/cirrus/{macos-12.vars => macos-14.vars} | 2 +- ci/containers/almalinux-8.Dockerfile | 1 - ci/containers/alpine-317.Dockerfile | 1 - ci/containers/alpine-edge.Dockerfile | 1 - ci/containers/centos-stream-8.Dockerfile | 1 - ci/containers/centos-stream-9.Dockerfile | 1 - .../debian-11-cross-aarch64.Dockerfile | 1 - .../debian-11-cross-armv6l.Dockerfile | 1 - .../debian-11-cross-armv7l.Dockerfile | 1 - ci/containers/debian-11-cross-i686.Dockerfile | 1 - .../debian-11-cross-mips64el.Dockerfile | 1 - .../debian-11-cross-mipsel.Dockerfile | 1 - .../debian-11-cross-ppc64le.Dockerfile | 1 - .../debian-11-cross-s390x.Dockerfile | 1 - ci/containers/debian-11.Dockerfile | 1 - .../debian-12-cross-aarch64.Dockerfile | 1 - .../debian-12-cross-armv6l.Dockerfile | 1 - .../debian-12-cross-armv7l.Dockerfile | 1 - ci/containers/debian-12-cross-i686.Dockerfile | 1 - .../debian-12-cross-mips64el.Dockerfile | 1 - .../debian-12-cross-mipsel.Dockerfile | 1 - .../debian-12-cross-ppc64le.Dockerfile | 1 - .../debian-12-cross-s390x.Dockerfile | 1 - ci/containers/debian-12.Dockerfile | 1 - .../debian-sid-cross-aarch64.Dockerfile | 1 - .../debian-sid-cross-armv6l.Dockerfile | 1 - .../debian-sid-cross-armv7l.Dockerfile | 1 - .../debian-sid-cross-i686.Dockerfile | 1 - .../debian-sid-cross-mips64el.Dockerfile | 1 - .../debian-sid-cross-ppc64le.Dockerfile | 1 - .../debian-sid-cross-s390x.Dockerfile | 1 - ci/containers/debian-sid.Dockerfile | 1 - ci/containers/fedora-37.Dockerfile | 1 - .../fedora-38-cross-mingw32.Dockerfile | 2 +- .../fedora-38-cross-mingw64.Dockerfile | 2 +- ci/containers/fedora-38.Dockerfile | 1 - .../fedora-rawhide-cross-mingw32.Dockerfile | 2 +- .../fedora-rawhide-cross-mingw64.Dockerfile | 2 +- ci/containers/fedora-rawhide.Dockerfile | 1 - ci/containers/opensuse-leap-15.Dockerfile | 1 - ci/containers/opensuse-tumbleweed.Dockerfile | 1 - ci/containers/ubuntu-2004.Dockerfile | 1 - ci/containers/ubuntu-2204.Dockerfile | 1 - ci/gitlab/builds.yml | 24 +++++++++++++++---- ci/manifest.yml | 11 +++++++-- 88 files changed, 39 insertions(+), 92 deletions(-) copy ci/cirrus/{macos-12.vars => macos-13.vars} (91%) rename ci/cirrus/{macos-12.vars => macos-14.vars} (91%) -- 2.41.0

2 12

[PATCH] virDomainDeviceInfoCheckABIStability: Implement proper check for CCW addresses
by Peter Krempa 06 Nov '23

06 Nov '23

CCW addresses need to be also checked for ABI stability. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/conf/domain_conf.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 80f467ae7a..5ce1793c2d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19719,10 +19719,21 @@ virDomainDeviceInfoCheckABIStability(virDomainDeviceInfo *src, } break; + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: + if (src->addr.ccw.cssid != dst->addr.ccw.cssid || + src->addr.ccw.ssid != dst->addr.ccw.ssid || + src->addr.ccw.devno != dst->addr.ccw.devno) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target device CCW address %1$x.%2$x.%3$04x does not match source %4$x.%5$x.%6$04x"), + dst->addr.ccw.cssid, dst->addr.ccw.ssid, dst->addr.ccw.devno, + src->addr.ccw.cssid, src->addr.ccw.ssid, src->addr.ccw.devno); + return false; + } + break; + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390: - case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED: -- 2.41.0

2 1

[PATCH] virhostmem: Get total memory on macOS properly
by Michal Privoznik 06 Nov '23

06 Nov '23

Problem with HW_PHYSMEM sysctl on 64-bit macOS is that it returns a 32-bit signed value. Thus it overflows. Switching to HW_MEMSIZE is recommended as it's of an uint_64 type [1]. 1: https://github.com/apple-oss-distributions/xnu/blob/xnu-10002.1.13/bsd/sys/… Reported-by: Jaroslav Suchanek <jsuchane(a)redhat.com> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virhostmem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util/virhostmem.c b/src/util/virhostmem.c index 1da2759ac3..a7027af835 100644 --- a/src/util/virhostmem.c +++ b/src/util/virhostmem.c @@ -617,7 +617,10 @@ virHostMemGetTotal(void) unsigned long long physmem = 0; size_t len = sizeof(physmem); - if (sysctlbyname("hw.physmem", &physmem, &len, NULL, 0) < 0) { + /* On macOS hw.physmem is int32_t which doesn't fly with >4GiB of memory. + * But hw.memsize is uint64_t. */ + if (sysctlbyname("hw.memsize", &physmem, &len, NULL, 0) < 0 && + sysctlbyname("hw.physmem", &physmem, &len, NULL, 0) < 0) { virReportSystemError(errno, "%s", _("Unable to query memory total")); return 0; -- 2.41.0

2 1

[libvirt PATCH] rpcgen: use proper operators when comparing types
by Laine Stump 06 Nov '23

06 Nov '23

flake8 (run on all python scripts as a part of the syntax checks) version 6.1.0 (on macOS 14) issued many complaints like this on the new rpcgen python scripts: [...]libvirt/scripts/rpcgen/rpcgen/lexer.py:57:17: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` This patch changes all [type] == [type] to use "is" instead of "==", and similarly to use "is not" instead of "!=". (flake8 5.03, e.g. on Fedora 38, is just fine with using "==" and "!=", but python on both likes "is" and "is not") Fixes: commit v9.9.0-24-g8ec79e5e14 Fixes: commit v9.9.0-22-gca3f025011 Fixes: commit v9.9.0-21-g031efb691f Fixes: commit v9.9.0-20-g8c8b97685b Signed-off-by: Laine Stump <laine(a)redhat.com> --- scripts/rpcgen/rpcgen/ast.py | 4 +- scripts/rpcgen/rpcgen/generator.py | 26 ++++++------ scripts/rpcgen/rpcgen/lexer.py | 2 +- scripts/rpcgen/rpcgen/parser.py | 68 +++++++++++++++--------------- 4 files changed, 50 insertions(+), 50 deletions(-) diff --git a/scripts/rpcgen/rpcgen/ast.py b/scripts/rpcgen/rpcgen/ast.py index 3e3e089713..52d9c3ac46 100644 --- a/scripts/rpcgen/rpcgen/ast.py +++ b/scripts/rpcgen/rpcgen/ast.py @@ -185,9 +185,9 @@ class XDRTypeCustom(XDRType): self.definition = definition def is_scalar(self): - if type(self.definition) == XDRDefinitionEnum: + if type(self.definition) is XDRDefinitionEnum: return True - if type(self.definition) == XDRDefinitionTypedef: + if type(self.definition) is XDRDefinitionTypedef: return self.definition.decl.typ.is_scalar() return False diff --git a/scripts/rpcgen/rpcgen/generator.py b/scripts/rpcgen/rpcgen/generator.py index 73731e1497..c6e210e7b0 100644 --- a/scripts/rpcgen/rpcgen/generator.py +++ b/scripts/rpcgen/rpcgen/generator.py @@ -81,7 +81,7 @@ class XDRTypeDeclarationGenerator(XDRVisitor): ) def visit_declaration_variablearray(self, obj, indent, context): - if type(obj.typ) == XDRTypeString: + if type(obj.typ) is XDRTypeString: return "%schar *%s" % (indent, obj.identifier) else: code = ( @@ -178,10 +178,10 @@ class XDRTypeDeclarationGenerator(XDRVisitor): + "%s union {\n" % indent ) for value in obj.cases: - if type(value.decl.typ) == XDRTypeVoid: + if type(value.decl.typ) is XDRTypeVoid: continue code = code + self.visit_object(value, indent + " ") + ";\n" - if obj.default is not None and type(obj.default.typ) != XDRTypeVoid: + if obj.default is not None and type(obj.default.typ) is not XDRTypeVoid: code = code + self.visit_object(obj.default, indent + " ") + ";\n" code = code + "%s } %su;\n" % (indent, prefix) + "%s}" % indent return code @@ -250,10 +250,10 @@ class XDRMarshallImplementationGenerator(XDRVisitor): return code def generate_type_call(self, decl, field, typename, embedded=False, indent=""): - if type(decl.typ) == XDRTypeVoid: + if type(decl.typ) is XDRTypeVoid: return "" - if type(decl) == XDRDeclarationFixedArray: - if type(decl.typ) == XDRTypeOpaque: + if type(decl) is XDRDeclarationFixedArray: + if type(decl.typ) is XDRTypeOpaque: code = "%s if (!xdr_%s(xdrs, %s, %s))\n" % ( indent, self.visit_object(decl.typ, context="func"), @@ -270,7 +270,7 @@ class XDRMarshallImplementationGenerator(XDRVisitor): self.visit_object(decl.typ), self.visit_object(decl.typ, context="func"), ) - elif type(decl) == XDRDeclarationVariableArray: + elif type(decl) is XDRDeclarationVariableArray: fieldRef = "." pointerStr = "" if embedded: @@ -278,7 +278,7 @@ class XDRMarshallImplementationGenerator(XDRVisitor): else: fieldRef = "->" - if type(decl.typ) == XDRTypeString: + if type(decl.typ) is XDRTypeString: code = "%s if (!xdr_%s(xdrs, %s%s, %s))\n" % ( indent, self.visit_object(decl.typ, context="func"), @@ -286,7 +286,7 @@ class XDRMarshallImplementationGenerator(XDRVisitor): field, decl.maxlength, ) - elif type(decl.typ) == XDRTypeOpaque: + elif type(decl.typ) is XDRTypeOpaque: code = "%s if (!xdr_bytes(xdrs, (char **)&%s%s%s_val, " % ( indent, field, @@ -311,7 +311,7 @@ class XDRMarshallImplementationGenerator(XDRVisitor): self.visit_object(decl.typ, context="func"), ) ) - elif type(decl) == XDRDeclarationPointer: + elif type(decl) is XDRDeclarationPointer: pointerStr = "" if embedded: pointerStr = "&" @@ -327,9 +327,9 @@ class XDRMarshallImplementationGenerator(XDRVisitor): else: pointerStr = "" isFixedArray = ( - type(decl.typ) == XDRTypeCustom - and type(decl.typ.definition) == XDRDefinitionTypedef - and type(decl.typ.definition.decl) == XDRDeclarationFixedArray + type(decl.typ) is XDRTypeCustom + and type(decl.typ.definition) is XDRDefinitionTypedef + and type(decl.typ.definition.decl) is XDRDeclarationFixedArray ) if embedded and not isFixedArray: diff --git a/scripts/rpcgen/rpcgen/lexer.py b/scripts/rpcgen/rpcgen/lexer.py index 989c2ae216..a27d7005b8 100644 --- a/scripts/rpcgen/rpcgen/lexer.py +++ b/scripts/rpcgen/rpcgen/lexer.py @@ -55,7 +55,7 @@ class XDRToken(abc.ABC): def __eq__(self, other): return ( - type(self) == type(other) + type(self) is type(other) and self.line == other.line and self.column == other.column and self.value == other.value diff --git a/scripts/rpcgen/rpcgen/parser.py b/scripts/rpcgen/rpcgen/parser.py index 7efbe5468e..c01ae56755 100644 --- a/scripts/rpcgen/rpcgen/parser.py +++ b/scripts/rpcgen/rpcgen/parser.py @@ -162,10 +162,10 @@ class XDRParser: if token is None: return None - if type(token) == XDRTokenCEscape: + if type(token) is XDRTokenCEscape: return XDRDefinitionCEscape(token.value[1:]) - if type(token) != XDRTokenIdentifier: + if type(token) is not XDRTokenIdentifier: raise Exception("Expected identifier, but got %s" % token) defs = { @@ -186,18 +186,18 @@ class XDRParser: definition = func() semi = self.lexer.next() - if type(semi) != XDRTokenPunctuation or semi.value != ";": + if type(semi) is not XDRTokenPunctuation or semi.value != ";": raise Exception("Expected ';', but got %s" % semi) return definition def parse_definition_const(self): ident = self.lexer.next() - if type(ident) != XDRTokenIdentifier: + if type(ident) is not XDRTokenIdentifier: raise Exception("Expected identifier, but got %s" % ident) assign = self.lexer.next() - if type(assign) != XDRTokenPunctuation or assign.value != "=": + if type(assign) is not XDRTokenPunctuation or assign.value != "=": raise Exception("Expected '=', but got %s" % assign) const = self.lexer.next() @@ -217,7 +217,7 @@ class XDRParser: def parse_definition_enum(self): name = self.lexer.next() - if type(name) != XDRTokenIdentifier: + if type(name) is not XDRTokenIdentifier: raise Exception("Expected identifier, but got %s" % name) body = self.parse_enum_body() @@ -231,7 +231,7 @@ class XDRParser: def parse_definition_struct(self): name = self.lexer.next() - if type(name) != XDRTokenIdentifier: + if type(name) is not XDRTokenIdentifier: raise Exception("Expected identifier, but got %s" % name) body = self.parse_struct_body() @@ -245,7 +245,7 @@ class XDRParser: def parse_definition_union(self): name = self.lexer.next() - if type(name) != XDRTokenIdentifier: + if type(name) is not XDRTokenIdentifier: raise Exception("Expected identifier, but got %s" % name) body = self.parse_union_body() @@ -260,23 +260,23 @@ class XDRParser: def parse_declaration(self): typ = self.parse_type() - if type(typ) == XDRTypeVoid: + if type(typ) is XDRTypeVoid: return XDRDeclarationScalar(typ, None) ident = self.lexer.next() pointer = False - if type(ident) == XDRTokenPunctuation: + if type(ident) is XDRTokenPunctuation: if ident.value != "*": raise Exception("Expected '*' or identifer, but got %s" % ident) - if type(typ) == XDRTypeString or type(typ) == XDRTypeOpaque: + if type(typ) is XDRTypeString or type(typ) is XDRTypeOpaque: raise Exception("Pointer invalid for 'string' and 'opaque' types") pointer = True ident = self.lexer.next() bracket = self.lexer.peek() - if type(bracket) == XDRTokenPunctuation: + if type(bracket) is XDRTokenPunctuation: if bracket.value == "[": _ = self.lexer.next() value = self.lexer.next() @@ -284,10 +284,10 @@ class XDRParser: raise Exception("Expected constant, but got %s" % value) close = self.lexer.next() - if type(close) != XDRTokenPunctuation or close.value != "]": + if type(close) is not XDRTokenPunctuation or close.value != "]": raise Exception("Expected ']', but got %s" % value) - if type(typ) == XDRTypeString: + if type(typ) is XDRTypeString: raise Exception("Fixed array invalid for 'string' type") return XDRDeclarationFixedArray(typ, ident.value, value.value) elif bracket.value == "<": @@ -298,7 +298,7 @@ class XDRParser: value = self.lexer.next().value close = self.lexer.next() - if type(close) != XDRTokenPunctuation or close.value != ">": + if type(close) is not XDRTokenPunctuation or close.value != ">": raise Exception("Expected '>', but got %s" % close) return XDRDeclarationVariableArray(typ, ident.value, value) @@ -310,12 +310,12 @@ class XDRParser: def parse_type(self): typ = self.lexer.next() - if type(typ) != XDRTokenIdentifier: + if type(typ) is not XDRTokenIdentifier: raise Exception("Expected identifier, but got %s" % typ) if typ.value == "unsigned": typ = self.lexer.peek() - if type(typ) != XDRTokenIdentifier: + if type(typ) is not XDRTokenIdentifier: raise Exception("Expected identifier, but got %s" % typ) if typ.value == "char": @@ -366,25 +366,25 @@ class XDRParser: def parse_enum_body(self): body = self.lexer.next() - if type(body) != XDRTokenPunctuation or body.value != "{": + if type(body) is not XDRTokenPunctuation or body.value != "{": raise Exception("Expected '{', but got %s" % body) values = [] while True: ident = self.lexer.next() - if type(ident) != XDRTokenIdentifier: + if type(ident) is not XDRTokenIdentifier: raise Exception("Expected identifier, but got %s" % ident) equal = self.lexer.next() - if type(equal) != XDRTokenPunctuation or equal.value != "=": + if type(equal) is not XDRTokenPunctuation or equal.value != "=": raise Exception("Expected '=', but got %s" % ident) value = self.lexer.next() - if type(value) != XDRTokenConstant: + if type(value) is not XDRTokenConstant: raise Exception("Expected constant, but got %s" % ident) separator = self.lexer.next() - if type(separator) != XDRTokenPunctuation and separator.value not in [ + if type(separator) is not XDRTokenPunctuation and separator.value not in [ "}", ",", ]: @@ -403,7 +403,7 @@ class XDRParser: def parse_struct_body(self): body = self.lexer.next() - if type(body) != XDRTokenPunctuation or body.value != "{": + if type(body) is not XDRTokenPunctuation or body.value != "{": raise Exception("Expected '{', but got %s" % body) fields = [] @@ -412,11 +412,11 @@ class XDRParser: fields.append(field) separator = self.lexer.next() - if type(separator) != XDRTokenPunctuation and separator.value != ";": + if type(separator) is not XDRTokenPunctuation and separator.value != ";": raise Exception("Expected ';', but got %s" % separator) end = self.lexer.peek() - if type(end) == XDRTokenPunctuation and end.value == "}": + if type(end) is XDRTokenPunctuation and end.value == "}": break # discard the '}' we peeked at to end the loop @@ -429,28 +429,28 @@ class XDRParser: def parse_union_body(self): ident = self.lexer.next() - if type(ident) != XDRTokenIdentifier or ident.value != "switch": + if type(ident) is not XDRTokenIdentifier or ident.value != "switch": raise Exception("Expected 'switch', but got %s" % ident) bracket = self.lexer.next() - if type(bracket) != XDRTokenPunctuation or bracket.value != "(": + if type(bracket) is not XDRTokenPunctuation or bracket.value != "(": raise Exception("Expected '(', but got %s" % bracket) discriminator = self.parse_declaration() bracket = self.lexer.next() - if type(bracket) != XDRTokenPunctuation or bracket.value != ")": + if type(bracket) is not XDRTokenPunctuation or bracket.value != ")": raise Exception("Expected ')', but got %s" % bracket) bracket = self.lexer.next() - if type(bracket) != XDRTokenPunctuation or bracket.value != "{": + if type(bracket) is not XDRTokenPunctuation or bracket.value != "{": raise Exception("Expected '{', but got %s" % bracket) default = None cases = [] while True: ident = self.lexer.next() - if type(ident) != XDRTokenIdentifier or ident.value not in [ + if type(ident) is not XDRTokenIdentifier or ident.value not in [ "default", "case", ]: @@ -463,7 +463,7 @@ class XDRParser: raise Exception("Expected constant, but got %s" % value) sep = self.lexer.next() - if type(sep) != XDRTokenPunctuation or sep.value != ":": + if type(sep) is not XDRTokenPunctuation or sep.value != ":": raise Exception("Expected ':', but got %s" % value) decl = self.parse_declaration() @@ -475,17 +475,17 @@ class XDRParser: raise Exception("Duplicate 'default' clause") sep = self.lexer.next() - if type(sep) != XDRTokenPunctuation or sep.value != ":": + if type(sep) is not XDRTokenPunctuation or sep.value != ":": raise Exception("Expected ':', but got %s" % value) default = self.parse_declaration() separator = self.lexer.next() - if type(separator) != XDRTokenPunctuation and separator.value != ";": + if type(separator) is not XDRTokenPunctuation and separator.value != ";": raise Exception("Expected ';', but got %s" % bracket) end = self.lexer.peek() - if type(end) == XDRTokenPunctuation and end.value == "}": + if type(end) is XDRTokenPunctuation and end.value == "}": break # discard the '}' we peeked at to end the loop -- 2.41.0

3 2

[PATCH] ci: drop mipsel on Debian Sid
by Daniel P. Berrangé 06 Nov '23

06 Nov '23

This port was discontinued and purged from the archives: https://lists.debian.org/debian-devel-announce/2023/09/msg00000.html Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- ci/buildenv/debian-sid-cross-mipsel.sh | 115 ----------------- .../debian-sid-cross-mipsel.Dockerfile | 121 ------------------ ci/gitlab/builds.yml | 22 ---- ci/gitlab/containers.yml | 8 -- ci/manifest.yml | 4 - 5 files changed, 270 deletions(-) delete mode 100644 ci/buildenv/debian-sid-cross-mipsel.sh delete mode 100644 ci/containers/debian-sid-cross-mipsel.Dockerfile diff --git a/ci/buildenv/debian-sid-cross-mipsel.sh b/ci/buildenv/debian-sid-cross-mipsel.sh deleted file mode 100644 index 90dac8c22a..0000000000 --- a/ci/buildenv/debian-sid-cross-mipsel.sh +++ /dev/null @@ -1,115 +0,0 @@ -# THIS FILE WAS AUTO-GENERATED -# -# $ lcitool manifest ci/manifest.yml -# -# https://gitlab.com/libvirt/libvirt-ci - -function install_buildenv() { - export DEBIAN_FRONTEND=noninteractive - apt-get update - apt-get dist-upgrade -y - apt-get install --no-install-recommends -y \ - augeas-lenses \ - augeas-tools \ - bash-completion \ - ca-certificates \ - ccache \ - codespell \ - cpp \ - diffutils \ - dwarves \ - ebtables \ - flake8 \ - gettext \ - git \ - grep \ - iproute2 \ - iptables \ - kmod \ - libc-dev-bin \ - libnbd-dev \ - libxml2-utils \ - locales \ - lvm2 \ - make \ - meson \ - nfs-common \ - ninja-build \ - numad \ - open-iscsi \ - perl-base \ - pkgconf \ - policykit-1 \ - python3 \ - python3-docutils \ - qemu-utils \ - scrub \ - sed \ - xsltproc - sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen - dpkg-reconfigure locales - export DEBIAN_FRONTEND=noninteractive - dpkg --add-architecture mipsel - apt-get update - apt-get dist-upgrade -y - apt-get install --no-install-recommends -y dpkg-dev - apt-get install --no-install-recommends -y \ - gcc-mipsel-linux-gnu \ - libacl1-dev:mipsel \ - libapparmor-dev:mipsel \ - libattr1-dev:mipsel \ - libaudit-dev:mipsel \ - libblkid-dev:mipsel \ - libc6-dev:mipsel \ - libcap-ng-dev:mipsel \ - libcurl4-gnutls-dev:mipsel \ - libdevmapper-dev:mipsel \ - libfuse-dev:mipsel \ - libglib2.0-dev:mipsel \ - libglusterfs-dev:mipsel \ - libgnutls28-dev:mipsel \ - libiscsi-dev:mipsel \ - libnl-3-dev:mipsel \ - libnl-route-3-dev:mipsel \ - libnuma-dev:mipsel \ - libparted-dev:mipsel \ - libpcap0.8-dev:mipsel \ - libpciaccess-dev:mipsel \ - librbd-dev:mipsel \ - libreadline-dev:mipsel \ - libsanlock-dev:mipsel \ - libsasl2-dev:mipsel \ - libselinux1-dev:mipsel \ - libssh-gcrypt-dev:mipsel \ - libssh2-1-dev:mipsel \ - libtirpc-dev:mipsel \ - libudev-dev:mipsel \ - libxml2-dev:mipsel \ - libyajl-dev:mipsel \ - systemtap-sdt-dev:mipsel - mkdir -p /usr/local/share/meson/cross - printf "[binaries]\n\ -c = '/usr/bin/mipsel-linux-gnu-gcc'\n\ -ar = '/usr/bin/mipsel-linux-gnu-gcc-ar'\n\ -strip = '/usr/bin/mipsel-linux-gnu-strip'\n\ -pkgconfig = '/usr/bin/mipsel-linux-gnu-pkg-config'\n\ -\n\ -[host_machine]\n\ -system = 'linux'\n\ -cpu_family = 'mips'\n\ -cpu = 'mipsel'\n\ -endian = 'little'\n" > /usr/local/share/meson/cross/mipsel-linux-gnu - dpkg-query --showformat '${Package}_${Version}_${Architecture}\n' --show > /packages.txt - mkdir -p /usr/libexec/ccache-wrappers - ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-cc - ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-gcc -} - -export CCACHE_WRAPPERSDIR="/usr/libexec/ccache-wrappers" -export LANG="en_US.UTF-8" -export MAKE="/usr/bin/make" -export NINJA="/usr/bin/ninja" -export PYTHON="/usr/bin/python3" - -export ABI="mipsel-linux-gnu" -export MESON_OPTS="--cross-file=mipsel-linux-gnu" diff --git a/ci/containers/debian-sid-cross-mipsel.Dockerfile b/ci/containers/debian-sid-cross-mipsel.Dockerfile deleted file mode 100644 index 81895b23dd..0000000000 --- a/ci/containers/debian-sid-cross-mipsel.Dockerfile +++ /dev/null @@ -1,121 +0,0 @@ -# THIS FILE WAS AUTO-GENERATED -# -# $ lcitool manifest ci/manifest.yml -# -# https://gitlab.com/libvirt/libvirt-ci - -FROM docker.io/library/debian:sid-slim - -RUN export DEBIAN_FRONTEND=noninteractive && \ - apt-get update && \ - apt-get install -y eatmydata && \ - eatmydata apt-get dist-upgrade -y && \ - eatmydata apt-get install --no-install-recommends -y \ - augeas-lenses \ - augeas-tools \ - bash-completion \ - ca-certificates \ - ccache \ - codespell \ - cpp \ - diffutils \ - dwarves \ - ebtables \ - flake8 \ - gettext \ - git \ - grep \ - iproute2 \ - iptables \ - kmod \ - libc-dev-bin \ - libnbd-dev \ - libxml2-utils \ - locales \ - lvm2 \ - make \ - meson \ - nfs-common \ - ninja-build \ - numad \ - open-iscsi \ - perl-base \ - pkgconf \ - policykit-1 \ - python3 \ - python3-docutils \ - qemu-utils \ - scrub \ - sed \ - xsltproc && \ - eatmydata apt-get autoremove -y && \ - eatmydata apt-get autoclean -y && \ - sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ - dpkg-reconfigure locales - -ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers" -ENV LANG "en_US.UTF-8" -ENV MAKE "/usr/bin/make" -ENV NINJA "/usr/bin/ninja" -ENV PYTHON "/usr/bin/python3" - -RUN export DEBIAN_FRONTEND=noninteractive && \ - dpkg --add-architecture mipsel && \ - eatmydata apt-get update && \ - eatmydata apt-get dist-upgrade -y && \ - eatmydata apt-get install --no-install-recommends -y dpkg-dev && \ - eatmydata apt-get install --no-install-recommends -y \ - gcc-mipsel-linux-gnu \ - libacl1-dev:mipsel \ - libapparmor-dev:mipsel \ - libattr1-dev:mipsel \ - libaudit-dev:mipsel \ - libblkid-dev:mipsel \ - libc6-dev:mipsel \ - libcap-ng-dev:mipsel \ - libcurl4-gnutls-dev:mipsel \ - libdevmapper-dev:mipsel \ - libfuse-dev:mipsel \ - libglib2.0-dev:mipsel \ - libglusterfs-dev:mipsel \ - libgnutls28-dev:mipsel \ - libiscsi-dev:mipsel \ - libnl-3-dev:mipsel \ - libnl-route-3-dev:mipsel \ - libnuma-dev:mipsel \ - libparted-dev:mipsel \ - libpcap0.8-dev:mipsel \ - libpciaccess-dev:mipsel \ - librbd-dev:mipsel \ - libreadline-dev:mipsel \ - libsanlock-dev:mipsel \ - libsasl2-dev:mipsel \ - libselinux1-dev:mipsel \ - libssh-gcrypt-dev:mipsel \ - libssh2-1-dev:mipsel \ - libtirpc-dev:mipsel \ - libudev-dev:mipsel \ - libxml2-dev:mipsel \ - libyajl-dev:mipsel \ - systemtap-sdt-dev:mipsel && \ - eatmydata apt-get autoremove -y && \ - eatmydata apt-get autoclean -y && \ - mkdir -p /usr/local/share/meson/cross && \ - printf "[binaries]\n\ -c = '/usr/bin/mipsel-linux-gnu-gcc'\n\ -ar = '/usr/bin/mipsel-linux-gnu-gcc-ar'\n\ -strip = '/usr/bin/mipsel-linux-gnu-strip'\n\ -pkgconfig = '/usr/bin/mipsel-linux-gnu-pkg-config'\n\ -\n\ -[host_machine]\n\ -system = 'linux'\n\ -cpu_family = 'mips'\n\ -cpu = 'mipsel'\n\ -endian = 'little'\n" > /usr/local/share/meson/cross/mipsel-linux-gnu && \ - dpkg-query --showformat '${Package}_${Version}_${Architecture}\n' --show > /packages.txt && \ - mkdir -p /usr/libexec/ccache-wrappers && \ - ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-cc && \ - ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/mipsel-linux-gnu-gcc - -ENV ABI "mipsel-linux-gnu" -ENV MESON_OPTS "--cross-file=mipsel-linux-gnu" diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index e1ea87db1b..2beca51767 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -898,28 +898,6 @@ mips64el-debian-sid-local-env: NAME: debian-sid -mipsel-debian-sid-prebuilt-env: - extends: .cross_build_job_prebuilt_env - needs: - - job: mipsel-debian-sid-container - optional: true - allow_failure: false - variables: - CROSS: mipsel - JOB_OPTIONAL: 1 - NAME: debian-sid - -mipsel-debian-sid-local-env: - extends: .cross_build_job_local_env - needs: [] - allow_failure: false - variables: - CROSS: mipsel - IMAGE: docker.io/library/debian:sid-slim - JOB_OPTIONAL: 1 - NAME: debian-sid - - ppc64le-debian-sid-prebuilt-env: extends: .cross_build_job_prebuilt_env needs: diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml index 05d22f7336..2463d1a5aa 100644 --- a/ci/gitlab/containers.yml +++ b/ci/gitlab/containers.yml @@ -283,14 +283,6 @@ mips64el-debian-sid-container: NAME: debian-sid-cross-mips64el -mipsel-debian-sid-container: - extends: .container_job - allow_failure: false - variables: - JOB_OPTIONAL: 1 - NAME: debian-sid-cross-mipsel - - ppc64le-debian-sid-container: extends: .container_job allow_failure: false diff --git a/ci/manifest.yml b/ci/manifest.yml index 2af8e62f28..e115f45b2c 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -144,10 +144,6 @@ targets: containers: false builds: false - - arch: mipsel - containers: false - builds: false - - arch: ppc64le containers: false builds: false -- 2.41.0

2 1

[libvirt PATCH 01/15] util: properly deal with module vs. driver when binding device to driver
by Laine Stump 06 Nov '23

06 Nov '23

(Sigh, resent because I forgot to update the list address in the reply :-/) Sorry, I meant to respond to this earlier and forgot. Now I'm sending v2 of the patches, and wanted to make sure you didn't think I was just ignoring your comments :-) (since this patch is still there in V2) On 10/23/23 9:39 AM, Jason Gunthorpe wrote: > On Mon, Oct 23, 2023 at 12:54:37AM -0400, Laine Stump wrote: > >> When we recently gained the ability to manually specify a driver to >> bind to with virsh nodedev-detach, the fragility of this system became >> apparent - if a user gives the driver name as "vfio_pci", then we >> would modprobe the module, but then erroneously believe it hadn't been >> loaded because /sys/bus/pci/drivers/vfio_pci didn't exist. For manual >> specification of the driver name, this could be dealt with by telling >> the user "always use the correct name for the driver, don't assume >> that it is the same as the modulename", but it would still end up >> confusing people, especially since some drivers do use underscore in >> their name (e.g. the mlx5_vfio_pci driver/module). > > I think you are creating more confusion by allowing this. The driver > name from module.alias should be used consistently in its exact > format. But the name in the modules.alias file *is not* the name of the driver. It is the name of the module, and the name of the driver may or may not be the same - that's the entire reason this issue came to light. And in the end I don't do anything more than what modprobe itself does. (Well, actually that's not true, since modprobe never has to actually *use* the drivers that are implemented by the modules that it loads, it doesn't need to understand that the name of the driver may be different from the name of the module, and so it doesn't have to look at the link in /sys/modules/$modulename/drivers/pci:$drivername to get the proper name that must be written to sysfs to get the driver bound to the device. It just unilaterally decides that all horizontal lines in a module name are "_", and so it replaces all "-" with "_") Really it is modprobe's practice of auto-translating all "-" to "_", combined with the inconsistency of naming between module names and driver names that is causing the confusion; what this patch is doing is helping to clear up that confusion, not make it worse. Essentially, whether someone uses the module name or the driver name, libvirt will get the correct driver bound to the device. (and we do have to allow both module name and driver name; the former in cases where the module hasn't been loaded yet and so the driver isn't available, and the latter in cases where the driver is statically linked into the kernel, as discussed below). > > Log a 'did you mean XYZ" or something if it doesn't work out. > > Pass the "driver name" directly to modprobe and let it sort it out In the cases (e.g. vfio_pci/vfio-pci) where the module name and driver name mismatch only due to -/_, what you say will work as long as the *driver* name is used (i.e. "vfio-pci"), but if we use the name discovered from modules.alias ("vfio_pci") then the modprobe will succeed, but the bind will fail. And we can't just assume that the driver name will always have "-" in place of "_" and do an auto-replace in the name prior to binding the device to the driver, because some drivers (in particular, mlx5_vfio_pci/mlx5_vfio_pci) *don't* use "-" in the driver name. libvirt has to do *something* in order to work in both of these cases, and I think anything less than what I've done would be "half baked" (well, half *something*, but I'd rather not swear on a public forum :-)) > Forget about modules entirely in the libvirt level, don't even check > it. Yes, if we're manually specifying the driver, then (at least in the case of vfio-pci and mlx5_vfio_pci) it *does* work to always use the driver name (because modprobe will change vfio-pci to vfio_pci, and leave mlx5_vfio_pci alone). But when we're discovering the variant driver via modules.alias (which is the official method of finding the best VFIO variant driver for a device), we don't start out with the driver name, we start out with (a modalias string, that leads us to) the *module* name, not a driver name. And while modprobe will of course accept the name of the module to load, you can't use the module name to bind the driver to the kernel - you have to do *something* to derive the driver name from the module name. That's what this code does. (I haven't seen an example where module name and driver name have more differences than just "-" vs "_", and it appears to be convention to "not do that", however it theoretically is completely doable - the driver name is just a string in a C file. I'd rather not have my code break at some random time in the future when somebody writes such a driver.) > >> c) All of this is conveniently ignoring the possibility of a VFIO >> variant driver that is statically linked in the kernel. The entire >> design of variant driver auto-detection is based on doing a lookup >> in modules.alias, and that only lists *loadable modules* (not >> drivers), so unless I'm missing something, it would be impossible >> to auto-detect a VFIO variant driver that was statically >> linked. This is beyond libvirt's ability to fix; the best that >> could be done would be to manually specify the driver name in the >> libvirt config, which I suppose is better than nothing :-) > > Why? This seems wrong. Statically linked drivers appear in > /sys/bus/drivers/XX too Yes, they appear in /sys/bus/drivers. But there isn't (as far as I know so far) a way to programmatically associate a statically linked variant driver with a device using the information available from the running kernel. What I've been told until now is that the only way to find the proper VFIO variant driver for a particular device is to take the modalias string from that device's sysfs directory, and search for a line in the modules.alias file that starts with "alias vfio_pci:" and has the "most specific match" for the device's modalias - *that* is the name of the *module* that contains the best VFIO variant driver for the device. If a driver is statically linked into the kernel, then it doesn't have a module, so it doesn't get a line in modules.alias (does it? I suppose I should try that to verify, but it doesn't make sense), and so there is no way to identify that driver as being a match for a device. Or am I missing something? In this case, as I've said in the commit logs somewhere, it's still possible to use a statically linked variant driver for a device, you just have to manually specify the driver name rather than having code that discovers it (which is what you have to do for *all* variant drivers until the final patch of this series anyway :-)

1 0

[PATCH] build: suppress "ignoring duplicate libraries" warning on macOS
by Laine Stump 03 Nov '23

03 Nov '23

Xcode 15, which provides the compiler toolchain for building libvirt on macOS has switched to a new linker that warns about duplicated "-lblah" options on the ld commandline. In practice this is impossible to prevent in a large project, and also harmless. Fortunately the new ld command also has an option, -no_warn_duplicate_libraries, that supresses this harmless/pointless warning, meson has a simple way to check if that option is supported, and libvirt's meson.build files already have examples of adding an option to the ld commandline if it's available. Signed-off-by: Laine Stump <laine(a)redhat.com> --- meson.build | 4 ++++ src/meson.build | 1 + tests/meson.build | 1 + tools/meson.build | 1 + 4 files changed, 7 insertions(+) diff --git a/meson.build b/meson.build index dc0969abcc..a39f942617 100644 --- a/meson.build +++ b/meson.build @@ -542,6 +542,10 @@ libvirt_no_indirect = cc.get_supported_link_arguments([ '-Wl,--no-copy-dt-needed-entries', ]) +libvirt_no_warn_duplicate_libraries = cc.get_supported_link_arguments([ + '-Wl,-no_warn_duplicate_libraries', +]) + if host_machine.system() == 'windows' version_script_flags = '-Wl,' elif host_machine.system() == 'darwin' diff --git a/src/meson.build b/src/meson.build index 5fc4d03b4a..6538c43628 100644 --- a/src/meson.build +++ b/src/meson.build @@ -18,6 +18,7 @@ src_dep = declare_dependency( link_args: ( libvirt_relro + libvirt_no_indirect + + libvirt_no_warn_duplicate_libraries + coverage_flags + driver_modules_flags + win32_link_flags diff --git a/tests/meson.build b/tests/meson.build index b235c5f4dd..e1cd57654a 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -28,6 +28,7 @@ tests_dep = declare_dependency( ], link_args: ( libvirt_export_dynamic + + libvirt_no_warn_duplicate_libraries + libvirt_flat_namespace + coverage_flags ), diff --git a/tools/meson.build b/tools/meson.build index f2d58cfdcb..c72f760a1d 100644 --- a/tools/meson.build +++ b/tools/meson.build @@ -16,6 +16,7 @@ tools_dep = declare_dependency( libvirt_relro + libvirt_no_indirect + libvirt_no_undefined + + libvirt_no_warn_duplicate_libraries ), ) -- 2.41.0

3 2

[PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest
by Laine Stump 03 Nov '23

03 Nov '23

This environment variable is supposedly set according to the contents of ~/.CFUserTextEncoding, and certainly on MacOS 14 (Sonoma) it shows up in the environment, causing commandtest to fail. However, the value that is shown in $__CF_USER_TEXT_ENCODING during the test 1) is not in the environment of the shell the test is run from, and 2) doesn't match the contents of ~/.CFUserTextEncoding. It is true, though, that filtering out this environment setting from the test results permits commandtest to pass on MacOS 14. Signed-off-by: Laine Stump <laine(a)redhat.com> --- [*] There may be a better way to suppress this environment setting (maybe something done to prevent it from ever being added to the environment in the first place?), and that would be fine too. This patch does work though. [*] Andrea's patches to force rpcgen to generate ANSI C code are also required for the test suite to pass on MacOS 14. tests/commandhelper.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 9b56feb120..08ee48a3a8 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -169,9 +169,12 @@ static int printEnvironment(FILE *log) for (i = 0; i < length; i++) { /* Ignore the variables used to instruct the loader into - * behaving differently, as they could throw the tests off. */ - if (!STRPREFIX(newenv[i], "LD_")) + * behaving differently, as they could throw the tests off. + * Also ignore __CF_USER_TEXT_ENCODING, which is set by MacOS. */ + if (!STRPREFIX(newenv[i], "LD_") && + !STRPREFIX(newenv[i], "__CF_USER_TEXT_ENCODING=")) { fprintf(log, "ENV:%s\n", newenv[i]); + } } return 0; -- 2.41.0

3 10

[libvirt PATCH] qemu_process: fix crash in qemuSaveImageDecompressionStart
by Pavel Hrdina 03 Nov '23

03 Nov '23

Commit changing the code to allow passing NULL as @data into qemuSaveImageDecompressionStart() was not correct as it left the original call into the function as well. Introduced-by: 2f3e582a1ac1008eba8d43c751cdba8712dd1614 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2247754 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_process.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1ef032dbd2..b9267d8699 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8208,9 +8208,6 @@ qemuProcessStartWithMemoryState(virConnectPtr conn, } } - if (qemuSaveImageDecompressionStart(data, fd, &intermediatefd, &errbuf, &cmd) < 0) - return -1; - /* No cookie means libvirt which saved the domain was too old to mess up * the CPU definitions. */ -- 2.41.0

2 1

[PATCH 00/16] Farewell rpcgen
by Daniel P. Berrangé 03 Nov '23

03 Nov '23

This series something I was hacking on a little while back in an attempt to make our RPC layer more maintainable. There are many aspects I'm unhappy about with current code * When serializing a message we have no clue how big it will be, but xdrmem_create wants a fixed size, so we have to keep trying to serialize in a loop making it bigger each time * We don't control memory allocation/free'ing directly so we can't do a virSecureErase on fields inside the RPC message struct that handle secrets. * The XDR API is generally unpleasant to use as it is outside our virNetMessage object. Ideally we would be reading/writing directly from/to the virNetMessage buffer with APIs on virNetMessage,instead of indirectly via a XDR object. * We want more from XDR than it actually gives us. Our XDR protocol files have annotations to express what we want our code generator todo, or for ACLs. The relationship between the structs and the message numbers is implicit. Essentially we've defined our own language indirectly via comments, and then parse this with regexes which is horrid. * The code rpcgen creates is poor quality which we have to post-process to fix bugs/problems. It also lacks support for modern features like g_auto. Anyway, in a fit of rage I looked at the XDR RFC and thought.. This language is trivial, why do we need to outsource to rpcgen and libtirpc instead of dealing with it directly. This small series moves in that direction. It creates an XDR language lexer and parser, and then a code generator which emits code that is (nearly) identical to what rpcgen would emit. This is sufficient to eliminate rpcgen usage and support g_auto. Since we're still using libtirpc at this stage we can be confident we're still doing the same thing on the wire. I've got some unit tests too with the rpcgen generation to validate stuff. The next step is to change the code generator so that instead of generating code for libtirpc APIs, it will instead directly speak virNetMessage APIs. That would give us full control over our RPC stack guaranteed to be platform portable instead of fighting slight differences in RPC libraries (eg xdr_quad vs xdr_int64 madness). I was going to wait until I had written such code before sending this series, but I've got diverted onto other more important tasks. So here at least is what I have so far. After that foundation is done, we are in a place where we can actually do more innovative things. For example we can directly extend the XDR protocol language if we like, turning our magic comments into properly parsable constructs. With this, we would be in a position to replace our Perl RPC client/server dispatch code generators with something that is more supportable in Python. The python code would work with properly represented objects and formal parsers and not regexes and anonymous complex perl data structures. Daniel P. Berrangé (16): rpcgen: drop type-puning workarounds build-aux: skip E203 and W503 flake8 checks build-aux: introduce 'black' tool for python formatting rpcgen: add an XDR protocol lexer rpcgen: add an XDR protocol abstract syntax tree rpcgen: add an XDR protocol parser rpcgen: define a visitor API for XDR protocol specs rpcgen: add a C code generator for XDR protocol specs rpcgen: add test case for XDR serialization rpcgen: define entrypoint for running new rpcgen impl build: switch over to new rpc generator code rpcgen: add g_auto function support rpc: use g_auto for client RPC return parameters admin: use g_auto for client RPC return parameters remote: use g_auto for client RPC return parameters rpc: add helpers for XDR type serialization build-aux/Makefile.in | 1 + build-aux/meson.build | 5 + build-aux/syntax-check.mk | 42 +- libvirt.spec.in | 2 +- meson.build | 13 +- scripts/meson.build | 2 + scripts/rpcgen/main.py | 90 ++ scripts/rpcgen/meson.build | 16 + scripts/rpcgen/rpcgen/ast.py | 270 ++++++ scripts/rpcgen/rpcgen/generator.py | 509 ++++++++++++ scripts/rpcgen/rpcgen/lexer.py | 213 +++++ scripts/rpcgen/rpcgen/meson.build | 7 + scripts/rpcgen/rpcgen/parser.py | 497 +++++++++++ scripts/rpcgen/rpcgen/visitor.py | 156 ++++ scripts/rpcgen/tests/demo.c | 495 +++++++++++ scripts/rpcgen/tests/demo.h | 264 ++++++ scripts/rpcgen/tests/demo.x | 127 +++ scripts/rpcgen/tests/meson.build | 20 + scripts/rpcgen/tests/simple.x | 35 + scripts/rpcgen/tests/test_demo.c | 782 ++++++++++++++++++ scripts/rpcgen/tests/test_demo_enum.bin | Bin 0 -> 4 bytes .../tests/test_demo_enum_fixed_array.bin | Bin 0 -> 52 bytes .../tests/test_demo_enum_pointer_null.bin | Bin 0 -> 4 bytes .../tests/test_demo_enum_pointer_set.bin | Bin 0 -> 8 bytes .../rpcgen/tests/test_demo_enum_scalar.bin | Bin 0 -> 4 bytes .../test_demo_enum_variable_array_empty.bin | Bin 0 -> 4 bytes .../test_demo_enum_variable_array_set.bin | Bin 0 -> 16 bytes .../tests/test_demo_int_fixed_array.bin | Bin 0 -> 12 bytes .../tests/test_demo_int_pointer_null.bin | Bin 0 -> 4 bytes .../tests/test_demo_int_pointer_set.bin | Bin 0 -> 8 bytes scripts/rpcgen/tests/test_demo_int_scalar.bin | Bin 0 -> 4 bytes .../test_demo_int_variable_array_empty.bin | Bin 0 -> 4 bytes .../test_demo_int_variable_array_set.bin | Bin 0 -> 16 bytes .../tests/test_demo_opaque_fixed_array.bin | Bin 0 -> 12 bytes .../test_demo_opaque_variable_array_empty.bin | Bin 0 -> 4 bytes .../test_demo_opaque_variable_array_set.bin | Bin 0 -> 8 bytes .../test_demo_string_variable_array_empty.bin | Bin 0 -> 4 bytes .../test_demo_string_variable_array_set.bin | Bin 0 -> 12 bytes scripts/rpcgen/tests/test_demo_struct.bin | Bin 0 -> 8 bytes .../tests/test_demo_struct_fixed_array.bin | Bin 0 -> 136 bytes .../tests/test_demo_struct_pointer_null.bin | Bin 0 -> 4 bytes .../tests/test_demo_struct_pointer_set.bin | Bin 0 -> 12 bytes .../rpcgen/tests/test_demo_struct_scalar.bin | 1 + .../test_demo_struct_variable_array_empty.bin | Bin 0 -> 4 bytes .../test_demo_struct_variable_array_set.bin | Bin 0 -> 28 bytes .../tests/test_demo_test_struct_all_types.bin | Bin 0 -> 1752 bytes scripts/rpcgen/tests/test_demo_union_case.bin | Bin 0 -> 8 bytes .../rpcgen/tests/test_demo_union_default.bin | Bin 0 -> 8 bytes .../tests/test_demo_union_fixed_array.bin | Bin 0 -> 168 bytes .../tests/test_demo_union_no_default_case.bin | Bin 0 -> 8 bytes .../tests/test_demo_union_pointer_null.bin | Bin 0 -> 4 bytes .../tests/test_demo_union_pointer_set.bin | Bin 0 -> 12 bytes .../rpcgen/tests/test_demo_union_scalar.bin | Bin 0 -> 8 bytes .../test_demo_union_variable_array_empty.bin | Bin 0 -> 4 bytes .../test_demo_union_variable_array_set.bin | Bin 0 -> 28 bytes .../test_demo_union_void_default_case.bin | Bin 0 -> 8 bytes .../test_demo_union_void_default_default.bin | 1 + scripts/rpcgen/tests/test_generator.py | 60 ++ scripts/rpcgen/tests/test_lexer.py | 116 +++ scripts/rpcgen/tests/test_parser.py | 91 ++ src/admin/admin_remote.c | 50 +- src/admin/meson.build | 8 +- src/locking/meson.build | 8 +- src/logging/meson.build | 8 +- src/lxc/meson.build | 12 +- src/remote/meson.build | 8 +- src/remote/remote_driver.c | 754 ++++++----------- src/rpc/gendispatch.pl | 60 +- src/rpc/genprotocol.pl | 144 ---- src/rpc/meson.build | 9 +- src/rpc/virnetmessage.c | 704 ++++++++++++++++ src/rpc/virnetmessage.h | 88 ++ 72 files changed, 4897 insertions(+), 771 deletions(-) create mode 100755 scripts/rpcgen/main.py create mode 100644 scripts/rpcgen/meson.build create mode 100644 scripts/rpcgen/rpcgen/ast.py create mode 100644 scripts/rpcgen/rpcgen/generator.py create mode 100644 scripts/rpcgen/rpcgen/lexer.py create mode 100644 scripts/rpcgen/rpcgen/meson.build create mode 100644 scripts/rpcgen/rpcgen/parser.py create mode 100644 scripts/rpcgen/rpcgen/visitor.py create mode 100644 scripts/rpcgen/tests/demo.c create mode 100644 scripts/rpcgen/tests/demo.h create mode 100644 scripts/rpcgen/tests/demo.x create mode 100644 scripts/rpcgen/tests/meson.build create mode 100644 scripts/rpcgen/tests/simple.x create mode 100644 scripts/rpcgen/tests/test_demo.c create mode 100644 scripts/rpcgen/tests/test_demo_enum.bin create mode 100644 scripts/rpcgen/tests/test_demo_enum_fixed_array.bin create mode 100644 scripts/rpcgen/tests/test_demo_enum_pointer_null.bin create mode 100644 scripts/rpcgen/tests/test_demo_enum_pointer_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_enum_scalar.bin create mode 100644 scripts/rpcgen/tests/test_demo_enum_variable_array_empty.bin create mode 100644 scripts/rpcgen/tests/test_demo_enum_variable_array_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_int_fixed_array.bin create mode 100644 scripts/rpcgen/tests/test_demo_int_pointer_null.bin create mode 100644 scripts/rpcgen/tests/test_demo_int_pointer_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_int_scalar.bin create mode 100644 scripts/rpcgen/tests/test_demo_int_variable_array_empty.bin create mode 100644 scripts/rpcgen/tests/test_demo_int_variable_array_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_opaque_fixed_array.bin create mode 100644 scripts/rpcgen/tests/test_demo_opaque_variable_array_empty.bin create mode 100644 scripts/rpcgen/tests/test_demo_opaque_variable_array_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_string_variable_array_empty.bin create mode 100644 scripts/rpcgen/tests/test_demo_string_variable_array_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_struct.bin create mode 100644 scripts/rpcgen/tests/test_demo_struct_fixed_array.bin create mode 100644 scripts/rpcgen/tests/test_demo_struct_pointer_null.bin create mode 100644 scripts/rpcgen/tests/test_demo_struct_pointer_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_struct_scalar.bin create mode 100644 scripts/rpcgen/tests/test_demo_struct_variable_array_empty.bin create mode 100644 scripts/rpcgen/tests/test_demo_struct_variable_array_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_test_struct_all_types.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_case.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_default.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_fixed_array.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_no_default_case.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_pointer_null.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_pointer_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_scalar.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_variable_array_empty.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_variable_array_set.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_void_default_case.bin create mode 100644 scripts/rpcgen/tests/test_demo_union_void_default_default.bin create mode 100644 scripts/rpcgen/tests/test_generator.py create mode 100644 scripts/rpcgen/tests/test_lexer.py create mode 100644 scripts/rpcgen/tests/test_parser.py delete mode 100755 src/rpc/genprotocol.pl -- 2.39.1

3 27

[libvirt PATCH 00/11] ci: Build RPMs on MinGW
by Andrea Bolognani 03 Nov '23

03 Nov '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1059447352 The openSUSE Leap 15 job failed, but that's caused by an unrelated packaging issue: $ pkg-config --cflags libtirpc -I/usr/include/tirpc $ rpm -ql libtirpc-devel | grep usr/include /usr/include/netconfig.h /usr/include/rpc /usr/include/rpc/auth.h /usr/include/rpc/auth_des.h ... /usr/include/rpc/types.h /usr/include/rpc/xdr.h /usr/include/rpcsvc /usr/include/rpcsvc/crypt.h /usr/include/rpcsvc/crypt.x The CI updates towards the end depend on the following unmerged libvirt-ci changes: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/440 Andrea Bolognani (11): rpm: Disable expensive tests for MinGW builds rpm: Explicitly enable NLS support rpm: Rename module-init-tools -> kmod rpm: Explain a couple of BuildRequires rpm: Add libxml2 BuildRequires for xmllint rpm: Shuffle BuildRequires around rpm: Split call to mingw_debug_package rpm: Introduce with_mingw32/with_mingw64 rpm: Introduce with_native ci: Refresh generated files ci: Build RPMs on MinGW .gitlab-ci.yml | 11 +- ci/buildenv/fedora-38-cross-mingw32.sh | 1 + ci/buildenv/fedora-38-cross-mingw64.sh | 1 + ci/buildenv/fedora-rawhide-cross-mingw32.sh | 1 + ci/buildenv/fedora-rawhide-cross-mingw64.sh | 1 + .../fedora-38-cross-mingw32.Dockerfile | 1 + .../fedora-38-cross-mingw64.Dockerfile | 1 + .../fedora-rawhide-cross-mingw32.Dockerfile | 1 + .../fedora-rawhide-cross-mingw64.Dockerfile | 1 + ci/jobs.sh | 19 +- libvirt.spec.in | 470 ++++++++++-------- 11 files changed, 296 insertions(+), 212 deletions(-) -- 2.41.0

2 18

[libvirt PATCH v2 0/1] rpc: Make rpcgen produce ANSI C code
by Andrea Bolognani 03 Nov '23

03 Nov '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1060019687 Changes from [v1] * retain portable-rpcgen support. [v1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/2A3K… Andrea Bolognani (1): rpc: Make rpcgen produce ANSI C code src/rpc/genprotocol.pl | 2 ++ 1 file changed, 2 insertions(+) -- 2.41.0

2 2

[libvirt PATCH 0/2] rpc: Make rpcgen produce ANSI C code
by Andrea Bolognani 03 Nov '23

03 Nov '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1059558331 Should make it possible to build libvirt on macOS 14, where it currently fails with src/rpc/virnetprotocol.c:13:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype] xdr_virNetMessageType(xdrs, objp) Andrea Bolognani (2): rpc: Drop support for portable-rpcgen rpc: Make rpcgen produce ANSI C code meson.build | 12 +----------- src/rpc/genprotocol.pl | 5 ++--- 2 files changed, 3 insertions(+), 14 deletions(-) -- 2.41.0

3 5

Release of libvirt-9.9.0
by Jiri Denemark 02 Nov '23

02 Nov '23

The 9.9.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * QEMU: implement reverting external snapshots Reverting external snapshots is now possible using the existing API ``virDomainSnapshotRevert()``. Management application can check host capabilities for ``<externalSnapshot/>`` element within the list of guest features to see if the current libvirt supports both deleting and reverting external snapshots. * virsh: add ``console --resume`` support The ``virsh console`` subcommand now accepts a ``--resume`` option. This will resume a paused guest after connecting to the console. * Improvements * virsh: Improve ``virsh start --console`` behavior The ``virsh start --console`` now tries to connect to the guest console before starting the vCPUs. * virsh: Improve ``virsh create --console`` behavior The ``virsh create --console`` now tries to connect to the guest console before starting the vCPUs. Enjoy. Jirka

4 4

Re: [PATCH v8 0/4] pci hotplug tracking
by Vladimir Sementsov-Ogievskiy 02 Nov '23

02 Nov '23

On 02.11.23 14:31, Michael S. Tsirkin wrote: > On Thu, Oct 05, 2023 at 12:29:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Main thing this series does is DEVICE_ON event - a counter-part to >> DEVICE_DELETED. A guest-driven event that device is powered-on. >> Details are in patch 2. The new event is paried with corresponding >> command query-hotplug. > > Several things questionable here: > 1. depending on guest activity you can get as many > DEVICE_ON events as you like No, I've made it so it may be sent only once per device > 2. it's just for shpc and native pcie - things are > confusing enough for management, we should make sure > it can work for all devices Agree, I'm thinking about it > 3. what about non hotpluggable devices? do we want the event for them? > I think, yes, especially if we make async=true|false flag for device_add, so that successful device_add must be always followed by DEVICE_ON - like device_del is followed by DEVICE_DELETED. Maybe, to generalize, it should be called not DEVICE_ON (which mostly relate to hotplug controller statuses) but DEVICE_ADDED - a full counterpart for DEVICE_DELETED. > > I feel this needs actual motivation so we can judge what's the > right way to do it. My first motivation for this series was the fact that successful device_add doesn't guarantee that hard disk successfully hotplugged to the guest. It relates to some problems with shpc/pcie hotplug we had in the past, and they are mostly fixed. But still, for management tool it's good to understand that all actions related to hotplug controller are done and we have "green light". Recently new motivation come, as I described in my "ping" letter <6bd19a07-5224-464d-b54d-1d738f5ba8f7(a)yandex-team.ru>, that we have a performance degradation because of 7bed89958bfbf40df, which introduces drain_call_rcu() in device_add, to make it more synchronous. So, my suggestion is make it instead more asynchronous (probably with special flag) and rely on DEVICE_ON event. > > >> >> v8: >> - improve naming, wording and style >> - make new QMP interface experimental >> >> >> Vladimir Sementsov-Ogievskiy (4): >> qapi/qdev.json: unite DEVICE_* event data into single structure >> qapi: add DEVICE_ON and query-hotplug infrastructure >> shpc: implement DEVICE_ON event and query-hotplug >> pcie: implement DEVICE_ON event and query-hotplug >> >> hw/core/hotplug.c | 12 +++ >> hw/pci-bridge/pci_bridge_dev.c | 14 +++ >> hw/pci-bridge/pcie_pci_bridge.c | 1 + >> hw/pci/pcie.c | 83 +++++++++++++++ >> hw/pci/pcie_port.c | 1 + >> hw/pci/shpc.c | 86 +++++++++++++++ >> include/hw/hotplug.h | 11 ++ >> include/hw/pci/pci_bridge.h | 2 + >> include/hw/pci/pcie.h | 2 + >> include/hw/pci/shpc.h | 2 + >> include/hw/qdev-core.h | 7 ++ >> include/monitor/qdev.h | 6 ++ >> qapi/qdev.json | 178 +++++++++++++++++++++++++++++--- >> softmmu/qdev-monitor.c | 58 +++++++++++ >> 14 files changed, 451 insertions(+), 12 deletions(-) >> >> -- >> 2.34.1 > -- Best regards, Vladimir

2 4

Re: [PATCH v8 0/4] pci hotplug tracking
by Vladimir Sementsov-Ogievskiy 02 Nov '23

02 Nov '23

[cc Peter, Nikolay and libvirt list] On 02.11.23 11:06, Vladimir Sementsov-Ogievskiy wrote: > Ping. > > And some addition. We have the case, when the commit > > commit 7bed89958bfbf40df9ca681cefbdca63abdde39d > Author: Maxim Levitsky <mlevitsk(a)redhat.com> > Date: Tue Oct 6 14:38:58 2020 +0200 > > device_core: use drain_call_rcu in in qmp_device_add > Soon, a device removal might only happen on RCU callback execution. > This is okay for device-del which provides a DEVICE_DELETED event, > but not for the failure case of device-add. To avoid changing > monitor semantics, just drain all pending RCU callbacks on error. > > sensibly slows down vm initialization (several calls to device_add of pc-dimm). > > And looking at commit message, I see that what I do in the series is exactly a suggestion to change monitor semantics. > > What do you think? > > Maybe we need a boolean "async" parameter for device_add, which will turn off drain_call_rcu() call and rely on user to handle DEVICE_ON? > > On 05.10.23 12:29, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Main thing this series does is DEVICE_ON event - a counter-part to >> DEVICE_DELETED. A guest-driven event that device is powered-on. >> Details are in patch 2. The new event is paried with corresponding >> command query-hotplug. >> >> >> v8: >> - improve naming, wording and style >> - make new QMP interface experimental >> >> >> Vladimir Sementsov-Ogievskiy (4): >> qapi/qdev.json: unite DEVICE_* event data into single structure >> qapi: add DEVICE_ON and query-hotplug infrastructure >> shpc: implement DEVICE_ON event and query-hotplug >> pcie: implement DEVICE_ON event and query-hotplug >> >> hw/core/hotplug.c | 12 +++ >> hw/pci-bridge/pci_bridge_dev.c | 14 +++ >> hw/pci-bridge/pcie_pci_bridge.c | 1 + >> hw/pci/pcie.c | 83 +++++++++++++++ >> hw/pci/pcie_port.c | 1 + >> hw/pci/shpc.c | 86 +++++++++++++++ >> include/hw/hotplug.h | 11 ++ >> include/hw/pci/pci_bridge.h | 2 + >> include/hw/pci/pcie.h | 2 + >> include/hw/pci/shpc.h | 2 + >> include/hw/qdev-core.h | 7 ++ >> include/monitor/qdev.h | 6 ++ >> qapi/qdev.json | 178 +++++++++++++++++++++++++++++--- >> softmmu/qdev-monitor.c | 58 +++++++++++ >> 14 files changed, 451 insertions(+), 12 deletions(-) >> > -- Best regards, Vladimir

1 0

ANNOUNCE: Mailing list move complete
by Daniel P. Berrangé 01 Nov '23

01 Nov '23

This is an announcement to the effect that the mailing list move is now complete. TL;DR the new list addresses are: * announce(a)lists.libvirt.org (formerly libvirt-announce(a)redhat.com) Low volume, announcements of releases and other important info * users(a)lists.libvirt.org (formerly libvirt-users(a)redhat.com) End user questions and discussions and collaboration * devel(a)lists.libvirt.org (formerly libvir-list(a)redhat.com) Patch submission for development of main project * security(a)lists.libvirt.org (formerly libvir-security(a)redhat.com) Submission of security sensitive bug reports The online archive and membership mgmt interface is https://lists.libvirt.org In my original announcement[1] I mentioned that people would need to manually re-subscribe. Due to a mixup in communications, our IT admins went ahead and migrated across the existing entire subscriber base for all lists. Thus there is NO need to re-subscribe to any of the lists. If you were doing filtering of mail, you may need to update filters for the new list ID matches. With the new list server, HyperKitty is providing the web interface. Thus if you wish to interact with the lists entire via the browser this is now possible. Note that it requires you to register for an account and set a password, even if you are already a list subscriber. If you mistakenly send to the old lists you should receive an auto-reply about the moved destinations. Note, we had some technical issues on Thursday/Friday, so if you sent mails on those two days they probably will not have reached any lists, and so you may wish to re-send them. With regards, Daniel [1] https://listman.redhat.com/archives/libvirt-announce/2023-October/000650.ht… -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

2 2

RFC: Switch to a date-based versioning scheme
by Andrea Bolognani 01 Nov '23

01 Nov '23

Since we're just a few months away from the 10.0.0 release, I thought it would be a good time to bring up this idea. Can we move to date-based version numbers? I suggest having libvirt 24.01.0 instead of 10.0.0 24.03.0 10.1.0 24.04.0 10.2.0 ... 24.11.0 10.9.0 24.12.0 10.10.0 The big advantage is that, once version numbers are obviously date-based, any expectation of them being interpreted according to semver[1] are immediately gone. Of course semver doesn't make sense for us, given our extremely strong backwards compatibility guarantees, and that's exactly why we've left it behind with 2.0.0; however, that's something that's not immediately obvious to someone who's not very involved with our development process, and regarless of our intentions libvirt version numbers *will* be mistakenly assumed to be semver-compliant on occasion. People are quite used to date-based version numbers thanks to Ubuntu having used them for almost two decades, so I don't think anyone is going to be confused by the move. And since our release schedule is already date-based, having the versioning scheme match that just makes perfect sense IMO. Up until now, one could have argued in favor of the current versioning scheme because of the single-digit major version component, but that's going away next year regardless, which makes this the perfect time to raise the topic :) Thoughts? [1] https://semver.org/ -- Andrea Bolognani / Red Hat / Virtualization

5 10

[libvirt PATCH] src: Remove duplicated VIR_REQUIRE_FLAG_GOTO() call
by Andrea Bolognani 31 Oct '23

31 Oct '23

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/libvirt-domain.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6616294fc1..58e1e5ea8d 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -4221,10 +4221,6 @@ virDomainMigrate3(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC, error); - VIR_REQUIRE_FLAG_GOTO(VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES, - VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC, - error); - if (flags & VIR_MIGRATE_PEER2PEER) { virReportInvalidArg(flags, "%s", _("use virDomainMigrateToURI3 for peer-to-peer migration")); -- 2.41.0

2 1

[libvirt PATCH v4] hypervisor: Move interface mgmt methods to hypervisor
by Praveen K Paladugu 30 Oct '23

30 Oct '23

Move guest interface management methods from qemu to hypervisor. These methods will be shared by networking support in ch driver. Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com> --- v4: * logging and formatting fixes v3: * Moved qemuInterfaceStopDevice/s methods into hypervisor, to keep all the related methods together. Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com> --- po/POTFILES | 1 + src/hypervisor/domain_interface.c | 370 ++++++++++++++++++++++++++++++ src/hypervisor/domain_interface.h | 41 ++++ src/hypervisor/meson.build | 1 + src/libvirt_private.syms | 8 + src/qemu/qemu_command.c | 6 +- src/qemu/qemu_hotplug.c | 5 +- src/qemu/qemu_interface.c | 339 +-------------------------- src/qemu/qemu_interface.h | 11 - src/qemu/qemu_process.c | 5 +- 10 files changed, 436 insertions(+), 351 deletions(-) create mode 100644 src/hypervisor/domain_interface.c create mode 100644 src/hypervisor/domain_interface.h diff --git a/po/POTFILES b/po/POTFILES index 3a51aea5cb..023c041f61 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -92,6 +92,7 @@ src/hyperv/hyperv_util.c src/hyperv/hyperv_wmi.c src/hypervisor/domain_cgroup.c src/hypervisor/domain_driver.c +src/hypervisor/domain_interface.c src/hypervisor/virhostdev.c src/interface/interface_backend_netcf.c src/interface/interface_backend_udev.c diff --git a/src/hypervisor/domain_interface.c b/src/hypervisor/domain_interface.c new file mode 100644 index 0000000000..07a83d2034 --- /dev/null +++ b/src/hypervisor/domain_interface.c @@ -0,0 +1,370 @@ +/* + * Copyright (C) 2015-2016 Red Hat, Inc. + * Copyright IBM Corp. 2014 + * + * domain_interface.c: methods to manage guest/domain interfaces + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + */ + +#include <config.h> + +#include "domain_audit.h" +#include "domain_conf.h" +#include "domain_interface.h" +#include "domain_nwfilter.h" +#include "network_conf.h" +#include "viralloc.h" +#include "virconftypes.h" +#include "virebtables.h" +#include "virfile.h" +#include "virlog.h" +#include "virmacaddr.h" +#include "virnetdevbridge.h" +#include "virnetdevtap.h" + +#define VIR_FROM_THIS VIR_FROM_DOMAIN + +VIR_LOG_INIT("domain.interface"); + +bool +virDomainInterfaceIsVnetCompatModel(const virDomainNetDef *net) +{ + return (virDomainNetIsVirtioModel(net) || + net->model == VIR_DOMAIN_NET_MODEL_E1000E || + net->model == VIR_DOMAIN_NET_MODEL_IGB || + net->model == VIR_DOMAIN_NET_MODEL_VMXNET3); +} + +/* virDomainInterfaceEthernetConnect: + * @def: the definition of the VM + * @net: a net definition in the VM + * @ebtables: ebtales context + * @macFilter: whether driver support mac Filtering + * @privileged: whether running as privileged user + * @tapfd: array of file descriptor return value for the new device + * @tapfdsize: number of file descriptors in @tapfd + * + * Called *only* called if actualType is VIR_DOMAIN_NET_TYPE_ETHERNET + * (i.e. if the connection is made with a tap device) + */ +int +virDomainInterfaceEthernetConnect(virDomainDef *def, + virDomainNetDef *net, + ebtablesContext *ebtables, + bool macFilter, + bool privileged, + int *tapfd, + size_t tapfdSize) +{ + virMacAddr tapmac; + int ret = -1; + unsigned int tap_create_flags = VIR_NETDEV_TAP_CREATE_IFUP; + bool template_ifname = false; + const char *tunpath = "/dev/net/tun"; + const char *auditdev = tunpath; + + if (net->backend.tap) { + tunpath = net->backend.tap; + if (!privileged) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("cannot use custom tap device in session mode")); + goto cleanup; + } + } + + if (virDomainInterfaceIsVnetCompatModel(net)) + tap_create_flags |= VIR_NETDEV_TAP_CREATE_VNET_HDR; + + if (net->managed_tap == VIR_TRISTATE_BOOL_NO) { + if (!net->ifname) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("target dev must be supplied when managed='no'")); + goto cleanup; + } + if (virNetDevExists(net->ifname) != 1) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("target managed='no' but specified dev doesn't exist")); + goto cleanup; + } + + tap_create_flags |= VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING; + + if (virNetDevMacVLanIsMacvtap(net->ifname)) { + auditdev = net->ifname; + if (virNetDevMacVLanTapOpen(net->ifname, tapfd, tapfdSize) < 0) + goto cleanup; + if (virNetDevMacVLanTapSetup(tapfd, tapfdSize, + virDomainInterfaceIsVnetCompatModel(net)) < 0) { + goto cleanup; + } + } else { + if (virNetDevTapCreate(&net->ifname, tunpath, tapfd, tapfdSize, + tap_create_flags) < 0) + goto cleanup; + } + } else { + + if (!net->ifname) + template_ifname = true; + + if (virNetDevTapCreate(&net->ifname, tunpath, tapfd, tapfdSize, + tap_create_flags) < 0) { + goto cleanup; + } + + /* The tap device's MAC address cannot match the MAC address + * used by the guest. This results in "received packet on + * vnetX with own address as source address" error logs from + * the kernel. + */ + virMacAddrSet(&tapmac, &net->mac); + if (tapmac.addr[0] == 0xFE) + tapmac.addr[0] = 0xFA; + else + tapmac.addr[0] = 0xFE; + + if (virNetDevSetMAC(net->ifname, &tapmac) < 0) + goto cleanup; + + if (virNetDevSetOnline(net->ifname, true) < 0) + goto cleanup; + } + + if (net->script && + virNetDevRunEthernetScript(net->ifname, net->script) < 0) + goto cleanup; + + if (macFilter && + ebtablesAddForwardAllowIn(ebtables, + net->ifname, + &net->mac) < 0) + goto cleanup; + + if (net->filter && + virDomainConfNWFilterInstantiate(def->name, def->uuid, net, false) < 0) { + goto cleanup; + } + + virDomainAuditNetDevice(def, net, auditdev, true); + + ret = 0; + + cleanup: + if (ret < 0) { + size_t i; + + virDomainAuditNetDevice(def, net, auditdev, false); + for (i = 0; i < tapfdSize && tapfd[i] >= 0; i++) + VIR_FORCE_CLOSE(tapfd[i]); + if (template_ifname) + VIR_FREE(net->ifname); + } + + return ret; +} + +/** + * virDomainInterfaceStartDevice: + * @net: net device to start + * + * Based upon the type of device provided, perform the appropriate + * work to completely activate the device and make it reachable from + * the rest of the network. + */ +int +virDomainInterfaceStartDevice(virDomainNetDef *net) +{ + virDomainNetType actualType = virDomainNetGetActualType(net); + + switch (actualType) { + case VIR_DOMAIN_NET_TYPE_BRIDGE: + case VIR_DOMAIN_NET_TYPE_NETWORK: + if (virDomainNetGetActualBridgeMACTableManager(net) + == VIR_NETWORK_BRIDGE_MAC_TABLE_MANAGER_LIBVIRT) { + /* libvirt is managing the FDB of the bridge this device + * is attaching to, so we have turned off learning and + * unicast_flood on the device to prevent the kernel from + * adding any FDB entries for it. This means we need to + * add an fdb entry ourselves, using the MAC address from + * the interface config. + */ + if (virNetDevBridgeFDBAdd(&net->mac, net->ifname, + VIR_NETDEVBRIDGE_FDB_FLAG_MASTER | + VIR_NETDEVBRIDGE_FDB_FLAG_TEMP) < 0) + return -1; + } + break; + + case VIR_DOMAIN_NET_TYPE_DIRECT: { + const char *physdev = virDomainNetGetActualDirectDev(net); + bool isOnline = true; + + /* set the physdev online if necessary. It may already be up, + * in which case we shouldn't re-up it just in case that causes + * some sort of "blip" in the physdev's status. + */ + if (physdev && virNetDevGetOnline(physdev, &isOnline) < 0) + return -1; + if (!isOnline && virNetDevSetOnline(physdev, true) < 0) + return -1; + + /* macvtap devices share their MAC address with the guest + * domain, and if they are set online prior to the domain CPUs + * being started, the host may send out traffic from this + * device that could confuse other entities on the network (in + * particular, if this new domain is the destination of a + * migration, and the source domain is still running, another + * host may mistakenly direct traffic for the guest to the + * destination domain rather than source domain). To prevent + * this, we create the macvtap device with IFF_UP false + * (i.e. "offline") then wait to bring it online until just as + * we are starting the domain CPUs. + */ + if (virNetDevSetOnline(net->ifname, true) < 0) + return -1; + break; + } + + case VIR_DOMAIN_NET_TYPE_ETHERNET: + if (virNetDevIPInfoAddToDev(net->ifname, &net->hostIP) < 0) + return -1; + + break; + + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_VHOSTUSER: + case VIR_DOMAIN_NET_TYPE_SERVER: + case VIR_DOMAIN_NET_TYPE_CLIENT: + case VIR_DOMAIN_NET_TYPE_MCAST: + case VIR_DOMAIN_NET_TYPE_UDP: + case VIR_DOMAIN_NET_TYPE_INTERNAL: + case VIR_DOMAIN_NET_TYPE_HOSTDEV: + case VIR_DOMAIN_NET_TYPE_VDPA: + case VIR_DOMAIN_NET_TYPE_NULL: + case VIR_DOMAIN_NET_TYPE_VDS: + case VIR_DOMAIN_NET_TYPE_LAST: + /* these types all require no action */ + break; + } + + return 0; +} + +/** + * virDomainInterfaceStartDevices: + * @def: domain definition + * + * Set all ifaces associated with this domain to the online state. + */ +int +virDomainInterfaceStartDevices(virDomainDef *def) +{ + size_t i; + + for (i = 0; i < def->nnets; i++) { + if (virDomainInterfaceStartDevice(def->nets[i]) < 0) + return -1; + } + return 0; +} + +/** + * virDomainInterfaceStopDevice: + * @net: net device to stop + * + * Based upon the type of device provided, perform the appropriate + * work to deactivate the device so that packets aren't forwarded to + * it from the rest of the network. + */ +int +virDomainInterfaceStopDevice(virDomainNetDef *net) +{ + virDomainNetType actualType = virDomainNetGetActualType(net); + + switch (actualType) { + case VIR_DOMAIN_NET_TYPE_BRIDGE: + case VIR_DOMAIN_NET_TYPE_NETWORK: + if (virDomainNetGetActualBridgeMACTableManager(net) + == VIR_NETWORK_BRIDGE_MAC_TABLE_MANAGER_LIBVIRT) { + /* remove the FDB entries that were added during + * virDomainInterfaceStartDevices() + */ + if (virNetDevBridgeFDBDel(&net->mac, net->ifname, + VIR_NETDEVBRIDGE_FDB_FLAG_MASTER | + VIR_NETDEVBRIDGE_FDB_FLAG_TEMP) < 0) + return -1; + } + break; + + case VIR_DOMAIN_NET_TYPE_DIRECT: { + const char *physdev = virDomainNetGetActualDirectDev(net); + + /* macvtap interfaces need to be marked !IFF_UP (ie "down") to + * prevent any host-generated traffic sent from this interface + * from putting bad info into the arp caches of other machines + * on this network. + */ + if (virNetDevSetOnline(net->ifname, false) < 0) + return -1; + + /* also mark the physdev down for passthrough macvtap, as the + * physdev has the same MAC address as the macvtap device. + */ + if (virDomainNetGetActualDirectMode(net) == + VIR_NETDEV_MACVLAN_MODE_PASSTHRU && + physdev && virNetDevSetOnline(physdev, false) < 0) + return -1; + break; + } + + case VIR_DOMAIN_NET_TYPE_ETHERNET: + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_VHOSTUSER: + case VIR_DOMAIN_NET_TYPE_SERVER: + case VIR_DOMAIN_NET_TYPE_CLIENT: + case VIR_DOMAIN_NET_TYPE_MCAST: + case VIR_DOMAIN_NET_TYPE_UDP: + case VIR_DOMAIN_NET_TYPE_INTERNAL: + case VIR_DOMAIN_NET_TYPE_HOSTDEV: + case VIR_DOMAIN_NET_TYPE_VDPA: + case VIR_DOMAIN_NET_TYPE_NULL: + case VIR_DOMAIN_NET_TYPE_VDS: + case VIR_DOMAIN_NET_TYPE_LAST: + /* these types all require no action */ + break; + } + + return 0; +} + +/** + * virDomainInterfaceStopDevices: + * @def: domain definition + * + * Make all interfaces associated with this domain inaccessible from + * the rest of the network. + */ +int +virDomainInterfaceStopDevices(virDomainDef *def) +{ + size_t i; + + for (i = 0; i < def->nnets; i++) { + if (virDomainInterfaceStopDevice(def->nets[i]) < 0) + return -1; + } + return 0; +} diff --git a/src/hypervisor/domain_interface.h b/src/hypervisor/domain_interface.h new file mode 100644 index 0000000000..68bf2ae51d --- /dev/null +++ b/src/hypervisor/domain_interface.h @@ -0,0 +1,41 @@ +/* + * Copyright (C) 2015-2016 Red Hat, Inc. + * Copyright IBM Corp. 2014 + * + * domain_interface.h: methods to manage guest/domain interfaces + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + */ + +#pragma once + +#include "virebtables.h" + +int +virDomainInterfaceEthernetConnect(virDomainDef *def, + virDomainNetDef *net, + ebtablesContext *ebtables, + bool macFilter, + bool privileged, + int *tapfd, + size_t tapfdSize); + +bool +virDomainInterfaceIsVnetCompatModel(const virDomainNetDef *net); + +int virDomainInterfaceStartDevice(virDomainNetDef *net); +int virDomainInterfaceStartDevices(virDomainDef *def); +int virDomainInterfaceStopDevice(virDomainNetDef *net); +int virDomainInterfaceStopDevices(virDomainDef *def); diff --git a/src/hypervisor/meson.build b/src/hypervisor/meson.build index f35565b16b..819a9a82a2 100644 --- a/src/hypervisor/meson.build +++ b/src/hypervisor/meson.build @@ -1,6 +1,7 @@ hypervisor_sources = [ 'domain_cgroup.c', 'domain_driver.c', + 'domain_interface.c', 'virclosecallbacks.c', 'virhostdev.c', ] diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 553b01b8c0..b7f329be43 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1630,6 +1630,14 @@ virDomainDriverNodeDeviceReset; virDomainDriverParseBlkioDeviceStr; virDomainDriverSetupPersistentDefBlkioParams; +# hypervisor/domain_interface.h +virDomainInterfaceEthernetConnect; +virDomainInterfaceIsVnetCompatModel; +virDomainInterfaceStartDevice; +virDomainInterfaceStartDevices; +virDomainInterfaceStopDevice; +virDomainInterfaceStopDevices; + # hypervisor/virclosecallbacks.h virCloseCallbacksDomainAdd; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index fd0f12f304..036f6ba2e5 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -43,6 +43,7 @@ #include "domain_nwfilter.h" #include "domain_addr.h" #include "domain_conf.h" +#include "domain_interface.h" #include "netdev_bandwidth_conf.h" #include "virnetdevopenvswitch.h" #include "device_conf.h" @@ -8505,7 +8506,10 @@ qemuBuildInterfaceConnect(virDomainObj *vm, break; case VIR_DOMAIN_NET_TYPE_ETHERNET: - if (qemuInterfaceEthernetConnect(vm->def, priv->driver, net, + if (virDomainInterfaceEthernetConnect(vm->def, net, + priv->driver->ebtables, + priv->driver->config->macFilter, + priv->driver->privileged, tapfd, tapfdSize) < 0) return -1; vhostfd = true; diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index fec7c4be4e..63a130c201 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -39,6 +39,7 @@ #include "qemu_virtiofs.h" #include "domain_audit.h" #include "domain_cgroup.h" +#include "domain_interface.h" #include "netdev_bandwidth_conf.h" #include "domain_nwfilter.h" #include "virlog.h" @@ -1272,7 +1273,7 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver, } /* Set device online immediately */ - if (qemuInterfaceStartDevice(net) < 0) + if (virDomainInterfaceStartDevice(net) < 0) goto cleanup; qemuDomainInterfaceSetDefaultQDisc(driver, net); @@ -4772,7 +4773,7 @@ qemuDomainRemoveNetDevice(virQEMUDriver *driver, * affect the parent device (e.g. macvtap passthrough mode sets * the parent device offline) */ - ignore_value(qemuInterfaceStopDevice(net)); + ignore_value(virDomainInterfaceStopDevice(net)); qemuDomainObjEnterMonitor(vm); if (qemuMonitorRemoveNetdev(priv->mon, hostnet_name) < 0) { diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c index 8856bb95a8..c2007c7043 100644 --- a/src/qemu/qemu_interface.c +++ b/src/qemu/qemu_interface.c @@ -24,6 +24,7 @@ #include "network_conf.h" #include "domain_audit.h" #include "domain_nwfilter.h" +#include "domain_interface.h" #include "qemu_interface.h" #include "viralloc.h" #include "virlog.h" @@ -41,211 +42,6 @@ VIR_LOG_INIT("qemu.qemu_interface"); -/** - * qemuInterfaceStartDevice: - * @net: net device to start - * - * Based upon the type of device provided, perform the appropriate - * work to completely activate the device and make it reachable from - * the rest of the network. - */ -int -qemuInterfaceStartDevice(virDomainNetDef *net) -{ - virDomainNetType actualType = virDomainNetGetActualType(net); - - switch (actualType) { - case VIR_DOMAIN_NET_TYPE_BRIDGE: - case VIR_DOMAIN_NET_TYPE_NETWORK: - if (virDomainNetGetActualBridgeMACTableManager(net) - == VIR_NETWORK_BRIDGE_MAC_TABLE_MANAGER_LIBVIRT) { - /* libvirt is managing the FDB of the bridge this device - * is attaching to, so we have turned off learning and - * unicast_flood on the device to prevent the kernel from - * adding any FDB entries for it. This means we need to - * add an fdb entry ourselves, using the MAC address from - * the interface config. - */ - if (virNetDevBridgeFDBAdd(&net->mac, net->ifname, - VIR_NETDEVBRIDGE_FDB_FLAG_MASTER | - VIR_NETDEVBRIDGE_FDB_FLAG_TEMP) < 0) - return -1; - } - break; - - case VIR_DOMAIN_NET_TYPE_DIRECT: { - const char *physdev = virDomainNetGetActualDirectDev(net); - bool isOnline = true; - - /* set the physdev online if necessary. It may already be up, - * in which case we shouldn't re-up it just in case that causes - * some sort of "blip" in the physdev's status. - */ - if (physdev && virNetDevGetOnline(physdev, &isOnline) < 0) - return -1; - if (!isOnline && virNetDevSetOnline(physdev, true) < 0) - return -1; - - /* macvtap devices share their MAC address with the guest - * domain, and if they are set online prior to the domain CPUs - * being started, the host may send out traffic from this - * device that could confuse other entities on the network (in - * particular, if this new domain is the destination of a - * migration, and the source domain is still running, another - * host may mistakenly direct traffic for the guest to the - * destination domain rather than source domain). To prevent - * this, we create the macvtap device with IFF_UP false - * (i.e. "offline") then wait to bring it online until just as - * we are starting the domain CPUs. - */ - if (virNetDevSetOnline(net->ifname, true) < 0) - return -1; - break; - } - - case VIR_DOMAIN_NET_TYPE_ETHERNET: - if (virNetDevIPInfoAddToDev(net->ifname, &net->hostIP) < 0) - return -1; - - break; - - case VIR_DOMAIN_NET_TYPE_USER: - case VIR_DOMAIN_NET_TYPE_VHOSTUSER: - case VIR_DOMAIN_NET_TYPE_SERVER: - case VIR_DOMAIN_NET_TYPE_CLIENT: - case VIR_DOMAIN_NET_TYPE_MCAST: - case VIR_DOMAIN_NET_TYPE_UDP: - case VIR_DOMAIN_NET_TYPE_INTERNAL: - case VIR_DOMAIN_NET_TYPE_HOSTDEV: - case VIR_DOMAIN_NET_TYPE_VDPA: - case VIR_DOMAIN_NET_TYPE_NULL: - case VIR_DOMAIN_NET_TYPE_VDS: - case VIR_DOMAIN_NET_TYPE_LAST: - /* these types all require no action */ - break; - } - - return 0; -} - -/** - * qemuInterfaceStartDevices: - * @def: domain definition - * - * Set all ifaces associated with this domain to the online state. - */ -int -qemuInterfaceStartDevices(virDomainDef *def) -{ - size_t i; - - for (i = 0; i < def->nnets; i++) { - if (qemuInterfaceStartDevice(def->nets[i]) < 0) - return -1; - } - return 0; -} - - -/** - * qemuInterfaceStopDevice: - * @net: net device to stop - * - * Based upon the type of device provided, perform the appropriate - * work to deactivate the device so that packets aren't forwarded to - * it from the rest of the network. - */ -int -qemuInterfaceStopDevice(virDomainNetDef *net) -{ - virDomainNetType actualType = virDomainNetGetActualType(net); - - switch (actualType) { - case VIR_DOMAIN_NET_TYPE_BRIDGE: - case VIR_DOMAIN_NET_TYPE_NETWORK: - if (virDomainNetGetActualBridgeMACTableManager(net) - == VIR_NETWORK_BRIDGE_MAC_TABLE_MANAGER_LIBVIRT) { - /* remove the FDB entries that were added during - * qemuInterfaceStartDevices() - */ - if (virNetDevBridgeFDBDel(&net->mac, net->ifname, - VIR_NETDEVBRIDGE_FDB_FLAG_MASTER | - VIR_NETDEVBRIDGE_FDB_FLAG_TEMP) < 0) - return -1; - } - break; - - case VIR_DOMAIN_NET_TYPE_DIRECT: { - const char *physdev = virDomainNetGetActualDirectDev(net); - - /* macvtap interfaces need to be marked !IFF_UP (ie "down") to - * prevent any host-generated traffic sent from this interface - * from putting bad info into the arp caches of other machines - * on this network. - */ - if (virNetDevSetOnline(net->ifname, false) < 0) - return -1; - - /* also mark the physdev down for passthrough macvtap, as the - * physdev has the same MAC address as the macvtap device. - */ - if (virDomainNetGetActualDirectMode(net) == - VIR_NETDEV_MACVLAN_MODE_PASSTHRU && - physdev && virNetDevSetOnline(physdev, false) < 0) - return -1; - break; - } - - case VIR_DOMAIN_NET_TYPE_ETHERNET: - case VIR_DOMAIN_NET_TYPE_USER: - case VIR_DOMAIN_NET_TYPE_VHOSTUSER: - case VIR_DOMAIN_NET_TYPE_SERVER: - case VIR_DOMAIN_NET_TYPE_CLIENT: - case VIR_DOMAIN_NET_TYPE_MCAST: - case VIR_DOMAIN_NET_TYPE_UDP: - case VIR_DOMAIN_NET_TYPE_INTERNAL: - case VIR_DOMAIN_NET_TYPE_HOSTDEV: - case VIR_DOMAIN_NET_TYPE_VDPA: - case VIR_DOMAIN_NET_TYPE_NULL: - case VIR_DOMAIN_NET_TYPE_VDS: - case VIR_DOMAIN_NET_TYPE_LAST: - /* these types all require no action */ - break; - } - - return 0; -} - -/** - * qemuInterfaceStopDevices: - * @def: domain definition - * - * Make all interfaces associated with this domain inaccessible from - * the rest of the network. - */ -int -qemuInterfaceStopDevices(virDomainDef *def) -{ - size_t i; - - for (i = 0; i < def->nnets; i++) { - if (qemuInterfaceStopDevice(def->nets[i]) < 0) - return -1; - } - return 0; -} - - -static bool -qemuInterfaceIsVnetCompatModel(const virDomainNetDef *net) -{ - return (virDomainNetIsVirtioModel(net) || - net->model == VIR_DOMAIN_NET_MODEL_E1000E || - net->model == VIR_DOMAIN_NET_MODEL_IGB || - net->model == VIR_DOMAIN_NET_MODEL_VMXNET3); -} - - /** * qemuInterfaceDirectConnect: * @def: the definition of the VM (needed by 802.1Qbh and audit) @@ -271,7 +67,7 @@ qemuInterfaceDirectConnect(virDomainDef *def, unsigned int macvlan_create_flags = VIR_NETDEV_MACVLAN_CREATE_WITH_TAP; qemuDomainNetworkPrivate *netpriv = QEMU_DOMAIN_NETWORK_PRIVATE(net); - if (qemuInterfaceIsVnetCompatModel(net)) + if (virDomainInterfaceIsVnetCompatModel(net)) macvlan_create_flags |= VIR_NETDEV_MACVLAN_VNET_HDR; if (virNetDevMacVLanCreateWithVPortProfile(net->ifname, @@ -409,133 +205,6 @@ qemuCreateInBridgePortWithHelper(virQEMUDriverConfig *cfg, return *tapfd < 0 ? -1 : 0; } - -/* qemuInterfaceEthernetConnect: - * @def: the definition of the VM - * @driver: qemu driver data - * @net: pointer to the VM's interface description - * @tapfd: array of file descriptor return value for the new device - * @tapfdsize: number of file descriptors in @tapfd - * - * Called *only* called if actualType is VIR_DOMAIN_NET_TYPE_ETHERNET - * (i.e. if the connection is made with a tap device) - */ -int -qemuInterfaceEthernetConnect(virDomainDef *def, - virQEMUDriver *driver, - virDomainNetDef *net, - int *tapfd, - size_t tapfdSize) -{ - virMacAddr tapmac; - int ret = -1; - unsigned int tap_create_flags = VIR_NETDEV_TAP_CREATE_IFUP; - bool template_ifname = false; - g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); - const char *tunpath = "/dev/net/tun"; - const char *auditdev = tunpath; - - if (net->backend.tap) { - tunpath = net->backend.tap; - if (!driver->privileged) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("cannot use custom tap device in session mode")); - goto cleanup; - } - } - - if (qemuInterfaceIsVnetCompatModel(net)) - tap_create_flags |= VIR_NETDEV_TAP_CREATE_VNET_HDR; - - if (net->managed_tap == VIR_TRISTATE_BOOL_NO) { - if (!net->ifname) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("target dev must be supplied when managed='no'")); - goto cleanup; - } - if (virNetDevExists(net->ifname) != 1) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("target managed='no' but specified dev doesn't exist")); - goto cleanup; - } - - tap_create_flags |= VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING; - - if (virNetDevMacVLanIsMacvtap(net->ifname)) { - auditdev = net->ifname; - if (virNetDevMacVLanTapOpen(net->ifname, tapfd, tapfdSize) < 0) - goto cleanup; - if (virNetDevMacVLanTapSetup(tapfd, tapfdSize, - qemuInterfaceIsVnetCompatModel(net)) < 0) { - goto cleanup; - } - } else { - if (virNetDevTapCreate(&net->ifname, tunpath, tapfd, tapfdSize, - tap_create_flags) < 0) - goto cleanup; - } - } else { - - if (!net->ifname) - template_ifname = true; - - if (virNetDevTapCreate(&net->ifname, tunpath, tapfd, tapfdSize, - tap_create_flags) < 0) { - goto cleanup; - } - - /* The tap device's MAC address cannot match the MAC address - * used by the guest. This results in "received packet on - * vnetX with own address as source address" error logs from - * the kernel. - */ - virMacAddrSet(&tapmac, &net->mac); - if (tapmac.addr[0] == 0xFE) - tapmac.addr[0] = 0xFA; - else - tapmac.addr[0] = 0xFE; - - if (virNetDevSetMAC(net->ifname, &tapmac) < 0) - goto cleanup; - - if (virNetDevSetOnline(net->ifname, true) < 0) - goto cleanup; - } - - if (net->script && - virNetDevRunEthernetScript(net->ifname, net->script) < 0) - goto cleanup; - - if (cfg->macFilter && - ebtablesAddForwardAllowIn(driver->ebtables, - net->ifname, - &net->mac) < 0) - goto cleanup; - - if (net->filter && - virDomainConfNWFilterInstantiate(def->name, def->uuid, net, false) < 0) { - goto cleanup; - } - - virDomainAuditNetDevice(def, net, auditdev, true); - - ret = 0; - - cleanup: - if (ret < 0) { - size_t i; - - virDomainAuditNetDevice(def, net, auditdev, false); - for (i = 0; i < tapfdSize && tapfd[i] >= 0; i++) - VIR_FORCE_CLOSE(tapfd[i]); - if (template_ifname) - VIR_FREE(net->ifname); - } - - return ret; -} - - /* qemuInterfaceBridgeConnect: * @def: the definition of the VM * @driver: qemu driver data @@ -578,7 +247,7 @@ qemuInterfaceBridgeConnect(virDomainDef *def, if (!net->ifname) template_ifname = true; - if (qemuInterfaceIsVnetCompatModel(net)) + if (virDomainInterfaceIsVnetCompatModel(net)) tap_create_flags |= VIR_NETDEV_TAP_CREATE_VNET_HDR; if (driver->privileged) { @@ -598,7 +267,7 @@ qemuInterfaceBridgeConnect(virDomainDef *def, * is attaching to, so we need to turn off learning and * unicast_flood on the device to prevent the kernel from * adding any FDB entries for it. We will add an fdb - * entry ourselves (during qemuInterfaceStartDevices(), + * entry ourselves (during virDomainInterfaceStartDevices(), * using the MAC address from the interface config. */ if (virNetDevBridgePortSetLearning(brname, net->ifname, false) < 0) diff --git a/src/qemu/qemu_interface.h b/src/qemu/qemu_interface.h index 6eed3e6bd7..47d7ec03fd 100644 --- a/src/qemu/qemu_interface.h +++ b/src/qemu/qemu_interface.h @@ -25,11 +25,6 @@ #include "qemu_domain.h" #include "qemu_slirp.h" -int qemuInterfaceStartDevice(virDomainNetDef *net); -int qemuInterfaceStartDevices(virDomainDef *def); -int qemuInterfaceStopDevice(virDomainNetDef *net); -int qemuInterfaceStopDevices(virDomainDef *def); - int qemuInterfaceDirectConnect(virDomainDef *def, virQEMUDriver *driver, virDomainNetDef *net, @@ -37,12 +32,6 @@ int qemuInterfaceDirectConnect(virDomainDef *def, size_t tapfdSize, virNetDevVPortProfileOp vmop); -int qemuInterfaceEthernetConnect(virDomainDef *def, - virQEMUDriver *driver, - virDomainNetDef *net, - int *tapfd, - size_t tapfdSize); - int qemuInterfaceBridgeConnect(virDomainDef *def, virQEMUDriver *driver, virDomainNetDef *net, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 1ef032dbd2..1626f368bd 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -74,6 +74,7 @@ #include "virhostcpu.h" #include "domain_audit.h" #include "domain_cgroup.h" +#include "domain_interface.h" #include "domain_nwfilter.h" #include "domain_postparse.h" #include "domain_validate.h" @@ -3121,7 +3122,7 @@ qemuProcessStartCPUs(virQEMUDriver *driver, virDomainObj *vm, g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); /* Bring up netdevs before starting CPUs */ - if (qemuInterfaceStartDevices(vm->def) < 0) + if (virDomainInterfaceStartDevices(vm->def) < 0) return -1; VIR_DEBUG("Using lock state '%s'", NULLSTR(priv->lockState)); @@ -3184,7 +3185,7 @@ int qemuProcessStopCPUs(virQEMUDriver *driver, goto cleanup; /* de-activate netdevs after stopping CPUs */ - ignore_value(qemuInterfaceStopDevices(vm->def)); + ignore_value(virDomainInterfaceStopDevices(vm->def)); if (vm->job->current) ignore_value(virTimeMillisNow(&vm->job->current->stopped)); -- 2.41.0

1 0

[PATCH V2] support for hotplug/hotunplug in test hypervisor
by Thanos Makatos 30 Oct '23

30 Oct '23

Signed-off-by: Thanos Makatos <thanos.makatos(a)nutanix.com> --- src/test/test_driver.c | 59 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e87d7cfd44..80ef1b3cbb 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -10035,6 +10035,62 @@ testConnectGetDomainCapabilities(virConnectPtr conn G_GNUC_UNUSED, return virDomainCapsFormat(domCaps); } +static int +testVirDomainAttachDeviceFlags(virDomainPtr domain, + const char *xml, + unsigned int flags G_GNUC_UNUSED) { + + int ret = -1; + virDomainObj *vm; + testDriver *driver; + virDomainDeviceDef *devConf; + + if (!(vm = testDomObjFromDomain(domain))) + return -1; + + driver = domain->conn->privateData; + + if (!(devConf = virDomainDeviceDefParse(xml, vm->def, driver->xmlopt, + NULL, 0))) + goto out; + + VIR_APPEND_ELEMENT(vm->def->hostdevs, vm->def->nhostdevs, + devConf->data.hostdev); + virDomainDeviceDefFree(devConf); + ret = 0; +out: + virDomainObjEndAPI(&vm); + return ret; +} + +static int +testVirDomainAttachDevice(virDomainPtr domain, const char *xml) +{ + return testVirDomainAttachDeviceFlags(domain, xml, 0); +} + +static int +testVirDomainDetachDeviceAlias(virDomainPtr domain, + const char *alias, + unsigned int flags G_GNUC_UNUSED) +{ + virDomainObj *vm; + int size_t; + bool found = false; + + if (!(vm = testDomObjFromDomain(domain))) + return -1; + + for (i = 0; i < vm->def->nhostdevs && !found; i++) { + if (!strcmp(vm->def->hostdevs[i]->info->alias, alias)) { + virDomainHostdevDefFree(vm->def->hostdevs[i]); + VIR_DELETE_ELEMENT(vm->def->hostdevs, i, vm->def->nhostdevs); + found = true; + } + } + virDomainObjEndAPI(&vm); + return found ? 0 : -1; +} /* * Test driver @@ -10058,6 +10114,9 @@ static virHypervisorDriver testHypervisorDriver = { .connectListDomains = testConnectListDomains, /* 0.1.1 */ .connectNumOfDomains = testConnectNumOfDomains, /* 0.1.1 */ .connectListAllDomains = testConnectListAllDomains, /* 0.9.13 */ + .domainAttachDevice = testVirDomainAttachDevice, /* 9.9.0 */ + .domainAttachDeviceFlags = testVirDomainAttachDeviceFlags, /* 9.9.0 */ + .domainDetachDeviceAlias = testVirDomainDetachDeviceAlias, /* 9.9.0 */ .domainCreateXML = testDomainCreateXML, /* 0.1.4 */ .domainCreateXMLWithFiles = testDomainCreateXMLWithFiles, /* 5.7.0 */ .domainLookupByID = testDomainLookupByID, /* 0.1.1 */ -- 2.27.0

2 2

RE: [PATCH] support for hotplug/hotunplug in test hypervisor
by Thanos Makatos 30 Oct '23

30 Oct '23

> -----Original Message----- > From: Daniel P. Berrangé <berrange(a)redhat.com> > Sent: Friday, October 27, 2023 6:13 PM > To: Thanos Makatos <thanos.makatos(a)nutanix.com> > Cc: devel(a)lists.libvirt.org > Subject: Re: [PATCH] support for hotplug/hotunplug in test hypervisor > > On Fri, Oct 27, 2023 at 03:44:13PM +0000, Thanos Makatos wrote: > > Signed-off-by: Thanos Makatos <thanos.makatos(a)nutanix.com> > > --- > > src/test/test_driver.c | 61 > ++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 59 insertions(+), 2 deletions(-) > > > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > > index e87d7cfd44..6eda0dcc01 100644 > > --- a/src/test/test_driver.c > > +++ b/src/test/test_driver.c > > @@ -26,8 +26,6 @@ > > #include <unistd.h> > > #include <sys/stat.h> > > #include <libxml/xmlsave.h> > > - > > - > > Unrelated whitespace change. Ack > > > #include "virerror.h" > > #include "datatypes.h" > > #include "test_driver.h" > > @@ -10035,6 +10033,62 @@ > testConnectGetDomainCapabilities(virConnectPtr conn G_GNUC_UNUSED, > > return virDomainCapsFormat(domCaps); > > } > > > > +static int > > +testVirDomainAttachDeviceFlags(virDomainPtr domain, > > + const char *xml, > > + unsigned int flags G_GNUC_UNUSED) { > > + > > + int ret = -1; > > + virDomainObj *vm; > > + testDriver *driver; > > + virDomainDeviceDef *devConf; > > + > > + if (!(vm = testDomObjFromDomain(domain))) > > + return -1; > > + > > + driver = domain->conn->privateData; > > + > > + if (!(devConf = virDomainDeviceDefParse(xml, vm->def, driver->xmlopt, > > + NULL, 0))) > > + goto out; > > + > > + VIR_APPEND_ELEMENT(vm->def->hostdevs, vm->def->nhostdevs, > > + devConf->data.hostdev); > > Aling 'devConf' with the '(' above it Ack > > > + virDomainDeviceDefFree(devConf); > > + ret = 0; > > +out: > > + virDomainObjEndAPI(&vm); > > + return ret; > > +} > > + > > +static int > > +testVirDomainAttachDevice(virDomainPtr domain, const char *xml) > > +{ > > + return testVirDomainAttachDeviceFlags(domain, xml, 0); > > +} > > + > > +static int > > +testVirDomainDetachDeviceAlias(virDomainPtr domain, > > + const char *alias, > > + unsigned int flags __attribute__((unused))) > > Horizontal alignemtn is off, and also needs to be G_GNUC_UNUSED > like the earlier method. Ack > > > +{ > > + virDomainObj *vm; > > + int i; > > size_t for loop iterators please. Ack > > > + bool found = false; > > + > > + if (!(vm = testDomObjFromDomain(domain))) > > + return -1; > > + > > + for (i = 0; i < vm->def->nhostdevs && !found; i++) { > > + if (!strcmp(vm->def->hostdevs[i]->info->alias, alias)) { > > + virDomainHostdevDefFree(vm->def->hostdevs[i]); > > + VIR_DELETE_ELEMENT(vm->def->hostdevs, i, vm->def->nhostdevs); > > + found = true; > > + } > > + } > > + virDomainObjEndAPI(&vm); > > + return found ? 0 : -1; > > +} > > > > /* > > * Test driver > > @@ -10058,6 +10112,9 @@ static virHypervisorDriver testHypervisorDriver = > { > > .connectListDomains = testConnectListDomains, /* 0.1.1 */ > > .connectNumOfDomains = testConnectNumOfDomains, /* 0.1.1 */ > > .connectListAllDomains = testConnectListAllDomains, /* 0.9.13 */ > > + .domainAttachDevice = testVirDomainAttachDevice, /* 9.9.0 */ > > + .domainAttachDeviceFlags = testVirDomainAttachDeviceFlags, /* 9.9.0 */ > > + .domainDetachDeviceAlias = testVirDomainDetachDeviceAlias, /* 9.9.0 */ > > .domainCreateXML = testDomainCreateXML, /* 0.1.4 */ > > .domainCreateXMLWithFiles = testDomainCreateXMLWithFiles, /* 5.7.0 */ > > .domainLookupByID = testDomainLookupByID, /* 0.1.1 */ > > -- > > 2.27.0 > > > > With regards, > Daniel > -- > |: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__berrange.com&d=DwIBaQ&c=s883GpUCOChKOHiocYtGcg&r=XTpYsh5Ps2zJ > vtw6ogtti46atk736SI4vgsJiUKIyDE&m=7tOGBG0mrTLgztzu23pWZjCQpfdKbv7cV > ilnYobvnzJSHk- > m3fVMonE71FEjfJUc&s=MKxz2dbrxpoqVQEKrR1rIHTDNh3TQzk6j9ILpLJO4eI&e > = -o- https://urldefense.proofpoint.com/v2/url?u=https- > 3A__www.flickr.com_photos_dberrange&d=DwIBaQ&c=s883GpUCOChKOHiocYt > Gcg&r=XTpYsh5Ps2zJvtw6ogtti46atk736SI4vgsJiUKIyDE&m=7tOGBG0mrTLgztzu > 23pWZjCQpfdKbv7cVilnYobvnzJSHk-m3fVMonE71FEjfJUc&s=yYyWxbabM- > x_RY69yLXObz2p8wo1OAy4DioA0YScDYc&e= :| > |: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__libvirt.org&d=DwIBaQ&c=s883GpUCOChKOHiocYtGcg&r=XTpYsh5Ps2zJvtw > 6ogtti46atk736SI4vgsJiUKIyDE&m=7tOGBG0mrTLgztzu23pWZjCQpfdKbv7cVilnY > obvnzJSHk- > m3fVMonE71FEjfJUc&s=YVwYpdMFSWcMfQ2sM9QgKFheo9Dxq8s4_sFI0KfGqu > o&e= -o- https://urldefense.proofpoint.com/v2/url?u=https- > 3A__fstop138.berrange.com&d=DwIBaQ&c=s883GpUCOChKOHiocYtGcg&r=XTp > Ysh5Ps2zJvtw6ogtti46atk736SI4vgsJiUKIyDE&m=7tOGBG0mrTLgztzu23pWZjCQ > pfdKbv7cVilnYobvnzJSHk-m3fVMonE71FEjfJUc&s=- > C8ZIdR8IJmdjdVJljDjhjVC4UiJcAeuiWQ-B_dV4wM&e= :| > |: https://urldefense.proofpoint.com/v2/url?u=https-3A__entangle- > 2Dphoto.org&d=DwIBaQ&c=s883GpUCOChKOHiocYtGcg&r=XTpYsh5Ps2zJvtw6o > gtti46atk736SI4vgsJiUKIyDE&m=7tOGBG0mrTLgztzu23pWZjCQpfdKbv7cVilnYob > vnzJSHk- > m3fVMonE71FEjfJUc&s=BgvlBMRgX56LJG0ZSE02GviPHpVTcQ_Nx1N3aEWk9d4 > &e= -o- https://urldefense.proofpoint.com/v2/url?u=https- > 3A__www.instagram.com_dberrange&d=DwIBaQ&c=s883GpUCOChKOHiocYtGc > g&r=XTpYsh5Ps2zJvtw6ogtti46atk736SI4vgsJiUKIyDE&m=7tOGBG0mrTLgztzu23 > pWZjCQpfdKbv7cVilnYobvnzJSHk-m3fVMonE71FEjfJUc&s=g23VsTOOhoOdgm- > cJyiOixKvywYEQXh-L7sRK8YPm90&e= :|

1 0

Entering freeze for libvirt-9.9.0
by Jiri Denemark 30 Oct '23

30 Oct '23

I have just tagged v9.9.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[libvirt PATCH 0/4] Update for mailing list move
by Daniel P. Berrangé 30 Oct '23

30 Oct '23

A surprising number of places mention the mailing lists Daniel P. Berrangé (4): src: update log/error messages pointing to old mailing list addr docs: update docs pointing to old mailing list addrs gitpublish: update for new devel mailing list address docs: update search form to use hyperkitty search .gitpublish | 2 +- README.rst | 4 +-- docs/bindings.rst | 2 +- docs/contact.rst | 18 ++++++------- docs/downloads.rst | 2 +- docs/js/main.js | 37 +++++++++++++++++---------- docs/newreposetup.rst | 2 +- docs/securityprocess.rst | 2 +- docs/submitting-patches.rst | 10 ++++---- docs/testapi.rst | 4 +-- src/conf/domain_capabilities.c | 2 +- src/storage_file/storage_file_probe.c | 2 +- src/util/virarch.c | 4 +-- 13 files changed, 51 insertions(+), 40 deletions(-) -- 2.41.0

2 7

[PATCH] support for hotplug/hotunplug in test hypervisor
by Thanos Makatos 27 Oct '23

27 Oct '23

Signed-off-by: Thanos Makatos <thanos.makatos(a)nutanix.com> --- src/test/test_driver.c | 61 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 59 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e87d7cfd44..6eda0dcc01 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -26,8 +26,6 @@ #include <unistd.h> #include <sys/stat.h> #include <libxml/xmlsave.h> - - #include "virerror.h" #include "datatypes.h" #include "test_driver.h" @@ -10035,6 +10033,62 @@ testConnectGetDomainCapabilities(virConnectPtr conn G_GNUC_UNUSED, return virDomainCapsFormat(domCaps); } +static int +testVirDomainAttachDeviceFlags(virDomainPtr domain, + const char *xml, + unsigned int flags G_GNUC_UNUSED) { + + int ret = -1; + virDomainObj *vm; + testDriver *driver; + virDomainDeviceDef *devConf; + + if (!(vm = testDomObjFromDomain(domain))) + return -1; + + driver = domain->conn->privateData; + + if (!(devConf = virDomainDeviceDefParse(xml, vm->def, driver->xmlopt, + NULL, 0))) + goto out; + + VIR_APPEND_ELEMENT(vm->def->hostdevs, vm->def->nhostdevs, + devConf->data.hostdev); + virDomainDeviceDefFree(devConf); + ret = 0; +out: + virDomainObjEndAPI(&vm); + return ret; +} + +static int +testVirDomainAttachDevice(virDomainPtr domain, const char *xml) +{ + return testVirDomainAttachDeviceFlags(domain, xml, 0); +} + +static int +testVirDomainDetachDeviceAlias(virDomainPtr domain, + const char *alias, + unsigned int flags __attribute__((unused))) +{ + virDomainObj *vm; + int i; + bool found = false; + + if (!(vm = testDomObjFromDomain(domain))) + return -1; + + for (i = 0; i < vm->def->nhostdevs && !found; i++) { + if (!strcmp(vm->def->hostdevs[i]->info->alias, alias)) { + virDomainHostdevDefFree(vm->def->hostdevs[i]); + VIR_DELETE_ELEMENT(vm->def->hostdevs, i, vm->def->nhostdevs); + found = true; + } + } + virDomainObjEndAPI(&vm); + return found ? 0 : -1; +} /* * Test driver @@ -10058,6 +10112,9 @@ static virHypervisorDriver testHypervisorDriver = { .connectListDomains = testConnectListDomains, /* 0.1.1 */ .connectNumOfDomains = testConnectNumOfDomains, /* 0.1.1 */ .connectListAllDomains = testConnectListAllDomains, /* 0.9.13 */ + .domainAttachDevice = testVirDomainAttachDevice, /* 9.9.0 */ + .domainAttachDeviceFlags = testVirDomainAttachDeviceFlags, /* 9.9.0 */ + .domainDetachDeviceAlias = testVirDomainDetachDeviceAlias, /* 9.9.0 */ .domainCreateXML = testDomainCreateXML, /* 0.1.4 */ .domainCreateXMLWithFiles = testDomainCreateXMLWithFiles, /* 5.7.0 */ .domainLookupByID = testDomainLookupByID, /* 0.1.1 */ -- 2.27.0

1 0

Re: [libvirt] [Qemu-devel] Qemu migration with vhost-user-blk on top of local storage
by Stefan Hajnoczi 27 Oct '23

27 Oct '23

On Wed, Jan 09, 2019 at 06:23:42PM +0800, wuzhouhui wrote: > Hi everyone, > > I'm working qemu with vhost target (e.g. spdk), and I attempt to migrate VM with > 2 local storages. One local storage is a regular file, e.g. /tmp/c74.qcow2, and > the other is a malloc bdev that spdk created. This malloc bdev will exported to > VM via vhost-user-blk. When I execute following command: > > virsh migrate --live --persistent --unsafe --undefinesource --copy-storage-all \ > --p2p --auto-converge --verbose --desturi qemu+tcp://<uri>/system vm0 > > The libvirt reports: > > qemu-2.12.1: error: internal error: unable to execute QEMU command \ > 'nbd-server-add': Cannot find device=drive-virtio-disk1 nor \ > node_name=drive-virtio-disk1 Please post your libvirt domain XML. > Does it means that qemu with spdk on top of local storage don't support migration? > > QEMU: 2.12.1 > SPDK: 18.10 vhost-user-blk bypasses the QEMU block layer, so NBD storage migration at the QEMU level will not work for the vhost-user-blk disk. Stefan

4 4

[libvirt] [PATCH v3] openvswitch: Add new port VLAN mode "dot1q-tunnel"
by luzhipeng＠uniudc.com 27 Oct '23

27 Oct '23

From: ZhiPeng Lu <luzhipeng(a)uniudc.com> Signed-off-by: ZhiPeng Lu <luzhipeng(a)uniudc.com> --- v1->v2: 1. Fix "make syntax-check" failure v2->v3: 1. remove other_config when updating vlan docs/formatnetwork.html.in | 17 +++++++++-------- docs/schemas/networkcommon.rng | 1 + src/conf/netdev_vlan_conf.c | 2 +- src/util/virnetdevopenvswitch.c | 7 +++++++ src/util/virnetdevvlan.h | 1 + 5 files changed, 19 insertions(+), 9 deletions(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 363a72b..3c1ae62 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in @@ -688,16 +688,17 @@ </p> <p> For network connections using Open vSwitch it is also possible - to configure 'native-tagged' and 'native-untagged' VLAN modes + to configure 'native-tagged' and 'native-untagged' and 'dot1q-tunnel' + VLAN modes. <span class="since">Since 1.1.0.</span> This is done with the - optional <code>nativeMode</code> attribute on - the <code><tag></code> subelement: <code>nativeMode</code> - may be set to 'tagged' or 'untagged'. The <code>id</code> - attribute of the <code><tag></code> subelement - containing <code>nativeMode</code> sets which VLAN is considered - to be the "native" VLAN for this interface, and + optional <code>nativeMode</code> attribute on the + <code><tag></code> subelement: <code>nativeMode</code> + may be set to 'tagged' or 'untagged' or 'dot1q-tunnel'. + The <code>id</code> attribute of the <code><tag></code> + subelement containing <code>nativeMode</code> sets which VLAN is + considered to be the "native" VLAN for this interface, and the <code>nativeMode</code> attribute determines whether or not - traffic for that VLAN will be tagged. + traffic for that VLAN will be tagged or QinQ. </p> <p> <code><vlan></code> elements can also be specified in diff --git a/docs/schemas/networkcommon.rng b/docs/schemas/networkcommon.rng index 2699555..11c48ff 100644 --- a/docs/schemas/networkcommon.rng +++ b/docs/schemas/networkcommon.rng @@ -223,6 +223,7 @@ <choice> <value>tagged</value> <value>untagged</value> + <value>dot1q-tunnel</value> </choice> </attribute> </optional> diff --git a/src/conf/netdev_vlan_conf.c b/src/conf/netdev_vlan_conf.c index dff49c6..79710d9 100644 --- a/src/conf/netdev_vlan_conf.c +++ b/src/conf/netdev_vlan_conf.c @@ -29,7 +29,7 @@ #define VIR_FROM_THIS VIR_FROM_NONE VIR_ENUM_IMPL(virNativeVlanMode, VIR_NATIVE_VLAN_MODE_LAST, - "default", "tagged", "untagged") + "default", "tagged", "untagged", "dot1q-tunnel") int virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virNetDevVlanPtr def) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index 8fe06fd..9fec30b 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -91,6 +91,11 @@ virNetDevOpenvswitchConstructVlans(virCommandPtr cmd, virNetDevVlanPtr virtVlan) virCommandAddArg(cmd, "vlan_mode=native-untagged"); virCommandAddArgFormat(cmd, "tag=%d", virtVlan->nativeTag); break; + case VIR_NATIVE_VLAN_MODE_DOT1Q_TUNNEL: + virCommandAddArg(cmd, "vlan_mode=dot1q-tunnel"); + virCommandAddArg(cmd, "other_config:qinq-ethtype=802.1q"); + virCommandAddArgFormat(cmd, "tag=%d", virtVlan->nativeTag); + break; case VIR_NATIVE_VLAN_MODE_DEFAULT: default: break; @@ -504,6 +509,8 @@ int virNetDevOpenvswitchUpdateVlan(const char *ifname, "--", "--if-exists", "clear", "Port", ifname, "tag", "--", "--if-exists", "clear", "Port", ifname, "trunk", "--", "--if-exists", "clear", "Port", ifname, "vlan_mode", + "--", "--if-exists", "remove", "Port", ifname, "other_config", + "qinq-ethtype", NULL, "--", "--if-exists", "set", "Port", ifname, NULL); if (virNetDevOpenvswitchConstructVlans(cmd, virtVlan) < 0) diff --git a/src/util/virnetdevvlan.h b/src/util/virnetdevvlan.h index be85f59..0667f9d 100644 --- a/src/util/virnetdevvlan.h +++ b/src/util/virnetdevvlan.h @@ -29,6 +29,7 @@ typedef enum { VIR_NATIVE_VLAN_MODE_DEFAULT = 0, VIR_NATIVE_VLAN_MODE_TAGGED, VIR_NATIVE_VLAN_MODE_UNTAGGED, + VIR_NATIVE_VLAN_MODE_DOT1Q_TUNNEL, VIR_NATIVE_VLAN_MODE_LAST } virNativeVlanMode; -- 1.8.3.1

3 2

[libvirt] [PATCH] Fix compile error for stable 1.2.9
by Yang hongyang 27 Oct '23

27 Oct '23

Seems a backport miss. An extra member is passed to struct virLXCBasicMountInfo. Signed-off-by: Yang hongyang <hongyang.yang(a)easystack.cn> --- src/lxc/lxc_container.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 28dabec..1c65fa9 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -760,7 +760,7 @@ typedef struct { static const virLXCBasicMountInfo lxcBasicMounts[] = { { "proc", "/proc", "proc", MS_NOSUID|MS_NOEXEC|MS_NODEV, false, false }, - { "/proc/sys", "/proc/sys", NULL, MS_BIND|MS_NOSUID|MS_NOEXEC|MS_NODEV|MS_RDONLY, false, false, false }, + { "/proc/sys", "/proc/sys", NULL, MS_BIND|MS_NOSUID|MS_NOEXEC|MS_NODEV|MS_RDONLY, false, false }, { "sysfs", "/sys", "sysfs", MS_NOSUID|MS_NOEXEC|MS_NODEV|MS_RDONLY, false, false }, { "securityfs", "/sys/kernel/security", "securityfs", MS_NOSUID|MS_NOEXEC|MS_NODEV|MS_RDONLY, true, true }, #if WITH_SELINUX -- 1.7.1

3 2

[libvirt] [PATCH] web docs -- macvtap mode explanation
by Stefan Berger 27 Oct '23

27 Oct '23

This adds more information about the different macvtap device modes. Regards, Stefan

3 2

[libvirt] Supporting vhost-net and macvtap in libvirt for QEMU
by Anthony Liguori 27 Oct '23

27 Oct '23

Disclaimer: I am neither an SR-IOV nor a vhost-net expert, but I've CC'd people that are who can throw tomatoes at me for getting bits wrong :-) I wanted to start a discussion about supporting vhost-net in libvirt. vhost-net has not yet been merged into qemu but I expect it will be soon so it's a good time to start this discussion. There are two modes worth supporting for vhost-net in libvirt. The first mode is where vhost-net backs to a tun/tap device. This is behaves in very much the same way that -net tap behaves in qemu today. Basically, the difference is that the virtio backend is in the kernel instead of in qemu so there should be some performance improvement. Current, libvirt invokes qemu with -net tap,fd=X where X is an already open fd to a tun/tap device. I suspect that after we merge vhost-net, libvirt could support vhost-net in this mode by just doing -net vhost,fd=X. I think the only real question for libvirt is whether to provide a user visible switch to use vhost or to just always use vhost when it's available and it makes sense. Personally, I think the later makes sense. The more interesting invocation of vhost-net though is one where the vhost-net device backs directly to a physical network card. In this mode, vhost should get considerably better performance than the current implementation. I don't know the syntax yet, but I think it's reasonable to assume that it will look something like -net tap,dev=eth0. The effect will be that eth0 is dedicated to the guest. On most modern systems, there is a small number of network devices so this model is not all that useful except when dealing with SR-IOV adapters. In that case, each physical device can be exposed as many virtual devices (VFs). There are a few restrictions here though. The biggest is that currently, you can only change the number of VFs by reloading a kernel module so it's really a parameter that must be set at startup time. I think there are a few ways libvirt could support vhost-net in this second mode. The simplest would be to introduce a new tag similar to <source network='br0'>. In fact, if you probed the device type for the network parameter, you could probably do something like <source network='eth0'> and have it Just Work. Another model would be to have libvirt see an SR-IOV adapter as a network pool whereas it handled all of the VF management. Considering how inflexible SR-IOV is today, I'm not sure whether this is the best model. Has anyone put any more thought into this problem or how this should be modeled in libvirt? Michael, could you share your current thinking for -net syntax? -- Regards, Anthony Liguori

8 26

[PULL 00/39] Migration 20231024 patches
by Juan Quintela 26 Oct '23

26 Oct '23

The following changes since commit a95260486aa7e78d7c7194eba65cf03311ad94ad: Merge tag 'pull-tcg-20231023' of https://gitlab.com/rth7680/qemu into staging (2023-10-23 14:45:46 -0700) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20231024-pull-request for you to fetch changes up to 088f7f03da3f5b3487091302b795c22b1bfe56fb: migration: Deprecate old compression method (2023-10-24 13:48:24 +0200) ---------------------------------------------------------------- Migration Pull request (20231024) Hi In this PULL: - vmstate registration fixes (thomas, juan) - start merging vmstate_section_needed changes (marc) - migration depreactions (juan) - migration documentation for backwards compatibility (juan) Please apply. ---------------------------------------------------------------- Juan Quintela (31): migration/doc: Add contents migration/doc: Add documentation for backwards compatiblity migration/doc: How to migrate when hosts have different features migration/doc: We broke backwards compatibility migration: Receiving a zero page non zero is an error migration: Rename ram_handle_compressed() to ram_handle_zero() migration: Give one error if trying to set MULTIFD and XBZRLE migration: Give one error if trying to set COMPRESSION and XBZRLE migration: Remove save_page_use_compression() migration: Make compress_data_with_multithreads return bool migration: Simplify compress_page_with_multithread() migration: Move busy++ to migrate_with_multithread migration: Create compress_update_rates() migration: Export send_queued_data() migration: Move ram_flush_compressed_data() to ram-compress.c migration: Merge flush_compressed_data() and compress_flush_data() migration: Rename ram_compressed_pages() to compress_ram_pages() migration: Create vmstate_register_any() migration: Use vmstate_register_any() migration: Use vmstate_register_any() for isa-ide migration: Use VMSTATE_INSTANCE_ID_ANY for slirp migration: Hack to maintain backwards compatibility for ppc migration: Improve example and documentation of vmstate_register() migration: Use vmstate_register_any() for audio migration: Use vmstate_register_any() for eeprom93xx migration: Use vmstate_register_any() for vmware_vga qemu-iotests: Filter warnings about block migration being deprecated migration: migrate 'inc' command option is deprecated. migration: migrate 'blk' command option is deprecated. migration: Deprecate block migration migration: Deprecate old compression method Marc-André Lureau (2): migration: rename vmstate_save_needed->vmstate_section_needed migration: set file error on subsection loading Peter Xu (1): migration: Check in savevm_state_handler_insert for dups Thomas Huth (5): hw/ipmi: Don't call vmstate_register() from instance_init() functions hw/s390x/s390-skeys: Don't call register_savevm_live() during instance_init() hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" property hw/s390x/s390-stattrib: Don't call register_savevm_live() during instance_init() migration/ram: Fix compilation with -Wshadow=local docs/about/deprecated.rst | 35 ++ docs/devel/migration.rst | 532 ++++++++++++++++++++++++++++++- qapi/migration.json | 93 ++++-- include/migration/vmstate.h | 30 +- migration/ram-compress.h | 10 +- migration/ram.h | 3 +- audio/audio.c | 2 +- backends/dbus-vmstate.c | 3 +- backends/tpm/tpm_emulator.c | 3 +- hw/display/vmware_vga.c | 2 +- hw/i2c/core.c | 2 +- hw/ide/isa.c | 2 +- hw/input/adb.c | 2 +- hw/input/ads7846.c | 2 +- hw/input/stellaris_input.c | 3 +- hw/intc/xics.c | 18 +- hw/ipmi/ipmi_bmc_extern.c | 29 +- hw/ipmi/isa_ipmi_bt.c | 34 +- hw/ipmi/isa_ipmi_kcs.c | 50 +-- hw/net/eepro100.c | 3 +- hw/nvram/eeprom93xx.c | 2 +- hw/pci/pci.c | 2 +- hw/ppc/spapr.c | 25 +- hw/ppc/spapr_nvdimm.c | 3 +- hw/s390x/s390-skeys.c | 35 +- hw/s390x/s390-stattrib.c | 71 ++--- hw/timer/arm_timer.c | 2 +- hw/virtio/virtio-mem.c | 4 +- migration/block.c | 3 + migration/migration-hmp-cmds.c | 10 + migration/migration.c | 10 + migration/options.c | 36 ++- migration/ram-compress.c | 112 +++++-- migration/ram.c | 114 ++----- migration/rdma.c | 8 +- migration/savevm.c | 34 +- migration/vmstate.c | 5 +- net/slirp.c | 5 +- tests/qemu-iotests/183 | 2 +- tests/qemu-iotests/common.filter | 7 + 40 files changed, 1041 insertions(+), 307 deletions(-) -- 2.41.0

3 43

[PATCH v2 0/3] qemu: Fix hotplug and blockcopy to VDPA disks
by Peter Krempa 26 Oct '23

26 Oct '23

Content-type: text/plain v2: - also deal with blockcopy (requires more helpers) Peter Krempa (3): qemu: process: Extract host setup of disk device into helpers qemu: hotplug: Setup host side of VDPA device for disk hotplug qemu: Setup host side of VDPA device for block copy src/qemu/qemu_block.c | 4 +++ src/qemu/qemu_driver.c | 12 +++++++ src/qemu/qemu_hotplug.c | 3 ++ src/qemu/qemu_process.c | 76 ++++++++++++++++++++++++++++++++++++----- src/qemu/qemu_process.h | 7 ++++ 5 files changed, 93 insertions(+), 9 deletions(-) -- 2.41.0

1 3

[PATCH 00/22] qemu: Refactor blockdev protocol JSON generators ('raw' driver removal part 2)
by Peter Krempa 26 Oct '23

26 Oct '23

Second part cleans up tests and various bits and refactors the protocol blockdev JSON configuration generator to be reusable. This still doesn't change the configuration of the blockdevs, just reorders some arguments. Peter Krempa (22): qemuxml2(argv|xml)test: Add network backed disk type='sd' qemu: migration: No longer avoid 'auto-read-only' option for migration qemuBuildDriveSourceStr: Absorb only use of qemuDiskSourceGetProps qemuBlockStorageSourceGetBackendProps: Remove unnecessary indent for non-nbdkit code path conf: Move definition of some disk type enums to a common header virStorageSource: Use proper type for shadow copies of iomode/cachemode/discard/detect_zeroes qemuDomainDiskCachemodeFlags: Simplify usage qemuBlockStorageSourceGetBlockdevGetCacheProps: Return the cache object rather than appending it qemublocktest: Use "target only" mode in 'testJSONtoJSON' and 'testBackingXMLjsonXML' qemublocktest: Drop 'sheepdog' and 'vxhs' test cases qemublocktest: Fix logical bug in TEST_JSON_FORMAT macro qemublocktest: testBackingXMLjsonXML: Drop 'legacy' mode qemuBlockStorageSourceGetBackendProps: Unify cases for '!onlytarget' and '!legacy' virDomainDiskGetDetectZeroesMode: Return proper type qemuBlockStorageSourceGetBackendProps: Unify ordering of fields qemu: block: Add helper to add common properties for -blockdev configuration qemu: block: Use qemuBlockStorageSourceAddBlockdevCommonProps for storage slice qemuBlockStorageSourceGetBackendProps: Introduce QEMU_BLOCK_STORAGE_SOURCE_BACKEND_PROPS_EFFECTIVE_NODE qemuBuildHostdevSCSIAttachPrepare: Use "effective node" mode for getting blockdev props qemuBlockStorageSourceGetBackendProps: Use qemuBlockStorageSourceAddBlockdevCommonProps qemuBlockStorageSourceGetBackendProps: Remove unused logic for (auto-)read-only flags qemu: block: Remove unused flags QEMU_BLOCK_STORAGE_SOURCE_BACKEND_PROPS_ flags src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 39 +- src/conf/storage_source_conf.h | 8 +- src/conf/virconftypes.h | 39 +- src/qemu/qemu_block.c | 349 +++++++++--------- src/qemu/qemu_block.h | 6 +- src/qemu/qemu_command.c | 63 ++-- src/qemu/qemu_domain.c | 33 +- src/qemu/qemu_domain.h | 4 +- src/qemu/qemu_migration.c | 5 +- tests/qemublocktest.c | 41 +- .../jsontojson/curl-libguestfs-out.json | 5 +- .../ssh-passthrough-libguestfs-out.json | 4 +- .../xml2json/dir-fat-cache.json | 6 +- .../file-backing_basic-cache-directsync.json | 24 +- .../file-backing_basic-cache-none.json | 24 +- .../file-backing_basic-cache-unsafe.json | 24 +- .../file-backing_basic-cache-writeback.json | 24 +- ...file-backing_basic-cache-writethrough.json | 24 +- .../xml2json/file-raw-aio_native.json | 6 +- ...work-qcow2-backing-chain-cache-unsafe.json | 12 +- .../blkdeviotune-group-num.x86_64-latest.args | 4 +- ...blkdeviotune-max-length.x86_64-latest.args | 4 +- .../blkdeviotune-max.x86_64-latest.args | 4 +- .../blkdeviotune.x86_64-latest.args | 4 +- .../controller-order.x86_64-latest.args | 2 +- .../disk-aio.x86_64-latest.args | 2 +- .../disk-arm-virtio-sd.aarch64-latest.args | 2 + tests/qemuxml2argvdata/disk-arm-virtio-sd.xml | 16 + .../disk-cache.x86_64-latest.args | 10 +- .../disk-error-policy-s390x.s390x-latest.args | 6 +- .../disk-error-policy.x86_64-latest.args | 6 +- .../disk-metadata-cache.x86_64-latest.args | 6 +- .../disk-network-nfs.x86_64-latest.args | 2 +- ...rk-tlsx509-nbd-hostname.x86_64-latest.args | 2 +- ...disk-network-tlsx509-nbd.x86_64-5.2.0.args | 2 +- ...isk-network-tlsx509-nbd.x86_64-latest.args | 2 +- ...isk-network-tlsx509-vxhs.x86_64-5.0.0.args | 6 +- .../disk-nvme.x86_64-latest.args | 2 +- .../disk-shared.x86_64-latest.args | 6 +- .../disk-slices.x86_64-latest.args | 8 +- .../disk-snapshot.x86_64-latest.args | 4 +- .../disk-transient.x86_64-latest.args | 2 +- .../disk-vhostvdpa.x86_64-latest.args | 2 +- .../name-escape.x86_64-latest.args | 2 +- .../user-aliases.x86_64-latest.args | 4 +- ...eo-bochs-display-device.x86_64-latest.args | 2 +- ...-device-pciaddr-default.x86_64-latest.args | 2 +- ...video-qxl-device-vgamem.x86_64-latest.args | 2 +- .../video-qxl-device.x86_64-latest.args | 2 +- ...o-qxl-sec-device-vgamem.x86_64-latest.args | 2 +- .../video-qxl-sec-device.x86_64-latest.args | 2 +- ...eo-ramfb-display-device.x86_64-latest.args | 2 +- ...video-vga-device-vgamem.x86_64-latest.args | 2 +- .../video-vga-device.x86_64-latest.args | 2 +- .../video-virtio-blob-off.x86_64-latest.args | 2 +- .../video-virtio-blob-on.x86_64-latest.args | 2 +- ...video-virtio-gpu-device.x86_64-latest.args | 2 +- ...video-virtio-gpu-sdl-gl.x86_64-latest.args | 2 +- ...deo-virtio-gpu-spice-gl.x86_64-latest.args | 2 +- .../video-virtio-gpu-virgl.x86_64-latest.args | 2 +- .../video-virtio-vga.x86_64-latest.args | 2 +- .../disk-arm-virtio-sd.aarch64-latest.xml | 16 + 63 files changed, 438 insertions(+), 462 deletions(-) -- 2.41.0

2 26

[PATCH 0/2] qemu: Fix hotplug of VDPA disks
by Peter Krempa 26 Oct '23

26 Oct '23

Peter Krempa (2): qemu: process: Extract host setup of disk device into a helper qemu: hotplug: Setup host side of VDPA device for disk hotplug src/qemu/qemu_hotplug.c | 3 +++ src/qemu/qemu_process.c | 42 ++++++++++++++++++++++++++++++++--------- src/qemu/qemu_process.h | 3 +++ 3 files changed, 39 insertions(+), 9 deletions(-) -- 2.41.0

1 3

[PATCH] docs: formatdomain: Clarify that the SLIC ACPI table config is available for all modes
by Peter Krempa 26 Oct '23

26 Oct '23

Move the docs for the <acpi><table> element under a common section as it's not specific for direct kernel boot. In fact the original use was for Windows activation. Fixes: 72f652da63255c7f1a9914625cce617dde9128d0 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/formatdomain.rst | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 03735e4593..459815d2b5 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -387,9 +387,6 @@ and full virtualized guests. <initrd>/root/f8-i386-initrd</initrd> <cmdline>console=ttyS0 ks=http://example.com/f8-i386/os/</cmdline> <dtb>/root/ppc.dtb</dtb> - <acpi> - <table type='slic'>/path/to/slic.dat</table> - </acpi> </os> ... @@ -413,11 +410,6 @@ and full virtualized guests. The contents of this element specify the fully-qualified path to the (optional) device tree binary (dtb) image in the host OS. :since:`Since 1.0.4` -``acpi`` - The ``table`` element contains a fully-qualified path to the ACPI table. The - ``type`` attribute contains the ACPI table type (currently only ``slic`` is - supported) :since:`Since 1.3.5 (QEMU)` :since:`Since 5.9.0 (Xen)` - Container boot ~~~~~~~~~~~~~~ @@ -470,6 +462,27 @@ If you want to enable user namespace, set the ``idmap`` element. The ``uid`` and <gid start='0' target='1000' count='10'/> </idmap> +Common ``<os>`` element configuration +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +These options apply to any form of booting of the guest OS. + +:: + + ... + <os> + ... + <acpi> + <table type='slic'>/path/to/slic.dat</table> + </acpi> + </os> + ... + +``acpi`` + The ``table`` element contains a fully-qualified path to the ACPI table. The + ``type`` attribute contains the ACPI table type (currently only ``slic`` is + supported) :since:`Since 1.3.5 (QEMU)` :since:`Since 5.9.0 (Xen)` + SMBIOS System Information ------------------------- -- 2.41.0

2 1

[PATCH] qemucapabilitiestest: Update capabilities data for 8.2 dev cycle on x86_64
by Peter Krempa 26 Oct '23

26 Oct '23

Update to v8.1.0-2161-ga95260486a Notable changes: - new CPU topology parameters: 'books', 'drawers' - new migration parameter 'avail-switchover-bandwidth' - new s390x CPU properties: 'dedicated', 'entitlement' - new 'hostmem' parameter for 'virtio-gpu' - new device 'piix4-isa' - new property 'dynamic-memslots' of 'virtio-mem' device - new 'gsi*' parameters of 'ICH9-LPC' - new experimental 'x-south-bridge' machine option Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_8.2.0_x86_64.replies | 3168 +++++++++-------- .../caps_8.2.0_x86_64.xml | 2 +- 2 files changed, 1681 insertions(+), 1489 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies index 9d947917e3..14736e6558 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies @@ -21,7 +21,7 @@ "minor": 1, "major": 8 }, - "package": "v8.1.0-1639-g63011373ad" + "package": "v8.1.0-2161-ga95260486a" }, "id": "libvirt-2" } @@ -1435,7 +1435,7 @@ }, { "name": "query-replay", - "ret-type": "220", + "ret-type": "223", "meta-type": "command", "arg-type": "0" }, @@ -1443,7 +1443,7 @@ "name": "replay-break", "ret-type": "0", "meta-type": "command", - "arg-type": "221" + "arg-type": "224" }, { "name": "replay-delete-break", @@ -1455,18 +1455,18 @@ "name": "replay-seek", "ret-type": "0", "meta-type": "command", - "arg-type": "222" + "arg-type": "225" }, { "name": "yank", "ret-type": "0", "allow-oob": true, "meta-type": "command", - "arg-type": "223" + "arg-type": "226" }, { "name": "query-yank", - "ret-type": "[224]", + "ret-type": "[227]", "allow-oob": true, "meta-type": "command", "arg-type": "0" @@ -1475,17 +1475,17 @@ "name": "add_client", "ret-type": "0", "meta-type": "command", - "arg-type": "225" + "arg-type": "228" }, { "name": "query-name", - "ret-type": "226", + "ret-type": "229", "meta-type": "command", "arg-type": "0" }, { "name": "query-iothreads", - "ret-type": "[227]", + "ret-type": "[230]", "meta-type": "command", "arg-type": "0" }, @@ -1514,7 +1514,7 @@ "name": "human-monitor-command", "ret-type": "str", "meta-type": "command", - "arg-type": "228", + "arg-type": "231", "features": [ "savevm-monitor-nodes" ] @@ -1523,47 +1523,47 @@ "name": "getfd", "ret-type": "0", "meta-type": "command", - "arg-type": "229" + "arg-type": "232" }, { "name": "closefd", "ret-type": "0", "meta-type": "command", - "arg-type": "231" + "arg-type": "234" }, { "name": "add-fd", - "ret-type": "233", + "ret-type": "236", "meta-type": "command", - "arg-type": "232" + "arg-type": "235" }, { "name": "remove-fd", "ret-type": "0", "meta-type": "command", - "arg-type": "234" + "arg-type": "237" }, { "name": "query-fdsets", - "ret-type": "[235]", + "ret-type": "[238]", "meta-type": "command", "arg-type": "0" }, { "name": "query-command-line-options", - "ret-type": "[237]", + "ret-type": "[240]", "meta-type": "command", - "arg-type": "236" + "arg-type": "239" }, { "name": "RTC_CHANGE", "meta-type": "event", - "arg-type": "238" + "arg-type": "241" }, { "name": "VFU_CLIENT_HANGUP", "meta-type": "event", - "arg-type": "239" + "arg-type": "242" }, { "name": "rtc-reset-reinjection", @@ -1573,19 +1573,19 @@ }, { "name": "query-sev", - "ret-type": "240", + "ret-type": "243", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-launch-measure", - "ret-type": "241", + "ret-type": "244", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-capabilities", - "ret-type": "242", + "ret-type": "245", "meta-type": "command", "arg-type": "0" }, @@ -1593,29 +1593,29 @@ "name": "sev-inject-launch-secret", "ret-type": "0", "meta-type": "command", - "arg-type": "243" + "arg-type": "246" }, { "name": "query-sev-attestation-report", - "ret-type": "245", + "ret-type": "248", "meta-type": "command", - "arg-type": "244" + "arg-type": "247" }, { "name": "query-sgx", - "ret-type": "248", + "ret-type": "251", "meta-type": "command", "arg-type": "0" }, { "name": "query-sgx-capabilities", - "ret-type": "248", + "ret-type": "251", "meta-type": "command", "arg-type": "0" }, { "name": "xen-event-list", - "ret-type": "[249]", + "ret-type": "[252]", "meta-type": "command", "arg-type": "0" }, @@ -1623,46 +1623,46 @@ "name": "xen-event-inject", "ret-type": "0", "meta-type": "command", - "arg-type": "250" + "arg-type": "253" }, { "name": "query-audiodevs", - "ret-type": "[251]", + "ret-type": "[254]", "meta-type": "command", "arg-type": "0" }, { "name": "query-acpi-ospm-status", - "ret-type": "[252]", + "ret-type": "[255]", "meta-type": "command", "arg-type": "0" }, { "name": "ACPI_DEVICE_OST", "meta-type": "event", - "arg-type": "253" + "arg-type": "256" }, { "name": "query-pci", - "ret-type": "[254]", + "ret-type": "[257]", "meta-type": "command", "arg-type": "0" }, { "name": "query-stats", - "ret-type": "[256]", + "ret-type": "[259]", "meta-type": "command", - "arg-type": "255" + "arg-type": "258" }, { "name": "query-stats-schemas", - "ret-type": "[258]", + "ret-type": "[261]", "meta-type": "command", - "arg-type": "257" + "arg-type": "260" }, { "name": "x-query-virtio", - "ret-type": "[259]", + "ret-type": "[262]", "meta-type": "command", "arg-type": "0", "features": [ @@ -1671,43 +1671,43 @@ }, { "name": "x-query-virtio-status", - "ret-type": "261", + "ret-type": "264", "meta-type": "command", - "arg-type": "260", + "arg-type": "263", "features": [ "unstable" ] }, { "name": "x-query-virtio-queue-status", - "ret-type": "263", + "ret-type": "266", "meta-type": "command", - "arg-type": "262", + "arg-type": "265", "features": [ "unstable" ] }, { "name": "x-query-virtio-vhost-queue-status", - "ret-type": "265", + "ret-type": "268", "meta-type": "command", - "arg-type": "264", + "arg-type": "267", "features": [ "unstable" ] }, { "name": "x-query-virtio-queue-element", - "ret-type": "267", + "ret-type": "270", "meta-type": "command", - "arg-type": "266", + "arg-type": "269", "features": [ "unstable" ] }, { "name": "query-cryptodev", - "ret-type": "[268]", + "ret-type": "[271]", "meta-type": "command", "arg-type": "0" }, @@ -1715,37 +1715,37 @@ "name": "cxl-inject-general-media-event", "ret-type": "0", "meta-type": "command", - "arg-type": "269" + "arg-type": "272" }, { "name": "cxl-inject-dram-event", "ret-type": "0", "meta-type": "command", - "arg-type": "270" + "arg-type": "273" }, { "name": "cxl-inject-memory-module-event", "ret-type": "0", "meta-type": "command", - "arg-type": "271" + "arg-type": "274" }, { "name": "cxl-inject-poison", "ret-type": "0", "meta-type": "command", - "arg-type": "272" + "arg-type": "275" }, { "name": "cxl-inject-uncorrectable-errors", "ret-type": "0", "meta-type": "command", - "arg-type": "273" + "arg-type": "276" }, { "name": "cxl-inject-correctable-error", "ret-type": "0", "meta-type": "command", - "arg-type": "274" + "arg-type": "277" }, { "name": "0", @@ -1769,7 +1769,7 @@ }, { "name": "status", - "type": "275" + "type": "278" } ], "meta-type": "object" @@ -1783,7 +1783,7 @@ }, { "name": "reason", - "type": "276" + "type": "279" } ], "meta-type": "object" @@ -1797,7 +1797,7 @@ }, { "name": "reason", - "type": "276" + "type": "279" } ], "meta-type": "object" @@ -1807,7 +1807,7 @@ "members": [ { "name": "action", - "type": "277" + "type": "280" } ], "meta-type": "object" @@ -1817,7 +1817,7 @@ "members": [ { "name": "action", - "type": "277" + "type": "280" } ], "meta-type": "object" @@ -1828,22 +1828,22 @@ { "name": "reboot", "default": null, - "type": "278" + "type": "281" }, { "name": "shutdown", "default": null, - "type": "279" + "type": "282" }, { "name": "panic", "default": null, - "type": "280" + "type": "283" }, { "name": "watchdog", "default": null, - "type": "277" + "type": "280" } ], "meta-type": "object" @@ -1853,12 +1853,12 @@ "members": [ { "name": "action", - "type": "281" + "type": "284" }, { "name": "info", "default": null, - "type": "282" + "type": "285" } ], "meta-type": "object" @@ -1868,12 +1868,12 @@ "members": [ { "name": "action", - "type": "281" + "type": "284" }, { "name": "info", "default": null, - "type": "282" + "type": "285" } ], "meta-type": "object" @@ -1883,15 +1883,15 @@ "members": [ { "name": "recipient", - "type": "283" + "type": "286" }, { "name": "action", - "type": "284" + "type": "287" }, { "name": "flags", - "type": "285" + "type": "288" } ], "meta-type": "object" @@ -1905,7 +1905,7 @@ }, { "name": "status", - "type": "286" + "type": "289" } ], "meta-type": "object" @@ -1984,11 +1984,11 @@ }, { "name": "type", - "type": "287" + "type": "290" }, { "name": "status", - "type": "286" + "type": "289" }, { "name": "current-progress", @@ -2149,7 +2149,7 @@ { "name": "read-only-mode", "default": null, - "type": "288" + "type": "291" } ], "meta-type": "object" @@ -2376,7 +2376,7 @@ { "name": "io-status", "default": null, - "type": "289" + "type": "292" } ], "meta-type": "object" @@ -2417,12 +2417,12 @@ }, { "name": "stats", - "type": "290" + "type": "293" }, { "name": "driver-specific", "default": null, - "type": "291" + "type": "294" }, { "name": "parent", @@ -2475,7 +2475,7 @@ }, { "name": "io-status", - "type": "289" + "type": "292" }, { "name": "ready", @@ -2483,7 +2483,7 @@ }, { "name": "status", - "type": "286" + "type": "289" }, { "name": "auto-finalize", @@ -2551,7 +2551,7 @@ { "name": "mode", "default": null, - "type": "292" + "type": "295" } ], "meta-type": "object" @@ -2639,7 +2639,7 @@ { "name": "on-error", "default": null, - "type": "293" + "type": "296" }, { "name": "filter-node-name", @@ -2673,7 +2673,7 @@ }, { "name": "sync", - "type": "294" + "type": "297" }, { "name": "speed", @@ -2688,7 +2688,7 @@ { "name": "bitmap-mode", "default": null, - "type": "295" + "type": "298" }, { "name": "compress", @@ -2698,12 +2698,12 @@ { "name": "on-source-error", "default": null, - "type": "293" + "type": "296" }, { "name": "on-target-error", "default": null, - "type": "293" + "type": "296" }, { "name": "auto-finalize", @@ -2723,7 +2723,7 @@ { "name": "x-perf", "default": null, - "type": "296", + "type": "299", "features": [ "unstable" ] @@ -2740,7 +2740,7 @@ { "name": "mode", "default": null, - "type": "292" + "type": "295" } ], "meta-type": "object" @@ -2759,7 +2759,7 @@ }, { "name": "sync", - "type": "294" + "type": "297" }, { "name": "speed", @@ -2774,7 +2774,7 @@ { "name": "bitmap-mode", "default": null, - "type": "295" + "type": "298" }, { "name": "compress", @@ -2784,12 +2784,12 @@ { "name": "on-source-error", "default": null, - "type": "293" + "type": "296" }, { "name": "on-target-error", "default": null, - "type": "293" + "type": "296" }, { "name": "auto-finalize", @@ -2809,7 +2809,7 @@ { "name": "x-perf", "default": null, - "type": "296", + "type": "299", "features": [ "unstable" ] @@ -2872,7 +2872,7 @@ }, { "name": "detect_zeroes", - "type": "297" + "type": "300" }, { "name": "bps", @@ -2900,7 +2900,7 @@ }, { "name": "image", - "type": "298" + "type": "301" }, { "name": "bps_max", @@ -2974,7 +2974,7 @@ }, { "name": "cache", - "type": "299" + "type": "302" }, { "name": "write_threshold", @@ -2983,7 +2983,7 @@ { "name": "dirty-bitmaps", "default": null, - "type": "[300]" + "type": "[303]" } ], "meta-type": "object" @@ -2993,11 +2993,11 @@ "members": [ { "name": "nodes", - "type": "[301]" + "type": "[304]" }, { "name": "edges", - "type": "[302]" + "type": "[305]" } ], "meta-type": "object" @@ -3035,12 +3035,12 @@ }, { "name": "sync", - "type": "294" + "type": "297" }, { "name": "mode", "default": null, - "type": "292" + "type": "295" }, { "name": "speed", @@ -3060,12 +3060,12 @@ { "name": "on-source-error", "default": null, - "type": "293" + "type": "296" }, { "name": "on-target-error", "default": null, - "type": "293" + "type": "296" }, { "name": "unmap", @@ -3075,7 +3075,7 @@ { "name": "copy-mode", "default": null, - "type": "303" + "type": "306" }, { "name": "auto-finalize", @@ -3146,7 +3146,7 @@ }, { "name": "bitmaps", - "type": "[304]" + "type": "[307]" } ], "meta-type": "object" @@ -3184,7 +3184,7 @@ }, { "name": "sync", - "type": "294" + "type": "297" }, { "name": "speed", @@ -3204,12 +3204,12 @@ { "name": "on-source-error", "default": null, - "type": "293" + "type": "296" }, { "name": "on-target-error", "default": null, - "type": "293" + "type": "296" }, { "name": "filter-node-name", @@ -3219,7 +3219,7 @@ { "name": "copy-mode", "default": null, - "type": "303" + "type": "306" }, { "name": "auto-finalize", @@ -3274,7 +3274,7 @@ { "name": "on-error", "default": null, - "type": "293" + "type": "296" }, { "name": "filter-node-name", @@ -3379,197 +3379,197 @@ "variants": [ { "case": "blkdebug", - "type": "308" + "type": "311" }, { "case": "blklogwrites", - "type": "309" + "type": "312" }, { "case": "blkverify", - "type": "310" + "type": "313" }, { "case": "blkreplay", - "type": "311" + "type": "314" }, { "case": "bochs", - "type": "312" + "type": "315" }, { "case": "cloop", - "type": "312" + "type": "315" }, { "case": "compress", - "type": "312" + "type": "315" }, { "case": "copy-before-write", - "type": "313" + "type": "316" }, { "case": "copy-on-read", - "type": "314" + "type": "317" }, { "case": "dmg", - "type": "312" + "type": "315" }, { "case": "file", - "type": "315" + "type": "318" }, { "case": "ftp", - "type": "316" + "type": "319" }, { "case": "ftps", - "type": "317" + "type": "320" }, { "case": "gluster", - "type": "318" + "type": "321" }, { "case": "host_cdrom", - "type": "315" + "type": "318" }, { "case": "host_device", - "type": "315" + "type": "318" }, { "case": "http", - "type": "319" + "type": "322" }, { "case": "https", - "type": "320" + "type": "323" }, { "case": "io_uring", - "type": "321" + "type": "324" }, { "case": "iscsi", - "type": "322" + "type": "325" }, { "case": "luks", - "type": "323" + "type": "326" }, { "case": "nbd", - "type": "324" + "type": "327" }, { "case": "nfs", - "type": "325" + "type": "328" }, { "case": "null-aio", - "type": "326" + "type": "329" }, { "case": "null-co", - "type": "326" + "type": "329" }, { "case": "nvme", - "type": "327" + "type": "330" }, { "case": "nvme-io_uring", - "type": "328" + "type": "331" }, { "case": "parallels", - "type": "312" + "type": "315" }, { "case": "preallocate", - "type": "329" + "type": "332" }, { "case": "qcow2", - "type": "330" + "type": "333" }, { "case": "qcow", - "type": "331" + "type": "334" }, { "case": "qed", - "type": "332" + "type": "335" }, { "case": "quorum", - "type": "333" + "type": "336" }, { "case": "raw", - "type": "334" + "type": "337" }, { "case": "rbd", - "type": "335" + "type": "338" }, { "case": "replication", - "type": "336" + "type": "339" }, { "case": "snapshot-access", - "type": "312" + "type": "315" }, { "case": "ssh", - "type": "337" + "type": "340" }, { "case": "throttle", - "type": "338" + "type": "341" }, { "case": "vdi", - "type": "312" + "type": "315" }, { "case": "vhdx", - "type": "312" + "type": "315" }, { "case": "virtio-blk-vfio-pci", - "type": "339" + "type": "342" }, { "case": "virtio-blk-vhost-user", - "type": "340" + "type": "343" }, { "case": "virtio-blk-vhost-vdpa", - "type": "341" + "type": "344" }, { "case": "vmdk", - "type": "332" + "type": "335" }, { "case": "vpc", - "type": "312" + "type": "315" }, { "case": "vvfat", - "type": "342" + "type": "345" } ], "members": [ { "name": "driver", - "type": "305" + "type": "308" }, { "name": "node-name", @@ -3579,12 +3579,12 @@ { "name": "discard", "default": null, - "type": "306" + "type": "309" }, { "name": "cache", "default": null, - "type": "307" + "type": "310" }, { "name": "read-only", @@ -3604,7 +3604,7 @@ { "name": "detect-zeroes", "default": null, - "type": "297" + "type": "300" } ], "meta-type": "object" @@ -3638,7 +3638,7 @@ }, { "name": "options", - "type": "343" + "type": "346" } ], "meta-type": "object" @@ -3656,7 +3656,7 @@ }, { "name": "options", - "type": "344" + "type": "347" }, { "name": "force", @@ -3713,11 +3713,11 @@ }, { "name": "operation", - "type": "345" + "type": "348" }, { "name": "action", - "type": "346" + "type": "349" }, { "name": "nospace", @@ -3736,7 +3736,7 @@ "members": [ { "name": "type", - "type": "287" + "type": "290" }, { "name": "device", @@ -3767,7 +3767,7 @@ "members": [ { "name": "type", - "type": "287" + "type": "290" }, { "name": "device", @@ -3797,11 +3797,11 @@ }, { "name": "operation", - "type": "345" + "type": "348" }, { "name": "action", - "type": "346" + "type": "349" } ], "meta-type": "object" @@ -3811,7 +3811,7 @@ "members": [ { "name": "type", - "type": "287" + "type": "290" }, { "name": "device", @@ -3837,7 +3837,7 @@ "members": [ { "name": "type", - "type": "287" + "type": "290" }, { "name": "id", @@ -3907,7 +3907,7 @@ }, { "name": "iothread", - "type": "347" + "type": "350" }, { "name": "force", @@ -3940,7 +3940,7 @@ "members": [ { "name": "type", - "type": "348" + "type": "351" }, { "name": "error", @@ -4040,7 +4040,7 @@ "members": [ { "name": "addr", - "type": "349" + "type": "352" }, { "name": "tls-creds", @@ -4100,7 +4100,7 @@ { "name": "mode", "default": null, - "type": "350" + "type": "353" } ], "meta-type": "object" @@ -4111,25 +4111,25 @@ "variants": [ { "case": "nbd", - "type": "352" + "type": "355" }, { "case": "vhost-user-blk", - "type": "353" + "type": "356" }, { "case": "fuse", - "type": "354" + "type": "357" }, { "case": "vduse-blk", - "type": "355" + "type": "358" } ], "members": [ { "name": "type", - "type": "351" + "type": "354" }, { "name": "id", @@ -4172,7 +4172,7 @@ { "name": "mode", "default": null, - "type": "350" + "type": "353" } ], "meta-type": "object" @@ -4201,7 +4201,7 @@ }, { "name": "type", - "type": "351" + "type": "354" }, { "name": "node-name", @@ -4266,7 +4266,7 @@ { "name": "format", "default": null, - "type": "356" + "type": "359" } ], "meta-type": "object" @@ -4285,7 +4285,7 @@ { "name": "format", "default": null, - "type": "356" + "type": "359" } ], "meta-type": "object" @@ -4304,7 +4304,7 @@ }, { "name": "backend", - "type": "357" + "type": "360" } ], "meta-type": "object" @@ -4329,7 +4329,7 @@ }, { "name": "backend", - "type": "357" + "type": "360" } ], "meta-type": "object" @@ -4397,7 +4397,7 @@ { "name": "format", "default": null, - "type": "358" + "type": "361" } ], "meta-type": "object" @@ -4407,7 +4407,7 @@ "members": [ { "name": "status", - "type": "359" + "type": "362" }, { "name": "completed", @@ -4440,7 +4440,7 @@ "members": [ { "name": "formats", - "type": "[358]" + "type": "[361]" } ], "meta-type": "object" @@ -4465,55 +4465,55 @@ "variants": [ { "case": "nic", - "type": "361" + "type": "364" }, { "case": "user", - "type": "362" + "type": "365" }, { "case": "tap", - "type": "363" + "type": "366" }, { "case": "l2tpv3", - "type": "364" + "type": "367" }, { "case": "socket", - "type": "365" + "type": "368" }, { "case": "stream", - "type": "366" + "type": "369" }, { "case": "dgram", - "type": "367" + "type": "370" }, { "case": "vde", - "type": "368" + "type": "371" }, { "case": "bridge", - "type": "369" + "type": "372" }, { "case": "hubport", - "type": "370" + "type": "373" }, { "case": "netmap", - "type": "371" + "type": "374" }, { "case": "vhost-user", - "type": "373" + "type": "376" }, { "case": "vhost-vdpa", - "type": "374" + "type": "377" }, { "case": "none", @@ -4527,7 +4527,7 @@ }, { "name": "type", - "type": "360" + "type": "363" } ], "meta-type": "object" @@ -4571,15 +4571,15 @@ }, { "name": "multicast", - "type": "378" + "type": "381" }, { "name": "unicast", - "type": "378" + "type": "381" }, { "name": "vlan", - "type": "378" + "type": "381" }, { "name": "broadcast-allowed", @@ -4678,7 +4678,7 @@ }, { "name": "addr", - "type": "379" + "type": "382" } ], "meta-type": "object" @@ -4779,11 +4779,11 @@ }, { "name": "duplex", - "type": "380" + "type": "383" }, { "name": "autoneg", - "type": "381" + "type": "384" } ], "meta-type": "object" @@ -4821,15 +4821,15 @@ }, { "name": "key", - "type": "382" + "type": "385" }, { "name": "mask", - "type": "383" + "type": "386" }, { "name": "action", - "type": "384" + "type": "387" } ], "meta-type": "object" @@ -4987,7 +4987,7 @@ }, { "name": "options", - "type": "385" + "type": "388" } ], "meta-type": "object" @@ -4998,7 +4998,7 @@ "variants": [ { "case": "vnc", - "type": "388" + "type": "391" }, { "case": "spice", @@ -5008,7 +5008,7 @@ "members": [ { "name": "protocol", - "type": "386" + "type": "389" }, { "name": "password", @@ -5017,7 +5017,7 @@ { "name": "connected", "default": null, - "type": "387" + "type": "390" } ], "meta-type": "object" @@ -5028,7 +5028,7 @@ "variants": [ { "case": "vnc", - "type": "389" + "type": "392" }, { "case": "spice", @@ -5038,7 +5038,7 @@ "members": [ { "name": "protocol", - "type": "386" + "type": "389" }, { "name": "time", @@ -5067,7 +5067,7 @@ { "name": "format", "default": null, - "type": "390" + "type": "393" } ], "meta-type": "object" @@ -5110,12 +5110,12 @@ }, { "name": "mouse-mode", - "type": "391" + "type": "394" }, { "name": "channels", "default": null, - "type": "[392]" + "type": "[395]" } ], "meta-type": "object" @@ -5125,11 +5125,11 @@ "members": [ { "name": "server", - "type": "393" + "type": "396" }, { "name": "client", - "type": "393" + "type": "396" } ], "meta-type": "object" @@ -5139,11 +5139,11 @@ "members": [ { "name": "server", - "type": "394" + "type": "397" }, { "name": "client", - "type": "392" + "type": "395" } ], "meta-type": "object" @@ -5153,11 +5153,11 @@ "members": [ { "name": "server", - "type": "393" + "type": "396" }, { "name": "client", - "type": "393" + "type": "396" } ], "meta-type": "object" @@ -5177,7 +5177,7 @@ { "name": "family", "default": null, - "type": "395" + "type": "398" }, { "name": "service", @@ -5192,7 +5192,7 @@ { "name": "clients", "default": null, - "type": "[396]" + "type": "[399]" } ], "meta-type": "object" @@ -5211,20 +5211,20 @@ }, { "name": "server", - "type": "[397]" + "type": "[400]" }, { "name": "clients", - "type": "[396]" + "type": "[399]" }, { "name": "auth", - "type": "398" + "type": "401" }, { "name": "vencrypt", "default": null, - "type": "399" + "type": "402" }, { "name": "display", @@ -5249,11 +5249,11 @@ "members": [ { "name": "server", - "type": "400" + "type": "403" }, { "name": "client", - "type": "401" + "type": "404" } ], "meta-type": "object" @@ -5263,11 +5263,11 @@ "members": [ { "name": "server", - "type": "400" + "type": "403" }, { "name": "client", - "type": "396" + "type": "399" } ], "meta-type": "object" @@ -5277,11 +5277,11 @@ "members": [ { "name": "server", - "type": "400" + "type": "403" }, { "name": "client", - "type": "396" + "type": "399" } ], "meta-type": "object" @@ -5318,7 +5318,7 @@ "members": [ { "name": "keys", - "type": "[402]" + "type": "[405]" }, { "name": "hold-time", @@ -5343,7 +5343,7 @@ }, { "name": "events", - "type": "[403]" + "type": "[406]" } ], "meta-type": "object" @@ -5354,19 +5354,19 @@ "variants": [ { "case": "curses", - "type": "408" + "type": "411" }, { "case": "egl-headless", - "type": "409" + "type": "412" }, { "case": "dbus", - "type": "410" + "type": "413" }, { "case": "sdl", - "type": "411" + "type": "414" }, { "case": "default", @@ -5384,7 +5384,7 @@ "members": [ { "name": "type", - "type": "404" + "type": "407" }, { "name": "full-screen", @@ -5404,7 +5404,7 @@ { "name": "gl", "default": null, - "type": "405" + "type": "408" } ], "meta-type": "object" @@ -5415,13 +5415,13 @@ "variants": [ { "case": "vnc", - "type": "413" + "type": "416" } ], "members": [ { "name": "type", - "type": "412" + "type": "415" } ], "meta-type": "object" @@ -5432,13 +5432,13 @@ "variants": [ { "case": "vnc", - "type": "415" + "type": "418" } ], "members": [ { "name": "type", - "type": "414" + "type": "417" } ], "meta-type": "object" @@ -5478,27 +5478,27 @@ { "name": "status", "default": null, - "type": "416" + "type": "419" }, { "name": "ram", "default": null, - "type": "417" + "type": "420" }, { "name": "disk", "default": null, - "type": "417" + "type": "420" }, { "name": "vfio", "default": null, - "type": "418" + "type": "421" }, { "name": "xbzrle-cache", "default": null, - "type": "419" + "type": "422" }, { "name": "total-time", @@ -5548,12 +5548,12 @@ { "name": "compression", "default": null, - "type": "420" + "type": "423" }, { "name": "socket-address", "default": null, - "type": "[379]" + "type": "[382]" }, { "name": "dirty-limit-throttle-time-per-round", @@ -5588,7 +5588,7 @@ "members": [ { "name": "capability", - "type": "421" + "type": "424" }, { "name": "state", @@ -5663,23 +5663,28 @@ { "name": "tls-creds", "default": null, - "type": "347" + "type": "350" }, { "name": "tls-hostname", "default": null, - "type": "347" + "type": "350" }, { "name": "tls-authz", "default": null, - "type": "347" + "type": "350" }, { "name": "max-bandwidth", "default": null, "type": "int" }, + { + "name": "avail-switchover-bandwidth", + "default": null, + "type": "int" + }, { "name": "downtime-limit", "default": null, @@ -5721,7 +5726,7 @@ { "name": "multifd-compression", "default": null, - "type": "422" + "type": "425" }, { "name": "multifd-zlib-level", @@ -5736,7 +5741,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[423]" + "type": "[426]" }, { "name": "x-vcpu-dirty-limit-period", @@ -5837,6 +5842,11 @@ "default": null, "type": "int" }, + { + "name": "avail-switchover-bandwidth", + "default": null, + "type": "int" + }, { "name": "downtime-limit", "default": null, @@ -5878,7 +5888,7 @@ { "name": "multifd-compression", "default": null, - "type": "422" + "type": "425" }, { "name": "multifd-zlib-level", @@ -5893,7 +5903,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[423]" + "type": "[426]" }, { "name": "x-vcpu-dirty-limit-period", @@ -5916,7 +5926,7 @@ "members": [ { "name": "status", - "type": "416" + "type": "419" } ], "meta-type": "object" @@ -5936,11 +5946,11 @@ "members": [ { "name": "mode", - "type": "424" + "type": "427" }, { "name": "reason", - "type": "425" + "type": "428" } ], "meta-type": "object" @@ -5950,7 +5960,7 @@ "members": [ { "name": "state", - "type": "416" + "type": "419" } ], "meta-type": "object" @@ -6069,15 +6079,15 @@ "members": [ { "name": "mode", - "type": "424" + "type": "427" }, { "name": "last-mode", - "type": "424" + "type": "427" }, { "name": "reason", - "type": "425" + "type": "428" } ], "meta-type": "object" @@ -6112,7 +6122,7 @@ { "name": "calc-time-unit", "default": null, - "type": "426" + "type": "429" }, { "name": "sample-pages", @@ -6122,7 +6132,7 @@ { "name": "mode", "default": null, - "type": "427" + "type": "430" } ], "meta-type": "object" @@ -6133,7 +6143,7 @@ { "name": "calc-time-unit", "default": null, - "type": "426" + "type": "429" } ], "meta-type": "object" @@ -6148,7 +6158,7 @@ }, { "name": "status", - "type": "428" + "type": "431" }, { "name": "start-time", @@ -6160,7 +6170,7 @@ }, { "name": "calc-time-unit", - "type": "426" + "type": "429" }, { "name": "sample-pages", @@ -6168,12 +6178,12 @@ }, { "name": "mode", - "type": "427" + "type": "430" }, { "name": "vcpu-dirty-rate", "default": null, - "type": "[429]" + "type": "[432]" } ], "meta-type": "object" @@ -6313,12 +6323,12 @@ "members": [ { "name": "actions", - "type": "[430]" + "type": "[433]" }, { "name": "properties", "default": null, - "type": "431" + "type": "434" } ], "meta-type": "object" @@ -6355,7 +6365,7 @@ }, { "name": "state", - "type": "432" + "type": "435" }, { "name": "vcpu", @@ -6400,7 +6410,7 @@ { "name": "enable", "default": null, - "type": "[433]" + "type": "[436]" } ], "meta-type": "object" @@ -6410,7 +6420,7 @@ "members": [ { "name": "qemu", - "type": "434" + "type": "437" }, { "name": "package", @@ -6445,31 +6455,31 @@ "variants": [ { "case": "builtin", - "type": "436" + "type": "439" }, { "case": "enum", - "type": "437" + "type": "440" }, { "case": "array", - "type": "438" + "type": "441" }, { "case": "object", - "type": "439" + "type": "442" }, { "case": "alternate", - "type": "440" + "type": "443" }, { "case": "command", - "type": "441" + "type": "444" }, { "case": "event", - "type": "442" + "type": "445" } ], "members": [ @@ -6479,7 +6489,7 @@ }, { "name": "meta-type", - "type": "435" + "type": "438" }, { "name": "features", @@ -6622,167 +6632,167 @@ "variants": [ { "case": "authz-list", - "type": "444" + "type": "447" }, { "case": "authz-listfile", - "type": "445" + "type": "448" }, { "case": "authz-pam", - "type": "446" + "type": "449" }, { "case": "authz-simple", - "type": "447" + "type": "450" }, { "case": "can-host-socketcan", - "type": "448" + "type": "451" }, { "case": "colo-compare", - "type": "449" + "type": "452" }, { "case": "cryptodev-backend", - "type": "450" + "type": "453" }, { "case": "cryptodev-backend-builtin", - "type": "450" + "type": "453" }, { "case": "cryptodev-backend-lkcf", - "type": "450" + "type": "453" }, { "case": "cryptodev-vhost-user", - "type": "451" + "type": "454" }, { "case": "dbus-vmstate", - "type": "452" + "type": "455" }, { "case": "filter-buffer", - "type": "453" + "type": "456" }, { "case": "filter-dump", - "type": "454" + "type": "457" }, { "case": "filter-mirror", - "type": "455" + "type": "458" }, { "case": "filter-redirector", - "type": "456" + "type": "459" }, { "case": "filter-replay", - "type": "457" + "type": "460" }, { "case": "filter-rewriter", - "type": "458" + "type": "461" }, { "case": "input-barrier", - "type": "459" + "type": "462" }, { "case": "input-linux", - "type": "460" + "type": "463" }, { "case": "iothread", - "type": "461" + "type": "464" }, { "case": "main-loop", - "type": "462" + "type": "465" }, { "case": "memory-backend-epc", - "type": "463" + "type": "466" }, { "case": "memory-backend-file", - "type": "464" + "type": "467" }, { "case": "memory-backend-memfd", - "type": "465" + "type": "468" }, { "case": "memory-backend-ram", - "type": "466" + "type": "469" }, { "case": "pr-manager-helper", - "type": "467" + "type": "470" }, { "case": "qtest", - "type": "468" + "type": "471" }, { "case": "rng-builtin", - "type": "469" + "type": "472" }, { "case": "rng-egd", - "type": "470" + "type": "473" }, { "case": "rng-random", - "type": "471" + "type": "474" }, { "case": "secret", - "type": "472" + "type": "475" }, { "case": "secret_keyring", - "type": "473" + "type": "476" }, { "case": "sev-guest", - "type": "474" + "type": "477" }, { "case": "thread-context", - "type": "475" + "type": "478" }, { "case": "throttle-group", - "type": "476" + "type": "479" }, { "case": "tls-creds-anon", - "type": "477" + "type": "480" }, { "case": "tls-creds-psk", - "type": "478" + "type": "481" }, { "case": "tls-creds-x509", - "type": "479" + "type": "482" }, { "case": "tls-cipher-suites", - "type": "480" + "type": "483" }, { "case": "x-remote-object", - "type": "481" + "type": "484" }, { "case": "x-vfio-user-server", - "type": "482" + "type": "485" }, { "case": "can-bus", @@ -6800,7 +6810,7 @@ "members": [ { "name": "qom-type", - "type": "443" + "type": "446" }, { "name": "id", @@ -6900,7 +6910,7 @@ "variants": [ { "case": "s390x", - "type": "485" + "type": "488" }, { "case": "aarch64", @@ -7039,11 +7049,11 @@ { "name": "props", "default": null, - "type": "483" + "type": "486" }, { "name": "target", - "type": "484" + "type": "487" } ], "meta-type": "object" @@ -7118,7 +7128,7 @@ "members": [ { "name": "arch", - "type": "484" + "type": "487" } ], "meta-type": "object" @@ -7242,7 +7252,7 @@ }, { "name": "policy", - "type": "486" + "type": "489" } ], "meta-type": "object" @@ -7265,7 +7275,7 @@ }, { "name": "props", - "type": "483" + "type": "486" }, { "name": "qom-path", @@ -7281,29 +7291,29 @@ "variants": [ { "case": "node", - "type": "488" + "type": "491" }, { "case": "dist", - "type": "489" + "type": "492" }, { "case": "cpu", - "type": "490" + "type": "493" }, { "case": "hmat-lb", - "type": "491" + "type": "494" }, { "case": "hmat-cache", - "type": "492" + "type": "495" } ], "members": [ { "name": "type", - "type": "487" + "type": "490" } ], "meta-type": "object" @@ -7364,29 +7374,29 @@ "variants": [ { "case": "dimm", - "type": "494" + "type": "497" }, { "case": "nvdimm", - "type": "494" + "type": "497" }, { "case": "virtio-pmem", - "type": "495" + "type": "498" }, { "case": "virtio-mem", - "type": "496" + "type": "499" }, { "case": "sgx-epc", - "type": "497" + "type": "500" } ], "members": [ { "name": "type", - "type": "493" + "type": "496" } ], "meta-type": "object" @@ -7449,11 +7459,11 @@ "members": [ { "name": "type", - "type": "500" + "type": "503" }, { "name": "model", - "type": "498" + "type": "501" } ], "meta-type": "object" @@ -7463,7 +7473,7 @@ "members": [ { "name": "model", - "type": "498" + "type": "501" } ], "meta-type": "object" @@ -7511,11 +7521,11 @@ "meta-type": "object" }, { - "name": "220", + "name": "223", "members": [ { "name": "mode", - "type": "501" + "type": "506" }, { "name": "filename", @@ -7530,7 +7540,7 @@ "meta-type": "object" }, { - "name": "221", + "name": "224", "members": [ { "name": "icount", @@ -7540,7 +7550,7 @@ "meta-type": "object" }, { - "name": "222", + "name": "225", "members": [ { "name": "icount", @@ -7550,31 +7560,31 @@ "meta-type": "object" }, { - "name": "223", + "name": "226", "members": [ { "name": "instances", - "type": "[224]" + "type": "[227]" } ], "meta-type": "object" }, { - "name": "[224]", - "element-type": "224", + "name": "[227]", + "element-type": "227", "meta-type": "array" }, { - "name": "224", + "name": "227", "tag": "type", "variants": [ { "case": "block-node", - "type": "503" + "type": "508" }, { "case": "chardev", - "type": "504" + "type": "509" }, { "case": "migration", @@ -7584,13 +7594,13 @@ "members": [ { "name": "type", - "type": "502" + "type": "507" } ], "meta-type": "object" }, { - "name": "225", + "name": "228", "members": [ { "name": "protocol", @@ -7614,7 +7624,7 @@ "meta-type": "object" }, { - "name": "226", + "name": "229", "members": [ { "name": "name", @@ -7625,12 +7635,12 @@ "meta-type": "object" }, { - "name": "[227]", - "element-type": "227", + "name": "[230]", + "element-type": "230", "meta-type": "array" }, { - "name": "227", + "name": "230", "members": [ { "name": "id", @@ -7660,7 +7670,7 @@ "meta-type": "object" }, { - "name": "228", + "name": "231", "members": [ { "name": "command-line", @@ -7675,7 +7685,7 @@ "meta-type": "object" }, { - "name": "229", + "name": "232", "members": [ { "name": "fdname", @@ -7685,7 +7695,7 @@ "meta-type": "object" }, { - "name": "231", + "name": "234", "members": [ { "name": "fdname", @@ -7695,7 +7705,7 @@ "meta-type": "object" }, { - "name": "232", + "name": "235", "members": [ { "name": "fdset-id", @@ -7711,7 +7721,7 @@ "meta-type": "object" }, { - "name": "233", + "name": "236", "members": [ { "name": "fdset-id", @@ -7725,7 +7735,7 @@ "meta-type": "object" }, { - "name": "234", + "name": "237", "members": [ { "name": "fdset-id", @@ -7740,12 +7750,12 @@ "meta-type": "object" }, { - "name": "[235]", - "element-type": "235", + "name": "[238]", + "element-type": "238", "meta-type": "array" }, { - "name": "235", + "name": "238", "members": [ { "name": "fdset-id", @@ -7753,13 +7763,13 @@ }, { "name": "fds", - "type": "[505]" + "type": "[510]" } ], "meta-type": "object" }, { - "name": "236", + "name": "239", "members": [ { "name": "option", @@ -7770,12 +7780,12 @@ "meta-type": "object" }, { - "name": "[237]", - "element-type": "237", + "name": "[240]", + "element-type": "240", "meta-type": "array" }, { - "name": "237", + "name": "240", "members": [ { "name": "option", @@ -7783,13 +7793,13 @@ }, { "name": "parameters", - "type": "[506]" + "type": "[511]" } ], "meta-type": "object" }, { - "name": "238", + "name": "241", "members": [ { "name": "offset", @@ -7803,7 +7813,7 @@ "meta-type": "object" }, { - "name": "239", + "name": "242", "members": [ { "name": "vfu-id", @@ -7825,7 +7835,7 @@ "meta-type": "object" }, { - "name": "240", + "name": "243", "members": [ { "name": "enabled", @@ -7849,7 +7859,7 @@ }, { "name": "state", - "type": "507" + "type": "512" }, { "name": "handle", @@ -7859,7 +7869,7 @@ "meta-type": "object" }, { - "name": "241", + "name": "244", "members": [ { "name": "data", @@ -7869,7 +7879,7 @@ "meta-type": "object" }, { - "name": "242", + "name": "245", "members": [ { "name": "pdh", @@ -7895,7 +7905,7 @@ "meta-type": "object" }, { - "name": "243", + "name": "246", "members": [ { "name": "packet-header", @@ -7914,7 +7924,7 @@ "meta-type": "object" }, { - "name": "244", + "name": "247", "members": [ { "name": "mnonce", @@ -7924,7 +7934,7 @@ "meta-type": "object" }, { - "name": "245", + "name": "248", "members": [ { "name": "data", @@ -7934,7 +7944,7 @@ "meta-type": "object" }, { - "name": "248", + "name": "251", "members": [ { "name": "sgx", @@ -7954,18 +7964,18 @@ }, { "name": "sections", - "type": "[508]" + "type": "[513]" } ], "meta-type": "object" }, { - "name": "[249]", - "element-type": "249", + "name": "[252]", + "element-type": "252", "meta-type": "array" }, { - "name": "249", + "name": "252", "members": [ { "name": "port", @@ -7977,7 +7987,7 @@ }, { "name": "type", - "type": "509" + "type": "514" }, { "name": "remote-domain", @@ -7999,7 +8009,7 @@ "meta-type": "object" }, { - "name": "250", + "name": "253", "members": [ { "name": "port", @@ -8009,45 +8019,45 @@ "meta-type": "object" }, { - "name": "[251]", - "element-type": "251", + "name": "[254]", + "element-type": "254", "meta-type": "array" }, { - "name": "251", + "name": "254", "tag": "driver", "variants": [ { "case": "none", - "type": "511" + "type": "516" }, { "case": "alsa", - "type": "512" + "type": "517" }, { "case": "dbus", - "type": "511" + "type": "516" }, { "case": "oss", - "type": "516" + "type": "521" }, { "case": "pa", - "type": "517" + "type": "522" }, { "case": "sdl", - "type": "519" + "type": "524" }, { "case": "spice", - "type": "511" + "type": "516" }, { "case": "wav", - "type": "521" + "type": "526" } ], "members": [ @@ -8057,7 +8067,7 @@ }, { "name": "driver", - "type": "510" + "type": "515" }, { "name": "timer-period", @@ -8068,12 +8078,12 @@ "meta-type": "object" }, { - "name": "[252]", - "element-type": "252", + "name": "[255]", + "element-type": "255", "meta-type": "array" }, { - "name": "252", + "name": "255", "members": [ { "name": "device", @@ -8086,7 +8096,7 @@ }, { "name": "slot-type", - "type": "522" + "type": "527" }, { "name": "source", @@ -8100,22 +8110,22 @@ "meta-type": "object" }, { - "name": "253", + "name": "256", "members": [ { "name": "info", - "type": "252" + "type": "255" } ], "meta-type": "object" }, { - "name": "[254]", - "element-type": "254", + "name": "[257]", + "element-type": "257", "meta-type": "array" }, { - "name": "254", + "name": "257", "members": [ { "name": "bus", @@ -8123,18 +8133,18 @@ }, { "name": "devices", - "type": "[523]" + "type": "[528]" } ], "meta-type": "object" }, { - "name": "255", + "name": "258", "tag": "target", "variants": [ { "case": "vcpu", - "type": "526" + "type": "531" }, { "case": "vm", @@ -8148,27 +8158,27 @@ "members": [ { "name": "target", - "type": "524" + "type": "529" }, { "name": "providers", "default": null, - "type": "[525]" + "type": "[530]" } ], "meta-type": "object" }, { - "name": "[256]", - "element-type": "256", + "name": "[259]", + "element-type": "259", "meta-type": "array" }, { - "name": "256", + "name": "259", "members": [ { "name": "provider", - "type": "527" + "type": "532" }, { "name": "qom-path", @@ -8177,52 +8187,52 @@ }, { "name": "stats", - "type": "[528]" + "type": "[533]" } ], "meta-type": "object" }, { - "name": "257", + "name": "260", "members": [ { "name": "provider", "default": null, - "type": "527" + "type": "532" } ], "meta-type": "object" }, { - "name": "[258]", - "element-type": "258", + "name": "[261]", + "element-type": "261", "meta-type": "array" }, { - "name": "258", + "name": "261", "members": [ { "name": "provider", - "type": "527" + "type": "532" }, { "name": "target", - "type": "524" + "type": "529" }, { "name": "stats", - "type": "[529]" + "type": "[534]" } ], "meta-type": "object" }, { - "name": "[259]", - "element-type": "259", + "name": "[262]", + "element-type": "262", "meta-type": "array" }, { - "name": "259", + "name": "262", "members": [ { "name": "path", @@ -8236,7 +8246,7 @@ "meta-type": "object" }, { - "name": "260", + "name": "263", "members": [ { "name": "path", @@ -8246,7 +8256,7 @@ "meta-type": "object" }, { - "name": "261", + "name": "264", "members": [ { "name": "name", @@ -8266,15 +8276,15 @@ }, { "name": "guest-features", - "type": "530" + "type": "535" }, { "name": "host-features", - "type": "530" + "type": "535" }, { "name": "backend-features", - "type": "530" + "type": "535" }, { "name": "num-vqs", @@ -8282,7 +8292,7 @@ }, { "name": "status", - "type": "531" + "type": "536" }, { "name": "isr", @@ -8331,13 +8341,13 @@ { "name": "vhost-dev", "default": null, - "type": "532" + "type": "537" } ], "meta-type": "object" }, { - "name": "262", + "name": "265", "members": [ { "name": "path", @@ -8351,7 +8361,7 @@ "meta-type": "object" }, { - "name": "263", + "name": "266", "members": [ { "name": "name", @@ -8415,7 +8425,7 @@ "meta-type": "object" }, { - "name": "264", + "name": "267", "members": [ { "name": "path", @@ -8429,7 +8439,7 @@ "meta-type": "object" }, { - "name": "265", + "name": "268", "members": [ { "name": "name", @@ -8487,7 +8497,7 @@ "meta-type": "object" }, { - "name": "266", + "name": "269", "members": [ { "name": "path", @@ -8506,7 +8516,7 @@ "meta-type": "object" }, { - "name": "267", + "name": "270", "members": [ { "name": "name", @@ -8518,26 +8528,26 @@ }, { "name": "descs", - "type": "[533]" + "type": "[538]" }, { "name": "avail", - "type": "534" + "type": "539" }, { "name": "used", - "type": "535" + "type": "540" } ], "meta-type": "object" }, { - "name": "[268]", - "element-type": "268", + "name": "[271]", + "element-type": "271", "meta-type": "array" }, { - "name": "268", + "name": "271", "members": [ { "name": "id", @@ -8545,17 +8555,17 @@ }, { "name": "service", - "type": "[536]" + "type": "[541]" }, { "name": "client", - "type": "[537]" + "type": "[542]" } ], "meta-type": "object" }, { - "name": "269", + "name": "272", "members": [ { "name": "path", @@ -8563,7 +8573,7 @@ }, { "name": "log", - "type": "538" + "type": "543" }, { "name": "flags", @@ -8609,7 +8619,7 @@ "meta-type": "object" }, { - "name": "270", + "name": "273", "members": [ { "name": "path", @@ -8617,7 +8627,7 @@ }, { "name": "log", - "type": "538" + "type": "543" }, { "name": "flags", @@ -8683,7 +8693,7 @@ "meta-type": "object" }, { - "name": "271", + "name": "274", "members": [ { "name": "path", @@ -8691,7 +8701,7 @@ }, { "name": "log", - "type": "538" + "type": "543" }, { "name": "flags", @@ -8737,7 +8747,7 @@ "meta-type": "object" }, { - "name": "272", + "name": "275", "members": [ { "name": "path", @@ -8755,7 +8765,7 @@ "meta-type": "object" }, { - "name": "273", + "name": "276", "members": [ { "name": "path", @@ -8763,13 +8773,13 @@ }, { "name": "errors", - "type": "[539]" + "type": "[544]" } ], "meta-type": "object" }, { - "name": "274", + "name": "277", "members": [ { "name": "path", @@ -8777,7 +8787,7 @@ }, { "name": "type", - "type": "540" + "type": "545" } ], "meta-type": "object" @@ -8788,7 +8798,7 @@ "meta-type": "builtin" }, { - "name": "275", + "name": "278", "members": [ { "name": "debug" @@ -8860,7 +8870,7 @@ ] }, { - "name": "276", + "name": "279", "members": [ { "name": "none" @@ -8912,7 +8922,7 @@ ] }, { - "name": "277", + "name": "280", "members": [ { "name": "reset" @@ -8948,7 +8958,7 @@ ] }, { - "name": "278", + "name": "281", "members": [ { "name": "reset" @@ -8964,7 +8974,7 @@ ] }, { - "name": "279", + "name": "282", "members": [ { "name": "poweroff" @@ -8980,7 +8990,7 @@ ] }, { - "name": "280", + "name": "283", "members": [ { "name": "pause" @@ -9004,7 +9014,7 @@ ] }, { - "name": "281", + "name": "284", "members": [ { "name": "pause" @@ -9024,28 +9034,28 @@ ] }, { - "name": "282", + "name": "285", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "542" + "type": "547" }, { "case": "s390", - "type": "543" + "type": "548" } ], "members": [ { "name": "type", - "type": "541" + "type": "546" } ], "meta-type": "object" }, { - "name": "283", + "name": "286", "members": [ { "name": "hypervisor" @@ -9061,7 +9071,7 @@ ] }, { - "name": "284", + "name": "287", "members": [ { "name": "ignore" @@ -9085,7 +9095,7 @@ ] }, { - "name": "285", + "name": "288", "members": [ { "name": "action-required", @@ -9099,7 +9109,7 @@ "meta-type": "object" }, { - "name": "286", + "name": "289", "members": [ { "name": "undefined" @@ -9151,7 +9161,7 @@ ] }, { - "name": "287", + "name": "290", "members": [ { "name": "commit" @@ -9200,7 +9210,7 @@ "meta-type": "builtin" }, { - "name": "288", + "name": "291", "members": [ { "name": "retain" @@ -9225,7 +9235,7 @@ "meta-type": "array" }, { - "name": "289", + "name": "292", "members": [ { "name": "ok" @@ -9245,7 +9255,7 @@ ] }, { - "name": "290", + "name": "293", "members": [ { "name": "rd_bytes", @@ -9378,46 +9388,46 @@ }, { "name": "timed_stats", - "type": "[544]" + "type": "[549]" }, { "name": "rd_latency_histogram", "default": null, - "type": "545" + "type": "550" }, { "name": "wr_latency_histogram", "default": null, - "type": "545" + "type": "550" }, { "name": "zone_append_latency_histogram", "default": null, - "type": "545" + "type": "550" }, { "name": "flush_latency_histogram", "default": null, - "type": "545" + "type": "550" } ], "meta-type": "object" }, { - "name": "291", + "name": "294", "tag": "driver", "variants": [ { "case": "file", - "type": "546" + "type": "551" }, { "case": "host_device", - "type": "546" + "type": "551" }, { "case": "nvme", - "type": "547" + "type": "552" }, { "case": "blkdebug", @@ -9599,13 +9609,13 @@ "members": [ { "name": "driver", - "type": "305" + "type": "308" } ], "meta-type": "object" }, { - "name": "292", + "name": "295", "members": [ { "name": "existing" @@ -9621,7 +9631,7 @@ ] }, { - "name": "293", + "name": "296", "members": [ { "name": "report" @@ -9649,7 +9659,7 @@ ] }, { - "name": "294", + "name": "297", "members": [ { "name": "top" @@ -9677,7 +9687,7 @@ ] }, { - "name": "295", + "name": "298", "members": [ { "name": "on-success" @@ -9697,7 +9707,7 @@ ] }, { - "name": "296", + "name": "299", "members": [ { "name": "use-copy-range", @@ -9718,7 +9728,7 @@ "meta-type": "object" }, { - "name": "297", + "name": "300", "members": [ { "name": "off" @@ -9738,7 +9748,7 @@ ] }, { - "name": "298", + "name": "301", "members": [ { "name": "filename", @@ -9800,18 +9810,18 @@ { "name": "format-specific", "default": null, - "type": "548" + "type": "553" }, { "name": "backing-image", "default": null, - "type": "298" + "type": "301" } ], "meta-type": "object" }, { - "name": "299", + "name": "302", "members": [ { "name": "writeback", @@ -9829,12 +9839,12 @@ "meta-type": "object" }, { - "name": "[300]", - "element-type": "300", + "name": "[303]", + "element-type": "303", "meta-type": "array" }, { - "name": "300", + "name": "303", "members": [ { "name": "name", @@ -9870,12 +9880,12 @@ "meta-type": "object" }, { - "name": "[301]", - "element-type": "301", + "name": "[304]", + "element-type": "304", "meta-type": "array" }, { - "name": "301", + "name": "304", "members": [ { "name": "id", @@ -9883,7 +9893,7 @@ }, { "name": "type", - "type": "549" + "type": "554" }, { "name": "name", @@ -9893,12 +9903,12 @@ "meta-type": "object" }, { - "name": "[302]", - "element-type": "302", + "name": "[305]", + "element-type": "305", "meta-type": "array" }, { - "name": "302", + "name": "305", "members": [ { "name": "parent", @@ -9914,17 +9924,17 @@ }, { "name": "perm", - "type": "[550]" + "type": "[555]" }, { "name": "shared-perm", - "type": "[550]" + "type": "[555]" } ], "meta-type": "object" }, { - "name": "303", + "name": "306", "members": [ { "name": "background" @@ -9940,12 +9950,12 @@ ] }, { - "name": "[304]", - "element-type": "304", + "name": "[307]", + "element-type": "307", "meta-type": "array" }, { - "name": "304", + "name": "307", "members": [ { "type": "str" @@ -9957,7 +9967,7 @@ "meta-type": "alternate" }, { - "name": "305", + "name": "308", "members": [ { "name": "blkdebug" @@ -10153,7 +10163,7 @@ ] }, { - "name": "306", + "name": "309", "members": [ { "name": "ignore" @@ -10169,7 +10179,7 @@ ] }, { - "name": "307", + "name": "310", "members": [ { "name": "direct", @@ -10185,11 +10195,11 @@ "meta-type": "object" }, { - "name": "308", + "name": "311", "members": [ { "name": "image", - "type": "551" + "type": "556" }, { "name": "config", @@ -10229,36 +10239,36 @@ { "name": "inject-error", "default": null, - "type": "[552]" + "type": "[557]" }, { "name": "set-state", "default": null, - "type": "[553]" + "type": "[558]" }, { "name": "take-child-perms", "default": null, - "type": "[550]" + "type": "[555]" }, { "name": "unshare-child-perms", "default": null, - "type": "[550]" + "type": "[555]" } ], "meta-type": "object" }, { - "name": "309", + "name": "312", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "log", - "type": "551" + "type": "556" }, { "name": "log-sector-size", @@ -10279,49 +10289,49 @@ "meta-type": "object" }, { - "name": "310", + "name": "313", "members": [ { "name": "test", - "type": "551" + "type": "556" }, { "name": "raw", - "type": "551" + "type": "556" } ], "meta-type": "object" }, { - "name": "311", + "name": "314", "members": [ { "name": "image", - "type": "551" + "type": "556" } ], "meta-type": "object" }, { - "name": "312", + "name": "315", "members": [ { "name": "file", - "type": "551" + "type": "556" } ], "meta-type": "object" }, { - "name": "313", + "name": "316", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "target", - "type": "551" + "type": "556" }, { "name": "bitmap", @@ -10331,7 +10341,7 @@ { "name": "on-cbw-error", "default": null, - "type": "554" + "type": "559" }, { "name": "cbw-timeout", @@ -10342,11 +10352,11 @@ "meta-type": "object" }, { - "name": "314", + "name": "317", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "bottom", @@ -10357,7 +10367,7 @@ "meta-type": "object" }, { - "name": "315", + "name": "318", "members": [ { "name": "filename", @@ -10371,12 +10381,12 @@ { "name": "locking", "default": null, - "type": "555" + "type": "560" }, { "name": "aio", "default": null, - "type": "556" + "type": "561" }, { "name": "aio-max-batch", @@ -10403,7 +10413,7 @@ ] }, { - "name": "316", + "name": "319", "members": [ { "name": "url", @@ -10443,7 +10453,7 @@ "meta-type": "object" }, { - "name": "317", + "name": "320", "members": [ { "name": "url", @@ -10488,7 +10498,7 @@ "meta-type": "object" }, { - "name": "318", + "name": "321", "members": [ { "name": "volume", @@ -10500,7 +10510,7 @@ }, { "name": "server", - "type": "[379]" + "type": "[382]" }, { "name": "debug", @@ -10516,7 +10526,7 @@ "meta-type": "object" }, { - "name": "319", + "name": "322", "members": [ { "name": "url", @@ -10566,7 +10576,7 @@ "meta-type": "object" }, { - "name": "320", + "name": "323", "members": [ { "name": "url", @@ -10621,7 +10631,7 @@ "meta-type": "object" }, { - "name": "321", + "name": "324", "members": [ { "name": "filename", @@ -10631,11 +10641,11 @@ "meta-type": "object" }, { - "name": "322", + "name": "325", "members": [ { "name": "transport", - "type": "557" + "type": "562" }, { "name": "portal", @@ -10668,7 +10678,7 @@ { "name": "header-digest", "default": null, - "type": "558" + "type": "563" }, { "name": "timeout", @@ -10679,11 +10689,11 @@ "meta-type": "object" }, { - "name": "323", + "name": "326", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "key-secret", @@ -10694,11 +10704,11 @@ "meta-type": "object" }, { - "name": "324", + "name": "327", "members": [ { "name": "server", - "type": "379" + "type": "382" }, { "name": "export", @@ -10737,11 +10747,11 @@ "meta-type": "object" }, { - "name": "325", + "name": "328", "members": [ { "name": "server", - "type": "559" + "type": "564" }, { "name": "path", @@ -10781,7 +10791,7 @@ "meta-type": "object" }, { - "name": "326", + "name": "329", "members": [ { "name": "size", @@ -10802,7 +10812,7 @@ "meta-type": "object" }, { - "name": "327", + "name": "330", "members": [ { "name": "device", @@ -10816,7 +10826,7 @@ "meta-type": "object" }, { - "name": "328", + "name": "331", "members": [ { "name": "path", @@ -10826,11 +10836,11 @@ "meta-type": "object" }, { - "name": "329", + "name": "332", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "prealloc-align", @@ -10846,16 +10856,16 @@ "meta-type": "object" }, { - "name": "330", + "name": "333", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "backing", "default": null, - "type": "560" + "type": "565" }, { "name": "lazy-refcounts", @@ -10885,7 +10895,7 @@ { "name": "overlap-check", "default": null, - "type": "561" + "type": "566" }, { "name": "cache-size", @@ -10915,53 +10925,53 @@ { "name": "encrypt", "default": null, - "type": "562" + "type": "567" }, { "name": "data-file", "default": null, - "type": "551" + "type": "556" } ], "meta-type": "object" }, { - "name": "331", + "name": "334", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "backing", "default": null, - "type": "560" + "type": "565" }, { "name": "encrypt", "default": null, - "type": "563" + "type": "568" } ], "meta-type": "object" }, { - "name": "332", + "name": "335", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "backing", "default": null, - "type": "560" + "type": "565" } ], "meta-type": "object" }, { - "name": "333", + "name": "336", "members": [ { "name": "blkverify", @@ -10970,7 +10980,7 @@ }, { "name": "children", - "type": "[551]" + "type": "[556]" }, { "name": "vote-threshold", @@ -10984,17 +10994,17 @@ { "name": "read-pattern", "default": null, - "type": "564" + "type": "569" } ], "meta-type": "object" }, { - "name": "334", + "name": "337", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "offset", @@ -11010,7 +11020,7 @@ "meta-type": "object" }, { - "name": "335", + "name": "338", "members": [ { "name": "pool", @@ -11038,7 +11048,7 @@ { "name": "encrypt", "default": null, - "type": "565" + "type": "570" }, { "name": "user", @@ -11048,7 +11058,7 @@ { "name": "auth-client-required", "default": null, - "type": "[566]" + "type": "[571]" }, { "name": "key-secret", @@ -11058,21 +11068,21 @@ { "name": "server", "default": null, - "type": "[567]" + "type": "[572]" } ], "meta-type": "object" }, { - "name": "336", + "name": "339", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "mode", - "type": "568" + "type": "573" }, { "name": "top-id", @@ -11083,11 +11093,11 @@ "meta-type": "object" }, { - "name": "337", + "name": "340", "members": [ { "name": "server", - "type": "569" + "type": "574" }, { "name": "path", @@ -11101,13 +11111,13 @@ { "name": "host-key-check", "default": null, - "type": "570" + "type": "575" } ], "meta-type": "object" }, { - "name": "338", + "name": "341", "members": [ { "name": "throttle-group", @@ -11115,13 +11125,13 @@ }, { "name": "file", - "type": "551" + "type": "556" } ], "meta-type": "object" }, { - "name": "339", + "name": "342", "members": [ { "name": "path", @@ -11131,7 +11141,7 @@ "meta-type": "object" }, { - "name": "340", + "name": "343", "members": [ { "name": "path", @@ -11141,7 +11151,7 @@ "meta-type": "object" }, { - "name": "341", + "name": "344", "members": [ { "name": "path", @@ -11154,7 +11164,7 @@ ] }, { - "name": "342", + "name": "345", "members": [ { "name": "dir", @@ -11189,64 +11199,64 @@ "meta-type": "array" }, { - "name": "343", + "name": "346", "tag": "driver", "variants": [ { "case": "file", - "type": "571" + "type": "576" }, { "case": "gluster", - "type": "572" + "type": "577" }, { "case": "luks", - "type": "573" + "type": "578" }, { "case": "nfs", - "type": "574" + "type": "579" }, { "case": "parallels", - "type": "575" + "type": "580" }, { "case": "qcow", - "type": "576" + "type": "581" }, { "case": "qcow2", - "type": "577" + "type": "582" }, { "case": "qed", - "type": "578" + "type": "583" }, { "case": "rbd", - "type": "579" + "type": "584" }, { "case": "ssh", - "type": "580" + "type": "585" }, { "case": "vdi", - "type": "581" + "type": "586" }, { "case": "vhdx", - "type": "582" + "type": "587" }, { "case": "vmdk", - "type": "583" + "type": "588" }, { "case": "vpc", - "type": "584" + "type": "589" }, { "case": "blkdebug", @@ -11384,22 +11394,22 @@ "members": [ { "name": "driver", - "type": "305" + "type": "308" } ], "meta-type": "object" }, { - "name": "344", + "name": "347", "tag": "driver", "variants": [ { "case": "luks", - "type": "585" + "type": "590" }, { "case": "qcow2", - "type": "586" + "type": "591" }, { "case": "blkdebug", @@ -11585,13 +11595,13 @@ "members": [ { "name": "driver", - "type": "305" + "type": "308" } ], "meta-type": "object" }, { - "name": "345", + "name": "348", "members": [ { "name": "read" @@ -11607,7 +11617,7 @@ ] }, { - "name": "346", + "name": "349", "members": [ { "name": "ignore" @@ -11627,7 +11637,7 @@ ] }, { - "name": "347", + "name": "350", "members": [ { "type": "str" @@ -11639,7 +11649,7 @@ "meta-type": "alternate" }, { - "name": "348", + "name": "351", "members": [ { "name": "read" @@ -11659,36 +11669,36 @@ ] }, { - "name": "349", + "name": "352", "tag": "type", "variants": [ { "case": "inet", - "type": "588" + "type": "593" }, { "case": "unix", - "type": "589" + "type": "594" }, { "case": "vsock", - "type": "590" + "type": "595" }, { "case": "fd", - "type": "591" + "type": "596" } ], "members": [ { "name": "type", - "type": "587" + "type": "592" } ], "meta-type": "object" }, { - "name": "350", + "name": "353", "members": [ { "name": "safe" @@ -11704,7 +11714,7 @@ ] }, { - "name": "351", + "name": "354", "members": [ { "name": "nbd" @@ -11728,7 +11738,7 @@ ] }, { - "name": "352", + "name": "355", "members": [ { "name": "name", @@ -11743,7 +11753,7 @@ { "name": "bitmaps", "default": null, - "type": "[304]" + "type": "[307]" }, { "name": "allocation-depth", @@ -11754,11 +11764,11 @@ "meta-type": "object" }, { - "name": "353", + "name": "356", "members": [ { "name": "addr", - "type": "379" + "type": "382" }, { "name": "logical-block-size", @@ -11774,7 +11784,7 @@ "meta-type": "object" }, { - "name": "354", + "name": "357", "members": [ { "name": "mountpoint", @@ -11788,13 +11798,13 @@ { "name": "allow-other", "default": null, - "type": "592" + "type": "597" } ], "meta-type": "object" }, { - "name": "355", + "name": "358", "members": [ { "name": "name", @@ -11824,7 +11834,7 @@ "meta-type": "object" }, { - "name": "356", + "name": "359", "members": [ { "name": "utf8" @@ -11840,108 +11850,108 @@ ] }, { - "name": "357", + "name": "360", "tag": "type", "variants": [ { "case": "file", - "type": "594" + "type": "599" }, { "case": "serial", - "type": "595" + "type": "600" }, { "case": "parallel", - "type": "595" + "type": "600" }, { "case": "pipe", - "type": "595" + "type": "600" }, { "case": "socket", - "type": "596" + "type": "601" }, { "case": "udp", - "type": "597" + "type": "602" }, { "case": "pty", - "type": "598" + "type": "603" }, { "case": "null", - "type": "598" + "type": "603" }, { "case": "mux", - "type": "599" + "type": "604" }, { "case": "msmouse", - "type": "598" + "type": "603" }, { "case": "wctablet", - "type": "598" + "type": "603" }, { "case": "braille", - "type": "598" + "type": "603" }, { "case": "testdev", - "type": "598" + "type": "603" }, { "case": "stdio", - "type": "600" + "type": "605" }, { "case": "console", - "type": "598" + "type": "603" }, { "case": "spicevmc", - "type": "601" + "type": "606" }, { "case": "spiceport", - "type": "602" + "type": "607" }, { "case": "qemu-vdagent", - "type": "603" + "type": "608" }, { "case": "dbus", - "type": "604" + "type": "609" }, { "case": "vc", - "type": "605" + "type": "610" }, { "case": "ringbuf", - "type": "606" + "type": "611" }, { "case": "memory", - "type": "606" + "type": "611" } ], "members": [ { "name": "type", - "type": "593" + "type": "598" } ], "meta-type": "object" }, { - "name": "358", + "name": "361", "members": [ { "name": "elf" @@ -11969,7 +11979,7 @@ ] }, { - "name": "359", + "name": "362", "members": [ { "name": "none" @@ -11993,12 +12003,12 @@ ] }, { - "name": "[358]", - "element-type": "358", + "name": "[361]", + "element-type": "361", "meta-type": "array" }, { - "name": "360", + "name": "363", "members": [ { "name": "none" @@ -12062,7 +12072,7 @@ ] }, { - "name": "361", + "name": "364", "members": [ { "name": "netdev", @@ -12093,7 +12103,7 @@ "meta-type": "object" }, { - "name": "362", + "name": "365", "members": [ { "name": "hostname", @@ -12153,7 +12163,7 @@ { "name": "dnssearch", "default": null, - "type": "[607]" + "type": "[612]" }, { "name": "domainname", @@ -12193,12 +12203,12 @@ { "name": "hostfwd", "default": null, - "type": "[607]" + "type": "[612]" }, { "name": "guestfwd", "default": null, - "type": "[607]" + "type": "[612]" }, { "name": "tftp-server-name", @@ -12209,7 +12219,7 @@ "meta-type": "object" }, { - "name": "363", + "name": "366", "members": [ { "name": "ifname", @@ -12290,7 +12300,7 @@ "meta-type": "object" }, { - "name": "364", + "name": "367", "members": [ { "name": "src", @@ -12363,7 +12373,7 @@ "meta-type": "object" }, { - "name": "365", + "name": "368", "members": [ { "name": "fd", @@ -12399,11 +12409,11 @@ "meta-type": "object" }, { - "name": "366", + "name": "369", "members": [ { "name": "addr", - "type": "379" + "type": "382" }, { "name": "server", @@ -12419,23 +12429,23 @@ "meta-type": "object" }, { - "name": "367", + "name": "370", "members": [ { "name": "local", "default": null, - "type": "379" + "type": "382" }, { "name": "remote", "default": null, - "type": "379" + "type": "382" } ], "meta-type": "object" }, { - "name": "368", + "name": "371", "members": [ { "name": "sock", @@ -12461,7 +12471,7 @@ "meta-type": "object" }, { - "name": "369", + "name": "372", "members": [ { "name": "br", @@ -12477,7 +12487,7 @@ "meta-type": "object" }, { - "name": "370", + "name": "373", "members": [ { "name": "hubid", @@ -12492,7 +12502,7 @@ "meta-type": "object" }, { - "name": "371", + "name": "374", "members": [ { "name": "ifname", @@ -12507,7 +12517,7 @@ "meta-type": "object" }, { - "name": "373", + "name": "376", "members": [ { "name": "chardev", @@ -12527,7 +12537,7 @@ "meta-type": "object" }, { - "name": "374", + "name": "377", "members": [ { "name": "vhostdev", @@ -12556,7 +12566,7 @@ "meta-type": "object" }, { - "name": "378", + "name": "381", "members": [ { "name": "normal" @@ -12581,36 +12591,36 @@ "meta-type": "array" }, { - "name": "379", + "name": "382", "tag": "type", "variants": [ { "case": "inet", - "type": "569" + "type": "574" }, { "case": "unix", - "type": "609" + "type": "614" }, { "case": "vsock", - "type": "610" + "type": "615" }, { "case": "fd", - "type": "607" + "type": "612" } ], "members": [ { "name": "type", - "type": "587" + "type": "592" } ], "meta-type": "object" }, { - "name": "380", + "name": "383", "members": [ { "name": "half" @@ -12626,7 +12636,7 @@ ] }, { - "name": "381", + "name": "384", "members": [ { "name": "off" @@ -12642,7 +12652,7 @@ ] }, { - "name": "382", + "name": "385", "members": [ { "name": "priority", @@ -12701,7 +12711,7 @@ "meta-type": "object" }, { - "name": "383", + "name": "386", "members": [ { "name": "in-pport", @@ -12742,7 +12752,7 @@ "meta-type": "object" }, { - "name": "384", + "name": "387", "members": [ { "name": "goto-tbl", @@ -12778,16 +12788,16 @@ "meta-type": "object" }, { - "name": "385", + "name": "388", "tag": "type", "variants": [ { "case": "passthrough", - "type": "611" + "type": "616" }, { "case": "emulator", - "type": "612" + "type": "617" } ], "members": [ @@ -12799,7 +12809,7 @@ "meta-type": "object" }, { - "name": "386", + "name": "389", "members": [ { "name": "vnc" @@ -12815,7 +12825,7 @@ ] }, { - "name": "387", + "name": "390", "members": [ { "name": "keep" @@ -12835,7 +12845,7 @@ ] }, { - "name": "388", + "name": "391", "members": [ { "name": "display", @@ -12846,7 +12856,7 @@ "meta-type": "object" }, { - "name": "389", + "name": "392", "members": [ { "name": "display", @@ -12857,7 +12867,7 @@ "meta-type": "object" }, { - "name": "390", + "name": "393", "members": [ { "name": "ppm" @@ -12873,7 +12883,7 @@ ] }, { - "name": "391", + "name": "394", "members": [ { "name": "client" @@ -12893,12 +12903,12 @@ ] }, { - "name": "[392]", - "element-type": "392", + "name": "[395]", + "element-type": "395", "meta-type": "array" }, { - "name": "392", + "name": "395", "members": [ { "name": "host", @@ -12910,7 +12920,7 @@ }, { "name": "family", - "type": "395" + "type": "398" }, { "name": "connection-id", @@ -12932,7 +12942,7 @@ "meta-type": "object" }, { - "name": "393", + "name": "396", "members": [ { "name": "host", @@ -12944,13 +12954,13 @@ }, { "name": "family", - "type": "395" + "type": "398" } ], "meta-type": "object" }, { - "name": "394", + "name": "397", "members": [ { "name": "host", @@ -12962,7 +12972,7 @@ }, { "name": "family", - "type": "395" + "type": "398" }, { "name": "auth", @@ -12973,7 +12983,7 @@ "meta-type": "object" }, { - "name": "395", + "name": "398", "members": [ { "name": "ipv4" @@ -13001,12 +13011,12 @@ ] }, { - "name": "[396]", - "element-type": "396", + "name": "[399]", + "element-type": "399", "meta-type": "array" }, { - "name": "396", + "name": "399", "members": [ { "name": "host", @@ -13018,7 +13028,7 @@ }, { "name": "family", - "type": "395" + "type": "398" }, { "name": "websocket", @@ -13038,12 +13048,12 @@ "meta-type": "object" }, { - "name": "[397]", - "element-type": "397", + "name": "[400]", + "element-type": "400", "meta-type": "array" }, { - "name": "397", + "name": "400", "members": [ { "name": "host", @@ -13055,7 +13065,7 @@ }, { "name": "family", - "type": "395" + "type": "398" }, { "name": "websocket", @@ -13063,18 +13073,18 @@ }, { "name": "auth", - "type": "398" + "type": "401" }, { "name": "vencrypt", "default": null, - "type": "399" + "type": "402" } ], "meta-type": "object" }, { - "name": "398", + "name": "401", "members": [ { "name": "none" @@ -13118,7 +13128,7 @@ ] }, { - "name": "399", + "name": "402", "members": [ { "name": "plain" @@ -13162,7 +13172,7 @@ ] }, { - "name": "400", + "name": "403", "members": [ { "name": "host", @@ -13174,7 +13184,7 @@ }, { "name": "family", - "type": "395" + "type": "398" }, { "name": "websocket", @@ -13189,7 +13199,7 @@ "meta-type": "object" }, { - "name": "401", + "name": "404", "members": [ { "name": "host", @@ -13201,7 +13211,7 @@ }, { "name": "family", - "type": "395" + "type": "398" }, { "name": "websocket", @@ -13211,71 +13221,71 @@ "meta-type": "object" }, { - "name": "[402]", - "element-type": "402", + "name": "[405]", + "element-type": "405", "meta-type": "array" }, { - "name": "402", + "name": "405", "tag": "type", "variants": [ { "case": "number", - "type": "614" + "type": "619" }, { "case": "qcode", - "type": "615" + "type": "620" } ], "members": [ { "name": "type", - "type": "613" + "type": "618" } ], "meta-type": "object" }, { - "name": "[403]", - "element-type": "403", + "name": "[406]", + "element-type": "406", "meta-type": "array" }, { - "name": "403", + "name": "406", "tag": "type", "variants": [ { "case": "key", - "type": "617" + "type": "622" }, { "case": "btn", - "type": "618" + "type": "623" }, { "case": "rel", - "type": "619" + "type": "624" }, { "case": "abs", - "type": "619" + "type": "624" }, { "case": "mtt", - "type": "620" + "type": "625" } ], "members": [ { "name": "type", - "type": "616" + "type": "621" } ], "meta-type": "object" }, { - "name": "404", + "name": "407", "members": [ { "name": "default" @@ -13311,7 +13321,7 @@ ] }, { - "name": "405", + "name": "408", "members": [ { "name": "off" @@ -13335,7 +13345,7 @@ ] }, { - "name": "406", + "name": "409", "members": [ { "name": "grab-on-hover", @@ -13361,7 +13371,7 @@ "meta-type": "object" }, { - "name": "407", + "name": "410", "members": [ { "name": "left-command-key", @@ -13382,7 +13392,7 @@ "meta-type": "object" }, { - "name": "408", + "name": "411", "members": [ { "name": "charset", @@ -13393,7 +13403,7 @@ "meta-type": "object" }, { - "name": "409", + "name": "412", "members": [ { "name": "rendernode", @@ -13404,7 +13414,7 @@ "meta-type": "object" }, { - "name": "410", + "name": "413", "members": [ { "name": "rendernode", @@ -13430,18 +13440,18 @@ "meta-type": "object" }, { - "name": "411", + "name": "414", "members": [ { "name": "grab-mod", "default": null, - "type": "621" + "type": "626" } ], "meta-type": "object" }, { - "name": "412", + "name": "415", "members": [ { "name": "vnc" @@ -13453,7 +13463,7 @@ ] }, { - "name": "413", + "name": "416", "members": [ { "name": "tls-certs", @@ -13464,7 +13474,7 @@ "meta-type": "object" }, { - "name": "414", + "name": "417", "members": [ { "name": "vnc" @@ -13476,18 +13486,18 @@ ] }, { - "name": "415", + "name": "418", "members": [ { "name": "addresses", "default": null, - "type": "[379]" + "type": "[382]" } ], "meta-type": "object" }, { - "name": "416", + "name": "419", "members": [ { "name": "none" @@ -13551,7 +13561,7 @@ ] }, { - "name": "417", + "name": "420", "members": [ { "name": "transferred", @@ -13632,7 +13642,7 @@ "meta-type": "object" }, { - "name": "418", + "name": "421", "members": [ { "name": "transferred", @@ -13642,7 +13652,7 @@ "meta-type": "object" }, { - "name": "419", + "name": "422", "members": [ { "name": "cache-size", @@ -13676,7 +13686,7 @@ "meta-type": "object" }, { - "name": "420", + "name": "423", "members": [ { "name": "pages", @@ -13702,12 +13712,12 @@ "meta-type": "object" }, { - "name": "[379]", - "element-type": "379", + "name": "[382]", + "element-type": "382", "meta-type": "array" }, { - "name": "421", + "name": "424", "members": [ { "name": "xbzrle" @@ -13813,7 +13823,7 @@ ] }, { - "name": "422", + "name": "425", "members": [ { "name": "none" @@ -13833,12 +13843,12 @@ ] }, { - "name": "[423]", - "element-type": "423", + "name": "[426]", + "element-type": "426", "meta-type": "array" }, { - "name": "423", + "name": "426", "members": [ { "name": "node-name", @@ -13850,13 +13860,13 @@ }, { "name": "bitmaps", - "type": "[622]" + "type": "[627]" } ], "meta-type": "object" }, { - "name": "424", + "name": "427", "members": [ { "name": "none" @@ -13876,7 +13886,7 @@ ] }, { - "name": "425", + "name": "428", "members": [ { "name": "none" @@ -13900,7 +13910,7 @@ ] }, { - "name": "426", + "name": "429", "members": [ { "name": "second" @@ -13916,7 +13926,7 @@ ] }, { - "name": "427", + "name": "430", "members": [ { "name": "page-sampling" @@ -13936,7 +13946,7 @@ ] }, { - "name": "428", + "name": "431", "members": [ { "name": "unstarted" @@ -13956,12 +13966,12 @@ ] }, { - "name": "[429]", - "element-type": "429", + "name": "[432]", + "element-type": "432", "meta-type": "array" }, { - "name": "429", + "name": "432", "members": [ { "name": "id", @@ -13975,84 +13985,84 @@ "meta-type": "object" }, { - "name": "[430]", - "element-type": "430", + "name": "[433]", + "element-type": "433", "meta-type": "array" }, { - "name": "430", + "name": "433", "tag": "type", "variants": [ { "case": "abort", - "type": "624" + "type": "629" }, { "case": "block-dirty-bitmap-add", - "type": "625" + "type": "630" }, { "case": "block-dirty-bitmap-remove", - "type": "626" + "type": "631" }, { "case": "block-dirty-bitmap-clear", - "type": "626" + "type": "631" }, { "case": "block-dirty-bitmap-enable", - "type": "626" + "type": "631" }, { "case": "block-dirty-bitmap-disable", - "type": "626" + "type": "631" }, { "case": "block-dirty-bitmap-merge", - "type": "627" + "type": "632" }, { "case": "blockdev-backup", - "type": "628" + "type": "633" }, { "case": "blockdev-snapshot", - "type": "629" + "type": "634" }, { "case": "blockdev-snapshot-internal-sync", - "type": "630" + "type": "635" }, { "case": "blockdev-snapshot-sync", - "type": "631" + "type": "636" }, { "case": "drive-backup", - "type": "632" + "type": "637" } ], "members": [ { "name": "type", - "type": "623" + "type": "628" } ], "meta-type": "object" }, { - "name": "431", + "name": "434", "members": [ { "name": "completion-mode", "default": null, - "type": "633" + "type": "638" } ], "meta-type": "object" }, { - "name": "432", + "name": "435", "members": [ { "name": "unavailable" @@ -14072,12 +14082,12 @@ ] }, { - "name": "[433]", - "element-type": "433", + "name": "[436]", + "element-type": "436", "meta-type": "array" }, { - "name": "433", + "name": "436", "members": [ { "name": "oob" @@ -14089,7 +14099,7 @@ ] }, { - "name": "434", + "name": "437", "members": [ { "name": "major", @@ -14107,7 +14117,7 @@ "meta-type": "object" }, { - "name": "435", + "name": "438", "members": [ { "name": "builtin" @@ -14143,21 +14153,21 @@ ] }, { - "name": "436", + "name": "439", "members": [ { "name": "json-type", - "type": "634" + "type": "639" } ], "meta-type": "object" }, { - "name": "437", + "name": "440", "members": [ { "name": "members", - "type": "[635]" + "type": "[640]" }, { "name": "values", @@ -14170,7 +14180,7 @@ "meta-type": "object" }, { - "name": "438", + "name": "441", "members": [ { "name": "element-type", @@ -14180,11 +14190,11 @@ "meta-type": "object" }, { - "name": "439", + "name": "442", "members": [ { "name": "members", - "type": "[636]" + "type": "[641]" }, { "name": "tag", @@ -14194,23 +14204,23 @@ { "name": "variants", "default": null, - "type": "[637]" + "type": "[642]" } ], "meta-type": "object" }, { - "name": "440", + "name": "443", "members": [ { "name": "members", - "type": "[638]" + "type": "[643]" } ], "meta-type": "object" }, { - "name": "441", + "name": "444", "members": [ { "name": "arg-type", @@ -14229,7 +14239,7 @@ "meta-type": "object" }, { - "name": "442", + "name": "445", "members": [ { "name": "arg-type", @@ -14239,7 +14249,7 @@ "meta-type": "object" }, { - "name": "443", + "name": "446", "members": [ { "name": "authz-list" @@ -14429,23 +14439,23 @@ ] }, { - "name": "444", + "name": "447", "members": [ { "name": "policy", "default": null, - "type": "639" + "type": "644" }, { "name": "rules", "default": null, - "type": "[640]" + "type": "[645]" } ], "meta-type": "object" }, { - "name": "445", + "name": "448", "members": [ { "name": "filename", @@ -14460,7 +14470,7 @@ "meta-type": "object" }, { - "name": "446", + "name": "449", "members": [ { "name": "service", @@ -14470,7 +14480,7 @@ "meta-type": "object" }, { - "name": "447", + "name": "450", "members": [ { "name": "identity", @@ -14480,7 +14490,7 @@ "meta-type": "object" }, { - "name": "448", + "name": "451", "members": [ { "name": "if", @@ -14494,7 +14504,7 @@ "meta-type": "object" }, { - "name": "449", + "name": "452", "members": [ { "name": "primary_in", @@ -14541,7 +14551,7 @@ "meta-type": "object" }, { - "name": "450", + "name": "453", "members": [ { "name": "queues", @@ -14562,7 +14572,7 @@ "meta-type": "object" }, { - "name": "451", + "name": "454", "members": [ { "name": "queues", @@ -14587,7 +14597,7 @@ "meta-type": "object" }, { - "name": "452", + "name": "455", "members": [ { "name": "addr", @@ -14602,7 +14612,7 @@ "meta-type": "object" }, { - "name": "453", + "name": "456", "members": [ { "name": "netdev", @@ -14611,7 +14621,7 @@ { "name": "queue", "default": null, - "type": "641" + "type": "646" }, { "name": "status", @@ -14626,7 +14636,7 @@ { "name": "insert", "default": null, - "type": "642" + "type": "647" }, { "name": "interval", @@ -14636,7 +14646,7 @@ "meta-type": "object" }, { - "name": "454", + "name": "457", "members": [ { "name": "netdev", @@ -14645,7 +14655,7 @@ { "name": "queue", "default": null, - "type": "641" + "type": "646" }, { "name": "status", @@ -14660,7 +14670,7 @@ { "name": "insert", "default": null, - "type": "642" + "type": "647" }, { "name": "file", @@ -14675,7 +14685,7 @@ "meta-type": "object" }, { - "name": "455", + "name": "458", "members": [ { "name": "netdev", @@ -14684,7 +14694,7 @@ { "name": "queue", "default": null, - "type": "641" + "type": "646" }, { "name": "status", @@ -14699,7 +14709,7 @@ { "name": "insert", "default": null, - "type": "642" + "type": "647" }, { "name": "outdev", @@ -14714,7 +14724,7 @@ "meta-type": "object" }, { - "name": "456", + "name": "459", "members": [ { "name": "netdev", @@ -14723,7 +14733,7 @@ { "name": "queue", "default": null, - "type": "641" + "type": "646" }, { "name": "status", @@ -14738,7 +14748,7 @@ { "name": "insert", "default": null, - "type": "642" + "type": "647" }, { "name": "indev", @@ -14759,7 +14769,7 @@ "meta-type": "object" }, { - "name": "457", + "name": "460", "members": [ { "name": "netdev", @@ -14768,7 +14778,7 @@ { "name": "queue", "default": null, - "type": "641" + "type": "646" }, { "name": "status", @@ -14783,13 +14793,13 @@ { "name": "insert", "default": null, - "type": "642" + "type": "647" } ], "meta-type": "object" }, { - "name": "458", + "name": "461", "members": [ { "name": "netdev", @@ -14798,7 +14808,7 @@ { "name": "queue", "default": null, - "type": "641" + "type": "646" }, { "name": "status", @@ -14813,7 +14823,7 @@ { "name": "insert", "default": null, - "type": "642" + "type": "647" }, { "name": "vnet_hdr_support", @@ -14824,7 +14834,7 @@ "meta-type": "object" }, { - "name": "459", + "name": "462", "members": [ { "name": "name", @@ -14864,7 +14874,7 @@ "meta-type": "object" }, { - "name": "460", + "name": "463", "members": [ { "name": "evdev", @@ -14883,13 +14893,13 @@ { "name": "grab-toggle", "default": null, - "type": "643" + "type": "648" } ], "meta-type": "object" }, { - "name": "461", + "name": "464", "members": [ { "name": "aio-max-batch", @@ -14925,7 +14935,7 @@ "meta-type": "object" }, { - "name": "462", + "name": "465", "members": [ { "name": "aio-max-batch", @@ -14946,7 +14956,7 @@ "meta-type": "object" }, { - "name": "463", + "name": "466", "members": [ { "name": "dump", @@ -14966,7 +14976,7 @@ { "name": "policy", "default": null, - "type": "486" + "type": "489" }, { "name": "prealloc", @@ -15006,7 +15016,7 @@ "meta-type": "object" }, { - "name": "464", + "name": "467", "members": [ { "name": "dump", @@ -15026,7 +15036,7 @@ { "name": "policy", "default": null, - "type": "486" + "type": "489" }, { "name": "prealloc", @@ -15094,13 +15104,13 @@ { "name": "rom", "default": null, - "type": "555" + "type": "560" } ], "meta-type": "object" }, { - "name": "465", + "name": "468", "members": [ { "name": "dump", @@ -15120,7 +15130,7 @@ { "name": "policy", "default": null, - "type": "486" + "type": "489" }, { "name": "prealloc", @@ -15175,7 +15185,7 @@ "meta-type": "object" }, { - "name": "466", + "name": "469", "members": [ { "name": "dump", @@ -15195,7 +15205,7 @@ { "name": "policy", "default": null, - "type": "486" + "type": "489" }, { "name": "prealloc", @@ -15235,7 +15245,7 @@ "meta-type": "object" }, { - "name": "467", + "name": "470", "members": [ { "name": "path", @@ -15245,7 +15255,7 @@ "meta-type": "object" }, { - "name": "468", + "name": "471", "members": [ { "name": "chardev", @@ -15260,7 +15270,7 @@ "meta-type": "object" }, { - "name": "469", + "name": "472", "members": [ { "name": "opened", @@ -15274,7 +15284,7 @@ "meta-type": "object" }, { - "name": "470", + "name": "473", "members": [ { "name": "opened", @@ -15292,7 +15302,7 @@ "meta-type": "object" }, { - "name": "471", + "name": "474", "members": [ { "name": "opened", @@ -15311,7 +15321,7 @@ "meta-type": "object" }, { - "name": "472", + "name": "475", "members": [ { "name": "loaded", @@ -15324,7 +15334,7 @@ { "name": "format", "default": null, - "type": "644" + "type": "649" }, { "name": "keyid", @@ -15350,7 +15360,7 @@ "meta-type": "object" }, { - "name": "473", + "name": "476", "members": [ { "name": "loaded", @@ -15363,7 +15373,7 @@ { "name": "format", "default": null, - "type": "644" + "type": "649" }, { "name": "keyid", @@ -15383,7 +15393,7 @@ "meta-type": "object" }, { - "name": "474", + "name": "477", "members": [ { "name": "sev-device", @@ -15428,7 +15438,7 @@ "meta-type": "object" }, { - "name": "475", + "name": "478", "members": [ { "name": "cpu-affinity", @@ -15444,12 +15454,12 @@ "meta-type": "object" }, { - "name": "476", + "name": "479", "members": [ { "name": "limits", "default": null, - "type": "645" + "type": "650" }, { "name": "x-iops-total", @@ -15607,7 +15617,7 @@ "meta-type": "object" }, { - "name": "477", + "name": "480", "members": [ { "name": "verify-peer", @@ -15622,7 +15632,7 @@ { "name": "endpoint", "default": null, - "type": "646" + "type": "651" }, { "name": "priority", @@ -15641,7 +15651,7 @@ "meta-type": "object" }, { - "name": "478", + "name": "481", "members": [ { "name": "verify-peer", @@ -15656,7 +15666,7 @@ { "name": "endpoint", "default": null, - "type": "646" + "type": "651" }, { "name": "priority", @@ -15680,7 +15690,7 @@ "meta-type": "object" }, { - "name": "479", + "name": "482", "members": [ { "name": "verify-peer", @@ -15695,7 +15705,7 @@ { "name": "endpoint", "default": null, - "type": "646" + "type": "651" }, { "name": "priority", @@ -15724,7 +15734,7 @@ "meta-type": "object" }, { - "name": "480", + "name": "483", "members": [ { "name": "verify-peer", @@ -15739,7 +15749,7 @@ { "name": "endpoint", "default": null, - "type": "646" + "type": "651" }, { "name": "priority", @@ -15750,7 +15760,7 @@ "meta-type": "object" }, { - "name": "481", + "name": "484", "members": [ { "name": "fd", @@ -15764,11 +15774,11 @@ "meta-type": "object" }, { - "name": "482", + "name": "485", "members": [ { "name": "socket", - "type": "379" + "type": "382" }, { "name": "device", @@ -15778,13 +15788,23 @@ "meta-type": "object" }, { - "name": "483", + "name": "486", "members": [ { "name": "node-id", "default": null, "type": "int" }, + { + "name": "drawer-id", + "default": null, + "type": "int" + }, + { + "name": "book-id", + "default": null, + "type": "int" + }, { "name": "socket-id", "default": null, @@ -15814,7 +15834,7 @@ "meta-type": "object" }, { - "name": "484", + "name": "487", "members": [ { "name": "aarch64" @@ -15946,17 +15966,27 @@ ] }, { - "name": "485", + "name": "488", "members": [ { "name": "cpu-state", - "type": "647" + "type": "652" + }, + { + "name": "dedicated", + "default": null, + "type": "bool" + }, + { + "name": "entitlement", + "default": null, + "type": "504" } ], "meta-type": "object" }, { - "name": "486", + "name": "489", "members": [ { "name": "default" @@ -15980,7 +16010,7 @@ ] }, { - "name": "487", + "name": "490", "members": [ { "name": "node" @@ -16008,7 +16038,7 @@ ] }, { - "name": "488", + "name": "491", "members": [ { "name": "nodeid", @@ -16039,7 +16069,7 @@ "meta-type": "object" }, { - "name": "489", + "name": "492", "members": [ { "name": "src", @@ -16057,13 +16087,23 @@ "meta-type": "object" }, { - "name": "490", + "name": "493", "members": [ { "name": "node-id", "default": null, "type": "int" }, + { + "name": "drawer-id", + "default": null, + "type": "int" + }, + { + "name": "book-id", + "default": null, + "type": "int" + }, { "name": "socket-id", "default": null, @@ -16093,7 +16133,7 @@ "meta-type": "object" }, { - "name": "491", + "name": "494", "members": [ { "name": "initiator", @@ -16105,11 +16145,11 @@ }, { "name": "hierarchy", - "type": "648" + "type": "653" }, { "name": "data-type", - "type": "649" + "type": "654" }, { "name": "latency", @@ -16125,7 +16165,7 @@ "meta-type": "object" }, { - "name": "492", + "name": "495", "members": [ { "name": "node-id", @@ -16141,11 +16181,11 @@ }, { "name": "associativity", - "type": "650" + "type": "655" }, { "name": "policy", - "type": "651" + "type": "656" }, { "name": "line", @@ -16155,7 +16195,7 @@ "meta-type": "object" }, { - "name": "493", + "name": "496", "members": [ { "name": "dimm" @@ -16183,47 +16223,47 @@ ] }, { - "name": "494", + "name": "497", "members": [ { "name": "data", - "type": "652" + "type": "657" } ], "meta-type": "object" }, { - "name": "495", + "name": "498", "members": [ { "name": "data", - "type": "653" + "type": "658" } ], "meta-type": "object" }, { - "name": "496", + "name": "499", "members": [ { "name": "data", - "type": "654" + "type": "659" } ], "meta-type": "object" }, { - "name": "497", + "name": "500", "members": [ { "name": "data", - "type": "655" + "type": "660" } ], "meta-type": "object" }, { - "name": "498", + "name": "501", "members": [ { "name": "name", @@ -16238,7 +16278,7 @@ "meta-type": "object" }, { - "name": "499", + "name": "502", "members": [ { "name": "incompatible" @@ -16262,7 +16302,7 @@ ] }, { - "name": "500", + "name": "503", "members": [ { "name": "static" @@ -16278,7 +16318,31 @@ ] }, { - "name": "501", + "name": "504", + "members": [ + { + "name": "auto" + }, + { + "name": "low" + }, + { + "name": "medium" + }, + { + "name": "high" + } + ], + "meta-type": "enum", + "values": [ + "auto", + "low", + "medium", + "high" + ] + }, + { + "name": "506", "members": [ { "name": "none" @@ -16298,7 +16362,7 @@ ] }, { - "name": "502", + "name": "507", "members": [ { "name": "block-node" @@ -16318,7 +16382,7 @@ ] }, { - "name": "503", + "name": "508", "members": [ { "name": "node-name", @@ -16328,7 +16392,7 @@ "meta-type": "object" }, { - "name": "504", + "name": "509", "members": [ { "name": "id", @@ -16338,12 +16402,12 @@ "meta-type": "object" }, { - "name": "[505]", - "element-type": "505", + "name": "[510]", + "element-type": "510", "meta-type": "array" }, { - "name": "505", + "name": "510", "members": [ { "name": "fd", @@ -16358,12 +16422,12 @@ "meta-type": "object" }, { - "name": "[506]", - "element-type": "506", + "name": "[511]", + "element-type": "511", "meta-type": "array" }, { - "name": "506", + "name": "511", "members": [ { "name": "name", @@ -16371,7 +16435,7 @@ }, { "name": "type", - "type": "656" + "type": "661" }, { "name": "help", @@ -16387,7 +16451,7 @@ "meta-type": "object" }, { - "name": "507", + "name": "512", "members": [ { "name": "uninit" @@ -16419,12 +16483,12 @@ ] }, { - "name": "[508]", - "element-type": "508", + "name": "[513]", + "element-type": "513", "meta-type": "array" }, { - "name": "508", + "name": "513", "members": [ { "name": "node", @@ -16438,7 +16502,7 @@ "meta-type": "object" }, { - "name": "509", + "name": "514", "members": [ { "name": "closed" @@ -16470,7 +16534,7 @@ ] }, { - "name": "510", + "name": "515", "members": [ { "name": "none" @@ -16510,33 +16574,33 @@ ] }, { - "name": "511", + "name": "516", "members": [ { "name": "in", "default": null, - "type": "657" + "type": "662" }, { "name": "out", "default": null, - "type": "657" + "type": "662" } ], "meta-type": "object" }, { - "name": "512", + "name": "517", "members": [ { "name": "in", "default": null, - "type": "658" + "type": "663" }, { "name": "out", "default": null, - "type": "658" + "type": "663" }, { "name": "threshold", @@ -16547,33 +16611,33 @@ "meta-type": "object" }, { - "name": "513", + "name": "518", "members": [ { "name": "in", "default": null, - "type": "659" + "type": "664" }, { "name": "out", "default": null, - "type": "659" + "type": "664" } ], "meta-type": "object" }, { - "name": "514", + "name": "519", "members": [ { "name": "in", "default": null, - "type": "657" + "type": "662" }, { "name": "out", "default": null, - "type": "657" + "type": "662" }, { "name": "latency", @@ -16584,33 +16648,33 @@ "meta-type": "object" }, { - "name": "515", + "name": "520", "members": [ { "name": "in", "default": null, - "type": "660" + "type": "665" }, { "name": "out", "default": null, - "type": "660" + "type": "665" } ], "meta-type": "object" }, { - "name": "516", + "name": "521", "members": [ { "name": "in", "default": null, - "type": "661" + "type": "666" }, { "name": "out", "default": null, - "type": "661" + "type": "666" }, { "name": "try-mmap", @@ -16631,17 +16695,17 @@ "meta-type": "object" }, { - "name": "517", + "name": "522", "members": [ { "name": "in", "default": null, - "type": "662" + "type": "667" }, { "name": "out", "default": null, - "type": "662" + "type": "667" }, { "name": "server", @@ -16652,49 +16716,49 @@ "meta-type": "object" }, { - "name": "518", + "name": "523", "members": [ { "name": "in", "default": null, - "type": "663" + "type": "668" }, { "name": "out", "default": null, - "type": "663" + "type": "668" } ], "meta-type": "object" }, { - "name": "519", + "name": "524", "members": [ { "name": "in", "default": null, - "type": "664" + "type": "669" }, { "name": "out", "default": null, - "type": "664" + "type": "669" } ], "meta-type": "object" }, { - "name": "520", + "name": "525", "members": [ { "name": "in", "default": null, - "type": "657" + "type": "662" }, { "name": "out", "default": null, - "type": "657" + "type": "662" }, { "name": "dev", @@ -16710,17 +16774,17 @@ "meta-type": "object" }, { - "name": "521", + "name": "526", "members": [ { "name": "in", "default": null, - "type": "657" + "type": "662" }, { "name": "out", "default": null, - "type": "657" + "type": "662" }, { "name": "path", @@ -16731,7 +16795,7 @@ "meta-type": "object" }, { - "name": "522", + "name": "527", "members": [ { "name": "DIMM" @@ -16747,12 +16811,12 @@ ] }, { - "name": "[523]", - "element-type": "523", + "name": "[528]", + "element-type": "528", "meta-type": "array" }, { - "name": "523", + "name": "528", "members": [ { "name": "bus", @@ -16768,11 +16832,11 @@ }, { "name": "class_info", - "type": "665" + "type": "670" }, { "name": "id", - "type": "666" + "type": "671" }, { "name": "irq", @@ -16790,17 +16854,17 @@ { "name": "pci_bridge", "default": null, - "type": "667" + "type": "672" }, { "name": "regions", - "type": "[668]" + "type": "[673]" } ], "meta-type": "object" }, { - "name": "524", + "name": "529", "members": [ { "name": "vm" @@ -16820,16 +16884,16 @@ ] }, { - "name": "[525]", - "element-type": "525", + "name": "[530]", + "element-type": "530", "meta-type": "array" }, { - "name": "525", + "name": "530", "members": [ { "name": "provider", - "type": "527" + "type": "532" }, { "name": "names", @@ -16840,7 +16904,7 @@ "meta-type": "object" }, { - "name": "526", + "name": "531", "members": [ { "name": "vcpus", @@ -16851,7 +16915,7 @@ "meta-type": "object" }, { - "name": "527", + "name": "532", "members": [ { "name": "kvm" @@ -16867,12 +16931,12 @@ ] }, { - "name": "[528]", - "element-type": "528", + "name": "[533]", + "element-type": "533", "meta-type": "array" }, { - "name": "528", + "name": "533", "members": [ { "name": "name", @@ -16880,18 +16944,18 @@ }, { "name": "value", - "type": "669" + "type": "674" } ], "meta-type": "object" }, { - "name": "[529]", - "element-type": "529", + "name": "[534]", + "element-type": "534", "meta-type": "array" }, { - "name": "529", + "name": "534", "members": [ { "name": "name", @@ -16899,12 +16963,12 @@ }, { "name": "type", - "type": "670" + "type": "675" }, { "name": "unit", "default": null, - "type": "671" + "type": "676" }, { "name": "base", @@ -16924,7 +16988,7 @@ "meta-type": "object" }, { - "name": "530", + "name": "535", "members": [ { "name": "transports", @@ -16944,7 +17008,7 @@ "meta-type": "object" }, { - "name": "531", + "name": "536", "members": [ { "name": "statuses", @@ -16959,7 +17023,7 @@ "meta-type": "object" }, { - "name": "532", + "name": "537", "members": [ { "name": "n-mem-sections", @@ -16979,19 +17043,19 @@ }, { "name": "features", - "type": "530" + "type": "535" }, { "name": "acked-features", - "type": "530" + "type": "535" }, { "name": "backend-features", - "type": "530" + "type": "535" }, { "name": "protocol-features", - "type": "672" + "type": "677" }, { "name": "max-queues", @@ -17013,12 +17077,12 @@ "meta-type": "object" }, { - "name": "[533]", - "element-type": "533", + "name": "[538]", + "element-type": "538", "meta-type": "array" }, { - "name": "533", + "name": "538", "members": [ { "name": "addr", @@ -17036,7 +17100,7 @@ "meta-type": "object" }, { - "name": "534", + "name": "539", "members": [ { "name": "flags", @@ -17054,7 +17118,7 @@ "meta-type": "object" }, { - "name": "535", + "name": "540", "members": [ { "name": "flags", @@ -17068,12 +17132,12 @@ "meta-type": "object" }, { - "name": "[536]", - "element-type": "536", + "name": "[541]", + "element-type": "541", "meta-type": "array" }, { - "name": "536", + "name": "541", "members": [ { "name": "cipher" @@ -17101,12 +17165,12 @@ ] }, { - "name": "[537]", - "element-type": "537", + "name": "[542]", + "element-type": "542", "meta-type": "array" }, { - "name": "537", + "name": "542", "members": [ { "name": "queue", @@ -17114,13 +17178,13 @@ }, { "name": "type", - "type": "673" + "type": "678" } ], "meta-type": "object" }, { - "name": "538", + "name": "543", "members": [ { "name": "informational" @@ -17144,16 +17208,16 @@ ] }, { - "name": "[539]", - "element-type": "539", + "name": "[544]", + "element-type": "544", "meta-type": "array" }, { - "name": "539", + "name": "544", "members": [ { "name": "type", - "type": "674" + "type": "679" }, { "name": "header", @@ -17163,7 +17227,7 @@ "meta-type": "object" }, { - "name": "540", + "name": "545", "members": [ { "name": "cache-data-ecc" @@ -17199,7 +17263,7 @@ ] }, { - "name": "541", + "name": "546", "members": [ { "name": "hyper-v" @@ -17215,7 +17279,7 @@ ] }, { - "name": "542", + "name": "547", "members": [ { "name": "arg1", @@ -17241,7 +17305,7 @@ "meta-type": "object" }, { - "name": "543", + "name": "548", "members": [ { "name": "core", @@ -17257,18 +17321,18 @@ }, { "name": "reason", - "type": "675" + "type": "680" } ], "meta-type": "object" }, { - "name": "[544]", - "element-type": "544", + "name": "[549]", + "element-type": "549", "meta-type": "array" }, { - "name": "544", + "name": "549", "members": [ { "name": "interval_length", @@ -17338,7 +17402,7 @@ "meta-type": "object" }, { - "name": "545", + "name": "550", "members": [ { "name": "boundaries", @@ -17352,7 +17416,7 @@ "meta-type": "object" }, { - "name": "546", + "name": "551", "members": [ { "name": "discard-nb-ok", @@ -17370,7 +17434,7 @@ "meta-type": "object" }, { - "name": "547", + "name": "552", "members": [ { "name": "completion-errors", @@ -17393,40 +17457,40 @@ "meta-type": "array" }, { - "name": "548", + "name": "553", "tag": "type", "variants": [ { "case": "qcow2", - "type": "677" + "type": "682" }, { "case": "vmdk", - "type": "678" + "type": "683" }, { "case": "luks", - "type": "679" + "type": "684" }, { "case": "rbd", - "type": "680" + "type": "685" }, { "case": "file", - "type": "681" + "type": "686" } ], "members": [ { "name": "type", - "type": "676" + "type": "681" } ], "meta-type": "object" }, { - "name": "549", + "name": "554", "members": [ { "name": "block-backend" @@ -17446,12 +17510,12 @@ ] }, { - "name": "[550]", - "element-type": "550", + "name": "[555]", + "element-type": "555", "meta-type": "array" }, { - "name": "550", + "name": "555", "members": [ { "name": "consistent-read" @@ -17475,7 +17539,7 @@ ] }, { - "name": "551", + "name": "556", "members": [ { "type": "57" @@ -17487,16 +17551,16 @@ "meta-type": "alternate" }, { - "name": "[552]", - "element-type": "552", + "name": "[557]", + "element-type": "557", "meta-type": "array" }, { - "name": "552", + "name": "557", "members": [ { "name": "event", - "type": "682" + "type": "687" }, { "name": "state", @@ -17506,7 +17570,7 @@ { "name": "iotype", "default": null, - "type": "683" + "type": "688" }, { "name": "errno", @@ -17532,16 +17596,16 @@ "meta-type": "object" }, { - "name": "[553]", - "element-type": "553", + "name": "[558]", + "element-type": "558", "meta-type": "array" }, { - "name": "553", + "name": "558", "members": [ { "name": "event", - "type": "682" + "type": "687" }, { "name": "state", @@ -17556,7 +17620,7 @@ "meta-type": "object" }, { - "name": "554", + "name": "559", "members": [ { "name": "break-guest-write" @@ -17572,7 +17636,7 @@ ] }, { - "name": "555", + "name": "560", "members": [ { "name": "auto" @@ -17592,7 +17656,7 @@ ] }, { - "name": "556", + "name": "561", "members": [ { "name": "threads" @@ -17612,7 +17676,7 @@ ] }, { - "name": "557", + "name": "562", "members": [ { "name": "tcp" @@ -17628,7 +17692,7 @@ ] }, { - "name": "558", + "name": "563", "members": [ { "name": "crc32c" @@ -17652,11 +17716,11 @@ ] }, { - "name": "559", + "name": "564", "members": [ { "name": "type", - "type": "684" + "type": "689" }, { "name": "host", @@ -17666,7 +17730,7 @@ "meta-type": "object" }, { - "name": "560", + "name": "565", "members": [ { "type": "57" @@ -17681,62 +17745,62 @@ "meta-type": "alternate" }, { - "name": "561", + "name": "566", "members": [ { - "type": "685" + "type": "690" }, { - "type": "686" + "type": "691" } ], "meta-type": "alternate" }, { - "name": "562", + "name": "567", "tag": "format", "variants": [ { "case": "aes", - "type": "688" + "type": "693" }, { "case": "luks", - "type": "689" + "type": "694" } ], "members": [ { "name": "format", - "type": "687" + "type": "692" } ], "meta-type": "object" }, { - "name": "563", + "name": "568", "tag": "format", "variants": [ { "case": "aes", - "type": "688" + "type": "693" } ], "members": [ { "name": "format", - "type": "690" + "type": "695" } ], "meta-type": "object" }, { - "name": "[551]", - "element-type": "551", + "name": "[556]", + "element-type": "556", "meta-type": "array" }, { - "name": "564", + "name": "569", "members": [ { "name": "quorum" @@ -17752,42 +17816,42 @@ ] }, { - "name": "565", + "name": "570", "tag": "format", "variants": [ { "case": "luks", - "type": "692" + "type": "697" }, { "case": "luks2", - "type": "693" + "type": "698" }, { "case": "luks-any", - "type": "694" + "type": "699" } ], "members": [ { "name": "format", - "type": "691" + "type": "696" }, { "name": "parent", "default": null, - "type": "565" + "type": "570" } ], "meta-type": "object" }, { - "name": "[566]", - "element-type": "566", + "name": "[571]", + "element-type": "571", "meta-type": "array" }, { - "name": "566", + "name": "571", "members": [ { "name": "cephx" @@ -17803,12 +17867,12 @@ ] }, { - "name": "[567]", - "element-type": "567", + "name": "[572]", + "element-type": "572", "meta-type": "array" }, { - "name": "567", + "name": "572", "members": [ { "name": "host", @@ -17822,7 +17886,7 @@ "meta-type": "object" }, { - "name": "568", + "name": "573", "members": [ { "name": "primary" @@ -17838,7 +17902,7 @@ ] }, { - "name": "569", + "name": "574", "members": [ { "name": "host", @@ -17882,12 +17946,12 @@ "meta-type": "object" }, { - "name": "570", + "name": "575", "tag": "mode", "variants": [ { "case": "hash", - "type": "696" + "type": "701" }, { "case": "none", @@ -17901,13 +17965,13 @@ "members": [ { "name": "mode", - "type": "695" + "type": "700" } ], "meta-type": "object" }, { - "name": "571", + "name": "576", "members": [ { "name": "filename", @@ -17920,7 +17984,7 @@ { "name": "preallocation", "default": null, - "type": "697" + "type": "702" }, { "name": "nocow", @@ -17936,11 +18000,11 @@ "meta-type": "object" }, { - "name": "572", + "name": "577", "members": [ { "name": "location", - "type": "318" + "type": "321" }, { "name": "size", @@ -17949,13 +18013,13 @@ { "name": "preallocation", "default": null, - "type": "697" + "type": "702" } ], "meta-type": "object" }, { - "name": "573", + "name": "578", "members": [ { "name": "key-secret", @@ -17965,27 +18029,27 @@ { "name": "cipher-alg", "default": null, - "type": "698" + "type": "703" }, { "name": "cipher-mode", "default": null, - "type": "699" + "type": "704" }, { "name": "ivgen-alg", "default": null, - "type": "700" + "type": "705" }, { "name": "ivgen-hash-alg", "default": null, - "type": "701" + "type": "706" }, { "name": "hash-alg", "default": null, - "type": "701" + "type": "706" }, { "name": "iter-time", @@ -17994,7 +18058,7 @@ }, { "name": "file", - "type": "551" + "type": "556" }, { "name": "size", @@ -18003,17 +18067,17 @@ { "name": "preallocation", "default": null, - "type": "697" + "type": "702" } ], "meta-type": "object" }, { - "name": "574", + "name": "579", "members": [ { "name": "location", - "type": "325" + "type": "328" }, { "name": "size", @@ -18023,11 +18087,11 @@ "meta-type": "object" }, { - "name": "575", + "name": "580", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "size", @@ -18042,11 +18106,11 @@ "meta-type": "object" }, { - "name": "576", + "name": "581", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "size", @@ -18060,22 +18124,22 @@ { "name": "encrypt", "default": null, - "type": "702" + "type": "707" } ], "meta-type": "object" }, { - "name": "577", + "name": "582", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "data-file", "default": null, - "type": "551" + "type": "556" }, { "name": "data-file-raw", @@ -18094,7 +18158,7 @@ { "name": "version", "default": null, - "type": "703" + "type": "708" }, { "name": "backing-file", @@ -18104,12 +18168,12 @@ { "name": "backing-fmt", "default": null, - "type": "305" + "type": "308" }, { "name": "encrypt", "default": null, - "type": "702" + "type": "707" }, { "name": "cluster-size", @@ -18119,7 +18183,7 @@ { "name": "preallocation", "default": null, - "type": "697" + "type": "702" }, { "name": "lazy-refcounts", @@ -18134,17 +18198,17 @@ { "name": "compression-type", "default": null, - "type": "704" + "type": "709" } ], "meta-type": "object" }, { - "name": "578", + "name": "583", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "size", @@ -18158,7 +18222,7 @@ { "name": "backing-fmt", "default": null, - "type": "305" + "type": "308" }, { "name": "cluster-size", @@ -18174,11 +18238,11 @@ "meta-type": "object" }, { - "name": "579", + "name": "584", "members": [ { "name": "location", - "type": "335" + "type": "338" }, { "name": "size", @@ -18192,17 +18256,17 @@ { "name": "encrypt", "default": null, - "type": "705" + "type": "710" } ], "meta-type": "object" }, { - "name": "580", + "name": "585", "members": [ { "name": "location", - "type": "337" + "type": "340" }, { "name": "size", @@ -18212,11 +18276,11 @@ "meta-type": "object" }, { - "name": "581", + "name": "586", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "size", @@ -18225,17 +18289,17 @@ { "name": "preallocation", "default": null, - "type": "697" + "type": "702" } ], "meta-type": "object" }, { - "name": "582", + "name": "587", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "size", @@ -18254,7 +18318,7 @@ { "name": "subformat", "default": null, - "type": "706" + "type": "711" }, { "name": "block-state-zero", @@ -18265,11 +18329,11 @@ "meta-type": "object" }, { - "name": "583", + "name": "588", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "size", @@ -18278,12 +18342,12 @@ { "name": "extents", "default": null, - "type": "[551]" + "type": "[556]" }, { "name": "subformat", "default": null, - "type": "707" + "type": "712" }, { "name": "backing-file", @@ -18293,7 +18357,7 @@ { "name": "adapter-type", "default": null, - "type": "708" + "type": "713" }, { "name": "hwversion", @@ -18314,11 +18378,11 @@ "meta-type": "object" }, { - "name": "584", + "name": "589", "members": [ { "name": "file", - "type": "551" + "type": "556" }, { "name": "size", @@ -18327,7 +18391,7 @@ { "name": "subformat", "default": null, - "type": "709" + "type": "714" }, { "name": "force-size", @@ -18338,11 +18402,11 @@ "meta-type": "object" }, { - "name": "585", + "name": "590", "members": [ { "name": "state", - "type": "710" + "type": "715" }, { "name": "new-secret", @@ -18373,12 +18437,12 @@ "meta-type": "object" }, { - "name": "586", + "name": "591", "members": [ { "name": "encrypt", "default": null, - "type": "711" + "type": "716" } ], "meta-type": "object" @@ -18389,7 +18453,7 @@ "meta-type": "builtin" }, { - "name": "587", + "name": "592", "members": [ { "name": "inet" @@ -18413,47 +18477,47 @@ ] }, { - "name": "588", + "name": "593", "members": [ { "name": "data", - "type": "569" + "type": "574" } ], "meta-type": "object" }, { - "name": "589", + "name": "594", "members": [ { "name": "data", - "type": "609" + "type": "614" } ], "meta-type": "object" }, { - "name": "590", + "name": "595", "members": [ { "name": "data", - "type": "610" + "type": "615" } ], "meta-type": "object" }, { - "name": "591", + "name": "596", "members": [ { "name": "data", - "type": "607" + "type": "612" } ], "meta-type": "object" }, { - "name": "592", + "name": "597", "members": [ { "name": "off" @@ -18473,7 +18537,7 @@ ] }, { - "name": "593", + "name": "598", "members": [ { "name": "file" @@ -18569,142 +18633,142 @@ ] }, { - "name": "594", + "name": "599", "members": [ { "name": "data", - "type": "712" + "type": "717" } ], "meta-type": "object" }, { - "name": "595", + "name": "600", "members": [ { "name": "data", - "type": "713" + "type": "718" } ], "meta-type": "object" }, { - "name": "596", + "name": "601", "members": [ { "name": "data", - "type": "714" + "type": "719" } ], "meta-type": "object" }, { - "name": "597", + "name": "602", "members": [ { "name": "data", - "type": "715" + "type": "720" } ], "meta-type": "object" }, { - "name": "598", + "name": "603", "members": [ { "name": "data", - "type": "716" + "type": "721" } ], "meta-type": "object" }, { - "name": "599", + "name": "604", "members": [ { "name": "data", - "type": "717" + "type": "722" } ], "meta-type": "object" }, { - "name": "600", + "name": "605", "members": [ { "name": "data", - "type": "718" + "type": "723" } ], "meta-type": "object" }, { - "name": "601", + "name": "606", "members": [ { "name": "data", - "type": "719" + "type": "724" } ], "meta-type": "object" }, { - "name": "602", + "name": "607", "members": [ { "name": "data", - "type": "720" + "type": "725" } ], "meta-type": "object" }, { - "name": "603", + "name": "608", "members": [ { "name": "data", - "type": "721" + "type": "726" } ], "meta-type": "object" }, { - "name": "604", + "name": "609", "members": [ { "name": "data", - "type": "722" + "type": "727" } ], "meta-type": "object" }, { - "name": "605", + "name": "610", "members": [ { "name": "data", - "type": "723" + "type": "728" } ], "meta-type": "object" }, { - "name": "606", + "name": "611", "members": [ { "name": "data", - "type": "724" + "type": "729" } ], "meta-type": "object" }, { - "name": "[607]", - "element-type": "607", + "name": "[612]", + "element-type": "612", "meta-type": "array" }, { - "name": "607", + "name": "612", "members": [ { "name": "str", @@ -18714,7 +18778,7 @@ "meta-type": "object" }, { - "name": "609", + "name": "614", "members": [ { "name": "path", @@ -18734,7 +18798,7 @@ "meta-type": "object" }, { - "name": "610", + "name": "615", "members": [ { "name": "cid", @@ -18748,27 +18812,27 @@ "meta-type": "object" }, { - "name": "611", + "name": "616", "members": [ { "name": "data", - "type": "725" + "type": "730" } ], "meta-type": "object" }, { - "name": "612", + "name": "617", "members": [ { "name": "data", - "type": "726" + "type": "731" } ], "meta-type": "object" }, { - "name": "613", + "name": "618", "members": [ { "name": "number" @@ -18784,7 +18848,7 @@ ] }, { - "name": "614", + "name": "619", "members": [ { "name": "data", @@ -18794,17 +18858,17 @@ "meta-type": "object" }, { - "name": "615", + "name": "620", "members": [ { "name": "data", - "type": "727" + "type": "732" } ], "meta-type": "object" }, { - "name": "616", + "name": "621", "members": [ { "name": "key" @@ -18832,47 +18896,47 @@ ] }, { - "name": "617", + "name": "622", "members": [ { "name": "data", - "type": "728" + "type": "733" } ], "meta-type": "object" }, { - "name": "618", + "name": "623", "members": [ { "name": "data", - "type": "729" + "type": "734" } ], "meta-type": "object" }, { - "name": "619", + "name": "624", "members": [ { "name": "data", - "type": "730" + "type": "735" } ], "meta-type": "object" }, { - "name": "620", + "name": "625", "members": [ { "name": "data", - "type": "731" + "type": "736" } ], "meta-type": "object" }, { - "name": "621", + "name": "626", "members": [ { "name": "lctrl-lalt" @@ -18897,12 +18961,12 @@ "meta-type": "builtin" }, { - "name": "[622]", - "element-type": "622", + "name": "[627]", + "element-type": "627", "meta-type": "array" }, { - "name": "622", + "name": "627", "members": [ { "name": "name", @@ -18915,13 +18979,13 @@ { "name": "transform", "default": null, - "type": "732" + "type": "737" } ], "meta-type": "object" }, { - "name": "623", + "name": "628", "members": [ { "name": "abort" @@ -18980,17 +19044,17 @@ ] }, { - "name": "624", + "name": "629", "members": [ { "name": "data", - "type": "733" + "type": "738" } ], "meta-type": "object" }, { - "name": "625", + "name": "630", "members": [ { "name": "data", @@ -19000,7 +19064,7 @@ "meta-type": "object" }, { - "name": "626", + "name": "631", "members": [ { "name": "data", @@ -19010,7 +19074,7 @@ "meta-type": "object" }, { - "name": "627", + "name": "632", "members": [ { "name": "data", @@ -19020,7 +19084,7 @@ "meta-type": "object" }, { - "name": "628", + "name": "633", "members": [ { "name": "data", @@ -19030,7 +19094,7 @@ "meta-type": "object" }, { - "name": "629", + "name": "634", "members": [ { "name": "data", @@ -19040,7 +19104,7 @@ "meta-type": "object" }, { - "name": "630", + "name": "635", "members": [ { "name": "data", @@ -19050,7 +19114,7 @@ "meta-type": "object" }, { - "name": "631", + "name": "636", "members": [ { "name": "data", @@ -19060,7 +19124,7 @@ "meta-type": "object" }, { - "name": "632", + "name": "637", "members": [ { "name": "data", @@ -19070,7 +19134,7 @@ "meta-type": "object" }, { - "name": "633", + "name": "638", "members": [ { "name": "individual" @@ -19086,7 +19150,7 @@ ] }, { - "name": "634", + "name": "639", "members": [ { "name": "string" @@ -19126,12 +19190,12 @@ ] }, { - "name": "[635]", - "element-type": "635", + "name": "[640]", + "element-type": "640", "meta-type": "array" }, { - "name": "635", + "name": "640", "members": [ { "name": "name", @@ -19146,12 +19210,12 @@ "meta-type": "object" }, { - "name": "[636]", - "element-type": "636", + "name": "[641]", + "element-type": "641", "meta-type": "array" }, { - "name": "636", + "name": "641", "members": [ { "name": "name", @@ -19175,12 +19239,12 @@ "meta-type": "object" }, { - "name": "[637]", - "element-type": "637", + "name": "[642]", + "element-type": "642", "meta-type": "array" }, { - "name": "637", + "name": "642", "members": [ { "name": "case", @@ -19194,12 +19258,12 @@ "meta-type": "object" }, { - "name": "[638]", - "element-type": "638", + "name": "[643]", + "element-type": "643", "meta-type": "array" }, { - "name": "638", + "name": "643", "members": [ { "name": "type", @@ -19209,7 +19273,7 @@ "meta-type": "object" }, { - "name": "639", + "name": "644", "members": [ { "name": "deny" @@ -19225,12 +19289,12 @@ ] }, { - "name": "[640]", - "element-type": "640", + "name": "[645]", + "element-type": "645", "meta-type": "array" }, { - "name": "640", + "name": "645", "members": [ { "name": "match", @@ -19238,18 +19302,18 @@ }, { "name": "policy", - "type": "639" + "type": "644" }, { "name": "format", "default": null, - "type": "734" + "type": "739" } ], "meta-type": "object" }, { - "name": "641", + "name": "646", "members": [ { "name": "all" @@ -19269,7 +19333,7 @@ ] }, { - "name": "642", + "name": "647", "members": [ { "name": "before" @@ -19285,7 +19349,7 @@ ] }, { - "name": "643", + "name": "648", "members": [ { "name": "ctrl-ctrl" @@ -19317,7 +19381,7 @@ ] }, { - "name": "644", + "name": "649", "members": [ { "name": "raw" @@ -19333,7 +19397,7 @@ ] }, { - "name": "645", + "name": "650", "members": [ { "name": "iops-total", @@ -19434,7 +19498,7 @@ "meta-type": "object" }, { - "name": "646", + "name": "651", "members": [ { "name": "client" @@ -19450,7 +19514,7 @@ ] }, { - "name": "647", + "name": "652", "members": [ { "name": "uninitialized" @@ -19478,7 +19542,7 @@ ] }, { - "name": "648", + "name": "653", "members": [ { "name": "memory" @@ -19502,7 +19566,7 @@ ] }, { - "name": "649", + "name": "654", "members": [ { "name": "access-latency" @@ -19534,7 +19598,7 @@ ] }, { - "name": "650", + "name": "655", "members": [ { "name": "none" @@ -19554,7 +19618,7 @@ ] }, { - "name": "651", + "name": "656", "members": [ { "name": "none" @@ -19574,7 +19638,7 @@ ] }, { - "name": "652", + "name": "657", "members": [ { "name": "id", @@ -19613,7 +19677,7 @@ "meta-type": "object" }, { - "name": "653", + "name": "658", "members": [ { "name": "id", @@ -19636,7 +19700,7 @@ "meta-type": "object" }, { - "name": "654", + "name": "659", "members": [ { "name": "id", @@ -19675,7 +19739,7 @@ "meta-type": "object" }, { - "name": "655", + "name": "660", "members": [ { "name": "id", @@ -19702,7 +19766,7 @@ "meta-type": "object" }, { - "name": "656", + "name": "661", "members": [ { "name": "string" @@ -19726,7 +19790,7 @@ ] }, { - "name": "657", + "name": "662", "members": [ { "name": "mixing-engine", @@ -19756,7 +19820,7 @@ { "name": "format", "default": null, - "type": "735" + "type": "740" }, { "name": "buffer-length", @@ -19767,7 +19831,7 @@ "meta-type": "object" }, { - "name": "658", + "name": "663", "members": [ { "name": "mixing-engine", @@ -19797,7 +19861,7 @@ { "name": "format", "default": null, - "type": "735" + "type": "740" }, { "name": "buffer-length", @@ -19823,7 +19887,7 @@ "meta-type": "object" }, { - "name": "659", + "name": "664", "members": [ { "name": "mixing-engine", @@ -19853,7 +19917,7 @@ { "name": "format", "default": null, - "type": "735" + "type": "740" }, { "name": "buffer-length", @@ -19869,7 +19933,7 @@ "meta-type": "object" }, { - "name": "660", + "name": "665", "members": [ { "name": "mixing-engine", @@ -19899,7 +19963,7 @@ { "name": "format", "default": null, - "type": "735" + "type": "740" }, { "name": "buffer-length", @@ -19935,7 +19999,7 @@ "meta-type": "object" }, { - "name": "661", + "name": "666", "members": [ { "name": "mixing-engine", @@ -19965,7 +20029,7 @@ { "name": "format", "default": null, - "type": "735" + "type": "740" }, { "name": "buffer-length", @@ -19991,7 +20055,7 @@ "meta-type": "object" }, { - "name": "662", + "name": "667", "members": [ { "name": "mixing-engine", @@ -20021,7 +20085,7 @@ { "name": "format", "default": null, - "type": "735" + "type": "740" }, { "name": "buffer-length", @@ -20047,7 +20111,7 @@ "meta-type": "object" }, { - "name": "663", + "name": "668", "members": [ { "name": "mixing-engine", @@ -20077,7 +20141,7 @@ { "name": "format", "default": null, - "type": "735" + "type": "740" }, { "name": "buffer-length", @@ -20103,7 +20167,7 @@ "meta-type": "object" }, { - "name": "664", + "name": "669", "members": [ { "name": "mixing-engine", @@ -20133,7 +20197,7 @@ { "name": "format", "default": null, - "type": "735" + "type": "740" }, { "name": "buffer-length", @@ -20149,7 +20213,7 @@ "meta-type": "object" }, { - "name": "665", + "name": "670", "members": [ { "name": "desc", @@ -20164,7 +20228,7 @@ "meta-type": "object" }, { - "name": "666", + "name": "671", "members": [ { "name": "device", @@ -20188,27 +20252,27 @@ "meta-type": "object" }, { - "name": "667", + "name": "672", "members": [ { "name": "bus", - "type": "736" + "type": "741" }, { "name": "devices", "default": null, - "type": "[523]" + "type": "[528]" } ], "meta-type": "object" }, { - "name": "[668]", - "element-type": "668", + "name": "[673]", + "element-type": "673", "meta-type": "array" }, { - "name": "668", + "name": "673", "members": [ { "name": "bar", @@ -20240,7 +20304,7 @@ "meta-type": "object" }, { - "name": "669", + "name": "674", "members": [ { "type": "int" @@ -20255,7 +20319,7 @@ "meta-type": "alternate" }, { - "name": "670", + "name": "675", "members": [ { "name": "cumulative" @@ -20283,7 +20347,7 @@ ] }, { - "name": "671", + "name": "676", "members": [ { "name": "bytes" @@ -20307,7 +20371,7 @@ ] }, { - "name": "672", + "name": "677", "members": [ { "name": "protocols", @@ -20322,7 +20386,7 @@ "meta-type": "object" }, { - "name": "673", + "name": "678", "members": [ { "name": "builtin" @@ -20342,7 +20406,7 @@ ] }, { - "name": "674", + "name": "679", "members": [ { "name": "cache-data-parity" @@ -20410,7 +20474,7 @@ ] }, { - "name": "675", + "name": "680", "members": [ { "name": "unknown" @@ -20438,7 +20502,7 @@ ] }, { - "name": "676", + "name": "681", "members": [ { "name": "qcow2" @@ -20466,57 +20530,57 @@ ] }, { - "name": "677", + "name": "682", "members": [ { "name": "data", - "type": "737" + "type": "742" } ], "meta-type": "object" }, { - "name": "678", + "name": "683", "members": [ { "name": "data", - "type": "738" + "type": "743" } ], "meta-type": "object" }, { - "name": "679", + "name": "684", "members": [ { "name": "data", - "type": "739" + "type": "744" } ], "meta-type": "object" }, { - "name": "680", + "name": "685", "members": [ { "name": "data", - "type": "740" + "type": "745" } ], "meta-type": "object" }, { - "name": "681", + "name": "686", "members": [ { "name": "data", - "type": "741" + "type": "746" } ], "meta-type": "object" }, { - "name": "682", + "name": "687", "members": [ { "name": "l1_update" @@ -20716,7 +20780,7 @@ ] }, { - "name": "683", + "name": "688", "members": [ { "name": "read" @@ -20748,7 +20812,7 @@ ] }, { - "name": "684", + "name": "689", "members": [ { "name": "inet" @@ -20760,12 +20824,12 @@ ] }, { - "name": "685", + "name": "690", "members": [ { "name": "template", "default": null, - "type": "686" + "type": "691" }, { "name": "main-header", @@ -20816,7 +20880,7 @@ "meta-type": "object" }, { - "name": "686", + "name": "691", "members": [ { "name": "none" @@ -20840,7 +20904,7 @@ ] }, { - "name": "687", + "name": "692", "members": [ { "name": "aes" @@ -20856,7 +20920,7 @@ ] }, { - "name": "688", + "name": "693", "members": [ { "name": "key-secret", @@ -20867,7 +20931,7 @@ "meta-type": "object" }, { - "name": "689", + "name": "694", "members": [ { "name": "key-secret", @@ -20878,7 +20942,7 @@ "meta-type": "object" }, { - "name": "690", + "name": "695", "members": [ { "name": "aes" @@ -20890,7 +20954,7 @@ ] }, { - "name": "691", + "name": "696", "members": [ { "name": "luks" @@ -20910,7 +20974,7 @@ ] }, { - "name": "692", + "name": "697", "members": [ { "name": "key-secret", @@ -20920,7 +20984,7 @@ "meta-type": "object" }, { - "name": "693", + "name": "698", "members": [ { "name": "key-secret", @@ -20930,7 +20994,7 @@ "meta-type": "object" }, { - "name": "694", + "name": "699", "members": [ { "name": "key-secret", @@ -20940,7 +21004,7 @@ "meta-type": "object" }, { - "name": "695", + "name": "700", "members": [ { "name": "none" @@ -20960,11 +21024,11 @@ ] }, { - "name": "696", + "name": "701", "members": [ { "name": "type", - "type": "742" + "type": "747" }, { "name": "hash", @@ -20974,7 +21038,7 @@ "meta-type": "object" }, { - "name": "697", + "name": "702", "members": [ { "name": "off" @@ -20998,7 +21062,7 @@ ] }, { - "name": "698", + "name": "703", "members": [ { "name": "aes-128" @@ -21054,7 +21118,7 @@ ] }, { - "name": "699", + "name": "704", "members": [ { "name": "ecb" @@ -21078,7 +21142,7 @@ ] }, { - "name": "700", + "name": "705", "members": [ { "name": "plain" @@ -21098,7 +21162,7 @@ ] }, { - "name": "701", + "name": "706", "members": [ { "name": "md5" @@ -21134,28 +21198,28 @@ ] }, { - "name": "702", + "name": "707", "tag": "format", "variants": [ { "case": "qcow", - "type": "688" + "type": "693" }, { "case": "luks", - "type": "744" + "type": "749" } ], "members": [ { "name": "format", - "type": "743" + "type": "748" } ], "meta-type": "object" }, { - "name": "703", + "name": "708", "members": [ { "name": "v2" @@ -21171,7 +21235,7 @@ ] }, { - "name": "704", + "name": "709", "members": [ { "name": "zlib" @@ -21187,16 +21251,16 @@ ] }, { - "name": "705", + "name": "710", "tag": "format", "variants": [ { "case": "luks", - "type": "745" + "type": "750" }, { "case": "luks2", - "type": "746" + "type": "751" }, { "case": "luks-any", @@ -21206,13 +21270,13 @@ "members": [ { "name": "format", - "type": "691" + "type": "696" } ], "meta-type": "object" }, { - "name": "706", + "name": "711", "members": [ { "name": "dynamic" @@ -21228,7 +21292,7 @@ ] }, { - "name": "707", + "name": "712", "members": [ { "name": "monolithicSparse" @@ -21256,7 +21320,7 @@ ] }, { - "name": "708", + "name": "713", "members": [ { "name": "ide" @@ -21280,7 +21344,7 @@ ] }, { - "name": "709", + "name": "714", "members": [ { "name": "dynamic" @@ -21296,7 +21360,7 @@ ] }, { - "name": "710", + "name": "715", "members": [ { "name": "active" @@ -21312,12 +21376,12 @@ ] }, { - "name": "711", + "name": "716", "tag": "format", "variants": [ { "case": "luks", - "type": "747" + "type": "752" }, { "case": "qcow", @@ -21327,13 +21391,13 @@ "members": [ { "name": "format", - "type": "743" + "type": "748" } ], "meta-type": "object" }, { - "name": "712", + "name": "717", "members": [ { "name": "logfile", @@ -21363,7 +21427,7 @@ "meta-type": "object" }, { - "name": "713", + "name": "718", "members": [ { "name": "logfile", @@ -21383,7 +21447,7 @@ "meta-type": "object" }, { - "name": "714", + "name": "719", "members": [ { "name": "logfile", @@ -21397,7 +21461,7 @@ }, { "name": "addr", - "type": "349" + "type": "352" }, { "name": "tls-creds", @@ -21448,7 +21512,7 @@ "meta-type": "object" }, { - "name": "715", + "name": "720", "members": [ { "name": "logfile", @@ -21462,18 +21526,18 @@ }, { "name": "remote", - "type": "349" + "type": "352" }, { "name": "local", "default": null, - "type": "349" + "type": "352" } ], "meta-type": "object" }, { - "name": "716", + "name": "721", "members": [ { "name": "logfile", @@ -21489,7 +21553,7 @@ "meta-type": "object" }, { - "name": "717", + "name": "722", "members": [ { "name": "logfile", @@ -21509,7 +21573,7 @@ "meta-type": "object" }, { - "name": "718", + "name": "723", "members": [ { "name": "logfile", @@ -21530,7 +21594,7 @@ "meta-type": "object" }, { - "name": "719", + "name": "724", "members": [ { "name": "logfile", @@ -21550,7 +21614,7 @@ "meta-type": "object" }, { - "name": "720", + "name": "725", "members": [ { "name": "logfile", @@ -21570,7 +21634,7 @@ "meta-type": "object" }, { - "name": "721", + "name": "726", "members": [ { "name": "logfile", @@ -21596,7 +21660,7 @@ "meta-type": "object" }, { - "name": "722", + "name": "727", "members": [ { "name": "logfile", @@ -21616,7 +21680,7 @@ "meta-type": "object" }, { - "name": "723", + "name": "728", "members": [ { "name": "logfile", @@ -21652,7 +21716,7 @@ "meta-type": "object" }, { - "name": "724", + "name": "729", "members": [ { "name": "logfile", @@ -21673,7 +21737,7 @@ "meta-type": "object" }, { - "name": "725", + "name": "730", "members": [ { "name": "path", @@ -21689,7 +21753,7 @@ "meta-type": "object" }, { - "name": "726", + "name": "731", "members": [ { "name": "chardev", @@ -21699,7 +21763,7 @@ "meta-type": "object" }, { - "name": "727", + "name": "732", "members": [ { "name": "unmapped" @@ -22355,11 +22419,11 @@ ] }, { - "name": "728", + "name": "733", "members": [ { "name": "key", - "type": "402" + "type": "405" }, { "name": "down", @@ -22369,11 +22433,11 @@ "meta-type": "object" }, { - "name": "729", + "name": "734", "members": [ { "name": "button", - "type": "748" + "type": "753" }, { "name": "down", @@ -22383,11 +22447,11 @@ "meta-type": "object" }, { - "name": "730", + "name": "735", "members": [ { "name": "axis", - "type": "749" + "type": "754" }, { "name": "value", @@ -22397,11 +22461,11 @@ "meta-type": "object" }, { - "name": "731", + "name": "736", "members": [ { "name": "type", - "type": "750" + "type": "755" }, { "name": "slot", @@ -22413,7 +22477,7 @@ }, { "name": "axis", - "type": "749" + "type": "754" }, { "name": "value", @@ -22423,7 +22487,7 @@ "meta-type": "object" }, { - "name": "732", + "name": "737", "members": [ { "name": "persistent", @@ -22434,13 +22498,13 @@ "meta-type": "object" }, { - "name": "733", + "name": "738", "members": [ ], "meta-type": "object" }, { - "name": "734", + "name": "739", "members": [ { "name": "exact" @@ -22456,7 +22520,7 @@ ] }, { - "name": "735", + "name": "740", "members": [ { "name": "u8" @@ -22492,7 +22556,7 @@ ] }, { - "name": "736", + "name": "741", "members": [ { "name": "number", @@ -22508,21 +22572,21 @@ }, { "name": "io_range", - "type": "751" + "type": "756" }, { "name": "memory_range", - "type": "751" + "type": "756" }, { "name": "prefetchable_range", - "type": "751" + "type": "756" } ], "meta-type": "object" }, { - "name": "737", + "name": "742", "members": [ { "name": "compat", @@ -22560,22 +22624,22 @@ { "name": "encrypt", "default": null, - "type": "752" + "type": "757" }, { "name": "bitmaps", "default": null, - "type": "[753]" + "type": "[758]" }, { "name": "compression-type", - "type": "704" + "type": "709" } ], "meta-type": "object" }, { - "name": "738", + "name": "743", "members": [ { "name": "create-type", @@ -22591,34 +22655,34 @@ }, { "name": "extents", - "type": "[754]" + "type": "[759]" } ], "meta-type": "object" }, { - "name": "739", + "name": "744", "members": [ { "name": "cipher-alg", - "type": "698" + "type": "703" }, { "name": "cipher-mode", - "type": "699" + "type": "704" }, { "name": "ivgen-alg", - "type": "700" + "type": "705" }, { "name": "ivgen-hash-alg", "default": null, - "type": "701" + "type": "706" }, { "name": "hash-alg", - "type": "701" + "type": "706" }, { "name": "payload-offset", @@ -22634,24 +22698,24 @@ }, { "name": "slots", - "type": "[755]" + "type": "[760]" } ], "meta-type": "object" }, { - "name": "740", + "name": "745", "members": [ { "name": "encryption-format", "default": null, - "type": "691" + "type": "696" } ], "meta-type": "object" }, { - "name": "741", + "name": "746", "members": [ { "name": "extent-size-hint", @@ -22662,7 +22726,7 @@ "meta-type": "object" }, { - "name": "742", + "name": "747", "members": [ { "name": "md5" @@ -22682,7 +22746,7 @@ ] }, { - "name": "743", + "name": "748", "members": [ { "name": "qcow" @@ -22698,7 +22762,7 @@ ] }, { - "name": "744", + "name": "749", "members": [ { "name": "key-secret", @@ -22708,27 +22772,27 @@ { "name": "cipher-alg", "default": null, - "type": "698" + "type": "703" }, { "name": "cipher-mode", "default": null, - "type": "699" + "type": "704" }, { "name": "ivgen-alg", "default": null, - "type": "700" + "type": "705" }, { "name": "ivgen-hash-alg", "default": null, - "type": "701" + "type": "706" }, { "name": "hash-alg", "default": null, - "type": "701" + "type": "706" }, { "name": "iter-time", @@ -22739,7 +22803,7 @@ "meta-type": "object" }, { - "name": "745", + "name": "750", "members": [ { "name": "key-secret", @@ -22748,13 +22812,13 @@ { "name": "cipher-alg", "default": null, - "type": "698" + "type": "703" } ], "meta-type": "object" }, { - "name": "746", + "name": "751", "members": [ { "name": "key-secret", @@ -22763,17 +22827,17 @@ { "name": "cipher-alg", "default": null, - "type": "698" + "type": "703" } ], "meta-type": "object" }, { - "name": "747", + "name": "752", "members": [ { "name": "state", - "type": "710" + "type": "715" }, { "name": "new-secret", @@ -22804,7 +22868,7 @@ "meta-type": "object" }, { - "name": "748", + "name": "753", "members": [ { "name": "left" @@ -22852,7 +22916,7 @@ ] }, { - "name": "749", + "name": "754", "members": [ { "name": "x" @@ -22868,7 +22932,7 @@ ] }, { - "name": "750", + "name": "755", "members": [ { "name": "begin" @@ -22896,7 +22960,7 @@ ] }, { - "name": "751", + "name": "756", "members": [ { "name": "base", @@ -22910,12 +22974,12 @@ "meta-type": "object" }, { - "name": "752", + "name": "757", "tag": "format", "variants": [ { "case": "luks", - "type": "739" + "type": "744" }, { "case": "aes", @@ -22925,18 +22989,18 @@ "members": [ { "name": "format", - "type": "687" + "type": "692" } ], "meta-type": "object" }, { - "name": "[753]", - "element-type": "753", + "name": "[758]", + "element-type": "758", "meta-type": "array" }, { - "name": "753", + "name": "758", "members": [ { "name": "name", @@ -22948,18 +23012,18 @@ }, { "name": "flags", - "type": "[756]" + "type": "[761]" } ], "meta-type": "object" }, { - "name": "[754]", - "element-type": "754", + "name": "[759]", + "element-type": "759", "meta-type": "array" }, { - "name": "754", + "name": "759", "members": [ { "name": "filename", @@ -22987,12 +23051,12 @@ "meta-type": "object" }, { - "name": "[755]", - "element-type": "755", + "name": "[760]", + "element-type": "760", "meta-type": "array" }, { - "name": "755", + "name": "760", "members": [ { "name": "active", @@ -23016,12 +23080,12 @@ "meta-type": "object" }, { - "name": "[756]", - "element-type": "756", + "name": "[761]", + "element-type": "761", "meta-type": "array" }, { - "name": "756", + "name": "761", "members": [ { "name": "in-use" @@ -23616,6 +23680,10 @@ "name": "pc-i440fx-2.10-machine", "parent": "generic-pc-machine" }, + { + "name": "thread-context", + "parent": "object" + }, { "name": "i82557c", "parent": "pci-device" @@ -23625,8 +23693,8 @@ "parent": "pci-device" }, { - "name": "thread-context", - "parent": "object" + "name": "EPYC-Milan-v2-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "Haswell-IBRS-x86_64-cpu", @@ -23736,10 +23804,6 @@ "name": "Opteron_G2-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "EPYC-Milan-v2-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "chardev-dbus", "parent": "chardev-socket" @@ -23776,6 +23840,10 @@ "name": "amd-iommu", "parent": "x86-iommu" }, + { + "name": "Nehalem-v2-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "virtio-9p-pci-non-transitional", "parent": "virtio-9p-pci-base" @@ -23784,10 +23852,6 @@ "name": "memory-backend-file", "parent": "memory-backend" }, - { - "name": "Nehalem-v2-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "xen-disk", "parent": "xen-block" @@ -24064,10 +24128,6 @@ "name": "vhost-user-blk-pci-non-transitional", "parent": "vhost-user-blk-pci-base" }, - { - "name": "Cooperlake-v2-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "cirrus-vga", "parent": "pci-device" @@ -24113,8 +24173,8 @@ "parent": "xen-block" }, { - "name": "gpex-root", - "parent": "pci-device" + "name": "Cooperlake-v2-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "container", @@ -24136,6 +24196,10 @@ "name": "sgx-epc", "parent": "device" }, + { + "name": "gpex-root", + "parent": "pci-device" + }, { "name": "vmport", "parent": "isa-device" @@ -24842,7 +24906,7 @@ }, { "name": "PIIX3", - "parent": "pci-piix3" + "parent": "pci-piix" }, { "name": "pc-q35-2.4-machine", @@ -25360,6 +25424,10 @@ "name": "virtio-iommu-device", "parent": "virtio-device" }, + { + "name": "chardev-pty", + "parent": "chardev" + }, { "name": "virtio-net-pci", "parent": "virtio-net-pci-base" @@ -25397,8 +25465,8 @@ "parent": "virtio-mem-pci-base" }, { - "name": "chardev-pty", - "parent": "chardev" + "name": "chardev-serial", + "parent": "chardev-fd" }, { "name": "virtio-pmem-pci", @@ -25641,8 +25709,8 @@ "parent": "netfilter" }, { - "name": "chardev-serial", - "parent": "chardev-fd" + "name": "virtio-blk-pci-transitional", + "parent": "virtio-blk-pci-base" }, { "name": "chardev-ringbuf", @@ -25685,16 +25753,16 @@ "parent": "qio-channel" }, { - "name": "virtio-blk-pci-transitional", - "parent": "virtio-blk-pci-base" + "name": "GraniteRapids-v1-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "virtio-vga", "parent": "virtio-vga-base-type" }, { - "name": "GraniteRapids-v1-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "piix4-isa", + "parent": "pci-piix" }, { "name": "Icelake-Server-v1-x86_64-cpu", @@ -28379,6 +28447,11 @@ "description": "on/off", "type": "bool" }, + { + "default-value": 0, + "name": "hostmem", + "type": "size" + }, { "default-value": false, "name": "x-disable-legacy-check", @@ -28403,8 +28476,7 @@ }, { "default-value": true, - "name": "queue_reset", - "description": "on/off", + "name": "use-started", "type": "bool" }, { @@ -28415,7 +28487,8 @@ }, { "default-value": true, - "name": "use-started", + "name": "queue_reset", + "description": "on/off", "type": "bool" }, { @@ -28514,6 +28587,11 @@ "description": "on/off", "type": "bool" }, + { + "default-value": 0, + "name": "hostmem", + "type": "size" + }, { "default-value": 1280, "name": "xres", @@ -28653,68 +28731,164 @@ "type": "bool" }, { - "name": "acpi_enable_cmd", - "type": "uint8" + "name": "acpi-pci-hotplug-with-bridge-support", + "type": "bool" }, { - "name": "x-smi-negotiated-features", - "type": "uint64" + "name": "gsi[12]", + "type": "link<irq>" + }, + { + "name": "gsi[16]", + "type": "link<irq>" + }, + { + "name": "gsi[13]", + "type": "link<irq>" + }, + { + "name": "rtc", + "type": "child<mc146818rtc>" + }, + { + "name": "gsi[14]", + "type": "link<irq>" }, { "name": "disable_s4", "type": "uint8" }, + { + "name": "disable_s3", + "type": "uint8" + }, + { + "name": "gsi[15]", + "type": "link<irq>" + }, { "name": "sci_int", "type": "uint8" }, { - "name": "acpi-pci-hotplug-with-bridge-support", + "name": "acpi_disable_cmd", + "type": "uint8" + }, + { + "name": "gsi[17]", + "type": "link<irq>" + }, + { + "name": "pm_io_base", + "type": "uint32" + }, + { + "name": "gsi[18]", + "type": "link<irq>" + }, + { + "name": "gsi[19]", + "type": "link<irq>" + }, + { + "name": "enable_tco", "type": "bool" }, + { + "name": "s4_val", + "type": "uint8" + }, { "name": "memory-hotplug-support", "type": "bool" }, { - "name": "rtc", - "type": "child<mc146818rtc>" + "name": "gsi[0]", + "type": "link<irq>" }, { - "name": "disable_s3", - "type": "uint8" + "name": "x-smi-negotiated-features", + "type": "uint64" }, { - "name": "enable_tco", - "type": "bool" + "name": "gsi[1]", + "type": "link<irq>" }, { - "name": "gpe0_blk_len", - "type": "uint32" + "name": "gsi[20]", + "type": "link<irq>" }, { "name": "gpe0_blk", "type": "uint32" }, + { + "name": "gsi[21]", + "type": "link<irq>" + }, + { + "name": "gsi[2]", + "type": "link<irq>" + }, { "name": "x-keep-pci-slot-hpc", "type": "bool" }, { - "name": "acpi_disable_cmd", - "type": "uint8" + "name": "gsi[3]", + "type": "link<irq>" }, { - "name": "s4_val", + "name": "gsi[22]", + "type": "link<irq>" + }, + { + "name": "gpe0_blk_len", + "type": "uint32" + }, + { + "name": "gsi[4]", + "type": "link<irq>" + }, + { + "name": "gsi[23]", + "type": "link<irq>" + }, + { + "name": "acpi_enable_cmd", "type": "uint8" }, + { + "name": "gsi[5]", + "type": "link<irq>" + }, + { + "name": "gsi[6]", + "type": "link<irq>" + }, { "name": "cpu-hotplug-legacy", "type": "bool" }, { - "name": "pm_io_base", - "type": "uint32" + "name": "gsi[7]", + "type": "link<irq>" + }, + { + "name": "gsi[8]", + "type": "link<irq>" + }, + { + "name": "gsi[10]", + "type": "link<irq>" + }, + { + "name": "gsi[9]", + "type": "link<irq>" + }, + { + "name": "gsi[11]", + "type": "link<irq>" } ], "id": "libvirt-24" @@ -29842,9 +30016,9 @@ "type": "bool" }, { - "default-value": 0, - "name": "memaddr", - "type": "uint64" + "default-value": false, + "name": "dynamic-memslots", + "type": "bool" }, { "default-value": true, @@ -29894,8 +30068,8 @@ "type": "bool" }, { - "default-value": false, - "name": "packed", + "default-value": true, + "name": "queue_reset", "description": "on/off", "type": "bool" }, @@ -29906,8 +30080,9 @@ "type": "bool" }, { - "default-value": true, - "name": "use-started", + "default-value": false, + "name": "packed", + "description": "on/off", "type": "bool" }, { @@ -29921,8 +30096,7 @@ }, { "default-value": true, - "name": "queue_reset", - "description": "on/off", + "name": "use-started", "type": "bool" }, { @@ -29931,14 +30105,19 @@ "description": "on/off/auto", "type": "OnOffAuto" }, + { + "name": "size", + "type": "size" + }, { "default-value": true, "name": "use-disabled-flag", "type": "bool" }, { - "name": "size", - "type": "size" + "default-value": 0, + "name": "memaddr", + "type": "uint64" }, { "name": "virtio-backend", @@ -35547,6 +35726,11 @@ "help": "Set off to disable the instantiation an ISA serial port", "type": "boolean" }, + { + "name": "x-south-bridge", + "help": "Use a different south bridge than PIIX3", + "type": "string" + }, { "name": "kernel", "help": "Linux kernel image file", @@ -36443,6 +36627,14 @@ "name": "sockets", "type": "number" }, + { + "name": "books", + "type": "number" + }, + { + "name": "drawers", + "type": "number" + }, { "name": "cpus", "type": "number" diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml index ec4c8217dd..1dfe173a57 100644 --- a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml @@ -201,7 +201,7 @@ <flag name='virtio-blk-vhost-vdpa'/> <version>8001050</version> <microcodeVersion>43100246</microcodeVersion> - <package>v8.1.0-1639-g63011373ad</package> + <package>v8.1.0-2161-ga95260486a</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='avx-ne-convert' type='boolean' value='false'/> -- 2.41.0

1 0

[libvirt PATCH v2 0/8] meson: Improve handling of tests
by Andrea Bolognani 26 Oct '23

26 Oct '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1049326523 Changes from [v1] * fix test suite on macOS and ensure it is run as part of the pipeline (with the previous version it would just always fail); * disable a couple of tests (check-html, check-html-references) that I had missed the first time around. [v1] https://listman.redhat.com/archives/libvir-list/2023-October/242491.html Andrea Bolognani (8): tests: Fix some test cases on macOS ci: Disable optimizations on macOS meson: Do less when not building from git meson: Move all handling of test options together meson: Handle -Dtests=enabled with Clang meson: Make -Dexpensive_tests depend on -Dtests meson: Disable all tests when tests are disabled meson: Rename build_tests -> tests_enabled build-aux/meson.build | 99 +++++---- ci/cirrus/build.yml | 2 +- docs/html/meson.build | 20 +- docs/meson.build | 24 ++- meson.build | 75 ++++--- meson_options.txt | 2 +- src/access/meson.build | 16 +- src/meson.build | 204 +++++++++--------- .../disk-source-fd.x86_64-latest.args | 10 +- .../disk-vhostvdpa.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 8 +- 11 files changed, 242 insertions(+), 220 deletions(-) -- 2.41.0

2 9

hdd kills vm
by daggs 26 Oct '23

26 Oct '23

Greetings, I have a windows 11 vm running on my Gentoo using libvirt (9.8.0) + qemu (8.1.2), I'm passing almost all available resources to the vm (all 16 cpus, 31 out of 32 GB, nVidia gpu is pt), but the performance is not good, system lags, takes long time to boot. after trying a few ways to fix it, I've concluded that the issue might be related to the why the hdd is defined at the vm level. here is the xml: https://bpa.st/MYTA I assume that the hdd sits on the sata ctrl causing the issue but I'm not sure what is the proper way to fix it, any ideas? Thanks, Dagg.

2 6

[libvirt PATCH 0/6] meson: Improve handling of tests
by Andrea Bolognani 25 Oct '23

25 Oct '23

Andrea Bolognani (6): meson: Do less when not building from git meson: Move all handling of test options together meson: Handle -Dtests=enabled with Clang meson: Make -Dexpensive_tests depend on -Dtests meson: Disable all tests when tests are disabled meson: Rename build_tests -> tests_enabled build-aux/meson.build | 99 ++++++++++---------- meson.build | 75 +++++++++------ meson_options.txt | 2 +- src/access/meson.build | 16 ++-- src/meson.build | 204 +++++++++++++++++++++-------------------- 5 files changed, 207 insertions(+), 189 deletions(-) -- 2.41.0

2 9

unsubscribe
by Alvaro Miranda Aguilera 25 Oct '23

25 Oct '23

unsubscribe -- Alvaro

1 0