November 2020 - Devel - libvirt List Archives

[PATCH 0/6] Hyper-V code cleanup
by Matt Coleman 02 Nov '20

02 Nov '20

Here's a draft GitLab MR if you'd prefer to review the changes there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/3/diffs Matt Coleman (6): hyperv: reformat WQL query strings hyperv: remove duplicate function hypervGetVSSDFromUUID() hyperv: remove duplicate function hypervGetMemSDByVSSDInstanceId() hyperv: remove unneeded braces in hypervDomainGetInfo() and hypervDomainGetXMLDesc() hyperv: reduce duplicate code for Msvm_ComputerSystem lookups hyperv: do not overwrite errors from hypervInvokeMethod() src/hyperv/hyperv_driver.c | 169 +++++++++---------------------------- src/hyperv/hyperv_wmi.c | 57 +++++++------ src/hyperv/hyperv_wmi.h | 4 + 3 files changed, 75 insertions(+), 155 deletions(-) -- 2.27.0

3 9

[PATCH 0/3] qemu: Prevent breakage of libvirt-6.9.0 with qemu-5.2.0
by Peter Krempa 02 Nov '20

02 Nov '20

Justification from 1/3: Unfortunately qemu wants to change the interface of 'block-export-add' before the release. Since we've tried to stay up to date and added the code before it was written in stone, we need to disable the use of the new interface for the upcoming libvirt release so that we don't have a version of libvirt which would not work with the upcoming qemu version. Patch 2/3 is the fix itself which uses the new interface. Patch 1/3 and 3/3 are a plan-B option if qemu doesn't include the fix until libvirt-6.9.0 will be about to be released. In such case I'll push patch 1/3 and patches 2-3/3 will be left for a subsequent release. Peter Krempa (3): qemu: capabilities: Disable detection of QEMU_CAPS_BLOCK_EXPORT_ADD qemu: Update to new design of 'block-export-add' qemu: capabilities: Re-enable detection of QEMU_CAPS_BLOCK_EXPORT_ADD src/qemu/qemu_block.c | 17 +- src/qemu/qemu_block.h | 2 +- .../caps_5.2.0.x86_64.replies | 2377 +++++++++-------- .../caps_5.2.0.x86_64.xml | 2 +- tests/qemumonitorjsontest.c | 3 +- 5 files changed, 1339 insertions(+), 1062 deletions(-) -- 2.26.2

2 10

[libvirt PATCH] rpm: fix name of meson option for disabling glusterfs
by Daniel P. Berrangé 02 Nov '20

02 Nov '20

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 06afd0dab8..f0990b870b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1056,9 +1056,9 @@ exit 1 %endif %if %{with_storage_gluster} - %define arg_storage_gluster -Dstorage_gluster=enabled + %define arg_storage_gluster -Dstorage_glusterfs=enabled %else - %define arg_storage_gluster -Dstorage_gluster=disabled + %define arg_storage_gluster -Dstorage_glusterfs=disabled %endif %if %{with_storage_zfs} -- 2.28.0

1 1

[PATCH] news: Fix an RST alignment typo with '=' which breaks the pipeline
by Erik Skultety 02 Nov '20

02 Nov '20

This is just a warning, but because we're invoking rst2html5 with --strict, it will fail at encountering a single minor issue. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed as trivial. NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 09170638ec..a8dde151e0 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -9,7 +9,7 @@ For a more fine-grained view, use the `git log`_. v6.10.0 (unreleased) -=================== +==================== * **New features** -- 2.26.2

2 2

[libvirt PATCH] news: Remove empty section
by Andrea Bolognani 02 Nov '20

02 Nov '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. NEWS.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index a8dde151e0..905deba5a8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -59,8 +59,6 @@ v6.9.0 (2020-11-02) using ``<interface type='vdpa'>``. The node device APIs also now list and provide XML descriptions for vDPA devices. -* **Improvements** - * **Bug fixes** * hyperv: ensure WQL queries work in all locales -- 2.26.2

1 0

Proposal: drop support for Hyper-V 2008R2
by Matt Coleman 02 Nov '20

02 Nov '20

Hello, I've been getting familiar with Hyper-V recently and have gotten stymied by inconsistencies in its API. While Hyper-V has V1 and V2 APIs, neither one is consistent between Windows versions. For example... * Windows 2012 only supports a subset of the V2 API * Windows 2012 implements some V1 functions differently than 2008R2 * Windows 2016 broke compatibility with 2012R2 by replacing some classes Some of these differences are undocumented, too, which is just lovely. Most of these changes are relatively easy to handle, but the differences between 2008R2's and 2012's implementations of the V1 API result in libvirt code with a lot of conditionals containing obscure format strings in the 2008R2 blocks. Windows 2008R2's extended support ended January 14, 2020: https://docs.microsoft.com/en-us/lifecycle/products/windows-server-2008-r2 Windows 2012's mainstream support ended in 2018, but it still has extended support through October 10, 2023: https://docs.microsoft.com/en-us/lifecycle/products/windows-server-2012 Since 2008R2 is no longer supported by Microsoft, I propose removing support for it from libvirt. Thoughts? -- Matt

4 7

[libvirt PATCH 0/2] Run full unit tests on i686 too
by Daniel P. Berrangé 02 Nov '20

02 Nov '20

Daniel P. Berrangé (2): gitlab: run unit tests in i686 cross build scripts: trim "__attribute__((packed))" in RPC struct diff .gitlab-ci.yml | 1 + scripts/check-remote-protocol.py | 6 ++++++ 2 files changed, 7 insertions(+) -- 2.28.0

2 3