[libvirt PATCH v4 0/4] Add support for QEMU's fmode and dmode
by Brian Turek
This is the latest set of patches to expose QEMU's fmode and dmode
functionality. I hopefully split these up correctly per Peter Krempa's
guidance.
I debated where to implement the fmode/dmode value validation and
ultimately decided on domain_conf.c rather than qemu_validate.c. My
reasoning being that it is essentially enforcing the schema rather than
performing QEMU-specific validation.
Brian Turek (4):
qemu: capabilities: add QEMU_CAPS_FSDEV_CREATEMODE
qemu: add 'fmode' and 'dmode' options
qemu: add support for 'fmode' and 'dmode'
qemu: add docs for 'fmode' and 'dmode' options
docs/formatdomain.rst | 13 ++++
docs/schemas/domaincommon.rng | 16 +++++
src/conf/domain_conf.c | 29 +++++++++
src/conf/domain_conf.h | 2 +
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 6 ++
src/qemu/qemu_validate.c | 18 ++++++
.../caps_2.10.0.aarch64.xml | 1 +
.../caps_2.10.0.ppc64.xml | 1 +
.../caps_2.10.0.s390x.xml | 1 +
.../caps_2.10.0.x86_64.xml | 1 +
.../caps_2.11.0.s390x.xml | 1 +
.../caps_2.11.0.x86_64.xml | 1 +
.../caps_2.12.0.aarch64.xml | 1 +
.../caps_2.12.0.ppc64.xml | 1 +
.../caps_2.12.0.s390x.xml | 1 +
.../caps_2.12.0.x86_64.xml | 1 +
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 +
.../caps_3.0.0.riscv32.xml | 1 +
.../caps_3.0.0.riscv64.xml | 1 +
.../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 +
.../caps_3.0.0.x86_64.xml | 1 +
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 +
.../caps_3.1.0.x86_64.xml | 1 +
.../caps_4.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 +
.../caps_4.0.0.riscv32.xml | 1 +
.../caps_4.0.0.riscv64.xml | 1 +
.../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 +
.../caps_4.0.0.x86_64.xml | 1 +
.../caps_4.1.0.x86_64.xml | 1 +
.../caps_4.2.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 +
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 +
.../caps_4.2.0.x86_64.xml | 1 +
.../caps_5.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 +
.../caps_5.0.0.riscv64.xml | 1 +
.../caps_5.0.0.x86_64.xml | 1 +
.../caps_5.1.0.x86_64.xml | 1 +
.../caps_5.2.0.x86_64.xml | 1 +
.../virtio-9p-createmode.x86_64-latest.args | 46 ++++++++++++++
.../qemuxml2argvdata/virtio-9p-createmode.xml | 58 ++++++++++++++++++
tests/qemuxml2argvtest.c | 1 +
.../virtio-9p-createmode.x86_64-latest.xml | 61 +++++++++++++++++++
tests/qemuxml2xmltest.c | 1 +
47 files changed, 288 insertions(+)
create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/virtio-9p-createmode.xml
create mode 100644 tests/qemuxml2xmloutdata/virtio-9p-createmode.x86_64-latest.xml
--
2.25.1
4 years, 6 months
[PATCH 0/3] IPV6 filters example.
by Aleksandr Alekseev
Add nwfilter examples for ipv6 similar to existing ip filters.
Add appropriate docs for them and for some previously undocumented,
but existing filters. Also fix a typo and some formatting.
Aleksandr Alekseev (3):
example: fix typo and formatting
example: add ipv6 filters examples
doc: document new filters and not documented ones
docs/firewall.html.in | 9 ++++++
docs/formatnwfilter.html.in | 41 ++++++++++++++++++++++--
src/nwfilter/xml/allow-dhcp-server.xml | 4 +--
src/nwfilter/xml/allow-dhcp.xml | 4 +--
src/nwfilter/xml/allow-dhcpv6-server.xml | 27 ++++++++++++++++
src/nwfilter/xml/allow-dhcpv6.xml | 24 ++++++++++++++
src/nwfilter/xml/allow-incoming-ipv6.xml | 3 ++
src/nwfilter/xml/allow-ipv6.xml | 3 ++
src/nwfilter/xml/meson.build | 6 ++++
src/nwfilter/xml/no-ipv6-multicast.xml | 9 ++++++
src/nwfilter/xml/no-ipv6-spoofing.xml | 15 +++++++++
11 files changed, 138 insertions(+), 7 deletions(-)
create mode 100644 src/nwfilter/xml/allow-dhcpv6-server.xml
create mode 100644 src/nwfilter/xml/allow-dhcpv6.xml
create mode 100644 src/nwfilter/xml/allow-incoming-ipv6.xml
create mode 100644 src/nwfilter/xml/allow-ipv6.xml
create mode 100644 src/nwfilter/xml/no-ipv6-multicast.xml
create mode 100644 src/nwfilter/xml/no-ipv6-spoofing.xml
--
2.28.0.97.gdc04167d37
4 years, 6 months
[PATCH v2] cpu_ppc64: compare CPU function is ignoring return value
by Julio Faracco
Function to compare CPU on 64-bits PowerPC is ignoring the flag to avoid failure
in case of CPUs (host and guest) are incompatible. Basically, the function is
returning -1 even if it is set to continue.
Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com>
---
src/cpu/cpu_ppc64.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 2fedcd25da..555eeecbe7 100644
--- a/src/cpu/cpu_ppc64.c
+++ b/src/cpu/cpu_ppc64.c
@@ -524,11 +524,11 @@ virCPUppc64Compare(virCPUDefPtr host,
if (failIncompatible) {
virReportError(VIR_ERR_CPU_INCOMPATIBLE, "%s",
_("unknown host CPU"));
- } else {
- VIR_WARN("unknown host CPU");
- ret = VIR_CPU_COMPARE_INCOMPATIBLE;
+ return VIR_CPU_COMPARE_ERROR;
}
- return -1;
+
+ VIR_WARN("unknown host CPU");
+ return VIR_CPU_COMPARE_INCOMPATIBLE;
}
ret = ppc64Compute(host, cpu, NULL, &message);
--
2.25.1
4 years, 6 months
[PATCH 0/9] qemu: backup/checkpoint: Error reporting and handling fixes
by Peter Krempa
Peter Krempa (9):
checkpoint: Mention that VIR_DOMAIN_CHECKPOINT_XML_SIZE may require
running vm
man: virsh: Mention that '--size' for 'checkpoint-dumpxml' may require
running vm
error: Introduce VIR_ERR_CHECKPOINT_INCONSISTENT error code
qemu: backup: Use VIR_ERR_CHECKPOINT_INCONSISTENT when starting a
backup
checkpoint: Introduce VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE flag
virsh: checkpoint-create: Add support for
VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE
conf: checkpoint: Split virDomainCheckpointRedefinePrep into two
functions
qemu: checkpoint: Implement VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE
qemu: backup: Add partial validation of incremental backup checkpoint
docs/manpages/virsh.rst | 13 ++++-
include/libvirt/libvirt-domain-checkpoint.h | 2 +
include/libvirt/virterror.h | 1 +
src/conf/checkpoint_conf.c | 30 +++++++---
src/conf/checkpoint_conf.h | 14 +++--
src/libvirt-domain-checkpoint.c | 13 ++++-
src/libvirt_private.syms | 1 +
src/qemu/qemu_backup.c | 13 ++++-
src/qemu/qemu_checkpoint.c | 64 +++++++++++++++------
src/test/test_driver.c | 9 ++-
src/util/virerror.c | 4 ++
tools/virsh-checkpoint.c | 8 +++
12 files changed, 133 insertions(+), 39 deletions(-)
--
2.26.2
4 years, 6 months
[PATCH v2 0/9] tests: Add testing of qemu migration cookie
by Peter Krempa
Add testing of migration cookie as we don't have any schema or examples
of it to prevent breakage and help with development.
v2:
- no longer depends on the somewhat controversial GHashTable refactor
- removed leftover commented out code in patch 2
Peter Krempa (9):
qemuxml2xmltest: Remove 'WITH_QEMU' conditional
qemuxml2xmltest: Split out status XML testing to
qemustatusxml2xmltest.c
qemu_migration_cookie: Make header standalone
qemu_migration_cookie: Export qemuMigrationCookieXMLFormat for tests
tests: Add mock library for virGetHostname and virGetHostUUID
qemu_migration_cookie: Make cookie parsing robust against missing
domain job
tests: Add testing of qemu migration cookie
qemumigrationcookiexmltest: Add synthetic test case
virCPUDefFormatBufFull: Use virXMLFormatElement
src/conf/cpu_conf.c | 16 +-
src/qemu/qemu_migration_cookie.c | 4 +-
src/qemu/qemu_migration_cookie.h | 9 +
src/util/virutil.h | 2 +-
src/util/viruuid.h | 2 +-
tests/hostidmock.c | 36 ++
tests/meson.build | 3 +
.../basic-xml2xml-in.xml | 6 +
.../basic-xml2xml-out.xml | 9 +
.../full-xml2xml-in.xml | 221 ++++++++++++
.../full-xml2xml-out.xml | 219 ++++++++++++
.../modern-dom-out-dest.xml | 12 +
.../modern-dom-out-source.xml | 12 +
tests/qemumigrationcookiexmltest.c | 337 ++++++++++++++++++
tests/qemustatusxml2xmltest.c | 155 ++++++++
tests/qemuxml2xmltest.c | 136 ++-----
16 files changed, 1044 insertions(+), 135 deletions(-)
create mode 100644 tests/hostidmock.c
create mode 100644 tests/qemumigrationcookiexmldata/basic-xml2xml-in.xml
create mode 100644 tests/qemumigrationcookiexmldata/basic-xml2xml-out.xml
create mode 100644 tests/qemumigrationcookiexmldata/full-xml2xml-in.xml
create mode 100644 tests/qemumigrationcookiexmldata/full-xml2xml-out.xml
create mode 100644 tests/qemumigrationcookiexmldata/modern-dom-out-dest.xml
create mode 100644 tests/qemumigrationcookiexmldata/modern-dom-out-source.xml
create mode 100644 tests/qemumigrationcookiexmltest.c
create mode 100644 tests/qemustatusxml2xmltest.c
--
2.26.2
4 years, 6 months
[PULL 0/6] Mips fixes patches
by Philippe Mathieu-Daudé
The following changes since commit 83851c7c60c90e9fb6a23ff48076387a77bc33cd:
Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-10-27-v3-ta=
g' into staging (2020-11-03 12:47:58 +0000)
are available in the Git repository at:
https://gitlab.com/philmd/qemu.git tags/mips-fixes-20201103
for you to fetch changes up to 8a805609d126ff2be9ad9ec118185dfc52633d6f:
target/mips: Add unaligned access support for MIPS64R6 and Loongson-3 (2020=
-11-03 16:51:13 +0100)
----------------------------------------------------------------
MIPS patches queue
- Removal of the 'r4k' machine (deprecated before 5.0)
- Fix LGPL license text (Chetan Pant)
- Support unaligned accesses on Loongson-3 (Huacai Chen)
- Fix out-of-bound access in Loongson-3 embedded I/O interrupt
controller (Alex Chen)
CI jobs results:
. https://cirrus-ci.com/build/6324890389184512
. https://gitlab.com/philmd/qemu/-/pipelines/211275262
. https://travis-ci.org/github/philmd/qemu/builds/741188958
----------------------------------------------------------------
AlexChen (1):
hw/intc/loongson: Fix incorrect 'core' calculation in
liointc_read/write
Chetan Pant (3):
hw/mips: Fix Lesser GPL version number
hw/mips/boston: Fix Lesser GPL version number
target/mips: Fix Lesser GPL version number
Huacai Chen (1):
target/mips: Add unaligned access support for MIPS64R6 and Loongson-3
Philippe Mathieu-Daud=C3=A9 (1):
hw/mips: Remove the 'r4k' machine
docs/system/deprecated.rst | 12 +-
.../devices/mips-softmmu-common.mak | 1 -
include/hw/mips/cps.h | 2 +-
include/hw/misc/mips_cpc.h | 2 +-
include/hw/misc/mips_itu.h | 2 +-
include/hw/pci-host/xilinx-pcie.h | 2 +-
hw/core/loader-fit.c | 2 +-
hw/intc/loongson_liointc.c | 4 +-
hw/mips/boston.c | 2 +-
hw/mips/cps.c | 2 +-
hw/mips/r4k.c | 318 ------------------
hw/misc/mips_cpc.c | 2 +-
hw/misc/mips_itu.c | 2 +-
hw/pci-host/xilinx-pcie.c | 2 +-
target/mips/cp0_helper.c | 2 +-
target/mips/dsp_helper.c | 2 +-
target/mips/fpu_helper.c | 2 +-
target/mips/gdbstub.c | 2 +-
target/mips/helper.c | 2 +-
target/mips/lmmi_helper.c | 2 +-
target/mips/mips-semi.c | 2 +-
target/mips/msa_helper.c | 2 +-
target/mips/op_helper.c | 2 +-
target/mips/translate.c | 6 +-
tests/qtest/cdrom-test.c | 2 +-
tests/qtest/endianness-test.c | 2 -
MAINTAINERS | 6 -
hw/mips/Kconfig | 13 -
hw/mips/meson.build | 1 -
target/mips/translate_init.c.inc | 2 +-
30 files changed, 32 insertions(+), 373 deletions(-)
delete mode 100644 hw/mips/r4k.c
--=20
2.26.2
4 years, 6 months
Hyper-V CPU details
by Matt Coleman
Hello,
I'm implementing domainGetVcpus and could use some guidance on what
value to use for virVcpuInfo->cpu.
Hyper-V does not allow the user to pin vCPUs to host CPUs and doesn't
allow the user to see which host CPU a vCPU is currently running on.
Since it's a type 1 hypervisor, none of its scheduling data is
available to the Windows userspace: there aren't any processes or
threads that correspond to vCPUs that I could query the OS scheduler
about.
My code currently sets it to -1, which produces the following `virsh
vcpuinfo` output for a running VM with two cores:
VCPU: 0
CPU: -1
State: running
CPU time: 1684.5s
CPU Affinity: yyyy
VCPU: 1
CPU: -1
State: running
CPU time: 1346.0s
CPU Affinity: yyyy
However, this doesn't match the comment in _virVcpuInfo's declaration,
which says that -1 signifies an offline CPU:
https://gitlab.com/libvirt/libvirt/-/blob/v6.8.0/include/libvirt/libvirt-...
Should I stick with -1? Or, should I introduce -2 as a value that
indicates that the hypervisor doesn't provide that information? Or, is
there some better way to handle this that I'm not aware of?
--
Matt
4 years, 6 months
[PATCH 0/4] Couple of qemusecuritytest and security_util improvements
by Michal Privoznik
These were sparked by a discussion on the list where the test is failing
on macOS.
Michal Prívozník (4):
security_util: Don't error on macOS when getting/setting/moving XATTRs
qemusecuritytest: Test SELinux too
qemusecuritytest: Skip on non supported platforms
qemu_conf: Don't even attempt to enable rememberOwner if unsupported
src/libvirt_private.syms | 4 +
src/qemu/qemu_conf.c | 7 +-
src/security/security_util.c | 26 ++-
src/security/security_util.h | 3 +
tests/qemusecuritydata/virtual_domain_context | 2 +
tests/qemusecuritydata/virtual_image_context | 2 +
tests/qemusecuritymock.c | 195 +++++++++++++++++-
tests/qemusecuritytest.c | 57 ++++-
8 files changed, 282 insertions(+), 14 deletions(-)
create mode 100644 tests/qemusecuritydata/virtual_domain_context
create mode 100644 tests/qemusecuritydata/virtual_image_context
--
2.26.2
4 years, 6 months
