- Devel - libvirt List Archives

[libvirt] [PATCH v3] dirty-bitmaps: remove deprecated autoload parameter
by John Snow 09 Oct '19

09 Oct '19

This parameter has been deprecated since 2.12.0 and is eligible for removal. Remove this parameter as it is actually completely ignored; let's not give false hope. Signed-off-by: John Snow <jsnow(a)redhat.com> Reviewed-by: Eric Blake <eblake(a)redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov(a)virtuozzo.com> --- V2: Change 2.12.0 -> 4.2.0 in removed section. Adjust phrasing to match. qemu-deprecated.texi | 20 +++++++++++++++----- qapi/block-core.json | 6 +----- blockdev.c | 6 ------ 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 01245e0b1c..7239e0959d 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -149,11 +149,6 @@ QEMU 4.1 has three options, please migrate to one of these three: @section QEMU Machine Protocol (QMP) commands -@subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) - -"autoload" parameter is now ignored. All bitmaps are automatically loaded -from qcow2 images. - @subsection query-block result field dirty-bitmaps[i].status (since 4.0) The ``status'' field of the ``BlockDirtyInfo'' structure, returned by @@ -356,3 +351,18 @@ existing CPU models. Management software that needs runnability guarantees must resolve the CPU model aliases using te ``alias-of'' field returned by the ``query-cpu-definitions'' QMP command. + + +@node Recently removed features +@appendix Recently removed features + +What follows is a record of recently removed, formerly deprecated +features that serves as a record for users who have encountered +trouble after a recent upgrade. + +@section QEMU Machine Protocol (QMP) commands + +@subsection block-dirty-bitmap-add "autoload" parameter (since 4.2.0) + +The "autoload" parameter has been ignored since 2.12.0. All bitmaps +are automatically loaded from qcow2 images. diff --git a/qapi/block-core.json b/qapi/block-core.json index e6edd641f1..e4975ece4a 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1987,10 +1987,6 @@ # Qcow2 disks support persistent bitmaps. Default is false for # block-dirty-bitmap-add. (Since: 2.10) # -# @autoload: ignored and deprecated since 2.12. -# Currently, all dirty tracking bitmaps are loaded from Qcow2 on -# open. -# # @disabled: the bitmap is created in the disabled state, which means that # it will not track drive changes. The bitmap may be enabled with # block-dirty-bitmap-enable. Default is false. (Since: 4.0) @@ -1999,7 +1995,7 @@ ## { 'struct': 'BlockDirtyBitmapAdd', 'data': { 'node': 'str', 'name': 'str', '*granularity': 'uint32', - '*persistent': 'bool', '*autoload': 'bool', '*disabled': 'bool' } } + '*persistent': 'bool', '*disabled': 'bool' } } ## # @BlockDirtyBitmapMergeSource: diff --git a/blockdev.c b/blockdev.c index fbef6845c8..93804da840 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1966,7 +1966,6 @@ static void block_dirty_bitmap_add_prepare(BlkActionState *common, qmp_block_dirty_bitmap_add(action->node, action->name, action->has_granularity, action->granularity, action->has_persistent, action->persistent, - action->has_autoload, action->autoload, action->has_disabled, action->disabled, &local_err); @@ -2858,7 +2857,6 @@ out: void qmp_block_dirty_bitmap_add(const char *node, const char *name, bool has_granularity, uint32_t granularity, bool has_persistent, bool persistent, - bool has_autoload, bool autoload, bool has_disabled, bool disabled, Error **errp) { @@ -2890,10 +2888,6 @@ void qmp_block_dirty_bitmap_add(const char *node, const char *name, persistent = false; } - if (has_autoload) { - warn_report("Autoload option is deprecated and its value is ignored"); - } - if (!has_disabled) { disabled = false; } -- 2.21.0

1 1

[libvirt] [PATCH 0/1] qemu: fix type of default video device
by Pavel Mores 09 Oct '19

09 Oct '19

This patch does seem to fix the original bug as it was reported, however it also raises the broader question of how exactly to decide under various circumstances what the type of the video device we're silently adding should be. This patch is meant to be an initial suggestion to kick off discussion. If you don't like anything about it please comment. :-) Pavel Mores (1): qemu: fix type of default video device src/qemu/qemu_domain.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) -- 2.21.0

2 2

[libvirt] [PATCH] libvirt_python:fix bug of sanitytest.py script
by ossdev＠puresoftware.com 09 Oct '19

09 Oct '19

From: ossdev <ossdev(a)puresoftware.com> libvirt-python:fix bug of sanitytest.py script Signed-off-by: ossdev <ossdev(a)puresoftware.com> --- sanitytest.py | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/sanitytest.py b/sanitytest.py index e87b57d..c5d1f42 100644 --- a/sanitytest.py +++ b/sanitytest.py @@ -22,6 +22,21 @@ def get_libvirt_api_xml_path(): sys.exit(proc.returncode) return stdout.splitlines()[0] +def sanitize_enum_val(value): + if value == 'VIR_TYPED_PARAM_INT': + value = 1 + elif value == 'VIR_TYPED_PARAM_UINT': + value = 2 + elif value == 'VIR_TYPED_PARAM_LLONG': + value = 3 + elif value == 'VIR_TYPED_PARAM_ULLONG': + value = 4 + elif value == 'VIR_TYPED_PARAM_DOUBLE': + value = 5 + elif value == 'VIR_TYPED_PARAM_BOOLEAN': + value = 6 + return value + # Path to the libvirt API XML file if len(sys.argv) >= 3: xml = sys.argv[2] @@ -48,8 +63,8 @@ set = tree.xpath('/api/symbols/enum') for n in set: typ = n.attrib['type'] name = n.attrib['name'] - val = n.attrib['value'] - + #val = n.attrib['value'] + val = sanitize_enum_val(n.attrib['value']) if typ not in enumvals: enumvals[typ] = {} -- 2.17.1 -- *Disclaimer* -The information transmitted is intended solely for the individual or entity to which it is addressed and may contain confidential and/or privileged material. Any review, re-transmission, dissemination or other use of or taking action in reliance upon this information by persons or entities other than the intended recipient is prohibited. If you have received this email in error please contact the sender and delete the material from any computer. In such instances you are further prohibited from reproducing, disclosing, distributing or taking any action in reliance on it.As a recipient of this email, you are responsible for screening its contents and the contents of any attachments for the presence of viruses. No liability is accepted for any damages caused by any virus transmitted by this email.

2 1

[libvirt] [PATCH 1/4] qemu: validate bochs-display capability
by Jonathon Jongsma 09 Oct '19

09 Oct '19

When the bochs display type was added, the capability was never checked. Add that check in the same place as the other video device capability checks. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/qemu/qemu_process.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 955ba4de4c..b93af966e2 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5278,7 +5278,9 @@ qemuProcessStartValidateVideo(virDomainObjPtr vm, !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU)) || (video->type == VIR_DOMAIN_VIDEO_TYPE_VIRTIO && video->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU_CCW))) { + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU_CCW)) || + (video->type == VIR_DOMAIN_VIDEO_TYPE_BOCHS && + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_BOCHS_DISPLAY))) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("this QEMU does not support '%s' video device"), virDomainVideoTypeToString(video->type)); -- 2.21.0

2 5

[libvirt] [PATCH] conf: remove parse code for long-extinct "<state devaddr='d:b:s'/>
by Laine Stump 09 Oct '19

09 Oct '19

Back in July 2009, in the days before libvirt supported explicitly assigning a PCI address to every device, code was added to save the PCI addresses of hotplugged network, disk, and hostdevs in the domain status with this XML element: <status devaddr='domain:bus:slot'/> This was added in commits 4e21a95a, 01654107, in v0.7.0, and 0c5b7b93 in v0.7.1. Then just a few months later, in November 2009, The code that actually formatted the "devaddr='blah' into the status XML was removed by commit 1b0cce7d3 (which "Introduce[d] a standardized data structure for device addresses"). The code to *parse* the devaddr from the status was left in for backward compatibility though (it just parses it into the "standard" PCI address). At the time the devaddr attribute was added, a few other attributes already existed in the <status> element for network devices, and these were removed over time (I haven't checked the exact dates of this), but 10 years later, in libvirt v5.8.0, we *still* maintain code to parse <status devaddr='blah'/> from the domain status. In the meantime, even distros so old that we no longer support them in upstream libvirt are using a libvirt new enough that it doesn't ever write <status devaddr='blah'/> to the domain status XML. Since the only way a current libvirt would ever encounter this element would be if someone was upgrading directly from libvirt <=v0.7.5 with running guests, it seems safe to finally remove the code that parses it. Signed-off-by: Laine Stump <laine(a)redhat.com> --- The git commit ID's etc are probably not essential to have in the log message, but I did think it was interesting that we've been carrying this for so many years... src/conf/domain_conf.c | 76 +++++------------------------------------- 1 file changed, 8 insertions(+), 68 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a53cd6a725..423c242be9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7558,24 +7558,6 @@ virDomainDeviceInfoParseXML(virDomainXMLOptionPtr xmlopt ATTRIBUTE_UNUSED, return ret; } -static int -virDomainParseLegacyDeviceAddress(char *devaddr, - virPCIDeviceAddressPtr pci) -{ - char *tmp; - - /* expected format: <domain>:<bus>:<slot> */ - if (/* domain */ - virStrToLong_ui(devaddr, &tmp, 16, &pci->domain) < 0 || *tmp != ':' || - /* bus */ - virStrToLong_ui(tmp + 1, &tmp, 16, &pci->bus) < 0 || *tmp != ':' || - /* slot */ - virStrToLong_ui(tmp + 1, NULL, 16, &pci->slot) < 0) - return -1; - - return 0; -} - static int virDomainHostdevSubsysUSBDefParseXML(xmlNodePtr node, virDomainHostdevDefPtr def) @@ -7758,19 +7740,7 @@ virDomainHostdevSubsysPCIDefParseXML(xmlNodePtr node, if (virPCIDeviceAddressParseXML(cur, addr) < 0) goto out; - } else if ((flags & VIR_DOMAIN_DEF_PARSE_STATUS) && - virXMLNodeNameEqual(cur, "state")) { - /* Legacy back-compat. Don't add any more attributes here */ - VIR_AUTOFREE(char *) devaddr = virXMLPropString(cur, "devaddr"); - if (devaddr && - virDomainParseLegacyDeviceAddress(devaddr, - &def->info->addr.pci) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to parse devaddr parameter '%s'"), - devaddr); - goto out; - } - def->info->type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI; + } else if ((flags & VIR_DOMAIN_DEF_PARSE_PCI_ORIG_STATES) && virXMLNodeNameEqual(cur, "origstates")) { virDomainHostdevOrigStatesPtr states = &def->origstates; @@ -9959,7 +9929,6 @@ virDomainDiskDefParseXML(virDomainXMLOptionPtr xmlopt, VIR_AUTOFREE(char *) sgio = NULL; VIR_AUTOFREE(char *) target = NULL; VIR_AUTOFREE(char *) bus = NULL; - VIR_AUTOFREE(char *) devaddr = NULL; VIR_AUTOFREE(char *) serial = NULL; VIR_AUTOFREE(char *) startupPolicy = NULL; VIR_AUTOFREE(char *) tray = NULL; @@ -10126,10 +10095,6 @@ virDomainDiskDefParseXML(virDomainXMLOptionPtr xmlopt, def->src->shared = true; } else if (virXMLNodeNameEqual(cur, "transient")) { def->transient = true; - } else if ((flags & VIR_DOMAIN_DEF_PARSE_STATUS) && - virXMLNodeNameEqual(cur, "state")) { - /* Legacy back-compat. Don't add any more attributes here */ - devaddr = virXMLPropString(cur, "devaddr"); } else if (!encryption && virXMLNodeNameEqual(cur, "encryption")) { /* If we've already parsed <source> and found an <encryption> child, @@ -10314,19 +10279,9 @@ virDomainDiskDefParseXML(virDomainXMLOptionPtr xmlopt, } } - if (devaddr) { - if (virDomainParseLegacyDeviceAddress(devaddr, - &def->info.addr.pci) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to parse devaddr parameter '%s'"), - devaddr); - goto error; - } - def->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI; - } else { - if (virDomainDeviceInfoParseXML(xmlopt, node, &def->info, - flags | VIR_DOMAIN_DEF_PARSE_ALLOW_BOOT) < 0) - goto error; + if (virDomainDeviceInfoParseXML(xmlopt, node, &def->info, + flags | VIR_DOMAIN_DEF_PARSE_ALLOW_BOOT) < 0) { + goto error; } if (startupPolicy) { @@ -11488,7 +11443,6 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, VIR_AUTOFREE(char *) str = NULL; VIR_AUTOFREE(char *) filter = NULL; VIR_AUTOFREE(char *) internal = NULL; - VIR_AUTOFREE(char *) devaddr = NULL; VIR_AUTOFREE(char *) mode = NULL; VIR_AUTOFREE(char *) linkstate = NULL; VIR_AUTOFREE(char *) addrtype = NULL; @@ -11669,10 +11623,6 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, filter = virXMLPropString(cur, "filter"); virHashFree(filterparams); filterparams = virNWFilterParseParamAttributes(cur); - } else if ((flags & VIR_DOMAIN_DEF_PARSE_STATUS) && - virXMLNodeNameEqual(cur, "state")) { - /* Legacy back-compat. Don't add any more attributes here */ - devaddr = virXMLPropString(cur, "devaddr"); } else if (virXMLNodeNameEqual(cur, "boot")) { /* boot is parsed as part of virDomainDeviceInfoParseXML */ } else if (!actual && @@ -11725,20 +11675,10 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, def->mac_generated = true; } - if (devaddr) { - if (virDomainParseLegacyDeviceAddress(devaddr, - &def->info.addr.pci) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to parse devaddr parameter '%s'"), - devaddr); - goto error; - } - def->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI; - } else { - if (virDomainDeviceInfoParseXML(xmlopt, node, &def->info, - flags | VIR_DOMAIN_DEF_PARSE_ALLOW_BOOT - | VIR_DOMAIN_DEF_PARSE_ALLOW_ROM) < 0) - goto error; + if (virDomainDeviceInfoParseXML(xmlopt, node, &def->info, + flags | VIR_DOMAIN_DEF_PARSE_ALLOW_BOOT + | VIR_DOMAIN_DEF_PARSE_ALLOW_ROM) < 0) { + goto error; } if (model != NULL && -- 2.21.0

2 1

[libvirt] [dockerfiles PATCH] Refresh after recent changes to Python handling
by Andrea Bolognani 09 Oct '19

09 Oct '19

The corresponding libvirt-jenkins-ci commit is 1ec59b56598b. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. Plain-text diff below. buildenv-libosinfo-centos-7.zip | Bin 532 -> 546 bytes buildenv-libosinfo-debian-10.zip | Bin 638 -> 646 bytes buildenv-libosinfo-debian-9.zip | Bin 659 -> 666 bytes buildenv-libosinfo-debian-sid.zip | Bin 638 -> 646 bytes buildenv-libosinfo-fedora-29.zip | Bin 507 -> 513 bytes buildenv-libosinfo-fedora-30.zip | Bin 569 -> 575 bytes buildenv-libosinfo-fedora-rawhide.zip | Bin 527 -> 533 bytes buildenv-libosinfo-ubuntu-16.zip | Bin 662 -> 669 bytes buildenv-libosinfo-ubuntu-18.zip | Bin 662 -> 669 bytes buildenv-libvirt-centos-7.zip | Bin 715 -> 729 bytes buildenv-libvirt-debian-10-cross-aarch64.zip | Bin 981 -> 998 bytes buildenv-libvirt-debian-10-cross-armv6l.zip | Bin 976 -> 989 bytes buildenv-libvirt-debian-10-cross-armv7l.zip | Bin 978 -> 993 bytes buildenv-libvirt-debian-10-cross-i686.zip | Bin 977 -> 993 bytes buildenv-libvirt-debian-10-cross-mips.zip | Bin 972 -> 987 bytes buildenv-libvirt-debian-10-cross-mips64el.zip | Bin 984 -> 1000 bytes buildenv-libvirt-debian-10-cross-mipsel.zip | Bin 978 -> 992 bytes buildenv-libvirt-debian-10-cross-ppc64le.zip | Bin 985 -> 999 bytes buildenv-libvirt-debian-10-cross-s390x.zip | Bin 978 -> 991 bytes buildenv-libvirt-debian-10.zip | Bin 868 -> 879 bytes buildenv-libvirt-debian-9-cross-aarch64.zip | Bin 1021 -> 1028 bytes buildenv-libvirt-debian-9-cross-armv6l.zip | Bin 1013 -> 1021 bytes buildenv-libvirt-debian-9-cross-armv7l.zip | Bin 1019 -> 1025 bytes buildenv-libvirt-debian-9-cross-mips.zip | Bin 1008 -> 1020 bytes buildenv-libvirt-debian-9-cross-mips64el.zip | Bin 1024 -> 1032 bytes buildenv-libvirt-debian-9-cross-mipsel.zip | Bin 1015 -> 1023 bytes buildenv-libvirt-debian-9-cross-ppc64le.zip | Bin 1021 -> 1032 bytes buildenv-libvirt-debian-9-cross-s390x.zip | Bin 1015 -> 1022 bytes buildenv-libvirt-debian-9.zip | Bin 901 -> 908 bytes buildenv-libvirt-debian-sid-cross-aarch64.zip | Bin 981 -> 997 bytes buildenv-libvirt-debian-sid-cross-armv6l.zip | Bin 976 -> 989 bytes buildenv-libvirt-debian-sid-cross-armv7l.zip | Bin 978 -> 994 bytes buildenv-libvirt-debian-sid-cross-i686.zip | Bin 980 -> 992 bytes buildenv-libvirt-debian-sid-cross-mips.zip | Bin 975 -> 987 bytes ...denv-libvirt-debian-sid-cross-mips64el.zip | Bin 988 -> 999 bytes buildenv-libvirt-debian-sid-cross-mipsel.zip | Bin 980 -> 992 bytes buildenv-libvirt-debian-sid-cross-ppc64le.zip | Bin 985 -> 1000 bytes buildenv-libvirt-debian-sid-cross-s390x.zip | Bin 978 -> 991 bytes buildenv-libvirt-debian-sid.zip | Bin 868 -> 879 bytes buildenv-libvirt-fedora-29.zip | Bin 731 -> 738 bytes buildenv-libvirt-fedora-30.zip | Bin 854 -> 862 bytes buildenv-libvirt-fedora-rawhide.zip | Bin 752 -> 758 bytes buildenv-libvirt-ubuntu-16.zip | Bin 907 -> 915 bytes buildenv-libvirt-ubuntu-18.zip | Bin 909 -> 916 bytes 44 files changed, 0 insertions(+), 0 deletions(-) diff --git a/buildenv-libosinfo-centos-7.zip b/buildenv-libosinfo-centos-7.zip index fa8131e..4da4c52 100644 --- a/buildenv-libosinfo-centos-7.zip +++ b/buildenv-libosinfo-centos-7.zip @@ -1,6 +1,7 @@ FROM centos:centos7 RUN yum update -y && \ + yum install -y epel-release && \ yum install -y \ autoconf \ automake \ @@ -38,6 +39,7 @@ RUN yum update -y && \ python2-setuptools \ python3 \ python3-pip \ + python3-setuptools \ python36-lxml \ python36-pytest \ python36-requests \ diff --git a/buildenv-libosinfo-debian-10.zip b/buildenv-libosinfo-debian-10.zip index 4650523..e3b9a99 100644 --- a/buildenv-libosinfo-debian-10.zip +++ b/buildenv-libosinfo-debian-10.zip @@ -44,6 +44,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ python3-lxml \ python3-pytest \ python3-requests \ + python3-setuptools \ screen \ strace \ sudo \ diff --git a/buildenv-libosinfo-debian-9.zip b/buildenv-libosinfo-debian-9.zip index 35e894a..47d4c59 100644 --- a/buildenv-libosinfo-debian-9.zip +++ b/buildenv-libosinfo-debian-9.zip @@ -44,6 +44,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ python3-pip \ python3-pytest \ python3-requests \ + python3-setuptools \ screen \ strace \ sudo \ diff --git a/buildenv-libosinfo-debian-sid.zip b/buildenv-libosinfo-debian-sid.zip index 0478a9e..de8128f 100644 --- a/buildenv-libosinfo-debian-sid.zip +++ b/buildenv-libosinfo-debian-sid.zip @@ -44,6 +44,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ python3-lxml \ python3-pytest \ python3-requests \ + python3-setuptools \ screen \ strace \ sudo \ diff --git a/buildenv-libosinfo-fedora-29.zip b/buildenv-libosinfo-fedora-29.zip index 99702c0..a0fbbb2 100644 --- a/buildenv-libosinfo-fedora-29.zip +++ b/buildenv-libosinfo-fedora-29.zip @@ -42,6 +42,7 @@ RUN dnf update -y && \ python3-lxml \ python3-pytest \ python3-requests \ + python3-setuptools \ rpm-build \ screen \ strace \ diff --git a/buildenv-libosinfo-fedora-30.zip b/buildenv-libosinfo-fedora-30.zip index 3dbd85b..fa864d5 100644 --- a/buildenv-libosinfo-fedora-30.zip +++ b/buildenv-libosinfo-fedora-30.zip @@ -54,6 +54,7 @@ RUN dnf update -y && \ python3-lxml \ python3-pytest \ python3-requests \ + python3-setuptools \ rpm-build \ screen \ strace \ diff --git a/buildenv-libosinfo-fedora-rawhide.zip b/buildenv-libosinfo-fedora-rawhide.zip index 7f4c423..45acef2 100644 --- a/buildenv-libosinfo-fedora-rawhide.zip +++ b/buildenv-libosinfo-fedora-rawhide.zip @@ -43,6 +43,7 @@ RUN dnf update -y --nogpgcheck fedora-gpg-keys && \ python3-lxml \ python3-pytest \ python3-requests \ + python3-setuptools \ rpm-build \ screen \ strace \ diff --git a/buildenv-libosinfo-ubuntu-16.zip b/buildenv-libosinfo-ubuntu-16.zip index 0fbfcd1..4e2ef2e 100644 --- a/buildenv-libosinfo-ubuntu-16.zip +++ b/buildenv-libosinfo-ubuntu-16.zip @@ -44,6 +44,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ python3-pip \ python3-pytest \ python3-requests \ + python3-setuptools \ screen \ strace \ sudo \ diff --git a/buildenv-libosinfo-ubuntu-18.zip b/buildenv-libosinfo-ubuntu-18.zip index bb2edd6..fae08fc 100644 --- a/buildenv-libosinfo-ubuntu-18.zip +++ b/buildenv-libosinfo-ubuntu-18.zip @@ -44,6 +44,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ python3-pip \ python3-pytest \ python3-requests \ + python3-setuptools \ screen \ strace \ sudo \ diff --git a/buildenv-libvirt-centos-7.zip b/buildenv-libvirt-centos-7.zip index 871c20b..148a4e5 100644 --- a/buildenv-libvirt-centos-7.zip +++ b/buildenv-libvirt-centos-7.zip @@ -1,6 +1,7 @@ FROM centos:centos7 RUN yum update -y && \ + yum install -y epel-release && \ yum install -y \ audit-libs-devel \ augeas \ @@ -67,7 +68,9 @@ RUN yum update -y && \ pkgconfig \ polkit \ python2-setuptools \ + python3 \ python3-pip \ + python3-setuptools \ qemu-img \ radvd \ readline-devel \ diff --git a/buildenv-libvirt-debian-10-cross-aarch64.zip b/buildenv-libvirt-debian-10-cross-aarch64.zip index 03081da..8783769 100644 --- a/buildenv-libvirt-debian-10-cross-aarch64.zip +++ b/buildenv-libvirt-debian-10-cross-aarch64.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10-cross-armv6l.zip b/buildenv-libvirt-debian-10-cross-armv6l.zip index 53b46b2..2ac1669 100644 --- a/buildenv-libvirt-debian-10-cross-armv6l.zip +++ b/buildenv-libvirt-debian-10-cross-armv6l.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10-cross-armv7l.zip b/buildenv-libvirt-debian-10-cross-armv7l.zip index ab9173f..5f8ef23 100644 --- a/buildenv-libvirt-debian-10-cross-armv7l.zip +++ b/buildenv-libvirt-debian-10-cross-armv7l.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10-cross-i686.zip b/buildenv-libvirt-debian-10-cross-i686.zip index 6c7549a..d31143d 100644 --- a/buildenv-libvirt-debian-10-cross-i686.zip +++ b/buildenv-libvirt-debian-10-cross-i686.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10-cross-mips.zip b/buildenv-libvirt-debian-10-cross-mips.zip index 464dfdd..fc111ce 100644 --- a/buildenv-libvirt-debian-10-cross-mips.zip +++ b/buildenv-libvirt-debian-10-cross-mips.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10-cross-mips64el.zip b/buildenv-libvirt-debian-10-cross-mips64el.zip index 82749e4..0195967 100644 --- a/buildenv-libvirt-debian-10-cross-mips64el.zip +++ b/buildenv-libvirt-debian-10-cross-mips64el.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10-cross-mipsel.zip b/buildenv-libvirt-debian-10-cross-mipsel.zip index 3a3d7bd..bdea106 100644 --- a/buildenv-libvirt-debian-10-cross-mipsel.zip +++ b/buildenv-libvirt-debian-10-cross-mipsel.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10-cross-ppc64le.zip b/buildenv-libvirt-debian-10-cross-ppc64le.zip index 2ad797b..b4c6373 100644 --- a/buildenv-libvirt-debian-10-cross-ppc64le.zip +++ b/buildenv-libvirt-debian-10-cross-ppc64le.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10-cross-s390x.zip b/buildenv-libvirt-debian-10-cross-s390x.zip index 76fed77..b13c921 100644 --- a/buildenv-libvirt-debian-10-cross-s390x.zip +++ b/buildenv-libvirt-debian-10-cross-s390x.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-10.zip b/buildenv-libvirt-debian-10.zip index 253d476..6da9f17 100644 --- a/buildenv-libvirt-debian-10.zip +++ b/buildenv-libvirt-debian-10.zip @@ -78,6 +78,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9-cross-aarch64.zip b/buildenv-libvirt-debian-9-cross-aarch64.zip index 16ad2f1..9d1150c 100644 --- a/buildenv-libvirt-debian-9-cross-aarch64.zip +++ b/buildenv-libvirt-debian-9-cross-aarch64.zip @@ -41,7 +41,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9-cross-armv6l.zip b/buildenv-libvirt-debian-9-cross-armv6l.zip index 5642c86..8bcabc2 100644 --- a/buildenv-libvirt-debian-9-cross-armv6l.zip +++ b/buildenv-libvirt-debian-9-cross-armv6l.zip @@ -41,7 +41,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9-cross-armv7l.zip b/buildenv-libvirt-debian-9-cross-armv7l.zip index 094b155..c4f5e06 100644 --- a/buildenv-libvirt-debian-9-cross-armv7l.zip +++ b/buildenv-libvirt-debian-9-cross-armv7l.zip @@ -41,7 +41,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9-cross-mips.zip b/buildenv-libvirt-debian-9-cross-mips.zip index e9e113a..771e34a 100644 --- a/buildenv-libvirt-debian-9-cross-mips.zip +++ b/buildenv-libvirt-debian-9-cross-mips.zip @@ -41,7 +41,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9-cross-mips64el.zip b/buildenv-libvirt-debian-9-cross-mips64el.zip index 5022ccd..52a6ec3 100644 --- a/buildenv-libvirt-debian-9-cross-mips64el.zip +++ b/buildenv-libvirt-debian-9-cross-mips64el.zip @@ -41,7 +41,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9-cross-mipsel.zip b/buildenv-libvirt-debian-9-cross-mipsel.zip index 5d3eff7..8b3146c 100644 --- a/buildenv-libvirt-debian-9-cross-mipsel.zip +++ b/buildenv-libvirt-debian-9-cross-mipsel.zip @@ -41,7 +41,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9-cross-ppc64le.zip b/buildenv-libvirt-debian-9-cross-ppc64le.zip index 91017a8..6476438 100644 --- a/buildenv-libvirt-debian-9-cross-ppc64le.zip +++ b/buildenv-libvirt-debian-9-cross-ppc64le.zip @@ -41,7 +41,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9-cross-s390x.zip b/buildenv-libvirt-debian-9-cross-s390x.zip index 4f46538..9eebda0 100644 --- a/buildenv-libvirt-debian-9-cross-s390x.zip +++ b/buildenv-libvirt-debian-9-cross-s390x.zip @@ -41,7 +41,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-9.zip b/buildenv-libvirt-debian-9.zip index 03347de..4a20573 100644 --- a/buildenv-libvirt-debian-9.zip +++ b/buildenv-libvirt-debian-9.zip @@ -77,7 +77,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-aarch64.zip b/buildenv-libvirt-debian-sid-cross-aarch64.zip index 2f3a5eb..72d3f19 100644 --- a/buildenv-libvirt-debian-sid-cross-aarch64.zip +++ b/buildenv-libvirt-debian-sid-cross-aarch64.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-armv6l.zip b/buildenv-libvirt-debian-sid-cross-armv6l.zip index 93b93a3..b644daf 100644 --- a/buildenv-libvirt-debian-sid-cross-armv6l.zip +++ b/buildenv-libvirt-debian-sid-cross-armv6l.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-armv7l.zip b/buildenv-libvirt-debian-sid-cross-armv7l.zip index a5f26ed..3620b23 100644 --- a/buildenv-libvirt-debian-sid-cross-armv7l.zip +++ b/buildenv-libvirt-debian-sid-cross-armv7l.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-i686.zip b/buildenv-libvirt-debian-sid-cross-i686.zip index ebf9d9e..4de80e2 100644 --- a/buildenv-libvirt-debian-sid-cross-i686.zip +++ b/buildenv-libvirt-debian-sid-cross-i686.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-mips.zip b/buildenv-libvirt-debian-sid-cross-mips.zip index e354ef7..7ba7296 100644 --- a/buildenv-libvirt-debian-sid-cross-mips.zip +++ b/buildenv-libvirt-debian-sid-cross-mips.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-mips64el.zip b/buildenv-libvirt-debian-sid-cross-mips64el.zip index fdfc3f8..233e30c 100644 --- a/buildenv-libvirt-debian-sid-cross-mips64el.zip +++ b/buildenv-libvirt-debian-sid-cross-mips64el.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-mipsel.zip b/buildenv-libvirt-debian-sid-cross-mipsel.zip index 68b5e06..5fb2ad4 100644 --- a/buildenv-libvirt-debian-sid-cross-mipsel.zip +++ b/buildenv-libvirt-debian-sid-cross-mipsel.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-ppc64le.zip b/buildenv-libvirt-debian-sid-cross-ppc64le.zip index 12efa81..fab8039 100644 --- a/buildenv-libvirt-debian-sid-cross-ppc64le.zip +++ b/buildenv-libvirt-debian-sid-cross-ppc64le.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid-cross-s390x.zip b/buildenv-libvirt-debian-sid-cross-s390x.zip index 7e5fd7e..51afe17 100644 --- a/buildenv-libvirt-debian-sid-cross-s390x.zip +++ b/buildenv-libvirt-debian-sid-cross-s390x.zip @@ -42,6 +42,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-debian-sid.zip b/buildenv-libvirt-debian-sid.zip index 50d700d..b84bbc8 100644 --- a/buildenv-libvirt-debian-sid.zip +++ b/buildenv-libvirt-debian-sid.zip @@ -78,6 +78,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-fedora-29.zip b/buildenv-libvirt-fedora-29.zip index 51b2c94..ada66ea 100644 --- a/buildenv-libvirt-fedora-29.zip +++ b/buildenv-libvirt-fedora-29.zip @@ -71,7 +71,9 @@ RUN dnf update -y && \ perl \ pkgconfig \ polkit \ + python3 \ python3-flake8 \ + python3-setuptools \ qemu-img \ radvd \ readline-devel \ diff --git a/buildenv-libvirt-fedora-30.zip b/buildenv-libvirt-fedora-30.zip index a64c8e3..87a61df 100644 --- a/buildenv-libvirt-fedora-30.zip +++ b/buildenv-libvirt-fedora-30.zip @@ -97,7 +97,9 @@ RUN dnf update -y && \ perl \ pkgconfig \ polkit \ + python3 \ python3-flake8 \ + python3-setuptools \ qemu-img \ radvd \ readline-devel \ diff --git a/buildenv-libvirt-fedora-rawhide.zip b/buildenv-libvirt-fedora-rawhide.zip index ec93dcc..1c1d488 100644 --- a/buildenv-libvirt-fedora-rawhide.zip +++ b/buildenv-libvirt-fedora-rawhide.zip @@ -72,7 +72,9 @@ RUN dnf update -y --nogpgcheck fedora-gpg-keys && \ perl \ pkgconfig \ polkit \ + python3 \ python3-flake8 \ + python3-setuptools \ qemu-img \ radvd \ readline-devel \ diff --git a/buildenv-libvirt-ubuntu-16.zip b/buildenv-libvirt-ubuntu-16.zip index 0c949f7..978ec36 100644 --- a/buildenv-libvirt-ubuntu-16.zip +++ b/buildenv-libvirt-ubuntu-16.zip @@ -78,7 +78,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ diff --git a/buildenv-libvirt-ubuntu-18.zip b/buildenv-libvirt-ubuntu-18.zip index 6a293d7..92e6c8f 100644 --- a/buildenv-libvirt-ubuntu-18.zip +++ b/buildenv-libvirt-ubuntu-18.zip @@ -78,7 +78,9 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ perl \ pkgconf \ policykit-1 \ + python3 \ python3-pip \ + python3-setuptools \ qemu-utils \ radvd \ screen \ -- 2.21.0

1 0

[libvirt] [jenkins-ci PATCH] guests: Install EPEL on CentOS 7 container
by Fabiano Fidêncio 09 Oct '19

09 Oct '19

Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to have both "ninja" and "python36-*" packages in the system. However, we've forgot to add the very code to the lcitool so the containers would also have EPEL release installed. Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- guests/lcitool | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/guests/lcitool b/guests/lcitool index a3ef137..0d11d37 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -714,6 +714,14 @@ class Application: {package_manager} autoremove -y && \\ {package_manager} clean all -y """).format(**varmap)) + else if os_name == "CentOS" and os_version == "7": + sys.stdout.write(textwrap.dedent(""" + RUN {package_manager} update -y && \\ + {package_manager} install -y epel-release && \\ + {package_manager} install -y {pkgs} && \\ + {package_manager} autoremove -y && \\ + {package_manager} clean all -y + """).format(**varmap)) else: sys.stdout.write(textwrap.dedent(""" RUN {package_manager} update -y && \\ -- 2.23.0

3 3

[libvirt] [jenkins-ci PATCH 0/3] Add python3 & python3-setup tools to the base project
by Fabiano Fidêncio 09 Oct '19

09 Oct '19

The former can be added to tbe base project as a direct or indirect dependency of the most part of the projects in libvirt-jenkins-ci. The latter is needed in order to use pip module for ansible, which is used to install meson in platforms where it's either not supported or doesn't match the minimum required version. Fabiano Fidêncio (3): guests: Move python3 to the base project mappings: Add python3-setuptools guests: Add python3-setuptools to the base project guests/vars/mappings.yml | 4 ++++ guests/vars/projects/base.yml | 2 ++ guests/vars/projects/libvirt-dbus.yml | 1 - guests/vars/projects/libvirt-python.yml | 1 - guests/vars/projects/osinfo-db-tools.yml | 1 - guests/vars/projects/osinfo-db.yml | 1 - guests/vars/projects/virt-manager.yml | 1 - 7 files changed, 6 insertions(+), 5 deletions(-) -- 2.23.0

2 4

[libvirt] Update the release note of released version
by Han Han 09 Oct '19

09 Oct '19

Hi, Although libvirt-5.8 is released, however some features or improvement like "slirp helper process" are missing in release note now. Can I update the news.xml even after v5.8 ? -- Best regards, ----------------------------------- Han Han Quality Engineer Redhat. Email: hhan(a)redhat.com Phone: +861065339333

3 2

[libvirt] [PATCH 0/7] security: apparmor: prep for qcow2 data_file
by Cole Robinson 09 Oct '19

09 Oct '19

This series does some preparation cleanup and refactoring to simplify adding qcow2 data_file support to the apparmor driver. More info on the qcow2 feature and libvirt work here: https://www.redhat.com/archives/libvir-list/2019-October/msg00303.html Cole Robinson (7): conf: Move -virDomainDiskDefForeachPath to virt-aa-helper security: apparmor: Remove unused ignoreOpenFailure security: apparmor: Drop disk_foreach_iterator security: apparmor: Pass virStorageSource to add_file_path security: apparmor: Push virStorageSource checks to add_file_path security: apparmor: Use only virStorageSource for disk paths security: apparmor: Make storage_source_add_files recursively callable src/conf/domain_conf.c | 42 ---------------------------------- src/conf/domain_conf.h | 10 -------- src/libvirt_private.syms | 1 - src/security/virt-aa-helper.c | 43 ++++++++++++++++++++++++----------- 4 files changed, 30 insertions(+), 66 deletions(-) -- 2.23.0

2 10