- Devel - libvirt List Archives

[libvirt] [jenkins-ci PATCH] guests: add glib2 as a package dependency for libvirt
by Daniel P. Berrangé 07 Oct '19

07 Oct '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/projects/libvirt+mingw32.yml | 1 + guests/vars/projects/libvirt+mingw64.yml | 1 + guests/vars/projects/libvirt.yml | 1 + 3 files changed, 3 insertions(+) diff --git a/guests/vars/projects/libvirt+mingw32.yml b/guests/vars/projects/libvirt+mingw32.yml index 2fc6603..444eb2b 100644 --- a/guests/vars/projects/libvirt+mingw32.yml +++ b/guests/vars/projects/libvirt+mingw32.yml @@ -5,6 +5,7 @@ packages: - mingw32-dlfcn - mingw32-gcc - mingw32-gettext + - mingw32-glib2 - mingw32-gnutls - mingw32-libssh2 - mingw32-libxml2 diff --git a/guests/vars/projects/libvirt+mingw64.yml b/guests/vars/projects/libvirt+mingw64.yml index 615ecec..1de4995 100644 --- a/guests/vars/projects/libvirt+mingw64.yml +++ b/guests/vars/projects/libvirt+mingw64.yml @@ -5,6 +5,7 @@ packages: - mingw64-dlfcn - mingw64-gcc - mingw64-gettext + - mingw64-glib2 - mingw64-gnutls - mingw64-libssh2 - mingw64-libxml2 diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index 688dfa3..04c3ecd 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -10,6 +10,7 @@ packages: - dwarves - ebtables - fuse + - glib2 - glusterfs - gnutls - hal -- 2.21.0

2 1

[libvirt] -blockdev bug (and some questions)
by Cole Robinson 07 Oct '19

07 Oct '19

Hi Peter + list, I'm testing libvirt -blockdev, using your enablement patches from here: https://www.redhat.com/archives/libvir-list/2019-September/msg00524.html I'm hitting an issue but the fix isn't clear to me. Take a VM with standard disk XML, using a qcow2 image with a backing file <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/OVERLAY.qcow2'/> <target dev='vda' bus='virtio'/> </disk> The VM starts fine, generated -blockdev options are: -blockdev '{"driver":"file","filename":"/BACKING.qcow2","node-name":"libvirt-2-storage","auto-read-only":true,"discard":"unmap"}' \ -blockdev '{"node-name":"libvirt-2-format","read-only":true,"driver":"qcow2","file":"libvirt-2-storage","backing":null}' \ -blockdev '{"driver":"file","filename":"/OVERLAY.qcow2","node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ -blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"qcow2","file":"libvirt-1-storage","backing":"libvirt-2-format"}' \ Stop the VM. Edit the disk XML to have a single stub <backingStore/> element: <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/OVERLAY.qcow2'/> <backingStore/> <target dev='vda' bus='virtio'/> </disk> (FWIW my VM just happened to have this element in the XML, not sure where it came from, maybe some wayward XML edit at some point) Start the VM. It starts, but it's not using the backing file, so things don't really work. The generate -blockdev bits are: -blockdev '{"driver":"file","filename":"/OVERLAY.qcow2","node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ -blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"qcow2","file":"libvirt-1-storage","backing":null}' \ This all works correctly with non-blockdev master. The difference comes from this code in qemuProcessPrepareHostStorage: /* backing chain needs to be redetected if we aren't using blockdev */ if (!blockdev) virStorageSourceBackingStoreClear(disk->src); The <backingStore/> causes a disk->src->backingStore to be allocated by the domain_conf XML parser. On git master it is removed here. Later in qemuDomainDetermineDiskChain, it basically only probes the root image file if !disk->src->backingStore. Since the blockdev case doesn't call BackingStoreClear, the root image file is never probed in qemuDomainDetermineDiskChain, which causes the differing behavior. Do you have a suggestion for a proper fix? I can try implementing it if you'd like, it will help me better understand this stuff. More generally I have questions about why we track backingStore in the XML for an offline VM anyways? I presume this is intentional, but I don't understand the usecases. Can you provide more info or link me to somewhere if this has been discussed before? FWIW the XML docs claim backingStore is output only, but seems to contradict itself in the next sentence, and they aren't helping me much to understand the big picture: https://libvirt.org/formatdomain.html#elementsDisks Thanks, Cole

2 3

[libvirt] [PATCH] qemu: add pointer check in qemuMonitorLastError
by Xu Yandong 07 Oct '19

07 Oct '19

We found a exception when libvirt occurrs segmentation fault. thread 1 is waiting object lock in qemuConnectMonitor, qemu process exits and sends EOF event as well, so thread 2 invokes qemuMonitorLastError but pointer mon is NULL. Signed-off-by: Xu Yandong <xuyandong2(a)huawei.com> --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index aa230b3306..28f18391a5 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1103,7 +1103,7 @@ qemuMonitorSend(qemuMonitorPtr mon, virErrorPtr qemuMonitorLastError(qemuMonitorPtr mon) { - if (mon->lastError.code == VIR_ERR_OK) + if (!mon || mon->lastError.code == VIR_ERR_OK) return NULL; return virErrorCopyNew(&mon->lastError); -- 2.18.1

3 2

[libvirt] [PATCH] build: ask for -std=gnu99 explicitly
by Daniel P. Berrangé 07 Oct '19

07 Oct '19

We previously got -std=gnu99 secretly enabled as a side-effect of requesting the 'stdarg' gnulib module. We rely on some extensions from c99/gnu99 and while RHEL-7 supports this, it still defaults to gnu89. RHEL-7 also supports some newer standards but declares them experimental/incomplete, so sticking with gnu99 is best bet for now & matches historical usage. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- m4/virt-compile-warnings.m4 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index f9460e82ba..502f7384ff 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -189,6 +189,10 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ wantwarn="$wantwarn -Werror" fi + # Request the gnu99 standard which is the best choice with + # gcc 4.8.0 + wantwarn="-std=gnu99" + # Check for $CC support of each warning for w in $wantwarn; do gl_WARN_ADD([$w]) -- 2.21.0

3 4

[libvirt] [PATCH 0/4] build: take full ownership of syntax-check from gnulib
by Daniel P. Berrangé 07 Oct '19

07 Oct '19

Our syntax-check rule relies in various files imported during the gnulib bootstrap process. As we switch to meson & try to eliminate gnulib, we need to take ownership of syntax-check. This patch series follows the approach taken for libosinfo & other projects wrt syntax-check rules, but goes a step further and eliminates alot of baggage we don't care about & merges all logic into one file. Daniel P. Berrangé (4): build: import gnulib's syntax-check make rules build: remove all logic unrelated to syntax-check build: delete all syntax check rules we're skipping build: merge all syntax-check logic into one file Makefile.am | 7 +- bootstrap.conf | 4 - cfg.mk => build-aux/syntax-check.mk | 1141 +++++++++++++++++++++++++-- build-aux/useless-if-before-free | 226 ++++++ build-aux/vc-list-files | 113 +++ 5 files changed, 1411 insertions(+), 80 deletions(-) rename cfg.mk => build-aux/syntax-check.mk (52%) create mode 100755 build-aux/useless-if-before-free create mode 100755 build-aux/vc-list-files -- 2.21.0

2 8

[libvirt] [PATCH] build: force -Werror for distcheck target
by Daniel P. Berrangé 07 Oct '19

07 Oct '19

The 'make distcheck' target validates that a tarball builds and is ready for release. We expect that libvirt builds cleanly on all supported platforms, so we should be enabling -Werror when running distcheck. This ensures that our CI systems in turn also use -Werror. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile.am b/Makefile.am index 2cc4b91f9c..1a9f3af66d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -19,6 +19,10 @@ LCOV = lcov GENHTML = genhtml +# when building from tarball -Werror isn't auto enabled +# so force it explicitly +DISTCHECK_CONFIGURE_FLAGS = --enable-werror + SUBDIRS = . gnulib/lib include/libvirt src tools docs gnulib/tests \ tests po examples -- 2.21.0

2 1

[libvirt] [PATCH 1/1] qemu_command: tidy up qemuBuildHostdevCommandLine loop
by Daniel Henrique Barboza 07 Oct '19

07 Oct '19

The current 'for' loop with 5 consecutive 'ifs' inside qemuBuildHostdevCommandLine can be a bit smarter: - all 5 'ifs' fails if hostdev->mode is not equal to VIR_DOMAIN_HOSTDEV_MODE_SUBSYS. This check can be moved to the start of the loop, failing to the next element immediately in case it fails; - all 5 'ifs' checks for a specific subsys->type to build the proper command line argument (virHostdevIsSCSIDevice and virHostdevIsMdevDevice do that but within a helper). Problem is that the code will keep checking for matches even if one was already found, and there is no way a hostdev will fit more than one 'if' (i.e. a hostdev can't have 2+ different types). This means that a SUBSYS_TYPE_USB will create its command line argument in the first 'if', then all other conditionals will surely fail but will end up being checked anyway. This can be avoided by adding 'continue' statements inside the first 4 conditionals. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- Arguably safe for freeze since it's trivial, but not a deal breaker if postponed. I am fine with both. src/qemu/qemu_command.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 8c979fdf65..0357481dd1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5471,20 +5471,23 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd, virDomainHostdevSubsysPtr subsys = &hostdev->source.subsys; VIR_AUTOFREE(char *) devstr = NULL; + if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) + continue; + /* USB */ - if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && - subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) { + if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) { virCommandAddArg(cmd, "-device"); if (!(devstr = qemuBuildUSBHostdevDevStr(def, hostdev, qemuCaps))) return -1; virCommandAddArg(cmd, devstr); + + continue; } /* PCI */ - if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && - subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { + if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { int backend = subsys->u.pci.backend; if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) { @@ -5514,6 +5517,8 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd, if (!devstr) return -1; virCommandAddArg(cmd, devstr); + + continue; } /* SCSI */ @@ -5543,11 +5548,12 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd, if (!(devstr = qemuBuildSCSIHostdevDevStr(def, hostdev))) return -1; virCommandAddArg(cmd, devstr); + + continue; } /* SCSI_host */ - if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && - subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST) { + if (subsys->type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST) { if (hostdev->source.subsys.u.scsi_host.protocol == VIR_DOMAIN_HOSTDEV_SUBSYS_SCSI_HOST_PROTOCOL_TYPE_VHOST) { VIR_AUTOFREE(char *) vhostfdName = NULL; @@ -5573,6 +5579,8 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd, virCommandAddArg(cmd, devstr); } + + continue; } /* MDEV */ -- 2.21.0

2 1

[libvirt] [PATCH v2 0/1] virsh: fixed handling of sourceless disks in 'domblkinfo' cmd
by Pavel Mores 07 Oct '19

07 Oct '19

Integrating feedback to the original version. This changes the approach to fixing the problem - previously, we called virDomainGetBlockInfo() and if it failed, we mitigated the failure for CDROMs and floppies specifically. Now we first check for existence of a <source> element in the corresponding XML and if we find none, we avoid calling virDomainGetBlockInfo() altogether as we know it's bound to fail in that case. The benefit is that whereas the previous fix swallowed all errors concerning CDROMs and floppies - not just missing <source> - this one only handles missing <source> specifically and doesn't mask other problems that might come up. The patch itself is fairly simple, unfortunately some noise is caused by additional indentation of code related to the virDomainGetBlockInfo() call. That code should however be unchanged (apart from reformating a comment to keep line lengths under 80 chars). Pavel Mores (1): fixed handling of sourceless disks in 'domblkinfo' cmd tools/virsh-domain-monitor.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) -- 2.21.0

2 2

[libvirt] [PATCH 0/5] build: eliminate more redundant/obsolete gnulib modules
by Daniel P. Berrangé 07 Oct '19

07 Oct '19

A follow up to my previous series that was already pushed. This identifies some more unused modules, or things that are easily replaced. Daniel P. Berrangé (5): build: remove all gnulib bit manipulation modules build: drop the ignore-value gnulib module build: drop the ldexp gnulib module build: drop the isatty gnulib module build: remove the sched gnulib module bootstrap.conf | 9 --------- src/conf/capabilities.c | 3 +-- src/conf/domain_conf.c | 1 - src/conf/snapshot_conf.c | 1 - src/internal.h | 18 +++++++++++++++--- src/libxl/xen_common.c | 1 - src/util/Makefile.inc.am | 1 + src/util/virbitmap.c | 7 +++---- src/util/vircgroupv2.c | 2 +- src/util/virhashcode.c | 6 +++++- src/util/virhostcpu.c | 1 - src/util/virhostmem.c | 1 - src/util/virrandom.c | 4 +--- tools/vsh.c | 2 +- 14 files changed, 28 insertions(+), 29 deletions(-) -- 2.21.0

2 6

[libvirt] [PATCH] qemu: capabilities: Fill in bochs-display info
by Fabiano Fidêncio 07 Oct '19

07 Oct '19

086c19d69 added bochs-display capability but didn't fill in the info for domain capabilities. Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- src/qemu/qemu_capabilities.c | 2 ++ tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml | 1 + 5 files changed, 6 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 3b50576a2b..d0b789bbea 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5357,6 +5357,8 @@ virQEMUCapsFillDomainDeviceVideoCaps(virQEMUCapsPtr qemuCaps, VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_QXL); if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU)) VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_VIRTIO); + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_BOCHS_DISPLAY)) + VIR_DOMAIN_CAPS_ENUM_SET(dev->modelType, VIR_DOMAIN_VIDEO_TYPE_BOCHS); return 0; } diff --git a/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml b/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml index 402848442f..059403cebc 100644 --- a/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml +++ b/tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml @@ -127,6 +127,7 @@ <value>vmvga</value> <value>qxl</value> <value>virtio</value> + <value>bochs</value> </enum> </video> <hostdev supported='yes'> diff --git a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml index 1ffd5e3cc0..eb24b9a604 100644 --- a/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml +++ b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml @@ -127,6 +127,7 @@ <value>vmvga</value> <value>qxl</value> <value>virtio</value> + <value>bochs</value> </enum> </video> <hostdev supported='yes'> diff --git a/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml index 79b41ef6da..f5685d2068 100644 --- a/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml +++ b/tests/domaincapsschemadata/qemu_4.1.0.x86_64.xml @@ -131,6 +131,7 @@ <value>vmvga</value> <value>qxl</value> <value>virtio</value> + <value>bochs</value> </enum> </video> <hostdev supported='yes'> diff --git a/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml b/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml index 6bdeb20479..5bd376bb2e 100644 --- a/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml +++ b/tests/domaincapsschemadata/qemu_4.2.0.x86_64.xml @@ -131,6 +131,7 @@ <value>vmvga</value> <value>qxl</value> <value>virtio</value> + <value>bochs</value> </enum> </video> <hostdev supported='yes'> -- 2.23.0

4 3