- Devel - libvirt List Archives

[libvirt] Plans for next release
by Daniel Veillard 27 Aug '19

27 Aug '19

With the end of month coming soon, time to plan for next release, I suggest to enter freeze tomorrow wed 28, the have an RC2 on Friday and if everything looks good next Monday we can push 5.7.0 Hope this works for everybody, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] apparmor: Allow to run pygrup
by Guido Günther 27 Aug '19

27 Aug '19

Debian has pygrub in /usr/lib/xen-*/bin/pygrub Allow it to be run. --- I'm open to making this more broad since it seems /usr/{lib,lib64}/xen/bin/* Ux, serves a similar purpose. Cheers, -- Guido src/security/apparmor/usr.sbin.libvirtd | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/apparmor/usr.sbin.libvirtd b/src/security/apparmor/usr.sbin.libvirtd index 29f9936ad9..f9a523c213 100644 --- a/src/security/apparmor/usr.sbin.libvirtd +++ b/src/security/apparmor/usr.sbin.libvirtd @@ -87,6 +87,7 @@ profile libvirtd /usr/sbin/libvirtd flags=(attach_disconnected) { /usr/{lib,lib64}/xen-common/bin/xen-toolstack PUx, /usr/{lib,lib64}/xen/bin/* Ux, /usr/lib/xen-*/bin/libxl-save-helper PUx, + /usr/lib/xen-*/bin/pygrub PUx, # Required by nwfilter_ebiptables_driver.c:ebiptablesWriteToTempFile() to # read and run an ebtables script. -- 2.20.1

2 1

[libvirt] [PATCH 0/2] qemu: Couple of cleanups after qemuDomainGetGuestInfo
by Michal Privoznik 27 Aug '19

27 Aug '19

*** BLURB HERE *** Michal Prívozník (2): qemu: Acquire domain job in qemuDomainGetFSInfo and qemuDomainGetGuestInfo qemu: Don't duplicate domain def in qemuDomainGetFSInfo src/qemu/qemu_driver.c | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) -- 2.21.0

2 3

[libvirt] [PATCH 0/4] remote: better handle system activation and upgrades
by Daniel P. Berrangé 27 Aug '19

27 Aug '19

This improves the upgrade path to systemd socket activation - Disable socket activation in RPM %post if we see use of --listen arg on existing install - Report fatal error if --listen is used with socket activation, since it is not honoured Daniel P. Berrangé (4): remote: use Wants instead of Requires for libvirtd sockets remote: move timeout arg into sysconf file remote: forbid the --listen arg when systemd socket activation rpm: don't enable socket activation in upgrade if --listen present libvirt.spec.in | 44 ++++++++++++++++++++++++---------- src/remote/libvirtd.pod | 33 ++++++++++++++++++++++++- src/remote/libvirtd.service.in | 15 ++++++------ src/remote/libvirtd.sysconf | 12 +++++++--- src/remote/remote_daemon.c | 7 ++++++ 5 files changed, 86 insertions(+), 25 deletions(-) -- 2.21.0

2 10

[libvirt] [jenkins-ci PATCH 0/7] Switch osinfo-db-tools to Meson
by Fabiano Fidêncio 27 Aug '19

27 Aug '19

This patch series switches osinfo-db-tools to using meson instead of autotools. In order to do so, meson build jobs had to be added as the first step. I've tried to make the osinfo-db-tools changes as small as possible so it'd make the review easier. Fabiano Fidêncio (7): jobs: add a template for Meson guests: Add Meson jobs mappings: Add meson osinfo-db-tools: Add meson dependency Only build osinfo-db-tools on systems with meson >= 0.49.0 Update osinfo-db-tools' archive_format Switch osinfo-db-tools builds to Meson guests/host_vars/libvirt-centos-7/main.yml | 1 - guests/host_vars/libvirt-debian-9/main.yml | 1 - guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - guests/host_vars/libvirt-ubuntu-18/main.yml | 1 - guests/playbooks/build/jobs/defaults.yml | 3 + .../playbooks/build/jobs/meson-build-job.yml | 14 ++ .../playbooks/build/jobs/meson-check-job.yml | 15 ++ guests/playbooks/build/jobs/meson-rpm-job.yml | 15 ++ .../build/jobs/meson-syntax-check-job.yml | 11 ++ .../projects/osinfo-db-tools+mingw32.yml | 6 +- .../projects/osinfo-db-tools+mingw64.yml | 6 +- .../build/projects/osinfo-db-tools.yml | 24 +-- guests/vars/mappings.yml | 3 + .../vars/projects/osinfo-db-tools+mingw32.yml | 1 + .../vars/projects/osinfo-db-tools+mingw64.yml | 1 + guests/vars/projects/osinfo-db-tools.yml | 1 + jenkins/jobs/defaults.yaml | 3 + jenkins/jobs/meson.yaml | 174 ++++++++++++++++++ jenkins/projects/osinfo-db-tools+mingw32.yaml | 6 +- jenkins/projects/osinfo-db-tools+mingw64.yaml | 6 +- jenkins/projects/osinfo-db-tools.yaml | 30 ++- 21 files changed, 277 insertions(+), 46 deletions(-) create mode 100644 guests/playbooks/build/jobs/meson-build-job.yml create mode 100644 guests/playbooks/build/jobs/meson-check-job.yml create mode 100644 guests/playbooks/build/jobs/meson-rpm-job.yml create mode 100644 guests/playbooks/build/jobs/meson-syntax-check-job.yml create mode 100644 jenkins/jobs/meson.yaml -- 2.21.0

2 16

[libvirt] [PATCH] tools: console: Relax stream EOF handling
by Roman Bolshakov 26 Aug '19

26 Aug '19

An attempt to poweroff a VM from inside triggers the error for existing session of virsh console and it returns with non-zero exit code: error: internal error: console stream EOF The message and status code are misleading because there's no real error. Fixes: 29f2b5248c6 ("tools: console: pass stream/fd errors to user") Signed-off-by: Roman Bolshakov <r.bolshakov(a)yadro.com> --- tools/virsh-console.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/virsh-console.c b/tools/virsh-console.c index e16f841e57..408a745b0f 100644 --- a/tools/virsh-console.c +++ b/tools/virsh-console.c @@ -172,10 +172,6 @@ virConsoleEventOnStream(virStreamPtr st, if (got == -2) goto cleanup; /* blocking */ if (got <= 0) { - if (got == 0) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("console stream EOF")); - virConsoleShutdown(con); goto cleanup; } -- 2.22.0

3 4

[libvirt] [PATCH 00/19] qemu_command: use more of VIR_AUTO*
by Ján Tomko 26 Aug '19

26 Aug '19

Ján Tomko (19): qemuBuildSerialChrDeviceStr: rename cmd to buf qemuBuildNumaArgStr: split variable declarations qemuBuildHotpluggableCPUProps: use VIR_RETURN_PTR qemuxml2xmltest: switch TPM tests to use latest caps qemu: move TPM vaildation to qemuDomainDeviceDefValidateTPM qemuBuildTPMBackendStr: format device and alias separately qemu_command: switch to VIR_AUTOCLEAN for virBuffer qemu_command: use VIR_AUTOPTR for virJSONValue qemu_command: use VIR_AUTOFREE for variables used once qemuBuildNetworkDriveURI: use VIR_AUTOPTR for virURI qemuBuildControllersByTypeCommandLine: use VIR_AUTOFREE qemuBuildRNGCommandLine: use VIR_AUTOFREE qemuBuildSmpCommandLine: use virCommandAddArgBuffer directly qemuBuildShmemCommandLine: add chardev variable qemuBuildShmemCommandLine: use VIR_AUTOFREE for devstr qemu_command: use VIR_AUTOUNREF qemu_command: remove unnecessary labels and ret variables qemuBuildCommandLine: use VIR_AUTO* qemuBuildCommandLine: remove unnecessary error label src/qemu/qemu_command.c | 1388 ++++++----------- src/qemu/qemu_domain.c | 29 +- ...> tpm-emulator-tpm2-enc.x86_64-latest.xml} | 4 +- ...ml => tpm-emulator-tpm2.x86_64-latest.xml} | 4 +- ...tor.xml => tpm-emulator.x86_64-latest.xml} | 4 +- ... => tpm-passthrough-crb.x86_64-latest.xml} | 4 +- ....xml => tpm-passthrough.x86_64-latest.xml} | 4 +- tests/qemuxml2xmltest.c | 10 +- 8 files changed, 545 insertions(+), 902 deletions(-) rename tests/qemuxml2xmloutdata/{tpm-emulator-tpm2-enc.xml => tpm-emulator-tpm2-enc.x86_64-latest.xml} (89%) rename tests/qemuxml2xmloutdata/{tpm-emulator-tpm2.xml => tpm-emulator-tpm2.x86_64-latest.xml} (89%) rename tests/qemuxml2xmloutdata/{tpm-emulator.xml => tpm-emulator.x86_64-latest.xml} (89%) rename tests/qemuxml2xmloutdata/{tpm-passthrough-crb.xml => tpm-passthrough-crb.x86_64-latest.xml} (89%) rename tests/qemuxml2xmloutdata/{tpm-passthrough.xml => tpm-passthrough.x86_64-latest.xml} (89%) -- 2.19.2

2 27

[libvirt] [PATCH] api: fix typo in virDomainGetGuestInfo docs
by Ján Tomko 26 Aug '19

26 Aug '19

s/strign/string/ Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 704754ac15..cea4d2c11b 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12224,7 +12224,7 @@ virDomainSetVcpu(virDomainPtr domain, * The reported data depends on the guest agent implementation. The information * is returned as an array of typed parameters containing the individual * parameters. The parameter name for each information field consists of a - * dot-separated strign containing the name of the requested group followed by + * dot-separated string containing the name of the requested group followed by * a group-specific description of the statistic value. * * The information groups are enabled using the @types parameter which is a -- 2.20.1

1 0

[libvirt] [RFC PATCH 0/2] qemu: Enable -blockdev [READ ME!] (blockdev-add saga finale?)
by Peter Krempa 26 Aug '19

26 Aug '19

With the patches I've posted to the list libvirt should be mostly prepared to use -blockdev instead of -drive to specify disk images. There's one gothcha though. Internal snapshots don't work due to qemu considering every monitor-owned node for snapshot as well. With blockdev everything became monitor-owned including the 'file' nodes which are definitely not snapshottable. Even when qemu fixes that bug I don't think it will be introspectable. Our options are either to wait for the qemu fix and then try to detect it somehow, perhaps as a version check (yuck), or go ahead and inform users to upgrade to a newer qemu afterwards. Any other ideas or suggestions? Peter Krempa (2): qemu: caps: Add capability for dynamic 'auto-read-only' support for files qemu: enable blockdev support src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + .../caps_4.1.0.x86_64.xml | 2 + .../controller-virtio-scsi.x86_64-latest.args | 35 +++-- .../disk-aio.x86_64-latest.args | 19 ++- ...-backing-chains-noindex.x86_64-latest.args | 145 +++++++++++++++--- .../disk-cache.x86_64-latest.args | 50 ++++-- .../disk-cdrom-network.x86_64-latest.args | 32 ++-- .../disk-cdrom-tray.x86_64-latest.args | 24 ++- .../disk-cdrom.x86_64-latest.args | 21 +-- .../disk-copy_on_read.x86_64-latest.args | 19 ++- .../disk-detect-zeroes.x86_64-latest.args | 17 +- .../disk-error-policy.x86_64-latest.args | 30 ++-- .../disk-floppy-q35-2_11.x86_64-latest.args | 14 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 14 +- .../disk-floppy.x86_64-latest.args | 21 ++- .../disk-network-gluster.x86_64-latest.args | 32 ++-- .../disk-network-iscsi.x86_64-latest.args | 58 ++++--- .../disk-network-nbd.x86_64-latest.args | 41 +++-- .../disk-network-rbd.x86_64-latest.args | 67 +++++--- .../disk-network-sheepdog.x86_64-latest.args | 16 +- ...isk-network-source-auth.x86_64-latest.args | 30 ++-- .../disk-network-tlsx509.x86_64-latest.args | 64 +++++--- .../disk-readonly-disk.x86_64-latest.args | 14 +- .../disk-scsi-device-auto.x86_64-latest.args | 14 +- .../disk-scsi.x86_64-latest.args | 35 +++-- .../disk-shared.x86_64-latest.args | 36 +++-- ...irtio-scsi-reservations.x86_64-latest.args | 20 ++- .../floppy-drive-fat.x86_64-latest.args | 7 +- ...egl-headless-rendernode.x86_64-latest.args | 7 +- .../graphics-egl-headless.x86_64-latest.args | 7 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 25 ++- ...y-hotplug-nvdimm-access.x86_64-latest.args | 7 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 7 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 7 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 7 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 7 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 7 +- ...eo-bochs-display-device.x86_64-latest.args | 10 +- ...virtio-non-transitional.x86_64-latest.args | 7 +- .../virtio-transitional.x86_64-latest.args | 7 +- .../x86_64-pc-graphics.x86_64-latest.args | 8 +- .../x86_64-pc-headless.x86_64-latest.args | 8 +- .../x86_64-q35-graphics.x86_64-latest.args | 8 +- .../x86_64-q35-headless.x86_64-latest.args | 8 +- 45 files changed, 714 insertions(+), 306 deletions(-) -- 2.21.0

2 4

[libvirt] [PATCH 00/10] qemu: Blockdevize external snapshot creation (blokcdev-add saga)
by Peter Krempa 26 Aug '19

26 Aug '19

Peter Krempa (10): qemu: snapshot: Don't modify persistent XML if disk source is different qemu: driver: Remove dead code from qemuDomainSnapshotUpdateDiskSources qemu: Remove cleanup label in qemuDomainSnapshotPrepareDiskExternal qemu: snapshot: Restrict file existance check only for local storage qemu: Split out preparing of single snapshot from qemuDomainSnapshotDiskDataCollect qemu: Disband qemuDomainSnapshotCreateSingleDiskActive qemu: Merge conditions depending on the 'reuse' flag in qemuDomainSnapshotDiskDataCollectOne qemu: snapshot: Skip overlay file creation/interogation if unsupported qemu: Add -blockdev support for external snapshots qemu: Defer support checks for external active snapshots to blockdev code or qemu src/qemu/qemu_driver.c | 333 ++++++++++++++++++++++++++--------------- 1 file changed, 210 insertions(+), 123 deletions(-) -- 2.21.0

2 20