- Devel - libvirt List Archives

[libvirt] [PATCH v2] docs: Harmonize hypervisor names for QEMU and LXC
by Michael Weiser 10 Jan '20

10 Jan '20

Trivially replace usages of qemu and lxc in the virsh manpage with their more heavily used and (according to Wikipedia) correct upper-case spellings QEMU and LXC. Signed-off-by: Michael Weiser <michael.weiser(a)gmx.de> Suggested-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- docs/manpages/virsh.rst | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index fea0527caf..26f08b7701 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -577,7 +577,7 @@ from the domain's XML <os/> element and <type/> subelement or one from a list of machines from the ``virsh capabilities`` output for a specific architecture and domain type. -For the qemu hypervisor, a *virttype* of either 'qemu' or 'kvm' must be +For the QEMU hypervisor, a *virttype* of either 'qemu' or 'kvm' must be supplied along with either the *emulatorbin* or *arch* in order to generate output for the default *machine*. Supplying a *machine* value will generate output for the specific machine. @@ -1072,7 +1072,7 @@ read I/O operations limit. write I/O operations limit. *--size-iops-sec* specifies size I/O operations limit per second. *--group-name* specifies group name to share I/O quota between multiple drives. -For a qemu domain, if no name is provided, then the default is to have a single +For a QEMU domain, if no name is provided, then the default is to have a single group for each *device*. Older versions of virsh only accepted these options with underscore @@ -1084,7 +1084,7 @@ An explicit 0 also clears any limit. A non-zero value for a given total cannot be mixed with non-zero values for read or write. It is up to the hypervisor to determine how to handle the length values. -For the qemu hypervisor, if an I/O limit value or maximum value is set, +For the QEMU hypervisor, if an I/O limit value or maximum value is set, then the default value of 1 second will be displayed. Supplying a 0 will reset the value back to the default. @@ -1211,7 +1211,7 @@ to a unique target name (<target dev='name'/>) or source file (<source file='name'/>) for one of the disk devices attached to *domain* (see also ``domblklist`` for listing these names). *bandwidth* specifies copying bandwidth limit in MiB/s, although for -qemu, it may be non-zero only for an online domain. For further information +QEMU, it may be non-zero only for an online domain. For further information on the *bandwidth* argument see the corresponding section for the ``blockjob`` command. @@ -1642,7 +1642,7 @@ domblkstat Get device block stats for a running domain. A *block-device* corresponds to a unique target name (<target dev='name'/>) or source file (<source file='name'/>) for one of the disk devices attached to *domain* (see -also ``domblklist`` for listing these names). On a lxc or qemu domain, +also ``domblklist`` for listing these names). On a LXC or QEMU domain, omitting the *block-device* yields device block stats summarily for the entire domain. @@ -3247,7 +3247,7 @@ destination). Some hypervisors do not support this feature and will return an error if this parameter is used. Optional *disks-port* sets the port that hypervisor on destination side should -bind to for incoming disks traffic. Currently it is supported only by qemu. +bind to for incoming disks traffic. Currently it is supported only by QEMU. migrate-compcache @@ -7438,7 +7438,7 @@ qemu-monitor-command qemu-monitor-command domain { [--hmp] | [--pretty] } command... Send an arbitrary monitor command *command* to domain *domain* through the -qemu monitor. The results of the command will be printed on stdout. If +QEMU monitor. The results of the command will be printed on stdout. If *--hmp* is passed, the command is considered to be a human monitor command and libvirt will automatically convert it into QMP if needed. In that case the result will also be converted back from QMP. If *--pretty* is given, @@ -7457,7 +7457,7 @@ qemu-agent-command qemu-agent-command domain [--timeout seconds | --async | --block] command... Send an arbitrary guest agent command *command* to domain *domain* through -qemu agent. +QEMU agent. *--timeout*, *--async* and *--block* options are exclusive. *--timeout* requires timeout seconds *seconds* and it must be positive. When *--aysnc* is given, the command waits for timeout whether success or -- 2.24.1

3 2

[libvirt] [PATCH] tests: avoid probing host CPU from bhyve test
by Daniel P. Berrangé 09 Jan '20

09 Jan '20

bhyveargv2xmlmock calls virBhyveCapsBuild which in turn calls virCPUProbeHost, probing the real host CPU. This causes a test failure if the host CPU happens to contain the 'arch-capabilities' feature as it triggers a call to virHostCPUGetMSR() which fails on FreeBSD. Fortunately we already have convenient code for mocking the host CPU probing. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- tests/bhyveargv2xmlmock.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/bhyveargv2xmlmock.c b/tests/bhyveargv2xmlmock.c index 1f08bebb7b..8120be29c1 100644 --- a/tests/bhyveargv2xmlmock.c +++ b/tests/bhyveargv2xmlmock.c @@ -2,7 +2,9 @@ #include "virnetdev.h" #include "internal.h" +#include "testutilshostcpus.h" #include "util/viruuid.h" +#include "cpu/cpu.h" #define VIR_FROM_THIS VIR_FROM_BHYVE @@ -25,3 +27,9 @@ virUUIDGenerate(unsigned char *uuid) return -1; return 0; } + +virCPUDefPtr +virCPUProbeHost(virArch arch) +{ + return testUtilsHostCpusGetDefForArch(arch); +} -- 2.24.1

2 1

[libvirt] [PATCH] qemu: Don't use NULL path from qemuDomainGetHostdevPath
by Jiri Denemark 09 Jan '20

09 Jan '20

Commit v5.10.0-290-g3a4787a301 refactored qemuDomainGetHostdevPath to return a single path rather than an array of paths. When the function is called on a missing device, it will now return NULL in @path rather than a NULL array with zero items and the callers need to be adapted properly. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_cgroup.c | 32 ++++++++++++++++++-------------- src/qemu/qemu_domain.c | 9 +++++---- 2 files changed, 23 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2bcc0527f6..45701b4c6e 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -426,13 +426,15 @@ qemuSetupHostdevCgroup(virDomainObjPtr vm, if (qemuDomainGetHostdevPath(dev, &path, &perms) < 0) return -1; - VIR_DEBUG("Cgroup allow %s perms=%d", path, perms); - rv = virCgroupAllowDevicePath(priv->cgroup, path, perms, false); - virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path, - virCgroupGetDevicePermsString(perms), - rv); - if (rv < 0) - return -1; + if (path) { + VIR_DEBUG("Cgroup allow %s perms=%d", path, perms); + rv = virCgroupAllowDevicePath(priv->cgroup, path, perms, false); + virDomainAuditCgroupPath(vm, priv->cgroup, "allow", path, + virCgroupGetDevicePermsString(perms), + rv); + if (rv < 0) + return -1; + } if (qemuHostdevNeedsVFIO(dev)) { VIR_DEBUG("Cgroup allow %s perms=%d", QEMU_DEV_VFIO, VIR_CGROUP_DEVICE_RW); @@ -473,13 +475,15 @@ qemuTeardownHostdevCgroup(virDomainObjPtr vm, if (qemuDomainGetHostdevPath(dev, &path, NULL) < 0) return -1; - VIR_DEBUG("Cgroup deny %s", path); - rv = virCgroupDenyDevicePath(priv->cgroup, path, - VIR_CGROUP_DEVICE_RWM, false); - virDomainAuditCgroupPath(vm, priv->cgroup, - "deny", path, "rwm", rv); - if (rv < 0) - return -1; + if (path) { + VIR_DEBUG("Cgroup deny %s", path); + rv = virCgroupDenyDevicePath(priv->cgroup, path, + VIR_CGROUP_DEVICE_RWM, false); + virDomainAuditCgroupPath(vm, priv->cgroup, + "deny", path, "rwm", rv); + if (rv < 0) + return -1; + } if (qemuHostdevNeedsVFIO(dev) && !qemuDomainNeedsVFIO(vm->def)) { diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 24e84a5966..1f358544ab 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -14001,7 +14001,8 @@ qemuDomainNeedsVFIO(const virDomainDef *def) * * For given device @dev fetch its host path and store it at * @path. Optionally, caller can get @perms on the path (e.g. - * rw/ro). + * rw/ro). When called on a missing device, the function will return success + * and store NULL at @path. * * The caller is responsible for freeing the @path when no longer * needed. @@ -14625,7 +14626,7 @@ qemuDomainSetupHostdev(virQEMUDriverConfigPtr cfg G_GNUC_UNUSED, if (qemuDomainGetHostdevPath(dev, &path, NULL) < 0) return -1; - if (qemuDomainCreateDevice(path, data, false) < 0) + if (path && qemuDomainCreateDevice(path, data, false) < 0) return -1; if (qemuHostdevNeedsVFIO(dev) && @@ -15688,7 +15689,7 @@ qemuDomainNamespaceSetupHostdev(virDomainObjPtr vm, if (qemuDomainGetHostdevPath(hostdev, &path, NULL) < 0) return -1; - if (qemuDomainNamespaceMknodPath(vm, path) < 0) + if (path && qemuDomainNamespaceMknodPath(vm, path) < 0) return -1; if (qemuHostdevNeedsVFIO(hostdev) && @@ -15720,7 +15721,7 @@ qemuDomainNamespaceTeardownHostdev(virDomainObjPtr vm, if (qemuDomainGetHostdevPath(hostdev, &path, NULL) < 0) return -1; - if (qemuDomainNamespaceUnlinkPath(vm, path) < 0) + if (path && qemuDomainNamespaceUnlinkPath(vm, path) < 0) return -1; if (qemuHostdevNeedsVFIO(hostdev) && -- 2.24.1

2 1

[libvirt] backing file chains, -blockdev, and storage file autodetection
by Martin Wilck 09 Jan '20

09 Jan '20

The recent change in libvirt to pass storage arguments to qemu via "-blockdev", explicity passing backing file chain information rather than relying on qemu to figure it out, has bitten me quite painfully. I've had the habit for years to use qcow2 with backing chains without specifying the backing file format explicitly, as information like the following was enough both for me and for qemu to figure out that the backing file was in qcow2 format: # qemu-img info sles15-gm-cc.qcow2 image: sles15-gm-cc.qcow2 file format: qcow2 virtual size: 20 GiB (21474836480 bytes) disk size: 407 MiB cluster_size: 65536 backing file: /mnt/vms/sles15-gm-base.qcow2 But if libvirt encounters a qemu-img file like this, it passes the backing file to qemu with "driver";"raw": -blockdev '{"driver":"file","filename":"/mnt/vms/sles15-gm-base.qcow2","node-name":"libvirt-4-storage","auto-read-only":true,"discard": "unmap"}' \ -blockdev '{"node-name":"libvirt-4-format","read-only":true,"driver":"raw","file":"libvirt-4-storage"}' \ The effect was that some of my VMs would refuse to start with a "no bootable disk" error message from the VM's BIOS. Others did boot (I believe this was because the boot sector had been modified in the top image in the backing file chain), and I'm quite grateful I did not attempt to boot them fully, because god knows what might have happened if the OS had later encountered garbage data from the backing file at some random point. It took me half a day to figure out that this effect had been caused by the recent libvirt update. I'm aware that documentation about this has been added recently (https://libvirt.org/kbase/backing_chains.html (*)). Also I believe that current libvirt master (unlike 5.10.0) would refuse to start such images in the first place ( https://bugzilla.redhat.com/show_bug.cgi?id=1588373) perhaps providing users with a better clue than before what was going wrong. Meanwhile I've fixed my VM images by adding the backing file format tag, as suggested in the documentation. However I still think that this was quite a disruptive change and highly unexpected for users. IMO the default behavior shouldn't have been switched like this without appropriate warnings. The rationale given for not autodetecting the file format is "a malicious guest could rewrite the header of the disk leading to access of host files". I suppose a guest would need to manipulate a raw image to look like qcow2, qed or similar for this to happen (and set the backing file to "/etc/shadow", maybe?). Still the malicious guest would need to find a way to manipulate the data *on the backing store*, because the format of the topmost image is explicit anyway. Modifying the backing store could be difficult for the guest, because it's normally read-only and changes go only to the top layer. Or am I missing something? The opposite (manipulating qcow2 to look like raw) shouldn't be possible, IMO. While I can't deny that an attack like this might be feasible, I am still wondering why this hasn't been an issue in past years (with qemu auto-detecting the backing file format). More importantly, perhaps the disruption caused by this change could be mitigated by allowing autodetection in certain cases (e.g. if the file name of the backing file indicates it's qcow2, as in the example above), or by providing a configuration option to enable it in environments (like mine, developer test environment) where evil guests are very unlikely. Best regards, Martin (*) This page is quite hard to find, googling for "libvirt backing chain" does not pick it up prominently just yet. Actually I only found this information by running "git grep" on the libvirt git repo. -- Dr. Martin Wilck <mwilck(a)suse.com>, Tel. +49 (0)911 74053 2107 SUSE Software Solutions Germany GmbH HRB 36809, AG Nürnberg GF: Felix Imendörffer

3 10

[libvirt] [dockerfiles PATCH 0/2] openSUSE updates
by Andrea Bolognani 09 Jan '20

09 Jan '20

Pushed under the Dockerfile update rule. Andrea Bolognani (2): Update openSUSE Leap 15.1 to install Meson from pip Add openSUSE Leap 15.1 Dockerfile for libosinfo buildenv-libosinfo-opensuse-151.zip | Bin 0 -> 570 bytes buildenv-libvirt-opensuse-151.zip | Bin 761 -> 785 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 buildenv-libosinfo-opensuse-151.zip -- 2.24.1

1 2

[libvirt] [PATCH v3] driver: Include source as a flag to virDomainGetHostname
by Julio Faracco 09 Jan '20

09 Jan '20

There is a lots of possibilities to retrieve hostname information from domain. Libvirt could use lease information from dnsmasq to get current hostname too. QEMU supports QEMU-agent but it can use lease source. See 'domifaddr' as an example. This commit still adds lease options for QEMU. It will get the first hostname available from domain networks. This case, QEMU driver has a default section inside switch to keep compatibility. So, if someone call 'domhostname' without specifying source, it will get the default option. Some other drivers like LXC and OpenVZ supports only one type, virCheckFlags will handle this case. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- v1-v2: Moving sources into flags. v2-v3: Applying Michal's suggestions. --- docs/manpages/virsh.rst | 7 ++- include/libvirt/libvirt-domain.h | 5 ++ src/lxc/lxc_driver.c | 78 ++++++++++++++++++++++++++++++++ src/qemu/qemu_driver.c | 76 +++++++++++++++++++++++++++---- tools/virsh-completer-domain.c | 17 +++++++ tools/virsh-completer-domain.h | 4 ++ tools/virsh-domain.c | 26 ++++++++++- 7 files changed, 201 insertions(+), 12 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index fea0527caf..ba483d4d00 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -1797,10 +1797,15 @@ domhostname .. code-block:: - domhostname domain + domhostname domain [--source lease|agent] Returns the hostname of a domain, if the hypervisor makes it available. +The *--source* argument specifies what data source to use for the +hostnames, currently 'lease' to read DHCP leases or 'agent' to query +the guest OS via an agent. If unspecified, driver returns the default +method available (some drivers support only one type of source). + domid ----- diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index e60003978a..666c1875cc 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -4833,6 +4833,11 @@ typedef struct _virTypedParameter virMemoryParameter; */ typedef virMemoryParameter *virMemoryParameterPtr; +typedef enum { + VIR_DOMAIN_GET_HOSTNAME_LEASE = (1 << 0), /* Parse DHCP lease file */ + VIR_DOMAIN_GET_HOSTNAME_AGENT = (1 << 1), /* Query qemu guest agent */ +} virDomainGetHostnameFlags; + typedef enum { VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE = 0, /* Parse DHCP lease file */ VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT = 1, /* Query qemu guest agent */ diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 780c6ed4a2..2dac730e70 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -5291,6 +5291,83 @@ lxcDomainGetCPUStats(virDomainPtr dom, } +static char * +lxcDomainGetHostname(virDomainPtr dom, + unsigned int flags) +{ + virLXCDriverPtr driver = dom->conn->privateData; + virDomainObjPtr vm = NULL; + char macaddr[VIR_MAC_STRING_BUFLEN]; + g_autoptr(virConnect) conn = NULL; + virNetworkDHCPLeasePtr *leases = NULL; + int n_leases; + size_t i, j; + char *hostname = NULL; + + virCheckFlags(VIR_DOMAIN_GET_HOSTNAME_LEASE, NULL); + + if (!(vm = lxcDomObjFromDomain(dom))) + return NULL; + + if (virDomainGetHostnameEnsureACL(dom->conn, vm->def) < 0) + goto cleanup; + + if (virLXCDomainObjBeginJob(driver, vm, LXC_JOB_QUERY) < 0) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto endjob; + + if (!(conn = virGetConnectNetwork())) + goto endjob; + + for (i = 0; i < vm->def->nnets; i++) { + g_autoptr(virNetwork) network = NULL; + + if (vm->def->nets[i]->type != VIR_DOMAIN_NET_TYPE_NETWORK) + continue; + + virMacAddrFormat(&(vm->def->nets[i]->mac), macaddr); + network = virNetworkLookupByName(conn, + vm->def->nets[i]->data.network.name); + + if (!network) + goto endjob; + + if ((n_leases = virNetworkGetDHCPLeases(network, macaddr, + &leases, 0)) < 0) + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("There is no available hostname %d"), + flags); + + for (j = 0; j < n_leases; j++) { + virNetworkDHCPLeasePtr lease = leases[j]; + if (lease->hostname) { + hostname = g_strdup(lease->hostname); + + for (j = 0; j < n_leases; j++) + virNetworkDHCPLeaseFree(leases[j]); + + VIR_FREE(leases); + + goto endjob; + } + + virNetworkDHCPLeaseFree(lease); + } + + VIR_FREE(leases); + } + + endjob: + virLXCDomainObjEndJob(driver, vm); + + cleanup: + virDomainObjEndAPI(&vm); + return hostname; +} + + static int lxcNodeGetFreePages(virConnectPtr conn, unsigned int npages, @@ -5436,6 +5513,7 @@ static virHypervisorDriver lxcHypervisorDriver = { .domainSetMetadata = lxcDomainSetMetadata, /* 1.1.3 */ .domainGetMetadata = lxcDomainGetMetadata, /* 1.1.3 */ .domainGetCPUStats = lxcDomainGetCPUStats, /* 1.2.2 */ + .domainGetHostname = lxcDomainGetHostname, /* 6.0.0 */ .nodeGetMemoryParameters = lxcNodeGetMemoryParameters, /* 0.10.2 */ .nodeSetMemoryParameters = lxcNodeSetMemoryParameters, /* 0.10.2 */ .domainSendProcessSignal = lxcDomainSendProcessSignal, /* 1.0.1 */ diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ec8faf384c..d8ed859f70 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20280,9 +20280,19 @@ qemuDomainGetHostname(virDomainPtr dom, virQEMUDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm = NULL; qemuAgentPtr agent; + char macaddr[VIR_MAC_STRING_BUFLEN]; + g_autoptr(virConnect) conn = NULL; + virNetworkDHCPLeasePtr *leases = NULL; + int n_leases; + size_t i, j; char *hostname = NULL; - virCheckFlags(0, NULL); + virCheckFlags(VIR_DOMAIN_GET_HOSTNAME_LEASE | + VIR_DOMAIN_GET_HOSTNAME_AGENT, NULL); + + VIR_EXCLUSIVE_FLAGS_RET(VIR_DOMAIN_GET_HOSTNAME_LEASE, + VIR_DOMAIN_GET_HOSTNAME_AGENT, + NULL); if (!(vm = qemuDomainObjFromDomain(dom))) return NULL; @@ -20290,18 +20300,66 @@ qemuDomainGetHostname(virDomainPtr dom, if (virDomainGetHostnameEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (qemuDomainObjBeginAgentJob(driver, vm, QEMU_AGENT_JOB_QUERY) < 0) - goto cleanup; - if (virDomainObjCheckActive(vm) < 0) goto endjob; - if (!qemuDomainAgentAvailable(vm, true)) - goto endjob; + switch (flags) { + default: + case VIR_DOMAIN_GET_HOSTNAME_AGENT: + if (qemuDomainObjBeginAgentJob(driver, vm, QEMU_AGENT_JOB_QUERY) < 0) + goto cleanup; - agent = qemuDomainObjEnterAgent(vm); - ignore_value(qemuAgentGetHostname(agent, &hostname)); - qemuDomainObjExitAgent(vm, agent); + if (!qemuDomainAgentAvailable(vm, true)) + goto endjob; + + agent = qemuDomainObjEnterAgent(vm); + ignore_value(qemuAgentGetHostname(agent, &hostname)); + qemuDomainObjExitAgent(vm, agent); + + break; + case VIR_DOMAIN_GET_HOSTNAME_LEASE: + if (!(conn = virGetConnectNetwork())) + goto endjob; + + for (i = 0; i < vm->def->nnets; i++) { + g_autoptr(virNetwork) network = NULL; + + if (vm->def->nets[i]->type != VIR_DOMAIN_NET_TYPE_NETWORK) + continue; + + virMacAddrFormat(&(vm->def->nets[i]->mac), macaddr); + network = virNetworkLookupByName(conn, + vm->def->nets[i]->data.network.name); + + if (!network) + goto endjob; + + if ((n_leases = virNetworkGetDHCPLeases(network, macaddr, + &leases, 0)) < 0) + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("There is no available hostname %d"), + flags); + + for (j = 0; j < n_leases; j++) { + virNetworkDHCPLeasePtr lease = leases[j]; + if (lease->hostname) { + hostname = g_strdup(lease->hostname); + + for (j = 0; j < n_leases; j++) + virNetworkDHCPLeaseFree(leases[j]); + + VIR_FREE(leases); + + goto endjob; + } + + virNetworkDHCPLeaseFree(lease); + } + + VIR_FREE(leases); + } + break; + } endjob: qemuDomainObjEndAgentJob(vm); diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index 0311ee50d0..67e67d485a 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -296,3 +296,20 @@ virshDomainShutdownModeCompleter(vshControl *ctl, return virshCommaStringListComplete(mode, modes); } + + +char ** +virshDomainGetHosnameSourcesCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags) +{ + const char *sources[] = {"lease", "agent", NULL}; + const char *source = NULL; + + virCheckFlags(0, NULL); + + if (vshCommandOptStringQuiet(ctl, cmd, "source", &source) < 0) + return NULL; + + return virshCommaStringListComplete(source, sources); +} diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h index 083ab327cc..ad1b37a255 100644 --- a/tools/virsh-completer-domain.h +++ b/tools/virsh-completer-domain.h @@ -53,3 +53,7 @@ char ** virshDomainDeviceAliasCompleter(vshControl *ctl, char ** virshDomainShutdownModeCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** virshDomainGetHosnameSourcesCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 9d4cdd26dd..73e6780116 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11743,6 +11743,11 @@ static const vshCmdInfo info_domhostname[] = { static const vshCmdOptDef opts_domhostname[] = { VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), + {.name = "source", + .type = VSH_OT_STRING, + .flags = VSH_OFLAG_NONE, + .completer = virshDomainGetHosnameSourcesCompleter, + .help = N_("address source: 'lease' or 'agent'")}, {.name = NULL} }; @@ -11752,21 +11757,38 @@ cmdDomHostname(vshControl *ctl, const vshCmd *cmd) char *hostname; virDomainPtr dom; bool ret = false; + const char *sourcestr = NULL; + int flags = 0; /* Use default value. Drivers can have its own default. */ if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return false; - hostname = virDomainGetHostname(dom, 0); + if (vshCommandOptStringReq(ctl, cmd, "source", &sourcestr) < 0) + goto error; + + if (sourcestr) { + if (STREQ(sourcestr, "lease")) { + flags |= VIR_DOMAIN_GET_HOSTNAME_LEASE; + } else if (STREQ(sourcestr, "agent")) { + flags |= VIR_DOMAIN_GET_HOSTNAME_AGENT; + } else { + vshError(ctl, _("Unknown data source '%s'"), sourcestr); + goto error; + } + } + + hostname = virDomainGetHostname(dom, flags); if (hostname == NULL) { vshError(ctl, "%s", _("failed to get hostname")); goto error; } vshPrint(ctl, "%s\n", hostname); + + VIR_FREE(hostname); ret = true; error: - VIR_FREE(hostname); virshDomainFree(dom); return ret; } -- 2.20.1

2 1

[libvirt] [jenkins-ci PATCH v3 0/3] Add all possible projects to openSUSE 15.1
by Fabiano Fidêncio 09 Jan '20

09 Jan '20

Now that openSUSE 15.1 is a thing on libvirt-jenkins-ci, let's add all possible projects to the OS, doing the needed mappings adjustments whenever needed. Changes since v2: https://www.redhat.com/archives/libvir-list/2020-January/msg00333.html - Split meson change into its specific patch; - Re-ordered the commits based on Andrea's request; - (Possibly) Fixed all the issues pointed by Andrea; Changes since v1: https://www.redhat.com/archives/libvir-list/2020-January/msg00321.html - Added libvirt-perl and updated the mappings accordingly. Fabiano Fidêncio (3): mappings: Use meson from pip on openSUSE 15.1 mappings: Adjust mappings for openSUSE 15.1 guests: Add projects to openSUSE 15.1 guests/host_vars/libvirt-opensuse-151/main.yml | 14 ++++++++++++++ guests/playbooks/build/projects/libvirt-dbus.yml | 1 + .../playbooks/build/projects/libvirt-sandbox.yml | 1 + guests/playbooks/build/projects/virt-manager.yml | 2 ++ guests/vars/mappings.yml | 16 ++++++++++++++++ 5 files changed, 34 insertions(+) -- 2.24.1

2 4

[libvirt] [PATCH 00/16] include result of bootstrap in git
by Pavel Hrdina 09 Jan '20

09 Jan '20

This patch series is motivated by the effort to adopt Meson as our build system but all of it improves the current build system on its own. It moves the burden to run bootstrap/autoreconf to developers which means it will save some time for others when there is any change to the build system. Since one of the patches is slightly bigger here is link to git: <https://gitlab.com/phrdina/libvirt/commits/configure> Pavel Hrdina (16): secret: move virSecretGetSecretString into virsecret configure.ac: add check for getegid function bootstrap.conf: drop gnulib tests from libvirt bootstrap.conf: add pthread-h module bootstrap.conf: always copy files bootstrap.conf: declare bootstrap sync in configuration file bootstrap.conf: disable VC ignore files bootstrap.conf: stop creating AUTHORS file syntax-check: remove deleted daemon directory from space_indent_check autogen.sh: fix autoreconf step autogen.sh: move --system option to configure as --with-system gnulib: store result of bootstrap in git replace any autogen.sh reference with configure autogen.sh: remove configure related code autogen.sh: remove --dry-run option autogen.sh: remove --no-git and --gnulib-srcdir options .git-module-status | 2 + .gitignore | 18 - .gitlab-ci.yml | 2 +- .travis.yml | 4 +- INSTALL | 368 + Makefile.am | 2 +- Makefile.in | 2323 + README-hacking | 5 +- aclocal.m4 | 1719 + autogen.sh | 150 +- bootstrap.conf | 29 +- build-aux/compile | 348 + build-aux/config.guess | 1667 + build-aux/config.sub | 1793 + build-aux/depcomp | 791 + build-aux/install-sh | 529 + build-aux/ltmain.sh | 11149 ++++ build-aux/missing | 215 + build-aux/syntax-check.mk | 23 +- build-aux/test-driver | 148 + ci/build.sh | 1 - config.h.in | 2303 + configure | 56615 +++++++++++++++++++ configure.ac | 16 +- docs/Makefile.in | 2614 + docs/compiling.html.in | 21 +- examples/Makefile.in | 2494 + gnulib/lib/Makefile.in | 3997 ++ gnulib/lib/_Noreturn.h | 40 + gnulib/lib/accept.c | 52 + gnulib/lib/alloca.c | 478 + gnulib/lib/alloca.in.h | 71 + gnulib/lib/arg-nonnull.h | 26 + gnulib/lib/arpa_inet.in.h | 150 + gnulib/lib/asnprintf.c | 34 + gnulib/lib/assure.h | 37 + gnulib/lib/binary-io.c | 39 + gnulib/lib/binary-io.h | 77 + gnulib/lib/bind.c | 49 + gnulib/lib/c++defs.h | 316 + gnulib/lib/chown.c | 151 + gnulib/lib/cloexec.c | 83 + gnulib/lib/cloexec.h | 38 + gnulib/lib/close.c | 71 + gnulib/lib/connect.c | 56 + gnulib/lib/dup2.c | 235 + gnulib/lib/errno.in.h | 279 + gnulib/lib/fchown-stub.c | 16 + gnulib/lib/fcntl.c | 627 + gnulib/lib/fcntl.in.h | 392 + gnulib/lib/fd-hook.c | 116 + gnulib/lib/fd-hook.h | 119 + gnulib/lib/filename.h | 54 + gnulib/lib/float+.h | 147 + gnulib/lib/float.c | 33 + gnulib/lib/float.in.h | 188 + gnulib/lib/fseek.c | 30 + gnulib/lib/fseeko.c | 164 + gnulib/lib/fstat.c | 94 + gnulib/lib/gai_strerror.c | 92 + gnulib/lib/getaddrinfo.c | 473 + gnulib/lib/getdelim.c | 147 + gnulib/lib/getdtablesize.c | 124 + gnulib/lib/getgroups.c | 131 + gnulib/lib/gethostname.c | 104 + gnulib/lib/getline.c | 27 + gnulib/lib/getpass.c | 231 + gnulib/lib/getpass.h | 4 + gnulib/lib/getpeername.c | 49 + gnulib/lib/getsockname.c | 49 + gnulib/lib/gettext.h | 301 + gnulib/lib/getugroups.c | 128 + gnulib/lib/getugroups.h | 19 + gnulib/lib/glthread/threadlib.c | 73 + gnulib/lib/gnulib.mk | 2806 + gnulib/lib/inet_ntop.c | 260 + gnulib/lib/intprops.h | 584 + gnulib/lib/ioctl.c | 92 + gnulib/lib/itold.c | 28 + gnulib/lib/limits.in.h | 104 + gnulib/lib/listen.c | 49 + gnulib/lib/localcharset.c | 1159 + gnulib/lib/localcharset.h | 137 + gnulib/lib/locale.in.h | 305 + gnulib/lib/localeconv.c | 103 + gnulib/lib/lseek.c | 71 + gnulib/lib/malloc.c | 56 + gnulib/lib/malloca.c | 105 + gnulib/lib/malloca.h | 123 + gnulib/lib/memchr.c | 172 + gnulib/lib/memchr.valgrind | 30 + gnulib/lib/mgetgroups.c | 201 + gnulib/lib/mgetgroups.h | 22 + gnulib/lib/msvc-inval.c | 129 + gnulib/lib/msvc-inval.h | 222 + gnulib/lib/msvc-nothrow.c | 51 + gnulib/lib/msvc-nothrow.h | 43 + gnulib/lib/net_if.in.h | 53 + gnulib/lib/netdb.in.h | 293 + gnulib/lib/netinet_in.in.h | 47 + gnulib/lib/nonblocking.c | 159 + gnulib/lib/nonblocking.h | 62 + gnulib/lib/open.c | 203 + gnulib/lib/openpty.c | 136 + gnulib/lib/passfd.c | 205 + gnulib/lib/passfd.h | 32 + gnulib/lib/pathmax.h | 83 + gnulib/lib/physmem.c | 330 + gnulib/lib/physmem.h | 26 + gnulib/lib/pipe.c | 50 + gnulib/lib/pipe2.c | 167 + gnulib/lib/poll.c | 621 + gnulib/lib/poll.in.h | 125 + gnulib/lib/posix_openpt.c | 108 + gnulib/lib/printf-args.c | 183 + gnulib/lib/printf-args.h | 150 + gnulib/lib/printf-parse.c | 632 + gnulib/lib/printf-parse.h | 193 + gnulib/lib/pthread.in.h | 1831 + gnulib/lib/pthread_sigmask.c | 92 + gnulib/lib/pty.in.h | 131 + gnulib/lib/raise.c | 83 + gnulib/lib/rawmemchr.c | 136 + gnulib/lib/rawmemchr.valgrind | 28 + gnulib/lib/realloc.c | 79 + gnulib/lib/recv.c | 49 + gnulib/lib/sched.in.h | 97 + gnulib/lib/select.c | 583 + gnulib/lib/send.c | 49 + gnulib/lib/setsockopt.c | 65 + gnulib/lib/sig-handler.c | 3 + gnulib/lib/sig-handler.h | 51 + gnulib/lib/sigaction.c | 204 + gnulib/lib/signal.in.h | 475 + gnulib/lib/sigprocmask.c | 349 + gnulib/lib/size_max.h | 30 + gnulib/lib/snprintf.c | 71 + gnulib/lib/socket.c | 49 + gnulib/lib/sockets.c | 161 + gnulib/lib/sockets.h | 66 + gnulib/lib/stat-time.c | 3 + gnulib/lib/stat-time.h | 252 + gnulib/lib/stat-w32.c | 425 + gnulib/lib/stat-w32.h | 37 + gnulib/lib/stat.c | 433 + gnulib/lib/stdalign.in.h | 121 + gnulib/lib/stdbool.in.h | 132 + gnulib/lib/stddef.in.h | 121 + gnulib/lib/stdint.in.h | 746 + gnulib/lib/stdio-impl.h | 212 + gnulib/lib/stdio-read.c | 164 + gnulib/lib/stdio-write.c | 202 + gnulib/lib/stdio.in.h | 1444 + gnulib/lib/stdlib.in.h | 1112 + gnulib/lib/strchrnul.c | 142 + gnulib/lib/strchrnul.valgrind | 28 + gnulib/lib/strdup.c | 54 + gnulib/lib/streq.h | 176 + gnulib/lib/string.in.h | 1067 + gnulib/lib/strtok_r.c | 76 + gnulib/lib/sys_ioctl.in.h | 79 + gnulib/lib/sys_select.in.h | 319 + gnulib/lib/sys_socket.c | 4 + gnulib/lib/sys_socket.in.h | 721 + gnulib/lib/sys_stat.in.h | 823 + gnulib/lib/sys_time.in.h | 224 + gnulib/lib/sys_types.in.h | 106 + gnulib/lib/sys_uio.in.h | 63 + gnulib/lib/sys_utsname.in.h | 108 + gnulib/lib/sys_wait.in.h | 131 + gnulib/lib/termios.in.h | 73 + gnulib/lib/time.in.h | 364 + gnulib/lib/time_r.c | 44 + gnulib/lib/ttyname_r.c | 114 + gnulib/lib/uname.c | 268 + gnulib/lib/unistd.c | 4 + gnulib/lib/unistd.in.h | 1719 + gnulib/lib/unitypes.in.h | 46 + gnulib/lib/uniwidth.in.h | 72 + gnulib/lib/uniwidth/cjk.h | 37 + gnulib/lib/uniwidth/width.c | 468 + gnulib/lib/vasnprintf.c | 5615 ++ gnulib/lib/vasnprintf.h | 79 + gnulib/lib/verify.h | 301 + gnulib/lib/w32sock.h | 140 + gnulib/lib/waitpid.c | 30 + gnulib/lib/warn-on-use.h | 131 + gnulib/lib/wchar.in.h | 1144 + gnulib/lib/wctype-h.c | 4 + gnulib/lib/wctype.in.h | 679 + gnulib/lib/wcwidth.c | 73 + gnulib/lib/xalloc-oversized.h | 60 + gnulib/lib/xsize.c | 3 + gnulib/lib/xsize.h | 117 + gnulib/tests/Makefile.am | 32 - include/libvirt/Makefile.in | 1908 + m4/00gnulib.m4 | 46 + m4/absolute-header.m4 | 102 + m4/alloca.m4 | 128 + m4/arpa_inet_h.m4 | 59 + m4/asm-underscore.m4 | 72 + m4/chown.m4 | 216 + m4/close.m4 | 35 + m4/codeset.m4 | 24 + m4/configmake.m4 | 27 + m4/dup2.m4 | 117 + m4/eealloc.m4 | 31 + m4/environ.m4 | 45 + m4/errno_h.m4 | 133 + m4/exponentd.m4 | 116 + m4/extensions.m4 | 189 + m4/extern-inline.m4 | 114 + m4/fcntl-o.m4 | 139 + m4/fcntl.m4 | 126 + m4/fcntl_h.m4 | 52 + m4/float_h.m4 | 108 + m4/fseek.m4 | 15 + m4/fseeko.m4 | 77 + m4/fstat.m4 | 39 + m4/getaddrinfo.m4 | 239 + m4/getdelim.m4 | 98 + m4/getdtablesize.m4 | 60 + m4/getgroups.m4 | 109 + m4/gethostname.m4 | 107 + m4/getline.m4 | 109 + m4/getpass.m4 | 106 + m4/getugroups.m4 | 11 + m4/gnulib-cache.m4 | 164 + m4/gnulib-common.m4 | 459 + m4/gnulib-comp.m4 | 1079 + m4/gnulib-tool.m4 | 57 + m4/hostent.m4 | 49 + m4/include_next.m4 | 224 + m4/inet_ntop.m4 | 70 + m4/intmax_t.m4 | 59 + m4/inttypes_h.m4 | 29 + m4/ioctl.m4 | 44 + m4/largefile.m4 | 177 + m4/libtool.m4 | 8372 +++ m4/libunistring-base.m4 | 141 + m4/limits-h.m4 | 43 + m4/localcharset.m4 | 11 + m4/locale_h.m4 | 158 + m4/localeconv.m4 | 22 + m4/lseek.m4 | 71 + m4/ltoptions.m4 | 437 + m4/ltsugar.m4 | 124 + m4/ltversion.m4 | 23 + m4/lt~obsolete.m4 | 99 + m4/malloc.m4 | 104 + m4/malloca.m4 | 14 + m4/manywarnings-c++.m4 | 245 + m4/manywarnings.m4 | 339 + m4/math_h.m4 | 369 + m4/memchr.m4 | 112 + m4/mgetgroups.m4 | 10 + m4/mmap-anon.m4 | 55 + m4/mode_t.m4 | 26 + m4/msvc-inval.m4 | 19 + m4/msvc-nothrow.m4 | 10 + m4/multiarch.m4 | 62 + m4/net_if_h.m4 | 32 + m4/netdb_h.m4 | 44 + m4/netinet_in_h.m4 | 31 + m4/nonblocking.m4 | 29 + m4/off_t.m4 | 18 + m4/open-cloexec.m4 | 21 + m4/open-slash.m4 | 59 + m4/open.m4 | 56 + m4/passfd.m4 | 23 + m4/pathmax.m4 | 42 + m4/physmem.m4 | 46 + m4/pipe.m4 | 15 + m4/pipe2.m4 | 18 + m4/poll.m4 | 107 + m4/poll_h.m4 | 49 + m4/posix-shell.m4 | 63 + m4/posix_openpt.m4 | 19 + m4/printf.m4 | 1692 + m4/pthread_h.m4 | 268 + m4/pthread_sigmask.m4 | 273 + m4/pty.m4 | 160 + m4/pty_h.m4 | 73 + m4/raise.m4 | 36 + m4/rawmemchr.m4 | 20 + m4/realloc.m4 | 82 + m4/sched_h.m4 | 91 + m4/select.m4 | 116 + m4/servent.m4 | 51 + m4/sigaction.m4 | 40 + m4/signal_h.m4 | 83 + m4/signalblocking.m4 | 25 + m4/sigpipe.m4 | 29 + m4/size_max.m4 | 75 + m4/snprintf.m4 | 62 + m4/socketlib.m4 | 90 + m4/sockets.m4 | 17 + m4/socklen.m4 | 76 + m4/sockpfaf.m4 | 84 + m4/ssize_t.m4 | 23 + m4/stat-time.m4 | 83 + m4/stat.m4 | 74 + m4/stdalign.m4 | 57 + m4/stdbool.m4 | 122 + m4/stddef_h.m4 | 72 + m4/stdint.m4 | 535 + m4/stdint_h.m4 | 27 + m4/stdio_h.m4 | 225 + m4/stdlib_h.m4 | 136 + m4/strchrnul.m4 | 50 + m4/strdup.m4 | 36 + m4/string_h.m4 | 122 + m4/strtok_r.m4 | 73 + m4/sys_ioctl_h.m4 | 64 + m4/sys_select_h.m4 | 95 + m4/sys_socket_h.m4 | 188 + m4/sys_stat_h.m4 | 100 + m4/sys_time_h.m4 | 110 + m4/sys_types_h.m4 | 60 + m4/sys_uio_h.m4 | 31 + m4/sys_utsname_h.m4 | 54 + m4/sys_wait_h.m4 | 36 + m4/termios_h.m4 | 43 + m4/threadlib.m4 | 586 + m4/time_h.m4 | 144 + m4/time_r.m4 | 99 + m4/ttyname_r.m4 | 133 + m4/uname.m4 | 19 + m4/unistd_h.m4 | 201 + m4/vasnprintf.m4 | 288 + m4/waitpid.m4 | 14 + m4/warn-on-use.m4 | 51 + m4/warnings.m4 | 115 + m4/wchar_h.m4 | 241 + m4/wchar_t.m4 | 24 + m4/wctype_h.m4 | 216 + m4/wcwidth.m4 | 131 + m4/wint_t.m4 | 74 + m4/xsize.m4 | 12 + po/Makefile.in | 1880 + po/POTFILES.in | 1 - src/Makefile.in | 15853 ++++++ src/libvirt_private.syms | 5 +- src/libxl/libxl_conf.c | 2 +- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_process.c | 2 +- src/qemu/qemu_tpm.c | 2 +- src/secret/Makefile.inc.am | 11 - src/secret/secret_util.c | 102 - src/secret/secret_util.h | 33 - src/storage/storage_backend_iscsi.c | 2 +- src/storage/storage_backend_iscsi_direct.c | 2 +- src/storage/storage_backend_rbd.c | 2 +- src/storage/storage_util.c | 2 +- src/util/virsecret.c | 69 + src/util/virsecret.h | 8 + tests/Makefile.in | 7562 +++ tools/Makefile.in | 3727 ++ 358 files changed, 187869 insertions(+), 405 deletions(-) create mode 100644 .git-module-status create mode 100644 INSTALL create mode 100644 Makefile.in create mode 100644 aclocal.m4 create mode 100755 build-aux/compile create mode 100755 build-aux/config.guess create mode 100755 build-aux/config.sub create mode 100755 build-aux/depcomp create mode 100755 build-aux/install-sh create mode 100644 build-aux/ltmain.sh create mode 100755 build-aux/missing create mode 100755 build-aux/test-driver create mode 100644 config.h.in create mode 100755 configure create mode 100644 docs/Makefile.in create mode 100644 examples/Makefile.in create mode 100644 gnulib/lib/Makefile.in create mode 100644 gnulib/lib/_Noreturn.h create mode 100644 gnulib/lib/accept.c create mode 100644 gnulib/lib/alloca.c create mode 100644 gnulib/lib/alloca.in.h create mode 100644 gnulib/lib/arg-nonnull.h create mode 100644 gnulib/lib/arpa_inet.in.h create mode 100644 gnulib/lib/asnprintf.c create mode 100644 gnulib/lib/assure.h create mode 100644 gnulib/lib/binary-io.c create mode 100644 gnulib/lib/binary-io.h create mode 100644 gnulib/lib/bind.c create mode 100644 gnulib/lib/c++defs.h create mode 100644 gnulib/lib/chown.c create mode 100644 gnulib/lib/cloexec.c create mode 100644 gnulib/lib/cloexec.h create mode 100644 gnulib/lib/close.c create mode 100644 gnulib/lib/connect.c create mode 100644 gnulib/lib/dup2.c create mode 100644 gnulib/lib/errno.in.h create mode 100644 gnulib/lib/fchown-stub.c create mode 100644 gnulib/lib/fcntl.c create mode 100644 gnulib/lib/fcntl.in.h create mode 100644 gnulib/lib/fd-hook.c create mode 100644 gnulib/lib/fd-hook.h create mode 100644 gnulib/lib/filename.h create mode 100644 gnulib/lib/float+.h create mode 100644 gnulib/lib/float.c create mode 100644 gnulib/lib/float.in.h create mode 100644 gnulib/lib/fseek.c create mode 100644 gnulib/lib/fseeko.c create mode 100644 gnulib/lib/fstat.c create mode 100644 gnulib/lib/gai_strerror.c create mode 100644 gnulib/lib/getaddrinfo.c create mode 100644 gnulib/lib/getdelim.c create mode 100644 gnulib/lib/getdtablesize.c create mode 100644 gnulib/lib/getgroups.c create mode 100644 gnulib/lib/gethostname.c create mode 100644 gnulib/lib/getline.c create mode 100644 gnulib/lib/getpass.c create mode 100644 gnulib/lib/getpass.h create mode 100644 gnulib/lib/getpeername.c create mode 100644 gnulib/lib/getsockname.c create mode 100644 gnulib/lib/gettext.h create mode 100644 gnulib/lib/getugroups.c create mode 100644 gnulib/lib/getugroups.h create mode 100644 gnulib/lib/glthread/threadlib.c create mode 100644 gnulib/lib/gnulib.mk create mode 100644 gnulib/lib/inet_ntop.c create mode 100644 gnulib/lib/intprops.h create mode 100644 gnulib/lib/ioctl.c create mode 100644 gnulib/lib/itold.c create mode 100644 gnulib/lib/limits.in.h create mode 100644 gnulib/lib/listen.c create mode 100644 gnulib/lib/localcharset.c create mode 100644 gnulib/lib/localcharset.h create mode 100644 gnulib/lib/locale.in.h create mode 100644 gnulib/lib/localeconv.c create mode 100644 gnulib/lib/lseek.c create mode 100644 gnulib/lib/malloc.c create mode 100644 gnulib/lib/malloca.c create mode 100644 gnulib/lib/malloca.h create mode 100644 gnulib/lib/memchr.c create mode 100644 gnulib/lib/memchr.valgrind create mode 100644 gnulib/lib/mgetgroups.c create mode 100644 gnulib/lib/mgetgroups.h create mode 100644 gnulib/lib/msvc-inval.c create mode 100644 gnulib/lib/msvc-inval.h create mode 100644 gnulib/lib/msvc-nothrow.c create mode 100644 gnulib/lib/msvc-nothrow.h create mode 100644 gnulib/lib/net_if.in.h create mode 100644 gnulib/lib/netdb.in.h create mode 100644 gnulib/lib/netinet_in.in.h create mode 100644 gnulib/lib/nonblocking.c create mode 100644 gnulib/lib/nonblocking.h create mode 100644 gnulib/lib/open.c create mode 100644 gnulib/lib/openpty.c create mode 100644 gnulib/lib/passfd.c create mode 100644 gnulib/lib/passfd.h create mode 100644 gnulib/lib/pathmax.h create mode 100644 gnulib/lib/physmem.c create mode 100644 gnulib/lib/physmem.h create mode 100644 gnulib/lib/pipe.c create mode 100644 gnulib/lib/pipe2.c create mode 100644 gnulib/lib/poll.c create mode 100644 gnulib/lib/poll.in.h create mode 100644 gnulib/lib/posix_openpt.c create mode 100644 gnulib/lib/printf-args.c create mode 100644 gnulib/lib/printf-args.h create mode 100644 gnulib/lib/printf-parse.c create mode 100644 gnulib/lib/printf-parse.h create mode 100644 gnulib/lib/pthread.in.h create mode 100644 gnulib/lib/pthread_sigmask.c create mode 100644 gnulib/lib/pty.in.h create mode 100644 gnulib/lib/raise.c create mode 100644 gnulib/lib/rawmemchr.c create mode 100644 gnulib/lib/rawmemchr.valgrind create mode 100644 gnulib/lib/realloc.c create mode 100644 gnulib/lib/recv.c create mode 100644 gnulib/lib/sched.in.h create mode 100644 gnulib/lib/select.c create mode 100644 gnulib/lib/send.c create mode 100644 gnulib/lib/setsockopt.c create mode 100644 gnulib/lib/sig-handler.c create mode 100644 gnulib/lib/sig-handler.h create mode 100644 gnulib/lib/sigaction.c create mode 100644 gnulib/lib/signal.in.h create mode 100644 gnulib/lib/sigprocmask.c create mode 100644 gnulib/lib/size_max.h create mode 100644 gnulib/lib/snprintf.c create mode 100644 gnulib/lib/socket.c create mode 100644 gnulib/lib/sockets.c create mode 100644 gnulib/lib/sockets.h create mode 100644 gnulib/lib/stat-time.c create mode 100644 gnulib/lib/stat-time.h create mode 100644 gnulib/lib/stat-w32.c create mode 100644 gnulib/lib/stat-w32.h create mode 100644 gnulib/lib/stat.c create mode 100644 gnulib/lib/stdalign.in.h create mode 100644 gnulib/lib/stdbool.in.h create mode 100644 gnulib/lib/stddef.in.h create mode 100644 gnulib/lib/stdint.in.h create mode 100644 gnulib/lib/stdio-impl.h create mode 100644 gnulib/lib/stdio-read.c create mode 100644 gnulib/lib/stdio-write.c create mode 100644 gnulib/lib/stdio.in.h create mode 100644 gnulib/lib/stdlib.in.h create mode 100644 gnulib/lib/strchrnul.c create mode 100644 gnulib/lib/strchrnul.valgrind create mode 100644 gnulib/lib/strdup.c create mode 100644 gnulib/lib/streq.h create mode 100644 gnulib/lib/string.in.h create mode 100644 gnulib/lib/strtok_r.c create mode 100644 gnulib/lib/sys_ioctl.in.h create mode 100644 gnulib/lib/sys_select.in.h create mode 100644 gnulib/lib/sys_socket.c create mode 100644 gnulib/lib/sys_socket.in.h create mode 100644 gnulib/lib/sys_stat.in.h create mode 100644 gnulib/lib/sys_time.in.h create mode 100644 gnulib/lib/sys_types.in.h create mode 100644 gnulib/lib/sys_uio.in.h create mode 100644 gnulib/lib/sys_utsname.in.h create mode 100644 gnulib/lib/sys_wait.in.h create mode 100644 gnulib/lib/termios.in.h create mode 100644 gnulib/lib/time.in.h create mode 100644 gnulib/lib/time_r.c create mode 100644 gnulib/lib/ttyname_r.c create mode 100644 gnulib/lib/uname.c create mode 100644 gnulib/lib/unistd.c create mode 100644 gnulib/lib/unistd.in.h create mode 100644 gnulib/lib/unitypes.in.h create mode 100644 gnulib/lib/uniwidth.in.h create mode 100644 gnulib/lib/uniwidth/cjk.h create mode 100644 gnulib/lib/uniwidth/width.c create mode 100644 gnulib/lib/vasnprintf.c create mode 100644 gnulib/lib/vasnprintf.h create mode 100644 gnulib/lib/verify.h create mode 100644 gnulib/lib/w32sock.h create mode 100644 gnulib/lib/waitpid.c create mode 100644 gnulib/lib/warn-on-use.h create mode 100644 gnulib/lib/wchar.in.h create mode 100644 gnulib/lib/wctype-h.c create mode 100644 gnulib/lib/wctype.in.h create mode 100644 gnulib/lib/wcwidth.c create mode 100644 gnulib/lib/xalloc-oversized.h create mode 100644 gnulib/lib/xsize.c create mode 100644 gnulib/lib/xsize.h delete mode 100644 gnulib/tests/Makefile.am create mode 100644 include/libvirt/Makefile.in create mode 100644 m4/00gnulib.m4 create mode 100644 m4/absolute-header.m4 create mode 100644 m4/alloca.m4 create mode 100644 m4/arpa_inet_h.m4 create mode 100644 m4/asm-underscore.m4 create mode 100644 m4/chown.m4 create mode 100644 m4/close.m4 create mode 100644 m4/codeset.m4 create mode 100644 m4/configmake.m4 create mode 100644 m4/dup2.m4 create mode 100644 m4/eealloc.m4 create mode 100644 m4/environ.m4 create mode 100644 m4/errno_h.m4 create mode 100644 m4/exponentd.m4 create mode 100644 m4/extensions.m4 create mode 100644 m4/extern-inline.m4 create mode 100644 m4/fcntl-o.m4 create mode 100644 m4/fcntl.m4 create mode 100644 m4/fcntl_h.m4 create mode 100644 m4/float_h.m4 create mode 100644 m4/fseek.m4 create mode 100644 m4/fseeko.m4 create mode 100644 m4/fstat.m4 create mode 100644 m4/getaddrinfo.m4 create mode 100644 m4/getdelim.m4 create mode 100644 m4/getdtablesize.m4 create mode 100644 m4/getgroups.m4 create mode 100644 m4/gethostname.m4 create mode 100644 m4/getline.m4 create mode 100644 m4/getpass.m4 create mode 100644 m4/getugroups.m4 create mode 100644 m4/gnulib-cache.m4 create mode 100644 m4/gnulib-common.m4 create mode 100644 m4/gnulib-comp.m4 create mode 100644 m4/gnulib-tool.m4 create mode 100644 m4/hostent.m4 create mode 100644 m4/include_next.m4 create mode 100644 m4/inet_ntop.m4 create mode 100644 m4/intmax_t.m4 create mode 100644 m4/inttypes_h.m4 create mode 100644 m4/ioctl.m4 create mode 100644 m4/largefile.m4 create mode 100644 m4/libtool.m4 create mode 100644 m4/libunistring-base.m4 create mode 100644 m4/limits-h.m4 create mode 100644 m4/localcharset.m4 create mode 100644 m4/locale_h.m4 create mode 100644 m4/localeconv.m4 create mode 100644 m4/lseek.m4 create mode 100644 m4/ltoptions.m4 create mode 100644 m4/ltsugar.m4 create mode 100644 m4/ltversion.m4 create mode 100644 m4/lt~obsolete.m4 create mode 100644 m4/malloc.m4 create mode 100644 m4/malloca.m4 create mode 100644 m4/manywarnings-c++.m4 create mode 100644 m4/manywarnings.m4 create mode 100644 m4/math_h.m4 create mode 100644 m4/memchr.m4 create mode 100644 m4/mgetgroups.m4 create mode 100644 m4/mmap-anon.m4 create mode 100644 m4/mode_t.m4 create mode 100644 m4/msvc-inval.m4 create mode 100644 m4/msvc-nothrow.m4 create mode 100644 m4/multiarch.m4 create mode 100644 m4/net_if_h.m4 create mode 100644 m4/netdb_h.m4 create mode 100644 m4/netinet_in_h.m4 create mode 100644 m4/nonblocking.m4 create mode 100644 m4/off_t.m4 create mode 100644 m4/open-cloexec.m4 create mode 100644 m4/open-slash.m4 create mode 100644 m4/open.m4 create mode 100644 m4/passfd.m4 create mode 100644 m4/pathmax.m4 create mode 100644 m4/physmem.m4 create mode 100644 m4/pipe.m4 create mode 100644 m4/pipe2.m4 create mode 100644 m4/poll.m4 create mode 100644 m4/poll_h.m4 create mode 100644 m4/posix-shell.m4 create mode 100644 m4/posix_openpt.m4 create mode 100644 m4/printf.m4 create mode 100644 m4/pthread_h.m4 create mode 100644 m4/pthread_sigmask.m4 create mode 100644 m4/pty.m4 create mode 100644 m4/pty_h.m4 create mode 100644 m4/raise.m4 create mode 100644 m4/rawmemchr.m4 create mode 100644 m4/realloc.m4 create mode 100644 m4/sched_h.m4 create mode 100644 m4/select.m4 create mode 100644 m4/servent.m4 create mode 100644 m4/sigaction.m4 create mode 100644 m4/signal_h.m4 create mode 100644 m4/signalblocking.m4 create mode 100644 m4/sigpipe.m4 create mode 100644 m4/size_max.m4 create mode 100644 m4/snprintf.m4 create mode 100644 m4/socketlib.m4 create mode 100644 m4/sockets.m4 create mode 100644 m4/socklen.m4 create mode 100644 m4/sockpfaf.m4 create mode 100644 m4/ssize_t.m4 create mode 100644 m4/stat-time.m4 create mode 100644 m4/stat.m4 create mode 100644 m4/stdalign.m4 create mode 100644 m4/stdbool.m4 create mode 100644 m4/stddef_h.m4 create mode 100644 m4/stdint.m4 create mode 100644 m4/stdint_h.m4 create mode 100644 m4/stdio_h.m4 create mode 100644 m4/stdlib_h.m4 create mode 100644 m4/strchrnul.m4 create mode 100644 m4/strdup.m4 create mode 100644 m4/string_h.m4 create mode 100644 m4/strtok_r.m4 create mode 100644 m4/sys_ioctl_h.m4 create mode 100644 m4/sys_select_h.m4 create mode 100644 m4/sys_socket_h.m4 create mode 100644 m4/sys_stat_h.m4 create mode 100644 m4/sys_time_h.m4 create mode 100644 m4/sys_types_h.m4 create mode 100644 m4/sys_uio_h.m4 create mode 100644 m4/sys_utsname_h.m4 create mode 100644 m4/sys_wait_h.m4 create mode 100644 m4/termios_h.m4 create mode 100644 m4/threadlib.m4 create mode 100644 m4/time_h.m4 create mode 100644 m4/time_r.m4 create mode 100644 m4/ttyname_r.m4 create mode 100644 m4/uname.m4 create mode 100644 m4/unistd_h.m4 create mode 100644 m4/vasnprintf.m4 create mode 100644 m4/waitpid.m4 create mode 100644 m4/warn-on-use.m4 create mode 100644 m4/warnings.m4 create mode 100644 m4/wchar_h.m4 create mode 100644 m4/wchar_t.m4 create mode 100644 m4/wctype_h.m4 create mode 100644 m4/wcwidth.m4 create mode 100644 m4/wint_t.m4 create mode 100644 m4/xsize.m4 create mode 100644 po/Makefile.in create mode 100644 src/Makefile.in delete mode 100644 src/secret/secret_util.c delete mode 100644 src/secret/secret_util.h create mode 100644 tests/Makefile.in create mode 100644 tools/Makefile.in -- 2.24.1

2 21

[libvirt] Plans for next release
by Daniel Veillard 09 Jan '20

09 Jan '20

The next release 6.0.0 should land around 15 January (and 6.1.0 back at the end of Feb), this means we should enter freeze soon, I suggest tomorrow Friday, with the goal of an RC2 on Monday for a release on Wednesday assuming everything is fine. thanks Dan for the reminder :-) hope this works for everyone ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [jenkins-ci PATCH] guests: Fix indentation in README
by Andrea Bolognani 08 Jan '20

08 Jan '20

Text that we want to show up as monospace needs to be indented by at least four spaces. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. guests/README.markdown | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/guests/README.markdown b/guests/README.markdown index d10727c..f225da7 100644 --- a/guests/README.markdown +++ b/guests/README.markdown @@ -159,14 +159,14 @@ the official qcow2 images can be used to quickly bring up such guests. The default qcow2 images are sized too small to be usable. To enlarge them do - $ virsh blockresize libvirt-freebsd-$MAJOR \ - /var/lib/libvirt/images/libvirt-freebsd-$MAJOR.qcow2 15G + $ virsh blockresize libvirt-freebsd-$MAJOR \ + /var/lib/libvirt/images/libvirt-freebsd-$MAJOR.qcow2 15G Then inside the guest, as root, enlarge the 3rd partition & filesystem to consume all new space: - # gpart resize -i 3 vtbd0 - # service growfs onestart + # gpart resize -i 3 vtbd0 + # service growfs onestart Some manual tweaking will be needed, in particular: -- 2.24.1

1 0