- Devel - libvirt List Archives

[libvirt] [PATCH] qemu_capabilities: Do not report USB as subsystem type if it is not available
by Thomas Huth 13 Jan '20

13 Jan '20

libvirt currently always reports that USB is available as a bus subsystem type when running "virsh domcapabilities". However, this is not always true, for example the qemu-system-s390x binary normally never has support for USB. Thus we should only report that USB is available if there is also a USB host controller available where we can attach USB devices. Reported-by: Sebastian Mitterle <smitterl(a)redhat.com> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1759849 Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- src/qemu/qemu_capabilities.c | 13 ++++++++++++- tests/domaincapsdata/qemu_2.10.0.s390x.xml | 1 - tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 - tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 - tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 - tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 - tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 - tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 - tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 - tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 - 10 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index da0c7a257f..261cca19a7 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5674,10 +5674,21 @@ virQEMUCapsFillDomainDeviceHostdevCaps(virQEMUCapsPtr qemuCaps, VIR_DOMAIN_STARTUP_POLICY_OPTIONAL); VIR_DOMAIN_CAPS_ENUM_SET(hostdev->subsysType, - VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB, VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI, VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI); + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX3_USB_UHCI) || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX4_USB_UHCI) || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_USB_EHCI) || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_ICH9_USB_EHCI1) || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_VT82C686B_USB_UHCI) || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_PCI_OHCI) || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_NEC_USB_XHCI) || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QEMU_XHCI)) { + VIR_DOMAIN_CAPS_ENUM_SET(hostdev->subsysType, + VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB); + } + /* No virDomainHostdevCapsType for QEMU */ virDomainCapsEnumClear(&hostdev->capsType); diff --git a/tests/domaincapsdata/qemu_2.10.0.s390x.xml b/tests/domaincapsdata/qemu_2.10.0.s390x.xml index bf3f13887f..b41ca5158c 100644 --- a/tests/domaincapsdata/qemu_2.10.0.s390x.xml +++ b/tests/domaincapsdata/qemu_2.10.0.s390x.xml @@ -168,7 +168,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> diff --git a/tests/domaincapsdata/qemu_2.11.0.s390x.xml b/tests/domaincapsdata/qemu_2.11.0.s390x.xml index 9b3b18d320..ad4e6b0500 100644 --- a/tests/domaincapsdata/qemu_2.11.0.s390x.xml +++ b/tests/domaincapsdata/qemu_2.11.0.s390x.xml @@ -167,7 +167,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> diff --git a/tests/domaincapsdata/qemu_2.12.0.s390x.xml b/tests/domaincapsdata/qemu_2.12.0.s390x.xml index af7a04fb01..9736d6a42d 100644 --- a/tests/domaincapsdata/qemu_2.12.0.s390x.xml +++ b/tests/domaincapsdata/qemu_2.12.0.s390x.xml @@ -166,7 +166,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> diff --git a/tests/domaincapsdata/qemu_2.7.0.s390x.xml b/tests/domaincapsdata/qemu_2.7.0.s390x.xml index 258000dbaf..b19a4c9fed 100644 --- a/tests/domaincapsdata/qemu_2.7.0.s390x.xml +++ b/tests/domaincapsdata/qemu_2.7.0.s390x.xml @@ -71,7 +71,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> diff --git a/tests/domaincapsdata/qemu_2.8.0.s390x.xml b/tests/domaincapsdata/qemu_2.8.0.s390x.xml index cc858f538c..30d2f7ff1f 100644 --- a/tests/domaincapsdata/qemu_2.8.0.s390x.xml +++ b/tests/domaincapsdata/qemu_2.8.0.s390x.xml @@ -152,7 +152,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> diff --git a/tests/domaincapsdata/qemu_2.9.0.s390x.xml b/tests/domaincapsdata/qemu_2.9.0.s390x.xml index fe2c023956..2476e95181 100644 --- a/tests/domaincapsdata/qemu_2.9.0.s390x.xml +++ b/tests/domaincapsdata/qemu_2.9.0.s390x.xml @@ -153,7 +153,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> diff --git a/tests/domaincapsdata/qemu_3.0.0.s390x.xml b/tests/domaincapsdata/qemu_3.0.0.s390x.xml index 68bcafd62f..a297bf9ef1 100644 --- a/tests/domaincapsdata/qemu_3.0.0.s390x.xml +++ b/tests/domaincapsdata/qemu_3.0.0.s390x.xml @@ -173,7 +173,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> diff --git a/tests/domaincapsdata/qemu_4.0.0.s390x.xml b/tests/domaincapsdata/qemu_4.0.0.s390x.xml index 4298b148fd..21ddd27cb9 100644 --- a/tests/domaincapsdata/qemu_4.0.0.s390x.xml +++ b/tests/domaincapsdata/qemu_4.0.0.s390x.xml @@ -178,7 +178,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> diff --git a/tests/domaincapsdata/qemu_4.2.0.s390x.xml b/tests/domaincapsdata/qemu_4.2.0.s390x.xml index c6d92542c3..101d9d028b 100644 --- a/tests/domaincapsdata/qemu_4.2.0.s390x.xml +++ b/tests/domaincapsdata/qemu_4.2.0.s390x.xml @@ -172,7 +172,6 @@ <value>optional</value> </enum> <enum name='subsysType'> - <value>usb</value> <value>pci</value> <value>scsi</value> </enum> -- 2.18.1

2 2

[libvirt] [jenkins-ci PATCH] lcitool: Mark Fedora kernel packages as user-installed
by Andrea Bolognani 13 Jan '20

13 Jan '20

>From time to time we hit https://bugzilla.redhat.com/show_bug.cgi?id=1741381 which result in 'dnf autoremove' failing. The suggested workaround is to manually mark kernel packages as user-installed, so let's do that every single time just in case. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/playbooks/update/tasks/base.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/update/tasks/base.yml index f085f19..97f365e 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -100,6 +100,13 @@ when: - package_format == 'pkg' +- name: Clean up packages after update + command: '{{ package_manager }} mark install "kernel*"' + args: + warn: no + when: + - os_name == 'Fedora' + - name: Clean up packages after update shell: '{{ package_manager }} clean packages -y && {{ package_manager }} autoremove -y' args: -- 2.24.1

3 3

[libvirt] [PATCH for 6.0.0] qemuxml2*test: Fix hugepages-default-system-size tests
by Jiri Denemark 13 Jan '20

13 Jan '20

Commit v5.10.0-269-g62065a6cb5 moved NUMA validation code to domain definition time and appropriately adjusted affected test cases except for hugepages-default-system-size. And since we don't mock virGetSystemPageSizeKB in our tests, hugepages-default-system-size test would fail on architectures (ppc64le) with default page size other than 4KiB. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 8af2ba38d3..560a012149 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -946,7 +946,7 @@ mymain(void) QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD); DO_TEST("hugepages-default", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-default-2M", QEMU_CAPS_OBJECT_MEMORY_FILE); - DO_TEST("hugepages-default-system-size", NONE); + DO_TEST("hugepages-default-system-size", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST_PARSE_ERROR("hugepages-default-1G-nodeset-2M", NONE); DO_TEST("hugepages-nodeset", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST_PARSE_ERROR("hugepages-nodeset-nonexist", diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 262fc835f5..f7b6022819 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -293,7 +293,7 @@ mymain(void) DO_TEST("pages-dimm-discard", NONE); DO_TEST("hugepages-default", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-default-2M", QEMU_CAPS_OBJECT_MEMORY_FILE); - DO_TEST("hugepages-default-system-size", NONE); + DO_TEST("hugepages-default-system-size", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-nodeset", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-numa-default-2M", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-numa-default-dimm", QEMU_CAPS_OBJECT_MEMORY_FILE); -- 2.24.1

2 1

[libvirt] [PATCH 0/4] Fix formatting of encrypted disk secret info (for 6.0.0)
by Peter Krempa 13 Jan '20

13 Jan '20

See the last patch for explanation. Peter Krempa (4): tests: qemuxml2argv: Add disk image with encrypted backing file tests: qemuxml2argv: Run luks-disks-source-qcow2 case with latest caps tests: qemuxml2xml: Enable luks-disks-source-qcow2 case conf: Always format storage source auth and encryption under <source> for backing files src/conf/backup_conf.c | 2 +- src/conf/domain_conf.c | 13 ++- src/conf/domain_conf.h | 1 + src/conf/snapshot_conf.c | 2 +- src/qemu/qemu_domain.c | 4 +- tests/qemublocktest.c | 2 +- .../luks-disks-source-qcow2.args | 8 ++ ...luks-disks-source-qcow2.x86_64-latest.args | 110 ++++++++++++++++++ .../luks-disks-source-qcow2.xml | 18 +++ tests/qemuxml2argvtest.c | 1 + .../luks-disks-source-qcow2.x86_64-latest.xml | 106 +++++++++++++++++ tests/qemuxml2xmltest.c | 1 + tests/virstoragetest.c | 2 +- 13 files changed, 259 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/luks-disks-source-qcow2.x86_64-latest.args create mode 100644 tests/qemuxml2xmloutdata/luks-disks-source-qcow2.x86_64-latest.xml -- 2.24.1

2 6

[libvirt] [PATCH] Fix typo (cetificate -> certificate)
by Andrea Bolognani 13 Jan '20

13 Jan '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-domain.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 6446a903ca..c637caa583 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -3182,7 +3182,7 @@ Providing *--tls* causes the migration to use the host configured TLS setup the migration of the domain. Usage requires proper TLS setup for both source and target. Normally the TLS certificate from the destination host must match +the host's name for TLS verification to succeed. When the certificate does not -+match the destination hostname and the expected cetificate's hostname is ++match the destination hostname and the expected certificate's hostname is +known, *--tls-destination* can be used to pass the expected *hostname* when +starting the migration. diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index c1b9a9d1d0..1d76cdcc34 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1059,7 +1059,7 @@ typedef enum { * * Normally the TLS certificate from the destination host must match the host's * name for TLS verification to succeed. When the certificate does not match - * the destination hostname and the expected cetificate's hostname is known, + * the destination hostname and the expected certificate's hostname is known, * this parameter can be used to pass this expected hostname when starting * the migration. */ -- 2.24.1

1 0

[libvirt] [jenkins-ci PATCH] mappings: Refactor python3-devel mapping
by Andrea Bolognani 13 Jan '20

13 Jan '20

All RPM-based distributions except for CentOS 7 use the same name. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 14bf2ff..9833856 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -864,8 +864,7 @@ mappings: python3-devel: deb: python3-dev pkg: python3 - Fedora: python3-devel - OpenSUSE: python3-devel + rpm: python3-devel CentOS7: python36-devel cross-policy-deb: foreign -- 2.24.1

2 1

[libvirt] Question about parallel migration connections
by Jim Fehlig 10 Jan '20

10 Jan '20

Are they supported with tunneled migration? The feature seems limited to native migration, in which case I can send a patch prohibiting parallel migration connections with the tunnel. Regards, Jim

3 5

[libvirt] Question / Bug: "IO mon_iothread" not affected by "<iothreadsched scheduler=.."
by gima+libvir-list＠iki.fi 10 Jan '20

10 Jan '20

# Question / Bug For "<iothreads>1</iothreads>", QEMU creates two threads by name of "IO mon_iothread"and "IO iothread1" Both are affected by "<iothreadpin iothread='1' cpuset='5'/>" (pinned to specified CPU), but only "IO iothread1" is affected by "<iothreadsched iothread='1' cpuset='5'/>". I believe this is to be a bug, whereas both threads should be affected, and be set to be ruled by the specified iothread scheduler. Am I correct and is this a bug, or am I missing something? # What does this matter / How does this manifest a problem? This manifests in case there is 1 iothread, and both iothread and emulator are pinned to the same cpu and set to use fifo or rr as their scheduler. In this configuration, QEMU does not start correctly and "stalls" until I change the scheduler of "IO mon_iothread" to rr or fifo (respectively).

2 1

[libvirt] [jenkins-ci PATCH 0/2] Add all possible projects to OpenSUSE 15.1
by Fabiano Fidêncio 10 Jan '20

10 Jan '20

Now that OpenSUSE 15.1 is a thing on libvirt-jenkins-ci, let's add all possible projects to the OS, doing the needed mappings adjustments whenever needed. Fabiano Fidêncio (2): guests: Add projects to OpenSUSE 15.1 mappings: Adjust mappings for OpenSUSE 15.1 guests/host_vars/libvirt-opensuse-151/main.yml | 13 +++++++++++++ guests/playbooks/build/projects/virt-manager.yml | 2 ++ guests/vars/mappings.yml | 13 +++++++++++++ 3 files changed, 28 insertions(+) -- 2.24.1

2 4

[libvirt] [jenkins-ci PATCH] mappings: Reorder some entries
by Andrea Bolognani 10 Jan '20

10 Jan '20

We've always strived to keep entries sorted in a way that reflects the order in which they're actually processed, with entries that have the same priority being sorted alphabetically, however a few mistakes have managed to sneak into the file over time. Fix them. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. guests/vars/mappings.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 1d8d1e0..14bf2ff 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -348,8 +348,8 @@ mappings: libgovirt: rpm: libgovirt-devel - CentOS8: Debian: libgovirt-dev + CentOS8: cross-policy-deb: foreign libiscsi: @@ -370,9 +370,9 @@ mappings: libnuma: deb: libnuma-dev rpm: numactl-devel + OpenSUSE: libnuma-devel armv6l-deb: armv7l-deb: - OpenSUSE: libnuma-devel cross-policy-deb: foreign libparted: @@ -468,9 +468,9 @@ mappings: locales: deb: locales rpm: glibc-langpack-en - CentOS7: glibc-common FreeBSD: OpenSUSE: glibc-locale + CentOS7: glibc-common lsof: default: lsof @@ -849,8 +849,8 @@ mappings: python3-docutils: default: python3-docutils - CentOS7: python36-docutils FreeBSD: py37-docutils + CentOS7: python36-docutils python3: default: python3 @@ -930,8 +930,8 @@ mappings: rpcgen: deb: libc-dev-bin rpm: rpcgen - CentOS7: glibc-common FreeBSD: + CentOS7: glibc-common rpmbuild: rpm: rpm-build @@ -975,8 +975,8 @@ mappings: tc: deb: iproute2 rpm: iproute-tc - CentOS7: iproute OpenSUSE: iproute2 + CentOS7: iproute unzip: default: unzip @@ -1005,9 +1005,9 @@ mappings: xen: rpm: xen-devel CentOS: - x86_64-deb: libxen-dev - armv7l-deb: libxen-dev aarch64-deb: libxen-dev + armv7l-deb: libxen-dev + x86_64-deb: libxen-dev cross-policy-deb: foreign xfsprogs: -- 2.24.1

1 0