- Devel - libvirt List Archives

[libvirt PATCH 0/6] Clean up some includes
by Ján Tomko 03 Aug '20

03 Aug '20

2 7

[libvirt PATCH 0/8] Some cppcheck-inspired fixes
by Ján Tomko 03 Aug '20

03 Aug '20

At least I found a memleak. Ján Tomko (8): vz: remove redundant NULL pointer check Remove redundant conditions util: command: do not return after abort util: virhostmem: do not use scanf without field limits util: sync variable names between header and C files virsh: completer: use signed variable for XPathNodeSet errors tools: remove unread variables tools: virt-admin: do not leak daemon-log settings src/hypervisor/virhostdev.c | 2 +- src/libxl/xen_xl.c | 2 +- src/qemu/qemu_hotplug.c | 3 +-- src/qemu/qemu_process.c | 6 +++--- src/rpc/virnetsocket.c | 2 +- src/util/vircommand.c | 1 - src/util/virhostmem.c | 6 ++++-- src/util/virlease.c | 2 +- src/util/virresctrl.h | 2 +- src/util/virsocketaddr.h | 8 ++++---- src/vbox/vbox_common.c | 2 +- src/vz/vz_sdk.c | 8 ++++---- tools/virsh-completer-host.c | 4 ++-- tools/virsh-domain.c | 7 +++---- tools/virt-admin.c | 21 +++++++++------------ 15 files changed, 36 insertions(+), 40 deletions(-) -- 2.26.2

2 9

Release of libvirt-6.6.0
by Jiri Denemark 03 Aug '20

03 Aug '20

The 6.6.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any other feedback. Your work is greatly appreciated. * New features * Allow configuring of ACPI NUMA HMAT Libvirt allows configuring ACPI Heterogeneous Memory Attribute Table to hint software running inside the guest on optimization. * esx: Add a ``type`` attribute for mac addresses. This attribute allows (when set to ``static``) ignoring VMWare checks of the MAC addresses that would generate a new one if they were in its OUI (00:0c:29). * conf: add control over COW for storage pool directories The storage pool code now attempts to disable COW by default on btrfs, but management applications may wish to override this behaviour. This is now possible via new ``cow`` element. * Improvements * esx: Change the NIC limit for recent virtualHW versions Specifying a virtualHW version greater or equal to 7 (ESXi 4.0) will allow you to use up to 10 NICs instead of 4 as it was previously. * qemu: Support encrypted TLS keys for NBD disks The secret key used for disks can now be encrypted similarly to TLS keys used for migration, chardev and others. * qemu: ``VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD`` can now be registered for ``<mirror>`` The event can now be used also for block copy destinations by using the index of the ``<mirror>`` image. * qemu: consider available CPUs in ``vcpupin/emulatorpin`` output This patch changes the default bitmap of ``vcpupin`` and ``emulatorpin``, in the case of domains with static vcpu placement, all available CPUs instead of all possible CPUs are returned making these APIs consistent with the behavior of ``vcpuinfo``. * Bug fixes * virdevmapper: Don't use libdevmapper to obtain dependencies When building domain's private ``/dev`` in a namespace, libdevmapper was consulted for getting full dependency tree of domain's disks. However, this meant that libdevmapper opened ``/dev/mapper/control`` which wasn't closed and was leaked to QEMU. CVE-2020-14339 * qemu: Report correct ``index`` in ``VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD`` Starting from libvirt 5.10 with QEMU 4.2 the ``VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD`` event would report incorrect device ``index`` when reported for an image from the backing chain of a disk. * qemu: Don't fail active layer block commit or block copy in certain cases Starting from libvirt-6.5 an active layer block commit or a block copy could fail if the same destination was used more than once. * qemu: Don't change ownership of restore file When restoring a domain from a file, Libvirt no longer changes its ownership. * qemu: Set SPAPR TPM default to 2.0 and prevent 1.2 choice The firmware (SLOF) on QEMU for ppc64 does not support TPM 1.2, so prevent the choice of TPM 1.2 when the SPAPR device model is chosen and use a default of '2.0' (TPM 2) for the backend. * qemu: Do not set ``//cpu/@migratable`` for running domains Libvirt release of 6.4.0 started to fill the default value for ``//cpu/@migratable`` attribute according to QEMU support. However, active domains either have the migratable attribute already set or they were started with older Libvirt which doesn't support the attribute. Enjoy. Jirka

1 0

[libvirt PATCH 0/6] ci: clang on linux and more parallelism
by Ján Tomko 01 Aug '20

01 Aug '20

Run clang tests on Fedora Rawhide, Centos 8 and Debian 10. Specify needs: for everything to prevent pointless waiting. https://gitlab.com/jano.tomko/libvirt/-/pipelines/173023075 Ján Tomko (6): ci: refresh Dockerfiles ci: refresh Dockerfiles ci: add clang jobs ci: run Cirrus-based builds sooner ci: specify containter dependencies for all the jobs ci: run container jobs right away .gitlab-ci.yml | 76 +++++++++++++++++++ ci/containers/libvirt-centos-7.Dockerfile | 2 +- ci/containers/libvirt-centos-8.Dockerfile | 2 +- .../libvirt-centos-stream.Dockerfile | 2 +- ...libvirt-debian-10-cross-aarch64.Dockerfile | 2 +- .../libvirt-debian-10-cross-armv6l.Dockerfile | 3 +- .../libvirt-debian-10-cross-armv7l.Dockerfile | 3 +- .../libvirt-debian-10-cross-i686.Dockerfile | 2 +- .../libvirt-debian-10-cross-mips.Dockerfile | 2 +- ...ibvirt-debian-10-cross-mips64el.Dockerfile | 2 +- .../libvirt-debian-10-cross-mipsel.Dockerfile | 2 +- ...libvirt-debian-10-cross-ppc64le.Dockerfile | 2 +- .../libvirt-debian-10-cross-s390x.Dockerfile | 2 +- ci/containers/libvirt-debian-10.Dockerfile | 2 +- ...ibvirt-debian-sid-cross-aarch64.Dockerfile | 2 +- ...libvirt-debian-sid-cross-armv6l.Dockerfile | 3 +- ...libvirt-debian-sid-cross-armv7l.Dockerfile | 3 +- .../libvirt-debian-sid-cross-i686.Dockerfile | 2 +- ...bvirt-debian-sid-cross-mips64el.Dockerfile | 2 +- ...libvirt-debian-sid-cross-mipsel.Dockerfile | 3 +- ...ibvirt-debian-sid-cross-ppc64le.Dockerfile | 2 +- .../libvirt-debian-sid-cross-s390x.Dockerfile | 2 +- ci/containers/libvirt-debian-sid.Dockerfile | 2 +- ci/containers/libvirt-fedora-31.Dockerfile | 2 +- ci/containers/libvirt-fedora-32.Dockerfile | 2 +- ...rt-fedora-rawhide-cross-mingw32.Dockerfile | 1 + ...rt-fedora-rawhide-cross-mingw64.Dockerfile | 1 + .../libvirt-fedora-rawhide.Dockerfile | 2 +- ci/containers/libvirt-opensuse-151.Dockerfile | 2 +- ci/containers/libvirt-ubuntu-1804.Dockerfile | 2 +- ci/containers/libvirt-ubuntu-2004.Dockerfile | 2 +- 31 files changed, 111 insertions(+), 28 deletions(-) -- 2.26.2

3 8

[PATCH for 6.6.0] NEWS: Document changes for upcoming release
by Michal Privoznik 01 Aug '20

01 Aug '20

In contrast with other releases, this time NEWS is pretty much updated. I've identified only a couple of features/bug fixes worth mentioning that were not mentioned yet. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1314f3e698..d97ca501dc 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -24,6 +24,12 @@ v6.6.0 (unreleased) MAC addresses that would generate a new one if they were in its OUI (00:0c:29). + * conf: add control over COW for storage pool directories + + The storage pool code now attempts to disable COW by default on btrfs, but + management applications may wish to override this behaviour. This is now + possible via new ``cow`` element. + * **Improvements** * esx: Change the NIC limit for recent virtualHW versions @@ -41,6 +47,14 @@ v6.6.0 (unreleased) The event can now be used also for block copy destinations by using the index of the ``<mirror>`` image. + * qemu: consider available CPUs in ``vcpupin/emulatorpin`` output + + This patch changes the default bitmap of ``vcpupin`` and ``emulatorpin``, + in the case of domains with static vcpu placement, all available CPUs + instead of all possible CPUs are returned making these APIs consistent with + the behavior of ``vcpuinfo``. + + * **Bug fixes** * virdevmapper: Don't use libdevmapper to obtain dependencies @@ -61,6 +75,24 @@ v6.6.0 (unreleased) Starting from libvirt-6.5 an active layer block commit or a block copy could fail if the same destination was used more than once. + * qemu: Don't change ownership of restore file + + When restoring a domain from a file, Libvirt no longer changes its ownership. + + * qemu: Set SPAPR TPM default to 2.0 and prevent 1.2 choice + + The firmware (SLOF) on QEMU for ppc64 does not support TPM 1.2, so prevent + the choice of TPM 1.2 when the SPAPR device model is chosen and use a + default of '2.0' (TPM 2) for the backend. + + * qemu: Do not set ``//cpu/@migratable`` for running domains + + Libvirt release of 6.4.0 started to fill the default value for + ``//cpu/@migratable`` attribute according to QEMU support. However, active + domains either have the migratable attribute already set or they were + started with older Libvirt which doesn't support the attribute. + + v6.5.0 (2020-07-03) =================== -- 2.26.2

4 3

[PATCH] Ignore clangd-related files and folders
by Martin Kletzander 31 Jul '20

31 Jul '20

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- .gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 6c167e423b18..edc25cb8d0e0 100644 --- a/.gitignore +++ b/.gitignore @@ -38,3 +38,7 @@ Makefile.in /build/ /ci/scratch/ tags + +# clangd related ignores +.clangd +compile_commands.json -- 2.28.0

3 2

[PATCH] qemu: snapshot: Collect 'query-named-block-nodes' prior to memory migration
by Peter Krempa 31 Jul '20

31 Jul '20

When doing an external snapshot we migrate memory to a file as a form of taking the memory state. This creates a problem as qemu deactivates all active bitmaps after a successful migration. This means that calling 'query-named-block-nodes' will return an empty list of bitmaps for devices. We use the bitmap list to propagate the active bitmaps into the overlay files being created which is required for backups to work after a snapshot. Since we wouldn't propagate anythign a subsequent backup will fail with: invalid argument: missing or broken bitmap 'testchck' for disk 'vda' To fix this, we can simply collect the bitmap list prior to the migration. https://bugzilla.redhat.com/show_bug.cgi?id=1862472 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Note that with current qemu the above steps will still fail as qemu fails to 'cont' after a migration if backing images contain bitmaps which is the case here. See: https://lists.nongnu.org/archive/html/qemu-block/2020-07/msg01833.html src/qemu/qemu_driver.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0ad6359102..b655df8c98 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15365,6 +15365,7 @@ static int qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver, virDomainObjPtr vm, virDomainMomentObjPtr snap, + virHashTablePtr blockNamedNodeData, unsigned int flags, virQEMUDriverConfigPtr cfg, qemuDomainAsyncJob asyncJob) @@ -15378,17 +15379,12 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver, qemuDomainSnapshotDiskDataPtr diskdata = NULL; size_t ndiskdata = 0; bool blockdev = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV); - g_autoptr(virHashTable) blockNamedNodeData = NULL; if (virDomainObjCheckActive(vm) < 0) return -1; actions = virJSONValueNewArray(); - if (blockdev && - !(blockNamedNodeData = qemuBlockGetNamedNodeData(vm, asyncJob))) - return -1; - /* prepare a list of objects to use in the vm definition so that we don't * have to roll back later */ if (qemuDomainSnapshotDiskPrepare(driver, vm, snap, cfg, reuse, blockdev, @@ -15455,6 +15451,7 @@ qemuDomainSnapshotCreateActiveExternal(virQEMUDriverPtr driver, int compressed; g_autoptr(virCommand) compressor = NULL; virQEMUSaveDataPtr data = NULL; + g_autoptr(virHashTable) blockNamedNodeData = NULL; /* If quiesce was requested, then issue a freeze command, and a * counterpart thaw command when it is actually sent to agent. @@ -15509,6 +15506,13 @@ qemuDomainSnapshotCreateActiveExternal(virQEMUDriverPtr driver, } } + /* We need to collect reply from 'query-named-block-nodes' prior to the + * migration step as qemu deactivates bitmaps after migration so the result + * would be wrong */ + if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV) && + !(blockNamedNodeData = qemuBlockGetNamedNodeData(vm, QEMU_ASYNC_JOB_SNAPSHOT))) + goto cleanup; + /* do the memory snapshot if necessary */ if (memory) { /* check if migration is possible */ @@ -15553,7 +15557,8 @@ qemuDomainSnapshotCreateActiveExternal(virQEMUDriverPtr driver, /* the domain is now paused if a memory snapshot was requested */ - if ((ret = qemuDomainSnapshotCreateDiskActive(driver, vm, snap, flags, cfg, + if ((ret = qemuDomainSnapshotCreateDiskActive(driver, vm, snap, + blockNamedNodeData, flags, cfg, QEMU_ASYNC_JOB_SNAPSHOT)) < 0) goto cleanup; -- 2.26.2

2 1

[PATCH] NEWS: Mention fixes and improvements of BLOCK_THRESHOLD and TLS key tencryption
by Peter Krempa 31 Jul '20

31 Jul '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 8b53d21b8a..1e4c4df1d6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -31,6 +31,16 @@ v6.6.0 (unreleased) Specifying a virtualHW version greater or equal to 7 (ESXi 4.0) will allow you to use up to 10 NICs instead of 4 as it was previously. + * qemu: Support encrypted TLS keys for NBD disks + + The secret key used for disks can now be encrypted similarly to TLS keys + used for migration, chardev and others. + + * qemu: VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD can now be registered for <mirror> + + The event can now be used also for block copy destinations by using the + index of the <mirror> image. + * **Bug fixes** * virdevmapper: Don't use libdevmapper to obtain dependencies @@ -40,6 +50,16 @@ v6.6.0 (unreleased) meant that libdevmapper opened ``/dev/mapper/control`` which wasn't closed and was leaked to QEMU. CVE-2020-14339 + * qemu: Report correct index in VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD + + Starting from libvirt-5.10 with qemu-4.2 the + VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD event would report incorrect device + index when reported for an image from the backing chain of a disk. + + * qemu: Don't fail active layer block commit or block copy in certain cases + + Starting from libvirt-6.5 an active layer block commit or a block copy could + fail if the same destination was used more than once. v6.5.0 (2020-07-03) =================== -- 2.26.2

2 1

[PATCH v2 0/4] bhyve: implement sound device support
by Roman Bogorodskiy 31 Jul '20

31 Jul '20

Changes from v1: Main change is the addition of the "<audio>" element that allows to map the "<sound>" device to the host audio backend. Would appreciate initial feedback on this one, and then I'll proceed with adding more validation. Roman Bogorodskiy (4): bhyve: implement sound device support conf: allow to map sound device to host device bhyve: allow to specify host sound device tests: schema: test bhyvexml2xmloutdata schemas docs/schemas/domaincommon.rng | 36 ++++ src/bhyve/bhyve_capabilities.c | 14 ++ src/bhyve/bhyve_capabilities.h | 1 + src/bhyve/bhyve_command.c | 64 +++++++ src/bhyve/bhyve_device.c | 9 + src/conf/domain_capabilities.c | 4 + src/conf/domain_conf.c | 156 +++++++++++++++++- src/conf/domain_conf.h | 24 +++ src/conf/virconftypes.h | 3 + src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 2 + src/qemu/qemu_driver.c | 5 + src/qemu/qemu_hotplug.c | 3 + src/qemu/qemu_validate.c | 1 + .../bhyvexml2argv-sound.args | 10 ++ .../bhyvexml2argv-sound.ldargs | 3 + .../bhyvexml2argvdata/bhyvexml2argv-sound.xml | 30 ++++ tests/bhyvexml2argvtest.c | 6 +- .../bhyvexml2xmlout-sound.xml | 41 +++++ tests/bhyvexml2xmltest.c | 1 + tests/virschematest.c | 3 +- 23 files changed, 416 insertions(+), 4 deletions(-) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-sound.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-sound.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-sound.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-sound.xml -- 2.27.0

2 9

[PATCH] qemu: Do not silently allow non-available timers on non-x86 systems
by Thomas Huth 31 Jul '20

31 Jul '20

libvirt currently silently allows <timer name="kvmclock"/> and some other timer tags in the guest XML definition for timers that do not exist on non-x86 systems. We should not silently ignore these tags since the users might not get what they expected otherwise. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1754887 Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- src/qemu/qemu_validate.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 488f258d00..667ac5cc23 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -371,6 +371,18 @@ qemuValidateDomainDefClockTimers(const virDomainDef *def, case VIR_DOMAIN_TIMER_NAME_TSC: case VIR_DOMAIN_TIMER_NAME_KVMCLOCK: case VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK: + if (!ARCH_IS_X86(def->os.arch)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Configuring the '%s' timer is not supported " + "for virtType=%s arch=%s machine=%s guests"), + virDomainTimerNameTypeToString(timer->name), + virDomainVirtTypeToString(def->virtType), + virArchToString(def->os.arch), + def->os.machine); + return -1; + } + break; + case VIR_DOMAIN_TIMER_NAME_LAST: break; -- 2.18.1

3 3