- Devel - libvirt List Archives

[libvirt PATCH] README: drop Travis CI badge
by Ján Tomko 03 Aug '20

03 Aug '20

We stopped using Travis as of: commit c66ccb65f6a758e4c1660e153887b73b1478fe02 ci: Remove Travis CI Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. README.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.rst b/README.rst index ac6a4cd3e9..daabe76477 100644 --- a/README.rst +++ b/README.rst @@ -1,9 +1,6 @@ .. image:: https://gitlab.com/libvirt/libvirt/badges/master/pipeline.svg :target: https://gitlab.com/libvirt/libvirt/pipelines :alt: GitLab CI Build Status -.. image:: https://travis-ci.org/libvirt/libvirt.svg - :target: https://travis-ci.org/libvirt/libvirt - :alt: Travis CI Build Status .. image:: https://bestpractices.coreinfrastructure.org/projects/355/badge :target: https://bestpractices.coreinfrastructure.org/projects/355 :alt: CII Best Practices -- 2.26.2

2 1

[PATCH 0/2] docs: Simplify build of HTML files and fix 'edit' links for NEWS and hvsupport
by Peter Krempa 03 Aug '20

03 Aug '20

Peter Krempa (2): docs: meson: Simplify generation of html files docs: build: Use proper path to file in 'contribute' link docs/meson.build | 46 +++++++++++---------------------------- docs/page.xsl | 14 +++++++----- scripts/meson-html-gen.py | 2 +- 3 files changed, 22 insertions(+), 40 deletions(-) -- 2.26.2

3 4

[PATCH v3 0/2] qemu: support shmem device migration
by Wang Xin 03 Aug '20

03 Aug '20

Shmem device support property role with 'master'(master=on) or 'peer'(master=off, default mode), which controls to copy the shared memory on migration to the destination host or not. see https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/system/ivshmem.rst;hb=… The 1st patch add attribute 'role', it based on Martin's old patch https://www.redhat.com/archives/libvir-list/2016-September/msg00536.html The 2nd patch remove shmem name check in migraiton, which allows user change shared memory path on destination host. v3 -> v2: 1. Correct description of shmem ��role�� attribute. If there is any mistake in the description, please show me. Sorry for my poor English :) 2. Remove the inappropriate suggestion in migration log. 3. allow shmem name change in migration, instead add a new 'mem-path' attribute. v2 -> v1: Fix ivshmem testcases failure. Wang Xin (2): qemu: add support for shmem-{plain, doorbell} role conf: allow shmem name change in migration docs/formatdomain.html.in | 13 ++++++- docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 37 +++++++++++++++++-- src/conf/domain_conf.h | 10 +++++ src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 17 ++++++++- src/qemu/qemu_migration.c | 20 ++++++++-- .../qemuhotplug-ivshmem-plain-detach.xml | 2 +- .../qemuhotplug-ivshmem-plain.xml | 2 +- ...qemuhotplug-base-live+ivshmem-doorbell.xml | 2 +- .../qemuhotplug-base-live+ivshmem-plain.xml | 2 +- .../shmem-plain-doorbell.args | 6 ++- .../qemuxml2argvdata/shmem-plain-doorbell.xml | 4 +- .../shmem-plain-doorbell.xml | 4 +- tests/qemuxml2xmltest.c | 3 +- 15 files changed, 110 insertions(+), 22 deletions(-) -- 2.23.0

3 10

[PATCH 0/2] kbase: debuglogs: Ask for more data and add filter examples
by Peter Krempa 03 Aug '20

03 Aug '20

Peter Krempa (2): kbase: debuglogs: Include more data to attach to bugreports kbase: debuglogs: Add some more example filters settings docs/kbase/debuglogs.rst | 54 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 50 insertions(+), 4 deletions(-) -- 2.26.2

2 4

[libvirt PATCH] util: virlog.h: fix macro indentation
by Ján Tomko 03 Aug '20

03 Aug '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. src/util/virlog.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virlog.h b/src/util/virlog.h index 716fb9a378..37870e514c 100644 --- a/src/util/virlog.h +++ b/src/util/virlog.h @@ -27,10 +27,10 @@ #ifdef PACKAGER_VERSION # ifdef PACKAGER # define VIR_LOG_VERSION_STRING \ - "libvirt version: " VERSION ", package: " PACKAGER_VERSION " (" PACKAGER ")" + "libvirt version: " VERSION ", package: " PACKAGER_VERSION " (" PACKAGER ")" # else # define VIR_LOG_VERSION_STRING \ - "libvirt version: " VERSION ", package: " PACKAGER_VERSION + "libvirt version: " VERSION ", package: " PACKAGER_VERSION # endif #else # define VIR_LOG_VERSION_STRING \ @@ -88,7 +88,7 @@ struct _virLogSource { virLogMessage(src, VIR_LOG_ERROR, filename, linenr, funcname, NULL, __VA_ARGS__) #define VIR_DEBUG(...) \ - VIR_DEBUG_INT(&virLogSelf, __FILE__, __LINE__, __func__, __VA_ARGS__) + VIR_DEBUG_INT(&virLogSelf, __FILE__, __LINE__, __func__, __VA_ARGS__) #define VIR_INFO(...) \ VIR_INFO_INT(&virLogSelf, __FILE__, __LINE__, __func__, __VA_ARGS__) #define VIR_WARN(...) \ -- 2.26.2

1 0

[libvirt PATCH] util: cgroup: remove unused opts in virCgroupV2BindMount
by Ján Tomko 03 Aug '20

03 Aug '20

In virCgroupV2BindMount there is an unused variable containing what seem to be tmpfs mount options. Delete it. Unlike with cgroups v1, we do not create a tmpfs here. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/util/vircgroupv2.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c index 80f596542c..bf6b4a298c 100644 --- a/src/util/vircgroupv2.c +++ b/src/util/vircgroupv2.c @@ -548,9 +548,8 @@ virCgroupV2KillRecursive(virCgroupPtr group, static int virCgroupV2BindMount(virCgroupPtr group, const char *oldroot, - const char *mountopts) + const char *mountopts G_GNUC_UNUSED) { - g_autofree char *opts = NULL; g_autofree char *src = NULL; VIR_DEBUG("Mounting cgroups at '%s'", group->unified.mountPoint); @@ -561,8 +560,6 @@ virCgroupV2BindMount(virCgroupPtr group, return -1; } - opts = g_strdup_printf("mode=755,size=65536%s", mountopts); - src = g_strdup_printf("%s%s", oldroot, group->unified.mountPoint); if (mount(src, group->unified.mountPoint, "none", MS_BIND, NULL) < 0) { -- 2.26.2

2 1

[libvirt PATCH] Remove unused variables
by Ján Tomko 03 Aug '20

03 Aug '20

These variables are only used for assignment and have no other effect. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Found by clang-analyzer. Just install the package with scan-build and run: ninja -C build scan-build (or some meson --reconfigure might be necessary. OTOH, I did not get ninja coverage to work so far.) src/conf/domain_conf.c | 4 +--- src/util/virdevmapper.c | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index fd8cdb7695..69e0439e7e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8857,8 +8857,6 @@ virDomainHostdevDefParseXMLCaps(xmlNodePtr node G_GNUC_UNUSED, const char *type, virDomainHostdevDefPtr def) { - xmlNodePtr sourcenode; - /* @type is passed in from the caller rather than read from the * xml document, because it is specified in different places for * different kinds of defs - it is an attribute of @@ -8881,7 +8879,7 @@ virDomainHostdevDefParseXMLCaps(xmlNodePtr node G_GNUC_UNUSED, return -1; } - if (!(sourcenode = virXPathNode("./source", ctxt))) { + if (!virXPathNode("./source", ctxt)) { virReportError(VIR_ERR_XML_ERROR, "%s", _("Missing <source> element in hostdev device")); return -1; diff --git a/src/util/virdevmapper.c b/src/util/virdevmapper.c index a471504176..fe7f611496 100644 --- a/src/util/virdevmapper.c +++ b/src/util/virdevmapper.c @@ -162,7 +162,6 @@ virDMSanitizepath(const char *path) DIR *dh = NULL; const char *p; char *ret = NULL; - int rc; /* If a path is NOT provided then assume it's DM name */ p = strrchr(path, '/'); @@ -192,7 +191,7 @@ virDMSanitizepath(const char *path) if (virDirOpen(&dh, DEV_DM_DIR) < 0) return NULL; - while ((rc = virDirRead(dh, &ent, DEV_DM_DIR)) > 0) { + while (virDirRead(dh, &ent, DEV_DM_DIR) > 0) { g_autofree char *tmp = g_strdup_printf(DEV_DM_DIR "/%s", ent->d_name); if (stat(tmp, &sb[1]) == 0 && -- 2.26.2

2 1

[libvirt PATCH 0/3] Run more syntax checks
by Ján Tomko 03 Aug '20

03 Aug '20

Some were left out during the meson conversion. Ján Tomko (3): config.h: add a copyright blurb build-aux: set the PYTHON variable in the Makefile build-aux: add sc_ prefix to more syntax checks build-aux/Makefile.in | 1 + build-aux/meson.build | 1 + build-aux/syntax-check.mk | 18 +++++++++--------- config.h | 18 ++++++++++++++++++ 4 files changed, 29 insertions(+), 9 deletions(-) -- 2.26.2

2 5

[libvirt PATCH 0/6] Use more of GLib's g_str functions
by Ján Tomko 03 Aug '20

03 Aug '20

3 13

[libvirt PATCH 0/6] Clean up some includes
by Ján Tomko 03 Aug '20

03 Aug '20

2 7