- Devel - libvirt List Archives

[Libvir] [PATCH] make xen compile -Werror and without PROXY turned on (the autobuild config)
by Hugh Brock 06 Jun '07

06 Jun '07

$SUBJECT says it all... --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock(a)redhat.com | virtualization library http://libvirt.org

2 1

Re: [Libvir] [PATCH] add scheduler API(take 3?)
by Richard W.M. Jones 04 Jun '07

04 Jun '07

+char * +virDomainGetSchedulerType(virDomainPtr domain, int *nparams) +{ + virConnectPtr conn; + char *schedtype; + + if (domain == NULL) { + TODO + return NULL; + } Is this case an error, or were you thinking of adding more semantics later on here? (and the same comment for virDomainGet/SetSchedulerParameters) +static int +cmdSchedinfo(vshControl * ctl, vshCmd * cmd) +{ [...] + char *str_weight = strdup("weight"); + char *str_cap = strdup("cap"); + + nparams = malloc(sizeof(int)); + *nparams = 0; + + if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) + return FALSE; There's still a problem memory leak here. + /* Currently supports Xen Credit only */ + weight = vshCommandOptInt(cmd, "weight", &weightfound); + if(weightfound){ inputparam++; } + + cap = vshCommandOptInt(cmd, "cap", &capfound); + if(capfound){ inputparam++; } and can this be made so it isn't Xen-specific? + if ((domain == NULL) || (domain->conn == NULL)) + return -1; + + priv = (xenUnifiedPrivatePtr) domain->conn->privateData; + if (priv->handle < 0 || domain->id < 0) + return -1; At the lowest level, these functions should return error messages back to the upper layers. Otherwise users have nothing to diagnose errors with. + /* + * Support only dom_interface_version >=5 + * (Xen3.1.0 or later) + */ + if (dom_interface_version < 5) + return -1; Is this because earlier hypervisors didn't support this, or is it just not implemented? Rich.

3 7

[Libvir] [PATCH] Fix strange error message in virsh attach-device
by Masayuki Sunou 04 Jun '07

04 Jun '07

Hi Now, virsh attach-device displays the following messages when "device" attribute of "disk" element is "floppy" in XML. # virsh attach-device HVM_RH4_file floppy.xml libvir: Xen Daemon error : POST operation failed: (xend.err 'Invalid Configuration: XendConfig: @\x14\xce not a valid device type') error: Failed to attach device from floppy.xml This patch fixes this strange error message displaying "@\x14\xce". Description of this patch VirDomainParseXMLDiskDesc() returns 0 without putting data in virBuffer, when "floppy" is set. Therefore, virParseXMLDevice() returns no initialized data, and xenDaemonAttachDevice() passes Xen this data. Because virDomainParseXMLDesc() works wrong when this patch changes return value of VirDomainParseXMLDiskDesc(),this patch fixes virParseXMLDevice() as follows. - Initialize data - Return error if data does not change. As a result, xenDaemonAttachDevice() doesn't pass strange data to Xen, and Xen doesn't return strange error message. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: src/xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.73 diff -u -p -r1.73 xml.c --- src/xml.c 23 Apr 2007 07:41:23 -0000 1.73 +++ src/xml.c 25 May 2007 09:46:56 -0000 @@ -1481,6 +1481,7 @@ virParseXMLDevice(virConnectPtr conn, ch return (NULL); buf.size = 1000; buf.use = 0; + memset(buf.content, 0, (size_t)buf.size); xml = xmlReadDoc((const xmlChar *) xmldesc, "domain.xml", NULL, XML_PARSE_NOENT | XML_PARSE_NONET | XML_PARSE_NOERROR | XML_PARSE_NOWARNING); @@ -1492,6 +1493,9 @@ virParseXMLDevice(virConnectPtr conn, ch if (xmlStrEqual(node->name, BAD_CAST "disk")) { if (virDomainParseXMLDiskDesc(conn, node, &buf, hvm, xendConfigVersion) != 0) goto error; + /* SXP is not created when device is "floppy". */ + else if (!strlen(buf.content)) + goto error; } else if (xmlStrEqual(node->name, BAD_CAST "interface")) { if (virDomainParseXMLIfDesc(conn, node, &buf, hvm) != 0) ----------------------------------------------------------------------

2 5

[Libvir] Use virsh to monitor qemud
by Fabian Deutsch 04 Jun '07

04 Jun '07

Hey, I jsut installed Fedora 7 and tried to install some guests and it worked like a charm. I use qemu for full virtulization. A couple of minutes later i stumbled across libvirts virtsh. But now I wonder how I cna use virtsh to connect to qemud - all I get is something like: "Can't connect to hyperisor." - fabiand

3 4

[Libvir] SOLVED Re: cannot use vncviewer and VMM graphics console to access HVM guest on RHES 5
by Glen Deem 03 Jun '07

03 Jun '07

Thanks to Igor Chubin (spasibo) and Richard Jones, the qemu vnc server was listening but I did not connect to its proper port (why libvirt doesn't use <IP>:<domU id> kind of vnc connection and restricts the server to local host only by default?). Regards, Glen On 5/31/07, Glen Deem <xen.inbox@XXXXXXXXX> wrote: > Hi all, > > I've created an HVM guest under RHES 5 (Xen 3.0.3) using "xm create" > but I cannot access it with vncviewer. > > The Virtual Machine Manager also informs about graphics console unavailability. > > What am I doing wrong, please? > > I do > > vncviewer 123.456.789.123:4, > where 4 is the guest id. > > This is the xm config file is: > > name = "hvmGuest" > builder = "hvm" > memory = "500" > disk = [ 'file:/var/lib/red-hat.img,hda,w', ] > vif = [ 'type=ioemu, mac=00:16:3e:34:3b:ba, bridge=xenbr0', ] > device_model = "/usr/lib/xen/bin/qemu-dm" > kernel = "/usr/lib/xen/boot/hvmloader" > vnc=1 > vncunused=1 > apic=1 > acpi=1 > pae=1 > vcpus=1 > serial = "pty" > on_reboot = 'restart' > on_crash = 'restart' > > Thanks a lot in advance. > > Glen from Ottawa, Canada >

4 4

[Libvir] Re: [Xen-users] SOLVED Re: cannot use vncviewer and VMM graphics console to access HVM guest on RHES 5
by Glen Deem 02 Jun '07

02 Jun '07

Hi Dan, I'm with you about the VNC authentication. But I still don't understand the logic behind assigning HVM displays. Instead of clear "domU ID is the display number" (vncunused 0), the Virtual Machine Manager assigns vncunused to 1 and then calculates the 5900+ port, I suppose depending on what port is not occupied (BTW where exactly is this code in the source, please?). Why is that? And how am I suppose to find out what that port number is if I'd want to connect to a VMM-created vm manually with my vnc client? Thanks, Glen Daniel P. Berrange wrote: > On Fri, Jun 01, 2007 at 11:03:36AM -0400, Glen Deem wrote: >> Thanks to Igor Chubin (spasibo) and Richard Jones, the qemu vnc server >> was listening but I did not connect to its proper port (why libvirt >> doesn't use <IP>:<domU id> kind of vnc connection and restricts the >> server to local host only by default?). > > VNC authentication is an utter joke. It can be trivially brute forced > so exposing it on a public IP address is not a good idea, hence the > default is 127.0.0.1, though even that's not ideal because it is still > exposed to local users. Ultimately VNC needs to have SSL/TLS support > integrated into it to allow secure access over public network, which > is something I'm working on for QEMU... > > Dan.

2 1

[Libvir] cannot use vncviewer and VMM graphics console to access HVM guest on RHES 5
by Glen Deem 01 Jun '07

01 Jun '07

Hi all, I've created an HVM guest under RHES 5 (Xen 3.0.3) using "xm create" but I cannot access it with vncviewer. The Virtual Machine Manager also informs about graphics console unavailability. What am I doing wrong, please? I do > vncviewer 123.456.789.123:4, where 4 is the guest id. This is the xm config file is: name = "hvmGuest" builder = "hvm" memory = "500" disk = [ 'file:/var/lib/red-hat.img,hda,w', ] vif = [ 'type=ioemu, mac=00:16:3e:34:3b:ba, bridge=xenbr0', ] device_model = "/usr/lib/xen/bin/qemu-dm" kernel = "/usr/lib/xen/boot/hvmloader" vnc=1 vncunused=1 apic=1 acpi=1 pae=1 vcpus=1 serial = "pty" on_reboot = 'restart' on_crash = 'restart' Thanks a lot in advance. Glen from Ottawa, Canada

3 2

Re: [Libvir] Debian package structure
by Marco Sinhoreli 01 Jun '07

01 Jun '07

On 5/30/07, Richard W.M. Jones <rjones(a)redhat.com> wrote: > > Marco Sinhoreli wrote: > > hello all, > > > > I have been worked in libvirt, virt-manager and virtinst packages to > > Debian for a weeks. Packages are now stabilized. Following below the > > /debian directories structure for analise. > > * libvirt: > > svn co http://svn.mussicorp.net/projetos/src/xen/libvirt/trunk/ > > In debian/rules you shouldn't need this any longer (with latest CVS): > > export CFLAGS += -fno-stack-protector I know it is fixed for libvirt, but it is nedded to fix virt-manager too. That's why I keep it in this package. > * Virt-manager: > > svn co > > > http://svn.mussicorp.net/projetos/src/xen/virt-manager/virt-manager/trunk/ > > Shouldn't virt-manager Depends: on python-libvirt and virtinst? My fault. I'll fix it. It should probably Build-Depends: on (eg) cdbs too, since firstly you're > using cdbs in debian/rules, and secondly virt-manager isn't pure Python > - it contains a C-based widget. okay. I'll pay attention on that. Not clear what the postrm was for. Is there configuration kept in > /usr/share/virt-manager? My fault. I'll checked it. Thanks

1 0

[Libvir] Debian package structure
by Marco Sinhoreli 31 May '07

31 May '07

hello all, I have been worked in libvirt, virt-manager and virtinst packages to Debian for a weeks. Packages are now stabilized. Following below the /debian directories structure for analise. * libvirt: svn co http://svn.mussicorp.net/projetos/src/xen/libvirt/trunk/ * Virt-manager: svn co http://svn.mussicorp.net/projetos/src/xen/virt-manager/virt-manager/trunk/ * Virtinst: svn co http://svn.mussicorp.net/projetos/src/xen/virt-manager/virtinst/trunk/ Best regards, -- Marco Sinhoreli

2 1

Re: [Libvir] Error while run make: undefined reference to `xenHypervisorMakeCapabilitiesXML'
by Marco Sinhoreli 30 May '07

30 May '07

Thanks, I had a problem with my libxen package. The /usr/lib/libxenstore.so wasn't linked to /usr/lib/libxenstore.so.3.0.0. Regards, > > On 5/29/07, Daniel Veillard <veillard(a)redhat.com> wrote: > > > > On Mon, May 28, 2007 at 11:26:18AM -0400, Daniel Veillard wrote: > > > On Mon, May 28, 2007 at 12:15:31PM -0300, Marco Sinhoreli wrote: > > > > Hello list, > > > > > > > > I'm with this error while I am compiling the libvirt: > > > > > > > > xencapstest.o: In function `testCompareFiles': > > > > /usr/src/libvirt/tests/xencapstest.c:33: undefined reference to > > > > `xenHypervisorMakeCapabilitiesXML' > > > > collect2: ld returned 1 exit status > > > > > > > > Any idea? > > > > > > What version ? I guess it comes when compiling on a machine where > > > Xen developments environment is not present, this ought to be fixed > > > if not already in CVS, > > > > actually I can reproduce that to on CVs head, will fix ! > > > > Daniel > > > > -- > > Red Hat Virtualization group http://redhat.com/virtualization/ > > Daniel Veillard | virtualization library http://libvirt.org/ > > veillard(a)redhat.com | libxml GNOME XML XSLT toolkit > > http://xmlsoft.org/ > > http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ > > > > > > -- > Marco Sinhoreli -- Marco Sinhoreli

1 0