- Devel - libvirt List Archives

[Libvir] [PATCH] _N() has a conflict in Solaris
by Mark Johnson 15 Jun '07

15 Jun '07

There is a conflict with _N() in Solaris. Mark

3 4

[Libvir] [PATCH] setvcpus message
by Mark Johnson 15 Jun '07

15 Jun '07

This patch is probably not correct. I wasn't sure how to handle I18N in libvirt. Had a request to add an error message for setvcpus <domain> 0. This patch prints an error message for that case. Mark

3 2

[Libvir] [PATCH] return 0 networks if Network driver not implemented
by Mark Johnson 15 Jun '07

15 Jun '07

This handles net-list, etc. a little more gracefully for Xen. Mark

3 3

[Libvir] Solaris patches applied
by Richard W.M. Jones 15 Jun '07

15 Jun '07

I applied the easy ones: * src/internal.h, src/virsh.c: Replace _N with N_ so that Solaris builds work (Mark Johnson). * src/virsh.c: Add a couple of missing error messages (Mark Johnson). * python/types.c: Fix NULL pointer deref on DEBUG build (Mark Johnson). * src/virsh.c: Spelling fix (Mark Johnson). I can't test if it works on Solaris, but it still builds on Linux. Now to look at the last patch you sent ... Thanks for your contribution to libvirt. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] [PATCH] vcpuinfo message
by Mark Johnson 15 Jun '07

15 Jun '07

Another requested error message. This prints out a message if the vcpuinfo failed because the domain was shutdown. same comment as previous patch about I18N. Mark

2 1

[Libvir] [PATCH] Spelling fix
by Mark Johnson 15 Jun '07

15 Jun '07

Hi all, This is the first of 10 or 11 patches I'll be submitting which gets libvirt compiling/working on a Solaris dom0. Also some minor generic bug fixing.. Sorry it took me so long from the Xen Summit.. Starting with a very simple one. :-) As I test them on the cvs tree on Fedora, I'll submit them.. So they'll trickle in over the next couple of days. A couple of them will probably require some discussion and changes. I'm applying the patches with the following # patch -t -s -p1 -i ../patches/spelling on todays CVS gate and tested on a fedora 7 dom0 (LD_PRELOAD=src/.libs/libvirt.so src/.libs/virsh) Thanks, Mark

3 2

[Libvir] [PATCH] null pointer fix on debug build
by Mark Johnson 15 Jun '07

15 Jun '07

this fixes a null pointer dereference in printf on a DEBUG build. Mark

2 1

[Libvir] [PATCH] fix the Japanese messages
by Saori Fukuta 14 Jun '07

14 Jun '07

Hi, We are making a review of the Japanese messages. And we fix Japanese help messages first. Signed-off-by: Saori Fukuta <fukuta.saori(a)jp.fujitsu.com>, Minoru Takata <takata.minoru(a)jp.fujitsu.com> Best regards, Saori Fukuta Minoru Takata

4 5

[Libvir] no vfb for paravirt guest on RHEL 5 and strange args
by Glen Deem 13 Jun '07

13 Jun '07

Hi all, I'm creating a fairy simple paravirt machine under RHEL 5 (Xen 3.0.3, pygrub 0.6). A machine gets created but I see two problems: 1. no graphics console gets enabled (so RedHat VMM does not open it) so I cannot connect to it with vncviewer (am I naive to use vfb fpr a paravirt domU? - libvirt uses it, right?); 2. when I check what config has been used to create the domain (in /var/log/xen/xend.log) I see arguments ("args" or "extra") picked up from a virtual machine created a while age, my present "extra" parameter is ignored. I did regenerate xenstored/tdb and rebooted, still those args appear, drives my nuts :-). I'm actually after the graphics console, but I think both problems are related. Could anybody advise why I get no proper vfb setup (I'd expect a vnc-port vaue appearing in the xen store when it setup properly) and why I get those old args? Thanks in advance, Deem P.S. xm config ============ name = "para-2" memory = "256" disk = [ 'file:/var/lib/para-2.img,hda,w' ] vif = [ 'bridge=xenbr0' ] vfb = ['type=vnc, vncunused=1'] bootloader='/usr/bin/pygrub' vcpus=1 on_reboot = 'restart' on_crash = 'restart' extra = 'ignored' from /var/log/xen/xend.log: ================== [2007-06-12 17:13:56 xend.XendDomainInfo 5445] DEBUG (XendDomainInfo:940) XendDomainInfo.handleShutdownWatch [2007-06-12 17:41:57 xend.XendDomainInfo 5445] DEBUG (XendDomainInfo:190) XendDomainInfo.create(['vm', ['name', 'para-2'], ['memory', '256'], ['on_reboot', 'restart'], ['on_crash', 'restart'], ['vcpus', 1], ['bootloader', '/usr/bin/pygrub'], ['image', ['linux', ['ramdisk', '/var/lib/xen/initrd.NMeE1x'], ['kernel', '/var/lib/xen/vmlinuz.7QoaTW'], ['args', 'nosplash quiet rw acpi=on XXHOST=localhost.localdomain XXLDAP=127.0.0.1 resume2=swap:/dev/mapper/XxxxxxVG-swap vga=791 root=/dev/XxxxxxxVG/root']]], ['device', ['vbd', ['uname', 'file:/var/lib/para-2.img'], ['dev', 'hda'], ['mode', 'w']]], ['device', ['vif', ['bridge', 'xenbr0']]], ['device', ['vkbd']], ['device', ['vfb', ['vncunused', '1'], ['type', 'vnc'], ['display', ':0.0'], ['xauthority', '/root/.xauthfLRNzX']]]])

1 0

[Libvir] New vs old-style hypercalls
by Richard W.M. Jones 13 Jun '07

13 Jun '07

In xen_internal.c we've got code which claims to sniff out whether we are using new-style hypercall ioctls or old-style hypercall ioctls. hc.op = __HYPERVISOR_xen_version; hc.arg[0] = (unsigned long) XENVER_version; hc.arg[1] = 0; cmd = IOCTL_PRIVCMD_HYPERCALL; ret = ioctl(fd, cmd, (unsigned long) &hc); if ((ret != -1) && (ret != 0)) { #ifdef DEBUG fprintf(stderr, "Using new hypervisor call: %X\n", ret); #endif hv_version = ret; xen_ioctl_hypercall_cmd = cmd; goto detect_v2; } /* * check if the old hypercall are actually working */ v0_hc.op = __HYPERVISOR_xen_version; v0_hc.arg[0] = (unsigned long) XENVER_version; v0_hc.arg[1] = 0; cmd = _IOC(_IOC_NONE, 'P', 0, sizeof(v0_hypercall_t)); ret = ioctl(fd, cmd, (unsigned long) &v0_hc); But on 64 bit platforms (not 32 bit) cmd will be identical, so we'll just be trying the same ioctl twice. From <xen/linux/privcmd.h>: typedef struct privcmd_hypercall { __u64 op; __u64 arg[5]; } privcmd_hypercall_t; #define IOCTL_PRIVCMD_HYPERCALL \ _IOC(_IOC_NONE, 'P', 0, sizeof(privcmd_hypercall_t)) From src/xen_internal.c: typedef struct v0_hypercall_struct { unsigned long op; unsigned long arg[5]; } v0_hypercall_t; cmd = _IOC(_IOC_NONE, 'P', 0, sizeof(v0_hypercall_t)); On 64 bit platforms, both structures will be the same size. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 1