- Devel - libvirt List Archives

[libvirt] [PATCH] Fix node dumpxml infinite loop
by Cole Robinson 01 Jul '09

01 Jul '09

With current git, doing: 'virsh nodedev-dumpxml computer' locks up the daemon. The list iteration in update_caps was only happening conditionally: if that condition wasn't met, we loop forever. - Cole

3 2

[libvirt] PATCH: Opennebula Documentation updates
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, here are some changes to apply at the ONE Documentation, Thanks Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

2 1

[libvirt] fix for crash in NPIV code
by Dave Allan 01 Jul '09

01 Jul '09

DV found a place in the NPIV code that was freeing the wrong thing in the error case causing a segfault. The patch to fix it follows. Dave diff --git a/src/node_device.c b/src/node_device.c index cd9f0ef..c5b839b 100644 --- a/src/node_device.c +++ b/src/node_device.c @@ -489,8 +489,8 @@ get_wwns(virConnectPtr conn, if (*wwnn == NULL || *wwpn == NULL) { /* Free the other one, if allocated... */ - VIR_FREE(wwnn); - VIR_FREE(wwpn); + VIR_FREE(*wwnn); + VIR_FREE(*wwpn); ret = -1; virReportOOMError(conn); }

2 1

[libvirt] PATCH : Opennebula documentation
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, Attached is the OpenNebula driver documentation and a patch. The main Documentation file is "drvone.html.in" along with it a patch that includes: the API supported by the driver, an entry at "Documentation>Drivers" and a link to the documentation at "drivers.hmtl.in" Thanks --- sitemap.html.in.bak 2009-07-01 12:43:53.000000000 +0200 +++ sitemap.html.in 2009-06-30 18:19:44.000000000 +0200 @@ -148,6 +148,10 @@ <a href="drvvbox.html">VirtualBox</a> Driver for VirtualBox </li> + <li> + <a href="drvone.html">OpenNebula</a> + Driver for OpenNebula + </li> </ul> </li> <li> --- drivers.html.in.bak 2009-07-01 14:54:57.000000000 +0200 +++ drivers.html.in 2009-07-01 14:55:33.000000000 +0200 @@ -23,6 +23,7 @@ <li><a href="drvtest.html">Test</a></li> <li><a href="drvopenvz.html">OpenVZ</a></li> <li><a href="drvvbox.html">VirtualBox</a></li> + <li><a href="drvone.html">OpenNebula</a></li> </ul> </body> </html> --- hvsupport.html.in.bak 2009-07-01 12:41:36.000000000 +0200 +++ hvsupport.html.in 2009-07-01 13:02:38.000000000 +0200 @@ -22,6 +22,7 @@ updated on 2008-06-05. <th><a href="drvkvm.html">KVM</a></th> <th><a href="remote.html">Remote</a></th> <th><a href="drvvbox.html">VirtualBox</a></th> + <th><a href="drvone.html">ONE</a></th> </tr> <tr> <td> virConnectClose </td> @@ -31,6 +32,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetCapabilities </td> @@ -40,6 +42,7 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetHostname </td> @@ -49,6 +52,7 @@ updated on 2008-06-05. <td> ≥ 0.3.3 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virConnectGetMaxVcpus </td> @@ -58,6 +62,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virConnectGetType </td> @@ -67,6 +72,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetURI </td> @@ -76,6 +82,7 @@ updated on 2008-06-05. <td> ≥ 0.3.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectGetVersion </td> @@ -85,6 +92,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectListDefinedDomains </td> @@ -94,6 +102,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectListDomains </td> @@ -103,6 +112,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectNumOfDefinedDomains </td> @@ -112,6 +122,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectNumOfDomains </td> @@ -121,6 +132,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectOpen </td> @@ -130,6 +142,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virConnectOpenAuth </td> @@ -139,6 +152,7 @@ updated on 2008-06-05. <td> </td> <td> </td> <td> </td> + <td> </td> </tr> <tr> <td> virConnectOpenReadOnly </td> @@ -148,6 +162,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainAttachDevice </td> @@ -157,6 +172,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainBlockPeek </td> @@ -166,6 +182,7 @@ updated on 2008-06-05. <td> 0.4.3 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainBlockStats </td> @@ -175,6 +192,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCoreDump </td> @@ -184,6 +202,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainCreate </td> @@ -193,6 +212,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainCreateLinux </td> @@ -202,6 +222,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDefineXML </td> @@ -211,6 +232,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDestroy </td> @@ -220,6 +242,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainDetachDevice </td> @@ -229,6 +252,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainFree </td> @@ -238,6 +262,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetAutostart </td> @@ -247,11 +272,12 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetConnect </td> <td> 0.3.0 </td> - <td colspan="5"> not a HV function </td> + <td colspan="6"> not a HV function </td> </tr> <tr> <td> virDomainGetID </td> @@ -261,6 +287,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetInfo </td> @@ -270,6 +297,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetMaxMemory </td> @@ -279,6 +307,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainGetMaxVcpus </td> @@ -288,6 +317,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetName </td> @@ -297,6 +327,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetOSType </td> @@ -306,6 +337,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetSchedulerParameters </td> @@ -315,6 +347,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetSchedulerType </td> @@ -324,6 +357,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetUUID </td> @@ -333,6 +367,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetUUIDString </td> @@ -342,6 +377,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainGetVcpus </td> @@ -351,6 +387,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainInterfaceStats </td> @@ -360,6 +397,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainGetXMLDesc </td> @@ -369,6 +407,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainLookupByID </td> @@ -378,6 +417,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByName </td> @@ -387,6 +427,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByUUID </td> @@ -396,6 +437,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainLookupByUUIDString </td> @@ -405,6 +447,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainMigrate </td> @@ -414,6 +457,7 @@ updated on 2008-06-05. <td> x </td> <td> 0.3.2 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainPinVcpu </td> @@ -423,6 +467,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainReboot </td> @@ -432,6 +477,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainRestore </td> @@ -441,6 +487,8 @@ updated on 2008-06-05. <td> ≥ 0.3.2 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> + </tr> <tr> <td> virDomainResume </td> @@ -450,6 +498,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainSave </td> @@ -459,6 +508,7 @@ updated on 2008-06-05. <td> ≥ 0.3.2 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainSetAutostart </td> @@ -468,6 +518,7 @@ updated on 2008-06-05. <td> ≥ 0.2.1 </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetMaxMemory </td> @@ -476,6 +527,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> ≥ 0.3.0 </td> + <td> x </td> </tr> <tr> <td> virDomainSetMemory </td> @@ -485,6 +537,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virDomainSetSchedulerParameters </td> @@ -494,6 +547,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainSetVcpus </td> @@ -503,6 +557,7 @@ updated on 2008-06-05. <td> x </td> <td> ≥ 0.3.0 </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virDomainShutdown </td> @@ -512,6 +567,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainSuspend </td> @@ -521,6 +577,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virDomainUndefine </td> @@ -530,17 +587,18 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> ≥ 0.6.4 </td> </tr> <tr> <td> virGetVersion </td> <td> All </td> <td> All </td> - <td colspan="4"> Returns -1 if HV unsupported. </td> + <td colspan="5"> Returns -1 if HV unsupported. </td> </tr> <tr> <td> virInitialize </td> <td> 0.1.0 </td> - <td colspan="5"> not a HV function </td> + <td colspan="6"> not a HV function </td> </tr> <tr> <td> virDomainMemoryPeek </td> @@ -550,6 +608,7 @@ updated on 2008-06-05. <td> 0.4.3 </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetInfo </td> @@ -559,6 +618,7 @@ updated on 2008-06-05. <td> ≥ 0.2.0 </td> <td> ≥ 0.3.0 </td> <td> ≥ 0.6.3 </td> + <td> x </td> </tr> <tr> <td> virNodeGetFreeMemory </td> @@ -568,6 +628,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> <tr> <td> virNodeGetCellsFreeMemory </td> @@ -577,6 +638,7 @@ updated on 2008-06-05. <td> x </td> <td> x </td> <td> x </td> + <td> x </td> </tr> </table> <h3>Network functions</h3> Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 2

[libvirt] libvirt 0.6.4: Confusing error message during virDomainRestore() if network not started
by Charles Duffy 01 Jul '09

01 Jul '09

Howdy, 'yall -- I found myself scratching my head for a few minutes trying to start a VM image via virDomainRestore(). Looking through the header definition in the XML, it read as follows: <interface type="network"> <mac address="00:15:3d:49:ec:0e"/> <source network="fvte-MIXED-DEFAULT"/> <target dev="vnet3"/> <model type="e1000"/> </interface> ...and on trying to do a virDomainRestore(), it exited with the following: Traceback (most recent call last): File "/usr/bin/fvte", line 8, in <module> load_entry_point('fvte==1.0', 'console_scripts', 'fvte')() File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1838, in main cli.cmdloop() File "/opt/python25/lib/python2.5/cmd.py", line 142, in cmdloop stop = self.onecmd(line) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1791, in onecmd cmd.Cmd.onecmd(self, c) File "/opt/python25/lib/python2.5/cmd.py", line 219, in onecmd return func(arg) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/cli.py", line 1538, in do_mode self._vmm.vh_set_runmode(name, desired) File "/local/home-aux/cduffy/public_git/fvte/src/m1/fvte/vmmanip.py", line 324, in vh_set_runmode succp = (0 == virt['connect'].restore(ramfile)) File "/opt/python25/lib/python2.5/site-packages/libvirt.py", line 1224, in restore if ret == -1: raise libvirtError ('virDomainRestore() failed', conn=self) libvirt.libvirtError: internal error Failed to add tap interface 'vnet%d' to bridge 'fvtebr0' : No such device The actual issue was that the fvte-MIXED-DEFAULT network was not running, and an appropriate "virsh net-start" allowed the domain to restore correctly; detecting this condition and providing a clearer error message would probably be a Good Thing.

1 0

[libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 01 Jul '09

01 Jul '09

Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes. If you'd like a patch against mainline, I'd be willing to do that. http://karma.colliertech.org/~cjac/tmp/add-arm.patch Cheers, C.J.

1 0

[libvirt] While connecting through xen+ssh, virConnectClose doesn't close the connection
by Alexandru Nedelcu 01 Jul '09

01 Jul '09

Hi, I'm trying to create a Perl script with Sys::Virt (perl bindings). I'm also using Virsh for testing / experimenting, so this is in no way related to my Perl script (I mentioned it because there might be a sollution that I could use / implement). When connecting to libvirtd using a xen+ssh// connection, it connects, libvirt commands are executing, but on virsh "quit" (or when my script terminates), the connection is blocked. It bothers me because my script doesn't terminate. While running with LIBVIRT_DEBUG=1 I get the following messages: 14:30:51.086: debug : virDomainFree:1893 : domain=0x8791ff8 14:30:51.086: debug : virUnrefDomain:367 : unref domain 0x8791ff8 malcolm 1 14:30:51.086: debug : virReleaseDomain:325 : release domain 0x8791ff8 malcolm 14:30:51.087: debug : virReleaseDomain:337 : unref connection 0x87308a0 3 14:30:51.087: debug : virDomainFree:1893 : domain=0x8791f28 14:30:51.087: debug : virUnrefDomain:367 : unref domain 0x8791f28 Domain-0 1 14:30:51.087: debug : virReleaseDomain:325 : release domain 0x8791f28 Domain-0 14:30:51.087: debug : virReleaseDomain:337 : unref connection 0x87308a0 2 14:30:51.087: debug : virConnectClose:1203 : conn=0x87308a0 14:30:51.087: debug : call:6947 : Doing call 2 (nil) 14:30:51.087: debug : call:7017 : We have the buck 2 0x8796f68 0x8796f68 14:30:51.090: debug : processCallRecvLen:6605 : Got length, now need 28 total (24 more) 14:30:51.090: debug : processCalls:6873 : Giving up the buck 2 0x8796f68 (nil) 14:30:51.090: debug : call:7048 : All done with our call 2 (nil) 0x8796f68 Is this normal? Thanks,

1 0

[libvirt] PATCH : Opennebula, adding xen i686 domain capability and updating some error messages
by "Abel Míguez Rodríguez" 01 Jul '09

01 Jul '09

Hi, this patch uses "OPERATION_INVALID" error instead "OPERATION_FAILED" error where should be used, also adds a missing capability, defining Xen i686 domains. Thanks for the patches, --- one_driver.c.bak 2009-06-30 15:02:28.000000000 +0200 +++ one_driver.c 2009-06-30 15:02:29.000000000 +0200 @@ -505,7 +505,7 @@ static int oneDomainShutdown(virDomainPt ret= 0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } @@ -541,7 +541,7 @@ static int oneDomainDestroy(virDomainPtr if(c_oneCancel(vm->pid)) { /* VM not running, delete the instance at ONE DB */ if(c_oneFinalize(vm->pid)){ - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } @@ -576,11 +576,11 @@ static int oneDomainSuspend(virDomainPtr ret=0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } - oneError(dom->conn,dom,VIR_ERR_OPERATION_FAILED, + oneError(dom->conn,dom,VIR_ERR_OPERATION_INVALID, _("domain is not running")); } else { oneError(dom->conn, dom, VIR_ERR_INVALID_DOMAIN, @@ -609,11 +609,11 @@ static int oneDomainResume(virDomainPtr ret=0; goto return_point; } - oneError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + oneError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, _("Wrong state to perform action")); goto return_point; } - oneError(dom->conn,dom,VIR_ERR_OPERATION_FAILED, + oneError(dom->conn,dom,VIR_ERR_OPERATION_INVALID, _("domain is not paused ")); } else { oneError(dom->conn, dom, VIR_ERR_INVALID_DOMAIN, --- one_conf.c.bak 2009-06-30 15:01:06.000000000 +0200 +++ one_conf.c 2009-06-30 15:00:58.000000000 +0200 @@ -94,6 +94,27 @@ virCapsPtr oneCapsInit(void) { goto no_memory; } + if ((guest = virCapabilitiesAddGuest(caps, + "xen", + "i686", + 32, + NULL, + NULL, + 0, + NULL)) == NULL) + { + goto no_memory; + } + if (virCapabilitiesAddGuestDomain(guest, + "one", + NULL, + NULL, + 0, + NULL) == NULL) + { + goto no_memory; + } + return caps; Abel Miguez Rodriguez ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 4

[libvirt] [PATCH] logging: remove unused level 0
by Amy Griffis 01 Jul '09

01 Jul '09

Some more logging cleanup. Remove all references to log level 0, and replace with VIR_LOG_DEBUG where appropriate. Also change any hard numbers to the corresponding VirLogPriority and add VIR_LOG_DEFAULT for the starting log level. Signed-off-by: Amy Griffis <amy.griffis(a)hp.com --- docs/logging.html.in | 6 ++---- qemud/libvirtd.conf | 5 ++--- qemud/qemud.c | 11 ++++++----- src/logging.c | 10 +++++----- src/logging.h | 2 ++ 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/docs/logging.html.in b/docs/logging.html.in index 11ea68c..fcd100f 100644 --- a/docs/logging.html.in +++ b/docs/logging.html.in @@ -49,7 +49,6 @@ <ul> <li>log_level: accepts the following values: <ul> - <li>0: no logging at all</li> <li>4: only errors</li> <li>3: warnings and errors</li> <li>2: informations, warnings and errors</li> @@ -84,20 +83,19 @@ </ul> In all cases the x prefix is the minimal level, acting as a filter: <ul> - <li>0: everything</li> <li>1: DEBUG</li> <li>2: INFO</li> <li>3: WARNING</li> <li>4: ERROR</li> </ul> Multiple output can be defined , they just need to be separated by - spaces, e.g.: <code>"3:syslog:libvirtd 0:file:/tmp/libvirt.log"</code> + spaces, e.g.: <code>"3:syslog:libvirtd 1:file:/tmp/libvirt.log"</code> will log all warnings and errors to syslog under the libvirtd ident but also log everything debugging and informations included in the file <code>/tmp/libvirt.log</code> For example setting up the following: <pre>export LIBVIRT_DEBUG=1 -export LIBVIRT_LOG_OUTPUTS="0:file:virsh.log"</pre> +export LIBVIRT_LOG_OUTPUTS="1:file:virsh.log"</pre> and then running virsh will accumulate the logs in the <code>virsh.log</code> file in a way similar to: <pre>14:29:04.771: debug : virInitialize:278 : register drivers diff --git a/qemud/libvirtd.conf b/qemud/libvirtd.conf index 1fd5918..49de466 100644 --- a/qemud/libvirtd.conf +++ b/qemud/libvirtd.conf @@ -269,7 +269,7 @@ # Logging controls # -# Logging level: 0 none, 4 errors, 3 warnings, 2 informations, 1 debug +# Logging level: 4 errors, 3 warnings, 2 informations, 1 debug # basically 1 will log everything possible #log_level = 3 @@ -303,13 +303,12 @@ # x:file:file_path # output to a file, with the given filepath # In all case the x prefix is the minimal level, acting as a filter -# 0: everything # 1: DEBUG # 2: INFO # 3: WARNING # 4: ERROR # -# Multiple output can be defined , they just need to be separated by spaces. +# Multiple output can be defined, they just need to be separated by spaces. # e.g.: # log_outputs="3:syslog:libvirtd" # to log all warnings and errors to syslog under the libvirtd ident diff --git a/qemud/qemud.c b/qemud/qemud.c index b5e3665..da20aa9 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -128,7 +128,7 @@ static int sigwrite = -1; /* Signal handler pipe */ static int ipsock = 0; /* -l Listen for TCP/IP */ /* Defaults for logging */ -static int log_level = 3; +static int log_level = VIR_LOG_DEFAULT; static char *log_filters = NULL; static char *log_outputs = NULL; @@ -2499,15 +2499,16 @@ qemudSetLogging(virConfPtr conf, const char *filename) { log_outputs = strdup(debugEnv); } if (!log_outputs) { + char *tmp = NULL; if (godaemon) { - char *tmp = NULL; if (virAsprintf (&tmp, "%d:syslog:libvirtd", log_level) < 0) goto free_and_fail; - virLogParseOutputs (tmp); - VIR_FREE (tmp); } else { - virLogParseOutputs("0:stderr:libvirtd"); + if (virAsprintf(&tmp, "%d:stderr", log_level) < 0) + goto free_and_fail; } + virLogParseOutputs(tmp); + VIR_FREE(tmp); } else { virLogParseOutputs(log_outputs); } diff --git a/src/logging.c b/src/logging.c index fd1d5d4..d13ae0f 100644 --- a/src/logging.c +++ b/src/logging.c @@ -119,7 +119,7 @@ static int virLogNbOutputs = 0; /* * Default priorities */ -static virLogPriority virLogDefaultPriority = VIR_LOG_WARN; +static virLogPriority virLogDefaultPriority = VIR_LOG_DEFAULT; static int virLogResetFilters(void); static int virLogResetOutputs(void); @@ -174,7 +174,7 @@ int virLogStartup(void) { virLogLen = 0; virLogStart = 0; virLogEnd = 0; - virLogDefaultPriority = VIR_LOG_WARN; + virLogDefaultPriority = VIR_LOG_DEFAULT; virLogUnlock(); return(0); } @@ -196,7 +196,7 @@ int virLogReset(void) { virLogLen = 0; virLogStart = 0; virLogEnd = 0; - virLogDefaultPriority = VIR_LOG_WARN; + virLogDefaultPriority = VIR_LOG_DEFAULT; virLogUnlock(); return(0); } @@ -689,7 +689,7 @@ int virLogParseOutputs(const char *outputs) { virSkipSpaces(&cur); while (*cur != 0) { prio= virParseNumber(&cur); - if ((prio < 0) || (prio > 4)) + if ((prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) return(-1); if (*cur != ':') return(-1); @@ -770,7 +770,7 @@ int virLogParseFilters(const char *filters) { virSkipSpaces(&cur); while (*cur != 0) { prio= virParseNumber(&cur); - if ((prio < 0) || (prio > 4)) + if ((prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) return(-1); if (*cur != ':') return(-1); diff --git a/src/logging.h b/src/logging.h index d99bb31..0b9ae79 100644 --- a/src/logging.h +++ b/src/logging.h @@ -77,6 +77,8 @@ typedef enum { VIR_LOG_ERROR, } virLogPriority; +#define VIR_LOG_DEFAULT VIR_LOG_WARN + /** * virLogOutputFunc: * @category: the category for the message

3 3

[libvirt] Upcoming 0.6.5 release and switching the main SCM engine (to git)
by Daniel Veillard 01 Jul '09

01 Jul '09

A couple of things I wanted to raise. - First we have a release 0.6.5 at the end of the week, so we are in bug fix mode, it would be good if people could make a round of testing of the latest CVS/git version or the snapshot at ftp://libvirt.org/libvirt/libvirt-cvs-snapshot.tar.gz The snapshot generation was proken in the previous months but I fixed it today. - Another point is that we use CVS as the SCM, that's historical, that's what I was used to when I created the project but clearly most people now use the git mirror (or mercurial) to generate their patches. I tried to assert how much git was prevalent, at least for patches embedded within the mail content a large majority are git generated: paphio:~/Mail -> tail -100000 libvir | grep "^diff" | wc -l 268 paphio:~/Mail -> tail -100000 libvir | grep "^diff" | grep -- '-git' | wc -l 182 that doesn't account mails which are attached and base64 encoded but I think it's reasonnable to conclude most of people sending patches generated them out of a git tree. CVS certainly show its age, too ! So my plan would be to switch out of CVS and make git the primary SCM, Jim Meyering is already maintaining the current git tree, so the plan would be to create a new main git tree on libvirt.org based on the existing git://git.et.redhat.com/libvirt.git tree, maybe fixing a couple of things in the process, and desactivate the CVS server after a couple of week grace period. I think once the decision is taken it's better to do it earlier than late, and I'm thinking that this could be done earlier next week if Jim schedule allows and there is no objection. That would allow to manage the set of patches for the following release only under git and not need an SCM transition in the course of preparing 0.6.6 (or 0.7.0). - Speaking of the following release, I'm shooting for a slightly smaller development cycle, in order to be able to push the next version in time for Fedora 12 Beta, this means a new release at the end of July, so only a bit more than a couple of weeks for pushing the changes, I really hope we will be able to include a first version of the ESX driver and Power Hyprvisor, if it's the case I think it will be worth bumping the release name to 0.7.0 . Feedback and opinions welcome, I hope git is not too uncontroversial :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1