- Devel - libvirt List Archives

[libvirt] [PATCH] remote_internal.c: don't dereference a NULL "conn"
by Jim Meyering 03 Sep '09

03 Sep '09

Here's the test just before the else-if in the patch below: if (conn && conn->driver && STREQ (conn->driver->name, "remote")) { So, in the else-branch, "conn" is guaranteed to be NULL. And dereferenced. This may be only a theoretical risk, but if so, the test of "conn" above should be changed to an assertion, and/or the parameter should get the nonnull attribute. >From a1b1d36d96f6b50ddf514539af85da20ca671bf5 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 2 Sep 2009 11:54:38 +0200 Subject: [PATCH] remote_internal.c: don't dereference a NULL "conn" * src/remote_internal.c (remoteDevMonOpen): Avoid NULL-dereference. --- src/remote_internal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index ea50c11..141fef9 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -5148,7 +5148,7 @@ remoteDevMonOpen(virConnectPtr conn, conn->devMonPrivateData = priv; remoteDriverUnlock(priv); return VIR_DRV_OPEN_SUCCESS; - } else if (conn->networkDriver && + } else if (conn && conn->networkDriver && STREQ (conn->networkDriver->name, "remote")) { struct private_data *priv = conn->networkPrivateData; remoteDriverLock(priv); -- 1.6.4.2.395.ge3d52

5 9

[libvirt] [PATCH] test.c: don't use undefined local, "def"
by Jim Meyering 03 Sep '09

03 Sep '09

another real bug: >From fd41bd47252654f84684830e02ecbeb3d26e7dee Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 3 Sep 2009 12:12:19 +0200 Subject: [PATCH] test.c: don't use undefined local, "def" * src/test.c (testOpenVolumesForPool): Upon early virAsprintf or virXPathNodeSet failure, "goto error" would take us to virStorageVolDefFree(def), but with "def" not defined. Initialize it to NULL. --- src/test.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/test.c b/src/test.c index 7c8f85b..895cce1 100644 --- a/src/test.c +++ b/src/test.c @@ -435,7 +435,7 @@ static int testOpenVolumesForPool(virConnectPtr conn, char *vol_xpath; int i, ret, func_ret = -1; xmlNodePtr *vols = NULL; - virStorageVolDefPtr def; + virStorageVolDefPtr def = NULL; /* Find storage volumes */ if (virAsprintf(&vol_xpath, "/node/pool[%d]/volume", poolidx) < 0) { -- 1.6.4.2.395.ge3d52

2 1

[libvirt] Support for XCI (Xen Client)
by Andreas Sommer 03 Sep '09

03 Sep '09

Hi, I just wondered whether the Xen Client project (http://www.xen.org/products/xci.html) has been tested, or is supported by libvirt at all? I'm not sure if it has a different Xen API, but it definitely has different domain configuration files - that's why I ask. Best regards

2 1

[libvirt] [PATCH] Support for defining/dumping video device in VirtualBox
by Pritesh Kothari 03 Sep '09

03 Sep '09

Hi All, I have added support for defining/dumping video device in VirtualBox. The patch for the same is attached here. Also this patch depends on the earlier patch "Support for 3d Acceleration in video tag". Regards, Pritesh

3 3

[libvirt] [PATCH] Support for 3d Acceleration in video tag
by Pritesh Kothari 03 Sep '09

03 Sep '09

Hi All, I have added support for 3d Acceleration in the video tag, the patch for the same is attached here. Regards, Pritesh

3 5

[libvirt] [PATCH] Fix bugs in virDomainMigrate v2 code.
by Chris Lalancette 03 Sep '09

03 Sep '09

Paolo Bonzini points out that in my refactoring of the code for virDomainMigrate(), I added a check for the return value from virDomainMigratePerform(). The problem is that we don't want to exit if we fail, we actually want to go on and do virDomainMigrateFinish2() with a non-0 return code to clean things up. Remove the check. While reproducing this issue, I also noticed that we wouldn't always properly propagate an error message. In particular, I found that if you blocked off the migration ports (with iptables) and then tried the migration, it would actually fail but we would get no failure output from Qemu. Therefore, we would think we succeeded, and leave a huge mess behind us. Execute the monitor command "info migrate", and look for a failure string in there as well. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/libvirt.c | 2 -- src/qemu_driver.c | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index ca8e003..5c1efb6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -2962,8 +2962,6 @@ virDomainMigrateVersion2 (virDomainPtr domain, */ ret = domain->conn->driver->domainMigratePerform (domain, cookie, cookielen, uri, flags, dname, bandwidth); - if (ret == -1) - goto done; /* In version 2 of the migration protocol, we pass the * status code from the sender to the destination host, diff --git a/src/qemu_driver.c b/src/qemu_driver.c index eb22940..772f2f9 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -6956,6 +6956,21 @@ qemudDomainMigratePerform (virDomainPtr dom, goto cleanup; } + /* it is also possible that the migrate didn't fail initially, but + * rather failed later on. Check the output of "info migrate" + */ + VIR_FREE(info); + if (qemudMonitorCommand(vm, "info migrate", &info) < 0) { + qemudReportError (dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "%s", _("could not get info about migration")); + goto cleanup; + } + if (strstr(info, "fail") != NULL) { + qemudReportError (dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + _("migrate failed: %s"), info); + goto cleanup; + } + /* Clean up the source domain. */ qemudShutdownVMDaemon (dom->conn, driver, vm); paused = 0; -- 1.6.0.6

2 2

[libvirt] virsh vcpuinfo always returns CPU=0
by Shi Jin 03 Sep '09

03 Sep '09

Hi there, I wonder what does the CPU entry stands for in the output of vcpuinfo. I guess it is the CPU utilization rate, right? For both Ubuntu 9.04 (virsh version 0.6.1) and RHEL 5.4 (version 0.6.3), I always get the returned CPU value to be 0, no matter how busy the CPU can be and how many VCPU is used. For example, onnecting to uri: qemu:///system VCPU: 0 CPU: 0 State: running CPU Affinity: yyyyyyyyyyyyyyyy VCPU: 1 CPU: 0 State: running CPU Affinity: yyyyyyyyyyyyyyyy Is this a problem and how do I fix it? Thank you very much. -- Shi Jin, PhD

2 1

[libvirt] VMware ESX: Don't warn if a known query parameter should be ignored
by Matthias Bolte 02 Sep '09

02 Sep '09

esxUtil_ParseQuery() warns if a known query parameter should be ignored due to the corresponding char/int pointer being NULL, instead of silently ignoring it. The attached patch changes the if/else structure to fix this. Matthias

3 2

[libvirt] VMware ESX: Allow ethernet address type 'vpx'
by Matthias Bolte 02 Sep '09

02 Sep '09

The VMX entry ethernet0.addressType may be set to 'vpx' beside 'static' and 'generated'. 'vpx' indicates that the MAC address was generated by a vCenter. The attached patch adds 'vpx' to the valid values for ethernet0.addressType. Matthias

4 6

[libvirt] [PATCH] Support for getting/setting number of cpus in VirtualBox
by Pritesh Kothari 02 Sep '09

02 Sep '09

Hi All, I have just added support for getting/setting number of cpus in VirtualBox. The patch for the same is include below. Regards, Pritesh

3 2