- Devel - libvirt List Archives

[libvirt] [PATCH] Do a correct format mapping of partitions 2
by Henrik Persson 06 Jul '09

06 Jul '09

I make a new try from a different mail client now. /Henrik

4 5

Re: [libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 05 Jul '09

05 Jul '09

> On Wed, Jul 01, 2009 at 11:02:16AM -0700, C.J. Adams-Collier wrote: > > Hey folks, > > > > I got an android and wanted to set up an armel debian vm to test out > > some code. I had to launch it directly with qemu-system-arm, though, > > since virsh didn't have an arm option to select. > > > > This is a patch against the debian version of the source after applying > > debian-specific changes. If you'd like a patch against mainline, I'd be > > willing to do that. > > > > http://karma.colliertech.org/~cjac/tmp/add-arm.patch > > Well, this list is really about upstream patches not distro specific > ones, I just verified that it applies cleanly against CVS. > and I could not access said patch [1]. That is weird. I hope it was just a fluke! Attached. > Send a patch against the > latest version or CVS/git as an mail attachemnt and we will try to add > it. Alrighty. I see that the mips machines are separated into 'mips' and 'mipsel'. I don't know anything about the endian-ness of the various machines (aside from versatilepb, which is little), so I just left them all in the generic qemu_arch_info.arch="arm" table entry. > Daniel Cheers, C.J. > [1] the server seems down I got an HTTP request timeout. hurm... I'm getting hits at least hourly from a site revproxied by the same host ( http://wp.colliertech.org/cj/ ) - perhaps it was a coincidental outage (*shakes fist at comcast*)? > -- > Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ > daniel <at> veillard.com | Rpmfind RPM search engine http://rpmfind.net/ > http://veillard.com/ | virtualization library http://libvirt.org/

3 5

[libvirt] Release of libvirt-0.6.5
by Daniel Veillard 03 Jul '09

03 Jul '09

As scheduled, the new version is available on the server: ftp://libvirt.org/libvirt/ This is mostly a bug fix release, though it includes some serious improvements for storage/NPIV and on the OpenNebula driver: * New features - create storage columes on disk backend (Henrik Persson) - drop of capabilities based on libcap-ng when possible (Daniel Berrange) * Portability - fix build on non-Linux targets (Daniel Berrange) * Documentation - typo and english fixes (Runa Bhattacharjee and Garry Dolley) - Docs on extending APIs (Dave Allan) - cleanup of debug and logging documentation (Amy Griffis) - add HACKING doc to the website (Daniel Berrange) - documentation for OpenNebula driver (Abel Miguez Rodriguez) * Bug fixes - forbid autostart on transcient networks - xen device removal crash (Daniel Berrange) - re-detection of transient VMs after libvirtd restart(Daniel Berrange) - bug in virFindFileInPath (Daniel Berrange) - handle new availheap sysctl in Xen (Daniel Berrange) - allow USB hostdev product 0 (Cole Robinson) - cleanup when creating a storage pool fails (Henrik Persson) - domain id fix on redefinition in test driver (Cole Robinson) - fix raw storage allocation (Cole Robinson) - memory reporting for inactive qemu drivers (Cole Robinson) - segfault if storage pool has no type attribute (Cole Robinson) - OpenNebula compilation issues (Javier Fontan) - dominfo command without security driver (Daniel Berrange) - domain state problems after migration or destroy (Federico Simoncelli) - leak in node device parsing (Dave Allan) - storage pool definitions reading at startup (Cole Robinson) - bogus WWN in NPIV support (David Allan) - avoid a segfault with recent Xen (Sascha) - cope with libnuma failures on weird topologies (Dan Berrange) - crash in QEMU driver with bad capabilities data (Dan Berrange) - trying to re-create a pool should not destroy it (Dave Allan) - endless loop in node device XML dump (Cole Robinson) - Re-label shared and readonly images (Dan Berrange) * Improvements - create and destroy NPIV support (David Allan) - networking in UML driver (Daniel Berrange) - HAL driver restart thread safety (Daniel Berrange) - capabilities and nodeinfo APIs for LXC (Daniel Berrange) - iNUMA API for VBox (Daniel Berrange) - dynamically search and use kvm-img qemu-img or qcow-create (Doug Goldstein) - fix qemu and kvm version parsing (Mark McLoughlin) - serial number for HAL storage (Dave Allan) - improve error reporting for virConnectOpen URIs (Daniel Berrange) - include OS driver name in device XML (Daniel Berrange) - fix qemu command flags fetching (Cole Robinson) - check that qemu support -drive format= (Cole Robinson) - improve emulator detection (Cole Robinson) - changes to config parser to accomodate VMX syntax (Matthias Bolte) - update network schemas and driver for missing elements (Satoru SATOH) - avoid changing file context if not needed (Tim Waugh) - skip labelling if no src path (Cole Robinson) - add arm emulation if qemu-system-arm is present (C.J. Adams-Collier) * Cleanups - daemon check logging env variables (Daniel Berrange) - User Mode Linux start and stop cleanups (Daniel Berrange) - share the NUMA api implementations (Daniel Berrange) - storage module dependancies (Dave Allan) - refactor storage XML parsing (Cole Robinson) - big cleanup of logging code (Amy Griffis) - superfluous % on format (Matthias Bolte) - cleanups and updates on OpenNebula driver (Daniel Berrange and Abel Miguez Rodriguez) thanks everybody for report, patches, documentation, etc ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] gitignore & cscope
by Dave Allan 03 Jul '09

03 Jul '09

Could we add cscope's files to .gitignore? Dave diff --git a/.gitignore b/.gitignore index 1b36694..ca73a98 100644 --- a/.gitignore +++ b/.gitignore @@ -19,6 +19,8 @@ config.status config.sub configure coverage +cscope.files +cscope.out libtool libvirt-*.tar.gz libvirt.pc

4 3

[libvirt] [PATCH 1/2] Re-label shared and readonly images
by Mark McLoughlin 03 Jul '09

03 Jul '09

From: Daniel P. Berrange <berrange(a)redhat.com> This patch was posted ages ago here: https://bugzilla.redhat.com/493692 But was never posted upstream AFAICT. Signed-off-by: Mark McLoughlin <markmc(a)redhat.com> --- src/security_selinux.c | 27 +++++++++++++++++---------- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/security_selinux.c b/src/security_selinux.c index 4fb7c86..87073d2 100644 --- a/src/security_selinux.c +++ b/src/security_selinux.c @@ -24,11 +24,12 @@ #include "virterror_internal.h" #include "util.h" #include "memory.h" - +#include "logging.h" #define VIR_FROM_THIS VIR_FROM_SECURITY static char default_domain_context[1024]; +static char default_content_context[1024]; static char default_image_context[1024]; #define SECURITY_SELINUX_VOID_DOI "0" #define SECURITY_SELINUX_NAME "selinux" @@ -148,8 +149,13 @@ SELinuxInitialize(virConnectPtr conn) close(fd); ptr = strchrnul(default_image_context, '\n'); - *ptr = '\0'; - + if (*ptr == '\n') { + *ptr = '\0'; + strcpy(default_content_context, ptr+1); + ptr = strchrnul(default_content_context, '\n'); + if (*ptr == '\n') + *ptr = '\0'; + } return 0; } @@ -313,6 +319,8 @@ SELinuxSetFilecon(virConnectPtr conn, const char *path, char *tcon) { char ebuf[1024]; + VIR_INFO("Setting SELinux context on '%s' to '%s'", path, tcon); + if(setfilecon(path, tcon) < 0) { virSecurityReportError(conn, VIR_ERR_ERROR, _("%s: unable to set security context " @@ -337,9 +345,6 @@ SELinuxRestoreSecurityImageLabel(virConnectPtr conn, char *newpath = NULL; const char *path = disk->src; - if (disk->readonly || disk->shared) - return 0; - if ((err = virFileResolveLink(path, &newpath)) < 0) { virReportSystemError(conn, err, _("cannot resolve symlink %s"), path); @@ -366,8 +371,13 @@ SELinuxSetSecurityImageLabel(virConnectPtr conn, { const virSecurityLabelDefPtr secdef = &vm->def->seclabel; - if (secdef->imagelabel) + if (disk->shared) { + return SELinuxSetFilecon(conn, disk->src, default_image_context); + } else if (disk->readonly) { + return SELinuxSetFilecon(conn, disk->src, default_content_context); + } else if (secdef->imagelabel) { return SELinuxSetFilecon(conn, disk->src, secdef->imagelabel); + } return 0; } @@ -441,9 +451,6 @@ SELinuxSetSecurityLabel(virConnectPtr conn, if (secdef->imagelabel) { for (i = 0 ; i < vm->def->ndisks ; i++) { - if (vm->def->disks[i]->readonly || - vm->def->disks[i]->shared) continue; - if (SELinuxSetSecurityImageLabel(conn, vm, vm->def->disks[i]) < 0) return -1; } -- 1.6.2.5

2 5

[libvirt] vTPM support in libvirt
by Andreas Sommer 02 Jul '09

02 Jul '09

I'm wondering if there will be vTPM support in libvirt in the near future?! Xen does support it already with the configuration "vtpm = ['instance=1,backend=0']", for example. So it would be great if the libvirt XML format supported it, too... For example like this: <devices> <vtpm instance="1" backend="xxx" /> </devices> Both attributes are optional. The backend attribute is a VM ID (on Xen, only zero for dom0 is supported) and could be implemented as a UUID?! What do you think? Are there any efforts to introducing that? Cheers Andreas

6 13

[libvirt] [Patch] Fix network driver not to forget to save <domain/> in network XML file
by Satoru SATOH 02 Jul '09

02 Jul '09

It seems that libvirt network driver can understand /network/domain element but it does not save this configuration into the network definition XML file correctly (looks completely forgetting about it). Here is a fix for this problem. (see also: rhbz#505720) --- src/network_conf.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/network_conf.c b/src/network_conf.c index 1e0cbb8..1b50b84 100644 --- a/src/network_conf.c +++ b/src/network_conf.c @@ -592,6 +592,9 @@ char *virNetworkDefFormat(virConnectPtr conn, def->stp ? "on" : "off", def->delay); + if (def->domain) + virBufferVSprintf(&buf, " <domain name='%s'/>\n", def->domain); + if (def->ipAddress || def->netmask) { virBufferAddLit(&buf, " <ip"); -- 1.6.3.2

3 2

[libvirt] [Patch] Network schema fixes and updates
by Satoru SATOH 02 Jul '09

02 Jul '09

This is a patch to make network schema (network.rng) to support some neat features (/netowrk/domain, //dhcp/host/*). --- docs/schemas/network.rng | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 34c0163..a4281a5 100644 --- a/docs/schemas/network.rng +++ b/docs/schemas/network.rng @@ -1,6 +1,7 @@  <element name="network" xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> + <interleave>  <element name="name"><text/></element> @@ -43,6 +44,11 @@ </element> </optional> <optional> + <element name="domain"> + <attribute name="name"><text/></attribute> + </element> + </optional> + <optional>  <!-- FIXME: address, netmask and the start and end of the ranges @@ -63,7 +69,15 @@ <attribute name="end"><text/></attribute> </element> </zeroOrMore> + <zeroOrMore> + <element name="host"> + <attribute name="mac"><text/></attribute> + <attribute name="name"><text/></attribute> + <attribute name="ip"><text/></attribute> + </element> + </zeroOrMore> </element> </element> </optional> + </interleave> </element> -- 1.6.3.2

3 2

[libvirt] [PATCH 0/1] Fix pool create when pool already exists
by David Allan 02 Jul '09

02 Jul '09

When storagePoolCreate is called to define a pool that already exists, it mistakenly destroys the existing pool. This patch fixes the problem. Dave

5 8

[libvirt] Patch to include arm variants in virsh capabilities
by C.J. Adams-Collier 02 Jul '09

02 Jul '09

Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes. If you'd like a patch against mainline, I'd be willing to do that. http://karma.colliertech.org/~cjac/tmp/add-arm.patch Cheers, C.J.

2 1