- Devel - libvirt List Archives

[libvirt] PATCH: Fix non-raw storage volume cloning
by Daniel P. Berrange 17 Jul '09

17 Jul '09

The recent storage patches broke cloning of non-raw volumes, due to a small typo. THis was identified by the libvirt TCK storage tests! Daniel diff --git a/src/storage_backend.c b/src/storage_backend.c index 1664804..67815d7 100644 --- a/src/storage_backend.c +++ b/src/storage_backend.c @@ -567,7 +567,7 @@ virStorageBackendGetBuildVolFromFunction(virConnectPtr conn, (inputvol->type == VIR_STORAGE_VOL_FILE && inputvol->target.format != VIR_STORAGE_VOL_FILE_RAW)) { - if ((tool_type = virStorageBackendFindFSImageTool(NULL)) != -1) { + if ((tool_type = virStorageBackendFindFSImageTool(NULL)) < 0) { virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", _("creation of non-raw file images is " "not supported without qemu-img.")); -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 2

[libvirt] [PATCH] build: do not emit a trailing blank line into VC'd file, NEWS
by Jim Meyering 16 Jul '09

16 Jul '09

Cole Robinson noticed that the generated NEWS file would fail the "make syntax-check" tests. This adjusts the rule that generates it not to emit any of the offending trailing blank lines. At the same time, it regenerates NEWS. >From 53af8d848d78bcc5144b2c06b2109bbdc65803cf Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 16 Jul 2009 22:46:43 +0200 Subject: [PATCH] build: do not emit a trailing blank line into VC'd file, NEWS * docs/Makefile.am ($(top_builddir)/NEWS): Adjust rule to filter out any trailing blank lines when generating this file. * NEWS: Regenerate. --- NEWS | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ docs/Makefile.am | 7 ++++- 2 files changed, 61 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 5733fa8..447d2b4 100644 --- a/NEWS +++ b/NEWS @@ -5,6 +5,62 @@ http://libvirt.org/news.html +0.6.5: Jul 3 2009: + - New features: create storage columes on disk backend (Henrik Persson), + drop of capabilities based on libcap-ng when possible (Daniel + Berrange) + - Portability: fix build on non-Linux targets (Daniel Berrange) + - Documentation: typo and english fixes (Runa Bhattacharjee and + Garry Dolley), Docs on extending APIs (Dave Allan), cleanup + of debug and logging documentation (Amy Griffis), add + HACKING doc to the website (Daniel Berrange), + documentation for OpenNebula driver (Abel Miguez Rodriguez) + - Bug fixes: forbid autostart on transcient networks, + xen device removal crash (Daniel Berrange), re-detection of + transient VMs after libvirtd restart(Daniel Berrange), + bug in virFindFileInPath (Daniel Berrange), handle new + availheap sysctl in Xen (Daniel Berrange), allow USB hostdev + product 0 (Cole Robinson), cleanup when creating a storage pool + fails (Henrik Persson), domain id fix on redefinition in + test driver (Cole Robinson), fix raw storage allocation (Cole + Robinson), memory reporting for inactive qemu drivers (Cole + Robinson), segfault if storage pool has no type attribute (Cole + Robinson), OpenNebula compilation issues (Javier Fontan), + dominfo command without security driver (Daniel Berrange), + domain state problems after migration or destroy (Federico + Simoncelli), leak in node device parsing (Dave Allan), + storage pool definitions reading at startup (Cole Robinson), + bogus WWN in NPIV support (David Allan), avoid a segfault with + recent Xen (Sascha), cope with libnuma failures on weird + topologies (Dan Berrange), crash in QEMU driver with bad capabilities + data (Dan Berrange), trying to re-create a pool should not destroy + it (Dave Allan), endless loop in node device XML dump (Cole Robinson), + Re-label shared and readonly images (Dan Berrange) + - Improvements: create and destroy NPIV support (David Allan), + networking in UML driver (Daniel Berrange), HAL driver restart + thread safety (Daniel Berrange), capabilities and nodeinfo + APIs for LXC (Daniel Berrange), iNUMA API for VBox (Daniel Berrange), + dynamically search and use kvm-img qemu-img or qcow-create (Doug + Goldstein), fix qemu and kvm version parsing (Mark McLoughlin), + serial number for HAL storage (Dave Allan), improve error reporting + for virConnectOpen URIs (Daniel Berrange), include OS driver name + in device XML (Daniel Berrange), fix qemu command flags fetching + (Cole Robinson), check that qemu support -drive format= (Cole + Robinson), improve emulator detection (Cole Robinson), changes + to config parser to accomodate VMX syntax (Matthias Bolte), + update network schemas and driver for missing elements (Satoru SATOH), + avoid changing file context if not needed (Tim Waugh), + skip labelling if no src path (Cole Robinson), add arm emulation + if qemu-system-arm is present (C.J. Adams-Collier) + - Cleanups: daemon check logging env variables (Daniel Berrange), + User Mode Linux start and stop cleanups (Daniel Berrange), + share the NUMA api implementations (Daniel Berrange), storage + module dependancies (Dave Allan), refactor storage XML parsing + (Cole Robinson), big cleanup of logging code (Amy Griffis), + superfluous % on format (Matthias Bolte), cleanups and updates + on OpenNebula driver (Daniel Berrange and Abel Miguez Rodriguez) + + 0.6.4: May 29 2009: - New features: new API virStorageVolCreateXMLFrom (Cole Robinson), full VBox graphic capabilities (Pritesh Kothari), Interface config diff --git a/docs/Makefile.am b/docs/Makefile.am index 4bdb827..9ac2f6d 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -127,8 +127,11 @@ libvirt-api.xml libvirt-refs.xml: apibuild.py \ -(./apibuild.py) $(top_builddir)/NEWS: $(top_srcdir)/docs/news.xsl $(top_srcdir)/docs/news.html.in - -@(if [ -x $(XSLTPROC) ] ; then \ - $(XSLTPROC) --nonet $(top_srcdir)/docs/news.xsl $(top_srcdir)/docs/news.html.in > $(top_builddir)/NEWS ; fi ); + -@(if [ -x $(XSLTPROC) ] ; then \ + $(XSLTPROC) --nonet $(top_srcdir)/docs/news.xsl \ + $(top_srcdir)/docs/news.html.in \ + | perl -0777 -pe 's/\n\n+$$/\n/' \ + > $@-t && mv $@-t $@ ; fi ); clean-local: rm -f *~ *.bak *.hierarchy *.signals *-unused.txt -- 1.6.4.rc0.127.g81400

2 2

[libvirt] [PATCH 0/2] updated/working patches for netcf backend and virsh commands for virInterface*
by Laine Stump 16 Jul '09

16 Jul '09

These are updated versions of patches I previously sent: 1 - add iface-* commands to virsh to expose virInterface* functions to the cli. 2 - add the netcf backend driver. These haven't been exhaustively tested, but appear to work in simple smoke tests. Note that they all depend on the submitted-but-not-yet-committed virConnectListDefinedInterfaces() patch.

2 4

[libvirt] [PATCH 0/4] Storage disk backend fixes
by Cole Robinson 16 Jul '09

16 Jul '09

The following series fixes some issues in the disk storage backend, most wrt the recently added ability to create disk volumes. Cole Robinson (4): storage: disk: Fix parthelper '-g' option handling. storage: disk: Fix segfault creating volume without target path storage: disk: Default to 'ext2' for new volumes. storage: disk: Use capacity, not allocation, when creating volume. src/parthelper.c | 4 ++-- src/storage_backend_disk.c | 33 +++++++++++++++++++-------------- src/storage_conf.c | 2 +- 3 files changed, 22 insertions(+), 17 deletions(-)

3 14

[libvirt] [PATCH 0/9] Storage cloning for LVM and Disk backends
by Cole Robinson 16 Jul '09

16 Jul '09

This following series implements cloning for LVM and disk backends. Most of the functionality is already here, it just needed some reorganization to be accessible for every backend. I verified the following scenarios produced a bootable image: - Clone within a disk pool - Clone within a logical pool - Clone a raw file to a disk pool - Clone a disk pool to a logical pool Cole Robinson (9): storage: Refactor FS backend 'create' function choosing. storage: Always assume we are tracking alloc progress in FS backend storage: Move most of the FS creation functions to common backend. storage: cleanup: do away with 'createFile' storage: Break out actual raw cloning to separate function. storage: Implement 'CreateBlockFrom' helper. storage: Don't try sparse detection if writing to block device. storage: Implement CreateVolFrom for logical and disk backend. storage: Fix deadlock when cloning across pools. src/storage_backend.c | 471 +++++++++++++++++++++++++++++++++++++++++ src/storage_backend.h | 15 ++ src/storage_backend_disk.c | 15 ++ src/storage_backend_fs.c | 378 ++------------------------------- src/storage_backend_logical.c | 17 ++ src/storage_driver.c | 6 +- 6 files changed, 540 insertions(+), 362 deletions(-)

3 21

[libvirt] [PATCH 0/5] Add virConnectListDefinedInterfaces/NumOfDefinedInterfaces
by Laine Stump 16 Jul '09

16 Jul '09

This patch adds everything but the backend implementation of two APIs that were requested during review of my patch to add virsh commands that expose the virInterface* API. These count and list interfaces on the host that are currently inactive (ie "down"). virConnectListInterfaces and virConnectNumOfInterfaces will list/count *only* those interfaces that are currently active. With these functions in place, I'll be able to add the "--inactive" and "--all" flags to iface-list, as suggested by danpb. Implementation of the backend of these two functions is waiting for two things: 1) supporting code in libnetcf, and 2) implementation of the rest of the backend driver functions for virInterface* (ready in the wings and waiting to go).

3 14

[libvirt] [PATCH] implement virsh dump for qemu guests
by Paolo Bonzini 16 Jul '09

16 Jul '09

This patch uses a "migrate"+"cont" combination to implement "virsh dump" for QEMU guests (BZ507551). The code is mostly based on qemudDomainSave, except that the XML prolog is not included as it is not needed to examine the dump with e.g. crash. 2009-07-08 Paolo Bonzini <bonzini(a)gnu.org> * qemu_driver.c (qemudDomainCoreDump): New. (qemuDriver): Add core dump function. --- src/qemu_driver.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 84 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 95ea882..546a691 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2844,6 +2844,89 @@ cleanup: } +static int qemudDomainCoreDump(virDomainPtr dom, + const char *path, + int flags ATTRIBUTE_UNUSED) { + struct qemud_driver *driver = dom->conn->privateData; + virDomainObjPtr vm; + char *command = NULL; + char *info = NULL; + char *safe_path = NULL; + int ret = -1; + + qemuDriverLock(driver); + vm = virDomainFindByUUID(&driver->domains, dom->uuid); + + if (!vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_DOMAIN, + _("no domain with matching uuid '%s'"), uuidstr); + goto cleanup; + } + + if (!virDomainIsActive(vm)) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto cleanup; + } + + /* Migrate to file */ + safe_path = qemudEscapeShellArg(path); + if (!safe_path) { + virReportOOMError(dom->conn); + goto cleanup; + } + if (virAsprintf(&command, "migrate \"exec:" + "dd of='%s' 2>/dev/null" + "\"", safe_path) == -1) { + virReportOOMError(dom->conn); + command = NULL; + goto cleanup; + } + + if (qemudMonitorCommand(vm, command, &info) < 0) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "%s", _("migrate operation failed")); + goto cleanup; + } + + DEBUG ("%s: migrate reply: %s", vm->def->name, info); + + /* If the command isn't supported then qemu prints: + * unknown command: migrate" */ + if (strstr(info, "unknown command:")) { + qemudReportError (dom->conn, dom, NULL, VIR_ERR_NO_SUPPORT, + "%s", + _("'migrate' not supported by this qemu")); + goto cleanup; + } + + /* Migrate always stops the VM. However, since the monitor is always + attached to a pty for libvirt, it will support synchronous + operations so we get here just after the end of the migration. */ + if (vm->state == VIR_DOMAIN_RUNNING) { + if (qemudMonitorCommand(vm, "cont", &info) < 0) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "%s", _("continue operation failed")); + goto cleanup; + } + DEBUG("Reply %s", info); + VIR_FREE(info); + } + ret = 0; + +cleanup: + VIR_FREE(safe_path); + VIR_FREE(command); + VIR_FREE(info); + if (vm) + virDomainObjUnlock(vm); + qemuDriverUnlock(driver); + return ret; +} + + static int qemudDomainSetVcpus(virDomainPtr dom, unsigned int nvcpus) { struct qemud_driver *driver = dom->conn->privateData; virDomainObjPtr vm; @@ -5310,7 +5393,7 @@ static virDriver qemuDriver = { qemudDomainGetInfo, /* domainGetInfo */ qemudDomainSave, /* domainSave */ qemudDomainRestore, /* domainRestore */ - NULL, /* domainCoreDump */ + qemudDomainCoreDump, /* domainCoreDump */ qemudDomainSetVcpus, /* domainSetVcpus */ #if HAVE_SCHED_GETAFFINITY qemudDomainPinVcpu, /* domainPinVcpu */ -- 1.6.2.5

4 10

[libvirt] [PATCH] add cd and pwd commands to virsh
by Paolo Bonzini 16 Jul '09

16 Jul '09

This patch adds cd and pwd commands to virsh. These can be useful together with commands that refer to files in the local file systems, especially save and restore. I explicitly decided not to provide any other command, e.g. mkdir, to avoid going down a slippery slope (now you want mkdir, tomorrow ls and rm and so on...). If anything, it would be possible to add a generic shell command---but cd cannot be implemented that way, so pwd shall remain the sole "exception". I did not implement "cd -". Ok? 2009-07-02 Paolo Bonzini <pbonzini(a)redhat.com> * bootstrap: Add getcwd module. * docs/virsh.pod: Document cd and pwd commands. * src/virsh.c (info_cd, opts_cd, cmdCd, info_pwd, cmdPwd): New. (commands): Add cd and pwd commands. * virsh.1: Regenerate. Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com> --- bootstrap | 1 + docs/virsh.pod | 12 ++++++++ src/virsh.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ virsh.1 | 12 ++++++++- 4 files changed, 101 insertions(+), 1 deletions(-) diff --git a/bootstrap b/bootstrap index baf52e7..b14d8cc 100755 --- a/bootstrap +++ b/bootstrap @@ -69,6 +69,7 @@ c-ctype close connect getaddrinfo +getcwd gethostname getpass gettext diff --git a/docs/virsh.pod b/docs/virsh.pod index 6434d78..9530ba6 100644 --- a/docs/virsh.pod +++ b/docs/virsh.pod @@ -82,6 +82,18 @@ Running hypervisor: Xen 3.0.0 =back +=item B<cd> I<directory> optional + +Will change current directory to I<directory>. The default directory +for the B<cd> command is the home directory or, if there is no I<HOME> +variable in the environment, the root directory. + +This command is only available in interactive mode. + +=item B<pwd> + +Will print the current directory. + =item B<connect> I<URI> optional I<--readonly> (Re)-Connect to the hypervisor. This is a build-in command after shell diff --git a/src/virsh.c b/src/virsh.c index 5623499..856e5a0 100644 --- a/src/virsh.c +++ b/src/virsh.c @@ -6047,6 +6047,81 @@ editReadBackFile (vshControl *ctl, const char *filename) } /* + * "cd" command + */ +static const vshCmdInfo info_cd[] = { + {"help", gettext_noop("change the current directory")}, + {"desc", gettext_noop("Change the current directory.")}, + {NULL, NULL} +}; + +static const vshCmdOptDef opts_cd[] = { + {"dir", VSH_OT_DATA, 0, gettext_noop("directory to switch to (default: home or else root)")}, + {NULL, 0, 0, NULL} +}; + +static int +cmdCd(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) +{ + const char *dir; + int found; + + if (!ctl->imode) { + vshError(ctl, FALSE, _("cd: command valid only in interactive mode")); + return -1; + } + + dir = vshCommandOptString(cmd, "dir", &found); + if (!found) + dir = getenv ("HOME"); + if (!dir) + dir = "/"; + + if (chdir (dir) == -1) { + vshError(ctl, FALSE, _("cd: %s: %s"), strerror (errno), dir); + return -1; + } + + return 0; +} + +/* + * "pwd" command + */ +static const vshCmdInfo info_pwd[] = { + {"help", gettext_noop("print the current directory")}, + {"desc", gettext_noop("Print the current directory.")}, + {NULL, NULL} +}; + +static int +cmdPwd(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) +{ + char *cwd; + size_t path_max; + int err = TRUE; + + path_max = (size_t) PATH_MAX + 2; + cwd = vshMalloc (ctl, path_max); + while (cwd) { + err = getcwd (cwd, path_max) == NULL; + if (!err || errno != ERANGE) + break; + + path_max *= 2; + cwd = vshRealloc (ctl, cwd, path_max); + } + + if (err) + vshError(ctl, FALSE, _("pwd: cannot get current directory: %s"), strerror (errno)); + else + vshPrint (ctl, _("%s\n"), cwd); + + free (cwd); + return !err; +} + +/* * "edit" command */ static const vshCmdInfo info_edit[] = { @@ -6209,6 +6284,7 @@ static const vshCmdDef commands[] = { {"attach-interface", cmdAttachInterface, opts_attach_interface, info_attach_interface}, {"autostart", cmdAutostart, opts_autostart, info_autostart}, {"capabilities", cmdCapabilities, NULL, info_capabilities}, + {"cd", cmdCd, opts_cd, info_cd}, {"connect", cmdConnect, opts_connect, info_connect}, {"console", cmdConsole, opts_console, info_console}, {"create", cmdCreate, opts_create, info_create}, @@ -6277,6 +6353,7 @@ static const vshCmdDef commands[] = { {"pool-undefine", cmdPoolUndefine, opts_pool_undefine, info_pool_undefine}, {"pool-uuid", cmdPoolUuid, opts_pool_uuid, info_pool_uuid}, + {"pwd", cmdPwd, NULL, info_pwd}, {"quit", cmdQuit, NULL, info_quit}, {"reboot", cmdReboot, opts_reboot, info_reboot}, {"restore", cmdRestore, opts_restore, info_restore}, diff --git a/virsh.1 b/virsh.1 index 45ea614..ca03cc1 100644 --- a/virsh.1 +++ b/virsh.1 @@ -132,7 +132,7 @@ .\" ======================================================================== .\" .IX Title "VIRSH 1" -.TH VIRSH 1 "2009-04-16" "libvirt-0.6.2" "Virtualization Support" +.TH VIRSH 1 "2009-07-02" "libvirt-0.6.4" "Virtualization Support" .\" For nroff, turn off justification. Always turn off hyphenation; it makes .\" way too many mistakes in technical documents. .if n .ad l @@ -214,6 +214,16 @@ Running hypervisor: Xen 3.0.0 .RE .RS 4 .RE +.IP "\fBcd\fR \fIdirectory\fR optional" 4 +.IX Item "cd directory optional" +Will change current directory to \fIdirectory\fR. The default directory +for the \fBcd\fR command is the home directory or, if there is no \fI\s-1HOME\s0\fR +variable in the environment, the root directory. +.Sp +This command is only available in interactive mode. +.IP "\fBpwd\fR" 4 +.IX Item "pwd" +Will print the current directory. .IP "\fBconnect\fR \fI\s-1URI\s0\fR optional \fI\-\-readonly\fR" 4 .IX Item "connect URI optional --readonly" (Re)\-Connect to the hypervisor. This is a build-in command after shell -- 1.6.2.5

3 7

[libvirt] consistency: push "update" hook vs. "make syntax-check"
by Jim Meyering 16 Jul '09

16 Jul '09

Currently the server side hook that runs "git diff --check" to prevent pushing a change that adds trailing blanks is more strict than our "make syntax-check" hook, since the former rejects any change that adds blank lines at the end of a file, while "make syntax-check" doesn't complain about that. The two should be consistent. One way is to make "make syntax-check" more strict. If we were to do that, we'd have to choose between cleaning existing files and exempting them from the new test. Cleaning is easy and doesn't impact tests at all, so I prefer it. Here's what would be involved: - remove 121 trailing newlines from 109 files by running this command: git ls-files -z | xargs -0 perl -pi -0777 -e 's/\n\n+$/\n/' Add a rule to cfg.mk so that "make syntax-check" warns about any new violations. It might run something like this: git ls-files -z \ | xargs -0 perl -ln -0777 -e '/\n(\n+)$/ and print "$ARGV: ".length $1' That command prints the name of each offending file with its trailing blank line count. While it takes well under a second on my system, (admittedly, with a hot cache), it's not well optimized, reading each file into memory and processing it. If it matters, we can come up with a more efficient (yet still portable) way to compare the last two bytes of each file to "\n\n". I went ahead and wrote a nearly-minimal script to do that. Rather than reading/processing all 27MB of sources, this reads just the last 2 bytes of each of the 1048 files, comparing those bytes to "\n\n" and printing the name when there's a match: git ls-files -z \ | xargs -0 perl -le ' foreach my $f (@ARGV) { open F,"<",$f or (warn "failed to open $f: $!\n"), next; my $p = sysseek(F, -2, 2); # seek failure probably means file has < 2 bytes; ignore my $two; defined $p and $p = sysread F,$two,2; close F; # ignore read failure $p && $two eq "\n\n" and (print $f),$fail=1; } END {exit defined $fail ? 1 : 0}' However, counting minor page faults, there's little difference (2193 before, 1976 after), but maximum memory consumption is probably way down. I didn't measure that. With a hot cache, the latter takes .02elapsed, and the former takes .09 seconds. I'm leaning towards the simplicity of the former, in spite of its cost. I'll bet someone can come up with a simple *and* efficient script (probably using sed) to list files with one or more trailing blank line.

3 9

[libvirt] [PATCH 0/4] Prepare remote driver client for data streams
by Daniel P. Berrange 16 Jul '09

16 Jul '09

This patch series does a small amount of refactoring to the remote driver client to aid in supporting data streams Daniel P. Berrange (4): Refactor incoming message handling to prepare for data stream support Refactor message sending to allow code reuse for data streams Simplify remote driver error reporting Rename a bunch of internal methods to clarify their meaning src/remote_internal.c | 366 ++++++++++++++++++++++++------------------------- 1 files changed, 181 insertions(+), 185 deletions(-) -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 8