- Devel - libvirt List Archives

[libvirt] [PATCH] doc: don't emit trailing blanks into generated and VC'd NEWS file
by Jim Meyering 15 Sep '09

15 Sep '09

Daniel Veillard reported that the generated and VC'd NEWS file was causing trouble because the latest version contains trailing spaces, which conflicts with our server-side hook to prevent that. Here's the fix to avoid emitting those trailing spaces: >From 8110d304f49a217021371321ade0026ccd2627e1 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 15 Sep 2009 15:01:26 +0200 Subject: [PATCH] doc: don't emit trailing blanks into generated and VC'd NEWS file * docs/Makefile.am ($(top_builddir)/NEWS): Filter out trailing white space. --- docs/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 9ac2f6d..1125931 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -131,6 +131,7 @@ $(top_builddir)/NEWS: $(top_srcdir)/docs/news.xsl $(top_srcdir)/docs/news.html.i $(XSLTPROC) --nonet $(top_srcdir)/docs/news.xsl \ $(top_srcdir)/docs/news.html.in \ | perl -0777 -pe 's/\n\n+$$/\n/' \ + | perl -pe 's/[ \t]+$//' \ > $@-t && mv $@-t $@ ; fi ); clean-local: -- 1.6.5.rc1.171.g3f463

2 1

[libvirt] Release of libvirt-0.7.1
by Daniel Veillard 15 Sep '09

15 Sep '09

Okay, it's finally out of the box and available as usual at ftp://libvirt.org/libvirt/ There is a fair amount of new features and improvement, not surprizing considering 0.7.0 was 1.5 months ago. And of course many bug fixes and cleanups: * New Features: - Add an internal <secret> XML handling API (Miloslav Trmač) - VBox 3.0.6 API change support (Pritesh Kothari) - also allow use of XZ for Qemu image compression (Jim Meyering) - Multipath storage support module (Dave Allan) - VBox add Storage Volume support (Pritesh Kothari) - Support configuration of huge pages in guests (Daniel P. Berrange) - Add support for encrypted (qcow) volume creation. (Miloslav Trmač) - Secret manipulation public API (Miloslav Trmač) - support lzop save compression for qemu (Charles Duffy) - Support new PolicyKit 1.0 API (Daniel P. Berrange) - Compressed save image format for Qemu. (Chris Lalancette) - QEmu add host PCI device hotplug support (Mark McLoughlin) * Portability: - Fix win32 platform build (Daniel P. Berrange) * Documentation: - Minor comment changes (Laine Stump) - Fix up virNodeGetCellsFreeMemory (Chris Lalancette) - Fix some typos & remove unhelpful acronyms in QEMU docs (Daniel P. Berrange) - Add documentation about the QEMU driver security features (Daniel P. Berrange) - Remove 'the the' typo in docs (Daniel P. Berrange) - Fix some URLs in virsh manpage (Mark McLoughlin) - Add link to AbiCloud web management system (Daniel P. Berrange) - Update logging documentation (Amy Griffis) * Bug Fixes: - VBox bug when starting machine from old versions (Pritesh Kothari) - ESX avoid potential leaks (Matthias Bolte) - Fix more OOM handling bugs (Daniel P. Berrange) - Fix logging buffer overrun read (Daniel P. Berrange) - Fix misc thread locking bugs / bogus warnings (Daniel P. Berrange) - Fix regression from "Avoid polling on FDs with no events" (Chris Lalancette) - Close logfile fd after spawning qemu (Ryota Ozaki) - Check for libssh2 >= 1.0 for phy driver (Maximilian Wilhelm) - Avoid another leak in src/xend_internal.c (Matthias Bolte) - Avoid a leak in xenDaemonLookupByID (Matthias Bolte) - VBox fix minor bugs in display and added OOM checks (Pritesh Kothari) - Some close/fclose/closedir calls are missing (Matthias Bolte) - lxc_container.c: avoid a leak on error paths (Jim Meyering) - Fix several memory leaks (Ryota Ozaki) - Fix a memory leak in virsh (Laine Stump) - Fix ID field in virDomainPtr after starting Xen VM (Daniel P. Berrange) - Fix memory leak of monitor character device (Daniel P. Berrange) - Automatically set correct ownership of QEMU state directories (Daniel P. Berrange) - Avoid polling on FDs with no events enabled (Daniel P. Berrange) - esx_vi: return -1 upon failure, as intended (Matthias Bolte) - python: let libvirt_virConnectDomainEventCallback indicate success (Jim Meyering) - uml_conf.c: don't return an uninitialized pointer (Jim Meyering) - storage_backend.c: assure clang that inputvol can't be NULL (Jim Meyering) - libvir.c: avoid NULL dereference in virStoragePoolSetAutostart (Jim Meyering) - lxc: avoid NULL dereference upon getmntent failure (Jim Meyering) - storage_backend_fs: avoid NULL dereference on opendir failure (Jim Meyering) - Fix bugs in virDomainMigrate v2 code. (Chris Lalancette) - VMware ESX: Don't warn on some query parameter (Matthias Bolte) - Don't blindly reorder disk drives (Daniel P. Berrange) - Fix sexpr2string() to handle empty list. (Jim Fehlig) - Fix driver entry table for UML numa APIs (Daniel P. Berrange) - Fix crash in virsh vol-key command (Pritesh Kothari) - 517157 fix selinux problem with images on NFS (Darryl L. Pierce) - Fix phypOpen() escape_specialcharacters (Mattias Bolte) - Power Hypervisor: fix potential segfault (Mattias Bolte) - Fix bridge/tap system error reporting (Mark McLoughlin) - Reset PCI host devices after hot-unplug (Mark McLoughlin) - Reset unmanaged PCI host devices before hotplug (Mark McLoughlin) - Fix up connection reference counting. (Chris Lalancette) - Fix LXC driver crash when kernel doesn't support clone (Daniel P. Berrange) - Make LXC / UML drivers robust against NUMA topology brokenness (Daniel P. Berrange) - Run 'cont' on successful migration finish. (Chris Lalancette) - Fix QEMU domain status after restore. (Chris Lalancette) - Handle kernels with no ipv6 support (Mark McLoughlin) - Set perms on /var/lib/libvirt/boot to 0711 (Mark McLoughlin) - chown kernel/initrd before spawning qemu (Mark McLoughlin) - Several fixes to libvirtd's log setup (Amy Griffis) - Fix memleak if esxOpen fails (Matthias Bolte) * Improvements: - Add UUID definition required by storage encryption import (Daniel P. Berrange) - Make secrets RNG more strict (Daniel P. Berrange) - Fill in secret UUID for qcow encryption (Daniel P. Berrange) - Add usage type/id as a public API property of virSecret (Daniel P. Berrange) - Fix UUID handling in secrets/storage encryption APIs (Daniel P. Berrange) - Save vcpuinfo in status file (Daniel P. Berrange) - Restart libvirtd upon RPM upgrade (Daniel P. Berrange) - Add support for qcow encrypted volumes to qemu. (Miloslav Trmač) - Provide missing passphrase when creating a volume. (Miloslav Trmač) - Add virsh commands for secrets APIs (Miloslav Trmač) - Local file implementation of secret driver API (Miloslav Trmač) - Mask out flags used internally for virSecretGetValue (Miloslav Trmač) - Add <usage> to <secret> docs (Miloslav Trmač) - Support relabelling of USB and PCI devices (Daniel P. Berrange) - Add helper APIs for iterating over PCI device resource files (Daniel P. Berrange) - Add helper module for dealing with USB host devices (Daniel P. Berrange) - Test that domain-specific qemu machine types are used correctly (Mark McLoughlin) - Probe machine types from kvm binary too (Mark McLoughlin) - Look up machine types from all domains in qemudGetOldMachines() (Mark McLoughlin) - Test qemu machine aliases (Mark McLoughlin) - Add qemu -help test data for qemu-kvm-0.11.0-rc2 (Mark McLoughlin) - Add a more featureful qemu capabilities test data (Mark McLoughlin) - Add arm arch to capabilities schema (Mark McLoughlin) - Update capabilities schema to allow multiple machines per domain (Mark McLoughlin) - Add esx and tcp migration uri transports to capabilities schema (Mark McLoughlin) - Reintroduce support for lzop compression (Charles Duffy) - build: update gnulib submodule to latest (Jim Meyering) - Add flags and requires for Multipath storage (Daniel Veillard) - ESX raise error if UUID parse failed (Matthias Bolte) - ESX add domain undefine based on esxVI_UnregisterVM (Matthias Bolte) - ESX add esxGetCapabilities() with basic defaults (Matthias Bolte) - Switch Power Hypervisor to libssh2 (Eduardo Otubo) - Allow libvirtd to RPC to external libvirtd (Chris Lalancette) - Add support for setting disk drive serial numbers (Daniel P. Berrange) - VBox support for defining/dumping video devices (Pritesh Kothari) - Generic parsing support for video acceleration (Pritesh Kothari) - VMware ESX: Allow ethernet address type 'vpx' (Matthias Bolte) - Support for getting/setting number of cpus in VBox (Pritesh Kothari) - Make handling of monitor prompts more general. (Miloslav Trmač) - Attach encryption information to virDomainDiskDef. (Miloslav Trmač) - Recognize encryption format of qcow volumes. (Miloslav Trmač) - Attach encryption information to virStorageVolDef. (Miloslav Trmač) - Add volume encryption information handling. (Miloslav Trmač) - Secret manipulation API docs refresh & wire up python generator (Miloslav Trmač) - Secret manipulation remote client (Miloslav Trmač) - Secret manipulation libvirtd wire protocol & remote dispatcher (Miloslav Trmač) - Secret manipulation public API implementation (Miloslav Trmač) - Secret manipulation internal API (Miloslav Trmač) - Add test for recently fixed crash with latest XenD (Daniel P. Berrange) - Don't expose 'vnet%d' to the user (Mark McLoughlin) - Maintain a list of active PCI hostdevs and use it in pciResetDevice() (Mark McLoughlin) - Simplify PCI hostdev prepare/re-attach using a pciDeviceList type (Mark McLoughlin) - Use pci_addr=auto with QEMU's pci_add monitor command (Mark McLoughlin) - Check active domain hostdevs before allowing PCI reset (Mark McLoughlin) - Allow pciResetDevice() to reset multiple devices (Mark McLoughlin) - Improve PCI host device reset error message (Mark McLoughlin) - Reset and re-attach PCI host devices on guest shutdown (Mark McLoughlin) - Allow PM reset on multi-function PCI devices (Mark McLoughlin) - Detect KVM's PCI device assignment support (Mark McLoughlin) - Split virDomainMigrate into functions. (Chris Lalancette) - Consolidate code for parsing the logging env (Amy Griffis) * Cleanups: - Remove accidentally added UUID re-definition in storage schema (Daniel P. Berrange) - ESX cleanup of CPU model strings (Matthias Bolte) - Fix use of dlopen modules (Daniel P. Berrange) - Consolidate "cont" into qemudMonitorSendCont() (Miloslav Trmač) - Cleanup sec driver error reporting to use virReportSystemError (Daniel P. Berrange) - Port QEMU driver to use USB/PCI device helpers (Daniel P. Berrange) - Simplify and fix qemudCanonicalizeMachine() (Mark McLoughlin) - Split up qemudGetOldMachines() (Mark McLoughlin) - Re-factor qemu test machine allocation code (Mark McLoughlin) - Canonicalize the qemu machine type in qemuxml2argvtest (Mark McLoughlin) - Dump qemu driver capabilities if test debugging enabled (Mark McLoughlin) - Fix formatting of machine types in capabilities XML (Mark McLoughlin) - qemu_driver.c: factor out more duplication (Jim Meyering) - Deprecate lzma and lzop in favor of xz, add dep (Daniel Veillard) - qemu_driver.c: factor out duplication in compression-type handling (Jim Meyering) - openvz_conf.c: remove dead store to "p"; use strchrnul (Jim Meyering) - Remove some tabs used for indent (Daniel Veillard) - Updated a number of localizations and regenerated (Daniel Veillard) - Add a missing comment (Miloslav Trmač) - Fix a pasto in storage_encryption_conf.c (Miloslav Trmač) - xm_internal.c: remove four useless comparisons after strchr (Jim Meyering) - xm_internal.c: remove dead increment of "data" (Jim Meyering) - network_driver.c: remove dead store to "err" (Jim Meyering) - iptables.c: remove dead store to "s" (Jim Meyering) - util.c: avoid dead store to "flag" (Jim Meyering) - domain_conf.c: remove two dead stores (Jim Meyering) - xm_internal.c: remove two ret=... dead stores (Jim Meyering) - xm_internal.c: remove dead stores of local, "type" (Jim Meyering) - network_conf.c: remove dead store to "err" (Jim Meyering) - openvz_driver.c: avoid dead store to "err" (Jim Meyering) - xend_internal.c: Remove two dead stores to "ret" (Jim Meyering) - storage_driver.c: remove two dead stores to "backend" (Jim Meyering) - qemu_conf.c: add a comment suggesting why we leave a dead-store (Jim Meyering) - hash.c: remove a dead store (Jim Meyering) - interface_conf.c: remove a dead-store and declaration (Jim Meyering) - eventtest.c: detect write failure and avoid dead stores (Jim Meyering) - openvz_conf.c: Remove dead store to copy_fd (Jim Meyering) - storage_backend_logical.c: appease clang: remove useless increment (Jim Meyering) - ESX simplify SOAP request and response handling (Matthias Bolte) - ESX use virXPathNode*() to simplify XPath handling (Matthias Bolte) - ESX: make esxVI_GetVirtualMachineIdentity() robust (Matthias Bolte) - ESX: Fix VMX path parsing and URL encoding (Matthias Bolte) - VBox driver cleanups (Pritesh Kothari) - PHYP driver cleanups (Daniel Veillard) - Move QEMU monitor socket in /var/lib/libvirt/qemu (Daniel P. Berrange) - xen_internal.c: remove two unused local variables (Jim Meyering) - mdns.c: remove dead initialization (Jim Meyering) - node_device_conf.c: remove dead initialization (Jim Meyering) - openvz_conf.c: don't use undefined local, "net" (Jim Meyering) - test.c: don't use undefined local, "def" (Jim Meyering) - remote_internal.c: appease clang (Jim Meyering) - infra: define ATTRIBUTE_NONNULL to mark non-NULL parameters (Jim Meyering) - lxc: don't unlink(NULL) in main (Jim Meyering) - storage_conf.c: avoid overflow upon use of "z" or "Z" (zebi) suffix (Jim Meyering) - VBox cleanup and update of networking shutdown (Pritesh Kothari) - Box cleanup and update of networking XML functions (Pritesh Kothari) - Fix misc OOM bugs (Daniel P. Berrange) - Misc fixes to secrets API code (Daniel P. Berrange) - Only add glusterfs dep for Fedora >= 11 (Daniel P. Berrange) - Remove redundant base64 include file (Daniel P. Berrange) - Don't assume buffered output echoes the command. (Miloslav Trmač) - Update chinese, polish and spanish localizations (Daniel Veillard) - OpenVZ: accept NULL as type for GetMaxVCPUs. (Chris Lalancette) - Remove use of strncpy in qemudExtractMonitorPath. (Chris Lalancette) - Refactor policycode auth code to avoid compiler warnings (Daniel P. Berrange) - spec file: add URL to Source tag (Mark McLoughlin) - Small fixes for qemu save compression. (Chris Lalancette) - Fix thinko in PCI hostdev detach (Mark McLoughlin) - Revert changes to allow pciResetDevice() reset multiple devices (Mark McLoughlin) - Fix list updating after disk/network/hostdev hot-unplug (Mark McLoughlin) - Re-name remote_internal.c:driver to remote_driver (Mark McLoughlin) - Cosmetic change to 'virsh nodedev-list --tree' output (Mark McLoughlin) - Re-factor hostdev hotplug (Mark McLoughlin) - Remove a duplicated assignment in Xen PCI parsing. (Chris Lalancette) - Fix up a few minor indentation issues. (Chris Lalancette) - Fix phyp escape_specialcharacters. (Chris Lalancette) - Make openvzGetVPSUUID take a len. (Chris Lalancette) - Minor cleanup of error path for c_oneVmInfo. (Chris Lalancette) - Fix up a whitespace in comments in src/console.c (Chris Lalancette) - Fix up a stray whitespace in virHashGrow. (Chris Lalancette) - Remove unsafe strncpy from esx_vmx.c (Chris Lalancette) - Cleanup VIR_LOG_DEBUG parsing in eventtest (Amy Griffis) - Tighten libvirt's parsing of logging env (Amy Griffis) - Cleanup structure name naming (Matthias Bolte) - Add proper OOM reporting for esxDomainGetOSType (Matthias Bolte) Thanks to everybody who contributed one way or another, this list is getting longuer every release :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] Trouble booting Xen VM with NFS root file system
by Matthias Schmidt 15 Sep '09

15 Sep '09

Hi, I'm currently trying to boot a Xen VM with the root file system on NFS via libvirt. Previously we used a small python script and "xm create" to boot a number of VMs (which worked fine). Now I'm trying to integrate that functionality in a python project which uses libvirt, but sadly booting the VMs fail. The small script constructs a Xen command line which looks like the following: create =("/usr/sbin/xm create /foo.cfg \ kernel=%s ramdisk=%s memory=64\ root=/dev/nfs nfs_server=%s nfs_root=%s name=%s vif='mac=%s'\ dhcp='dhcp' vcpus=1 extra='init=/stateless.sh xencons=tty1'\ ")%(vm_kernel, vm_ramdisk, vm_nfs_server, vm_nfs_root, hostname, vif) kernel and ramdisk are the path to the installed version, vm_nfs_server is the IP address of the NFS server and vm_nfs_root the path to the operating system installation (which is a Debian Linux). Firing up the script brings up all VMs with a read-only NFS root file system. Now I tried to do this with libvirt, but all attempts failed with the following error popping up after the VM boots (after a certain time(out)): Gave up waiting for root device. Common problems: - Boot args (cat /proc/cmdline) - Check rootdelay= (did the system wait long enough?) - Check root= (did the system wait for the right device?) - Missing modules (cat /proc/modules; ls /dev) ALERT! /dev/nfs does not exist. Dropping to a shell! BusyBox v1.10.2 (Debian 1:1.10.2-2) built-in shell (ash) Enter 'help' for a list of built-in commands. /bin/sh: can't access tty; job control turned off (initramfs) cat /proc/cmdline root=/dev/nfs nfs_server=10.0.0.150 nfs_root=/opt/xge/util/ph vif="mac=1A:00:00:00:00:64" dhcp=dhcp extra="init=./stateless.sh xencons=tty" The cmdline looks the same as in the script, but booting won't work. I can provide the libvirt XML used to boot the VM and further information if that is necessary. Cheers Matthias PS: I'm using Xen 3.2.1, Kernel 2.6.26 and libvirt 0.6.3 from Debian here.

2 1

[libvirt] RFE storage cloning across connections.
by "Jóhann B. Guðmundsson" 15 Sep '09

15 Sep '09

Virt-manager now supports migration and VM cloning however cloning only works within a connection though so you can't clone to another machine. It certainly would be a nice addition if supports storage cloning across connections. Best regards. Jóhann B.

2 1

[libvirt] ANNOUNCE: perl bindings Sys-Virt release 0.2.2
by Daniel P. Berrange 15 Sep '09

15 Sep '09

FYI I have just uploaded a new release 0.2.2 of the libvirt perl bindings, Sys-Virt, to CPAN. http://search.cpan.org/dist/Sys-Virt/ Direct download link http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.2.2.tar.gz Changes since 0.2.1: - Add all new APIs upto libvirt 0.7.0 APIs (listing defined network interfaces) - Add missing APIs for looking up storage volumes based on path and key - Fix lookup of network interfaces based on MAC address - Add missing APIs for defining network interfaces and starting defined interfaces There will of course shortly be another release to cover the soon to be released APIs in libvirt 0.7.1 Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

Re: [libvirt] Interface driver and ESX support
by Matthias Bolte 15 Sep '09

15 Sep '09

Okay, I finally got the patches cleaned up. I just posted this 12 patches series to the mailing list. Apply them all to an up to date git clone and apply the attached, updated ESX interface driver stub patch in the end. Patch 6 of 12 adds the binding for HostCpuIdInfo and contains the functions to handle ArrayOf* types. Matthias 2009/9/13 Shahar Klein <shaharklein(a)yahoo.com>: > I see > You are making my (coding) life easier : ) > thanks > ________________________________ > From: Matthias Bolte <matthias.bolte(a)googlemail.com> > To: Shahar Klein <shaharklein(a)yahoo.com> > Cc: libvir-list(a)redhat.com > Sent: Sunday, September 13, 2009 4:39:22 PM > Subject: Re: [libvirt] Interface driver and ESX support > > No, as I said before you should wait until you can use the unpublished > binding of HostCpuIdInfo as an example. This also includes the code to > handle ArrayOf* types. I'm currently cleaning up this patches (didn't > have time on thursday for that) and will post them today, just wait > for this patches, because they will help you. > > Matthias > > 2009/9/13 Shahar Klein <shaharklein(a)yahoo.com>: >> I've defined (among others): >> int esxVI_PhysicalNic_CastListFromAnyType(virConnectPtr conn, >> esxVI_AnyType >> *anyType, esxVI_PhysicalNic **pNicList); >> but runing it returns somthing like: >> Expecting type 'PhysicalNic' but found 'ArrayOfPhysicalNic' >> Does it mean I should also implement: >> esxVI_ArrayOfPhysicalNic_CastListFromAnyType() >> and all the funcs/type definition coming with it? >> thanks >> Shahar >> ________________________________ >> From: Matthias Bolte <matthias.bolte(a)googlemail.com> >> To: Shahar Klein <shaharklein(a)yahoo.com> >> Cc: libvir-list(a)redhat.com >> Sent: Thursday, September 10, 2009 6:24:25 PM >> Subject: Re: [libvirt] Interface driver and ESX support >> >> 2009/9/10 Shahar Klein <shaharklein(a)yahoo.com>: >>> I'm not sure what you mean about mapping >>> lets take the pnics as a study case for me >>> do I need to define a structure similar to this: >>> >>> >>> http://www.vmware.com/support/developer/vc-sdk/visdk400pubs/ReferenceGuide/… >>> and also take care for it's allocation? >>> >> >> Yes, you need to implement the mapping (a better word may be >> 'binding') of this VI API type to a C type, that also includes to care >> about its allocation. You'll need to implement at least this set of >> function in esx_vi_types.[ch]: >> >> esxVI_PhysicalNic_Alloc() >> esxVI_PhysicalNic_Free() >> esxVI_PhysicalNic_CastFromAnyType() >> esxVI_PhysicalNic_CastListFromAnyType() >> esxVI_PhysicalNic_Deserialize() >> esxVI_PhysicalNic_DeserializeList() >> >> You could use the binding for the HostCpuIdInfo type, but >> unfortunately I haven't published the code for it yet. This code also >> includes some essential helper functions for >> esxVI_PhysicalNic_CastListFromAnyType(). >> >> Beside the PhysicalNic type, you may also have to bind the types of >> its members like PhysicalNicLinkInfo, PhysicalNicSpec and >> HostIpConfig, if you need or care about the information provided by >> them. >> >> The binding for HostCpuIdInfo is part of a larger set of patches that >> add some new features to ESX driver, but the patches needs some >> cleanup first. I may have some time later this evening to clean them >> up and post them. >> >> PS: You should refer to version 2.5 of the VI API [1] and not 4.0, >> because the complete VI API mapping is currently based on version 2.5. >> At some point I'll have to properly distinguish between version 2.5 >> and 4.0, but currently I would like to stick to version 2.5 only. >> >> [1] >> http://www.vmware.com/support/developer/vc-sdk/visdk25pubs/ReferenceGuide/ >> >> Matthias >> >> > >

3 3

[libvirt] [PATCH]: Bug when you try to start machines made will older VBox versions
by Pritesh Kothari 15 Sep '09

15 Sep '09

Hi All, Thanks to Florian, who pointed out the bug, due to which you can't start domains defined with older builds or with empty "FRONTEND/Type" tag in their xml files. Fixed it in the following patch. Regards, Pritesh

2 1

[libvirt] [PATCH 0/4] Changes to API/ABI for secrets handling
by Daniel P. Berrange 14 Sep '09

14 Sep '09

This series makes two changes to the public API and wire protocol ABI for the secrets handling support recently committed. As such this is a must fix before we do the release, since we can't break compatability once released. The first patch changes all the code to store UUIDs in raw format instead of printable format. This is important because it ensures that e3a9758f-b0c6-7a3a-ebb9-71a69c930289 is treated exactly the same as e3a9758fb0c67a3aebb971a69c930289, which is not the case with the currently committed code. It also makes the secrets and storage encryption XML parsers use the internal UUID handling APIs The second patch adds a new unique property to virSecretPtr. The "owner ID" is intended to be unique on a host wrt all secrets with matching usage type. This entails adding 2 APIs to querying the usage type, and another API to lookup a secret based on its usage. In testing the current code I frequently found myself getting into the situation where there were many secrets for the same volume which was not at all good. So if defining a secret to be used with a storage volume this ensures that you only ever have one secret associated with each storage volume path. The third patch ensures that when you query the XML for a qcow encrypted voluem, it will include the UUID of the secret. Previously if you created a volume, and then restarted libvirtd, the secret UUID would be lost. This patch is why we need the new API from the second patch virLookupSecretByUsage - without that it would be impossible to lookup the secret efficiently. THe final patch is a minor tweak to the RNG

3 13

[libvirt] [PATCH] Fix win32 platform build
by Daniel P. Berrange 14 Sep '09

14 Sep '09

* configure.in: Only define WITH_SECRETS if libvirtd is present * src/Makefile.am: Only build secrets driver if WITH_SECRETS is defined. Always add SECRET_DRIVER_SOURCES to EXTRA_DIST --- configure.in | 11 +++++++++++ src/Makefile.am | 3 +++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/configure.in b/configure.in index 120f7e7..fad1297 100644 --- a/configure.in +++ b/configure.in @@ -1062,6 +1062,17 @@ AM_CONDITIONAL([WITH_NETCF], [test "$with_netcf" = "yes"]) AC_SUBST([NETCF_CFLAGS]) AC_SUBST([NETCF_LIBS]) + +with_secrets=yes +if test "$with_libvirtd" = "no"; then + with_secrets=no +fi +if test "$with_secrets" = "yes" ; then + AC_DEFINE_UNQUOTED([WITH_SECRETS], 1, [whether local secrets management driver is available]) +fi +AM_CONDITIONAL([WITH_SECRETS], [test "$with_secrets" = "yes"]) + + AC_ARG_WITH([storage-fs], [ --with-storage-fs with FileSystem backend for the storage driver (on)],[],[with_storage_fs=check]) AC_ARG_WITH([storage-lvm], diff --git a/src/Makefile.am b/src/Makefile.am index 14a3a63..69f5ee7 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -461,6 +461,7 @@ endif libvirt_driver_interface_la_SOURCES = $(INTERFACE_DRIVER_SOURCES) endif +if WITH_SECRETS if WITH_DRIVER_MODULES mod_LTLIBRARIES += libvirt_driver_secret.la else @@ -471,6 +472,7 @@ if WITH_DRIVER_MODULES libvirt_driver_secret_la_LDFLAGS = -module -avoid-version endif libvirt_driver_secret_la_SOURCES = $(SECRET_DRIVER_SOURCES) +endif # Needed to keep automake quiet about conditionals libvirt_driver_storage_la_SOURCES = @@ -574,6 +576,7 @@ EXTRA_DIST += \ $(NODE_DEVICE_DRIVER_HAL_SOURCES) \ $(NODE_DEVICE_DRIVER_DEVKIT_SOURCES) \ $(SECURITY_DRIVER_SELINUX_SOURCES) \ + $(SECRET_DRIVER_SOURCES) \ $(VBOX_DRIVER_EXTRA_DIST) # -- 1.6.2.5

2 1

[libvirt] ESX [07/12]: Whitespace cleanup
by Matthias Bolte 14 Sep '09

14 Sep '09

Subject says it all.

2 1