- Devel - libvirt List Archives

[libvirt] [PATCH] openvzGetVEID: don't leak (memory + file descriptor)
by Jim Meyering 25 Feb '10

25 Feb '10

Coverity spotted the leaks. Here's a proposed fix. I didn't bother with a separate diagnostic for the unlikely event that we read a negative number from the pipe. Seems far-fetched enough not to bother, but it's easy to add, if anyone cares. >From f3439c7eae46681eacf5b469a6f0e22cb8fec1b4 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 25 Feb 2010 19:24:50 +0100 Subject: [PATCH] openvzGetVEID: don't leak (memory + file descriptor) * src/openvz/openvz_conf.c (openvzGetVEID): Always call fclose. Diagnose parse failure also when vzlist output is empty. If somehow we read a -1, diagnose that (albeit as a parse failure). --- src/openvz/openvz_conf.c | 19 +++++++------------ 1 files changed, 7 insertions(+), 12 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index ce0c4d3..3713a45 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -964,6 +964,7 @@ int openvzGetVEID(const char *name) { char *cmd; int veid; FILE *fp; + bool ok; if (virAsprintf(&cmd, "%s %s -ovpsid -H", VZLIST, name) < 0) { openvzError(NULL, VIR_ERR_INTERNAL_ERROR, "%s", @@ -979,18 +980,12 @@ int openvzGetVEID(const char *name) { return -1; } - if (fscanf(fp, "%d\n", &veid ) != 1) { - if (feof(fp)) - return -1; - - openvzError(NULL, VIR_ERR_INTERNAL_ERROR, - "%s", _("Failed to parse vzlist output")); - goto cleanup; - } - - return veid; - - cleanup: + ok = fscanf(fp, "%d\n", &veid ) == 1; fclose(fp); + if (ok && veid >= 0) + return veid; + + openvzError(NULL, VIR_ERR_INTERNAL_ERROR, + "%s", _("Failed to parse vzlist output")); return -1; } -- 1.7.0.401.g84adb

2 3

[libvirt] avoid "make rpm" failure in doc/
by Jim Meyering 25 Feb '10

25 Feb '10

"make rpm" fails like this: Rebuilding the HTML pages from the XML API make[3]: *** No rule to make target `html/libvirt-libvirt.html', needed by `distdir'. Stop. make[3]: *** Waiting for unfinished jobs.... Validating the resulting XHTML pages These two patches fix that: (though "make rpm" still fails for me: extracting debug info from /j/rpmbuild/BUILDROOT/libvirt-0.7.6-1.fc12.x86_6h.. *** ERROR: No build ID note found in /j/rpmbuild/BUILDROOT/libvirt-0.7.6-1.h.. The first (1/2) change is not officially required to solve this problem, but it overlapped, and does fix a non-distdir build failure. >From ace4dca5dfbc022b057ce1d9f3d2770ad3a34716 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 24 Feb 2010 22:51:47 +0100 Subject: [PATCH 1/2] build: teach apibuild.py to work in a non-srcdir build * docs/Makefile.am (libvirt-api.xml libvirt-refs.xml): Generalize apibuild.py to work in a non-srcdir build. Pass "srcdir" to it. * docs/apibuild.py (rebuild): Honor the $srcdir envvar. --- docs/Makefile.am | 2 +- docs/apibuild.py | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index e47b668..dbbd1ef 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -132,7 +132,7 @@ devhelp/index.html devhelp/libvirt.devhelp: libvirt-api.xml $(devhelpxsl) libvirt-api.xml libvirt-refs.xml: apibuild.py \ $(srcdir)/../include/libvirt/*.h \ $(srcdir)/../src/libvirt.c $(srcdir)/../src/util/virterror.c - -$(srcdir)/apibuild.py + -srcdir=$(srcdir) $(srcdir)/apibuild.py clean-local: rm -f *~ *.bak *.hierarchy *.signals *-unused.txt diff --git a/docs/apibuild.py b/docs/apibuild.py index e233c8b..0ab5db2 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -2102,10 +2102,14 @@ class docBuilder: def rebuild(): builder = None - if glob.glob("../src/libvirt.c") != [] : + srcdir = os.environ["srcdir"] + if glob.glob(srcdir + "/../src/libvirt.c") != [] : print "Rebuilding API description for libvirt" - builder = docBuilder("libvirt", ["../src", "../src/util", "../include/libvirt"], - []) + builder = docBuilder("libvirt", + [srcdir + "/../src", + srcdir + "/../src/util", + srcdir + "/../include/libvirt"], + []) elif glob.glob("src/libvirt.c") != [] : print "Rebuilding API description for libvir" builder = docBuilder("libvirt", ["src", "src/util", "include/libvirt"], -- 1.7.0.401.g84adb >From a79fb1c491197a91094cd2345c3d7bbba40da2fd Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 25 Feb 2010 10:35:20 +0100 Subject: [PATCH 2/2] build: avoid "make rpm" failure in docs/ Add missing rule to build html/libvirt-libvirt.html. Use a GNU Make pattern rule to avoid running apibuild.py once for each out-of-date target, in a parallel build. * docs/Makefile.am --- docs/Makefile.am | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index dbbd1ef..edf6fc8 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -123,17 +123,20 @@ html/index.html: libvirt-api.xml newapi.xsl page.xsl sitemap.html.in $(XMLLINT) --nonet --valid --noout html/*.html ; \ else echo "missing XHTML1 DTD" ; fi ; fi ); -devhelp/index.html devhelp/libvirt.devhelp: libvirt-api.xml $(devhelpxsl) +$(devhelphtml): libvirt-api.xml $(devhelpxsl) -@(echo Rebuilding devhelp files) -@(if [ -x $(XSLTPROC) ] ; then \ - $(XSLTPROC) --nonet -o devhelp/libvirt.devhelp $(top_srcdir)/docs/devhelp/devhelp.xsl $(top_srcdir)/docs/libvirt-api.xml ; fi ); + $(XSLTPROC) --nonet -o devhelp/libvirt.devhelp \ + $(top_srcdir)/docs/devhelp/devhelp.xsl libvirt-api.xml ; fi ); - -libvirt-api.xml libvirt-refs.xml: apibuild.py \ - $(srcdir)/../include/libvirt/*.h \ - $(srcdir)/../src/libvirt.c $(srcdir)/../src/util/virterror.c +html/%-%.html html/%-virterror.html %-api.xml %-refs.xml: $(srcdir)/apibuild.py -srcdir=$(srcdir) $(srcdir)/apibuild.py +html/%-%.html html/%-virterror.html %-api.xml %-refs.xml: \ + $(srcdir)/../include/%/*.h \ + $(srcdir)/../src/%.c \ + $(srcdir)/../src/util/virterror.c + clean-local: rm -f *~ *.bak *.hierarchy *.signals *-unused.txt -- 1.7.0.401.g84adb

2 3

[libvirt] [PATCH] build: avoid non-srcdir "make distcheck" failures (CLEANFILES)
by Jim Meyering 25 Feb '10

25 Feb '10

A quick review won't hurt, but this doesn't really need one. >From 9ac893a1342b31ef7df6fc57c03767c49ef98d5b Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 25 Feb 2010 09:28:51 +0100 Subject: [PATCH 1/4] build: avoid non-srcdir "make distcheck" failures (CLEANFILES) * docs/Makefile.am (MAINTAINERCLEANFILES): Use this variable for generated-and-distributed files, not "CLEANFILES". Besides, "make clean" and "make distclean" should not delete distributed files. --- docs/Makefile.am | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 07ea9bf..dbbd1ef 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -17,7 +17,7 @@ apipng = \ html/home.png \ html/right.png -devhelphtml = \ +devhelphtml = \ devhelp/libvirt.devhelp \ devhelp/index.html \ devhelp/general.html \ @@ -79,7 +79,7 @@ EXTRA_DIST= \ sitemap.html.in \ ChangeLog.awk -CLEANFILES = $(dot_html) $(apihtml) $(devhelphtml) +MAINTAINERCLEANFILES = $(dot_html) $(apihtml) $(devhelphtml) all: web -- 1.7.0.401.g84adb

2 1

[libvirt] [PATCH] qemu: Report binary path if error parsing -help
by Cole Robinson 25 Feb '10

25 Feb '10

Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/qemu/qemu_conf.c | 14 ++++++++------ src/qemu/qemu_conf.h | 3 ++- tests/qemuhelptest.c | 3 ++- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index e3da08a..1f8a9c3 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1237,7 +1237,8 @@ static unsigned long long qemudComputeCmdFlags(const char *help, #define SKIP_BLANKS(p) do { while ((*(p) == ' ') || (*(p) == '\t')) (p)++; } while (0) -int qemudParseHelpStr(const char *help, +int qemudParseHelpStr(const char *qemu, + const char *help, unsigned long long *flags, unsigned int *version, unsigned int *is_kvm, @@ -1308,8 +1309,8 @@ fail: p = strndup(help, p - help); qemuReportError(VIR_ERR_INTERNAL_ERROR, - _("cannot parse QEMU version number in '%s'"), - p ? p : help); + _("cannot parse %s version number in '%s'"), + qemu, p ? p : help); VIR_FREE(p); @@ -1340,12 +1341,13 @@ int qemudExtractVersionInfo(const char *qemu, enum { MAX_HELP_OUTPUT_SIZE = 1024*64 }; int len = virFileReadLimFD(newstdout, MAX_HELP_OUTPUT_SIZE, &help); if (len < 0) { - virReportSystemError(errno, "%s", - _("Unable to read QEMU help output")); + virReportSystemError(errno, + _("Unable to read %s help output"), qemu); goto cleanup2; } - if (qemudParseHelpStr(help, &flags, &version, &is_kvm, &kvm_version) == -1) + if (qemudParseHelpStr(qemu, help, &flags, + &version, &is_kvm, &kvm_version) == -1) goto cleanup2; if (retversion) diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index ae187dc..c8757c5 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -175,7 +175,8 @@ int qemudExtractVersionInfo (const char *qemu, unsigned int *version, unsigned long long *qemuCmdFlags); -int qemudParseHelpStr (const char *str, +int qemudParseHelpStr (const char *qemu, + const char *str, unsigned long long *qemuCmdFlags, unsigned int *version, unsigned int *is_kvm, diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index 0f2b509..ad355d7 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -49,7 +49,8 @@ static int testHelpStrParsing(const void *data) if (virtTestLoadFile(path, &help, MAX_HELP_OUTPUT_SIZE) < 0) return -1; - if (qemudParseHelpStr(help, &flags, &version, &is_kvm, &kvm_version) == -1) + if (qemudParseHelpStr("QEMU", help, &flags, + &version, &is_kvm, &kvm_version) == -1) return -1; if (flags != info->flags) { -- 1.6.5.2

2 2

[libvirt] [PATCH] remote: Improve daemon startup error reporting
by Cole Robinson 25 Feb '10

25 Feb '10

If I toggle enable_tcp in libvirtd.conf and add --listen in /etc/init.d/libvirtd, I get the unhelpful error: Starting libvirtd daemon: error: Unable to initialize network sockets. Running without --daemon provides much more useful info: sudo libvirtd --listen 11:29:26.117: error : remoteCheckCertFile:270 : Cannot access CA certificate '/etc/pki/CA/cacert.pem': No such file or directory The daemon architecture makes it difficult to report this useful info if daemonized, so point users to /var/log/messages and dropping the --daemon flag if they want more info. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- daemon/libvirtd.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index fefa7aa..cee6f13 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -474,7 +474,10 @@ static int daemonForkIntoBackground(void) { goto again; if (ret == 1 && status != 0) { - fprintf(stderr, "error: %s\n", virDaemonErrTypeToString(status)); + fprintf(stderr, + "error: %s. Check /var/log/messages or run without " + "--daemon for more info.\n", + virDaemonErrTypeToString(status)); } _exit(ret == 1 && status == 0 ? 0 : 1); } -- 1.6.5.2

2 1

[libvirt] [PATCH] virsh: Show errors reported by nonAPI functions
by Cole Robinson 25 Feb '10

25 Feb '10

Only API calls trigger the error callback, which is required for proper virsh error reporting. Since we use non API functions from util/, make sure we properly report these errors. Fixes lack of error message from 'virsh create idontexit.xml' Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- tools/virsh.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 5fdbbe5..74e3fad 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -352,8 +352,16 @@ virshErrorHandler(void *unused ATTRIBUTE_UNUSED, virErrorPtr error) static void virshReportError(vshControl *ctl) { - if (last_error == NULL) - return; + if (last_error == NULL) { + /* Calling directly into libvirt util functions won't trigger the + * error callback (which sets last_error), so check it ourselves. + * + * If the returned error has CODE_OK, this most likely means that + * no error was ever raised, so just ignore */ + last_error = virSaveLastError(); + if (!last_error || last_error->code == VIR_ERR_OK) + return NULL; + } if (last_error->code == VIR_ERR_OK) { vshError(ctl, "%s", _("unknown error")); -- 1.6.5.2

2 1

[libvirt] [PATCH] Use standard spacing for user/pass prompt
by Cole Robinson 24 Feb '10

24 Feb '10

Kind of minor, but it annoys me that the default auth callback doesn't put a space between the prompt and the input, like a typical terminal, ssh, etc. This patch changes the current prompt: Please enter your authentication name:myuser to Please enter your authentication name: myuser Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/libvirt.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index be17668..9d50c92 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -159,7 +159,7 @@ static int virConnectAuthCallbackDefault(virConnectCredentialPtr cred, case VIR_CRED_AUTHNAME: case VIR_CRED_ECHOPROMPT: case VIR_CRED_REALM: - if (printf("%s:", cred[i].prompt) < 0) + if (printf("%s: ", cred[i].prompt) < 0) return -1; if (fflush(stdout) != 0) return -1; @@ -178,7 +178,7 @@ static int virConnectAuthCallbackDefault(virConnectCredentialPtr cred, case VIR_CRED_PASSPHRASE: case VIR_CRED_NOECHOPROMPT: - if (printf("%s:", cred[i].prompt) < 0) + if (printf("%s: ", cred[i].prompt) < 0) return -1; if (fflush(stdout) != 0) return -1; -- 1.6.5.2

2 1

[libvirt] the price we pay for using gettext-0.14
by Jim Meyering 24 Feb '10

24 Feb '10

Make distcheck currently fails like this: make[2]: Entering directory `/t/libvirt-0.7.6/_build/po' /bin/sh @MKINSTALLDIRS@ /t/libvirt-0.7.6/_inst/share /bin/sh: @MKINSTALLDIRS@: No such file or directory make[2]: *** [install-data-yes] Error 127 That is due to our use of a version of gettext that is way too old: $ grep GETT configure.ac AM_GNU_GETTEXT_VERSION([0.14.1]) The work-around is to define (via AC_SUBST) the now-obsolete symbol, MKINSTALLDIRS, so that @MKINSTALLDIRS@ in the autopoint-provided Makefile.in.in (from the old version of gettext) ends up being substituted. As I recall, people insist on using this old version of gettext, because nothing newer is supplied by RHEL5.x. IMHO, that is RHEL5's problem, and should not be allowed to cause continuing problems in upstream projects. It is easy and safe to install a newer version of gettext, especially since any project using autopoint will automatically continue to get the same bit-rotting old files: a gettext installation includes an archive of all older versions of its files, to provide just this type of backwards compatibility. We had a similar problem in libguestfs, and it was not trivial to diagnose there, either, even though I'd seen it at least once or twice before then. Here's the work-around: [just realized this requires a comment. adding that now] >From 16b9418427101a495b7fdd6917f518f254d22720 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 24 Feb 2010 10:53:44 +0100 Subject: [PATCH] build: ensure that MKINSTALLDIRS is AC_SUBST-defined since we're using gettext-0.14.1, which uses that now-obsolete automake symbol. Otherwise, make distcheck would fails like this: make[2]: Entering directory `/t/libvirt-0.7.6/_build/po' /bin/sh @MKINSTALLDIRS@ /t/libvirt-0.7.6/_inst/share /bin/sh: @MKINSTALLDIRS@: No such file or directory make[2]: *** [install-data-yes] Error 127 * configure.ac (MKINSTALLDIRS): Define. --- configure.ac | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 117cb20..2f79970 100644 --- a/configure.ac +++ b/configure.ac @@ -49,6 +49,8 @@ AC_PROG_CPP AC_OBJEXT +AC_SUBST([MKINSTALLDIRS], [$ac_aux_dir/mkinstalldirs]) + dnl gl_INIT uses m4_foreach_w, yet that is not defined in autoconf-2.59. dnl In order to accommodate developers with such old tools, here's a dnl replacement definition. -- 1.7.0.367.g566c3

3 4

[libvirt] [PATCH] maint: relax git minimum version
by Eric Blake 24 Feb '10

24 Feb '10

From: Eric Blake <eblake(a)redhat.com> Requiring git 1.6.4, just for the optional GNULIB_SRCDIR support, was too harsh. Resynchronize from gnulib. * .gnulib: Import from latest gnulib. * bootstrap: Re-synchronize from .gnulib/build-aux. * bootstrap.conf: Drop git to 1.5.5. * README-hacking: Document use of GNULIB_SRCDIR. --- Chris is currently testing that RHEL 5 with git 1.5.5 can actually grok this patch. We don't have a README-prereq (but README-hacking was borrowed from coreutils, which does). Should we add one? The README-prereq in coreutils is not quite relevant for a straight-across copy. .gnulib | 2 +- README-hacking | 9 +++++++-- bootstrap | 41 +++++++++++++++++++++++++++++++++++------ bootstrap.conf | 2 +- 4 files changed, 44 insertions(+), 10 deletions(-) diff --git a/.gnulib b/.gnulib index 11fbc57..108cfb8 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 11fbc57405a118e6ec9a3ebc19bbf5ececdae4d6 +Subproject commit 108cfb803174abf17eb101e9999b9d1a642ce1ba diff --git a/README-hacking b/README-hacking index 4105a3e..80b022c 100644 --- a/README-hacking +++ b/README-hacking @@ -12,8 +12,7 @@ requirements on anyone wishing to build from the just-checked-out sources. Note the requirements to build the released archive are much less and are just the requirements of the standard ./configure && make procedure. Specific development tools and versions will be checked for and listed by -the bootstrap script. See README-prereq for specific notes on obtaining -these prerequisite tools. +the bootstrap script. Valgrind <http://valgrind.org/> is also highly recommended, if Valgrind supports your architecture. See also README-valgrind. @@ -28,6 +27,12 @@ You can get a copy of the source repository like this: $ git clone git://libvirt.org/libvirt $ cd libvirt +As an optional step, if you already have a copy of the gnulib git +repository on your hard drive, then you can use it as a reference to +reduce download time and disk space requirements: + + $ export GNULIB_SRCDIR=/path/to/gnulib + The next step is to get all required pieces from gnulib, to run autoreconf, and to invoke ./configure: diff --git a/bootstrap b/bootstrap index be96444..365a3d9 100755 --- a/bootstrap +++ b/bootstrap @@ -1,4 +1,6 @@ #! /bin/sh +# Print a version string. +scriptversion=2010-02-24.17; # UTC # Bootstrap this package from checked-out sources. @@ -17,7 +19,15 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -# Written by Paul Eggert. +# Originally written by Paul Eggert. The canonical version of this +# script is maintained as build-aux/bootstrap in gnulib, however, to +# be useful to your project, you should place a copy of it under +# version control in the top-level directory of your project. The +# intent is that all customization can be done with a bootstrap.conf +# file also maintained in your version control; gnulib comes with a +# template build-aux/bootstrap.conf to get you started. + +# Please report bugs or propose patches to bug-gnulib(a)gnu.org. nl=' ' @@ -161,7 +171,6 @@ vc_ignore=auto # die otherwise. find_tool () { - # Find sha1sum, named gsha1sum on MacPorts. find_tool_envvar=$1 shift find_tool_names=$@ @@ -424,12 +433,28 @@ case ${GNULIB_SRCDIR--} in GNULIB_SRCDIR=$gnulib_path ;; *) - # Use GNULIB_SRCDIR as a reference. Assumes git 1.6.4 or newer. + # Use GNULIB_SRCDIR as a reference. if test -d "$GNULIB_SRCDIR"/.git && \ git_modules_config submodule.gnulib.url >/dev/null; then echo "$0: getting gnulib files..." - git submodule update --init --reference "$GNULIB_SRCDIR" \ + if git submodule --help|grep reference > /dev/null; then + # Prefer the one-liner available in git 1.6.4 or newer. + git submodule update --init --reference "$GNULIB_SRCDIR" \ "$gnulib_path" || exit $? + else + # This fallback allows at least git 1.5.5. + if test -f "$gnulib_path"/gnulib-tool; then + # Since file already exists, assume submodule init already complete. + git submodule update || exit $? + else + # Older git can't clone into an empty directory. + rmdir "$gnulib_path" 2>/dev/null + git clone --reference "$GNULIB_SRCDIR" \ + "$(git_modules_config submodule.gnulib.url)" "$gnulib_path" \ + && git submodule init && git submodule update \ + || exit $? + fi + fi GNULIB_SRCDIR=$gnulib_path fi ;; @@ -819,6 +844,10 @@ bootstrap_epilogue echo "$0: done. Now you can run './configure'." -# Local Variables: -# indent-tabs-mode: nil +# Local variables: +# eval: (add-hook 'write-file-hooks 'time-stamp) +# time-stamp-start: "scriptversion=" +# time-stamp-format: "%:y-%02m-%02d.%02H" +# time-stamp-time-zone: "UTC" +# time-stamp-end: "; # UTC" # End: diff --git a/bootstrap.conf b/bootstrap.conf index d315e04..58ef2ab 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -124,7 +124,7 @@ autoconf 2.59 automake 1.9.6 autopoint - gettext - -git 1.6.4 +git 1.5.5 gzip - libtool - perl 5.5 -- 1.6.6.1

2 2

[libvirt] [PATCH v2] libvirtd: Better initscript error reporting
by Cole Robinson 24 Feb '10

24 Feb '10

>From time to time I bork my install, and hate it when the initscript returns no info. This patch removes the sanity check, which lets the shell give us 'command not found' or 'permission denied' errors. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- daemon/libvirtd.init.in | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/daemon/libvirtd.init.in b/daemon/libvirtd.init.in index 071fe2c..b808ab3 100644 --- a/daemon/libvirtd.init.in +++ b/daemon/libvirtd.init.in @@ -32,9 +32,6 @@ # pidfile: @localstatedir@/run/libvirtd.pid # -# Sanity checks. -[ -x @sbindir@/libvirtd ] || exit 0 - # Source function library. . @sysconfdir@/rc.d/init.d/functions -- 1.6.5.2

1 0