- Devel - libvirt List Archives

[libvirt] [PATCH] [macvtap] interface type direct web docs addition
by Stefan Berger 01 Mar '10

01 Mar '10

This adds a description about the 'direct' type of interface recently added for macvtap device type support on the host.

3 2

[libvirt] [PATCH] Free the macvtap mode string
by Stefan Berger 01 Mar '10

01 Mar '10

I forgot to free the macvtap mode string. This fixes it. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>

3 2

[libvirt] Hypervisor raw options
by Daniel Dehennin 01 Mar '10

01 Mar '10

Hello, I wonder if it's possible to add hypervisor pass-through options, I add some usage of kvm -startdate and need to use a script which call kvm with the desired option. Something like: <emulator>/usr/bin/kvm</emulator> <emulator-options> <option>-option1</option> <option>-option2</option> </emulator-options> The several <option/> will be passed to the <emulator/> command. Regards. -- Daniel Dehennin Récupérer ma clef GPG: gpg --keyserver pgp.mit.edu --recv-keys 0x6A2540D1

2 1

[libvirt] reload libvirtd.conf has a little problem.
by Osier Yang 01 Mar '10

01 Mar '10

hi When libvirtd is running, I changed "unix_sock_ro_perms=0777" into ""unix_sock_ro_perms=0755", and then reload the configuration with: kill -SIGHUP `pidof libvirtd` or "service libvirtd reload" the permission of /var/lib/libvirt/libvirt-sock-ro still is 0777, but not 0755. and after "service libvirtd restart", the permission is changed into 0755. think it's a little problem. libvirt version: libvirt-0.7.6-1.fc12.x86_64 Thanks and Regards osier

2 2

[libvirt] [PATCH] build: avoid warning about unused variables
by Jim Meyering 01 Mar '10

01 Mar '10

>From 8ddff3e6cdccc2b4289509c6941b43f2ddf8e643 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 25 Feb 2010 14:19:33 +0100 Subject: [PATCH] build: avoid warning about unused variables * tools/virsh.c (cmdCPUBaseline): Remove declarations of unused variables, p and cur. --- tools/virsh.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 5fdbbe5..89eefcf 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -7048,12 +7048,11 @@ cmdCPUBaseline(vshControl *ctl, const vshCmd *cmd) int found; int ret = TRUE; char *buffer; - char *p; char *result = NULL; const char **list = NULL; unsigned int count = 0; xmlDocPtr doc = NULL; - xmlNodePtr node_list, cur; + xmlNodePtr node_list; xmlXPathContextPtr ctxt = NULL; xmlSaveCtxtPtr sctxt = NULL; xmlBufferPtr buf = NULL; -- 1.7.0.401.g84adb

2 1

[libvirt] [PATCH] libvirtd: do not ignore failure to set group ID in privileged mode
by Jim Meyering 26 Feb '10

26 Feb '10

Coverity spotted these unchecked setgid calls: >From 7eddaf457d54974859a8c22cced6f43e2d267746 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 26 Feb 2010 10:42:14 +0100 Subject: [PATCH] libvirtd: do not ignore failure to set group ID in privileged mode * daemon/libvirtd.c (qemudListenUnix): Diagnose and fail upon failure to set or restore group-ID. --- daemon/libvirtd.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index cee6f13..9bdbecb 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -560,8 +560,10 @@ static int qemudListenUnix(struct qemud_server *server, oldgrp = getgid(); oldmask = umask(readonly ? ~unix_sock_ro_mask : ~unix_sock_rw_mask); - if (server->privileged) - setgid(unix_sock_gid); + if (server->privileged && setgid(unix_sock_gid)) { + VIR_ERROR(_("Failed to set group ID to %d"), unix_sock_gid); + goto cleanup; + } if (bind(sock->fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { VIR_ERROR(_("Failed to bind socket to '%s': %s"), @@ -569,8 +571,10 @@ static int qemudListenUnix(struct qemud_server *server, goto cleanup; } umask(oldmask); - if (server->privileged) - setgid(oldgrp); + if (server->privileged && setgid(oldgrp)) { + VIR_ERROR(_("Failed to restore group ID to %d"), oldgrp); + goto cleanup; + } if (listen(sock->fd, 30) < 0) { VIR_ERROR(_("Failed to listen for connections on '%s': %s"), -- 1.7.0.442.g55ad1

2 2

[libvirt] [PATCH] build: avoid warning about return-with-value in void function
by Jim Meyering 26 Feb '10

26 Feb '10

I saw this: virsh.c: In function 'virshReportError': virsh.c:363: warning: 'return' with a value, in function returning void >From fc83f08ac204cec5fba474a23bd19386d1a415d7 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 26 Feb 2010 11:50:34 +0100 Subject: [PATCH] build: avoid warning about return-with-value in void function * tools/virsh.c: Just "return;", not "return NULL;". --- tools/virsh.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index f7fd7d4..3b1011c 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -360,7 +360,7 @@ virshReportError(vshControl *ctl) * no error was ever raised, so just ignore */ last_error = virSaveLastError(); if (!last_error || last_error->code == VIR_ERR_OK) - return NULL; + return; } if (last_error->code == VIR_ERR_OK) { -- 1.7.0.442.g55ad1

2 1

[libvirt] build: update gnulib submodule to latest
by Jim Meyering 26 Feb '10

26 Feb '10

Thanks, Eric. >From bd3ff6b34892fe75cfcc67f1aeab43e8a273c1b6 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 26 Feb 2010 17:14:01 +0100 Subject: [PATCH] build: update gnulib submodule to latest * .gnulib: Update to latest. Commit 89bdf84bcd9c6032e37 inadvertently rewound the .gnulib submodule by 51 commits. This corrects it. Spotted by Eric Blake. --- .gnulib | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/.gnulib b/.gnulib index 11fbc57..80cd995 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 11fbc57405a118e6ec9a3ebc19bbf5ececdae4d6 +Subproject commit 80cd995cdcbf4b9ded895a43621a11f11806ad8d -- 1.7.0.442.g55ad1

2 1

[libvirt] [PATCH] Only build virDomainObjFormat if not building proxy.
by Chris Lalancette 26 Feb '10

26 Feb '10

While building under RHEL-5, I got a compile warning because virDomainObjFormat was defined but not used. That came about because in RHEL-5 we build with "#define PROXY", and virDomainObjFormat is only used with !PROXY. Move the define. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/conf/domain_conf.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b6d2c61..1d7f458 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5668,6 +5668,8 @@ char *virDomainDefFormat(virDomainDefPtr def, return NULL; } +#ifndef PROXY + static char *virDomainObjFormat(virCapsPtr caps, virDomainObjPtr obj, int flags) @@ -5703,9 +5705,6 @@ error: return NULL; } - -#ifndef PROXY - int virDomainSaveXML(const char *configDir, virDomainDefPtr def, const char *xml) -- 1.6.6.1

3 3

[libvirt] Odd implementation of libvirt qemudDomainSetMaxMemory
by Chris Lalancette 26 Feb '10

26 Feb '10

Hey Cole, In commit 09a33fd8a9cc85e5e1064168472bff7aecff15fb, you made it so that qemudDomainSetMaxMemory() was hotplug only. However, with the changes you pushed, this function no longer makes a lot of sense. It looks up the domain, checks to make sure it is active, and then if it is active, it fails. Assuming that qemu doesn't support changing the maximum amount of memory on the fly, wouldn't it be better to just remove this function entirely and let the higher libvirt layers report "function not supported"? -- Chris Lalancette

2 1