- Devel - libvirt List Archives

[libvirt PATCH 0/7] qemu: Add support for zero-copy migration
by Jiri Denemark 23 Jun '22

23 Jun '22

This series also fixes a few issues around memory locking limit in migration code which I found while implementing the feature. Jiri Denemark (7): qemu: Add qemuDomainSetMaxMemLock helper qemu_migration: Use qemuDomainSetMaxMemLock qemu_migration: Restore original memory locking limit qemu_migration: Don't set unlimited memlock limit for RDMA Add VIR_MIGRATE_ZEROCOPY flag virsh: Add support for VIR_MIGRATE_ZEROCOPY flag qemu_migration: Implement VIR_MIGRATE_ZEROCOPY flag docs/manpages/virsh.rst | 7 +- include/libvirt/libvirt-domain.h | 9 +++ src/qemu/qemu_domain.c | 107 ++++++++++++++++++++----------- src/qemu/qemu_domain.h | 6 ++ src/qemu/qemu_migration.c | 34 ++++++++-- src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 6 ++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 7 ++ 9 files changed, 136 insertions(+), 42 deletions(-) -- 2.35.1

3 13

[libvirt PATCH] conf: virDomainDefParseMemory: remove pointless assignment
by Ján Tomko 22 Jun '22

22 Jun '22

Evaluate the XPath as a boolean, instead of trying to get a node out of it. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9fe930a5d8..709ca53790 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19184,7 +19184,7 @@ virDomainDefParseMemory(virDomainDef *def, } } - if ((node = virXPathNode("./memoryBacking/nosharepages", ctxt))) + if (virXPathBoolean("boolean(./memoryBacking/nosharepages)", ctxt)) def->mem.nosharepages = true; if (virXPathBoolean("boolean(./memoryBacking/locked)", ctxt)) -- 2.34.1

2 1

[libvirt PATCH] docs: update links to listman
by Ján Tomko 22 Jun '22

22 Jun '22

The mailman for mailing lists hosted by Red Hat seems to have moved to listman.redhat.com. While the old links still seem to work, point our docs to the new location to avoid the redirect. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- docs/bindings.rst | 2 +- docs/contact.rst | 12 ++++++------ docs/submitting-patches.rst | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/bindings.rst b/docs/bindings.rst index 81a4a67067..522d443d50 100644 --- a/docs/bindings.rst +++ b/docs/bindings.rst @@ -57,6 +57,6 @@ For information on using libvirt on **Windows** `please see the Windows support page <windows.html>`__. Support, requests or help for libvirt bindings are welcome on the -`mailing list <https://www.redhat.com/mailman/listinfo/libvir-list/>`__, +`mailing list <https://listman.redhat.com/mailman/listinfo/libvir-list/>`__, as usual try to provide enough background information and make sure you use recent version, see the `help page <bugs.html>`__. diff --git a/docs/contact.rst b/docs/contact.rst index f8f7e806b3..f20801e895 100644 --- a/docs/contact.rst +++ b/docs/contact.rst @@ -21,9 +21,9 @@ There are three mailing-lists: **libvir-list(a)redhat.com** (for development) Archives - https://www.redhat.com/archives/libvir-list + https://listman.redhat.com/archives/libvir-list List info - https://www.redhat.com/mailman/listinfo/libvir-list + https://listman.redhat.com/mailman/listinfo/libvir-list This is a high volume mailing list. It is a place for discussions about the **development** of libvirt. @@ -37,9 +37,9 @@ There are three mailing-lists: **libvirt-users(a)redhat.com** (for users) Archives - https://www.redhat.com/archives/libvirt-users + https://listman.redhat.com/archives/libvirt-users List info - https://www.redhat.com/mailman/listinfo/libvirt-users + https://listman.redhat.com/mailman/listinfo/libvirt-users This is a moderate volume mailing list. It is a place for discussions involving libvirt **users**. @@ -53,9 +53,9 @@ There are three mailing-lists: **libvirt-announce(a)redhat.com** (for release notices) Archives - https://www.redhat.com/archives/libvirt-announce + https://listman.redhat.com/archives/libvirt-announce List info - https://www.redhat.com/mailman/listinfo/libvirt-announce + https://listman.redhat.com/mailman/listinfo/libvirt-announce This is a low volume mailing list, with restricted posting, for announcements of new libvirt releases. diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst index 7cb5c2e172..7bc22323ee 100644 --- a/docs/submitting-patches.rst +++ b/docs/submitting-patches.rst @@ -68,7 +68,7 @@ particularly bad at this. If everything went well, your patch should show up on the `libvir-list -archives <https://www.redhat.com/archives/libvir-list/>`__ in a +archives <https://listman.redhat.com/archives/libvir-list/>`__ in a matter of minutes; if you still can't find it on there after an hour or so, you should double-check your setup. **Note that, if you are not already a subscriber, your very first post to the -- 2.34.1

2 1

[libvirt PATCHv2] storagefile: set size field of ploop to 8
by Ján Tomko 22 Jun '22

22 Jun '22

For all file formats, the length of the size field is assumed and hardcoded to be 8 bytes. Fix the length for the ploop format - since we specify the offset, we read 8 bytes of the length, not 0. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/storage_file/storage_file_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage_file/storage_file_probe.c b/src/storage_file/storage_file_probe.c index 54e095ffd3..9465af5d96 100644 --- a/src/storage_file/storage_file_probe.c +++ b/src/storage_file/storage_file_probe.c @@ -296,7 +296,7 @@ static struct FileTypeInfo const fileTypeInfo[] = { [VIR_STORAGE_FILE_VHD] = { 0, NULL, LV_LITTLE_ENDIAN, -1, 0, {0}, 0, 0, 0, NULL, NULL, NULL, NULL }, [VIR_STORAGE_FILE_PLOOP] = { 0, "WithouFreSpacExt", LV_LITTLE_ENDIAN, - -2, 0, {0}, PLOOP_IMAGE_SIZE_OFFSET, 0, + -2, 0, {0}, PLOOP_IMAGE_SIZE_OFFSET, 8, PLOOP_SIZE_MULTIPLIER, NULL, NULL, NULL, NULL }, /* All formats with a backing store probe below here */ -- 2.34.1

2 1

[PATCH] Add support for network backed NVRAM
by Rohit Kumar 22 Jun '22

22 Jun '22

Signed-off-by: Rohit Kumar <rohit.kumar3(a)nutanix.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9a8624a97e..9766dbe1df 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,11 @@ v8.5.0 (unreleased) * **New features** + * qemu: Introduce support for network backed NVRAM + + Users can now use remote store NVRAM image by specifying attribute + `type='network'` with `<nvram>` element. + * qemu: Add support for post-copy migration recovery A new ``VIR_MIGRATE_POSTCOPY_RESUME`` flag (``virsh migrate --postcopy-resume``) -- 2.25.1

3 3

[libvirt PATCH 0/6] Use virURIFree less (glib chronicles)
by Ján Tomko 22 Jun '22

22 Jun '22

Ján Tomko (6): Use g_auto for virURI almost everywhere tests: remove pointless label in testURIParse vz: refactor testURIParse vmx: use g_autofree in virVMXParseSerial qemu: remove cleanup label from qemuMigrationSrcGraphicsRelocate libxl: remove cleanup label from libxlDomainMigrationSrcPerform src/esx/esx_driver.c | 3 +-- src/libxl/libxl_migration.c | 17 ++++++----------- src/qemu/qemu_migration.c | 30 ++++++++++++------------------ src/vmx/vmx.c | 13 ++++--------- src/vz/vz_driver.c | 3 +-- src/vz/vz_sdk.c | 31 +++++++++++-------------------- tests/viruritest.c | 14 +++++--------- 7 files changed, 40 insertions(+), 71 deletions(-) -- 2.34.1

2 8

[PATCH] libxl: Fix domain startup failure error reporting
by Cole Robinson 21 Jun '22

21 Jun '22

When domain startup fails, domain cleanup calls libxlNetworkUnwindDevices, which calls virGetConnectNetwork, which is a top level API entry point, which resets the initial saved error, leading to clients seeing: error: An error occurred, but the cause is unknown This preserves the error from before virGetConnectNetwork is called. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/libxl/libxl_domain.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 17b347de4e..bda110e9e6 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -830,12 +830,17 @@ libxlNetworkUnwindDevices(virDomainDef *def) /* cleanup actual device */ virDomainNetRemoveHostdev(def, net); if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) { - g_autoptr(virConnect) conn = virGetConnectNetwork(); + g_autoptr(virConnect) conn = NULL; + virErrorPtr save_err; + + virErrorPreserveLast(&save_err); + conn = virGetConnectNetwork(); if (conn) virDomainNetReleaseActualDevice(conn, def, net); else VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); + virErrorRestore(&save_err); } } } -- 2.36.1

2 2

[PATCH 0/4] qemu: Fix tpm-tis for armv7l and riscv
by Cole Robinson 21 Jun '22

21 Jun '22

This fixes tpm-tis usage for armv7l and riscv arches, and then switches qemu tpm validation to use domcaps as the source of truth Cole Robinson (4): qemu: validate: Drop tpm-tis arch validation qemu: command: Use correct tpm device for all non-x86 tests: mock swtpm initialization for all qemu tests qemu: validate: use domcaps for tpm validation src/qemu/qemu_command.c | 2 +- src/qemu/qemu_validate.c | 77 +++++++++------------------------------- tests/domaincapstest.c | 7 ---- tests/testutilsqemu.c | 8 +++++ 4 files changed, 26 insertions(+), 68 deletions(-) -- 2.36.1

2 8

[libvirt PATCH 0/2] tools: add integrated support for XPath in virsh
by Daniel P. Berrangé 17 Jun '22

17 Jun '22

See commit 2 for the example usage Daniel P. Berrangé (2): tools: add helper method for printing an XML document tools: add '--xpath EXPRESSION --wrap' args to all dumpxml commands docs/manpages/virsh.rst | 138 ++++++++++++++++++++++++++++++++++----- tools/virsh-backup.c | 17 ++++- tools/virsh-checkpoint.c | 17 ++++- tools/virsh-domain.c | 55 +++++++++++++--- tools/virsh-interface.c | 22 +++++-- tools/virsh-network.c | 47 +++++++++---- tools/virsh-nodedev.c | 17 ++++- tools/virsh-nwfilter.c | 51 ++++++++++----- tools/virsh-pool.c | 27 +++++--- tools/virsh-secret.c | 18 ++++- tools/virsh-snapshot.c | 17 ++++- tools/virsh-util.c | 59 +++++++++++++++++ tools/virsh-util.h | 7 ++ tools/virsh-volume.c | 28 +++++--- 14 files changed, 436 insertions(+), 84 deletions(-) -- 2.36.1

2 5

[PATCH] po/LINGUAS: Fix sorting
by Peter Krempa 17 Jun '22

17 Jun '22

Fixes breakage of 'sc_linguas_sorting'. Fixes: c886a40cfcbceb2efa57930b64f758d3e263d759 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed as a build fix. Whether that syntax check is a sensible use of CPU cycles is for another discussion. po/LINGUAS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/LINGUAS b/po/LINGUAS index 33418f7705..490a76b5d4 100644 --- a/po/LINGUAS +++ b/po/LINGUAS @@ -17,6 +17,7 @@ hu id it ja +ka kn ko mk @@ -42,4 +43,3 @@ uk vi zh_CN zh_TW -ka -- 2.36.1

3 3