- Devel - libvirt List Archives

[PATCH] po/LINGUAS: Fix sorting
by Peter Krempa 17 Jun '22

17 Jun '22

Fixes breakage of 'sc_linguas_sorting'. Fixes: c886a40cfcbceb2efa57930b64f758d3e263d759 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed as a build fix. Whether that syntax check is a sensible use of CPU cycles is for another discussion. po/LINGUAS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/LINGUAS b/po/LINGUAS index 33418f7705..490a76b5d4 100644 --- a/po/LINGUAS +++ b/po/LINGUAS @@ -17,6 +17,7 @@ hu id it ja +ka kn ko mk @@ -42,4 +43,3 @@ uk vi zh_CN zh_TW -ka -- 2.36.1

3 3

Some questions regarding firmware handling in the qemu driver
by Jim Fehlig 16 Jun '22

16 Jun '22

Hi All, I received a bug report (private, sorry) about inability to "deploy uefi virtual machine with secureboot enabled on aarch64 kvm host". Indeed the qemu driver has some checks that would prohibit using secure boot with aarch64 virt machines, e.g. https://gitlab.com/libvirt/libvirt/-/blob/master/src/qemu/qemu_validate.c#L… However it appears qemu does not restrict booting a firmware with keys enrolled and secure boot enabled. E.g. qemu-system-aarch64 -m 4096 -cpu host -accel kvm -smp 4 -M virt -drive if=pflash,format=raw,readonly=on,file=/usr/share/qemu/aavmf-aarch64-opensuse-code.bin -drive if=pflash,format=raw,file=/vm_images/jim/images/test/test-vars-store.bin ... seems to work fine and within the guest I see db keys loaded by kernel [ 4.782777] integrity: Loading X.509 certificate: UEFI:db [ 4.789494] integrity: Loaded X.509 cert 'Build time autogenerated kernel key: 44e3470bd0c5eb190e3292dfc42db061521184ee' [ 4.789548] integrity: Loading X.509 certificate: UEFI:db [ 4.789701] integrity: Loaded X.509 cert 'openSUSE Secure Boot Signkey: 0332fa9cbf0d88bf21924b0de82a09a54d5defc8' [ 4.789710] integrity: Loading X.509 certificate: UEFI:db [ 4.789841] integrity: Loaded X.509 cert 'SUSE Linux Enterprise Secure Boot Signkey: 3fb077b6cebc6ff2522e1c148c57c777c788e3e7' Can we consider easing the secure boot restrictions in qemuValidateDomainDefBoot? Experimenting with the behavior on x86 raised other questions: libvirt requires the firmware to support SMM to enable secure boot. But is SMM a strict requirement for secure boot? IIUC, lack of SMM makes the securely booted stack less secure since it is easier to tamper with it, but it does not prevent securely booting the components. When selecting firmwares manually and marking the loader secure, VM creation fails unless SMM is explicitly set in <features>. E.g. the following will fail with "unsupported configuration: Secure boot requires SMM feature enabled" <os> <type arch="x86_64" machine="q35">hvm</type> <loader readonly="yes" secure="yes" type="pflash">/usr/share/qemu/ovmf-x86_64-smm-code.bin</loader> <nvram template="/usr/share/qemu/ovmf-x86_64-smm-vars.bin"/> <boot dev="hd"/> </os> even though the descriptor file for /usr/share/qemu/ovmf-x86_64-smm-code.bin advertises secure-boot and requires-smm. Is this just a case of trying to mix old style explicit firmware selection vs firmware auto-select? I.e., if selecting the firmware explicitly, the onus is on the user to also specify any related and required config? Regards, Jim

5 12

[PATCH] storage: zfs: split pool and volume names properly
by Fabian Lesniak 16 Jun '22

16 Jun '22

Before, the volume name was determined as the last token after any / character. This does not work with zvols below the top level of the pool: /dev/zvols/pool/images/vm1 is truncated to /dev/zvols/pool/vm1. This patch removes the pool name only, so when using the pool "pool", the volume path "images/vm1" is used. --- src/storage/storage_backend_zfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index 2a5d74357d..397ea7f386 100644 --- a/src/storage/storage_backend_zfs.c +++ b/src/storage/storage_backend_zfs.c @@ -104,7 +104,7 @@ virStorageBackendZFSParseVol(virStoragePoolObj *pool, virStorageVolDef *volume = NULL; virStoragePoolDef *def = virStoragePoolObjGetDef(pool); g_auto(GStrv) tokens = NULL; - char *tmp; + char *pool_name = def->source.name; if (!(tokens = g_strsplit(volume_string, "\t", 0))) return -1; @@ -113,8 +113,9 @@ virStorageBackendZFSParseVol(virStoragePoolObj *pool, goto cleanup; vol_name = tokens[0]; - if ((tmp = strrchr(vol_name, '/'))) - vol_name = tmp + 1; + if (strlen(vol_name) > strlen(pool_name) && + STRPREFIX(vol_name, pool_name)) + vol_name += strlen(pool_name) + 1; if (vol == NULL) volume = virStorageVolDefFindByName(pool, vol_name); -- 2.36.1

2 1

[PATCH] qemu: Fix alignment in qemuFirmwareMappingFlashFormat()
by Andrea Bolognani 16 Jun '22

16 Jun '22

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. src/qemu/qemu_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 1dd5c09636..c8f462bfcf 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -751,7 +751,7 @@ qemuFirmwareMappingFlashFormat(virJSONValue *mapping, return -1; if (virJSONValueObjectAppend(mapping, - "nvram-template", + "nvram-template", &nvram_template) < 0) return -1; } -- 2.35.3

1 0

[PATCH 0/6] Improve setting of logging with 'virt-admin' when daemon uses auto-shutdown
by Peter Krempa 16 Jun '22

16 Jun '22

Allow setting of the timeout so that users can bypass it when they are setting runtime-logging. Update the docs to mention the caveat and suggest the bypass. Peter Krempa (6): virnetdaemon: Extract autoShutdownTimer operations from virNetDaemonRun virNetDaemonAutoShutdown: Allow live update of shutdown timeout scripts: apibuild: Improve error when API is missing from symbol file admin: Introduce virAdmConnectSetDaemonTimeout virt-admin: Introduce 'daemon-timeout' kbase: debuglogs: Add a note about auto-shutdown of daemons docs/kbase/debuglogs.rst | 20 +++++ docs/manpages/virt-admin.rst | 12 +++ include/libvirt/libvirt-admin.h | 4 + scripts/apibuild.py | 2 + src/admin/admin_protocol.x | 12 ++- src/admin/admin_server_dispatch.c | 12 +++ src/admin/libvirt-admin.c | 34 ++++++++ src/admin/libvirt_admin_public.syms | 5 ++ src/admin_protocol-structs | 5 ++ src/locking/lock_daemon.c | 5 +- src/logging/log_daemon.c | 5 +- src/remote/remote_daemon.c | 4 +- src/rpc/virnetdaemon.c | 127 ++++++++++++++++++---------- src/rpc/virnetdaemon.h | 4 +- tools/virt-admin.c | 45 ++++++++++ 15 files changed, 240 insertions(+), 56 deletions(-) -- 2.36.1

2 8

Plans for the next release
by Jiri Denemark 16 Jun '22

16 Jun '22

We are getting close to the next release of libvirt. To aim for the release on Jul 01 I suggest entering the freeze on Monday Jun 27 and tagging RC2 on Wednesday Jun 29. I hope this works for everyone. Jirka

1 0

[PATCH] virMacAddrParse: Fix wrong termination character
by Eustance Wu 16 Jun '22

16 Jun '22

>From ef22e53c9360ddb4bdff61a12013a2812fb7346a Mon Sep 17 00:00:00 2001 From: longtao <longtao.wu(a)zstack.io> Date: Thu, 16 Jun 2022 14:08:14 +0800 Subject: [PATCH] virMacAddrParse: Fix wrong termination character The judgment of the termination character should be the '\0' character, not a space. Using spaces to judge, content can be injected into mac. such as: "70:af:e7:1f:3f:89\32injected". Before this patch, the terminating character was a space ('\32'),not '\0'. So I can set the DHCP host mac like this "<host mac='c0:3b:04:21:15:35 injected' name='name129' ip='192.168.100.129'/>". When running the network, no error is reported. But, when using this mac to create a virtual machine, Will get "virNetSocketReadWire:1805 : End of file while reading data: Input/output error" in the libvirtd log. --- src/util/virmacaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virmacaddr.c b/src/util/virmacaddr.c index 6b22384cee..ba7c7e7076 100644 --- a/src/util/virmacaddr.c +++ b/src/util/virmacaddr.c @@ -163,7 +163,7 @@ virMacAddrParse(const char* str, virMacAddr *addr) addr->addr[i] = (unsigned char) result; - if ((i == 5) && (*end_ptr <= ' ')) + if ((i == 5) && (*end_ptr == 0)) return 0; if (*end_ptr != ':') break; -- 2.32.0

2 2

[PATCH] [Doc] Update 2 items in the formatdomain.rst
by Yalan Zhang 16 Jun '22

16 Jun '22

Update the default "driver" value for hostdev interface since the default is not "KVM" anymore(refer to "Host device asssignment" part and by test results). And update the mac address in one xml example. Signed-off-by: Yalan Zhang <yalzhang(a)redhat.com> --- docs/formatdomain.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index b6a3495093..19c4aa5e2e 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -4917,9 +4917,9 @@ To use VFIO device assignment rather than traditional/legacy KVM device assignment (VFIO is a new method of device assignment that is compatible with UEFI Secure Boot), a type='hostdev' interface can have an optional ``driver`` sub-element with a ``name`` attribute set to "vfio". To use legacy KVM device -assignment you can set ``name`` to "kvm" (or simply omit the ``<driver>`` -element, since "kvm" is currently the default). :since:`Since 1.0.5 (QEMU and -KVM only, requires kernel 3.6 or newer)` +assignment you can set ``name`` to "kvm" (the default is "vfio" on systems +where the VFIO driver is available, and "kvm" on older systems. :since:`Since +1.1.3` (prior to that the default was always "kvm"). Note that this "intelligent passthrough" of network devices is very similar to the functionality of a standard <hostdev> device, the difference being that this @@ -5018,7 +5018,7 @@ directly reference an SRIOV VF device: <source> <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> </source> - <mac address='00:11:22:33:44:55:66'/> + <mac address='00:11:22:33:44:55'/> <teaming type='transient' persistent='ua-backup0'/> </interface> ... -- 2.32.0

2 1

[PATCH v3 00/26] Remove some unused includes
by Peng Liang 16 Jun '22

16 Jun '22

2 27

[PATCH] virMacAddrParse: Fix wrong termination character
by Eustance Wu 16 Jun '22

16 Jun '22

>From 7df034e93d392c734ac5c4f4148a3d05f9edce29 Mon Sep 17 00:00:00 2001 From: WuLongTao <eustancewu(a)gmail.com> Date: Thu, 16 Jun 2022 10:43:29 +0800 Subject: [PATCH] virMacAddrParse: Fix wrong termination character The judgment of the termination character should be the null character, not a space. Using spaces to judge, content can be injected into mac. such as: "70:af:e7:1f:3f:89\001 injected". This will result in an error: "virNetSocketReadWire:1805 : End of file while reading data: Input/output error" --- src/util/virmacaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virmacaddr.c b/src/util/virmacaddr.c index 6b22384cee..5c4aa07713 100644 --- a/src/util/virmacaddr.c +++ b/src/util/virmacaddr.c @@ -163,7 +163,7 @@ virMacAddrParse(const char* str, virMacAddr *addr) addr->addr[i] = (unsigned char) result; - if ((i == 5) && (*end_ptr <= ' ')) + if ((i == 5) && (*end_ptr <= 0)) return 0; if (*end_ptr != ':') break; -- 2.32.0

2 1