- Devel - libvirt List Archives

[libvirt] Build failed in Jenkins: libvirt-syntax-check #2035
by Jenkins CI 03 Mar '14

03 Mar '14

See <http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/2035/> ------------------------------------------ Started by upstream project "libvirt-build" build number 2286 Building on master in workspace <http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/ws/> [workspace] $ /bin/sh -xe /tmp/hudson2145980330175113322.sh + make syntax-check GEN bracket-spacing-check GFDL_version 0.53 GFDL_version TAB_in_indentation 0.37 TAB_in_indentation Wundef_boolean 0.21 Wundef_boolean avoid_attribute_unused_in_header 0.25 avoid_attribute_unused_in_header avoid_ctype_macros 0.62 avoid_ctype_macros avoid_if_before_free 4.83 avoid_if_before_free avoid_strcase 0.63 avoid_strcase avoid_write 0.31 avoid_write bindtextdomain 0.30 bindtextdomain cast_of_argument_to_free 0.54 cast_of_argument_to_free cast_of_x_alloc_return_value 0.55 cast_of_x_alloc_return_value changelog 0.31 changelog const_long_option 0.58 const_long_option copyright_check 0.81 copyright_check copyright_format 1.60 copyright_format copyright_usage 1.65 copyright_usage correct_id_types 0.67 correct_id_types error_message_period 0.53 error_message_period error_message_warn_fatal 0.52 error_message_warn_fatal flags_debug 1.11 flags_debug flags_usage 1.04 flags_usage forbid_const_pointer_typedef 1.12 forbid_const_pointer_typedef libvirt_unmarked_diagnostics 1.59 libvirt_unmarked_diagnostics m4_quote_check 0.25 m4_quote_check makefile_TAB_only_indentation 0.22 makefile_TAB_only_indentation makefile_at_at_check 0.20 makefile_at_at_check makefile_conditionals 0.21 makefile_conditionals po_check 15.16 po_check preprocessor_indentation cppi: src/nwfilter/nwfilter_dhcpsnoop.c: line 272: not properly indented maint.mk: incorrect preprocessor indentation make: *** [sc_preprocessor_indentation] Error 1 Build step 'Execute shell' marked build as failure

2 2

Re: [libvirt] Compiling libvirt RPC client library for QNX
by Panday Ritesh Sharma (rpanday) 03 Mar '14

03 Mar '14

On 25/02/14 9:18 PM, "Panday Ritesh Sharma (rpanday)" <rpanday(a)cisco.com> wrote: >Hi Roman, >Sorry !!! I did not understand "Once again, please don't top-post on >technical lists." > >I should not include 'libvirt-list(a)redhat.com' in my mail thread ? > >I have already used the option '--without-libvirtd' and hence the result. > >We are using a wrapper of make for compilation for QNX. So I need to know, >when I am compiling this client library on linux with '--without-libvirtd' >option, what all .c files and libraries are being used. Then I will take >those .c files to my build environment and link that to the libraries >needed. I will have to see whether those libraries are present in my QNX >build environment. Please helpŠ > > >Regards >Ritesh Sharma > > >On 25/02/14 8:57 PM, "Eric Blake" <eblake(a)redhat.com> wrote: > >>On 02/25/2014 08:10 AM, Panday Ritesh Sharma (rpanday) wrote: >> >>Once again, please don't top-post on technical lists. >> >>> Hi Eric, >>> I used the option '--without-macvtap' and I was able to compile on my >>> linux box. When I compiled, I see many libraries are getting built. But >>>as >>> I have explained my requirement earlier, I just need a RPC client >>>library, >>> essentially the option '--with-remote'. >> >>To build just the client library, use ./configure --without-libvirtd. >> >>> >>> If I check .c files I see only './src/libvirt.c' and './tools/virsh.c' >>>are >>> the two files where '# ifdef WITH_REMOTE' is present. >>> >>> Does it mean that as per my requirement I only need to compile these >>>files? >> >>No. You must unpack the ENTIRE tarball, and then use the configure >>options to control which files are built. Some of the logic on what to >>build is in the makefiles, and another consideration is that there are a >>LOT of library files that are used in both libvirt.so (your client >>library) and in libvirtd (the daemon executable that you are not >>building). >> >>> >>> My intent is to have a library with minimal files which suffice to my >>> requirement. Because that way it will be easier for me to compile them >>>on >>> QNX. >> >>Using configure options to compile fewer files is reasonable. Omitting >>files from the tarball is not. >> >>> >>> You have mentioned on another thread that in a weeks time some new >>>version >>> of libvirt will come which we can compile for non-linux machines ? What >>> change is coming in that version ? The latest version of libvirt can >>>not >>> be compiled for QNX ? >> >>The latest version is currently 1.2.1, but 1.2.2-rc0 was just announced >>and 1.2.2 is expected next week if all goes well. If you could test >>1.2.2-rc0 on QNX, we can still fix issues that you turn up before 1.2.2 >>goes stable. >> >> >>-- >>Eric Blake eblake redhat com +1-919-301-3266 >>Libvirt virtualization library http://libvirt.org Adding [libvirt-list] Hi Eric, This time I am writing a the bottom of this thread, is this correct ? Write way of mailing ? Could you please reply my query ? Regards Ritesh Sharma >> >

3 8

[libvirt] [PATCH 0/3] nwfilter: Fix some issues in DHCP Snooping code
by Stefan Berger 03 Mar '14

03 Mar '14

The following 3 patches fix some issues in the DHCP Snooping code. Stefan Berger (3): nwfilter: Cap the poll timeout in the DHCP Snooping code nwfilter: Display the pcap errror message nwfilter: Increase buffer size for libpcap src/nwfilter/nwfilter_dhcpsnoop.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) -- 1.8.1.4

2 8

[libvirt] [PATCH] dnsmasq: allowing RFC 2782 compliant srv records
by Steven Malin 03 Mar '14

03 Mar '14

Hello, I want to provide a patch which allows RFC 2782 compliant dns srv records in the network configs. If you have questions, please contact me. Kind Regards, Steven Malin --- src/conf/network_conf.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index bac0465..9a4285b 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -961,9 +961,11 @@ virNetworkDNSSrvDefParseXML(const char *networkName, goto error; } - /* Check whether protocol value is the supported one */ + /* Check whether protocol value is supported (also RFC 2782 compliant) */ if (def->protocol && STRNEQ(def->protocol, "tcp") && - (STRNEQ(def->protocol, "udp"))) { + STRNEQ(def->protocol, "udp") && + STRNEQ(def->protocol, "_tcp") && + STRNEQ(def->protocol, "_udp")) { virReportError(VIR_ERR_XML_DETAIL, _("Invalid protocol attribute value '%s' " "in DNS SRV record of network %s"), -- 1.7.1

2 1

[libvirt] [PATCH] qemu: Implement a stub cpuArchDriver.baseline() handler for arm
by Oleg Strikov 03 Mar '14

03 Mar '14

Openstack Nova calls virConnectBaselineCPU() during initialization of the instance to get a full list of CPU features. This patch adds a stub to arm-specific code to handle this request (no actual work is done). Signed-off-by: Oleg Strikov <oleg.strikov(a)canonical.com> --- This is a port of the following aarch64-specific change: http://libvirt.org/git/?p=libvirt.git;a=commit;h=69fba97f631c26a322bf9f2949… Only function names were changed. --- src/cpu/cpu_arm.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index 5baff42..ec80b35 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -86,6 +86,29 @@ ArmGuestData(virCPUDefPtr host ATTRIBUTE_UNUSED, return VIR_CPU_COMPARE_IDENTICAL; } +static virCPUDefPtr +ArmBaseline(virCPUDefPtr *cpus, + unsigned int ncpus ATTRIBUTE_UNUSED, + const char **models ATTRIBUTE_UNUSED, + unsigned int nmodels ATTRIBUTE_UNUSED, + unsigned int flags) +{ + virCPUDefPtr cpu = NULL; + + virCheckFlags(VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES, NULL); + + if (VIR_ALLOC(cpu) < 0 || + VIR_STRDUP(cpu->model, cpus[0]->model) < 0) { + virCPUDefFree(cpu); + return NULL; + } + + cpu->type = VIR_CPU_TYPE_GUEST; + cpu->match = VIR_CPU_MATCH_EXACT; + + return cpu; +} + struct cpuArchDriver cpuDriverArm = { .name = "arm", .arch = archs, @@ -96,7 +119,7 @@ struct cpuArchDriver cpuDriverArm = { .free = ArmDataFree, .nodeData = ArmNodeData, .guestData = ArmGuestData, - .baseline = NULL, + .baseline = ArmBaseline, .update = ArmUpdate, .hasFeature = NULL, }; -- 1.7.9.5

2 1

Re: [libvirt] [PATCH 4/4] qemu: add unit tests for the capabilities xml
by Francesco Romani 03 Mar '14

03 Mar '14

----- Original Message ----- > From: "Eric Blake" <eblake(a)redhat.com> > To: "Francesco Romani" <fromani(a)redhat.com>, libvir-list(a)redhat.com > Sent: Friday, February 28, 2014 12:49:25 AM > Subject: Re: [libvirt] [PATCH 4/4] qemu: add unit tests for the capabilities xml > > On 01/17/2014 08:31 AM, Francesco Romani wrote: > > the test is loosely inspired from qemucapabilitiestest > > and qemuxml2xmltest. > > > > Added a new test instead of extending an existing one because > > the feature being tested don't really fits nicely in any > > s/don't/doesn't/ s/fits/fit/ Will fix. > > existing place. > > --- > > .gitignore | 1 + > > tests/Makefile.am | 10 +- > > tests/qemucaps2xmldata/all_1.6.0-1.caps | 142 ++++++++++++++ > > tests/qemucaps2xmldata/all_1.6.0-1.xml | 51 +++++ > > tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps | 141 +++++++++++++ > > tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.xml | 51 +++++ > > tests/qemucaps2xmltest.c | 217 > > +++++++++++++++++++++ > > 7 files changed, 612 insertions(+), 1 deletion(-) > > create mode 100644 tests/qemucaps2xmldata/all_1.6.0-1.caps > > create mode 100644 tests/qemucaps2xmldata/all_1.6.0-1.xml > > create mode 100644 tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps > > create mode 100644 tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.xml > > create mode 100644 tests/qemucaps2xmltest.c > > Fails 'make check' for me: > > $ make -C tests check TESTS=qemucaps2xmltest \ > VERBOSE=yes VIR_TEST_DEBUG=1 > ... > > TEST: qemucaps2xmltest > 1) all_1.6.0-1 ... > Offset 393 > Expect [6</machine> > <machine>none</machine> > <machine canonical='pc-i440fx-1.6'>pc</machine> > <machine>pc-i440fx-1.5</machine> > <machine>pc-i440fx-1.4</machine> > ... > Actual [7</machine> > <machine>none</machine> > <machine canonical='pc-i440fx-1.7'>pc</machine> > <machine>pc-i440fx-1.6</machine> > <machine>pc-i440fx-1.5</machine> > > which means you wrote the test by probing the installed qemu, instead of > our testsuite helper binary, and my installed qemu 1.7 differs from your > setup of 1.6. That has to be fixed before this can be applied. Yes, I have qemu 1.6.1 in my test box, this is probably the reason why I haven't noticed this misbehaviour before. This is a point I wanted to discuss because I'm not sure how to properly achieve this. Please see below for my questions on this topic. > > > +++ b/tests/qemucaps2xmltest.c > > @@ -0,0 +1,217 @@ > > +/* > > > + > > + virQEMUCapsCacheAdd(cache, "kvm", qemuCaps); > > + virQEMUCapsCacheAdd(cache, "qemu", qemuCaps); > > + virQEMUCapsCacheAdd(cache, "qemu-system-x86_64", qemuCaps); > > + virQEMUCapsCacheAdd(cache, "qemu-system-i386", qemuCaps); > > + virQEMUCapsCacheAdd(cache, "/usr/bin/qemu-system-x86_64", qemuCaps); > > + virQEMUCapsCacheAdd(cache, "/usr/bin/qemu-system-i386", qemuCaps); > > Is this where the testsuite ended up probing the installed file system > instead of using only data from the testsuite? Yes, it is. What I want to achieve here is to pre-fill the capabilities cache, by using the function I exported in a previous patch on this series, with the test data. The intent is of course to use only the data from the testsuite and to be independent from the installed QEMU, if any, as you pointed out above. I tried a few different attempts but looks like I'm still missing the point. How can I improve this test to achieve this objective? There is an unit-test I can learn from? Any advice is welcome, I want to fix this. Thanks for the review and best regards, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani

1 0

[libvirt] [PATCH] docs: typo fix
by Roman Bogorodskiy 03 Mar '14

03 Mar '14

* drvuml.html.in: (connected) s/toa PTY/to a PTY/ --- docs/drvuml.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvuml.html.in b/docs/drvuml.html.in index fe7769d..03c04ef 100644 --- a/docs/drvuml.html.in +++ b/docs/drvuml.html.in @@ -65,7 +65,7 @@ uml+ssh://root@example.com/system (remote access, SSH tunnelled) </p> <p> - Once booted the primary console is connected toa PTY, and + Once booted the primary console is connected to a PTY, and thus accessible with "virsh console" or equivalent tools </p> -- 1.8.4.2

2 2

[libvirt] [PATCHv2 0/2] Add virusbtest
by Ján Tomko 03 Mar '14

03 Mar '14

v1: https://www.redhat.com/archives/libvir-list/2014-February/msg01620.html v2: Split the mocked part into a separate file and only build the test on Linux. Remove 'serial' files. Get out of testDeviceFind earlier if failure is expected and use a switch. Switches are nice. Check number of returned devices more often in testUSBList, not just at the end. Ján Tomko (2): Add tests for virUSBDeviceFind functions Add a test for virUSBDeviceList functions .gitignore | 1 + cfg.mk | 3 +- tests/Makefile.am | 22 ++ tests/virusbmock.c | 99 +++++++ tests/virusbtest.c | 292 +++++++++++++++++++++ .../sys_bus_usb/devices/1-1.5.3.1/devnum | 1 + .../sys_bus_usb/devices/1-1.5.3.1/idProduct | 1 + .../sys_bus_usb/devices/1-1.5.3.1/idVendor | 1 + .../sys_bus_usb/devices/1-1.5.3.3/devnum | 1 + .../sys_bus_usb/devices/1-1.5.3.3/idProduct | 1 + .../sys_bus_usb/devices/1-1.5.3.3/idVendor | 1 + .../sys_bus_usb/devices/1-1.5.3/devnum | 1 + .../sys_bus_usb/devices/1-1.5.3/idProduct | 1 + .../sys_bus_usb/devices/1-1.5.3/idVendor | 1 + .../sys_bus_usb/devices/1-1.5.4/devnum | 1 + .../sys_bus_usb/devices/1-1.5.4/idProduct | 1 + .../sys_bus_usb/devices/1-1.5.4/idVendor | 1 + .../sys_bus_usb/devices/1-1.5.5/devnum | 1 + .../sys_bus_usb/devices/1-1.5.5/idProduct | 1 + .../sys_bus_usb/devices/1-1.5.5/idVendor | 1 + .../sys_bus_usb/devices/1-1.5.6/devnum | 1 + .../sys_bus_usb/devices/1-1.5.6/idProduct | 1 + .../sys_bus_usb/devices/1-1.5.6/idVendor | 1 + .../sys_bus_usb/devices/1-1.5/devnum | 1 + .../sys_bus_usb/devices/1-1.5/idProduct | 1 + .../sys_bus_usb/devices/1-1.5/idVendor | 1 + .../sys_bus_usb/devices/1-1.6/devnum | 1 + .../sys_bus_usb/devices/1-1.6/idProduct | 1 + .../sys_bus_usb/devices/1-1.6/idVendor | 1 + .../virusbtestdata/sys_bus_usb/devices/1-1/devnum | 1 + .../sys_bus_usb/devices/1-1/idProduct | 1 + .../sys_bus_usb/devices/1-1/idVendor | 1 + .../sys_bus_usb/devices/2-1.2/devnum | 1 + .../sys_bus_usb/devices/2-1.2/idProduct | 1 + .../sys_bus_usb/devices/2-1.2/idVendor | 1 + .../virusbtestdata/sys_bus_usb/devices/2-1/devnum | 1 + .../sys_bus_usb/devices/2-1/idProduct | 1 + .../sys_bus_usb/devices/2-1/idVendor | 1 + .../virusbtestdata/sys_bus_usb/devices/usb1/devnum | 1 + .../sys_bus_usb/devices/usb1/idProduct | 1 + .../sys_bus_usb/devices/usb1/idVendor | 1 + .../virusbtestdata/sys_bus_usb/devices/usb2/devnum | 1 + .../sys_bus_usb/devices/usb2/idProduct | 1 + .../sys_bus_usb/devices/usb2/idVendor | 1 + .../virusbtestdata/sys_bus_usb/devices/usb3/devnum | 1 + .../sys_bus_usb/devices/usb3/idProduct | 1 + .../sys_bus_usb/devices/usb3/idVendor | 1 + .../virusbtestdata/sys_bus_usb/devices/usb4/devnum | 1 + .../sys_bus_usb/devices/usb4/idProduct | 1 + .../sys_bus_usb/devices/usb4/idVendor | 1 + 50 files changed, 461 insertions(+), 1 deletion(-) create mode 100644 tests/virusbmock.c create mode 100644 tests/virusbtest.c create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3.1/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3.1/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3.1/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3.3/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3.3/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3.3/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.4/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.4/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.4/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.5/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.5/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.5/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.6/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.6/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.6/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.6/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.6/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.6/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/2-1.2/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/2-1.2/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/2-1.2/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/2-1/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/2-1/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/2-1/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb1/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb1/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb1/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb2/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb2/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb2/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb3/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb3/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb3/idVendor create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb4/devnum create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb4/idProduct create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb4/idVendor -- 1.8.3.2

2 4

[libvirt] [PATCH] Fix indentation in virsystemdmock
by Ján Tomko 03 Mar '14

03 Mar '14

--- Pushed as trivial. tests/virsystemdmock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virsystemdmock.c b/tests/virsystemdmock.c index b3b82b4..0295231 100644 --- a/tests/virsystemdmock.c +++ b/tests/virsystemdmock.c @@ -92,7 +92,7 @@ DBusMessage *dbus_connection_send_with_reply_and_block(DBusConnection *connectio "s", &sub); if (!dbus_message_iter_append_basic(&sub, - DBUS_TYPE_STRING, + DBUS_TYPE_STRING, &svc1)) goto error; if (!getenv("FAIL_NO_SERVICE") && -- 1.8.3.2

1 0

[libvirt] [PATCH] Replace space with a tab in the Makefile
by Ján Tomko 03 Mar '14

03 Mar '14

All the other test_programs in the section use tabs and virportallocatortest sticks out with tab width other than 8. --- Pushed as trivial. tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 1b752b2..cd91734 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -143,7 +143,7 @@ test_programs = virshtest sockettest \ virlockspacetest \ virlogtest \ virstringtest \ - virportallocatortest \ + virportallocatortest \ sysinfotest \ virstoragetest \ virnetdevbandwidthtest \ -- 1.8.3.2

1 0