- Devel - libvirt List Archives

[libvirt] [libvirt-perl PATCH] Add virDomainAddIOThread and virDomainDelIOThread support
by John Ferlan 28 Apr '15

28 Apr '15

Add support for the new IOThread APIs Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Changes | 1 + Virt.xs | 20 ++++++++++++++++++++ lib/Sys/Virt/Domain.pm | 12 ++++++++++++ 3 files changed, 33 insertions(+) diff --git a/Changes b/Changes index ead8f8e..58efa37 100644 --- a/Changes +++ b/Changes @@ -6,6 +6,7 @@ Revision history for perl module Sys::Virt event callback & constants. - Add JOB_DOWNTIME_NET constant - Add JOB_TIME_ELAPSED_NET constant + - Add virDomainAddIOThread and virDomainDelIOThread API bindings 1.2.14 2015-04-09 diff --git a/Virt.xs b/Virt.xs index debb8f4..29f20ec 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5100,6 +5100,26 @@ PREINIT: _croak_error(); +void +add_iothread(dom, iothread_id, flags=0) + virDomainPtr dom; + unsigned int iothread_id; + unsigned int flags; + PPCODE: + if (virDomainAddIOThread(dom, iothread_id, flags) < 0) + _croak_error(); + + +void +del_iothread(dom, iothread_id, flags=0) + virDomainPtr dom; + unsigned int iothread_id; + unsigned int flags; + PPCODE: + if (virDomainDelIOThread(dom, iothread_id, flags) < 0) + _croak_error(); + + int num_of_snapshots(dom, flags=0) virDomainPtr dom; diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index f12abd1..2fda74d 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -1237,6 +1237,18 @@ Pin the IOThread given by index C<$iothread> to physical CPUs given by C<$mask>. The C<$mask> is a string representing a bitmask against physical CPUs, 8 cpus per character. +=item $dom->add_iothread($iothread, $flags=0) + +Add a new IOThread by the C<$iothread> value to the guest domain. +The C<$flags> parameter accepts one or more the CONFIG OPTION constants +documented later, and defaults to 0 if omitted. + +=item $dom->del_iothread($iothread, $flags=0) + +Delete an existing IOThread by the C<$iothread> value from the guest domain. +The C<$flags> parameter accepts one or more the CONFIG OPTION constants +documented later, and defaults to 0 if omitted. + =item my @stats = $dom->get_cpu_stats($startCpu, $numCpus, $flags=0) Requests the guests host physical CPU usage statistics, starting -- 2.1.0

2 1

[libvirt] [PATCH] Add missing linker flags for MinGW build
by Pavel Fedin 28 Apr '15

28 Apr '15

This fix should completely close https://bugzilla.redhat.com/show_bug.cgi?id=1214605 Signed-off-by: Pavel Fedin <p.fedin(a)samsung.com> tests/Makefile.am | 40 +++++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 09dc2cb..e69235b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -553,7 +553,8 @@ qemuxml2argvmock_la_SOURCES = \ qemuxml2argvmock.c qemuxml2argvmock_la_CFLAGS = $(AM_CFLAGS) qemuxml2argvmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) qemuxml2xmltest_SOURCES = \ qemuxml2xmltest.c testutilsqemu.c testutilsqemu.h \ @@ -614,7 +615,8 @@ qemucaps2xmlmock_la_SOURCES = \ qemucaps2xmlmock.c qemucaps2xmlmock_la_CFLAGS = $(AM_CFLAGS) qemucaps2xmlmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) qemuagenttest_SOURCES = \ qemuagenttest.c \ @@ -722,7 +724,8 @@ bhyvexml2argvmock_la_SOURCES = \ bhyvexml2argvmock.c bhyvexml2argvmock_la_CFLAGS = $(AM_CFLAGS) bhyvexml2argvmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) bhyve_LDADDS = ../src/libvirt_driver_bhyve_impl.la if WITH_STORAGE @@ -930,7 +933,9 @@ virnetserverclientmock_la_SOURCES = \ virnetserverclientmock.c virnetserverclientmock_la_CFLAGS = $(AM_CFLAGS) virnetserverclientmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(GNULIB_LIBS) \ + $(MINGW_EXTRA_LDFLAGS) if WITH_GNUTLS virnettlscontexttest_SOURCES = \ @@ -1009,7 +1014,8 @@ libvirportallocatormock_la_SOURCES = \ virportallocatortest.c libvirportallocatormock_la_CFLAGS = $(AM_CFLAGS) -DMOCK_HELPER=1 libvirportallocatormock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) vircgrouptest_SOURCES = \ vircgrouptest.c testutils.h testutils.c @@ -1019,7 +1025,8 @@ vircgroupmock_la_SOURCES = \ vircgroupmock.c vircgroupmock_la_CFLAGS = $(AM_CFLAGS) vircgroupmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) vircryptotest_SOURCES = \ vircryptotest.c testutils.h testutils.c @@ -1039,7 +1046,8 @@ virpcimock_la_CFLAGS = $(AM_CFLAGS) virpcimock_la_LIBADD = $(GNULIB_LIBS) \ ../src/libvirt.la virpcimock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) virnetdevtest_SOURCES = \ virnetdevtest.c testutils.h testutils.c @@ -1052,7 +1060,8 @@ virnetdevmock_la_CFLAGS = $(AM_CFLAGS) $(LIBNL_CFLAGS) virnetdevmock_la_LIBADD = $(GNULIB_LIBS) \ ../src/libvirt.la virnetdevmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) if WITH_LINUX virusbtest_SOURCES = \ @@ -1066,13 +1075,15 @@ virnetdevbandwidthtest_LDADD = $(LDADDS) $(LIBXML_LIBS) virusbmock_la_SOURCES = virusbmock.c virusbmock_la_CFLAGS = $(AM_CFLAGS) virusbmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) virnetdevbandwidthmock_la_SOURCES = \ virnetdevbandwidthmock.c virnetdevbandwidthmock_la_CFLAGS = $(AM_CFLAGS) virnetdevbandwidthmock_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) else ! WITH_LINUX EXTRA_DIST += virusbtest.c virusbmock.c \ @@ -1089,7 +1100,8 @@ virmockdbus_la_SOURCES = \ virmockdbus.c virmockdbus_la_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) virmockdbus_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) virpolkittest_SOURCES = \ virpolkittest.c testutils.h testutils.c @@ -1136,7 +1148,8 @@ endif ! WITH_TESTS libsecurityselinuxhelper_la_SOURCES = \ securityselinuxhelper.c libsecurityselinuxhelper_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) securityselinuxtest_SOURCES = \ securityselinuxtest.c testutils.h testutils.c @@ -1209,7 +1222,8 @@ endif WITH_LIBVIRTD libshunload_la_SOURCES = shunloadhelper.c libshunload_la_LIBADD = ../src/libvirt.la libshunload_la_LDFLAGS = -module -avoid-version \ - -rpath /evil/libtool/hack/to/force/shared/lib/creation + -rpath /evil/libtool/hack/to/force/shared/lib/creation \ + $(MINGW_EXTRA_LDFLAGS) shunloadtest_SOURCES = \ shunloadtest.c Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

2 8

[libvirt] FYI: Hacking on Sys::Virt libvirt Perl binding
by Daniel P. Berrange 28 Apr '15

28 Apr '15

Historically I have taken care of everything related to the Sys::Virt Perl binding for libvirt. Recently a couple of adventurous people have started sending patches too. Perl may have a reputation for being scary, but at this point extending the Sys::Virt binding when new APIs or constants are added is actually pretty straightforward. The majority of new libvirt APIs calls look very similar to one or more existing APIs, so you can usually get away with just doing a copy+paste job from some existing Perl API binding. To assist people in understanding how todo this, I've updated the HACKING file with some guidance. I'm including it inline here for reference. I'm not expecting everyone to submit Perl binding code for APIs they add. If people do submit binding code for new APIs though, it will be more than welcome - if not I'll continue to watch for changes and update things myself when required. Hacking on libvirt perl ======================= The libvirt Perl release versions are tied directly to the libvirt C library release versions. ie Sys::Virt 1.2.10 will require libvirt version 1.2.10 or newer in order to build. We do not aim to support conditional compilation against versions of libvirt that are older than the version of Sys::Virt. General changes for new APIs ---------------------------- Additions to the libvirt C API will require changes to a minimum of two parts of the Sys::Virt codebase. - Virt.xs - this provides the C glue code to access the libvirt C library APIs and constants from the Perl interpretor. As a general rule, every new function and header file constant/enum requires an addition to this file. The exceptions are functions that are only provided for the benefit of language bindings and not intended for use by application code. For example the reference counting APIs don't need exposing to Perl applications - lib/ - this directory contains the pure Perl part of the binding. There are separate files for each core libvirt object type - lib/Sys/Virt.pm - mapping for virConnectPtr - lib/Sys/Virt/Domain.pm - mapping for virDomainPtr - lib/Sys/Virt/Error.pm - mapping for virErrorPtr - lib/Sys/Virt/Event.pm - mapping for virEventPtr - lib/Sys/Virt/Interface.pm - mapping for virInterfacePtr - lib/Sys/Virt/Network.pm - mapping for virNetworkPtr - lib/Sys/Virt/NodeDevice.pm - mapping for virNodeDevicePtr - lib/Sys/Virt/NWFilter.pm - mapping for virNWFilterPtr - lib/Sys/Virt/Secret.pm - mapping for virSecretPtr - lib/Sys/Virt/StoragePool.pm - mapping for virStoragePoolPtr - lib/Sys/Virt/StorageVol.pm - mapping for virStorageVolPtr - lib/Sys/Virt/Stream.pm - mapping for virStreamPtr There is rarely a need to write Perl code in the .pm modules, as the mapping in the Virt.xs file is usually sufficient. As such the primary purpose of the .pm modules is to hold the POD inline documentation. Every function and constants is required to have full API documentation provided There are a number of unit tests available in the t/ directory which assist in creation of new APIs. - t/010-pod-coverage.t - ensures that every Perl method and constant has POD documentation present - t/030-api-coverage.t - ensures that every C library method/constant in the libvirt-api.xml file has corresponding code in the Virt.xs. Certain functions can be blacklisted in t/030-api-coverage.t as not needed mapping to Perl. This only runs if TEST_MAINTAINER=1 is set. - t/*.t - the other files mostly do functional testing against the test:///default API - if the new function has support in the test driver, then suitable additions should be made If use of the API is not obvious, it is often worth providing a small example program in the examples/ directory. These examples are also useful when adding APIs to ensure that they are operating correctly, if it wasn't possible to unit test them with test:///default. Every addition / change to the API must be documented in the Changes file. New API addition workflow ------------------------- When the libvirt C library is changed, the following workflow is an effective way to update the Perl binding. - Build the libvirt C library # cd $HOME/src/libvirt # ./autogen.sh --system # make - Configure & build the Sys::Virt module to build against the just built libvirt library # cd $HOME/src/libvirt-perl # ../libvirt/run perl Makefile.PL # ../libvirt/run make - Run the test suite to identify which new functions/constants need handling # ../libvirt/run make test TEST_MAINTAINER=1 - For each missing item reported in the test suite... - Edit Virt.xs to add the C binding - Edit lib/*.pm to add the POD documentation (and occassionally Perl glue code) - Edit Changes to document the addition - Run the test suite (without maintainer mode) to verify POD docs # ../libvirt/run make test - Optionally add to one of the t/*.t test cases - Optionally add demo to examples/ - Commit the changes to GIT Understanding Virt.xs glue layer -------------------------------- The Perl XS glue (Virt.xs) is a pretty bizarre language, that mostly looks like C but is actually run through a Perl specific preprocessor to turn it into real C code. Learning and understanding XS code well is a really difficult task, but fortunately such knowledge is rarely required in order to add new APIs to the Perl Sys::Virt code. When adding constants just look for the REGISTER_CONSTANT() macro at the end of Virt.xs. Make sure that the constant is registered against the correct Sys::Virt::XXXX object namespace - look for the adjacent 'gv_stashpv' calls to see which namespace is currently in effect. When adding methods, you must again make sure they are put in the correct object namespace. For methods, look for the statements that look like: MODULE = Sys::Virt::NWFilter PACKAGE = Sys::Virt::NWFilter these indicate the start of a namespace for the object in question. When implementing the binding for a method, if not already familiar with XS code, the best technique is to just do cut+paste programming. Find an existing libvirt API call that has the same kind of API signature as the new API. Then just copy the XS code for that method and tweak the parameter names as needed. Async event callbacks have a little bit of special handling too. The callbacks are all implemented as static methods at the very top of the Virt.XS file. Look for method names like _domain_event_pmsuspend_callback and just copy the code for an existing callback method that has a similar set of parameters to the new callback. Once the callback is implemented look for the domain_event_register_any() or network_event_register_any() methods and extend the switch() statement so that it maps the event ID constant to your new callback. Making new releases ------------------- The Sys::Virt releases are hosted on the Perl project CPAN infrastructure rather than libvirt.org 1. Build the new release of libvirt as an RPM and install it on the local machine. 2. Set the release date in the Changes file and commit the change 3. Tag the release with a GPG signed tag using vX.Y.Z syntax for the tag name git tag -s -m 'Release 1.2.14' v1.2.14 4. Clone the repository or run 'git clean -x -f -d' to ensure a 100% pristine state 5. Run autobuild.sh to test the full test suite and generate local RPMs. This results in Sys-Virt-1.2.14.tar.gz file being created 6. Take the src.rpm file that was just generated by autobuild.sh and run a scratch build against Fedora rawhide # cd $HOME/src/fedora/perl-Sys-Virt # fedpkg scratch-build --srpm /path/to/src/rpm/file 7. Push the Changes commit and tag to GIT master # git push # git push origin v1.2.14 If there is a failure at any step then this must be corrected as follows a. Delete the signed release tag git tag -d v1.2.14 b. Fix whatever the problem was and update the Changes file if appropriate c. Go to release process step 3 again. Assuming the release has now been made, the Sys-Virt-1.2.14.tar.gz file should be uploaded to CPAN using https://pause.cpan.org form. The upload is currently done by Daniel Berrange (username DANBERR). Now open the tree for the next release version by editing the files lib/Sys/Virt.pm, README, Makefile.PL to update the version number listed. Also edit Changes to add a placeholder entry for the new release number. Run 'make test' to ensure Changes file is syntax valid. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [perl][PATCH 0/4] Fix coverage
by Michal Privoznik 28 Apr '15

28 Apr '15

In order to match the newish things in libvirt. Michal Privoznik (4): domain_event_register_any: Align the code Add support for VIR_DOMAIN_EVENT_ID_DEVICE_ADDED Add JOB_DOWNTIME_NET constant Add JOB_TIME_ELAPSED_NET constant Changes | 5 ++++- Virt.xs | 48 ++++++++++++++++++++++++++++++++++++++++++++++-- lib/Sys/Virt/Domain.pm | 16 ++++++++++++++++ t/030-api-coverage.t | 1 + 4 files changed, 67 insertions(+), 3 deletions(-) -- 2.0.5

2 8

[libvirt] [PATCH 0/2] IOThread algorithm followups
by John Ferlan 28 Apr '15

28 Apr '15

During Peter's review of the recent IOThreads Add/Del series he noted two outstanding issues: 1. The qemuDomainParseIOThreadAlias should be done within the context of the qemuMonitorJSONGetIOThreads and return an iothread_id instead of a name which must be parsed by everyone 2. The order of checks in qemuProcessDetectIOThreadPIDs to compare the returned niothreads against zero, should have been done after the comparison of whether the number returned matches what the domain expects. If the domain had expected some number of iothreads and none were returned, then that needs to be noted. For review details, see: http://www.redhat.com/archives/libvir-list/2015-April/msg01361.html John Ferlan (2): qemu: Remove need for qemuDomainParseIOThreadAlias qemu: qemuProcessDetectIOThreadPIDs invert checks src/qemu/qemu_command.c | 17 ----------------- src/qemu/qemu_command.h | 3 --- src/qemu/qemu_driver.c | 9 ++------- src/qemu/qemu_monitor.c | 1 - src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 7 ++++++- src/qemu/qemu_process.c | 23 ++++++++++------------- tests/qemumonitorjsontest.c | 12 ++++++------ 8 files changed, 25 insertions(+), 49 deletions(-) -- 2.1.0

2 6

[libvirt] [PATCH] conf: explicitly initialize 'cpumask' variable
by Roman Bogorodskiy 28 Apr '15

28 Apr '15

Build with clang fails with: CC conf/libvirt_conf_la-domain_conf.lo conf/domain_conf.c:13377:9: error: variable 'cpumask' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (!(tmp = virXMLPropString(node, "cpuset"))) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ and many other similar errors regarding the 'cpuset' variable. Fix by explicitly initializing it with NULL. --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b18720..957221b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13342,7 +13342,7 @@ virDomainIOThreadPinDefParseXML(xmlNodePtr node, { int ret = -1; virDomainIOThreadIDDefPtr iothrid; - virBitmapPtr cpumask; + virBitmapPtr cpumask = NULL; xmlNodePtr oldnode = ctxt->node; unsigned int iothreadid; char *tmp = NULL; -- 2.3.5

2 2

[libvirt] [PATCH 0/2] skip names of devices already existing on host when auto-assigning bridge name
by Laine Stump 28 Apr '15

28 Apr '15

Shivaprasad Bhat earlier sent patches to fix this problem which added a call to virNetDevExists() in the conf directory: https://www.redhat.com/archives/libvir-list/2015-March/msg00397.html (V1) https://www.redhat.com/archives/libvir-list/2015-March/msg00569.html (V2) https://www.redhat.com/archives/libvir-list/2015-March/msg01174.html (V3) https://www.redhat.com/archives/libvir-list/2015-March/msg01297.html (V4) After discussing it with him a few times (both email and irc), I decided that the only way to really understand the problems he described (related to locking) with my counterproposal (do the checking in the bridge driver itself), was to try fixing it myself. I do now understand the problems he encountered with locking, but also found that the instance of the call to the "Find a bridge name and set it" function that caused the problem was unnecessary (see the commit message of patch 1). The first patch here essentially reimplements current functionality but moving the majority of the code from conf/network_conf.c to network/bridge_driver.c. The 2nd patch adds the all-important virNetDevExists() call to the function that is looking for an unused bridge name. Laine Stump (2): network: move auto-assign of bridge name from XML parser to net driver network: check for bridge name conflict with existing devices src/conf/network_conf.c | 60 --------------------------- src/conf/network_conf.h | 9 +---- src/libvirt_private.syms | 2 +- src/network/bridge_driver.c | 98 ++++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 99 insertions(+), 70 deletions(-) -- 2.1.0

2 9

[libvirt] [PATCH 0/4] enable s390 support for crypto key mgmt operations
by akrowiak＠linux.vnet.ibm.com 27 Apr '15

27 Apr '15

From: Tony Krowiak <akrowiak(a)linux.vnet.ibm.com> The IBM System z Central Processor Assist for Cryptographic Functions (CPACF) hardware provides a set of CPU instructions for use in clear-key encryption, pseudo random number generation, hash functions, and protected-key encryption. The CPACF protected key cryptographic functions operate with a protected key that is encrypted under a unique wrapping key stored in the Hardware System Area (HSA) of the machine and can only be accessed by firmware. The wrapping key cannot be accessed by the operating system or application programs. There are two wrapping keys: One for wrapping AES keys and one for wrapping DEA/TDEA (DES/TDES) keys. This patch set enables the support for encrypting clear keys under the AES or DEA/TDEA wrapping key on a guest VM running on an s390 host that supports key wrapping. Tony Krowiak (4): libvirt: docs: XML to enable/disable protected key mgmt ops libvirt: conf: parse XML for protected key management ops libvirt: qemu: enable/disable protected key management ops libvirt: tests: test protected key mgmt ops support

1 0

[libvirt] [PATCH] test: Fix actual vs. expected in virtTestCompareFiles
by Laine Stump 27 Apr '15

27 Apr '15

Commit ca329299 added a utility function virtTestCompareFiles() to eliminate repetitive code in several test programs. It unfortunately calls virtTestDifference() with the arguments in the wrong order - strcontent is the "actual" output gathered by the test rig, while filecontent is the "expected", and virtTestDifference() wants expected (filecontent) followed by actual (strcontent), but virtTestCompareFiles() does the opposite, which can make the output a bit confusing when there is a failure. --- tests/testutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testutils.c b/tests/testutils.c index acb2ef1..6a8fe6a 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -1,7 +1,7 @@ /* * testutils.c: basic test utils * - * Copyright (C) 2005-2014 Red Hat, Inc. + * Copyright (C) 2005-2015 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -641,7 +641,7 @@ virtTestCompareToFile(const char *strcontent, goto failure; goto out; } - virtTestDifference(stderr, strcontent, filecontent); + virtTestDifference(stderr, filecontent, strcontent); goto failure; } -- 2.1.0

2 1

[libvirt] [PATCH v5 00/10] Implement Add/Del IOThreads
by John Ferlan 27 Apr '15

27 Apr '15

v4 here: http://www.redhat.com/archives/libvir-list/2015-April/msg01008.html I was asked to post a complete series by Peter, so rather than repeat v5 changes described here: http://www.redhat.com/archives/libvir-list/2015-April/msg01192.html John Ferlan (10): conf: Add new domain XML element 'iothreadids' qemu: Use domain iothreadids to IOThread's 'thread_id' conf: Move virDomainPinIsDuplicate and make static Move iothreadspin information into iothreadids conf: Adjust the iothreadsched expectations Implement virDomainAddIOThread and virDomainDelIOThread remote: Add support for AddIOThread and DelIOThread domain: Introduce virDomainIOThreadSchedDelId qemu: Add support to Add/Delete IOThreads virsh: Add iothreadadd and iothreaddel commands docs/formatdomain.html.in | 56 ++- docs/schemas/domaincommon.rng | 12 + include/libvirt/libvirt-domain.h | 6 + src/conf/domain_audit.c | 9 + src/conf/domain_audit.h | 6 + src/conf/domain_conf.c | 359 ++++++++++++--- src/conf/domain_conf.h | 27 +- src/driver-hypervisor.h | 12 + src/libvirt-domain.c | 118 +++++ src/libvirt_private.syms | 7 +- src/libvirt_public.syms | 6 + src/qemu/qemu_cgroup.c | 34 +- src/qemu/qemu_command.c | 38 +- src/qemu/qemu_command.h | 3 + src/qemu/qemu_domain.c | 36 -- src/qemu/qemu_domain.h | 3 - src/qemu/qemu_driver.c | 486 +++++++++++++++++---- src/qemu/qemu_process.c | 43 +- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 30 +- src/remote_protocol-structs | 12 + .../qemuxml2argv-cputune-iothreadsched-toomuch.xml | 3 +- .../qemuxml2argv-iothreads-ids-partial.args | 10 + .../qemuxml2argv-iothreads-ids-partial.xml | 33 ++ .../qemuxml2argv-iothreads-ids.args | 8 + .../qemuxml2argv-iothreads-ids.xml | 33 ++ tests/qemuxml2argvtest.c | 2 + .../qemuxml2xmlout-cputune-iothreads.xml | 2 +- tests/qemuxml2xmltest.c | 2 + tools/virsh-domain.c | 164 +++++++ tools/virsh.pod | 31 ++ 31 files changed, 1333 insertions(+), 260 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids-partial.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-ids.xml -- 2.1.0

2 32