- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] parallels: implement domainDetachDevice and domainDetachDeviceFlags
by Maxim Nestratov 28 Apr '15

28 Apr '15

Maxim Nestratov (2): parallels: add prlsdkDelDisk and prlsdkGetDiskIndex functions parallels: implement domainDetachDevice and domainDetachDeviceFlags

2 4

[libvirt] [PATCH 0/2] tests: fix memleak in qemumonitorjsontest
by Zhang Bo 28 Apr '15

28 Apr '15

the free callback should be qemuMonitorChardevInfoFree rather than just 'free' when virHashCreate'ing the chardevInfo hash. Zhang Bo (2): qemu: make qemuMonitorChardevInfoFree non-static tests: free ChardevInfo correctly in qemumonitorjsontest src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor.h | 1 + tests/qemumonitorjsontest.c | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) -- 1.7.12.4

2 3

[libvirt] [PATCH] Fix building virnetserverclientmock with MinGW
by Martin Kletzander 28 Apr '15

28 Apr '15

Signed-off-by: Pavel Fedin <p.fedin(a)samsung.com> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Notes: This was a part of commit 9dc57ce2, but separable; plus the library should be in LIBADD and not LDFLAGS. Depends on my previous cleanup [2] [1] https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=9dc57ce2 [2] https://www.redhat.com/archives/libvir-list/2015-April/msg01336.html v2: Use LIBADD instead of LDADDS (which doesn't even exist) tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index dc7daaa..8e2dbec 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -931,6 +931,7 @@ virnetserverclientmock_la_SOURCES = \ virnetserverclientmock.c virnetserverclientmock_la_CFLAGS = $(AM_CFLAGS) virnetserverclientmock_la_LDFLAGS = $(MOCKLIBS_LDFLAGS) +virnetserverclientmock_la_LIBADD = $(GNULIB_LIBS) if WITH_GNUTLS virnettlscontexttest_SOURCES = \ -- 2.3.6

2 1

[libvirt] [libvirt-cim][PATCH] list_util.h: Drop inline modifiers
by Michal Privoznik 28 Apr '15

28 Apr '15

There's no need to mark a function as inline in the function declaration. In fact, it causes a compilation error: CC xmlgen.lo In file included from acl_parsing.h:29:0, from xmlgen.h:26, from capability_parsing.c:37: list_util.h:67:21: error: inline function ‘list_node_prev_node’ declared but never defined [-Werror] inline list_node_t *list_node_prev_node(list_node_t *node); ^ list_util.h:66:14: error: inline function ‘list_node_prev’ declared but never defined [-Werror] inline void *list_node_prev(list_node_t *node); ^ list_util.h:64:21: error: inline function ‘list_node_next_node’ declared but never defined [-Werror] inline list_node_t *list_node_next_node(list_node_t *node); ^ list_util.h:63:14: error: inline function ‘list_node_next’ declared but never defined [-Werror] inline void *list_node_next(list_node_t *node); ^ list_util.h:61:21: error: inline function ‘list_last_node’ declared but never defined [-Werror] inline list_node_t *list_last_node(list_t *list); ^ list_util.h:60:14: error: inline function ‘list_last’ declared but never defined [-Werror] inline void *list_last(list_t *list); ^ list_util.h:58:21: error: inline function ‘list_first_node’ declared but never defined [-Werror] inline list_node_t *list_first_node(list_t *list); ^ list_util.h:57:14: error: inline function ‘list_first’ declared but never defined [-Werror] inline void *list_first(list_t *list); ^ list_util.h:55:13: error: inline function ‘list_node_data_set’ declared but never defined [-Werror] inline void list_node_data_set(list_node_t *node, void *data); ^ list_util.h:54:14: error: inline function ‘list_node_data_get’ declared but never defined [-Werror] inline void *list_node_data_get(list_node_t *node); ^ list_util.h:52:21: error: inline function ‘list_count’ declared but never defined [-Werror] inline unsigned int list_count(list_t *list); ^ cc1: all warnings being treated as errors Makefile:499: recipe for target 'capability_parsing.lo' failed make[2]: *** [capability_parsing.lo] Error 1 make[2]: *** Waiting for unfinished jobs.... Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- libxkutil/list_util.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libxkutil/list_util.h b/libxkutil/list_util.h index 6510272..6582dfe 100644 --- a/libxkutil/list_util.h +++ b/libxkutil/list_util.h @@ -49,22 +49,22 @@ void list_remove_node(list_t *list, list_node_t *node); bool list_foreach(list_t *list, list_foreach_cb cb, void *user_data); -inline unsigned int list_count(list_t *list); +unsigned int list_count(list_t *list); -inline void *list_node_data_get(list_node_t *node); -inline void list_node_data_set(list_node_t *node, void *data); +void *list_node_data_get(list_node_t *node); +void list_node_data_set(list_node_t *node, void *data); -inline void *list_first(list_t *list); -inline list_node_t *list_first_node(list_t *list); +void *list_first(list_t *list); +list_node_t *list_first_node(list_t *list); -inline void *list_last(list_t *list); -inline list_node_t *list_last_node(list_t *list); +void *list_last(list_t *list); +list_node_t *list_last_node(list_t *list); -inline void *list_node_next(list_node_t *node); -inline list_node_t *list_node_next_node(list_node_t *node); +void *list_node_next(list_node_t *node); +list_node_t *list_node_next_node(list_node_t *node); -inline void *list_node_prev(list_node_t *node); -inline list_node_t *list_node_prev_node(list_node_t *node); +void *list_node_prev(list_node_t *node); +list_node_t *list_node_prev_node(list_node_t *node); #ifdef __cplusplus } /* extern "C" */ -- 2.0.5

4 5

[libvirt] virtual smartcard support for GPG backend?
by roky＠openmailbox.org 28 Apr '15

28 Apr '15

Hi. I am trying to get a virtual smartcard attached to a vm but I want it to use GPG instead of NSS. RedHat focuses on NSS becuase of PKCS#11 requirements and FIPS approval, but for most of the community its GPG that matters for smartcards. Is is possible to use GPG on the host instead of NSS with virtual smartcards? Please document how or add support for it. Is using a virtual smartcard make the host less secure from a rogue vm? If there are bugs in GPG/NSS backend on the host can they be abused by untrusted code in the vm?

1 1

[libvirt] [PATCH] storage: fs: Ignore volumes that fail to open with EPERM
by Cole Robinson 28 Apr '15

28 Apr '15

Trying to use qemu:///session to create a storage pool pointing at /tmp will usually fail with something like: $ virsh pool-start tmp error: Failed to start pool tmp error: cannot open volume '/tmp/systemd-private-c38cf0418d7a4734a66a8175996c384f-colord.service-kEyiTA': Permission denied If any volume in an FS pool can't be opened by the daemon, the refresh fails, and the pool can't be used. This causes pain for virt-install/virt-manager though. Imaging a user downloads a disk image to /tmp. virt-manager wants to import /tmp as a storage pool, so we can detect what disk format it is, and set the XML correctly. However this case will likely fail as explained above. Change the logic here to skip volumes that fail to open. This could conceivably cause user complaints along the lines of 'why doesn't libvirt show $ROOT-OWNED-VOLUME-FOO', but figuring that currently the pool won't even startup, I don't think there are any current users that care about that case. https://bugzilla.redhat.com/show_bug.cgi?id=1103308 --- src/storage/storage_backend.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index e0311e1..186013c 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -1445,6 +1445,10 @@ virStorageBackendVolOpen(const char *path, struct stat *sb, VIR_WARN("ignoring missing fifo '%s'", path); return -2; } + if (errno == EACCES && noerror) { + VIR_WARN("ignore permission error for '%s'", path); + return -2; + } virReportSystemError(errno, _("cannot open volume '%s'"), path); return -1; -- 2.3.6

2 2

[libvirt] [PATCH 0/4] storage: Fix a few issues with pool state tracking
by Cole Robinson 28 Apr '15

28 Apr '15

First patch fixes a regression introduced with pool state patches Last 3 patches help fix other issues with the state tracking Cole Robinson (4): storage: Fix autostart dir for qemu:///session storage: Don't leave stale state file if pool startup fails storage: Break out storageDriverLoadPoolState storage: If driver startup state syncing fails, delete statefile src/storage/storage_driver.c | 109 ++++++++++++++++++++++++++----------------- 1 file changed, 67 insertions(+), 42 deletions(-) -- 2.3.6

2 6

[libvirt] Repo link for libvirt-cim throws 404
by Nehal J Wani 28 Apr '15

28 Apr '15

The repository link for libvirt-cim at http://libvirt.org/CIM/downloads.html seems outdated. Shouldn't it be: git clone git://libvirt.org/libvirt-cim instead of hg clone http://libvirt.org/hg/libvirt-cim -- Nehal J Wani

2 1

[libvirt] [PATCH v2 0/3] IOThread algorithm followups
by John Ferlan 28 Apr '15

28 Apr '15

v1 here: http://www.redhat.com/archives/libvir-list/2015-April/msg01382.html v2 changes: Patch 1 - Add a !STRPREFIX(tmp, "iothread") of the returned iothreads to ignore anything that doesn't start with "iothread". Patch 2 - already ACKed, just difficult to extract. Patch 3 - NEW: remove qemuMonitorIOThreadInfoFree as requested from review of patch 1. John Ferlan (3): qemu: Remove need for qemuDomainParseIOThreadAlias qemu: qemuProcessDetectIOThreadPIDs invert checks qemu: Remove need for qemuMonitorIOThreadInfoFree src/qemu/qemu_command.c | 17 ----------------- src/qemu/qemu_command.h | 3 --- src/qemu/qemu_driver.c | 15 +++++---------- src/qemu/qemu_monitor.c | 10 ---------- src/qemu/qemu_monitor.h | 4 +--- src/qemu/qemu_monitor_json.c | 22 +++++++++++++++------- src/qemu/qemu_process.c | 25 +++++++++++-------------- tests/qemumonitorjsontest.c | 14 +++++++------- 8 files changed, 39 insertions(+), 71 deletions(-) -- 2.1.0

2 8

[libvirt] [PATCH v4 0/6] Add vmport feature
by Marc-André Lureau 28 Apr '15

28 Apr '15

Hi, The QEMU machine vmport option allows to set the VMWare IO port emulation. This emulation is useful for absolute pointer input when the guest has vmware input drivers, and is enabled by default for kvm. However it is unnecessary for Spice-enabled VM, since the agent already handles absolute pointer and multi-monitors. Furthermore, it prevents Spice from switching to relative input since the regular ps/2 pointer driver is replaced by the vmware driver. It is thus advised to disable vmport when using a Spice VM. This will permit the Spice client to switch from absolute to relative pointer, as it may be required for certain games or applications. The following patch series allows to configure the vmport feature. v2: - use a feature instead of a domain attribute, suggested by D. Berrange v3: - use qmp query for caps instead of version v4: - use vesion check & qmp, add runtime check for machine kind Marc-André Lureau (6): docs: add domain vmport feature domain/conf: add VIR_DOMAIN_FEATURE_VMPORT qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT qemu: add virQEMUCapsSupportsVmport qemu: add machine vmport argument tests: add machine-vmport-opt qemu test docs/formatdomain.html.in | 6 ++++ docs/schemas/domaincommon.rng | 9 ++++++ src/conf/domain_conf.c | 5 +++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 20 +++++++++++++ src/qemu/qemu_capabilities.h | 4 +++ src/qemu/qemu_command.c | 33 +++++++++------------- src/qemu/qemu_domain.c | 19 +++++++++++++ src/qemu/qemu_domain.h | 3 ++ .../qemuxml2argv-machine-vmport-opt.args | 6 ++++ .../qemuxml2argv-machine-vmport-opt.xml | 28 ++++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 12 files changed, 116 insertions(+), 20 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-vmport-opt.xml -- 2.1.0

2 12