- Devel - libvirt List Archives

[libvirt] [PATCH 0/6] Add virtio-gpu & virgl support
by Marc-André Lureau 24 Nov '15

24 Nov '15

The following series allow using virtio-gpu and virgl if qemu support it. Ths Spice bits are not yet in qemu 2.5, but should make it in 2.6 and I added the RFC patches that are expected to not change much. Marc-André Lureau (6): qemu: add virtio video device qemu: query virtio-gpu for virgl support tests: add qemu 2.5 caps test tests: add a few qemuxml2argv virtio-gpu tests RFC qemu: add spice opengl support RFC tests: add virgl/spice qemuxml2argv test docs/formatdomain.html.in | 11 +- docs/schemas/domaincommon.rng | 6 + src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 + src/qemu/qemu_capabilities.c | 21 + src/qemu/qemu_capabilities.h | 5 + src/qemu/qemu_command.c | 44 +- tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 22 +- tests/qemucapabilitiesdata/caps_1.3.1-1.replies | 22 +- tests/qemucapabilitiesdata/caps_1.4.2-1.replies | 22 +- tests/qemucapabilitiesdata/caps_1.5.3-1.replies | 22 +- tests/qemucapabilitiesdata/caps_1.6.0-1.replies | 22 +- tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 22 +- tests/qemucapabilitiesdata/caps_2.1.1-1.replies | 22 +- tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 3 + tests/qemucapabilitiesdata/caps_2.4.0-1.replies | 95 +- tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 170 + tests/qemucapabilitiesdata/caps_2.5.0-1.replies | 4043 ++++++++++++++++++++ tests/qemucapabilitiestest.c | 1 + .../qemuxml2argv-video-virtio-gpu-device.args | 23 + .../qemuxml2argv-video-virtio-gpu-device.xml | 29 + .../qemuxml2argv-video-virtio-gpu-nodevice.args | 24 + .../qemuxml2argv-video-virtio-gpu-nodevice.xml | 29 + .../qemuxml2argv-video-virtio-gpu-virgl.args | 23 + .../qemuxml2argv-video-virtio-gpu-virgl.xml | 32 + tests/qemuxml2argvtest.c | 11 + 26 files changed, 4676 insertions(+), 64 deletions(-) create mode 100644 tests/qemucapabilitiesdata/caps_2.5.0-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_2.5.0-1.replies create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-device.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-device.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-nodevice.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-nodevice.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-virgl.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-virgl.xml -- 2.5.0

3 11

[libvirt] build issue due to '-Werror=cast-align' on ARM (armhf) [was: Re: [Xen-devel] [libvirt test] 63528: regressions - FAIL]
by Dario Faggioli 24 Nov '15

24 Nov '15

Hello, The Xen Project's automated test suite is failing at running its libvirt tests for a few time, like this: On Wed, 2015-11-04 at 09:04 +0000, osstest service owner wrote: > flight 63528 libvirt real [real] > http://logs.test-lab.xenproject.org/osstest/logs/63528/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-armhf-libvirt 5 libvirt-build fail REGR. vs. 63340 > More specifically (from a more recent run): CC util/libvirt_util_la-virnetdevmacvlan.lo util/virnetdev.c: In function 'virNetDevParseDadStatus': util/virnetdev.c:1319:188: error: cast increases required alignment of target type [-Werror=cast-align] util/virnetdev.c:1332:41: error: cast increases required alignment of target type [-Werror=cast-align] util/virnetdev.c:1334:92: error: cast increases required alignment of target type [-Werror=cast-align] cc1: all warnings being treated as errors make[3]: *** [util/libvirt_util_la-virnetdev.lo] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory `/home/osstest/build.64130.build-armhf-libvirt/libvirt/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/osstest/build.64130.build-armhf-libvirt/libvirt/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/osstest/build.64130.build-armhf-libvirt/libvirt' make: *** [all] Error 2 The changeset being tested last, as of now, and still failing, is: db92aee2b477355759351889e37a365379b43bf6 Full logs available at the following links: http://logs.test-lab.xenproject.org/osstest/logs/64130/build-armhf-libvirt/… http://logs.test-lab.xenproject.org/osstest/logs/64130/build-armhf-libvirt/… Right now, I don't have an ARM cross build environment handy to try to reproduce and attempt a fix, so I figured I at least was reporting it here. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

3 2

[libvirt] [PATCH] vz: implementation of domainCreateXML callback
by Mikhail Feoktistov 24 Nov '15

24 Nov '15

--- src/vz/vz_driver.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 39f58a4..31dfb6a 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -979,6 +979,38 @@ vzDomainUndefine(virDomainPtr domain) return vzDomainUndefineFlags(domain, 0); } +static virDomainPtr +vzDomainCreateXML(virConnectPtr conn, + const char *xml, + unsigned int flags) +{ + virDomainPtr domain; + int ret; + + virCheckFlags(VIR_DOMAIN_START_PAUSED, NULL); + + domain = vzDomainDefineXMLFlags(conn, xml, 0); + if (domain == NULL) + return domain; + + ret = vzDomainCreate(domain); + if (ret != 0) { + vzDomainUndefine(domain); + return NULL; + } + + if (flags & VIR_DOMAIN_START_PAUSED) { + ret = vzDomainSuspend(domain); + if (ret != 0) { + vzDomainDestroy(domain); + vzDomainUndefine(domain); + return NULL; + } + } + + return domain; +} + static int vzDomainHasManagedSaveImage(virDomainPtr domain, unsigned int flags) { @@ -1493,6 +1525,7 @@ static virHypervisorDriver vzDriver = { .domainShutdown = vzDomainShutdown, /* 0.10.0 */ .domainCreate = vzDomainCreate, /* 0.10.0 */ .domainCreateWithFlags = vzDomainCreateWithFlags, /* 1.2.10 */ + .domainCreateXML = vzDomainCreateXML, /* 1.2.22 */ .domainReboot = vzDomainReboot, /* 1.2.22 */ .domainDefineXML = vzDomainDefineXML, /* 0.10.0 */ .domainDefineXMLFlags = vzDomainDefineXMLFlags, /* 1.2.12 */ -- 1.8.3.1

3 2

[libvirt] [PATCH] vz: allow to boot VM from cdrom
by Mikhail Feoktistov 24 Nov '15

24 Nov '15

--- src/vz/vz_sdk.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 750133d..9bdf7aa9a 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2023,8 +2023,9 @@ prlsdkCheckUnsupportedParams(PRL_HANDLE sdkdom, virDomainDefPtr def) } if (!IS_CT(def)) { - if (def->os.nBootDevs != 1 || - def->os.bootDevs[0] != VIR_DOMAIN_BOOT_DISK || + if (def->os.nBootDevs == 0 || + (def->os.bootDevs[0] != VIR_DOMAIN_BOOT_DISK && + def->os.bootDevs[0] != VIR_DOMAIN_BOOT_CDROM) || def->os.init != NULL || def->os.initargv != NULL) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -3179,11 +3180,12 @@ static int prlsdkAddDisk(PRL_HANDLE sdkdom, if (disk->src->type == VIR_STORAGE_TYPE_FILE) { if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK && - virDomainDiskGetFormat(disk) != VIR_STORAGE_FILE_PLOOP) { + (virDomainDiskGetFormat(disk) != VIR_STORAGE_FILE_PLOOP && + virDomainDiskGetFormat(disk) != VIR_STORAGE_FILE_NONE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Invalid format of " - "disk %s, vz driver supports only " - "images in ploop format."), disk->src->path); + "disk %s, it should be either not set or " + "ploop format."), disk->src->path); goto cleanup; } @@ -3205,11 +3207,13 @@ static int prlsdkAddDisk(PRL_HANDLE sdkdom, pret = PrlVmDev_SetEmulatedType(sdkdisk, emutype); prlsdkCheckRetGoto(pret, cleanup); - pret = PrlVmDev_SetSysName(sdkdisk, disk->src->path); - prlsdkCheckRetGoto(pret, cleanup); + if (disk->src->path != NULL) { + pret = PrlVmDev_SetSysName(sdkdisk, disk->src->path); + prlsdkCheckRetGoto(pret, cleanup); - pret = PrlVmDev_SetFriendlyName(sdkdisk, disk->src->path); - prlsdkCheckRetGoto(pret, cleanup); + pret = PrlVmDev_SetFriendlyName(sdkdisk, disk->src->path); + prlsdkCheckRetGoto(pret, cleanup); + } drive = &disk->info.addr.drive; if (drive->controller > 0) { -- 1.8.3.1

2 1

[libvirt] [perl PATCH] Post-release version bump to 1.3.0
by Pavel Hrdina 24 Nov '15

24 Nov '15

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Makefile.PL | 2 +- README | 2 +- lib/Sys/Virt.pm | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 709be83..4ae538f 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -3,7 +3,7 @@ use ExtUtils::MakeMaker; # See lib/ExtUtils/MakeMaker.pm for details of how to influence # the contents of the Makefile that is written. -my $libvirtver = "1.2.21"; +my $libvirtver = "1.3.0"; my $stat = system "pkg-config --atleast-version=$libvirtver libvirt"; die "cannot run pkg-config to check libvirt version" if $stat == -1; die "libvirt >= $libvirtver is required\n" unless $stat == 0; diff --git a/README b/README index 757d652..a942d66 100644 --- a/README +++ b/README @@ -7,6 +7,6 @@ further details on libvirt consult its website http://libvirt.org/ The only pre-requisite for this module is libvirt itself. For installation instructions, consult the INSTALL file. -The current minimum required version of libvirt is 1.2.21 +The current minimum required version of libvirt is 1.3.0 -- End diff --git a/lib/Sys/Virt.pm b/lib/Sys/Virt.pm index 0371d08..9e7c6d9 100644 --- a/lib/Sys/Virt.pm +++ b/lib/Sys/Virt.pm @@ -78,7 +78,7 @@ use Sys::Virt::NWFilter; use Sys::Virt::DomainSnapshot; use Sys::Virt::Stream; -our $VERSION = '1.2.21'; +our $VERSION = '1.3.0'; require XSLoader; XSLoader::load('Sys::Virt', $VERSION); -- 2.6.3

2 2

[libvirt] [PATCH v2] Post-release version bump to 1.3.0
by Pavel Hrdina 24 Nov '15

24 Nov '15

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- configure.ac | 2 +- src/libxl/libxl_driver.c | 4 ++-- src/vz/vz_driver.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index f481c50..4b7c9ed 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [1.2.22], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [1.3.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index d77a0e4..35d7fae 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -5421,8 +5421,8 @@ static virHypervisorDriver libxlHypervisorDriver = { #endif .nodeGetFreeMemory = libxlNodeGetFreeMemory, /* 0.9.0 */ .nodeGetCellsFreeMemory = libxlNodeGetCellsFreeMemory, /* 1.1.1 */ - .domainMemoryStats = libxlDomainMemoryStats, /* 1.2.22 */ - .domainGetCPUStats = libxlDomainGetCPUStats, /* 1.2.22 */ + .domainMemoryStats = libxlDomainMemoryStats, /* 1.3.0 */ + .domainGetCPUStats = libxlDomainGetCPUStats, /* 1.3.0 */ .connectDomainEventRegister = libxlConnectDomainEventRegister, /* 0.9.0 */ .connectDomainEventDeregister = libxlConnectDomainEventDeregister, /* 0.9.0 */ .domainManagedSave = libxlDomainManagedSave, /* 0.9.2 */ diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 39f58a4..ea1090a 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -1493,7 +1493,7 @@ static virHypervisorDriver vzDriver = { .domainShutdown = vzDomainShutdown, /* 0.10.0 */ .domainCreate = vzDomainCreate, /* 0.10.0 */ .domainCreateWithFlags = vzDomainCreateWithFlags, /* 1.2.10 */ - .domainReboot = vzDomainReboot, /* 1.2.22 */ + .domainReboot = vzDomainReboot, /* 1.3.0 */ .domainDefineXML = vzDomainDefineXML, /* 0.10.0 */ .domainDefineXMLFlags = vzDomainDefineXMLFlags, /* 1.2.12 */ .domainUndefine = vzDomainUndefine, /* 1.2.10 */ -- 2.6.3

2 2

[libvirt] [python PATCH] Post-release version bump to 1.3.0
by Pavel Hrdina 24 Nov '15

24 Nov '15

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 61fa369..04e3de4 100755 --- a/setup.py +++ b/setup.py @@ -311,7 +311,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '1.2.21', + version = '1.3.0', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.6.3

1 0

[libvirt] [PATCH] qemu: pass the asyncJob to qemuProcessStartCPUs
by Ján Tomko 24 Nov '15

24 Nov '15

Now that new domains are started inside a QEMU_ASYNC_JOB_START job, we need to pass it down to qemuProcessStartCPUs too. This removes the warning: qemuDomainObjEnterMonitorInternal:1750 : This thread seems to be the async job owner; entering monitor without asking for a nested job is dangerous Introduced by commit 04c721f, before that this code path was only executed with QEMU_ASYNC_JOB_NONE. (This code is not executed on migration, because qemuMigrationPrepareAny sets the VIR_QEMU_PROCESS_START_PAUSED flag.) --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2192ad8..68542e7 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5013,15 +5013,15 @@ int qemuProcessStart(virConnectPtr conn, goto error; if (!(flags & VIR_QEMU_PROCESS_START_PAUSED)) { VIR_DEBUG("Starting domain CPUs"); /* Allow the CPUS to start executing */ if (qemuProcessStartCPUs(driver, vm, conn, VIR_DOMAIN_RUNNING_BOOTED, - QEMU_ASYNC_JOB_NONE) < 0) { + asyncJob) < 0) { if (virGetLastError() == NULL) virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("resume operation failed")); goto error; } } else { virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, -- 2.4.6

2 2

[libvirt] [PATCH 0/2] nodedev: fix virtual_functions element
by Laine Stump 24 Nov '15

24 Nov '15

Moshe Levi pointed out yesterday in an email to libvir-list that there was no way to tell from the node device API that a PCI was capable of having SRIOV virtual functions (VFs) if it was currently setup to not have any: https://www.redhat.com/archives/libvir-list/2015-November/msg00894.html These two patches modify the node device XML in two ways: 1) if the device has a file called sriov_totalvfs, the value contained in that file will be included in the capabilities element as the attribute "maxCount". 2) in this case, even if there are currently no VFs active/visible for the device, the virtual_functions capability will still be reported. Laine Stump (2): conf: support reporting maxCount attribute for virtual_functions cap nodedev: report maxCount for virtual_functions capability docs/formatnode.html.in | 11 ++++++++++- src/conf/node_device_conf.c | 32 +++++++++++++++++++------------ src/conf/node_device_conf.h | 1 + src/network/bridge_driver.c | 5 +++-- src/node_device/node_device_linux_sysfs.c | 7 +++++-- src/util/virnetdev.c | 9 ++++++--- src/util/virnetdev.h | 5 +++-- src/util/virpci.c | 30 +++++++++++++++++++++++++---- src/util/virpci.h | 5 +++-- 9 files changed, 77 insertions(+), 28 deletions(-) -- 2.4.3

2 4

[libvirt] [PATCH] Post-release version bump to 1.3.0
by Pavel Hrdina 24 Nov '15

24 Nov '15

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- We've dropped support for old QEMU and there was a vote to change version to 1.3.0, let's make it official. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f481c50..4b7c9ed 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [1.2.22], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [1.3.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) -- 2.6.3

3 2